[dpdk-dev] [PATCH v2 1/3] eal/x86: run-time dispatch over memcpy

2017-09-19 Thread Li, Xiaoyun
Hi all After further investigating, we have found some benefits with the patchset. So the plan is to add a config parameter CONFIG_RTE_ENABLE_RUNTIME_DISPATCH. By default, the value is "n" and would use current memcpy codes. Only if users config it to "y", it would use the run-time dispatch codes(

Re: [dpdk-dev] [PATCH v5 0/2] add uevent monitor for hot plug

2017-09-19 Thread Guo, Jia
hi,jan On 9/20/2017 2:44 AM, Jan Blunck wrote: On Wed, Sep 20, 2017 at 6:12 AM, Jeff Guo wrote: So far, about hot plug in dpdk, we already have hot plug add/remove api and fail-safe driver to offload the fail-safe work from the app user. But there are still lack of a general event api, since

Re: [dpdk-dev] [PATCH v4 4/5] gso: add GRE GSO support

2017-09-19 Thread Hu, Jiayu
Hi Jianfeng, > -Original Message- > From: Tan, Jianfeng > Sent: Wednesday, September 20, 2017 10:54 AM > To: Hu, Jiayu ; dev@dpdk.org > Cc: Ananyev, Konstantin ; Kavanagh, Mark > B ; Yigit, Ferruh ; > tho...@monjalon.net > Subject: Re: [PATCH v4 4/5] gso: add GRE GSO support > > Hi, > >

[dpdk-dev] [PATCH v5] net/i40e: fix mirror rule reset when port is stopped

2017-09-19 Thread Wei Dai
When an i40e PF port is stopped, all mirror rules should be removed. All rule related software and hardware resources should also be removed. Fixes: a4def5edf0fc ("i40e: enable port mirroring") Cc: sta...@dpdk.org Signed-off-by: Wei Dai Tested-by: Lijuan Tu --- drivers/net/i40e/i40e_ethdev.c |

Re: [dpdk-dev] [PATCH 1/2] net/i40e: queue region set and flush

2017-09-19 Thread Zhao1, Wei
Hi, Ferruh > -Original Message- > From: Yigit, Ferruh > Sent: Friday, September 15, 2017 7:01 PM > To: Zhao1, Wei ; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH 1/2] net/i40e: queue region set and flush > > On 9/6/2017 10:11 AM, Ferruh Yigit wrote: > > On 9/1/2017 3:38 AM, Zhao1, Wei wro

Re: [dpdk-dev] [PATCH v4 3/5] gso: add VxLAN GSO support

2017-09-19 Thread Hu, Jiayu
Hi Jianfeng, > -Original Message- > From: Tan, Jianfeng > Sent: Wednesday, September 20, 2017 11:11 AM > To: Hu, Jiayu ; dev@dpdk.org > Cc: Ananyev, Konstantin ; Kavanagh, Mark > B ; Yigit, Ferruh ; > tho...@monjalon.net > Subject: Re: [PATCH v4 3/5] gso: add VxLAN GSO support > > > On 9

Re: [dpdk-dev] [PATCH v4 3/5] gso: add VxLAN GSO support

2017-09-19 Thread Tan, Jianfeng
On 9/19/2017 3:32 PM, Jiayu Hu wrote: From: Mark Kavanagh This patch adds GSO support for VxLAN-encapsulated packets. Supported VxLAN packets must have an outer IPv4 header (prepended by an optional VLAN tag), and contain an inner TCP/IPv4 packet (with an optional inner VLAN tag). This patch

Re: [dpdk-dev] [PATCH 06/12] eal: add channel for primary/secondary communication

2017-09-19 Thread Jiayu Hu
Hi Jianfeng, Few questions are inline. Thanks, Jiayu On Fri, Aug 25, 2017 at 09:40:46AM +, Jianfeng Tan wrote: > Previouly, there is only one way for primary/secondary to exchange > messages, that is, primary process writes info into some predefind > file, and secondary process reads info ou

Re: [dpdk-dev] [PATCH v2] net/virtio-user: fix not working on 32-bit system

2017-09-19 Thread Jim Murphy
On Tue, Sep 19, 2017 at 7:17 PM, Tan, Jianfeng wrote: > Hi Jim, > > > -Original Message- > > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Jim Murphy > > Sent: Wednesday, September 20, 2017 6:24 AM > > To: dev@dpdk.org > > Subject: [dpdk-dev] [PATCH v2] net/virtio-user: fix not wor

Re: [dpdk-dev] [PATCH v4 4/5] gso: add GRE GSO support

2017-09-19 Thread Tan, Jianfeng
Hi, On 9/19/2017 3:32 PM, Jiayu Hu wrote: From: Mark Kavanagh This patch adds GSO support for GRE-tunneled packets. Supported GRE packets must contain an outer IPv4 header, and inner TCP/IPv4 headers. They may also contain a single VLAN tag. GRE GSO doesn't check if all input packets have cor

[dpdk-dev] [PATCH v4] net/i40e: fix mirror rule reset when port is stopped

2017-09-19 Thread Wei Dai
When an i40e PF port is stopped, all mirror rules should be removed. All rule related software and hardware resources should also be removed. Fixes: a4def5edf0fc ("i40e: enable port mirroring") Cc: sta...@dpdk.org Signed-off-by: Wei Dai Tested-by: Lijuan Tu --- drivers/net/i40e/i40e_ethdev.c |

Re: [dpdk-dev] [PATCH v2] net/virtio-user: fix not working on 32-bit system

2017-09-19 Thread Tan, Jianfeng
Hi Jim, > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Jim Murphy > Sent: Wednesday, September 20, 2017 6:24 AM > To: dev@dpdk.org > Subject: [dpdk-dev] [PATCH v2] net/virtio-user: fix not working on 32-bit > system > > Hi, > > The fix contained in this patch

[dpdk-dev] [PATCH v3] net/i40e: fix mirror rule reset when port is stopped

2017-09-19 Thread Wei Dai
When an i40e PF port is stopped, all mirror rules should be removed. All rule related software and hardware resources should also be removed. Fixes: a4def5edf0fc ("i40e: enable port mirroring") Cc: sta...@dpdk.org Signed-off-by: Wei Dai Tested-by: Lijuan Tu --- drivers/net/i40e/i40e_ethdev.c |

Re: [dpdk-dev] [PATCH v2] net/i40e: fix mirror rule reset when port is stopped

2017-09-19 Thread Dai, Wei
Many thanks to Jingjing and Beilei. Sorry, this patch is a wrong v2 due to a building error. I have submitted another v2 . Anyway, I will submit v3 patch per your feedback. > -Original Message- > From: Wu, Jingjing > Sent: Tuesday, September 19, 2017 10:21 AM > To: Xing, Beilei ; Dai, Wei

Re: [dpdk-dev] [PATCH v2] net/i40e: fix incorrect var assignment

2017-09-19 Thread Xing, Beilei
> -Original Message- > From: Wu, Jingjing > Sent: Tuesday, September 19, 2017 2:53 AM > To: Xing, Beilei > Cc: dev@dpdk.org; Wu, Jingjing ; sta...@dpdk.org > Subject: [PATCH v2] net/i40e: fix incorrect var assignment > > rx/tx_queue_setup functions are shared between PF and VF drivers.

Re: [dpdk-dev] [PATCH] pmd_virtio: Unchecked return value from library

2017-09-19 Thread Tan, Jianfeng
Hi, Thank you for those fixes. > -Original Message- > From: Basierski, SebastianX > Sent: Tuesday, September 19, 2017 7:47 PM > To: skh...@vmware.com > Cc: Basierski, SebastianX; Tan, Jianfeng; dev@dpdk.org > Subject: [PATCH] pmd_virtio: Unchecked return value from library > > Check retu

Re: [dpdk-dev] [PATCH] pmd_virtio: Buffer not null terminated

2017-09-19 Thread Tan, Jianfeng
> -Original Message- > From: Basierski, SebastianX > Sent: Tuesday, September 19, 2017 7:41 PM > To: skh...@vmware.com > Cc: Basierski, SebastianX; Tan, Jianfeng; dev@dpdk.org > Subject: [PATCH] pmd_virtio: Buffer not null terminated > > Fix calling strncpy with the a maximum size equal

[dpdk-dev] Your Bugzilla bug list needs attention.

2017-09-19 Thread bugzilla
[This e-mail has been automatically generated.] You have one or more bugs assigned to you in the Bugzilla bug tracking system (http://dpdk.org/tracker/) that require attention. All of these bugs are in the CONFIRMED state, and have not been touched in 7 days or more. You need to take a look at t

[dpdk-dev] [PATCH v2] net/virtio-user: fix not working on 32-bit system

2017-09-19 Thread Jim Murphy
Hi, The fix contained in this patch breaks under the following scenario: 1. A 64 bit host and virtual machine. Therefore all physical addresses are 64 bits. 2. A 32 bit user mode DPDK process running on a 64 bit virtual machine (64 bit kernel). In this case, the physical address is 64bits but th

[dpdk-dev] [PATCH v2] net/af_packet: make bypass configurable

2017-09-19 Thread Chas Williams
From: "Charles (Chas) Williams" In certain situations, low speed interfaces, it may be desirable to have the flow control provided by the kernel queueing disciplines. Signed-off-by: Chas Williams --- drivers/net/af_packet/rte_eth_af_packet.c | 22 +- 1 file changed, 17 inse

Re: [dpdk-dev] [PATCH v5 2/5] cfgfile: change existing API functions

2017-09-19 Thread Thomas Monjalon
Hi, 19/09/2017 13:07, Kuba Kozak: > @@ -409,7 +407,11 @@ rte_cfgfile_section_num_entries(struct rte_cfgfile *cfg, > { > const struct rte_cfgfile_section *s = _get_section(cfg, sectionname); > if (s == NULL) > +#ifdef RTE_NEXT_ABI > + return -EINVAL; > +#else >

[dpdk-dev] [PATCH] net/af_packet: make bypass configurable

2017-09-19 Thread Chas Williams
From: "Charles (Chas) Williams" In certain situations, low speed interfaces, it may be desirable to have the flow control provided by the kernel queueing disciplines. Signed-off-by: Chas Williams --- drivers/net/af_packet/rte_eth_af_packet.c | 22 +- 1 file changed, 17 inse

[dpdk-dev] [PATCH 3/3] maintainers: add Ferruh for main branch

2017-09-19 Thread Thomas Monjalon
Ferruh will co-maintain the main branch at git://dpdk.org/dpdk. Signed-off-by: Thomas Monjalon --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 7fde8d1c3..8df2a7f2a 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -24,6 +24,7 @@ General Project Adm

[dpdk-dev] [PATCH 2/3] maintainers: add Yuanhan for stable branches

2017-09-19 Thread Thomas Monjalon
Yuanhan was maintaining 16.07, 17.02 and 17.05 branches. He is still doing LTS releases for 16.11. Signed-off-by: Thomas Monjalon --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 20516fe9e..7fde8d1c3 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@

[dpdk-dev] [PATCH 1/3] maintainers: separate main tree and devtools maintenance

2017-09-19 Thread Thomas Monjalon
Being the maintainer of devtools is different of maintaining the main tree. Signed-off-by: Thomas Monjalon --- MAINTAINERS | 27 ++- 1 file changed, 14 insertions(+), 13 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index a0cd75e15..20516fe9e 100644 --- a/MAINTAINE

[dpdk-dev] [PATCH 0/3] update git tree maintainers

2017-09-19 Thread Thomas Monjalon
The file MAINTAINERS must be updated according to the current organization. Ferruh is now working on main tree. Yuanhan work on stable tree since the first stable release. Thanks to Yuanhan and Ferruh for their help on git trees. Note that more maintainers are welcomed to propose themselves for ol

Re: [dpdk-dev] [PATCH v4 04/41] bus/dpaa: add OF parser for device scanning

2017-09-19 Thread Thomas Monjalon
19/09/2017 16:15, Ferruh Yigit: > On 9/19/2017 2:37 PM, Shreyansh Jain wrote: > > On Monday 18 September 2017 08:19 PM, Ferruh Yigit wrote: > >> On 9/9/2017 12:20 PM, Shreyansh Jain wrote: > >>> This layer is used by Bus driver's scan function. Devices are parsed > >>> using OF parser and added to

Re: [dpdk-dev] [PATCH] eal: bus scan and probe never fail

2017-09-19 Thread Jan Blunck
On Mon, Sep 18, 2017 at 1:36 PM, Hemant Agrawal wrote: > Tested-by: Hemant Agrawal > > > On 8/12/2017 3:52 PM, Shreyansh Jain wrote: >> >> Bus scan is responsible for finding devices over *all* buses. >> Some of these buses might not be able to scan but that should >> not prevent other buses to b

Re: [dpdk-dev] [PATCH v5 0/2] add uevent monitor for hot plug

2017-09-19 Thread Jan Blunck
On Wed, Sep 20, 2017 at 6:12 AM, Jeff Guo wrote: > So far, about hot plug in dpdk, we already have hot plug add/remove > api and fail-safe driver to offload the fail-safe work from the app > user. But there are still lack of a general event api, since the interrupt > event, which hot plug related

[dpdk-dev] [PATCH v5 2/2] app/testpmd: get information about protocols defined in ddp profile

2017-09-19 Thread Kirill Rybalchenko
Update 'ddp get info' command to display protocols defined in a profile v5: buff_size parameter in rte_pmd_i40e_get_ddp_info function call always represents buffer size in bytes Signed-off-by: Kirill Rybalchenko --- app/test-pmd/cmdline.c | 110 -

[dpdk-dev] [PATCH v5 0/2] net/i40e: get information about protocols defined in ddp profile

2017-09-19 Thread Kirill Rybalchenko
This patch adds ability to request information about protocols defined in dynamic device personalization profile v2: Some code style warnings were removed v3: info_size parameter always represents size of the info buffer in bytes; fix code style; v4: another code style fixes v5: in testpmd buf

[dpdk-dev] [PATCH v5 1/2] net/i40e: get information about protocols defined in ddp profile

2017-09-19 Thread Kirill Rybalchenko
This patch adds new package info types to get list of protocols, pctypes and ptypes defined in a profile --- v3 info_size parameter always represents size of the info buffer in bytes Signed-off-by: Kirill Rybalchenko --- drivers/net/i40e/rte_pmd_i40e.c | 171

[dpdk-dev] [PATCH v4 2/2] app/testpmd: get information about protocols defined in ddp profile

2017-09-19 Thread Kirill Rybalchenko
Update 'ddp get info' command to display protocols defined in a profile Signed-off-by: Kirill Rybalchenko --- app/test-pmd/cmdline.c | 111 - 1 file changed, 110 insertions(+), 1 deletion(-) diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdl

[dpdk-dev] [PATCH v4 1/2] net/i40e: get information about protocols defined in ddp profile

2017-09-19 Thread Kirill Rybalchenko
This patch adds new package info types to get list of protocols, pctypes and ptypes defined in a profile --- v3 info_size parameter always represents size of the info buffer in bytes Signed-off-by: Kirill Rybalchenko --- drivers/net/i40e/rte_pmd_i40e.c | 171

[dpdk-dev] [PATCH v4 0/2] net/i40e: get information about protocols defined in ddp profile

2017-09-19 Thread Kirill Rybalchenko
This patch adds ability to request information about protocols defined in dynamic device personalization profile v2: Some code style warnings were removed v3: info_size parameter always represents size of the info buffer in bytes; fix code style; v4: anothe code style fixes Kirill Rybalchenko

Re: [dpdk-dev] [PATCH v8 2/9] eal/pci: get iommu class

2017-09-19 Thread santosh
Hi Anatoly, On Tuesday 19 September 2017 10:07 PM, Burakov, Anatoly wrote: > On 18-Sep-17 11:42 AM, Santosh Shukla wrote: >> Introducing rte_pci_get_iommu_class API which helps to get iommu class >> of PCI device on the bus and returns preferred iova mapping mode for >> PCI bus. >> >> Patch also

Re: [dpdk-dev] [PATCH v5] ethdev: add return code to rte_eth_stats_reset()

2017-09-19 Thread Ferruh Yigit
On 9/1/2017 3:26 AM, David Harton wrote: > Some devices do not support reset of eth stats. An application may > need to know not to clear shadow stats if the device cannot. > > rte_eth_stats_reset is updated to provide a return code to share > whether the device supports reset or not. > > Signed

Re: [dpdk-dev] [PATCH v3 3/3] doc: update timer lib docs

2017-09-19 Thread Carrillo, Erik G
Thanks for the review, John. I've submitted the change you suggest in a new patch series. Regards, Gabriel > -Original Message- > From: Mcnamara, John > Sent: Monday, September 18, 2017 11:20 AM > To: Carrillo, Erik G ; rsanf...@akamai.com > Cc: dev@dpdk.org; Ananyev, Konstantin ; > ste

Re: [dpdk-dev] [PATCH 3/3] rte_flow: add new action for traffic metering and policing

2017-09-19 Thread Adrien Mazarguil
Hi Cristian, On Tue, Sep 19, 2017 at 04:36:50PM +, Dumitrescu, Cristian wrote: > > > /** > > > + * RTE_FLOW_ACTION_TYPE_METER > > > + * > > > + * Traffic metering and policing (MTR). > > > + * > > > + * Packets matched by items of this type can be either dropped or passed > > to the > > > +

[dpdk-dev] [PATCH v4 3/3] doc: update timer lib docs

2017-09-19 Thread Erik Gabriel Carrillo
From: Erik Carrillo This change updates the timer library documentation to reflect a change to the organization of the skiplists in the implementation. Signed-off-by: Erik Gabriel Carrillo Acked-by: John McNamara --- v4: * Made changes suggested by John Mcnamara[1]. [1] http://dpdk.org/ml/arc

[dpdk-dev] [PATCH v4 2/3] timer: handle timers installed from non-EAL threads

2017-09-19 Thread Erik Gabriel Carrillo
From: Erik Carrillo This commit adds support for timers being created from non-EAL threads; it maps timers from all such threads to lcore id RTE_MAX_LCORE, and puts them all in a corresponding skiplist. Signed-off-by: Erik Gabriel Carrillo --- v3: * Rebased patch on reworked parent commit v2:

[dpdk-dev] [PATCH v4 1/3] timer: add multiple pending lists option for each lcore

2017-09-19 Thread Erik Gabriel Carrillo
From: Erik Carrillo This commit adds support for enabling multiple pending timer lists in each lcore's priv_timer struct with a new function; a single list is still used by default. In the case that multiple lcores repeatedly install timers on the same target lcore, this option reduces lock conte

[dpdk-dev] [PATCH v4 0/3] timer library enhancement

2017-09-19 Thread Erik Gabriel Carrillo
In the current implementation of the DPDK timer library, timers can be created and set to be handled by a target lcore by adding it to a skiplist that corresponds to that lcore. However, if an application enables multiple lcores, and each of these lcores repeatedly attempts to install timers on th

[dpdk-dev] [PATCH v3 2/2] app/testpmd: get information about protocols defined in ddp profile

2017-09-19 Thread Kirill Rybalchenko
Update 'ddp get info' command to display protocols defined in a profile --- v3 Fix code style Signed-off-by: Kirill Rybalchenko --- app/test-pmd/cmdline.c | 107 - 1 file changed, 106 insertions(+), 1 deletion(-) diff --git a/app/test-pmd/cmdlin

[dpdk-dev] [PATCH v3 1/2] net/i40e: get information about protocols defined in ddp profile

2017-09-19 Thread Kirill Rybalchenko
This patch adds new package info types to get list of protocols, pctypes and ptypes defined in a profile --- v3 info_size parameter always represents size of the info buffer in bytes --- Signed-off-by: Kirill Rybalchenko --- drivers/net/i40e/rte_pmd_i40e.c | 171

[dpdk-dev] [PATCH v3 0/2] net/i40e: get information about protocols defined in ddp profile

2017-09-19 Thread Kirill Rybalchenko
This patch adds ability to request information about protocols defined in dynamic device personalization profile v2: Some code style warnings were removed v3: info_size parameter always represents size of the info buffer in bytes; fix code style; Kirill Rybalchenko (2): net/i40e: get informat

Re: [dpdk-dev] [PATCH v8 2/9] eal/pci: get iommu class

2017-09-19 Thread Burakov, Anatoly
On 18-Sep-17 11:42 AM, Santosh Shukla wrote: Introducing rte_pci_get_iommu_class API which helps to get iommu class of PCI device on the bus and returns preferred iova mapping mode for PCI bus. Patch also add rte_pci_get_iommu_class definition for bsdapp, in bsdapp case - api returns default iov

Re: [dpdk-dev] [PATCH 3/3] rte_flow: add new action for traffic metering and policing

2017-09-19 Thread Dumitrescu, Cristian
Hi Adrien, > -Original Message- > From: Adrien Mazarguil [mailto:adrien.mazarg...@6wind.com] > Sent: Wednesday, September 6, 2017 5:23 PM > To: Dumitrescu, Cristian > Cc: dev@dpdk.org; tho...@monjalon.net; > jerin.ja...@caviumnetworks.com; hemant.agra...@nxp.com > Subject: Re: [PATCH 3/3]

Re: [dpdk-dev] [PATCH v4 5/5] net/mlx5: multi-process document update

2017-09-19 Thread Mcnamara, John
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Xueming Li > Sent: Tuesday, September 19, 2017 3:32 PM > To: Nelio Laranjeiro ; Adrien Mazarguil > > Cc: Xueming Li ; dev@dpdk.org > Subject: [dpdk-dev] [PATCH v4 5/5] net/mlx5: multi-process document update > >

Re: [dpdk-dev] [PATCH 2/3] ethdev: add new rte_mtr API for traffic metering and policing

2017-09-19 Thread Dumitrescu, Cristian
Hi Hemant, ... > >>> +/** > >>> + * Meter profile delete > >>> + * > >>> + * Delete an existing meter profile. This operation fails when there is > >>> + * currently at least one user (i.e. MTR object) of this profile. > >>> + * > >> > >> Do you want to do this checking at library level or at dri

Re: [dpdk-dev] [PATCH 1/3] ethdev: add new eth_dev_ops function for mtr ops get

2017-09-19 Thread Dumitrescu, Cristian
Thanks for your input, Jerin! ... > > It will useful to have capability info here. In Cavium hardwares, > all input pkts are considered as green when they enqueue to ethdev tx > queue. > OK, will add capability API in V2. > On the congestion control on Rx side, We support tail drop and RED pe

Re: [dpdk-dev] [PATCH 3/4] eventdev: Add eventdev ethernet Rx adapter

2017-09-19 Thread Rao, Nikhil
On 9/18/2017 9:06 PM, Van Haaren, Harry wrote: From: Rao, Nikhil +++ b/lib/librte_eventdev/rte_event_eth_rx_adapter.c @@ -0,0 +1,1239 @@ +#include +#include +#include +#include +#include +#include +#include +#include +#include + +#include "rte_eventdev.h" +#include "rte_eventdev_pmd.h

Re: [dpdk-dev] [PATCH v2 1/2] app/testpmd: add traffic management forwarding mode

2017-09-19 Thread Singh, Jasvinder
Hi Pablo, Thanks for feedback and review. > > app/test-pmd/Makefile | 5 + > > app/test-pmd/testpmd.c | 11 + > > app/test-pmd/testpmd.h | 34 ++ > > app/test-pmd/tm.c | 863 > > + > > 4 files changed, 913 insertions(+) > > create mode

Re: [dpdk-dev] [PATCH v2 2/2] app/testpmd: add CLI for tm mode

2017-09-19 Thread Singh, Jasvinder
> > Add following CLIs in testpmd application; > > - commands to build hierarchical tree for the QoS Scheduler. > > - commands for runtime update of the hierarchical tree. > > - commands to display TM capability information. > > (per port, per hierarchy level and per hierarchy node) > > - comman

Re: [dpdk-dev] [PATCH v4 0/5] net/mlx5 multi-process support

2017-09-19 Thread Xueming(Steven) Li
The only example to verify forked mode secondary process - should be deleted now as fork support removed in v4 > -Original Message- > From: Ferruh Yigit [mailto:ferruh.yi...@intel.com] > Sent: Tuesday, September 19, 2017 10:48 PM > To: Xueming(Steven) Li ; Nélio Laranjeiro > ; Adrien Maza

Re: [dpdk-dev] [dpdk-stable] [PATCH] net/i40e/base: fix bool definition

2017-09-19 Thread Ferruh Yigit
On 9/18/2017 7:11 PM, Jingjing Wu wrote: > use stdbool.h instead of defining the bool type, to make > sure the virtchnnl msg format definition is the same > between PF and VF. > > Cc: sta...@dpdk.org > Fixes: 4861cde46116 ("i40e: new poll mode driver") > > Signed-off-by: Jingjing Wu Applied to

Re: [dpdk-dev] [PATCH v4 0/5] net/mlx5 multi-process support

2017-09-19 Thread Ferruh Yigit
On 9/19/2017 3:31 PM, Xueming Li wrote: > This patchset enhances Mellanox multi-process by supporting all multi-process > examples, also support reading ethdev (x)stats in secondary process. > > Start from V2, this patchset depends on upstream rdma-core enhancement > and l2fork example bug fix: >

Re: [dpdk-dev] [PATCH] pmd_vmxnet3: Unintentional integer overflow

2017-09-19 Thread Ferruh Yigit
On 9/19/2017 12:47 PM, SebastianX Basierski wrote: > Fixed overflow by casting txq->cmd_ring.next2fill to uint64_t type. > > Coverity issue: 143457 > > Fixes: 01fef6e3c181 ("net/vmxnet3: allow variable length Tx data ring") > Cc: skh...@vmware.com > cc: dev@dpdk.org > > Signed-off-by: SebastianX

Re: [dpdk-dev] [PATCH 4/4] doc: add NXP DPAA SEC

2017-09-19 Thread Mcnamara, John
> -Original Message- > From: Akhil Goyal [mailto:akhil.go...@nxp.com] > Sent: Thursday, August 24, 2017 1:01 AM > To: dev@dpdk.org; De Lara Guarch, Pablo > Cc: Doherty, Declan ; Mcnamara, John > ; hemant.agra...@nxp.com; Akhil Goyal > > Subject: [PATCH 4/4] doc: add NXP DPAA SEC > > Si

Re: [dpdk-dev] [PATCH v4 0/5] net/mlx5 multi-process support

2017-09-19 Thread Nélio Laranjeiro
On Tue, Sep 19, 2017 at 10:31:47PM +0800, Xueming Li wrote: > This patchset enhances Mellanox multi-process by supporting all multi-process > examples, also support reading ethdev (x)stats in secondary process. > > Start from V2, this patchset depends on upstream rdma-core enhancement > and l2fork

[dpdk-dev] [PATCH v4 5/5] net/mlx5: multi-process document update

2017-09-19 Thread Xueming Li
This patch update the feature list and NIC guide to be multi-process enabled. Signed-off-by: Xueming Li Acked-by: Nelio Laranjeiro --- doc/guides/nics/features/mlx5.ini | 1 + doc/guides/nics/mlx5.rst | 4 ++-- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/doc/guides/n

[dpdk-dev] [PATCH v4 4/5] net/mlx5: add operations for secondary process

2017-09-19 Thread Xueming Li
Add operations that are safe for secondary processes: * (x)stats * device info get * rx/tx descriptor status Signed-off-by: Xueming Li Acked-by: Nelio Laranjeiro --- drivers/net/mlx5/mlx5.c| 16 +++- drivers/net/mlx5/mlx5.h| 1 + drivers/net/mlx5/mlx5_ethdev.c | 11

[dpdk-dev] [PATCH v4 3/5] net/mlx5: allocate verbs object into shared memory

2017-09-19 Thread Xueming Li
PMD uses Verbs object which were not available in the shared memory. This patch modify the location where Verbs objects are allocated (from process memory address space to shared memory address space) and thus allow a secondary process to use those object by mapping this shared memory space its ow

[dpdk-dev] [PATCH v4 2/5] net/mlx5: install a socket to exchange a file descriptor

2017-09-19 Thread Xueming Li
Use a unix socket to get back the communication channel with the Kernel driver from the primary process, this is necessary to remap those pages in the secondary process memory space and thus use the same Tx queues. This is only supported from rdma-core (v15). Signed-off-by: Nelio Laranjeiro Sign

[dpdk-dev] [PATCH v4 1/5] net/mlx5: change eth device reference for secondary process

2017-09-19 Thread Xueming Li
rte_eth_dev created by primary process were not available in secondary process, it was not possible to use the primary process local memory object from a secondary process. This patch modify the reference of primary rte_eth_dev object, use local rte_eth_dev secondary process instead. Signed-off-b

[dpdk-dev] [PATCH v4 0/5] net/mlx5 multi-process support

2017-09-19 Thread Xueming Li
This patchset enhances Mellanox multi-process by supporting all multi-process examples, also support reading ethdev (x)stats in secondary process. Start from V2, this patchset depends on upstream rdma-core enhancement and l2fork example bug fix: http://www.dpdk.org/ml/archives/dev/2017-August/0734

Re: [dpdk-dev] [PATCH v4 04/41] bus/dpaa: add OF parser for device scanning

2017-09-19 Thread Ferruh Yigit
On 9/19/2017 2:37 PM, Shreyansh Jain wrote: > On Monday 18 September 2017 08:19 PM, Ferruh Yigit wrote: >> On 9/9/2017 12:20 PM, Shreyansh Jain wrote: >>> This layer is used by Bus driver's scan function. Devices are parsed >>> using OF parser and added to DPAA device list. >> >> So this is device

Re: [dpdk-dev] [PATCH v4 17/41] doc: add NXP DPAA PMD documentation

2017-09-19 Thread Shreyansh Jain
On Monday 18 September 2017 08:23 PM, Ferruh Yigit wrote: On 9/9/2017 12:21 PM, Shreyansh Jain wrote: Signed-off-by: Hemant Agrawal Signed-off-by: Shreyansh Jain <...> +Config File Options +~~~ + +The following options can be modified in the ``config`` file. +Please note th

Re: [dpdk-dev] [PATCH v4 11/41] bus/dpaa: add QMan driver core routines

2017-09-19 Thread Shreyansh Jain
On Monday 18 September 2017 08:23 PM, Ferruh Yigit wrote: On 9/9/2017 12:21 PM, Shreyansh Jain wrote: Signed-off-by: Geoff Thorpe Signed-off-by: Roy Pledge Signed-off-by: Hemant Agrawal Signed-off-by: Shreyansh Jain <...> +#ifdef RTE_LIBRTE_DPAA_CHECKING This is not defined anywhere, it

Re: [dpdk-dev] [PATCH v4 07/41] bus/dpaa: enable DPAA IOCTL portal driver

2017-09-19 Thread Shreyansh Jain
On Monday 18 September 2017 08:21 PM, Ferruh Yigit wrote: On 9/9/2017 12:20 PM, Shreyansh Jain wrote: Userspace applications interact with DPAA blocks using this IOCTL driver. Signed-off-by: Geoff Thorpe Signed-off-by: Hemant Agrawal Signed-off-by: Shreyansh Jain <...> +static int fd = -

Re: [dpdk-dev] 回复: About the shared flock for hugepage files

2017-09-19 Thread Burakov, Anatoly
Hi Bakari, On 12-Sep-17 4:41 AM, 912873551 at qq.com (白长敏) wrote: Hi Jim, Thank you for reply, i understand it, but i still have two doubts. 1) if i have > 1 DPDK application on a machine, i can use the parameter "--file-prefix" to distinguish, it can work even if have not flock. That's n

Re: [dpdk-dev] [PATCH 26/26] doc: add octeontx ethdev driver documentation

2017-09-19 Thread Mcnamara, John
> -Original Message- > From: Jerin Jacob [mailto:jerin.ja...@caviumnetworks.com] > Sent: Thursday, August 31, 2017 3:55 PM > To: dev@dpdk.org > Cc: Yigit, Ferruh ; > santosh.shu...@caviumnetworks.com; Jerin Jacob > ; Mcnamara, John > Subject: [dpdk-dev] [PATCH 26/26] doc: add octeontx et

Re: [dpdk-dev] [PATCH v2 10/10] doc: add mempool and octeontx mempool device

2017-09-19 Thread Mcnamara, John
> -Original Message- > From: Santosh Shukla [mailto:santosh.shu...@caviumnetworks.com] > Sent: Thursday, August 31, 2017 7:37 AM > To: dev@dpdk.org; olivier.m...@6wind.com > Cc: jerin.ja...@caviumnetworks.com; Mcnamara, John > ; tho...@monjalon.net; hemant.agra...@nxp.com; > Santosh Shukl

Re: [dpdk-dev] [PATCH v4 03/41] bus/dpaa: add compatibility and helper macros

2017-09-19 Thread Shreyansh Jain
On Tuesday 19 September 2017 07:10 PM, Ferruh Yigit wrote: On 9/19/2017 2:18 PM, Shreyansh Jain wrote: On Monday 18 September 2017 08:19 PM, Ferruh Yigit wrote: On 9/9/2017 12:20 PM, Shreyansh Jain wrote: From: Hemant Agrawal Linked list, bit operations and compatibility macros. Signed-off-

[dpdk-dev] [PATCH] eal: fix resource leak

2017-09-19 Thread Daniel Mrzyglod
Memory allocated in strdup is not free. Coverity issue: 143257 Fixes: d8a2bc71dfc2 ("log: remove app path from syslog id") Cc: tho...@monjalon.net Signed-off-by: Daniel Mrzyglod --- lib/librte_eal/linuxapp/eal/eal.c | 16 1 file changed, 16 insertions(+) diff --git a/lib/librt

Re: [dpdk-dev] [PATCH v4 03/41] bus/dpaa: add compatibility and helper macros

2017-09-19 Thread Ferruh Yigit
On 9/19/2017 2:18 PM, Shreyansh Jain wrote: > On Monday 18 September 2017 08:19 PM, Ferruh Yigit wrote: >> On 9/9/2017 12:20 PM, Shreyansh Jain wrote: >>> From: Hemant Agrawal >>> >>> Linked list, bit operations and compatibility macros. >>> >>> Signed-off-by: Geoff Thorpe >>> Signed-off-by: Hema

Re: [dpdk-dev] [PATCH v2 5/5] doc: remove dpdk iova aware notice

2017-09-19 Thread Mcnamara, John
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Santosh Shukla > Sent: Tuesday, September 5, 2017 11:31 AM > To: dev@dpdk.org > Cc: tho...@monjalon.net; jerin.ja...@caviumnetworks.com; > hemant.agra...@nxp.com; olivier.m...@6wind.com; Santosh Shukla > > Subjec

Re: [dpdk-dev] [PATCH v4 02/41] bus/dpaa: introduce NXP DPAA Bus driver skeleton

2017-09-19 Thread Ferruh Yigit
On 9/19/2017 2:14 PM, Shreyansh Jain wrote: > Hello Ferruh, > > On Monday 18 September 2017 08:17 PM, Ferruh Yigit wrote: >> On 9/9/2017 12:20 PM, Shreyansh Jain wrote: >>> Signed-off-by: Shreyansh Jain >>> Signed-off-by: Hemant Agrawal <...> >>> +struct rte_dpaa_device { >>> + TAILQ_ENTRY(r

Re: [dpdk-dev] [PATCH] hash: document rte_jhash() boundary behavior

2017-09-19 Thread Mcnamara, John
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Chas Williams > Sent: Monday, September 18, 2017 8:48 PM > To: dev@dpdk.org > Cc: Richardson, Bruce ; De Lara Guarch, Pablo > ; Chas Williams > Subject: [dpdk-dev] [PATCH] hash: document rte_jhash() boundary beha

Re: [dpdk-dev] [PATCH v4 05/41] bus/dpaa: introducing FMan configurations

2017-09-19 Thread Shreyansh Jain
On Monday 18 September 2017 08:20 PM, Ferruh Yigit wrote: On 9/9/2017 12:20 PM, Shreyansh Jain wrote: FMan or Frame Manager, inspects traffic, splits it into queueson ingress. It is also responsible for directing traffic on queues on egress. This patch introduces FMan configurational interfaces

Re: [dpdk-dev] [PATCH v4 04/41] bus/dpaa: add OF parser for device scanning

2017-09-19 Thread Shreyansh Jain
On Monday 18 September 2017 08:19 PM, Ferruh Yigit wrote: On 9/9/2017 12:20 PM, Shreyansh Jain wrote: This layer is used by Bus driver's scan function. Devices are parsed using OF parser and added to DPAA device list. So this is device tree parser in DPDK. Do we really want this, and as long a

Re: [dpdk-dev] [PATCH v4 03/41] bus/dpaa: add compatibility and helper macros

2017-09-19 Thread Shreyansh Jain
On Monday 18 September 2017 08:19 PM, Ferruh Yigit wrote: On 9/9/2017 12:20 PM, Shreyansh Jain wrote: From: Hemant Agrawal Linked list, bit operations and compatibility macros. Signed-off-by: Geoff Thorpe Signed-off-by: Hemant Agrawal <...> diff --git a/drivers/bus/dpaa/include/compat.h

Re: [dpdk-dev] [PATCH v4 02/41] bus/dpaa: introduce NXP DPAA Bus driver skeleton

2017-09-19 Thread Shreyansh Jain
Hello Ferruh, On Monday 18 September 2017 08:17 PM, Ferruh Yigit wrote: On 9/9/2017 12:20 PM, Shreyansh Jain wrote: Signed-off-by: Shreyansh Jain Signed-off-by: Hemant Agrawal <...> diff --git a/drivers/bus/dpaa/rte_bus_dpaa_version.map b/drivers/bus/dpaa/rte_bus_dpaa_version.map new fil

Re: [dpdk-dev] [PATCH] net/enic: fix multi-process operation

2017-09-19 Thread Ferruh Yigit
On 9/19/2017 6:31 AM, John Daley (johndale) wrote: > >> -Original Message- >> From: Thomas Monjalon [mailto:tho...@monjalon.net] >> Sent: Monday, September 18, 2017 3:25 PM >> To: John Daley (johndale) >> Cc: Ferruh Yigit ; dev@dpdk.org; Sergio Gonzalez >> Monroy >> Subject: Re: [PATCH]

Re: [dpdk-dev] [PATCH 1/2] net/tap: fix setting speed by argument

2017-09-19 Thread Pascal Mazon
Hi, The patch looks mainly ok to me. I'll put some comments inline. On 18/09/2017 20:47, Ferruh Yigit wrote: > From: Vipin Varghese > > tap speed argument is not working without generating any error. Can you describe the error, paste the log? > > This patch sets the configured speed during devi

Re: [dpdk-dev] [PATCH 2/2] net/tap: fix unregistering callback with invalid fd

2017-09-19 Thread Pascal Mazon
Looks good. Best regards, Pascal Acked-by: Pascal Mazon On 18/09/2017 20:47, Ferruh Yigit wrote: > From: Vipin Varghese > > tap_intr_handle_set() called by tap_dev_start(), and if LSC is disabled > (dev_conf.intr_conf.lsc == 0), it tries to unregister interrupt > callback without checking the

Re: [dpdk-dev] [PATCH v2 11/19] net/bnxt: add support for xstats get by id

2017-09-19 Thread Ferruh Yigit
On 9/18/2017 4:17 PM, Ajit Khaparde wrote: > This patch adds support for xstats_get_by_id/xstats_get_names_by_id. > > Signed-off-by: Ajit Khaparde > > -- > v1->v2: incorporate review comments. > --- > drivers/net/bnxt/bnxt_ethdev.c | 2 ++ > drivers/net/bnxt/bnxt_stats.c | 47 > +

Re: [dpdk-dev] [PATCH v2 19/19] doc: update release notes

2017-09-19 Thread Ferruh Yigit
On 9/18/2017 4:17 PM, Ajit Khaparde wrote: > Update release doc briefly describing updates to bnxt PMD. > > Signed-off-by: Ajit Khaparde > --- > doc/guides/rel_notes/release_17_11.rst | 5 + > 1 file changed, 5 insertions(+) > > diff --git a/doc/guides/rel_notes/release_17_11.rst > b/doc/g

Re: [dpdk-dev] [PATCH v2 18/19] net/bnxt: add support for flow filter ops

2017-09-19 Thread Ferruh Yigit
On 9/18/2017 4:17 PM, Ajit Khaparde wrote: > This patch adds support for flow validate/create/destroy/flush ops. > Also update doc/guides/nics/features/bnxt.ini to indicate this. > > Signed-off-by: Ajit Khaparde <...> > +int bnxt_hwrm_set_ntuple_filter(struct bnxt *bp, > +

Re: [dpdk-dev] [PATCH v3 1/4] ethdev: increase port_id range

2017-09-19 Thread Wiles, Keith
> On Sep 19, 2017, at 1:05 AM, Yang, Zhiyong wrote: > > > >> -Original Message- >> From: Yigit, Ferruh >> Sent: Wednesday, September 13, 2017 9:33 PM >> To: Thomas Monjalon >> Cc: Yang, Zhiyong ; dev@dpdk.org; Doherty, Declan >> ; Lu, Wenzhuo ; >> hemant.agra...@nxp.com; Hunt, David ;

[dpdk-dev] [PATCH v5 2/2] app/testpmd: use uevent to monitor hot removal

2017-09-19 Thread Jeff Guo
use testpmd for example, to show app how to request and use uevent monitoring to handle the hot removal event and the hot insertion event. Signed-off-by: Jeff Guo --- v5->v4: add new callback to process hot insertion --- app/test-pmd/testpmd.c | 90 ++

[dpdk-dev] [PATCH v5 0/2] add uevent monitor for hot plug

2017-09-19 Thread Jeff Guo
So far, about hot plug in dpdk, we already have hot plug add/remove api and fail-safe driver to offload the fail-safe work from the app user. But there are still lack of a general event api, since the interrupt event, which hot plug related with, is diversity between each device and driver, such as

[dpdk-dev] [PATCH v5 1/2] eal: add uevent monitor for hot plug

2017-09-19 Thread Jeff Guo
This patch aim to add a general uevent mechanism in eal device layer, to enable all kernel object hot plug monitoring, so user could use these API to monitor and read out the device status info sent from the kernel side, then corresponding to handle it, such as detach or attach the device, and even

[dpdk-dev] [PATCH] pmd_vmxnet3: Unintentional integer overflow

2017-09-19 Thread SebastianX Basierski
Fixed overflow by casting txq->cmd_ring.next2fill to uint64_t type. Coverity issue: 143457 Fixes: 01fef6e3c181 ("net/vmxnet3: allow variable length Tx data ring") Cc: skh...@vmware.com cc: dev@dpdk.org Signed-off-by: SebastianX Basierski --- drivers/net/vmxnet3/vmxnet3_rxtx.c | 5 +++-- 1 file

[dpdk-dev] [PATCH] pmd_virtio: Unchecked return value from library

2017-09-19 Thread SebastianX Basierski
Check return value from library in order to prevent potential fail. Coverity issue: 143439 Fixes: ef53b6030039 ("net/virtio-user: support LSC") Cc: jianfeng@intel.com cc: dev@dpdk.org Signed-off-by: SebastianX Basierski --- drivers/net/virtio/virtio_user_ethdev.c | 10 -- 1 file ch

[dpdk-dev] [PATCH] pmd_virtio: Buffer not null terminated

2017-09-19 Thread SebastianX Basierski
Fix calling strncpy with the a maximum size equal of destination array size. Coverity issue: 140732 Fixes: e3b434818bbb ("net/virtio-user: support kernel vhost") Cc: jianfeng@intel.com cc: dev@dpdk.org Signed-off-by: SebastianX Basierski --- drivers/net/virtio/virtio_user/vhost_kernel_tap.

Re: [dpdk-dev] [PATCH] vfio: refactor PCI BAR mapping

2017-09-19 Thread Burakov, Anatoly
Hi Jonas, On 17-Aug-17 12:35 PM, Jonas Pfefferle wrote: Split pci_vfio_map_resource for primary and secondary processes. Save all relevant mapping data in primary process to allow the secondary process to perform mappings. Signed-off-by: Jonas Pfefferle --- lib/librte_eal/common/include/rte_

Re: [dpdk-dev] [PATCH] doc: update failsafe feature list

2017-09-19 Thread Matan Azrad
Hi Ferruh > -Original Message- > From: Ferruh Yigit [mailto:ferruh.yi...@intel.com] > Sent: Tuesday, September 19, 2017 2:00 PM > To: Matan Azrad ; Gaetan Rivet > > Cc: dev@dpdk.org; john.mcnam...@intel.com > Subject: Re: [dpdk-dev] [PATCH] doc: update failsafe feature list > > On 9/19/2

[dpdk-dev] [PATCH v5 2/5] cfgfile: change existing API functions

2017-09-19 Thread Kuba Kozak
From: Jacek Piasecki Change to flat arrays in cfgfile struct force slightly diffrent data access for most of cfgfile functions. This patch provides necessary changes in existing API. Signed-off-by: Jacek Piasecki Acked-by: Bruce Richardson --- doc/guides/rel_notes/deprecation.rst | 5 ++ li

[dpdk-dev] [PATCH v5 4/5] cfgfile: rework of load function

2017-09-19 Thread Kuba Kozak
From: Jacek Piasecki New functions added to cfgfile library make it possible to significantly simplify the code of rte_cfgfile_load_with_params() This patch shows the new body of this function. Signed-off-by: Jacek Piasecki Acked-by: Bruce Richardson --- lib/librte_cfgfile/rte_cfgfile.c | 15

  1   2   >