[dpdk-dev] [PATCH] bus/pci: fix vfio device reset

2017-10-27 Thread Jerin Jacob
If the device is not capable of resetting, then Linux kernel updates the errno as EINVAL. http://elixir.free-electrons.com/linux/v4.9/source/drivers/vfio/pci/vfio_pci.c#L887 Honor the EINVAL errno value to avoid pci vfio setup failure. Fixes: f25f8f367644 ("bus/pci: check VFIO reset ioctl error")

[dpdk-dev] [PATCH] bus/pci: fix vfio mode

2017-10-27 Thread Jerin Jacob
The definition of VFIO_PRESENT is "eal_vfio.h", Fail to include eal_vfio.h will result in disabling vfio. Fixes: 279b581c897d ("vfio: expose functions") Cc: Gaetan Rivet Signed-off-by: Jerin Jacob --- drivers/bus/pci/linux/pci.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/bus/

[dpdk-dev] [PATCH] doc: fix an error in DPDK programmers's guide (EAL)

2017-10-27 Thread Rami Rosen
Fix an error in DPDK programmer's guide (EAL section): it should be rte_thread_get_affinity() instead of rte_pthread_get_affinity(). Signed-off-by: Rami Rosen --- doc/guides/prog_guide/env_abstraction_layer.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/guides/prog

Re: [dpdk-dev] Huge mapping secondary process linux

2017-10-27 Thread Jonas Pfefferle1
"Burakov, Anatoly" wrote on 27/10/2017 18:00:27: > From: "Burakov, Anatoly" > To: Jonas Pfefferle1 > Cc: bruce.richard...@intel.com, chao...@linux.vnet.ibm.com, dev@dpdk.org > Date: 27/10/2017 18:00 > Subject: Re: [dpdk-dev] Huge mapping secondary process linux > > On 27-Oct-17 4:16 PM, Jonas

Re: [dpdk-dev] [PATCH v9 3/4] bus/vdev: move to vdev bus to drivers/bus

2017-10-27 Thread Gaëtan Rivet
On Fri, Oct 27, 2017 at 10:53:11AM +0200, Thomas Monjalon wrote: > 27/10/2017 10:19, Tan, Jianfeng: > > From: Thomas Monjalon [mailto:tho...@monjalon.net] > > > 27/10/2017 03:06, Jianfeng Tan: > > > > --- /dev/null > > > > +++ b/drivers/bus/vdev/rte_bus_vdev_version.map > > > > @@ -0,0 +1,8 @@ > >

[dpdk-dev] [PATCH v2] test/pmd_perf: fix for segmentation fault

2017-10-27 Thread Daniel Mrzyglod
Error can be reproduce if we run pmd_perf_autotest with more then one device in such way: RTE>>set_rxtx_sc poll_before_xmit RTE>>pmd_perf_autotest if first burst was value less than MAX_PKT_BURST in the end we overwrite pkts_burst table for rx which was supposed for another interface. Fixes: 002a

Re: [dpdk-dev] Huge mapping secondary process linux

2017-10-27 Thread Burakov, Anatoly
On 27-Oct-17 4:48 PM, Tan, Jianfeng wrote: On 10/27/2017 10:44 PM, Burakov, Anatoly wrote: On 27-Oct-17 3:28 PM, Jonas Pfefferle1 wrote: "Burakov, Anatoly" wrote on 10/27/2017 04:06:44 PM:  > From: "Burakov, Anatoly"  > To: Jonas Pfefferle1 , dev@dpdk.org  > Cc: chao...@linux.vnet.ibm.com

Re: [dpdk-dev] Huge mapping secondary process linux

2017-10-27 Thread Burakov, Anatoly
On 27-Oct-17 4:16 PM, Jonas Pfefferle1 wrote: "dev" wrote on 10/27/2017 04:58:01 PM: > From: "Jonas Pfefferle1" > To: "Burakov, Anatoly" > Cc: bruce.richard...@intel.com, chao...@linux.vnet.ibm.com, dev@dpdk.org > Date: 10/27/2017 04:58 PM > Subject: Re: [dpdk-dev] Huge mapping secondary

[dpdk-dev] [PATCH] net/bnxt: fix fdir filter code

2017-10-27 Thread Ajit Khaparde
Set the filter_type before we match a new filter against existing filters. Otherwise we are missing the existing filters. Fixes: 2d64da097aa0 ("net/bnxt: support FDIR") Signed-off-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_ethdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --

Re: [dpdk-dev] Huge mapping secondary process linux

2017-10-27 Thread Tan, Jianfeng
On 10/27/2017 10:44 PM, Burakov, Anatoly wrote: On 27-Oct-17 3:28 PM, Jonas Pfefferle1 wrote: "Burakov, Anatoly" wrote on 10/27/2017 04:06:44 PM: > From: "Burakov, Anatoly" > To: Jonas Pfefferle1 , dev@dpdk.org > Cc: chao...@linux.vnet.ibm.com, bruce.richard...@intel.com > Date: 10/27/

Re: [dpdk-dev] [PATCH 1/7] Use an accessor for rte_hash_key

2017-10-27 Thread De Lara Guarch, Pablo
> From: Mike Stolarchuk [mailto:mike.stolarc...@bigswitch.com] > Sent: Friday, October 27, 2017 4:00 PM > To: De Lara Guarch, Pablo > Cc: Thomas Monjalon ; Richardson, Bruce > ; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH 1/7] Use an accessor for rte_hash_key > > Pablo, > > Also, what about th

Re: [dpdk-dev] Huge mapping secondary process linux

2017-10-27 Thread Jonas Pfefferle1
"dev" wrote on 10/27/2017 04:58:01 PM: > From: "Jonas Pfefferle1" > To: "Burakov, Anatoly" > Cc: bruce.richard...@intel.com, chao...@linux.vnet.ibm.com, dev@dpdk.org > Date: 10/27/2017 04:58 PM > Subject: Re: [dpdk-dev] Huge mapping secondary process linux > Sent by: "dev" > > > "Burakov, Ana

Re: [dpdk-dev] [PATCH] cfgfile: fix resource leak

2017-10-27 Thread Jastrzebski, MichalX K
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Jacek Piasecki > Sent: Thursday, October 26, 2017 8:21 AM > To: Dumitrescu, Cristian > Cc: dev@dpdk.org; Piasecki, JacekX ; > sta...@dpdk.org > Subject: [dpdk-dev] [PATCH] cfgfile: fix resource leak > > Unsuccesfu

Re: [dpdk-dev] [PATCH] cfgfile: fix NULL pointer dereference

2017-10-27 Thread Jastrzebski, MichalX K
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Jacek Piasecki > Sent: Thursday, October 26, 2017 8:24 AM > To: Dumitrescu, Cristian > Cc: dev@dpdk.org; Piasecki, JacekX ; > sta...@dpdk.org > Subject: [dpdk-dev] [PATCH] cfgfile: fix NULL pointer dereference > >

Re: [dpdk-dev] [PATCH 1/7] Use an accessor for rte_hash_key

2017-10-27 Thread Mike Stolarchuk
Pablo, Also, what about the other patch? the use of a static variable in a recursive call? obviously incorrect for a threaded environment ... has that been accepted? regards, mts. On Thu, Oct 19, 2017 at 4:10 AM, De Lara Guarch, Pablo < pablo.de.lara.gua...@intel.com> wrote: > > > > -Orig

Re: [dpdk-dev] Huge mapping secondary process linux

2017-10-27 Thread Jonas Pfefferle1
"Burakov, Anatoly" wrote on 10/27/2017 04:44:52 PM: > From: "Burakov, Anatoly" > To: Jonas Pfefferle1 > Cc: bruce.richard...@intel.com, chao...@linux.vnet.ibm.com, dev@dpdk.org > Date: 10/27/2017 04:45 PM > Subject: Re: [dpdk-dev] Huge mapping secondary process linux > > On 27-Oct-17 3:28 PM,

Re: [dpdk-dev] Huge mapping secondary process linux

2017-10-27 Thread Burakov, Anatoly
On 27-Oct-17 3:28 PM, Jonas Pfefferle1 wrote: "Burakov, Anatoly" wrote on 10/27/2017 04:06:44 PM: > From: "Burakov, Anatoly" > To: Jonas Pfefferle1 , dev@dpdk.org > Cc: chao...@linux.vnet.ibm.com, bruce.richard...@intel.com > Date: 10/27/2017 04:06 PM > Subject: Re: [dpdk-dev] Huge mappi

Re: [dpdk-dev] Huge mapping secondary process linux

2017-10-27 Thread Jonas Pfefferle1
"Burakov, Anatoly" wrote on 10/27/2017 04:06:44 PM: > From: "Burakov, Anatoly" > To: Jonas Pfefferle1 , dev@dpdk.org > Cc: chao...@linux.vnet.ibm.com, bruce.richard...@intel.com > Date: 10/27/2017 04:06 PM > Subject: Re: [dpdk-dev] Huge mapping secondary process linux > > On 27-Oct-17 1:43 PM, J

Re: [dpdk-dev] Huge mapping secondary process linux

2017-10-27 Thread Burakov, Anatoly
On 27-Oct-17 1:43 PM, Jonas Pfefferle1 wrote: Hi @all, I'm trying to make sense of the hugepage memory mappings in librte_eal/linuxapp/eal/eal_memory.c: * In rte_eal_hugepage_attach (line 1347) when we try to do a private mapping on /dev/zero (line 1393) why do we not use MAP_FIXED if we need

[dpdk-dev] [PATCH] net/ixgbe: fix IPsec Rx with SSE on

2017-10-27 Thread Radu Nicolau
Fixes: 9a0752f498d2 ("net/ixgbe: enable inline IPsec") And small performance improvement Signed-off-by: Radu Nicolau --- drivers/net/ixgbe/ixgbe_rxtx_vec_sse.c | 79 +- 1 file changed, 30 insertions(+), 49 deletions(-) diff --git a/drivers/net/ixgbe/ixgbe_rxtx_ve

[dpdk-dev] Leftover reference to Intel DPDK

2017-10-27 Thread Stephen Hemminger
I noticed that all references to "Intel DPDK" have been eliminated from the documentation text. But still see it in kernel_nic_intf.png has Intel(r) DPDK in the image. Not sure if there are others.

[dpdk-dev] Huge mapping secondary process linux

2017-10-27 Thread Jonas Pfefferle1
Hi @all, I'm trying to make sense of the hugepage memory mappings in librte_eal/linuxapp/eal/eal_memory.c: * In rte_eal_hugepage_attach (line 1347) when we try to do a private mapping on /dev/zero (line 1393) why do we not use MAP_FIXED if we need the addresses to be identical with the primary p

[dpdk-dev] [PATCH] lib/librte_table: fix copy paste error in lru hash table

2017-10-27 Thread Jasvinder Singh
Fixes the copy paste error in lru hash table parameters check. Coverity issue: 198433 Fixes: b5cde2cb8c81 ("table: rework variable size key lru hash table") Signed-off-by: Jasvinder Singh Acked-by: Cristian Dumitrescu --- lib/librte_table/rte_table_hash_lru.c | 5 ++--- 1 file changed, 2 inser

Re: [dpdk-dev] [PATCH] examples/ip_pipeline: avoid the failure of creating hash table

2017-10-27 Thread Dumitrescu, Cristian
> -Original Message- > From: Jianbo Liu [mailto:jianbo@arm.com] > Sent: Friday, October 27, 2017 3:55 AM > To: dev@dpdk.org; Dumitrescu, Cristian > Cc: Jianbo Liu > Subject: [PATCH] examples/ip_pipeline: avoid the failure of creating hash > table > > Hash table function will check

Re: [dpdk-dev] [PATCH v2] examples/ip_pipeline: use crc32 in hash functions for arm64

2017-10-27 Thread Dumitrescu, Cristian
> -Original Message- > From: Jianbo Liu [mailto:jianbo@arm.com] > Sent: Friday, October 27, 2017 10:25 AM > To: dev@dpdk.org; Dumitrescu, Cristian > Cc: Jianbo Liu > Subject: [PATCH v2] examples/ip_pipeline: use crc32 in hash functions for > arm64 > > From: Jianbo Liu > > Impleme

[dpdk-dev] [PATCH] app/testpmd: remove port status check from TM hierarchy commit cli

2017-10-27 Thread Jasvinder Singh
Some drivers might allow to commit the traffic management hierarchy while being in running state. Therefore, removes port status check before invoking hierarchy commit API in the cli. If needed, device can add port status check at the driver layer. Signed-off-by: Jasvinder Singh --- app/test-pmd

[dpdk-dev] [PATCH v2] examples/ip_pipeline: use crc32 in hash functions for arm64

2017-10-27 Thread Jianbo Liu
From: Jianbo Liu Implement the same hash functions with crc32 on arm platform. Signed-off-by: Jianbo Liu --- examples/ip_pipeline/pipeline/hash_func.h | 2 + examples/ip_pipeline/pipeline/hash_func_arm64.h | 261 2 files changed, 263 insertions(+) create mode

[dpdk-dev] [PATCH] app/testpmd: fix memory access error for metering CLI

2017-10-27 Thread Jasvinder Singh
Fix memory access (out of bounds write) error, color and action assignments. Coverity issue: 198437 Fixes: 30ffb4e67ee3 ("app/testpmd: add commands traffic metering and policing") Signed-off-by: Jasvinder Singh --- app/test-pmd/cmdline_mtr.c | 6 ++ 1 file changed, 2 insertions(+), 4 deleti

[dpdk-dev] [PATCH] app/testpmd: fix NULL pointer deref for traffic management CLI

2017-10-27 Thread Jasvinder Singh
Malloc() function might returns NULL when memory allocation fails due to insufficient space. Therefore, check for handling memory allocation failure is added. Coverity issue: 198442,198444 Fixes: 996cb153af06 ("app/testpmd: add commands for TM nodes and hierarchy commit") Signed-off-by: Jasvinde

Re: [dpdk-dev] [PATCH v9 3/4] bus/vdev: move to vdev bus to drivers/bus

2017-10-27 Thread Thomas Monjalon
27/10/2017 10:19, Tan, Jianfeng: > From: Thomas Monjalon [mailto:tho...@monjalon.net] > > 27/10/2017 03:06, Jianfeng Tan: > > > --- /dev/null > > > +++ b/drivers/bus/vdev/rte_bus_vdev_version.map > > > @@ -0,0 +1,8 @@ > > > +DPDK_17.11 { > > > + global: > > > + > > > + rte_vdev_init; >

Re: [dpdk-dev] [PATCH v9 3/4] bus/vdev: move to vdev bus to drivers/bus

2017-10-27 Thread Tan, Jianfeng
> -Original Message- > From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Friday, October 27, 2017 3:56 PM > To: Tan, Jianfeng > Cc: dev@dpdk.org; jblu...@infradead.org; Richardson, Bruce; Ananyev, > Konstantin; De Lara Guarch, Pablo; y...@fridaylinux.org; > maxime.coque...@redhat

Re: [dpdk-dev] [PATCH v9 3/4] bus/vdev: move to vdev bus to drivers/bus

2017-10-27 Thread Thomas Monjalon
27/10/2017 03:06, Jianfeng Tan: > --- /dev/null > +++ b/drivers/bus/vdev/rte_bus_vdev_version.map > @@ -0,0 +1,8 @@ > +DPDK_17.11 { > + global: > + > + rte_vdev_init; > + rte_vdev_register; > + rte_vdev_uninit; > + rte_vdev_unregister; > +}; It should not be needed to