Hi Gabriel,
Can you please split the patch into smaller chunks so that it will be easy to
review and provide comments.
Regards,
Pavan.
On Mon, Nov 20, 2017 at 04:35:33PM -0600, Erik Gabriel Carrillo wrote:
> Signed-off-by: Erik Gabriel Carrillo
> ---
> v3
> - Reworked allocation and ops organiz
> -Original Message-
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Yang, Zhiyong
> Sent: Thursday, November 23, 2017 9:57 AM
> To: Wu, Yanglong ; dev@dpdk.org
> Cc: Wu, Yanglong
> Subject: Re: [dpdk-dev] [PATCH] app/testpmd: fix port_id alloction issue
>
> Hi Yanglong,
>
> Goo
Hi Yanglong,
Good catch! Thanks for your patch.
Thanks
Zhiyong
> -Original Message-
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Yanglong Wu
> Sent: Thursday, November 23, 2017 9:27 AM
> To: dev@dpdk.org
> Cc: Wu, Yanglong
> Subject: [dpdk-dev] [PATCH] app/testpmd: fix port_id
the port_id was allocated as a inccrete number,
for init function was passthroughed a wrong
size of parameter
Fixes:28caa76aea71 ("app/testpmd: fix port id type")
Signed-off-by: Yanglong Wu
---
app/test-pmd/cmdline.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/app/test-p
> -Original Message-
> From: Yigit, Ferruh
> Sent: Thursday, November 23, 2017 6:39 AM
> To: Wu, Jingjing ; dev@dpdk.org
> Cc: Lu, Wenzhuo
> Subject: Re: [dpdk-dev] [RFC 4/9] net/avf: enable basic Rx Tx func
>
> On 11/21/2017 11:55 PM, Wu, Jingjing wrote:
> >
> >
> >> -Original Mess
On 11/21/2017 4:57 PM, Stephen Hemminger wrote:
> On Tue, 21 Nov 2017 16:06:24 -0800
> Ferruh Yigit wrote:
>
>> On 10/20/2017 1:26 AM, Jingjing Wu wrote:
>>> Signed-off-by: Wenzhuo Lu
>>
>> <...>
>>
>>> @@ -214,6 +214,9 @@ CONFIG_RTE_LIBRTE_FM10K_INC_VECTOR=y
>>> # Compile burst-oriented AVF
On 11/22/2017 1:28 AM, Pavan Nikhilesh wrote:
> Update legacy log types regex strings used for registering dynamic logs.
>
> Signed-off-by: Pavan Nikhilesh
For series
Reviewed-by: Ferruh Yigit
On 11/21/2017 11:55 PM, Wu, Jingjing wrote:
>
>
>> -Original Message-
>> From: Yigit, Ferruh
>> Sent: Wednesday, November 22, 2017 8:06 AM
>> To: Wu, Jingjing ; dev@dpdk.org
>> Cc: Lu, Wenzhuo
>> Subject: Re: [dpdk-dev] [RFC 4/9] net/avf: enable basic Rx Tx func
>>
>> On 10/20/2017 1:26
List of supported OpenSSL versions and code block with dependencies were
not properly formatted.
Fixes: d61f70b4c918 ("crypto/libcrypto: add driver for OpenSSL library")
Signed-off-by: Andrea Grandi
---
doc/guides/cryptodevs/openssl.rst | 12 +---
1 file changed, 9 insertions(+), 3 dele
Add a missing space must before the first item of the list to display it
correctly in the User Guide.
Fixes: d61f70b4c918 ("crypto/libcrypto: add driver for OpenSSL library")
Fixes: b79e4c00af0e ("cryptodev: use AES-GCM/CCM as AEAD algorithms")
Signed-off-by: Andrea Grandi
---
doc/guides/crypto
Add template release notes for DPDK 18.02 with inline
comments and explanations of the various sections.
Signed-off-by: John McNamara
---
V2: Added "Removed Items" and removed "Resolved Issues".
doc/guides/rel_notes/release_18_02.rst | 186 +
1 file changed, 186
> -Original Message-
> From: Thomas Monjalon [mailto:tho...@monjalon.net]
> Sent: Wednesday, November 22, 2017 11:07 AM
> To: Mcnamara, John
> Cc: dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v1] doc: add template release notes for
> 18.02
>
> Hi,
>
> 17/11/2017 23:41, John McNamara:
> -Original Message-
> From: Gaëtan Rivet [mailto:gaetan.ri...@6wind.com]
> Sent: Wednesday, November 22, 2017 2:32 PM
> To: Neil Horman
> Cc: Nelio Laranjeiro ; Akhil Goyal
> ; Doherty, Declan ;
> dev@dpdk.org; De Lara Guarch, Pablo ;
> sta...@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH 2
On Wed, Nov 22, 2017 at 08:43:29PM +0530, Anoob wrote:
>Hi Nelio,
>
>The issue is probably because of a different patch titled, "[PATCH 2/3]
>crypto: fix pedentic compilation errors". I was able to reproduce the
>issue with that.
>
>Hope this helps.
>
>Thanks,
>Anoob
Hi Nelio,
The issue is probably because of a different patch titled, "[PATCH 2/3]
crypto: fix pedentic compilation errors". I was able to reproduce the
issue with that.
Hope this helps.
Thanks,
Anoob
On 11/22/2017 06:35 PM, Nelio Laranjeiro wrote:
On Wed, Nov 22, 2017 at 06:25:12PM +0530,
On Wed, Nov 22, 2017 at 08:56:14AM -0500, Neil Horman wrote:
> On Wed, Nov 22, 2017 at 09:10:17AM +0100, Nelio Laranjeiro wrote:
> > /root/dpdk/x86_64-native-linuxapp-gcc/include/rte_crypto.h:126:28: error:
> > ISO C forbids zero-size array ‘sym’ [-Werror=pedantic]
> >struct rte_crypto_sym_op
Without this patch, the number of queues per i40e VF is defined as 4
by CONFIG_RTE_LIBRTE_I40E_QUEUE_NUM_PER_VF=4 in config/common_base.
It is fixed value determined in building time and can't be changed
during run time.
With this patch, the number of queues per i40e VF can be determinated
during
Hi,
Please see inline.
On 11/22/2017 06:57 PM, Neil Horman wrote:
On Wed, Nov 22, 2017 at 06:55:15AM +, Anoob Joseph wrote:
In case of inline protocol processed ingress traffic, the packet may not
have enough information to determine the security parameters with which
the packet was proce
On Wed, Nov 22, 2017 at 09:10:17AM +0100, Nelio Laranjeiro wrote:
> /root/dpdk/x86_64-native-linuxapp-gcc/include/rte_crypto.h:126:28: error:
> ISO C forbids zero-size array ‘sym’ [-Werror=pedantic]
>struct rte_crypto_sym_op sym[0];
> ^~~
>
> Fixes: d2a4223c4c6d (
Hi Nelio,
Please ignore the previous mail. I'll check the issue and let you know.
Thanks,
Anoob
On 11/22/2017 07:08 PM, Anoob wrote:
Hi Nelio,
So you had attempted inline-crypto(not inline-protocol), right?
Can you give some more details on the test case which caused the
issue? Was it inbo
Hi Nelio,
So you had attempted inline-crypto(not inline-protocol), right?
Can you give some more details on the test case which caused the issue?
Was it inbound or outbound?
And your PMD doesn't have "get_pkt_metadata" function pointer
registered, right?
Thanks,
Anoob
On 11/22/2017 06:35
On Wed, Nov 22, 2017 at 06:55:15AM +, Anoob Joseph wrote:
> In case of inline protocol processed ingress traffic, the packet may not
> have enough information to determine the security parameters with which
> the packet was processed. For such cases, application could register a
> 64 bit metada
On Wed, Nov 22, 2017 at 06:25:12PM +0530, Anoob wrote:
> Hi Nelio,
>
> Which mode was attempted when you got the crash? Is it with inline-protocol?
Hi Annoob,
Yes, MLX5 ConnectX-4 Lx INNOVA is an inline crypto NIC.
> Thanks,
>
> Anoob
>
>
> On 11/22/2017 05:51 PM, Nelio Laranjeiro wrote:
> >
Hi Nelio,
Which mode was attempted when you got the crash? Is it with inline-protocol?
Thanks,
Anoob
On 11/22/2017 05:51 PM, Nelio Laranjeiro wrote:
Hi Anoob,
I am facing a segfault in ipsec-secgw with this series when using MLX5
PMD, maybe you can help here, see the following gdb backtrace
Hi Anoob,
I am facing a segfault in ipsec-secgw with this series when using MLX5
PMD, maybe you can help here, see the following gdb backtrace.
Thread 1 "ipsec-secgw" received signal SIGSEGV, Segmentation fault.
0x555b5123 in __rte_security_attach_session (sym_op=0x0,
sess=0x7ffef7edb5
On 11/22/2017 11:52 AM, Anoob wrote:
Hi,
See inline.
Thanks,
Anoob
On 11/22/2017 04:59 PM, Radu Nicolau wrote:
On 11/22/2017 6:55 AM, Anoob Joseph wrote:
In case of inline protocol processed ingress traffic, the packet may
not
have enough information to determine the security parameter
Hi,
See inline.
Thanks,
Anoob
On 11/22/2017 04:59 PM, Radu Nicolau wrote:
On 11/22/2017 6:55 AM, Anoob Joseph wrote:
In case of inline protocol processed ingress traffic, the packet may not
have enough information to determine the security parameters with which
the packet was processed. Fo
On 11/22/2017 6:55 AM, Anoob Joseph wrote:
In case of inline protocol processed ingress traffic, the packet may not
have enough information to determine the security parameters with which
the packet was processed. For such cases, application could register a
64 bit metadata in security session,
Signed-off-by: Radu Nicolau
---
drivers/net/ixgbe/ixgbe_ipsec.c | 78 ++---
drivers/net/ixgbe/ixgbe_ipsec.h | 4 ---
2 files changed, 35 insertions(+), 47 deletions(-)
diff --git a/drivers/net/ixgbe/ixgbe_ipsec.c b/drivers/net/ixgbe/ixgbe_ipsec.c
index 105da1
Hi,
17/11/2017 23:41, John McNamara:
> +Resolved Issues
> +---
> +
> +.. This section should contain bug fixes added to the relevant
> + sections. Sample format:
I am not sure about this section.
It is really too hard to maintain it.
We have only few fixes referenced here.
The conse
Hi Pablo,
On Wed, Nov 22, 2017 at 09:48:47AM +, De Lara Guarch, Pablo wrote:
> Hi Nelio,
>
> > -Original Message-
> > From: Nelio Laranjeiro [mailto:nelio.laranje...@6wind.com]
> > Sent: Wednesday, November 22, 2017 8:10 AM
> > To: Akhil Goyal ; Doherty, Declan
> >
> > Cc: dev@dpdk.o
Hi Nelio,
> -Original Message-
> From: Nelio Laranjeiro [mailto:nelio.laranje...@6wind.com]
> Sent: Wednesday, November 22, 2017 8:10 AM
> To: Akhil Goyal ; Doherty, Declan
>
> Cc: dev@dpdk.org; De Lara Guarch, Pablo
> ; sta...@dpdk.org
> Subject: [PATCH 2/3] crypto: fix pedentic compilat
Remove RTE_LOG_LEVEL config option, use existing RTE_LOG_DP_LEVEL config
option for controlling datapath log level.
RTE_LOG_LEVEL is no longer needed as dynamic logging can be used to
control global and module specific log levels.
Signed-off-by: Pavan Nikhilesh
---
config/common_base
Update legacy log types regex strings used for registering dynamic logs.
Signed-off-by: Pavan Nikhilesh
---
Note:
This patchset is based on patch set
http://dpdk.org/dev/patchwork/patch/31443/
followed by ml discussion
http://dpdk.org/ml/archives/dev/2017-November/081953.html
lib/librte_ea
Use global default loglevel to DEBUG(8) and dynamic default loglevel
to INFO(7).
Signed-off-by: Pavan Nikhilesh
---
lib/librte_eal/common/eal_common_log.c | 8 ++--
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/lib/librte_eal/common/eal_common_log.c
b/lib/librte_eal/common/e
22/11/2017 09:43, Shahaf Shuler:
> Tuesday, November 21, 2017 8:03 PM, Ferruh Yigit:
> > On 11/21/2017 12:32 AM, Shahaf Shuler wrote:
> > >
> > > The deprecation of the old offloads API is set to 18.05 [1]. my
> > understanding was that we agreed to convert all PMDs on 18.02.
> > > If the PMD deadl
Hemant:
I am working the changes we are asking for on the BSD license. With respect to
the Synopsys license text. They are telling me that similar header concerns
were raised from linux .org and they were OK keeping the header if an author
signoff-off text was included. Would that be suffici
Tuesday, November 21, 2017 8:03 PM, Ferruh Yigit:
> On 11/21/2017 12:32 AM, Shahaf Shuler wrote:
> >
> > The deprecation of the old offloads API is set to 18.05 [1]. my
> understanding was that we agreed to convert all PMDs on 18.02.
> > If the PMD deadline is going to be postponed I think the ethd
> -Original Message-
> From: Yigit, Ferruh
> Sent: Wednesday, November 22, 2017 8:09 AM
> To: Wu, Jingjing ; dev@dpdk.org
> Cc: Lu, Wenzhuo ; Olivier MATZ
>
> Subject: Re: [dpdk-dev] [RFC 8/9] net/avf: enable ops to check queue info and
> status
>
> On 10/20/2017 1:26 AM, Jingjing Wu wr
Hi,
The patch looks globally fine to me.
I'll inline just one comment.
Best regards,
Pascal
On 20/11/2017 14:59, Moti Haimovsky wrote:
> This patch adds support for registering and waiting for Rx interrupts.
> This allows applications to wait for Rx events from the PMD using the
> DPDK rte_epoll
/root/dpdk/x86_64-native-linuxapp-gcc/include/rte_security.h:229:8: error:
struct has no members [-Werror=pedantic]
struct rte_security_macsec_xform {
^
/root/dpdk/x86_64-native-linuxapp-gcc/include/rte_security.h:453:3: error:
struct has no members [-Werror=p
Device operation pointers should be constant to avoid any modification
while it is in use.
Fixes: c261d1431bd8 ("security: introduce security API and framework")
Cc: akhil.go...@nxp.com
Cc: sta...@dpdk.org
Signed-off-by: Nelio Laranjeiro
---
lib/librte_security/rte_security.h | 2 +-
1 file cha
/root/dpdk/x86_64-native-linuxapp-gcc/include/rte_crypto.h:126:28: error: ISO
C forbids zero-size array ‘sym’ [-Werror=pedantic]
struct rte_crypto_sym_op sym[0];
^~~
Fixes: d2a4223c4c6d ("cryptodev: do not store pointer to op specific params")
Cc: pablo.de.lara.gua
43 matches
Mail list logo
