Re: [dpdk-dev] [PATCH v3 1/5] bbdev: librte_bbdev library

2017-12-08 Thread Ferruh Yigit
On 12/7/2017 1:40 PM, Amr Mokhtar wrote: Patch title has duplication, it can be something like: bbdev: introduce base band device abstraction library > - BBDEV library files > - BBDEV is tagged as EXPERIMENTAL > - Makefiles and configuration macros definition > - The bbdev framework and the 'null

[dpdk-dev] [PATCH] igb_uio: allow multi-process access

2017-12-08 Thread Xiao Wang
In some case, one device are accessed by different processes via different BARs, so one uio device may be opened by more than one process, for this case we just need to enable interrupt once, and pci_clear_master only when the last process closed. Fixes: 5f6ff30dc507 ("igb_uio: fix interrupt enabl

[dpdk-dev] [PATCH] net/fm10k: fix logical port delete

2017-12-08 Thread Xiao Wang
When closing port, we need to send mailbox messages to switch manager to reset multicast mode and delete logical port. In the latest IES_SDK, e.g. v4.3.3, switch takes longer time to handle these mailbox messages. So this patch adds longer delay to accommodate this change. Otherwise, the mailbox w

[dpdk-dev] [PATCH] pktgen-stats/latency: fix RTE version in lib includes

2017-12-08 Thread Georgios Katsikas
--- app/pktgen-latency.c | 2 +- app/pktgen-stats.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/app/pktgen-latency.c b/app/pktgen-latency.c index 9c83748..7cfc1d5 100644 --- a/app/pktgen-latency.c +++ b/app/pktgen-latency.c @@ -13,7 +13,7 @@ #include "pktgen.h" -#

Re: [dpdk-dev] [PATCH 16/16] net/axgbe: add support for build 32-bit mode

2017-12-08 Thread Ferruh Yigit
On 11/30/2017 5:11 AM, Ravi Kumar wrote: Can you please update axgbe.ini in this patch to add x86-32 support. > Signed-off-by: Ravi Kumar > --- > drivers/net/axgbe/axgbe_common.h| 49 +++--- > drivers/net/axgbe/axgbe_ethdev.c| 10 +- > drivers/net/axgbe/axgbe_ethdev.h| 8 +- > d

Re: [dpdk-dev] [PATCH 14/16] doc: add documents for AMD axgbe Ethernet PMD

2017-12-08 Thread Ferruh Yigit
On 11/30/2017 5:11 AM, Ravi Kumar wrote: > Signed-off-by: Ravi Kumar <...> > +++ b/doc/guides/nics/features/axgbe.ini > @@ -0,0 +1,18 @@ > +; > +; Supported features of the 'axgbe' network poll mode driver. > +; > +; Refer to default.ini for the full list of available PMD features. > +; > +[Feat

Re: [dpdk-dev] [PATCH 10/16] net/axgbe: add transmit and receive data path apis

2017-12-08 Thread Ferruh Yigit
On 11/30/2017 5:11 AM, Ravi Kumar wrote: > Signed-off-by: Ravi Kumar > --- > drivers/net/axgbe/Makefile | 1 + > drivers/net/axgbe/axgbe_ethdev.c | 56 - > drivers/net/axgbe/axgbe_rxtx.c | 427 > + > drivers/net/axgbe/axgbe_rxtx.h | 1

Re: [dpdk-dev] [PATCH 12/16] net/axgbe: add promiscuous mode support

2017-12-08 Thread Ferruh Yigit
On 11/30/2017 5:11 AM, Ravi Kumar wrote: add promisc _and_ allmulticast support... > Signed-off-by: Ravi Kumar <...>

Re: [dpdk-dev] [PATCH 09/16] net/axgbe: add DMA programming and dev start and stop apis

2017-12-08 Thread Ferruh Yigit
On 11/30/2017 5:11 AM, Ravi Kumar wrote: > Signed-off-by: Ravi Kumar <...> > +/* > + * Configure device link speed and setup link. > + * It returns 0 on success. > + */ > +static int > +axgbe_dev_configure(struct rte_eth_dev *dev) > +{ > + struct axgbe_port *pdata = dev->data->dev_private;

Re: [dpdk-dev] [PATCH 07/16] net/axgbe: add interrupt handler for autonegotiation

2017-12-08 Thread Ferruh Yigit
On 11/30/2017 5:11 AM, Ravi Kumar wrote: > Signed-off-by: Ravi Kumar <...> > +static void > +axgbe_dev_interrupt_handler(void *param) > +{ > + struct rte_eth_dev *dev = (struct rte_eth_dev *)param; > + struct axgbe_port *pdata = dev->data->dev_private; > + > + pdata->phy_if.an_isr(pd

Re: [dpdk-dev] [PATCH 04/16] net/axgbe: add structures for MAC initialization and reset

2017-12-08 Thread Ferruh Yigit
On 11/30/2017 5:11 AM, Ravi Kumar wrote: > Signed-off-by: Ravi Kumar <...> > + > + eth_dev->data->mac_addrs = rte_zmalloc("axgbe_mac_addr", > +ETHER_ADDR_LEN, 0); Can you please add equivalent free() function for this in eth_axgbe_dev_uninit()?

Re: [dpdk-dev] [PATCH 02/16] net/axgbe: add register map and related macros

2017-12-08 Thread Ferruh Yigit
On 11/30/2017 5:10 AM, Ravi Kumar wrote: > Signed-off-by: Ravi Kumar <...> > -#define HZ 250 > +#define AXGBE_HZ 250 Why not add the correct one in prev patch? <...>

Re: [dpdk-dev] [PATCH 01/16] net/axgbe: add minimal dev init and uninit support

2017-12-08 Thread Ferruh Yigit
On 11/30/2017 5:10 AM, Ravi Kumar wrote: > Signed-off-by: Ravi Kumar <...> > + /* > + * For secondary processes, we don't initialise any further as primary > + * has already done this work. > + */ > + if (rte_eal_process_type() != RTE_PROC_PRIMARY) { > + PMD_DR

Re: [dpdk-dev] [PATCH v2 1/2] ethdev: add GENEVE flow pattern item

2017-12-08 Thread Ferruh Yigit
On 12/7/2017 3:52 PM, Ferruh Yigit wrote: > On 12/4/2017 6:03 AM, Adrien Mazarguil wrote: >> On Fri, Dec 01, 2017 at 10:43:15AM +, Andrew Rybchenko wrote: >>> From: Roman Zhukov >>> >>> Add new pattern item RTE_FLOW_ITEM_TYPE_GENEVE in flow API. >>> Add default mask for the item. >>> >>> Signe

Re: [dpdk-dev] [PATCH] net: update licence for network headers

2017-12-08 Thread Andrew Rybchenko
On 12/08/2017 08:29 PM, Ferruh Yigit wrote: On 12/8/2017 2:28 AM, Olivier Matz wrote: To be compliant with the DPDK licensing guidelines, switch to BSD-3-Clause. It can be done safely since the BSD headers from which these files derive also exist as a BSD-3-Clause license in FreeBSD. Link: htt

Re: [dpdk-dev] [PATCH v3 3/4] change NXP dpaa2 code License text to SPDX tags

2017-12-08 Thread Stephen Hemminger
On Fri, 8 Dec 2017 13:11:52 +0530 Hemant Agrawal wrote: > diff --git a/drivers/bus/fslmc/fslmc_bus.c b/drivers/bus/fslmc/fslmc_bus.c > index 480857e..4a6135d 100644 > --- a/drivers/bus/fslmc/fslmc_bus.c > +++ b/drivers/bus/fslmc/fslmc_bus.c > @@ -1,33 +1,8 @@ > /*- > - * BSD LICENSE The kerne

Re: [dpdk-dev] [PATCH] net: update licence for network headers

2017-12-08 Thread Stephen Hemminger
On Fri, 8 Dec 2017 09:29:57 -0800 Ferruh Yigit wrote: > On 12/8/2017 2:28 AM, Olivier Matz wrote: > > To be compliant with the DPDK licensing guidelines, switch to > > BSD-3-Clause. It can be done safely since the BSD headers from which > > these files derive also exist as a BSD-3-Clause license

Re: [dpdk-dev] [PATCH 1/2] net/octeontx: add channel to port id mapping

2017-12-08 Thread Ferruh Yigit
On 12/8/2017 3:08 AM, Pavan Nikhilesh Bhagavatula wrote: > On Thu, Dec 07, 2017 at 04:41:04PM -0800, Ferruh Yigit wrote: >> On 11/28/2017 6:58 AM, Pavan Nikhilesh wrote: >>> The channel to port id map is used by event octeontx to map the received >>> wqe to the respective ethdev port. >>> >>> Signe

Re: [dpdk-dev] [PATCH] net: update licence for network headers

2017-12-08 Thread Ferruh Yigit
On 12/8/2017 2:28 AM, Olivier Matz wrote: > To be compliant with the DPDK licensing guidelines, switch to > BSD-3-Clause. It can be done safely since the BSD headers from which > these files derive also exist as a BSD-3-Clause license in FreeBSD. > > Link: > https://raw.githubusercontent.com/free

[dpdk-dev] [PATCHv2 3/4] Makefiles: Add experimental tag check and warnings to trigger on use

2017-12-08 Thread Neil Horman
Add checks during build to ensure that all symbols in the EXPERIMENTAL version map section have __experimental tags on their definitions, and enable the warnings needed to announce their use. Also add a ALLOW_EXPERIMENTAL_FUNCTIONS variable check to allow for in-tree dpdk libraries to override tho

[dpdk-dev] [PATCHv2 4/4] dpdk: add __experimental tag to appropriate api calls

2017-12-08 Thread Neil Horman
Append the __experimental tag to api calls appearing in the EXPERIMENTAL section of their libraries version map Signed-off-by: Neil Horman CC: Thomas Monjalon CC: "Mcnamara, John" --- lib/librte_eal/common/eal_common_dev.c | 6 ++- lib/librte_eal/common/eal_common_devargs.c

[dpdk-dev] [PATCHv2 1/4] buildtools: Add tool to check EXPERIMENTAL api exports

2017-12-08 Thread Neil Horman
This tools reads the given version map for a directory, and checks to ensure that, for each symbol listed in the export list, the corresponding definition is tagged as __experimental, erroring out if its not. In this way, we can ensure that the EXPERIMENTAL api is kept in sync with the tags Signe

[dpdk-dev] [PATCHv2 2/4] compat: Add __experimental macro

2017-12-08 Thread Neil Horman
The __experimental macro tags a given exported function as being part of the EXPERIMENTAL api. Use of this tag will cause any caller of the function (that isn't removed by dead code elimination) to emit a warning that the user is making use of an API whos stabilty isn't guaranteed. It also places

[dpdk-dev] [PATCHv2 0/4] dpdk: enhance EXPERIMENTAL api tagging

2017-12-08 Thread Neil Horman
Hey all- A few days ago, I was lamenting the fact that, when reviewing patches I would frequently complain about ABI changes that were actually considered safe because they were part of the EXPERIMENTAL api set. John M. asked me then what I might do to improve the situation, and the follow

[dpdk-dev] DPDK 16.11.4 (LTS) released

2017-12-08 Thread Luca Boccassi
Hi all, Here is a new stable release: http://fast.dpdk.org/rel/dpdk-16.11.4.tar.xz The git tree is at: http://dpdk.org/browse/dpdk-stable/ Kind regards, Luca Boccassi --- app/test-pmd/cmdline.c | 2 +- app/test-pmd/config.c

Re: [dpdk-dev] [PATCH] doc: announce ABI change for ring structure

2017-12-08 Thread Thomas Monjalon
08/12/2017 15:14, Olivier MATZ: > > +* ring: The alignment constraints on the ring structure will be relaxed > > + to one cache line instead of two, and an empty cache line padding will > > + be added between the producer and consumer structures. The size of the > > + structure and the offset of

Re: [dpdk-dev] [PATCH v2 4/6] net/representor: Implement port representor PMD

2017-12-08 Thread Mohammad Abdul Awal
On 08/12/2017 15:02, Remy Horton wrote: On 20/11/2017 07:46, Ferruh Yigit wrote: [..] Why we need this PMD? It looks like this has been used only for parameter parsing. Can it be possible to rte_representor_broker_init() will allocate ethdevs and fill brokers with this information? Possi

Re: [dpdk-dev] [PATCH v2 2/2] examples/ipsec-secgw: add target queues in flow actions

2017-12-08 Thread Anoob Joseph
HI Nelio, On 08-12-2017 20:10, Nelio Laranjeiro wrote: On Fri, Dec 08, 2017 at 07:30:03PM +0530, Anoob wrote: Hi Nelio, [...] + goto flow_create; + /* Try Queue. */ + for (i = 0; +

Re: [dpdk-dev] [PATCH v4] mbuf: fix mbuf free performance with non atomic refcnt

2017-12-08 Thread Stephen Hemminger
On Fri, 8 Dec 2017 16:46:51 +0100 Olivier Matz wrote: > +/* internal */ > +static inline uint16_t > +__rte_mbuf_refcnt_update(struct rte_mbuf *m, int16_t value) > +{ > + return (uint16_t)(rte_atomic16_add_return(&m->refcnt_atomic, value)); > +} You don't need the cast (or paren's around rte

Re: [dpdk-dev] [PATCH v4] mbuf: fix mbuf free performance with non atomic refcnt

2017-12-08 Thread Olivier MATZ
On Fri, Dec 08, 2017 at 08:04:50PM +0400, Ilya Matveychikov wrote: > Olivier, > > > On Dec 8, 2017, at 7:46 PM, Olivier Matz wrote: > > > > > > > lib/librte_mbuf/rte_mbuf.h | 23 ++- > > 1 file changed, 18 insertions(+), 5 deletions(-) > > > > diff --git a/lib/librte_mbuf/r

Re: [dpdk-dev] [PATCH v2] virtio_net: kick guest even when virtio queue is full

2017-12-08 Thread Maxime Coquelin
Hi Agota, Patrick, On 12/05/2017 12:30 PM, Agota Benyhe wrote: From: Patrik Andersson R Changing the vring call file descriptor during virtio device enqueue operation may lead to "kick" on a file descriptor that is closed. As a consequence the guest might not be notified of new packets in the e

Re: [dpdk-dev] [PATCH v4] mbuf: fix mbuf free performance with non atomic refcnt

2017-12-08 Thread Ilya Matveychikov
Olivier, > On Dec 8, 2017, at 7:46 PM, Olivier Matz wrote: > > > lib/librte_mbuf/rte_mbuf.h | 23 ++- > 1 file changed, 18 insertions(+), 5 deletions(-) > > diff --git a/lib/librte_mbuf/rte_mbuf.h b/lib/librte_mbuf/rte_mbuf.h > index ce8a05ddf..dd08cb72b 100644 > --- a/lib/

[dpdk-dev] [RFC] mbuf: remove control mbuf

2017-12-08 Thread Olivier Matz
The rte_ctrlmbuf structure is not used by any example application in dpdk. Remove it, as announced on the mailing list. Signed-off-by: Olivier Matz --- This RFC targets 18.05. If no opposition, I'll send a deprecation notice for it. doc/guides/prog_guide/glossary.rst | 3 -- doc/guides/pro

[dpdk-dev] [PATCH v4] mbuf: fix mbuf free performance with non atomic refcnt

2017-12-08 Thread Olivier Matz
When RTE_MBUF_REFCNT_ATOMIC=n, the decrement of the mbuf reference counter uses an atomic operation. This is not necessary and impacts the performance (seen with TRex traffic generator). We cannot replace rte_atomic16_add_return() by rte_mbuf_refcnt_update() because it would add an additional chec

Re: [dpdk-dev] [PATCH 3/3] logs: remove log level config option

2017-12-08 Thread Olivier MATZ
On Thu, Dec 07, 2017 at 07:37:14PM +0530, Pavan Nikhilesh Bhagavatula wrote: > Hi Oliver, > > Thanks for the review. > > On Thu, Dec 07, 2017 at 02:21:21PM +0100, Olivier MATZ wrote: > > On Wed, Nov 22, 2017 at 02:58:06PM +0530, Pavan Nikhilesh wrote: > > > --- a/test/test/test.h > > > +++ b/tes

Re: [dpdk-dev] [PATCH v2 1/6] ethdev: added switch_domain and representor port flag

2017-12-08 Thread Mohammad Abdul Awal
On 20/11/2017 19:57, Ferruh Yigit wrote: On 11/17/2017 6:42 AM, Mohammad Abdul Awal wrote: switch_domain attribute has been added to specify that a rte_eth_dev instance belongs to a switch domain in the software switch. RTE_ETH_DEV_REPRESENTOR_PORT has been defined to specify that a rte_eth_d

Re: [dpdk-dev] [PATCH v1] lib/cmdline: init parse result memory

2017-12-08 Thread Olivier MATZ
Hi, On Fri, Dec 08, 2017 at 04:04:33PM +0100, Adrien Mazarguil wrote: > On Fri, Dec 08, 2017 at 02:51:15PM +0100, Olivier MATZ wrote: > > On Fri, Dec 08, 2017 at 01:27:26PM +0100, Adrien Mazarguil wrote: > > > On Fri, Dec 08, 2017 at 03:02:44PM +0800, Xueming Li wrote: > > > > Initialize binary re

Re: [dpdk-dev] [PATCH v1] lib/cmdline: init parse result memory

2017-12-08 Thread Adrien Mazarguil
On Fri, Dec 08, 2017 at 02:51:15PM +0100, Olivier MATZ wrote: > On Fri, Dec 08, 2017 at 01:27:26PM +0100, Adrien Mazarguil wrote: > > On Fri, Dec 08, 2017 at 03:02:44PM +0800, Xueming Li wrote: > > > Initialize binary result memory before parsing to avoid garbage in > > > parsing result. > > > > >

Re: [dpdk-dev] [PATCH v2 4/6] net/representor: Implement port representor PMD

2017-12-08 Thread Remy Horton
On 20/11/2017 07:46, Ferruh Yigit wrote: [..] Why we need this PMD? It looks like this has been used only for parameter parsing. Can it be possible to rte_representor_broker_init() will allocate ethdevs and fill brokers with this information? Possible, but not sure it gains much in practice.

Re: [dpdk-dev] [PATCH v2 2/6] lib/representor: port representor library to manage broker infrastructure and representor PMDs

2017-12-08 Thread Mohammad Abdul Awal
On 17/11/2017 23:03, Ferruh Yigit wrote: On 11/17/2017 6:42 AM, Mohammad Abdul Awal wrote: diff --git a/lib/librte_representor/rte_port_representor_version.map b/lib/librte_representor/rte_port_representor_version.map new file mode 100644 index 000..09ed768 --- /dev/null +++ b/lib/librte_

Re: [dpdk-dev] [PATCH] version: 18.02-rc0

2017-12-08 Thread Mcnamara, John
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Thomas Monjalon > Sent: Thursday, November 23, 2017 10:39 PM > To: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] version: 18.02-rc0 > > The new release cycle is open, and reviews are more than welcome :) Please >

Re: [dpdk-dev] [PATCH v1] lib/cmdline: init parse result memory

2017-12-08 Thread Xueming(Steven) Li
> -Original Message- > From: Olivier MATZ [mailto:olivier.m...@6wind.com] > Sent: Friday, December 8, 2017 9:51 PM > To: Adrien Mazarguil > Cc: Xueming(Steven) Li ; Wenzhuo Lu > ; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v1] lib/cmdline: init parse result memory > > On Fri, Dec 08,

Re: [dpdk-dev] [PATCH v2 2/2] examples/ipsec-secgw: add target queues in flow actions

2017-12-08 Thread Nelio Laranjeiro
On Fri, Dec 08, 2017 at 07:30:03PM +0530, Anoob wrote: > Hi Nelio, > > [...] > > + goto flow_create; > > + /* Try Queue. */ > > + for (i = 0; > > +i < eth_dev->data->nb_rx_queues;

Re: [dpdk-dev] [PATCH] doc: announce ABI change for ring structure

2017-12-08 Thread Olivier MATZ
Hi, On Mon, Sep 11, 2017 at 03:39:13PM +0200, Olivier Matz wrote: > As discussed on the mailing list, the alignment constraint of > the ring structure can be relaxed. > > Link: http://dpdk.org/dev/patchwork/patch/25039 > Link: http://dpdk.org/dev/patchwork/patch/26103 > > Signed-off-by: Olivier

Re: [dpdk-dev] [PATCH v2 2/2] examples/ipsec-secgw: add target queues in flow actions

2017-12-08 Thread Anoob
Hi Nelio, On 12/04/2017 07:41 PM, Nelio Laranjeiro wrote: Mellanox INNOVA NIC needs to have final target queue actions to perform inline crypto. Signed-off-by: Nelio Laranjeiro --- Changes in v2: * Test the rule by PASSTHRU/RSS/QUEUE and apply the first one validated. --- examples/ipse

Re: [dpdk-dev] [PATCH v1] lib/cmdline: init parse result memory

2017-12-08 Thread Olivier MATZ
On Fri, Dec 08, 2017 at 01:27:26PM +0100, Adrien Mazarguil wrote: > On Fri, Dec 08, 2017 at 03:02:44PM +0800, Xueming Li wrote: > > Initialize binary result memory before parsing to avoid garbage in > > parsing result. > > > > Signed-off-by: Xueming Li > > Since you chose to move the break state

[dpdk-dev] [PATCH 1/2] test: rely on dynamic log level to display hexdumps

2017-12-08 Thread Olivier Matz
Instead of relying on a compile-time option, use the global log-level to decide if the hexdumps should be displayed in the tests. Valitation: # build/app/test --no-huge RTE>>crc_autotest Test OK # build/app/test --no-huge --log-level=8 RTE>>crc_autotest [many hexdumps...] Test OK

[dpdk-dev] [PATCH 2/2] test: add a testcase for dynamic logs

2017-12-08 Thread Olivier Matz
Update the logs test to also validate the dynamic log framework. For now, also keep the old way using the static USER type. Validated with: # build/app/test --no-huge ... RTE>>logs_autotest == dynamic log types error message critical message critical message error message

[dpdk-dev] [PATCH] app/testpmd: register a specific log type

2017-12-08 Thread Olivier Matz
Instead of using USERx logs, register a dynamic log type, as introduced in commit c1b5fa94a46f ("eal: support dynamic log types"). Signed-off-by: Olivier Matz --- app/test-pmd/csumonly.c | 9 - app/test-pmd/testpmd.c | 16 +++- app/test-pmd/testpmd.h | 4 3 files cha

Re: [dpdk-dev] [PATCH 2/5] ethdev: add port ownership

2017-12-08 Thread Neil Horman
On Fri, Dec 08, 2017 at 12:35:18PM +0100, Thomas Monjalon wrote: > 05/12/2017 11:05, Bruce Richardson: > > > I think you suggest to make all the ethdev configuration race safe, it > > > is behind to this thread. Current ethdev implementation leave the > > > race management to applications, so port

Re: [dpdk-dev] [PATCH v1] lib/cmdline: init parse result memory

2017-12-08 Thread Adrien Mazarguil
On Fri, Dec 08, 2017 at 03:02:44PM +0800, Xueming Li wrote: > Initialize binary result memory before parsing to avoid garbage in > parsing result. > > Signed-off-by: Xueming Li Since you chose to move the break statement, maybe the original commit mentioned in my previous message (9b3fbb051d2e "

Re: [dpdk-dev] [PATCH 2/5] ethdev: add port ownership

2017-12-08 Thread Thomas Monjalon
05/12/2017 11:05, Bruce Richardson: > > I think you suggest to make all the ethdev configuration race safe, it > > is behind to this thread. Current ethdev implementation leave the > > race management to applications, so port ownership as any other port > > configurations should be designed in the

Re: [dpdk-dev] [PATCH 1/2] net/octeontx: add channel to port id mapping

2017-12-08 Thread Pavan Nikhilesh Bhagavatula
On Thu, Dec 07, 2017 at 04:41:04PM -0800, Ferruh Yigit wrote: > On 11/28/2017 6:58 AM, Pavan Nikhilesh wrote: > > The channel to port id map is used by event octeontx to map the received > > wqe to the respective ethdev port. > > > > Signed-off-by: Pavan Nikhilesh > > <...> > > > @@ -52,12 +52,18

Re: [dpdk-dev] [PATCH 2/5] ethdev: add port ownership

2017-12-08 Thread Thomas Monjalon
05/12/2017 20:26, Neil Horman: > I get that much of dpdk relies on the fact that the application either handles > all the locking, or architects itself so that a single thread of execution (or > at least only one thread at a time), is responsible for packet processing and > port configuration. Yes

Re: [dpdk-dev] [PATCH v2 1/2] ethdev: add GENEVE flow pattern item

2017-12-08 Thread Adrien Mazarguil
On Thu, Dec 07, 2017 at 03:52:44PM -0800, Ferruh Yigit wrote: > On 12/4/2017 6:03 AM, Adrien Mazarguil wrote: > > On Fri, Dec 01, 2017 at 10:43:15AM +, Andrew Rybchenko wrote: > >> From: Roman Zhukov > >> > >> Add new pattern item RTE_FLOW_ITEM_TYPE_GENEVE in flow API. > >> Add default mask fo

[dpdk-dev] [PATCH] net: update licence for network headers

2017-12-08 Thread Olivier Matz
To be compliant with the DPDK licensing guidelines, switch to BSD-3-Clause. It can be done safely since the BSD headers from which these files derive also exist as a BSD-3-Clause license in FreeBSD. Link: https://raw.githubusercontent.com/freebsd/freebsd/78a6b0861813af31e1354fa407c5701e8764b4d6/s

[dpdk-dev] [RFC 4/4] eal: set affinity for control threads

2017-12-08 Thread Olivier Matz
The management threads must not bother the dataplane or service cores. Set the affinity of these threads accordingly. Signed-off-by: Olivier Matz --- lib/librte_eal/common/eal_common_thread.c | 20 +++- lib/librte_eal/common/include/rte_lcore.h | 4 +++- 2 files changed, 22 inse

[dpdk-dev] [RFC 1/4] eal: use sizeof to avoid a double use of a define

2017-12-08 Thread Olivier Matz
Only a cosmetic change. Signed-off-by: Olivier Matz --- lib/librte_eal/bsdapp/eal/eal.c | 2 +- lib/librte_eal/bsdapp/eal/eal_thread.c | 2 +- lib/librte_eal/linuxapp/eal/eal.c| 4 ++-- lib/librte_eal/linuxapp/eal/eal_thread.c | 2 +- 4 files changed, 5 insertions(+), 5 deleti

[dpdk-dev] [RFC 3/4] eal: set name when creating a control thread

2017-12-08 Thread Olivier Matz
To avoid code duplication, add a parameter to rte_ctrl_thread_create() to specify the name of the thread. This requires to add a wrapper for the thread start routine in rte_thread_init(), which will first wait that the thread is configured. Signed-off-by: Olivier Matz --- lib/librte_eal/common/

[dpdk-dev] [RFC 0/4] new function to create control threads

2017-12-08 Thread Olivier Matz
This patchset targets 18.05. It applies on top of 17.11 + [1] and [2]. Some parts of dpdk use their own management threads. Most of the time, the affinity of the thread is not properly set: it should not be scheduled on the dataplane cores, because interrupting them can cause packet losses. This

[dpdk-dev] [RFC 2/4] eal: new function to create control threads

2017-12-08 Thread Olivier Matz
Many parts of dpdk use their own management threads. Introduce a new wrapper for thread creation that will be extended in next commit to set the name and affinity. To be consistent with other DPDK APIs, the return value is negative in case of error, which was not the case for pthread_create(). Si

[dpdk-dev] [PATCH] pdump: fix error code check when creating/canceling pthread

2017-12-08 Thread Olivier Matz
On error, pthread_create() returns a positive number (an errno) but does not set the errno variable. Fixes: 278f945402c5 ("pdump: add new library for packet capture") Cc: sta...@dpdk.org Signed-off-by: Olivier Matz --- lib/librte_pdump/rte_pdump.c | 4 ++-- 1 file changed, 2 insertions(+), 2 de

[dpdk-dev] [PATCH] vhost: fix error code check when creating pthread

2017-12-08 Thread Olivier Matz
On error, pthread_create() returns a positive number (errno). Fix the test on the return value. Fixes: af1475918124 ("vhost: introduce API to start a specific driver") Fixes: e623e0c6d8a5 ("vhost: add reconnect ability") Cc: sta...@dpdk.org Signed-off-by: Olivier Matz --- lib/librte_vhost/socke

Re: [dpdk-dev] [PATCH 1/5] net/virtio: fix vector Rx break caused by rxq flushing

2017-12-08 Thread Kevin Traynor
On 12/08/2017 02:30 AM, Tiwei Bie wrote: > On Thu, Dec 07, 2017 at 04:00:57PM +, Kevin Traynor wrote: >> On 12/07/2017 05:30 AM, Tiwei Bie wrote: >>> The vector Rx will be broken if backend has consumed all >>> the descs in the avail ring before the device is started. >>> Because in current imp

Re: [dpdk-dev] [PATCH v1] net/tap: allow user mac to be passed as args

2017-12-08 Thread Pascal Mazon
Hi, Can you also not use a global value for user_mac, but instead change the last argument for eth_dev_tap_create(): Use directly a char mac[ETHER_ADDR_LEN], automatic variable from rte_pmd_tap_probe(). In set_mac_type(), you can check either for "fixed" or a correct custom mac address. Then eth_d

Re: [dpdk-dev] [PATCH] vhost_user: protect active rings from async ring changes

2017-12-08 Thread Maxime Coquelin
Hi Jianfeng, On 12/08/2017 09:51 AM, Tan, Jianfeng wrote: -Original Message- From: Maxime Coquelin [mailto:maxime.coque...@redhat.com] Sent: Friday, December 8, 2017 4:36 PM To: Tan, Jianfeng; Victor Kaplansky; dev@dpdk.org; y...@fridaylinux.org; Bie, Tiwei Cc: sta...@dpdk.org; jfrei.

Re: [dpdk-dev] [PATCH 1/2] net/softnic: enable flow classification function

2017-12-08 Thread Singh, Jasvinder
Hi Ferruh, > -Original Message- > From: Yigit, Ferruh > Sent: Thursday, December 7, 2017 9:03 PM > To: Singh, Jasvinder ; dev@dpdk.org > Cc: Dumitrescu, Cristian ; Thomas Monjalon > > Subject: Re: [PATCH 1/2] net/softnic: enable flow classification function > > On 11/30/2017 12:08 PM, Ja

Re: [dpdk-dev] [PATCH 0/2] net/softnic: add flow classification support

2017-12-08 Thread Singh, Jasvinder
HI Ferruh, > -Original Message- > From: Yigit, Ferruh > Sent: Thursday, December 7, 2017 9:02 PM > To: Singh, Jasvinder ; dev@dpdk.org > Cc: Dumitrescu, Cristian > Subject: Re: [PATCH 0/2] net/softnic: add flow classification support > > On 11/30/2017 12:08 PM, Jasvinder Singh wrote: > >

Re: [dpdk-dev] [PATCH] vhost_user: protect active rings from async ring changes

2017-12-08 Thread Tan, Jianfeng
> -Original Message- > From: Maxime Coquelin [mailto:maxime.coque...@redhat.com] > Sent: Friday, December 8, 2017 4:36 PM > To: Tan, Jianfeng; Victor Kaplansky; dev@dpdk.org; y...@fridaylinux.org; Bie, > Tiwei > Cc: sta...@dpdk.org; jfrei...@redhat.com > Subject: Re: [PATCH] vhost_user: p

Re: [dpdk-dev] [PATCH] vhost_user: protect active rings from async ring changes

2017-12-08 Thread Maxime Coquelin
On 12/08/2017 03:14 AM, Tan, Jianfeng wrote: -Original Message- From: Maxime Coquelin [mailto:maxime.coque...@redhat.com] Sent: Thursday, December 7, 2017 6:02 PM To: Tan, Jianfeng; Victor Kaplansky; dev@dpdk.org; y...@fridaylinux.org; Bie, Tiwei Cc: sta...@dpdk.org; jfrei...@redhat.

[dpdk-dev] [RFC v1 9/9] doc/scapy: add scapy how-to guide

2017-12-08 Thread Xueming Li
Signed-off-by: Xueming Li --- doc/guides/howto/scapy.rst | 300 + 1 file changed, 300 insertions(+) create mode 100644 doc/guides/howto/scapy.rst diff --git a/doc/guides/howto/scapy.rst b/doc/guides/howto/scapy.rst new file mode 100644 index 0

[dpdk-dev] [RFC v1 8/9] test/expect: add expect test scripts

2017-12-08 Thread Xueming Li
Please enable python module to run thesse scripts --- test/expect/init.exp | 28 +++ test/expect/rx.exp | 134 +++ 2 files changed, 162 insertions(+) create mode 100644 test/expect/init.exp create mode 100644 test/expect/rx.exp diff --g

[dpdk-dev] [RFC v1 6/9] app/testpmd: add pktgen forwarding engine

2017-12-08 Thread Xueming Li
Add new "pktgen" forwarding engine that send and receive packets acoording to pktgen_task instruction. Signed-off-by: Xueming Li --- app/test-pmd/Makefile | 1 + app/test-pmd/cmdline.c | 3 + app/test-pmd/pktgen.c | 605 + app/test-pmd/testpm

[dpdk-dev] [RFC v1 5/9] app/testpmd: add python command

2017-12-08 Thread Xueming Li
py shell: invoke python shell, Ctrl+d to quit py : run python clause Signed-off-by: Xueming Li Conflicts: app/test-pmd/cmdline.c --- app/test-pmd/cmdline.c | 60 ++ 1 file changed, 60 insertions(+) diff --git a/app/test-pmd/cmdline.c b/ap

[dpdk-dev] [RFC v1 7/9] app/testpmd: add pktgen engine scapy commands

2017-12-08 Thread Xueming Li
new commands: tx: send packets rx: receive packets expect: send and expect back Signed-off-by: Xueming Li Conflicts: app/test-pmd/Makefile app/test-pmd/testpmd.h --- app/test-pmd/Makefile | 5 + app/test-pmd/cmdline.c | 14 +- app/test-pmd/pktgen.c | 493 +++

[dpdk-dev] [RFC v1 2/9] app/testpmd: support command echo in CLI batch loading

2017-12-08 Thread Xueming Li
Use first bit of verbose_level to enable CLI echo of batch loading. Signed-off-by: Xueming Li --- app/test-pmd/cmdline.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c index f71d96301..4acce9f07 100644 --- a/app/test-pmd/cmdl

[dpdk-dev] [RFC v1 0/9] scapy/python extension

2017-12-08 Thread Xueming Li
This patch introduced a set of new elements into DPDK: 1. python/scapy as a standard dpdk library, disabled by default. Could be used by any application to integrate powerful python features. 2. tx, rx and expect, blocking mode testpmd CLI command tx command send packets with scapy syntax tem

[dpdk-dev] [RFC v1 1/9] lib/cmdline: add echo support in batch loading from file

2017-12-08 Thread Xueming Li
Add echo option to echo commandline to screen when running loaded scripts from file. Signed-off-by: Xueming Li --- lib/librte_cmdline/cmdline_socket.c | 5 +++-- lib/librte_cmdline/cmdline_socket.h | 3 ++- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/lib/librte_cmdline/cmdline

[dpdk-dev] [RFC v1 4/9] lib/python: add embedded python lib

2017-12-08 Thread Xueming Li
Add embedded python lib to support following: 1. Generate packet using scapy syntax 2. Dump packet content with scapy 3. Run python cmd 4. Interactive shell Conflicts: lib/Makefile lib/librte_eal/common/include/rte_log.h --- config/common_base | 6 + lib/Ma

[dpdk-dev] [RFC v1 3/9] test: update batch loading test

2017-12-08 Thread Xueming Li
Support echo back in batch loading. Signed-off-by: Xueming Li --- test/test/test_cmdline_lib.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/test/test/test_cmdline_lib.c b/test/test/test_cmdline_lib.c index 65b823a72..c700671d1 100644 --- a/test/test/test_cmdline