Re: [dpdk-dev] [PATCH v3] arch/arm: optimization for memcpy on AArch64

2017-12-18 Thread Jerin Jacob
-Original Message- > Date: Tue, 19 Dec 2017 05:33:19 + > From: Herbert Guan > To: Jerin Jacob > CC: "dev@dpdk.org" , nd > Subject: RE: [PATCH v3] arch/arm: optimization for memcpy on AArch64 > > Jerin, > > Thanks for review and comments. Please find my feedbacks below inline. > >

Re: [dpdk-dev] [PATCH] igb: fix Tx queue number

2017-12-18 Thread Zhang, Helin
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of zhouyangchao > Sent: Wednesday, November 29, 2017 10:50 AM > To: dev@dpdk.org > Cc: Lu, Wenzhuo > Subject: [dpdk-dev] [PATCH] igb: fix Tx queue number Basically please follow the style of 'net/igb:', thanks! /Hel

Re: [dpdk-dev] [PATCH 4/6] event/dpaa: add eventdev PMD

2017-12-18 Thread Sunil Kumar Kori
Hi Jerin, > -Original Message- > From: Jerin Jacob [mailto:jerin.ja...@caviumnetworks.com] > Sent: 16 December, 2017 6:07 PM > To: Sunil Kumar Kori > Cc: dev@dpdk.org; Hemant Agrawal > Subject: Re: [PATCH 4/6] event/dpaa: add eventdev PMD > > -Original Message- > > Date: Fri, 1

[dpdk-dev] [PATCH v2] igb_uio: allow multi-process access

2017-12-18 Thread Xiao Wang
In some case, one device are accessed by different processes via different BARs, so one uio device may be opened by more than one process, for this case we just need to enable interrupt once, and pci_clear_master only when the last process closed. Fixes: 5f6ff30dc507 ("igb_uio: fix interrupt enabl

[dpdk-dev] [PATCH 11/11] lio: implement dynamic logging

2017-12-18 Thread Stephen Hemminger
This driver mostly uses the common pattern. Convert this to the dynamic logging. Signed-off-by: Stephen Hemminger --- config/common_base| 2 -- drivers/net/liquidio/lio_ethdev.c | 15 +++ drivers/net/liquidio/lio_logs.h | 20 3 files changed, 2

[dpdk-dev] [PATCH 10/11] qede: implement dynamic logging

2017-12-18 Thread Stephen Hemminger
This driver is mostly like others with slightly different logging macros. The semantics were retained, with some minor reformatting. Signed-off-by: Stephen Hemminger --- config/common_base | 2 -- drivers/net/qede/qede_ethdev.c | 15 drivers/net/qede/qede_logs.h | 53

[dpdk-dev] [PATCH 06/11] virtio: implement dynamic logging

2017-12-18 Thread Stephen Hemminger
Signed-off-by: Stephen Hemminger --- config/common_base | 2 -- drivers/net/virtio/virtio_ethdev.c | 15 +++ drivers/net/virtio/virtio_logs.h | 19 +++ 3 files changed, 22 insertions(+), 14 deletions(-) diff --git a/config/common_base b/config/commo

[dpdk-dev] [PATCH 08/11] fm10k: implement dynamic logging

2017-12-18 Thread Stephen Hemminger
Signed-off-by: Stephen Hemminger --- config/common_base | 2 -- drivers/net/fm10k/fm10k_ethdev.c | 15 +++ drivers/net/fm10k/fm10k_logs.h | 16 ++-- 3 files changed, 21 insertions(+), 12 deletions(-) diff --git a/config/common_base b/config/common_base in

[dpdk-dev] [PATCH 05/11] e1000: implement dynamic logging

2017-12-18 Thread Stephen Hemminger
Signed-off-by: Stephen Hemminger --- config/common_base | 2 -- drivers/net/e1000/e1000_logs.h | 16 ++-- drivers/net/e1000/em_ethdev.c | 15 +++ 3 files changed, 21 insertions(+), 12 deletions(-) diff --git a/config/common_base b/config/common_base index 33

[dpdk-dev] [PATCH 09/11] ena: implement dynamic logging

2017-12-18 Thread Stephen Hemminger
Use dynamic rather static configuration for logging. Also include ena_assert_msg. Signed-off-by: Stephen Hemminger --- config/common_base | 1 - drivers/net/ena/ena_ethdev.c | 15 +++ drivers/net/ena/ena_logs.h | 14 ++ drivers/net/ena/ena_platform.h |

[dpdk-dev] [PATCH 07/11] nfp: implement dynamic logging

2017-12-18 Thread Stephen Hemminger
Signed-off-by: Stephen Hemminger --- config/common_base | 3 ++- drivers/net/nfp/nfp_net.c | 14 ++ drivers/net/nfp/nfp_net_logs.h | 22 ++ 3 files changed, 22 insertions(+), 17 deletions(-) diff --git a/config/common_base b/config/common_base in

[dpdk-dev] [PATCH 04/11] ixgbe: implement dynamic logging

2017-12-18 Thread Stephen Hemminger
Convert all drivers possible to dynamic logging. Signed-off-by: Stephen Hemminger --- config/common_base | 2 -- drivers/net/ixgbe/ixgbe_ethdev.c | 15 +++ drivers/net/ixgbe/ixgbe_logs.h | 16 ++-- 3 files changed, 21 insertions(+), 12 deletions(-) diff

[dpdk-dev] [PATCH 02/11] bnx2x: implement dynamic logging

2017-12-18 Thread Stephen Hemminger
Replace compile time option for init and driver log with dynamic value. Signed-off-by: Stephen Hemminger --- config/common_base | 2 -- doc/guides/nics/bnx2x.rst| 8 drivers/net/bnx2x/bnx2x_ethdev.c | 15 +++ drivers/net/bnx2x/bnx2x_logs.h | 17

[dpdk-dev] [PATCH 03/11] vmxnet3: implement dynamic logging

2017-12-18 Thread Stephen Hemminger
Replace compile time configuration with runtime. Signed-off-by: Stephen Hemminger --- config/common_base | 2 -- drivers/net/vmxnet3/vmxnet3_ethdev.c | 15 +++ drivers/net/vmxnet3/vmxnet3_logs.h | 17 ++--- 3 files changed, 21 insertions(+), 13 deleti

[dpdk-dev] [PATCH 00/11] Dynamic logging (just do it)

2017-12-18 Thread Stephen Hemminger
This patch set implements dynamic logging for 11 drivers. All these patches are compile tested only. I don't have access to most of this hardware. It makes more sense to "just do it" for dynamic logging rather than keeping TODO lists in the documentation and expecting the vendors to fix their own

[dpdk-dev] [PATCH 01/11] avp: implement dynamic logging

2017-12-18 Thread Stephen Hemminger
All PMD should be using dynamic log levels. Signed-off-by: Stephen Hemminger --- config/common_base | 1 - drivers/net/avp/avp_ethdev.c | 10 ++ drivers/net/avp/avp_logs.h | 9 - 3 files changed, 14 insertions(+), 6 deletions(-) diff --git a/config/common_base b/co

Re: [dpdk-dev] [PATCH v5 2/3] examples/ipsec-secgw: add target queues in flow actions

2017-12-18 Thread Anoob Joseph
On 12/18/2017 03:54 PM, Nelio Laranjeiro wrote: Mellanox INNOVA NIC needs to have final target queue actions to perform inline crypto. Signed-off-by: Nelio Laranjeiro Acked-by: Anoob Joseph --- Changes in v5: * Add back default second action. Changes in v4: * remove Egress code.

Re: [dpdk-dev] [RFC v3 0/1] Compression API in DPDK

2017-12-18 Thread Verma, Shally
> -Original Message- > From: Ahmed Mansour [mailto:ahmed.mans...@nxp.com] > Sent: 19 December 2017 02:37 > To: dev@dpdk.org; Verma, Shally ; Hemant > Agrawal > Cc: Hemant Agrawal ; Challa, Mahipal > ; fiona.tr...@intel.com; Athreya, Narayana > Prasad ; > pablo.de.lara.gua...@intel.com; R

Re: [dpdk-dev] [PATCH v2] doc: announce ABI change for pktmbuf pool create API

2017-12-18 Thread Hemant Agrawal
On 12/18/2017 7:21 PM, Wiles, Keith wrote: On Dec 15, 2017, at 4:41 AM, Hemant Agrawal wrote: Introduce a new argument ops_name in rte_mempool_set_ops_byname for allowing the application to optionally specify the mempool ops. Signed-off-by: Hemant Agrawal --- v2: fix checkpatch error doc/

Re: [dpdk-dev] [PATCH v3] arch/arm: optimization for memcpy on AArch64

2017-12-18 Thread Herbert Guan
Jerin, Thanks for review and comments. Please find my feedbacks below inline. > -Original Message- > From: Jerin Jacob [mailto:jerin.ja...@caviumnetworks.com] > Sent: Monday, December 18, 2017 15:44 > To: Herbert Guan > Cc: dev@dpdk.org > Subject: Re: [PATCH v3] arch/arm: optimization f

Re: [dpdk-dev] [PATCH v4 2/4] change root makefile license to SPDX tag

2017-12-18 Thread Hemant Agrawal
On 12/18/2017 10:00 PM, Thomas Monjalon wrote: 18/12/2017 16:52, Bruce Richardson: On Mon, Dec 18, 2017 at 06:09:02PM +0530, Hemant Agrawal wrote: --- a/GNUmakefile +++ b/GNUmakefile @@ -1,33 +1,6 @@ -# BSD LICENSE +# SPDX-License-Identifier: BSD-3-Clause # # Copyright(c) 2010-2015 Intel

Re: [dpdk-dev] [PATCH] doc: convert license headers to SPDX tags for NIC docs

2017-12-18 Thread Hemant Agrawal
+ Jerin (Cavium), Oliver (6 Wind) Hi Ferruh, You have also modified the license header for Cavium and 6 Wind copyright files. This patch will need an explicit ack from Cavium and 6 Wind. regards, Hemant On 12/19/2017 2:37 AM, Ferruh Yigit wrote: Signed-off-by: Ferruh Yigit --- doc/guides/

Re: [dpdk-dev] [PATCH] net/pcap: convert license headers to SPDX tags

2017-12-18 Thread Hemant Agrawal
HI Ferruh, On 12/19/2017 2:48 AM, Ferruh Yigit wrote: On 12/18/2017 1:06 PM, Ferruh Yigit wrote: Signed-off-by: Ferruh Yigit <...> + * SPDX-License-Identifier: BSD-3-Clause + * Copyright(c) 2010-2016 Intel Corporation. All rights reserved. + * Copyright(c) 2014 6WIND S.A. + * All rights re

[dpdk-dev] [PATCH] net/i40e: enable VF TSO function

2017-12-18 Thread Beilei Xing
I40E VF supports HW TSO, this patch enables VF TSO function. Signed-off-by: Beilei Xing --- drivers/net/i40e/i40e_ethdev_vf.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/net/i40e/i40e_ethdev_vf.c b/drivers/net/i40e/i40e_ethdev_vf.c index 91b5bb0..b0b724c 1

Re: [dpdk-dev] [PATCH v1 2/3] net/hyperv: implement core functionality

2017-12-18 Thread Ferruh Yigit
On 12/18/2017 8:46 AM, Adrien Mazarguil wrote: > As described in more details in the attached documentation (see patch > contents), this virtual device driver manages NetVSC interfaces in virtual > machines hosted by Hyper-V/Azure platforms. > > This driver does not manage traffic nor Ethernet dev

Re: [dpdk-dev] [PATCH v1 0/3] Introduce virtual PMD for Hyper-V/Azure platforms

2017-12-18 Thread Stephen Hemminger
On Mon, Dec 18, 2017 at 12:13 PM, Thomas Monjalon wrote: > 18/12/2017 19:23, Stephen Hemminger: > > Please don't call this drivers/net/hyperv/ > > that name conflicts with the real netvsc PMD that I am working on. > > > > Maybe vdev-netvsc? > > I expect your PMD to be in drivers/net/netvsc/ > Why

Re: [dpdk-dev] [PATCH v2] igb_uio: convert license headers to SPDX tags

2017-12-18 Thread Ferruh Yigit
On 12/18/2017 4:10 PM, Stephen Hemminger wrote: > On Tue, 19 Dec 2017 00:03:14 + > Ferruh Yigit wrote: > >> +# SPDX-License-Identifier: BSD-3-Clause >> +# Copyright(c) 2010-2017 Intel Corporation. All rights reserved. >> > > It doesn't matter much, but it seems odd that Makefile is BSD-3-C

Re: [dpdk-dev] [PATCH v2] igb_uio: convert license headers to SPDX tags

2017-12-18 Thread Stephen Hemminger
On Tue, 19 Dec 2017 00:03:14 + Ferruh Yigit wrote: > +# SPDX-License-Identifier: BSD-3-Clause > +# Copyright(c) 2010-2017 Intel Corporation. All rights reserved. > It doesn't matter much, but it seems odd that Makefile is BSD-3-Clause but the kernel driver itself is GPL-2.0. Wouldn't it

[dpdk-dev] [PATCH v2 2/2] net/kni: convert license headers to SPDX tags

2017-12-18 Thread Ferruh Yigit
Signed-off-by: Ferruh Yigit --- doc/guides/nics/kni.rst | 29 + drivers/net/kni/Makefile | 31 ++- drivers/net/kni/rte_eth_kni.c | 32 ++-- 3 files changed, 5 insertions(+), 87 deletions(-) diff --git

[dpdk-dev] [PATCH v2 1/2] kni: convert license headers to SPDX tags

2017-12-18 Thread Ferruh Yigit
Signed-off-by: Ferruh Yigit --- v2: * follow Linux kernel standard for Linux kernel module source files --- doc/guides/prog_guide/kernel_nic_interface.rst | 29 +-- doc/guides/sample_app_ug/kernel_nic_interface.rst | 29 +-- examples/kni/Makefile

[dpdk-dev] [PATCH v2] igb_uio: convert license headers to SPDX tags

2017-12-18 Thread Ferruh Yigit
Signed-off-by: Ferruh Yigit --- v2: * follow Linux kernel standard for Linux kernel module source files --- lib/librte_eal/linuxapp/igb_uio/Makefile | 32 ++- lib/librte_eal/linuxapp/igb_uio/igb_uio.c | 23 ++ 2 files changed, 4 insertions(+), 51 d

Re: [dpdk-dev] [PATCH v1 2/3] net/hyperv: implement core functionality

2017-12-18 Thread Stephen Hemminger
On Mon, 18 Dec 2017 17:46:23 +0100 Adrien Mazarguil wrote: > +static int > +ether_addr_from_str(struct ether_addr *eth_addr, const char *str) > +{ > + static const uint8_t conv[0x100] = { > + ['0'] = 0x80, ['1'] = 0x81, ['2'] = 0x82, ['3'] = 0x83, > + ['4'] = 0x84, ['5

Re: [dpdk-dev] [PATCH] igb_uio: convert license headers to SPDX tags

2017-12-18 Thread Stephen Hemminger
On Mon, 18 Dec 2017 15:08:06 -0800 Ferruh Yigit wrote: > OK, I will update. > > Is there any benefit of following Linux kernel standard not only for kernel > modules but for all DPDK files? Nothing immediate, since SPDX usage is so new. But I expect that there will be tools and scripts that sca

Re: [dpdk-dev] [PATCH] igb_uio: convert license headers to SPDX tags

2017-12-18 Thread Ferruh Yigit
On 12/18/2017 2:13 PM, Stephen Hemminger wrote: > On Mon, 18 Dec 2017 21:06:58 + > Ferruh Yigit wrote: > >> diff --git a/lib/librte_eal/linuxapp/igb_uio/igb_uio.c >> b/lib/librte_eal/linuxapp/igb_uio/igb_uio.c >> index a3a98c173..d0e4fd966 100644 >> --- a/lib/librte_eal/linuxapp/igb_uio/igb_

Re: [dpdk-dev] [PATCH] [RFC] ether: standardize getting the port by name

2017-12-18 Thread Thomas Monjalon
Let's summarize and resume this thread. We need a generic syntax to describe a device. This syntax can be used - before initializing the device (i.e. whitelist/blacklist) - or after the initialization (e.g. user config) We need to answer 4 questions: 1/ what are the separators (co

Re: [dpdk-dev] [PATCH] [RFC] ether: standardize getting the port by name

2017-12-18 Thread Thomas Monjalon
18/12/2017 23:30, Stephen Hemminger: > On Mon, 18 Dec 2017 23:25:37 +0100 > Thomas Monjalon wrote: > > > 05/12/2017 14:20, Thomas Monjalon: > > > 05/12/2017 12:04, Adrien Mazarguil: > > > > Just for information, this "port=x" argument in mlx4 is consistent with > > > > the > > > > value found

Re: [dpdk-dev] [PATCH] [RFC] ether: standardize getting the port by name

2017-12-18 Thread Stephen Hemminger
On Mon, 18 Dec 2017 23:25:37 +0100 Thomas Monjalon wrote: > 05/12/2017 14:20, Thomas Monjalon: > > 05/12/2017 12:04, Adrien Mazarguil: > > > Just for information, this "port=x" argument in mlx4 is consistent with > > > the > > > value found in /sys/class/net/ethX/dev_port under Linux. If we ch

Re: [dpdk-dev] [PATCH] [RFC] ether: standardize getting the port by name

2017-12-18 Thread Thomas Monjalon
05/12/2017 14:20, Thomas Monjalon: > 05/12/2017 12:04, Adrien Mazarguil: > > Just for information, this "port=x" argument in mlx4 is consistent with the > > value found in /sys/class/net/ethX/dev_port under Linux. If we choose to use > > a port index (instead of a MAC or something else), it would m

Re: [dpdk-dev] [PATCH] igb_uio: convert license headers to SPDX tags

2017-12-18 Thread Stephen Hemminger
On Mon, 18 Dec 2017 21:06:58 + Ferruh Yigit wrote: > diff --git a/lib/librte_eal/linuxapp/igb_uio/igb_uio.c > b/lib/librte_eal/linuxapp/igb_uio/igb_uio.c > index a3a98c173..d0e4fd966 100644 > --- a/lib/librte_eal/linuxapp/igb_uio/igb_uio.c > +++ b/lib/librte_eal/linuxapp/igb_uio/igb_uio.c >

Re: [dpdk-dev] [PATCH 2/2] mempool/octeontx: clean up memory area registration

2017-12-18 Thread Pavan Nikhilesh
On Mon, Dec 18, 2017 at 10:30:59AM +0530, santosh wrote: > > On Friday 15 December 2017 09:30 PM, Pavan Nikhilesh wrote: > > Clean up dependency between alloc and memory area registration, this > > removes the need for SLIST data structure and octeontx_pool_list. > > > > Signed-off-by: Pavan Nikhil

Re: [dpdk-dev] [PATCH v2 1/2] net/octeontx: add channel to port id mapping

2017-12-18 Thread Pavan Nikhilesh
On Mon, Dec 18, 2017 at 03:11:15PM +0530, santosh wrote: > > On Saturday 09 December 2017 06:25 PM, Pavan Nikhilesh wrote: > > The channel to port id map is used by event octeontx to map the received > > wqe to the respective ethdev port. > > > > Signed-off-by: Pavan Nikhilesh > > --- > > > > v2

[dpdk-dev] [PATCH v2 11/12] app/eventdev: add pipeline atq worker functions

2017-12-18 Thread Pavan Nikhilesh
Signed-off-by: Pavan Nikhilesh --- app/test-eventdev/test_pipeline_atq.c | 354 +- 1 file changed, 353 insertions(+), 1 deletion(-) diff --git a/app/test-eventdev/test_pipeline_atq.c b/app/test-eventdev/test_pipeline_atq.c index f625b04b1..6507ac911 100644 --- a/

[dpdk-dev] [PATCH v2 10/12] app/eventdev: add pipeline atq test

2017-12-18 Thread Pavan Nikhilesh
This is a pipeline test case that aims at testing the following with ``all types queue`` eventdev scheme. 1. Measure the end-to-end performance of an event dev with a ethernet dev. 2. Maintain packet ordering from Rx to Tx. The atq queue test functions as same as ``pipeline_queue`` test. The diffe

[dpdk-dev] [PATCH v2 09/12] app/eventdev: add pipeline queue worker functions

2017-12-18 Thread Pavan Nikhilesh
Signed-off-by: Pavan Nikhilesh --- app/test-eventdev/test_pipeline_common.h | 80 +++ app/test-eventdev/test_pipeline_queue.c | 367 ++- 2 files changed, 446 insertions(+), 1 deletion(-) diff --git a/app/test-eventdev/test_pipeline_common.h b/app/test-eventdev/

[dpdk-dev] [PATCH v2 08/12] app/eventdev: add pipeline queue test

2017-12-18 Thread Pavan Nikhilesh
This is a pipeline queue test case that aims at testing the following: 1. Measure the end-to-end performance of an event dev with a ethernet dev. 2. Maintain packet ordering from Rx to Tx. The pipeline queue test configures the eventdev with Q queues and P ports, where Q is (nb_ethdev * nb_stages)

[dpdk-dev] [PATCH v2 07/12] app/eventdev: launch pipeline lcores

2017-12-18 Thread Pavan Nikhilesh
The event master lcore's test termination and the logic to print the mpps are common for the queue and all types queue test. Move them as the common function. Signed-off-by: Pavan Nikhilesh --- app/test-eventdev/test_pipeline_common.c | 64 app/test-eventdev/tes

[dpdk-dev] [PATCH v2 06/12] app/eventdev: add event port setup and Rx adapter setup

2017-12-18 Thread Pavan Nikhilesh
Setup one port per worker and link to all queues and setup producer port based on Rx adapter capabilities. Signed-off-by: Pavan Nikhilesh --- app/test-eventdev/test_pipeline_common.c | 102 +++ app/test-eventdev/test_pipeline_common.h | 4 ++ 2 files changed, 106 in

[dpdk-dev] [PATCH v2 04/12] app/eventdev: add pipeline opt dump and check functions

2017-12-18 Thread Pavan Nikhilesh
Signed-off-by: Pavan Nikhilesh --- app/test-eventdev/test_pipeline_common.c | 84 app/test-eventdev/test_pipeline_common.h | 3 ++ 2 files changed, 87 insertions(+) diff --git a/app/test-eventdev/test_pipeline_common.c b/app/test-eventdev/test_pipeline_common.c

[dpdk-dev] [PATCH v2 05/12] app/eventdev: add perf ethport setup and destroy

2017-12-18 Thread Pavan Nikhilesh
Add common ethdev port setup and destroy along with event dev destroy. Signed-off-by: Pavan Nikhilesh --- app/test-eventdev/test_pipeline_common.c | 98 app/test-eventdev/test_pipeline_common.h | 3 + 2 files changed, 101 insertions(+) diff --git a/app/test-eve

[dpdk-dev] [PATCH v2 02/12] app/eventdev: add pipeline test setup and destroy

2017-12-18 Thread Pavan Nikhilesh
Pipeline test has the queue and all types queue variants. Introduce test_pipeline_common* to share the common code between those tests. Signed-off-by: Pavan Nikhilesh --- app/test-eventdev/Makefile | 2 + app/test-eventdev/test_pipeline_common.c | 71 +++ a

[dpdk-dev] [PATCH v2 03/12] app/eventdev: add mempool setup and destroy

2017-12-18 Thread Pavan Nikhilesh
Signed-off-by: Pavan Nikhilesh --- app/test-eventdev/test_pipeline_common.c | 29 + app/test-eventdev/test_pipeline_common.h | 2 ++ 2 files changed, 31 insertions(+) diff --git a/app/test-eventdev/test_pipeline_common.c b/app/test-eventdev/test_pipeline_common.c in

[dpdk-dev] [PATCH v2 01/12] app/eventdev: add packet distribution logs

2017-12-18 Thread Pavan Nikhilesh
Add logs for packet distribution across worker cores to be printed along with the test results. Signed-off-by: Pavan Nikhilesh Acked-by: Jerin Jacob --- app/test-eventdev/evt_main.c | 3 +++ app/test-eventdev/test_perf_common.c | 12 2 files changed, 15 insertions(+) diff

Re: [dpdk-dev] [RFC v3 1/1] lib: add compressdev API

2017-12-18 Thread Ahmed Mansour
On 12/15/2017 11:19 PM, Trahe, Fiona wrote: .. > + > +/** Compression Algorithms */ > +enum rte_comp_algorithm { > + RTE_COMP_NULL = 0, > + /**< No compression. > + * Pass-through, data is copied unchanged from source buffer to > + * destination buffer. > + */ > + RTE_C

Re: [dpdk-dev] [PATCH] net/pcap: convert license headers to SPDX tags

2017-12-18 Thread Thomas Monjalon
18/12/2017 22:18, Ferruh Yigit: > On 12/18/2017 1:06 PM, Ferruh Yigit wrote: > > Signed-off-by: Ferruh Yigit > > <...> > > > + * SPDX-License-Identifier: BSD-3-Clause > > + * Copyright(c) 2010-2016 Intel Corporation. All rights reserved. > > + * Copyright(c) 2014 6WIND S.A. > > + * All rights re

Re: [dpdk-dev] [PATCH v1 2/3] net/hyperv: implement core functionality

2017-12-18 Thread Stephen Hemminger
On Mon, 18 Dec 2017 22:03:55 +0100 Thomas Monjalon wrote: > > > > Good question. For the following reasons: > > > > - I forgot about the existence of ether_ntoa() and didn't look it up seeing > > struct ether_addr is (re-)defined by rte_ether.h. What happens when one > > includes netinet/et

Re: [dpdk-dev] [PATCH] net/pcap: convert license headers to SPDX tags

2017-12-18 Thread Ferruh Yigit
On 12/18/2017 1:06 PM, Ferruh Yigit wrote: > Signed-off-by: Ferruh Yigit <...> > + * SPDX-License-Identifier: BSD-3-Clause > + * Copyright(c) 2010-2016 Intel Corporation. All rights reserved. > + * Copyright(c) 2014 6WIND S.A. > + * All rights reserved. > */ Hi Hemant, Thomas, Can you please

Re: [dpdk-dev] [PATCH v1 1/3] net/hyperv: introduce MS Hyper-V platform driver

2017-12-18 Thread Stephen Hemminger
On Mon, 18 Dec 2017 20:54:16 +0100 Thomas Monjalon wrote: > > > +#endif /* RTE_LIBRTE_HYPERV_DEBUG */ > > > + > > > +#define DEBUG(...) PMD_DRV_LOG(DEBUG, __VA_ARGS__) > > > +#define INFO(...) PMD_DRV_LOG(INFO, __VA_ARGS__) > > > +#define WARN(...) PMD_DRV_LOG(WARNING, __VA_ARGS__) > > > +#define

[dpdk-dev] [PATCH] doc: convert license headers to SPDX tags for NIC docs

2017-12-18 Thread Ferruh Yigit
Signed-off-by: Ferruh Yigit --- doc/guides/nics/build_and_test.rst | 28 +--- doc/guides/nics/features.rst | 29 + doc/guides/nics/overview.rst | 28 +--- 3 files changed, 3 insertions(+), 82 deletions(-) dif

[dpdk-dev] [PATCH] igb_uio: convert license headers to SPDX tags

2017-12-18 Thread Ferruh Yigit
Signed-off-by: Ferruh Yigit --- lib/librte_eal/linuxapp/igb_uio/Makefile | 32 ++- lib/librte_eal/linuxapp/igb_uio/igb_uio.c | 23 ++ 2 files changed, 4 insertions(+), 51 deletions(-) diff --git a/lib/librte_eal/linuxapp/igb_uio/Makefile b/lib/li

[dpdk-dev] [PATCH 2/2] net/kni: convert license headers to SPDX tags

2017-12-18 Thread Ferruh Yigit
Signed-off-by: Ferruh Yigit --- doc/guides/nics/kni.rst | 29 + drivers/net/kni/Makefile | 31 ++- drivers/net/kni/rte_eth_kni.c | 32 ++-- 3 files changed, 5 insertions(+), 87 deletions(-) diff --git

[dpdk-dev] [PATCH 1/2] kni: convert license headers to SPDX tags

2017-12-18 Thread Ferruh Yigit
Signed-off-by: Ferruh Yigit --- doc/guides/prog_guide/kernel_nic_interface.rst | 29 +-- doc/guides/sample_app_ug/kernel_nic_interface.rst | 29 +-- examples/kni/Makefile | 32 +--- examples/kni/main.c| 32 +

Re: [dpdk-dev] [RFC v3 0/1] Compression API in DPDK

2017-12-18 Thread Ahmed Mansour
Hi Fiona, On 12/15/2017 11:16 PM, Trahe, Fiona wrote: > With the vast amounts of data being transported around networks and stored in > storage systems, reducing data size is becoming ever more important. There > are both software libraries and hardware devices available that provide > compressio

[dpdk-dev] [PATCH] net/pcap: convert license headers to SPDX tags

2017-12-18 Thread Ferruh Yigit
Signed-off-by: Ferruh Yigit --- doc/guides/nics/pcap_ring.rst | 29 + drivers/net/pcap/Makefile | 35 --- drivers/net/pcap/rte_eth_pcap.c | 35 --- 3 files changed, 9 insertions(+), 90 deletions(-)

Re: [dpdk-dev] [PATCH v1 2/3] net/hyperv: implement core functionality

2017-12-18 Thread Thomas Monjalon
18/12/2017 21:21, Adrien Mazarguil: > On Mon, Dec 18, 2017 at 10:26:29AM -0800, Stephen Hemminger wrote: > > On Mon, 18 Dec 2017 17:46:23 +0100 > > Adrien Mazarguil wrote: > > > > > +static int > > > +ether_addr_from_str(struct ether_addr *eth_addr, const char *str) > > > +{ > > > + static const

Re: [dpdk-dev] [PATCH v1 1/3] net/hyperv: introduce MS Hyper-V platform driver

2017-12-18 Thread Thomas Monjalon
18/12/2017 19:28, Stephen Hemminger: > On Mon, 18 Dec 2017 17:46:21 +0100 > Adrien Mazarguil wrote: > > > +#ifdef RTE_LIBRTE_HYPERV_DEBUG > > + > > +#define PMD_DRV_LOG(level, ...) \ > > + RTE_LOG(level, PMD, \ > > + RTE_FMT("%s:%u: %s(): " RTE_FMT_HEAD(__VA_ARGS__,) "\n", \ > > +

Re: [dpdk-dev] [PATCH v1 2/3] net/hyperv: implement core functionality

2017-12-18 Thread Adrien Mazarguil
On Mon, Dec 18, 2017 at 10:34:12AM -0800, Stephen Hemminger wrote: > On Mon, 18 Dec 2017 17:46:23 +0100 > Adrien Mazarguil wrote: > > > > > /** > > + * Destroy a hyperv context instance. > > + * > > + * @param ctx > > + * Context to destroy. > > + */ > > +static void > > +hyperv_ctx_destroy(

Re: [dpdk-dev] [PATCH v1 2/3] net/hyperv: implement core functionality

2017-12-18 Thread Adrien Mazarguil
On Mon, Dec 18, 2017 at 10:26:29AM -0800, Stephen Hemminger wrote: > On Mon, 18 Dec 2017 17:46:23 +0100 > Adrien Mazarguil wrote: > > > +static int > > +ether_addr_from_str(struct ether_addr *eth_addr, const char *str) > > +{ > > + static const uint8_t conv[0x100] = { > > + ['0'] = 0x

Re: [dpdk-dev] [PATCH v1 0/3] Introduce virtual PMD for Hyper-V/Azure platforms

2017-12-18 Thread Adrien Mazarguil
On Mon, Dec 18, 2017 at 10:23:04AM -0800, Stephen Hemminger wrote: > On Mon, 18 Dec 2017 17:46:19 +0100 > Adrien Mazarguil wrote: > > > Virtual machines hosted by Hyper-V/Azure platforms are fitted with > > simplified virtual network devices named NetVSC that are used for fast > > communication b

Re: [dpdk-dev] [PATCH v1 0/3] Introduce virtual PMD for Hyper-V/Azure platforms

2017-12-18 Thread Thomas Monjalon
18/12/2017 19:23, Stephen Hemminger: > Please don't call this drivers/net/hyperv/ > that name conflicts with the real netvsc PMD that I am working on. > > Maybe vdev-netvsc? I expect your PMD to be in drivers/net/netvsc/ Why is it conflicting with drivers/net/hyperv/ ?

Re: [dpdk-dev] [PATCH v1 2/3] net/hyperv: implement core functionality

2017-12-18 Thread Wiles, Keith
> On Dec 18, 2017, at 11:59 AM, Adrien Mazarguil > wrote: >> Not to criticize style, but a few blank lines could help in readability for >> these files IMHO. Unless blank lines are illegal :-) > > It's a matter of taste, I think people tend to add random blank lines where > they think doing

Re: [dpdk-dev] [PATCH v1 2/3] net/hyperv: implement core functionality

2017-12-18 Thread Stephen Hemminger
On Mon, 18 Dec 2017 17:46:23 +0100 Adrien Mazarguil wrote: > > /** > + * Destroy a hyperv context instance. > + * > + * @param ctx > + * Context to destroy. > + */ > +static void > +hyperv_ctx_destroy(struct hyperv_ctx *ctx) > +{ > + if (ctx->pipe[0] != -1) > + close(ctx->pip

Re: [dpdk-dev] [PATCH v1 1/3] net/hyperv: introduce MS Hyper-V platform driver

2017-12-18 Thread Stephen Hemminger
On Mon, 18 Dec 2017 17:46:21 +0100 Adrien Mazarguil wrote: > +#ifdef RTE_LIBRTE_HYPERV_DEBUG > + > +#define PMD_DRV_LOG(level, ...) \ > + RTE_LOG(level, PMD, \ > + RTE_FMT("%s:%u: %s(): " RTE_FMT_HEAD(__VA_ARGS__,) "\n", \ > + strrchr("/" __FILE__, '/') + 1, \

Re: [dpdk-dev] [PATCH v1 2/3] net/hyperv: implement core functionality

2017-12-18 Thread Stephen Hemminger
On Mon, 18 Dec 2017 17:46:23 +0100 Adrien Mazarguil wrote: > +static int > +ether_addr_from_str(struct ether_addr *eth_addr, const char *str) > +{ > + static const uint8_t conv[0x100] = { > + ['0'] = 0x80, ['1'] = 0x81, ['2'] = 0x82, ['3'] = 0x83, > + ['4'] = 0x84, ['5

Re: [dpdk-dev] [PATCH v1 0/3] Introduce virtual PMD for Hyper-V/Azure platforms

2017-12-18 Thread Stephen Hemminger
On Mon, 18 Dec 2017 17:46:19 +0100 Adrien Mazarguil wrote: > Virtual machines hosted by Hyper-V/Azure platforms are fitted with > simplified virtual network devices named NetVSC that are used for fast > communication between VM to VM, VM to hypervisor, and the outside. > > They appear as standar

Re: [dpdk-dev] [PATCH 0/6] next-build: create both static and shared libs

2017-12-18 Thread Aaron Conole
Luca Boccassi writes: > On Tue, 2017-12-12 at 17:14 +, Bruce Richardson wrote: >> On Tue, Dec 12, 2017 at 04:59:34PM +, Bruce Richardson wrote: >> > This patchset changes the meson+ninja build system to always create >> > both >> > static and shared libraries when doing a build. The appli

Re: [dpdk-dev] [PATCH v1 2/3] net/hyperv: implement core functionality

2017-12-18 Thread Adrien Mazarguil
On Mon, Dec 18, 2017 at 05:04:23PM +, Wiles, Keith wrote: > > On Dec 18, 2017, at 10:46 AM, Adrien Mazarguil > > wrote: > > > > As described in more details in the attached documentation (see patch > > contents), this virtual device driver manages NetVSC interfaces in virtual > > machines ho

Re: [dpdk-dev] [PATCH] build: replace license text with SPDX ids in meson files

2017-12-18 Thread Luca Boccassi
On Mon, 2017-12-18 at 17:41 +, Bruce Richardson wrote: > On Mon, Dec 18, 2017 at 04:27:48PM +, Luca Boccassi wrote: > > On Mon, 2017-12-18 at 16:00 +, Bruce Richardson wrote: > > > Signed-off-by: Bruce Richardson > > > --- > > >  app/meson.build| 32

Re: [dpdk-dev] [PATCH] build: replace license text with SPDX ids in meson files

2017-12-18 Thread Bruce Richardson
On Mon, Dec 18, 2017 at 04:27:48PM +, Luca Boccassi wrote: > On Mon, 2017-12-18 at 16:00 +, Bruce Richardson wrote: > > Signed-off-by: Bruce Richardson > > --- > > Reviewed-by: Luca Boccassi > Applied to dpdk-next-build.

Re: [dpdk-dev] [PATCH] build: replace license text with SPDX ids in meson files

2017-12-18 Thread Bruce Richardson
On Mon, Dec 18, 2017 at 04:27:48PM +, Luca Boccassi wrote: > On Mon, 2017-12-18 at 16:00 +, Bruce Richardson wrote: > > Signed-off-by: Bruce Richardson > > --- > >  app/meson.build| 32 ++ > > > > Reviewed-by: Luca Boccassi > > LG

Re: [dpdk-dev] [PATCH v1 2/3] net/hyperv: implement core functionality

2017-12-18 Thread Wiles, Keith
> On Dec 18, 2017, at 10:46 AM, Adrien Mazarguil > wrote: > > As described in more details in the attached documentation (see patch > contents), this virtual device driver manages NetVSC interfaces in virtual > machines hosted by Hyper-V/Azure platforms. > > This driver does not manage traffi

[dpdk-dev] [PATCH v1 3/3] net/hyperv: add "force" parameter

2017-12-18 Thread Adrien Mazarguil
This parameter allows specifying any non-NetVSC interface to use with tap sub-devices for development purposes. Signed-off-by: Adrien Mazarguil --- doc/guides/nics/hyperv.rst | 5 + drivers/net/hyperv/hyperv.c | 26 +++--- 2 files changed, 24 insertions(+), 7 deletions(

[dpdk-dev] [PATCH v1 2/3] net/hyperv: implement core functionality

2017-12-18 Thread Adrien Mazarguil
As described in more details in the attached documentation (see patch contents), this virtual device driver manages NetVSC interfaces in virtual machines hosted by Hyper-V/Azure platforms. This driver does not manage traffic nor Ethernet devices directly; it acts as a thin configuration layer that

[dpdk-dev] [PATCH v1 1/3] net/hyperv: introduce MS Hyper-V platform driver

2017-12-18 Thread Adrien Mazarguil
This patch lays the groundwork for this PMD (draft documentation, copyright notices, code base skeleton and build system hooks). While it can be successfully compiled and invoked, it's an empty shell at this stage. Signed-off-by: Adrien Mazarguil --- MAINTAINERS

[dpdk-dev] [PATCH v1 0/3] Introduce virtual PMD for Hyper-V/Azure platforms

2017-12-18 Thread Adrien Mazarguil
Virtual machines hosted by Hyper-V/Azure platforms are fitted with simplified virtual network devices named NetVSC that are used for fast communication between VM to VM, VM to hypervisor, and the outside. They appear as standard system netdevices to user-land applications, the main difference bein

Re: [dpdk-dev] [RFC PATCH 0/3] ethdev: few changes in rte_ethdev layer

2017-12-18 Thread Jerin Jacob
-Original Message- > Date: Thu, 14 Dec 2017 13:57:02 + > From: "Ananyev, Konstantin" > To: Jerin Jacob > CC: "dev@dpdk.org" , "shah...@mellanox.com" > > Subject: RE: [dpdk-dev] [RFC PATCH 0/3] ethdev: few changes in rte_ethdev > layer > > Hi Jerin, Hi Konstantin, > > > > > Hi

Re: [dpdk-dev] [RFC] eventdev: add crypto adapter API header

2017-12-18 Thread Eads, Gage
> -Original Message- > From: Jerin Jacob [mailto:jerin.ja...@caviumnetworks.com] > Sent: Monday, December 18, 2017 12:30 AM > To: Eads, Gage > Cc: Gujjar, Abhinandan S ; dev@dpdk.org; > Vangati, Narender ; Rao, Nikhil > ; hemant.agra...@nxp.com; Doherty, Declan > ; nidadavolu.mur...@cavi

Re: [dpdk-dev] [PATCH v4 2/4] change root makefile license to SPDX tag

2017-12-18 Thread Thomas Monjalon
18/12/2017 16:52, Bruce Richardson: > On Mon, Dec 18, 2017 at 06:09:02PM +0530, Hemant Agrawal wrote: > > --- a/GNUmakefile > > +++ b/GNUmakefile > > @@ -1,33 +1,6 @@ > > -# BSD LICENSE > > +# SPDX-License-Identifier: BSD-3-Clause > > # > > # Copyright(c) 2010-2015 Intel Corporation. All righ

Re: [dpdk-dev] [PATCH] igb_uio: allow multi-process access

2017-12-18 Thread Wang, Xiao W
Hi, > -Original Message- > From: Stephen Hemminger [mailto:step...@networkplumber.org] > Sent: Tuesday, December 12, 2017 9:39 AM > To: Wang, Xiao W > Cc: Yigit, Ferruh ; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] igb_uio: allow multi-process access > > On Fri, 8 Dec 2017 17:57:33 -

Re: [dpdk-dev] [PATCH v4 2/4] change root makefile license to SPDX tag

2017-12-18 Thread Bruce Richardson
On Mon, Dec 18, 2017 at 06:09:02PM +0530, Hemant Agrawal wrote: > Signed-off-by: Hemant Agrawal > --- > GNUmakefile | 29 + > Makefile| 29 + > 2 files changed, 2 insertions(+), 56 deletions(-) > > diff --git a/GNUmakefile b/GNUmakefile

Re: [dpdk-dev] [PATCH v2 2/2] eal/x86: Use lock-prefixed instructions to reduce cost of rte_smp_mb()

2017-12-18 Thread Bruce Richardson
On Mon, Dec 18, 2017 at 03:34:13PM +, Konstantin Ananyev wrote: > On x86 it is possible to use lock-prefixed instructions to get > the similar effect as mfence. > As pointed by Java guys, on most modern HW that gives a better > performance than using mfence: > https://shipilev.net/blog/2014/on

Re: [dpdk-dev] [PATCH 1/2] test: use env variable to run test if set

2017-12-18 Thread Jerin Jacob
-Original Message- > Date: Mon, 18 Dec 2017 15:24:22 + > From: "Van Haaren, Harry" > To: Jerin Jacob > CC: "dev@dpdk.org" , "Richardson, Bruce" > > Subject: RE: [dpdk-dev] [PATCH 1/2] test: use env variable to run test if > set > > > From: Jerin Jacob [mailto:jerin.ja...@caviumnet

[dpdk-dev] [PATCH v2 1/2] test/test: introduce new test-case for rte_smp_mb()

2017-12-18 Thread Konstantin Ananyev
Simple functional test for rte_smp_mb() implementations. Also when executed on a single lcore could be used as rough estimation how many cycles particular implementation of rte_smp_mb() might take. Signed-off-by: Konstantin Ananyev --- test/test/Makefile | 1 + test/test/test_mb.c | 315 +

[dpdk-dev] [PATCH v2 0/2] eal/x86: Optimize rte_smp_mb() and create a new test case for it

2017-12-18 Thread Konstantin Ananyev
v2 changes: Address Bruce code-review comments: - get rid of macros to simplify the code - add more comments to the test case Konstantin Ananyev (2): test/test: introduce new test-case for rte_smp_mb() eal/x86: Use lock-prefixed instructions to reduce cost of rte_smp_mb() .../common/in

[dpdk-dev] [PATCH v2 2/2] eal/x86: Use lock-prefixed instructions to reduce cost of rte_smp_mb()

2017-12-18 Thread Konstantin Ananyev
On x86 it is possible to use lock-prefixed instructions to get the similar effect as mfence. As pointed by Java guys, on most modern HW that gives a better performance than using mfence: https://shipilev.net/blog/2014/on-the-fence-with-dependencies/ That patch adopts that technique for rte_smp_mb(

Re: [dpdk-dev] [PATCH 2/2] meson: add tests app to build

2017-12-18 Thread Van Haaren, Harry
> From: Richardson, Bruce > Sent: Monday, December 18, 2017 1:55 PM > To: Van Haaren, Harry > Cc: dev@dpdk.org > Subject: Re: [PATCH 2/2] meson: add tests app to build > > On Mon, Dec 18, 2017 at 11:53:58AM +, Harry van Haaren wrote: > > This patch enables the test/test app to be built. It al

Re: [dpdk-dev] [PATCH 1/2] test: use env variable to run test if set

2017-12-18 Thread Van Haaren, Harry
> From: Jerin Jacob [mailto:jerin.ja...@caviumnetworks.com] > Sent: Monday, December 18, 2017 2:59 PM > To: Van Haaren, Harry > Cc: dev@dpdk.org; Richardson, Bruce > Subject: Re: [dpdk-dev] [PATCH 1/2] test: use env variable to run test if > set > > -Original Message- > > Date: Mon, 18 D

Re: [dpdk-dev] [PATCH 0/2] next-build: add test app to build

2017-12-18 Thread Van Haaren, Harry
> From: Richardson, Bruce > Sent: Monday, December 18, 2017 1:57 PM > To: Van Haaren, Harry > Cc: dev@dpdk.org > Subject: Re: [PATCH 0/2] next-build: add test app to build > > On Mon, Dec 18, 2017 at 11:53:56AM +, Harry van Haaren wrote: > > This patchset adds the test/test/test app to the Me

Re: [dpdk-dev] [PATCH v1] net/tap: allow user mac to be passed as args

2017-12-18 Thread Varghese, Vipin
On 11/30/2017 11:49 AM, Vipin Varghese wrote: > One of the uses cases from customer site is use TAP PMD to intake user > specific MAC address during probe. This allows applications make use > of interfaces with desired MAC. > > Extending MAC argumentinfrastructure for tap PMD; we pass custom MAC

Re: [dpdk-dev] [PATCH v2] virtio_net: kick guest even when virtio queue is full

2017-12-18 Thread Patrik Andersson R
Hi Maxime, apologies for the late answer. Yes I would think that it would solve the problem that we had. But there is a slight risk that a driver in a VM (not within our area of influence) was partly responsible for the severity of the fault and that we might again experience some difficulties

Re: [dpdk-dev] [PATCH 1/2] test: use env variable to run test if set

2017-12-18 Thread Jerin Jacob
-Original Message- > Date: Mon, 18 Dec 2017 11:53:57 + > From: Harry van Haaren > To: dev@dpdk.org > CC: bruce.richard...@intel.com, Harry van Haaren > > Subject: [dpdk-dev] [PATCH 1/2] test: use env variable to run test if set > X-Mailer: git-send-email 2.7.4 > > This commit paves

  1   2   >