Re: [dpdk-dev] [PATCH 1/2] net/ixgbe: fix mailbox interrupt handler

2018-01-11 Thread Zhang, Qi Z
> -Original Message- > From: Dai, Wei > Sent: Thursday, December 28, 2017 12:39 PM > To: Zhang, Qi Z ; Lu, Wenzhuo > > Cc: dev@dpdk.org; Wang, Liang-min ; > sta...@dpdk.org > Subject: RE: [PATCH 1/2] net/ixgbe: fix mailbox interrupt handler > > According to step 7 & 8 in Table 7-74 PF-t

Re: [dpdk-dev] [PATCH] i40e: fix flag sent to mac_address_write

2018-01-11 Thread Xing, Beilei
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Igor Ryzhov > Sent: Thursday, January 11, 2018 6:40 AM > To: dev@dpdk.org > Subject: [dpdk-dev] [PATCH] i40e: fix flag sent to mac_address_write Prefix with net/i40e: > > Use the same value as in Linux driver.

[dpdk-dev] [PATCH 1/6] ethdev: add a function to look up Rx offload names

2018-01-11 Thread Andrew Rybchenko
From: Ivan Malov Commonly, drivers converted to the new offload API may need to log unsupported offloads as a response to wrong settings. From this perspective, it would be convenient to have generic functions to look up offload names. The patch adds such a helper for Rx. Signed-off-by: Ivan Mal

[dpdk-dev] [PATCH 0/6] net/sfc: convert to the new offload API

2018-01-11 Thread Andrew Rybchenko
May be it is too late to suggest a new API functions to ethdev, but hopefully if the idea is accepted, it could be applied in the current release cycle since these functions are trivial. I'm not sure that rte_ethdev_version.map is updated correctly since EXPERIMENTAL tag is present and I don't und

[dpdk-dev] [PATCH 2/6] ethdev: add a function to look up Tx offload names

2018-01-11 Thread Andrew Rybchenko
From: Ivan Malov Commonly, drivers converted to the new offload API may need to log unsupported offloads as a response to wrong settings. From this perspective, it would be convenient to have generic functions to look up offload names. The patch adds such a helper for Tx. Signed-off-by: Ivan Mal

[dpdk-dev] [PATCH 3/6] net/sfc: factor out function to report Rx capabilities

2018-01-11 Thread Andrew Rybchenko
From: Ivan Malov The patch adds a separate function to report supported Rx capabilities because this function will be required in more places across the code in the upcoming patches. Signed-off-by: Ivan Malov Signed-off-by: Andrew Rybchenko --- drivers/net/sfc/sfc_ethdev.c | 9 + dri

[dpdk-dev] [PATCH 5/6] net/sfc: factor out function to report Tx capabilities

2018-01-11 Thread Andrew Rybchenko
From: Ivan Malov The patch adds a separate function to report supported Tx capabilities because this function will be required in more places across the code in the upcoming patches. Signed-off-by: Ivan Malov Signed-off-by: Andrew Rybchenko --- drivers/net/sfc/sfc_ethdev.c | 13 +

[dpdk-dev] [PATCH 4/6] net/sfc: convert to the new Rx offload API

2018-01-11 Thread Andrew Rybchenko
From: Ivan Malov Ethdev Rx offloads API has changed since: commit ce17eddefc20 ("ethdev: introduce Rx queue offloads API") This commit support the new Rx offloads API. Signed-off-by: Ivan Malov Signed-off-by: Andrew Rybchenko --- drivers/net/sfc/sfc_ethdev.c | 27 +-- drivers/net/sfc

[dpdk-dev] [PATCH 6/6] net/sfc: convert to the new Tx offload API

2018-01-11 Thread Andrew Rybchenko
From: Ivan Malov Ethdev Tx offloads API has changed since: commit cba7f53b717d ("ethdev: introduce Tx queue offloads API") This commit support the new Tx offloads API. The code which fills in txq_flags in default_txconf is preserved because rte_eth_dev_info_get() lacks conversion between offload

Re: [dpdk-dev] [dpdk-dev, v2] net/e1000: always enable receive and transmit

2018-01-11 Thread Wenzhuo Lu
Hi, > Date: Thu, 19 Oct 2017 23:23:39 -0400 > > From: Chas Williams > > The transmit and receive controller state machines are only enabled after > receiving an interrupt and the link status is now valid. If an adapter > is being used in conjunction with NC-SI, network controller sideband > inte

Re: [dpdk-dev] [PATCH] net/mlx5: fix parsing all-multicast from flow item

2018-01-11 Thread Nélio Laranjeiro
On Wed, Jan 10, 2018 at 11:51:53PM -0800, Yongseok Koh wrote: > As the dst_mac of allmulti is already masked with the mask, it has 0x01 in > the first octet. Checking the least significant bit only can't distinguish > it from broadcast or IPv6 multicast. > > Fixes: bb47fb6e6067 ("net/mlx5: fix flow

Re: [dpdk-dev] [PATCH] net/i40e: fix VSI MAC filter on primary address change

2018-01-11 Thread Xing, Beilei
Hi Igor, Thanks for the catch, and glad to see your patch☺ It resolves a potential problem in PMD. The patch looks OK for me except some minor comments (in another mail thread). Best Regards, Beilei From: Igor Ryzhov [mailto:iryz...@nfware.com] Sent: Thursday, January 11, 2018 6:47 AM To: Zhang

[dpdk-dev] [RFC] New packet type query API

2018-01-11 Thread Qiming Yang
This RFC contains a proposal to add a new packet type query API to DPDK. Motivation == In current DPDK implementation, when received one packet, driver will lookup the packet type mapping table and transmit the result value to struct mbuf. Appilcation will analyze the mbuf->packet_type

Re: [dpdk-dev] [PATCH] net/e1000: add minimum support for Broadcom 54616 PHY

2018-01-11 Thread Lu, Wenzhuo
Hi Chas, > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Chas Williams > Sent: Thursday, December 7, 2017 7:55 AM > To: dev@dpdk.org > Cc: skh...@vmware.com; Charles (Chas) Williams ; > Chas Williams > Subject: [dpdk-dev] [PATCH] net/e1000: add minimum support

Re: [dpdk-dev] [PATCH v4 0/5] lib: add Port Representors

2018-01-11 Thread Alex Rosenbaum
Declan, In all previous series I explained my objection for using the broker framework for holding the VF rep port. You guys just waved it away (and sent a new series) instead of really giving a clear reason why they are required. I think Yuanhan's suggestion gets ride of the broker model in a cl

Re: [dpdk-dev] [PATCH v6 02/14] net/avf: initialization of avf PMD

2018-01-11 Thread Ferruh Yigit
On 1/11/2018 2:07 AM, Lu, Wenzhuo wrote: > Hi Stephen, > >> -Original Message- >> From: Stephen Hemminger [mailto:step...@networkplumber.org] >> Sent: Thursday, January 11, 2018 1:15 AM >> To: Lu, Wenzhuo >> Cc: dev@dpdk.org; Wu, Jingjing >> Subject: Re: [dpdk-dev] [PATCH v6 02/14] net/a

Re: [dpdk-dev] [PATCH] bus/fslmc: add support for scanned device count

2018-01-11 Thread Hemant Agrawal
On 1/2/2018 6:38 PM, Shreyansh Jain wrote: FSLMC bus detects a multiple type of logical objects representing components of the datapath. Using the type of device, a newly introduced API rte_fslmc_get_device_count can return the count of devices scanned of that device type. Signed-off-by: Shreya

Re: [dpdk-dev] [PATCH v3 6/8] net/vdev_netvsc: skip routed netvsc probing

2018-01-11 Thread Matan Azrad
Hi Stephan From: Stephen Hemminger, Wednesday, January 10, 2018 6:44 PM > On Wed, 10 Jan 2018 15:07:14 + > Matan Azrad wrote: > > > Hi Stephan > > > > From: Stephen Hemminger, Tuesday, January 9, 2018 8:51 PM > > > To: Matan Azrad > > > Cc: Ferruh Yigit ; Thomas Monjalon > > > ; dev@dpdk.o

[dpdk-dev] [PATCH 2/2] examples/ipsec-secgw: fix SPI byte order in flow item

2018-01-11 Thread Nelio Laranjeiro
SPI field is defined in the RFC2406 [1] as a big endian field it should be provided in its final form to the drivers through RTE flow. Fixes: ec17993a145a ("examples/ipsec-secgw: support security offload") Cc: akhil.go...@nxp.com Signed-off-by: Nelio Laranjeiro [1] https://tools.ietf.org/html/r

[dpdk-dev] [PATCH 1/2] net: fix ESP header byte ordering definition

2018-01-11 Thread Nelio Laranjeiro
ESP header is defined in the RFC2406 [1] as Big Endian fields it should use the corresponding types in DPDK as well. Fixes: d4b684f7197a ("net: add ESP header to generic flow steering") Cc: bor...@mellanox.com Signed-off-by: Nelio Laranjeiro [1] https://tools.ietf.org/html/rfc2406 --- lib/libr

[dpdk-dev] [PATCH] net/mlx5: fix all multi verification code position

2018-01-11 Thread Nelio Laranjeiro
All multi code should not be handled in exit part of the code but in the mainline of the function. Fixes: 4241d84c0a32 ("net/mlx5: fix flow type for allmulti rules") Cc: rasl...@mellanox.com Signed-off-by: Nelio Laranjeiro --- drivers/net/mlx5/mlx5_flow.c | 20 ++-- 1 file chang

Re: [dpdk-dev] [PATCH v4 0/5] lib: add Port Representors

2018-01-11 Thread Remy Horton
On 11/01/2018 03:18, Yuanhan Liu wrote: [..] - Then inside the driver (say, i40e) * allocate 1 DPDK ethdev port * allocate 4 DPDK ethdev port, one for each VF specified by the vf_ports option. And these are VF representors. * link the VF representors to the right VF port For examp

[dpdk-dev] [PATCH] test/memzone: Fix test_memzone_basic & test_memzone_free issues.

2018-01-11 Thread Phil Yang
1. test_memzone_basic: No need to free a NULL memzone. It will cause test termination. 2. test_memzone_free: Out of mz[RTE_MAX_MEMZONE] memory bound while reserving memzone for mz. It will flush variable i. Fix by extend to mz[RTE_MAX_MEMZONE + 1]. Signed-off-by: Phil Yang --- test/test/test_mem

Re: [dpdk-dev] [PATCH v4] net/ixgbe: fix l3fwd start failed on VF

2018-01-11 Thread Dai, Wei
According to 82599 datasheet, VF working mode is controlled by its host PF. If VF is working in RSS or DCB mode, it can use more than 1 queues. That also means its host PF should enable RSS or DCB. The PF Rx mode can be ETH_MQ_RX_VMDQ_RSS or ETH_MQ_RX_VMDQ_DCB. So I think that DPDK app with PF caus

Re: [dpdk-dev] [PATCH 2/2] examples/ipsec-secgw: fix SPI byte order in flow item

2018-01-11 Thread Akhil Goyal
Acked-by: Akhil Goyal

[dpdk-dev] [PATCH v1] net/i40e: fix packet type parser issue

2018-01-11 Thread Beilei Xing
Ptype mapping table will fail to update when loading PPP profile, fix the issue via modifying metadata and adding check. Fixes: ab2e350c4f4b ("net/i40e: improve packet type parser") Cc: sta...@dpdk.org Signed-off-by: Beilei Xing --- drivers/net/i40e/i40e_ethdev.c | 2 +- drivers/net/i40e/rte_p

[dpdk-dev] [PATCH v2] net/i40e: fix flag sent to mac_address_write

2018-01-11 Thread Igor Ryzhov
Use the same value as in Linux driver. Fixes: e18e01e92c29 ("i40e: support default MAC address setting") Cc: sta...@dpdk.org Signed-off-by: Igor Ryzhov --- v2: * fix checkpatch warning (long line) * fix commit subject * add Fixes line * CC to stable --- drivers/net/i40e/i40e_ethdev.c | 4 ++--

Re: [dpdk-dev] [PATCH] net/i40e: fix VSI MAC filter on primary address change

2018-01-11 Thread Igor Ryzhov
Sent v2: https://dpdk.org/dev/patchwork/patch/33570/ On Thu, Jan 11, 2018 at 11:21 AM, Xing, Beilei wrote: > Hi Igor, > > > > Thanks for the catch, and glad to see your patchJ It resolves a potential > problem in PMD. > > The patch looks OK for me except some minor comments (in another mail > th

[dpdk-dev] [PATCH v5 02/11] eventdev: add API to perform self test

2018-01-11 Thread Pavan Nikhilesh
Add API to perform self test on the underlying event device driver. Signed-off-by: Pavan Nikhilesh Acked-by: Harry van Haaren Acked-by: Jerin Jacob --- lib/librte_eventdev/rte_eventdev.c | 10 ++ lib/librte_eventdev/rte_eventdev.h | 12 lib/librte_event

[dpdk-dev] [PATCH v5 04/11] event/octeontx: modify octeontx eventdev test

2018-01-11 Thread Pavan Nikhilesh
Modify test_eventdev_octeontx to be standalone selftest independent of test framework. Signed-off-by: Pavan Nikhilesh --- drivers/event/octeontx/ssovf_evdev_selftest.c | 425 ++ 1 file changed, 232 insertions(+), 193 deletions(-) diff --git a/drivers/event/octeontx/ssovf

[dpdk-dev] [PATCH v5 03/11] event/octeontx: move eventdev octeontx test to driver

2018-01-11 Thread Pavan Nikhilesh
Move octeontx eventdev specific test (test_eventdev_octeontx.c) to driver/event/octeontx. Signed-off-by: Pavan Nikhilesh Acked-by: Jerin Jacob --- .../event/octeontx/ssovf_evdev_selftest.c| 0 test/test/Makefile

[dpdk-dev] [PATCH v5 01/11] eal: add common test assert macros

2018-01-11 Thread Pavan Nikhilesh
Adding common test assertion macros for unit testing. Replaced common macros in test/test.h with new RTE_TEST_ASSERT_* macros. Signed-off-by: Pavan Nikhilesh Acked-by: Jerin Jacob --- v5 Changes: - rebase patchset - remove duplication between test/test/test.h and rte_test.h by mapping RT

[dpdk-dev] [PATCH v5 05/11] event/octeontx: update octeontx eventdev selftest ops

2018-01-11 Thread Pavan Nikhilesh
Update octeontx eventdev ops to invoke selftest when application invokes `rte_event_dev_selftest`. Signed-off-by: Pavan Nikhilesh Acked-by: Jerin Jacob --- drivers/event/octeontx/Makefile | 3 ++- drivers/event/octeontx/ssovf_evdev.c | 2 ++ drivers/event/octeontx/ssovf_evdev.h | 4 3

[dpdk-dev] [PATCH v5 06/11] event/octeontx: add selftest to device arguments

2018-01-11 Thread Pavan Nikhilesh
Add selftest as a device argument that can be enabled by suppling 'self_test=1' as a vdev parameter --vdev="event_octeontx,self_test=1" The selftest is run after vdev creation is successfully complete. Signed-off-by: Pavan Nikhilesh Acked-by: Jerin Jacob --- drivers/event/octeontx/Mak

[dpdk-dev] [PATCH v5 08/11] event/sw: modify eventdev software test

2018-01-11 Thread Pavan Nikhilesh
Modify test_eventdev_sw to be standalone selftest independent of test framework. Signed-off-by: Pavan Nikhilesh Acked-by: Harry van Haaren --- drivers/event/sw/sw_evdev_selftest.c | 70 ++-- 1 file changed, 36 insertions(+), 34 deletions(-) diff --git a/drivers/

[dpdk-dev] [PATCH v5 10/11] test: register eventdev selftest

2018-01-11 Thread Pavan Nikhilesh
Signed-off-by: Pavan Nikhilesh Acked-by: Jerin Jacob --- test/test/test_eventdev.c | 22 ++ 1 file changed, 22 insertions(+) diff --git a/test/test/test_eventdev.c b/test/test/test_eventdev.c index f8ee1bef6..7465251dc 100644 --- a/test/test/test_eventdev.c +++ b/test/test/t

[dpdk-dev] [PATCH v5 09/11] event/sw: update software eventdev selftest ops

2018-01-11 Thread Pavan Nikhilesh
Update software eventdev ops to invoke selftest when application invokes `rte_event_dev_selftest`. Signed-off-by: Pavan Nikhilesh Acked-by: Harry van Haaren --- drivers/event/sw/Makefile | 2 ++ drivers/event/sw/sw_evdev.c | 2 ++ drivers/event/sw/sw_evdev.h | 1 + 3 files changed, 5 insertio

[dpdk-dev] [PATCH v5 07/11] event/sw: move eventdev software test to driver

2018-01-11 Thread Pavan Nikhilesh
Move software eventdev specific test (test_eventdev_sw) to driver/event/sw/. Signed-off-by: Pavan Nikhilesh Acked-by: Harry van Haaren --- test/test/test_eventdev_sw.c => drivers/event/sw/sw_evdev_selftest.c | 0 test/test/Makefile | 1 - 2 file

[dpdk-dev] [PATCH v5 11/11] doc: update eventdev documentation

2018-01-11 Thread Pavan Nikhilesh
Update octeontx eventdev documentation to include new selftest feature. Signed-off-by: Pavan Nikhilesh Acked-by: Marko Kovacevic --- doc/guides/eventdevs/octeontx.rst | 13 + 1 file changed, 13 insertions(+) diff --git a/doc/guides/eventdevs/octeontx.rst b/doc/guides/eventdevs/oct

Re: [dpdk-dev] [PATCH v5 01/11] eal: add common test assert macros

2018-01-11 Thread Pavan Nikhilesh
+Cc: tho...@monjalon.net On Thu, Jan 11, 2018 at 03:51:46PM +0530, Pavan Nikhilesh wrote: > Adding common test assertion macros for unit testing. > Replaced common macros in test/test.h with new RTE_TEST_ASSERT_* macros. > > Signed-off-by: Pavan Nikhilesh > Acked-by: Jerin Jacob > --- > > v5 Cha

Re: [dpdk-dev] [PATCH v4] net/ixgbe: fix l3fwd start failed on VF

2018-01-11 Thread Wu, Yanglong
Yes, this problem is caused by PF passing a wrong number of queue to VF. So basically, I removed model check of "case ETH_MQ_RX_NONE". It seem right after I do that but I'am also not very sure the changing is really right. So thank to your comments, I will redebug this problem. -Original M

Re: [dpdk-dev] [PATCH v5 01/11] eal: add common test assert macros

2018-01-11 Thread Thomas Monjalon
11/01/2018 11:29, Pavan Nikhilesh: > +Cc: tho...@monjalon.net > On Thu, Jan 11, 2018 at 03:51:46PM +0530, Pavan Nikhilesh wrote: > > Adding common test assertion macros for unit testing. > > Replaced common macros in test/test.h with new RTE_TEST_ASSERT_* macros. > > > > Signed-off-by: Pavan Nikhil

Re: [dpdk-dev] [PATCH v6 01/23] eventtimer: add event timer adapter API

2018-01-11 Thread Pavan Nikhilesh
On Wed, Jan 10, 2018 at 06:20:52PM -0600, Erik Gabriel Carrillo wrote: > Signed-off-by: Erik Gabriel Carrillo Consider giving credit to the original authors. > --- > lib/librte_eventdev/Makefile | 1 + > lib/librte_eventdev/rte_event_timer_adapter.h | 566 > +

Re: [dpdk-dev] [PATCH 00/11] net/vhostpci: A new vhostpci PMD supporting VM2VM scenario

2018-01-11 Thread Yang, Zhiyong
Hi Maxime, all, > -Original Message- > From: Maxime Coquelin [mailto:maxime.coque...@redhat.com] > Sent: Tuesday, December 19, 2017 7:15 PM > To: Yang, Zhiyong ; dev@dpdk.org; > y...@fridaylinux.org > Cc: Wang, Wei W ; Tan, Jianfeng > > Subject: Re: [PATCH 00/11] net/vhostpci: A new vhos

Re: [dpdk-dev] [PATCH v6 05/23] eventtimer: add adapter allocation definitions

2018-01-11 Thread Pavan Nikhilesh
On Wed, Jan 10, 2018 at 06:20:56PM -0600, Erik Gabriel Carrillo wrote: > Add definitions for the functions that allocate and deallocate adapter > instances in the default software implementation. > > Signed-off-by: Erik Gabriel Carrillo > --- > lib/Makefile | 2

Re: [dpdk-dev] [PATCH v5 11/11] doc: update eventdev documentation

2018-01-11 Thread Jerin Jacob
-Original Message- > Date: Thu, 11 Jan 2018 15:51:56 +0530 > From: Pavan Nikhilesh > To: jerin.ja...@caviumnetworks.com, harry.van.haa...@intel.com, > gage.e...@intel.com, liang.j...@intel.com > Cc: dev@dpdk.org, Pavan Nikhilesh > Subject: [dpdk-dev] [PATCH v5 11/11] doc: update eventdev

Re: [dpdk-dev] [PATCH v6 10/23] eventtimer: remove service id entry from info structure

2018-01-11 Thread Pavan Nikhilesh
On Wed, Jan 10, 2018 at 06:21:01PM -0600, Erik Gabriel Carrillo wrote: > Signed-off-by: Erik Gabriel Carrillo > --- > lib/librte_eventdev/rte_event_timer_adapter.c | 11 +-- > lib/librte_eventdev/rte_event_timer_adapter.h | 2 -- > 2 files changed, 1 insertion(+), 12 deletions(-) > > dif

[dpdk-dev] [PATCH v2 0/3] crypto/dpaa_sec: performance optimizations

2018-01-11 Thread Akhil Goyal
Following changes are added to improve performance. 1. optimize virtual to physical address conversion 2. support for multiple sessions in a single queue pair 3. support for ipsec protocol offload changes in v2: - incorporated comments from Hemant - split the patchset to remove dependency on bus

[dpdk-dev] [PATCH v2 1/3] crypto/dpaa_sec: optimize virt to phy conversion

2018-01-11 Thread Akhil Goyal
From: Hemant Agrawal Context memory is allocated from mempool. Ideally it will get all memory from single segment, so simple offset calculation is used for address conversion for such addresses from context memory. Signed-off-by: Hemant Agrawal Acked-by: Akhil Goyal --- drivers/crypto/dpaa_se

[dpdk-dev] [PATCH v2 3/3] crypto/dpaa_sec: support ipsec protocol offload

2018-01-11 Thread Akhil Goyal
Signed-off-by: Akhil Goyal Acked-by: Hemant Agrawal --- doc/guides/cryptodevs/features/dpaa_sec.ini | 1 + drivers/crypto/dpaa_sec/dpaa_sec.c | 410 ++-- drivers/crypto/dpaa_sec/dpaa_sec.h | 62 - 3 files changed, 450 insertions(+), 23 deletions(-

[dpdk-dev] [PATCH v2 2/3] crypto/dpaa_sec: support multiple sessions per qp

2018-01-11 Thread Akhil Goyal
From: Hemant Agrawal Signed-off-by: Hemant Agrawal Acked-by: Akhil Goyal --- drivers/crypto/dpaa_sec/dpaa_sec.c | 154 + drivers/crypto/dpaa_sec/dpaa_sec.h | 74 +- 2 files changed, 145 insertions(+), 83 deletions(-) diff --git a/drivers/cr

Re: [dpdk-dev] [PATCH v6 12/23] eventtimer: add event timer arm/cancel function definitions

2018-01-11 Thread Pavan Nikhilesh
On Wed, Jan 10, 2018 at 06:21:03PM -0600, Erik Gabriel Carrillo wrote: > Signed-off-by: Erik Gabriel Carrillo > --- > lib/Makefile | 2 +- > lib/librte_eventdev/Makefile | 2 +- > lib/librte_eventdev/rte_event_timer_adapter.c | 155 >

[dpdk-dev] [PATCH v2] crypto/dpaa_sec: rewrite Rx/Tx path

2018-01-11 Thread Akhil Goyal
Rx and Tx patch are rewritten with improved internal APIs to improve performance. Signed-off-by: Akhil Goyal Signed-off-by: Nipun Gupta --- changes in v2: Incorporated comments from Hemant. split patch from the patch series to remove dependancy of other patches on bus/dpaa patch Note: This patc

[dpdk-dev] [PATCH] examples/ipsec-secgw: fix corner case for spi value

2018-01-11 Thread Akhil Goyal
application is using index 0 of SA table as error, with current value of IPSEC_SA_MAX_ENTRIES(128) it can not support SA with spi = 128, as it uses sa_idx = 0 in the SA table. With this patch, sa_idx = 0 can also be used. PS: spi = 0 is an invalid SPI and application throws error for it. Fixes:

Re: [dpdk-dev] [PATCH v6 13/23] eventtimer: add adapter service definition

2018-01-11 Thread Pavan Nikhilesh
On Wed, Jan 10, 2018 at 06:21:04PM -0600, Erik Gabriel Carrillo wrote: > Define the callback function for the service that corresponds to an > adapter instance, as well as the callback for expired timers that the > service manages. > > Signed-off-by: Erik Gabriel Carrillo > --- > lib/librte_event

Re: [dpdk-dev] [PATCH v3 09/12] app/eventdev: add pipeline queue worker functions

2018-01-11 Thread Van Haaren, Harry
> From: Pavan Nikhilesh [mailto:pbhagavat...@caviumnetworks.com] > Sent: Wednesday, January 10, 2018 8:17 PM > To: Van Haaren, Harry ; > jerin.ja...@caviumnetworks.com; santosh.shu...@caviumnetworks.com; Eads, > Gage ; hemant.agra...@nxp.com; nipun.gu...@nxp.com; Ma, > Liang J > Cc: dev@dpdk.org >

Re: [dpdk-dev] [PATCH v6 15/23] eventtimer: add buffering of timer expiry events

2018-01-11 Thread Pavan Nikhilesh
On Wed, Jan 10, 2018 at 06:21:06PM -0600, Erik Gabriel Carrillo wrote: > Buffer timer expiry events generated while walking a "run list" > in rte_timer_manage, and burst enqueue them to an event device > to the extent possible. > IMO in some cases this adds a lot of delay between expiries and even

Re: [dpdk-dev] [PATCH v6 19/23] test: exercise event timer arm and expiry

2018-01-11 Thread Pavan Nikhilesh
On Wed, Jan 10, 2018 at 06:21:10PM -0600, Erik Gabriel Carrillo wrote: > Add a test that creates an event timer and detects the generation of a > timer expiry event being scheduled through the software event device. > > Signed-off-by: Erik Gabriel Carrillo > --- > test/test/test_event_timer_adapt

Re: [dpdk-dev] [PATCH v2 2/6] ethdev: add port ownership

2018-01-11 Thread Ananyev, Konstantin
Hi Matan, > > Hi Konstantin > > From: Ananyev, Konstantin, Wednesday, January 10, 2018 3:36 PM > > Hi Matan, > > > > Few comments from me below. > > BTW, do you plan to add ownership mandatory check in control path > > functions that change port configuration? > > No. So it still totally volu

Re: [dpdk-dev] [PATCH 2/4] drivers/net: add drivers for Cavium NICs to meson build

2018-01-11 Thread Pavan Nikhilesh
On Tue, Jan 09, 2018 at 05:29:36PM +, Bruce Richardson wrote: > On Sun, Dec 31, 2017 at 05:32:01AM +0530, Pavan Nikhilesh wrote: > > Add Cavium octeontx and thunder nicvf to meson build infrastructure. > > > > Signed-off-by: Pavan Nikhilesh > > --- > > drivers/net/meson.build

Re: [dpdk-dev] [PATCH v5] sched: make RED scaling configurable

2018-01-11 Thread Dumitrescu, Cristian
Hi Alan, More issues and questions below: ... > diff --git a/lib/librte_sched/rte_red.c b/lib/librte_sched/rte_red.h I suggest we use uint32_t for rte_red_scaling and rte_red_max_threshold, even though their values can fit into uint8_t and uint16_t respectively. > diff --git a/lib/librte_sche

Re: [dpdk-dev] [PATCH 3/4] event/octeontx: add octeontx event device to meson build

2018-01-11 Thread Pavan Nikhilesh
On Tue, Jan 09, 2018 at 05:34:00PM +, Bruce Richardson wrote: > On Sun, Dec 31, 2017 at 05:32:02AM +0530, Pavan Nikhilesh wrote: > > Add Cavium octeontx to meson build and change order of drivers built > > from event->mempool->net to mempool->net->event to resolve dependency. > > > > Signed-off

[dpdk-dev] [PATCH] net/i40e: fix VF reset stats crash

2018-01-11 Thread David C Harton
Calling i40evf_dev_xstats_reset can sometimes crash. Fixed issue by adding a pstats NULL check. Fixes: da61cd0849766 ("i40evf: add extended stats") 8210e9e0d805e ("net/i40e: fix clear xstats bug in VF") Cc: wei.zh...@intel.com Signed-off-by: David C Harton --- drivers/net/i40e/i40e_ethd

Re: [dpdk-dev] [PATCH] maintainers: update for enic

2018-01-11 Thread Ferruh Yigit
On 1/10/2018 9:17 AM, John Daley wrote: > Welcome Hyong Youb Kim. > > Signed-off-by: John Daley Series applied to dpdk-next-net/master, thanks. Welcome Hyong Youb Kim.

[dpdk-dev] [PATCH] net/sfc/base: change license to BSD-3-Clause

2018-01-11 Thread Andrew Rybchenko
Change license from BSD-2-Clause-FreeBSD to BSD-3-Clause. Bump copyright year. Fixes: 0b6f6260ac6c ("net/sfc/base: change license to BSD-3-Clause") Cc: Ferruh Yigit Signed-off-by: Andrew Rybchenko --- Could you squash the patch into changeset specified in Fixes tag. drivers/net/sfc/base/efx_t

Re: [dpdk-dev] [PATCH 1/4] drivers/mempool: add octeontx mempool driver to meson build

2018-01-11 Thread Pavan Nikhilesh
On Tue, Jan 09, 2018 at 05:35:28PM +, Bruce Richardson wrote: > On Sun, Dec 31, 2017 at 05:32:00AM +0530, Pavan Nikhilesh wrote: > > Add octeontx hardware mempool driver to meson build. > > > > Signed-off-by: Pavan Nikhilesh > > --- > > drivers/mempool/meson.build | 2 +- > > drivers

Re: [dpdk-dev] [PATCH 1/4] drivers/mempool: add octeontx mempool driver to meson build

2018-01-11 Thread Pavan Nikhilesh
On Tue, Jan 09, 2018 at 05:35:28PM +, Bruce Richardson wrote: > On Sun, Dec 31, 2017 at 05:32:00AM +0530, Pavan Nikhilesh wrote: > > Add octeontx hardware mempool driver to meson build. > > > > Signed-off-by: Pavan Nikhilesh > > --- > > drivers/mempool/meson.build | 2 +- > > drivers

[dpdk-dev] [PATCH v2] net/i40e: fix VF reset stats crash

2018-01-11 Thread David C Harton
Calling i40evf_dev_xstats_reset can sometimes crash. Fixed issue by adding a pstats NULL check. Fixes: 8210e9e0d805e ("net/i40e: fix clear xstats bug in VF") Cc: wei.zh...@intel.com Signed-off-by: David C Harton --- v2: * Fixed fixes line in commit message. drivers/net/i40e/i40e_ethdev_vf.c

[dpdk-dev] [PATCH] app/testpmd: add meter to the actions table

2018-01-11 Thread Tomasz Duszynski
Since METER action is supported by the testpmd application suitable entry should exist in flow actions information table. Without that testpmd will return error on adding a new flow to the list of flows attached to a given port. Signed-off-by: Tomasz Duszynski --- app/test-pmd/config.c | 1 + 1

[dpdk-dev] [pull-request] next-qos 18.02 pre-rc1

2018-01-11 Thread Cristian Dumitrescu
The following changes since commit f06125c07d6203a84e9b242c62d6a8e532a5c51d: doc: add metering and policing in testpmd guide (2018-01-10 00:54:52 +0100) are available in the git repository at: http://dpdk.org/git/next/dpdk-next-qos for you to fetch changes up to 9550cc5fe3408b33d53673c723a

Re: [dpdk-dev] DPDK-pktgen not giving expected throughput

2018-01-11 Thread Wiles, Keith
> On Jan 11, 2018, at 12:45 AM, Shailja Pandey wrote: > > I have also tried with multiple cpus using the command line- > > ./app/app/x86_64-native-linuxapp-gcc/pktgen -c 0x -n 4 -- -T -P -m > "[0:4].0,[5:8].1,[9-12].2,[13-16].3” What is port 0 and 1, I guess that port 2 and 3 are the 2x

Re: [dpdk-dev] [PATCH v3 09/12] app/eventdev: add pipeline queue worker functions

2018-01-11 Thread Pavan Nikhilesh
On Thu, Jan 11, 2018 at 12:17:38PM +, Van Haaren, Harry wrote: > > > > > Thinking a little more about this, also in light of patch 11/12 of this > > series. > > > > > > The code here has a "safe" and "unsafe" version of TX. This involves > > adding a spinlock inside the code, which is being

Re: [dpdk-dev] [PATCH v4] lib/librte_meter: add meter configuration profile

2018-01-11 Thread Dumitrescu, Cristian
> -Original Message- > From: Singh, Jasvinder > Sent: Monday, January 8, 2018 3:44 PM > To: dev@dpdk.org > Cc: Dumitrescu, Cristian > Subject: [PATCH v4] lib/librte_meter: add meter configuration profile > > From: Cristian Dumitrescu > > This patch adds support for meter configuration

[dpdk-dev] [PATCH V10 1/2] eal: add uevent monitor api and callback func

2018-01-11 Thread Jeff Guo
This patch aim to add a general uevent mechanism in eal device layer, to enable all linux kernel object uevent monitoring, user could use these APIs to monitor and read out the device status info that sent from the kernel side, then corresponding to handle it, such as when detect hotplug uevent typ

[dpdk-dev] [PATCH V10 2/2] eal: add uevent pass and process function

2018-01-11 Thread Jeff Guo
In order to handle the uevent which have been detected from the kernel side, add uevent process function, let hot plug event to be example to show uevent mechanism how to pass the uevent and process the uevent. About uevent passing and processing, add below functions in linux eal dev layer. FreeBS

Re: [dpdk-dev] [pull-request] next-qos 18.02 pre-rc1

2018-01-11 Thread Thomas Monjalon
11/01/2018 14:51, Cristian Dumitrescu: > Cristian Dumitrescu (1): > lib/librte_meter: add meter configuration profile Only one commit? I am sure there is more pending in patchwork.

Re: [dpdk-dev] [PATCH v2 3/3] crypto/dpaa_sec: support ipsec protocol offload

2018-01-11 Thread De Lara Guarch, Pablo
Hi Akhil, > -Original Message- > From: Akhil Goyal [mailto:akhil.go...@nxp.com] > Sent: Thursday, January 11, 2018 11:33 AM > To: dev@dpdk.org > Cc: De Lara Guarch, Pablo ; > hemant.agra...@nxp.com; Akhil Goyal > Subject: [PATCH v2 3/3] crypto/dpaa_sec: support ipsec protocol offload > >

Re: [dpdk-dev] [PATCH 1/4] drivers/mempool: add octeontx mempool driver to meson build

2018-01-11 Thread Pavan Nikhilesh
On Tue, Jan 09, 2018 at 05:41:23PM +, Bruce Richardson wrote: > On Sun, Dec 31, 2017 at 05:32:00AM +0530, Pavan Nikhilesh wrote: > > Add octeontx hardware mempool driver to meson build. > > > > Signed-off-by: Pavan Nikhilesh > > --- > > On the set as a whole, it looks good to me, just the few

Re: [dpdk-dev] [PATCH 1/6] test: fix memory leak in bitmap test

2018-01-11 Thread Dumitrescu, Cristian
> -Original Message- > From: Burakov, Anatoly > Sent: Friday, December 22, 2017 10:12 AM > To: dev@dpdk.org > Cc: Dumitrescu, Cristian ; > pbhagavat...@caviumnetworks.com > Subject: [PATCH 1/6] test: fix memory leak in bitmap test > > Fixes: c7e4a134e769 ("test: verify bitmap operations"

Re: [dpdk-dev] [PATCH 5/6] test: fix memory leak in table autotest

2018-01-11 Thread Dumitrescu, Cristian
> -Original Message- > From: Burakov, Anatoly > Sent: Friday, December 22, 2017 10:12 AM > To: dev@dpdk.org > Cc: Dumitrescu, Cristian ; sta...@dpdk.org > Subject: [PATCH 5/6] test: fix memory leak in table autotest > > Always deallocate allocated resources after the test is done. > > F

Re: [dpdk-dev] [PATCH] test: fix uninitialized parameter in table autotest

2018-01-11 Thread Dumitrescu, Cristian
> -Original Message- > From: Burakov, Anatoly > Sent: Thursday, December 21, 2017 3:53 PM > To: dev@dpdk.org > Cc: Dumitrescu, Cristian ; Kerlin, Marcin > ; sta...@dpdk.org > Subject: [PATCH] test: fix uninitialized parameter in table autotest > > delete_bulk() copies metadata to pointer

Re: [dpdk-dev] [PATCH V9 1/5] eal: add uevent monitor api and callback func

2018-01-11 Thread Guo, Jia
On 1/11/2018 9:43 AM, Thomas Monjalon wrote: Hi, Thanks for splitting the patches. I will review the first one today. Please see below. 10/01/2018 10:12, Jeff Guo: --- /dev/null +++ b/lib/librte_eal/bsdapp/eal/eal_dev.c +int +rte_dev_monitor_start(void) +{ + return -1; +} + +int +rte_d

Re: [dpdk-dev] [PATCH 0/3] AVF optimization

2018-01-11 Thread Ferruh Yigit
On 1/11/2018 6:52 AM, Wenzhuo Lu wrote: > The optimization for AVF code. > As the AVF patches is in the next-net repo but not merged > to the master branch, proposed these patches that can be > merged to the previouse ones. > Sorry for the inconvenience. > > Wenzhuo Lu (3): > net/avf/base: add s

Re: [dpdk-dev] [PATCH 1/5] net/ixgbevf: unregister irq handler when other interrupts not allowed.

2018-01-11 Thread Tonghao Zhang
On Thu, Jan 11, 2018 at 2:55 PM, Xing, Beilei wrote: > > >> -Original Message- >> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Tonghao Zhang >> Sent: Friday, January 5, 2018 10:11 PM >> To: dev@dpdk.org >> Cc: Tonghao Zhang >> Subject: [dpdk-dev] [PATCH 1/5] net/ixgbevf: unregiste

Re: [dpdk-dev] [PATCH] examples/ipsec-secgw: add cryptodev mask option

2018-01-11 Thread De Lara Guarch, Pablo
> -Original Message- > From: Akhil Goyal [mailto:akhil.go...@nxp.com] > Sent: Thursday, December 14, 2017 6:52 AM > To: dev@dpdk.org > Cc: De Lara Guarch, Pablo ; > hemant.agra...@nxp.com; Gonzalez Monroy, Sergio > ; Nicolau, Radu > ; Akhil Goyal > Subject: [PATCH] examples/ipsec-secgw:

Re: [dpdk-dev] [PATCH] vhost: support Explicit Congestion Notification

2018-01-11 Thread Yuanhan Liu
On Wed, Nov 22, 2017 at 11:19:42AM +0800, Jiayu Hu wrote: > In virtio, Explicit Congestion Notification (ECN) includes two parts: > guest ECN and host ECN. Guest ECN means the frontend can handle TSO > packets which have ECN set, and host ECN means the backend can handle > TSO packets which have EC

Re: [dpdk-dev] [PATCH 2/5] net/ixgbevf: set the inter-interrupt interval for EITR.

2018-01-11 Thread Tonghao Zhang
On Thu, Jan 11, 2018 at 3:26 PM, Xing, Beilei wrote: > > >> -Original Message- >> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Tonghao Zhang >> Sent: Friday, January 5, 2018 10:11 PM >> To: dev@dpdk.org >> Cc: Tonghao Zhang >> Subject: [dpdk-dev] [PATCH 2/5] net/ixgbevf: set the i

[dpdk-dev] [PATCH] doc: ethdev ABI change deprecation notice

2018-01-11 Thread Kirill Rybalchenko
Signed-off-by: Kirill Rybalchenko --- doc/guides/rel_notes/deprecation.rst | 6 ++ 1 file changed, 6 insertions(+) diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst index 13e8543..f0589ea 100644 --- a/doc/guides/rel_notes/deprecation.rst +++ b/doc/guid

Re: [dpdk-dev] [PATCH v2 2/6] ethdev: add port ownership

2018-01-11 Thread Matan Azrad
Hi Konstantin From: Ananyev, Konstantin, Thursday, January 11, 2018 2:40 PM > Hi Matan, > > > > > Hi Konstantin > > > > From: Ananyev, Konstantin, Wednesday, January 10, 2018 3:36 PM > > > Hi Matan, > > > > > > Few comments from me below. > > > BTW, do you plan to add ownership mandatory check in

Re: [dpdk-dev] [PATCH] net/i40e: fix VF reset stats crash

2018-01-11 Thread Van Haaren, Harry
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of David C Harton > Sent: Thursday, January 11, 2018 1:24 PM > To: Wu, Jingjing ; Xing, Beilei > > Cc: dev@dpdk.org; David C Harton ; Zhao1, Wei > > Subject: [dpdk-dev] [PATCH] net/i40e: fix VF reset stats crash > > Calling i40evf_dev_xstats_re

Re: [dpdk-dev] [PATCH] net/i40e: fix VF reset stats crash

2018-01-11 Thread David Harton (dharton)
> -Original Message- > From: Van Haaren, Harry [mailto:harry.van.haa...@intel.com] > > > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of David C Harton > > > > Calling i40evf_dev_xstats_reset can sometimes crash. > > > > Fixed issue by adding a pstats NULL check. > > Perhaps add a n

Re: [dpdk-dev] [PATCH] net/i40e: fix VF reset stats crash

2018-01-11 Thread Van Haaren, Harry
> From: David Harton (dharton) [mailto:dhar...@cisco.com] > Sent: Thursday, January 11, 2018 2:59 PM > To: Van Haaren, Harry ; Wu, Jingjing > ; Xing, Beilei > Cc: dev@dpdk.org; Zhao1, Wei > Subject: RE: [dpdk-dev] [PATCH] net/i40e: fix VF reset stats crash > > > > -Original Message- > >

Re: [dpdk-dev] [pull-request] next-qos 18.02 pre-rc1

2018-01-11 Thread Dumitrescu, Cristian
> -Original Message- > From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Thursday, January 11, 2018 2:13 PM > To: Dumitrescu, Cristian > Cc: dev@dpdk.org; Singh, Jasvinder > Subject: Re: [pull-request] next-qos 18.02 pre-rc1 > > 11/01/2018 14:51, Cristian Dumitrescu: > > Crist

[dpdk-dev] [PATCH v3] net/i40e: fix VF reset stats crash

2018-01-11 Thread David C Harton
Calling i40evf_dev_xstats_reset can sometimes crash. Fixed issue by checking return code before using pstats. Fixes: 8210e9e0d805e ("net/i40e: fix clear xstats bug in VF") Cc: wei.zh...@intel.com Signed-off-by: David C Harton --- v2: * Fixed fixes line in commit message. v3: * Modified condit

Re: [dpdk-dev] [PATCH v6 22/23] doc: add event timer adapter section to programmer's guide

2018-01-11 Thread Kovacevic, Marko
> Signed-off-by: Erik Gabriel Carrillo > --- > doc/guides/prog_guide/event_timer_adapter.rst | 301 > ++ > doc/guides/prog_guide/index.rst | 1 + > 2 files changed, 302 insertions(+) > create mode 100644 doc/guides/prog_guide/event_timer_adapter.rst <...>

Re: [dpdk-dev] [PATCH v4] net/ixgbe: fix l3fwd start failed on VF

2018-01-11 Thread Wu, Yanglong
Hi daiwei: After I double checked with this bug, the problem can be described as follow: When we start PF using testpmd like this: testpmd -c 0x3 -n 4 --socket-mem=1024,1024 --file-prefix=pf -w :05:00.0 -w :05:00.1 -- -i. The number of queue signed to each port would be 1 and the rxmode

Re: [dpdk-dev] [PATCH 4/5] net/ixgbevf: add check for rte_intr_enable.

2018-01-11 Thread Tonghao Zhang
On Thu, Jan 11, 2018 at 3:06 PM, Xing, Beilei wrote: > > >> -Original Message- >> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Tonghao Zhang >> Sent: Friday, January 5, 2018 10:11 PM >> To: dev@dpdk.org >> Cc: Tonghao Zhang >> Subject: [dpdk-dev] [PATCH 4/5] net/ixgbevf: add check

[dpdk-dev] [PATCH 0/5] net/mrvl: fix recently found pmd issues

2018-01-11 Thread Tomasz Duszynski
Following commits provide fixes for a few recently found NET MRVL PMD issues. Natalie Samsonov (5): net/mrvl: fix multiple probe issue net/mrvl: fix hif objects allocation net/mrvl: fix oversize bpool handling net/mrvl: fix shadow queue tail and size calculations net/mrvl: keep shadow tx

[dpdk-dev] [PATCH 2/5] net/mrvl: fix hif objects allocation

2018-01-11 Thread Tomasz Duszynski
From: Natalie Samsonov 1. Add checking for non-EAL threads. 2. Create hif objects on first use since sometimes on probe not all lcores are initialized and can be added later. In this case the hif objects for later cores were not created and this caused system crash. Fixes: 0ddc9b8 ("ne

[dpdk-dev] [PATCH 1/5] net/mrvl: fix multiple probe issue

2018-01-11 Thread Tomasz Duszynski
From: Natalie Samsonov MUSDK library initialization and cleanup should be done once. This commit fixes that by doing necessary initialization once the first port is probed and cleanup once the last port is removed. Fixes: 0ddc9b8 ("net/mrvl: add net PMD skeleton") Signed-off-by: Natalie Samsono

  1   2   3   >