[dpdk-dev] [PATCH v5 7/7] dpaa2: register dpaa2 as platform HW mempool on runtime

2018-01-19 Thread Hemant Agrawal
Detect if the DPAA2 mempool objects are present and register it as platform default hw mempool Signed-off-by: Hemant Agrawal --- config/defconfig_arm64-dpaa2-linuxapp-gcc | 1 - drivers/bus/fslmc/portal/dpaa2_hw_dpbp.c | 3 +++ drivers/bus/fslmc/portal/dpaa2_hw_pvt.h | 2 ++ drivers/mempool/d

[dpdk-dev] [PATCH v5 0/7] Dynamic HW Mempool Detection Support

2018-01-19 Thread Hemant Agrawal
W.r.t the multiple discussions in the past about the ability to dynamically detect the HW mempool support. [1],[2] & [3] This patchset helps in removing the current static mempool selection model and provides a flexible model to select the pktmbuf mempool in more dynamic way. 1) This patchset upd

[dpdk-dev] [PATCH v5 5/7] app/testpmd: set preferred mempool as default pktpool

2018-01-19 Thread Hemant Agrawal
From: Pavan Nikhilesh Set the mempool preferred by the ethernet devices as default mbuf mempool before creating the pktpool. Signed-off-by: Pavan Nikhilesh Signed-off-by: Hemant Agrawal --- app/test-pmd/testpmd.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/app/test-pmd/testpmd.c b/

[dpdk-dev] [PATCH v5 4/7] mbuf: pktmbuf pool create helper for specific mempool ops

2018-01-19 Thread Hemant Agrawal
Introduce a new helper for pktmbuf pool, which will allow the application to optionally specify the mempool ops name as well. Signed-off-by: Hemant Agrawal --- lib/librte_mbuf/rte_mbuf.c | 23 +-- lib/librte_mbuf/rte_mbuf.h | 42 ++ 2 f

[dpdk-dev] [PATCH v5 2/7] mbuf: maintain user and compile time mempool ops name

2018-01-19 Thread Hemant Agrawal
This patch change the logic to maintain the value of user defined and compile time i.e. RTE_MBUF_DEFAULT_MEMPOOL_OPS. The pktmbuf_create_pool is updated to reflect the same. Signed-off-by: Hemant Agrawal --- lib/librte_eal/common/eal_common_options.c | 2 +- lib/librte_mbuf/rte_mbuf.c

[dpdk-dev] [PATCH v5 1/7] eal: prefix mbuf pool ops name with user defined

2018-01-19 Thread Hemant Agrawal
This patch prefix the mbuf pool ops name with "user" to indicate that it is user defined. Signed-off-by: Hemant Agrawal --- lib/librte_eal/bsdapp/eal/eal.c | 4 ++-- lib/librte_eal/common/eal_internal_cfg.h | 3 ++- lib/librte_eal/linuxapp/eal/eal.c| 4 ++-- 3 files changed, 6 i

[dpdk-dev] [PATCH v5 6/7] dpaa: register dpaa as platform HW mempool on runtime

2018-01-19 Thread Hemant Agrawal
Signed-off-by: Hemant Agrawal --- config/defconfig_arm64-dpaa-linuxapp-gcc | 1 - drivers/bus/dpaa/dpaa_bus.c | 2 ++ drivers/bus/dpaa/rte_dpaa_bus.h | 2 ++ drivers/mempool/dpaa/dpaa_mempool.c | 2 +- 4 files changed, 5 insertions(+), 2 deletions(-) diff --git a/confi

[dpdk-dev] [PATCH v5 3/7] mbuf: add pool ops name selection API helpers

2018-01-19 Thread Hemant Agrawal
This patch add support for various mempool ops config helper APIs. 1.User defined mempool ops 2.Platform detected HW mempool ops (active). 3.Best selection of mempool ops by looking into user defined, platform registered and compile time configured. Signed-off-by: Hemant Agrawal --- doc/api/d

[dpdk-dev] Compilation errors in drivers/event/opdl/

2018-01-19 Thread Patil, Harish
Hi, I am seeing below compilation errors in drivers/event/opdl/, this is with cloned latest DPDK (git clone http://dpdk.org/git/dpdk). .. .. /home2/hpatil/e4/jan19-inbox-submit/dpdk/drivers/event/opdl/opdl_evdev_xsta ts.c: In function ‘opdl_xstats_get_names’: /home2/hpatil/e4/jan19-inbox-subm

Re: [dpdk-dev] [PATCH v2 2/6] ethdev: add port ownership

2018-01-19 Thread Tuxdriver
Writing from my phone, so sorry for typos and top posting. Need to apologise for a misunderstanding on my part. I had a dyslexic moment and reversed the validity check on the port owner comparison. What I thought was => was actually =<, and so my concern that only the last allocated owner is

Re: [dpdk-dev] [PATCH] cmdline: fix dynamic tokens parsing

2018-01-19 Thread Xueming(Steven) Li
Sorry, sent wrong patch, please ignore this one. > -Original Message- > From: Xueming(Steven) Li > Sent: Saturday, January 20, 2018 10:30 AM > To: Xueming(Steven) Li ; Olivier MATZ > > Cc: dev@dpdk.org; Adrien Mazarguil ; > sta...@dpdk.org > Subject: RE: [PATCH] cmdline: fix dynamic token

[dpdk-dev] [PATCH] cmdline: avoid garbage in unused fields of parsed result

2018-01-19 Thread Xueming Li
The result buffer was not initialized before parsing, inducing garbage in unused fields or padding of the parsed structure. Initialize the result buffer each time before parsing. Fixes: af75078fece3 ("first public release") Cc: sta...@dpdk.org Signed-off-by: Xueming Li --- lib/librte_cmdline/cm

Re: [dpdk-dev] [PATCH] cmdline: fix dynamic tokens parsing

2018-01-19 Thread Xueming(Steven) Li
Hi Olivier, Almost forgot this one, my original proposal for CLI issue. Split out according to your suggestion. Thanks, Xueming > -Original Message- > From: Xueming Li [mailto:xuemi...@mellanox.com] > Sent: Saturday, January 20, 2018 10:26 AM > To: Olivier MATZ > Cc: Xueming(Steven) Li

[dpdk-dev] [PATCH] cmdline: fix dynamic tokens parsing

2018-01-19 Thread Xueming Li
When using dynamic tokens, the result buffer contains pointers to some location inside the result buffer. When the content of the temporary buffer is copied in the final one, these pointers still point to the temporary buffer. This works until the temporary buffer is kept intact, but the next comm

Re: [dpdk-dev] [PATCH] app/testpmd: change log level at run time

2018-01-19 Thread Ferruh Yigit
On 1/19/2018 10:19 PM, Elza Mathew wrote: > Introduced a run time command to change the > log level for a given log type. Added the > necessary documentation. > > Signed-off-by: Elza Mathew Reviewed-by: Ferruh Yigit

Re: [dpdk-dev] [PATCH v6 0/8] Introduce virtual driver for Hyper-V/Azure platforms

2018-01-19 Thread Ferruh Yigit
On 1/18/2018 1:51 PM, Matan Azrad wrote: > Virtual machines hosted by Hyper-V/Azure platforms are fitted with simplified > virtual network devices named NetVSC that are used for fast communication > between VM to VM, VM to hypervisor, and the outside. > > They appear as standard system netdevice

Re: [dpdk-dev] [PATCH] maintainers: update for ipsec-secgw

2018-01-19 Thread Thomas Monjalon
> > Signed-off-by: Akhil Goyal > > Acked-by: Pablo de Lara Applied, thanks

Re: [dpdk-dev] [PATCH v2 2/6] ethdev: add port ownership

2018-01-19 Thread Neil Horman
On Fri, Jan 19, 2018 at 09:19:18PM +0100, Thomas Monjalon wrote: Apolgies for the top post, but I'm preparing for a trip out of the country, and so may not have time to fully answer these questions until I get back (or at least until I get someplace with power and internet). If the conversation is

[dpdk-dev] [dpdk-announce] DPDK Summit – Bangalore March 9th

2018-01-19 Thread Tibrewala, Sujata
The first DPDK Summit of 2018 will take place in the Leela Palace hotel [1] in Bangalore on Friday March 9th. The event will cover the latest developments to the DPDK framework, and their application to a variety of industry segments including telecom, cloud, enterprise and security. The event e

[dpdk-dev] [PATCH] app/testpmd: change log level at run time

2018-01-19 Thread Elza Mathew
Introduced a run time command to change the log level for a given log type. Added the necessary documentation. Signed-off-by: Elza Mathew --- app/test-pmd/cmdline.c | 53 + doc/guides/testpmd_app_ug/testpmd_funcs.rst | 19 +++ 2 files chan

Re: [dpdk-dev] [PATCH 1/2] crypto/dpaa2_sec: support for scatter gather

2018-01-19 Thread De Lara Guarch, Pablo
Hi Akhil, > -Original Message- > From: Akhil Goyal [mailto:akhil.go...@nxp.com] > Sent: Friday, January 19, 2018 11:51 AM > To: dev@dpdk.org > Cc: De Lara Guarch, Pablo ; > hemant.agra...@nxp.com; alok.makhar...@nxp.com; Akhil Goyal > > Subject: [PATCH 1/2] crypto/dpaa2_sec: support for s

Re: [dpdk-dev] [PATCH v2 2/6] ethdev: add port ownership

2018-01-19 Thread Thomas Monjalon
19/01/2018 20:47, Neil Horman: > On Fri, Jan 19, 2018 at 07:12:36PM +0100, Thomas Monjalon wrote: > > 19/01/2018 18:43, Neil Horman: > > > On Fri, Jan 19, 2018 at 06:17:51PM +0100, Thomas Monjalon wrote: > > > > 19/01/2018 16:27, Neil Horman: > > > > > On Fri, Jan 19, 2018 at 03:13:47PM +0100, Thom

Re: [dpdk-dev] [PATCH] ethdev: add missing doxygen

2018-01-19 Thread Ferruh Yigit
On 1/19/2018 8:10 PM, Ferruh Yigit wrote: > On 1/19/2018 11:42 AM, Radu Nicolau wrote: >> Added missing doxygen for rte_eth_dev_get_sec_ctx >> and moved the declaration to the proper place. >> >> Signed-off-by: Radu Nicolau > > Reviewed-by: Ferruh Yigit Applied to dpdk-next-net/master, thanks.

Re: [dpdk-dev] [PATCH] ethdev: add missing doxygen

2018-01-19 Thread Ferruh Yigit
On 1/19/2018 11:42 AM, Radu Nicolau wrote: > Added missing doxygen for rte_eth_dev_get_sec_ctx > and moved the declaration to the proper place. > > Signed-off-by: Radu Nicolau Reviewed-by: Ferruh Yigit

Re: [dpdk-dev] [dpdk-stable] [PATCH] net/failsafe: fix default Rx offload capabilities

2018-01-19 Thread Ferruh Yigit
On 1/19/2018 10:33 AM, Gaëtan Rivet wrote: > Hi Moti, > > On Fri, Jan 19, 2018 at 11:42:48AM +0200, Moti Haimovsky wrote: >> This commit enhances the default Rx offload capabilities of the >> failsafe device to initially support all possible capabilities. >> This is done in order to support a wide

Re: [dpdk-dev] [PATCH] doc: advertise mbuf fast free in sfc feature list

2018-01-19 Thread Ferruh Yigit
On 1/19/2018 9:21 AM, Andrew Rybchenko wrote: > From: Ivan Malov > > Fixes: bb0c613f1eed ("net/sfc: convert to the new Tx offload API") > > Signed-off-by: Ivan Malov > Signed-off-by: Andrew Rybchenko > --- > Feel free to squash the fix into fixes changeset. Squashed into relevant commit in ne

Re: [dpdk-dev] [PATCH] net/sfc/base: fix unused argument warning

2018-01-19 Thread Ferruh Yigit
On 1/19/2018 6:47 AM, Andrew Rybchenko wrote: > From: Andy Moreton > > The type_data argument to ef10_rx_qcreate is only used > in builds with EFSYS_OPT_RX_PACKED_STREAM. note this as > an usued argument to avoid warnings in builds without > packed stream support. > > Fixes: b749646dade4 ("net/s

Re: [dpdk-dev] [PATCH v2 2/6] ethdev: add port ownership

2018-01-19 Thread Neil Horman
On Fri, Jan 19, 2018 at 07:12:36PM +0100, Thomas Monjalon wrote: > 19/01/2018 18:43, Neil Horman: > > On Fri, Jan 19, 2018 at 06:17:51PM +0100, Thomas Monjalon wrote: > > > 19/01/2018 16:27, Neil Horman: > > > > On Fri, Jan 19, 2018 at 03:13:47PM +0100, Thomas Monjalon wrote: > > > > > 19/01/2018 1

Re: [dpdk-dev] [dpdk-stable] [PATCH v3] doc: fix link bonding PMD typo in prog guide

2018-01-19 Thread Ferruh Yigit
On 1/19/2018 2:21 AM, Zhiyong Yang wrote: > fix one typo and a grammatical mistake. > > Fixes: b0152b1b40fe ("doc: update bonding") > Cc: sta...@dpdk.org > > Signed-off-by: Zhiyong Yang > Acked-by: Marko Kovacevic Applied to dpdk-next-net/master, thanks.

Re: [dpdk-dev] [PATCH v3] net/dpaa: add null point check and fix mem leak

2018-01-19 Thread Ferruh Yigit
On 1/18/2018 11:48 AM, Yong Wang wrote: > There are several func calls to rte_zmalloc() which don't do null > point check on the return value. And before return, the memory is not > freed. Fix it by adding null point check and rte_free(). Fixes: 37f9b54bd3cf ("net/dpaa: support Tx and Rx queu

Re: [dpdk-dev] [RFC 24/24] WORKAROUND examples/vhost_scsi: avoid broken EVENT_IDX

2018-01-19 Thread Michael S. Tsirkin
On Fri, Jan 19, 2018 at 01:44:44PM +, Stefan Hajnoczi wrote: > The EVENT_IDX code in DPDK is broken. It's missing the > signalled_used_valid flag that handles the corner cases (startup and > wrapping). Disable it for now. > > Signed-off-by: Stefan Hajnoczi FYI signalled_used_valid isn't st

Re: [dpdk-dev] [PATCH v3 02/10] app/testpmd: convert to new Ethdev Rx offloads API

2018-01-19 Thread Patil, Harish
-Original Message- From: dev on behalf of Shahaf Shuler Date: Tuesday, December 26, 2017 at 1:44 AM To: "jingjing...@intel.com" , "ferruh.yi...@intel.com" Cc: "dev@dpdk.org" Subject: [dpdk-dev] [PATCH v3 02/10] app/testpmd: convert to new Ethdev Rx offloads API >Ethdev Rx offloads

Re: [dpdk-dev] [PATCH v4] net/mlx5: load libmlx5 and libibverbs in run-time

2018-01-19 Thread Marcelo Ricardo Leitner
Hello, On Thu, Jan 04, 2018 at 08:36:08AM +0100, Nélio Laranjeiro wrote: > Hi Shachar, > > On Wed, Jan 03, 2018 at 03:00:46PM +, Shachar Beiser wrote: > > > > > --- a/config/common_base > > > > +++ b/config/common_base > > > > @@ -236,6 +236,7 @@ CONFIG_RTE_LIBRTE_MLX4_TX_MP_CACHE=8 > > > >

Re: [dpdk-dev] [PATCH v4] net/mlx5: load libmlx5 and libibverbs in run-time

2018-01-19 Thread Marcelo Ricardo Leitner
Hi, On Sun, Dec 31, 2017 at 07:52:51AM +, Shachar Beiser wrote: > MLX5 PMD loads libraries: libibverbs and libmlx5. > MLX5 PMD is not linked to external libraries. > > Signed-off-by: Shachar Beiser > --- > v1: > load external libraries in run-time > v2: > * fix checkpatch warnings

[dpdk-dev] [PATCH v4 2/2] build: add support for detecting march on ARM

2018-01-19 Thread Pavan Nikhilesh
Added support for detecting march and mcpu by reading midr_el1 register. The implementer, primary part number values read can be used to figure out the underlying arm cpu. Signed-off-by: Pavan Nikhilesh --- app/test-pmd/meson.build| 2 +- config/arm/armv8_machine.py | 18 +++ config

[dpdk-dev] [PATCH v4 1/2] build: add support for ARM builds

2018-01-19 Thread Pavan Nikhilesh
From: Bruce Richardson Add files to enable compiling for ARM cross builds. This can be tested by doing a cross-compile for armv8-a type using the linaro gcc toolchain. meson arm-build --cross-file aarch64_cross.txt ninja -C arm-build where aarch64_cross.txt contained the followi

Re: [dpdk-dev] [PATCH v2] lib/cmdline: init CLI parsing memory

2018-01-19 Thread Xueming(Steven) Li
> -Original Message- > From: Olivier Matz [mailto:olivier.m...@6wind.com] > Sent: Friday, January 19, 2018 5:07 PM > To: Xueming(Steven) Li > Cc: Adrien Mazarguil ; dev@dpdk.org > Subject: Re: [PATCH v2] lib/cmdline: init CLI parsing memory > > On Thu, Jan 18, 2018 at 04:29:59AM +,

Re: [dpdk-dev] [PATCH v6 4/6] ethdev: adjust APIs removal error report

2018-01-19 Thread Thomas Monjalon
19/01/2018 19:13, Ferruh Yigit: > On 1/19/2018 5:54 PM, Thomas Monjalon wrote: > > 19/01/2018 17:19, Ferruh Yigit: > >> On 1/18/2018 6:10 PM, Matan Azrad wrote: > >>> From: Ferruh Yigit, Thursday, January 18, 2018 7:31 PM > This patch updates *all* ethdev public APIs to add if device is remove

[dpdk-dev] [PATCH v3] cmdline: fix dynamic tokens parsing

2018-01-19 Thread Xueming Li
When using dynamic tokens, the result buffer contains pointers to some location inside the result buffer. When the content of the temporary buffer is copied in the final one, these pointers still point to the temporary buffer. This works until the temporary buffer is kept intact, but the next comm

[dpdk-dev] [PATCH v4 3/4] event: add octeontx event device to meson build

2018-01-19 Thread Pavan Nikhilesh
Add Cavium octeontx to meson build and change order of drivers built from event->mempool->net to mempool->net->event to resolve dependency. Signed-off-by: Pavan Nikhilesh Acked-by: Bruce Richardson --- drivers/event/meson.build | 2 +- drivers/event/octeo

[dpdk-dev] [PATCH v4 4/4] app/test-eventdev: add test-eventdev to meson build

2018-01-19 Thread Pavan Nikhilesh
Signed-off-by: Pavan Nikhilesh Acked-by: Bruce Richardson --- app/meson.build | 1 + app/test-eventdev/meson.build | 28 2 files changed, 29 insertions(+) create mode 100644 app/test-eventdev/meson.build diff --git a/app/meson.build b/app/meson.build

[dpdk-dev] [PATCH v4 2/4] drivers/net: add drivers for Cavium NICs to meson build

2018-01-19 Thread Pavan Nikhilesh
Add Cavium octeontx and thunder nicvf to meson build infrastructure. Signed-off-by: Pavan Nikhilesh --- drivers/net/meson.build | 3 ++- drivers/net/octeontx/base/meson.build | 21 + drivers/net/octeontx/meson.build

[dpdk-dev] [PATCH v4 1/4] drivers/mempool: add octeontx mempool driver to meson build

2018-01-19 Thread Pavan Nikhilesh
Add octeontx hardware mempool driver to meson build. Signed-off-by: Pavan Nikhilesh Acked-by: Bruce Richardson --- v4 Changes: - fix incompatable flag with clang (net/thunderx) - add flag to ignore uninitialized warning (net/thunderx) v3 Changes: - added flag to disable array prefetch

Re: [dpdk-dev] [PATCH v6 4/6] ethdev: adjust APIs removal error report

2018-01-19 Thread Ferruh Yigit
On 1/19/2018 5:54 PM, Thomas Monjalon wrote: > 19/01/2018 17:19, Ferruh Yigit: >> On 1/18/2018 6:10 PM, Matan Azrad wrote: >>> From: Ferruh Yigit, Thursday, January 18, 2018 7:31 PM This patch updates *all* ethdev public APIs to add if device is removed check? >>> >>> Yes. >>> And ea

Re: [dpdk-dev] [PATCH v2 2/6] ethdev: add port ownership

2018-01-19 Thread Thomas Monjalon
19/01/2018 18:43, Neil Horman: > On Fri, Jan 19, 2018 at 06:17:51PM +0100, Thomas Monjalon wrote: > > 19/01/2018 16:27, Neil Horman: > > > On Fri, Jan 19, 2018 at 03:13:47PM +0100, Thomas Monjalon wrote: > > > > 19/01/2018 14:30, Neil Horman: > > > > > So it seems like the real point of contention

Re: [dpdk-dev] [PATCH v2 2/6] ethdev: add port ownership

2018-01-19 Thread Thomas Monjalon
19/01/2018 18:37, Neil Horman: > On Fri, Jan 19, 2018 at 06:09:47PM +0100, Thomas Monjalon wrote: > > 19/01/2018 15:32, Neil Horman: > > > On Fri, Jan 19, 2018 at 03:07:28PM +0100, Thomas Monjalon wrote: > > > > 19/01/2018 14:57, Neil Horman: > > > > > > > I specifically pointed that out above. Th

Re: [dpdk-dev] [PATCH v6 4/6] ethdev: adjust APIs removal error report

2018-01-19 Thread Thomas Monjalon
19/01/2018 17:19, Ferruh Yigit: > On 1/18/2018 6:10 PM, Matan Azrad wrote: > > From: Ferruh Yigit, Thursday, January 18, 2018 7:31 PM > >> This patch updates *all* ethdev public APIs to add if device is removed > >> check? > > > > Yes. > > > >> And each check goes to ethdev is_removed() dev_ops t

Re: [dpdk-dev] [PATCH] vhost: fix ANY_LAYOUT declaration

2018-01-19 Thread Tan, Jianfeng
On 1/19/2018 10:42 PM, Yuanhan Liu wrote: On Fri, Jan 19, 2018 at 02:02:50PM -0500, Zhihong Wang wrote: The VIRTIO_F_ANY_LAYOUT feature indicates the device accepts arbitrary descriptor layouts. The vhost-user lib already supports it, but the feature declaration is missing. This patch fixes th

Re: [dpdk-dev] [PATCH v2 2/6] ethdev: add port ownership

2018-01-19 Thread Neil Horman
On Fri, Jan 19, 2018 at 06:17:51PM +0100, Thomas Monjalon wrote: > 19/01/2018 16:27, Neil Horman: > > On Fri, Jan 19, 2018 at 03:13:47PM +0100, Thomas Monjalon wrote: > > > 19/01/2018 14:30, Neil Horman: > > > > So it seems like the real point of contention that we need to settle > > > > here is,

Re: [dpdk-dev] [PATCH v2] vfio: noiommu check error handling

2018-01-19 Thread Maxime Coquelin
On 10/31/2017 04:59 PM, Jonas Pfefferle wrote: Check and report errors on open/read in noiommu check. Signed-off-by: Jonas Pfefferle --- lib/librte_eal/linuxapp/eal/eal_vfio.c | 29 + 1 file changed, 21 insertions(+), 8 deletions(-) I agree with the fix, Kerne

Re: [dpdk-dev] [PATCH v2 2/6] ethdev: add port ownership

2018-01-19 Thread Neil Horman
On Fri, Jan 19, 2018 at 06:09:47PM +0100, Thomas Monjalon wrote: > 19/01/2018 15:32, Neil Horman: > > On Fri, Jan 19, 2018 at 03:07:28PM +0100, Thomas Monjalon wrote: > > > 19/01/2018 14:57, Neil Horman: > > > > > > I specifically pointed that out above. There is no reason an > > > > > > owernshi

Re: [dpdk-dev] [PATCH] build: add support for vendor specific ARM cross builds

2018-01-19 Thread Bruce Richardson
On Fri, Jan 19, 2018 at 10:56:08PM +0530, Pavan Nikhilesh wrote: > On Fri, Jan 19, 2018 at 04:41:26PM +, Bruce Richardson wrote: > > On Fri, Jan 19, 2018 at 06:45:08PM +0530, Pavan Nikhilesh wrote: > > > Add various vendor specific cross build targets. > > > This can be verified by using linaro

Re: [dpdk-dev] [PATCH v6 4/6] ethdev: adjust APIs removal error report

2018-01-19 Thread Ananyev, Konstantin
> -Original Message- > From: Yigit, Ferruh > Sent: Friday, January 19, 2018 4:19 PM > To: Matan Azrad ; Adrien Mazarguil > ; Gaetan Rivet > Cc: Thomas Monjalon ; dev@dpdk.org; Andrew Rybchenko > ; Ananyev, Konstantin > ; Alejandro Lucero > ; Jerin Jacob > ; Hemant Agrawal ; > Shahaf

Re: [dpdk-dev] [PATCH v11 5/5] net/virtio: support GUEST ANNOUNCE

2018-01-19 Thread Ferruh Yigit
On 1/16/2018 9:41 PM, Xiao Wang wrote: > When live migration is done, for the backup VM, either the virtio > frontend or the vhost backend needs to send out gratuitous RARP packet > to announce its new network location. > > This patch enables VIRTIO_NET_F_GUEST_ANNOUNCE feature to support live > m

Re: [dpdk-dev] [PATCH v3 1/2] build: add support for ARM builds

2018-01-19 Thread Bruce Richardson
On Fri, Jan 19, 2018 at 04:49:04PM +, Hemant Agrawal wrote: > HI Bruce, > Are these planned for 18.02? If so, I will prioritize this work. > > Regards, > Hemant > Hi Hemant, yes, this is planned to be merged as *experimental* for 18.02. If no feedback, I'll pull them as-is for 18.02

Re: [dpdk-dev] [PATCH] keepalive: fix keepalive state alignment

2018-01-19 Thread Van Haaren, Harry
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Andriy Berestovskyy > Sent: Friday, January 19, 2018 2:48 PM > To: dev@dpdk.org > Cc: Horton, Remy > Subject: [dpdk-dev] [PATCH] keepalive: fix keepalive state alignment > > The __rte_cache_aligned was applied to the whole array, > not the ar

Re: [dpdk-dev] [PATCH v3 2/2] build: add support for detecting march on ARM

2018-01-19 Thread Bruce Richardson
On Fri, Jan 19, 2018 at 10:43:31PM +0530, Pavan Nikhilesh wrote: > On Fri, Jan 19, 2018 at 04:17:41PM +, Bruce Richardson wrote: > > On Fri, Jan 19, 2018 at 07:22:51PM +0530, Pavan Nikhilesh wrote: > > > Added support for detecting march and mcpu by reading midr_el1 register. > > > The implemen

Re: [dpdk-dev] [PATCH v3 2/4] drivers/net: add drivers for Cavium NICs to meson build

2018-01-19 Thread Pavan Nikhilesh
On Fri, Jan 19, 2018 at 05:16:30PM +, Bruce Richardson wrote: > On Fri, Jan 19, 2018 at 06:42:02PM +0530, Pavan Nikhilesh wrote: > > Add Cavium octeontx and thunder nicvf to meson build infrastructure. > > > > Signed-off-by: Pavan Nikhilesh > > --- > > drivers/net/meson.build

Re: [dpdk-dev] [PATCH v3 4/4] app/test-eventdev: add test-eventdev to meson build

2018-01-19 Thread Bruce Richardson
On Fri, Jan 19, 2018 at 06:42:04PM +0530, Pavan Nikhilesh wrote: > Signed-off-by: Pavan Nikhilesh > --- Acked-by: Bruce Richardson

Re: [dpdk-dev] [PATCH] build: add support for vendor specific ARM cross builds

2018-01-19 Thread Pavan Nikhilesh
On Fri, Jan 19, 2018 at 04:41:26PM +, Bruce Richardson wrote: > On Fri, Jan 19, 2018 at 06:45:08PM +0530, Pavan Nikhilesh wrote: > > Add various vendor specific cross build targets. > > This can be verified by using linaro toolchain and running > > > > meson build --cross-file config/arm/ar

[dpdk-dev] [PATCH v4 4/7] mbuf: pktmbuf pool create helper for specific mempool ops

2018-01-19 Thread Hemant Agrawal
Introduce a new helper for pktmbuf pool, which will allow the application to optionally specify the mempool ops name as well. Signed-off-by: Hemant Agrawal --- lib/librte_mbuf/rte_mbuf.c | 23 +-- lib/librte_mbuf/rte_mbuf.h | 42 ++ 2 f

[dpdk-dev] [PATCH v4 1/7] eal: prefix mbuf pool ops name with user defined

2018-01-19 Thread Hemant Agrawal
This patch prefix the mbuf pool ops name with "user" to indicate that it is user defined. Signed-off-by: Hemant Agrawal --- lib/librte_eal/bsdapp/eal/eal.c | 4 ++-- lib/librte_eal/common/eal_internal_cfg.h | 3 ++- lib/librte_eal/linuxapp/eal/eal.c| 4 ++-- 3 files changed, 6 i

[dpdk-dev] [PATCH v4 6/7] dpaa: register dpaa as platform HW mempool on runtime

2018-01-19 Thread Hemant Agrawal
Signed-off-by: Hemant Agrawal --- config/defconfig_arm64-dpaa-linuxapp-gcc | 1 - drivers/bus/dpaa/dpaa_bus.c | 2 ++ drivers/bus/dpaa/rte_dpaa_bus.h | 2 ++ drivers/mempool/dpaa/dpaa_mempool.c | 2 +- 4 files changed, 5 insertions(+), 2 deletions(-) diff --git a/confi

[dpdk-dev] [PATCH v4 2/7] mbuf: maintain user and compile time mempool ops name

2018-01-19 Thread Hemant Agrawal
This patch change the logic to maintain the value of user defined and compile time i.e. RTE_MBUF_DEFAULT_MEMPOOL_OPS. The pktmbuf_create_pool is updated to reflect the same. Signed-off-by: Hemant Agrawal --- lib/librte_eal/common/eal_common_options.c | 2 +- lib/librte_mbuf/rte_mbuf.c

Re: [dpdk-dev] [PATCH v3 3/4] event: add octeontx event device to meson build

2018-01-19 Thread Bruce Richardson
On Fri, Jan 19, 2018 at 06:42:03PM +0530, Pavan Nikhilesh wrote: > Add Cavium octeontx to meson build and change order of drivers built > from event->mempool->net to mempool->net->event to resolve dependency. > > Signed-off-by: Pavan Nikhilesh > --- Acked-by: Bruce Richardson

Re: [dpdk-dev] [PATCH v2 2/6] ethdev: add port ownership

2018-01-19 Thread Thomas Monjalon
19/01/2018 16:27, Neil Horman: > On Fri, Jan 19, 2018 at 03:13:47PM +0100, Thomas Monjalon wrote: > > 19/01/2018 14:30, Neil Horman: > > > So it seems like the real point of contention that we need to settle here > > > is, > > > what codifies an 'owner'. Must it be a specific execution context, o

Re: [dpdk-dev] [PATCH v3 2/4] drivers/net: add drivers for Cavium NICs to meson build

2018-01-19 Thread Bruce Richardson
On Fri, Jan 19, 2018 at 06:42:02PM +0530, Pavan Nikhilesh wrote: > Add Cavium octeontx and thunder nicvf to meson build infrastructure. > > Signed-off-by: Pavan Nikhilesh > --- > drivers/net/meson.build | 3 ++- > drivers/net/octeontx/base/meson.build |

Re: [dpdk-dev] [PATCH v3 2/2] build: add support for detecting march on ARM

2018-01-19 Thread Pavan Nikhilesh
On Fri, Jan 19, 2018 at 04:17:41PM +, Bruce Richardson wrote: > On Fri, Jan 19, 2018 at 07:22:51PM +0530, Pavan Nikhilesh wrote: > > Added support for detecting march and mcpu by reading midr_el1 register. > > The implementer, primary part number values read can be used to figure > > out the un

Re: [dpdk-dev] [PATCH v2 2/6] ethdev: add port ownership

2018-01-19 Thread Thomas Monjalon
19/01/2018 15:32, Neil Horman: > On Fri, Jan 19, 2018 at 03:07:28PM +0100, Thomas Monjalon wrote: > > 19/01/2018 14:57, Neil Horman: > > > > > I specifically pointed that out above. There is no reason an > > > > > owernship record > > > > > couldn't be added to the rte_eth_dev structure. > > > >

Re: [dpdk-dev] [PATCH v3 1/2] build: add support for ARM builds

2018-01-19 Thread Hemant Agrawal
HI Bruce, Are these planned for 18.02? If so, I will prioritize this work. Regards, Hemant > -Original Message- > From: Bruce Richardson [mailto:bruce.richard...@intel.com] > Sent: Friday, January 19, 2018 9:54 PM > To: Pavan Nikhilesh > Cc: jerin.ja...@caviumnetworks.com; harr

Re: [dpdk-dev] [PATCH v3 1/4] drivers/mempool: add octeontx mempool driver to meson build

2018-01-19 Thread Bruce Richardson
On Fri, Jan 19, 2018 at 06:42:01PM +0530, Pavan Nikhilesh wrote: > Add octeontx hardware mempool driver to meson build. > > Signed-off-by: Pavan Nikhilesh > --- Acked-by: Bruce Richardson

Re: [dpdk-dev] [PATCH v8 2/3] ring: introduce new header file to include common functions

2018-01-19 Thread Hemant Agrawal
Hi Olivier, > On Fri, Jan 19, 2018 at 07:45:30PM +0530, Hemant Agrawal wrote: > > Hi Jia, > > > > On 1/17/2018 9:33 AM, Jia He wrote: > > > Move the common part of rte_ring.h into rte_ring_generic.h. > > > Move the memory barrier part into update_tail(). > > > > > > No functional changes here. > >

Re: [dpdk-dev] [PATCH] build: add support for vendor specific ARM cross builds

2018-01-19 Thread Bruce Richardson
On Fri, Jan 19, 2018 at 06:45:08PM +0530, Pavan Nikhilesh wrote: > Add various vendor specific cross build targets. > This can be verified by using linaro toolchain and running > > meson build --cross-file config/arm/arch64_armv8__cross > "arch64-armv8"? I thought we were standardizing on

Re: [dpdk-dev] [PATCH v8 2/3] ring: introduce new header file to include common functions

2018-01-19 Thread Olivier Matz
Hi Hemant, On Fri, Jan 19, 2018 at 07:45:30PM +0530, Hemant Agrawal wrote: > Hi Jia, > > On 1/17/2018 9:33 AM, Jia He wrote: > > Move the common part of rte_ring.h into rte_ring_generic.h. > > Move the memory barrier part into update_tail(). > > > > No functional changes here. > > > > Signed-of

[dpdk-dev] [PATCH v4 7/7] dpaa2: register dpaa2 as platform HW mempool on runtime

2018-01-19 Thread Hemant Agrawal
Detect if the DPAA2 mempool objects are present and register it as platform default hw mempool Signed-off-by: Hemant Agrawal --- config/defconfig_arm64-dpaa2-linuxapp-gcc | 1 - drivers/bus/fslmc/portal/dpaa2_hw_dpbp.c | 3 +++ drivers/bus/fslmc/portal/dpaa2_hw_pvt.h | 2 ++ drivers/mempool/d

[dpdk-dev] [PATCH v4 5/7] app/testpmd: set preferred mempool as default pktpool

2018-01-19 Thread Hemant Agrawal
From: Pavan Nikhilesh Set the mempool preferred by the ethernet devices as default mbuf mempool before creating the pktpool. Signed-off-by: Pavan Nikhilesh Signed-off-by: Hemant Agrawal --- app/test-pmd/testpmd.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/app/test-pmd/testpmd.c b/

[dpdk-dev] [PATCH v4 3/7] mbuf: add pool ops name selection API helpers

2018-01-19 Thread Hemant Agrawal
This patch add support for various mempool ops config helper APIs. 1.User defined mempool ops 2.Platform detected HW mempool ops (active). 3.Best selection of mempool ops by looking into user defined, platform registered and compile time configured. Signed-off-by: Hemant Agrawal --- lib/librt

Re: [dpdk-dev] [PATCH v5 00/15] common ethdev linkstatus functions

2018-01-19 Thread Ferruh Yigit
On 1/17/2018 4:18 PM, Ferruh Yigit wrote: > On 1/17/2018 4:05 PM, Stephen Hemminger wrote: >> On Wed, 17 Jan 2018 14:32:17 + >> Ferruh Yigit wrote: >> >>> On 1/17/2018 7:56 AM, Andrew Rybchenko wrote: On 01/16/2018 09:37 PM, Stephen Hemminger wrote: > While reviewing drivers, notice

[dpdk-dev] [PATCH v4 0/7] Dynamic HW Mempool Detection Support

2018-01-19 Thread Hemant Agrawal
W.r.t the multiple discussions in the past about the ability to dynamically detect the HW mempool support. [1],[2] & [3] This patchset helps in removing the current static mempool selection model and provides a flexible model to select the pktmbuf mempool in more dynamic way. 1) This patchset upd

[dpdk-dev] [PATCH v2 2/2] net/mlx5: fix allocation when no memory on device NUMA node

2018-01-19 Thread Olivier Matz
If there is no memory available on the same numa node than the device, it is preferable to fallback on another socket instead of failing. Fixes: 1e3a39f72d5d ("net/mlx5: allocate verbs object into shared memory") Cc: sta...@dpdk.org Signed-off-by: Olivier Matz Signed-off-by: Nelio Laranjeiro --

[dpdk-dev] [PATCH v2 1/2] net/mlx5: fix return value of start operation

2018-01-19 Thread Olivier Matz
On error, mlx5_dev_start() does not return a negative value as it is supposed to do. The consequence is that the application (ex: testpmd) does not notice that the port is not started and begins the rxtx on an uninitialized port, which crashes. Fixes: e1016cb73383 ("net/mlx5: fix Rx interrupts man

Re: [dpdk-dev] [PATCH v3 1/2] build: add support for ARM builds

2018-01-19 Thread Bruce Richardson
On Fri, Jan 19, 2018 at 07:22:50PM +0530, Pavan Nikhilesh wrote: > From: Bruce Richardson > > Add files to enable compiling for ARM cross builds. > This can be tested by doing a cross-compile for armv8-a type using > the linaro gcc toolchain. > > meson arm-build --cross-file aarch64_cros

Re: [dpdk-dev] [PATCH v6 4/6] ethdev: adjust APIs removal error report

2018-01-19 Thread Ferruh Yigit
On 1/18/2018 6:10 PM, Matan Azrad wrote: > Hi Ferruh > > From: Ferruh Yigit, Thursday, January 18, 2018 7:31 PM >> On 1/18/2018 11:27 AM, Matan Azrad wrote: >>> rte_eth_dev_is_removed API was added to detect a device removal >>> synchronously. >>> >>> When a device removal occurs during control co

Re: [dpdk-dev] [PATCH v3 2/2] build: add support for detecting march on ARM

2018-01-19 Thread Bruce Richardson
On Fri, Jan 19, 2018 at 07:22:51PM +0530, Pavan Nikhilesh wrote: > Added support for detecting march and mcpu by reading midr_el1 register. > The implementer, primary part number values read can be used to figure > out the underlying arm cpu. > > Signed-off-by: Pavan Nikhilesh > --- > app/test-p

Re: [dpdk-dev] [PATCH 1/2] net: fixup RARP generation

2018-01-19 Thread Ferruh Yigit
On 1/18/2018 3:14 AM, Yuanhan Liu wrote: > Due to a mistake operation from me, older version (v10) was merged to > master branch. It's the v11 should be applied. However, the master branch > is not rebase-able. Thus, this patch is made, from the diff between v10 > and v11. > > Code is from Xiao Wa

[dpdk-dev] [PATCH v2 4/4] net/virtio: fix typo in function name

2018-01-19 Thread Olivier Matz
Fixes: c1f86306a026 ("virtio: add new driver") Signed-off-by: Olivier Matz --- drivers/net/virtio/virtio_ethdev.c | 2 +- drivers/net/virtio/virtqueue.c | 2 +- drivers/net/virtio/virtqueue.h | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/virtio/virtio

[dpdk-dev] [PATCH v2 2/4] net/virtio: fix memory leak when reinitializing device

2018-01-19 Thread Olivier Matz
Free the previous queues and the attached mbufs before initializing new ones. The function virtio_dev_free_mbufs() is now called when reconfiguring the device, so we also need to add a check to ensure that it won't crash for uninitialized queues. Cc: sta...@dpdk.org Fixes: 60e6f4707ef2 ("net/virt

[dpdk-dev] [PATCH v2 3/4] net/virtio: rationalize queue flushing

2018-01-19 Thread Olivier Matz
Use the same kind of loop than in virtio_free_queues() and factorize common code. Signed-off-by: Olivier Matz --- drivers/net/virtio/virtio_ethdev.c | 57 -- 1 file changed, 24 insertions(+), 33 deletions(-) diff --git a/drivers/net/virtio/virtio_ethdev.c b/

[dpdk-dev] [PATCH v2 1/4] net/virtio: fix queue flushing with vector Rx enabled

2018-01-19 Thread Olivier Matz
When using vector Rx mode (use_simple_rx = 1), vq->vq_descx[] is not kept up to date. To properly detach the mbufs in this case, browse sw_ring[] instead, as it's done in virtqueue_rxvq_flush(). Since we need virtio_get_queue_type(), also move this function in virtqueue.h as a static inline. Fixe

[dpdk-dev] [PATCH v2 0/4] net/virtio: fix memory leak when reinitializing device

2018-01-19 Thread Olivier Matz
When devops->configure() is called, the queues may be reallocated if the features flag changed, but the previous are not freed. This patchset fixes this issue. To really point out the issue, I instrumented rte_malloc, rte_memzone_reserve, rte_mbuf_alloc to track the allocations and frees. For refe

Re: [dpdk-dev] [dpdk-ci] [PATCHv3 0/4] dpdk: enhance EXPERIMENTAL api tagging

2018-01-19 Thread Neil Horman
On Tue, Jan 09, 2018 at 10:20:05AM +0100, Thomas Monjalon wrote: > 09/01/2018 02:32, Neil Horman: > > On Fri, Jan 05, 2018 at 11:00:52AM -0500, Neil Horman wrote: > > > On Fri, Jan 05, 2018 at 03:08:52PM +0100, Thomas Monjalon wrote: > > > > 04/01/2018 13:56, Neil Horman: > > > > > On Sat, Dec 30,

Re: [dpdk-dev] [PATCH v2 2/6] ethdev: add port ownership

2018-01-19 Thread Neil Horman
On Fri, Jan 19, 2018 at 03:13:47PM +0100, Thomas Monjalon wrote: > 19/01/2018 14:30, Neil Horman: > > So it seems like the real point of contention that we need to settle here > > is, > > what codifies an 'owner'. Must it be a specific execution context, or can > > we > > define any arbitrary se

Re: [dpdk-dev] [PATCH v8 2/3] ring: introduce new header file to include common functions

2018-01-19 Thread Hemant Agrawal
Hi Jia, On 1/17/2018 9:33 AM, Jia He wrote: Move the common part of rte_ring.h into rte_ring_generic.h. Move the memory barrier part into update_tail(). No functional changes here. Signed-off-by: Jia He Suggested-by: Jerin Jacob Suggested-by: Ananyev Konstantin Acked-by: Jerin Jacob Acked-

Re: [dpdk-dev] [PATCH v8 3/3] ring: introduce new header file to support C11 memory model

2018-01-19 Thread Hemant Agrawal
HI Jia, On 1/17/2018 2:17 PM, Jia He wrote: Hi Thomas On 1/17/2018 4:24 PM, Thomas Monjalon Wrote: 17/01/2018 05:03, Jia He: To support C11 memory model barrier, 2 options are suggested by Jerin: 1. use rte_smp_rmb 2. use load_acquire/store_release(refer to [1]). CONFIG_RTE_RING_USE_C11_MEM_

[dpdk-dev] [PATCH] net/mlx5: remmap UAR address for multiple process

2018-01-19 Thread Xueming Li
UAR(doorbell) is hw resources that have to be same address between primary and secondary process, failed to mmap UAR will make TX packets invisible to HW. Today, UAR address returned from verbs api is mixed in heap and loaded library address space, prone to be occupied in secondary process. This pa

Re: [dpdk-dev] [PATCH v8 3/3] ring: introduce new header file to support C11 memory model

2018-01-19 Thread Hemant Agrawal
My thunderbird mails are getting delayed. I have provided a response there that this patch is not ok in it's current state.

Re: [dpdk-dev] [PATCH v3 7/7] app/testpmd: adjust ethdev port ownership

2018-01-19 Thread Gaëtan Rivet
Hi Matan, On Fri, Jan 19, 2018 at 01:35:10PM +, Matan Azrad wrote: > Hi Konstantin > > From: Ananyev, Konstantin, Friday, January 19, 2018 3:09 PM > > > -Original Message- > > > From: Matan Azrad [mailto:ma...@mellanox.com] > > > Sent: Friday, January 19, 2018 12:52 PM > > > To: Anany

[dpdk-dev] [PATCH] keepalive: fix keepalive state alignment

2018-01-19 Thread Andriy Berestovskyy
The __rte_cache_aligned was applied to the whole array, not the array elements. This leads to a false sharing between the monitored cores. Fixes: e70a61ad50ab ("keepalive: export states") Cc: remy.hor...@intel.com Signed-off-by: Andriy Berestovskyy --- lib/librte_eal/common/rte_keepalive.c | 25

Re: [dpdk-dev] [PATCH] vhost: fix ANY_LAYOUT declaration

2018-01-19 Thread Yuanhan Liu
On Fri, Jan 19, 2018 at 02:02:50PM -0500, Zhihong Wang wrote: > The VIRTIO_F_ANY_LAYOUT feature indicates the device accepts arbitrary > descriptor layouts. The vhost-user lib already supports it, but the > feature declaration is missing. This patch fixes the mismatch. I remembered there was a lo

Re: [dpdk-dev] [PATCH] reset src fd field to -1 in fdset_move of vhost

2018-01-19 Thread Yuanhan Liu
On Thu, Dec 21, 2017 at 05:15:40PM +0800, Bing Zhao wrote: > In the fdset_move, after copying the fd&rwfds from the src to the dst, the fd > should be set to -1. Or else in some cases, there will be a fault missing. > E.g: > Before: 1 -1 3 4 -1 6 7 -1 9 10 > After: 1 10 3 4 9 6 7 -1 9 10 > Then t

  1   2   3   >