Re: [dpdk-dev] [PATCH 2/2] test/memzone: handle previously allocated memzones

2018-01-30 Thread Phil Yang
Hi Anatoly, I think your fix is elegant, however you can't grantee it doesn't have dirty memzone remained after memzone autotest. What if some existed initial memzone released during the test and some dirty memzone remained. The counter cannot illustrate this state. My fix just care about the m

Re: [dpdk-dev] Kernel Crash bug of ixgbevf kernel module in "Intel(R) 10GbE PCI Express Virtual Function Driver Version: 4.0.3 Release: 1"

2018-01-30 Thread Sam
wrong order, actually is this: 4. stop bond1(ifdown bond1), stop dpdkb2(rte_eth_dev_stop), sleep 5 second, start dpdkb2(rte_eth_dev_start), start bond1(ifup bond1). 2018-01-31 15:34 GMT+08:00 Sam : > Hi all, > > There is a kernel crash bug of ixgbevf kernel module in "Intel(R) 10GbE > PCI Express

[dpdk-dev] [PATCH v1] build: add more implementers' IDs and PNs for Arm platforms

2018-01-30 Thread Herbert Guan
1) Add native PN option '-march=native' to allow automatic detection. Set 'arm_force_native_march' to 'true' in config/arm/meson.build to use native PN option. 2) Add implementer_pn option for part num selection in cross compile 3) Add known Arm cortex PN support 4) Add known implementers' ID

Re: [dpdk-dev] [PATCH] event/rx_adapter: fix ignore return of event start

2018-01-30 Thread Jerin Jacob
-Original Message- > > > Adding eventdev PMD folks for their suggestions on how to handle the return > value from rte_event_dev_start() below. > > > -Original Message- > > From: Varghese, Vipin > > Sent: Wednesday, January 31, 2018 4:26 AM > > To: dev@dpdk.org; Rao, Nikhil > > Cc:

Re: [dpdk-dev] [PATCH v5] vhost_user: protect active rings from async ring changes

2018-01-30 Thread Chen, Junjie J
Hi May I know why not use trylock also in enqueue path? Cheers JJ > > When performing live migration or memory hot-plugging, the changes to the > device and vrings made by message handler done independently from vring > usage by PMD threads. > > This causes for example segfaults during live-mi

Re: [dpdk-dev] [PATCH v3] doc: update flow filtering document

2018-01-30 Thread Zhang, Helin
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Wei Zhao > Sent: Wednesday, January 31, 2018 10:12 AM > To: dev@dpdk.org > Cc: Mcnamara, John; sta...@dpdk.org; or...@mellanox.com; Zhao1, Wei > Subject: [dpdk-dev] [PATCH v3] doc: update flow filtering document >

Re: [dpdk-dev] [PATCH v2] app/eventdev: fix port dequeue depth configuration

2018-01-30 Thread Jerin Jacob
-Original Message- > Received: from BN6PR07MB3457.namprd07.prod.outlook.com (10.174.64.21) by > BN3PR07MB2513.namprd07.prod.outlook.com with HTTPS via > BN3PR05CA0011.NAMPRD05.PROD.OUTLOOK.COM; Tue, 30 Jan 2018 11:18:05 + > Authentication-Results: caviumnetworks.com; dkim=none (messag

Re: [dpdk-dev] [PATCH 1/3] bus/fslmc: create function to prefetch next DQRR entry

2018-01-30 Thread Jerin Jacob
-Original Message- > Date: Wed, 24 Jan 2018 05:20:25 + > From: Hemant Agrawal > To: Nipun Gupta , "jerin.ja...@caviumnetworks.com" > > CC: "dev@dpdk.org" > Subject: RE: [PATCH 1/3] bus/fslmc: create function to prefetch next DQRR > entry > > > -Original Message- > > From:

Re: [dpdk-dev] [PATCH] eal/arm64: fix instrinsic for ARM64 NEON with GCC < 4.9

2018-01-30 Thread Jerin Jacob
-Original Message- > Date: Tue, 30 Jan 2018 16:07:08 -0800 > From: Yongseok Koh > To: jerin.ja...@caviumnetworks.com, jianbo@arm.com > CC: dev@dpdk.org, Yongseok Koh , sta...@dpdk.org > Subject: [PATCH] eal/arm64: fix instrinsic for ARM64 NEON with GCC < 4.9 > X-Mailer: git-send-email

Re: [dpdk-dev] [PATCH RFC 1/2] vhost: make capabilities configurable

2018-01-30 Thread Wang, Zhihong
Hi Maxime, > -Original Message- > From: Maxime Coquelin [mailto:maxime.coque...@redhat.com] > Sent: Tuesday, January 30, 2018 11:00 PM > To: Wang, Zhihong ; dev@dpdk.org > Cc: Tan, Jianfeng ; Bie, Tiwei > ; y...@fridaylinux.org; Liang, Cunming > ; Wang, Xiao W ; Daly, > Dan > Subject: Re:

Re: [dpdk-dev] [PATCH] event/rx_adapter: fix ignore return of event start

2018-01-30 Thread Rao, Nikhil
Adding eventdev PMD folks for their suggestions on how to handle the return value from rte_event_dev_start() below. > -Original Message- > From: Varghese, Vipin > Sent: Wednesday, January 31, 2018 4:26 AM > To: dev@dpdk.org; Rao, Nikhil > Cc: Jain, Deepak K ; Varghese, Vipin > > Subjec

Re: [dpdk-dev] [PATCH V14 3/3] app/testpmd: use uevent to monitor hotplug

2018-01-30 Thread Wu, Jingjing
> -Original Message- > From: Guo, Jia > Sent: Tuesday, January 30, 2018 8:21 PM > To: step...@networkplumber.org; Richardson, Bruce > ; > gaetan.ri...@6wind.com; Wu, Jingjing ; > tho...@monjalon.net; > mo...@mellanox.com > Cc: Yigit, Ferruh ; Ananyev, Konstantin > ; jblu...@infradead.or

[dpdk-dev] [PATCH] net/tap: fix build issue with ARM32

2018-01-30 Thread Jerin Jacob
arm32 Linux does not support eBPF interface. Since tap PMD driver has a dependency on eBPF(the symbol __NR_bpf), disabling it armv7 config. compilation error log: In file included from /tmp/dpdk/drivers/net/tap/tap_bpf_api.c:15:0: /tmp/dpdk/drivers/net/tap/tap_bpf.h:103:4: error: #error __NR_bpf n

[dpdk-dev] [PATCH] build: add more implementers' IDs and PNs for Arm platforms

2018-01-30 Thread Herbert Guan
1) Add native PN option '-march=native' to allow automatic detection. Set 'arm_force_native_march' to 'true' in config/arm/meson.build to use native PN option. 2) Add implementer_pn option for part num selection in cross compile 3) Add known Arm cortex PN support 4) Add known implementers' ID

Re: [dpdk-dev] [PATCH] lpm: fix allocation of an existing object

2018-01-30 Thread Phil Yang
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Pavan Nikhilesh > Sent: Wednesday, January 31, 2018 2:52 AM > To: tho...@monjalon.net; zhiyong.y...@intel.com; ferruh.yi...@intel.com; > olivier.m...@6wind.com; pablo.de.lara.gua...@intel.com > Cc: dev@dpdk.org; Pa

[dpdk-dev] [PATCH] net/i40e: update Rx checksum offload

2018-01-30 Thread Beilei Xing
HW supports outer IP Rx checksum offload, this patch updates Rx checksum offload for PF and VF. Signed-off-by: Beilei Xing --- drivers/net/i40e/i40e_ethdev.c| 3 ++- drivers/net/i40e/i40e_ethdev_vf.c | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/net/i40e/i40

Re: [dpdk-dev] [PATCH v4] app/testpmd: do not enable Rx offloads by default

2018-01-30 Thread Lu, Wenzhuo
Hi Moti, > -Original Message- > From: Moti Haimovsky [mailto:mo...@mellanox.com] > Sent: Tuesday, January 30, 2018 5:01 PM > To: Lu, Wenzhuo ; tho...@monjalon.net > Cc: dev@dpdk.org; Moti Haimovsky > Subject: [PATCH v4] app/testpmd: do not enable Rx offloads by default > > Removed the ha

[dpdk-dev] [PATCH] ethdev: fix MTU setup error

2018-01-30 Thread Mallesh Koujalagi
NULL device is failed to attach ovs, reported operation not supported and configuration failed. To attach ovs: $VSCTL add-port ovs-br dpdk1 -- set Interface dpdk1 type=dpdk \ options:dpdk-devargs=eth_null0,size=64,copy=1 Signed-off-by: Mallesh Koujalagi --- drivers/net/null/rte_eth_null

[dpdk-dev] [PATCH] vhost: fix ANY_LAYOUT definition for old kernels

2018-01-30 Thread Zhihong Wang
This patch fixes compile failure with old kernels which have no VIRTIO_F_ANY_LAYOUT defined. Signed-off-by: Zhihong Wang --- lib/librte_vhost/vhost.h | 4 1 file changed, 4 insertions(+) diff --git a/lib/librte_vhost/vhost.h b/lib/librte_vhost/vhost.h index ba80584..646aad3 100644 --- a/li

Re: [dpdk-dev] [PATCH v2] doc: update flow filting document

2018-01-30 Thread Zhao1, Wei
Hi, Ori Kam A new v3 has been committed just now, thank you for your review work. https://dpdk.org/dev/patchwork/patch/34742/ > -Original Message- > From: Ori Kam [mailto:or...@mellanox.com] > Sent: Tuesday, January 30, 2018 5:22 PM > To: Zhao1, Wei ; dev@dpdk.org > Cc: sta...@dpdk.o

[dpdk-dev] [PATCH v3] doc: update flow filtering document

2018-01-30 Thread Wei Zhao
This patch will update example application of flow_filtering document. It add Tx queues configuration related comment. Signed-off-by: Wei Zhao Reviewed-by: Ori Kam --- v2: -change code indentation style. v3: -fix a typo in the patch subject and comment. --- doc/guides/sample_app_ug/flow_filt

Re: [dpdk-dev] [PATCH] igb_uio: fix uevent montior issue

2018-01-30 Thread Wu, Jingjing
> -Original Message- > From: Guo, Jia > Sent: Tuesday, January 30, 2018 6:01 PM > To: Yigit, Ferruh ; Wu, Jingjing > ; Tan, > Jianfeng > Cc: tho...@monjalon.net; dev@dpdk.org; Guo, Jia > Subject: [PATCH] igb_uio: fix uevent montior issue > > udev could not detect remove and add event

Re: [dpdk-dev] DPDK kernel requirements

2018-01-30 Thread Thomas Monjalon
31/01/2018 01:31, Stephen Hemminger: > Where is the minimum Linux kernel version requirement documented. > > For 18.02 the version should be kernel version 3.2 or greater. It is your patch: http://dpdk.org/commit/90f3229fc0 > Since 3.2 will EOL if May, for 18.05 the requirement will adva

Re: [dpdk-dev] [PATCH V14 1/3] eal: add uevent monitor api and callback func

2018-01-30 Thread Stephen Hemminger
On Tue, 30 Jan 2018 20:20:58 +0800 Jeff Guo wrote: > + memset(&ep_kernel, 0, sizeof(struct epoll_event)); > + ep_kernel.events = EPOLLIN | EPOLLPRI | EPOLLRDHUP | EPOLLHUP; > + ep_kernel.data.fd = netlink_fd; > + if (epoll_ctl(fd_ep, EPOLL_CTL_ADD, netlink_fd, > + &ep_

Re: [dpdk-dev] [PATCH 1/3] config: change dpaa2 mbuf headroom size to 128

2018-01-30 Thread Thomas Monjalon
30/01/2018 16:06, Shreyansh Jain: > From: Hemant Agrawal > > Signed-off-by: Hemant Agrawal Series applied, thanks

[dpdk-dev] DPDK kernel requirements

2018-01-30 Thread Stephen Hemminger
Where is the minimum Linux kernel version requirement documented. For 18.02 the version should be kernel version 3.2 or greater. Since 3.2 will EOL if May, for 18.05 the requirement will advance to next LTS kernel which is 3.16. It would be good to put in a deprecation warning about that in 18.

[dpdk-dev] [PATCH] eal/arm64: fix instrinsic for ARM64 NEON with GCC < 4.9

2018-01-30 Thread Yongseok Koh
vceqzq_u32() is being used by mlx5 PMD but added since gcc 4.9. Fixes: 570acdb1da8a ("net/mlx5: add vectorized Rx/Tx burst for ARM") Cc: sta...@dpdk.org Signed-off-by: Yongseok Koh --- lib/librte_eal/common/include/arch/arm/rte_vect.h | 6 ++ 1 file changed, 6 insertions(+) diff --git a/li

Re: [dpdk-dev] [PATCH] eal: fix default mempool ops returning NULL

2018-01-30 Thread Thomas Monjalon
30/01/2018 16:57, Pavan Nikhilesh: > If '--mbuf-pool-ops' is not passed to EAL as command line argument then > rte_eal_mbuf_default_mempool_ops will return NULL. > > Instead check if internal_config.user_mbuf_pool_ops_name is NULL and > return compile time RTE_MBUF_DEFAULT_MEMPOOL_OPS. > > Fixes:

Re: [dpdk-dev] [PATCH v2] test: fix debug autotest with eal cleanup addition

2018-01-30 Thread Thomas Monjalon
30/01/2018 19:26, Harry van Haaren: > Before this patch, the debug_autotest would call fork(), > call rte_panic() or rte_exit() in the child process, and > examine the return code to verify that rte_panic() and > rte_exit() were correctly reporting failures. > > With the inclusion of the rte_eal_c

Re: [dpdk-dev] [PATCH v1] mk: support building with renamed makefile

2018-01-30 Thread Thomas Monjalon
> > The build system made a recursive call to "make" after creating the build > > directory. This recursive call used the hard-coded filename "Makefile", > > which > > prevented builds from working if the file was renamed and make called using > > "make -f". Taking the filename from MAKEFILES_LIST

Re: [dpdk-dev] [PATCH] mk: add debug target

2018-01-30 Thread Thomas Monjalon
16/12/2017 01:13, Ferruh Yigit: > Add "debug" target to build library with debug symbols and optimization > disabled. > > This is shortcut for exiting method to compile with > EXTRA_CFLAGS="-O0 -g3" > > Signed-off-by: Ferruh Yigit > --- > + debugbuild library with debug symbols [

[dpdk-dev] [PATCH] event/rx_adapter: fix ignore return of event start

2018-01-30 Thread Vipin Varghese
Capture the return value for rte_event_dev_start. Return the result back to user. Coverity issue: 257000 Fixes: 9c38b704d280 ("eventdev: add eth Rx adapter implementation") Cc: nikhil@intel.com Signed-off-by: Vipin Varghese --- lib/librte_eventdev/rte_event_eth_rx_adapter.c | 4 ++-- 1 file

Re: [dpdk-dev] [PATCH] vhost: fix ANY_LAYOUT declaration

2018-01-30 Thread Thomas Monjalon
Hi, There is a compilation error on Ubuntu 12.04 / kernel 3.8. VIRTIO_F_ANY_LAYOUT is undeclared. 26/01/2018 14:04, Yuanhan Liu: > On Sat, Jan 20, 2018 at 01:54:52AM +0800, Tan, Jianfeng wrote: > > > > > > On 1/19/2018 10:42 PM, Yuanhan Liu wrote: > > >On Fri, Jan 19, 2018 at 02:02:50PM -0500,

Re: [dpdk-dev] [PATCH v3] net/mlx4: fix dev rmv not detected after port stop

2018-01-30 Thread Shahaf Shuler
Tuesday, January 30, 2018 11:40 AM, Adrien Mazarguil: > Unfortunately I didn't get a chance to review this patch before it was > applied. > I'm not sure a stopped port is supposed to report events (interrupts). Will > applications expect them to occur at this point? Why not? Stopped port is stil

Re: [dpdk-dev] [PATCH v2 1/5] ethdev: introduce Tx generic tunnel offloads

2018-01-30 Thread Thomas Monjalon
Xueming, We already discussed privately some time ago about this API. You got some questions from me, from Olivier and from Konstantin. The next version should answer the questions asked. When defining an API, the doxygen documentation must explain precisely what must be set, when and why. The do

Re: [dpdk-dev] [PATCH v3 2/2] eal/x86: Use lock-prefixed instructions to reduce cost of rte_smp_mb()

2018-01-30 Thread Stephen Hemminger
On Mon, 29 Jan 2018 16:47:45 +0100 Thomas Monjalon wrote: > 15/01/2018 16:09, Konstantin Ananyev: > > On x86 it is possible to use lock-prefixed instructions to get > > the similar effect as mfence. > > As pointed by Java guys, on most modern HW that gives a better > > performance than using mfe

[dpdk-dev] [PATCH] lpm: fix allocation of an existing object

2018-01-30 Thread Pavan Nikhilesh
Fix rte_lpm_create_*() functions to return NULL and set rte_errno to EEXIST when lpm object name already exists. This is the behavior described in the API documentation in the header file. Fixes: 134975073af3 ("lib: remove unnecessary pointer cast") Signed-off-by: Pavan Nikhilesh --- This was

Re: [dpdk-dev] [PATCH v4 2/4] net/mlx4: spawn rdma-core dependency plug-in

2018-01-30 Thread Adrien Mazarguil
On Tue, Jan 30, 2018 at 03:54:59PM -0200, Marcelo Ricardo Leitner wrote: > On Tue, Jan 30, 2018 at 04:34:54PM +0100, Adrien Mazarguil wrote: > ... > > + handle = dlopen(MLX4_GLUE, RTLD_LAZY); > > + if (!handle) { > > + rte_errno = EINVAL; > > + dlmsg = dlerror(); > > +

[dpdk-dev] [PATCH v2] test: fix debug autotest with eal cleanup addition

2018-01-30 Thread Harry van Haaren
Before this patch, the debug_autotest would call fork(), call rte_panic() or rte_exit() in the child process, and examine the return code to verify that rte_panic() and rte_exit() were correctly reporting failures. With the inclusion of the rte_eal_cleanup() patch, rte_exit() was modified to clean

[dpdk-dev] [PATCH] test: fix debug autotest with eal cleanup addition

2018-01-30 Thread Harry van Haaren
Before this patch, the debug_autotest would call fork(), call rte_panic() or rte_exit() in the child process, and examine the return code to verify that rte_panic() and rte_exit() were correctly reporting failures. With the inclusion of the rte_eal_cleanup() patch, rte_exit() was modified to clean

[dpdk-dev] [PATCH v2] net/i40e: fix multiple DDP packages should not be allowed

2018-01-30 Thread Kirill Rybalchenko
Should be not possible to load conflicting DDP profiles. Only DDP profiles of the same group (not 0) can be loaded together; If DDP profile group is 0, it is exclusive, i.e. it cannot be loaded with any other DDP profile; If DDP profile groups are different - these profiles cannot be loaded togethe

Re: [dpdk-dev] [PATCH v4 2/4] net/mlx4: spawn rdma-core dependency plug-in

2018-01-30 Thread Marcelo Ricardo Leitner
On Tue, Jan 30, 2018 at 04:34:54PM +0100, Adrien Mazarguil wrote: ... > + handle = dlopen(MLX4_GLUE, RTLD_LAZY); > + if (!handle) { > + rte_errno = EINVAL; > + dlmsg = dlerror(); > + if (dlmsg) > + ERROR("cannot load glue library: %s",

Re: [dpdk-dev] [PATCH v2 1/5] ethdev: introduce Tx generic tunnel offloads

2018-01-30 Thread Xueming(Steven) Li
> -Original Message- > From: Ananyev, Konstantin [mailto:konstantin.anan...@intel.com] > Sent: Wednesday, January 31, 2018 1:05 AM > To: Xueming(Steven) Li ; Olivier MATZ > > Cc: dev@dpdk.org; Wu, Jingjing ; Shahaf Shuler > ; Yongseok Koh ; Thomas Monjalon > ; Yigit, Ferruh > Subject: R

Re: [dpdk-dev] [RFC 23/24] WORKAROUND revert virtio-net mq vring deletion

2018-01-30 Thread Maxime Coquelin
Hi Stefan, On 01/19/2018 02:44 PM, Stefan Hajnoczi wrote: The virtio-net mq vring deletion code should be in virtio_net.c, not in the generic vhost_user.c code where it breaks non-virtio-net devices. Signed-off-by: Stefan Hajnoczi --- drivers/librte_vhost/vhost_user.c | 2 ++ 1 file changed

[dpdk-dev] [PATCH] net/i40e: multiple DDP packages should not be allowed

2018-01-30 Thread Kirill Rybalchenko
Should be not possible to load conflicting DDP profiles. Only DDP profiles of the same group (not 0) can be loaded together; If DDP profile group is 0, it is exclusive, i.e. it cannot be loaded with any other DDP profile; If DDP profile groups are different - these profiles cannot be loaded togethe

Re: [dpdk-dev] [PATCH] net/mlx4: fix drop flow resources not freed

2018-01-30 Thread Adrien Mazarguil
On Tue, Jan 30, 2018 at 05:41:07PM +0100, Adrien Mazarguil wrote: > Hi Moti, > > On Tue, Jan 30, 2018 at 05:54:00PM +0200, Moti Haimovsky wrote: > > This patch fixes the drop-flow resources not being freed when the device > > is closed. > > Issue can be observed when running testpmd and adding the

Re: [dpdk-dev] [PATCH v2 1/5] ethdev: introduce Tx generic tunnel offloads

2018-01-30 Thread Ananyev, Konstantin
> -Original Message- > From: Xueming(Steven) Li [mailto:xuemi...@mellanox.com] > Sent: Tuesday, January 30, 2018 4:10 PM > To: Ananyev, Konstantin ; Olivier MATZ > > Cc: dev@dpdk.org; Wu, Jingjing ; Shahaf Shuler > ; Yongseok Koh > ; Thomas Monjalon ; Yigit, Ferruh > > Subject: RE: [

[dpdk-dev] [PATCH] net/mlx4: fix Rx pkt offloads nonfrag indication

2018-01-30 Thread Moti Haimovsky
This patch fixes the missing RTE_PTYPE_L4_NONFRAG on non-fragmented IP packets with unrecognized payload type. Fixes: aee4a03fee4f ("net/mlx4: enhance Rx packet type offloads") Cc: sta...@dpdk.org Signed-off-by: Moti Haimovsky --- drivers/net/mlx4/mlx4_rxtx.c | 3 ++- 1 file changed, 2 insertio

Re: [dpdk-dev] [PATCH v3 00/11] Introduce generic 'rawdevice' support

2018-01-30 Thread Thomas Monjalon
30/01/2018 15:56, Shreyansh Jain: > Shreyansh Jain (11): > rawdev: introduce raw device library support > rawdev: add attribute get and set support > rawdev: add buffer stream IO support > rawdev: support for extended stats > rawdev: support for firmware management > rawdev: add self te

Re: [dpdk-dev] [PATCH v3 10/11] maintainers: claim ownership of rawdev

2018-01-30 Thread Thomas Monjalon
30/01/2018 15:57, Shreyansh Jain: > +Rawdev API - EXPERIMENTAL > +M: Shreyansh Jain > +M: Hemant Agrawal > +F: lib/librte_rawdev/* > +F: test/test/test_rawdev.c > +F: drivers/rawdev/skeleton/* > > Bus Drivers > --- One blank line is missing. You should update MAINTAINERS in the patc

Re: [dpdk-dev] [PATCH v3 07/11] drivers/raw: introduce skeleton rawdev driver

2018-01-30 Thread Thomas Monjalon
There is a compilation error with clang-5.0: 30/01/2018 15:57, Shreyansh Jain: > +struct queue_buffers { > + void *bufs[SKELETON_QUEUE_MAX_DEPTH]; > +}; > + > +static struct queue_buffers queue_buf[SKELETON_MAX_QUEUES] = {0}; drivers/raw/skeleton_rawdev/skeleton_rawdev.c:46:63: fatal error: s

Re: [dpdk-dev] [PATCH] net/mlx4: fix drop flow resources not freed

2018-01-30 Thread Adrien Mazarguil
Hi Moti, On Tue, Jan 30, 2018 at 05:54:00PM +0200, Moti Haimovsky wrote: > This patch fixes the drop-flow resources not being freed when the device > is closed. > Issue can be observed when running testpmd and adding the following rule > more than once: > "flow create 0 ingress pattern eth / end a

Re: [dpdk-dev] [PATCH] net/ixgbe: fix reconfiguration of rx queues

2018-01-30 Thread Chas Williams
On Tue, Jan 30, 2018 at 8:14 AM, Ananyev, Konstantin < konstantin.anan...@intel.com> wrote: > > > > > > > > > > From: "Charles (Chas) Williams" > > > > > > > > .dev_configure() may be called again after RX queues have been setup. > > > > This has the effect of clearing whatever setting the RX que

Re: [dpdk-dev] [PATCH 0/5] dpdk: enhance EXPERIMENTAL api tagging

2018-01-30 Thread Thomas Monjalon
30/01/2018 16:54, Neil Horman: > On Mon, Jan 29, 2018 at 10:46:27PM +0100, Thomas Monjalon wrote: > > 22/01/2018 02:48, Neil Horman: > > > v5 Changes > > > * Clean ups suggested by Thomas > > > > There were a lot of new functions to tag when rebasing this v5. > > Rebased and applied, thanks. > >

Re: [dpdk-dev] [PATCH v2 0/2] fix eBPF TAP RSS leakage and map key handling

2018-01-30 Thread Pascal Mazon
The patches look good to me. Good catch. Acked-by: Pascal Mazon for the series. On 30/01/2018 17:00, Ophir Munk wrote: > v2: > fix eBPF RSS map key handling > > v1: > fix eBPF file descriptors leakage > > Ophir Munk (2): > net/tap: fix eBPF file descriptors leakage > net/tap: fix eBPF RSS ma

Re: [dpdk-dev] [PATCH v2 1/5] ethdev: introduce Tx generic tunnel offloads

2018-01-30 Thread Xueming(Steven) Li
> -Original Message- > From: Ananyev, Konstantin [mailto:konstantin.anan...@intel.com] > Sent: Wednesday, January 31, 2018 12:03 AM > To: Xueming(Steven) Li ; Olivier MATZ > > Cc: dev@dpdk.org; Wu, Jingjing ; Shahaf Shuler > ; Yongseok Koh ; Thomas Monjalon > ; Yigit, Ferruh > Subject:

Re: [dpdk-dev] [PATCH v2 1/5] ethdev: introduce Tx generic tunnel offloads

2018-01-30 Thread Ananyev, Konstantin
> > > > > > > > > > > This patch introduce new TX offloads flag for devices that > > > > > > > support tunnel agnostic checksum and TSO offloads. > > > > > > > > > > > > > > The support from the device is for inner and outer checksums > > > > > > > on IPV4/TCP/UDP and TSO for *any packet with the

Re: [dpdk-dev] [PATCH 0/5] ARMv8: enable DPAA-X driver compilation

2018-01-30 Thread Thomas Monjalon
25/01/2018 10:53, Hemant Agrawal: > This patchset enables DPAA drivers compilation for ARM targets. > This also includes patches to fix the DPAA compilation for clang > compiler. > > Note that the dpaa(x) specific config files are still preserved > to continue customer support. They also contain s

[dpdk-dev] [PATCH v2 2/2] net/tap: fix eBPF RSS map key handling

2018-01-30 Thread Ophir Munk
This commit addresses a case of RSS and non RSS flows mixture. In the corrupted code, if a non-RSS flow is destroyed, it has an eBPF map index 0 (initialized upon flow creation). This might unintentionally remove RSS entry 0 from eBPF map. To fix this issue, add an offset to the real index during a

[dpdk-dev] [PATCH v2 1/2] net/tap: fix eBPF file descriptors leakage

2018-01-30 Thread Ophir Munk
When a user creates an RSS rule, the tap PMD dynamically allocates a 'flow' data structure, and uploads BPF programs (represented by file descriptors) to the kernel. The kernel might reject the rule (due to filters overlap, for example) in which case, flow memory should be freed and BPF file descri

[dpdk-dev] [PATCH v2 0/2] fix eBPF TAP RSS leakage and map key handling

2018-01-30 Thread Ophir Munk
v2: fix eBPF RSS map key handling v1: fix eBPF file descriptors leakage Ophir Munk (2): net/tap: fix eBPF file descriptors leakage net/tap: fix eBPF RSS map key handling drivers/net/tap/tap_flow.c | 104 +++-- 1 file changed, 73 insertions(+), 31 dele

[dpdk-dev] [PATCH] eal: fix default mempool ops returning NULL

2018-01-30 Thread Pavan Nikhilesh
If '--mbuf-pool-ops' is not passed to EAL as command line argument then rte_eal_mbuf_default_mempool_ops will return NULL. Instead check if internal_config.user_mbuf_pool_ops_name is NULL and return compile time RTE_MBUF_DEFAULT_MEMPOOL_OPS. Fixes: 8b0f7f43413 ("mbuf: maintain user and compile ti

Re: [dpdk-dev] [PATCH 0/5] dpdk: enhance EXPERIMENTAL api tagging

2018-01-30 Thread Neil Horman
On Mon, Jan 29, 2018 at 10:46:27PM +0100, Thomas Monjalon wrote: > 22/01/2018 02:48, Neil Horman: > > v5 Changes > > * Clean ups suggested by Thomas > > There were a lot of new functions to tag when rebasing this v5. > Rebased and applied, thanks. > Sorry, not clear what you mean by this. Are y

[dpdk-dev] [PATCH] net/mlx4: fix drop flow resources not freed

2018-01-30 Thread Moti Haimovsky
This patch fixes the drop-flow resources not being freed when the device is closed. Issue can be observed when running testpmd and adding the following rule more than once: "flow create 0 ingress pattern eth / end actions drop / end" then either exiting testpmd using the "quit" command or by runnin

Re: [dpdk-dev] [PATCH] test/test: add new tests in 18.02-rc2 to meson build

2018-01-30 Thread Bruce Richardson
On Tue, Jan 30, 2018 at 03:20:35PM +, Luca Boccassi wrote: > On Tue, 2018-01-30 at 14:41 +, Bruce Richardson wrote: > > Signed-off-by: Bruce Richardson > > --- > >  test/test/meson.build | 6 ++ > >  1 file changed, 6 insertions(+) > > Reviewed-by: Luca Boccassi > > LGTM! > Applied

Re: [dpdk-dev] [PATCH v2 1/5] ethdev: introduce Tx generic tunnel offloads

2018-01-30 Thread Xueming(Steven) Li
> -Original Message- > From: Ananyev, Konstantin [mailto:konstantin.anan...@intel.com] > Sent: Tuesday, January 30, 2018 11:34 PM > To: Xueming(Steven) Li ; Olivier MATZ > > Cc: dev@dpdk.org; Wu, Jingjing ; Shahaf Shuler > ; Yongseok Koh ; Thomas Monjalon > ; Yigit, Ferruh > Subject: RE

[dpdk-dev] [PATCH v4 2/4] net/mlx4: spawn rdma-core dependency plug-in

2018-01-30 Thread Adrien Mazarguil
When mlx4 is not compiled directly as an independent shared object (e.g. CONFIG_RTE_BUILD_SHARED_LIB not enabled for performance reasons), DPDK applications inherit its dependencies on libibverbs and libmlx4 through rte.app.mk. This is an issue both when DPDK is delivered as a binary package (Linu

[dpdk-dev] [PATCH v4 4/4] net/mlx5: spawn rdma-core dependency plug-in

2018-01-30 Thread Adrien Mazarguil
When mlx5 is not compiled directly as an independent shared object (e.g. CONFIG_RTE_BUILD_SHARED_LIB not enabled for performance reasons), DPDK applications inherit its dependencies on libibverbs and libmlx5 through rte.app.mk. This is an issue both when DPDK is delivered as a binary package (Linu

[dpdk-dev] [PATCH v4 3/4] net/mlx5: move rdma-core calls to separate file

2018-01-30 Thread Adrien Mazarguil
From: Nelio Laranjeiro This lays the groundwork for externalizing rdma-core as an optional run-time dependency instead of a mandatory one. No functional change. Signed-off-by: Nelio Laranjeiro Signed-off-by: Adrien Mazarguil --- drivers/net/mlx5/Makefile | 1 + drivers/net/mlx5/mlx5.c

[dpdk-dev] [PATCH v4 0/4] net/mlx: make rdma-core optional at run-time

2018-01-30 Thread Adrien Mazarguil
A problem encountered with Mellanox PMDs and frequently reported by DPDK application developers and Linux distribution package maintainers is their dependency on rdma-core components, namely libibverbs, libmlx4, and libmlx5. For best performance in applications, DPDK is normally built as a collect

[dpdk-dev] [PATCH v4 1/4] net/mlx4: move rdma-core calls to separate file

2018-01-30 Thread Adrien Mazarguil
This lays the groundwork for externalizing rdma-core as an optional run-time dependency instead of a mandatory one. No functional change. Signed-off-by: Adrien Mazarguil Acked-by: Nelio Laranjeiro --- drivers/net/mlx4/Makefile | 1 + drivers/net/mlx4/mlx4.c| 35 ++--- drivers/n

Re: [dpdk-dev] [PATCH v2 1/5] ethdev: introduce Tx generic tunnel offloads

2018-01-30 Thread Ananyev, Konstantin
> -Original Message- > From: Xueming(Steven) Li [mailto:xuemi...@mellanox.com] > Sent: Tuesday, January 30, 2018 3:27 PM > To: Ananyev, Konstantin ; Olivier MATZ > > Cc: dev@dpdk.org; Wu, Jingjing ; Shahaf Shuler > ; Yongseok Koh > ; Thomas Monjalon ; Yigit, Ferruh > > Subject: RE: [

Re: [dpdk-dev] [PATCH v2 1/5] ethdev: introduce Tx generic tunnel offloads

2018-01-30 Thread Xueming(Steven) Li
Hi Ananyev, > -Original Message- > From: Ananyev, Konstantin [mailto:konstantin.anan...@intel.com] > Sent: Tuesday, January 30, 2018 9:28 PM > To: Xueming(Steven) Li ; Olivier MATZ > > Cc: dev@dpdk.org; Wu, Jingjing ; Shahaf Shuler > ; Yongseok Koh ; Thomas Monjalon > ; Yigit, Ferruh > S

[dpdk-dev] [PATCH v2] net/dpaa2: fix the err with testpmd in Tx only mode

2018-01-30 Thread Hemant Agrawal
Fixes: 043b36f621dd ("net/dpaa2: support more than 16 burst size in Rx") Signed-off-by: Hemant Agrawal --- v2: fix checkpatch warning * This patch is applicable over net-next tree* drivers/net/dpaa2/dpaa2_rxtx.c | 126 +++-- 1 file changed, 33 insertions(+),

[dpdk-dev] [PATCH v3 08/11] drivers/raw: support for rawdev testcases

2018-01-30 Thread Shreyansh Jain
Patch introduces rawdev unit testcase for validation against the Skeleton rawdev dummy PMD implementation. Test cases are added along with the skeleton driver implementation. It can be enabled by using vdev argument to any DPDK binary: --vdev="rawdev_skeleton,self_test=1" In case 'self_test=1'

[dpdk-dev] [PATCH v3 03/11] rawdev: add buffer stream IO support

2018-01-30 Thread Shreyansh Jain
Introduce handlers for raw buffer enqueue and dequeue. A raw buffer is essentially a void object which is transparently passed via the library onto the driver. Using a context field as argument, any arbitrary meta information can be passed by application to the driver/implementation. This can be a

[dpdk-dev] [PATCH v3 01/11] rawdev: introduce raw device library support

2018-01-30 Thread Shreyansh Jain
Each device in DPDK has a type associated with it - ethernet, crypto, event etc. This patch introduces 'rawdevice' which is a generic type of device, not currently handled out-of-the-box by DPDK. A device which can be scanned on an installed bus (pci, fslmc, ...) or instantiated through devargs, c

[dpdk-dev] [PATCH v3 07/11] drivers/raw: introduce skeleton rawdev driver

2018-01-30 Thread Shreyansh Jain
Skeleton rawdevice driver, on the lines of eventdev skeleton, is for showcasing the rawdev library. This driver implements some of the operations of the library based on which a test module can be developed. Design of skeleton involves a virtual device which is plugged into VDEV bus on initializat

[dpdk-dev] [PATCH v3 04/11] rawdev: support for extended stats

2018-01-30 Thread Shreyansh Jain
Generic rawdev library cannot define a pre-defined set of stats for devices which are yet to be defined. This patch introduces the xstats support for rawdev so that any implementation can create its own statistics. Signed-off-by: Shreyansh Jain --- lib/librte_rawdev/rte_rawdev.c | 75

[dpdk-dev] [PATCH v3 00/11] Introduce generic 'rawdevice' support

2018-01-30 Thread Shreyansh Jain
Change History ~~ v3: - rebased over master (367bc2a9fd) - added __rte_experimental flag - added initial documentation v2: - restructure comments to prefix model - split patches pivoted on APIs introduced in library - moved test into drivers/rawdev/skeleton from test/test - rem

[dpdk-dev] [PATCH v3 09/11] test: enable rawdev skeleton test

2018-01-30 Thread Shreyansh Jain
Skeleton rawdevice test cases are part of driver layer. This patch allows test cases to be executed using 'rawdev_autotest' command in test framework. Signed-off-by: Shreyansh Jain --- test/test/Makefile | 4 test/test/test_rawdev.c | 27 +++ 2 files changed, 3

[dpdk-dev] [PATCH 2/3] net/dpaa2: fix the bpid offset

2018-01-30 Thread Shreyansh Jain
From: Hemant Agrawal Fixes: 774e9ea91992 ("net/dpaa2: add support for multi seg buffers") Cc: hemant.agra...@nxp.com Fixes: d2ef05d5c13e ("net/dpaa2: optimize Rx/Tx path") Cc: hemant.agra...@nxp.com Signed-off-by: Hemant Agrawal --- drivers/net/dpaa2/dpaa2_rxtx.c | 3 +-- 1 file changed, 1 ins

[dpdk-dev] [PATCH v3 02/11] rawdev: add attribute get and set support

2018-01-30 Thread Shreyansh Jain
A rawdevice can have various attributes. This patch introduce support for transparently setting attribute value or getting current attribute state. This is done by allowing an opaque set of key and value to be passed through rawdev library. Signed-off-by: Shreyansh Jain --- lib/librte_rawdev/rte

[dpdk-dev] [PATCH v3 05/11] rawdev: support for firmware management

2018-01-30 Thread Shreyansh Jain
Some generic operations for firmware management can loading, unloading, starting, stopping and querying firmware of a device. This patch adds support for such generic operations. Signed-off-by: Shreyansh Jain --- lib/librte_rawdev/rte_rawdev.c | 43 lib/librte_raw

[dpdk-dev] [PATCH 1/3] config: change dpaa2 mbuf headroom size to 128

2018-01-30 Thread Shreyansh Jain
From: Hemant Agrawal Signed-off-by: Hemant Agrawal --- config/defconfig_arm64-dpaa2-linuxapp-gcc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/config/defconfig_arm64-dpaa2-linuxapp-gcc b/config/defconfig_arm64-dpaa2-linuxapp-gcc index 5d4437ca5..aa135caab 100644 --- a/con

[dpdk-dev] [PATCH v3 11/11] doc: add rawdev library page

2018-01-30 Thread Shreyansh Jain
Signed-off-by: Shreyansh Jain --- doc/guides/prog_guide/index.rst | 1 + doc/guides/prog_guide/rawdev_lib.rst | 83 2 files changed, 84 insertions(+) create mode 100644 doc/guides/prog_guide/rawdev_lib.rst diff --git a/doc/guides/prog_guide/index.rst b

[dpdk-dev] [PATCH v3 06/11] rawdev: add self test support

2018-01-30 Thread Shreyansh Jain
Signed-off-by: Shreyansh Jain --- lib/librte_rawdev/rte_rawdev.c | 10 ++ lib/librte_rawdev/rte_rawdev.h | 13 + lib/librte_rawdev/rte_rawdev_pmd.h | 11 +++ lib/librte_rawdev/rte_rawdev_version.map | 1 + 4 files changed, 35 insertions(+) d

[dpdk-dev] [PATCH 3/3] bus/fslmc: fix incorrect string compare length

2018-01-30 Thread Shreyansh Jain
Fixes: 828d51d8fc3e ("bus/fslmc: refactor scan and probe functions") Cc: shreyansh.j...@nxp.com Incorrect string length was being compared while scanning DPCI object. Signed-off-by: Shreyansh Jain --- drivers/bus/fslmc/fslmc_bus.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --gi

[dpdk-dev] [PATCH v3 10/11] maintainers: claim ownership of rawdev

2018-01-30 Thread Shreyansh Jain
Signed-off-by: Shreyansh Jain --- MAINTAINERS | 6 ++ 1 file changed, 6 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 5afa9cc6e..e422c871c 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -306,6 +306,12 @@ F: lib/librte_eventdev/*eth_rx_adapter* F: test/test/test_event_eth_rx_adap

Re: [dpdk-dev] [PATCH] test/test: add new tests in 18.02-rc2 to meson build

2018-01-30 Thread Luca Boccassi
On Tue, 2018-01-30 at 14:41 +, Bruce Richardson wrote: > Signed-off-by: Bruce Richardson > --- >  test/test/meson.build | 6 ++ >  1 file changed, 6 insertions(+) Reviewed-by: Luca Boccassi LGTM! -- Kind regards, Luca Boccassi

[dpdk-dev] [PATCH] net/dpaa2: fix the err with testpmd in Tx only mode

2018-01-30 Thread Hemant Agrawal
Fixes: 043b36f621dd ("net/dpaa2: support more than 16 burst size in Rx") Signed-off-by: Hemant Agrawal --- *This patch is applicable on top of next-net* drivers/net/dpaa2/dpaa2_rxtx.c | 126 +++-- 1 file changed, 33 insertions(+), 93 deletions(-) diff --git

[dpdk-dev] [PATCH v2] config: enable dpaaX drivers compilation for ARMv8

2018-01-30 Thread Hemant Agrawal
This patch enables the NXP DPAA & DPAA2 drivers for ARMV8 targets. They can be used with standard armv8 config with command line mempool argument or newly introduced platform mempool internal registration mechanism. Note that the dpaa(x) specific config files are still preserved to continue custom

Re: [dpdk-dev] [PATCH 00/17] use SPDX tags on 6WIND copyrighted files

2018-01-30 Thread Bruce Richardson
On Tue, Jan 30, 2018 at 07:36:30PM +0530, Hemant Agrawal wrote: > On 1/29/2018 6:41 PM, Olivier Matz wrote: > > This patchset updates the license on files that contain a 6WIND copyright > > to use a SPDX tag. > > It applies on master + https://dpdk.org/dev/patchwork/patch/34604/ > > > > For compon

Re: [dpdk-dev] [PATCH] drivers: improve pmdinfo generation when using meson

2018-01-30 Thread Bruce Richardson
On Thu, Jan 25, 2018 at 11:14:43AM +, Bruce Richardson wrote: > Since meson 0.44, changing any file inside a PMD directory (quite > correctly) triggers a full re-run of meson on build, rather than an > incremental build as with earlier versions. This rerun is needed because > we use "grep" in m

Re: [dpdk-dev] [PATCH RFC 1/2] vhost: make capabilities configurable

2018-01-30 Thread Maxime Coquelin
Hi Zhihong On 12/23/2017 04:36 AM, Zhihong Wang wrote: This patch makes vhost device capabilities configurable to adopt various engines. Such capabilities include supported features, protocol features, queue number. APIs are introduced to let app configure these capabilities. Why does the vDPA

Re: [dpdk-dev] [PATCH v7 0/2] generic channel for multi-process communication

2018-01-30 Thread Thomas Monjalon
30/01/2018 07:58, Jianfeng Tan: > This patchset adds a generic channel for multi-process (primary/secondary) > communication. Applied, thanks

Re: [dpdk-dev] [PATCH 5/5] config: enable dpaaX drivers compilation for ARMv8

2018-01-30 Thread Hemant Agrawal
On 1/30/2018 3:03 PM, Hemant Agrawal wrote: On 1/30/2018 2:12 PM, Hemant Agrawal wrote: Hi Jerin, On 1/25/2018 4:51 PM, Jerin Jacob wrote: -Original Message- Date: Thu, 25 Jan 2018 15:23:31 +0530 From: Hemant Agrawal To: dev@dpdk.org CC: jerin.ja...@caviumnetworks.com Subject: [PATCH

[dpdk-dev] [PATCH] test/test: add new tests in 18.02-rc2 to meson build

2018-01-30 Thread Bruce Richardson
Signed-off-by: Bruce Richardson --- test/test/meson.build | 6 ++ 1 file changed, 6 insertions(+) diff --git a/test/test/meson.build b/test/test/meson.build index b8bae5afa..d5b768b9d 100644 --- a/test/test/meson.build +++ b/test/test/meson.build @@ -7,6 +7,7 @@ test_sources = files('command

[dpdk-dev] [PATCH 1/2] app/testpmd: fix port validation

2018-01-30 Thread Matan Azrad
rte_eth_dev_is_valid_port() API validates each valid port from ethdev point of view and may validate ports which should not be used by the application. Testpmd should use only the ports available through the RTE_ETH_FOREACH_DEV iterator. Replace rte_eth_dev_is_valid_port() usage by RTE_ETH_FOREAC

[dpdk-dev] [PATCH 2/2] app/testpmd: fix invalid port detach

2018-01-30 Thread Matan Azrad
Using registration to all ports includes also the ports which should not be used by the application. It is nice to print each port event by testpmd but in case of RMV event, testpmd tries to detach the port and this case is problematic when the port should not be used by the application. Check th

  1   2   >