[dpdk-dev] [PATCH] net/i40e: fix VF testpmd startup failure issue

2018-02-01 Thread Xiaoyun Li
New testpmd will get CRC strip offload from rx_offload_capa. I40evf cannot disable CRC strip. And in fact, it is enabled by PF. This patch solves the issue by adding CRC strip flag into rx_offload_capa in i40e and i40evf. Fixes: 8b9bd0efe0b6 ("app/testpmd: disable Rx VLAN offloads by default") Cc:

Re: [dpdk-dev] [PATCH 1/2] Revert "eal: fix default mempool ops"

2018-02-01 Thread Hemant Agrawal
HI Pavan, > Currently, best_mempool_ops is broken because when > rte_mbuf_user_mempool_ops is invoked it is expected to returns 'NULL' through > internal_config.user_mbuf_pool_ops_name. IMO it is best to create a named > memzone ('mbuf_user_pool_ops') at the end of eal_init and copy mbuf-pool

[dpdk-dev] [PATCH] app/testpmd:vlan filter fail

2018-02-01 Thread Yanglong Wu
Removing out port_conf.rxmode.hw_vlan_filter = 1 will let it equal to 0 and port_conf.rxmode.offloads is assigned as 0 again if hw_vlan_filter = 1. So it will always lead to fail for vlan filter setting Fix:0074d02fc(convert to new Rx offloads API) Signed-off-by: Yanglong Wu --- app/test-pmd/tes

Re: [dpdk-dev] [PATCH v2] doc: add a user guidance document for igb

2018-02-01 Thread Zhao1, Wei
Hi, John A new v3 commit. https://dpdk.org/dev/patchwork/patch/34863/ > -Original Message- > From: Mcnamara, John > Sent: Thursday, February 1, 2018 5:14 PM > To: Zhao1, Wei ; dev@dpdk.org > Cc: Lu, Wenzhuo > Subject: RE: [PATCH v2] doc: add a user guidance document for igb > > > >

Re: [dpdk-dev] [PATCH] app/testpmd:vlan filter fail

2018-02-01 Thread Wu, Yanglong
Hi, This patch is wrong, but there is bug absolutely. The problem can be stated as following: in your patch(0074d02fc), @@ -2224,7 +2221,7 @@ init_port_dcb_config(portid_t pid, retval = get_eth_dcb_conf(&port_conf, dcb_mode, num_tcs, pfc_en); if (retval < 0) return

[dpdk-dev] [PATCH v3] doc: add a user guidance document for igb

2018-02-01 Thread Wei Zhao
This patch add a user guidance document specific for igb nic. By now, a doc like ixgbe.rst is also needed by igb nic. So this patch add igb.rst to record important information about igb, like feature supported and known issues. Signed-off-by: Wei Zhao --- v2: -change code indentation style. v3

[dpdk-dev] [PATCH v2] net/bnxt: Fix to set timestamp flag

2018-02-01 Thread Somnath Kotur
The timestamp flag needed to be set in the offload flags for the received pkt in case of PTP offload Signed-off-by: Somnath Kotur --- v1->v2: Trimmed subject line and added content in commit log drivers/net/bnxt/bnxt_rxr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drive

[dpdk-dev] [PATCH v2] net/bnxt: Fix to set timestamp flag

2018-02-01 Thread Somnath Kotur
The timestamp flag needed to be set in the offload flags for the recieved pkt in case of PTP offload Signed-off-by: Somnath Kotur --- v1->v2: Trimmed subject line and added content in commit log drivers/net/bnxt/bnxt_rxr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drive

[dpdk-dev] [Bug 14] Kernel Crash bug of ixgbevf kernel module in "Intel(R) 10GbE PCI Express Virtual Function Driver Version: 4.0.3 Release: 1" and the latest version

2018-02-01 Thread bugzilla
https://dpdk.org/tracker/show_bug.cgi?id=14 Bug ID: 14 Summary: Kernel Crash bug of ixgbevf kernel module in "Intel(R) 10GbE PCI Express Virtual Function Driver Version: 4.0.3 Release: 1" and the latest version Product: DPDK

[dpdk-dev] [PATCH] net/ixgbe: fix busy wait in ixgbevf_check_link()

2018-02-01 Thread Chas Williams
From: "Charles (Chas) Williams" If we haven't set wait_to_complete, there is no need to busy wait until we have a link status. Applications, like bonding, use the wait_to_complete flag to indicate that they will be doing their own busy wait and will likely be polling again shortly. Fixes: dc66e

[dpdk-dev] I40E VF nullptr Dreference: rx_mbuf_alloc_failed

2018-02-01 Thread Stefan Baranoff
All, I was unclear if this should be usage or dev but it seemed like a dev issue to me. I'm on DPDK 16.11.2 (CentOS packages) using the I40EVF driver and in the case of rx_mbuf_alloc_failed there is a null pointer dereference in drivers/net/i40e/i40e_rxtx.c line 830. The variable 'dev' is null.

Re: [dpdk-dev] [RFC v2] doc compression API for DPDK

2018-02-01 Thread Ahmed Mansour
>>> [Fiona] I propose if BFINAL bit is detected before end of input >>> the decompression should stop. In this case consumed will be < src.length. >>> produced will be < dst buffer size. Do we need an extra STATUS response? >>> STATUS_BFINAL_DETECTED ? >> [Shally] @fiona, I assume you mean here de

Re: [dpdk-dev] [PATCH 1/2] Revert "eal: fix default mempool ops"

2018-02-01 Thread Pavan Nikhilesh
Hi Hemanth, Currently, best_mempool_ops is broken because when rte_mbuf_user_mempool_ops is invoked it is expected to returns 'NULL' through internal_config.user_mbuf_pool_ops_name. IMO it is best to create a named memzone ('mbuf_user_pool_ops') at the end of eal_init and copy mbuf-pool-op

Re: [dpdk-dev] [RFC v2] doc compression API for DPDK

2018-02-01 Thread Ahmed Mansour
On 1/31/2018 2:03 PM, Trahe, Fiona wrote: > Hi Ahmed, Shally, > > ///snip/// >>> D.1.1 Stateless and OUT_OF_SPACE >>> >>> OUT_OF_SPACE is a condition when output buffer runs out of space and >> where PMD still has more data to pr

Re: [dpdk-dev] [RFC] tunnel endpoint hw acceleration enablement

2018-02-01 Thread Shahaf Shuler
Hi Declan, sorry for the late response. Tuesday, January 23, 2018 5:36 PM, Doherty, Declan: > > If I get it right, the API proposed here is to have a tunnel endpoint which > > is > a logical port on top of ethdev port. the TEP is able to receive and monitor > some specific tunneled traffic, for

Re: [dpdk-dev] [PATCH 1/2] Revert "eal: fix default mempool ops"

2018-02-01 Thread Hemant Agrawal
Hi Pavan, Your patch was breaking the design of the best_mempool_ops and the whole purpose of selection was getting lost. I guess you were trying to fix test_mempool. I have sent another patch, which fixes that and start using the best mempool ops API instead of default mempool ops API

[dpdk-dev] [PATCH 2/2] test: use the best mempool ops API to get mbuf pool

2018-02-01 Thread Hemant Agrawal
This patch replaces the uses of default mempool ops API with newly supported best_mempool_ops API. Signed-off-by: Hemant Agrawal --- test/test/test_mempool.c | 3 ++- test/test/test_mempool_perf.c | 5 +++-- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/test/test/test_mempo

[dpdk-dev] [PATCH 1/2] Revert "eal: fix default mempool ops"

2018-02-01 Thread Hemant Agrawal
This reverts commit fe06cb6c54fe5ada299ebba40a382bee37c919f2. --- lib/librte_eal/bsdapp/eal/eal.c | 3 --- lib/librte_eal/linuxapp/eal/eal.c | 3 --- 2 files changed, 6 deletions(-) diff --git a/lib/librte_eal/bsdapp/eal/eal.c b/lib/librte_eal/bsdapp/eal/eal.c index 1622a41..b612af0 100644 ---

Re: [dpdk-dev] IXGBE, IOMMU DMAR DRHD handling fault issue

2018-02-01 Thread Ravi Kerur
On Thu, Feb 1, 2018 at 2:10 AM, Burakov, Anatoly wrote: > On 31-Jan-18 9:51 PM, Ravi Kerur wrote: > >> >> Hi Anatoly, >> >> Thanks. I am following wiki link below which uses vIOMMU with DPDK as a >> use-case and instantiate VM as specified with Q35 chipset in Qemu. >> >> https://wiki.qemu.org/Fea

Re: [dpdk-dev] [PATCH] net/mlx5: fix CRC strip cap query

2018-02-01 Thread Yongseok Koh
> On Feb 1, 2018, at 10:53 AM, Shahaf Shuler wrote: > > IBV_WQ_FLAGS_SCATTER_FCS is a WQ flag to be used to configure the CRC > strip on a queue upon creation. > > Using IBV_RAW_PACKET_CAP_SCATTER_FCS instead to query to capability. > Even though this is RAW_QP capability, it is being used by r

[dpdk-dev] [PATCH v2] examples/l2fwd: check if user portmask is valid

2018-02-01 Thread Vipin Varghese
User can pass portmask with any value, even invalid mask. The code checks against actual portmask. Signed-off-by: Vipin Varghese --- V2 Changes: - correct the spelling in comment - Vipin --- examples/l2fwd/main.c | 5 + 1 file changed, 5 insertions(+) diff --git a/examples/l2fwd/main.c b/

[dpdk-dev] [PATCH] net/mlx5: fix CRC strip cap query

2018-02-01 Thread Shahaf Shuler
IBV_WQ_FLAGS_SCATTER_FCS is a WQ flag to be used to configure the CRC strip on a queue upon creation. Using IBV_RAW_PACKET_CAP_SCATTER_FCS instead to query to capability. Even though this is RAW_QP capability, it is being used by rdma-core to indicate for both RAW_QP and WQ. Fixes: 43e9d9794cde (

[dpdk-dev] [PATCH] examples/l2fwd: check if user portmask is valid

2018-02-01 Thread Vipin Varghese
User can pass portmask with any value, even invalid mask. The code checks against actual portmask. Signed-off-by: Vipin Varghese --- examples/l2fwd/main.c | 5 + 1 file changed, 5 insertions(+) diff --git a/examples/l2fwd/main.c b/examples/l2fwd/main.c index 6c07ed4..1c02c1b 100644 --- a/ex

[dpdk-dev] [PATCH] net/bonding: check return value

2018-02-01 Thread Radu Nicolau
Coverity issue: 260405 Fixes: 2efb58cbab6e ("bond: new link bonding library") Cc: sta...@dpdk.org Signed-off-by: Radu Nicolau --- drivers/net/bonding/rte_eth_bond_api.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/drivers/net/bonding/rte_eth_bond_api.c b/drivers/

[dpdk-dev] [PATCH v4] doc: convert Intel sharing license headers to SPDX tags

2018-02-01 Thread Ferruh Yigit
Signed-off-by: Ferruh Yigit Acked-by: Bruce Richardson --- v3: Intel ones sharing copyright --- doc/guides/linux_gsg/linux_drivers.rst | 28 +--- 1 file changed, 1 insertion(+), 27 deletions(-) diff --git a/doc/guides/linux_gsg/linux_drivers.rst b/doc/guides/linux_gsg/l

Re: [dpdk-dev] [PATCH v2] eal: add error check for core options

2018-02-01 Thread Burakov, Anatoly
On 01-Feb-18 5:07 PM, Marko Kovacevic wrote: Error information on the current core usage list,mask and map were incomplete. Added states to differentiate core usage and to inform user. Signed-off-by: Marko Kovacevic --- Should've kept my Reviewed-by tag, but no harm done. Reviewed-by: Anato

[dpdk-dev] [PATCH v2] eal: add error check for core options

2018-02-01 Thread Marko Kovacevic
Error information on the current core usage list,mask and map were incomplete. Added states to differentiate core usage and to inform user. Signed-off-by: Marko Kovacevic --- V2: - Cleaned up the logging for error cases - Anatoly --- doc/guides/testpmd_app_ug/run_app.rst | 4 lib/li

Re: [dpdk-dev] [PATCH v3 1/6] test: fix memory leak in bitmap test

2018-02-01 Thread Burakov, Anatoly
On 01-Feb-18 12:10 AM, Thomas Monjalon wrote: 17/01/2018 12:15, Anatoly Burakov: Acked-by: Cristian Dumitrescu Fixes: c7e4a134e769 ("test: verify bitmap operations") Cc: pbhagavat...@caviumnetworks.com Signed-off-by: Anatoly Burakov I think you missed to report some previous acks in this s

Re: [dpdk-dev] [PATCH] mk: add debug target

2018-02-01 Thread Ferruh Yigit
On 1/30/2018 11:40 PM, Thomas Monjalon wrote: > 16/12/2017 01:13, Ferruh Yigit: >> Add "debug" target to build library with debug symbols and optimization >> disabled. >> >> This is shortcut for exiting method to compile with >> EXTRA_CFLAGS="-O0 -g3" >> >> Signed-off-by: Ferruh Yigit >> --- >> +

[dpdk-dev] [PATCH v2] doc: update definition of lcore id and lcore index

2018-02-01 Thread Marko Kovacevic
Added examples in lcore index for better explanation on various examples, Sited examples for lcore id. Signed-off-by: Marko Kovacevic --- V2: - Added clearer description to lcore id - Bruce - Reframed examples for lcore index - Bruce --- lib/librte_eal/common/include/rte_lcore.h | 14

[dpdk-dev] [PATCH v2] doc: update definition of lcore id and lcore index

2018-02-01 Thread Marko Kovacevic
Added examples in lcore index for better explanation on various examples, Sited examples for lcore id. Signed-off-by: Marko Kovacevic --- V2: - Added clearer description to lcore id - Bruce - Reframed examples for lcore index - Bruce --- lib/librte_eal/common/include/rte_lcore.h | 14

Re: [dpdk-dev] [PATCH] net/ena: fix jumbo support in Rx offloads flags

2018-02-01 Thread Michał Krawczyk
2018-02-01 17:49 GMT+01:00 Ferruh Yigit : > On 2/1/2018 4:36 PM, Michał Krawczyk wrote: >> 2018-02-01 14:06 GMT+01:00 Rafal Kozik : >>> >>> ENA device supports Rx jumbo frames and such information needs to >>> be provided in the offloads flags. >>> >>> Fixes: 7369f88f88c0 ("net/ena: convert to new

Re: [dpdk-dev] [PATCH] net/ena: fix jumbo support in Rx offloads flags

2018-02-01 Thread Ferruh Yigit
On 2/1/2018 4:36 PM, Michał Krawczyk wrote: > 2018-02-01 14:06 GMT+01:00 Rafal Kozik : >> >> ENA device supports Rx jumbo frames and such information needs to >> be provided in the offloads flags. >> >> Fixes: 7369f88f88c0 ("net/ena: convert to new Rx offloads API") >> >> Signed-off-by: Rafal Kozi

[dpdk-dev] [PATCH] examples/ptpclient: fix Tx configuration

2018-02-01 Thread Pablo de Lara
The PTP Client application requires IEEE1588 to be supported by the network driver used, which needs full Tx data path to be used. Fixes: b960219b0d83 ("examples/ptpclient: convert to new ethdev offloads API") Signed-off-by: Pablo de Lara --- examples/ptpclient/ptpclient.c | 2 ++ 1 file change

Re: [dpdk-dev] [PATCH v1] eal: add error check for core options

2018-02-01 Thread Burakov, Anatoly
On 01-Feb-18 3:39 PM, Marko Kovacevic wrote: Error information on the current core usage list,mask and map were incomplete. Added states to differentiate core usage and to inform user. Nitpicking, but line width on commit message is a little on the short side... Signed-off-by: Marko Kovace

Re: [dpdk-dev] [PATCH] net/ena: fix jumbo support in Rx offloads flags

2018-02-01 Thread Michał Krawczyk
2018-02-01 14:06 GMT+01:00 Rafal Kozik : > > ENA device supports Rx jumbo frames and such information needs to > be provided in the offloads flags. > > Fixes: 7369f88f88c0 ("net/ena: convert to new Rx offloads API") > > Signed-off-by: Rafal Kozik Signed-off-by: Michal Krawczyk > > --- > drivers

Re: [dpdk-dev] [PATCH 3/6] test/test: mark tests as skipped when required lib not available

2018-02-01 Thread Hunt, David
Hi Bruce, On 31/1/2018 5:42 PM, Bruce Richardson wrote: The power management and KNI libraries are not compiled on a FreeBSD platform, which means that the tests can't run. Add in stub code for these cases, allowing the tests to still be compiled, but to report as skipped in those cases. Signed

Re: [dpdk-dev] [PATCH] bnxt: Fix to set timestamp flag as well in the offload flags for the recieved pkt in case of PTP offload

2018-02-01 Thread Somnath Kotur
Sure , will do a response Thanks Som On Feb 1, 2018 8:54 PM, "Ferruh Yigit" wrote: > On 2/1/2018 5:09 AM, Somnath Kotur wrote: > > Hi Somnath, > > Can you please keep patch title brief (around 50 characters) and put more > content in commit log? > > > Signed-off-by: Somnath Kotur > > --- > >

[dpdk-dev] [PATCH v1] eal: add error check for core options

2018-02-01 Thread Marko Kovacevic
Error information on the current core usage list,mask and map were incomplete. Added states to differentiate core usage and to inform user. Signed-off-by: Marko Kovacevic --- doc/guides/testpmd_app_ug/run_app.rst | 4 lib/librte_eal/common/eal_common_options.c | 33 +++

Re: [dpdk-dev] [PATCH v3 0/2] vhost: IOTLB fixes

2018-02-01 Thread Yuanhan Liu
On Mon, Jan 29, 2018 at 05:30:38PM +0100, Maxime Coquelin wrote: > First patch of the series fixes OOM handling from the IOTLB > mempool, the second one removes pending IOTLB entry when the > IOTLB miss request sending failed. > > Changes since v2: > - > - patch 2: Fix error messag

Re: [dpdk-dev] [PATCH] bnxt: Fix to set timestamp flag as well in the offload flags for the recieved pkt in case of PTP offload

2018-02-01 Thread Ferruh Yigit
On 2/1/2018 5:09 AM, Somnath Kotur wrote: Hi Somnath, Can you please keep patch title brief (around 50 characters) and put more content in commit log? > Signed-off-by: Somnath Kotur > --- > drivers/net/bnxt/bnxt_rxr.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/dr

Re: [dpdk-dev] [PATCH v1] doc: update definition of lcore id and lcore index

2018-02-01 Thread Bruce Richardson
On Wed, Jan 31, 2018 at 04:46:46PM +, Marko Kovacevic wrote: > Added examples in lcore index for better > explanation on various examples, > Sited examples for lcore id. > > Signed-off-by: Marko Kovacevic > --- > lib/librte_eal/common/include/rte_lcore.h | 17 +++-- > 1 file chan

Re: [dpdk-dev] [PATCH] examples/vhost_scsi: drop unimplemented EVENT_IDX feature bit

2018-02-01 Thread Yuanhan Liu
On Wed, Jan 31, 2018 at 05:48:28PM +, Stefan Hajnoczi wrote: > The vhost_scsi example application negotiates the > VIRTIO_RING_F_EVENT_IDX feature bit but does not honor it when accessing > vrings. > > In particular, commit e37ff954405addb8ea422426a2d162d00dcad196 ("vhost: > support virtqueue

Re: [dpdk-dev] [PATCH 0/2] vhost: fix VIRTIO_NET_F_MQ vhost_scsi breakage

2018-02-01 Thread Yuanhan Liu
On Wed, Jan 31, 2018 at 05:46:49PM +, Stefan Hajnoczi wrote: > These patches fix a recent regression in librte_vhost that breaks the > vhost_scsi example application. vhost_user.c assumes all devices are vhost > net > backends when handling the VIRTIO_NET_F_MQ feature bit. The code is trigge

Re: [dpdk-dev] [PATCH 1/2] vhost: add flag for built-in virtio_net.c driver

2018-02-01 Thread Yuanhan Liu
Hi Stefan, On Wed, Jan 31, 2018 at 05:46:50PM +, Stefan Hajnoczi wrote: > The librte_vhost API is used in two ways: > 1. As a vhost net device backend via rte_vhost_enqueue/dequeue_burst(). This is how DPDK vhost-user firstly implemented. > 2. As a library for implementing vhost device backe

Re: [dpdk-dev] [PATCH v1] build: add more implementers' IDs and PNs for Arm platforms

2018-02-01 Thread Bruce Richardson
On Wed, Jan 31, 2018 at 03:39:19PM +0800, Herbert Guan wrote: > 1) Add native PN option '-march=native' to allow automatic detection. >Set 'arm_force_native_march' to 'true' in config/arm/meson.build >to use native PN option. > 2) Add implementer_pn option for part num selection in cross co

[dpdk-dev] [PATCH v2 4/5] test/test: fix dependency on power lib for BSD meson build

2018-02-01 Thread Bruce Richardson
The power library is not built on FreeBSD, so it needs to be an optional rather than a mandatory dependency for building the autotest binary. Fixes: b5dc795a8a55 ("test: build app with meson as dpdk-test") Signed-off-by: Bruce Richardson --- test/test/meson.build | 4 +++- 1 file changed, 3 ins

[dpdk-dev] [PATCH v2 5/5] test/test: fix dependency on KNI lib for BSD meson build

2018-02-01 Thread Bruce Richardson
The KNI library is not built on FreeBSD, so it needs to be an optional rather than a mandatory dependency for building the autotest binary. Fixes: b5dc795a8a55 ("test: build app with meson as dpdk-test") Signed-off-by: Bruce Richardson --- test/test/meson.build | 3 +++ 1 file changed, 3 insert

[dpdk-dev] [PATCH v2 3/5] test/test: mark tests as skipped when required lib not available

2018-02-01 Thread Bruce Richardson
The power management and KNI libraries are not compiled on a FreeBSD platform, which means that the tests can't run. Add in stub code for these cases, allowing the tests to still be compiled, but to report as skipped in those cases. Signed-off-by: Bruce Richardson CC: Ferruh Yigit CC: David Hunt

[dpdk-dev] [PATCH v2 2/5] build: fix dependency on execinfo for BSD meson builds

2018-02-01 Thread Bruce Richardson
The binaries and apps in DPDK all need to be linked against the execinfo library on FreeBSD so add this as a dependency in cases where it is found. It's available by default on BSD, but not at all on Linux Fixes: 16ade738fd0d ("app/testpmd: build with meson") Fixes: 89f0711f9ddf ("examples: build

[dpdk-dev] [PATCH v2 1/5] eal/bsdapp: fix building kernel modules

2018-02-01 Thread Bruce Richardson
The kernel module source file directory passed via VPATH was wrong, which caused the source files to be not found via make. Rather than explicitly passing VPATH, make use of the fact that the full path to the source files is passed by meson, so split that into directory part - to be used as VPATH -

[dpdk-dev] [PATCH v2 0/5] Fix meson build on FreeBSD

2018-02-01 Thread Bruce Richardson
There are a few issues with building DPDK for FreeBSD using the meson build system, specifically: * the kernel modules aren't compiling due to an incorrect VPATH * a number of unit tests depend on libraries not supported on BSD * applications and examples need to be linked with execinfo library. -

Re: [dpdk-dev] [PATCH v2] doc: add preferred burst size support

2018-02-01 Thread Bruce Richardson
On Thu, Feb 01, 2018 at 07:58:32PM +0530, Shreyansh Jain wrote: > On Thursday 01 February 2018 06:57 PM, Bruce Richardson wrote: > > On Thu, Feb 01, 2018 at 06:18:23PM +0530, Shreyansh Jain wrote: > > > rte_eth_rx_burst(..,nb_pkts) function has semantic that if return value > > > is smaller than re

Re: [dpdk-dev] [PATCH v2] doc: add preferred burst size support

2018-02-01 Thread Shreyansh Jain
On Thursday 01 February 2018 06:57 PM, Bruce Richardson wrote: On Thu, Feb 01, 2018 at 06:18:23PM +0530, Shreyansh Jain wrote: rte_eth_rx_burst(..,nb_pkts) function has semantic that if return value is smaller than requested, application can consider it end of packet stream. Some hardware can on

[dpdk-dev] [PATCH] ethdev: check consistency of per port offloads

2018-02-01 Thread Wei Dai
A per port offloading feature should be enabled or disabled at same time in both rte_eth_dev_configure( ) and rte_eth_rx_queue_setup( )/rte_eth_tx_queue_setup( ). This patch check if a per port offloading flag has same configuration in rte_eth_dev_configure( ) and rte_eth_rx_queue_setup( )/rte_eth_

Re: [dpdk-dev] [RFC v2 01/17] mempool: fix phys contig check if populate default skipped

2018-02-01 Thread Andrew Rybchenko
On 02/01/2018 01:33 PM, santosh wrote: On Thursday 01 February 2018 03:44 PM, Olivier Matz wrote: On Thu, Feb 01, 2018 at 01:00:12PM +0300, Andrew Rybchenko wrote: On 02/01/2018 12:30 PM, santosh wrote: On Thursday 01 February 2018 02:48 PM, Andrew Rybchenko wrote: On 02/01/2018 12:09 PM, san

[dpdk-dev] [PATCH] mempool: fix phys contig check if populate default skipped

2018-02-01 Thread Andrew Rybchenko
There is not specified dependency between rte_mempool_populate_default() and rte_mempool_populate_iova(). So, the second should not rely on the fact that the first adds capability flags to the mempool flags. Fixes: 65cf769f5e6a ("mempool: detect physical contiguous objects") Cc: sta...@dpdk.org S

[dpdk-dev] [PATCH] buildtools: output build failure reason to stderr

2018-02-01 Thread Andrew Rybchenko
If build fails because of failed experimental check and stdout is redirected to /dev/null, it is absolutely unclear why build fails. Fixes: a4bcd61de82d ("buildtools: add script to check experimental API exports") Signed-off-by: Andrew Rybchenko --- buildtools/check-experimental-syms.sh | 8 +++

Re: [dpdk-dev] [RFC v2 03/17] mempool/octeontx: add callback to calculate memory size

2018-02-01 Thread santosh
On Thursday 01 February 2018 03:31 PM, santosh wrote: > Hi Andrew, > > > On Thursday 01 February 2018 11:48 AM, Jacob, Jerin wrote: >> The driver requires one and only one physically contiguous >> memory chunk for all objects. >> >> Signed-off-by: Andrew Rybchenko >> --- >> drivers/mempool/octe

[dpdk-dev] Link discovery using DPDK-based NICs

2018-02-01 Thread george . dit
Hi all, I wonder if there is any means in DPDK to perform link discovery. I know that DPDK is all about packet I/O, but maybe there is some library with useful functions that an application could use for link discovery (e.g., using LLDP). Any suggestions are much appreciated. Thanks, -- Georgios

Re: [dpdk-dev] [PATCH v2] doc: add preferred burst size support

2018-02-01 Thread Bruce Richardson
On Thu, Feb 01, 2018 at 06:18:23PM +0530, Shreyansh Jain wrote: > rte_eth_rx_burst(..,nb_pkts) function has semantic that if return value > is smaller than requested, application can consider it end of packet > stream. Some hardware can only support smaller burst sizes which need > to be advertised

Re: [dpdk-dev] [PATCH v3] net/i40e: fix multiple DDP packages should not be allowed

2018-02-01 Thread Chilikin, Andrey
> -Original Message- > From: Rybalchenko, Kirill > Sent: Thursday, February 1, 2018 12:43 PM > To: dev@dpdk.org > Cc: sta...@dpdk.org; Rybalchenko, Kirill ; > Chilikin, Andrey ; Xing, Beilei > ; Wu, Jingjing > Subject: [PATCH v3] net/i40e: fix multiple DDP packages should not be > allowed

[dpdk-dev] [PATCH] net/ena: fix jumbo support in Rx offloads flags

2018-02-01 Thread Rafal Kozik
ENA device supports Rx jumbo frames and such information needs to be provided in the offloads flags. Fixes: 7369f88f88c0 ("net/ena: convert to new Rx offloads API") Signed-off-by: Rafal Kozik --- drivers/net/ena/ena_ethdev.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/ena

Re: [dpdk-dev] [PATCH] test/test: clean up memory for func reentrancy test

2018-02-01 Thread Olivier Matz
On Wed, Jan 31, 2018 at 02:17:32PM +, Anatoly Burakov wrote: > Function reentrancy test limits maximum number of iterations based > on the number of memzones and cores, however it doesn't free the > memzones after the fact, so on a machine with big amount of cores > the tests will fail due to r

Re: [dpdk-dev] [PATCH 0/2] vhost: fix VIRTIO_NET_F_MQ vhost_scsi breakage

2018-02-01 Thread Maxime Coquelin
On 01/31/2018 06:46 PM, Stefan Hajnoczi wrote: These patches fix a recent regression in librte_vhost that breaks the vhost_scsi example application. vhost_user.c assumes all devices are vhost net backends when handling the VIRTIO_NET_F_MQ feature bit. The code is triggered by vhost scsi devic

Re: [dpdk-dev] [PATCH] doc: announce API/ABI changes for mempool

2018-02-01 Thread Hemant Agrawal
On 2/1/2018 12:10 PM, Jerin Jacob wrote: -Original Message- Date: Wed, 31 Jan 2018 17:46:51 +0100 From: Olivier Matz To: Andrew Rybchenko CC: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH] doc: announce API/ABI changes for mempool User-Agent: NeoMutt/20170113 (1.7.2) On Tue, Jan 23, 201

Re: [dpdk-dev] [PATCH] net/mlx5: fix flow priority on queue action

2018-02-01 Thread Shahaf Shuler
Thursday, February 1, 2018 3:42 AM, Yongseok Koh: > > On Jan 31, 2018, at 8:13 AM, Nelio Laranjeiro > wrote: > > > > A single queue should have the same verbs priority as an RSS one. > > > > Fixes: 8086cf08b2f0 ("net/mlx5: handle RSS hash configuration in RSS flow") > > Cc: sta...@dpdk.org > > > >

Re: [dpdk-dev] [PATCH v2] doc: add preferred burst size support

2018-02-01 Thread Andrew Rybchenko
On 02/01/2018 03:48 PM, Shreyansh Jain wrote: rte_eth_rx_burst(..,nb_pkts) function has semantic that if return value is smaller than requested, application can consider it end of packet stream. Some hardware can only support smaller burst sizes which need to be advertised. Similar is the case fo

Re: [dpdk-dev] [PATCH v2] doc: add preferred burst size support

2018-02-01 Thread Hemant Agrawal
On 2/1/2018 6:18 PM, Shreyansh Jain wrote: rte_eth_rx_burst(..,nb_pkts) function has semantic that if return value is smaller than requested, application can consider it end of packet stream. Some hardware can only support smaller burst sizes which need to be advertised. Similar is the case for T

Re: [dpdk-dev] [PATCH] net/mlx5: fix port stop by verify flows are still present

2018-02-01 Thread Shahaf Shuler
Tuesday, January 30, 2018 3:37 PM, Nelio Laranjeiro: > priv_flow_stop() may be called several times, in such situation flows are > already removed from the NIC and thus all associated objects are no present > in the flow object (ibv_flow, indirections tables, ). s/indirections/ indirection >

Re: [dpdk-dev] [PATCH 2/2] vhost: only drop vqs with built-in virtio_net.c driver

2018-02-01 Thread Maxime Coquelin
On 02/01/2018 11:24 AM, Stefan Hajnoczi wrote: On Wed, Jan 31, 2018 at 07:07:50PM +0100, Maxime Coquelin wrote: Hi Stefan, On 01/31/2018 06:46 PM, Stefan Hajnoczi wrote: Commit e29109323595beb3884da58126ebb3b878cb66f5 ("vhost: destroy unused virtqueues when multiqueue not negotiated") broke

Re: [dpdk-dev] [PATCH v2] relicense various bits of the dpdk

2018-02-01 Thread Hemant Agrawal
On 2/1/2018 5:49 PM, Neil Horman wrote: Received a note the other day from the Linux Foundation governance board for DPDK indicating that several files I have copyright on need to be relicensed to be compliant with the DPDK licensing guidelines. I have some concerns with some parts of the reques

[dpdk-dev] [PATCH v3] net/i40e: fix multiple DDP packages should not be allowed

2018-02-01 Thread Kirill Rybalchenko
Should be not possible to load conflicting DDP profiles. Only DDP profiles of the same group (not 0) can be loaded together; If DDP profile group is 0, it is exclusive, i.e. it cannot be loaded with any other DDP profile; If DDP profile groups are different - these profiles cannot be loaded togethe

[dpdk-dev] [PATCH v2] doc: add preferred burst size support

2018-02-01 Thread Shreyansh Jain
rte_eth_rx_burst(..,nb_pkts) function has semantic that if return value is smaller than requested, application can consider it end of packet stream. Some hardware can only support smaller burst sizes which need to be advertised. Similar is the case for Tx burst. This patch adds deprecation notice

[dpdk-dev] [PATCH] doc/ip_pipeline.rst: update f_post_init and correct f_track

2018-02-01 Thread longtb5
Update f_post_init for pipeline frontend. Move f_track from pipeline backend to pipeline frontend. Signed-off-by: longtb5 --- doc/guides/sample_app_ug/ip_pipeline.rst | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/doc/guides/sample_app_ug/ip_pipeline.rst b/doc/guides/

[dpdk-dev] [PATCH] doc: add preferred burst size support

2018-02-01 Thread Shreyansh Jain
rte_eth_rx_burst(..,nb_pkts) function has semantic that if return value is smaller than requested, application can consider it end of packet stream. Some hardware can only support smaller burst sizes which need to be advertised. Similar is the case for Tx burst. This patch adds deprecation notice

[dpdk-dev] [PATCH v2] relicense various bits of the dpdk

2018-02-01 Thread Neil Horman
Received a note the other day from the Linux Foundation governance board for DPDK indicating that several files I have copyright on need to be relicensed to be compliant with the DPDK licensing guidelines. I have some concerns with some parts of the request, but am not opposed to other parts. So,

[dpdk-dev] [PATCH v2 3/3] net/i40e: fix multiple driver support issue

2018-02-01 Thread Beilei Xing
This patch provides the option to disable writing some global registers in PMD, in order to avoid affecting other drivers, when multiple drivers run on the same NIC and control different physical ports. Because there are few global resources shared among different physical ports. Fixes: ec246eeb5d

[dpdk-dev] [PATCH v2 2/3] net/i40e: add debug logs when writing global registers

2018-02-01 Thread Beilei Xing
Add debug logs when writing global registers. Signed-off-by: Beilei Xing Cc: sta...@dpdk.org --- drivers/net/i40e/i40e_ethdev.c | 131 ++--- drivers/net/i40e/i40e_ethdev.h | 9 +++ 2 files changed, 92 insertions(+), 48 deletions(-) diff --git a/drivers/net/

[dpdk-dev] [PATCH v2 0/3] net/i40e: fix multiple driver support issue

2018-02-01 Thread Beilei Xing
DPDK i40e PMD will modify some global registers during initialization and post initialization, there'll be impact during use of 700 series Ethernet Adapter with both Linux kernel and DPDK PMD. This patchset adds logs for global configuration and adds device args to disable global configuration. Th

[dpdk-dev] [PATCH v2 1/3] net/i40e: add warnings when writing global registers

2018-02-01 Thread Beilei Xing
Add warnings when writing global registers. Signed-off-by: Beilei Xing Cc: sta...@dpdk.org --- doc/guides/nics/i40e.rst | 12 drivers/net/i40e/i40e_ethdev.c | 15 +++ drivers/net/i40e/i40e_ethdev.h | 43 ++ 3 files changed, 7

Re: [dpdk-dev] [RFC v2] doc compression API for DPDK

2018-02-01 Thread Trahe, Fiona
> >[Fiona] I propose if BFINAL bit is detected before end of input > >the decompression should stop. In this case consumed will be < src.length. > >produced will be < dst buffer size. Do we need an extra STATUS response? > >STATUS_BFINAL_DETECTED ? > [Shally] @fiona, I assume you mean here decomp

Re: [dpdk-dev] [PATCH] net/i40e: fix missing deps for avx2 code in meson

2018-02-01 Thread Bruce Richardson
On Wed, Jan 31, 2018 at 05:09:05PM +, Bruce Richardson wrote: > The AVX2 code path includes files from the ethdev, hash and kvargs libs. > These are not listed as dependencies in the case where AVX2 is not in > the default instruction set for the build e.g. machine=nehalem. This > leads to comp

[dpdk-dev] [PATCH v3 2/3] net/i40e: add debug logs when writing global registers

2018-02-01 Thread Beilei Xing
Add debug logs when writing global registers. Signed-off-by: Beilei Xing --- drivers/net/i40e/i40e_ethdev.c | 153 ++--- drivers/net/i40e/i40e_ethdev.h | 11 +++ 2 files changed, 123 insertions(+), 41 deletions(-) diff --git a/drivers/net/i40e/i40e_ethdev.c

[dpdk-dev] [PATCH v3 3/3] net/i40e: fix multiple driver support issue

2018-02-01 Thread Beilei Xing
This patch provides the option to disable writing some global registers in PMD, in order to avoid affecting other drivers, when multiple drivers run on the same NIC and control different physical ports. Because there are few global resources shared among different physical ports. Fixes: ec246eeb5d

[dpdk-dev] [PATCH v3 0/3] net/i40e: fix multiple driver support issue

2018-02-01 Thread Beilei Xing
DPDK i40e PMD will modify some global registers during initialization and post initialization, there'll be impact during use of 700 series Ethernet Adapter with both Linux kernel and DPDK PMD. This patchset adds log for global configuration and adds device args to disable global configuration. v3

[dpdk-dev] [PATCH v3 1/3] net/i40e: add warnings when writing global registers

2018-02-01 Thread Beilei Xing
Add warnings when writing global registers. Signed-off-by: Beilei Xing --- doc/guides/nics/i40e.rst | 12 drivers/net/i40e/i40e_ethdev.c | 25 drivers/net/i40e/i40e_ethdev.h | 43 ++ drivers/net/i40e/i40e_fdir.c

[dpdk-dev] [PATCH 1/2] doc: update mlx PMD release notes

2018-02-01 Thread Shahaf Shuler
Signed-off-by: Shahaf Shuler --- doc/guides/rel_notes/release_18_02.rst | 27 +++ 1 file changed, 27 insertions(+) diff --git a/doc/guides/rel_notes/release_18_02.rst b/doc/guides/rel_notes/release_18_02.rst index 689080bed..714a24388 100644 --- a/doc/guides/rel_notes/re

[dpdk-dev] [PATCH 2/2] doc: update mlx5 required OFED version

2018-02-01 Thread Shahaf Shuler
Signed-off-by: Shahaf Shuler --- doc/guides/nics/mlx5.rst | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/doc/guides/nics/mlx5.rst b/doc/guides/nics/mlx5.rst index a9e4bf51a..b2376363b 100644 --- a/doc/guides/nics/mlx5.rst +++ b/doc/guides/nics/mlx5.rst @@ -131,7 +131,7 @@

[dpdk-dev] [PATCH] ethdev: fix comments for offload capabilites

2018-02-01 Thread Wei Dai
Indeed, rx_offload_capa or tx_offload_capa in struct rte_eth_dev_info includes not only per port offloading features but also per queue ones. This patch make its meaning much clearer. Fixes: ce17eddefc20 ("ethdev: introduce Rx queue offloads API") Fixes: cba7f53b717d ("ethdev: introduce Tx queue

[dpdk-dev] FW: [RFC v1 1/1] lib/cryptodev: add support of asymmetric crypto

2018-02-01 Thread Verma, Shally
Hi Pablo/Fiona Could you please provide your input on this RFC. Your feedback is awaited. Thanks Shally -Original Message- From: Verma, Shally Sent: 23 January 2018 15:24 To: declan.dohe...@intel.com Cc: dev@dpdk.org; Athreya, Narayana Prasad ; Murthy, Nidadavolu ; Sahu, Sunila ; Gupt

[dpdk-dev] [PATCH v3] test/bonding: assign non-zero MAC to null devices

2018-02-01 Thread Radu Nicolau
Prevent failure in rte_eth_dev_default_mac_addr_set() that resunts in bonding add slave failure. Fixes: aa7791ba8de0 ("net/bonding: fix setting slave MAC addresses") Signed-off-by: Radu Nicolau --- v3: update commit message test/test/test_link_bonding_rssconf.c | 5 + 1 file changed, 5 ins

[dpdk-dev] [RFC v4 1/1] lib/compressdev: Adding hash support

2018-02-01 Thread Shally Verma
Added hash support in lib compressdev. It's an incremental patch to compression lib RFC v3 https://dpdk.org/dev/patchwork/patch/32331/ Changes from RFC v3: - Added hash algo enumeration and associated capability stucture and params in xform and rte_comp_op - Rearranged rte_compresdev_capability

[dpdk-dev] [PATCH v2] net/failsafe: fix strerror call in sub-eal

2018-02-01 Thread Gaetan Rivet
Ownership API returns a negative value, strerror expects a valid errno value, thus positive. Coverity issue: 260401 Fixes: dcd0c9c32b8d ("net/failsafe: use ownership mechanism for slaves") Signed-off-by: Gaetan Rivet --- v2: Fix coverity reference syntax in commit log. drivers/net/failsafe/fa

[dpdk-dev] [PATCH v2] test/bonding: assign non-zero MAC to null devices

2018-02-01 Thread Radu Nicolau
Prevent failure in rte_eth_dev_default_mac_addr_set() that resunts in bonding add slave failure. Signed-off-by: Radu Nicolau --- v2: update commit message test/test/test_link_bonding_rssconf.c | 5 + 1 file changed, 5 insertions(+) diff --git a/test/test/test_link_bonding_rssconf.c b/test

[dpdk-dev] [PATCH v2] test/virtual_pmd: add set MAC address dev op

2018-02-01 Thread Radu Nicolau
Needed if used with net/bonding Signed-off-by: Radu Nicolau --- v2: remove redundant memcpy test/test/virtual_pmd.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/test/test/virtual_pmd.c b/test/test/virtual_pmd.c index 7a7adbb..2f5b31d 100644 --- a/test/test/virtual_p

[dpdk-dev] [PATCH v2] net/null: add set MAC address dev op

2018-02-01 Thread Radu Nicolau
Needed if used with net/bonding Signed-off-by: Radu Nicolau --- v2: remove redundant memcpy drivers/net/null/rte_eth_null.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/net/null/rte_eth_null.c b/drivers/net/null/rte_eth_null.c index 9385ffd..d003b28 100644 --- a/drivers/ne

[dpdk-dev] [PATCH 1/3] net/null: add set MAC address dev op

2018-02-01 Thread Radu Nicolau
Needed if used with net/bonding Signed-off-by: Radu Nicolau --- v2: remove redundant memcpy drivers/net/null/rte_eth_null.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/net/null/rte_eth_null.c b/drivers/net/null/rte_eth_null.c index 9385ffd..d003b28 100644 --- a/drivers/ne

[dpdk-dev] [PATCH 1/3] net/null: add set MAC address dev op

2018-02-01 Thread Radu Nicolau
Needed if used with net/bonding Signed-off-by: Radu Nicolau --- v2: remove redundant memcpy drivers/net/null/rte_eth_null.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/net/null/rte_eth_null.c b/drivers/net/null/rte_eth_null.c index 9385ffd..d003b28 100644 --- a/drivers/ne

Re: [dpdk-dev] [RFC v2 01/17] mempool: fix phys contig check if populate default skipped

2018-02-01 Thread santosh
On Thursday 01 February 2018 03:44 PM, Olivier Matz wrote: > On Thu, Feb 01, 2018 at 01:00:12PM +0300, Andrew Rybchenko wrote: >> On 02/01/2018 12:30 PM, santosh wrote: >>> On Thursday 01 February 2018 02:48 PM, Andrew Rybchenko wrote: On 02/01/2018 12:09 PM, santosh wrote: > On Thursday

  1   2   >