[dpdk-dev] [PATCH v3] app/testpmd: fix port_id alloction issue

2018-02-04 Thread Yanglong Wu
In the feature of increasing port_id range from 8 bits to 16 bits, vlan port_id allocation function was forget to substitute UINT8 with UINT16, so the vlan port_id was allocated as a inccrete number. Fixes:28caa76aea71 ("app/testpmd: fix port id type") Signed-off-by: Yanglong Wu Reviewed-by: Zhi

Re: [dpdk-dev] [PATCH v2 2/2] doc: update mlx PMD required OFED version

2018-02-04 Thread NĂ©lio Laranjeiro
On Sun, Feb 04, 2018 at 09:08:06AM +0200, Shahaf Shuler wrote: > Signed-off-by: Shahaf Shuler > --- > > On v2: > - Updated the OFED version for mlx4 guide as well. > > --- > doc/guides/nics/mlx4.rst | 2 +- > doc/guides/nics/mlx5.rst | 4 ++-- > 2 files changed, 3 insertions(+), 3 deletions(-)

[dpdk-dev] [PATCH] test: use the best mempool ops API to get mbuf pool

2018-02-04 Thread Nipun Gupta
From: Hemant Agrawal This patch replaces the uses of default mempool ops API with newly supported best_mempool_ops API. Signed-off-by: Hemant Agrawal --- test/test/test_mempool.c | 3 ++- test/test/test_mempool_perf.c | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a

Re: [dpdk-dev] [PATCH v2] app/testpmd:vlan filter fail

2018-02-04 Thread Wu, Yanglong
Thx! I will change it right now -Original Message- From: Shahaf Shuler [mailto:shah...@mellanox.com] Sent: Monday, February 5, 2018 2:14 PM To: Wu, Yanglong ; dev@dpdk.org Cc: Lu, Wenzhuo Subject: RE: [PATCH v2] app/testpmd:vlan filter fail Hi Wu, Few small comment. Monday, February

Re: [dpdk-dev] [PATCH 1/4] bus/fslmc: fix registering dpaa2 mempool ops

2018-02-04 Thread Shreyansh Jain
> -Original Message- > From: Nipun Gupta > Sent: Monday, February 5, 2018 10:52 AM > To: tho...@monjalon.net; jerin.ja...@caviumnetworks.com > Cc: dev@dpdk.org; santosh.shu...@caviumnetworks.com; Hemant Agrawal > ; Shreyansh Jain ; > Sunil Kumar Kori ; Nipun Gupta > > Subject: [PATCH 1/4]

Re: [dpdk-dev] [PATCH 2/4] bus/dpaa: fix registering dpaa mempool ops

2018-02-04 Thread Shreyansh Jain
> -Original Message- > From: Nipun Gupta > Sent: Monday, February 5, 2018 10:52 AM > To: tho...@monjalon.net; jerin.ja...@caviumnetworks.com > Cc: dev@dpdk.org; santosh.shu...@caviumnetworks.com; Hemant Agrawal > ; Shreyansh Jain ; > Sunil Kumar Kori ; Nipun Gupta > > Subject: [PATCH 2/4]

Re: [dpdk-dev] [PATCH v3] doc: add preferred burst size support

2018-02-04 Thread Yang, Zhiyong
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Shreyansh Jain > Sent: Monday, February 5, 2018 2:22 PM > To: dev@dpdk.org > Cc: Yigit, Ferruh ; tho...@monjalon.net; > Richardson, Bruce ; Ananyev, Konstantin > ; hemant.agra...@nxp.com; > ma...@mellanox.com; Shr

Re: [dpdk-dev] [PATCH v2] app/testpmd:vlan filter fail

2018-02-04 Thread Shahaf Shuler
Hi Wu, Few small comment. Monday, February 5, 2018 4:34 AM, Yanglong Wu: > Subject: [PATCH v2] app/testpmd:vlan filter fail The commit title can better describe the patch, something like: "app/testpmd: fix port DCB configuration" > > This bug is caused by miss port configuration. The above

[dpdk-dev] [PATCH v3] doc: add preferred burst size support

2018-02-04 Thread Shreyansh Jain
rte_eth_rx_burst(..,nb_pkts) function has semantic that if return value is smaller than requested, application can consider it end of packet stream. Some hardware can only support smaller burst sizes which need to be advertised. Similar is the case for Tx burst. This patch adds deprecation notice

Re: [dpdk-dev] [PATCH v2] net/octeontx: register fpa as platform HW mempool

2018-02-04 Thread santosh
On Sunday 04 February 2018 09:03 PM, Pavan Nikhilesh wrote: > Register octeontx-fpavf as platform HW mempool when net/octeontx pmd is > used. > > Signed-off-by: Pavan Nikhilesh > --- Acked-by: Santosh Shukla

Re: [dpdk-dev] [PATCH 2/4] bus/dpaa: fix registering dpaa mempool ops

2018-02-04 Thread santosh
On Monday 05 February 2018 10:51 AM, Nipun Gupta wrote: > Fixes: 2bd0d5b951a9 ("bus/dpaa: register platform HW mempool on runtime") > > Signed-off-by: Nipun Gupta > --- > drivers/bus/dpaa/dpaa_bus.c | 8 +++- > 1 file changed, 7 insertions(+), 1 deletion(-) > > diff --git a/drivers/bus/dpaa/

Re: [dpdk-dev] [PATCH v2] doc: add preferred burst size support

2018-02-04 Thread Shreyansh Jain
Hi Bruce, On Thursday 01 February 2018 07:49 PM, Bruce Richardson wrote: On Thu, Feb 01, 2018 at 07:58:32PM +0530, Shreyansh Jain wrote: On Thursday 01 February 2018 06:57 PM, Bruce Richardson wrote: On Thu, Feb 01, 2018 at 06:18:23PM +0530, Shreyansh Jain wrote: rte_eth_rx_burst(..,nb_pkts)

[dpdk-dev] [PATCH 3/4] event/dpaa: rename dpaa vdev with dpaa1

2018-02-04 Thread Nipun Gupta
DPAA2 eventdev is named as event_dpaa2 which conflicts with event_dpaa when both are compiled in together. So event_dpaa is required to renamed. Fixes: 1ee9569576f6 ("config: enable dpaaX drivers for generic ARMv8") Signed-off-by: Nipun Gupta --- doc/guides/eventdevs/dpaa.rst | 6 +++--- d

[dpdk-dev] [PATCH 4/4] event/dpaa: fix portal allocation

2018-02-04 Thread Nipun Gupta
Checking if portal has been allocated is now required at the caller of rte_dpaa_portal_init() API. This patch adds check in the dpaa eventdev driver. Fixes: 5d944582d028 ("bus/dpaa: check portal presence in the caller function") Signed-off-by: Nipun Gupta --- drivers/event/dpaa/dpaa_eventdev.c

[dpdk-dev] [PATCH 2/4] bus/dpaa: fix registering dpaa mempool ops

2018-02-04 Thread Nipun Gupta
Fixes: 2bd0d5b951a9 ("bus/dpaa: register platform HW mempool on runtime") Signed-off-by: Nipun Gupta --- drivers/bus/dpaa/dpaa_bus.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/bus/dpaa/dpaa_bus.c b/drivers/bus/dpaa/dpaa_bus.c index 1946bbe..290b967 100644

[dpdk-dev] [PATCH 1/4] bus/fslmc: fix registering dpaa2 mempool ops

2018-02-04 Thread Nipun Gupta
Fixes: 8824b74d8f5f ("bus/fslmc: register platform HW mempool on runtime") Signed-off-by: Nipun Gupta --- Though I have sent these patches yesterday, but they did not reach out. If by any chance they have entered your mailbox before please ignore the older patches. drivers/bus/fslmc/portal/dpaa

[dpdk-dev] [PATCH v2] app/testpmd:vlan filter fail

2018-02-04 Thread Yanglong Wu
This bug is caused by miss port configuration. The port_conf for the DCB configuration should inherit the same configuration of the port. Fix:0074d02fc(convert to new Rx offloads API) Signed-off-by: Yanglong Wu --- v2: changing patch accoding to the review --- app/test-pmd/testpmd.c | 3 +++ 1 f

Re: [dpdk-dev] [PATCH] app/testpmd:vlan filter fail

2018-02-04 Thread Wu, Yanglong
Hi, Thanks for your review. I got it! Yanglong Wu -Original Message- From: Shahaf Shuler [mailto:shah...@mellanox.com] Sent: Sunday, February 4, 2018 2:27 PM To: Wu, Yanglong ; dev@dpdk.org Cc: Lu, Wenzhuo Subject: RE: [PATCH] app/testpmd:vlan filter fail Hi Wu, Indeed there is an issu

[dpdk-dev] [PATCH v3 5/5] net/ixgbe: remove the unnecessary call rte_intr_enable.

2018-02-04 Thread xiangxia . m . yue
From: Tonghao Zhang When binding the ixgbe pf or vf to vfio and call the rte_eth_dev_rx_intr_enable frequently, the interrupt setting (msi_set_mask_bit) will take more CPU as show below. rte_intr_enable calls the ioctl to map the fd to interrupts frequently. perf top: 5.45% [kernel] [k] msi_s

[dpdk-dev] [PATCH v3 4/5] net/ixgbevf: save IXGBE_VTEIMS to intr->mask for performance.

2018-02-04 Thread xiangxia . m . yue
From: Tonghao Zhang If dpdk APPs call the rte_eth_dev_rx_intr_enable or rte_eth_dev_rx_intr_disable frequently, and ixgbe vf will read the IXGBE_VTEIMS register everytime. The patch saves the IXGBE_VTEIMS to mask to avoid read frequently. Signed-off-by: Tonghao Zhang Acked-by: Beilei Xing Acke

[dpdk-dev] [PATCH v3 3/5] net/ixgbe: write disable to ITR counter.

2018-02-04 Thread xiangxia . m . yue
From: Tonghao Zhang ixgbe doesn't write the ITR counter, disable it now. Signed-off-by: Tonghao Zhang --- drivers/net/ixgbe/ixgbe_ethdev.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c index 14296ea..0e

[dpdk-dev] [PATCH v3 1/5] net/ixgbevf: set the inter-interrupt interval for EITR.

2018-02-04 Thread xiangxia . m . yue
From: Tonghao Zhang Set EITR interval as default. This patch can improve the performance when we enable the rx-intrrupt to process the packets because we hope rx-intrrupt reduce CPU. For example, the 200us value of EITR makes the performance better with the low CPU. Users can configure the value

[dpdk-dev] [PATCH v3 2/5] net/ixgbe: set the ITR via configuration.

2018-02-04 Thread xiangxia . m . yue
From: Tonghao Zhang With this patch, the ITR value of ixgbe PF, can be configured as wanted. Signed-off-by: Tonghao Zhang --- drivers/net/ixgbe/ixgbe_ethdev.c | 5 + drivers/net/ixgbe/ixgbe_rxtx.c | 3 ++- 2 files changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/net/ixgbe/i

[dpdk-dev] [PATCH v3 0/5] ixgbe: fix bugs or just improve.

2018-02-04 Thread xiangxia . m . yue
From: Tonghao Zhang The patches in the patchset have no dependency. But all of them is about ixgbe or ixgbevf. The patch 1 and 2 add the itr configuration for ixgbe and ixgbevf, the user and developer can configure it for their platform. Other patches refine the ixgbe or ixgbevf. v2 --> v3: remo

[dpdk-dev] [PATCH v2] eventdev: fix unchecked return in default Rx adapter conf cb

2018-02-04 Thread Nikhil Rao
The default adapter configuration callback is invoked when a Rx queue is added to the adapter and the adapter detects that a SW service is needed. The adapter needs to re-configure the device with an additional port and to do do, it needs to stop the device and restart it after it is done reconfigu

[dpdk-dev] [PATCH 2/2] app/testpmd: use dedicated function to get Tx port

2018-02-04 Thread Matan Azrad
A new function was added to get a Tx port as a function of the topology mode and the Rx port. Use this function to get the Tx port of simple stream. Signed-off-by: Matan Azrad --- app/test-pmd/config.c | 31 +++ 1 file changed, 3 insertions(+), 28 deletions(-) diff

[dpdk-dev] [PATCH 1/2] app/testpmd: fix RSS stream invalid Tx port set

2018-02-04 Thread Matan Azrad
Testpmd application configures RSS forward streams, by default, when the number of queues is higher than 1. In this mode the configured port topology is not taken into account. Morever, the Tx port may be invalid in case of odd number of forward ports. Configure the RSS stream Tx port by dedicate

[dpdk-dev] [PATCH v2] net/octeontx: register fpa as platform HW mempool

2018-02-04 Thread Pavan Nikhilesh
Register octeontx-fpavf as platform HW mempool when net/octeontx pmd is used. Signed-off-by: Pavan Nikhilesh --- v2 Changes: - fixed compilation issues caused by using experimental API in both meson and make. drivers/net/octeontx/Makefile | 2 ++ drivers/net/octeontx/meson.build

Re: [dpdk-dev] [PATCH v2 3/4] net/mlx: version rdma-core glue libraries

2018-02-04 Thread Thomas Monjalon
02/02/2018 17:46, Adrien Mazarguil: > --- a/drivers/net/mlx4/Makefile > +++ b/drivers/net/mlx4/Makefile > @@ -33,7 +33,9 @@ include $(RTE_SDK)/mk/rte.vars.mk > > # Library name. > LIB = librte_pmd_mlx4.a > -LIB_GLUE = librte_pmd_mlx4_glue.so > +LIB_GLUE = $(LIB_GLUE_BASE).$(LIB_GLUE_VERSION) >

Re: [dpdk-dev] [PATCH] compressdev: implement API

2018-02-04 Thread Thomas Monjalon
02/02/2018 19:25, Fiona Trahe: > config/common_base | 6 + > doc/api/doxy-api-index.md | 1 + > doc/api/doxy-api.conf | 1 + > lib/Makefile | 3 + > lib/librte_compre

Re: [dpdk-dev] [PATCH] compressdev: implement API

2018-02-04 Thread Thomas Monjalon
02/02/2018 19:25, Fiona Trahe: > - Used dynamic logging [...] > --- a/lib/librte_eal/common/include/rte_log.h > +++ b/lib/librte_eal/common/include/rte_log.h > @@ -60,6 +60,7 @@ extern struct rte_logs rte_logs; > #define RTE_LOGTYPE_EFD 18 /**< Log related to EFD. */ > #define RTE_LOGTYPE_E

Re: [dpdk-dev] [PATCH v3] checkpatches.sh: Add checks for ABI symbol addition

2018-02-04 Thread Thomas Monjalon
31/01/2018 18:27, Neil Horman: > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -42,6 +42,7 @@ F: doc/ > > Developers and Maintainers Tools > M: Thomas Monjalon > +M: Neil Horman > F: MAINTAINERS > F: devtools/check-dup-includes.sh > F: devtools/check-maintainers.sh You don't need to add your

[dpdk-dev] [PATCH 0/3] add vDPA sample driver

2018-02-04 Thread Xiao Wang
This patch set has dependency on the vhost lib patch: http://dpdk.org/dev/patchwork/patch/34872/ This patch set shows a reference sample of making vDPA device driver , this driver uses a QEMU-emulated virtio-net PCI device as vDPA device, and make it serve as a backend for a virtio-net pci device

[dpdk-dev] [PATCH 3/3] examples/vdpa: add a new sample for vdpa

2018-02-04 Thread Xiao Wang
This patch adds a sample which creates vhost-user socket based on vdpa driver. vdpa driver can help to set up vhost datapath so this app doesn't need to spend a dedicated worker thread on vhost enqueue/dequeue operations. Below are setup steps for your reference: 1. Make sure your kernnel vhost m

[dpdk-dev] [PATCH 1/3] bus/pci: expose API for vDPA

2018-02-04 Thread Xiao Wang
Some existing PCI APIs are helpful for vDPA device setup, expose them for the later driver patch. Signed-off-by: Xiao Wang --- drivers/bus/pci/Makefile| 1 + drivers/bus/pci/linux/pci.c | 10 +++--- drivers/bus/pci/linux/pci_init.h| 22 +++

[dpdk-dev] [PATCH 2/3] net/vdpa_virtio_pci: introduce vdpa sample driver

2018-02-04 Thread Xiao Wang
This driver is a reference sample of making vDPA device driver based on vhost lib, this driver uses a standard virtio-net PCI device as vDPA device, it can serve as a backend for a virtio-net pci device in nested VM. The key driver ops implemented are: * vdpa_virtio_eng_init Mapping virtio pci de

Re: [dpdk-dev] XL710: [Q] traffic steering under DPDK.

2018-02-04 Thread Zhang, Qi Z
Hi Arkady: See my comment inline Regards Qi > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Arkady Gilinsky > Sent: Friday, February 2, 2018 4:15 PM > To: dev@dpdk.org > Subject: [dpdk-dev] XL710: [Q] traffic steering under DPDK. > > Hi, > > Basicall

Re: [dpdk-dev] [PATCH FIX-OPTION-1] mbuf: fix the logic of user mempool ops API

2018-02-04 Thread Hemant Agrawal
Thanks we also identified it. The fix is on the way. Sent from my Android phone using TouchDown (www.symantec.com) -Original Message- From: santosh [santosh.shu...@caviumnetworks.com] Received: Sunday, 04 Feb 2018, 12:05PM To: Hemant Agrawal [hemant.agra...@nxp.com]; dev [dev@dpdk.org] CC