Re: [dpdk-dev] [PATCH v1] net/mlx: control netdevices through ioctl only

2018-02-09 Thread Marcelo Ricardo Leitner
On Thu, Feb 08, 2018 at 05:37:06PM +0100, Adrien Mazarguil wrote: > Several control operations implemented by these PMDs affect netdevices > through sysfs, itself subject to file system permission checks enforced by > the kernel, which limits their use for most purposes to applications > running wi

[dpdk-dev] [PATCH 1/2] test/bitmap: add additional tests

2018-02-09 Thread Chas Williams
From: "Charles (Chas) Williams" Add addtional units tests for the rte_bitmap_scan() routine. Test that we are gettting the bits returned that we expect. Signed-off-by: Chas Williams --- test/test/test_bitmap.c | 68 + 1 file changed, 68 insertio

[dpdk-dev] [PATCH 2/2] lib: fix bitmap scanning

2018-02-09 Thread Chas Williams
From: "Charles (Chas) Williams" index2 is used inconsistently, both as an array offset and as a bit offset. Fix usage to be consistent as a bit offset. Additonally, offset1 needs to be shifted with the size of the array1 slab entries, not the cache line sizes. __rte_bitmap_scan_read() needs to

Re: [dpdk-dev] [RFC v1 1/1] lib/cryptodev: add support of asymmetric crypto

2018-02-09 Thread Trahe, Fiona
Hi Shally, Comments below. > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Shally Verma > Sent: Tuesday, January 23, 2018 9:54 AM > To: Doherty, Declan > Cc: dev@dpdk.org; pathr...@caviumnetworks.com; nmur...@caviumnetworks.com; > ss...@caviumnetworks.com; agu.

[dpdk-dev] [PATCH] doc: add missing SFN8xxx adapters to the list of supported

2018-02-09 Thread Andrew Rybchenko
Signed-off-by: Andrew Rybchenko --- doc/guides/nics/sfc_efx.rst | 6 ++ 1 file changed, 6 insertions(+) diff --git a/doc/guides/nics/sfc_efx.rst b/doc/guides/nics/sfc_efx.rst index 8e0782c..ccdf5ff 100644 --- a/doc/guides/nics/sfc_efx.rst +++ b/doc/guides/nics/sfc_efx.rst @@ -192,8 +192,14 @

Re: [dpdk-dev] IXGBE, IOMMU DMAR DRHD handling fault issue

2018-02-09 Thread Ravi Kerur
On Thu, Feb 8, 2018 at 3:20 AM, Burakov, Anatoly wrote: > On 06-Feb-18 5:55 PM, Ravi Kerur wrote: > >> >> Hi Anatoly, >> >> I am actually confused with the state of vIOMMU + DPDK. Can you please >> help me clarify? >> >> I tested following DPDK versions >> >> (1) DPDK 17.11, exhibits the issue (I

[dpdk-dev] [PATCH] vhost: reduce size of coredump file

2018-02-09 Thread Tomasz Kulasek
If application coredumps with vhost-user devices connected to it, the generated coredump file size is huge. To limit its size, this patch adds call to madvise() with MADV_DONTDUMP on memory regions mapped from the VM. Signed-off-by: Sebastian Basierski Signed-off-by: Tomasz Kulasek --- lib/lib

[dpdk-dev] [PATCH] vhost: fix wait for valid descriptor

2018-02-09 Thread Tomasz Kulasek
For each virt queue's kickfd and callfd, there are 2 invalid status: VIRTIO_UNINITIALIZED_EVENTFD and VIRTIO_INVALID_EVENTFD. Don't set the virt queue to ready status until got the valid descriptor. This is safe for polling mode drivers in Guest OS, the backend vhost process will not post notifica

[dpdk-dev] [PATCH] vhost: fix return avail ring position in get vring base

2018-02-09 Thread Tomasz Kulasek
According to the "Vhost-user Protocol" document, VHOST_USER_GET_VRING_BASE should get the available vring base offset. Fixes: 8f972312b8f4 ("vhost: support vhost-user") Cc: huawei@intel.com Cc: sta...@dpdk.org Signed-off-by: Pawel Wodkowski Signed-off-by: Tomasz Kulasek --- lib/librte_vhos

[dpdk-dev] [PATCH] vhost: fix remove macro name conflict

2018-02-09 Thread Tomasz Kulasek
LOG_DEBUG is a symbol defined by POSIX, so if sys/log.h is included the symbols conflict. This patch changes LOG_DEBUG to VHOST_LOG_DEBUG. Fixes: 1c01d52392d5 ("vhost: add debug print") Cc: huawei@intel.com Cc: sta...@dpdk.org Signed-off-by: Ben Walker Signed-off-by: Tomasz Kulasek --- li

[dpdk-dev] [PATCH] vhost: fix realloc failure

2018-02-09 Thread Tomasz Kulasek
When reallocation of guest pages fails, vhost_user_set_mem_table() also should fail. Fixes: e246896178e6 ("vhost: get guest/host physical address mappings") Cc: yuanhan@linux.intel.com Cc: sta...@dpdk.org Signed-off-by: Ziye Yang Signed-off-by: Tomasz Kulasek --- lib/librte_vhost/vhost_use

[dpdk-dev] [PATCH] vhost: fix double free on shutdown

2018-02-09 Thread Tomasz Kulasek
The vhost connection can be closed concurrently from 2 places: * the connection thread itself * rte_vhost_driver_unregister The connection thread will terminate the connection if any recv error occurred. The unregister function will terminate the connection together with the thread. However, the

[dpdk-dev] [PATCH] vhost: fix close callfd on get vring base

2018-02-09 Thread Tomasz Kulasek
This prevents from destroying & recreating user device in "incomplete" vring state. virtio_is_ready() was returning true for devices with vrings which did not have valid callfd (their VHOST_USER_SET_VRING_CALL hasn't arrived yet) Fixes: 8f972312b8f4 ("vhost: support vhost-user") Cc: huawei@int

[dpdk-dev] [PATCH v2] vhost: fix check if cmsg is NULL

2018-02-09 Thread Tomasz Kulasek
Fixes: 8f972312b8f4 ("vhost: support vhost-user") Cc: jianfeng@intel.com Cc: sta...@dpdk.org Signed-off-by: Pawel Wodkowski Signed-off-by: Tomasz Kulasek --- v2 changes: - Changed fixline to point right commit --- lib/librte_vhost/socket.c | 5 + 1 file changed, 5 insertions(+) diff

[dpdk-dev] [PATCH] doc: add change notice for mbuf sched field

2018-02-09 Thread Cristian Dumitrescu
Signed-off-by: Cristian Dumitrescu Acked-by: Jasvinder Singh Acked-by: Roy Fan Zhang Acked-by: Kevin Laatz --- doc/guides/rel_notes/deprecation.rst | 5 + 1 file changed, 5 insertions(+) diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst index d59ad5

Re: [dpdk-dev] [PATCH v1] doc: update mlx4 flow limitations

2018-02-09 Thread Thomas Monjalon
09/02/2018 17:21, Adrien Mazarguil: > This section is titled "Limitations" but contains a mix of features, > limitations and quirks, more like "Random thoughts regarding rte_flow > support". I think this is not what users might expect from such a > documentation which must be exhaustive and consist

Re: [dpdk-dev] [PATCH v1] doc: update mlx4 flow limitations

2018-02-09 Thread Adrien Mazarguil
Hi Ophir, On Thu, Feb 08, 2018 at 06:55:54AM +, Ophir Munk wrote: > From: Moti Haimovsky Relatively minor, patch author differs from the only sign off below, I don't think it's on purpose. > This patch updates mlx4 documentation with flow > configuration limitations imposed by NIC hardware

Re: [dpdk-dev] [PATCH] Add myself as driver information maintainer

2018-02-09 Thread Thomas Monjalon
09/02/2018 16:23, Neil Horman: > I wrote pmdinfogen initially, and since there isn't a maintainer for it, > I'll volunteer to take care of it > > Signed-off-by: Neil Horman Acked-by: Thomas Monjalon Applied, thanks Neil

[dpdk-dev] [PATCH] Add myself as driver information maintainer

2018-02-09 Thread Neil Horman
I wrote pmdinfogen initially, and since there isn't a maintainer for it, I'll volunteer to take care of it Signed-off-by: Neil Horman CC: Thomas Monjalon --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index d9d2abff8..d1ef43479 100644 --- a/MAINTAI

[dpdk-dev] [PATCH v5] checkpatches.sh: Add checks for ABI symbol addition

2018-02-09 Thread Neil Horman
Recently, some additional patches were added to allow for programmatic marking of C symbols as experimental. The addition of these markers is dependent on the manual addition of exported symbols to the EXPERIMENTAL section of the corresponding libraries version map file. The consensus on review i

Re: [dpdk-dev] [PATCH] examples: update copyrights and license

2018-02-09 Thread Hemant Agrawal
Hi Lee, On 1/23/2018 10:16 PM, Lee Daly wrote: This updates the Intel, Cavium and Hasan Alayli license on files in examples to be the standard BSD-3-Clause license used for the rest of DPDK, bringing the files in compliance with the DPDK licensing policy. Please change the patch commit msg to

Re: [dpdk-dev] [PATCH] doc: fix ethdev API port_id parameter size

2018-02-09 Thread Hemant Agrawal
> > > > Fix rte_eth_dev_get_sec_ctx() parameter port_id storage size, form > > uint8_t to uint16_t > > > > Signed-off-by: Ferruh Yigit > > --- > Acked-by: Radu Nicolau Acked-by: Hemant Agrawal

Re: [dpdk-dev] [PATCH] doc: add ABI change notice for numa_node_count in eal

2018-02-09 Thread Bruce Richardson
On Wed, Feb 07, 2018 at 03:40:20PM +0530, Jerin Jacob wrote: > -Original Message- > > Date: Tue, 23 Jan 2018 10:39:58 + > > From: "Mcnamara, John" > > To: "Burakov, Anatoly" , "dev@dpdk.org" > > > > CC: Neil Horman , "Kovacevic, Marko" > > > > Subject: Re: [dpdk-dev] [PATCH] doc: a

[dpdk-dev] [PATCH 2/2] vhost: don't take access_lock on VHOST_USER_RESET_OWNER

2018-02-09 Thread Maxime Coquelin
A deadlock happens when handling VHOST_USER_RESET_OWNER request for the same reason the lock is not taken for VHOST_USER_GET_VRING_BASE. It is safe not to take the lock, as the queues are no more used by the application when the virtqueues and the device are reset. Fixes: a3688046995f ("vhost: pr

[dpdk-dev] [PATCH 1/2] virtio: fix resuming traffic with rx vector path

2018-02-09 Thread Maxime Coquelin
This patch fixes traffic resuming issue seen when using Rx vector path. Fixes: efc83a1e7fc3 ("net/virtio: fix queue setup consistency") Signed-off-by: Tiwei Bie Signed-off-by: Maxime Coquelin --- drivers/net/virtio/virtio_rxtx.c| 34 ++--- drivers/net/virtio

[dpdk-dev] [PATCH 0/2] Vhost & Virtio fixes for -rc4

2018-02-09 Thread Maxime Coquelin
This two patches series fixes two regressions met with virtio-user. The first one is only reproduced when using the Vector path, the second one may be met whatever the rx function. Maxime Coquelin (2): virtio: fix resuming traffic with rx vector path vhost: don't take access_lock on VHOST_USER

Re: [dpdk-dev] [PATCH v2] doc: update ethdev APIs to return named opaque type

2018-02-09 Thread Ananyev, Konstantin
> -Original Message- > From: Yigit, Ferruh > Sent: Friday, February 9, 2018 10:18 AM > To: Neil Horman ; Mcnamara, John > ; Kovacevic, Marko > > Cc: dev@dpdk.org; Yigit, Ferruh ; Ananyev, Konstantin > ; Stephen Hemminger > ; Richardson, Bruce ; > Thomas Monjalon > Subject: [PATCH v2]

Re: [dpdk-dev] [PATCH] doc: fix ethdev API port_id parameter size

2018-02-09 Thread Nicolau, Radu
> -Original Message- > From: Yigit, Ferruh > Sent: Friday, February 9, 2018 9:54 AM > To: Neil Horman ; Mcnamara, John > ; Kovacevic, Marko > > Cc: dev@dpdk.org; Yigit, Ferruh ; Thomas Monjalon > ; Boris Pismenny ; Aviad > Yehezkel ; Nicolau, Radu > ; Doherty, Declan ; > Hemant Agrawal

[dpdk-dev] [PATCH] examples/ipsec-secgw: print correct crypto name

2018-02-09 Thread Radu Nicolau
When AES-256 was used aes-128 was printed in the console Fixes: fa9088849e12 ("examples/ipsec-secgw: support AES 256") Signed-off-by: Radu Nicolau --- examples/ipsec-secgw/sa.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/examples/ipsec-secgw/sa.c b/examples/ipsec-secgw/

[dpdk-dev] [PATCH] Improve the shaper accuracy for large packets

2018-02-09 Thread alanrobertsonatt
From: Alan Robertson There were 2 issues, the first was time could be lost whilst updating the traffic-class period, the second was a frame could be delayed if not enough tokens were available for the full frame. By allowing the shaper to borrow credit from the next period the throughput is impr

[dpdk-dev] [PATCH] Improve the shaper accuracy for large packets

2018-02-09 Thread alanrobertsonatt
From: Alan Robertson There were 2 issues, the first was time could be lost whilst updating the traffic-class period, the second was a frame could be delayed if not enough tokens were available for the full frame. By allowing the shaper to borrow credit from the next period the throughput is impr

[dpdk-dev] [PATCH v2] doc: update ethdev APIs to return named opaque type

2018-02-09 Thread Ferruh Yigit
Ethdev APIs to add callback return the callback object as "void *", update return type to actual object type "struct rte_eth_rxtx_callback *" Signed-off-by: Ferruh Yigit --- Cc: Konstantin Ananyev Cc: Stephen Hemminger Cc: Bruce Richardson Cc: Thomas Monjalon --- doc/guides/rel_notes/depreca

[dpdk-dev] [PATCH] doc: update ethdev APIs to return named opaque type

2018-02-09 Thread Ferruh Yigit
Ethdev APIs to add callback return the callback object as "void *", update return type to actual object type "struct rte_eth_rxtx_callback *" Signed-off-by: Ferruh Yigit --- Cc: Konstantin Ananyev Cc: Stephen Hemminger Cc: Bruce Richardson Cc: Thomas Monjalon --- doc/guides/rel_notes/depreca

Re: [dpdk-dev] [PATCH] doc: add VxLAN GRO to release notes

2018-02-09 Thread Thomas Monjalon
09/02/2018 10:56, Mcnamara, John: > The text has been added between the previous section and a note belonging > to the previous section. > > However, we can fix this in the final revision of the release notes, so: I can fix it. I also take care of keeping a logical order in release notes features

Re: [dpdk-dev] [PATCH v2] doc: add vhost-user live migration features to release notes

2018-02-09 Thread Mcnamara, John
> -Original Message- > From: Hu, Jiayu > Sent: Friday, February 9, 2018 7:47 AM > To: dev@dpdk.org > Cc: Mcnamara, John ; tho...@monjalon.net; Wang, > Zhihong ; Hu, Jiayu > Subject: [PATCH v2] doc: add vhost-user live migration features to release > notes > > Signed-off-by: Jiayu Hu >

Re: [dpdk-dev] [PATCH] doc: add vhost-user live migration features to release notes

2018-02-09 Thread Mcnamara, John
> -Original Message- > From: Hu, Jiayu > Sent: Friday, February 9, 2018 7:13 AM > To: dev@dpdk.org > Cc: Mcnamara, John ; tho...@monjalon.net; Hu, > Jiayu > Subject: [PATCH] doc: add vhost-user live migration features to release > notes > > Signed-off-by: Jiayu Hu > --- > doc/guides/r

Re: [dpdk-dev] [PATCH] doc: add VxLAN GRO to release notes

2018-02-09 Thread Mcnamara, John
> -Original Message- > From: Hu, Jiayu > Sent: Friday, February 9, 2018 5:29 AM > To: dev@dpdk.org > Cc: Mcnamara, John ; tho...@monjalon.net; Hu, > Jiayu > Subject: [PATCH] doc: add VxLAN GRO to release notes > > Signed-off-by: Jiayu Hu > --- > doc/guides/rel_notes/release_18_02.rst

Re: [dpdk-dev] [PATCH] doc: add virtio GUEST ANNOUNCE to release notes

2018-02-09 Thread Mcnamara, John
> -Original Message- > From: Wang, Xiao W > Sent: Friday, February 9, 2018 2:28 PM > To: dev@dpdk.org > Cc: Mcnamara, John ; tho...@monjalon.net; Wang, > Xiao W > Subject: [PATCH] doc: add virtio GUEST ANNOUNCE to release notes > > Signed-off-by: Xiao Wang > --- > doc/guides/rel_notes

[dpdk-dev] [PATCH] doc: fix ethdev API port_id parameter size

2018-02-09 Thread Ferruh Yigit
Fix rte_eth_dev_get_sec_ctx() parameter port_id storage size, form uint8_t to uint16_t Signed-off-by: Ferruh Yigit --- Cc: Boris Pismenny Cc: Aviad Yehezkel Cc: Radu Nicolau Cc: Declan Doherty Cc: Hemant Agrawal --- doc/guides/rel_notes/deprecation.rst | 4 1 file changed, 4 insertions

Re: [dpdk-dev] [PATCH v2 06/10] net/virtio: fix queue setup consistency

2018-02-09 Thread Maxime Coquelin
On 02/09/2018 09:59 AM, Maxime Coquelin wrote: Hi Zhihong, On 02/09/2018 06:44 AM, Wang, Zhihong wrote: Hi Olivier, Given the situation that the vec path can be selected silently now once condition is met. So theoretically speaking this issue impacts the whole virtio pmd. If you plan to fix

Re: [dpdk-dev] [PATCH v3] doc: update the usage for shared library

2018-02-09 Thread Mcnamara, John
> -Original Message- > From: Varghese, Vipin > Sent: Thursday, February 8, 2018 6:20 PM > To: dev@dpdk.org; Mcnamara, John > Cc: Kovacevic, Marko ; Varghese, Vipin > > Subject: [PATCH v3] doc: update the usage for shared library > > Add note information to intimate about use of option

Re: [dpdk-dev] [PATCH v2 06/10] net/virtio: fix queue setup consistency

2018-02-09 Thread Maxime Coquelin
Hi Zhihong, On 02/09/2018 06:44 AM, Wang, Zhihong wrote: Hi Olivier, Given the situation that the vec path can be selected silently now once condition is met. So theoretically speaking this issue impacts the whole virtio pmd. If you plan to fix it in the next release, do you want to do a tempor