Re: [dpdk-dev] [PATCH] maintainers: update vhost lib and pmd

Hi Jianfeng, On 02/11/2018 02:04 AM, Jianfeng Tan wrote: Signed-off-by: Jianfeng Tan --- MAINTAINERS | 2 ++ 1 file changed, 2 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 4f1f33b..38e5fb8 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -559,6 +559,7 @@ F: doc/guides/nics/featur

Re: [dpdk-dev] [PATCH] igb_uio: fix uevent montior issue

On 2/9/2018 6:01 AM, Thomas Monjalon wrote: 30/01/2018 11:01, Jeff Guo: udev could not detect remove and add event of device when hotplug in and out devices, that related with the fix about using pointer of rte_uio_pci_dev as dev_id instead of uio_device for irq device handler, that would resu

Re: [dpdk-dev] [PATCH v1] net/mlx: control netdevices through ioctl only

Hi Shahaf, On Sun, Feb 11, 2018 at 11:55:44AM +, Shahaf Shuler wrote: > Hi Adrien, > > Small doc issues. > > -/** > > * Perform ifreq ioctl() on associated Ethernet device. > > * > > * @param[in] priv > > @@ -361,12 +200,12 @@ mlx4_get_mac(struct priv *priv, uint8_t > > (*mac)[ETHER_AD

[dpdk-dev] [PATCH] MAINTAINERS: resign from vhost/virtio maintainer

I was doing terrible reviews jobs recently, and to not hold back the vhost/virtio development, it's better for me to resign. Then here it is. Signed-off-by: Yuanhan Liu --- MAINTAINERS | 3 --- 1 file changed, 3 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 4f1f33b..f12d83d 100644

Re: [dpdk-dev] [PATCH v2] ethdev: make ethdev data cache aligned

Hi Jerin From: Jerin Jacob [mailto:jerin.ja...@caviumnetworks.com] > Since struct rte_eth_dev_data used in the fast path, making it as cache > aligned. > > Fixes: af75078fece3 ("first public release") > Fixes: 5b7ba31148a8 ("ethdev: add port ownership") Looks like it is just improvement. No nee

Re: [dpdk-dev] [PATCH v2] ethdev: make ethdev data cache aligned

-Original Message- > Date: Mon, 12 Feb 2018 09:04:07 + > From: Matan Azrad > To: Jerin Jacob , "dev@dpdk.org" > > CC: "ferruh.yi...@intel.com" , Thomas Monjalon > , Konstantin Ananyev , > Pavan Nikhilesh > Subject: RE: [dpdk-dev] [PATCH v2] ethdev: make ethdev data cache aligned >

Re: [dpdk-dev] [PATCH 2/2] vhost: don't take access_lock on VHOST_USER_RESET_OWNER

On Fri, Feb 09, 2018 at 03:26:54PM +0100, Maxime Coquelin wrote: > A deadlock happens when handling VHOST_USER_RESET_OWNER request > for the same reason the lock is not taken for > VHOST_USER_GET_VRING_BASE. > > It is safe not to take the lock, as the queues are no more used > by the application w

Re: [dpdk-dev] [PATCH] MAINTAINERS: resign from vhost/virtio maintainer

On Mon, Feb 12, 2018 at 04:51:58PM +0800, Yuanhan Liu wrote: > I was doing terrible reviews jobs recently, and to not hold back > the vhost/virtio development, it's better for me to resign. > > Then here it is. One thing I forgot to mention is, not surprisingly, I will also resign from the commit

Re: [dpdk-dev] [PATCH] igb_uio: fix uevent montior issue

12/02/2018 09:28, Guo, Jia: > > On 2/9/2018 6:01 AM, Thomas Monjalon wrote: > > 30/01/2018 11:01, Jeff Guo: > >> udev could not detect remove and add event of device when hotplug in > >> and out devices, that related with the fix about using pointer of > >> rte_uio_pci_dev as dev_id instead of uio

Re: [dpdk-dev] [PATCH v2] ethdev: make ethdev data cache aligned

Hi Jerin From: Jerin Jacob, Sent: Monday, February 12, 2018 11:26 AM > -Original Message- > > Date: Mon, 12 Feb 2018 09:04:07 + > > From: Matan Azrad > > To: Jerin Jacob , "dev@dpdk.org" > > > > CC: "ferruh.yi...@intel.com" , Thomas Monjalon > > , Konstantin Ananyev > > , Pavan Nik

Re: [dpdk-dev] [PATCH] MAINTAINERS: resign from vhost/virtio maintainer

Hi Yuanhan, On 02/12/2018 10:44 AM, Yuanhan Liu wrote: On Mon, Feb 12, 2018 at 04:51:58PM +0800, Yuanhan Liu wrote: I was doing terrible reviews jobs recently, and to not hold back the vhost/virtio development, it's better for me to resign. I would not put this in the commit message, because

[dpdk-dev] [PATCH] net/nfp: rename nfp PF file

Other NICs with VF support do not use the _pf suffix for these files but just for the VF description. This change makes NFP files consistent in this regard and helps with how the DPDK web nics features matrix shows NFP devices. Signed-off-by: Alejandro Lucero --- doc/guides/nics/features/nfp.in

Re: [dpdk-dev] [PATCH] usertools/dpdk-devbind.py: add support for wind river avp device

On 11-Feb-18 9:52 AM, Xiaohua Zhang wrote: Signed-off-by: Xiaohua Zhang --- usertools/dpdk-devbind.py | 8 1 file changed, 8 insertions(+) diff --git a/usertools/dpdk-devbind.py b/usertools/dpdk-devbind.py index 18d9386..f488318 100755 --- a/usertools/dpdk-devbind.py +++ b/usertools

Re: [dpdk-dev] IXGBE, IOMMU DMAR DRHD handling fault issue

On 10-Feb-18 5:53 PM, Ravi Kerur wrote: On Sat, Feb 10, 2018 at 2:58 AM, Burakov, Anatoly mailto:anatoly.bura...@intel.com>> wrote: On 29-Jan-18 10:35 PM, Ravi Kerur wrote: Hi Burakov, When using vfio-pci on host both VF and PF interfaces works fine with dpdk i.

Re: [dpdk-dev] [PATCH v4] examples/ip_pipeline: update copyright and license

On Wed, Feb 07, 2018 at 04:43:59PM +, Lee Daly wrote: > This updates the Intel and Oliver Matz licenses on a file in examples > to be the standard BSD-3-Clause license used for the rest of DPDK, > bringing the files in compliance with the DPDK licensing policy. > > --- > > V2: Combined Intel

Re: [dpdk-dev] [PATCH] examples/cmdline: update copyright and license

On Wed, Feb 07, 2018 at 04:15:01PM +, Ferruh Yigit wrote: > On 1/23/2018 4:43 PM, Lee Daly wrote: > > This updates the license on files in examples to be the standard > > BSD-3-Clause license used for the rest of DPDK, > > bringing the files in compliance with the DPDK licensing policy. > > >

Re: [dpdk-dev] [PATCH v2] ethdev: make ethdev data cache aligned

-Original Message- > Date: Mon, 12 Feb 2018 09:49:55 + > From: Matan Azrad > To: Jerin Jacob > CC: "dev@dpdk.org" , "ferruh.yi...@intel.com" > , Thomas Monjalon , > Konstantin Ananyev , Pavan Nikhilesh > > Subject: RE: [dpdk-dev] [PATCH v2] ethdev: make ethdev data cache aligned >

Re: [dpdk-dev] [PATCH] doc: announce control mbuf removal

Hi, Please, any other comments or acks for this one? Thanks Olivier On Mon, Jan 29, 2018 at 10:30:27AM +0100, Olivier Matz wrote: > Link: http://dpdk.org/ml/archives/dev/2017-July/069813.html > Link: http://dpdk.org/dev/patchwork/patch/32041/ > > Signed-off-by: Olivier Matz > --- > doc/guide

[dpdk-dev] [PATCH] doc: update doc for intel VF usage

update for intel VF usage: - Add note for AVF device ID generation. - Add steps for vfio-pci pass through. Signed-off-by: Jingjing Wu --- doc/guides/nics/intel_vf.rst | 21 - 1 file changed, 20 insertions(+), 1 deletion(-) diff --git a/doc/guides/nics/intel_vf.rst b/doc/gu

Re: [dpdk-dev] [PATCH] doc: announce control mbuf removal

> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Olivier Matz > Sent: Monday, February 12, 2018 10:22 AM > To: dev@dpdk.org; Neil Horman ; Mcnamara, > John ; Kovacevic, Marko > > Cc: Kevin Wilson ; Ananyev, Konstantin > > Subject: Re: [dpdk-dev] [PATCH] doc: a

[dpdk-dev] [PATCH v2] doc: update doc for intel VF usage

update for intel VF usage: - Add note for AVF device ID generation. - Add steps for vfio-pci pass through. Signed-off-by: Jingjing Wu --- v2 change: fix typo doc/guides/nics/intel_vf.rst | 21 - 1 file changed, 20 insertions(+), 1 deletion(-) diff --git a/doc/guides/nics

Re: [dpdk-dev] [PATCH] net/mlx4: use PCI address as port name

Hi Yuanhan, On Sun, Feb 11, 2018 at 04:29:32PM +0800, Yuanhan Liu wrote: > It is suggested to use PCI BDF to identify a port for port addition > in OVS-DPDK. While mlx5 has its own naming style: name it by ib dev > name. This breaks the typical OVS DPDK use case and brings more puzzle > to the end

Re: [dpdk-dev] [PATCH] doc: announce control mbuf removal

On Mon, Feb 12, 2018 at 11:22:15AM +0100, Olivier Matz wrote: > Hi, > > Please, any other comments or acks for this one? > > Thanks > Olivier I would tend to support leaving the flag in place. Other than that, I think the functions for it can go. > > > On Mon, Jan 29, 2018 at 10:30:27AM +0100,

Re: [dpdk-dev] [PATCH v1] doc: update mlx4 flow limitations

On Fri, Feb 09, 2018 at 05:39:50PM +0100, Thomas Monjalon wrote: > 09/02/2018 17:21, Adrien Mazarguil: > > This section is titled "Limitations" but contains a mix of features, > > limitations and quirks, more like "Random thoughts regarding rte_flow > > support". I think this is not what users migh

Re: [dpdk-dev] [PATCH] MAINTAINERS: resign from vhost/virtio maintainer

On Mon, Feb 12, 2018 at 10:54:08AM +0100, Maxime Coquelin wrote: > Hi Yuanhan, > > On 02/12/2018 10:44 AM, Yuanhan Liu wrote: > >On Mon, Feb 12, 2018 at 04:51:58PM +0800, Yuanhan Liu wrote: > >>I was doing terrible reviews jobs recently, and to not hold back > >>the vhost/virtio development, it's

Re: [dpdk-dev] [PATCH v2] ethdev: make ethdev data cache aligned

Hi Jerin From: Jerin Jacob, Sent: Monday, February 12, 2018 12:21 PM > -Original Message- > > Date: Mon, 12 Feb 2018 09:49:55 + > > From: Matan Azrad > > To: Jerin Jacob > > CC: "dev@dpdk.org" , "ferruh.yi...@intel.com" > > , Thomas Monjalon , > > Konstantin Ananyev , Pavan Nikhiles

Re: [dpdk-dev] [PATCH v1] doc: update mlx4 flow limitations

On Mon, Feb 12, 2018 at 07:41:03AM +, Shahaf Shuler wrote: > Hi Marcelo, > > Sunday, February 11, 2018 9:31 PM, Marcelo Ricardo: > > On Thu, Feb 08, 2018 at 06:55:54AM +, Ophir Munk wrote: > > > From: Moti Haimovsky > > > > > > This patch updates mlx4 documentation with flow configuration

[dpdk-dev] [PATCH v3] ethdev: fix ethdev data alignment

The struct rte_eth_dev_data is used in ethdev fastpath routines and it not aligned to cache line size. This patch fixes the ethdev data alignment. The alignment was broken from the "first public release" changeset where ethdev data address was aligned only to the first port. Remaining ports alignm

Re: [dpdk-dev] [PATCH 07/14] net/virtio: implement transmit path for packed queues

On 2018年01月29日 22:11, Jens Freimann wrote: +/* Cleanup from completed transmits. */ +static void +virtio_xmit_cleanup(struct virtqueue *vq) +{ + uint16_t idx; + uint16_t size = vq->vq_nentries; + struct vring_desc_1_1 *desc = vq->vq_ring.desc_1_1; + + idx = vq->vq_used_c

[dpdk-dev] [PATCH] net/virtio: fix mbuf data offset for simple Rx function

The mbuf->data_off was was not properly set for the first received mbufs. Fix this by setting it in virtqueue_enqueue_recv_refill_simple(), which is used to enqueue the first mbuf in the ring. The function virtio_rxq_rearm_vec(), which is used to rearm the ring with new mbufs, is valid and does no

Re: [dpdk-dev] [PATCH 1/2] virtio: fix resuming traffic with rx vector path

On Fri, Feb 09, 2018 at 03:26:53PM +0100, Maxime Coquelin wrote: > This patch fixes traffic resuming issue seen when using > Rx vector path. > > Fixes: efc83a1e7fc3 ("net/virtio: fix queue setup consistency") > > Signed-off-by: Tiwei Bie > Signed-off-by: Maxime Coquelin Proposed change for a m

Re: [dpdk-dev] [PATCH] MAINTAINERS: resign from vhost/virtio maintainer

On 2/12/2018 5:54 PM, Maxime Coquelin wrote: Hi Yuanhan, On 02/12/2018 10:44 AM, Yuanhan Liu wrote: On Mon, Feb 12, 2018 at 04:51:58PM +0800, Yuanhan Liu wrote: I was doing terrible reviews jobs recently, and to not hold back the vhost/virtio development, it's better for me to resign. I wo

Re: [dpdk-dev] [PATCH v1] doc: update mlx4 flow limitations

Monday, February 12, 2018 2:46 PM, Marcelo Ricardo Leitner: > On Mon, Feb 12, 2018 at 07:41:03AM +, Shahaf Shuler wrote: > The need to have eth dst specified. This is not correct. the device can support such rules. Are you running on VF? Can you paste the rule you try to create and the error

Re: [dpdk-dev] [PATCH v3] ethdev: fix ethdev data alignment

Hi Jerin From: Jerin Jacob [mailto:jerin.ja...@caviumnetworks.com] > The struct rte_eth_dev_data is used in ethdev fastpath routines and it not > aligned to cache line size. This patch fixes the ethdev data alignment. > > The alignment was broken from the "first public release" changeset where >

Re: [dpdk-dev] [PATCH v3] ethdev: fix ethdev data alignment

-Original Message- > Date: Mon, 12 Feb 2018 13:44:54 + > From: Matan Azrad > To: Jerin Jacob , "dev@dpdk.org" > > CC: "ferruh.yi...@intel.com" , "sta...@dpdk.org" > , Thomas Monjalon , Konstantin > Ananyev , Pavan Nikhilesh > > Subject: RE: [dpdk-dev] [PATCH v3] ethdev: fix ethde

Re: [dpdk-dev] [PATCH 1/4] ether: support deferred queue setup

As a general comment, please review wording and explanations of this patchset. 12/02/2018 05:53, Qi Zhang: > +/** < Deferred queue setup / release capability */ > +#define DEV_DEFERRED_RX_QUEUE_SETUP 0x0001 > +#define DEV_DEFERRED_TX_QUEUE_SETUP 0x0002 > +#define DEV_DEFERRED_RX_QUEUE_RELE

Re: [dpdk-dev] [PATCH v1] doc: update mlx4 flow limitations

12/02/2018 12:23, Adrien Mazarguil: > On Fri, Feb 09, 2018 at 05:39:50PM +0100, Thomas Monjalon wrote: > > I think it's better to have some random thoughts than nothing. > > All the comments you gave in this thread deserve to be written in > > the documentation as soon as possible. > > Right, but

Re: [dpdk-dev] [PATCH v3] ethdev: fix ethdev data alignment

From: Jerin Jacob, Sent: Monday, February 12, 2018 3:51 PM > -Original Message- > > Date: Mon, 12 Feb 2018 13:44:54 + > > From: Matan Azrad > > To: Jerin Jacob , "dev@dpdk.org" > > > > CC: "ferruh.yi...@intel.com" , "sta...@dpdk.org" > > , Thomas Monjalon , > Konstantin > > Ananye

Re: [dpdk-dev] [PATCH v3] ethdev: fix ethdev data alignment

-Original Message- > Date: Mon, 12 Feb 2018 14:02:17 + > From: Matan Azrad > To: Jerin Jacob > CC: "dev@dpdk.org" , "ferruh.yi...@intel.com" > , "sta...@dpdk.org" , Thomas > Monjalon , Konstantin Ananyev > , Pavan Nikhilesh > > Subject: RE: [dpdk-dev] [PATCH v3] ethdev: fix ethde

Re: [dpdk-dev] [PATCH v1] doc: update mlx4 flow limitations

On Mon, Feb 12, 2018 at 02:58:31PM +0100, Thomas Monjalon wrote: > 12/02/2018 12:23, Adrien Mazarguil: > > On Fri, Feb 09, 2018 at 05:39:50PM +0100, Thomas Monjalon wrote: > > > I think it's better to have some random thoughts than nothing. > > > All the comments you gave in this thread deserve to

[dpdk-dev] [dpdk-stable] [PATCH] build: remove unused map symbols

Remove some unused map symbol. Signed-off-by: Pavan Nikhilesh --- drivers/bus/fslmc/rte_bus_fslmc_version.map | 2 -- drivers/mempool/dpaa/rte_mempool_dpaa_version.map | 1 - lib/librte_eal/rte_eal_version.map| 1 - lib/librte_ether/rte_ethdev_version.map | 1 - l

[dpdk-dev] [PATCH v1] net/tap: fix CRC stripping capability report

CRC stripping is executed outside of TAP PMD scope. There is no prevention that TAP reports on Rx CRC stripping capability. It is especially required when TAP is operating as failsafe sub-device with another PCI sub-device which supports CRC stripping. In the corrupted code TAP did not report on th

[dpdk-dev] [PATCH v1] net/tap: allow user MAC to be passed as args

Allow TAP PMD to pass user desired MAC address as argument. The argument value is processed as string delimited by ':', is parsed and converted to HEX MAC address after validation. Signed-off-by: Vipin Varghese Signed-off-by: Pascal Mazon --- Changes: - seggrated the function for hex sting va

Re: [dpdk-dev] [PATCH v2] doc: update doc for intel VF usage

> -Original Message- > From: Wu, Jingjing > Sent: Monday, February 12, 2018 10:26 AM > To: Mcnamara, John > Cc: Lu, Wenzhuo ; Wu, Jingjing > ; dev@dpdk.org > Subject: [PATCH v2] doc: update doc for intel VF usage > > update for intel VF usage: > - Add note for AVF device ID generation.

Re: [dpdk-dev] [PATCH] doc: add missing SFN8xxx adapters to the list of supported

> -Original Message- > From: Andrew Rybchenko [mailto:arybche...@solarflare.com] > Sent: Friday, February 9, 2018 5:58 PM > To: dev@dpdk.org > Cc: Mcnamara, John > Subject: [PATCH] doc: add missing SFN8xxx adapters to the list of > supported > > Signed-off-by: Andrew Rybchenko Acked-b

Re: [dpdk-dev] [PATCH] net/virtio: fix mbuf data offset for simple Rx function

Hi Olivier, On 02/12/2018 02:16 PM, Olivier Matz wrote: The mbuf->data_off was was not properly set for the first received mbufs. Fix this by setting it in virtqueue_enqueue_recv_refill_simple(), which is used to enqueue the first mbuf in the ring. The function virtio_rxq_rearm_vec(), which is

Re: [dpdk-dev] [PATCH 2/3] net/vdpa_virtio_pci: introduce vdpa sample driver

Hi Maxime, > -Original Message- > From: Maxime Coquelin [mailto:maxime.coque...@redhat.com] > Sent: Thursday, February 8, 2018 5:09 PM > To: Wang, Xiao W ; dev@dpdk.org > Cc: Tan, Jianfeng ; Bie, Tiwei ; > y...@fridaylinux.org; Liang, Cunming ; Daly, Dan > ; Wang, Zhihong > Subject: Re: [

[dpdk-dev] [PATCH v2 1/3] net/virtio: fix mbuf data offset for simple Rx function

From: Olivier Matz The mbuf->data_off was was not properly set for the first received mbufs. Fix this by setting it in virtqueue_enqueue_recv_refill_simple(), which is used to enqueue the first mbuf in the ring. The function virtio_rxq_rearm_vec(), which is used to rearm the ring with new mbufs,

[dpdk-dev] [PATCH v2 0/3] Vhost & Virtio fixes for v18.02

The second revision of this series includes Olivier's patch as first patch in order to ease Thomas job when applying. Patch 2 rewords the commit message with detailed informations provided by Tiwei and olivier (Thanks!). It also moves call to virtio_rxq_vec_setup() and removes virtqueue_enqueue_re

[dpdk-dev] [PATCH v2 2/3] virtio: fix resuming port with rx vector path

Since commit efc83a1e7fc3 ("net/virtio: fix queue setup consistency"), when resuming a virtio port, the rx rings are refilled with new mbufs until they are full (vq->vq_free_cnt == 0). This is done without ensuring that the descriptor index remains a multiple of RTE_VIRTIO_VPMD_RX_REARM_THRESH, whi

[dpdk-dev] [PATCH v2 3/3] vhost: don't take access_lock on VHOST_USER_RESET_OWNER

A deadlock happens when handling VHOST_USER_RESET_OWNER request for the same reason the lock is not taken for VHOST_USER_GET_VRING_BASE. It is safe not to take the lock, as the queues are no more used by the application when the virtqueues and the device are reset. Fixes: a3688046995f ("vhost: pr

Re: [dpdk-dev] [PATCH v2] doc: add deprecation notice for memory hotplug changes

On Thu, 18 Jan 2018 10:32:28 + Anatoly Burakov wrote: Due to coming changes outlined in memory hotplug RFC, there will be several API/ABI changes. Signed-off-by: Anatoly Burakov --- Notes: Patch outlining future changes: http://dpdk.org/dev/patchwork/patch/32467/ v2: added r

Re: [dpdk-dev] [PATCH] doc: add ABI change notice for numa_node_count in eal

On Tue, 16 Jan 2018 17:53:40 + Anatoly Burakov wrote: There will be a new function added in v18.05 that will return number of detected sockets, which will change the ABI. Signed-off-by: Anatoly Burakov --- doc/guides/rel_notes/deprecation.rst | 2 ++ 1 file changed, 2 insertions(+) diff -

[dpdk-dev] [PATCH] devtools: add script to verify map files

This script checks for the symbols specified in the map files against the symbols present in the map file directory. Currently, the script checks for map files in drivers and lib directory. Example: ./devtools/check-map.py The following symbols are unused : Map file : /home/pavan/Work/clean/dpdk

Re: [dpdk-dev] [PATCH v1] doc: update mlx4 flow limitations

12/02/2018 15:19, Adrien Mazarguil: > On Mon, Feb 12, 2018 at 02:58:31PM +0100, Thomas Monjalon wrote: > > 12/02/2018 12:23, Adrien Mazarguil: > > > On Fri, Feb 09, 2018 at 05:39:50PM +0100, Thomas Monjalon wrote: > > > > I think it's better to have some random thoughts than nothing. > > > > All th

Re: [dpdk-dev] [dpdk-stable] [PATCH] build: remove unused map symbols

On Mon, Feb 12, 2018 at 07:53:05PM +0530, Pavan Nikhilesh wrote: > Remove some unused map symbol. > > Signed-off-by: Pavan Nikhilesh > --- > drivers/bus/fslmc/rte_bus_fslmc_version.map | 2 -- > drivers/mempool/dpaa/rte_mempool_dpaa_version.map | 1 - > lib/librte_eal/rte_eal_version.map

[dpdk-dev] [PATCH] doc: improve HTML spacing in release notes

Vertical spacing is lower before an item title than after. So the items with paragraphs are not well separated. A custom CSS is added to override the rtd theme. Signed-off-by: Thomas Monjalon --- doc/guides/conf.py| 2 ++ doc/guides/custom.css | 7 +++ mk/rte.sdkdoc.mk | 8 +++-

Re: [dpdk-dev] [dpdk-stable] [PATCH v1] net/tap: fix CRC stripping capability report

The title should be "add CRC stripping capability". 12/02/2018 15:43, Ophir Munk: > CRC stripping is executed outside of TAP PMD scope. There is no > prevention that TAP reports on Rx CRC stripping capability. We could mention that the CRC stripping is done in the kernel. > It is especially requ

Re: [dpdk-dev] [dpdk-stable] [PATCH] build: remove unused map symbols

On Mon, Feb 12, 2018 at 12:41:54PM -0500, Neil Horman wrote: > On Mon, Feb 12, 2018 at 07:53:05PM +0530, Pavan Nikhilesh wrote: > > Remove some unused map symbol. > > > > Signed-off-by: Pavan Nikhilesh > > --- > > drivers/bus/fslmc/rte_bus_fslmc_version.map | 2 -- > > drivers/mempool/dpaa/

Re: [dpdk-dev] [PATCH v2] net/bonding: fix link status check

It's not clear to me that link_properties_valid() is even correct. Nothing prevents an adapter from later negotiating a lower speed and would fail this test. If both adapters are set to autoneg, that should be sufficient but nothing enforces the speed match after the slaves are configured. So wh

Re: [dpdk-dev] [PATCH v6 3/3] net/failsafe: fix hotplug races

Hi Matan, On Sun, Feb 11, 2018 at 05:24:32PM +, Matan Azrad wrote: > Fail-safe uses periodic alarm mechanism, running from the host thread, > to manage the hot-plug events of its sub-devices. This management > requires a lot of sub-devices PMDs operations (stop,close,start,etc). > > While the

Re: [dpdk-dev] [PATCH] net/failsafe: fix reconfiguration

Hi Matan, On Sun, Feb 11, 2018 at 05:27:34PM +, Matan Azrad wrote: > Fail-safe PMD manages the states of its sub-devices gradually: > DEV_UNDEFINED, DEV_PARSED, DEV_PROBED, DEV_ACTIVE, DEV_STARTED. > > When the sub-device arguments successfully was parsed, the state is > raised from DEV_UNDEF

Re: [dpdk-dev] [PATCH v6 3/3] net/failsafe: fix hotplug races

Hi Gaetan From: Gaëtan Rivet, Sent: Monday, February 12, 2018 8:33 PM > Hi Matan, > > On Sun, Feb 11, 2018 at 05:24:32PM +, Matan Azrad wrote: > > Fail-safe uses periodic alarm mechanism, running from the host thread, > > to manage the hot-plug events of its sub-devices. This management > > r

[dpdk-dev] [PATCH v7 0/3] failsafe: fix hotplug races

This series fixes failsafe race between control commands to the asynchronic plug-out\in processes. V7(matan): improve commit logs. return back emty line. return back description wrongly removed. V6(matan): Full lock based fix. Change the remove flag scope until SW resources release. v5(Matan):

[dpdk-dev] [PATCH v7 1/3] net/failsafe: fix hotplug alarm cancel

The hot-plug alarm mechanism of fail-safe PMD is responsible for handling removed devices during a plug-out event and to restore them back to activity following a plug-in event. Fail-safe sets a flag called "pending_alarm" to validate that only one alarm callback is pending at any time. While this

[dpdk-dev] [PATCH v7 2/3] net/failsafe: fix removal scope

The fail-safe PMD uses a per sub-device flag called "remove" to indicate the scope where the sub-device was removed physically and whether its software resources should be released. This flag is set when the fail-safe receives an RMV notification about the physical removal of the sub-device, and s

[dpdk-dev] [PATCH v7 3/3] net/failsafe: fix hotplug races

Fail-safe uses a periodic alarm mechanism, running from the host thread, to manage the hot-plug events of its sub-devices. This management requires a lot of sub-devices PMDs operations (stop, close, start, configure, etc.). While the hot-plug alarm runs in the host thread, the application may call

Re: [dpdk-dev] IXGBE, IOMMU DMAR DRHD handling fault issue

On Mon, Feb 12, 2018 at 2:13 AM, Burakov, Anatoly wrote: > On 10-Feb-18 5:53 PM, Ravi Kerur wrote: > > >> >> On Sat, Feb 10, 2018 at 2:58 AM, Burakov, Anatoly < >> anatoly.bura...@intel.com > wrote: >> >> On 29-Jan-18 10:35 PM, Ravi Kerur wrote: >> >>

Re: [dpdk-dev] [dpdk-stable] [PATCH v1] net/tap: fix CRC stripping capability report

Will issue v2 with commit message updated > -Original Message- > From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Monday, February 12, 2018 7:55 PM > To: Ophir Munk > Cc: dev@dpdk.org; Pascal Mazon ; Olga Shern > > Subject: Re: [dpdk-stable] [PATCH v1] net/tap: fix CRC strippin

Re: [dpdk-dev] [PATCH v2] doc: add deprecation notice for memory hotplug changes

> On Jan 18, 2018, at 2:32 AM, Anatoly Burakov > wrote: > > Due to coming changes outlined in memory hotplug RFC, there will > be several API/ABI changes. > > Signed-off-by: Anatoly Burakov > --- Acked-by: Yongseok Koh Thanks

Re: [dpdk-dev] [PATCH 1/2] virtio: fix resuming traffic with rx vector path

Just realize that I forgot to CC dev@dpdk.org. > -Original Message- > From: Tan, Jianfeng [mailto:jianfeng@intel.com] > Sent: Monday, February 12, 2018 8:51 PM > To: Maxime Coquelin > Subject: Re: [dpdk-dev] [PATCH 1/2] virtio: fix resuming traffic with rx > vector > path > > > > O

Re: [dpdk-dev] [PATCH] usertools/dpdk-devbind.py: add support for wind river avp device

Hi Anatoly, AVP is a virtual NIC type, so you are right. When using the AVP device, you will see the following information from lspci (example). Slot: :00:05.0 Class: Unclassified device [00ff] Vendor: Red Hat, Inc [1af4] Device:Virtio memory balloon [1002] SVendor:

Re: [dpdk-dev] [PATCH v3] doc: add a user guidance document for igb

> -Original Message- > From: Mcnamara, John > Sent: Thursday, February 8, 2018 8:27 PM > To: Yigit, Ferruh ; Zhao1, Wei > ; dev@dpdk.org > Subject: RE: [dpdk-dev] [PATCH v3] doc: add a user guidance document for > igb > > > -Original Message- > > From: Yigit, Ferruh > > Sent: Thu

[dpdk-dev] [PATCH] example exception_path: cache align per CPU stats

Align stats structure to cache line to prevent bouncing per CPU stats structure between cache lines. Signed-off-by: Dustin Lundquist --- examples/exception_path/main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/examples/exception_path/main.c b/examples/exception_path/mai

Re: [dpdk-dev] [dpdk-stable] [PATCH] build: remove unused map symbols

HI Pavan, On 2/12/2018 7:53 PM, Pavan Nikhilesh wrote: Remove some unused map symbol. Signed-off-by: Pavan Nikhilesh --- diff --git a/drivers/mempool/dpaa/rte_mempool_dpaa_version.map b/drivers/mempool/dpaa/rte_mempool_dpaa_version.map index cc635c736..d05f274d0 100644 --- a/drivers/mempoo

[dpdk-dev] Multi-driver support for Fortville

Hi, Resending the queries with change in subject line. 1) With these patches, we have 2 different values for some of the global registers depending upon whether single driver or multi-driver is using all ports of the NIC. Does it impact any functionality/performance if we use DPDK drivers in sin

Re: [dpdk-dev] [PATCH] doc: announce control mbuf removal

On 2/12/2018 3:52 PM, Olivier Matz wrote: On Mon, Jan 29, 2018 at 10:30:27AM +0100, Olivier Matz wrote: Link: http://dpdk.org/ml/archives/dev/2017-July/069813.html Link: http://dpdk.org/dev/patchwork/patch/32041/ Signed-off-by: Olivier Matz Acked-by: Hemant Agrawal --- doc/guides/rel_not

Re: [dpdk-dev] [PATCH] doc: add change notice for mbuf sched field

On 2/10/2018 6:18 PM, Jerin Jacob wrote: -Original Message- Date: Fri, 9 Feb 2018 16:45:16 + From: Cristian Dumitrescu To: dev@dpdk.org CC: olivier.m...@6wind.com, tho...@monjalon.net, jasvinder.si...@intel.com, roy.fan.zh...@intel.com, kevin.la...@intel.com Subject: [dpdk-dev] [P

Re: [dpdk-dev] [PATCH v2] doc: update ethdev APIs to return named opaque type

On 2/10/2018 5:32 PM, Jerin Jacob wrote: -Original Message- From: Yigit, Ferruh Sent: Friday, February 9, 2018 10:18 AM To: Neil Horman ; Mcnamara, John ; Kovacevic, Marko Cc: dev@dpdk.org; Yigit, Ferruh ; Ananyev, Konstantin ; Stephen Hemminger ; Richardson, Bruce ; Thomas Monjalon

Re: [dpdk-dev] [dpdk-stable] [PATCH] build: remove unused map symbols

On 2/13/2018 9:16 AM, Hemant Agrawal wrote: HI Pavan, On 2/12/2018 7:53 PM, Pavan Nikhilesh wrote: Remove some unused map symbol. Signed-off-by: Pavan Nikhilesh --- diff --git a/drivers/mempool/dpaa/rte_mempool_dpaa_version.map b/drivers/mempool/dpaa/rte_mempool_dpaa_version.map index cc6

Re: [dpdk-dev] [PATCH v2] doc: announce ABI change for RSS configuration structure

Tuesday, February 6, 2018 9:39 AM, Xueming Li: > Subject: [PATCH v2] doc: announce ABI change for RSS configuration > structure > > Update deprecation notice for the new rss_level field of rte_eth_rss_conf. > > Link: http://www.dpdk.org/dev/patchwork/patch/31891 > > Signed-off-by: Xueming Li >