On 02/09/2018 06:24 PM, Tomasz Kulasek wrote:
LOG_DEBUG is a symbol defined by POSIX, so if sys/log.h is
included the symbols conflict.
This patch changes LOG_DEBUG to VHOST_LOG_DEBUG.
Fixes: 1c01d52392d5 ("vhost: add debug print")
Cc: huawei@intel.com
Cc: sta...@dpdk.org
Signed-off-by:
Hi Jianfeng,
On 02/14/2018 05:01 AM, Jianfeng Tan wrote:
Some trivial fixes, and a vhost memory optimization to avoid polulating
guest memory.
Jianfeng Tan (4):
vhost: remove unused macro
vhost: avoid function call in data path
app/testpmd: add option to avoid lock all memory
vhost:
On 02/19/2018 09:48 PM, Maxime Coquelin wrote:
On 02/14/2018 05:01 AM, Jianfeng Tan wrote:
Previously, get_device() is a function call. It's OK for slow path
configuration, but takes some cycles for data path.
To avoid that, we turn this function to inline type.
Cc: maxime.coque...@redhat.
On 02/19/2018 09:49 PM, Maxime Coquelin wrote:
On 02/14/2018 05:01 AM, Jianfeng Tan wrote:
Cc: tomaszx.kula...@intel.com
Cc: maxime.coque...@redhat.com
Cc: y...@fridaylinux.org
Signed-off-by: Jianfeng Tan
---
lib/librte_vhost/vhost.h | 2 --
1 file changed, 2 deletions(-)
Reviewed-by:
-Original Message-
> Date: Tue, 20 Feb 2018 18:55:09 +
> From: "Vangati, Narender"
> To: Jerin Jacob , "Gujjar, Abhinandan S"
>
> CC: "dev@dpdk.org" , "Rao, Nikhil" ,
> "Eads, Gage" , "hemant.agra...@nxp.com"
> , "akhil.go...@nxp.com" ,
> "narayanaprasad.athr...@cavium.com" ,
> "
For inline protocol processing, the PMD/device is required to maintain
the ESN. But the application is required to monitor ESN overflow to
initiate SA expiry.
For such cases, application would set the ESN soft limit. An IPsec event
would be raised by rte_eth_event framework, when ESN hits the soft
Extending 'userdata' to be used for IPsec events too.
IPsec events would have some metadata which would uniquely identify the
security session for which the event is raised. But application would
need some construct which it can understand. The 'userdata' solves a
similar problem for inline proces
Adding support for IPsec event
Signed-off-by: Anoob Joseph
---
app/test-pmd/parameters.c | 2 ++
app/test-pmd/testpmd.c| 2 ++
2 files changed, 4 insertions(+)
diff --git a/app/test-pmd/parameters.c b/app/test-pmd/parameters.c
index 97d22b8..7ea882f 100644
--- a/app/test-pmd/parameters.c
++
Adding ESN soft limit in conf. This will be used in case of protocol
offload. Per SA, application could specify for what ESN the security
device need to notify application. In case of eth dev(inline protocol),
rte_eth_event framework would raise an IPsec event.
Signed-off-by: Anoob Joseph
---
li
This series enables application to set the sequence number soft limit
for IPsec offload. In inline IPsec offload, as the sequence number
(maintained by PMD/device) reaches the specified soft limit, the PMD
would raise an "IPSEC_EVENT". This event would have some metadata,
which would be used by the
Adding support for IPsec events in rte_eth_event framework. In inline
IPsec offload, the per packet protocol defined variables, like ESN,
would be managed by PMD. In such cases, PMD would need IPsec events
to notify application about various conditions like, ESN overflow.
Signed-off-by: Anoob Jose
---
lib/librte_ip_frag/ip_frag_internal.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/lib/librte_ip_frag/ip_frag_internal.c
b/lib/librte_ip_frag/ip_frag_internal.c
index 7397aa6..2cfa56b 100644
--- a/lib/librte_ip_frag/ip_frag_internal.c
+++ b/lib/librte_ip_frag/ip_fra
After using dynamic logging for a while, I think there was a poor design choice
on using regular expressions to match logging string. The naming policy looks
like a hierarchy and the matching is with regular expressions. For most other
applications where a hierarchy is implied, a globbing rather t
On Tue, 20 Feb 2018 17:07:27 +
Bruce Richardson wrote:
> Following on from the number of patches needing to be done for strncpy
> issues highlighted by coverity...
>
> The strncpy function is error prone for doing "safe" string copies, so
> we generally try to use "snprintf" instead in the c
/// snip ///
>>> D.2.1 Stateful operation state maintenance
>>> ---
>>> It is always an ideal expectation from application that it
>>> should parse
>> through all related chunk o
Jerin,
I see the "ENQ" part of the adapter a little differently. I think there is
value to offloading cryptodev_enqueue to an adapter service, even when the h/w
natively supports DEQ.
When the same queue pair is being used by the workers to enqueue requests (this
could be where the pre crypto s
Hi,
I'm running DPDK on Intel x86 processor which supports SSE2,
in my current deployment I didn't enabled RTE_FORCE_INTRINSIC.
After reading on Intel's intrinsic pause I wonder if I should enable it or
not.
especially how it should impact on latency those noop command going through
the CPU.
Also
On 19-Feb-18 9:03 PM, Thomas Monjalon wrote:
The new release cycle is started!
If you think some patches are already ready for integration in master,
please notify me.
Note that changes impacting a lot of future patches (big changes, renames,
or core features) are preferred to be integrated ear
The change adds TUN PMD logic to the existing TAP PMD. TUN PMD can
be initialized with 'net_tunX' where 'X' represents unique id. PMD
supports argument interface, while MAC address and remote are not
supported.
Signed-off-by: Vipin Varghese
---
doc/guides/nics/tap.rst | 15 -
drivers/
The length of the longest header name is used to adjust the padding
the header row automatically, instead of fixed length.
The previous length (10) was too short for vdev_netvsc.
Fixes: 6086ab3bb3d2 ("net/vdev_netvsc: introduce Hyper-V platform driver")
Cc: sta...@dpdk.org
Signed-off-by: Thomas M
The font size of the header row is reduced in order to shrink
the column size of the tables.
It is required for the NICs features table which is too large to fit
in the page width.
Cc: sta...@dpdk.org
Signed-off-by: Thomas Monjalon
---
doc/guides/conf.py | 2 +-
1 file changed, 1 insertion(+),
This table does not fit in the page:
http://dpdk.org/doc/guides-18.02/nics/overview.html#id1
because there are a lot of drivers,
and the vdev_netvsc is truncated in length.
Both fixes are relevant for 18.02 backport.
Thomas Monjalon (2):
doc: reduce features tables column width
doc: adapt f
Fixes: f18b146c498d ("net/octeontx: create ethdev ports")
Coverity issue: 195045
Cc: sta...@dpdk.org
Signed-off-by: Santosh Shukla
---
drivers/net/octeontx/octeontx_ethdev.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/octeontx/octeontx_ethdev.c
b/drivers/net/
Fixes: f18b146c498d ("net/octeontx: create ethdev ports")
Coverity issue: 195040
Cc: sta...@dpdk.org
Signed-off-by: Santosh Shukla
---
drivers/net/octeontx/octeontx_ethdev.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/octeontx/octeontx_ethdev.c
b/drivers/net/
Following on from the number of patches needing to be done for strncpy
issues highlighted by coverity...
The strncpy function is error prone for doing "safe" string copies, so
we generally try to use "snprintf" instead in the code. The function
"strlcpy" is a better alternative, though, since it b
Fixes a potential memory overrun detected by Coverity.
This overrun cannot currently happen in practice because
rte_metrics_reg_names() explicitly forces the last name
character to be a NULL terminator. This patch adds the
same enforcement to rte_metrics_get_names() in order to
correct the warning,
On 20/02/2018 15:11, Bruce Richardson wrote:
[..]
Again, I think the better fix is to replace strncpy with snprintf which
will guarantee the null termination, unlike strncpy which is nasty that
way.
OK, v2 on way..
On Tue, Feb 20, 2018 at 02:50:01PM +, Remy Horton wrote:
> Fixes a potential memory overrun detected by Coverity.
> This overrun cannot currently happen in practice because
> rte_metrics_reg_names() explicitly forces the last name
> character to be a NULL terminator. This patch adds the
> same
Fixes a potential memory overrun detected by Coverity.
This overrun cannot currently happen in practice because
rte_metrics_reg_names() explicitly forces the last name
character to be a NULL terminator. This patch adds the
same enforcement to rte_metrics_get_names() in order to
correct the warning.
On Tue, Feb 20, 2018 at 01:52:22PM +, Radu Nicolau wrote:
> Replace strncpy with snprintf to avoid overwriting the last
> NULL character.
>
> Fixes: 2deb6b5246d7 ("app/procinfo: add collectd format and host id")
> Coverity issue: 143252
>
> Cc: sta...@dpdk.org
>
> Signed-off-by: Radu Nicolau
-Original Message-
> Date: Mon, 19 Feb 2018 10:55:58 +
> From: "Gujjar, Abhinandan S"
> To: Jerin Jacob
> CC: "dev@dpdk.org" , "Vangati, Narender"
> , "Rao, Nikhil" , "Eads,
> Gage" , "hemant.agra...@nxp.com"
> , "akhil.go...@nxp.com" ,
> "narayanaprasad.athr...@cavium.com" ,
> "
Replace strncpy with snprintf to avoid overwriting the last
NULL character.
Fixes: 2deb6b5246d7 ("app/procinfo: add collectd format and host id")
Coverity issue: 143252
Cc: sta...@dpdk.org
Signed-off-by: Radu Nicolau
---
v3: replaced strncpy with snprintf
app/proc_info/main.c | 2 +-
1 file c
WRED thresholds can be specified in bytes if the TM leaf
node supports it. Also extend WRED thresholds to 32 bits from 16.
TM capability (port/level/queue) fields cman_wred_packet_mode_supported and
cman_wred_byte_mode_supported, when non-zero, indicate support for WRED
thresholds in packets and b
On Tue, Feb 20, 2018 at 12:57:36PM +, Radu Nicolau wrote:
> Change strncpy count parameter to MAX_LONG_OPT_SZ-1 to avoid
> overwriting the last NULL character and for consistency.
>
> Fixes: 2deb6b5246d7 ("app/procinfo: add collectd format and host id")
> Coverity issue: 30688
>
> Cc: sta...@
Change strncpy count parameter to MAX_LONG_OPT_SZ-1 to avoid
overwriting the last NULL character and for consistency.
Fixes: 2deb6b5246d7 ("app/procinfo: add collectd format and host id")
Coverity issue: 143252
Cc: sta...@dpdk.org
Signed-off-by: Radu Nicolau
---
v2: corrected coverity issue id
Change strncpy count parameter to MAX_LONG_OPT_SZ-1 to avoid
overwriting the last NULL character and for consistency.
Fixes: 2deb6b5246d7 ("app/procinfo: add collectd format and host id")
Coverity issue: 30688
Cc: sta...@dpdk.org
Signed-off-by: Radu Nicolau
---
app/proc_info/main.c | 2 +-
1 f
On Tue, Feb 20, 2018 at 10:17:34AM +0100, David Marchand wrote:
[...]
> Btw, I had forgotten about the deprecation notice [1] sent by Olivier.
> Just discussed it with him, let's wait for this change before looking
> at the issue again.
>
>
> 1:
> http://dpdk.org/browse/dpdk/commit/doc?id=16a700
Application doesn't support more that 64 lcores due to command
line limitation of using a coremask that is parsed as a 64bit
value, so changed it to reflect this limitation.
Fixes: af75078fece3 ("first public release")
Coverity issue: 30688
Cc: sta...@dpdk.org
Signed-off-by: Radu Nicolau
---
e
Add timestamp to received packets before enqueuing to
event device if the timestamp is not already set. Adding
timestamp in the Rx adapter avoids additional latency due
to the event device.
Signed-off-by: Nikhil Rao
---
lib/librte_eventdev/rte_event_eth_rx_adapter.h | 6 +-
lib/librte_
Hi,
There are currently 50 open Coverity static analysis defects assigned to
the following authors based on "git blame".
Can you please address these defects an close them early in the 18.05
release cycle. Details on what is required are below the list.
143436 adrien.mazarg...@6wind.com
>-Original Message-
>From: Ahmed Mansour [mailto:ahmed.mans...@nxp.com]
>Sent: 17 February 2018 02:52
>To: Trahe, Fiona ; Verma, Shally
>; dev@dpdk.org
>Cc: Athreya, Narayana Prasad ; Gupta,
>Ashish ; Sahu, Sunila
>; De Lara Guarch, Pablo
>; Challa, Mahipal
>; Jain, Deepak K ; Hemant
On Tue, Feb 20, 2018 at 06:12:49AM +, Hemant Agrawal wrote:
> Hi Thomas,
> Can you integrate ?
> http://dpdk.org/dev/patchwork/patch/33666/
>
> An early integration will help the subsequent kernel module patches to use
> new path.
>
> Regards,
> Hemant
>
I think that could do with a
On 02/09/2018 06:19 PM, Tomasz Kulasek wrote:
When reallocation of guest pages fails, vhost_user_set_mem_table() also
should fail.
Fixes: e246896178e6 ("vhost: get guest/host physical address mappings")
Cc:yuanhan@linux.intel.com
Cc:sta...@dpdk.org
Signed-off-by: Ziye Yang
Signed-off-by:
Hello,
On Tue, Feb 20, 2018 at 6:41 AM, Hyong Youb Kim wrote:
> On Mon, Feb 19, 2018 at 01:42:27PM +0100, David Marchand wrote:
>> Reused the .mac_addr_add and .mac_addr_del callbacks code to implement
>> primary mac address handler.
>>
>> Signed-off-by: David Marchand
>
> Hi, thanks for taking
On 02/09/2018 06:10 PM, Tomasz Kulasek wrote:
This prevents from destroying & recreating user device in "incomplete"
vring state. virtio_is_ready() was returning true for devices with
vrings which did not have valid callfd (their VHOST_USER_SET_VRING_CALL
hasn't arrived yet)
Fixes: 8f972312b8f
Hi Tomasz,
On 02/09/2018 06:05 PM, Tomasz Kulasek wrote:
Fixes: 8f972312b8f4 ("vhost: support vhost-user")
Cc:jianfeng@intel.com
Cc:sta...@dpdk.org
Signed-off-by: Pawel Wodkowski
Signed-off-by: Tomasz Kulasek
---
v2 changes:
- Changed fixline to point right commit
---
lib/librte_vhost
46 matches
Mail list logo
