Re: [dpdk-dev] [PATCH] compressdev: implement API

2018-03-02 Thread Ahmed Mansour
On 2/28/2018 1:39 PM, Trahe, Fiona wrote: > Hi Ahmed, Shally, > > So just to capture what we concluded in the call today: > > - There's no requirement for a device-agnostic session to facilitate > load-balancing. > - For stateful data a stream is compulsory. Xform is passed to stream on > creat

Re: [dpdk-dev] [PATCH V5 2/2] net/tap: use new Rx offloads API

2018-03-02 Thread Ferruh Yigit
On 1/17/2018 2:04 PM, Moti Haimovsky wrote: > Ethdev Rx offloads API has changed since: > commit ce17eddefc20 ("ethdev: introduce Rx queue offloads API") > This commit adds support for the new Rx offloads API. > > Signed-off-by: Moti Haimovsky <...> > +static bool > +tap_rxq_are_offloads_valid(

Re: [dpdk-dev] [PATCH] eal: add asynchronous request API to DPDK IPC

2018-03-02 Thread Stephen Hemminger
On Tue, 27 Feb 2018 14:59:29 + Anatoly Burakov wrote: > This API is similar to the blocking API that is already present, > but reply will be received in a separate callback by the caller. > > Under the hood, we create a separate thread to deal with replies to > asynchronous requests, that wi

Re: [dpdk-dev] [PATCH] compressdev: implement API

2018-03-02 Thread Ahmed Mansour
On 3/2/2018 4:53 AM, Trahe, Fiona wrote: > >> On 3/1/2018 9:41 AM, Trahe, Fiona wrote: >>> Hi Shally >>> >>> //snip// [Shally] This looks better to me. So it mean app would always call xform_init() for stateless and attach >> an updated priv_xform to ops (depending upon if there's s

Re: [dpdk-dev] [PATCH v1] net/mlx4: fix 'show port info all' during detach

2018-03-02 Thread Adrien Mazarguil
On Wed, Feb 28, 2018 at 04:47:30PM +, Ophir Munk wrote: > The following scenario causes a crash in function mlx4_get_ifname > 1. On testpmd startup mlx4 device is probed and started > 2. mlx4 sriov is disabled. As a result an RMV event is sent to > testpmd which closes the device and nullify th

Re: [dpdk-dev] [PATCH] eal: add asynchronous request API to DPDK IPC

2018-03-02 Thread Stephen Hemminger
On Tue, 27 Feb 2018 14:59:29 + Anatoly Burakov wrote: > +rte_mp_request_async(struct rte_mp_msg *req, const struct timespec *ts) > { > + struct sync_request *dummy; > + struct async_request_shared_param *param = NULL; > + struct rte_mp_reply *reply = NULL; > + int dir_fd, ret

[dpdk-dev] [PATCH v2] eal: add asynchronous request API to DPDK IPC

2018-03-02 Thread Anatoly Burakov
This API is similar to the blocking API that is already present, but reply will be received in a separate callback by the caller. Under the hood, we create a separate thread to deal with replies to asynchronous requests, that will just wait to be notified by the main thread, or woken up on a timer

Re: [dpdk-dev] Fwd: SR-IOV dpdk testpmd bonding does not work

2018-03-02 Thread Ferruh Yigit
On 2/28/2018 6:30 AM, Hekai Wang wrote: > -- Forwarded message -- > From: Hekai Wang > Date: 2018-02-28 14:28 GMT+08:00 > Subject: SR-IOV dpdk testpmd bonding does not work > To: test-rep...@dpdk.org > > > Hi > > I have a problem with dpdk testpmd bonding,I think may be a bug >

Re: [dpdk-dev] [PATCH v2] net/mlx: fix rdma-core glue path with EAL plugins

2018-03-02 Thread Timothy Redaelli
On Fri, 2 Mar 2018 15:15:17 +0100 Adrien Mazarguil wrote: > Glue object files are looked up in RTE_EAL_PMD_PATH by default when > set and should be installed in this directory. > > During startup, EAL attempts to load them automatically like other > plug-ins found there. While normally harmless,

Re: [dpdk-dev] [PATCH] usertools/dpdk-devbind.py: add support for avp device

2018-03-02 Thread Ferruh Yigit
On 2/26/2018 5:43 AM, Xiaohua Zhang wrote: > Signed-off-by: Xiaohua Zhang Patch title should be: usertools: add support for AVP device Except from that, Acked-by: Ferruh Yigit

[dpdk-dev] [PATCH v4 5/5] eal: simplify IPC sync request timeout code

2018-03-02 Thread Anatoly Burakov
Signed-off-by: Anatoly Burakov --- lib/librte_eal/common/eal_common_proc.c | 18 -- 1 file changed, 4 insertions(+), 14 deletions(-) diff --git a/lib/librte_eal/common/eal_common_proc.c b/lib/librte_eal/common/eal_common_proc.c index f382184..666c566 100644 --- a/lib/librte_eal/

[dpdk-dev] [PATCH v4 2/5] eal: use file to check if secondary process is ready

2018-03-02 Thread Anatoly Burakov
Previously, IPC would remove sockets it considers to be "inactive" based on whether they have responded. We also need to prevent sending messages to processes that are active, but haven't yet finished initialization. This will create a "init file" per socket which will be removed after initializat

[dpdk-dev] [PATCH v4 3/5] eal: prevent secondary process init while sending messages

2018-03-02 Thread Anatoly Burakov
Currently, it is possible to spin up a secondary process while either sendmsg or request is in progress. Fix this by adding directory locks during init, sendmsg and requests. Signed-off-by: Anatoly Burakov --- Notes: v4: fixed resource leaks and added support for init files introduce

[dpdk-dev] [PATCH v4 1/5] eal: add internal flag indicating init has completed

2018-03-02 Thread Anatoly Burakov
Currently, primary process initialization is finalized by setting the RTE_MAGIC value in the shared config. However, it is not possible to check whether secondary process initialization has completed. Add such a value to internal config. Signed-off-by: Anatoly Burakov --- Notes: v4: make ini

[dpdk-dev] [PATCH v4 4/5] eal: don't hardcode socket filter value in IPC

2018-03-02 Thread Anatoly Burakov
Currently, filter value is hardcoded and disconnected from actual value returned by eal_mp_socket_path(). Fix this to generate filter value by deriving it from eal_mp_socket_path() instead. Signed-off-by: Anatoly Burakov Acked-by: Jianfeng Tan --- Notes: v4: added filtering for init files a

[dpdk-dev] [PATCH v2] net/mlx: fix rdma-core glue path with EAL plugins

2018-03-02 Thread Adrien Mazarguil
Glue object files are looked up in RTE_EAL_PMD_PATH by default when set and should be installed in this directory. During startup, EAL attempts to load them automatically like other plug-ins found there. While normally harmless, dlopen() fails when rdma-core is not installed, EAL interprets this a

Re: [dpdk-dev] [PATCH] vhost: fix return avail ring position in get vring base

2018-03-02 Thread Maxime Coquelin
On 02/21/2018 09:29 AM, Maxime Coquelin wrote: On 02/09/2018 06:28 PM, Tomasz Kulasek wrote: According to the "Vhost-user Protocol" document, VHOST_USER_GET_VRING_BASE should get the available vring base offset. Fixes: 8f972312b8f4 ("vhost: support vhost-user") Cc:huawei@intel.com Cc:st

Re: [dpdk-dev] [PATCH] vhost: fix close callfd on get vring base

2018-03-02 Thread Maxime Coquelin
Hi Tomasz, On 02/20/2018 10:09 AM, Maxime Coquelin wrote: On 02/09/2018 06:10 PM, Tomasz Kulasek wrote: This prevents from destroying & recreating user device in "incomplete" vring state. virtio_is_ready() was returning true for devices with vrings which did not have valid callfd (their VHOST

Re: [dpdk-dev] virtio with 2MB hugepages - bringing back single file segments

2018-03-02 Thread Maxime Coquelin
On 03/02/2018 10:03 AM, Stojaczyk, DariuszX wrote: Hi Maxime, Hi, I'm trying to make a vhost-user initiator built upon DPDK work with 2MB hugepages. In the initiator we have to share all memory with the host process, so it can perform DMA. DPDK currently enforces having one descriptor per h

Re: [dpdk-dev] 16.11.5 (LTS) patches review and test

2018-03-02 Thread Luca Boccassi
On Fri, 2018-03-02 at 14:10 +0530, gowrishankar muthukrishnan wrote: > Anywhere do we track its kernel and GCC compatibility esp for KNI,  > vfio/uio ?. If not, it would be good to document for supported > kernel  > versions I think. I'm not sure if it's explicitly tracked - are you seeing these p

Re: [dpdk-dev] [PATCH] compressdev: implement API

2018-03-02 Thread Trahe, Fiona
> -Original Message- > From: Ahmed Mansour [mailto:ahmed.mans...@nxp.com] > Sent: Friday, March 2, 2018 12:56 AM > To: Trahe, Fiona ; Verma, Shally > ; dev@dpdk.org > Cc: De Lara Guarch, Pablo ; Athreya, Narayana > Prasad > ; Gupta, Ashish ; > Sahu, Sunila > ; Challa, Mahipal ; Jain,

[dpdk-dev] [DPDK] net/i40e: convert to new Tx offloads API

2018-03-02 Thread Yanglong Wu
Ethdev Tx offloads API has changed since: commit cba7f53b717d ("ethdev: introduce Tx queue offloads API") This commit support the new Tx offloads API. Signed-off-by: Yanglong Wu --- drivers/net/i40e/i40e_ethdev.c| 1 + drivers/net/i40e/i40e_ethdev_vf.c | 1 + drivers/net/i40e/i40e_rxtx.c

Re: [dpdk-dev] virtio with 2MB hugepages - bringing back single file segments

2018-03-02 Thread Stojaczyk, DariuszX
Hi Maxime, > > Hi, > > > > I'm trying to make a vhost-user initiator built upon DPDK work with > > 2MB hugepages. In the initiator we have to share all memory with the host > process, so it can perform DMA. DPDK currently enforces having one descriptor > per hugepage and there's an artificial limi

[dpdk-dev] [PATCH v2 2/5] eal: fix IPC socket paths

2018-03-02 Thread Anatoly Burakov
Fixes: bacaa2754017 ("eal: add channel for multi-process communication") Cc: jianfeng@intel.com Signed-off-by: Anatoly Burakov Acked-by: Jianfeng Tan --- Notes: v2: no changes lib/librte_eal/common/eal_common_proc.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --gi

[dpdk-dev] [PATCH v2 5/5] eal: fix race condition in IPC requests

2018-03-02 Thread Anatoly Burakov
Unlocking the action list before sending message and locking it again aftterwards introduces a window where a response might arrive before we have a chance to start waiting on a condition, resulting in timeouts on valid messages. Fixes: 783b6e54971d ("eal: add synchronous multi-process communicati

[dpdk-dev] [PATCH v2 1/5] eal: fix IPC timeouts

2018-03-02 Thread Anatoly Burakov
Fixes: 783b6e54971d ("eal: add synchronous multi-process communication") Cc: jianfeng@intel.com Signed-off-by: Anatoly Burakov Acked-by: Jianfeng Tan --- Notes: v2: no changes lib/librte_eal/common/eal_common_proc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/l

[dpdk-dev] [PATCH v2 4/5] eal: fix handling of errno values in IPC

2018-03-02 Thread Anatoly Burakov
Fixes: bacaa2754017 ("eal: add channel for multi-process communication") Cc: jianfeng@intel.com Signed-off-by: Anatoly Burakov Acked-by: Jianfeng Tan --- Notes: v2: no changes lib/librte_eal/common/eal_common_proc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[dpdk-dev] [PATCH v2 3/5] eal: fix IPC request socket paths

2018-03-02 Thread Anatoly Burakov
Fixes: 783b6e54971d ("eal: add synchronous multi-process communication") Cc: jianfeng@intel.com Signed-off-by: Anatoly Burakov Acked-by: Jianfeng Tan --- Notes: v2: no changes lib/librte_eal/common/eal_common_proc.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --g

Re: [dpdk-dev] 16.11.5 (LTS) patches review and test

2018-03-02 Thread gowrishankar muthukrishnan
Anywhere do we track its kernel and GCC compatibility esp for KNI, vfio/uio ?. If not, it would be good to document for supported kernel versions I think. I see below compilation error for a kernel *3.10.0-693.1.1.el7.ppc64le (RHEL 7.4)*: .. ppc_64-power8-linuxapp-gcc/build/lib/librte_eal/lin

[dpdk-dev] [DPDK] net/i40e: convert to new Rx offloads API

2018-03-02 Thread Yanglong Wu
Ethdev Tx offloads API has changed since: commit cba7f53b717d ("ethdev: introduce Tx queue offloads API") This commit support the new Tx offloads API. Signed-off-by: Yanglong Wu --- drivers/net/i40e/i40e_ethdev.c| 30 ++ drivers/net/i40e/i40e_ethdev_vf.c | 22