Re: [dpdk-dev] [RFC v2 03/17] mempool/octeontx: add callback to calculate memory size

2018-03-10 Thread santosh
Hi Andrew, On Saturday 10 March 2018 09:19 PM, Andrew Rybchenko wrote: > Hi Santosh, > > On 02/01/2018 04:40 PM, santosh wrote: >> On Thursday 01 February 2018 03:31 PM, santosh wrote: >>> Hi Andrew, >>> >>> >>> On Thursday 01 February 2018 11:48 AM, Jacob, Jerin wrote: The driver requires o

[dpdk-dev] [PATCH 11/13] cxgbe: export supported RSS hash functions

2018-03-10 Thread Rahul Lakkireddy
Export supported RSS hash functions in device info. Also add check to prevent configuring unsupported RSS hash functions. Fixes: 58c5a23c1c4f ("net/cxgbe: support updating RSS hash configuration and key") Signed-off-by: Rahul Lakkireddy Signed-off-by: Kumar Sanghvi --- drivers/net/cxgbe/cxgbe

[dpdk-dev] [PATCH 13/13] cxgbe: add option to keep outer VLAN tag in Q-in-Q

2018-03-10 Thread Rahul Lakkireddy
From: Kumar Sanghvi Add compile time option to keep outer VLAN tag in Q-in-Q packets. Signed-off-by: Kumar Sanghvi Signed-off-by: Rahul Lakkireddy --- config/common_base | 1 + doc/guides/nics/cxgbe.rst| 4 +++ drivers/net/cxgbe/base/t4_regs.h | 54

[dpdk-dev] [PATCH 10/13] cxgbe: fix check to close other ports properly

2018-03-10 Thread Rahul Lakkireddy
Fixes: 084b35314ff2 ("net/cxgbe: rework ethdev device allocation") Signed-off-by: Rahul Lakkireddy Signed-off-by: Kumar Sanghvi --- drivers/net/cxgbe/cxgbe_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/cxgbe/cxgbe_main.c b/drivers/net/cxgbe/cxgbe_main.c i

[dpdk-dev] [PATCH 09/13] cxgbe: add support to set mac address

2018-03-10 Thread Rahul Lakkireddy
From: Kumar Sanghvi Signed-off-by: Kumar Sanghvi Signed-off-by: Rahul Lakkireddy --- drivers/net/cxgbe/cxgbe_ethdev.c | 17 + drivers/net/cxgbe/cxgbe_pfvf.h | 1 + drivers/net/cxgbe/cxgbevf_ethdev.c | 1 + 3 files changed, 19 insertions(+) diff --git a/drivers/net/cxgb

[dpdk-dev] [PATCH 12/13] cxgbe: convert to SPDX license tags

2018-03-10 Thread Rahul Lakkireddy
Signed-off-by: Rahul Lakkireddy Signed-off-by: Kumar Sanghvi --- doc/guides/nics/cxgbe.rst | 32 +++ drivers/net/cxgbe/Makefile | 33 +++- drivers/net/cxgbe/base/adapter.h| 34 +++--

[dpdk-dev] [PATCH 04/13] cxgbe: add probe to initialize VF devices

2018-03-10 Thread Rahul Lakkireddy
From: Kumar Sanghvi Add probe to initialize VF devices. Separate init/de-init paths for PF and VF. Do firmware state initialization wrt VF and retrieve various operational parameters by querying firmware. Finally configure and initialize ports. Signed-off-by: Kumar Sanghvi Signed-off-by: Rah

[dpdk-dev] [PATCH 05/13] cxgbe: initialize SGE and queues for VF

2018-03-10 Thread Rahul Lakkireddy
From: Kumar Sanghvi Query firmware and initialize SGE parameters and enable queue allocation for VF. Calculate pcie channel and queue congestion management for VF. Signed-off-by: Kumar Sanghvi Signed-off-by: Rahul Lakkireddy --- drivers/net/cxgbe/base/adapter.h| 2 + drivers/net/cx

[dpdk-dev] [PATCH 06/13] cxgbe: enable RSS for VF

2018-03-10 Thread Rahul Lakkireddy
From: Kumar Sanghvi Query firmware and configure RSS for VF. Signed-off-by: Kumar Sanghvi Signed-off-by: Rahul Lakkireddy --- drivers/net/cxgbe/base/common.h | 22 ++ drivers/net/cxgbe/base/t4fw_interface.h | 78 + drivers/net/cxgbe/base/t4vf_hw

[dpdk-dev] [PATCH 08/13] cxgbe: add VF port statistics

2018-03-10 Thread Rahul Lakkireddy
From: Kumar Sanghvi Signed-off-by: Kumar Sanghvi Signed-off-by: Rahul Lakkireddy --- drivers/net/cxgbe/base/common.h | 2 + drivers/net/cxgbe/base/t4_regs.h| 10 +++ drivers/net/cxgbe/base/t4fw_interface.h | 13 drivers/net/cxgbe/base/t4vf_hw.c| 105 +++

[dpdk-dev] [PATCH 07/13] cxgbe: update TX and RX path for VF

2018-03-10 Thread Rahul Lakkireddy
From: Kumar Sanghvi On TX path, add fw_eth_tx_pkt_vm_wr to transmit packets over VF. Use is_pf4() to correctly calculate the work request size and offsets within the work request. On RX path, use pktshift to adjust data offset within the mbuf. Signed-off-by: Kumar Sanghvi Signed-off-by: Rahul

[dpdk-dev] [PATCH 03/13] cxgbe: add base for enabling VF ports

2018-03-10 Thread Rahul Lakkireddy
From: Kumar Sanghvi Add base to enable VF ports in subsequent patches. Signed-off-by: Kumar Sanghvi Signed-off-by: Rahul Lakkireddy --- drivers/net/cxgbe/base/common.h | 31 +++ drivers/net/cxgbe/base/t4_hw.c | 9 +- drivers/net/cxgbe/base/t4_regs.h| 2 + drivers

[dpdk-dev] [PATCH 01/13] cxgbe: add skeleton VF driver

2018-03-10 Thread Rahul Lakkireddy
From: Kumar Sanghvi Add minimal VF driver. Declare functions common to both PF and VF functionality in separate header file and import the header file. Signed-off-by: Kumar Sanghvi Signed-off-by: Rahul Lakkireddy --- doc/guides/nics/features/cxgbevf.ini | 28 +++ doc/guides/rel_not

[dpdk-dev] [PATCH 02/13] cxgbe: add VF firmware mailbox support

2018-03-10 Thread Rahul Lakkireddy
From: Kumar Sanghvi Add firmware mailbox communication support for VF. Add is_pf4() to check if driver is attached to PF4. Use is_pf4() to determine whether to use PF or VF mailbox communication. Signed-off-by: Kumar Sanghvi Signed-off-by: Rahul Lakkireddy --- drivers/net/cxgbe/Makefile

[dpdk-dev] [PATCH 00/13] cxgbe: add CXGBE VF PMD and updates

2018-03-10 Thread Rahul Lakkireddy
Patches 1 - 9 add support for cxgbe VF driver. Patches 10 - 12 fix bugs and convert license in cxgbe files to SPDX License Tag. Patch 13 adds compile time option to keep outer vlan tag in Q-in-Q packet. Patch 1 adds minimal cxgbe VF driver. Patch 2 adds firmware mailbox support for VF. Patch 3

Re: [dpdk-dev] [PATCH 0/3] add ifcvf driver

2018-03-10 Thread Maxime Coquelin
Hi Xiao, On 03/10/2018 12:08 AM, Xiao Wang wrote: This patch set has dependency on http://dpdk.org/dev/patchwork/patch/35635/ (vhost: support selective datapath); ifc VF is compatible with virtio vring operations, this driver implements vDPA driver ops which configures ifc VF to be a vhost data

[dpdk-dev] [PATCH] rte_kvargs:fix comments to use commas not semicolons

2018-03-10 Thread Keith Wiles
Signed-off-by: Keith Wiles --- lib/librte_kvargs/rte_kvargs.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/librte_kvargs/rte_kvargs.c b/lib/librte_kvargs/rte_kvargs.c index 9662375e8..d92a5f9dc 100644 --- a/lib/librte_kvargs/rte_kvargs.c +++ b/lib/librte_kvargs/rte_

Re: [dpdk-dev] [RFC v2 03/17] mempool/octeontx: add callback to calculate memory size

2018-03-10 Thread Andrew Rybchenko
Hi Santosh, On 02/01/2018 04:40 PM, santosh wrote: On Thursday 01 February 2018 03:31 PM, santosh wrote: Hi Andrew, On Thursday 01 February 2018 11:48 AM, Jacob, Jerin wrote: The driver requires one and only one physically contiguous memory chunk for all objects. Signed-off-by: Andrew Rybch

[dpdk-dev] [PATCH v1 7/9] mempool: remove callback to register memory area

2018-03-10 Thread Andrew Rybchenko
The callback is not required any more since there is a new callback to populate objects using provided memory area which provides the same information. Signed-off-by: Andrew Rybchenko --- RFCv2 -> v1: - advertise ABI changes in release notes doc/guides/rel_notes/deprecation.rst | 1 - d

[dpdk-dev] [PATCH v1 0/9] mempool: prepare to add bucket driver

2018-03-10 Thread Andrew Rybchenko
The initial patch series [1] is split into two to simplify processing. The second series relies on this one and will add bucket mempool driver and related ops. The patch series has generic enhancements suggested by Olivier. Basically it adds driver callbacks to calculate required memory size and t

[dpdk-dev] [PATCH v1 8/9] mempool: ensure the mempool is initialized before populating

2018-03-10 Thread Andrew Rybchenko
From: "Artem V. Andreev" Callback to calculate required memory area size may require mempool driver data to be already allocated and initialized. Signed-off-by: Artem V. Andreev Signed-off-by: Andrew Rybchenko --- RFCv2 -> v1: - rename helper function as mempool_ops_alloc_once() lib/librte_

[dpdk-dev] [PATCH v1 9/9] mempool: support flushing the default cache of the mempool

2018-03-10 Thread Andrew Rybchenko
From: "Artem V. Andreev" Mempool get/put API cares about cache itself, but sometimes it is required to flush the cache explicitly. The function is moved in the file since it now requires rte_mempool_default_cache(). Signed-off-by: Artem V. Andreev Signed-off-by: Andrew Rybchenko --- lib/libr

[dpdk-dev] [PATCH v1 6/9] mempool/dpaa: prepare to remove register memory area op

2018-03-10 Thread Andrew Rybchenko
Populate mempool driver callback is executed a bit later than register memory area, provides the same information and will substitute the later since it gives more flexibility and in addition to notification about memory area allows to customize how mempool objects are stored in memory. Signed-off

[dpdk-dev] [PATCH v1 5/9] mempool/octeontx: prepare to remove register memory area op

2018-03-10 Thread Andrew Rybchenko
Callback to populate pool objects has all required information and executed a bit later than register memory area callback. Signed-off-by: Andrew Rybchenko --- drivers/mempool/octeontx/rte_mempool_octeontx.c | 25 ++--- 1 file changed, 10 insertions(+), 15 deletions(-) diff

[dpdk-dev] [PATCH v1 4/9] mempool: deprecate xmem functions

2018-03-10 Thread Andrew Rybchenko
Move rte_mempool_xmem_size() code to internal helper function since it is required in two places: deprecated rte_mempool_xmem_size() and non-deprecated rte_mempool_op_calc_mem_size_deafult(). Signed-off-by: Andrew Rybchenko --- RFCv2 -> v1: - advertise deprecation in release notes - factor out

[dpdk-dev] [PATCH v1 3/9] mempool: remove callback to get capabilities

2018-03-10 Thread Andrew Rybchenko
The callback was introduced to let generic code to know octeontx mempool driver requirements to use single physically contiguous memory chunk to store all objects and align object address to total object size. Now these requirements are met using a new callbacks to calculate required memory chunk s

[dpdk-dev] [PATCH v1 2/9] mempool: add op to populate objects using provided memory

2018-03-10 Thread Andrew Rybchenko
The callback allows to customize how objects are stored in the memory chunk. Default implementation of the callback which simply puts objects one by one is available. Signed-off-by: Andrew Rybchenko --- RFCv2 -> v1: - advertise ABI changes in release notes - use consistent name for default call

[dpdk-dev] [PATCH v1 1/9] mempool: add op to calculate memory size to be allocated

2018-03-10 Thread Andrew Rybchenko
Size of memory chunk required to populate mempool objects depends on how objects are stored in the memory. Different mempool drivers may have different requirements and a new operation allows to calculate memory size in accordance with driver requirements and advertise requirements on minimum memor