[dpdk-dev] [PATCH v3 01/10] event/dpaa: fix include header

2018-03-14 Thread Hemant Agrawal
rte_cycles.h shall be included instead of rte_cycles_64.h dpaa_eventdev.c:32:27: fatal error: rte_cycles_64.h: No such file or directory Fixes: 9caac5dd1e7f ("event/dpaa: introduce PMD") Cc: sta...@dpdk.org Signed-off-by: Hemant Agrawal --- drivers/event/dpaa/dpaa_eventdev.c | 2 +- 1 file cha

[dpdk-dev] [PATCH v3 00/10] meson build support for dpaaX

2018-03-14 Thread Hemant Agrawal
Earlier dpaaX was only compiled for armv8 target. This patch series first prepares the dpaaX drivers to be compiled for non-ARM platform as well. Note: This patch changes all of the dpaa drivers/modules - So it shall be applied to master tree instead of meson build tree. v3: - improved cross

[dpdk-dev] [PATCH v3 02/10] bus/dpaa: fix the BE compilation issue

2018-03-14 Thread Hemant Agrawal
The array pointers were used without index. Fixes: b9083ea5e084 ("net/dpaa: further push mode optimizations") Cc: sta...@dpdk.org Signed-off-by: Hemant Agrawal Acked-by: Shreyansh Jain --- drivers/bus/dpaa/base/qbman/qman.c| 5 +++-- drivers/bus/dpaa/base/qbman/qman_driver.c | 5 +

[dpdk-dev] [PATCH v3 03/10] dpaa: prepare for 32 bit compilation

2018-03-14 Thread Hemant Agrawal
This patch prepares the dpaa drivers for compilation on 32 bit machine. Signed-off-by: Hemant Agrawal --- drivers/bus/dpaa/base/fman/fman.c | 2 +- drivers/bus/dpaa/base/qbman/bman_driver.c | 2 +- drivers/bus/dpaa/dpaa_bus.c | 3 +-- drivers/crypto/dpaa_sec/dpaa_sec.c

[dpdk-dev] [PATCH v3 06/10] bus/dpaa: enabling dpaa compilation for other platforms

2018-03-14 Thread Hemant Agrawal
Signed-off-by: Hemant Agrawal --- drivers/bus/dpaa/include/compat.h | 30 -- 1 file changed, 28 insertions(+), 2 deletions(-) diff --git a/drivers/bus/dpaa/include/compat.h b/drivers/bus/dpaa/include/compat.h index 53707bb..e4b5702 100644 --- a/drivers/bus/dpaa/inclu

[dpdk-dev] [PATCH v3 05/10] bus/fslmc: add 32 bit functional support for ARM

2018-03-14 Thread Hemant Agrawal
This patch adds the functional logic to make the dpaa2 drivers work on 32bit machine. Signed-off-by: Hemant Agrawal --- drivers/bus/fslmc/qbman/qbman_sys.h | 30 -- drivers/bus/fslmc/qbman/qbman_sys_decl.h | 9 + 2 files changed, 37 insertions(+), 2 dele

[dpdk-dev] [PATCH v3 04/10] dpaa2: prepare for 32 bit compilation

2018-03-14 Thread Hemant Agrawal
This patch prepare the dpaa2 drivers for compilation on 32 bit machine. Signed-off-by: Hemant Agrawal --- drivers/bus/fslmc/fslmc_vfio.c | 10 +-- drivers/bus/fslmc/mc/fsl_mc_cmd.h | 2 +- drivers/bus/fslmc/portal/dpaa2_hw_dpio.c| 22 +++--- drivers/bus/fslmc/porta

[dpdk-dev] [PATCH v3 08/10] config: add dpaaX build support in common linuxapp

2018-03-14 Thread Hemant Agrawal
Signed-off-by: Hemant Agrawal --- config/common_armv8a_linuxapp | 58 --- config/common_base| 4 +++ config/common_linuxapp| 14 +++ 3 files changed, 18 insertions(+), 58 deletions(-) diff --git a/config/common_armv8a_linuxapp

[dpdk-dev] [PATCH v3 07/10] bus/fslmc: enabling dpaa2 compilation for other platforms

2018-03-14 Thread Hemant Agrawal
Signed-off-by: Hemant Agrawal --- drivers/bus/fslmc/qbman/qbman_sys_decl.h | 14 ++ 1 file changed, 14 insertions(+) diff --git a/drivers/bus/fslmc/qbman/qbman_sys_decl.h b/drivers/bus/fslmc/qbman/qbman_sys_decl.h index 5640b04..fa6977f 100644 --- a/drivers/bus/fslmc/qbman/qbman_sys

[dpdk-dev] [PATCH v3 09/10] build: add meson support for dpaaX platforms

2018-03-14 Thread Hemant Agrawal
Signed-off-by: Akhil Goyal Signed-off-by: Hemant Agrawal --- app/test-pmd/meson.build | 3 +++ config/arm/meson.build | 13 + config/rte_config.h | 12 +++- drivers/bus/dpaa/meson.build | 29 + dr

[dpdk-dev] [PATCH v3 10/10] build: add meson cross compile config for dpaaX

2018-03-14 Thread Hemant Agrawal
Signed-off-by: Hemant Agrawal --- config/arm/arm64_dpaa2_linuxapp_gcc | 15 +++ config/arm/arm64_dpaa_linuxapp_gcc | 15 +++ 2 files changed, 30 insertions(+) create mode 100644 config/arm/arm64_dpaa2_linuxapp_gcc create mode 100644 config/arm/arm64_dpaa_linuxapp_gcc d

[dpdk-dev] [PATCH] eal/vfio: export internal vfio functions

2018-03-14 Thread Hemant Agrawal
This patch moves some of the internal vfio functions from eal_vfio.h to rte_vfio.h for common uses with "rte_" prefix. This patch also change the FSLMC bus usages from the internal VFIO functions to external ones with "rte_" prefix Signed-off-by: Hemant Agrawal --- This patch has some minor conf

Re: [dpdk-dev] [PATCH] drivers/net: update link status

2018-03-14 Thread Nélio Laranjeiro
On Tue, Mar 13, 2018 at 06:05:34PM +, Ferruh Yigit wrote: > Update link status related feature document items and minor updates in > some link status related functions. > > Signed-off-by: Ferruh Yigit > --- > doc/guides/nics/features/fm10k.ini | 2 ++ > doc/guides/nics/features/fm10k_vf

[dpdk-dev] [PATCH v4] doc: add driver limitation for vhost dequeue zero copy

2018-03-14 Thread Junjie Chen
In vhost-switch example, when binding nic to vfio-pci with iommu enabled, dequeue zero copy cannot work in VM2NIC mode due to no iommu dma mapping is setup for guest memory currently. Signed-off-by: Junjie Chen --- Changes in V4: - make words more accurate Changes in V3: - update limitation to io

Re: [dpdk-dev] [PATCH v3 00/10] meson build support for dpaaX

2018-03-14 Thread Bruce Richardson
On Wed, Mar 14, 2018 at 01:25:56PM +0530, Hemant Agrawal wrote: > Earlier dpaaX was only compiled for armv8 target. This patch series first > prepares the dpaaX drivers to be compiled for non-ARM platform as well. > > > Note: This patch changes all of the dpaa drivers/modules - So it shall be >

Re: [dpdk-dev] [PATCH v3 00/10] meson build support for dpaaX

2018-03-14 Thread Hemant Agrawal
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Bruce Richardson > Sent: Wednesday, March 14, 2018 2:39 PM > On Wed, Mar 14, 2018 at 01:25:56PM +0530, Hemant Agrawal wrote: > > Earlier dpaaX was only compiled for armv8 target. This patch series first > prepares

[dpdk-dev] Sharing Common libs between PMDs

2018-03-14 Thread Liron Himi
Hi, We have several PMDs in DPDK that are using the same underlying common libraries. In addition, we have plans to add some new common service into DPDK that already introduces too much complexity with the way that the code is written now. Therefore, we would like to move all our common functi

[dpdk-dev] [PATCH 1/2] eal: add macros to align value to multiple

2018-03-14 Thread Pavan Nikhilesh
Add macros to align given value to the multiple of the supplied integer. Signed-off-by: Pavan Nikhilesh --- Common code needed for OcteonTx event timer device. lib/librte_eal/common/include/rte_common.h | 16 1 file changed, 16 insertions(+) diff --git a/lib/librte_eal/commo

[dpdk-dev] [PATCH 2/2] test: update common auto test

2018-03-14 Thread Pavan Nikhilesh
Update common auto test to include test for aligning values to multiples of given integer. Signed-off-by: Pavan Nikhilesh --- test/test/test_common.c | 12 1 file changed, 12 insertions(+) diff --git a/test/test/test_common.c b/test/test/test_common.c index d0342430f..e43cba49b 100

Re: [dpdk-dev] [PATCH] crypto/mrvl: add MRVL to hash test cases

2018-03-14 Thread De Lara Guarch, Pablo
Hi Tomasz, > -Original Message- > From: Tomasz Duszynski [mailto:t...@semihalf.com] > Sent: Thursday, March 8, 2018 1:27 PM > To: dev@dpdk.org > Cc: De Lara Guarch, Pablo ; Doherty, > Declan ; Richardson, Bruce > ; Tomasz Duszynski ; > sta...@dpdk.org > Subject: Re: [PATCH] crypto/mrvl: ad

Re: [dpdk-dev] [PATCH] eal/vfio: export internal vfio functions

2018-03-14 Thread Burakov, Anatoly
On 14-Mar-18 8:00 AM, Hemant Agrawal wrote: This patch moves some of the internal vfio functions from eal_vfio.h to rte_vfio.h for common uses with "rte_" prefix. This patch also change the FSLMC bus usages from the internal VFIO functions to external ones with "rte_" prefix Signed-off-by: Hema

Re: [dpdk-dev] [PATCH] crypto/mrvl: add MRVL to hash test cases

2018-03-14 Thread Tomasz Duszynski
On Wed, Mar 14, 2018 at 10:13:58AM +, De Lara Guarch, Pablo wrote: > Hi Tomasz, > > > -Original Message- > > From: Tomasz Duszynski [mailto:t...@semihalf.com] > > Sent: Thursday, March 8, 2018 1:27 PM > > To: dev@dpdk.org > > Cc: De Lara Guarch, Pablo ; Doherty, > > Declan ; Richardson,

Re: [dpdk-dev] [PATCH] net/bonding: switch to new offloading flags

2018-03-14 Thread Radu Nicolau
On 3/13/2018 12:24 PM, Ferruh Yigit wrote: Switch from using deprecated bitfields in rxmode to offloads variable. Signed-off-by: Ferruh Yigit --- Acked-by: Radu Nicolau

Re: [dpdk-dev] [PATCH 1/2] eal: add macros to align value to multiple

2018-03-14 Thread Ananyev, Konstantin
Hi Pavan, > > Add macros to align given value to the multiple of the supplied > integer. > > Signed-off-by: Pavan Nikhilesh > --- > > Common code needed for OcteonTx event timer device. > > lib/librte_eal/common/include/rte_common.h | 16 > 1 file changed, 16 insertions(+)

Re: [dpdk-dev] [PATCH] net/mrvl: convert license headers to SPDX tags

2018-03-14 Thread De Lara Guarch, Pablo
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Tomasz Duszynski > Sent: Friday, March 9, 2018 9:40 AM > To: dev@dpdk.org > Cc: m...@semihalf.com; d...@marvell.com; nsams...@marvell.com; > j...@semihalf.com; jianbo@arm.com; Tomasz Duszynski > > Subject: [d

Re: [dpdk-dev] [PATCH 1/5] flow_classify: remove void pointer cast

2018-03-14 Thread Iremonger, Bernard
> -Original Message- > From: Yang, Zhiyong > Sent: Monday, February 26, 2018 8:11 AM > To: dev@dpdk.org > Cc: Yigit, Ferruh ; Iremonger, Bernard > ; Yang, Zhiyong > Subject: [PATCH 1/5] flow_classify: remove void pointer cast > > Cc: bernard.iremon...@intel.com > Signed-off-by: Zhiyong Ya

Re: [dpdk-dev] [PATCH v2] net/i40e: fix intr callback unregister by adding retry

2018-03-14 Thread Rybalchenko, Kirill
Hi Yunjian, > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of wangyunjian > Sent: Tuesday 13 March 2018 06:53 > To: dev@dpdk.org > Cc: ca...@huawei.com; Yunjian Wang > Subject: [dpdk-dev] [PATCH v2] net/i40e: fix intr callback unregister by > adding retry > > Fr

Re: [dpdk-dev] [PATCH v2 1/2] Add RIB library

2018-03-14 Thread Bruce Richardson
On Wed, Feb 21, 2018 at 09:44:54PM +, Medvedkin Vladimir wrote: > RIB is an alternative to current LPM library. > It solves the following problems > - Increases the speed of control plane operations against lpm such as >adding/deleting routes > - Adds abstraction from dataplane algorithms

Re: [dpdk-dev] [PATCH 2/3] bus/pci: expose sysfs parsing API

2018-03-14 Thread Burakov, Anatoly
On 09-Mar-18 11:08 PM, Xiao Wang wrote: Some existing sysfs parsing functions are helpful for the later vDPA driver, this patch make them global and expose them to shared lib. Signed-off-by: Xiao Wang --- drivers/bus/pci/linux/pci.c | 9 - drivers/bus/pci/linux/pci_init.h

Re: [dpdk-dev] [PATCH v2] net/i40e: fix intr callback unregister by adding retry

2018-03-14 Thread wangyunjian
> -Original Message- > From: Rybalchenko, Kirill [mailto:kirill.rybalche...@intel.com] > Sent: Wednesday, March 14, 2018 7:04 PM > To: wangyunjian ; dev@dpdk.org > Cc: caihe > Subject: RE: [dpdk-dev] [PATCH v2] net/i40e: fix intr callback unregister by > adding retry > > Hi Yunjian, >

Re: [dpdk-dev] [PATCH] lib/cryptodev: pass rte driver to REGISTER macro

2018-03-14 Thread De Lara Guarch, Pablo
> -Original Message- > From: Akhil Goyal [mailto:akhil.go...@nxp.com] > Sent: Tuesday, March 13, 2018 12:34 PM > To: Trahe, Fiona ; dev@dpdk.org; > jerin.ja...@caviumnetworks.com; Zhang, Roy Fan > ; Doherty, Declan ; > j...@semihalf.com; t...@semihalf.com; d...@marvell.com; > nsams...@mar

Re: [dpdk-dev] [PATCH v3 1/2] Add RIB library

2018-03-14 Thread Bruce Richardson
On Thu, Feb 22, 2018 at 10:50:55PM +, Medvedkin Vladimir wrote: > RIB is an alternative to current LPM library. > It solves the following problems > - Increases the speed of control plane operations against lpm such as >adding/deleting routes > - Adds abstraction from dataplane algorithms

Re: [dpdk-dev] [PATCH] net/i40e:fix VSI stats error

2018-03-14 Thread Rybalchenko, Kirill
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Yanglong Wu > Sent: Thursday 1 February 2018 02:11 > To: dev@dpdk.org > Cc: Zhang, Qi Z ; Lu, Wenzhuo > ; Wu, Yanglong > Subject: [dpdk-dev] [PATCH] net/i40e:fix VSI stats error > > In VF, the number of ibytes re

[dpdk-dev] [PATCH v3] net/i40e: fix intr callback unregister by adding retry

2018-03-14 Thread wangyunjian
From: Yunjian Wang The nic's interrupt source has some active callbacks, when the port hotplug. Add a retry to give more port's a chance to uninit before returning an error. Fixes: d42aaf30008b ("i40e: support port hotplug") Signed-off-by: Yunjian Wang --- v2: * Fix return value check --- v3:

Re: [dpdk-dev] [PATCH] crypto/mrvl: add MRVL to hash test cases

2018-03-14 Thread De Lara Guarch, Pablo
> -Original Message- > From: Tomasz Duszynski [mailto:t...@semihalf.com] > Sent: Wednesday, March 14, 2018 10:30 AM > To: De Lara Guarch, Pablo > Cc: Tomasz Duszynski ; dev@dpdk.org; Doherty, > Declan ; Richardson, Bruce > ; sta...@dpdk.org > Subject: Re: [PATCH] crypto/mrvl: add MRVL to

Re: [dpdk-dev] [PATCH v2 1/2] Add RIB library

2018-03-14 Thread Richardson, Bruce
> > +/** RIB nodes allocation type */ > > +enum rte_rib_alloc_type { > > + RTE_RIB_MALLOC, > > + RTE_RIB_MEMPOOL, > > + RTE_RIB_ALLOC_MAX > > +}; > > Not sure you need this any more. Malloc allocations and mempool > allocations are now pretty much the same thing. Sorry, please ignore this c

Re: [dpdk-dev] [PATCH v3] net/i40e: fix intr callback unregister by adding retry

2018-03-14 Thread Rybalchenko, Kirill
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of wangyunjian > Sent: Wednesday 14 March 2018 12:02 > To: dev@dpdk.org > Cc: ca...@huawei.com; Yunjian Wang > Subject: [dpdk-dev] [PATCH v3] net/i40e: fix intr callback unregister by > adding retry > > From: Yunji

Re: [dpdk-dev] [PATCH 1/3] eal/vfio: add support for multiple container

2018-03-14 Thread Burakov, Anatoly
On 09-Mar-18 11:08 PM, Xiao Wang wrote: From: Junjie Chen Currently eal vfio framework binds vfio group fd to the default container fd, while in some cases, e.g. vDPA (vhost data path acceleration), we want to set vfio group to a new container and program DMA mapping via this new container, so

Re: [dpdk-dev] [PATCH 0/2] lib: move Netlink wrapper to lib

2018-03-14 Thread Nélio Laranjeiro
On Tue, Mar 13, 2018 at 02:20:31PM -0700, Stephen Hemminger wrote: > On Tue, 13 Mar 2018 13:28:25 +0100 > Nelio Laranjeiro wrote: > > > TAP PMD uses a wrapper to communicate with Netlink through a socket. This > > wrapper can be useful for other PMD which may need to communicate also with > > th

Re: [dpdk-dev] [PATCH] net/bonding: set MTU on slave configure

2018-03-14 Thread Radu Nicolau
On 2/23/2018 4:01 AM, Chas Williams wrote: From: Chas Williams When a slave is configured make sure that the slave's MTU matches the bonding's idea of the MTU. Signed-off-by: Chas Williams --- Acked-by: Radu Nicolau

Re: [dpdk-dev] [RFC v1 1/1] lib/cryptodev: add support of asymmetric crypto

2018-03-14 Thread Trahe, Fiona
Hi Shally, > -Original Message- > From: Verma, Shally [mailto:shally.ve...@cavium.com] > Sent: Wednesday, March 7, 2018 12:16 PM > To: Trahe, Fiona ; dev@dpdk.org; Athreya, Narayana > Prasad > ; Murthy, Nidadavolu > ; Sahu, > Sunila ; Gupta, Ashish ; > Doherty, Declan > ; Keating, Brian

Re: [dpdk-dev] [PATCH v2 2/3] net/mlx5: fix link status behavior

2018-03-14 Thread Adrien Mazarguil
On Tue, Mar 13, 2018 at 02:54:44PM -0700, Yongseok Koh wrote: > On Mon, Mar 12, 2018 at 02:43:18PM +0100, Nelio Laranjeiro wrote: > > This behavior is mixed between what should be handled by the application > > and what is under PMD responsibility. > > > > According to DPDK API: > > - link_update(

Re: [dpdk-dev] [PATCH v2 2/3] net/mlx5: fix link status behavior

2018-03-14 Thread Nélio Laranjeiro
On Tue, Mar 13, 2018 at 02:54:44PM -0700, Yongseok Koh wrote: > On Mon, Mar 12, 2018 at 02:43:18PM +0100, Nelio Laranjeiro wrote: > > This behavior is mixed between what should be handled by the application > > and what is under PMD responsibility. > > > > According to DPDK API: > > - link_update(

Re: [dpdk-dev] [RFC PATCH v1 1/4] ethdev: add support for PMD-tuned Tx/Rx parameters

2018-03-14 Thread Shreyansh Jain
> -Original Message- > From: Remy Horton [mailto:remy.hor...@intel.com] > Sent: Wednesday, March 7, 2018 5:39 PM > To: dev@dpdk.org > Cc: Wenzhuo Lu ; Jingjing Wu > ; Qi Zhang ; Beilei Xing > ; Shreyansh Jain ; > Thomas Monjalon > Subject: [RFC PATCH v1 1/4] ethdev: add support for PMD-tun

Re: [dpdk-dev] [PATCH v2 1/4] ether: support deferred queue setup

2018-03-14 Thread Ananyev, Konstantin
Hi Qi, > > The patch let etherdev driver expose the capability flag through > rte_eth_dev_info_get when it support deferred queue configuraiton, > then base on the flag rte_eth_[rx|tx]_queue_setup could decide > continue to setup the queue or just return fail when device already > started. > > S

Re: [dpdk-dev] [PATCH v2 4/4] net/i40e: enable deferred queue setup

2018-03-14 Thread Ananyev, Konstantin
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Qi Zhang > Sent: Friday, March 2, 2018 4:13 AM > To: tho...@monjalon.net > Cc: dev@dpdk.org; Xing, Beilei ; Wu, Jingjing > ; Lu, Wenzhuo ; > Zhang, Qi Z > Subject: [dpdk-dev] [PATCH v2 4/4] net/i40e: enable defe

Re: [dpdk-dev] [RFC v4 1/1] lib/compressdev: Adding hash support

2018-03-14 Thread Trahe, Fiona
Hi Shally, Sorry about the delay in responding. Comments below. If you want to push next update to github we can continue dev there. Regards, Fiona > -Original Message- > From: Shally Verma [mailto:shally.ve...@caviumnetworks.com] > Sent: Thursday, February 1, 2018 11:07 AM > To: Trahe,

Re: [dpdk-dev] [PATCH] net/bonding: switch to new offloading flags

2018-03-14 Thread Matan Azrad
Hi Ferruh From: Ferruh Yigit, Sent: Tuesday, March 13, 2018 2:25 PM > Switch from using deprecated bitfields in rxmode to offloads variable. > > Signed-off-by: Ferruh Yigit > --- > drivers/net/bonding/rte_eth_bond_api.c | 3 ++- > drivers/net/bonding/rte_eth_bond_pmd.c | 9 +++-- > 2 files c

Re: [dpdk-dev] [PATCH] compressdev: implement API - mbuf alternative

2018-03-14 Thread Verma, Shally
>-Original Message- >From: Trahe, Fiona [mailto:fiona.tr...@intel.com] >Sent: 13 March 2018 21:22 >To: Verma, Shally ; Ahmed Mansour >; dev@dpdk.org >Cc: De Lara Guarch, Pablo ; Athreya, Narayana >Prasad ; >Gupta, Ashish ; Sahu, Sunila >; Challa, Mahipal >; Jain, Deepak K ; Hemant >Ag

Re: [dpdk-dev] [PATCH v7 5/7] test: add event timer adapter auto-test

2018-03-14 Thread Pavan Nikhilesh
Hi Gabriel, On Thu, Mar 08, 2018 at 03:54:04PM -0600, Erik Gabriel Carrillo wrote: > Signed-off-by: Erik Gabriel Carrillo > --- > test/test/Makefile |1 + > test/test/test_event_timer_adapter.c | 1234 > ++ > 2 files changed, 1235 insertions

Re: [dpdk-dev] [PATCH] net/i40e:fix VSI stats error

2018-03-14 Thread Zhang, Qi Z
> -Original Message- > From: Rybalchenko, Kirill > Sent: Wednesday, March 14, 2018 8:00 PM > To: Wu, Yanglong ; dev@dpdk.org > Cc: Zhang, Qi Z ; Lu, Wenzhuo > ; Wu, Yanglong > Subject: RE: [dpdk-dev] [PATCH] net/i40e:fix VSI stats error > > > > -Original Message- > > From: dev

Re: [dpdk-dev] [PATCH] hash: fix missing spinlock unlock in add key

2018-03-14 Thread De Lara Guarch, Pablo
> -Original Message- > From: Pavan Nikhilesh [mailto:pbhagavat...@caviumnetworks.com] > Sent: Sunday, March 4, 2018 2:59 PM > To: jerin.ja...@caviumnetworks.com; Richardson, Bruce > ; De Lara Guarch, Pablo > > Cc: dev@dpdk.org; Pavan Nikhilesh > ; sta...@dpdk.org > Subject: [dpdk-dev] [P

Re: [dpdk-dev] [PATCH] event/sw: add unlikely branch predict

2018-03-14 Thread Laatz, Kevin
On 27/02/2018 20:08, Vipin Varghese wrote: For most run cases 'sw->started' holds true. Adding a branch prediction suggestion to compiler helps as this is first conditional check just after entering the function. Signed-off-by: Vipin Varghese --- drivers/event/sw/sw_evdev_scheduler.c | 2 +-

[dpdk-dev] [PATCH v2] test/crypto: add MRVL to hash test cases

2018-03-14 Thread Tomasz Duszynski
MRVL Crypto PMD supports most of the hash algorithms covered by test suites thus specific bits should be set in pmd_masks. Otherwise blockcipher authonly test returns success even though no real tests have been executed. Fixes: 84e0ded38ac5 ("test/crypto: add mrvl crypto unit tests") Cc: sta...@d

Re: [dpdk-dev] [PATCH] event/sw: move stats code for better cache access

2018-03-14 Thread Laatz, Kevin
On 27/02/2018 20:17, Vipin Varghese wrote: variables 'out_pkts_total' and 'out_pkts_total' will be in registers. Hence shifting the code after the loop, helps the update from registers. Signed-off-by: Vipin Varghese <...> Acked-by: Kevin Laatz

Re: [dpdk-dev] [PATCH] event/sw: code refractor for counter set

2018-03-14 Thread Laatz, Kevin
On 27/02/2018 21:10, Vipin Varghese wrote: Counter variable 'out_pkts' had been set to 0, then updated. Current code change elimates double assignment to direct assignment. Signed-off-by: Vipin Varghese <...> Acked-by: Kevin Laatz

Re: [dpdk-dev] [PATCH v5] vfio: change to use generic multi-process channel

2018-03-14 Thread Burakov, Anatoly
On 04-Mar-18 2:57 PM, Jianfeng Tan wrote: Previously, vfio uses its own private channel for the secondary process to get container fd and group fd from the primary process. This patch changes to use the generic mp channel. Test: 1. Bind two NICs to vfio-pci. 2. Start the primary and seco

Re: [dpdk-dev] [PATCH 2/3] bus/pci: expose sysfs parsing API

2018-03-14 Thread Gaëtan Rivet
Hi, On Wed, Mar 14, 2018 at 11:19:31AM +, Burakov, Anatoly wrote: > On 09-Mar-18 11:08 PM, Xiao Wang wrote: > > Some existing sysfs parsing functions are helpful for the later vDPA > > driver, this patch make them global and expose them to shared lib. > > > > Signed-off-by: Xiao Wang > > ---

Re: [dpdk-dev] [PATCH v7 5/7] test: add event timer adapter auto-test

2018-03-14 Thread Pavan Nikhilesh
Hi Gabriel, Please make sure that the unit tests are generic, I could see that some places it is verifying whether event port is used or service cores are used, but doesn't verify if actually event port/service core are needed i.e. INTERNAL_PORT capability. On Thu, Mar 08, 2018 at 03:54:04PM -060

Re: [dpdk-dev] [PATCH v3] net/i40e: fix intr callback unregister by adding retry

2018-03-14 Thread Zhang, Qi Z
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Rybalchenko, Kirill > Sent: Wednesday, March 14, 2018 8:08 PM > To: wangyunjian ; dev@dpdk.org > Cc: ca...@huawei.com > Subject: Re: [dpdk-dev] [PATCH v3] net/i40e: fix intr callback unregister by > adding retry >

[dpdk-dev] [PATCH v2 00/11] event/octeontx: add event timer adapter driver

2018-03-14 Thread Pavan Nikhilesh
The event timer adapter[1] provides APIs to configure an event timer device that allows an application to arm timers which on expiry push events to an event device such as OcteonTx SSO. The OcteonTx TIM is a co-processor that can be configured as an event timer adapter which can be used by an appli

[dpdk-dev] [PATCH v2 01/11] mempool/octeontx: probe timvf PCIe devices

2018-03-14 Thread Pavan Nikhilesh
On Octeontx HW, each event timer device is enumerated as separate SRIOV VF PCIe device. In order to expose as a event timer device: On PCIe probe, the driver stores the information associated with the PCIe device and later when appliacation requests for a event timer device through `rte_event_time

[dpdk-dev] [PATCH v2 03/11] event/octeontx: add support to create and free timer adapter

2018-03-14 Thread Pavan Nikhilesh
When the application requests to create a timer device, Octeontx TIM create does the following: - Get the requested TIMvf ring based on adapter_id. - Verify the config parameters supplied. - Allocate memory required for * Buckets based on min and max timeout supplied. * Allocate the chunk pool

[dpdk-dev] [PATCH v2 02/11] usertools: add Cavium TIM as an event device

2018-03-14 Thread Pavan Nikhilesh
Signed-off-by: Pavan Nikhilesh --- usertools/dpdk-devbind.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/usertools/dpdk-devbind.py b/usertools/dpdk-devbind.py index 18d938607..f6cbb2bb7 100755 --- a/usertools/dpdk-devbind.py +++ b/usertools/dpdk-devbind.py @@ -22,10 +22

[dpdk-dev] [PATCH v2 06/11] event/octeontx: add single producer timer arm variant

2018-03-14 Thread Pavan Nikhilesh
When application creates the timer adapter by passing `RTE_EVENT_TIMER_ADAPTER_F_SP_PUT` flag, we can optimize the arm sequence by removing the locking overhead. Signed-off-by: Pavan Nikhilesh --- drivers/event/octeontx/timvf_evdev.c | 15 --- drivers/event/octeontx/timvf_evdev.h | 2

[dpdk-dev] [PATCH v2 04/11] event/octeontx: add support to start and stop timer device

2018-03-14 Thread Pavan Nikhilesh
When application requests to start the timer adapter through `rte_event_timer_adapter_start`, Octeontx TIMvf ring does the following: - Uses mbox to communicate TIMpf driver about, * SCLK frequency used to convert ns<->cycles. * program the ring control parameters and start the ring. * get th

[dpdk-dev] [PATCH v2 05/11] event/octeontx: add multiproducer timer arm and cancel

2018-03-14 Thread Pavan Nikhilesh
Signed-off-by: Pavan Nikhilesh --- drivers/event/octeontx/Makefile | 5 + drivers/event/octeontx/meson.build| 1 + drivers/event/octeontx/timvf_evdev.c | 7 +- drivers/event/octeontx/timvf_evdev.h | 32 drivers/event/octeontx/timvf_worker.c | 59 +++ drivers/event/oct

[dpdk-dev] [PATCH v2 07/11] event/octeontx: add burst mode for timer arm

2018-03-14 Thread Pavan Nikhilesh
Signed-off-by: Pavan Nikhilesh --- drivers/event/octeontx/timvf_evdev.c | 1 + drivers/event/octeontx/timvf_evdev.h | 3 ++ drivers/event/octeontx/timvf_worker.c | 36 + drivers/event/octeontx/timvf_worker.h | 95 +++ 4 files changed, 135 insertions

[dpdk-dev] [PATCH v2 08/11] event/octeontx: optimize timer adapter resolution parameters

2018-03-14 Thread Pavan Nikhilesh
When application sets `RTE_EVENT_TIMER_ADAPTER_F_ADJUST_RES` flag while creating adapter underlying driver is free to optimize the resolution for best possible configuration. Signed-off-by: Pavan Nikhilesh --- drivers/event/octeontx/timvf_evdev.c | 48 +++- driver

[dpdk-dev] [PATCH v2 09/11] event/octeontx: add option to use fpavf as chunk pool

2018-03-14 Thread Pavan Nikhilesh
Add compile-time configurable option to force TIMvf to use Octeontx FPAvf pool manager as its chunk pool. When FPAvf is used as pool manager the TIMvf automatically frees the chunks to FPAvf through gpool-id. Signed-off-by: Pavan Nikhilesh --- drivers/event/octeontx/timvf_evdev.c | 22 +

[dpdk-dev] [PATCH v2 10/11] doc: update eventdev OcteonTx documentation

2018-03-14 Thread Pavan Nikhilesh
Signed-off-by: Pavan Nikhilesh --- doc/guides/eventdevs/octeontx.rst | 9 + 1 file changed, 9 insertions(+) diff --git a/doc/guides/eventdevs/octeontx.rst b/doc/guides/eventdevs/octeontx.rst index 4fabe54f9..f4f5473fd 100644 --- a/doc/guides/eventdevs/octeontx.rst +++ b/doc/guides/event

[dpdk-dev] [PATCH v2 11/11] maintainers: claim responsibility for octeontx timvf

2018-03-14 Thread Pavan Nikhilesh
Signed-off-by: Pavan Nikhilesh --- MAINTAINERS | 4 1 file changed, 4 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index a646ca3e1..4fac167d7 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -737,6 +737,10 @@ M: Santosh Shukla F: drivers/event/octeontx/ F: doc/guides/eventdevs/octeo

Re: [dpdk-dev] [RFC PATCH v1 1/4] ethdev: add support for PMD-tuned Tx/Rx parameters

2018-03-14 Thread Remy Horton
On 14/03/2018 12:28, Shreyansh Jain wrote: [..] + /* Use default specified by driver, if nb_rc_desc is zero */ ^^^ Should be '_rx_' [..] Other than the above; Ok - v2 on the way :) Acked-by

Re: [dpdk-dev] [PATCH v2] net/i40e: fix link_state update for i40e_ethdev_vf drv

2018-03-14 Thread Rybalchenko, Kirill
Hi, > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Tushar Mulkar > Sent: Wednesday 14 February 2018 12:00 > To: Zhang, Helin ; dev@dpdk.org > Cc: Xing, Beilei ; Zhang, Qi Z > Subject: [dpdk-dev] [PATCH v2] net/i40e: fix link_state update for > i40e_ethdev_vf d

Re: [dpdk-dev] [PATCH v1 3/9] mempool: remove callback to get capabilities

2018-03-14 Thread Burakov, Anatoly
On 10-Mar-18 3:39 PM, Andrew Rybchenko wrote: The callback was introduced to let generic code to know octeontx mempool driver requirements to use single physically contiguous memory chunk to store all objects and align object address to total object size. Now these requirements are met using a ne

Re: [dpdk-dev] [RFC PATCH v1 1/4] ethdev: add support for PMD-tuned Tx/Rx parameters

2018-03-14 Thread Ferruh Yigit
On 3/7/2018 12:08 PM, Remy Horton wrote: > The optimal values of several transmission & reception related > parameters, such as burst sizes, descriptor ring sizes, and number > of queues, varies between different network interface devices. This > patch allows individual PMDs to specify preferred pa

Re: [dpdk-dev] Sharing Common libs between PMDs

2018-03-14 Thread Jerin Jacob
-Original Message- > Date: Wed, 14 Mar 2018 09:34:40 + > From: Liron Himi > To: "dev@dpdk.org" > CC: Liron Himi > Subject: [dpdk-dev] Sharing Common libs between PMDs > > Hi, > > We have several PMDs in DPDK that are using the same underlying common > libraries. > In addition, we

Re: [dpdk-dev] Sharing Common libs between PMDs

2018-03-14 Thread Bruce Richardson
On Wed, Mar 14, 2018 at 08:25:45PM +0530, Jerin Jacob wrote: > -Original Message- > > Date: Wed, 14 Mar 2018 09:34:40 + > > From: Liron Himi > > To: "dev@dpdk.org" > > CC: Liron Himi > > Subject: [dpdk-dev] Sharing Common libs between PMDs > > > > Hi, > > > > We have several PMDs i

Re: [dpdk-dev] [PATCH v2] net/mrvl: convert license headers to SPDX tags

2018-03-14 Thread Ferruh Yigit
On 3/12/2018 7:37 AM, Hemant Agrawal wrote: >> -Original Message- >> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Tomasz Duszynski >> Sent: Monday, March 12, 2018 1:02 PM >> To: dev@dpdk.org >> Cc: m...@semihalf.com; d...@marvell.com; nsams...@marvell.com; >> j...@semihalf.com; jian

Re: [dpdk-dev] [RFC PATCH v1 1/4] ethdev: add support for PMD-tuned Tx/Rx parameters

2018-03-14 Thread Shreyansh Jain
> -Original Message- > From: Ferruh Yigit [mailto:ferruh.yi...@intel.com] > Sent: Wednesday, March 14, 2018 8:14 PM > To: Remy Horton ; dev@dpdk.org > Cc: Wenzhuo Lu ; Jingjing Wu > ; Qi Zhang ; Beilei Xing > ; Shreyansh Jain ; > Thomas Monjalon > Subject: Re: [dpdk-dev] [RFC PATCH v1 1/4

Re: [dpdk-dev] [PATCH] net/i40e: remove unnecessary FDIR mask configuration

2018-03-14 Thread Rybalchenko, Kirill
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Beilei Xing > Sent: Sunday 11 February 2018 07:10 > To: Zhang, Qi Z > Cc: dev@dpdk.org > Subject: [dpdk-dev] [PATCH] net/i40e: remove unnecessary FDIR mask > configuration > > Remove unnecessary FDIR mask config

Re: [dpdk-dev] [PATCH 0/2] lib: move Netlink wrapper to lib

2018-03-14 Thread Stephen Hemminger
On Wed, 14 Mar 2018 13:08:55 +0100 Nélio Laranjeiro wrote: > On Tue, Mar 13, 2018 at 02:20:31PM -0700, Stephen Hemminger wrote: > > On Tue, 13 Mar 2018 13:28:25 +0100 > > Nelio Laranjeiro wrote: > > > > > TAP PMD uses a wrapper to communicate with Netlink through a socket. This > > > wrapper

Re: [dpdk-dev] [PATCH] net/mrvl: convert license headers to SPDX tags

2018-03-14 Thread Ferruh Yigit
On 3/14/2018 10:51 AM, De Lara Guarch, Pablo wrote: > > >> -Original Message- >> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Tomasz Duszynski >> Sent: Friday, March 9, 2018 9:40 AM >> To: dev@dpdk.org >> Cc: m...@semihalf.com; d...@marvell.com; nsams...@marvell.com; >> j...@semih

Re: [dpdk-dev] [PATCH] net/i40e: add log when setting input set

2018-03-14 Thread Rybalchenko, Kirill
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Beilei Xing > Sent: Sunday 11 February 2018 06:56 > To: Zhang, Qi Z > Cc: dev@dpdk.org > Subject: [dpdk-dev] [PATCH] net/i40e: add log when setting input set > > This patch adds log when setting input set since

Re: [dpdk-dev] [RFC PATCH v1 1/4] ethdev: add support for PMD-tuned Tx/Rx parameters

2018-03-14 Thread Remy Horton
On 14/03/2018 14:43, Ferruh Yigit wrote: [..] lib/librte_ether/rte_ethdev.c | 18 ++ lib/librte_ether/rte_ethdev.h | 15 +++ Can you please remove deprecation notice in this patch. Done. + /* Defaults for drivers that don't implement preferred +* q

Re: [dpdk-dev] [PATCH v1 0/9] mempool: prepare to add bucket driver

2018-03-14 Thread santosh
Hi Andrew, On Saturday 10 March 2018 09:09 PM, Andrew Rybchenko wrote: [...] > RFCv1 -> RFCv2: > - add driver ops to calculate required memory size and populate > mempool objects, remove extra flags which were required before > to control it > - transition of octeontx and dpaa drive

Re: [dpdk-dev] [PATCH v1 0/9] mempool: prepare to add bucket driver

2018-03-14 Thread Andrew Rybchenko
Hi Santosh, On 03/14/2018 06:49 PM, santosh wrote: Hi Andrew, On Saturday 10 March 2018 09:09 PM, Andrew Rybchenko wrote: [...] RFCv1 -> RFCv2: - add driver ops to calculate required memory size and populate mempool objects, remove extra flags which were required before to cont

Re: [dpdk-dev] Sharing Common libs between PMDs

2018-03-14 Thread Trahe, Fiona
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Bruce Richardson > Sent: Wednesday, March 14, 2018 3:05 PM > To: Jerin Jacob > Cc: Liron Himi ; dev@dpdk.org > Subject: Re: [dpdk-dev] Sharing Common libs between PMDs > > On Wed, Mar 14, 2018 at 08:25:45PM +053

Re: [dpdk-dev] [PATCH v1 3/9] mempool: remove callback to get capabilities

2018-03-14 Thread Andrew Rybchenko
On 03/14/2018 05:40 PM, Burakov, Anatoly wrote: On 10-Mar-18 3:39 PM, Andrew Rybchenko wrote: The callback was introduced to let generic code to know octeontx mempool driver requirements to use single physically contiguous memory chunk to store all objects and align object address to total objec

Re: [dpdk-dev] [RFC PATCH v1 1/4] ethdev: add support for PMD-tuned Tx/Rx parameters

2018-03-14 Thread Ferruh Yigit
On 3/14/2018 3:48 PM, Remy Horton wrote: > > On 14/03/2018 14:43, Ferruh Yigit wrote: > [..] >>> lib/librte_ether/rte_ethdev.c | 18 ++ >>> lib/librte_ether/rte_ethdev.h | 15 +++ >> >> Can you please remove deprecation notice in this patch. > > Done. > >>> + /* Def

Re: [dpdk-dev] [PATCH v1 0/5] add framework to load and execute BPF code

2018-03-14 Thread Alejandro Lucero
I tried to start a discussion about eBPF support with DPDK in last DPDK meeting in Santa Clara: https://dpdksummit.com/Archive/pdf/2017USA/DPDK%20support%20for%20new%20hardware%20offloads.pdf In slide 17 I have some points which, IMHO, are worth to discuss before adding this support. I can see c

Re: [dpdk-dev] [PATCH v1 3/9] mempool: remove callback to get capabilities

2018-03-14 Thread Burakov, Anatoly
On 14-Mar-18 4:12 PM, Andrew Rybchenko wrote: On 03/14/2018 05:40 PM, Burakov, Anatoly wrote: On 10-Mar-18 3:39 PM, Andrew Rybchenko wrote: The callback was introduced to let generic code to know octeontx mempool driver requirements to use single physically contiguous memory chunk to store all

Re: [dpdk-dev] [PATCH 3/5] net/mlx5: use Netlink to add/remove MAC addresses

2018-03-14 Thread Adrien Mazarguil
On Tue, Mar 13, 2018 at 01:50:37PM +0100, Nelio Laranjeiro wrote: > VF devices are not able to receive traffic unless it fully requests it > though Netlink. This will cause the request to be processed by the PF > which will add/remove the MAC address to the VF table if the VF is trusted. > > Sign

Re: [dpdk-dev] [PATCH 2/5] net/mlx5: retrieve device index from Netlink

2018-03-14 Thread Adrien Mazarguil
On Tue, Mar 13, 2018 at 01:50:36PM +0100, Nelio Laranjeiro wrote: > This patch new file is not compiled yet, it starts a series necessary to > fix some issues with VF devices. > > Signed-off-by: Nelio Laranjeiro The fact this new file is not compiled in at this point won't be obvious when runnin

Re: [dpdk-dev] [PATCH 1/5] net/mlx5: add VF information in configuration

2018-03-14 Thread Adrien Mazarguil
On Tue, Mar 13, 2018 at 01:50:35PM +0100, Nelio Laranjeiro wrote: > Signed-off-by: Nelio Laranjeiro Perhaps with a line that states the reason given similar code was dropped by prior patch "net/mlx5: fix sriov flag", for instance: Subsequent patches will need a convenient method to determine if

Re: [dpdk-dev] [PATCH 4/5] net/mlx5: use Netlink to enable promisc/allmulti

2018-03-14 Thread Adrien Mazarguil
On Tue, Mar 13, 2018 at 01:50:38PM +0100, Nelio Laranjeiro wrote: > VF devices are not able to receive promisc or allmulti traffic unless it > fully requests it though Netlink. This will cause the request to be > processed by the PF which will handle the request and enable it. > > This requires t

Re: [dpdk-dev] [PATCH 5/5] net/mlx5: add a parameter for Netlink support in VF

2018-03-14 Thread Adrien Mazarguil
On Tue, Mar 13, 2018 at 01:50:39PM +0100, Nelio Laranjeiro wrote: > All Netlink request the PMD will do can also be done by a iproute2 command > line interface, letting the operator configure the VF behavior without > having to modify the application nor reaching PMD limits (e.g. MAC > address numb

Re: [dpdk-dev] [PATCH v2 6/8] net/mrvl: add extended statistics

2018-03-14 Thread Ferruh Yigit
On 3/12/2018 8:42 AM, Tomasz Duszynski wrote: > Add extended statistics implementation. > > Signed-off-by: Natalie Samsonov > Signed-off-by: Tomasz Duszynski <...> > @@ -1674,6 +1784,94 @@ mrvl_eth_filter_ctrl(struct rte_eth_dev *dev > __rte_unused, > } > } > > +/** > + * DPDK callba

Re: [dpdk-dev] [RFC PATCH v1 1/4] ethdev: add support for PMD-tuned Tx/Rx parameters

2018-03-14 Thread Shreyansh Jain
> -Original Message- > From: Ferruh Yigit [mailto:ferruh.yi...@intel.com] > Sent: Wednesday, March 14, 2018 10:13 PM > To: Remy Horton ; dev@dpdk.org > Cc: Wenzhuo Lu ; Jingjing Wu > ; Qi Zhang ; Beilei Xing > ; Shreyansh Jain ; > Thomas Monjalon > Subject: Re: [dpdk-dev] [RFC PATCH v1 1/4

Re: [dpdk-dev] [PATCH v1 3/9] mempool: remove callback to get capabilities

2018-03-14 Thread Andrew Rybchenko
On 03/14/2018 07:53 PM, Burakov, Anatoly wrote: On 14-Mar-18 4:12 PM, Andrew Rybchenko wrote: On 03/14/2018 05:40 PM, Burakov, Anatoly wrote: On 10-Mar-18 3:39 PM, Andrew Rybchenko wrote: The callback was introduced to let generic code to know octeontx mempool driver requirements to use single

  1   2   >