[dpdk-dev] [PATCH v3 1/7] crypto/virtio: add virtio related fundamental functions

2018-03-25 Thread Jay Zhou
Since there does not have the common virtio library, we have to put these files here. They are basically the same with virtio net related files with some minor changes. Signed-off-by: Jay Zhou --- config/common_base | 20 ++ drivers/crypto/virtio/virtio_logs.h | 47 drive

[dpdk-dev] [PATCH v3 0/7] crypto: add virtio poll mode driver

2018-03-25 Thread Jay Zhou
This patch series introduce virtio crypto poll mode driver. Since it is limited by the vhost crypto backend of the virtio-crypto, this patch series only supports a limited subset of crypto services. Only the following algorithms are tested: Cipher algorithms: - RTE_CRYPTO_CIPHER_AES_CBC (128-bi

[dpdk-dev] [PATCH v3 3/7] cryptodev/virtio: core code of crypto devices

2018-03-25 Thread Jay Zhou
The idea comes from QAT and virtio-net devices. Signed-off-by: Jay Zhou --- drivers/crypto/virtio/virtio_crypto_capabilities.h | 51 + drivers/crypto/virtio/virtio_cryptodev.c | 1553 drivers/crypto/virtio/virtio_cryptodev.h | 66 + drivers/crypto/vir

[dpdk-dev] [PATCH v3 2/7] crpyto/virtio: add crypto related session structure

2018-03-25 Thread Jay Zhou
This structure will be used in the following patches, especially at creating and destroying crypto sessions. Signed-off-by: Jay Zhou --- drivers/crypto/virtio/virtio_crypto_algs.h | 27 +++ 1 file changed, 27 insertions(+) create mode 100644 drivers/crypto/virtio/virtio_

[dpdk-dev] [PATCH v3 5/7] cryptodev: add document for virtio crypto PMD

2018-03-25 Thread Jay Zhou
Signed-off-by: Jay Zhou --- doc/guides/cryptodevs/features/virtio.ini | 22 ++ doc/guides/cryptodevs/virtio.rst | 117 ++ 2 files changed, 139 insertions(+) create mode 100644 doc/guides/cryptodevs/features/virtio.ini create mode 100644 doc/guides/crypt

[dpdk-dev] [PATCH v3 7/7] MAINTAINERS: add myself as virtio crypto PMD maintainer

2018-03-25 Thread Jay Zhou
Signed-off-by: Jay Zhou --- MAINTAINERS | 6 ++ 1 file changed, 6 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index a646ca3..be1b394 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -719,6 +719,12 @@ F: drivers/crypto/snow3g/ F: doc/guides/cryptodevs/snow3g.rst F: doc/guides/cryptode

[dpdk-dev] [PATCH v3 6/7] cryptodev: add function tests for virtio crypto PMD

2018-03-25 Thread Jay Zhou
Only RTE_CRYPTO_CIPHER_AES_CBC cipher algorithms are tested as unit test, it is supported both by the cryptodev-backend-builtin and cryptodev-vhost-user of qemu side. Signed-off-by: Jay Zhou --- test/test/test_cryptodev.c | 49 + test/test/test_crypto

[dpdk-dev] [PATCH v3 4/7] crypto/virtio: add makefile

2018-03-25 Thread Jay Zhou
The virtio crypto PMD driver can be compiled now. Signed-off-by: Jay Zhou --- drivers/crypto/Makefile| 1 + drivers/crypto/virtio/Makefile | 31 ++ .../virtio/rte_pmd_virtio_crypto_version.map | 3 +++ mk/rte.app.mk

Re: [dpdk-dev] [PATCH 0/3] add ifcvf driver

2018-03-25 Thread Maxime Coquelin
On 03/23/2018 11:27 AM, Wang, Xiao W wrote: Hi Maxime, -Original Message- From: Maxime Coquelin [mailto:maxime.coque...@redhat.com] Sent: Thursday, March 22, 2018 4:48 AM To: Wang, Xiao W ; dev@dpdk.org Cc: Wang, Zhihong ; y...@fridaylinux.org; Liang, Cunming ; Xu, Rosen ; Chen, Junji

[dpdk-dev] vmxnet3 RX VLAN Strip offload incorrect behaviour

2018-03-25 Thread Padam Jeet Singh
When configuring the vmxnet3 based ethernet device, the VLAN Strip RX offload does not work as it usually does with other real NICs. When configuring with rxmode.hw_vlan_strip = 1, the ipackets statistic does not increase when a VLAN ether type frame is received on the port and it is also not r

Re: [dpdk-dev] [PATCH v2] net/mlx4: support CRC strip toggling

2018-03-25 Thread Ophir Munk
Hi Adrien, v3 is ready and will be sent soon. Please see inline more comments. > -Original Message- > From: Adrien Mazarguil [mailto:adrien.mazarg...@6wind.com] > Sent: Friday, March 23, 2018 5:53 PM > To: Ophir Munk > Cc: dev@dpdk.org; Thomas Monjalon ; Olga Shern > ; Shahaf Shuler > Su

[dpdk-dev] [PATCH v2 00/11] mempool: prepare to add bucket driver

2018-03-25 Thread Andrew Rybchenko
The patch series should be applied on top of [7]. The initial patch series [1] is split into two to simplify processing. The second series relies on this one and will add bucket mempool driver and related ops. The patch series has generic enhancements suggested by Olivier. Basically it adds drive

[dpdk-dev] [PATCH v2 01/11] mempool: fix memhdr leak when no objects are populated

2018-03-25 Thread Andrew Rybchenko
Fixes: 84121f197187 ("mempool: store memory chunks in a list") Cc: sta...@dpdk.org Suggested-by: Olivier Matz Signed-off-by: Andrew Rybchenko --- v1 -> v2: - added in v2 as discussed in [1] [1] https://dpdk.org/ml/archives/dev/2018-March/093329.html lib/librte_mempool/rte_mempool.c | 10

[dpdk-dev] [PATCH v2 02/11] mempool: rename flag to control IOVA-contiguous objects

2018-03-25 Thread Andrew Rybchenko
Flag MEMPOOL_F_NO_PHYS_CONTIG is renamed as MEMPOOL_F_NO_IOVA_CONTIG to follow IO memory contiguos terminology. MEMPOOL_F_NO_PHYS_CONTIG is kept for backward compatibility and deprecated. Suggested-by: Olivier Matz Signed-off-by: Andrew Rybchenko --- v1 -> v2: - added in v2 as discussed in [1]

[dpdk-dev] [PATCH v2 03/11] mempool: ensure the mempool is initialized before populating

2018-03-25 Thread Andrew Rybchenko
From: "Artem V. Andreev" Callback to calculate required memory area size may require mempool driver data to be already allocated and initialized. Signed-off-by: Artem V. Andreev Signed-off-by: Andrew Rybchenko --- v1 -> v2: - add init check to mempool_ops_alloc_once() - move ealier in the pa

[dpdk-dev] [PATCH v2 07/11] mempool: deprecate xmem functions

2018-03-25 Thread Andrew Rybchenko
Move rte_mempool_xmem_size() code to internal helper function since it is required in two places: deprecated rte_mempool_xmem_size() and non-deprecated rte_mempool_op_calc_mem_size_default(). Suggested-by: Olivier Matz Signed-off-by: Andrew Rybchenko --- v1 -> v2: - deprecate rte_mempool_popula

[dpdk-dev] [PATCH v2 05/11] mempool: add op to populate objects using provided memory

2018-03-25 Thread Andrew Rybchenko
The callback allows to customize how objects are stored in the memory chunk. Default implementation of the callback which simply puts objects one by one is available. Suggested-by: Olivier Matz Signed-off-by: Andrew Rybchenko --- v1 -> v2: - fix memory leak if off is bigger than len RFCv2 -> v

[dpdk-dev] [PATCH v2 04/11] mempool: add op to calculate memory size to be allocated

2018-03-25 Thread Andrew Rybchenko
Size of memory chunk required to populate mempool objects depends on how objects are stored in the memory. Different mempool drivers may have different requirements and a new operation allows to calculate memory size in accordance with driver requirements and advertise requirements on minimum memor

[dpdk-dev] [PATCH v2 11/11] mempool: support flushing the default cache of the mempool

2018-03-25 Thread Andrew Rybchenko
From: "Artem V. Andreev" Mempool get/put API cares about cache itself, but sometimes it is required to flush the cache explicitly. The function is moved in the file since it now requires rte_mempool_default_cache(). Signed-off-by: Artem V. Andreev Signed-off-by: Andrew Rybchenko --- v1 -> v2:

[dpdk-dev] [PATCH v2 09/11] mempool/dpaa: prepare to remove register memory area op

2018-03-25 Thread Andrew Rybchenko
Populate mempool driver callback is executed a bit later than register memory area, provides the same information and will substitute the later since it gives more flexibility and in addition to notification about memory area allows to customize how mempool objects are stored in memory. Signed-off

[dpdk-dev] [PATCH v2 10/11] mempool: remove callback to register memory area

2018-03-25 Thread Andrew Rybchenko
The callback is not required any more since there is a new callback to populate objects using provided memory area which provides the same information. Signed-off-by: Andrew Rybchenko --- v1 -> v2: - none RFCv2 -> v1: - advertise ABI changes in release notes doc/guides/rel_notes/deprecation.

[dpdk-dev] [PATCH v2 08/11] mempool/octeontx: prepare to remove register memory area op

2018-03-25 Thread Andrew Rybchenko
Callback to populate pool objects has all required information and executed a bit later than register memory area callback. Signed-off-by: Andrew Rybchenko --- v1 -> v2 - none drivers/mempool/octeontx/rte_mempool_octeontx.c | 25 ++--- 1 file changed, 10 insertions(+), 15 d

[dpdk-dev] [PATCH v2 06/11] mempool: remove callback to get capabilities

2018-03-25 Thread Andrew Rybchenko
The callback was introduced to let generic code to know octeontx mempool driver requirements to use single physically contiguous memory chunk to store all objects and align object address to total object size. Now these requirements are met using a new callbacks to calculate required memory chunk s

Re: [dpdk-dev] [PATCH v2 1/2] Add RIB library

2018-03-25 Thread Vladimir Medvedkin
Hi, 2018-03-14 14:09 GMT+03:00 Bruce Richardson : > On Wed, Feb 21, 2018 at 09:44:54PM +, Medvedkin Vladimir wrote: > > RIB is an alternative to current LPM library. > > It solves the following problems > > - Increases the speed of control plane operations against lpm such as > >adding/d

Re: [dpdk-dev] i40e mbuf->rss indication

2018-03-25 Thread Chilikin, Andrey
Hi Hanoh, Could you please explain what do you mean by *wrong hash value*? i40e calculates hash value for TCP/UDP using 4-tuple: L3 source/destination addresses and L4 source/destination ports. It does not use IP protocol, as TCP and UDP already separated to different PCTYPEs at HW level. Could

Re: [dpdk-dev] [PATCH v3 1/2] Add RIB library

2018-03-25 Thread Vladimir Medvedkin
2018-03-15 17:27 GMT+03:00 Bruce Richardson : > On Thu, Feb 22, 2018 at 10:50:55PM +, Medvedkin Vladimir wrote: > > RIB is an alternative to current LPM library. > > It solves the following problems > > - Increases the speed of control plane operations against lpm such as > >adding/deleti

[dpdk-dev] [PATCH] net/bnxt: convert to SPDX license tag

2018-03-25 Thread Ajit Khaparde
From: Scott Branden Update the license header on bnxt files to be the standard BSD-3-Clause license used for the rest of DPDK, bring the files in compliance with the DPDK licensing policy. Signed-off-by: Scott Branden Signed-off-by: Ajit Khaparde --- doc/guides/nics/bnxt.rst | 3

Re: [dpdk-dev] [PATCH v3 3/3] net/i40e: enable runtime queue setup

2018-03-25 Thread Ananyev, Konstantin
Hi Qi, > > Expose the runtime queue configuration capability and enhance > i40e_dev_[rx|tx]_queue_setup to handle the situation when > device already started. > > Signed-off-by: Qi Zhang > --- > v3: > - no queue start/stop in setup/release > - return fail when required rx/tx function conflict w

Re: [dpdk-dev] [PATCH v3 1/3] ether: support runtime queue setup

2018-03-25 Thread Ananyev, Konstantin
> -Original Message- > From: Zhang, Qi Z > Sent: Wednesday, March 21, 2018 7:28 AM > To: tho...@monjalon.net; Ananyev, Konstantin > Cc: dev@dpdk.org; Xing, Beilei ; Wu, Jingjing > ; Lu, Wenzhuo ; > Zhang, Qi Z > Subject: [PATCH v3 1/3] ether: support runtime queue setup > > The patch

[dpdk-dev] [PATCH v3] net/mlx4: support CRC strip toggling

2018-03-25 Thread Ophir Munk
Previous to this commit mlx4 CRC stripping was executed by default and there was no verbs API to disable it. Signed-off-by: Ophir Munk --- v1: initial version v2: following internal reviews v3: following dpdk.org mailing list reviews drivers/net/mlx4/mlx4.c | 6 +- drivers/net/mlx4/ml

Re: [dpdk-dev] i40e mbuf->rss indication

2018-03-25 Thread Hanoch Haim (hhaim)
Hi Andrey, The ML specification is clear. The key is defined and work the same for all driver. My point is that the RSS result (Rx-queue) is *correct* but the 32bit intermediate hash value that is reported in the descriptor is not correct. The hash value reside in the first 16B. I can send how

[dpdk-dev] [PATCH v3] net/i40e: fix flow RSS configuration error

2018-03-25 Thread Wei Zhao
I40e need a protection for rss rule flow configuration after one rule is set for a port. Fixes: ecad87d22383 ("net/i40e: move RSS to flow API") Signed-off-by: Wei Zhao Tested-by: Peng Yuan --- Changes in v2: change fixes version number. Changes in v3: change ret default number. --- drivers

Re: [dpdk-dev] [PATCH] net/e1000: fix flow RSS queue index error

2018-03-25 Thread Lu, Wenzhuo
Hi, > -Original Message- > From: Zhao1, Wei > Sent: Wednesday, March 21, 2018 3:18 PM > To: dev@dpdk.org > Cc: Lu, Wenzhuo ; Zhao1, Wei > > Subject: [PATCH] net/e1000: fix flow RSS queue index error > > Igb has a bug about queue index for rss rule flow configuration when set > redirectio

Re: [dpdk-dev] [PATCH 08/17] net/virtio: implement receive path for packed queues

2018-03-25 Thread Jason Wang
On 2018年03月16日 23:21, Jens Freimann wrote: From: Yuanhan Liu Implement the receive part here. No support for mergeable buffers yet. Signed-off-by: Jens Freimann Signed-off-by: Yuanhan Liu --- drivers/net/virtio/virtio_ethdev.c | 5 +- drivers/net/virtio/virtio_ethdev.h | 2 + drive

Re: [dpdk-dev] [PATCH 07/17] net/virtio: implement transmit path for packed queues

2018-03-25 Thread Jason Wang
On 2018年03月16日 23:21, Jens Freimann wrote: This implements the transmit path for devices with support for Virtio 1.1. Add the feature bit for Virtio 1.1 and enable code to add buffers to vring and mark descriptors as available. This is based on a patch by Yuanhan Liu. Signed-off-by: Jens Fre

Re: [dpdk-dev] [PATCH] net/i40e: remove unnecessary FDIR mask configuration

2018-03-25 Thread Zhang, Qi Z
> -Original Message- > From: Rybalchenko, Kirill > Sent: Wednesday, March 14, 2018 11:17 PM > To: Xing, Beilei ; Zhang, Qi Z > Cc: dev@dpdk.org > Subject: RE: [dpdk-dev] [PATCH] net/i40e: remove unnecessary FDIR mask > configuration > > > > > -Original Message- > > From: dev [

[dpdk-dev] [PATCH v2] net/bnxt: fix flow director with same cmd different queue

2018-03-25 Thread Somnath Kotur
When user reissues same flow director cmd with a different queue update the existing filter to redirect flow to the new desired queue as destination just like the other filters like 5 tuple and generic flow. Fixes: 2d64da097aa0 ("net/bnxt: support FDIR") Cc: ajit.khapa...@broadcom.com Signed-off-

Re: [dpdk-dev] [PATCH v3] net/i40e: fix flow RSS configuration error

2018-03-25 Thread Zhang, Qi Z
> -Original Message- > From: Zhao1, Wei > Sent: Monday, March 26, 2018 9:12 AM > To: dev@dpdk.org > Cc: Zhang, Qi Z ; Zhao1, Wei > Subject: [PATCH v3] net/i40e: fix flow RSS configuration error > > I40e need a protection for rss rule flow configuration after one rule is set > for a > por

Re: [dpdk-dev] [PATCH v3 1/7] crypto/virtio: add virtio related fundamental functions

2018-03-25 Thread Zhang, Roy Fan
> -Original Message- > From: Jay Zhou [mailto:jianjay.z...@huawei.com] > Sent: Sunday, March 25, 2018 9:34 AM > To: dev@dpdk.org > Cc: De Lara Guarch, Pablo ; Zhang, Roy Fan > ; tho...@monjalon.net; > arei.gong...@huawei.com; Zeng, Xin ; > weidong.hu...@huawei.com; wangxinxin.w...@huawei.

Re: [dpdk-dev] [PATCH v3 3/7] cryptodev/virtio: core code of crypto devices

2018-03-25 Thread Zhang, Roy Fan
> -Original Message- > From: Jay Zhou [mailto:jianjay.z...@huawei.com] > Sent: Sunday, March 25, 2018 9:34 AM > To: dev@dpdk.org > Cc: De Lara Guarch, Pablo ; Zhang, Roy Fan > ; tho...@monjalon.net; > arei.gong...@huawei.com; Zeng, Xin ; > weidong.hu...@huawei.com; wangxinxin.w...@huawei.

Re: [dpdk-dev] [PATCH v3 6/7] cryptodev: add function tests for virtio crypto PMD

2018-03-25 Thread Zhang, Roy Fan
> -Original Message- > From: Jay Zhou [mailto:jianjay.z...@huawei.com] > Sent: Sunday, March 25, 2018 9:34 AM > To: dev@dpdk.org > Cc: De Lara Guarch, Pablo ; Zhang, Roy Fan > ; tho...@monjalon.net; > arei.gong...@huawei.com; Zeng, Xin ; > weidong.hu...@huawei.com; wangxinxin.w...@huawei.

Re: [dpdk-dev] [PATCH v3 4/7] crypto/virtio: add makefile

2018-03-25 Thread Zhang, Roy Fan
> -Original Message- > From: Jay Zhou [mailto:jianjay.z...@huawei.com] > Sent: Sunday, March 25, 2018 9:34 AM > To: dev@dpdk.org > Cc: De Lara Guarch, Pablo ; Zhang, Roy Fan > ; tho...@monjalon.net; > arei.gong...@huawei.com; Zeng, Xin ; > weidong.hu...@huawei.com; wangxinxin.w...@huawei.

Re: [dpdk-dev] [PATCH v3 5/7] cryptodev: add document for virtio crypto PMD

2018-03-25 Thread Zhang, Roy Fan
> -Original Message- > From: Jay Zhou [mailto:jianjay.z...@huawei.com] > Sent: Sunday, March 25, 2018 9:34 AM > To: dev@dpdk.org > Cc: De Lara Guarch, Pablo ; Zhang, Roy Fan > ; tho...@monjalon.net; > arei.gong...@huawei.com; Zeng, Xin ; > weidong.hu...@huawei.com; wangxinxin.w...@huawei.

Re: [dpdk-dev] [PATCH v3 2/7] crpyto/virtio: add crypto related session structure

2018-03-25 Thread Zhang, Roy Fan
> -Original Message- > From: Jay Zhou [mailto:jianjay.z...@huawei.com] > Sent: Sunday, March 25, 2018 9:34 AM > To: dev@dpdk.org > Cc: De Lara Guarch, Pablo ; Zhang, Roy Fan > ; tho...@monjalon.net; > arei.gong...@huawei.com; Zeng, Xin ; > weidong.hu...@huawei.com; wangxinxin.w...@huawei.