Re: [dpdk-dev] [PATCH] net/bnxt: convert to SPDX license tag

2018-03-26 Thread Hemant Agrawal
Hi Scott, > On 18-03-26 12:28 AM, Hemant Agrawal wrote: > > Hi Ajit/Scott, > > > > > > On 3/26/2018 12:37 AM, Ajit Khaparde wrote: > >> From: Scott Branden > >> > >> Update the license header on bnxt files to be the standard > >> BSD-3-Clause license used for the rest of DPDK, bring the files in

Re: [dpdk-dev] [PATCH 1/2] net/mlx5: enforce RSS key length limitation

2018-03-26 Thread Shahaf Shuler
Monday, March 26, 2018 2:18 PM, Nélio Laranjeiro: > On Mon, Mar 26, 2018 at 01:12:18PM +0300, Shahaf Shuler wrote: > > @@ -48,6 +48,13 @@ mlx5_rss_hash_update(struct rte_eth_dev *dev, > > return -rte_errno; > > } > > if (rss_conf->rss_key && rss_conf->rss_key_len) { > > +

Re: [dpdk-dev] [PATCH 0/3] add ifcvf driver

2018-03-26 Thread Maxime Coquelin
Hi Xiao, On 03/27/2018 06:40 AM, Wang, Xiao W wrote: Hi Maxime, -Original Message- From: Maxime Coquelin [mailto:maxime.coque...@redhat.com] Sent: Monday, March 26, 2018 9:30 PM To: Wang, Xiao W ; dev@dpdk.org Cc: Wang, Zhihong ; y...@fridaylinux.org; Liang, Cunming ; Xu, Rosen ; Chen,

Re: [dpdk-dev] [PATCH 0/3] add ifcvf driver

2018-03-26 Thread Wang, Xiao W
Hi Maxime, > -Original Message- > From: Maxime Coquelin [mailto:maxime.coque...@redhat.com] > Sent: Monday, March 26, 2018 9:30 PM > To: Wang, Xiao W ; dev@dpdk.org > Cc: Wang, Zhihong ; y...@fridaylinux.org; Liang, > Cunming ; Xu, Rosen ; Chen, > Junjie J ; Daly, Dan > Subject: Re: [PATC

Re: [dpdk-dev] [PATCH] pdump: change to use generic multi-process channel

2018-03-26 Thread Tan, Jianfeng
> -Original Message- > From: Pattan, Reshma > Sent: Wednesday, March 21, 2018 5:55 PM > To: Tan, Jianfeng; dev@dpdk.org > Subject: RE: [PATCH] pdump: change to use generic multi-process channel > > Hi, > > > -Original Message- > > From: Tan, Jianfeng > > Sent: Wednesday, March 2

Re: [dpdk-dev] [PATCH] vhost: avoid concurrency when logging dirty pages

2018-03-26 Thread Tan, Jianfeng
> -Original Message- > From: Maxime Coquelin [mailto:maxime.coque...@redhat.com] > Sent: Wednesday, March 21, 2018 11:44 PM > To: dev@dpdk.org; Tan, Jianfeng; Bie, Tiwei; jfreim...@redhat.com > Cc: sta...@dpdk.org; Maxime Coquelin > Subject: [PATCH] vhost: avoid concurrency when logging d

[dpdk-dev] [PATCH v3 19/20] ethdev: add device matching field name

2018-03-26 Thread Gaetan Rivet
The eth device class can now parse a field name, matching the eth_dev name with one passed as "class=eth,name=xx" Signed-off-by: Gaetan Rivet --- lib/librte_ether/rte_class_eth.c | 18 -- 1 file changed, 16 insertions(+), 2 deletions(-) diff --git a/lib/librte_ether/rte_

[dpdk-dev] [PATCH v3 20/20] app/testpmd: add show device command

2018-03-26 Thread Gaetan Rivet
A new interactive command is offered: show device This commands lists all rte_device element matching the device description. e.g.: show device bus=pci show device bus=vdev show device bus=vdev/class=eth show device bus=vdev,driver=net_ring/class=eth show device bus=vdev/class

[dpdk-dev] [PATCH v3 18/20] ethdev: register ether layer as a class

2018-03-26 Thread Gaetan Rivet
Signed-off-by: Gaetan Rivet --- lib/Makefile | 2 +- lib/librte_ether/Makefile| 3 +- lib/librte_ether/rte_class_eth.c | 65 3 files changed, 68 insertions(+), 2 deletions(-) create mode 100644 lib/librte_ether/rte_class_eth.

[dpdk-dev] [PATCH v3 13/20] bus/pci: implement device iteration and comparison

2018-03-26 Thread Gaetan Rivet
Signed-off-by: Gaetan Rivet --- drivers/bus/pci/Makefile | 2 +- drivers/bus/pci/pci_common.c | 34 ++ 2 files changed, 35 insertions(+), 1 deletion(-) diff --git a/drivers/bus/pci/Makefile b/drivers/bus/pci/Makefile index f3df1c4ce..73498dc77 100644 --- a/dr

[dpdk-dev] [PATCH v3 15/20] bus/vdev: fix find device implementation

2018-03-26 Thread Gaetan Rivet
If start is set and a device before it matches the data, this device is returned. This induces potentially infinite loops. Fixes: c7fe1eea8a74 ("bus: simplify finding starting point") Cc: sta...@dpdk.org Signed-off-by: Gaetan Rivet --- drivers/bus/vdev/rte_bus_vdev.h | 3 +++ drivers/bus/vdev

[dpdk-dev] [PATCH v3 17/20] bus/vdev: add device matching field driver

2018-03-26 Thread Gaetan Rivet
The vdev bus parses a field "driver", matching a vdev driver name with one passed as follows: "bus=vdev,driver=" Signed-off-by: Gaetan Rivet --- drivers/bus/vdev/vdev.c | 22 -- 1 file changed, 20 insertions(+), 2 deletions(-) diff --git a/drivers/bus/vdev/vdev.c b/d

[dpdk-dev] [PATCH v3 14/20] bus/pci: add device matching field id

2018-03-26 Thread Gaetan Rivet
The PCI bus can now parse a matching field "id" as follows: "bus=pci,id=:00:00.0" or "bus=pci,id=00:00.0" Signed-off-by: Gaetan Rivet --- drivers/bus/pci/pci_common.c | 26 -- 1 file changed, 24 insertions(+), 2 deletions(-) diff --git a/drivers/b

[dpdk-dev] [PATCH v3 16/20] bus/vdev: implement device iteration

2018-03-26 Thread Gaetan Rivet
Signed-off-by: Gaetan Rivet --- drivers/bus/vdev/Makefile | 2 +- drivers/bus/vdev/vdev.c | 34 ++ 2 files changed, 35 insertions(+), 1 deletion(-) diff --git a/drivers/bus/vdev/Makefile b/drivers/bus/vdev/Makefile index 24d424a38..52728833c 100644 --- a/driver

[dpdk-dev] [PATCH v3 09/20] eal/bus: add device iteration

2018-03-26 Thread Gaetan Rivet
Signed-off-by: Gaetan Rivet --- lib/librte_eal/common/include/rte_bus.h | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/librte_eal/common/include/rte_bus.h b/lib/librte_eal/common/include/rte_bus.h index eb9eded4e..747baf140 100644 --- a/lib/librte_eal/common/include/rte_bus.h +++ b/lib/

[dpdk-dev] [PATCH v3 12/20] bus/pci: fix find device implementation

2018-03-26 Thread Gaetan Rivet
If start is set, and a device before it matches the data passed for comparison, then this first device is returned. This induces potentially infinite loops. Fixes: c7fe1eea8a74 ("bus: simplify finding starting point") Cc: sta...@dpdk.org Signed-off-by: Gaetan Rivet --- drivers/bus/pci/pci_comm

[dpdk-dev] [PATCH v3 11/20] eal/dev: implement device iteration

2018-03-26 Thread Gaetan Rivet
Use the iteration hooks in the abstraction layers to perform the requested filtering on the internal device lists. Signed-off-by: Gaetan Rivet --- lib/librte_eal/common/eal_common_dev.c | 170 lib/librte_eal/common/include/rte_dev.h | 25 + lib/librte_eal/r

[dpdk-dev] [PATCH v3 10/20] eal/dev: implement device iteration initialization

2018-03-26 Thread Gaetan Rivet
Parse a device description. Split this description in their relevant part for each layers. No dynamic allocation is performed. Cc: Neil Horman Cc: "Wiles, Keith" Signed-off-by: Gaetan Rivet --- This version uses librte_kvargs. lib/Makefile| 1 + lib/librte_eal/b

[dpdk-dev] [PATCH v3 08/20] eal/class: add device iteration

2018-03-26 Thread Gaetan Rivet
Signed-off-by: Gaetan Rivet --- lib/librte_eal/common/include/rte_class.h | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/librte_eal/common/include/rte_class.h b/lib/librte_eal/common/include/rte_class.h index 95107d937..6cce99925 100644 --- a/lib/librte_eal/common/include/rte_class.h ++

[dpdk-dev] [PATCH v3 07/20] eal/dev: add device iterator interface

2018-03-26 Thread Gaetan Rivet
A device iterator allows iterating over a set of devices. This set is defined by the two descriptions offered, * rte_bus * rte_class Only one description can be provided, or both. It is not allowed to provide no description at all. Each layer of abstraction then performs a filter based on th

[dpdk-dev] [PATCH v3 06/20] eal/class: register destructor

2018-03-26 Thread Gaetan Rivet
Signed-off-by: Gaetan Rivet --- lib/librte_eal/common/include/rte_class.h | 5 + 1 file changed, 5 insertions(+) diff --git a/lib/librte_eal/common/include/rte_class.h b/lib/librte_eal/common/include/rte_class.h index 59b578e3e..95107d937 100644 --- a/lib/librte_eal/common/include/rte_class

[dpdk-dev] [PATCH v3 05/20] eal: introduce device class abstraction

2018-03-26 Thread Gaetan Rivet
Signed-off-by: Gaetan Rivet --- lib/librte_eal/bsdapp/eal/Makefile | 1 + lib/librte_eal/common/Makefile | 2 +- lib/librte_eal/common/eal_common_class.c | 62 +++ lib/librte_eal/common/include/rte_class.h | 121 + lib/librte_eal

[dpdk-dev] [PATCH v3 04/20] eal: introduce dtor macros

2018-03-26 Thread Gaetan Rivet
Signed-off-by: Gaetan Rivet --- lib/librte_eal/common/include/rte_common.h | 23 +++ 1 file changed, 23 insertions(+) diff --git a/lib/librte_eal/common/include/rte_common.h b/lib/librte_eal/common/include/rte_common.h index 99a799d6d..bdccc2553 100644 --- a/lib/librte_eal/c

[dpdk-dev] [PATCH v3 02/20] kvargs: build before EAL

2018-03-26 Thread Gaetan Rivet
Signed-off-by: Gaetan Rivet --- lib/Makefile | 3 +-- lib/librte_eal/common/Makefile| 2 +- lib/librte_kvargs/Makefile| 2 +- lib/librte_kvargs/rte_kvargs.c

[dpdk-dev] [PATCH v3 01/20] kvargs: remove rte log dependency

2018-03-26 Thread Gaetan Rivet
Signed-off-by: Gaetan Rivet --- lib/librte_kvargs/rte_kvargs.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/lib/librte_kvargs/rte_kvargs.c b/lib/librte_kvargs/rte_kvargs.c index 9662375e8..d6b187aac 100644 --- a/lib/librte_kvargs/rte_kvargs.c +++ b/lib/librte_kva

[dpdk-dev] [PATCH v3 00/20] Device querying

2018-03-26 Thread Gaetan Rivet
This patchset introduces a new EAL API for querying devices, filtered by arbitrary properties. The following elements are introduced to this end: * A new object, "rte_class", is used to describe the device class abstraction layer (eth, crypto, ...). * Both rte_bus and rte_class now offer a

[dpdk-dev] [PATCH v3 03/20] eal: list acceptable init priorities

2018-03-26 Thread Gaetan Rivet
Build a central list to quickly see each used priorities for constructors, allowing to verify that they are both above 100 and in the proper order. Signed-off-by: Gaetan Rivet Acked-by: Neil Horman --- lib/librte_eal/common/eal_common_log.c | 2 +- lib/librte_eal/common/include/rte_bus.h

[dpdk-dev] [PATCH v2] net/bnxt: switch to the new offload API

2018-03-26 Thread Ajit Khaparde
Update bnxt PMD to new ethdev offloads API. Signed-off-by: Ajit Khaparde --- v1->v2: return an error if requested offload flags do not match supported offload capabilities. --- drivers/net/bnxt/bnxt_ethdev.c | 63 ++ 1 file changed, 45 insertions(+), 18 de

Re: [dpdk-dev] [PATCH v4 2/2] event/sw: support device stop flush callback

2018-03-26 Thread Eads, Gage
> -Original Message- > From: Van Haaren, Harry > Sent: Friday, March 23, 2018 12:06 PM > To: Eads, Gage ; dev@dpdk.org > Cc: jerin.ja...@caviumnetworks.com; hemant.agra...@nxp.com; Richardson, > Bruce ; santosh.shu...@caviumnetworks.com; > nipun.gu...@nxp.com > Subject: RE: [PATCH v4 2/2]

Re: [dpdk-dev] [PATCH v4 1/2] eventdev: add device stop flush callback

2018-03-26 Thread Eads, Gage
> -Original Message- > From: Van Haaren, Harry > Sent: Friday, March 23, 2018 11:57 AM > To: Eads, Gage ; dev@dpdk.org > Cc: jerin.ja...@caviumnetworks.com; hemant.agra...@nxp.com; Richardson, > Bruce ; santosh.shu...@caviumnetworks.com; > nipun.gu...@nxp.com > Subject: RE: [PATCH v4 1/2]

Re: [dpdk-dev] [PATCH 00/13] cxgbe: add CXGBE VF PMD and updates

2018-03-26 Thread Ferruh Yigit
On 3/10/2018 10:48 PM, Rahul Lakkireddy wrote: > Patches 1 - 9 add support for cxgbe VF driver. Patches 10 - 12 fix > bugs and convert license in cxgbe files to SPDX License Tag. Patch > 13 adds compile time option to keep outer vlan tag in Q-in-Q packet. > > Patch 1 adds minimal cxgbe VF driver

[dpdk-dev] [PATCH v2] igb_uio: bind error if pcie bridge

2018-03-26 Thread Ajit Khaparde
From: Darren Edamura Probe function should exit immediately if pcie bridge detected Signed-off-by: Darren Edamura Signed-off-by: Rahul Gupta Signed-off-by: Scott Branden Signed-off-by: Ajit Khaparde --- v1->v2: add a log message if the condition is true. --- lib/librte_eal/linuxapp/igb_uio/

Re: [dpdk-dev] [dpdk-stable] [PATCH] net/bnxt: fix an erorr with vnic_tpa_cfg command

2018-03-26 Thread Ferruh Yigit
On 2/28/2018 10:12 PM, Ajit Khaparde wrote: > When the vnic_tpa_cfg HWRM command is sent to the FW, > we are not passing the VNIC ID in case of disable. > This can cause the FW to return an error. > Correct VNIC ID needs to be passed for both enable and disable. > > Fixes: 0958d8b6435d ("net/bnxt:

Re: [dpdk-dev] [PATCH v4] ethdev: fix port id storage

2018-03-26 Thread Ferruh Yigit
On 3/9/2018 12:58 PM, Thomas Monjalon wrote: > 09/03/2018 12:27, Ferruh Yigit: >> port_id is now 16bits, update function parameter according. >> >> Fixes: 4c270218aa26 ("ethdev: support security APIs") >> Cc: sta...@dpdk.org >> Cc: declan.dohe...@intel.com >> >> Signed-off-by: Ferruh Yigit >> Acke

Re: [dpdk-dev] [dpdk-stable] [PATCH] net/bnxt: fix an erorr with vnic_tpa_cfg command

2018-03-26 Thread Ajit Khaparde
On Mon, Mar 26, 2018 at 1:20 PM, Ferruh Yigit wrote: > On 2/28/2018 10:12 PM, Ajit Khaparde wrote: > > When the vnic_tpa_cfg HWRM command is sent to the FW, > > we are not passing the VNIC ID in case of disable. > > This can cause the FW to return an error. > > Correct VNIC ID needs to be passed

Re: [dpdk-dev] [dpdk-stable] [PATCH] net/bnxt: fix an erorr with vnic_tpa_cfg command

2018-03-26 Thread Ferruh Yigit
On 2/28/2018 10:12 PM, Ajit Khaparde wrote: > When the vnic_tpa_cfg HWRM command is sent to the FW, > we are not passing the VNIC ID in case of disable. > This can cause the FW to return an error. > Correct VNIC ID needs to be passed for both enable and disable. Hi Ajit, Patch title doesn't tell

Re: [dpdk-dev] [PATCH 4/4] igb_uio: bind error if pcie bridge

2018-03-26 Thread Scott Branden
On 18-03-26 11:20 AM, Ferruh Yigit wrote: On 3/26/2018 7:05 PM, Scott Branden wrote: Hi Ferruh, On 18-03-26 10:24 AM, Ferruh Yigit wrote: On 3/21/2018 6:06 PM, Ajit Khaparde wrote: From: Darren Edamura Probe function should exit immediately if pcie bridge detected Signed-off-by: Darren

Re: [dpdk-dev] [PATCH] ethdev: return diagnostic when setting MAC address

2018-03-26 Thread Ferruh Yigit
On 2/27/2018 3:11 PM, Olivier Matz wrote: > Change the prototype and the behavior of dev_ops->eth_mac_addr_set(): a > return code is added to notify the caller (librte_ether) if an error > occurred in the PMD. > > The new default MAC address is now copied in dev->data->mac_addrs[0] > only if the o

Re: [dpdk-dev] [PATCH V2] igb_uio: fix uevent montior issue

2018-03-26 Thread Ferruh Yigit
On 2/27/2018 7:20 AM, Jeff Guo wrote: > udev could not detect remove and add event of device when hotplug in > and out devices, that related with the fix about using pointer of > rte_uio_pci_dev as dev_id instead of uio_device for irq device handler, > that would result igb uio irq failure when ker

Re: [dpdk-dev] [PATCH 4/4] igb_uio: bind error if pcie bridge

2018-03-26 Thread Ferruh Yigit
On 3/26/2018 7:05 PM, Scott Branden wrote: > Hi Ferruh, > > > On 18-03-26 10:24 AM, Ferruh Yigit wrote: >> On 3/21/2018 6:06 PM, Ajit Khaparde wrote: >>> From: Darren Edamura >>> >>> Probe function should exit immediately if pcie bridge detected >>> >>> Signed-off-by: Darren Edamura >>> Signed-

Re: [dpdk-dev] [PATCH v2] net/mlx5: setup RSS regardless of queue count

2018-03-26 Thread Legacy, Allain
> -Original Message- > From: Yongseok Koh [mailto:ys...@mellanox.com] > Sent: Thursday, March 22, 2018 7:38 PM <..> > > > > Signed-off-by: Allain Legacy > > Signed-off-by: Nelio Laranjeiro > > --- > > Dahir, Allain > > Did you get a chance to test this patch? It would be good to have '

Re: [dpdk-dev] [PATCH 4/4] igb_uio: bind error if pcie bridge

2018-03-26 Thread Scott Branden
Hi Ferruh, On 18-03-26 10:24 AM, Ferruh Yigit wrote: On 3/21/2018 6:06 PM, Ajit Khaparde wrote: From: Darren Edamura Probe function should exit immediately if pcie bridge detected Signed-off-by: Darren Edamura Signed-off-by: Rahul Gupta Signed-off-by: Scott Branden Signed-off-by: Ajit Kh

Re: [dpdk-dev] [PATCH 4/4] igb_uio: bind error if pcie bridge

2018-03-26 Thread Ferruh Yigit
On 3/21/2018 6:06 PM, Ajit Khaparde wrote: > From: Darren Edamura > > Probe function should exit immediately if pcie bridge detected > > Signed-off-by: Darren Edamura > Signed-off-by: Rahul Gupta > Signed-off-by: Scott Branden > Signed-off-by: Ajit Khaparde > --- > lib/librte_eal/linuxapp/i

Re: [dpdk-dev] [PATCH] kni: optimize the kni release speed

2018-03-26 Thread Ferruh Yigit
On 2/6/2018 10:33 AM, zhouyangchao wrote: > Physical addresses in the fifo named alloc_q need to be traversed to > release in user space. The physical address to the virtual address > conversion in kernel space is much better. Yes current approach should be slower but this is not in data path, thi

[dpdk-dev] [PATCH v1 3/6] mempool: support block dequeue operation

2018-03-26 Thread Andrew Rybchenko
From: "Artem V. Andreev" If mempool manager supports object blocks (physically and virtual contiguous set of objects), it is sufficient to get the first object only and the function allows to avoid filling in of information about each block member. Signed-off-by: Artem V. Andreev Signed-off-by:

[dpdk-dev] [PATCH v1 1/6] mempool/bucket: implement bucket mempool manager

2018-03-26 Thread Andrew Rybchenko
From: "Artem V. Andreev" The manager provides a way to allocate physically and virtually contiguous set of objects. Signed-off-by: Artem V. Andreev Signed-off-by: Andrew Rybchenko --- MAINTAINERS| 9 + config/common_base

[dpdk-dev] [PATCH v1 0/6] mempool: add bucket driver

2018-03-26 Thread Andrew Rybchenko
The initial patch series [1] (RFCv1 is [2]) is split into two to simplify processing. It is the second part which relies on the first one [3]. It should be applied on top of [4] and [3]. The patch series adds bucket mempool driver which allows to allocate (both physically and virtually) contiguo

[dpdk-dev] [PATCH v1 6/6] doc: advertise bucket mempool driver

2018-03-26 Thread Andrew Rybchenko
Signed-off-by: Andrew Rybchenko --- doc/guides/rel_notes/release_18_05.rst | 9 + 1 file changed, 9 insertions(+) diff --git a/doc/guides/rel_notes/release_18_05.rst b/doc/guides/rel_notes/release_18_05.rst index 016c4ed..c578364 100644 --- a/doc/guides/rel_notes/release_18_05.rst +++ b

[dpdk-dev] [PATCH v1 5/6] mempool/bucket: do not allow one lcore to grab all buckets

2018-03-26 Thread Andrew Rybchenko
From: "Artem V. Andreev" Signed-off-by: Artem V. Andreev Signed-off-by: Andrew Rybchenko --- drivers/mempool/bucket/rte_mempool_bucket.c | 13 + 1 file changed, 13 insertions(+) diff --git a/drivers/mempool/bucket/rte_mempool_bucket.c b/drivers/mempool/bucket/rte_mempool_bucket.c

[dpdk-dev] [PATCH v1 4/6] mempool/bucket: implement block dequeue operation

2018-03-26 Thread Andrew Rybchenko
From: "Artem V. Andreev" Signed-off-by: Artem V. Andreev Signed-off-by: Andrew Rybchenko --- drivers/mempool/bucket/rte_mempool_bucket.c | 52 + 1 file changed, 52 insertions(+) diff --git a/drivers/mempool/bucket/rte_mempool_bucket.c b/drivers/mempool/bucket/rte_

[dpdk-dev] [PATCH v3 04/11] mempool: add op to calculate memory size to be allocated

2018-03-26 Thread Andrew Rybchenko
Size of memory chunk required to populate mempool objects depends on how objects are stored in the memory. Different mempool drivers may have different requirements and a new operation allows to calculate memory size in accordance with driver requirements and advertise requirements on minimum memor

[dpdk-dev] [PATCH v3 11/11] mempool: support flushing the default cache of the mempool

2018-03-26 Thread Andrew Rybchenko
From: "Artem V. Andreev" Mempool get/put API cares about cache itself, but sometimes it is required to flush the cache explicitly. The function is moved in the file since it now requires rte_mempool_default_cache(). Signed-off-by: Artem V. Andreev Signed-off-by: Andrew Rybchenko --- v2 -> v3:

[dpdk-dev] [PATCH v1 2/6] mempool: implement abstract mempool info API

2018-03-26 Thread Andrew Rybchenko
From: "Artem V. Andreev" Primarily, it is intended as a way for the mempool driver to provide additional information on how it lays up objects inside the mempool. Signed-off-by: Artem V. Andreev Signed-off-by: Andrew Rybchenko --- lib/librte_mempool/rte_mempool.h | 41 ++

[dpdk-dev] [PATCH v3 10/11] mempool: remove callback to register memory area

2018-03-26 Thread Andrew Rybchenko
The callback is not required any more since there is a new callback to populate objects using provided memory area which provides the same information. Signed-off-by: Andrew Rybchenko --- v2 -> v3: - none v1 -> v2: - none RFCv2 -> v1: - advertise ABI changes in release notes doc/guides/rel

[dpdk-dev] [PATCH v3 03/11] mempool: ensure the mempool is initialized before populating

2018-03-26 Thread Andrew Rybchenko
From: "Artem V. Andreev" Callback to calculate required memory area size may require mempool driver data to be already allocated and initialized. Signed-off-by: Artem V. Andreev Signed-off-by: Andrew Rybchenko --- v2 -> v3: - none v1 -> v2: - add init check to mempool_ops_alloc_once() - mo

[dpdk-dev] [PATCH v3 01/11] mempool: fix memhdr leak when no objects are populated

2018-03-26 Thread Andrew Rybchenko
Fixes: 84121f197187 ("mempool: store memory chunks in a list") Cc: sta...@dpdk.org Suggested-by: Olivier Matz Signed-off-by: Andrew Rybchenko --- v2 -> v3: - none v1 -> v2: - added in v2 as discussed in [1] [1] https://dpdk.org/ml/archives/dev/2018-March/093329.html lib/librte_mempool/rte_

[dpdk-dev] [PATCH v3 07/11] mempool: deprecate xmem functions

2018-03-26 Thread Andrew Rybchenko
Move rte_mempool_xmem_size() code to internal helper function since it is required in two places: deprecated rte_mempool_xmem_size() and non-deprecated rte_mempool_op_calc_mem_size_default(). Suggested-by: Olivier Matz Signed-off-by: Andrew Rybchenko --- v2 -> v3: - none v1 -> v2: - deprecate

[dpdk-dev] [PATCH v3 02/11] mempool: rename flag to control IOVA-contiguous objects

2018-03-26 Thread Andrew Rybchenko
Flag MEMPOOL_F_NO_PHYS_CONTIG is renamed as MEMPOOL_F_NO_IOVA_CONTIG to follow IO memory contiguos terminology. MEMPOOL_F_NO_PHYS_CONTIG is kept for backward compatibility and deprecated. Suggested-by: Olivier Matz Signed-off-by: Andrew Rybchenko --- v2 -> v3: - none v1 -> v2: - added in v2 a

[dpdk-dev] [PATCH v3 06/11] mempool: remove callback to get capabilities

2018-03-26 Thread Andrew Rybchenko
The callback was introduced to let generic code to know octeontx mempool driver requirements to use single physically contiguous memory chunk to store all objects and align object address to total object size. Now these requirements are met using a new callbacks to calculate required memory chunk s

[dpdk-dev] [PATCH v3 09/11] mempool/dpaa: prepare to remove register memory area op

2018-03-26 Thread Andrew Rybchenko
Populate mempool driver callback is executed a bit later than register memory area, provides the same information and will substitute the later since it gives more flexibility and in addition to notification about memory area allows to customize how mempool objects are stored in memory. Signed-off

[dpdk-dev] [PATCH v3 00/11] mempool: prepare to add bucket driver

2018-03-26 Thread Andrew Rybchenko
The patch series should be applied on top of [7]. The initial patch series [1] is split into two to simplify processing. The second series relies on this one and will add bucket mempool driver and related ops. The patch series has generic enhancements suggested by Olivier. Basically it adds drive

[dpdk-dev] [PATCH v3 08/11] mempool/octeontx: prepare to remove register memory area op

2018-03-26 Thread Andrew Rybchenko
Callback to populate pool objects has all required information and executed a bit later than register memory area callback. Signed-off-by: Andrew Rybchenko --- v2 -> v3: - none v1 -> v2 - none drivers/mempool/octeontx/rte_mempool_octeontx.c | 25 ++--- 1 file changed, 10

[dpdk-dev] [PATCH v3 05/11] mempool: add op to populate objects using provided memory

2018-03-26 Thread Andrew Rybchenko
The callback allows to customize how objects are stored in the memory chunk. Default implementation of the callback which simply puts objects one by one is available. Suggested-by: Olivier Matz Signed-off-by: Andrew Rybchenko --- v2 -> v3: - none v1 -> v2: - fix memory leak if off is bigger t

Re: [dpdk-dev] [PATCH 2/2] dev: use rte_kvargs

2018-03-26 Thread Wiles, Keith
> On Mar 26, 2018, at 8:59 AM, Gaëtan Rivet wrote: > > Hi Neil, > > On Mon, Mar 26, 2018 at 07:38:19AM -0400, Neil Horman wrote: >> On Fri, Mar 23, 2018 at 07:45:03PM +0100, Gaetan Rivet wrote: >>> Signed-off-by: Gaetan Rivet >>> --- >>> >>> Cc: Neil Horman >>> > > Keep in mind that all o

[dpdk-dev] [PATCH v2] net/mrvl: rename PMD driver as mvpp2

2018-03-26 Thread Tomasz Duszynski
From: Natalie Samsonov The name "mrvl" for Marvell PMD driver for PPv2 Marvell PPv2 (Packet Processor v2) 1/10 Gbps adapter is too generic and causes problem for adding new PMD drivers for other Marvell devices. Changed to "mvpp2" for specific Marvell PPv2 PMD. This patch doesn't introduce any c

Re: [dpdk-dev] [PATCH v5 2/2] eal: add asynchronous request API to DPDK IPC

2018-03-26 Thread Burakov, Anatoly
On 26-Mar-18 3:15 PM, Tan, Jianfeng wrote: On 3/24/2018 8:46 PM, Anatoly Burakov wrote: This API is similar to the blocking API that is already present, but reply will be received in a separate callback by the caller (callback specified at the time of request, rather than registering for it in

Re: [dpdk-dev] [PATCH v5 2/2] eal: add asynchronous request API to DPDK IPC

2018-03-26 Thread Tan, Jianfeng
On 3/24/2018 8:46 PM, Anatoly Burakov wrote: This API is similar to the blocking API that is already present, but reply will be received in a separate callback by the caller (callback specified at the time of request, rather than registering for it in advance). Under the hood, we create a sepa

Re: [dpdk-dev] [PATCH 2/2] dev: use rte_kvargs

2018-03-26 Thread Gaëtan Rivet
Hi Neil, On Mon, Mar 26, 2018 at 07:38:19AM -0400, Neil Horman wrote: > On Fri, Mar 23, 2018 at 07:45:03PM +0100, Gaetan Rivet wrote: > > Signed-off-by: Gaetan Rivet > > --- > > > > Cc: Neil Horman > > Keep in mind that all of this is to achieve the trivial task I was doing in 20 lines or so.

Re: [dpdk-dev] [PATCH] event/opdl: fix atomic queue race condition issue

2018-03-26 Thread Liang, Ma
On 26 Mar 05:29, Van Haaren, Harry wrote: > > From: Ma, Liang J > > Sent: Tuesday, March 13, 2018 11:34 AM > > To: jerin.ja...@caviumnetworks.com > > Cc: dev@dpdk.org; Van Haaren, Harry ; Jain, > > Deepak > > K ; Geary, John ; Mccarthy, > > Peter > > Subject: [PATCH] event/opdl: fix atomic queue

Re: [dpdk-dev] [PATCH 0/3] add ifcvf driver

2018-03-26 Thread Maxime Coquelin
On 03/26/2018 11:05 AM, Wang, Xiao W wrote: Hi Maxime, -Original Message- From: Maxime Coquelin [mailto:maxime.coque...@redhat.com] Sent: Sunday, March 25, 2018 5:51 PM To: Wang, Xiao W ; dev@dpdk.org Cc: Wang, Zhihong ; y...@fridaylinux.org; Liang, Cunming ; Xu, Rosen ; Chen, Junjie

[dpdk-dev] [PATCH 0/3] net/sfc: add device parameter to choose FW variant

2018-03-26 Thread Andrew Rybchenko
Patch 'net/sfc: add device parameter to choose FW variant' has checkpatches.sh warning since positive errno is used inside the driver. Gautam Dawar (1): net/sfc/base: add support to choose firmware variant Roman Zhukov (2): net/sfc/base: add values for RxDPCPU firmware id recognition net/sf

[dpdk-dev] [PATCH 2/3] net/sfc/base: add values for RxDPCPU firmware id recognition

2018-03-26 Thread Andrew Rybchenko
From: Roman Zhukov Signed-off-by: Roman Zhukov Signed-off-by: Andrew Rybchenko --- drivers/net/sfc/base/efx.h | 7 +++ drivers/net/sfc/base/efx_nic.c | 12 2 files changed, 19 insertions(+) diff --git a/drivers/net/sfc/base/efx.h b/drivers/net/sfc/base/efx.h index 499474

[dpdk-dev] [PATCH 3/3] net/sfc: add device parameter to choose FW variant

2018-03-26 Thread Andrew Rybchenko
From: Roman Zhukov Add support of choice the preferred firmware variant to use in device parameters. Signed-off-by: Roman Zhukov Signed-off-by: Andrew Rybchenko --- doc/guides/nics/sfc_efx.rst | 15 ++ drivers/net/sfc/sfc.c| 123 ++- drive

[dpdk-dev] [PATCH 1/3] net/sfc/base: add support to choose firmware variant

2018-03-26 Thread Andrew Rybchenko
From: Gautam Dawar Signed-off-by: Gautam Dawar Signed-off-by: Andrew Rybchenko --- drivers/net/sfc/base/efx.h | 15 ++- drivers/net/sfc/base/efx_impl.h | 1 + drivers/net/sfc/base/efx_mcdi.c | 14 ++ drivers/net/sfc/base/efx_nic.c | 23 ++- dr

[dpdk-dev] DPDK techboard minutes of March 14

2018-03-26 Thread Thomas Monjalon
Meeting notes for the DPDK technical board meeting held on 2018-03-14 Attendees: - Bruce Richardson - Ferruh Yigit - Hemant Agrawal - Jerin Jacob - Konstantin Ananyev - Olivier Matz - Stephen Hemminger - Thomas Monjalon - Yuan

[dpdk-dev] DPDK techboard minutes of February 28

2018-03-26 Thread Thomas Monjalon
Meeting notes for the DPDK technical board meeting held on 2018-02-28 Attendees: - Bruce Richardson - Ferruh Yigit - Hemant Agrawal - Konstantin Ananyev - Olivier Matz - Stephen Hemminger - Thomas Monjalon - Yuanhan Liu 1/ There was an approval to publish the draft for Windows port in htt

Re: [dpdk-dev] [PATCH v3] net/mlx4: support CRC strip toggling

2018-03-26 Thread Thomas Monjalon
26/03/2018 13:54, Adrien Mazarguil: > On Mon, Mar 26, 2018 at 12:38:22PM +0100, Ferruh Yigit wrote: > > On 3/25/2018 9:19 PM, Ophir Munk wrote: > > > Previous to this commit mlx4 CRC stripping was executed by default and > > > there was no verbs API to disable it. > > > > Are you aware of the disc

Re: [dpdk-dev] [PATCH] event/opdl: fix atomic queue race condition issue

2018-03-26 Thread Van Haaren, Harry
> From: Ma, Liang J > Sent: Tuesday, March 13, 2018 11:34 AM > To: jerin.ja...@caviumnetworks.com > Cc: dev@dpdk.org; Van Haaren, Harry ; Jain, Deepak > K ; Geary, John ; Mccarthy, > Peter > Subject: [PATCH] event/opdl: fix atomic queue race condition issue > > If application link one atomic queu

Re: [dpdk-dev] [PATCH v3] net/mlx4: support CRC strip toggling

2018-03-26 Thread Adrien Mazarguil
On Mon, Mar 26, 2018 at 12:38:22PM +0100, Ferruh Yigit wrote: > On 3/25/2018 9:19 PM, Ophir Munk wrote: > > Previous to this commit mlx4 CRC stripping was executed by default and > > there was no verbs API to disable it. > > Are you aware of the discussion about CRC [1]? Is this patch compatible w

Re: [dpdk-dev] [PATCH] compressdev: implement API

2018-03-26 Thread Trahe, Fiona
> -Original Message- > From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Saturday, March 24, 2018 1:02 AM > To: Trahe, Fiona > Cc: dev@dpdk.org; ahmed.mans...@nxp.com; shally.ve...@cavium.com; De Lara > Guarch, Pablo > ; fiona.tr...@gmail.com > Subject: Re: [dpdk-dev] [PATCH] c

Re: [dpdk-dev] [PATCH] net/mlx5: add supported hash function check

2018-03-26 Thread Nélio Laranjeiro
On Thu, Mar 22, 2018 at 10:42:44AM +, Xueming(Steven) Li wrote: > Just remind, denying unsupported hash function in rte_eth_dev_configure() > might > impact some user app using PMD that simply ignoring them silently. If the default behavior from other devices is to use only possible values, t

Re: [dpdk-dev] [PATCH 2/2] dev: use rte_kvargs

2018-03-26 Thread Neil Horman
On Fri, Mar 23, 2018 at 07:45:03PM +0100, Gaetan Rivet wrote: > Signed-off-by: Gaetan Rivet > --- > > Cc: Neil Horman > I'm actually ok with this, but as Keith noted, I'm not sure why you didn't just: 1) Add the ability to create a grouping key, so that key value pairs could contain a list of

Re: [dpdk-dev] [PATCH v3] net/mlx4: support CRC strip toggling

2018-03-26 Thread Ferruh Yigit
On 3/25/2018 9:19 PM, Ophir Munk wrote: > Previous to this commit mlx4 CRC stripping was executed by default and > there was no verbs API to disable it. Are you aware of the discussion about CRC [1]? Is this patch compatible with plans? [1] https://dpdk.org/dev/patchwork/patch/36415/ > Signed-o

Re: [dpdk-dev] [PATCH 2/2] net/mlx5: fix RSS key len query

2018-03-26 Thread Nélio Laranjeiro
On Mon, Mar 26, 2018 at 01:12:19PM +0300, Shahaf Shuler wrote: > The RSS key length returned by rte_eth_dev_info_get command was taken > from the > PMD private structure. This structure initialization was done only after > the port configuration. > > Considering Mellanox device supports only 40B l

Re: [dpdk-dev] [PATCH v2 04/18] eal: add lightweight kvarg parsing utility

2018-03-26 Thread Neil Horman
On Fri, Mar 23, 2018 at 02:12:36PM +0100, Gaëtan Rivet wrote: > On Fri, Mar 23, 2018 at 07:54:11AM -0400, Neil Horman wrote: > > On Fri, Mar 23, 2018 at 10:31:22AM +0100, Gaëtan Rivet wrote: > > > On Thu, Mar 22, 2018 at 08:53:49PM -0400, Neil Horman wrote: > > > > On Thu, Mar 22, 2018 at 05:27:51P

[dpdk-dev] [PATCH V16 3/4] eal/linux: uevent parse and process

2018-03-26 Thread Jeff Guo
In order to handle the uevent which have been detected from the kernel side, add uevent parse and process function to translate the uevent into device event, which user has subscribe to monitor. Signed-off-by: Jeff Guo --- 1.move all linux specific together --- lib/librte_eal/linuxapp/eal/eal_de

[dpdk-dev] [PATCH V16 4/4] app/testpmd: enable device hotplug monitoring

2018-03-26 Thread Jeff Guo
Use testpmd for example, to show an application how to use device event mechanism to monitor the hotplug event, involve both hot removal event and the hot insertion event. The process is that, testpmd first enable hotplug monitoring and register the user's callback, when device being hotplug inser

[dpdk-dev] [PATCH V16 2/4] eal: add device event monitor framework

2018-03-26 Thread Jeff Guo
This patch aims to add a general device event monitor mechanism at EAL device layer, for device hotplug awareness and actions adopted accordingly. It could also expand for all other type of device event monitor, but not in this scope at the stage. To get started, users firstly register or unregist

[dpdk-dev] [PATCH V16 0/4] add device event monitor framework

2018-03-26 Thread Jeff Guo
About hot plug in dpdk, We already have proactive way to add/remove devices through APIs (rte_eal_hotplug_add/remove), and also have fail-safe driver to offload the fail-safe work from the app user. But there are still lack of a general mechanism to monitor hotplug event for all driver, now the hot

[dpdk-dev] [PATCH V16 1/4] eal: add device event handle in interrupt thread

2018-03-26 Thread Jeff Guo
Add new interrupt handle type of RTE_INTR_HANDLE_DEV_EVENT, for device event interrupt monitor. Signed-off-by: Jeff Guo --- v16->v15: split into small patch base on the function --- lib/librte_eal/common/include/rte_eal_interrupts.h | 1 + lib/librte_eal/linuxapp/eal/eal_interrupts.c | 5 +

Re: [dpdk-dev] [PATCH 1/2] net/mlx5: enforce RSS key length limitation

2018-03-26 Thread Nélio Laranjeiro
On Mon, Mar 26, 2018 at 01:12:18PM +0300, Shahaf Shuler wrote: > RSS hash key must be 40 Bytes long. > > Cc: sta...@dpdk.org > > Signed-off-by: Shahaf Shuler > --- > drivers/net/mlx5/mlx5_ethdev.c | 3 ++- > drivers/net/mlx5/mlx5_rss.c| 7 +++ > 2 files changed, 9 insertions(+), 1 delet

[dpdk-dev] [PATCH v2] net/octeontx: use the new offload APIs

2018-03-26 Thread Pavan Nikhilesh
Use the new Rx/Tx offload APIs and remove the old style offloads. Signed-off-by: Pavan Nikhilesh Acked-by: Santosh Shukla --- drivers/net/octeontx/octeontx_ethdev.c | 82 +- drivers/net/octeontx/octeontx_ethdev.h | 3 ++ 2 files changed, 65 insertions(+), 20 del

[dpdk-dev] [PATCH V16 1/3] eal: add device event handle in interrupt thread

2018-03-26 Thread Jeff Guo
Add new interrupt handle type of RTE_INTR_HANDLE_DEV_EVENT, for device event interrupt monitor. Signed-off-by: Jeff Guo --- v16->v15: split into small patch base on the function --- lib/librte_eal/common/include/rte_eal_interrupts.h | 1 + lib/librte_eal/linuxapp/eal/eal_interrupts.c | 5 +

[dpdk-dev] [PATCH V16 2/3] eal: add device event monitor framework

2018-03-26 Thread Jeff Guo
This patch aims to add a general device event monitor mechanism at EAL device layer, for device hotplug awareness and actions adopted accordingly. It could also expand for all other type of device event monitor, but not in this scope at the stage. To get started, users firstly register or unregist

[dpdk-dev] [PATCH V16 3/3] app/testpmd: enable device hotplug monitoring

2018-03-26 Thread Jeff Guo
Use testpmd for example, to show an application how to use device event mechanism to monitor the hotplug event, involve both hot removal event and the hot insertion event. The process is that, testpmd first enable hotplug monitoring and register the user's callback, when device being hotplug inser

[dpdk-dev] [PATCH V16 0/3] add device event monitor framework

2018-03-26 Thread Jeff Guo
About hot plug in dpdk, We already have proactive way to add/remove devices through APIs (rte_eal_hotplug_add/remove), and also have fail-safe driver to offload the fail-safe work from the app user. But there are still lack of a general mechanism to monitor hotplug event for all driver, now the hot

[dpdk-dev] [PATCH 2/2] net/mlx5: fix RSS key len query

2018-03-26 Thread Shahaf Shuler
The RSS key length returned by rte_eth_dev_info_get command was taken from the PMD private structure. This structure initialization was done only after the port configuration. Considering Mellanox device supports only 40B long RSS key, reporting the fixed number instead. Fixes: 29c1d8bb3e79 ("net

Re: [dpdk-dev] [PATCH 06/17] net/virtio-user: add option to use packed queues

2018-03-26 Thread Jens Freimann
On Mon, Mar 19, 2018 at 04:33:27PM +0800, Tiwei Bie wrote: On Fri, Mar 16, 2018 at 04:21:09PM +0100, Jens Freimann wrote: [...] diff --git a/drivers/net/virtio/virtio_user_ethdev.c b/drivers/net/virtio/virtio_user_ethdev.c index 2636490..ee291b3 100644 --- a/drivers/net/virtio/virtio_user_ethde

[dpdk-dev] [PATCH 1/2] net/mlx5: enforce RSS key length limitation

2018-03-26 Thread Shahaf Shuler
RSS hash key must be 40 Bytes long. Cc: sta...@dpdk.org Signed-off-by: Shahaf Shuler --- drivers/net/mlx5/mlx5_ethdev.c | 3 ++- drivers/net/mlx5/mlx5_rss.c| 7 +++ 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/drivers/net/mlx5/mlx5_ethdev.c b/drivers/net/mlx5/mlx5_ethde

[dpdk-dev] [PATCH v3 09/10] examples/vhost_crypto: add vhost crypto sample application

2018-03-26 Thread Fan Zhang
This patch adds vhost_crypto sample application to DPDK. Signed-off-by: Fan Zhang --- examples/vhost_crypto/Makefile | 32 +++ examples/vhost_crypto/main.c | 598 + 2 files changed, 630 insertions(+) create mode 100644 examples/vhost_crypto/Makefile c

  1   2   >