[dpdk-dev] [PATCH v2] vhost: add support for interrupt mode

2018-03-28 Thread Junjie Chen
In some cases we want vhost dequeue work in interrupt mode to release cpus to others when no data to transmit. So we install interrupt handler of vhost device and interrupt vectors for each rx queue when creating new backend according to vhost intrerupt configuration. Thus, applications could regis

Re: [dpdk-dev] [PATCH v2 0/2] net/fm10k: convert to new Rx/Tx offloads API

2018-03-28 Thread Zhang, Helin
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Zhang, Qi Z > Sent: Thursday, March 29, 2018 2:23 PM > To: Dai, Wei; Wang, Xiao W > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v2 0/2] net/fm10k: convert to new Rx/Tx > offloads API > > > > > -Original

[dpdk-dev] [PATCH 2/4] ether: add flow last hit query support

2018-03-28 Thread Qi Zhang
Enhanced the action RTE_FLOW_TYPE_ACTION_COUNT, number of milliseconds since last hit can be queried. Signed-off-by: Qi Zhang --- lib/librte_ether/rte_flow.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/lib/librte_ether/rte_flow.h b/lib/librte_ether/rte_flow.h index 9649519..1288379 100

[dpdk-dev] [PATCH 4/4] ether: add packet modification aciton in flow API

2018-03-28 Thread Qi Zhang
Add new actions that be used to modify packet content with generic semantic: RTE_FLOW_ACTION_TYPE_FIELD_UPDATE: - update specific field of packet RTE_FLWO_ACTION_TYPE_FIELD_INCREMENT: - increament specific field of packet RTE_FLWO_ACTION_TYPE_FIELD_DECREMENT: - decreament s

[dpdk-dev] [PATCH 3/4] ether: add more protocol support in flow API

2018-03-28 Thread Qi Zhang
Add new protocol header match support as below RTE_FLOW_ITEM_TYPE_ARP - match IPv4 ARP header RTE_FLOW_ITEM_TYPE_EXT_HDR_ANY - match any IPv6 extension header RTE_FLOW_ITEM_TYPE_ICMPV6 - match IPv6 ICMP header RTE_FLOW_ITEM_TYPE_ICMPV6_TGT_ADDR - match IPv6 ICMP Tar

[dpdk-dev] [PATCH 1/4] ether: add flow action to redirect packet in a switch domain

2018-03-28 Thread Qi Zhang
Add action RTE_FLOW_ACTION_TYPE_SWITCH_PORT, it can be used to redirect a packet to a network interface that connect to the same switch domain, rte_ethdev's port_id is used as an identification of the destination. A typical use case is: with a smart NIC for vSwitch acceleration, flow is defined to

[dpdk-dev] [PATCH 0/4] rte_flow extension for vSwitch acceleration

2018-03-28 Thread Qi Zhang
This patch extend rte_flow API. The purpose is to provide necessary programming interface for virtual switch software (such as OVS) to take advantage of incoming device's vSwitch acceleration capability when using DPDK as data plane. Below is summary of changes: 1. Support to specify flow's desti

[dpdk-dev] [PATCH v2] net/i40e: remove unnecessary FDIR mask configuration

2018-03-28 Thread Beilei Xing
Remove unnecessary FDIR mask configuration, otherwise flow directory mask will be changed when configuring hash input set. Signed-off-by: Beilei Xing Reviewed-by: Kirill Rybalchenko Acked-by: Qi Zhang --- v2 change: - Rebase code base. drivers/net/i40e/rte_pmd_i40e.c | 4 1 file change

Re: [dpdk-dev] [PATCH v2 0/2] net/fm10k: convert to new Rx/Tx offloads API

2018-03-28 Thread Zhang, Qi Z
> -Original Message- > From: Dai, Wei > Sent: Wednesday, March 28, 2018 4:01 PM > To: Zhang, Qi Z ; Wang, Xiao W > > Cc: dev@dpdk.org; Dai, Wei > Subject: [PATCH v2 0/2] net/fm10k: convert to new Rx/Tx offloads API > > This patch set support new offloads API in fm10k PF and VF. > > --

Re: [dpdk-dev] [PATCH v6 4/8] ethdev: Add port representor device flag

2018-03-28 Thread Shahaf Shuler
Wednesday, March 28, 2018 4:54 PM, Declan Doherty: > Subject: [dpdk-dev][PATCH v6 4/8] ethdev: Add port representor device flag > > Add new device flag to specify that ethdev port is a port representor. > Extend rte_eth_dev_info structure to expose device flags to user which > enable applications

Re: [dpdk-dev] [PATCH v6 3/8] ethdev: add generic create/destroy ethdev APIs

2018-03-28 Thread Shahaf Shuler
Wednesday, March 28, 2018 4:54 PM, Declan Doherty: > Subject: [dpdk-dev][PATCH v6 3/8] ethdev: add generic create/destroy > ethdev APIs > > Add new bus generic ethdev create/destroy APIs which are bus independent > and provide hooks for bus specific initialisation. > > Signed-off-by: Declan Doher

Re: [dpdk-dev] [PATCH v6 2/8] ethdev: add switch identifier parameter to port

2018-03-28 Thread Shahaf Shuler
Hi Declan, Thanks for the series! See some comments below Wednesday, March 28, 2018 4:54 PM, Declan Doherty: > Subject: [dpdk-dev][PATCH v6 2/8] ethdev: add switch identifier parameter > to port > > Introduces a new port attribute to ethdev port's which denotes the switch > domain a port belongs

Re: [dpdk-dev] [PATCH v2 1/2] net/fm10k: convert to new Rx offloads API

2018-03-28 Thread Zhang, Qi Z
> -Original Message- > From: Zhang, Qi Z > Sent: Wednesday, March 28, 2018 6:08 PM > To: Dai, Wei ; Wang, Xiao W > Cc: dev@dpdk.org > Subject: RE: [PATCH v2 1/2] net/fm10k: convert to new Rx offloads API > > Hi Daiwei: > > > +static uint64_t fm10k_get_rx_queue_offloads_capa(struct rte_

Re: [dpdk-dev] [PATCH v2 2/2] net/i40e: convert to new Tx offloads API

2018-03-28 Thread Zhang, Qi Z
> -Original Message- > From: Wu, Yanglong > Sent: Thursday, March 29, 2018 1:27 PM > To: dev@dpdk.org > Cc: Zhang, Qi Z ; Dai, Wei ; Xing, > Beilei ; Wu, Yanglong > Subject: [PATCH v2 2/2] net/i40e: convert to new Tx offloads API I think this is v3, not v2, please keep this correct and

Re: [dpdk-dev] [PATCH] net/avf: fix link autoneg value

2018-03-28 Thread Zhang, Helin
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Zhang, Qi Z > Sent: Wednesday, March 28, 2018 2:43 PM > To: Yigit, Ferruh; Wu, Jingjing; Lu, Wenzhuo > Cc: dev@dpdk.org; Yigit, Ferruh; sta...@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] net/avf: fix link autoneg v

Re: [dpdk-dev] [PATCH] net/i40e: fix support DDP packages group 0xff

2018-03-28 Thread Zhang, Helin
> -Original Message- > From: Zhang, Qi Z > Sent: Wednesday, March 28, 2018 2:25 PM > To: Rybalchenko, Kirill; dev@dpdk.org > Cc: sta...@dpdk.org; Chilikin, Andrey; Xing, Beilei; Zhang, Helin > Subject: RE: [PATCH] net/i40e: fix support DDP packages group 0xff > > > > > -Original Me

Re: [dpdk-dev] [PATCH] net/i40e: add log when setting input set

2018-03-28 Thread Zhang, Helin
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Zhang, Qi Z > Sent: Wednesday, March 28, 2018 9:16 AM > To: Xing, Beilei > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] net/i40e: add log when setting input set > > > -Original Message- > > From: Xi

Re: [dpdk-dev] [PATCH v2 2/2] ethdev: add new offload flag to keep CRC

2018-03-28 Thread Shahaf Shuler
Wednesday, March 21, 2018 9:48 PM, Ferruh Yigit: > DEV_RX_OFFLOAD_KEEP_CRC offload flag added. > > DEV_RX_OFFLOAD_CRC_STRIP flag will remain one more release but default > behavior in PMDs is to strip the CRC independent from this flag. > > Until DEV_RX_OFFLOAD_CRC_STRIP flag is removed: > - Sett

[dpdk-dev] [PATCH v2 2/2] net/i40e: convert to new Tx offloads API

2018-03-28 Thread Yanglong Wu
Ethdev Tx offloads API has changed since: commit cba7f53b717d ("ethdev: introduce Tx queue offloads API") This commit support the new Tx offloads API. Signed-off-by: Yanglong Wu --- drivers/net/i40e/i40e_ethdev.c| 1 + drivers/net/i40e/i40e_ethdev_vf.c | 1 + drivers/net/i40e/i40e_rxtx.c

[dpdk-dev] [PATCH v2 2/2] net/i40e: convert to new Tx offloads API

2018-03-28 Thread Yanglong Wu
Ethdev Tx offloads API has changed since: commit cba7f53b717d ("ethdev: introduce Tx queue offloads API") This commit support the new Tx offloads API. Signed-off-by: Yanglong Wu --- drivers/net/i40e/i40e_ethdev.c| 1 + drivers/net/i40e/i40e_ethdev_vf.c | 1 + drivers/net/i40e/i40e_rxtx.c

Re: [dpdk-dev] [PATCH] net/ixgbe: fix reconfiguration of rx queues

2018-03-28 Thread Zhang, Helin
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Ananyev, Konstantin > Sent: Wednesday, January 31, 2018 9:39 PM > To: Chas Williams; dev@dpdk.org > Cc: Lu, Wenzhuo > Subject: Re: [dpdk-dev] [PATCH] net/ixgbe: fix reconfiguration of rx queues > > > > > > > > >

Re: [dpdk-dev] [PATCH v2] drivers/net/i40e/i40e_ethdev_vf.c: fix missing promiscuous disable at device stop

2018-03-28 Thread Zhang, Helin
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Zhang, Qi Z > Sent: Friday, March 16, 2018 2:25 PM > To: Xu, Rosen; Xing, Beilei > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v2] drivers/net/i40e/i40e_ethdev_vf.c: fix > missing promiscuous disable at devi

Re: [dpdk-dev] [PATCH] net/ixgbe: fix intr callback unregister by adding retry

2018-03-28 Thread Zhang, Helin
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Zhang, Qi Z > Sent: Wednesday, March 28, 2018 8:56 AM > To: wangyunjian; dev@dpdk.org > Cc: ca...@huawei.com > Subject: Re: [dpdk-dev] [PATCH] net/ixgbe: fix intr callback unregister by > adding > retry > > > --

Re: [dpdk-dev] [PATCH v3 01/10] lib/librte_vhost: add external backend support

2018-03-28 Thread Liu, Changpeng
> -Original Message- > From: Tan, Jianfeng > Sent: Thursday, March 29, 2018 10:11 AM > To: Zhang, Roy Fan ; dev@dpdk.org > Cc: maxime.coque...@redhat.com; jianjay.z...@huawei.com; Liu, Changpeng > ; Wodkowski, PawelX > ; Stojaczyk, DariuszX > ; Kulasek, TomaszX > Subject: Re: [dpdk-dev]

Re: [dpdk-dev] Under Ovs-2.8.0 + DPDK-17.05-rc1, can't add port which using mlx5 driver onto bridge br0

2018-03-28 Thread Sam
KNI also works 2018-03-29 10:03 GMT+08:00 Sam : > But testpmd at the same version of DPDK is OK, like this: > > [gangyewei@yf-mos-test-net07 dpdk]$ sudo > /usr/local/share/openvswitch/scripts/dpdk_nic_bind >> --status >> Network devices using DPDK-compatible driver >> ===

Re: [dpdk-dev] [PATCH v3 01/10] lib/librte_vhost: add external backend support

2018-03-28 Thread Tan, Jianfeng
It's interesting that we add some new APIs to be used by the lib/librte_vhost/ itself. I can understand as we planned to not put vhost crypto into the lib. As vhost crypto is not a real "external backend", we could ask opinion of a real external backend if these are really necessary. pre and

Re: [dpdk-dev] Under Ovs-2.8.0 + DPDK-17.05-rc1, can't add port which using mlx5 driver onto bridge br0

2018-03-28 Thread Sam
But testpmd at the same version of DPDK is OK, like this: [gangyewei@yf-mos-test-net07 dpdk]$ sudo > /usr/local/share/openvswitch/scripts/dpdk_nic_bind --status > Network devices using DPDK-compatible driver > > > Network devices using kernel driver >

Re: [dpdk-dev] [PATCH] net/virtio-user: specify the MAC of the tap

2018-03-28 Thread Tiwei Bie
On Thu, Mar 29, 2018 at 08:50:37AM +0800, Tan, Jianfeng wrote: > > -Original Message- > > From: Seán Harte [mailto:sea...@gmail.com] > > Sent: Thursday, March 29, 2018 12:55 AM > > To: Ning Li; Yuanhan Liu; Maxime Coquelin; Bie, Tiwei > > Cc: dev@dpdk.org; Tan, Jianfeng > > Subject: Re: [dp

Re: [dpdk-dev] [PATCH] net/virtio-user: specify the MAC of the tap

2018-03-28 Thread Tan, Jianfeng
> -Original Message- > From: Seán Harte [mailto:sea...@gmail.com] > Sent: Thursday, March 29, 2018 12:55 AM > To: Ning Li; Yuanhan Liu; Maxime Coquelin; Bie, Tiwei > Cc: dev@dpdk.org; Tan, Jianfeng > Subject: Re: [dpdk-dev] [PATCH] net/virtio-user: specify the MAC of the tap > > On 29/12

Re: [dpdk-dev] [PATCH] net/bonding: switch to new offloading flags

2018-03-28 Thread Matan Azrad
Hi Declan, Radu Please try to answer for the below questions. From: Ferruh Yigit, Sent: Thursday, March 22, 2018 8:14 PM > On 3/14/2018 12:50 PM, Matan Azrad wrote: > > Questions: > > Have you an idea why bonding PMD doesn't adjust the slaves port > configurations to the bonding port configuratio

[dpdk-dev] [PATCH v2] maintainers: call out subtree committers

2018-03-28 Thread Pablo de Lara
The MAINTAINERS file contains information of the maintainers of the different components on DPDK. However, it does not give any information on who maintains the different subtrees which accept new commits for these components. This commit adds a list of the subtree committers. Signed-off-by: Pabl

Re: [dpdk-dev] [PATCH 11/13] cxgbe: export supported RSS hash functions

2018-03-28 Thread Ferruh Yigit
On 3/10/2018 10:48 PM, Rahul Lakkireddy wrote: > Export supported RSS hash functions in device info. Also add check to > prevent configuring unsupported RSS hash functions. > > Fixes: 58c5a23c1c4f ("net/cxgbe: support updating RSS hash configuration and > key") > Signed-off-by: Rahul Lakkireddy

Re: [dpdk-dev] [PATCH 00/13] cxgbe: add CXGBE VF PMD and updates

2018-03-28 Thread Ferruh Yigit
On 3/10/2018 10:48 PM, Rahul Lakkireddy wrote: > Patches 1 - 9 add support for cxgbe VF driver. Patches 10 - 12 fix > bugs and convert license in cxgbe files to SPDX License Tag. Patch > 13 adds compile time option to keep outer vlan tag in Q-in-Q packet. > > Patch 1 adds minimal cxgbe VF driver

Re: [dpdk-dev] [PATCH 10/13] cxgbe: fix check to close other ports properly

2018-03-28 Thread Ferruh Yigit
On 3/10/2018 10:48 PM, Rahul Lakkireddy wrote: > Fixes: 084b35314ff2 ("net/cxgbe: rework ethdev device allocation") > Signed-off-by: Rahul Lakkireddy > Signed-off-by: Kumar Sanghvi Squashed into relevant commit in next-net, thanks.

Re: [dpdk-dev] [PATCH v2] net/avp: convert to SPDX license tags

2018-03-28 Thread Ferruh Yigit
On 3/28/2018 6:01 PM, Ferruh Yigit wrote: > On 3/28/2018 5:55 PM, Allain Legacy wrote: >> As per the following commit the AVP files maintained by Wind River are >> converted to use the SPDX license tag format. >> >> commit a4862c9e1a98 ("license: introduce SPDX identifiers") >> >> Signed-off-by

Re: [dpdk-dev] [PATCH v2] net/avp: convert to SPDX license tags

2018-03-28 Thread Ferruh Yigit
On 3/28/2018 5:55 PM, Allain Legacy wrote: > As per the following commit the AVP files maintained by Wind River are > converted to use the SPDX license tag format. > > commit a4862c9e1a98 ("license: introduce SPDX identifiers") > > Signed-off-by: Allain Legacy For Intel part: Acked-by: Ferr

[dpdk-dev] [PATCH v2] net/avp: convert to SPDX license tags

2018-03-28 Thread Allain Legacy
As per the following commit the AVP files maintained by Wind River are converted to use the SPDX license tag format. commit a4862c9e1a98 ("license: introduce SPDX identifiers") Signed-off-by: Allain Legacy --- drivers/net/avp/Makefile | 33 ++- drivers/net/avp/av

Re: [dpdk-dev] [PATCH] net/virtio-user: specify the MAC of the tap

2018-03-28 Thread Seán Harte
On 29/12/2017 09:44, tiwei.bie at intel.com (Tiwei Bie) wrote: Hi Ning, On Fri, Dec 29, 2017 at 11:38:42AM +0800, Ning Li wrote: When using virtio-user with vhost-kernel to exchange packet with kernel networking stack, application can set the MAC of the tap interface via parameter. Signed-off-

Re: [dpdk-dev] [PATCH] net/avp: convert to SPDX license tags

2018-03-28 Thread Ferruh Yigit
On 3/28/2018 2:05 PM, Allain Legacy wrote: > +/* SPDX-License-Identifier: (BSD-3-Clause OR LGPL-2.1) > + * Copyright(c) 2010-2013 Intel Corporation. All rights reserved. > + * Copyright(c) 2014-2017 Wind River Systems, Inc. All rights reserved. > */ We dropped "All rights reserved." in other pat

Re: [dpdk-dev] [PATCH] net/avp: convert to SPDX license tags

2018-03-28 Thread Ferruh Yigit
On 3/28/2018 2:05 PM, Allain Legacy wrote: > As per the following commit the AVP files maintained by Wind River are > converted to use the SPDX license tag format. > > commit a4862c9e1a98 ("license: introduce SPDX identifiers") > > Signed-off-by: Allain Legacy > --- > drivers/net/avp/avp_et

Re: [dpdk-dev] [PATCH v2] net/liquidio: move to new offload API

2018-03-28 Thread Ferruh Yigit
On 3/28/2018 7:51 AM, Shijith Thotton wrote: > Make use of new offloads member instead of bit fields in port Rx conf. > > Signed-off-by: Shijith Thotton Applied to dpdk-next-net/master, thanks.

Re: [dpdk-dev] [PATCH V16 4/4] app/testpmd: enable device hotplug monitoring

2018-03-28 Thread Tan, Jianfeng
On 3/26/2018 7:20 PM, Jeff Guo wrote: Use testpmd for example, to show an application how to use device event mechanism to monitor the hotplug event, involve both hot removal event involve -> including and the hot insertion event. The process is that, testpmd first enable hotplug monitorin

Re: [dpdk-dev] [dpdk-stable] [PATCH 2/4] net/mlx5: fix flow single queue

2018-03-28 Thread Ferruh Yigit
On 3/28/2018 4:09 PM, Nélio Laranjeiro wrote: > On Wed, Mar 28, 2018 at 02:16:44PM +0100, Ferruh Yigit wrote: >> On 3/28/2018 12:34 PM, Nélio Laranjeiro wrote: >>> On Wed, Mar 28, 2018 at 11:13:42AM +, Shahaf Shuler wrote: Wednesday, March 28, 2018 12:05 PM, Ferruh Yigit: > On 3/21/201

Re: [dpdk-dev] [PATCH V16 3/4] eal/linux: uevent parse and process

2018-03-28 Thread Tan, Jianfeng
BTW, adding new .c file needs to update meson.build now. On 3/26/2018 7:20 PM, Jeff Guo wrote: In order to handle the uevent which have been detected from the kernel side, add uevent parse and process function to translate the uevent into device event, which user has subscribe to monitor. Signe

Re: [dpdk-dev] [PATCH v3 0/6] Introduce Intel FPGA BUS

2018-03-28 Thread Zhang, Tianfei
> -Original Message- > From: Gaëtan Rivet [mailto:gaetan.ri...@6wind.com] > Sent: Wednesday, March 28, 2018 6:18 AM > To: Xu, Rosen > Cc: dev@dpdk.org; Doherty, Declan ; > Richardson, Bruce ; shreyansh.j...@nxp.com; > Zhang, Tianfei ; Wu, Hao > Subject: Re: [PATCH v3 0/6] Introduce Inte

[dpdk-dev] [PATCH 8/8] net/vmxnet3: skip empty segments in transmission

2018-03-28 Thread Didier Pallard
Packets containing empty segments are dropped by hypervisor, prevent this case by skipping empty segments in transmission. Also drop empty mbufs to be sure that at least one segment is transmitted for each mbuf. Signed-off-by: Didier Pallard --- drivers/net/vmxnet3/vmxnet3_rxtx.c | 13 ++

[dpdk-dev] [PATCH 7/8] net/vmxnet3: ignore emtpy segments in reception

2018-03-28 Thread Didier Pallard
When several TCP fragments are contained in a packet that is only one mbuf segment long, vmxnet3 receives an empty segment following first one, that contains offload information. In current version, this segment is propagated as is to upper application. Remove those empty segments directly when rec

[dpdk-dev] [PATCH 6/8] net/vmxnet3: guess mss if not provided in LRO mode

2018-03-28 Thread Didier Pallard
Not so old variants of vmxnet3 do not provide MSS value along with LRO packet. When this case happens, try to guess MSS value with information at hand. Signed-off-by: Didier Pallard --- drivers/net/vmxnet3/Makefile | 1 + drivers/net/vmxnet3/vmxnet3_ethdev.c | 2 ++ drivers/net/vmxnet3

[dpdk-dev] [PATCH 5/8] net/vmxnet3: complete Rx offloads support

2018-03-28 Thread Didier Pallard
Add support for IPv6, LRO and properly set packet type in all supported cases. Signed-off-by: Didier Pallard --- drivers/net/vmxnet3/base/vmxnet3_defs.h | 27 ++- drivers/net/vmxnet3/vmxnet3_rxtx.c | 82 +++-- 2 files changed, 93 insertions(+), 16 deletio

[dpdk-dev] [PATCH 4/8] net/vmxnet3: fix Rx offload information in multiseg packets

2018-03-28 Thread Didier Pallard
In case we are working on a multisegment buffer, most bit are set in last segment of the buffer. Correctly look at those bits in eop part of the rx_offload function. Fixes: 2fdd835f992c ("vmxnet3: support jumbo frames") Signed-off-by: Didier Pallard --- drivers/net/vmxnet3/vmxnet3_rxtx.c | 13 ++

[dpdk-dev] [PATCH 1/8] net: export IPv6 header extensions skip function

2018-03-28 Thread Didier Pallard
skip_ip6_ext function can be exported as a helper, it may be used by some PMD to skip IPv6 header extensions. Signed-off-by: Didier Pallard --- lib/librte_net/Makefile| 1 + lib/librte_net/rte_net.c | 21 ++--- lib/librte_net/rte_net.h | 27 ++

[dpdk-dev] [PATCH 3/8] net/vmxnet3: gather offload data on first and last segment

2018-03-28 Thread Didier Pallard
Offloads are split between first and last segment of a packet. Call a single vmxnet3_rx_offload function that will contain all offload operations. This patch does not introduce any code modification. Pass a vmxnet3_hw as parameter to the function, it is not presently used in this patch, but will b

[dpdk-dev] [PATCH 0/8] net/vmxnet3: fix offload issues

2018-03-28 Thread Didier Pallard
This patchset fixes several issues found in vmxnet3 driver when enabling LRO offload support: - Rx offload information are not correctly gathered in multisegmented packets, leading to inconsistent packet type and Rx offload bits in resulting mbuf - MSS recovery from offload information is not d

[dpdk-dev] [PATCH 2/8] net/vmxnet3: return unknown IPv4 extension len ptype

2018-03-28 Thread Didier Pallard
Rather than parsing IP header to get proper ptype to return, just return RTE_PTYPE_L3_IPV4_EXT_UNKNOWN, that tells application that we have an IP packet with unknown header length. Signed-off-by: Didier Pallard --- drivers/net/vmxnet3/vmxnet3_rxtx.c | 8 +--- 1 file changed, 1 insertion(+),

Re: [dpdk-dev] [PATCH v3 3/4] net/virtio-user: add support for server mode

2018-03-28 Thread Tan, Jianfeng
Hi Zhiyong, Triggered by the community discussion of thread creation in a library (http://dpdk.org/dev/patchwork/patch/36579/), we can think about if possible to avoid the pthread creation here. Just a quick think, it could be feasible. The key idea is to properly set up the LSC interrupt fo

Re: [dpdk-dev] [dpdk-stable] [PATCH 2/4] net/mlx5: fix flow single queue

2018-03-28 Thread Nélio Laranjeiro
On Wed, Mar 28, 2018 at 02:16:44PM +0100, Ferruh Yigit wrote: > On 3/28/2018 12:34 PM, Nélio Laranjeiro wrote: > > On Wed, Mar 28, 2018 at 11:13:42AM +, Shahaf Shuler wrote: > >> Wednesday, March 28, 2018 12:05 PM, Ferruh Yigit: > >>> On 3/21/2018 6:45 PM, Ferruh Yigit wrote: > On 3/13/201

Re: [dpdk-dev] [PATCH v6 1/8] doc: add switch representation documentation

2018-03-28 Thread Doherty, Declan
On 28/03/2018 3:53 PM, Thomas Monjalon wrote: 28/03/2018 15:54, Declan Doherty: From: Adrien Mazarguil Add document to describe a model for representing switching capable devices in DPDK, using a general ethdev port model and through port representors.This document also details the port model

Re: [dpdk-dev] [PATCH v6 1/8] doc: add switch representation documentation

2018-03-28 Thread Thomas Monjalon
28/03/2018 15:54, Declan Doherty: > From: Adrien Mazarguil > > Add document to describe a model for representing switching capable > devices in DPDK, using a general ethdev port model and through port > representors.This document also details the port model and the > rte_flow semantics required f

Re: [dpdk-dev] [PATCH] net/i40evf: add multicast MAC address filtering

2018-03-28 Thread Ferruh Yigit
On 3/28/2018 3:23 PM, Zhang, Qi Z wrote: > > >> -Original Message- >> From: Yigit, Ferruh >> Sent: Wednesday, March 28, 2018 9:53 PM >> To: Zhang, Qi Z ; Olivier Matz >> ; dev@dpdk.org; Xing, Beilei >> ; Lu, Wenzhuo ; Thomas >> Monjalon >> Subject: Re: [dpdk-dev] [PATCH] net/i40evf: add

Re: [dpdk-dev] [PATCH] examples/ipsec-secgw: remove redundant string compare

2018-03-28 Thread Anoob Joseph
Hi Akhil, Radu, Did you get time to review the patch? Thanks, Anoob On 23/03/18 11:20, Anoob Joseph wrote: Removing redundant strncmp in parsing long arguments. The getopt library provides means to identify long options using the "val" field of structure option. The existing code gets 0 as "va

Re: [dpdk-dev] [PATCH] net/i40evf: add multicast MAC address filtering

2018-03-28 Thread Zhang, Qi Z
> -Original Message- > From: Yigit, Ferruh > Sent: Wednesday, March 28, 2018 9:53 PM > To: Zhang, Qi Z ; Olivier Matz > ; dev@dpdk.org; Xing, Beilei > ; Lu, Wenzhuo ; Thomas > Monjalon > Subject: Re: [dpdk-dev] [PATCH] net/i40evf: add multicast MAC address > filtering > > On 3/28/2018 1

Re: [dpdk-dev] [PATCH v3] net/mlx4: support CRC strip toggling

2018-03-28 Thread Ferruh Yigit
On 3/28/2018 7:03 AM, Shahaf Shuler wrote: > Monday, March 26, 2018 3:31 PM, Thomas Monjalon: >> 26/03/2018 13:54, Adrien Mazarguil: >>> On Mon, Mar 26, 2018 at 12:38:22PM +0100, Ferruh Yigit wrote: On 3/25/2018 9:19 PM, Ophir Munk wrote: > Previous to this commit mlx4 CRC stripping was ex

Re: [dpdk-dev] [PATCH 00/13] cxgbe: add CXGBE VF PMD and updates

2018-03-28 Thread Ferruh Yigit
On 3/28/2018 10:29 AM, Rahul Lakkireddy wrote: > On Wednesday, March 03/28/18, 2018 at 14:00:58 +0530, Shahaf Shuler wrote: >> Wednesday, March 28, 2018 10:40 AM, Rahul Lakkireddy: >>> On Wednesday, March 03/28/18, 2018 at 10:19:17 +0530, Shahaf Shuler What exactly is the offload you try

[dpdk-dev] [PATCH v6 5/8] app/testpmd: add port name to device info

2018-03-28 Thread Declan Doherty
Add the port name to information printed by show port info Signed-off-by: Declan Doherty --- app/test-pmd/config.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c index e12f8c515..0fbdfdcdd 100644 --- a/app/test-pmd/config.c +++ b/app/test-pm

[dpdk-dev] [PATCH v6 8/8] net/ixgbe: add support for representor ports

2018-03-28 Thread Declan Doherty
Add support for virtual function representor ports to the ixgbe PF driver. When SR-IOV virtual functions devices are enabled a corresponding representor port for each VF can be enabled in the process in which the i40e PMD is running within, by specifying the representor devarg with the list of VF p

[dpdk-dev] [PATCH v6 7/8] net/i40e: add support for representor ports

2018-03-28 Thread Declan Doherty
Add support for virtual function representor ports to the i40e PF driver. When SR-IOV virtual functions devices are enabled a corresponding representor port for each VF can be enabled in the process in which the i40e PMD is running within, by specifying the representor devarg with the list of VF po

[dpdk-dev] [PATCH v6 6/8] ethdev: add common devargs parser

2018-03-28 Thread Declan Doherty
From: Remy Horton Introduces a new structure, rte_eth_devargs, to support generic ethdev arguments common across NET PMDs, with a new API rte_eth_devargs_parse API to support PMD parsing these arguments. Signed-off-by: Remy Horton Signed-off-by: Declan Doherty --- lib/Makefile

[dpdk-dev] [PATCH v6 4/8] ethdev: Add port representor device flag

2018-03-28 Thread Declan Doherty
Add new device flag to specify that ethdev port is a port representor. Extend rte_eth_dev_info structure to expose device flags to user which enable applications to discover if a port is a representor port. Signed-off-by: Declan Doherty --- lib/librte_ether/rte_ethdev.c | 1 + lib/li

[dpdk-dev] [PATCH v6 3/8] ethdev: add generic create/destroy ethdev APIs

2018-03-28 Thread Declan Doherty
Add new bus generic ethdev create/destroy APIs which are bus independent and provide hooks for bus specific initialisation. Signed-off-by: Declan Doherty --- lib/librte_ether/Makefile | 1 + lib/librte_ether/meson.build | 1 + lib/librte_ether/rte_ethdev.c

[dpdk-dev] [PATCH v6 1/8] doc: add switch representation documentation

2018-03-28 Thread Declan Doherty
From: Adrien Mazarguil Add document to describe a model for representing switching capable devices in DPDK, using a general ethdev port model and through port representors.This document also details the port model and the rte_flow semantics required for flow programming, as well as listing some e

[dpdk-dev] [PATCH v6 2/8] ethdev: add switch identifier parameter to port

2018-03-28 Thread Declan Doherty
Introduces a new port attribute to ethdev port's which denotes the switch domain a port belongs to. By default all port's switch identifiers are the their port_id. Ports which share a common switch domain are configured with the same switch id. Signed-off-by: Declan Doherty --- app/test-pmd/conf

[dpdk-dev] [PATCH v6 0/7] switching device representation

2018-03-28 Thread Declan Doherty
This patchset follows on from the port rerpesentor patchsets and the community discussion that resulted. It outlines the model for representing and controlling switching capable devices in a new programmer's guide entry based upon the excellent summary by Adrien Mazarguil in (http://dpdk.org/ml/a

Re: [dpdk-dev] [PATCH] net/i40evf: add multicast MAC address filtering

2018-03-28 Thread Ferruh Yigit
On 3/28/2018 11:15 AM, Zhang, Qi Z wrote: > Hi Ferruh: > >> -Original Message- >> From: Yigit, Ferruh >> Sent: Wednesday, March 28, 2018 6:01 PM >> To: Zhang, Qi Z ; Olivier Matz >> ; dev@dpdk.org; Xing, Beilei >> ; Lu, Wenzhuo >> Subject: Re: [dpdk-dev] [PATCH] net/i40evf: add multicast

Re: [dpdk-dev] [PATCH v3 4/6] drivers/bus: Add Intel FPGA Bus Lib Code

2018-03-28 Thread Gaëtan Rivet
On Wed, Mar 28, 2018 at 05:29:54PM +0800, Rosen Xu wrote: > Signed-off-by: Rosen Xu > --- > drivers/bus/Makefile| 1 + > drivers/bus/ifpga/Makefile | 33 ++ > drivers/bus/ifpga/ifpga_bus.c | 562 > > drivers/b

Re: [dpdk-dev] [PATCH v3 3/6] mk/rte.app.mk: Add Intel FPGA Bus Build Configuration Macro To App Script

2018-03-28 Thread Gaëtan Rivet
On Wed, Mar 28, 2018 at 05:29:53PM +0800, Rosen Xu wrote: > Signed-off-by: Rosen Xu > --- > mk/rte.app.mk | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/mk/rte.app.mk b/mk/rte.app.mk > index 3eb41d1..958b6b5 100644 > --- a/mk/rte.app.mk > +++ b/mk/rte.app.mk > @@ -107,6 +107,9 @@ _L

Re: [dpdk-dev] [PATCH v3 2/6] config/common_base: Add Intel FPGA Build Configuration Macro

2018-03-28 Thread Gaëtan Rivet
On Wed, Mar 28, 2018 at 05:29:52PM +0800, Rosen Xu wrote: > Signed-off-by: Rosen Xu > --- > config/common_base | 6 ++ > 1 file changed, 6 insertions(+) > > diff --git a/config/common_base b/config/common_base > index ad03cf4..08b7cce 100644 > --- a/config/common_base > +++ b/config/common_b

Re: [dpdk-dev] [PATCH v3 1/6] Add Intel FPGA BUS Command Parse Code

2018-03-28 Thread Gaëtan Rivet
On Wed, Mar 28, 2018 at 05:29:51PM +0800, Rosen Xu wrote: > Signed-off-by: Rosen Xu > --- > lib/librte_eal/common/eal_common_options.c | 8 +++- > lib/librte_eal/common/eal_options.h| 2 ++ > 2 files changed, 9 insertions(+), 1 deletion(-) > > diff --git a/lib/librte_eal/common/eal_c

Re: [dpdk-dev] [PATCH] net/avf: fix link autoneg value

2018-03-28 Thread Ferruh Yigit
On 3/28/2018 7:42 AM, Zhang, Qi Z wrote: > Hi Ferruh: > >> -Original Message- >> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Ferruh Yigit >> Sent: Saturday, March 10, 2018 1:57 AM >> To: Wu, Jingjing ; Lu, Wenzhuo >> >> Cc: dev@dpdk.org; Yigit, Ferruh ; sta...@dpdk.org >> Subject

Re: [dpdk-dev] [PATCH v3 0/6] Introduce Intel FPGA BUS

2018-03-28 Thread Gaëtan Rivet
Hi Rosen, On Wed, Mar 28, 2018 at 05:29:50PM +0800, Rosen Xu wrote: > Intel FPGA BUS in DPDK > - > > This patch set introduces Intel FPGA BUS support in DPDK. > > v3 updates: > === > - Remove all modifications of bus scan and probe > - FPGA BUS Scan is trigged b

Re: [dpdk-dev] [dpdk-stable] [PATCH 2/4] net/mlx5: fix flow single queue

2018-03-28 Thread Ferruh Yigit
On 3/28/2018 12:34 PM, Nélio Laranjeiro wrote: > On Wed, Mar 28, 2018 at 11:13:42AM +, Shahaf Shuler wrote: >> Wednesday, March 28, 2018 12:05 PM, Ferruh Yigit: >>> On 3/21/2018 6:45 PM, Ferruh Yigit wrote: On 3/13/2018 2:17 PM, Nelio Laranjeiro wrote: > The flow is created with any st

[dpdk-dev] [PATCH] net/avp: convert to SPDX license tags

2018-03-28 Thread Allain Legacy
As per the following commit the AVP files maintained by Wind River are converted to use the SPDX license tag format. commit a4862c9e1a98 ("license: introduce SPDX identifiers") Signed-off-by: Allain Legacy --- drivers/net/avp/avp_ethdev.c | 33 ++- drivers/net/avp/av

Re: [dpdk-dev] [PATCH 0/4] fix control thread affinities

2018-03-28 Thread Olivier Matz
Hi, On Tue, Feb 27, 2018 at 03:46:26PM +0100, Olivier Matz wrote: > Some parts of dpdk use their own management threads. Most of the time, > the affinity of the thread is not properly set: it should not be scheduled > on the dataplane cores, because interrupting them can cause packet losses. > >

Re: [dpdk-dev] [PATCH v3 1/7] ethdev: introduce Tx generic tunnel L3/L4 offload

2018-03-28 Thread Olivier Matz
Hi Xueming, Yongseok, On Thu, Mar 22, 2018 at 01:55:05PM +, Xueming(Steven) Li wrote: > > > > -Original Message- > > From: Yongseok Koh > > Sent: Wednesday, March 21, 2018 9:41 AM > > To: Xueming(Steven) Li > > Cc: Wenzhuo Lu ; Jingjing Wu ; > > Thomas Monjalon ; Olivier MATZ > > ;

Re: [dpdk-dev] [PATCH v3 10/20] eal/dev: implement device iteration initialization

2018-03-28 Thread Gaëtan Rivet
On Tue, Mar 27, 2018 at 07:26:41PM -0400, Neil Horman wrote: > On Tue, Mar 27, 2018 at 10:23:21PM +0200, Gaëtan Rivet wrote: > > On Tue, Mar 27, 2018 at 03:04:13PM +0200, Gaëtan Rivet wrote: > > > On Tue, Mar 27, 2018 at 02:40:00PM +0200, Gaëtan Rivet wrote: > > > > On Tue, Mar 27, 2018 at 07:47:50

Re: [dpdk-dev] Under Ovs-2.8.0 + DPDK-17.05-rc1, can't add port which using mlx5 driver onto bridge br0

2018-03-28 Thread Nélio Laranjeiro
On Wed, Mar 28, 2018 at 08:20:00PM +0800, Sam wrote: > Hi all, > > I'm using Ovs-2.8.0 + DPDK-17.05-rc1 with two netdev using mlx5 driver, > like this: > > $ sudo /usr/local/share/openvswitch/scripts/dpdk_nic_bind --status > > Network devices using DPDK-compatible driver > > =

Re: [dpdk-dev] [PATCH] ethdev: replace bus specific struct with generic dev

2018-03-28 Thread Shreyansh Jain
On 3/27/2018 11:10 PM, Ferruh Yigit wrote: Public struct rte_eth_dev_info has a "struct rte_pci_device" field in it although it is common for all ethdev in all buses. Replacing pci specific struct with generic device struct and updating places that are using pci device in a way to get this infor

Re: [dpdk-dev] [PATCH] ethdev: fix port accessing after release

2018-03-28 Thread Thomas Monjalon
28/03/2018 14:10, Matan Azrad: > rte_eth_dev_pci_release() function wrongly releases an ethdev port and > then releases internal fields of this port. > This behavior is problematic, because after the release, the port may > be reallocated again by another thread or just be invalid for any > usage.

Re: [dpdk-dev] [PATCH v6 2/2] eal: add asynchronous request API to DPDK IPC

2018-03-28 Thread Burakov, Anatoly
On 28-Mar-18 12:26 PM, Thomas Monjalon wrote: 28/03/2018 12:42, Burakov, Anatoly: On 28-Mar-18 10:53 AM, Thomas Monjalon wrote: 28/03/2018 11:21, Burakov, Anatoly: I'm not against trying to improve the core design. I'm just saying that, had this kind of feedback been provided just a bit earlie

[dpdk-dev] Under Ovs-2.8.0 + DPDK-17.05-rc1, can't add port which using mlx5 driver onto bridge br0

2018-03-28 Thread Sam
Hi all, I'm using Ovs-2.8.0 + DPDK-17.05-rc1 with two netdev using mlx5 driver, like this: $ sudo /usr/local/share/openvswitch/scripts/dpdk_nic_bind --status > Network devices using DPDK-compatible driver > > > Network devices using kernel driver > ==

[dpdk-dev] [PATCH] ethdev: fix port accessing after release

2018-03-28 Thread Matan Azrad
rte_eth_dev_pci_release() function wrongly releases an ethdev port and then releases internal fields of this port. This behavior is problematic, because after the release, the port may be reallocated again by another thread or just be invalid for any usage. Move the release operation to the end of

Re: [dpdk-dev] [dpdk-stable] [PATCH v3 1/7] ethdev: fix port data reset timing

2018-03-28 Thread Matan Azrad
Hi Ferruh > From: Ferruh Yigit, Wednesday, March 28, 2018 1:38 AM > On 3/5/2018 3:12 PM, Matan Azrad wrote: > > Hi Ferruh > > > > From: Ferruh Yigit, Sent: Monday, March 5, 2018 5:07 PM > >> On 3/5/2018 2:52 PM, Matan Azrad wrote: > >>> HI > >>> > >>> From: Ferruh Yigit, Sent: Monday, March 5, 201

Re: [dpdk-dev] [PATCH v2 40/41] net/virtio: use contiguous allocation for DMA memory

2018-03-28 Thread Maxime Coquelin
Hi Anatoly, On 03/07/2018 05:57 PM, Anatoly Burakov wrote: Signed-off-by: Anatoly Burakov Reviewed-by: Venkatesh Srinivas --- Notes: Not sure if virtio needs to allocate DMA-capable memory, being a software driver and all. Corrections welcome. Yes, we need the ring memory to be co

Re: [dpdk-dev] [dpdk-stable] [PATCH 2/4] net/mlx5: fix flow single queue

2018-03-28 Thread Nélio Laranjeiro
On Wed, Mar 28, 2018 at 11:13:42AM +, Shahaf Shuler wrote: > Wednesday, March 28, 2018 12:05 PM, Ferruh Yigit: > > On 3/21/2018 6:45 PM, Ferruh Yigit wrote: > > > On 3/13/2018 2:17 PM, Nelio Laranjeiro wrote: > > >> The flow is created with any steering being applied in the NIC when > > >> the

Re: [dpdk-dev] [PATCH v6 2/2] eal: add asynchronous request API to DPDK IPC

2018-03-28 Thread Thomas Monjalon
28/03/2018 12:42, Burakov, Anatoly: > On 28-Mar-18 10:53 AM, Thomas Monjalon wrote: > > 28/03/2018 11:21, Burakov, Anatoly: > >> so i don't think > >> it's such a big deal to have two IPC threads instead of one. I'm open to > >> suggestions on how to make this work without a second thread, but i >

[dpdk-dev] [PATCH] app/testpmd: fix slave port detection

2018-03-28 Thread Matan Azrad
Testpmd allows to create and control bonding devices by run time command lines using the bonding PMD API. Some bonding device slaves operations(close, stop, etc) should not be used by the application and must be managed by the bonding PMD. Thus, Testpmd manages slave flags to prevent the special

Re: [dpdk-dev] [PATCH v3 10/20] eal/dev: implement device iteration initialization

2018-03-28 Thread Neil Horman
On Wed, Mar 28, 2018 at 10:10:07AM +0200, Gaëtan Rivet wrote: > On Tue, Mar 27, 2018 at 07:53:46PM -0400, Neil Horman wrote: > > On Tue, Mar 27, 2018 at 08:48:01PM +, Richardson, Bruce wrote: > > > > > > > > > > -Original Message- > > > > From: Gaëtan Rivet [mailto:gaetan.ri...@6wind.

[dpdk-dev] [PATCH] net/bonding: add rte flow support

2018-03-28 Thread Matan Azrad
Ethernet devices which are grouped by bonding PMD, aka slaves, are sharing the same queues and RSS configurations and their Rx burst functions must be managed by the bonding PMD according to the bonding architectuer. So, it makes sense to configure the same flow rules for all the bond slaves to al

Re: [dpdk-dev] [dpdk-stable] [PATCH 2/4] net/mlx5: fix flow single queue

2018-03-28 Thread Shahaf Shuler
Wednesday, March 28, 2018 12:05 PM, Ferruh Yigit: > On 3/21/2018 6:45 PM, Ferruh Yigit wrote: > > On 3/13/2018 2:17 PM, Nelio Laranjeiro wrote: > >> The flow is created with any steering being applied in the NIC when > >> the device is handling a single Rx queue. > >> > >> Fixes: cede123a158f ("net

Re: [dpdk-dev] [PATCH v6 1/2] eal: rename IPC sync request to pending request

2018-03-28 Thread Burakov, Anatoly
On 28-Mar-18 11:08 AM, Thomas Monjalon wrote: 28/03/2018 11:15, Burakov, Anatoly: On 27-Mar-18 5:27 PM, Thomas Monjalon wrote: 27/03/2018 15:59, Anatoly Burakov: Signed-off-by: Anatoly Burakov Suggested-by: Jianfeng Tan Acked-by: Jianfeng Tan You probably have a good explanation for this

Re: [dpdk-dev] [PATCH v2] vhost: add virtio configuration space messages

2018-03-28 Thread Maxime Coquelin
On 03/28/2018 12:23 PM, Liu, Changpeng wrote: -Original Message- From: Maxime Coquelin [mailto:maxime.coque...@redhat.com] Sent: Wednesday, March 28, 2018 6:11 PM To: Liu, Changpeng ; Kulasek, TomaszX ; y...@fridaylinux.org Cc: Verkamp, Daniel ; Harris, James R ; Wodkowski, PawelX ;

  1   2   >