Re: [dpdk-dev] [PATCH] net/octeneontx: fix warnings

2018-04-05 Thread Jerin Jacob
-Original Message- > Date: Thu, 5 Apr 2018 08:12:28 -0700 > From: Stephen Hemminger > To: jerin.ja...@caviumnetworks.com > Cc: dev@dpdk.org, Stephen Hemminger > Subject: [PATCH] net/octeneontx: fix warnings > X-Mailer: git-send-email 2.16.3 > > This is fix for Coverity Devect 268319 abo

Re: [dpdk-dev] [PATCH] eal/service: remove experimental tags

2018-04-05 Thread Jerin Jacob
-Original Message- > Date: Thu, 5 Apr 2018 14:15:46 +0100 > From: Harry van Haaren > To: dev@dpdk.org > CC: Harry van Haaren > Subject: [dpdk-dev] [PATCH] eal/service: remove experimental tags > X-Mailer: git-send-email 2.7.4 > > This commit removes the experimental tags from the > servi

Re: [dpdk-dev] [PATCH v1 11/16] ethdev: refine TPID handling in flow API

2018-04-05 Thread Zhang, Qi Z
> -Original Message- > From: Adrien Mazarguil [mailto:adrien.mazarg...@6wind.com] > Sent: Thursday, April 5, 2018 10:39 PM > To: Zhang, Qi Z > Cc: Thomas Monjalon ; Yigit, Ferruh > ; dev@dpdk.org; Lu, Wenzhuo > ; Wu, Jingjing ; Ajit Khaparde > ; Somnath Kotur > ; John Daley ; Hyong > You

[dpdk-dev] [PATCH V21 1/4] eal: add device event handle in interrupt thread

2018-04-05 Thread Jeff Guo
Add new interrupt handle type of RTE_INTR_HANDLE_DEV_EVENT, for device event interrupt monitor. Signed-off-by: Jeff Guo Reviewed-by: Jianfeng Tan --- v21->v20: no change --- lib/librte_eal/common/include/rte_eal_interrupts.h | 1 + lib/librte_eal/linuxapp/eal/eal_interrupts.c | 11 +-

[dpdk-dev] [PATCH V21 2/4] eal: add device event monitor framework

2018-04-05 Thread Jeff Guo
This patch aims to add a general device event monitor framework at EAL device layer, for device hotplug awareness and actions adopted accordingly. It could also expand for all other types of device event monitor, but not in this scope at the stage. To get started, users firstly call below new adde

[dpdk-dev] [PATCH V21 4/4] app/testpmd: enable device hotplug monitoring

2018-04-05 Thread Jeff Guo
Use testpmd for example, to show how an application uses device event APIs to monitor the hotplug events, including both hot removal event and hot insertion event. The process is that, testpmd first enable hotplug by below commands, E.g. ./build/app/testpmd -c 0x3 --n 4 -- -i --hot-plug then tes

[dpdk-dev] [PATCH V21 3/4] eal/linux: uevent parse and process

2018-04-05 Thread Jeff Guo
In order to handle the uevent which has been detected from the kernel side, add uevent parse and process function to translate the uevent into device event, which user has subscribed to monitor. Signed-off-by: Jeff Guo Reviewed-by: Jianfeng Tan --- v21->v20: refine release note and some code cle

[dpdk-dev] [PATCH V21 0/4] add device event monitor framework

2018-04-05 Thread Jeff Guo
About hot plug in dpdk, We already have proactive way to add/remove devices through APIs (rte_eal_hotplug_add/remove), and also have fail-safe driver to offload the fail-safe work from the app user. But there are still lack of a general mechanism to monitor hotplug event for all driver, now the hot

Re: [dpdk-dev] [PATCH V20 3/4] eal/linux: uevent parse and process

2018-04-05 Thread Guo, Jia
On 4/6/2018 5:58 AM, Thomas Monjalon wrote: 05/04/2018 18:10, Jeff Guo: In order to handle the uevent which has been detected from the kernel side, add uevent parse and process function to translate the uevent into device event, which user has subscribed to monitor. Signed-off-by: Jeff Guo -

Re: [dpdk-dev] [PATCH V20 2/4] eal: add device event monitor framework

2018-04-05 Thread Guo, Jia
On 4/6/2018 5:54 AM, Thomas Monjalon wrote: 05/04/2018 18:10, Jeff Guo: --- a/lib/librte_eal/rte_eal_version.map +++ b/lib/librte_eal/rte_eal_version.map @@ -260,3 +260,13 @@ EXPERIMENTAL { rte_socket_id_by_idx; } DPDK_18.02; + +EXPERIMENTAL { + global: + + rte_dev_e

Re: [dpdk-dev] [PATCH V20 4/4] app/testpmd: enable device hotplug monitoring

2018-04-05 Thread Guo, Jia
On 4/6/2018 5:48 AM, Thomas Monjalon wrote: 05/04/2018 18:10, Jeff Guo: Use testpmd for example, to show how an application uses device event APIs to monitor the hotplug events, including both hot removal event and hot insertion event. The process is that, testpmd first enable hotplug by belo

Re: [dpdk-dev] [PATCH V20 3/4] eal/linux: uevent parse and process

2018-04-05 Thread Guo, Jia
thanks. On 4/6/2018 12:22 AM, Tan, Jianfeng wrote: On 4/6/2018 12:10 AM, Jeff Guo wrote: In order to handle the uevent which has been detected from the kernel side, add uevent parse and process function to translate the uevent into device event, which user has subscribed to monitor. Signed-

Re: [dpdk-dev] Sad News from Intel - Venky Venkatesan

2018-04-05 Thread Bob Monkman
Shocking and very sad...Venky's contributions, and his persona, as you outlined are significant and will be remembered. Robert (Bob) Monkman Director, Networking Software Strategy & Ecosystem Programs Arm 150 Rose Orchard Way San Jose, Ca 95134 M: +1.510.676.5490 Skype: robert.monkman From: gov

Re: [dpdk-dev] [PATCH] ring: relax alignment constraint on ring structure

2018-04-05 Thread Jerin Jacob
-Original Message- Hi Konstantin, > > > -Original Message- > > From: Jerin Jacob [mailto:jerin.ja...@caviumnetworks.com] > > Sent: Thursday, April 5, 2018 9:02 AM > > To: Ananyev, Konstantin > > Cc: Olivier Matz ; dev@dpdk.org; Richardson, Bruce > > > > Subject: Re: [dpdk-dev]

Re: [dpdk-dev] [PATCH 2/3] usertools: add hv_uio_setup script

2018-04-05 Thread Stephen Hemminger
On Thu, 5 Apr 2018 23:57:47 + "Ananyev, Konstantin" wrote: > > -Original Message- > > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Thomas Monjalon > > Sent: Thursday, April 5, 2018 10:11 PM > > To: Richardson, Bruce > > Cc: Stephen Hemminger ; dev@dpdk.org; Stephen > > Hemmi

[dpdk-dev] [PATCH v4 2/2] net/bnxt: switch to the new offload API

2018-04-05 Thread Ajit Khaparde
Update bnxt PMD to new ethdev offloads API. Signed-off-by: Ajit Khaparde -- v1->v2: return an error if requested offload flags do not match supported offload capabilities. v2->v3: modify the code based on review comments. v3->v4: fix compilation for i686 configuration. --- drivers/net/bnxt/bnxt_

[dpdk-dev] [PATCH v4 1/2] net/bnxt: fix rx_drop_en setting

2018-04-05 Thread Ajit Khaparde
If Rx descriptors are not available, pkts are dropped by default. Fix rx_drop_en setting in bnxt_dev_info_get_op to reflect it. Signed-off-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_ethdev.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/d

Re: [dpdk-dev] [PATCH 2/3] usertools: add hv_uio_setup script

2018-04-05 Thread Ananyev, Konstantin
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Thomas Monjalon > Sent: Thursday, April 5, 2018 10:11 PM > To: Richardson, Bruce > Cc: Stephen Hemminger ; dev@dpdk.org; Stephen > Hemminger > Subject: Re: [dpdk-dev] [PATCH 2/3] usertools: add hv_uio_setup scr

Re: [dpdk-dev] [PATCH 2/3] usertools: add hv_uio_setup script

2018-04-05 Thread Stephen Hemminger
On Thu, 05 Apr 2018 23:10:33 +0200 Thomas Monjalon wrote: > 05/04/2018 23:07, Bruce Richardson: > > On Thu, Apr 05, 2018 at 10:43:39PM +0200, Thomas Monjalon wrote: > > > 05/04/2018 21:13, Stephen Hemminger: > > > > Small script to rebind netvsc kernel device to Hyper-V > > > > networking PMD

Re: [dpdk-dev] [PATCH 2/3] usertools: add hv_uio_setup script

2018-04-05 Thread Stephen Hemminger
On Thu, 05 Apr 2018 23:13:54 +0200 Thomas Monjalon wrote: > 05/04/2018 23:03, Stephen Hemminger: > > On Thu, 05 Apr 2018 22:43:39 +0200 > > Thomas Monjalon wrote: > > > > > 05/04/2018 21:13, Stephen Hemminger: > > > > Small script to rebind netvsc kernel device to Hyper-V > > > > networking

Re: [dpdk-dev] [PATCH V20 3/4] eal/linux: uevent parse and process

2018-04-05 Thread Thomas Monjalon
05/04/2018 18:10, Jeff Guo: > In order to handle the uevent which has been detected from the kernel > side, add uevent parse and process function to translate the uevent into > device event, which user has subscribed to monitor. > > Signed-off-by: Jeff Guo > --- > lib/librte_eal/linuxapp/eal/eal

Re: [dpdk-dev] [PATCH V20 2/4] eal: add device event monitor framework

2018-04-05 Thread Thomas Monjalon
05/04/2018 18:10, Jeff Guo: > --- a/lib/librte_eal/rte_eal_version.map > +++ b/lib/librte_eal/rte_eal_version.map > @@ -260,3 +260,13 @@ EXPERIMENTAL { > rte_socket_id_by_idx; > > } DPDK_18.02; > + > +EXPERIMENTAL { > + global: > + > + rte_dev_event_monitor_start; > + r

Re: [dpdk-dev] [PATCH v4 0/3] timer library enhancement

2018-04-05 Thread Carrillo, Erik G
Hi Thomas, OK, I'll take a fresh look at these. Thanks, Erik > -Original Message- > From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Wednesday, April 4, 2018 5:43 PM > To: Carrillo, Erik G > Cc: dev@dpdk.org; rsanf...@akamai.com; Mcnamara, John > > Subject: Re: [dpdk-dev] [PA

Re: [dpdk-dev] [PATCH V20 4/4] app/testpmd: enable device hotplug monitoring

2018-04-05 Thread Thomas Monjalon
05/04/2018 18:10, Jeff Guo: > Use testpmd for example, to show how an application uses device event > APIs to monitor the hotplug events, including both hot removal event > and hot insertion event. > > The process is that, testpmd first enable hotplug by below commands, > > E.g. ./build/app/testp

Re: [dpdk-dev] [PATCH 2/3] usertools: add hv_uio_setup script

2018-04-05 Thread Stephen Hemminger
On Thu, 05 Apr 2018 23:13:54 +0200 Thomas Monjalon wrote: > 05/04/2018 23:03, Stephen Hemminger: > > On Thu, 05 Apr 2018 22:43:39 +0200 > > Thomas Monjalon wrote: > > > > > 05/04/2018 21:13, Stephen Hemminger: > > > > Small script to rebind netvsc kernel device to Hyper-V > > > > networking

Re: [dpdk-dev] [PATCH 3/3] net/netvsc: add hyper-v netvsc network device

2018-04-05 Thread Stephen Hemminger
On Thu, 05 Apr 2018 23:07:45 +0200 Thomas Monjalon wrote: > 05/04/2018 22:59, Stephen Hemminger: > > On Thu, 05 Apr 2018 22:52:31 +0200 > > Thomas Monjalon wrote: > > > > > Hi Stephen, > > > > > > Good to see there is a good progress. > > > > > > This patch should add an entry in the releas

Re: [dpdk-dev] [PATCH 2/3] usertools: add hv_uio_setup script

2018-04-05 Thread Stephen Hemminger
On Thu, 05 Apr 2018 23:13:54 +0200 Thomas Monjalon wrote: > 05/04/2018 23:03, Stephen Hemminger: > > On Thu, 05 Apr 2018 22:43:39 +0200 > > Thomas Monjalon wrote: > > > > > 05/04/2018 21:13, Stephen Hemminger: > > > > Small script to rebind netvsc kernel device to Hyper-V > > > > networking

[dpdk-dev] [RFC] testpmd: add ability to set tx IP and UDP parameters

2018-04-05 Thread Stephen Hemminger
Use RFC standard values address and ports for Tx only test as defaults. But let the user override those values on command line. Signed-off-by: Stephen Hemminger --- app/test-pmd/parameters.c | 49 +++ app/test-pmd/testpmd.h| 6 + a

Re: [dpdk-dev] [PATCH 2/3] usertools: add hv_uio_setup script

2018-04-05 Thread Thomas Monjalon
05/04/2018 23:03, Stephen Hemminger: > On Thu, 05 Apr 2018 22:43:39 +0200 > Thomas Monjalon wrote: > > > 05/04/2018 21:13, Stephen Hemminger: > > > Small script to rebind netvsc kernel device to Hyper-V > > > networking PMD. It could be integrated in dpdk-bind, but dpdk-bind > > > is focused on P

Re: [dpdk-dev] [PATCH 2/3] usertools: add hv_uio_setup script

2018-04-05 Thread Thomas Monjalon
05/04/2018 23:07, Bruce Richardson: > On Thu, Apr 05, 2018 at 10:43:39PM +0200, Thomas Monjalon wrote: > > 05/04/2018 21:13, Stephen Hemminger: > > > Small script to rebind netvsc kernel device to Hyper-V > > > networking PMD. It could be integrated in dpdk-bind, but dpdk-bind > > > is focused on P

Re: [dpdk-dev] [PATCH 2/3] usertools: add hv_uio_setup script

2018-04-05 Thread Bruce Richardson
On Thu, Apr 05, 2018 at 10:43:39PM +0200, Thomas Monjalon wrote: > 05/04/2018 21:13, Stephen Hemminger: > > Small script to rebind netvsc kernel device to Hyper-V > > networking PMD. It could be integrated in dpdk-bind, but dpdk-bind > > is focused on PCI, and that would get messy. > > > > Eventua

Re: [dpdk-dev] [PATCH 3/3] net/netvsc: add hyper-v netvsc network device

2018-04-05 Thread Thomas Monjalon
05/04/2018 22:59, Stephen Hemminger: > On Thu, 05 Apr 2018 22:52:31 +0200 > Thomas Monjalon wrote: > > > Hi Stephen, > > > > Good to see there is a good progress. > > > > This patch should add an entry in the release notes. > > But I guess it is not ready for 18.05? [...] > > > +The following

Re: [dpdk-dev] [PATCH 2/3] usertools: add hv_uio_setup script

2018-04-05 Thread Stephen Hemminger
On Thu, 05 Apr 2018 22:43:39 +0200 Thomas Monjalon wrote: > 05/04/2018 21:13, Stephen Hemminger: > > Small script to rebind netvsc kernel device to Hyper-V > > networking PMD. It could be integrated in dpdk-bind, but dpdk-bind > > is focused on PCI, and that would get messy. > > > > Eventually,

Re: [dpdk-dev] [PATCH 3/3] net/netvsc: add hyper-v netvsc network device

2018-04-05 Thread Stephen Hemminger
On Thu, 05 Apr 2018 22:52:31 +0200 Thomas Monjalon wrote: > Hi Stephen, > > Good to see there is a good progress. > > This patch should add an entry in the release notes. > But I guess it is not ready for 18.05? > > > 05/04/2018 21:13, Stephen Hemminger: > > +# > > +# Compile native PMD for H

Re: [dpdk-dev] [PATCH 3/3] net/netvsc: add hyper-v netvsc network device

2018-04-05 Thread Thomas Monjalon
Hi Stephen, Good to see there is a good progress. This patch should add an entry in the release notes. But I guess it is not ready for 18.05? 05/04/2018 21:13, Stephen Hemminger: > +# > +# Compile native PMD for Hyper-V/Azure > +# > +CONFIG_RTE_LIBRTE_NETVSC_PMD=n > +CONFIG_RTE_LIBRTE_NETVSC_DE

Re: [dpdk-dev] [PATCH 2/3] usertools: add hv_uio_setup script

2018-04-05 Thread Thomas Monjalon
05/04/2018 21:13, Stephen Hemminger: > Small script to rebind netvsc kernel device to Hyper-V > networking PMD. It could be integrated in dpdk-bind, but dpdk-bind > is focused on PCI, and that would get messy. > > Eventually, this functionality will be built into netvsc driver > (see vdev_netvsc a

Re: [dpdk-dev] [PATCH] vhost: fix meson build issues

2018-04-05 Thread Maxime Coquelin
On 04/05/2018 10:08 AM, Tomasz Duszynski wrote: This patch addresses following meson build issues: 1) Since rte_vdpa.h includes rte_pci.h it introduces pci dependency thus deps array should be updated accordingly. 2) Since vhost.h includes rte_vdpa.h vdpa.c should be added to the sour

Re: [dpdk-dev] [PATCH] vhost: fix meson build issues

2018-04-05 Thread Maxime Coquelin
On 04/05/2018 10:08 AM, Tomasz Duszynski wrote: This patch addresses following meson build issues: 1) Since rte_vdpa.h includes rte_pci.h it introduces pci dependency thus deps array should be updated accordingly. 2) Since vhost.h includes rte_vdpa.h vdpa.c should be added to the sour

Re: [dpdk-dev] [PATCH v7 0/8] vhost: introduce vhost crypto backend

2018-04-05 Thread Maxime Coquelin
On 04/05/2018 06:01 PM, Fan Zhang wrote: This patchset depends on the following patch and must be applied first: "lib/librte_vhost: add virtio_crypto.h header file" (https://dpdk.org/dev/patchwork/patch/37308/) This patchset adds crypto backend suppport to vhost library including a proof-of-c

Re: [dpdk-dev] [PATCH] lib/librte_vhost: add virtio_crypto.h header file

2018-04-05 Thread Maxime Coquelin
On 04/05/2018 04:37 PM, Jay Zhou wrote: Since the linux kernel header file virtio_crypto.h has been merged in 4.9, if we include this header file directly, compilation will be failed in the old kernels' environment, e.g. the vhost crypto backend series. Adding virtio_crypto.h in librte_vhost to

Re: [dpdk-dev] [PATCH v7 0/8] vhost: introduce vhost crypto backend

2018-04-05 Thread Maxime Coquelin
On 04/05/2018 06:01 PM, Fan Zhang wrote: This patchset depends on the following patch and must be applied first: "lib/librte_vhost: add virtio_crypto.h header file" (https://dpdk.org/dev/patchwork/patch/37308/) This patchset adds crypto backend suppport to vhost library including a proof-of-c

Re: [dpdk-dev] [PATCH] lib/librte_vhost: add virtio_crypto.h header file

2018-04-05 Thread Maxime Coquelin
On 04/05/2018 04:37 PM, Jay Zhou wrote: Since the linux kernel header file virtio_crypto.h has been merged in 4.9, if we include this header file directly, compilation will be failed in the old kernels' environment, e.g. the vhost crypto backend series. Adding virtio_crypto.h in librte_vhost to

[dpdk-dev] [PATCH 3/3] net/netvsc: add hyper-v netvsc network device

2018-04-05 Thread Stephen Hemminger
From: Stephen Hemminger Add VMBUS network device PMD. This code is based off of the FreeBSD driver. The file and variable names are kept the same to help with understanding (with most of the BSD style warts removed). Signed-off-by: Stephen Hemminger --- MAINTAINERS

[dpdk-dev] [PATCH 1/3] bus/vmbus: add hyper-v virtual bus support

2018-04-05 Thread Stephen Hemminger
From: Stephen Hemminger This patch adds support for an additional bus type Virtual Machine BUS (VMBUS)is used on Microsoft Hyper-V in Windows 10, Windows Server 2016 and Azure. Most of this code was extracted from FreeBSD and some of this is from earlier code donated by Brocade. Only Linux is s

[dpdk-dev] [PATCH 2/3] usertools: add hv_uio_setup script

2018-04-05 Thread Stephen Hemminger
Small script to rebind netvsc kernel device to Hyper-V networking PMD. It could be integrated in dpdk-bind, but dpdk-bind is focused on PCI, and that would get messy. Eventually, this functionality will be built into netvsc driver (see vdev_netvsc as an example). Signed-off-by: Stephen Hemminger

[dpdk-dev] [PATCH 0/3] add Hyper-V bus and network driver

2018-04-05 Thread Stephen Hemminger
This is an experimental driver originally developed by Vyatta/Brocade/ATT to support DPDK on Hyper-V. It is a native DPDK driver (unlike the TAP solution) for VMBus. The driver relies on the version UIO for Hyper-V (uio_hv_generic) which is in upstream kernel next tree (char-misc-next). It is not

Re: [dpdk-dev] [PATCH v3 00/68] Memory Hotplug for DPDK

2018-04-05 Thread santosh
Hi Anatoly, On Wednesday 04 April 2018 04:51 AM, Anatoly Burakov wrote: > This patchset introduces dynamic memory allocation for DPDK (aka memory > hotplug). Based upon RFC submitted in December [1]. > > Dependencies (to be applied in specified order): > - IPC asynchronous request API patch [2] >

[dpdk-dev] Sad News from Intel - Venky Venkatesan

2018-04-05 Thread St Leger, Jim
Several of you have already heard the very sad news of the passing of our dear friend and colleague Venky. He was "Mr. DPDK" to many, a nod to his invention and creation of DPDK about ten years ago (before it was called DPDK.) Of course his footprints across the industry and literally across t

Re: [dpdk-dev] [PATCH v6] net/virtio-user: add support for server mode

2018-04-05 Thread Tan, Jianfeng
On 4/6/2018 8:18 AM, zhiyong.y...@intel.com wrote: In a container environment if the vhost-user backend restarts, there's no way for it to reconnect to virtio-user. To address this, support for server mode is added. In this mode the socket file is created by virtio- user, which the backend then

Re: [dpdk-dev] [PATCH] net/tap: remove queue specific offload support

2018-04-05 Thread Thomas Monjalon
Pascal, Moti, Ophir, please comment. 22/03/2018 19:28, Ferruh Yigit: > It is not clear if tap PMD supports queue specific offloads, removing > the related code. > > Fixes: 95ae196ae10b ("net/tap: use new Rx offloads API") > Fixes: 818fe14a9891 ("net/tap: use new Tx offloads API") > Cc: mo...@mell

[dpdk-dev] [PATCH v2 5/5] drivers/net: share vdev data to secondary process

2018-04-05 Thread Jianfeng Tan
dpdk-procinfo, as a secondary process, cannot fetch stats for vdev. This patch enables that by attaching the port from the shared data. We also fill the eth dev ops, with only some ops works in secondary process, for example, stats_get(). Note that, we still cannot Rx/Tx packets on the ports whic

[dpdk-dev] [PATCH v2 4/5] drivers/net: not use private eth dev data

2018-04-05 Thread Jianfeng Tan
We introduced private rte_eth_dev_data to allow vdev to be created both in primary process and secondary process(es). This is not friendly to multi-process model, for example, it leads to port id contention issue if two processes both find the data entry is free. And to get stats of primary vdev i

[dpdk-dev] [PATCH v2 0/5] allow procinfo and pdump on eth vdev

2018-04-05 Thread Jianfeng Tan
v2: - Add spinlock for vdev device list as suggested by Anatoly. - Add ring, cxgbe and remove the free in each PMDs as suggested by Matan. - Rebase on master. As we know, we have below limitations in vdev: - dpdk-procinfo cannot get the stats of (most) vdev in primary process; - dpdk-pdu

[dpdk-dev] [PATCH v2 2/5] bus/vdev: add lock on vdev device list

2018-04-05 Thread Jianfeng Tan
As we could add virtual devices from different threads now, we add a spin lock to protect the vdev device list. Suggested-by: Anatoly Burakov Signed-off-by: Jianfeng Tan --- drivers/bus/vdev/vdev.c | 61 + 1 file changed, 47 insertions(+), 14 dele

[dpdk-dev] [PATCH v2 3/5] bus/vdev: bus scan by multi-process channel

2018-04-05 Thread Jianfeng Tan
To scan the vdevs in primary, we send request to primary process to obtain the names for vdevs. Only the name is shared from the primary. In probe(), the device driver is supposed to locate (or request more) the detail information from the primary. Signed-off-by: Jianfeng Tan --- drivers/bus/vd

[dpdk-dev] [PATCH v2 1/5] eal: bring forward multi-process channel init

2018-04-05 Thread Jianfeng Tan
Adjust the init sequence: put mp channel init before bus scan so that we can init the vdev bus through mp channel in the secondary process before the bus scan. Signed-off-by: Jianfeng Tan --- lib/librte_eal/bsdapp/eal/eal.c | 23 +-- lib/librte_eal/linuxapp/eal/eal.c | 23 +

Re: [dpdk-dev] [PATCH] net/octeontx: remove redundent driver name update

2018-04-05 Thread Ferruh Yigit
On 4/3/2018 10:06 AM, David Marchand wrote: > On Mon, Apr 2, 2018 at 6:05 PM, Santosh Shukla > wrote: >> Cc: sta...@dpdk.org >> >> Signed-off-by: Santosh Shukla > Reviewed-by: David Marchand Applied to dpdk-next-net/master, thanks.

Re: [dpdk-dev] [PATCH 12/13] ethdev: fix library version in meson build

2018-04-05 Thread Ferruh Yigit
On 3/23/2018 9:46 PM, Bruce Richardson wrote: > On Tue, Mar 20, 2018 at 11:26:26AM +, Andrew Rybchenko wrote: >> Fixes: 701ac75666b9 ("ethdev: remove versioning of ethdev filter control >> function") >> >> Signed-off-by: Andrew Rybchenko >> --- >> lib/librte_ether/meson.build | 2 +- >> 1 fi

Re: [dpdk-dev] [PATCH 0/3] cxgbe: Rx/Tx offload API, devargs, and doc updates

2018-04-05 Thread Ferruh Yigit
On 4/4/2018 4:53 AM, Rahul Lakkireddy wrote: > Patch 1 updates document for CXGBEVF PMD. > > Patch 2 adds runtime devargs option to CXGBE PMD to keep/strip > outer vlan in Q-in-Q packets. > > Patch 3 updates CXGBE PMD to use the new Rx/TX Offload API. > > Thanks, > Rahul > > Kumar Sanghvi (1):

Re: [dpdk-dev] [PATCH 1/1] net/szedata2: convert to new offload API

2018-04-05 Thread Ferruh Yigit
On 4/3/2018 4:06 PM, Matej Vido wrote: > Offload API is currently used only to setup correct receive function > for scattered packets. > Use offloads member instead of bitfield and advertise correct > capabilities. > > Signed-off-by: Matej Vido Applied to dpdk-next-net/master, thanks.

Re: [dpdk-dev] [PATCH v2 4/4] ethdev: Add metadata flow and action items support

2018-04-05 Thread Thomas Monjalon
05/04/2018 15:51, Declan Doherty: > +struct rte_flow_item_metadata { > + uint32_t id;/**< field identifier */ > + uint32_t size; /**< field size */ > + uint8_t bytes[];/**< field value */ > +}; Spotted C99 syntax of flexible array. Are we OK with all

Re: [dpdk-dev] [RFT] vmxnet3: coverity reported defect

2018-04-05 Thread Ferruh Yigit
On 4/5/2018 4:36 PM, Stephen Hemminger wrote: > I noticed Coverity defect in DPDK number 124563 was assigned to me. > > It looks like vmxnet3 driver code doesn't handle case where host incorrectly > sends a frame with out setting SOP bit in first segment. This would lead to > rxq->start_seq being

Re: [dpdk-dev] [PATCH v2 2/4] ethdev: Add vTEP encap/decap actions

2018-04-05 Thread Thomas Monjalon
05/04/2018 15:51, Declan Doherty: > +/** > + * RTE_FLOW_ACTION_TYPE_VTEP_ENCAP > + * > + * Virtual tunnel end-point encapsulation action data. > + * > + * Non-terminating action by default. > + */ > +struct rte_flow_action_vtep_encap { > + struct rte_flow_action_item { > + enum rte_

[dpdk-dev] [PATCH v6] net/virtio-user: add support for server mode

2018-04-05 Thread zhiyong . yang
In a container environment if the vhost-user backend restarts, there's no way for it to reconnect to virtio-user. To address this, support for server mode is added. In this mode the socket file is created by virtio- user, which the backend then connects to. This means that if the backend restarts,

[dpdk-dev] [PATCH v5] ethdev: replace bus specific struct with generic dev

2018-04-05 Thread Ferruh Yigit
Public struct rte_eth_dev_info has a "struct rte_pci_device" field in it although it is common for all ethdev in all buses. Replacing pci specific struct with generic device struct and updating places that are using pci device in a way to get this information from generic device. Signed-off-by: F

Re: [dpdk-dev] [PATCH v2 1/4] ethdev: add group counter support to rte_flow

2018-04-05 Thread Thomas Monjalon
05/04/2018 15:51, Declan Doherty: > +Group Count Query > +~ > + > +Query group counter which can be associated with multiple flows on a > specified > +port. > + > +This function allows retrieving of group counters. Data > +is gathered by special actions which must be present in the

Re: [dpdk-dev] [PATCH V20 3/4] eal/linux: uevent parse and process

2018-04-05 Thread Tan, Jianfeng
On 4/6/2018 12:10 AM, Jeff Guo wrote: In order to handle the uevent which has been detected from the kernel side, add uevent parse and process function to translate the uevent into device event, which user has subscribed to monitor. Signed-off-by: Jeff Guo Other than two nits below, Reviewe

[dpdk-dev] [PATCH V20 0/4] add device event monitor framework

2018-04-05 Thread Jeff Guo
About hot plug in dpdk, We already have proactive way to add/remove devices through APIs (rte_eal_hotplug_add/remove), and also have fail-safe driver to offload the fail-safe work from the app user. But there are still lack of a general mechanism to monitor hotplug event for all driver, now the hot

[dpdk-dev] [PATCH V20 3/4] eal/linux: uevent parse and process

2018-04-05 Thread Jeff Guo
In order to handle the uevent which has been detected from the kernel side, add uevent parse and process function to translate the uevent into device event, which user has subscribed to monitor. Signed-off-by: Jeff Guo --- v20->v19: add socket error handler --- lib/librte_eal/linuxapp/eal/eal_de

[dpdk-dev] [PATCH V20 4/4] app/testpmd: enable device hotplug monitoring

2018-04-05 Thread Jeff Guo
Use testpmd for example, to show how an application uses device event APIs to monitor the hotplug events, including both hot removal event and hot insertion event. The process is that, testpmd first enable hotplug by below commands, E.g. ./build/app/testpmd -c 0x3 --n 4 -- -i --hot-plug then tes

[dpdk-dev] [PATCH V20 1/4] eal: add device event handle in interrupt thread

2018-04-05 Thread Jeff Guo
Add new interrupt handle type of RTE_INTR_HANDLE_DEV_EVENT, for device event interrupt monitor. Signed-off-by: Jeff Guo Reviewed-by: Jianfeng Tan --- v20->19: no change --- lib/librte_eal/common/include/rte_eal_interrupts.h | 1 + lib/librte_eal/linuxapp/eal/eal_interrupts.c | 11 +-

[dpdk-dev] [PATCH V20 2/4] eal: add device event monitor framework

2018-04-05 Thread Jeff Guo
This patch aims to add a general device event monitor framework at EAL device layer, for device hotplug awareness and actions adopted accordingly. It could also expand for all other types of device event monitor, but not in this scope at the stage. To get started, users firstly call below new adde

[dpdk-dev] [PATCH v7 8/8] doc: update for vhost crypto support

2018-04-05 Thread Fan Zhang
Signed-off-by: Fan Zhang --- doc/guides/prog_guide/vhost_lib.rst | 25 ++ doc/guides/rel_notes/release_18_05.rst| 5 ++ doc/guides/sample_app_ug/index.rst| 1 + doc/guides/sample_app_ug/vhost_crypto.rst | 82 +++ 4 files changed, 113 inserti

[dpdk-dev] [PATCH v7 6/8] lib/librte_vhost: update makefile

2018-04-05 Thread Fan Zhang
This patch updates the Makefile of vhost library to enable vhost crypto compiling. Signed-off-by: Fan Zhang --- lib/librte_vhost/Makefile| 5 +++-- lib/librte_vhost/meson.build | 8 2 files changed, 7 insertions(+), 6 deletions(-) diff --git a/lib/librte_vhost/Makefile b/lib/librte

[dpdk-dev] [PATCH v7 5/8] lib/librte_vhost: add public function implementation

2018-04-05 Thread Fan Zhang
This patch adds public API implementation to vhost crypto. Signed-off-by: Fan Zhang --- lib/librte_vhost/rte_vhost_crypto.h| 97 - lib/librte_vhost/rte_vhost_version.map | 6 + lib/librte_vhost/vhost_crypto.c| 255 + 3 files changed, 357

[dpdk-dev] [PATCH v7 7/8] examples/vhost_crypto: add vhost crypto sample application

2018-04-05 Thread Fan Zhang
This patch adds vhost_crypto sample application to DPDK. Signed-off-by: Fan Zhang --- examples/vhost_crypto/Makefile| 32 +++ examples/vhost_crypto/main.c | 541 ++ examples/vhost_crypto/meson.build | 14 + 3 files changed, 587 insertions(+) create

[dpdk-dev] [PATCH v7 3/8] lib/librte_vhost: add session message handler

2018-04-05 Thread Fan Zhang
This patch adds session message handler to vhost crypto. Signed-off-by: Fan Zhang --- lib/librte_vhost/vhost_crypto.c | 434 lib/librte_vhost/vhost_user.c | 2 + 2 files changed, 436 insertions(+) create mode 100644 lib/librte_vhost/vhost_crypto.c d

[dpdk-dev] [PATCH v7 4/8] lib/librte_vhost: add request handler

2018-04-05 Thread Fan Zhang
This patch adds the implementation that parses virtio crypto request to dpdk crypto operation. Signed-off-by: Fan Zhang --- lib/librte_vhost/rte_vhost_crypto.h | 14 + lib/librte_vhost/vhost_crypto.c | 622 2 files changed, 636 insertions(+) create mode

[dpdk-dev] [PATCH v7 1/8] lib/librte_vhost: add vhost user message handlers

2018-04-05 Thread Fan Zhang
Previously, vhost library lacks the support to the vhost backend other than net such as adding private data or registering vhost-user message handlers. This patch fills the gap by adding data pointer and vhost-user pre and post message handlers to vhost library. Signed-off-by: Fan Zhang --- lib/

[dpdk-dev] [PATCH v7 0/8] vhost: introduce vhost crypto backend

2018-04-05 Thread Fan Zhang
This patchset depends on the following patch and must be applied first: "lib/librte_vhost: add virtio_crypto.h header file" (https://dpdk.org/dev/patchwork/patch/37308/) This patchset adds crypto backend suppport to vhost library including a proof-of-concept sample application. The implementation

[dpdk-dev] [PATCH v7 2/8] lib/librte_vhost: add virtio-crypto user message structure

2018-04-05 Thread Fan Zhang
This patch adds virtio-crypto spec user message structure to vhost_user. Signed-off-by: Fan Zhang --- lib/librte_vhost/rte_vhost.h | 4 lib/librte_vhost/vhost_user.h | 34 +++--- 2 files changed, 35 insertions(+), 3 deletions(-) diff --git a/lib/librte_vhost/r

Re: [dpdk-dev] [PATCH] doc: add timestamp offload for mlx5 to features table

2018-04-05 Thread Adrien Mazarguil
For completeness: Fixes: 78c7406b7b5a ("net/mlx5: add Rx HW timestamp") Cc: sta...@dpdk.org On Mon, Apr 02, 2018 at 10:01:22AM -0700, Yongseok Koh wrote: > Signed-off-by: Yongseok Koh Acked-by: Adrien Mazarguil > --- > doc/guides/nics/features/mlx5.ini | 1 + > 1 file changed, 1 insertion(+)

[dpdk-dev] [RFT] vmxnet3: coverity reported defect

2018-04-05 Thread Stephen Hemminger
I noticed Coverity defect in DPDK number 124563 was assigned to me. It looks like vmxnet3 driver code doesn't handle case where host incorrectly sends a frame with out setting SOP bit in first segment. This would lead to rxq->start_seq being NULL. Maybe something like this would fix it. I don't

[dpdk-dev] [PATCH v2 3/3] ethdev: deprecate port count function

2018-04-05 Thread Thomas Monjalon
Some DPDK applications wrongly assume these requirements: - no hotplug, i.e. ports are never detached - all allocated ports are available to the application Such application iterates over ports by its own mean. The most common pattern is to request the port count and assume ports with inde

[dpdk-dev] [PATCH v2 1/3] fix ethdev ports enumeration

2018-04-05 Thread Thomas Monjalon
Some DPDK applications wrongly assume these requirements: - no hotplug, i.e. ports are never detached - all allocated ports are available to the application Such application iterates over ports by its own mean. The most common pattern is to request the port count and assume ports with inde

[dpdk-dev] [PATCH v2 2/3] fix ethdev port id validation

2018-04-05 Thread Thomas Monjalon
Some DPDK applications wrongly assume these requirements: - no hotplug, i.e. ports are never detached - all allocated ports are available to the application Such application assume a valid port index is in the range [0..count[. There are three consequences when using such wrong design:

[dpdk-dev] [PATCH v2 0/3] ethdev: fix ports enumeration

2018-04-05 Thread Thomas Monjalon
Some DPDK applications wrongly assume these requirements: - no hotplug, i.e. ports are never detached - all allocated ports are available to the application Such application iterates over ports by its own mean. The most common pattern is to request the port count and assume ports with index in

Re: [dpdk-dev] [PATCH v3 02/21] net/virtio: vring init for packed queues

2018-04-05 Thread Jens Freimann
On Thu, Apr 05, 2018 at 10:22:28PM +0800, Tiwei Bie wrote: On Thu, Apr 05, 2018 at 12:10:12PM +0200, Jens Freimann wrote: Add and initialize descriptor data structures. Signed-off-by: Jens Freimann --- [...] diff --git a/drivers/net/virtio/virtio_ring.h b/drivers/net/virtio/virtio_ring.h ind

Re: [dpdk-dev] [PATCH v3 04/21] net/virtio: add packed virtqueue helpers

2018-04-05 Thread Jens Freimann
On Thu, Apr 05, 2018 at 10:40:29PM +0800, Tiwei Bie wrote: On Thu, Apr 05, 2018 at 04:27:51PM +0200, Maxime Coquelin wrote: On 04/05/2018 12:10 PM, Jens Freimann wrote: > Add helper functions to set/clear and check descriptor flags. > > Signed-off-by: Jens Freimann > --- > drivers/net/virtio/

[dpdk-dev] [PATCH] net/octeneontx: fix warnings

2018-04-05 Thread Stephen Hemminger
This is fix for Coverity Devect 268319 about uninitialized speed in an error case. Also drop unnecessary assignment. Signed-off-by: Stephen Hemminger --- drivers/net/octeontx/octeontx_ethdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/octeontx/octeontx_ethde

Re: [dpdk-dev] [PATCH v2 05/13] net/sfc: fix endian conversions in flow API

2018-04-05 Thread Andrew Rybchenko
Hi Adrien, On 04/04/2018 07:08 PM, Adrien Mazarguil wrote: Hi Andrew, On Wed, Apr 04, 2018 at 06:30:24PM +0300, Andrew Rybchenko wrote: Adrien, On 04/04/2018 05:57 PM, Adrien Mazarguil wrote: These conversions do not use the adequate function. Fixes: a9825ccf5bb8 ("net/sfc: support flow API

[dpdk-dev] [PATCH v4 2/3] net/mlx5: use Netlink to enable promisc / allmulti mode

2018-04-05 Thread Nelio Laranjeiro
VF devices are not able to receive promisc or allmulti traffic unless it fully requests it though Netlink. This will cause the request to be processed by the PF which will handle the request and enable it. This requires the VF to be trusted by the PF. Signed-off-by: Nelio Laranjeiro Acked-by: A

[dpdk-dev] [PATCH v4 3/3] net/mlx5: add a parameter for Netlink support in VF

2018-04-05 Thread Nelio Laranjeiro
All Netlink request the PMD will do can also be done by a iproute2 command line interface, enabling VF behavior configuration without having to modify the application nor reaching PMD limits (e.g. MAC address number limit). Signed-off-by: Nelio Laranjeiro Acked-by: Adrien Mazarguil --- doc/guid

[dpdk-dev] [PATCH v4 0/3] net/mlx5: use Netlink in VF mode

2018-04-05 Thread Nelio Laranjeiro
When MLX5 behaves in VF mode and the hypervisor have **trusted** this VF, to be able to receive specific traffic some requests must be done to configure the NIC. There is no API currently available to do it though Verbs, but there is in Linux side using Netlink. The specific cases are: - Enable/d

[dpdk-dev] [PATCH v4 1/3] net/mlx5: use Netlink to add/remove MAC addresses

2018-04-05 Thread Nelio Laranjeiro
VF devices are not able to receive traffic unless it fully requests it though Netlink. This will cause the request to be processed by the PF which will add/remove the MAC address to the VF table if the VF is trusted. Signed-off-by: Nelio Laranjeiro Acked-by: Adrien Mazarguil --- doc/guides/nic

Re: [dpdk-dev] [dpdk-stable] [PATCH] net/vmxnet3: keep link state consistent

2018-04-05 Thread Chas Williams
On Thu, Apr 5, 2018 at 6:03 AM, Thomas Monjalon wrote: > 20/03/2018 15:12, Ferruh Yigit: >> On 3/18/2018 1:45 AM, Chas Williams wrote: >> > From: Chas Williams >> > >> > The vmxnet3 never attempts link speed negotiation. As a virtual device >> > the link speed is vague at best. However, it is i

[dpdk-dev] [PATCH v2 2/4] net/nfp: update PMD for using new CPP interface

2018-04-05 Thread Alejandro Lucero
PF PMD support was based on NSPU interface. This patch changes the PMD for using the new CPP user space interface which gives more flexibility for adding new functionalities. This change just affects initialization with the datapath being the same than before. Signed-off-by: Alejandro Lucero ---

[dpdk-dev] [PATCH v2 4/4] net/nfp: remove files

2018-04-05 Thread Alejandro Lucero
New CPP interface makes NSPU interface obsolete. These files are not needed anymore. Signed-off-by: Alejandro Lucero --- drivers/net/nfp/nfp_net_eth.h | 82 -- drivers/net/nfp/nfp_nfpu.c| 108 --- drivers/net/nfp/nfp_nfpu.h| 55 drivers/net/nfp/nfp_nspu.c| 642

[dpdk-dev] [PATCH v2 3/4] doc: update NFP guide

2018-04-05 Thread Alejandro Lucero
New CPP interface changes the way firmware upload is managed by the PMD. It also supports different firmware file names for having specific firmware aplications per card. Signed-off-by: Alejandro Lucero --- doc/guides/nics/nfp.rst | 34 ++ 1 file changed, 26 inser

[dpdk-dev] [PATCH v2 0/4] NFP PF support based on new CPP interface

2018-04-05 Thread Alejandro Lucero
NFP PMD PF support requires to access the NFP chip for initialization. Current NFP PMD PF support was added based on the NSPU interface. This implies to do initialization through the NSP, a embedded ARM processor which does initialization tasks on demand. The main problem with this approach is it r

  1   2   3   >