Adding support for IPsec event
Signed-off-by: Anoob Joseph
Acked-by: Akhil Goyal
---
v4:
* No change
v3:
* No change
v2:
* No change
app/test-pmd/parameters.c | 2 ++
app/test-pmd/testpmd.c| 2 ++
2 files changed, 4 insertions(+)
diff --git a/app/test-pmd/parameters.c b/app/test-pmd/pa
Adding ESN soft limit in conf. This will be used in case of protocol
offload. Per SA, application could specify for what ESN the security
device need to notify application. In case of eth dev(inline protocol),
rte_eth_event framework would raise an IPsec event.
Signed-off-by: Anoob Joseph
Acked-b
Extending 'userdata' to be used for IPsec events too.
IPsec events would have some metadata which would uniquely identify the
security session for which the event is raised. But application would
need some construct which it can understand. The 'userdata' solves a
similar problem for inline proces
For inline protocol processing, the PMD/device is required to maintain
the ESN. But the application is required to monitor ESN overflow to
initiate SA expiry.
For such cases, application would set the ESN soft limit. An IPsec event
would be raised by rte_eth_event framework, when ESN hits the soft
Adding support for IPsec events in rte_eth_event framework. In inline
IPsec offload, the per packet protocol defined variables, like ESN,
would be managed by PMD. In such cases, PMD would need IPsec events
to notify application about various conditions like, ESN overflow.
Signed-off-by: Anoob Jose
This series enables application to set the sequence number soft limit
for IPsec offload. In inline IPsec offload, as the sequence number
(maintained by PMD/device) reaches the specified soft limit, the PMD
would raise an "IPSEC_EVENT". This event would have some metadata,
which would be used by the
rx_q fifo can only be released by kernel thread. There may be
mbuf leaks in rx_q because kernel threads are randomly stopped.
When the kni is released and netdev is unregisterd, convert the
physical address mbufs in rx_q to the virtual address in free_q.
By the way, alloc_q can be processed toget
On Tue, Apr 10, 2018 at 05:25:31PM -0700, Ananyev, Konstantin wrote:
>
>
> > -Original Message-
> > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Yongseok Koh
> > Sent: Tuesday, April 10, 2018 2:59 AM
> > To: Olivier Matz
> > Cc: Lu, Wenzhuo ; Wu, Jingjing
> > ; adrien.mazarg...@
On 4/7/18, 10:30 AM, "Jon DeVree" wrote:
This counter comes from a "hardware" register of the vmxnet3 device and
seems to behave like the MPC (Missed Packet Count) register of the Intel
NICs. So I think this data belongs in the imissed field rather than the
rx_nombuf field.
From: Tonghao Zhang
Fixes: 68451eb6 ("net/bonding: call through EAL on create/free")
Cc: sta...@dpdk.org
Signed-off-by: Tonghao Zhang
---
drivers/net/bonding/rte_eth_bond_pmd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/bonding/rte_eth_bond_pmd.c
b/drivers/
From: Tonghao Zhang
When creating bond device with mode6, dpdk will create
mempool for arp packets. If free the bond device and
create it with same name, there will be an error. Because
the mempool is not freed when destroying bond device.
Fixes: 06fe78b9 ("bond: add mode 6")
Fixes: ea0c20ea ("a
This patch add comment for flow rss parse function in order
to explain some important info. This patch also delete some
useless code for queue index check for RSS queue region
configuration.
Fixes: ecad87d22383 ("net/i40e: move RSS to flow API")
Signed-off-by: Wei Zhao
Tested-by: Peng Yuan
---
Hi Thomas,
Thanks for the comments. Will send a revised patch with your suggestions.
Anoob
On 10/04/18 14:41, Thomas Monjalon wrote:
Hi,
21/03/2018 12:11, Anoob Joseph:
Adding support for IPsec events in rte_eth_event framework. In inline
IPsec offload, the per packet protocol defined variab
dev_start sets *dev_attached* after setup queues, this sets device to
invalid state since no frontend is attached. Also destroy_device set
*started* to zero which makes *allow_queuing* always zero until dev_start
get called again. Actually, we should not determine queues existence by
*dev_attached*
Thanks to point this out, I forgot to run 'git add' before generating patch.
Need following change also:
--- a/drivers/net/vhost/rte_eth_vhost.c
+++ b/drivers/net/vhost/rte_eth_vhost.c
@@ -655,9 +655,8 @@ destroy_device(int vid)
eth_dev = list->eth_dev;
internal = eth_dev->data->d
> -Original Message-
> From: Zhang, Qi Z
> Sent: Tuesday, April 10, 2018 6:45 PM
> To: Zhao1, Wei ; dev@dpdk.org
> Cc: sta...@dpdk.org
> Subject: RE: [PATCH v2] net/i40e: fix flow RSS queue index check error
>
>
>
> > -Original Message-
> > From: Zhao1, Wei
> > Sent: Tuesday, A
-Original Message-
> Date: Wed, 11 Apr 2018 00:33:14 +
> From: "Ananyev, Konstantin"
> To: Jerin Jacob
> CC: Olivier Matz , "dev@dpdk.org" ,
> "Richardson, Bruce"
> Subject: RE: [dpdk-dev] [PATCH] ring: relax alignment constraint on ring
> structure
>
Hi Konstantin,
>
> > -
Hi Jerin,
> -Original Message-
> From: Jerin Jacob [mailto:jerin.ja...@caviumnetworks.com]
> Sent: Friday, April 6, 2018 2:26 AM
> To: Ananyev, Konstantin
> Cc: Olivier Matz ; dev@dpdk.org; Richardson, Bruce
>
> Subject: Re: [dpdk-dev] [PATCH] ring: relax alignment constraint on ring
>
> -Original Message-
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Yongseok Koh
> Sent: Tuesday, April 10, 2018 2:59 AM
> To: Olivier Matz
> Cc: Lu, Wenzhuo ; Wu, Jingjing ;
> adrien.mazarg...@6wind.com;
> nelio.laranje...@6wind.com; dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATC
04/04/2018 16:40, Anatoly Burakov:
> We already set IOVA addresses of memsegs and memzones to VA
> address during initialization, so we don't need to check
> whether we're in RTE_IOVA_VA mode anywhere else.
>
> Cc: sta...@dpdk.org
>
> Signed-off-by: Anatoly Burakov
> Acked-by: Santosh Shukla
S
Signed-off-by: Gaetan Rivet
---
lib/Makefile | 2 +-
lib/librte_ether/Makefile| 3 +-
lib/librte_ether/rte_class_eth.c | 79
3 files changed, 82 insertions(+), 2 deletions(-)
create mode 100644 lib/librte_ether/rte_class_eth.
The vdev bus parses a field "driver", matching
a vdev driver name with one passed as follows:
"bus=vdev,driver="
Signed-off-by: Gaetan Rivet
---
drivers/bus/vdev/Makefile | 1 +
drivers/bus/vdev/vdev.c | 14 --
2 files changed, 13 insertions(+), 2 deletions(-)
diff --git
This iterator can be customized with a comparison function that will
trigger a stopping condition.
It can be leveraged to write several different iterators that have
similar but non-identical purposes.
It is private to librte_ether.
Signed-off-by: Gaetan Rivet
---
lib/librte_ether/Makefile
Signed-off-by: Gaetan Rivet
---
drivers/bus/vdev/Makefile | 2 +-
drivers/bus/vdev/vdev.c | 42 ++
2 files changed, 43 insertions(+), 1 deletion(-)
diff --git a/drivers/bus/vdev/Makefile b/drivers/bus/vdev/Makefile
index 24d424a38..52728833c 100644
---
A new interactive command is offered:
show device
This commands lists all rte_device element matching the device
description. e.g.:
show device bus=pci
show device bus=vdev
show device bus=vdev/class=eth
show device bus=vdev,driver=net_ring/class=eth
show device bus=vdev/class
If start is set and a device before it matches the data,
this device is returned.
This induces potentially infinite loops.
Fixes: c7fe1eea8a74 ("bus: simplify finding starting point")
Cc: sta...@dpdk.org
Signed-off-by: Gaetan Rivet
---
drivers/bus/vdev/rte_bus_vdev.h | 3 +++
drivers/bus/vdev
The eth device class can now parse a field name,
matching the eth_dev name with one passed as
"class=eth,name=xx"
Signed-off-by: Gaetan Rivet
---
lib/librte_ether/rte_class_eth.c | 7 +++
1 file changed, 7 insertions(+)
diff --git a/lib/librte_ether/rte_class_eth.c b/lib/librte_ethe
Signed-off-by: Gaetan Rivet
---
drivers/bus/pci/Makefile | 2 +-
drivers/bus/pci/pci_common.c | 42 ++
2 files changed, 43 insertions(+), 1 deletion(-)
diff --git a/drivers/bus/pci/Makefile b/drivers/bus/pci/Makefile
index f3df1c4ce..73498dc77 100644
If start is set, and a device before it matches the data
passed for comparison, then this first device is returned.
This induces potentially infinite loops.
Fixes: c7fe1eea8a74 ("bus: simplify finding starting point")
Cc: sta...@dpdk.org
Signed-off-by: Gaetan Rivet
---
drivers/bus/pci/pci_comm
The PCI bus can now parse a matching field "id" as follows:
"bus=pci,id=:00:00.0"
or
"bus=pci,id=00:00.0"
Signed-off-by: Gaetan Rivet
---
drivers/bus/pci/pci_common.c | 28 ++--
1 file changed, 26 insertions(+), 2 deletions(-)
diff --git a/drivers
This function can be used as a callback to
rte_kvargs_process.
This should reduce code duplication.
Signed-off-by: Gaetan Rivet
---
lib/Makefile | 1 +
lib/librte_kvargs/rte_kvargs.c | 10 ++
lib/librte_kvargs/rte_kvargs.h | 28 ++
Use the iteration hooks in the abstraction layers to perform the
requested filtering on the internal device lists.
Signed-off-by: Gaetan Rivet
---
lib/librte_eal/common/eal_common_dev.c | 168
lib/librte_eal/common/include/rte_dev.h | 26 +
lib/librte_eal/r
Signed-off-by: Gaetan Rivet
---
lib/librte_eal/common/include/rte_class.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/lib/librte_eal/common/include/rte_class.h
b/lib/librte_eal/common/include/rte_class.h
index e8176f5e1..9d5b06807 100644
--- a/lib/librte_eal/common/include/rte_class.h
++
Signed-off-by: Gaetan Rivet
---
lib/librte_eal/common/include/rte_bus.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/lib/librte_eal/common/include/rte_bus.h
b/lib/librte_eal/common/include/rte_bus.h
index eb9eded4e..747baf140 100644
--- a/lib/librte_eal/common/include/rte_bus.h
+++ b/lib/
Parse a device description.
Split this description in their relevant part for each layers.
No dynamic allocation is performed.
Signed-off-by: Gaetan Rivet
---
lib/Makefile| 1 +
lib/librte_eal/bsdapp/eal/Makefile | 1 +
lib/librte_eal/common/eal_common_dev.c
A device iterator allows iterating over a set of devices.
This set is defined by the two descriptions offered,
* rte_bus
* rte_class
Only one description can be provided, or both. It is not allowed to
provide no description at all.
Each layer of abstraction then performs a filter based on th
Signed-off-by: Gaetan Rivet
---
lib/librte_eal/common/include/rte_common.h | 23 +++
1 file changed, 23 insertions(+)
diff --git a/lib/librte_eal/common/include/rte_common.h
b/lib/librte_eal/common/include/rte_common.h
index 8f04518f7..f326e1c30 100644
--- a/lib/librte_eal/c
This patchset introduces a new EAL API for querying devices,
filtered by arbitrary properties.
The following elements are introduced to this end:
* A new object, "rte_class", is used to describe
the device class abstraction layer (eth, crypto, ...).
* Both rte_bus and rte_class now offer a
Signed-off-by: Gaetan Rivet
---
lib/librte_eal/common/include/rte_class.h | 5 +
1 file changed, 5 insertions(+)
diff --git a/lib/librte_eal/common/include/rte_class.h
b/lib/librte_eal/common/include/rte_class.h
index b5e550a34..e8176f5e1 100644
--- a/lib/librte_eal/common/include/rte_class
Signed-off-by: Gaetan Rivet
---
lib/librte_eal/bsdapp/eal/Makefile | 1 +
lib/librte_eal/common/Makefile | 2 +-
lib/librte_eal/common/eal_common_class.c | 62 +++
lib/librte_eal/common/include/rte_class.h | 121 +
lib/librte_eal
Build a central list to quickly see each used priorities for
constructors, allowing to verify that they are both above 100 and in the
proper order.
Signed-off-by: Gaetan Rivet
Acked-by: Neil Horman
Acked-by: Shreyansh Jain
---
lib/librte_eal/common/eal_common_log.c | 2 +-
lib/librte_eal/c
Signed-off-by: Gaetan Rivet
---
lib/Makefile | 3 +--
lib/librte_eal/common/Makefile| 2 +-
lib/librte_kvargs/Makefile| 3 ++-
lib/librte_kvargs/rte_kvargs.c
09/04/2018 11:07, Jerin Jacob:
> -Original Message-
> > Date: Mon, 9 Apr 2018 14:28:37 +0530
> > From: Hemant Agrawal
> > To: dev@dpdk.org
> > CC: jerin.ja...@caviumnetworks.com, Hemant Agrawal
> > Subject: [PATCH] usertools: change to SPDX license identifier
> > X-Mailer: git-send-email
09/04/2018 12:24, Neil Horman:
> On Mon, Apr 09, 2018 at 02:28:36PM +0530, Hemant Agrawal wrote:
> > CC: nhor...@tuxdriver.com
> > Signed-off-by: Hemant Agrawal
> > ---
> > usertools/dpdk-pmdinfo.py | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/usertools/dpdk-pmdinfo.py b/user
Signed-off-by: Thomas Monjalon
---
Patch for the website (to w...@dpdk.org) Cc'ed to dev@dpdk.org
v2:
- more volunteers
- propose to do .1 release after -rc1 of next branch.
---
dev/roadmap.html | 37 -
1 file changed, 32 insertions(+), 5 dele
20/03/2018 20:20, Shahaf Shuler:
> This series is to align the format of the copyright in Mellanox related files.
>
> On v2:
> - remove completely the BSD licence from mlx PMD docs
> - add more patches to align files not under drivers/net/mlx*
Applied, thanks
10/04/2018 00:15, Jan Viktorin:
> Hi all,
>
> I've updated all relevant code to SPDX license. The last commit
> also updates the Cavium copyright, I've separated it for clarity
> otherwise it can be squashed into 02.
Applied, thanks
30/03/2018 12:40, Ferruh Yigit:
> On 3/28/2018 8:30 PM, Pablo de Lara wrote:
> > The MAINTAINERS file contains information of the maintainers
> > of the different components on DPDK.
> > However, it does not give any information on who maintains the
> > different subtrees which accept new commits f
04/04/2018 17:13, Ferruh Yigit:
> Cc: Helin Zhang
>
> Signed-off-by: Ferruh Yigit
Applied, thanks
30/03/2018 23:57, Yong Wang:
> Signed-off-by: Yong Wang
Applied, thanks
Hi, big issue here.
This patch does not compile on Linux with ICC or GCC < 4.9
because of a missing C11 header:
#include
GCC 4.9 is recommended in doc/guides/linux_gsg/sys_reqs.rst.
But GCC 4.8 is used by SLES 12, RHEL 7, etc...
Note: Intel compilation tests are running with a backlog of
Hi Ferruh,
We dropped this patch from the series - comment inline.
On 18-04-10 07:59 AM, Ferruh Yigit wrote:
On 4/6/2018 11:32 PM, Scott Branden wrote:
On 18-04-06 02:31 PM, Ferruh Yigit wrote:
On 4/6/2018 7:10 PM, Scott Branden wrote:
Hi Ferruh,
Somehow I did not receive your other email
On 4/10/2018 10:43 AM, Remy Horton wrote:
> The optimal values of several transmission & reception related parameters,
> such as burst sizes, descriptor ring sizes, and number of queues, varies
> between different network interface devices. This patchset allows individual
> PMDs to specify their pr
On 4/10/2018 9:29 AM, Thomas Monjalon wrote:
> 10/04/2018 10:20, Nélio Laranjeiro:
>> On Tue, Apr 10, 2018 at 09:16:31AM +0300, Shahaf Shuler wrote:
>>> When application works with LSC interrupts the ethdev layer skips
>>> the PMD callback and update according to the link status exists on
>>> devic
On 4/10/2018 2:34 PM, Thomas Monjalon wrote:
> 09/04/2018 14:09, Ferruh Yigit:
>> Public struct rte_eth_dev_info has a "struct rte_pci_device" field in it
>> although it is common for all ethdev in all buses.
>>
>> Replacing pci specific struct with generic device struct and updating
>> places that
> -Original Message-
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Lu, Wenzhuo
> Sent: Monday, April 9, 2018 8:49 AM
> To: Martin Weiser; Ananyev, Konstantin
> Cc: dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH] net/ixgbe: allow for setting 2.5G and 5G
> speeds on X550
>
> Hi,
>
On 4/9/2018 12:58 PM, Andrew Rybchenko wrote:
> v1 -> v2:
> - add patch to fix clang build error
>
> Andrew Rybchenko (3):
> net/sfc/base: fix comparison always true warning
> net/sfc: support loopback mode configuration
> app/testpmd: add commands to set loopback mode
Series applied to dp
On 4/9/2018 2:19 PM, Sunil Kumar Kori wrote:
> Signed-off-by: Sunil Kumar Kori
> ---
> drivers/net/dpaa2/dpaa2_ethdev.c | 63
> +---
> drivers/net/dpaa2/dpaa2_rxtx.c | 32 +++-
I see more old API related usage after this patch, can you please
On 4/9/2018 2:19 PM, Sunil Kumar Kori wrote:
> Signed-off-by: Sunil Kumar Kori
> ---
> drivers/net/dpaa/dpaa_ethdev.c | 46
> ++
> 1 file changed, 42 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/net/dpaa/dpaa_ethdev.c b/drivers/net/dpaa/dpaa_eth
RTE_FLOW_ACTION_TYPE_PORT_ID brings the ability to inject matching traffic
into a different device, as identified by its DPDK port ID.
This is normally only supported when the target port ID has some kind of
relationship with the port ID the flow rule is created against, such as
being exposed by a
This patch adds the missing action counterpart to the PHY_PORT pattern
item, that is, the ability to directly inject matching traffic into a
physical port of the underlying device.
It breaks ABI compatibility for the following public functions:
- rte_flow_copy()
- rte_flow_create()
- rte_flow_que
While RTE_FLOW_ITEM_TYPE_PORT refers to physical ports of the underlying
device using specific identifiers, these are often confused with DPDK port
IDs exposed to applications in the global name space.
Since this pattern item is seldom used, rename it RTE_FLOW_ITEM_PHY_PORT
for better clarity.
No
TPID handling in rte_flow VLAN and E_TAG pattern item definitions is not
consistent with the normal stacking order of pattern items, which is
confusing to applications.
Problem is that when followed by one of these layers, the EtherType field
of the preceding layer keeps its "inner" definition, an
Contrary to all other pattern items, these are inconsistently documented as
affecting traffic instead of simply matching its origin, without provision
for the latter.
This commit clarifies documentation and updates PMDs since the original
behavior now has to be explicitly requested using the new t
VLAN TCI is a 16-bit field broken down as PCP (3b), DEI (1b) and VID (12b).
The default mask used by PMDs for the VLAN pattern when one isn't provided
by the application comprises the entire TCI, which is problematic because
most devices only support VID matching.
This forces applications to alwa
This new attribute enables applications to create flow rules that do not
simply match traffic whose origin is specified in the pattern (e.g. some
non-default physical port or VF), but actively affect it by applying the
flow rule at the lowest possible level in the underlying device.
It breaks ABI
Since its inception, the rte_flow RSS action has been relying in part on
external struct rte_eth_rss_conf for compatibility with the legacy RSS API.
This structure lacks parameters such as the hash algorithm to use, and more
recently, a method to tell which layer RSS should be performed on [1].
Gi
RSS hash types (ETH_RSS_* macros defined in rte_ethdev.h) describe the
protocol header fields of a packet that must be taken into account while
computing RSS.
When facing encapsulated (e.g. tunneled) packets, there is an ambiguity as
to whether these should apply to inner or outer packets. Applica
This patch replaces C99-style flexible arrays in struct rte_flow_action_rss
and struct rte_flow_item_raw with standard pointers to the same data.
They proved difficult to use in the field (e.g. no possibility of static
initialization) and unsuitable for C++ applications.
Affected PMDs and example
By definition, RSS involves some kind of hash algorithm, usually Toeplitz.
Until now it could not be modified on a flow rule basis and PMDs had to
always assume RTE_ETH_HASH_FUNCTION_DEFAULT, which remains the default
behavior when unspecified (0).
This breaks ABI compatibility for the following
This section has become less relevant since the flow API (rte_flow) is now
a mature DPDK API with applications developed directly on top of it instead
of an afterthought.
This patch removes it for the following reasons:
- It has never been updated to track the latest changes in the legacy
filte
This patch makes the following changes to flow rule actions:
- List order now matters, they are redefined as performed first to last
instead of "all simultaneously".
- Repeated actions are now supported (e.g. specifying QUEUE multiple times
now duplicates traffic among them). Previously only
Although pattern items and actions examples end with "and so on", these
lists include all existing definitions and as a result are updated almost
every time new types are added. This is cumbersome and pointless.
This patch also synchronizes Doxygen and external API documentation wording
with a sli
Upcoming changes in relation to the handling of actions list will make the
DUP action redundant as specifying several QUEUE actions will achieve the
same behavior. Besides, no PMD implements this action.
By removing an entry from enum rte_flow_action_type, this patch breaks ABI
compatibility for t
These enable more precise reporting of objects responsible for errors.
This breaks ABI compatibility for the following public functions:
- rte_flow_create()
- rte_flow_destroy()
- rte_flow_error_set()
- rte_flow_flush()
- rte_flow_isolate()
- rte_flow_query()
- rte_flow_validate()
Signed-off-by:
As summarized in a prior RFC [1], the flow API (rte_flow) was chosen as a
means to manage switch offloads supported by many devices (usually going by
names such as E-Switch or vSwitch) through user-specified flow rules.
Combined with the need to support encap/decap actions, this requires a
change
On 03-Apr-18 2:04 PM, Olivier Matz wrote:
To avoid code duplication, add a parameter to rte_ctrl_thread_create()
to specify the name of the thread.
This requires to add a wrapper for the thread start routine in
rte_thread_init(), which will first wait that the thread is configured.
Signed-off-b
Original implementation lacks the on/off toggle.
This patch shows up as a fix because it has been a popular request ever
since the first DPDK release with the original implementation but was never
addressed.
Fixes: abc3d81aca1b ("app/testpmd: add item raw to flow command")
Cc: sta...@dpdk.org
Si
Fixes: b1a4b4cbc0a8 ("ethdev: introduce generic flow API")
Cc: sta...@dpdk.org
Signed-off-by: Adrien Mazarguil
Acked-by: Nelio Laranjeiro
---
lib/librte_ether/rte_flow.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/lib/librte_ether/rte_flow.h b/lib/librte_ether/rte_flow.h
index 13e4202
The rss_conf field is defined as a pointer to struct rte_eth_rss_conf.
Even assuming it is permanently allocated and a pointer copy is safe,
pointed data may change and not reflect an applied flow rule anymore.
This patch aligns with testpmd by making a deep copy instead.
Fixes: 18da437b5f63 ("e
Users cannot override the default RSS settings when entering a RSS action,
only a list of queues can be provided.
This patch enables them to set a RSS hash key and types for a flow rule.
Fixes: 05d34c6e9d2c ("app/testpmd: add queue actions to flow command")
Cc: sta...@dpdk.org
Signed-off-by: Adr
Except for a list of queues, RSS configuration (hash key and fields) cannot
be specified from the flow command line and testpmd does not provide safe
defaults either.
In order to validate their implementation with testpmd, PMDs had to
interpret its NULL RSS configuration parameters somehow, howeve
Configuration structure is not optional with flow rule actions that expect
one; this pointer is not supposed to be NULL and PMDs should not have to
verify it.
Like pattern item spec/last/mask fields, it is currently set when at least
one configuration parameter is provided on the command line. Thi
The lack of a working completion for RSS queues was overlooked during
development; until now only "end" was displayed as a valid token.
Fixes: 05d34c6e9d2c ("app/testpmd: add queue actions to flow command")
Cc: sta...@dpdk.org
Signed-off-by: Adrien Mazarguil
Cc: Wenzhuo Lu
Cc: Jingjing Wu
---
When an unsupported hash type is part of a RSS configuration structure, it
is silently ignored instead of triggering an error. This may lead
applications to assume that such types are accepted, while they are in fact
not part of the resulting flow rules.
Fixes: 078b8b452e6b ("net/mlx4: add RSS flo
The number of queues provided by the application is not checked against
parser's supported maximum.
Fixes: 3d821d6fea40 ("net/mlx5: support RSS action flow rule")
Cc: sta...@dpdk.org
Cc: Nelio Laranjeiro
Signed-off-by: Adrien Mazarguil
Acked-by: Nelio Laranjeiro
---
drivers/net/mlx5/mlx5_flow
Some values are interpreted without endian conversion and/or without
taking the proper mask into account.
Fixes: 5ef3b79fdfe6 ("net/bnxt: support flow filter ops")
Cc: sta...@dpdk.org
Cc: Ajit Khaparde
Signed-off-by: Adrien Mazarguil
---
drivers/net/bnxt/bnxt_filter.c | 14 +-
1 fi
When memory cannot be allocated for a flow rule, its RSS context reference
is not dropped.
Fixes: 078b8b452e6b ("net/mlx4: add RSS flow rule action support")
Cc: sta...@dpdk.org
Signed-off-by: Adrien Mazarguil
Cc: Shahaf Shuler
---
drivers/net/mlx4/mlx4_flow.c | 5 -
1 file changed, 4 inse
This series contains several fixes for rte_flow and its implementation in
PMDs and testpmd. Upcoming work on the flow API depends on it.
v4 changes:
- Rebased again.
- The reliance on rte_eth_dev_rss_hash_conf_get() was removed from patch #7,
see updated patch for details.
v3 changes:
- Rebas
On 4/9/2018 6:37 AM, Rasesh Mody wrote:
> From: Harish Patil
>
> Ethdev RX offloads API has changed since:
> commit ce17eddefc20 ("ethdev: introduce Rx queue offloads API")
>
> This patch makes use of DEV_RX_OFFLOAD_JUMBO_FRAME offload flag
> to advertise jumbo frame support.
>
> Signed-off-by:
On 03-Apr-18 2:04 PM, Olivier Matz wrote:
Some parts of dpdk use their own management threads. Most of the time,
the affinity of the thread is not properly set: it should not be scheduled
on the dataplane cores, because interrupting them can cause packet losses.
This patchset introduces a new wr
On 03-Apr-18 2:04 PM, Olivier Matz wrote:
Only a cosmetic change: the *_LEN defines are already used
when defining the buffer. Using sizeof() ensures that the length
stays consistent, even if the definition is modified.
Signed-off-by: Olivier Matz
---
Reviewed-by: Anatoly Burakov
--
Thanks,
On 03-Apr-18 2:04 PM, Olivier Matz wrote:
The management threads must not bother the dataplane or service cores.
Set the affinity of these threads accordingly.
Signed-off-by: Olivier Matz
---
Reviewed-by: Anatoly Burakov
--
Thanks,
Anatoly
On 03-Apr-18 2:04 PM, Olivier Matz wrote:
Many parts of dpdk use their own management threads. Introduce a new
wrapper for thread creation that will be extended in next commits to set
the name and affinity.
To be consistent with other DPDK APIs, the return value is negative in
case of error, whi
Thanks for the review.
I have sent an updated patch and will send patch to remove experimental
from API for next release
Thanks,
Shweta
On Wed, Apr 4, 2018 at 11:40 AM, Bruce Richardson <
bruce.richard...@intel.com> wrote:
> On Wed, Apr 04, 2018 at 11:14:35AM +0100, Ferruh Yigit wrote:
> > On 4/
On FreeBSD, make defconfig generates the config as "defconfig_x86_64-bsdapp-",
which does not resolve to any known config file.
This fix starts by introducing a 'compiler' variable which is set by executing
"${CC} --version" and pulling out the name of the compiler.
On FreeBDS, we get amd64 out o
On 10-Apr-18 4:44 PM, David Hunt wrote:
On FreeBSD, make defconfig generates the config as "defconfig_x86_64-bsdapp-",
which does not resolve to any known config file.
This fix starts by introducing a 'compiler' variable which is set by executing
"${CC} --version" and pulling out the name of the
On 10/4/2018 4:28 PM, Thomas Monjalon wrote:
10/04/2018 17:08, David Hunt:
Fixes: bce6c42c4ad5 ("mk: add sensible default target with defconfig")
Signed-off-by: David Hunt
I am sorry, I have to nack because the change is not explained.
Apologies, Thomas. I have now added an explanation o
From: Shweta Choudaha
Add ixgbe API to enable SBP bit in FCTRL register
to allow receiving packets that may otherwise be
considered length errors by ixgbe and dropped
Signed-off-by: Shweta Choudaha
Reviewed-by: Chas Williams
Reviewed-by: Luca Boccassi
---
drivers/net/ixgbe/rte_pmd_ixgbe.c
On Tue, Mar 13, 2018 at 06:05:34PM +, Ferruh Yigit wrote:
> Update link status related feature document items and minor updates in
> some link status related functions.
>
> Signed-off-by: Ferruh Yigit
> ---
> doc/guides/nics/features/fm10k.ini | 2 ++
> doc/guides/nics/features/fm10k_vf
1 - 100 of 206 matches
Mail list logo
