On Tue, Apr 24, 2018 at 9:44 AM, Arnon Warshavsky wrote:
> please ignore this patchset.
> The v6 formatting is messed up. resending
> Sorry for the mess
>
My bad. Ignore the ignore request
Its gmail thread aggregation view that made me think I mixed v5 and v6.
thanks
/Arnon
On 4/24/2018 2:58 AM, Arnon Warshavsky wrote:
replace panic calls with log and return value.
Signed-off-by: Arnon Warshavsky
---
Acked-by: Akhil Goyal
please ignore this patchset.
The v6 formatting is messed up. resending
Sorry for the mess
On Tue, Apr 24, 2018 at 9:41 AM, Arnon Warshavsky wrote:
> The purpose of this patch series is to cleanup the library code
> from paths that end up aborting the process,
> and move to checking error values,
Change some local functions return type from void to int.
This change does not break ABI as the functions are internal.
Panic thrown from threads was not handled in this patch
Signed-off-by: Arnon Warshavsky
---
lib/librte_eal/bsdapp/eal/eal.c | 70
lib/librte_eal/
replace panic calls with log and return value.
Signed-off-by: Arnon Warshavsky
---
lib/librte_eal/linuxapp/eal/eal_hugepage_info.c | 37 +
1 file changed, 26 insertions(+), 11 deletions(-)
diff --git a/lib/librte_eal/linuxapp/eal/eal_hugepage_info.c
b/lib/librte_eal/lin
replace panic calls with log and return value.
Thread function removes the noreturn attribute.
Signed-off-by: Arnon Warshavsky
---
lib/librte_eal/linuxapp/eal/eal_interrupts.c | 25 ++---
1 file changed, 18 insertions(+), 7 deletions(-)
diff --git a/lib/librte_eal/linuxapp/e
This patch adds a new function that is called
per every checked patch,
and alerts for new instances of rte_panic/rte_exit.
The check excludes comments, and alerts in the case
of a positive balance between additions and removals.
Signed-off-by: Arnon Warshavsky
---
devtools/checkpatches.sh | 95 +
Local function to this file,
changing from void to int is non-abi-breaking
Signed-off-by: Arnon Warshavsky
---
lib/librte_ether/rte_ethdev.c | 42 ++
lib/librte_ether/rte_ethdev.h | 4 +++-
2 files changed, 33 insertions(+), 13 deletions(-)
diff --git a/
replace panic calls with log and return value.
Signed-off-by: Arnon Warshavsky
---
lib/librte_eventdev/rte_eventdev_pmd_pci.h | 8 +---
lib/librte_eventdev/rte_eventdev_pmd_vdev.h | 8 +---
2 files changed, 10 insertions(+), 6 deletions(-)
diff --git a/lib/librte_eventdev/rte_eventdev_
replace panic calls with log and return value.
Local function to this file,
changing from void to int is non-abi-breaking
Signed-off-by: Arnon Warshavsky
---
v6:
- replaced rte_log with pmd log macro
drivers/net/ixgbe/ixgbe_ethdev.c | 6 --
drivers/net/ixgbe/ixgbe_ethdev.h | 2 +-
drive
replace panic calls with log and return value.
Local function to this file,
changing from void to int is non-abi-breaking
Signed-off-by: Arnon Warshavsky
---
lib/librte_kni/rte_kni.c | 18 --
lib/librte_kni/rte_kni_fifo.h | 11 ---
2 files changed, 20 insertions(+),
replace panic calls with log and return value.
Local function to this file,
changing from void to int is non-abi-breaking
Signed-off-by: Arnon Warshavsky
---
v6:
- replaced rte_log with pmd log macro
drivers/net/e1000/e1000_ethdev.h | 2 +-
drivers/net/e1000/igb_ethdev.c | 4 +++-
drivers
replace panic calls with log and return value.
Local functions to this file,
changing from void to int are non-abi-breaking
Signed-off-by: Arnon Warshavsky
---
drivers/net/bonding/rte_eth_bond_8023ad.c | 29 ++-
drivers/net/bonding/rte_eth_bond_8023ad_private.h | 2 +
replace panic calls with log and return value.
Signed-off-by: Arnon Warshavsky
---
drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c | 8 +---
drivers/crypto/dpaa_sec/dpaa_sec.c | 8 +---
2 files changed, 10 insertions(+), 6 deletions(-)
diff --git a/drivers/crypto/dpaa2_sec/dpaa2_se
The purpose of this patch series is to cleanup the library code
from paths that end up aborting the process,
and move to checking error values, in order to allow the running process
perform an orderly teardown or other mitigation of the event.
This patch modifies the majority of rte_panic calls
un
Another idea would be to keep the synchronization at the thread level and let
the application handle RCU. This will keep the cost down if the application has
multiple tables requiring RCU. It will also allow the application to use its
own methods to declare end of quiescent period.
However, the
A gentle reminder,
I am curious to know if/how rte_hash is thread safe for lookups.It is not
obvious to me how following code is thread safe:
_rte_hash_lookup_with_hash(const struct rte_hash *h, const void *key,
hash_sig_t sig, void **data)
{
…
Correct couple port id from uint8_t to uint16_t.
Fixes: f8244c6399d9 ("ethdev: increase port id range")
Cc: sta...@dpdk.org
Signed-off-by: Qi Zhang
---
app/test-pmd/cmdline.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/c
Correct token for queue start stop command.
Fixes: 5f4ec54f1d16 ("testpmd: queue start and stop")
Cc: sta...@dpdk.org
Signed-off-by: Qi Zhang
---
app/test-pmd/cmdline.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c
index 99dc
dpdk-procinfo, as a secondary process, cannot fetch stats for vdev.
This patch enables that by attaching the port from the shared data.
We also fill the eth dev ops, with only some ops works in secondary
process, for example, stats_get().
Note that, we still cannot Rx/Tx packets on the ports whic
As we could add virtual devices from different threads now, we
add a spin lock to protect the vdev device list.
Suggested-by: Anatoly Burakov
Signed-off-by: Jianfeng Tan
Reviewed-by: Qi Zhang
Acked-by: Anatoly Burakov
---
drivers/bus/vdev/vdev.c | 95 +++---
To scan the vdevs in primary, we send request to primary process
to obtain the names for vdevs.
Only the name is shared from the primary. In probe(), the device
driver is supposed to locate (or request more) the detail
information from the primary.
Signed-off-by: Jianfeng Tan
Reviewed-by: Qi Zha
Adjust the init sequence: put mp channel init before bus scan
so that we can init the vdev bus through mp channel in the
secondary process before the bus scan.
Signed-off-by: Jianfeng Tan
Reviewed-by: Qi Zhang
---
lib/librte_eal/bsdapp/eal/eal.c | 23 +--
lib/librte_eal/li
We introduced private rte_eth_dev_data to allow vdev to be created
both in primary process and secondary process(es). This is not
friendly to multi-process model, for example, it leads to port id
contention issue if two processes both find the data entry is free.
And to get stats of primary vdev i
v5:
- Addess a code style issue and an implementation bug as suggested
by Anatoly.
v4:
- Change the lock code style as suggested by Anatoly.
- Add function note as suggested by Anatoly.
v3:
- Update doc.
- Rebase on master.
v2:
- Add spinlock for vdev device list as suggested by
> -Original Message-
> From: Burakov, Anatoly
> Sent: Monday, April 23, 2018 5:55 PM
> To: Tan, Jianfeng; dev@dpdk.org
> Cc: tho...@monjalon.net
> Subject: Re: [dpdk-dev] [PATCH v4 3/5] bus/vdev: bus scan by multi-process
> channel
>
> On 20-Apr-18 5:57 PM, Jianfeng Tan wrote:
> > To sca
Hi Ferruh,
> -Original Message-
> From: Ferruh Yigit
> Sent: Tuesday, April 24, 2018 12:13 AM
> To: Xueming(Steven) Li ; Wenzhuo Lu
> ; Jingjing Wu
> ; Thomas Monjalon ; Adrien
> Mazarguil
>
> Cc: Nélio Laranjeiro ; Shahaf Shuler
> ; dev@dpdk.org;
> Olivier Matz
> Subject: Re: [dpdk-
On Tue, 24 Apr 2018 09:18:54 +0530
Jerin Jacob wrote:
> -Original Message-
> > Date: Mon, 23 Apr 2018 17:48:50 -0700
> > From: Jim Murphy
> > To: Stephen Hemminger
> > Cc: Brijesh Singh , dev@dpdk.org
> > Subject: Re: [dpdk-dev] rte_hash thread safe
> >
> > Anecdotally I've heard that
On Mon, 23 Apr 2018 18:38:53 -0700
Yongseok Koh wrote:
> This patch introduces a new way of attaching an external buffer to a mbuf.
>
> Attaching an external buffer is quite similar to mbuf indirection in
> replacing buffer addresses and length of a mbuf, but a few differences:
> - When an ind
-Original Message-
> Date: Mon, 23 Apr 2018 17:48:50 -0700
> From: Jim Murphy
> To: Stephen Hemminger
> Cc: Brijesh Singh , dev@dpdk.org
> Subject: Re: [dpdk-dev] rte_hash thread safe
>
> Anecdotally I've heard that the urcu hash implementation is slower than
> rte_hash based on pure loo
> -Original Message-
> From: Yigit, Ferruh
> Sent: Tuesday, April 24, 2018 1:45 AM
> To: Zhang, Qi Z ; tho...@monjalon.net
> Cc: Ananyev, Konstantin ; dev@dpdk.org;
> Xing, Beilei ; Wu, Jingjing ;
> Lu, Wenzhuo
> Subject: Re: [PATCH v7 4/5] app/testpmd: enable queue ring size configure
>
> + if (*vfinfo == NULL) {
> > + RTE_LOG(ERR, PMD, "%s() Cannot allocate memory for private
> VF data\n",
> > + __func__);
>
> Please use PMD_DRV_LOG since that has per driver logging control rather
> than global log.
>
Missed that one..Thanks
The basic operations for ports enumeration should not be
considered as experimental in DPDK 18.05.
The iterator RTE_ETH_FOREACH_DEV was introduced in DPDK 17.05.
It uses the function the rte_eth_find_next_owned_by() to get
only ownerless ports. Its API can be considered stable.
So the flag experim
Right, the threads using the DPDK libraries must do the right RCU stuff,
declare quiescent, etc.
I mentioned hooks to address the licensing issue. So for places in rte_hash
were synchronization must be done a no-op function could be called but
users could replace that function with one of their ch
On Mon, Apr 23, 2018 at 11:53:04AM +, Ananyev, Konstantin wrote:
[...]
> > @@ -693,9 +711,14 @@ rte_mbuf_to_baddr(struct rte_mbuf *md)
> > #define RTE_MBUF_INDIRECT(mb) ((mb)->ol_flags & IND_ATTACHED_MBUF)
> >
> > /**
> > + * Returns TRUE if given mbuf has external buffer, or FALSE otherwi
If PMD delivers Rx packets with non-direct mbuf, ol_flags should not be
overwritten. For mlx5 PMD, if Multi-Packet RQ is enabled, Rx packets could
be externally attached mbufs.
Signed-off-by: Yongseok Koh
---
app/test-pmd/csumonly.c | 3 +++
app/test-pmd/macfwd.c | 3 +++
app/test-pmd/macswap.
This patch introduces a new way of attaching an external buffer to a mbuf.
Attaching an external buffer is quite similar to mbuf indirection in
replacing buffer addresses and length of a mbuf, but a few differences:
- When an indirect mbuf is attached, refcnt of the direct mbuf would be
2 as
On Mon, Apr 23, 2018 at 06:18:43PM +0200, Olivier Matz wrote:
> Hi Yongseok,
>
> Please see some comments below.
>
> On Wed, Apr 18, 2018 at 06:11:04PM -0700, Yongseok Koh wrote:
> > This patch introduces a new way of attaching an external buffer to a mbuf.
> >
> > Attaching an external buffer i
On Mon, 23 Apr 2018 17:48:50 -0700
Jim Murphy wrote:
> Anecdotally I've heard that the urcu hash implementation is slower than
> rte_hash based on pure lookup performance. Has anyone considered adding RCU
> hooks into rte_hash?
Not really possible with DPDK (as I said earlier) because DPDK does
Anecdotally I've heard that the urcu hash implementation is slower than
rte_hash based on pure lookup performance. Has anyone considered adding RCU
hooks into rte_hash?
On Mon, Apr 23, 2018 at 5:30 PM, Stephen Hemminger <
step...@networkplumber.org> wrote:
> On Mon, 23 Apr 2018 17:21:15 -0700
>
On Mon, 23 Apr 2018 17:21:15 -0700
Jim Murphy wrote:
> Has anyone seen performance data comparing rte_hash (perhaps with r/w
> locks) versus URCU hash?
>
>
> On Mon, Apr 23, 2018 at 4:50 PM, Stephen Hemminger <
> step...@networkplumber.org> wrote:
>
> > On Mon, 23 Apr 2018 12:40:41 -0700
> >
Has anyone seen performance data comparing rte_hash (perhaps with r/w
locks) versus URCU hash?
On Mon, Apr 23, 2018 at 4:50 PM, Stephen Hemminger <
step...@networkplumber.org> wrote:
> On Mon, 23 Apr 2018 12:40:41 -0700
> Brijesh Singh wrote:
>
> > A gentle reminder,
> >
> > I am curious to kno
16/04/2018 15:24, Andrew Rybchenko:
> The initial patch series [1] is split into two to simplify processing.
> The second series relies on this one and will add bucket mempool driver
> and related ops.
[...]
> Andrew Rybchenko (9):
> mempool: fix memhdr leak when no objects are populated
> memp
On Mon, 23 Apr 2018 23:08:01 +0200
Thomas Monjalon wrote:
> Hi Stephen,
>
> 04/04/2018 13:34, Thomas Monjalon:
> > 23/02/2018 22:17, Stephen Hemminger:
> > > Regular expressions are not the best way to match a hierarchical
> > > pattern like dynamic log levels. And the separator for dynamic
>
On Tue, 24 Apr 2018 00:28:55 +0300
Arnon Warshavsky wrote:
> + if (*vfinfo == NULL) {
> + RTE_LOG(ERR, PMD, "%s() Cannot allocate memory for private VF
> data\n",
> + __func__);
Please use PMD_DRV_LOG since that has per driver logging control rather
t
On Tue, 24 Apr 2018 00:41:02 +0200
Gaetan Rivet wrote:
> Introduce new rte_devargs accessor allowing to iterate over all
> rte_devargs pertaining to a bus.
>
> Signed-off-by: Gaetan Rivet
> ---
Aren't devargs intended to be internal and not part of ABI.
If so maybe the experimental tag is not
The previous symbols were deprecated for two releases.
They are now marked as such and cannot be used anymore.
They are replaced by ones respecting the new namespace that are marked
experimental.
As a result, eth_dev attach and detach are slightly reworked to follow
the changes.
Signed-off-by: G
rte_eal_devargs is useless, rte_devargs is sufficient.
Only experimental functions are changed for now.
Signed-off-by: Gaetan Rivet
Acked-by: Thomas Monjalon
---
drivers/bus/vdev/vdev.c | 6 +++---
drivers/net/failsafe/failsafe_args.c| 2 +-
drivers/net/failsafe/f
rte_eal_devargs_parse can be used by EAL subsystems, drivers,
applications alike.
Device parameters may be presented with different structure each time;
as a single declaration string or several strings each describing
different parts of the declaration.
To simplify the use of this parsing facili
Device syntax documentation is out of date.
Signed-off-by: Gaetan Rivet
Acked-by: Thomas Monjalon
---
lib/librte_eal/common/include/rte_devargs.h | 26 --
1 file changed, 16 insertions(+), 10 deletions(-)
diff --git a/lib/librte_eal/common/include/rte_devargs.h
b/lib/l
Initially, rte_devargs was meant to be populated once and sometimes
accessed, then never emptied.
With the new hotplug functionality having better standing, new usage
appeared with repeated addition of devices and their subsequent removal.
Exposing devargs_list pushed bus drivers and libraries to
This list should not be used by drivers.
Use the public API instead.
Signed-off-by: Gaetan Rivet
Acked-by: Thomas Monjalon
---
drivers/bus/pci/Makefile | 1 +
drivers/bus/pci/pci_common.c | 6 +-
2 files changed, 2 insertions(+), 5 deletions(-)
diff --git a/drivers/bus/pci/Makefile b/d
The current test will not be compatible anymore with a private
devargs list.
Moreover, the new functions should have new tests, while the existing
API will be removed.
The current unit tests are thus obsolete and hereby removed.
Signed-off-by: Gaetan Rivet
Acked-by: Thomas Monjalon
---
MAINTA
In preparation to making devargs_list private.
Bus drivers generally need to access rte_devargs pertaining to their
operations. This match is a common operation for bus drivers.
Add a new accessor for the rte_devargs list.
Signed-off-by: Gaetan Rivet
Acked-by: Thomas Monjalon
---
lib/librte_e
This list should not be used by drivers.
Use the public API instead.
Signed-off-by: Gaetan Rivet
Acked-by: Thomas Monjalon
---
drivers/net/vdev_netvsc/vdev_netvsc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/vdev_netvsc/vdev_netvsc.c
b/drivers/net/vdev_netv
This list should not be operated upon by drivers.
Use the public API to achieve the same functionalities.
Signed-off-by: Gaetan Rivet
Acked-by: Jianfeng Tan
Acked-by: Thomas Monjalon
---
drivers/bus/vdev/Makefile | 1 +
drivers/bus/vdev/vdev.c | 11 +++
2 files changed, 4 insertions
Cleanup the rte_devargs API.
This is a continuous process.
The previous version of this patchset was dependent on changes
on the PCI bus and the rte_bus library. Not all these changes were
integrated. This patchset has thus been limited to elements that are
available right now, without dependencie
On Tue, 24 Apr 2018 00:41:01 +0200
Gaetan Rivet wrote:
> In preparation to making devargs_list private.
>
> Bus drivers generally need to access rte_devargs pertaining to their
> operations. This match is a common operation for bus drivers.
>
> Add a new accessor for the rte_devargs list.
>
>
On Mon, 23 Apr 2018 12:40:41 -0700
Brijesh Singh wrote:
> A gentle reminder,
>
> I am curious to know if/how rte_hash is thread safe for lookups.It is
> not obvious to me how following code is thread safe:
>
> _rte_hash_lookup_with_hash(const struct rte_hash *h, const void *key,
>
>
Hi,
Please see inline
> -Original Message-
> From: Hu, Jiayu [mailto:jiayu...@intel.com]
> Sent: Monday, April 23, 2018 4:07 AM
> To: Ophir Munk ; dev@dpdk.org; Mark Kavanagh
>
> Cc: Thomas Monjalon ; Olga Shern
>
> Subject: RE: TCP GSO support above IPv6
>
> Hi Ophir,
>
> Comparing wi
rte_eal_devargs is useless, rte_devargs is sufficient.
Only experimental functions are changed for now.
Signed-off-by: Gaetan Rivet
---
drivers/bus/vdev/vdev.c | 6 +++---
drivers/net/failsafe/failsafe_args.c| 2 +-
drivers/net/failsafe/failsafe_eal.c | 2
This previous symbols were deprecated for two releases.
They are now marked as such and cannot be used anymore.
They are replaced by ones respecting the new namespace that are marked
experimental.
As a result, eth_dev attach and detach is slightly reworked to follow
the changes.
Signed-off-by: G
rte_eal_devargs_parse can be used by EAL subsystems, drivers,
applications alike.
Device parameters may be presented with different structure each time;
as a single declaration string or several strings each describing
different parts of the declaration.
To simplify the use of this parsing facili
Initially, rte_devargs was meant to be populated once and sometimes
accessed, then never emptied.
With the new hotplug functionality having better standing, new usage
appeared with repeated addition of devices and their subsequent removal.
Exposing devargs_list pushed bus drivers and libraries to
This list should not be used by drivers.
Use the public API instead.
Signed-off-by: Gaetan Rivet
---
drivers/net/vdev_netvsc/vdev_netvsc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/vdev_netvsc/vdev_netvsc.c
b/drivers/net/vdev_netvsc/vdev_netvsc.c
index f710
The current test will not be compatible anymore with a private
devargs list.
Moreover, the new functions should have new tests, while the existing
API will be removed.
The current unit tests are thus obsolete and hereby removed.
Signed-off-by: Gaetan Rivet
---
MAINTAINERS | 1 -
This list should not be operated upon by drivers.
Use the public API to achieve the same functionalities.
Signed-off-by: Gaetan Rivet
---
drivers/bus/vdev/Makefile | 1 +
drivers/bus/vdev/vdev.c | 11 +++
2 files changed, 4 insertions(+), 8 deletions(-)
diff --git a/drivers/bus/vdev/
Introduce new rte_devargs accessor allowing to iterate over all
rte_devargs pertaining to a bus.
Signed-off-by: Gaetan Rivet
---
lib/librte_eal/common/include/rte_devargs.h | 8
1 file changed, 8 insertions(+)
diff --git a/lib/librte_eal/common/include/rte_devargs.h
b/lib/librte_eal/c
This list should not be used by drivers.
Use the public API instead.
Signed-off-by: Gaetan Rivet
---
drivers/bus/pci/Makefile | 1 +
drivers/bus/pci/pci_common.c | 6 +-
2 files changed, 2 insertions(+), 5 deletions(-)
diff --git a/drivers/bus/pci/Makefile b/drivers/bus/pci/Makefile
ind
Cleanup the rte_devargs API.
This is a continuous process.
The previous version of this patchset was dependent on changes
on the PCI bus and the rte_bus library. Not all these changes were
integrated. This patchset has thus been limited to elements that are
available right now, without dependencie
In preparation to making devargs_list private.
Bus drivers generally need to access rte_devargs pertaining to their
operations. This match is a common operation for bus drivers.
Add a new accessor for the rte_devargs list.
Signed-off-by: Gaetan Rivet
---
lib/librte_eal/common/eal_common_devarg
This patch adds a new function that is called
per every checked patch,
and alerts for new instances of rte_panic/rte_exit.
The check excludes comments, and alerts in the case
of a positive balance between additions and removals.
Signed-off-by: Arnon Warshavsky
---
devtools/checkpatches.sh | 95 +
Local function to this file,
changing from void to int is non-abi-breaking
Signed-off-by: Arnon Warshavsky
---
lib/librte_ether/rte_ethdev.c | 42 ++
lib/librte_ether/rte_ethdev.h | 4 +++-
2 files changed, 33 insertions(+), 13 deletions(-)
diff --git a/
Change some local functions return type from void to int.
This change does not break ABI as the functions are internal.
Panic thrown from threads was not handled in this patch
Signed-off-by: Arnon Warshavsky
---
lib/librte_eal/bsdapp/eal/eal.c | 70
lib/librte_eal/
replace panic calls with log and return value.
Local function to this file,
changing from void to int is non-abi-breaking
Signed-off-by: Arnon Warshavsky
---
lib/librte_kni/rte_kni.c | 18 --
lib/librte_kni/rte_kni_fifo.h | 11 ---
2 files changed, 20 insertions(+),
replace panic calls with log and return value.
Signed-off-by: Arnon Warshavsky
---
lib/librte_eal/linuxapp/eal/eal_hugepage_info.c | 37 +
1 file changed, 26 insertions(+), 11 deletions(-)
diff --git a/lib/librte_eal/linuxapp/eal/eal_hugepage_info.c
b/lib/librte_eal/lin
replace panic calls with log and return value.
Thread function removes the noreturn attribute.
Signed-off-by: Arnon Warshavsky
---
lib/librte_eal/linuxapp/eal/eal_interrupts.c | 25 ++---
1 file changed, 18 insertions(+), 7 deletions(-)
diff --git a/lib/librte_eal/linuxapp/e
replace panic calls with log and return value.
Signed-off-by: Arnon Warshavsky
---
lib/librte_eventdev/rte_eventdev_pmd_pci.h | 8 +---
lib/librte_eventdev/rte_eventdev_pmd_vdev.h | 8 +---
2 files changed, 10 insertions(+), 6 deletions(-)
diff --git a/lib/librte_eventdev/rte_eventdev_
replace panic calls with log and return value.
Local function to this file,
changing from void to int is non-abi-breaking
Signed-off-by: Arnon Warshavsky
---
drivers/net/ixgbe/ixgbe_ethdev.c | 6 --
drivers/net/ixgbe/ixgbe_ethdev.h | 2 +-
drivers/net/ixgbe/ixgbe_pf.c | 15 ++--
replace panic calls with log and return value.
Local function to this file,
changing from void to int is non-abi-breaking
Signed-off-by: Arnon Warshavsky
---
drivers/net/e1000/e1000_ethdev.h | 2 +-
drivers/net/e1000/igb_ethdev.c | 4 +++-
drivers/net/e1000/igb_pf.c | 15 +-
replace panic calls with log and return value.
Local functions to this file,
changing from void to int are non-abi-breaking
Signed-off-by: Arnon Warshavsky
---
drivers/net/bonding/rte_eth_bond_8023ad.c | 29 ++-
drivers/net/bonding/rte_eth_bond_8023ad_private.h | 2 +
The purpose of this patch series is to cleanup the library code
from paths that end up aborting the process,
and move to checking error values, in order to allow the running process
perform an orderly teardown or other mitigation of the event.
This patch modifies the majority of rte_panic calls
un
replace panic calls with log and return value.
Signed-off-by: Arnon Warshavsky
---
drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c | 8 +---
drivers/crypto/dpaa_sec/dpaa_sec.c | 8 +---
2 files changed, 10 insertions(+), 6 deletions(-)
diff --git a/drivers/crypto/dpaa2_sec/dpaa2_se
Hi Stephen,
04/04/2018 13:34, Thomas Monjalon:
> 23/02/2018 22:17, Stephen Hemminger:
> > Regular expressions are not the best way to match a hierarchical
> > pattern like dynamic log levels. And the separator for dynamic
> > log levels is period which is the regex wildcard character.
> >
> > A b
11/04/2018 16:14, Reshma Pattan:
> Unit Testcases are added for power_acpi_cpu_freq,
> power_kvm_vm_test to improve coverage
>
> Signed-off-by: Jananee Parthasarathy
> Acked-by: David Hunt
Applied, thanks
23/04/2018 15:09, David Hunt:
> On FreeBSD, make defconfig generates the config as
> "defconfig_x86_64-bsdapp-", which does not resolve to any known
> config file.
>
> On FreeBSD, we get amd64 out of "uname -m", which was not handled by
> the list of checks, but which now resolves to x86_64-native
20/04/2018 17:20, Jianfeng Tan:
> v2:
> - Fix typo.
> - Rebase on below patches:
> http://dpdk.org/dev/patchwork/patch/38358/
> http://dpdk.org/dev/patchwork/patch/38359/
> http://dpdk.org/dev/patchwork/patch/38360/
>
> Patch 1 is to rename some variable names for better readabilit
> > Anatoly Burakov (3):
> >ipc: use strlcpy where applicable
> >ipc: fix return without mutex unlock
> >ipc: fix resource leak
> >
> > lib/librte_eal/common/eal_common_proc.c | 23 ---
> > 1 file changed, 12 insertions(+), 11 deletions(-)
> >
>
> For this series
18/04/2018 10:51, Adrien Mazarguil:
> On Tue, Apr 17, 2018 at 04:44:04PM +0100, Anatoly Burakov wrote:
> > This patchset fixes a number of Coverity issues introduced
> > in recent DPDK memory hotplug patchset.
> >
> > Coverity issues fixed:
> > - 272564 - error condition not checked
> > - 272579 -
23/04/2018 15:47, Burakov, Anatoly:
> On 23-Apr-18 1:48 PM, Bruce Richardson wrote:
> > On Mon, Apr 23, 2018 at 12:14:13PM +0100, Anatoly Burakov wrote:
> >> fbarray stores its data in a shared file, which is not hidden.
> >> This leads to polluting user's HOME directory with visible
> >> files whe
16/02/2018 10:38, Singh, Jasvinder:
> > On Tue, Jan 30, 2018 at 08:37:08AM +0100, Tomasz Duszynski wrote:
> > > Private shaper profiles are attached to nodes defined in traffic
> > > manager hierarchy.
> > >
> > > Since not every node must have a configured shaper testpmd should
> > > allow setting
A gentle reminder,
I am curious to know if/how rte_hash is thread safe for lookups.It is
not obvious to me how following code is thread safe:
_rte_hash_lookup_with_hash(const struct rte_hash *h, const void *key,
hash_sig_t sig, void **data)
{
…
29/01/2018 11:29, Olivier Matz:
> The code to convert IPv4 and IPv6 address strings into a binary format
> (inet_ntop) was included in the cmdline library because the DPDK was
> historically compiled in environments where the standard inet_ntop()
> function is not available. Today, this is not the
20/04/2018 17:23, Burakov, Anatoly:
> On 20-Apr-18 4:10 PM, Xiao Wang wrote:
> > A previously mapped region is skipped during the search, leading to
> > DMA unmap fails.
> >
> > This patch fixes it and rewords the comment.
> >
> > Fixes: 73a639085938 ("vfio: allow to map other memory regions")
>
21/04/2018 17:33, Pablo de Lara:
> http://dpdk.org/git/next/dpdk-next-crypto
Pulled, thanks
23/04/2018 18:06, Ferruh Yigit:
> On 4/20/2018 3:30 PM, Xueming Li wrote:
> > Add supported RSS hash function check in device configuration to
> > have better error verbosity for application developers.
> >
> > Signed-off-by: Xueming Li
> > Acked-by: Adrien Mazarguil
> >
> > + /* Check that
On 4/22/2018 12:58 PM, Qi Zhang wrote:
> Each queue has independent configure information in rte_port.
> Base on this, we are able to add new commands to configure
> different queues with different value.
>
> Signed-off-by: Qi Zhang
<...>
> @@ -1752,30 +1753,41 @@ rxtx_config_display(void)
>
On 4/22/2018 12:58 PM, Qi Zhang wrote:
> From: Qi Zhang
>
> v7:
> - update default.ini and i40e.ini.
> - rename runtime_queue_setup_capa to dev_capa for generic.
> - testpmd queue setup command be moved to "ports" command group.
> - remove ring_size and offload from queue setup command in testpm
On 4/22/2018 12:58 PM, Qi Zhang wrote:
> It's not possible to setup a queue when the port is started
> because of a check in ethdev layer. New capability flags are
> added in order to relax this check for devices which support
> queue setup in runtime. The functions rte_eth_[rx|tx]_queue_setup
> wi
On 4/22/2018 12:58 PM, Qi Zhang wrote:
> Add command to change specific queue's ring size configure,
> the new value will only take effect after command that restart
> the device(port stop /port start ) or command
> that setup the queue(port rxq setup) at runtime.
>
> Signed-off-by: Qi Zhang
>
1 - 100 of 257 matches
Mail list logo
