Re: [dpdk-dev] [v4,1/5] eventdev: introduce event crypto adapter

2018-05-09 Thread Akhil Goyal
On 5/9/2018 1:16 AM, Abhinandan Gujjar wrote: Signed-off-by: Abhinandan Gujjar Signed-off-by: Nikhil Rao Signed-off-by: Gage Eads --- [...] + +/** + * @warning + * @b EXPERIMENTAL: this structure may change without prior notice + * + * Crypto event metadata structure will be filled by appli

Re: [dpdk-dev] [RFC v2 6/7] net/af_xdp: load BPF file

2018-05-09 Thread Björn Töpel
2018-03-09 0:15 GMT+01:00 Stephen Hemminger : > On Thu, 8 Mar 2018 21:52:48 +0800 > Qi Zhang wrote: > >> +struct bpf_insn prog[] = { >> + { >> + .code = 0x85, //call imm >> + .dst_reg = 0, >> + .src_reg = 0, >> + .off = 0, >> + .imm

Re: [dpdk-dev] [PATCH v2] crypto/dpaa_sec: update maximum queue pairs to 8

2018-05-09 Thread Akhil Goyal
On 5/8/2018 4:54 PM, Hemant Agrawal wrote: From: Nipun Gupta The underlying hardware can support multiple queue pairs. Signed-off-by: Nipun Gupta --- drivers/crypto/dpaa_sec/dpaa_sec.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/crypto/dpaa_sec/dpaa_sec.h b/d

Re: [dpdk-dev] [PATCH net-next v4 0/4] set ixgbe/ixgbevf EITR for performance

2018-05-09 Thread Zhang, Helin
> -Original Message- > From: Zhang, Qi Z > Sent: Wednesday, May 9, 2018 1:32 PM > To: xiangxia.m@gmail.com; Yigit, Ferruh; Zhang, Helin; Xing, Beilei; Dai, > Wei > Cc: dev@dpdk.org > Subject: RE: [PATCH net-next v4 0/4] set ixgbe/ixgbevf EITR for performance > > > > > -Original

Re: [dpdk-dev] [v4,1/5] eventdev: introduce event crypto adapter

2018-05-09 Thread Gujjar, Abhinandan S
> -Original Message- > From: Akhil Goyal [mailto:akhil.go...@nxp.com] > Sent: Wednesday, May 9, 2018 12:32 PM > To: Gujjar, Abhinandan S ; > jerin.ja...@caviumnetworks.com; hemant.agra...@nxp.com; > akhil.go...@nxp.com; dev@dpdk.org > Cc: Vangati, Narender ; Rao, Nikhil > ; Eads, Gage >

Re: [dpdk-dev] [PATCH v2 3/6] lib/cryptodev: add asymmetric crypto capability in cryptodev

2018-05-09 Thread Verma, Shally
>-Original Message- >From: Trahe, Fiona [mailto:fiona.tr...@intel.com] >Sent: 08 May 2018 20:30 >To: Verma, Shally ; De Lara Guarch, Pablo > >Cc: Doherty, Declan ; Athreya, Narayana Prasad >; Sahu, Sunila >; Gupta, Ashish ; >dev@dpdk.org; Sahu, Sunila ; >Gupta, Ashish >Subject: RE: [P

Re: [dpdk-dev] [PATCH v2 2/6] lib/cryptodev: add asym op support in cryptodev

2018-05-09 Thread Verma, Shally
>-Original Message- >From: Trahe, Fiona [mailto:fiona.tr...@intel.com] >Sent: 08 May 2018 20:14 >To: Verma, Shally ; De Lara Guarch, Pablo > >Cc: Doherty, Declan ; Athreya, Narayana Prasad >; Sahu, Sunila >; Gupta, Ashish ; >dev@dpdk.org; Sahu, Sunila ; >Gupta, Ashish >Subject: RE: [P

[dpdk-dev] [PATCH] net/mlx5: fix flow director drop rule deletion crash

2018-05-09 Thread Shahaf Shuler
Drop flow rules are created on the ETH queue even though the parser layer matches the flow rule layer (L3/L4) Fixes: 6f2f4948b236 ("net/mlx5: fix flow director rule deletion crash") Cc: sta...@dpdk.org Cc: adrien.mazarg...@6wind.com Signed-off-by: Shahaf Shuler --- drivers/net/mlx5/mlx5_flow.c

[dpdk-dev] [Bug 42] Crypto_mrvl error with multiple instances

2018-05-09 Thread bugzilla
https://dpdk.org/tracker/show_bug.cgi?id=42 Bug ID: 42 Summary: Crypto_mrvl error with multiple instances Product: DPDK Version: unspecified Hardware: ARM OS: Linux Status: CONFIRMED Severity: major

[dpdk-dev] [PATCH v10 0/3] Introduce Intel FPGA BUS

2018-05-09 Thread Xu, Rosen
From: "Xu, Rosen" Intel FPGA BUS in DPDK - This patch set introduces Intel FPGA BUS support in DPDK. v10 updates: === - Add prefix rte_ for exported symbols - Fix alphabetical order error - Fix share code title well underlined comments - Squash the release no

[dpdk-dev] [PATCH v10 1/3] bus/ifpga: Add Intel FPGA BUS Library

2018-05-09 Thread Xu, Rosen
From: Rosen Xu Defined FPGA-BUS for Acceleration Drivers of AFUs 1. FPGA PCI Scan (1st Scan) follows DPDK UIO/VFIO PCI Scan Process, probe Intel FPGA Rawdev Driver, it will be covered in following patches. 2. AFU Scan(2nd Scan) bind DPDK driver to FPGA Partial-Bitstream. This scan is trigged by

[dpdk-dev] [PATCH v10 3/3] iFPGA: Add Intel FPGA BUS Rawdev Driver

2018-05-09 Thread Xu, Rosen
From: Rosen Xu Add Intel FPGA BUS Rawdev Driver which is based on librte_rawdev library. Signed-off-by: Rosen Xu Signed-off-by: Yanglong Wu Signed-off-by: Tianfei Zhang Acked-by: Shreyansh Jain --- MAINTAINERS| 3 + config/common_base

[dpdk-dev] [Bug 43] "rte_eth_tx_queue_setup" will be failed to called if argument "tx_conf" not specified

2018-05-09 Thread bugzilla
https://dpdk.org/tracker/show_bug.cgi?id=43 Bug ID: 43 Summary: "rte_eth_tx_queue_setup" will be failed to called if argument "tx_conf" not specified Product: DPDK Version: 18.05 Hardware: x86 OS: Linux

Re: [dpdk-dev] [PATCH 1/2] crypto/ccp: enable CCP crypto poll mode driver by default

2018-05-09 Thread Thomas Monjalon
09/05/2018 07:53, Kumar, Ravi1: > > > >I think this cannot be enabled by default, since it has an external > >dependency on OpenSSL. > > Hi Pablo, > > We were asked to enable the PMD by default in one of the previous emails. > Unfortunately, we can't remove the dependency on OpenSSL. Kindly sug

[dpdk-dev] [Bug 41] testpmd failed with net_failsafe error

2018-05-09 Thread bugzilla
https://dpdk.org/tracker/show_bug.cgi?id=41 Raslan Darawsheh (rasl...@mellanox.com) changed: What|Removed |Added Status|CONFIRMED |RESOLVED

Re: [dpdk-dev] [PATCH v2] crypto/dpaa_sec: update maximum queue pairs to 8

2018-05-09 Thread De Lara Guarch, Pablo
> -Original Message- > From: Akhil Goyal [mailto:akhil.go...@nxp.com] > Sent: Wednesday, May 9, 2018 8:07 AM > To: Hemant Agrawal ; dev@dpdk.org > Cc: De Lara Guarch, Pablo ; > akhil.go...@nxp.com > Subject: Re: [dpdk-dev] [PATCH v2] crypto/dpaa_sec: update maximum queue > pairs to 8 > >

Re: [dpdk-dev] [PATCH v2 03/18] drivers/bus/dpaa: fix inconsistent struct alignment

2018-05-09 Thread Hemant Agrawal
On 5/9/2018 7:01 AM, Andy Green wrote: > The actual descriptor for qm_mr_entry is 64-byte aligned. > > But the original code plays a trick, and puts a u8 common > to the three descriptor subtypes in the union afterwards > outside their structure definitions. > > Unfortunately since they compose a

Re: [dpdk-dev] [PATCH 1/2] crypto/ccp: enable CCP crypto poll mode driver by default

2018-05-09 Thread Kumar, Ravi1
>09/05/2018 07:53, Kumar, Ravi1: >> > >> >I think this cannot be enabled by default, since it has an external >> >dependency on OpenSSL. >> >> Hi Pablo, >> >> We were asked to enable the PMD by default in one of the previous emails. >> Unfortunately, we can't remove the dependency on OpenSSL. K

Re: [dpdk-dev] [PATCH v1 1/3] net/mlx5: document update for Tx

2018-05-09 Thread Shahaf Shuler
Wednesday, May 9, 2018 3:15 AM, Xueming Li: > Cc: Xueming(Steven) Li ; dev@dpdk.org > Subject: [dpdk-dev] [PATCH v1 1/3] net/mlx5: document update for Tx > > Add document for hw header parsing and SWP. > > Signed-off-by: Xueming Li Series applied to next-net-mlx, thanks.

[dpdk-dev] [v5, 2/5] eventdev: add APIs and PMD callbacks for crypto adapter

2018-05-09 Thread Abhinandan Gujjar
This patch defines capabilities & functions to be called for eventdev PMDs. Signed-off-by: Abhinandan Gujjar Acked-by: Jerin Jacob Acked-by: Akhil Goyal --- drivers/event/sw/sw_evdev.c | 13 ++ lib/librte_eventdev/rte_eventdev.c | 25 lib/librte_eventdev/rte_e

[dpdk-dev] [v5,1/5] eventdev: introduce event crypto adapter

2018-05-09 Thread Abhinandan Gujjar
This patch introduces event crypto adapter APIs. It also provides information on working model/adapter modes & their usage. Application is expected to use this interface to transfer packets between the crypto device & the event device. Signed-off-by: Abhinandan Gujjar Signed-off-by: Nikhil Rao S

[dpdk-dev] [v5,0/5] eventdev: cover letter - crypto adapter

2018-05-09 Thread Abhinandan Gujjar
This patchset introduces the event crypto adapter which is intended to bridge between event devices and crypto devices. Addition of the event crypto adapter into eventdev library extends the event driven programming model with crypto devices. This patchset has dependency on below cryptodev patchse

[dpdk-dev] [v5,4/5] test: add event crypto adapter auto-test

2018-05-09 Thread Abhinandan Gujjar
Added testsuite to test the crypto adapter functionality. The testsuite detects the HW/SW event & crypto devices and their capabilities. Depending upon the capability, adapter is confgured and modes are tested. Signed-off-by: Abhinandan Gujjar Acked-by: Akhil Goyal --- MAINTAINERS

[dpdk-dev] [v5,5/5] doc: add event crypto adapter documentation

2018-05-09 Thread Abhinandan Gujjar
Add entries in the programmer's guide, API index, maintainer's file and release notes for the event crypto adapter. Signed-off-by: Abhinandan Gujjar Acked-by: Jerin Jacob Acked-by: Akhil Goyal --- MAINTAINERS|1 + doc/api/doxy-api-index.md

[dpdk-dev] [v5,3/5] eventdev: add crypto adapter implementation

2018-05-09 Thread Abhinandan Gujjar
This patch adds common code for the crypto adapter to support SW and HW based transfer mechanisms. The adapter uses an EAL service core function for SW based packet transfer and uses the eventdev PMD functions to configure HW based packet transfer between the crypto device and the event device. Thi

Re: [dpdk-dev] [PATCH 1/2] crypto/ccp: enable CCP crypto poll mode driver by default

2018-05-09 Thread Thomas Monjalon
09/05/2018 10:11, Kumar, Ravi1: > >09/05/2018 07:53, Kumar, Ravi1: > >> > > >> >I think this cannot be enabled by default, since it has an external > >> >dependency on OpenSSL. > >> > >> Hi Pablo, > >> > >> We were asked to enable the PMD by default in one of the previous emails. > >> Unfortuna

Re: [dpdk-dev] [PATCH 2/2] crypto/ccp: change to command line option from compile time

2018-05-09 Thread De Lara Guarch, Pablo
> -Original Message- > From: Ravi Kumar [mailto:ravi1.ku...@amd.com] > Sent: Thursday, May 3, 2018 6:57 AM > To: dev@dpdk.org > Cc: De Lara Guarch, Pablo ; > tho...@monjalon.net; hemant.agra...@nxp.com > Subject: [PATCH 2/2] crypto/ccp: change to command line option from compile > time >

Re: [dpdk-dev] [PATCH 1/2] crypto/ccp: enable CCP crypto poll mode driver by default

2018-05-09 Thread De Lara Guarch, Pablo
Hi Ravi, > -Original Message- > From: Kumar, Ravi1 [mailto:ravi1.ku...@amd.com] > Sent: Wednesday, May 9, 2018 9:11 AM > To: Thomas Monjalon > Cc: De Lara Guarch, Pablo ; dev@dpdk.org; > hemant.agra...@nxp.com > Subject: RE: [PATCH 1/2] crypto/ccp: enable CCP crypto poll mode driver by >

[dpdk-dev] Please revert: [PATCH 2/2] net/mlx4: fix useless default in RSS converter

2018-05-09 Thread Ophir Munk
Hi Shahaf, Adrien, This commit (in next-net/master since 8-May-18) is breaking all testpmd calls with mlx4 NIC, see [1]. Can you please revert it? [1] PMD: net_mlx4: cannot set up internal flow rules (code 95, "Operation not supported"), flow error type 16, cause 0x7fffdb5bb3a0, message: unsupp

Re: [dpdk-dev] [PATCH 1/2] crypto/ccp: enable CCP crypto poll mode driver by default

2018-05-09 Thread Kumar, Ravi1
>Hi Ravi, > >> -Original Message- >> From: Kumar, Ravi1 [mailto:ravi1.ku...@amd.com] >> Sent: Wednesday, May 9, 2018 9:11 AM >> To: Thomas Monjalon >> Cc: De Lara Guarch, Pablo ; >> dev@dpdk.org; hemant.agra...@nxp.com >> Subject: RE: [PATCH 1/2] crypto/ccp: enable CCP crypto poll mode >

[dpdk-dev] [PATCH v2] examples/ipsec-secgw: limit inflight packets count

2018-05-09 Thread Radu Nicolau
Revert previous patch that introduce a performance degradation in certain scenarios and add a configurable limit for number inflight packets. Revert commit 84d4b5e4ec48 ("examples/ipsec-secgw: improve IPsec dequeue logic") Cc: sta...@dpdk.org Signed-off-by: Radu Nicolau --- v2: updated enqueue s

Re: [dpdk-dev] [PATCH] doc: update release notes for OcteonTx TIM driver

2018-05-09 Thread Jerin Jacob
-Original Message- > Date: Fri, 20 Apr 2018 09:48:06 + > From: "Kovacevic, Marko" > To: Pavan Nikhilesh , > "tho...@monjalon.net" , > "jerin.ja...@caviumnetworks.com" , > "Mcnamara, John" > CC: "dev@dpdk.org" > Subject: RE: [dpdk-dev] [PATCH] doc: update release notes for OcteonTx

[dpdk-dev] [PATCH 1/2] event/dpaa2: remove check on return value from epoll wait

2018-05-09 Thread Shreyansh Jain
From: Nipun Gupta Driver shouldn't take decision on signals received. The return from epoll was blocking on EINTR which is not the right use-case. Fixes: 36d87bb92230 ("event/dpaa2: handle timeout using interrupts in dequeue") Signed-off-by: Nipun Gupta --- drivers/event/dpaa2/dpaa2_eventdev.

[dpdk-dev] [PATCH 2/2] event/dpaa2: Remove usage of link under evq_info_t structure

2018-05-09 Thread Shreyansh Jain
From: Ashish Jain Removing use of link data under evq_info_t structure which was used to check whether the the associated evq has been linked or not. Since, an evq can be linked to multiple event ports, thus setting the link variable only allowed the first event port to be associated with the evq

[dpdk-dev] [PATCH v3] examples/ipsec-secgw: limit inflight packets count

2018-05-09 Thread Radu Nicolau
Revert previous patch that introduce a performance degradation in certain scenarios and add a configurable limit for number inflight packets. Revert commit 84d4b5e4ec48 ("examples/ipsec-secgw: improve IPsec dequeue logic") Cc: sta...@dpdk.org Signed-off-by: Radu Nicolau --- v3: updated enqueue s

Re: [dpdk-dev] [PATCH] event/octeontx: fix incorrect SPDX placement

2018-05-09 Thread Jerin Jacob
-Original Message- > Date: Mon, 23 Apr 2018 13:27:54 + > From: Hemant Agrawal > To: Pavan Nikhilesh , > "jerin.ja...@caviumnetworks.com" > CC: "dev@dpdk.org" > Subject: RE: [dpdk-dev] [PATCH] event/octeontx: fix incorrect SPDX placement > > > Subject: [dpdk-dev] [PATCH] event/octeo

Re: [dpdk-dev] [PATCH] eventdev: convert eth Rx adapter files to SPDX license tag

2018-05-09 Thread Jerin Jacob
-Original Message- > Date: Wed, 25 Apr 2018 15:01:18 +0530 > From: Hemant Agrawal > To: Nikhil Rao , jerin.ja...@caviumnetworks.com > CC: dev@dpdk.org, hemant.agra...@nxp.com > Subject: Re: [dpdk-dev] [PATCH] eventdev: convert eth Rx adapter files to > SPDX license tag > User-Agent: Mozil

Re: [dpdk-dev] [PATCH] driver/octeontx: disable PMD for buggy compilers

2018-05-09 Thread Jerin Jacob
-Original Message- > Date: Tue, 8 May 2018 07:49:01 + > From: Ali Alnubani > To: 'Pavan Nikhilesh' , > "jerin.ja...@caviumnetworks.com" , > "santosh.shu...@caviumnetworks.com" , > "ferruh.yi...@intel.com" , Shahaf Shuler > > CC: "dev@dpdk.org" > Subject: RE: [dpdk-dev] [PATCH] dr

Re: [dpdk-dev] [PATCH v2 1/1] test: fix build with GCC 4.8.5

2018-05-09 Thread Jerin Jacob
-Original Message- > Date: Mon, 7 May 2018 14:12:52 -0500 > From: Erik Gabriel Carrillo > To: jerin.ja...@caviumnetworks.com > CC: dev@dpdk.org > Subject: [PATCH v2 1/1] test: fix build with GCC 4.8.5 > X-Mailer: git-send-email 1.7.10 > > Build errors occur on CentOS 7 with GCC 4.8.5 2015

Re: [dpdk-dev] [PATCH] event/octeontx: fix clang 6 linker error

2018-05-09 Thread Jerin Jacob
-Original Message- > Date: Wed, 9 May 2018 07:23:08 +0530 > From: Jerin Jacob > To: Pavan Nikhilesh > CC: santosh.shu...@caviumnetworks.com, arybche...@solarflare.com, > dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] event/octeontx: fix clang 6 linker error > User-Agent: Mutt/1.9.5 (2018

[dpdk-dev] [PATCH] crypto/dpaa2_sec: remove iova conversion for fle address

2018-05-09 Thread Shreyansh Jain
From: Hemant Agrawal fle is already in virtual addressing mode - no need to perform address conversion for it. Fixes: 8d1f3a5d751b ("crypto/dpaa2_sec: support crypto operation") Cc: akhil.go...@nxp.com Signed-off-by: Hemant Agrawal --- drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c | 3 +-- 1 fi

[dpdk-dev] [PATCH 1/2] net/dpaa: fix max push mode queue

2018-05-09 Thread Shreyansh Jain
Split default and max push mode queues to 4 and 8, respectively. Fixes: e6573771cdfb ("net/dpaa: integrate the support of push mode in PMD") Cc: hemant.agra...@nxp.com Signed-off-by: Shreyansh Jain DPDK-1304 --- drivers/net/dpaa/dpaa_ethdev.c | 9 + 1 file changed, 5 insertions(+), 4 de

[dpdk-dev] [PATCH 2/2] net/dpaa: update optimal burst size in device info

2018-05-09 Thread Shreyansh Jain
Signed-off-by: Shreyansh Jain --- drivers/net/dpaa/dpaa_ethdev.c | 2 ++ drivers/net/dpaa/dpaa_ethdev.h | 4 2 files changed, 6 insertions(+) diff --git a/drivers/net/dpaa/dpaa_ethdev.c b/drivers/net/dpaa/dpaa_ethdev.c index 88febe4d9..c0a56a9fe 100644 --- a/drivers/net/dpaa/dpaa_ethdev.c +

Re: [dpdk-dev] [PATCH] crypto/dpaa2_sec: remove iova conversion for fle address

2018-05-09 Thread Akhil Goyal
On 5/9/2018 2:56 PM, Shreyansh Jain wrote: From: Hemant Agrawal fle is already in virtual addressing mode - no need to perform address conversion for it. Fixes: 8d1f3a5d751b ("crypto/dpaa2_sec: support crypto operation") Cc: akhil.go...@nxp.com Signed-off-by: Hemant Agrawal --- drivers/cryp

[dpdk-dev] [PATCH] test: fix gcc 4.8 build issue

2018-05-09 Thread Radu Nicolau
Fixes: d1f3385d0076 ("test: add event timer adapter auto-test") Cc: sta...@dpdk.org Signed-off-by: Radu Nicolau --- test/test/test_event_timer_adapter.c | 4 1 file changed, 4 insertions(+) diff --git a/test/test/test_event_timer_adapter.c b/test/test/test_event_timer_adapter.c index 9347

Re: [dpdk-dev] [PATCH] examples/ip_pipeline: fix buffer not null terminated

2018-05-09 Thread Dumitrescu, Cristian
> -Original Message- > From: Richardson, Bruce > Sent: Tuesday, May 8, 2018 8:51 PM > To: Dumitrescu, Cristian > Cc: Zhang, Roy Fan ; dev@dpdk.org; Singh, > Jasvinder > Subject: Re: [dpdk-dev] [PATCH] examples/ip_pipeline: fix buffer not null > terminated > > On Tue, May 08, 2018 at 02

Re: [dpdk-dev] [PATCH] test: fix gcc 4.8 build issue

2018-05-09 Thread Jerin Jacob
-Original Message- > Date: Wed, 9 May 2018 10:10:17 +0100 > From: Radu Nicolau > To: dev@dpdk.org > CC: erik.g.carri...@intel.com, jerin.jacobkollanukka...@cavium.com, Radu > Nicolau , sta...@dpdk.org > Subject: [PATCH] test: fix gcc 4.8 build issue > X-Mailer: git-send-email 2.7.5 > > F

[dpdk-dev] [PATCH v2 2/2] net/dpaa: update optimal burst size in device info

2018-05-09 Thread Shreyansh Jain
Signed-off-by: Shreyansh Jain --- drivers/net/dpaa/dpaa_ethdev.c | 2 ++ drivers/net/dpaa/dpaa_ethdev.h | 4 2 files changed, 6 insertions(+) diff --git a/drivers/net/dpaa/dpaa_ethdev.c b/drivers/net/dpaa/dpaa_ethdev.c index 88febe4d9..c0a56a9fe 100644 --- a/drivers/net/dpaa/dpaa_ethdev.c +

[dpdk-dev] [PATCH v2 1/2] net/dpaa: fix max push mode queue

2018-05-09 Thread Shreyansh Jain
Split default and max push mode queues to 4 and 8, respectively. Fixes: e6573771cdfb ("net/dpaa: integrate the support of push mode in PMD") Cc: hemant.agra...@nxp.com Signed-off-by: Shreyansh Jain --- v2: - Removed stray internal tracking number from commit message drivers/net/dpaa/dpaa_e

Re: [dpdk-dev] [PATCH v1] net/mlx4: report on supported RSS hash functions

2018-05-09 Thread Shahaf Shuler
Hi Ophir, Tuesday, May 8, 2018 6:43 PM, Ophir Munk: > Subject: [PATCH v1] net/mlx4: report on supported RSS hash functions > > Report on mlx4 supported RSS functions as part of dev_infos_get callback. > Previous to this commit RSS support was reported as none. Since the > introduction of [1] it i

[dpdk-dev] [PATCH 02/11] net/failsafe: fix sub-device visibility

2018-05-09 Thread Thomas Monjalon
The iterator function rte_eth_find_next_owned_by(), used by the iterator macro RTE_ETH_FOREACH_DEV_OWNED_BY, are ignoring the devices which are neither ATTACHED nor REMOVED. Thus sub-devices, having the state DEFERRED, cannot be seen with the ethdev iterator. The state RTE_ETH_DEV_DEFERRED can be r

[dpdk-dev] [PATCH 00/11] ethdev: fix race conditions in iterator and notifications

2018-05-09 Thread Thomas Monjalon
We have discovered some race conditions when using the port iterator and/or the notifications recently added. The work was done mostly with failsafe but some bugs could be reproduced with other drivers. These 11 patches are fixing all these issues. The PMDs are modified to call a new function at th

[dpdk-dev] [PATCH 03/11] ethdev: add doxygen comments for each state

2018-05-09 Thread Thomas Monjalon
The enum rte_eth_dev_state was not properly documented. Its values did not appear in the doxygen output, and may be misunderstood. The state RTE_ETH_DEV_DEFERRED has no interest anymore since the ownership mechanism brings a more flexible categorization. This state could be removed later. Fixes:

[dpdk-dev] [PATCH 04/11] drivers/net: use higher level of probing helper for PCI

2018-05-09 Thread Thomas Monjalon
The drivers avp, bnx2x and liquidio were using the helper function rte_eth_dev_pci_allocate() and can be replaced by rte_eth_dev_pci_generic_probe() which calls the former. Fixes: dcd5c8112bc3 ("ethdev: add PCI driver helpers") Cc: sta...@dpdk.org Signed-off-by: Thomas Monjalon --- drivers/net/

[dpdk-dev] [PATCH 01/11] ethdev: fix debug log of owner id

2018-05-09 Thread Thomas Monjalon
The owner id is 64-bit. On 32-bit environment, it must be printed with PRIX64. Fixes: 5b7ba31148a8 ("ethdev: add port ownership") Cc: sta...@dpdk.org Signed-off-by: Thomas Monjalon --- lib/librte_ethdev/rte_ethdev.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/

[dpdk-dev] [PATCH 05/11] ethdev: add probing finish function

2018-05-09 Thread Thomas Monjalon
A new hook function is added and called inside the PMDs at the end of the device probing: - in primary process, after allocating, init and config - in secondary process, after attaching and local init This new function is almost empty for now. It will be used later to add some post

[dpdk-dev] [PATCH 06/11] ethdev: allow ownership operations on unused port

2018-05-09 Thread Thomas Monjalon
From: Matan Azrad When the state will be updated later than in allocation, we may need to update the ownership of a port which is still in state unused. It will be used to take ownership of a port before it is declared as available for other entities. Cc: sta...@dpdk.org Signed-off-by: Matan A

[dpdk-dev] [PATCH 11/11] ethdev: fix port removal notification timing

2018-05-09 Thread Thomas Monjalon
From: Matan Azrad When an ethdev port is released, a destroy event is triggered to notify the users about the released port. A bit before the destroy event is triggered, the port becomes invalid by changing its state to UNUSED and cleaning its data. Therefore, the port is invalid for the destroy

[dpdk-dev] [PATCH] app/crypto-perf: check minimum lcore number

2018-05-09 Thread Pablo de Lara
The crypto performance application requires at least two cores: one master core that launches the other slaves and one core acting as slave running the crypto device. Fixes: f8be1786b1b8 ("app/crypto-perf: introduce performance test application") Cc: sta...@dpdk.org Signed-off-by: Pablo de Lara

[dpdk-dev] [PATCH] net/virtio-user: fix multiple queues fail in server mode

2018-05-09 Thread zhiyong . yang
This patch fixes multiple queues failure when virtio-user works in server mode. Fixes: bd8f50a45d0f ("net/virtio-user: support server mode") Cc: sta...@dpdk.org Signed-off-by: Zhiyong Yang --- drivers/net/virtio/virtio_user/vhost_user.c | 3 +++ drivers/net/virtio/virtio_user/virtio_user_de

Re: [dpdk-dev] [PATCH 0/4] net/sfc/base: add new stats

2018-05-09 Thread Ferruh Yigit
On 5/3/2018 3:41 PM, Andrew Rybchenko wrote: > Update net/sfc base driver to provide a new stats available on > XtremeScale X2 (aka Medford2) NICs. No new code is required in > net/sfc PMD. > > HLB_IDLE and HLB_TIMEOUT stats are useful for packet drops and > performance investigations. > > There

Re: [dpdk-dev] [PATCH v2 05/18] drivers/net/nfp/nfpcore: fix strncpy misuse

2018-05-09 Thread Alejandro Lucero
On Wed, May 9, 2018 at 2:31 AM, Andy Green wrote: > Signed-off-by: Andy Green > --- > drivers/net/nfp/nfpcore/nfp_cpp_pcie_ops.c |4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/net/nfp/nfpcore/nfp_cpp_pcie_ops.c > b/drivers/net/nfp/nfpcore/nfp_cpp_pcie_ops

[dpdk-dev] [PATCH 09/11] ethdev: fix port probing notification

2018-05-09 Thread Thomas Monjalon
The new device was notified as soon as it was allocated. It leads to use a device which is not yet initialized. The notification must be published after the initialization is done by the PMD, but before the state is changed, in order to let notified entities taking ownership before general availab

[dpdk-dev] [PATCH 07/11] ethdev: add lock to port allocation check

2018-05-09 Thread Thomas Monjalon
From: Matan Azrad When comparing the port name, there can be a race condition with a thread allocating a new port and writing the name at the same time. It can lead to match with a partial name by error. The check of the port is now considered as a critical section protected with locks. This fi

[dpdk-dev] [PATCH 10/11] net/failsafe: fix sub-device ownership race

2018-05-09 Thread Thomas Monjalon
From: Matan Azrad There is time between the sub-device port probing by the sub-device PMD to the sub-device port ownership taking by a fail-safe port. In this time, the port is available for the application usage. For example, the port will be exposed to the applications which use RTE_ETH_FOREAC

[dpdk-dev] [PATCH 08/11] ethdev: fix port visibility before initialization

2018-05-09 Thread Thomas Monjalon
The port was set to the state ATTACHED during allocation. The consequence was to iterate over ports which are not initialized. The state ATTACHED is now set as the last step of probing. The uniqueness of port name is now checked before the availability of a port id for allocation (order reversed)

Re: [dpdk-dev] [PATCH v3 2/2] net/mlx5: fix resource leak in case of error

2018-05-09 Thread Shahaf Shuler
--Shahaf > -Original Message- > From: Yongseok Koh > Sent: Tuesday, May 8, 2018 10:20 PM > To: Raslan Darawsheh > Cc: Shahaf Shuler ; dev@dpdk.org; Thomas > Monjalon ; Ophir Munk > ; sta...@dpdk.org > Subject: Re: [PATCH v3 2/2] net/mlx5: fix resource leak in case of error > > > > On

Re: [dpdk-dev] [PATCH v3 1/2] net/mlx5: fix double free on error handling

2018-05-09 Thread Shahaf Shuler
Tuesday, May 8, 2018 10:09 PM, Yongseok Koh: > Subject: Re: [PATCH v3 1/2] net/mlx5: fix double free on error handling > > > > On May 8, 2018, at 2:11 AM, Raslan Darawsheh > wrote: > > > > When attr_ctx is NULL it will attempt to free the list of devices twice. > > Avoid double freeing the list

Re: [dpdk-dev] [PATCH v2 06/18] drivers/net/nfp/nfpcore: fix off-by-one and no NUL on strncpy use

2018-05-09 Thread Alejandro Lucero
On Wed, May 9, 2018 at 2:31 AM, Andy Green wrote: > /home/agreen/projects/dpdk/drivers/net/nfp/nfpcore/nfp_resource.c: > 76:2:error: ‘strncpy’ output may be truncated copying 8 bytes from > a string of length 8 [-Werror=stringop-truncation] > strncpy(name_pad, res->name, sizeof(name_pad)); > >

Re: [dpdk-dev] [PATCH v2 07/18] drivers/net/nfp: don't memcpy out of source range

2018-05-09 Thread Alejandro Lucero
On Wed, May 9, 2018 at 2:31 AM, Andy Green wrote: > /home/agreen/projects/dpdk/drivers/net/nfp/nfp_net.c:669:2: > error: ‘memcpy’ forming offset [5, 6] is out of the bounds > [0, 4] of object ‘tmp’ with type ‘uint32_t’ {aka ‘unsigned > int’} [-Werror=array-bounds] memcpy(&hw->mac_addr[0], > &tmp

Re: [dpdk-dev] Please revert: [PATCH 2/2] net/mlx4: fix useless default in RSS converter

2018-05-09 Thread Shahaf Shuler
Wednesday, May 9, 2018 11:47 AM, Ophir Munk: > Subject: Please revert: [dpdk-dev] [PATCH 2/2] net/mlx4: fix useless default > in RSS converter > > Hi Shahaf, Adrien, > > This commit (in next-net/master since 8-May-18) is breaking all testpmd calls > with mlx4 NIC, see [1]. > Can you please revert

Re: [dpdk-dev] [PATCH 1/2] event/dpaa2: remove check on return value from epoll wait

2018-05-09 Thread Hemant Agrawal
Subject: [PATCH 1/2] event/dpaa2: remove check on return value from epoll wait Importance: High From: Nipun Gupta Driver shouldn't take decision on signals received. The return from epoll was blocking on EINTR which is not the right use-case. Fixes: 36d87bb92230 ("event/dpaa2: handle timeout u

Re: [dpdk-dev] [PATCH 2/2] event/dpaa2: Remove usage of link under evq_info_t structure

2018-05-09 Thread Hemant Agrawal
On 5/9/2018 2:50 PM, Shreyansh Jain wrote: > From: Ashish Jain > > Removing use of link data under evq_info_t structure which was > used to check whether the the associated evq has been linked > or not. Since, an evq can be linked to multiple event ports, > thus setting the link variable only all

Re: [dpdk-dev] [PATCH v2 08/18] drivers/net/nfp: fix buffer overflow in fw_name

2018-05-09 Thread Alejandro Lucero
On Wed, May 9, 2018 at 2:31 AM, Andy Green wrote: > /home/agreen/projects/dpdk/drivers/net/nfp/nfp_net.c: In > function ‘nfp_pf_pci_probe’: > /home/agreen/projects/dpdk/drivers/net/nfp/nfp_net.c:3160: > 23: error: ‘%s’ directive writing up to 99 bytes into a > region of size 76 [-Werror=format-ov

Re: [dpdk-dev] [dpdk-stable] [PATCH] net/mlx5: fix calculation of Tx TSO inline room size

2018-05-09 Thread Shahaf Shuler
Tuesday, May 8, 2018 9:48 PM, Yongseok Koh: > Subject: [dpdk-stable] [PATCH] net/mlx5: fix calculation of Tx TSO inline room > size > > rdma-core doesn't add up max_tso_header size to max_inline_data size. The > library takes bigger value between the two. > > Fixes: 43e9d9794cde ("net/mlx5: suppo

Re: [dpdk-dev] [PATCH v1] doc: add mlx4 CRC stripping toggling limitation

2018-05-09 Thread Shahaf Shuler
Tuesday, May 8, 2018 3:34 PM, Thomas Monjalon: > Subject: Re: [PATCH v1] doc: add mlx4 CRC stripping toggling limitation > > 08/05/2018 14:30, Ophir Munk: > > +Limitations > > +--- > > + > > +- CRC stripping is supported by default and this capability is always > reported > > + as "true".

Re: [dpdk-dev] [dpdk-stable] [PATCH] app/crypto-perf: fix pmd_cyclecount_bench_ops

2018-05-09 Thread De Lara Guarch, Pablo
> -Original Message- > From: stable [mailto:stable-boun...@dpdk.org] On Behalf Of Tomasz Jozwiak > Sent: Thursday, April 26, 2018 10:06 AM > To: dev@dpdk.org > Cc: sta...@dpdk.org; Burakov, Anatoly ; Jozwiak, > TomaszX > Subject: [dpdk-stable] [PATCH] app/crypto-perf: fix pmd_cyclecount_

Re: [dpdk-dev] [dpdk-stable] [PATCH] app/crypto-perf: fix pmd_cyclecount_bench_ops

2018-05-09 Thread De Lara Guarch, Pablo
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of De Lara Guarch, Pablo > Sent: Wednesday, May 9, 2018 11:10 AM > To: Jozwiak, TomaszX ; dev@dpdk.org > Cc: sta...@dpdk.org; Burakov, Anatoly ; Jozwiak, > TomaszX > Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH] app

Re: [dpdk-dev] [PATCH] crypto/dpaa2_sec: remove iova conversion for fle address

2018-05-09 Thread De Lara Guarch, Pablo
> -Original Message- > From: Akhil Goyal [mailto:akhil.go...@nxp.com] > Sent: Wednesday, May 9, 2018 10:14 AM > To: Shreyansh Jain ; De Lara Guarch, Pablo > > Cc: akhil.go...@nxp.com; dev@dpdk.org; Hemant Agrawal > > Subject: Re: [dpdk-dev] [PATCH] crypto/dpaa2_sec: remove iova conversi

Re: [dpdk-dev] [PATCH v8] ethdev: check Rx/Tx offloads

2018-05-09 Thread Dai, Wei
Hi, Andrew See my in-line comments as below. From: Andrew Rybchenko [mailto:arybche...@solarflare.com] Sent: Tuesday, May 8, 2018 7:37 PM To: Dai, Wei ; Yigit, Ferruh ; tho...@monjalon.net; Doherty, Declan ; linvi...@tuxdriver.com; m...@semihalf.com; m...@semihalf.com; gtza...@amazon.com; evge

Re: [dpdk-dev] [PATCH v3] app/test: enhance cryptodev scheduler unit tests

2018-05-09 Thread De Lara Guarch, Pablo
> -Original Message- > From: Pattan, Reshma > Sent: Friday, April 13, 2018 10:00 AM > To: De Lara Guarch, Pablo ; dev@dpdk.org > Cc: Parthasarathy, JananeeX M > Subject: [PATCH v3] app/test: enhance cryptodev scheduler unit tests > > Unit Test Cases for MultiCore mode, Failover mode, Pa

Re: [dpdk-dev] [PATCH v1] doc: add mlx4 CRC stripping toggling limitation

2018-05-09 Thread Ophir Munk
Sure. Agreed. Regards, Ophir > -Original Message- > From: Shahaf Shuler > Sent: Wednesday, May 09, 2018 1:07 PM > To: Thomas Monjalon ; Ophir Munk > > Cc: dev@dpdk.org; Adrien Mazarguil ; Olga > Shern > Subject: RE: [PATCH v1] doc: add mlx4 CRC stripping toggling limitation > > Tuesday

Re: [dpdk-dev] [v5,0/5] eventdev: cover letter - crypto adapter

2018-05-09 Thread Jerin Jacob
-Original Message- > Date: Wed, 9 May 2018 13:47:56 +0530 > From: Abhinandan Gujjar > To: jerin.ja...@caviumnetworks.com, hemant.agra...@nxp.com, > akhil.go...@nxp.com, dev@dpdk.org > CC: narender.vang...@intel.com, abhinandan.guj...@intel.com, > nikhil@intel.com, gage.e...@intel.com

Re: [dpdk-dev] [PATCH v2 5/6] crypto/openssl: add asym crypto support

2018-05-09 Thread Trahe, Fiona
Hi Shally, > -Original Message- > From: Shally Verma [mailto:shally.ve...@caviumnetworks.com] > Sent: Thursday, April 5, 2018 12:25 PM > To: De Lara Guarch, Pablo > Cc: Doherty, Declan ; Trahe, Fiona > ; > pathr...@caviumnetworks.com; ss...@caviumnetworks.com; > agu...@caviumnetworks.

Re: [dpdk-dev] [PATCH v3] app/test: enhance cryptodev scheduler unit tests

2018-05-09 Thread De Lara Guarch, Pablo
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of De Lara Guarch, Pablo > Sent: Wednesday, May 9, 2018 11:31 AM > To: Pattan, Reshma ; dev@dpdk.org > Cc: Parthasarathy, JananeeX M > Subject: Re: [dpdk-dev] [PATCH v3] app/test: enhance cryptodev scheduler unit >

Re: [dpdk-dev] [v5,0/5] eventdev: cover letter - crypto adapter

2018-05-09 Thread Jerin Jacob
-Original Message- > Date: Wed, 9 May 2018 13:47:56 +0530 > From: Abhinandan Gujjar > To: jerin.ja...@caviumnetworks.com, hemant.agra...@nxp.com, > akhil.go...@nxp.com, dev@dpdk.org > CC: narender.vang...@intel.com, abhinandan.guj...@intel.com, > nikhil@intel.com, gage.e...@intel.com

Re: [dpdk-dev] [PATCH 2/2] event/dpaa2: Remove usage of link under evq_info_t structure

2018-05-09 Thread Jerin Jacob
-Original Message- > Date: Wed, 9 May 2018 10:03:33 + > From: Hemant Agrawal > To: Shreyansh Jain , > "jerin.ja...@caviumnetworks.com" > CC: "dev@dpdk.org" , Ashish Jain , Nipun > Gupta > Subject: RE: [PATCH 2/2] event/dpaa2: Remove usage of link under evq_info_t > structure > >

Re: [dpdk-dev] [PATCH v2 5/6] crypto/openssl: add asym crypto support

2018-05-09 Thread Verma, Shally
>-Original Message- >From: Trahe, Fiona [mailto:fiona.tr...@intel.com] >Sent: 09 May 2018 16:03 >To: Verma, Shally ; De Lara Guarch, Pablo > >Cc: Doherty, Declan ; Athreya, Narayana Prasad >; Sahu, Sunila >; Gupta, Ashish ; >dev@dpdk.org; Sahu, Sunila ; >Gupta, Ashish ; Trahe, Fiona >

[dpdk-dev] [pull-request] next-eventdev 18.05 RC3

2018-05-09 Thread Jerin Jacob
The following changes since commit 0256386dc43ce0f27f4c9d6bfa58c534aaf997e2: mem: add argument to memory event callback (2018-05-08 22:28:58 +0200) are available in the Git repository at: http://dpdk.org/git/next/dpdk-next-eventdev for you to fetch changes up to db3d585ff859251586f24f2bf60

Re: [dpdk-dev] [PATCH 3/3] net/mlx5: add Multi-Packet Rx support

2018-05-09 Thread Yongseok Koh
On Mon, May 07, 2018 at 03:49:10AM -0700, Shahaf Shuler wrote: > Hi Koh, > > Nice work. Please see some comments. > > Thursday, May 3, 2018 2:21 AM, Yongseok Koh: > > Subject: [dpdk-dev] [PATCH 3/3] net/mlx5: add Multi-Packet Rx support > > > > Multi-Packet Rx Queue (MPRQ a.k.a Striding RQ) can

[dpdk-dev] [PATCH v3] net/mlx5: change device reference for secondary process

2018-05-09 Thread Yongseok Koh
rte_eth_devices[] is not shared between primary and secondary process, but a static array to each process. The reverse pointer of device (priv->dev) is invalid. Instead, priv has the pointer to shared data of the device, struct rte_eth_dev_data *dev_data; Two macros are added, #define PORT_ID(

[dpdk-dev] [PATCH v2 0/4] net/mlx: add new Memory Region support

2018-05-09 Thread Yongseok Koh
This is the new design of Memory Region (MR) for mlx PMD, in order to: - Accommodate the new memory hotplug model. - Support non-contiguous Mempool. This patchset should be applied after: net/mlx5: change device reference for secondary process mem: add argument to memory event callback v2: * dr

[dpdk-dev] [PATCH v2 1/4] net/mlx5: remove Memory Region support

2018-05-09 Thread Yongseok Koh
This patch removes current support of Memory Region (MR) in order to accommodate the dynamic memory hotplug patch. This patch can be compiled but traffic can't flow and HW will raise faults. Subsequent patches will add new MR support. Signed-off-by: Yongseok Koh --- config/common_base

[dpdk-dev] [PATCH v2 2/4] net/mlx5: add new Memory Region support

2018-05-09 Thread Yongseok Koh
This is the new design of Memory Region (MR) for mlx PMD, in order to: - Accommodate the new memory hotplug model. - Support non-contiguous Mempool. There are multiple layers for MR search. L0 is to look up the last-hit entry which is pointed by mr_ctrl->mru (Most Recently Used). If L0 misses, L1

[dpdk-dev] [PATCH v2 3/4] net/mlx4: remove Memory Region support

2018-05-09 Thread Yongseok Koh
This patch removes current support of Memory Region (MR) in order to accommodate the dynamic memory hotplug patch. This patch can be compiled but traffic can't flow and HW will raise faults. Subsequent patches will add new MR support. Signed-off-by: Yongseok Koh --- config/common_base

[dpdk-dev] [PATCH v2 4/4] net/mlx4: add new Memory Region support

2018-05-09 Thread Yongseok Koh
This is the new design of Memory Region (MR) for mlx PMD, in order to: - Accommodate the new memory hotplug model. - Support non-contiguous Mempool. There are multiple layers for MR search. L0 is to look up the last-hit entry which is pointed by mr_ctrl->mru (Most Recently Used). If L0 misses, L1

Re: [dpdk-dev] [PATCH v1] doc: add mlx4 CRC stripping toggling limitation

2018-05-09 Thread Shahaf Shuler
Wednesday, May 9, 2018 1:32 PM, Ophir Munk: > Subject: RE: [PATCH v1] doc: add mlx4 CRC stripping toggling limitation > > Sure. Agreed. > > Regards, > Ophir > > > -Original Message- > > From: Shahaf Shuler > > Sent: Wednesday, May 09, 2018 1:07 PM > > To: Thomas Monjalon ; Ophir Munk > >

[dpdk-dev] [PATCH v2 1/3] net/mlx5: separate filling Rx flags

2018-05-09 Thread Yongseok Koh
Filling in fields of mbuf becomes a separate inline function so that this can be reused. Signed-off-by: Yongseok Koh Acked-by: Shahaf Shuler --- drivers/net/mlx5/mlx5_rxtx.c | 84 +++- 1 file changed, 51 insertions(+), 33 deletions(-) diff --git a/driver

Re: [dpdk-dev] [PATCH v2] net/mlx4: fix CRC stripping capability report

2018-05-09 Thread Shahaf Shuler
Tuesday, May 8, 2018 3:26 PM, Ophir Munk: > Subject: [PATCH v2] net/mlx4: fix CRC stripping capability report > > There are two capabilities related to CRC stripping: > 1. mlx4 HW capability to perform CRC stripping on a received packet. > This capability is built in mlx4 HW. It should be returned

[dpdk-dev] [PATCH v2 0/3] net/mlx5: add Multi-Packet Rx support

2018-05-09 Thread Yongseok Koh
Multi-Packet Rx Queue (MPRQ a.k.a Striding RQ) can further save PCIe bandwidth by posting a single large buffer for multiple packets. Instead of posting a buffer per a packet, one large buffer is posted in order to receive multiple packets on the buffer. A MPRQ buffer consists of multiple fixed-siz

  1   2   3   4   >