Re: [dpdk-dev] [PATCH v2] net/mlx5: fix flow director drop rule deletion crash

On Tue, May 15, 2018 at 09:26:35AM +0300, Shahaf Shuler wrote: > Drop flow rules are created on the ETH queue even though the parser layer > matches the flow rule layer (L3/L4) > > Fixes: 6f2f4948b236 ("net/mlx5: fix flow director rule deletion crash") > Cc: sta...@dpdk.org > Cc: adrien.mazarg...@

[dpdk-dev] [PATCH] bus/pci: correct the earlier strlcpy conversion

Fixes: fe5f777b5383 ("bus/pci: replace strncpy by strlcpy") Signed-off-by: Andy Green --- drivers/bus/pci/linux/pci.c |7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/bus/pci/linux/pci.c b/drivers/bus/pci/linux/pci.c index a73ee49c2..004600f1c 100644 --- a/dri

Re: [dpdk-dev] [PATCH v5 03/16] bus/pci: replace strncpy dangerous code

On 05/15/2018 02:12 PM, Yao, Lei A wrote: Hi, Andy This patch will break the vfio-pci driver on my server. I can't launch NIC with vfio-pci using testpmd. Could you have a check on this? Thanks a lot! My server info: OS: Ubuntu 16.04 LTS gcc: 5.4.0 kernel: 4.4.0 CPU: Intel(R) Xeon(R) CPU E5-

Re: [dpdk-dev] [PATCH v2] net/mlx5: fix flow director drop rule deletion crash

Tuesday, May 15, 2018 10:27 AM, Adrien Mazarguil: > ; dev@dpdk.org; sta...@dpdk.org > Subject: Re: [PATCH v2] net/mlx5: fix flow director drop rule deletion crash > > On Tue, May 15, 2018 at 09:26:35AM +0300, Shahaf Shuler wrote: > > Drop flow rules are created on the ETH queue even though the par

Re: [dpdk-dev] [PATCH] mempool: fix virt address mempool population

On 14-May-18 7:48 PM, Thomas Monjalon wrote: 14/05/2018 18:06, Anatoly Burakov: Currently, populate_virt will check if mempool is already populated. This will cause inability to reserve multi-chunk mempools if contiguous memory is not a hard requirement, because if allocating all-contiguous memo

Re: [dpdk-dev] [PATCH v5 03/16] bus/pci: replace strncpy dangerous code

> -Original Message- > From: Andy Green [mailto:a...@warmcat.com] > Sent: Tuesday, May 15, 2018 3:33 PM > To: Yao, Lei A ; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v5 03/16] bus/pci: replace strncpy dangerous > code > > > > On 05/15/2018 02:12 PM, Yao, Lei A wrote: > > Hi, Andy >

Re: [dpdk-dev] [dpdk-stable] [PATCH] net/bonding: fix slave activation simultaneously

Hi From: Chas Williams > There's possibly an issue here: > >         /* If the device isn't started don't handle interrupts */ >         if (!bonded_eth_dev->data->dev_started) >                 return rc; > >         /* verify that port_id is a valid slave of bonded port */ >         for (i = 0

[dpdk-dev] [PATCH 2/4] Driver/Mellanox: fix PMD compiling issue

Signed-off-by: Gavin Hu Signed-off-by: Sirshak Das Reviewed-by: Phil Yang Reviewed-by: Honnappa Nagarahalli --- drivers/net/mlx5/mlx5_rxtx_vec_neon.h | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/net/mlx5/mlx5_rxtx_vec_neon.h b/drivers/net/mlx5/mlx5_

[dpdk-dev] [PATCH 1/4] app: add LDFLAGS -latomic to link atomic lib

For ARM64 platform, libdpdk.a includes the librte_pmd_octeontx_ssovf.a, which requires the libatomic.a support.The atomic lib is built-in in the gcc toolchain, but for clang it has to be explicitly linked. For more details, please refer to https://clang.llvm.org/docs/Toolchain.html ~/dpdk/build/li

[dpdk-dev] [PATCH 0/4] *** fix native clang compiling errors on ARM64 ***

*** The patches are for fixing the native clang compiling errors on ARM64 building hosts.*** Gavin Hu (4): app: add LDFLAGS -latomic to link atomic lib Driver/Mellanox: fix PMD compiling issue cryptodev: fix the clang compiling issue ifpgai_rawdev: fix the clang compiling issue drivers/

[dpdk-dev] [PATCH 4/4] ifpgai_rawdev: fix the clang compiling issue

Newly introduced #pragma pack(1) in the header file caused comipiling issues for the files who included it. In file included from ~/dpdk/drivers/raw/ifpga_rawdev/base/ifpga_fme_dperf.c:5: In file included from ~/dpdk/drivers/raw/ifpga_rawdev/base/ifpga_feature_dev.h:8: ~/dpdk/drivers/raw/ifpga_ra

[dpdk-dev] [PATCH 3/4] cryptodev: fix the clang compiling issue

~/dpdk/lib/librte_eventdev/rte_event_crypto_adapter.c:530:49: error: 'rte_memcpy' call operates on objects of type 'struct rte_event' while the size is based on a different type 'struct rte_event *' [-Werror,-Wsizeof-pointer-memaccess] rte_memcpy(ev, &m_data->response_info,

[dpdk-dev] [PATCH] ethdev: fixed device info get issue

This patch fixed error function call order in rte_eth_dev_configure. This wrong order makes user can't get correct device informations, and cause DCB configure issue. Fixes: 3be82f5cc5e3 ("ethdev: support PMD-tuned Tx/Rx parameters") Signed-off-by: Qiming Yang --- lib/librte_ethdev/rte_ethdev.c

Re: [dpdk-dev] [PATCH v3 3/3] memzone: improve zero-length memzone reserve

On 15-May-18 7:24 AM, Remy Horton wrote: On 14/05/2018 12:29, Burakov, Anatoly wrote: [..] This failure is not caused by this patchset, and you should get similar failures on master if you get these while testing my patchset. I am not able to reproduce this issue, but i'll double-check the boun

Re: [dpdk-dev] [PATCH] ethdev: fixed device info get issue

On 05/15/2018 07:10 PM, Qiming Yang wrote: This patch fixed error function call order in rte_eth_dev_configure. This wrong order makes user can't get correct device informations, and cause DCB configure issue. Fixes: 3be82f5cc5e3 ("ethdev: support PMD-tuned Tx/Rx parameters") Signed-off-by: Qim

Re: [dpdk-dev] [PATCH 1/4] app: add LDFLAGS -latomic to link atomic lib

On Tue, May 15, 2018 at 04:28:41AM -0400, Gavin Hu wrote: > For ARM64 platform, libdpdk.a includes the librte_pmd_octeontx_ssovf.a, > which requires the libatomic.a support.The atomic lib is built-in in the > gcc toolchain, but for clang it has to be explicitly linked. > For more details, please re

Re: [dpdk-dev] [PATCH v2 4/4] net/mlx4: add new Memory Region support

On Thu, May 10, 2018 at 08:29:03PM +0100, Ferruh Yigit wrote: > On 5/10/2018 7:01 AM, Yongseok Koh wrote: > > > >> On May 9, 2018, at 8:00 PM, Yongseok Koh wrote: > >> > >> > >>> On May 9, 2018, at 4:12 PM, Ferruh Yigit wrote: > >>> > >>> On 5/9/2018 12:09 PM, Yongseok Koh wrote: > >>> <...> > >

Re: [dpdk-dev] [PATCH 1/4] app: add LDFLAGS -latomic to link atomic lib

-Original Message- > Date: Tue, 15 May 2018 04:28:41 -0400 > From: Gavin Hu > To: dev@dpdk.org > Subject: [dpdk-dev] [PATCH 1/4] app: add LDFLAGS -latomic to link atomic lib > X-Mailer: git-send-email 2.1.4 > > For ARM64 platform, libdpdk.a includes the librte_pmd_octeontx_ssovf.a, > whic

[dpdk-dev] [PATCH v2] net/tap: perform proto field update for tun only

The TX function is shared between TAP and TUN PMD. Checking TUN-TAP type field will ensure the TAP PMD will always have protocol field as 0. Signed-off-by: Vipin Varghese Suggested-by: Ferruh Yigit --- Changes in V2: updated in comment wording - Keith Wiles remove debug print from tx code - Kei

Re: [dpdk-dev] [PATCH] net/tap: perform proto field update for tun only

Thanks Keith, I have made changes and shared v2 patch for both the suggestions. Thanks Vipin Varghese > > + /* > > +* TUN and TAP are created with IFF_NO_PI disabled. > > +* For TUN PMD this mandatory as fields are used by > > +

Re: [dpdk-dev] [PATCH 2/4] Driver/Mellanox: fix PMD compiling issue

-Original Message- > Date: Tue, 15 May 2018 04:28:42 -0400 > From: Gavin Hu > To: dev@dpdk.org > CC: Sirshak Das > Subject: [dpdk-dev] [PATCH 2/4] Driver/Mellanox: fix PMD compiling issue > X-Mailer: git-send-email 2.1.4 Please add the reason and compilation error log. and make sure to f

[dpdk-dev] [PATCH v2 1/4] app: add LDFLAGS -latomic to link atomic lib

For ARM64 platform, libdpdk.a includes the librte_pmd_octeontx_ssovf.a, which requires the libatomic.a support.The atomic lib is built-in in the gcc toolchain, but for clang it has to be explicitly linked. For more details, please refer to https://clang.llvm.org/docs/Toolchain.html ~/dpdk/build/li

[dpdk-dev] [PATCH v2 4/4] ifpgai_rawdev: fix the clang compiling issue

Newly introduced #pragma pack(1) in the header file caused comipiling issues for the files who included it. In file included from ~/dpdk/drivers/raw/ifpga_rawdev/base/ifpga_fme_dperf.c:5: In file included from ~/dpdk/drivers/raw/ifpga_rawdev/base/ifpga_feature_dev.h:8: ~/dpdk/drivers/raw/ifpga_ra

[dpdk-dev] [PATCH v2 3/4] cryptodev: fix the clang compiling issue

~/dpdk/lib/librte_eventdev/rte_event_crypto_adapter.c:530:49: error: 'rte_memcpy' call operates on objects of type 'struct rte_event' while the size is based on a different type 'struct rte_event *' [-Werror,-Wsizeof-pointer-memaccess] rte_memcpy(ev, &m_data->response_info, si

[dpdk-dev] [PATCH v2 2/4] Driver/Mellanox: fix PMD compiling issue

Signed-off-by: Gavin Hu Signed-off-by: Sirshak Das Reviewed-by: Phil Yang Reviewed-by: Honnappa Nagarahalli --- drivers/net/mlx5/mlx5_rxtx_vec_neon.h | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/net/mlx5/mlx5_rxtx_vec_neon.h b/drivers/net/mlx5/mlx5_

Re: [dpdk-dev] [PATCH v2] net/mlx5: add bluefield device ID

On Tue, May 15, 2018 at 09:12:50AM +0300, Shahaf Shuler wrote: > Signed-off-by: Shahaf Shuler Acked-by: Nelio Laranjeiro > --- > > On v2: > - Updated mlx5 docs to include Bluefield product. > - PCI_DEVICE_ID_MELLANOX_BLUEFIELD -> PCI_DEVICE_ID_MELLANOX_CONNECTX5BF > > --- > config/common_b

Re: [dpdk-dev] [PATCH] net/mlx5: support MPLS-in-GRE and MPLS-in-UDP

Hi Matan, I have a single comment, please see bellow, On Mon, May 14, 2018 at 01:41:20PM +, Matan Azrad wrote: > Add support for MPLS over GRE and MPLS over UDP tunnel types as > described in the next RFCs: > 1. https://tools.ietf.org/html/rfc4023 > 2. https://tools.ietf.org/html/rfc7510 > 3

Re: [dpdk-dev] [PATCH v2] net/mlx5: add bluefield device ID

Tuesday, May 15, 2018 12:29 PM, Nélio Laranjeiro: > Subject: Re: [PATCH v2] net/mlx5: add bluefield device ID > > On Tue, May 15, 2018 at 09:12:50AM +0300, Shahaf Shuler wrote: > > Signed-off-by: Shahaf Shuler > > Acked-by: Nelio Laranjeiro Applied to next-net-mlx, thanks.

[dpdk-dev] [PATCH] bus/pci: fix driver name string manipulation

sizeof(dri_name) is 8B on 64Bit systems.The intended operation is coping the string after '/' from the string `name`. This bug is not letting to probe any device string >8B hence results in the testpmd error("No ethernet devices found) on some PMDs. Cc: Andy Green Cc: Pablo de Lara Fixes: fe5f

[dpdk-dev] [PATCH] test/eventdev: update the port id to 16 bit

port id in test case is update to unsigned int 16 bit, to prvent compilation faulure when RTE_ETH_MAX port is set more than 255. Signed-off-by: Vipin Varghese --- test/test/test_event_eth_rx_adapter.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/test/test_event_eth_rx

Re: [dpdk-dev] [PATCH 1/4] app: add LDFLAGS -latomic to link atomic lib

Hi Bruce, CC=clang Meson build did not hit this issue. The GNU Makefile using clang hit this issue: make config T=arm64-armv8a-linuxapp-clang Best Regards, Gavin -Original Message- From: Bruce Richardson Sent: Tuesday, May 15, 2018 5:00 PM To: Gavin Hu Cc: dev@dpdk.org Subject: Re: [d

Re: [dpdk-dev] [PATCH] bus/pci: fix driver name string manipulation

On 05/15/2018 06:03 PM, Jerin Jacob wrote: sizeof(dri_name) is 8B on 64Bit systems.The intended operation is coping the string after '/' from the string `name`. This bug is not letting to probe any device string >8B hence results in the testpmd error("No ethernet devices found) on some PMDs.

Re: [dpdk-dev] [PATCH] test/eventdev: update the port id to 16 bit

On 5/15/2018 9:18 PM, Vipin Varghese wrote: port id in test case is update to unsigned int 16 bit, to prvent compilation faulure when RTE_ETH_MAX port is set more ^^^ ^^^ ^^^ prevent failure RTE_MAX_ETHPORTS than 255. Signed-off-by: Vipin

[dpdk-dev] Unable to run the second DPDK app: Cannot allocate memzone list

Hi, starting from last night I cannot run the second DPDK app on the host. I definitely have problems on Ubuntu 16.04.4 (Linux 4.4.0-124-generic) and RHEL 7.5 (Linux 3.10.0-862.el7.x86_64). EAL command line option --file-prefix is used. So, it worked perfectly before. Not it fails in the follow

Re: [dpdk-dev] [PATCH] bus/pci: fix driver name string manipulation

-Original Message- > Date: Tue, 15 May 2018 18:19:19 +0800 > From: Andy Green > To: Jerin Jacob , dev@dpdk.org > CC: tho...@monjalon.net, ferruh.yi...@intel.com, Pablo de Lara > > Subject: Re: [dpdk-dev] [PATCH] bus/pci: fix driver name string manipulation > User-Agent: Mozilla/5.0 (X11;

[dpdk-dev] [PATCH v1 1/6] compress/zlib: add ZLIB PMD support

Add sw zlib pmd support in compressdev driver. Add device probe and remove support. Update makefile to build zlib. Signed-off-by: Sunila Sahu Signed-off-by: Shally Verma Signed-off-by: Ashish Gupta --- config/common_base | 6 ++ drivers/compress/Makefile

[dpdk-dev] [PATCH v1 2/6] compress/zlib: add device setup PMD ops

Implement device configure and PMD ops Signed-off-by: Sunila Sahu Signed-off-by: Shally Verma Signed-off-by: Ashish Gupta --- drivers/compress/zlib/zlib_pmd_ops.c | 238 +++ drivers/compress/zlib/zlib_pmd_private.h | 77 ++ 2 files changed, 315 insertio

[dpdk-dev] [PATCH v1 3/6] compress/zlib: add xform and stream create support

Implement private xform and stream create ops Signed-off-by: Sunila Sahu Signed-off-by: Shally Verma Signed-off-by: Ashish Gupta --- drivers/compress/zlib/zlib_pmd.c | 99 drivers/compress/zlib/zlib_pmd_ops.c | 84 -- 2 files

[dpdk-dev] [PATCH v1 0/6]compress: add zlib compression PMD

This patch series add software zlib based compression PMD in DPDK compress drivers. Application must need to install zlib prior to compile and run this PMD to avail compression/decompression services. Currently driver only tested for deflate, stateless compression and decompression with direct memo

[dpdk-dev] [PATCH v1 5/6] test: add ZLIB PMD for compressdev tests

link zlib pmd library in app.mk Signed-off-by: Sunila Sahu Signed-off-by: Shally Verma Signed-off-by: Ashish Gupta --- mk/rte.app.mk | 2 ++ 1 file changed, 2 insertions(+) diff --git a/mk/rte.app.mk b/mk/rte.app.mk index 6807663..71b9e89 100644 --- a/mk/rte.app.mk +++ b/mk/rte.app.mk @@ -237

[dpdk-dev] [PATCH v1 6/6] doc: add ZLIB PMD documentation

add zlib pmd feature specification and overview documentation Signed-off-by: Sunila Sahu Signed-off-by: Shally Verma Signed-off-by: Ashish Gupta --- doc/guides/compressdevs/features/zlib.ini | 22 ++ doc/guides/compressdevs/zlib.rst | 72 +++ 2 file

[dpdk-dev] [PATCH v1 4/6] compress/zlib: add enq deq apis

implement enqueue and dequeue apis Signed-off-by: Sunila Sahu Signed-off-by: Shally Verma Signed-off-by: Ashish Gupta --- drivers/compress/meson.build | 2 +- drivers/compress/zlib/meson.build | 11 ++ drivers/compress/zlib/zlib_pmd.c | 275 +- 3 fi

Re: [dpdk-dev] Unable to run the second DPDK app: Cannot allocate memzone list

On 15-May-18 11:24 AM, Andrew Rybchenko wrote: Hi, starting from last night I cannot run the second DPDK app on the host. I definitely have problems on Ubuntu 16.04.4 (Linux 4.4.0-124-generic) and RHEL 7.5 (Linux 3.10.0-862.el7.x86_64). EAL command line option --file-prefix is used. So, it worke

Re: [dpdk-dev] [PATCH] bus/pci: fix driver name string manipulation

On 05/15/2018 06:31 PM, Jerin Jacob wrote: -Original Message- Date: Tue, 15 May 2018 18:19:19 +0800 From: Andy Green To: Jerin Jacob , dev@dpdk.org CC: tho...@monjalon.net, ferruh.yi...@intel.com, Pablo de Lara Subject: Re: [dpdk-dev] [PATCH] bus/pci: fix driver name string manipul

[dpdk-dev] [PATCH] eal: move runtime dir creation after args parse

The intention of the original code was to create runtime data directory as early as possible, however it was moved too early, before the arguments were parsed, resulting in --file-prefix option essentially not working. Fix this by moving eal_create_runtime_dir() to after command line arguments par

Re: [dpdk-dev] Unable to run the second DPDK app: Cannot allocate memzone list

On 15-May-18 11:35 AM, Burakov, Anatoly wrote: On 15-May-18 11:24 AM, Andrew Rybchenko wrote: Hi, starting from last night I cannot run the second DPDK app on the host. I definitely have problems on Ubuntu 16.04.4 (Linux 4.4.0-124-generic) and RHEL 7.5 (Linux 3.10.0-862.el7.x86_64). EAL comma

Re: [dpdk-dev] [PATCH] bus/pci: correct the earlier strlcpy conversion

On 05/15/2018 10:31 AM, Andy Green wrote: Fixes: fe5f777b5383 ("bus/pci: replace strncpy by strlcpy") Signed-off-by: Andy Green Reviewed-by: Andrew Rybchenko Suggest to reword it as: bus/pci: fix invalid size of driver name buffer Variable dri_name is a pointer and it is incorrect to use i

Re: [dpdk-dev] [PATCH] bus/pci: fix driver name string manipulation

15/05/2018 12:41, Andy Green: > On 05/15/2018 06:31 PM, Jerin Jacob wrote: > >> [dpdk-dev] [PATCH] bus/pci: correct the earlier strlcpy conversion​ > > > > I am fine with taking any of the of the patch. Please improve the patch > > subject > > and bug description in case if you prefer to take yo

Re: [dpdk-dev] [PATCH] net/mlx5: support MPLS-in-GRE and MPLS-in-UDP

Hi Nelio From: Nélio Laranjeiro > Hi Matan, > > I have a single comment, please see bellow, > > On Mon, May 14, 2018 at 01:41:20PM +, Matan Azrad wrote: > > Add support for MPLS over GRE and MPLS over UDP tunnel types as > > described in the next RFCs: > > 1. > > https://emea01.safelinks.pro

[dpdk-dev] [PATCH v2] net/mlx5: support MPLS-in-GRE and MPLS-in-UDP

Add support for MPLS over GRE and MPLS over UDP tunnel types as described in the next RFCs: 1. https://tools.ietf.org/html/rfc4023 2. https://tools.ietf.org/html/rfc7510 3. https://tools.ietf.org/html/rfc4385 Signed-off-by: Matan Azrad --- doc/guides/nics/mlx5.rst | 4 +- drivers/net/mlx5/

Re: [dpdk-dev] [PATCH] mempool: fix virt address mempool population

On Tue, May 15, 2018 at 08:58:06AM +0100, Burakov, Anatoly wrote: > On 14-May-18 7:48 PM, Thomas Monjalon wrote: > > 14/05/2018 18:06, Anatoly Burakov: > > > Currently, populate_virt will check if mempool is already populated. > > > This will cause inability to reserve multi-chunk mempools if > > >

Re: [dpdk-dev] [dpdk-stable] [PATCH] ethdev: fixed device info get issue

On 5/15/2018 9:41 AM, Andrew Rybchenko wrote: > On 05/15/2018 07:10 PM, Qiming Yang wrote: >> This patch fixed error function call order in rte_eth_dev_configure. >> This wrong order makes user can't get correct device informations, >> and cause DCB configure issue. >> >> Fixes: 3be82f5cc5e3 ("ethd

Re: [dpdk-dev] [PATCH] eal: move runtime dir creation after args parse

On 05/15/2018 01:44 PM, Anatoly Burakov wrote: The intention of the original code was to create runtime data directory as early as possible, however it was moved too early, before the arguments were parsed, resulting in --file-prefix option essentially not working. Fix this by moving eal_create_

Re: [dpdk-dev] [PATCH v2 1/4] app: add LDFLAGS -latomic to link atomic lib

-Original Message- > Date: Tue, 15 May 2018 05:23:44 -0400 > From: Gavin Hu > To: dev@dpdk.org > Subject: [dpdk-dev] [PATCH v2 1/4] app: add LDFLAGS -latomic to link atomic > lib > X-Mailer: git-send-email 2.1.4 > > For ARM64 platform, libdpdk.a includes the librte_pmd_octeontx_ssovf.a,

Re: [dpdk-dev] [PATCH v2 3/4] cryptodev: fix the clang compiling issue

-Original Message- > Date: Tue, 15 May 2018 05:23:46 -0400 > From: Gavin Hu > To: dev@dpdk.org > Subject: [dpdk-dev] [PATCH v2 3/4] cryptodev: fix the clang compiling issue > X-Mailer: git-send-email 2.1.4 > > ~/dpdk/lib/librte_eventdev/rte_event_crypto_adapter.c:530:49: error: > 'rte_mem

Re: [dpdk-dev] [PATCH v2] net/mlx5: support MPLS-in-GRE and MPLS-in-UDP

On Tue, May 15, 2018 at 11:07:14AM +, Matan Azrad wrote: > Add support for MPLS over GRE and MPLS over UDP tunnel types as > described in the next RFCs: > 1. https://tools.ietf.org/html/rfc4023 > 2. https://tools.ietf.org/html/rfc7510 > 3. https://tools.ietf.org/html/rfc4385 > > Signed-off-by:

Re: [dpdk-dev] [PATCH] eal: move runtime dir creation after args parse

On 15-May-18 12:36 PM, Andrew Rybchenko wrote: On 05/15/2018 01:44 PM, Anatoly Burakov wrote: The intention of the original code was to create runtime data directory as early as possible, however it was moved too early, before the arguments were parsed, resulting in --file-prefix option essentia

Re: [dpdk-dev] [PATCH v2] net/tap: add RSS hash update callback

> On May 10, 2018, at 12:30 PM, Ophir Munk wrote: > > Add RSS hash update callback to eth_dev_ops. > > Signed-off-by: Ophir Munk > --- > v1: > Initial release > v2: > typo fix > Acked by: Keith Wiles Regards, Keith

[dpdk-dev] [PATCH v2] test/eventdev: update the port id to 16 bit

port id in test case is update to unsigned int 16 bit, to prevent compilation failure when RTE_MAX_ETHPORTS port is set more than 255. Signed-off-by: Vipin Varghese Acked-by: Nikhil Rao --- Changes for V2: spell check for commit message - Nikhil Rao --- test/test/test_event_eth_rx_adapter.c |

Re: [dpdk-dev] [PATCH] test/eventdev: update the port id to 16 bit

Thanks Nikhil, Have made changes and send a v2 for the same. > -Original Message- > From: Rao, Nikhil > Sent: Tuesday, May 15, 2018 3:54 PM > To: Varghese, Vipin ; dev@dpdk.org; Jain, Deepak K > > Cc: Rao, Nikhil > Subject: Re: [PATCH] test/eventdev: update the port id to 16 bit > > On

Re: [dpdk-dev] [PATCH v2] net/mlx5: support MPLS-in-GRE and MPLS-in-UDP

Tuesday, May 15, 2018 3:04 PM, Nélio Laranjeiro: > Subject: Re: [PATCH v2] net/mlx5: support MPLS-in-GRE and MPLS-in-UDP > > On Tue, May 15, 2018 at 11:07:14AM +, Matan Azrad wrote: > > Add support for MPLS over GRE and MPLS over UDP tunnel types as > > described in the next RFCs: > > 1. > > >

Re: [dpdk-dev] [PATCH] net/mlx5: fix compilation without tunnel RSS support

Monday, May 14, 2018 9:00 AM, Shahaf Shuler: > Subject: Re: [dpdk-dev] [PATCH] net/mlx5: fix compilation without tunnel > RSS support > > Sunday, May 13, 2018 4:28 PM, Xueming(Steven) Li: > > Thanks for fixing this, one minor issue below. > > > > > -Original Message- > > > From: Shahaf Shu

Re: [dpdk-dev] [PATCH v2] net/tap: perform proto field update for tun only

> On May 15, 2018, at 9:49 AM, Varghese, Vipin wrote: > > The TX function is shared between TAP and TUN PMD. Checking TUN-TAP > type field will ensure the TAP PMD will always have protocol field > as 0. > > Signed-off-by: Vipin Varghese > Suggested-by: Ferruh Yigit > --- > > Changes in V2:

Re: [dpdk-dev] [PATCH] net/tap: fix the vdev data sharing for tun

> On May 12, 2018, at 1:37 AM, Vipin Varghese wrote: > > Fixes: ee27edbe0c10 ("drivers/net: share vdev data to secondary process") > > Enables TUN PMD sharing by attaching the port from the shared data. > > Cc: zhihong.w...@intel.com > Cc: ferruh.yi...@intel.com > > Signed-off-by: Vipin Varg

Re: [dpdk-dev] [PATCH] net/i40e: fix fail to disable FDIR Tx queue

> -Original Message- > From: Xing, Beilei > Sent: Wednesday, May 16, 2018 12:19 AM > To: Wu, Jingjing ; Zhang, Qi Z > Cc: dev@dpdk.org; sta...@dpdk.org > Subject: [PATCH] net/i40e: fix fail to disable FDIR Tx queue > > If flow directory is enabled, FDIR Tx queue can't be disabled when exi

Re: [dpdk-dev] [PATCH] net/tap: update tap index to unsgined

> On May 12, 2018, at 1:30 AM, Vipin Varghese wrote: > > Updating the logic to reflect unsigned integer as index for TAP PMD. > > Signed-off-by: Vipin Varghese > --- > drivers/net/tap/rte_eth_tap.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/tap/rt

Re: [dpdk-dev] [PATCH] net/tap: fix the vdev data sharing for tun

HI Keith, Thanks for the input, please find my answer inline to email therad > > + /* TODO: request info from primary to set up Rx and Tx */ > > What is the rule (if we have one) about having TODO, FIXME, … like comments in > the code? Maybe remove the todo and create a enhancement r

Re: [dpdk-dev] [PATCH] librte_ip_frag: mbuf count, expiration

Hi Alex, On 14-May-18 3:23 PM, Alex Kiselev wrote: Hi. This patch adds two features to the librte_ip_frag library: The commit message will be saved in git history for all eternity. I don't think it should start with "Hi", it's not an email :) More to the point, generally, one patch == one

Re: [dpdk-dev] [PATCH] mempool: fix virt address mempool population

On 05/14/2018 07:06 PM, Anatoly Burakov wrote: Currently, populate_virt will check if mempool is already populated. This will cause inability to reserve multi-chunk mempools if contiguous memory is not a hard requirement, because if allocating all-contiguous memory fails, mempool will retry with

Re: [dpdk-dev] [PATCH 1/2] app/testpmd: add custom topology command

On 05/09/2018 01:34 PM, Wisam Jaddo wrote: > Set custom topology for forwading packets by making the ^ > given two ports as pair, in custom topology the active > ports will be the defiend in custum-topo only. ^^^^^ typos above and si

Re: [dpdk-dev] [PATCH] bus/pci: correct the earlier strlcpy conversion

15/05/2018 12:51, Andrew Rybchenko: > On 05/15/2018 10:31 AM, Andy Green wrote: > > Fixes: fe5f777b5383 ("bus/pci: replace strncpy by strlcpy") > > Signed-off-by: Andy Green > > Reviewed-by: Andrew Rybchenko > > Suggest to reword it as: > > bus/pci: fix invalid size of driver name buffer > >

[dpdk-dev] [PATCH] net/mlx5: fix default RSS level

Using inner RSS by default for GRE leads to memory corruption as the extra flow items added for the inner RSS are not counted in the flow attributes buffer size. Fixing by enforcing the default RSS level to be outer. This much simplify the flow engine and more robust. Future optimization for out o

Re: [dpdk-dev] [PATCH v2 3/4] cryptodev: fix the clang compiling issue

> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Jerin Jacob > Sent: Tuesday, May 15, 2018 12:42 PM > To: Gavin Hu > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v2 3/4] cryptodev: fix the clang compiling > issue > > -Original Message- > > Date:

Re: [dpdk-dev] [PATCH] vhost: improve dirty pages logging performance

Hi Tiwei, I just see I missed to reply to your comment on my commit message: On 05/03/2018 01:56 PM, Tiwei Bie wrote: On Mon, Apr 30, 2018 at 05:59:54PM +0200, Maxime Coquelin wrote: This patch caches all dirty pages logging until the used ring index is updated. These dirty pages won't be acce

Re: [dpdk-dev] [PATCH] eal: move runtime dir creation after args parse

15/05/2018 14:16, Burakov, Anatoly: > On 15-May-18 12:36 PM, Andrew Rybchenko wrote: > > On 05/15/2018 01:44 PM, Anatoly Burakov wrote: > >> The intention of the original code was to create runtime data > >> directory as early as possible, however it was moved too early, > >> before the arguments w

Re: [dpdk-dev] [PATCH 1/2] app/testpmd: add custom topology command

Hey Kevin, What if I have 10 ports and want all 9 ports to forward packets to port 0, this cannot done in paired. But with this topo the user can overwrite the topo. E.g: - Set custom-topo 1 0 Will make those paired and those two as active only. - set custom-topo 2 0 Will make those two as paire

Re: [dpdk-dev] [PATCH] mempool: fix virt address mempool population

15/05/2018 13:28, Olivier Matz: > On Tue, May 15, 2018 at 08:58:06AM +0100, Burakov, Anatoly wrote: > > On 14-May-18 7:48 PM, Thomas Monjalon wrote: > > > 14/05/2018 18:06, Anatoly Burakov: > > > > Currently, populate_virt will check if mempool is already populated. > > > > This will cause inabilit

Re: [dpdk-dev] [PATCH v3 2/4] net/bnx2x: correct unmeetable comparison

15/05/2018 00:16, Mody, Rasesh: > > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Andy Green > > Sent: Sunday, May 13, 2018 10:05 PM > > > > /home/agreen/projects/dpdk/drivers/net/bnx2x/elink.c: > > In function ‘elink_check_kr2_wa’: > > /home/agreen/projects/dpdk/drivers/net/bnx2x/elink.c:1

[dpdk-dev] [PATCH] eal/service: improve error checking of coremasks

This commit improves the error checking performed on the core masks (or lists) of the service cores, in particular with respect to the data-plane (RTE) cores of DPDK. With this commit, invalid configurations are detected at runtime, and warning messages are printed to inform the user. For example

[dpdk-dev] [PATCH] bus/pci: fix error in parsing vfio driver

In pci_get_kernel_driver_by_path(), the available memory size of dri_name should be strlen(name + 1) + 1, not the size of the pointer (8 bytes), so "vfio-pci" is truncated to "vfio-pc" ended with number 0. This patch fixes it. Fixes: fe5f777b5383 ("bus/pci: replace strncpy by strlcpy") Cc: sta...@

Re: [dpdk-dev] [PATCH] bus/pci: fix error in parsing vfio driver

Give up this patch as there is already a patch in http://dpdk.org/dev/patchwork/patch/40030/ bus/pci: correct the earlier strlcpy conversion > -Original Message- > From: Dai, Wei > Sent: Tuesday, May 15, 2018 10:41 PM > To: Yigit, Ferruh ; Burakov, Anatoly > > Cc: dev@dpdk.org; Dai, Wei

[dpdk-dev] [dpdk-announce] SPDK Summit Live streamed!

Hi All, We are happy to announce we will be live streaming the summit today and tomorrow. Please tune into to the link below to watch the sessions as they are delivered. Here is the agenda for the event. www.youtube.com/watch?v=g7J2i_jxBJI Thanks An

Re: [dpdk-dev] [PATCH] eal/service: improve error checking of coremasks

15/05/2018 16:52, Harry van Haaren: > + if (eal_service_cores_parsed()) > + RTE_LOG(ERR, EAL, > + "Warning: Service cores parsed before dataplane cores. > Ensure -c is before -s or -S.\n"); > + [...] > + if (core_parsed && taken_lcore_count != count) { > +

[dpdk-dev] [PATCH 1/2] net/mlx4: fix inadequate default in RSS converter

Below commit documents 0 as a value standing for a default set of RSS hash types, however the mlx4 PMD doesn't interpret it correctly and still uses its own internal special value for that (-1). Also, its function prototype was not updated. Fixes: ac8d22de2394 ("ethdev: flatten RSS configuration

[dpdk-dev] [PATCH 2/2] net/mlx4: refactor RSS conversion functions

Since commit 97b2217ae5bc ("net/mlx4: advertise supported RSS hash functions"), this PMD includes two similar-looking functions that convert RSS hash fields between Verbs and DPDK formats. This patch refactors them as a single two-way function and gets rid of redundant helper macros. Note the los

[dpdk-dev] [PATCH v2] eal/service: improve error checking of coremasks

This commit improves the error checking performed on the core masks (or lists) of the service cores, in particular with respect to the data-plane (RTE) cores of DPDK. With this commit, invalid configurations are detected at runtime, and warning messages are printed to inform the user. For example

[dpdk-dev] [PATCH v3 0/3] enhance sanity scripts

1/3: new test cases are added to sanity script 2/3: skipped test case result is updated appropriately 3/3: test cmdline is updated to support freebsd Signed-off-by: Jananee Parthasarathy Reviewed-by: Reshma Pattan Reviewed-by: Anatoly Burakov --- v3: created separate patches for all sanity sc

[dpdk-dev] [PATCH v3 1/3] app/test: add new test cases to sanity script

Sanity Script is enhanced with additional test cases being added to autotest_data.py Signed-off-by: Jananee Parthasarathy --- test/test/autotest_data.py | 471 - 1 file changed, 462 insertions(+), 9 deletions(-) mode change 100644 => 100755 test/test/

[dpdk-dev] [PATCH v3 3/3] app/test: enhance freebsd support in sanity script

Update test command line with no additional arguments, as FreeBSD doesn't support socket-mem, file-prefix options Signed-off-by: Jananee Parthasarathy --- test/test/autotest_runner.py | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/test/test/autotest_runner.py b/test/t

[dpdk-dev] [PATCH v3 2/3] app/test: update result for skipped test cases

Fixed in autotest_test_funcs.py to handle test cases which returns "Skipped" as result. The issue was skipped test cases got timed out, causing delay in sanity script execution. Signed-off-by: Jananee Parthasarathy --- test/test/autotest_test_funcs.py | 6 -- 1 file changed, 4 insertions(+),

Re: [dpdk-dev] [PATCH v3 1/3] app/test: add new test cases to sanity script

On 15-May-18 4:58 PM, Jananee Parthasarathy wrote: Sanity Script is enhanced with additional test cases being added to autotest_data.py Signed-off-by: Jananee Parthasarathy --- Patchset-wide reviews/acks should be part of the commit message. Just out of curiousity - where did the name "sanit

Re: [dpdk-dev] [PATCH v2] app/test: enhance sanity script

Hi Thomas, -Original Message- From: Thomas Monjalon [mailto:tho...@monjalon.net] Sent: Monday, May 14, 2018 3:42 AM To: Parthasarathy, JananeeX M Cc: dev@dpdk.org; Burakov, Anatoly ; Pattan, Reshma Subject: Re: [dpdk-dev] [PATCH v2] app/test: enhance sanity script Hi, 10/05/2018 12:3

Re: [dpdk-dev] [PATCH v2] app/test: enhance sanity script

15/05/2018 18:14, Parthasarathy, JananeeX M: > From: Thomas Monjalon [mailto:tho...@monjalon.net] > > 10/05/2018 12:36, Jananee Parthasarathy: > > > 1. Sanity Script is enhanced with additional test cases being added to > > > autotest_data.py > > > > How long they are? > > How did you choose to g

[dpdk-dev] [PATCH] maintainers: fix responsibility of flow API bits

The following commits lack MAINTAINERS entries for this mess. Fixes: 4d73b6fb9907 ("doc: add generic flow API guide") Fixes: 19c90af6285c ("app/testpmd: add flow command") Cc: sta...@dpdk.org Signed-off-by: Adrien Mazarguil Cc: Bernard Iremonger --- MAINTAINERS | 2 ++ 1 file changed, 2 insert

[dpdk-dev] [PATCH] app/test-pmd: fix testpmd log of start command

In the testpmd log of the start command, show the RX and TX descriptor values from dev_info instead of the default values. Fixes: d44f8a485f5d ("app/testpmd: enable per queue configure") Reported-by: Ferruh Yigit Signed-off-by: Bernard Iremonger --- app/test-pmd/testpmd.c | 4 ++-- 1 file chan

[dpdk-dev] [PATCH] igb_uio: fail and log if kernel lock down is enabled

When EFI secure boot is enabled, it is possible to lock down kernel and prevent accessing device BARs and this makes igb_uio unusable. Lock down patches are not part of the vanilla kernel but they are applied and used by some distros already [1]. It is not possible to fix this issue, but intentio

Re: [dpdk-dev] [PATCH v2 2/4] Driver/Mellanox: fix PMD compiling issue

> On May 15, 2018, at 2:23 AM, Gavin Hu wrote: The title should start from 'net/mlx5: ...' and please be more specific why that pair of parentheses is needed. Add more commit messages and it'd be better to add the error messages like you do in the other commit. To me, it still looks unnecessary

Re: [dpdk-dev] [PATCH v3 3/4] net/mlx5: solve var may be used uninitialized

> On May 13, 2018, at 10:04 PM, Andy Green wrote: > > Signed-off-by: Andy Green > Fixes: ccdcba53a3f4 ("net/mlx5: use Netlink to add/remove MAC addresses") > Acked-by: Pablo de Lara > --- Acked-by: Yongseok Koh Thanks > drivers/net/mlx5/mlx5.c |2 +- > 1 file changed, 1 insertion(+), 1

[dpdk-dev] [PATCH v2] vhost: improve dirty pages logging performance

This patch caches all dirty pages logging until the used ring index is updated. These dirty pages won't be accessed by the guest as long as the host doesn't give them back to it by updating the index. The goal of this optimization is to fix a performance regression introduced when the vhost librar

Re: [dpdk-dev] [PATCH] igb_uio: fail and log if kernel lock down is enabled

On Tue, 2018-05-15 at 17:56 +0100, Ferruh Yigit wrote: > When EFI secure boot is enabled, it is possible to lock down kernel > and > prevent accessing device BARs and this makes igb_uio unusable. > > Lock down patches are not part of the vanilla kernel but they are > applied and used by some distr

  1   2   >