[dpdk-dev] [PATCH v2] doc: correct spell issues in i40e.rst

2018-05-16 Thread Qiming Yang
This patch corrects some spelling issues in i40e.rst and clarifies which controllers and connections are part of the 700 Series. Signed-off-by: Qiming Yang --- doc/guides/nics/i40e.rst | 71 +--- 1 file changed, 37 insertions(+), 34 deletions(-) diff

[dpdk-dev] [PATCH] doc: correct spell issues in i40e.rst

2018-05-16 Thread Qiming Yang
This patch corrects some spelling issues in i40e.rst and clarifies which controllers and connections are part of the 700 Series. Signed-off-by: Qiming Yang --- doc/guides/nics/i40e.rst | 71 +--- 1 file changed, 37 insertions(+), 34 deletions(-) diff

Re: [dpdk-dev] [PATCH] compressdev: clarify buffer size limitation

2018-05-16 Thread Verma, Shally
>-Original Message- >From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Fiona Trahe >Sent: 16 May 2018 19:49 >To: dev@dpdk.org >Cc: pablo.de.lara.gua...@intel.com; fiona.tr...@intel.com >Subject: [dpdk-dev] [PATCH] compressdev: clarify buffer size limitation > >Signed-off-by: Fiona Trah

Re: [dpdk-dev] [PATCH] net/i40e: fix link up failure issue

2018-05-16 Thread Guo, Jia
make sense , will split the patch more explicit. thanks ,qi. On 5/16/2018 10:43 PM, Zhang, Qi Z wrote: Hi Jeff: -Original Message- From: Guo, Jia Sent: Wednesday, May 16, 2018 2:29 PM To: Xing, Beilei ; Zhang, Qi Z Cc: dev@dpdk.org; Guo, Jia Subject: [PATCH] net/i40e: fix link up fa

Re: [dpdk-dev] mellanox connectx-2 support

2018-05-16 Thread Olga Shern
Vasily, ConnectX-2 is very, very old card. We don't support it. You can run DPDK on ConnectX-3 Pro, ConnectX-4 /LX and ConnectX-5 NICs. The best performance and better feature set you will get with ConnectX-5 Best Regards, Olga --- Olga She

[dpdk-dev] [PATCH] net/ixgbe: fix VLAN strip setting fail for per port

2018-05-16 Thread Yanglong Wu
VLAN-strip should be set by both per port and per queue Fixes: 860a94d3c692 ("net/ixgbe: support VLAN strip per queue offloading in VF") Signed-off-by: Yanglong Wu --- drivers/net/ixgbe/ixgbe_ethdev.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/ixgbe/ixgbe_

[dpdk-dev] [PATCH] net/ixgbe: fix dcb configuration issue

2018-05-16 Thread Qiming Yang
This patch removed unnecessary check in ixgbe_check_mq_mode, fixed historical issue. Fixes: 27b609cbd1c6 ("ethdev: move the multi-queue mode check to specific drivers") Cc: sta...@dpdk.org Signed-off-by: Qiming Yang --- drivers/net/ixgbe/ixgbe_ethdev.c | 37

[dpdk-dev] [PATCH] net/ixgbe: fix too many interrupts

2018-05-16 Thread Wenzhuo Lu
To support kernel VF, PBA bit is always set. But it may cause the too many interrupts issue on specific Linux kernel, like 4.4.0-116. PF host should set the atuo clean, mask and throttling as we always set the register for kernel VF. Fixes: 6b75183ac4d0 ("net/ixgbe: fix wrong PBA setting") Signed

[dpdk-dev] [PATCH] app/testpmd: add to call detach for vdev when quitting

2018-05-16 Thread zhiyong . yang
For vdev, just calling rte_eth_dev_close() isn't enough to free all the resources allocated during device probe, e.g. for virtio-user, virtio_user_pmd_remove(), i.e. the remove() method of a vdev driver, needs to be called to unlink the socket file created during device probe. So this patch calls t

Re: [dpdk-dev] [PATCH v3] vhost: improve dirty pages logging performance

2018-05-16 Thread Tiwei Bie
On Thu, May 17, 2018 at 06:06:34AM +0300, Michael S. Tsirkin wrote: > On Wed, May 16, 2018 at 06:54:23PM +0200, Maxime Coquelin wrote: > > This patch caches all dirty pages logging until the used ring index > > is updated. > > > > The goal of this optimization is to fix a performance regression >

Re: [dpdk-dev] [PATCH v3] vhost: improve dirty pages logging performance

2018-05-16 Thread Michael S. Tsirkin
On Wed, May 16, 2018 at 06:54:23PM +0200, Maxime Coquelin wrote: > This patch caches all dirty pages logging until the used ring index > is updated. > > The goal of this optimization is to fix a performance regression > introduced when the vhost library started to use atomic operations > to set bi

[dpdk-dev] [PATCH v4 2/3] eventdev: fix the clang compiling issue

2018-05-16 Thread Gavin Hu
From: gavin hu This patch fix the clang compiling issue reported on the ARM64 builing hosts. ev is a pointer in size of 64bit, but herein it should be the size of its content. ~/dpdk/lib/librte_eventdev/rte_event_crypto_adapter.c:530:49: error: 'rte_memcpy' call operates on objects of type 'stru

[dpdk-dev] [PATCH v4 3/3] raw/ifpga: fix the clang compiling issue

2018-05-16 Thread Gavin Hu
From: gavin hu The patch fixes the compile issue with clang on ARM64, as well as clang + X86 builing hosts. Newly introduced #pragma pack(1) in the header file caused comipiling issues for the files who included it. In file included from ~/dpdk/drivers/raw/ifpga_rawdev/base/ ifpga_fme_dperf.c:5

[dpdk-dev] [PATCH v4 1/3] net/mlx5: fix the clang compiling issue

2018-05-16 Thread Gavin Hu
From: gavin hu This patch adds a pair of "()" to embrace the argument input to the function-like macro invocation. drivers/net/mlx5/mlx5_rxtx_vec.c:37: drivers/net/mlx5/mlx5_rxtx_vec_neon.h:170:24: error: too many arguments provided to function-like macro invocation (uint16x8_t) { 0, 0,

Re: [dpdk-dev] How to dump DPDK log?

2018-05-16 Thread Sam
Oh, it should be user1,8 in dpdk-17.05 OMG 2018-05-17 10:26 GMT+08:00 Sam : > How to set this param... > > I use this, but report me bug: > > sudo /usr/local/bin/ovs-vsctl --no-wait set Open_vSwitch . > other_config:dpdk-extra="--log-level=user1,debug -c 0x40004 -n 4 > --socket-mem 1024 -w 0

Re: [dpdk-dev] How to dump DPDK log?

2018-05-16 Thread Sam
How to set this param... I use this, but report me bug: sudo /usr/local/bin/ovs-vsctl --no-wait set Open_vSwitch . other_config:dpdk-extra="--log-level=user1,debug -c 0x40004 -n 4 --socket-mem 1024 -w :01:00.0 -w :01:00.1" Bug: 2018-05-17T02:23:21.878Z|00010|dpdk|INFO|EAL ARGS: ovs-vswi

Re: [dpdk-dev] [PATCH v3] vhost: improve dirty pages logging performance

2018-05-16 Thread Tiwei Bie
On Wed, May 16, 2018 at 06:54:23PM +0200, Maxime Coquelin wrote: > This patch caches all dirty pages logging until the used ring index > is updated. > > The goal of this optimization is to fix a performance regression > introduced when the vhost library started to use atomic operations > to set bi

Re: [dpdk-dev] [PATCH v3 3/3] raw/ifpga_rawdev: fix the clang compiling issue

2018-05-16 Thread Gavin Hu
If the subject changes to raw/ifpga, it will get a Wrong headline prefix(can be ignored?) warning when running git-log-fixes.h Wrong headline prefix: raw/ifpga: fix the clang compiling issue -Original Message- From: Jerin Jacob Sent: Wednesday, May 16, 2018 2:46 PM To: Gavin Hu

Re: [dpdk-dev] [PATCH] doc: correct spell issues in i40e.rst

2018-05-16 Thread Yang, Qiming
> -Original Message- > From: Kovacevic, Marko > Sent: Wednesday, May 16, 2018 9:36 PM > To: dev ; dev@dpdk.org > Cc: Yigit, Ferruh ; Yang, Qiming > > Subject: RE: [dpdk-dev] [PATCH] doc: correct spell issues in i40e.rst > > > This patch corrects some spelling issues in i40e.rst and clarif

[dpdk-dev] [PATCH V2] librte_hash: new hash del abi to return stored value

2018-05-16 Thread Vijaya Mohan Guvva
V2: Adding another new interface rte_hash_del_key_data to delete key from hash table and return stored data. V1: Add a new key delete interface rte_hash_del_key_with_hash_data to delete the key from hash and return the value stored. This is useful for hash users to free the data stored in the tabl

[dpdk-dev] mellanox connectx-2 support

2018-05-16 Thread Vasiliy Tolstov
Hello. I have some mellanox (ConnectX-2 ?) cards (MT26428) does it possible to use it with dpdk? Why dpdk supports only X-4 and X-5 cards? Thanks! -- Vasiliy Tolstov, e-mail: v.tols...@selfip.ru

[dpdk-dev] [PATCH v9 4/5] net/netvsc: add documentation

2018-05-16 Thread Stephen Hemminger
From: Stephen Hemminger Matching documentation for new netvsc device. Signed-off-by: Stephen Hemminger --- doc/guides/nics/features/netvsc.ini| 23 ++ doc/guides/nics/index.rst | 1 + doc/guides/nics/netvsc.rst | 103 + doc/guides/rel

[dpdk-dev] [PATCH v9 3/5] net/netvsc: add hyper-v netvsc network device

2018-05-16 Thread Stephen Hemminger
The driver supports Hyper-V networking directly like virtio for KVM or vmxnet3 for VMware. This code is based off of the FreeBSD driver. The file and variable names are kept the same to help with understanding (with most of the BSD style warts removed). This version supports the latest NetVSP 6.1

[dpdk-dev] [PATCH v9 5/5] bus/vmbus and net/netvsc: add meson build support

2018-05-16 Thread Stephen Hemminger
From: Stephen Hemminger Update meson build files for new netvsc and vmbus drivers. Signed-off-by: Stephen Hemminger --- drivers/bus/meson.build| 2 +- drivers/bus/vmbus/meson.build | 18 ++ drivers/net/meson.build| 2 +- drivers/net/netvsc/meson.build | 7 ++

[dpdk-dev] [PATCH v9 1/5] eal: add rte_uuid support

2018-05-16 Thread Stephen Hemminger
Since uuid functions may not be available everywhere, implement uuid functions in DPDK. These are based off the BSD licensed libuuid in util-link. Signed-off-by: Stephen Hemminger --- lib/librte_eal/bsdapp/eal/Makefile | 1 + lib/librte_eal/common/Makefile | 2 +- lib/librte_

[dpdk-dev] [PATCH v9 2/5] bus/vmbus: add hyper-v virtual bus support

2018-05-16 Thread Stephen Hemminger
This patch adds support for an additional bus type Virtual Machine BUS (VMBUS) on Microsoft Hyper-V in Windows 10, Windows Server 2016 and Azure. Most of this code was extracted from FreeBSD and some of this is from earlier code donated by Brocade. Only Linux is supported at present, but the code

[dpdk-dev] [PATCH v9 0/5] Hyper-V/Azure netvsc PMD and bus support

2018-05-16 Thread Stephen Hemminger
Yet another version of the Hyper-V native bus (VMBus) and network device (netvsc) drivers. This virtual device is used in Microsoft Hyper-V in Windows 10, Windows Server 2016 and Azure. Most of this code was extracted from FreeBSD and some of this is from earlier code donated by Brocade. Only Linu

[dpdk-dev] [PATCH] bus/vdev: don't double space log messages

2018-05-16 Thread Stephen Hemminger
The VDEV_LOG() macro already adds a newline, don't duplicate. Signed-off-by: Stephen Hemminger --- drivers/bus/vdev/vdev.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/bus/vdev/vdev.c b/drivers/bus/vdev/vdev.c index 9f576eb80f26..099b9ff85a70 100644 --- a/d

Re: [dpdk-dev] [PATCH v2] doc: advise to specify LTS branch when backporting patches

2018-05-16 Thread Kevin Traynor
On 05/16/2018 06:05 PM, luca.bocca...@gmail.com wrote: > From: Luca Boccassi > > We have many stable branches being maintained at the same time, and > sometimes it's not clear which branch a patch is being backported for. > Note in the guidelines that it should be specified via the cover letter,

[dpdk-dev] [PATCH v2] doc: advise to specify LTS branch when backporting patches

2018-05-16 Thread luca . boccassi
From: Luca Boccassi We have many stable branches being maintained at the same time, and sometimes it's not clear which branch a patch is being backported for. Note in the guidelines that it should be specified via the cover letter, annotation or using --subject-prefix. Also note to send only to s

Re: [dpdk-dev] [PATCH] doc: advise to specify LTS branch when backporting patches

2018-05-16 Thread Luca Boccassi
On Wed, 2018-05-16 at 16:19 +0100, Kevin Traynor wrote: > On 05/16/2018 03:31 PM, luca.bocca...@gmail.com wrote: > > From: Luca Boccassi > > > > We have many stable branches being maintaned at the same time, and > > typo > > > sometimes it's not clear which branch a patch is being backported >

[dpdk-dev] [PATCH v3] vhost: improve dirty pages logging performance

2018-05-16 Thread Maxime Coquelin
This patch caches all dirty pages logging until the used ring index is updated. The goal of this optimization is to fix a performance regression introduced when the vhost library started to use atomic operations to set bits in the shared dirty log map. While the fix was valid as previous implement

Re: [dpdk-dev] [PATCH] mempool/bucket: add the driver to meson build

2018-05-16 Thread Andrew Rybchenko
On 05/16/2018 07:41 PM, Andrew Rybchenko wrote: Fixes: 4ed00862c81d ("mempool/bucket: implement bucket mempool manager") Signed-off-by: Andrew Rybchenko Self NACK, sorry v2 is sent to fix From: and I've just realized that forgot to use --in-reply-to in v2

[dpdk-dev] [PATCH v2] mempool/bucket: add the driver to meson build

2018-05-16 Thread Andrew Rybchenko
Fixes: 4ed00862c81d ("mempool/bucket: implement bucket mempool manager") Signed-off-by: Andrew Rybchenko --- v1 -> v2: - fix from to be consistent with signed-off-by config/meson.build | 1 + drivers/mempool/meson.build | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --g

[dpdk-dev] [PATCH] mempool/bucket: add the driver to meson build

2018-05-16 Thread Andrew Rybchenko
From: Andrew Rybchenko Fixes: 4ed00862c81d ("mempool/bucket: implement bucket mempool manager") Signed-off-by: Andrew Rybchenko --- config/meson.build | 1 + drivers/mempool/meson.build | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/config/meson.build b/config/m

[dpdk-dev] [PATCH] net/mlx4: fix shifts of signed values

2018-05-16 Thread Adrien Mazarguil
This patch addresses the following issues reported by cppcheck: [drivers/net/mlx4/mlx4_rxtx.c:266]: (error) Shifting signed 32-bit value by 31 bits is undefined behaviour [drivers/net/mlx4/mlx4_rxtx.c:624]: (error) Shifting signed 32-bit value by 31 bits is undefined behaviour [driver

[dpdk-dev] [PATCH v1] net/tap: keep device alive when no queues exist

2018-05-16 Thread Ophir Munk
TAP device is created following its first queue creation. Multiple queues can be added or removed over time. In Linux terminology those are file descriptors which are opened or closed over time. As long as the number of opened file descriptors is positive - TAP device will appear as a Linux device.

Re: [dpdk-dev] cppcheck on dpdk

2018-05-16 Thread Adrien Mazarguil
On Wed, May 16, 2018 at 01:41:09PM +0100, Ferruh Yigit wrote: > Today after listening Colin's Static Analysis talk, I run cppcheck on > v18.05-rc4 > code and it revealed some issues, sharing here for anyone to interested in > fixing them. At least I encourage to check maintainers to check their ow

Re: [dpdk-dev] [dpdk-stable] [PATCH v2] crypto/scheduler: fix multicore rings re-use

2018-05-16 Thread De Lara Guarch, Pablo
> -Original Message- > From: stable [mailto:stable-boun...@dpdk.org] On Behalf Of Kirill Rybalchenko > Sent: Wednesday, May 16, 2018 3:25 PM > To: dev@dpdk.org > Cc: sta...@dpdk.org; Rybalchenko, Kirill ; > Zhang, > Roy Fan > Subject: [dpdk-stable] [PATCH v2] crypto/scheduler: fix multi

[dpdk-dev] [PATCH 1/2] app/testpmd: fix copy of raw flow item (revisited)

2018-05-16 Thread Adrien Mazarguil
While previous fix with the same title does address the main issue, root cause is that proper handling of spec/last/mask was overlooked in the original patch. Mask and last fields must be taken into account at all times. Fixes: d0ad8648b1c5 ("app/testpmd: fix RSS flow action configuration") Fixes

[dpdk-dev] [PATCH 2/2] ethdev: fix shallow copy of flow API RAW item

2018-05-16 Thread Adrien Mazarguil
Like original commit mentioned below, this fix synchronizes flow rule copy function with testpmd's own implementation following "app/testpmd: fix copy of raw flow item (revisited)". Fixes: d0ad8648b1c5 ("ethdev: fix shallow copy of flow API RSS action") Cc: sta...@dpdk.org Cc: Qi Zhang Signed-of

Re: [dpdk-dev] [PATCH] doc: advise to specify LTS branch when backporting patches

2018-05-16 Thread Kevin Traynor
On 05/16/2018 03:31 PM, luca.bocca...@gmail.com wrote: > From: Luca Boccassi > > We have many stable branches being maintaned at the same time, and typo > sometimes it's not clear which branch a patch is being backported for. > Note in the guidelines that it should be specified via the cover le

Re: [dpdk-dev] [PATCH v3 2/2] app/testpmd: add set topology on the fly command

2018-05-16 Thread Iremonger, Bernard
Hi Wisam, > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Wisam Jaddo > Sent: Wednesday, May 9, 2018 1:47 PM > To: Wu, Jingjing ; Lu, Wenzhuo > ; tho...@monjalon.net > Cc: rasl...@mellanox.com; dev@dpdk.org; shah...@mellanox.com; > wis...@mellanox.com > Subject:

Re: [dpdk-dev] [PATCH v3 1/2] app/testpmd: add custom topology command

2018-05-16 Thread Iremonger, Bernard
Hi Wisam, > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Wisam Jaddo > Sent: Wednesday, May 9, 2018 1:47 PM > To: Wu, Jingjing ; Lu, Wenzhuo > ; tho...@monjalon.net > Cc: rasl...@mellanox.com; dev@dpdk.org; shah...@mellanox.com; > wis...@mellanox.com > Subject:

Re: [dpdk-dev] [PATCH] vhost: improve dirty pages logging performance

2018-05-16 Thread Maxime Coquelin
On 05/16/2018 08:10 AM, Tiwei Bie wrote: On Tue, May 15, 2018 at 03:50:54PM +0200, Maxime Coquelin wrote: Hi Tiwei, I just see I missed to reply to your comment on my commit message: On 05/03/2018 01:56 PM, Tiwei Bie wrote: On Mon, Apr 30, 2018 at 05:59:54PM +0200, Maxime Coquelin wrote: T

Re: [dpdk-dev] [PATCH 0/2] app/testpmd: introduce new commands in forward topology

2018-05-16 Thread Gaëtan Rivet
Hi, On Wed, May 09, 2018 at 03:34:37PM +0300, Wisam Jaddo wrote: > 1- Add new forward topology (custom): This toplogy will > allow to create any topoloy you may need. > 2- Add new command to set the custom toplogy. > 3- Add new command to set the topoly on the fly. I have had the same kind of iss

Re: [dpdk-dev] [PATCH] net/i40e: fix link up failure issue

2018-05-16 Thread Zhang, Qi Z
Hi Jeff: > -Original Message- > From: Guo, Jia > Sent: Wednesday, May 16, 2018 2:29 PM > To: Xing, Beilei ; Zhang, Qi Z > Cc: dev@dpdk.org; Guo, Jia > Subject: [PATCH] net/i40e: fix link up failure issue > > If don't enable auto negotiation when set PHY to be link down, will cause PHY >

[dpdk-dev] [PATCH v3] igb_uio: fail and log if kernel lock down is enabled

2018-05-16 Thread Ferruh Yigit
When EFI secure boot is enabled, it is possible to lock down kernel and prevent accessing device BARs and this makes igb_uio unusable. Lock down patches are not part of the vanilla kernel but they are applied and used by some distros already [1]. It is not possible to fix this issue, but intentio

Re: [dpdk-dev] [PATCH] net/virtio-user: strip VIRTIO_NET_F_MAC when MAC isn't specified

2018-05-16 Thread Maxime Coquelin
On 05/16/2018 01:08 PM, Maxime Coquelin wrote: On 05/11/2018 12:55 PM, Tiwei Bie wrote: Currently VIRTIO_NET_F_MAC is set unconditionally when server mode is used. It should be stripped when MAC isn't specified. Fixes: bd8f50a45d0f ("net/virtio-user: support server mode") Signed-off-by: Ti

Re: [dpdk-dev] [PATCH] net/vhost: do not zero ol_flags in eth_vhost_rx()

2018-05-16 Thread Maxime Coquelin
On 05/16/2018 12:55 PM, Maxime Coquelin wrote: On 05/10/2018 09:04 AM, Tiwei Bie wrote: The ol_flags of mbufs returned by rte_vhost_dequeue_burst() contain necessary offload information. It can't be zeroed. Fixes: f63d356ee993 ("net/vhost: insert/strip VLAN header in software") Cc: Jan Blun

Re: [dpdk-dev] [PATCH] maintainers: fix responsibility of flow API bits

2018-05-16 Thread Adrien Mazarguil
On Wed, May 16, 2018 at 09:18:01AM +, Iremonger, Bernard wrote: > Hi Adrien, > > > -Original Message- > > From: Adrien Mazarguil [mailto:adrien.mazarg...@6wind.com] > > Sent: Tuesday, May 15, 2018 5:23 PM > > To: dev@dpdk.org > > Cc: sta...@dpdk.org; Iremonger, Bernard > > Subject: [P

[dpdk-dev] [PATCH] doc: advise to specify LTS branch when backporting patches

2018-05-16 Thread luca . boccassi
From: Luca Boccassi We have many stable branches being maintaned at the same time, and sometimes it's not clear which branch a patch is being backported for. Note in the guidelines that it should be specified via the cover letter, annotation or using --subject-prefix. Also note to send only to st

Re: [dpdk-dev] [PATCH V21 4/4] app/testpmd: show example to handle hot unplug

2018-05-16 Thread Iremonger, Bernard
Hi Jeff > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Jeff Guo > Sent: Thursday, May 3, 2018 9:57 AM > To: step...@networkplumber.org; Richardson, Bruce > ; Yigit, Ferruh ; > Ananyev, Konstantin ; > gaetan.ri...@6wind.com; Wu, Jingjing ; > tho...@monjalon.net;

[dpdk-dev] [PATCH v2] crypto/scheduler: fix multicore rings re-use

2018-05-16 Thread Kirill Rybalchenko
When scheduler mode changed from multicore to roundrobin and back to multicore, scheduler tries to create memory rings with the same name and fails. The fix allows to lookup and re-use previously allocated memory rings. Fixes: 4c07e0552f0a ("crypto/scheduler: add multicore scheduling mode") Cc: st

[dpdk-dev] [PATCH] net/sfc: fix errno value if flow API RSS action parse fails

2018-05-16 Thread Andrew Rybchenko
From: Roman Zhukov The value of rte_errno must be positive in case of an error. Fixes: d77d07391d4d ("net/sfc: support flow API RSS action") Cc: sta...@dpdk.org Signed-off-by: Roman Zhukov Signed-off-by: Andrew Rybchenko --- drivers/net/sfc/sfc_flow.c | 2 +- 1 file changed, 1 insertion(+),

[dpdk-dev] [PATCH] compressdev: clarify buffer size limitation

2018-05-16 Thread Fiona Trahe
Signed-off-by: Fiona Trahe --- lib/librte_compressdev/rte_comp.h | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/lib/librte_compressdev/rte_comp.h b/lib/librte_compressdev/rte_comp.h index 4c802195f..9826086b1 100644 --- a/lib/librte_compressdev/rte_comp.h +++ b/l

[dpdk-dev] [PATCH v2] log: fix pattern matching

2018-05-16 Thread Ferruh Yigit
loglevel set wrong when ":" is used as separator, like --log-type="user:debug" This is because fnmatch returns zero on success. Fixed fnmatch return value check. Fixes: 7f0bb634a140 ("log: add ability to match log type with globbing") Cc: step...@networkplumber.org Signed-off-by: Ferruh Yigit -

Re: [dpdk-dev] [PATCH v5 3/3] app/testpmd: add parse options from JSON cfg file

2018-05-16 Thread Iremonger, Bernard
Hi Kuba, This patch does not apply to the dpdk_18_05_rc4 master branch and needs to be rebased. Regards, Bernard.

[dpdk-dev] [PATCH] log: fix pattern matching

2018-05-16 Thread Ferruh Yigit
loglevel set wrong when ":" is used as seperator, like --log-type="user:debug" This is because fnmatch returns zero on success. Fixed fnmatch return value check. Fixes: 7f0bb634a140 ("log: add ability to match log type with globbing") Cc: step...@networkplumber.org Signed-off-by: Ferruh Yigit -

Re: [dpdk-dev] [PATCH v5 2/3] app/testpmd: add parse options from cfg file

2018-05-16 Thread Iremonger, Bernard
Hi Kuba, This patch does not apply to the dpdk_18_05.rc4 master and needs to be rebased. It also contains a lot of checkpatch warnings which should be addressed. Regards, Bernard.

Re: [dpdk-dev] [PATCH v8 4/5] net/netvsc: add documentation

2018-05-16 Thread Kovacevic, Marko
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Stephen Hemminger > Sent: Tuesday, May 15, 2018 10:20 PM > To: dev@dpdk.org > Cc: Stephen Hemminger > Subject: [dpdk-dev] [PATCH v8 4/5] net/netvsc: add documentation > > From: Stephen Hemminger > > Matching d

[dpdk-dev] [PATCH] app/testbbdev: fix unchecked return value

2018-05-16 Thread Kamil Chalupnik
Fixing CHECKED_RETURN issue by checking values returned by rte_bbdev_dec_op_alloc_bulk and rte_bbdev_enc_op_alloc_bulk functions. Fixes: f714a18885a6 ("app/testbbdev: add test application for bbdev") Coverity issue: 279447, 279456 Signed-off-by: Kamil Chalupnik --- app/test-bbdev/test_bbdev_per

Re: [dpdk-dev] [PATCH v2] crypto/scheduler: fix possible duplicated ring names

2018-05-16 Thread De Lara Guarch, Pablo
> -Original Message- > From: Zhang, Roy Fan > Sent: Wednesday, May 16, 2018 2:11 PM > To: dev@dpdk.org > Cc: Zhang, Roy Fan ; Rybalchenko, Kirill > ; sta...@dpdk.org; De Lara Guarch, Pablo > > Subject: [PATCH v2] crypto/scheduler: fix possible duplicated ring names > > This patch fixes

[dpdk-dev] [PATCH] drivers/raw/ifpga_rawdev: fix coverity issue

2018-05-16 Thread Rosen Xu
Fix coverity issue: 279449 Signed-off-by: Rosen Xu Fixes: ef1e8ede3da5 ("raw/ifpga: add Intel FPGA bus rawdev driver") Coverity issue: 279449 Cc: sta...@dpdk.org --- drivers/raw/ifpga_rawdev/ifpga_rawdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/raw/ifpga_raw

[dpdk-dev] [PATCH] drivers/bus/ifpga/: fix Coverity issue

2018-05-16 Thread Rosen Xu
Fix Coverity issue: 279455, 279459 and 279454 Signed-off-by: Rosen Xu Fixes: 05fa3d4a6539 ("bus/ifpga: add Intel FPGA bus library") Coverity issue: 279455, 279459 and 279454 Cc: sta...@dpdk.org --- drivers/bus/ifpga/ifpga_bus.c | 15 +-- 1 file changed, 9 insertions(+), 6 deletions(

Re: [dpdk-dev] [PATCH] doc: correct spell issues in i40e.rst

2018-05-16 Thread Kovacevic, Marko
> This patch corrects some spelling issues in i40e.rst and clarifies which > controllers and connections are part of the 700 Series. > > Signed-off-by: Qiming Yang > --- > doc/guides/nics/i40e.rst | 69 + > --- > 1 file changed, 36 insertions(+), 33 de

Re: [dpdk-dev] How to dump DPDK log?

2018-05-16 Thread Ferruh Yigit
On 5/16/2018 9:30 AM, Sam wrote: > I want DPDK VHOST module DEBUG level log > > 2018-05-16 16:27 GMT+08:00 Sam : > >> Hi all, >> >> I'm debugging OVS2.9.0 and DPDK18.02, I found I could not dump DPDK log >> like vhost module. >> >> How can I dump DPDK log into files? Thank you~ >> (Unfortunately

[dpdk-dev] [PATCH] net/sfc: improve unsupported flow pattern message

2018-05-16 Thread Andrew Rybchenko
From: Ivan Malov Such a message could be generated by two places in the code, and there is a difference in the text albeit there is no difference in the meaning. These two messages must be the same so that automated error log comparison may be carried out without confusion. Fixes: a9825ccf5bb8 (

[dpdk-dev] [PATCH v2] crypto/scheduler: fix possible duplicated ring names

2018-05-16 Thread Fan Zhang
This patch fixes the possible duplicated ring names in multi-core scheduler. Originally two or more multi-core schedulers may have same worker ring names thus will cause initialization error. Fixes: 4c07e0552f0a ("crypto/scheduler: add multicore scheduling mode") Signed-off-by: Fan Zhang --- v2:

Re: [dpdk-dev] [PATCH] crypto/scheduler: fix multicore rings re-use

2018-05-16 Thread Pattan, Reshma
Hi Kirill Not able to apply this patch cleanly either on dpdk.org or crypto next tree. Can you check if you have to rebase it? Thanks, Reshma

Re: [dpdk-dev] [PATCH v2 2/2] app/crypto-perf: fix memcpy source

2018-05-16 Thread De Lara Guarch, Pablo
> -Original Message- > From: Jerin Jacob [mailto:jerin.ja...@caviumnetworks.com] > Sent: Wednesday, May 16, 2018 1:28 PM > To: dev@dpdk.org > Cc: De Lara Guarch, Pablo ; > tho...@monjalon.net; Jerin Jacob ; > Doherty, Declan ; a...@warmcat.com; > sta...@dpdk.org > Subject: [dpdk-dev] [PAT

Re: [dpdk-dev] [PATCH v2 2/2] app/crypto-perf: fix memcpy source

2018-05-16 Thread Andy Green
On 05/16/2018 08:28 PM, Jerin Jacob wrote: Since arm64 was using plain memcpy for rte_memcpy, gcc 8.1, could detect size was more than source address range. In this case, the source was wrong. /export/dpdk.org/test/test/test_cryptodev.c: In function 'test_multi_session_random_usage': /export/d

Re: [dpdk-dev] [PATCH 1/2] app/testpmd: add custom topology command

2018-05-16 Thread Wisam Monther
PSB. BRs, Wisam Jaddo -Original Message- From: Kevin Traynor [mailto:ktray...@redhat.com] Sent: Wednesday, May 16, 2018 3:41 PM To: Wisam Monther; jingjing...@intel.com; wenzhuo...@intel.com; Thomas Monjalon Cc: Raslan Darawsheh; dev@dpdk.org; Shahaf Shuler Subject: Re: [dpdk-dev] [PATCH

[dpdk-dev] cppcheck on dpdk

2018-05-16 Thread Ferruh Yigit
Today after listening Colin's Static Analysis talk, I run cppcheck on v18.05-rc4 code and it revealed some issues, sharing here for anyone to interested in fixing them. At least I encourage to check maintainers to check their own pieces. It is really easy to run cppcheck, in dpdk source folder: c

Re: [dpdk-dev] [PATCH 1/2] app/testpmd: add custom topology command

2018-05-16 Thread Kevin Traynor
On 05/15/2018 03:05 PM, Wisam Monther wrote: > Hey Kevin, > > What if I have 10 ports and want all 9 ports to forward packets to port > 0, this cannot done in paired. > But with this topo the user can overwrite the topo. > E.g: > - Set custom-topo 1 0 > Will make those paired and those two as acti

[dpdk-dev] [PATCH] net/sfc: fix minimum number of Rx descriptors in ESSB mode

2018-05-16 Thread Andrew Rybchenko
Number of descriptors in equal stride super-buffer Rx mode defines number of packet buffers to be used. Each HW Rx descriptor has many packet buffers and the number depends on total size of mbuf and CONFIG_RTE_DRIVER_MEMPOOL_BUCKET_SIZE_KB value. Typically it makes a bit less than 32 buffers per de

[dpdk-dev] [PATCH v2 2/2] app/crypto-perf: fix memcpy source

2018-05-16 Thread Jerin Jacob
Since arm64 was using plain memcpy for rte_memcpy, gcc 8.1, could detect size was more than source address range. In this case, the source was wrong. /export/dpdk.org/test/test/test_cryptodev.c: In function 'test_multi_session_random_usage': /export/dpdk.org/build/include/rte_memcpy_64.h:364:29: e

[dpdk-dev] [PATCH v2 1/2] app/crypto-perf: use strcpy for allocated string

2018-05-16 Thread Jerin Jacob
inlined from ‘cperf_test_vector_get_from_file’ at ../app/test-crypto-perf/cperf_test_vector_parsing.c:578:11: ../app/test-crypto-perf/cperf_test_vector_parsing.c:510:3: error: ‘strncpy’ output truncated before terminating nul copying as many bytes from a string as its length [-Werror=stringop-trunc

Re: [dpdk-dev] [PATCH 2/2] app/crypto-perf: fix memcpy source range

2018-05-16 Thread Jerin Jacob
> > --- > > test/test/test_cryptodev.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/test/test/test_cryptodev.c b/test/test/test_cryptodev.c index > > 680082f2b..169ecdef3 100644 > > --- a/test/test/test_cryptodev.c > > +++ b/test/test/test_cryptodev.c > > @@ -661

Re: [dpdk-dev] [PATCH] igb_uio: fail and log if kernel lock down is enabled

2018-05-16 Thread Neil Horman
On Tue, May 15, 2018 at 05:56:12PM +0100, Ferruh Yigit wrote: > When EFI secure boot is enabled, it is possible to lock down kernel and > prevent accessing device BARs and this makes igb_uio unusable. > > Lock down patches are not part of the vanilla kernel but they are > applied and used by some

Re: [dpdk-dev] [PATCH 2/2] app/crypto-perf: fix memcpy source range

2018-05-16 Thread De Lara Guarch, Pablo
> -Original Message- > From: Jerin Jacob [mailto:jerin.ja...@caviumnetworks.com] > Sent: Wednesday, May 16, 2018 7:40 AM > To: dev@dpdk.org > Cc: tho...@monjalon.net; Jerin Jacob ; De > Lara Guarch, Pablo ; Doherty, Declan > ; a...@warmcat.com; sta...@dpdk.org > Subject: [dpdk-dev] [PATCH

[dpdk-dev] [PATCH] mbuf: properly cast shared data

2018-05-16 Thread David Marchand
Including rte_mbuf.h in C++ triggers the following warning as C++ does not allow implicit casting of a void *. In file included from test.cpp:1:0: x86_64-native-linuxapp-gcc/include/rte_mbuf.h: In function ‘rte_mbuf_ext_shared_info* rte_pktmbuf_ext_shinfo_init_helper(void*, uint16_t*, rte_mbuf_ext

Re: [dpdk-dev] [PATCH v2] app/testpmd: fix burst stat reporting

2018-05-16 Thread Iremonger, Bernard
> -Original Message- > From: Daniel Shelepov [mailto:das...@microsoft.com] > Sent: Monday, May 14, 2018 10:12 PM > To: Lu, Wenzhuo ; Wu, Jingjing > ; Iremonger, Bernard > > Cc: dev@dpdk.org; Daniel Shelepov > Subject: [PATCH v2] app/testpmd: fix burst stat reporting > > When RTE_TEST_PMD

Re: [dpdk-dev] [PATCH] net/virtio-user: strip VIRTIO_NET_F_MAC when MAC isn't specified

2018-05-16 Thread Maxime Coquelin
On 05/11/2018 12:55 PM, Tiwei Bie wrote: Currently VIRTIO_NET_F_MAC is set unconditionally when server mode is used. It should be stripped when MAC isn't specified. Fixes: bd8f50a45d0f ("net/virtio-user: support server mode") Signed-off-by: Tiwei Bie --- drivers/net/virtio/virtio_user/virt

[dpdk-dev] [PATCH 2/2] librte_ip_frag: add mbuf counter

2018-05-16 Thread Alex Kiselev
add new function rte_frag_table_mbuf_count() that returns number of mbufs holded in the fragmentation table. There might be situations (kind of attack when a lot of fragmented packets are sent to a dpdk application in order to flood the fragmentation table) when no additional mbufs must be added t

[dpdk-dev] [PATCH 1/2] librte_ip_frag: add function to delete expired entries

2018-05-16 Thread Alex Kiselev
add new function rte_frag_table_del_expired_entries() that scans the list of recently used packets and delete the expired ones. A fragmented packets is supposed to live no longer than max_cycles, but the lib deletes an expired packet only occasionally when it scans a bucket to find an empty slot w

Re: [dpdk-dev] [PATCH] net/vhost: do not zero ol_flags in eth_vhost_rx()

2018-05-16 Thread Maxime Coquelin
On 05/10/2018 09:04 AM, Tiwei Bie wrote: The ol_flags of mbufs returned by rte_vhost_dequeue_burst() contain necessary offload information. It can't be zeroed. Fixes: f63d356ee993 ("net/vhost: insert/strip VLAN header in software") Cc: Jan Blunck Cc:sta...@dpdk.org Reported-by: Lei Yao Signed

Re: [dpdk-dev] [PATCH] vhost/crypto: fix descriptor move

2018-05-16 Thread Maxime Coquelin
On 05/09/2018 04:08 PM, Fan Zhang wrote: This patch fixes the redundant descriptor move in the copy mode of vhost crypto. Originally the redundant descriptor move will cause the message parsing error. Signed-off-by: Fan Zhang --- lib/librte_vhost/vhost_crypto.c | 5 - 1 file changed, 5

Re: [dpdk-dev] [PATCH] vhost/crypto: handle virtually non-contiguous buffers

2018-05-16 Thread Maxime Coquelin
On 05/10/2018 05:41 PM, Fan Zhang wrote: This patch enables the handling of buffers non-contiguous in virtual address space in the vhost_crypto. Instead of using rte_vhost_va_from_guest_pa(), the host virtual address is converted by vhost_iova_to_vva() for wider use cases. For copy mode, the c

Re: [dpdk-dev] [PATCH v2] igb_uio: fail and log if kernel lock down is enabled

2018-05-16 Thread Luca Boccassi
On Wed, 2018-05-16 at 11:18 +0100, Ferruh Yigit wrote: > When EFI secure boot is enabled, it is possible to lock down kernel > and > prevent accessing device BARs and this makes igb_uio unusable. > > Lock down patches are not part of the vanilla kernel but they are > applied and used by some distr

[dpdk-dev] [PATCH v2] igb_uio: fail and log if kernel lock down is enabled

2018-05-16 Thread Ferruh Yigit
When EFI secure boot is enabled, it is possible to lock down kernel and prevent accessing device BARs and this makes igb_uio unusable. Lock down patches are not part of the vanilla kernel but they are applied and used by some distros already [1]. It is not possible to fix this issue, but intentio

Re: [dpdk-dev] [PATCH] igb_uio: fail and log if kernel lock down is enabled

2018-05-16 Thread Luca Boccassi
On Wed, 2018-05-16 at 10:45 +0100, Ferruh Yigit wrote: > On 5/15/2018 6:47 PM, Luca Boccassi wrote: > > On Tue, 2018-05-15 at 17:56 +0100, Ferruh Yigit wrote: > > > When EFI secure boot is enabled, it is possible to lock down > > > kernel > > > and > > > prevent accessing device BARs and this makes

Re: [dpdk-dev] [PATCH] igb_uio: fail and log if kernel lock down is enabled

2018-05-16 Thread Ferruh Yigit
On 5/15/2018 7:52 PM, Stephen Hemminger wrote: > On Tue, 15 May 2018 17:56:12 +0100 > Ferruh Yigit wrote: > >> When EFI secure boot is enabled, it is possible to lock down kernel and >> prevent accessing device BARs and this makes igb_uio unusable. > > This distro specific (and not upstream) stu

Re: [dpdk-dev] [PATCH 1/2] app/crypto-perf: use strcpy for allocated string

2018-05-16 Thread De Lara Guarch, Pablo
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Jerin Jacob > Sent: Wednesday, May 16, 2018 7:40 AM > To: dev@dpdk.org > Cc: tho...@monjalon.net; Jerin Jacob ; > Doherty, Declan ; a...@warmcat.com; > sta...@dpdk.org > Subject: [dpdk-dev] [PATCH 1/2] app/crypto-

Re: [dpdk-dev] [PATCH] vhost/crypto: handle virtually non-contiguous buffers

2018-05-16 Thread Maxime Coquelin
On 05/10/2018 05:41 PM, Fan Zhang wrote: This patch enables the handling of buffers non-contiguous in virtual address space in the vhost_crypto. Instead of using rte_vhost_va_from_guest_pa(), the host virtual address is converted by vhost_iova_to_vva() for wider use cases. For copy mode, the c

Re: [dpdk-dev] [PATCH] igb_uio: fail and log if kernel lock down is enabled

2018-05-16 Thread Ferruh Yigit
On 5/15/2018 6:47 PM, Luca Boccassi wrote: > On Tue, 2018-05-15 at 17:56 +0100, Ferruh Yigit wrote: >> When EFI secure boot is enabled, it is possible to lock down kernel >> and >> prevent accessing device BARs and this makes igb_uio unusable. >> >> Lock down patches are not part of the vanilla ker

Re: [dpdk-dev] [PATCH] crypto/scheduler: fix possible duplicated ring names

2018-05-16 Thread De Lara Guarch, Pablo
Hi Fan, > -Original Message- > From: Zhang, Roy Fan > Sent: Monday, May 14, 2018 11:09 AM > To: dev@dpdk.org > Cc: Zhang, Roy Fan ; Rybalchenko, Kirill > ; sta...@dpdk.org; De Lara Guarch, Pablo > > Subject: [PATCH] crypto/scheduler: fix possible duplicated ring names > > Fixes: 4c07e055

Re: [dpdk-dev] [PATCH] maintainers: fix responsibility of flow API bits

2018-05-16 Thread Iremonger, Bernard
Hi Adrien, > -Original Message- > From: Adrien Mazarguil [mailto:adrien.mazarg...@6wind.com] > Sent: Tuesday, May 15, 2018 5:23 PM > To: dev@dpdk.org > Cc: sta...@dpdk.org; Iremonger, Bernard > Subject: [PATCH] maintainers: fix responsibility of flow API bits > > The following commits la

[dpdk-dev] [PATCH] raw/ifpga/base: fix a return error value in ifpga_fme_pr

2018-05-16 Thread Xu, Rosen
From: "Zhang, Tianfei" fix a return error value by DPDK Coverity static code analysis Fixes: 56bb54ea1bdf ("raw/ifpga/base: add Intel FPGA OPAE share code") Coverity issue: 279448 Cc: sta...@dpdk.org Signed-off-by: Zhang, Tianfei --- drivers/raw/ifpga_rawdev/base/ifpga_fme_pr.c | 2 +- 1 file

Re: [dpdk-dev] [dpdk-stable] [PATCH] crypto/scheduler: fix multicore rings re-use

2018-05-16 Thread De Lara Guarch, Pablo
> -Original Message- > From: stable [mailto:stable-boun...@dpdk.org] On Behalf Of Kirill Rybalchenko > Sent: Monday, May 14, 2018 7:53 AM > To: dev@dpdk.org > Cc: sta...@dpdk.org; Rybalchenko, Kirill ; > Zhang, > Roy Fan > Subject: [dpdk-stable] [PATCH] crypto/scheduler: fix multicore r

  1   2   >