Re: [dpdk-dev] [PATCH] net/mlx5: fix memory region cache init

2018-05-25 Thread Yongseok Koh
> On May 25, 2018, at 7:32 PM, Xueming(Steven) Li wrote: > > > >> -Original Message- >> From: Yongseok Koh >> Sent: Friday, May 25, 2018 11:41 PM >> To: Xueming(Steven) Li >> Cc: Shahaf Shuler ; dev@dpdk.org; Nélio Laranjeiro >> ; >> Adrien Mazarguil >> Subject: Re: [PATCH] net/mlx5

Re: [dpdk-dev] [PATCH] net/mlx5: fix memory region cache init

2018-05-25 Thread Xueming(Steven) Li
> -Original Message- > From: Yongseok Koh > Sent: Friday, May 25, 2018 11:41 PM > To: Xueming(Steven) Li > Cc: Shahaf Shuler ; dev@dpdk.org; Nélio Laranjeiro > ; > Adrien Mazarguil > Subject: Re: [PATCH] net/mlx5: fix memory region cache init > > > > On May 25, 2018, at 6:18 AM, Xuem

[dpdk-dev] [PATCH] ethdev: Add rte_tm_get_number_of_leaf_nodes to .map file

2018-05-25 Thread Ben Shelton
The rte_tm_get_number_of_leaf_nodes() API function was added in DPDK 17.08. However, it was added to the .map file with the wrong function name (rte_tm_get_leaf_nodes), which was subsequently removed in commit 3e8ea3d ('lib: remove unused map symbols'). Add it back under the 17.08 release with th

[dpdk-dev] [PATCH] ethdev: Add rte_tm_get_number_of_leaf_nodes to .map file

2018-05-25 Thread Ben Shelton
The rte_tm_get_number_of_leaf_nodes() API function was added in DPDK 17.08. However, it was added to the .map file with the wrong function name (rte_tm_get_leaf_nodes), which was subsequently removed in commit 3e8ea3d ('lib: remove unused map symbols'). Add it back under the 17.08 release with th

[dpdk-dev] [PATCH] doc: add documentation for IPC

2018-05-25 Thread Anatoly Burakov
Describe all the capabilities of DPDK IPC, and provide some insight into how to best make use of it. Signed-off-by: Anatoly Burakov --- doc/guides/prog_guide/multi_proc_support.rst | 137 +++ 1 file changed, 137 insertions(+) diff --git a/doc/guides/prog_guide/multi_proc

Re: [dpdk-dev] [PATCH] net/mlx5: fix error message in probe function

2018-05-25 Thread Yongseok Koh
> On May 25, 2018, at 9:16 AM, Adrien Mazarguil > wrote: > > Error values passed to strerror() must be positive. > > Fixes: 012ad9944dfc ("net/mlx5: fix probe return value polarity") > Cc: Shahaf Shuler > > Signed-off-by: Adrien Mazarguil > --- Acked-by: Yongseok Koh Thanks

[dpdk-dev] [PATCH] net/bonding: add add/remove mac addrs

2018-05-25 Thread Alex Kiselev
add functions to add/remove MAC addresses Signed-off-by: Alex Kiselev --- drivers/net/bonding/rte_eth_bond_pmd.c | 76 +++--- 1 file changed, 71 insertions(+), 5 deletions(-) diff --git a/drivers/net/bonding/rte_eth_bond_pmd.c b/drivers/net/bonding/rte_eth_bond_pmd.

[dpdk-dev] [PATCH 7/7] net/mlx5: add parameter for port representors

2018-05-25 Thread Adrien Mazarguil
Prior to this patch, all port representors detected on a given device were probed and Ethernet devices instantiated for each of them. This patch adds support for the standard "representor" parameter, which implies that port representors are not probed by default anymore, except for the list provid

[dpdk-dev] [PATCH 4/7] net/mlx5: re-indent generic probing function

2018-05-25 Thread Adrien Mazarguil
Since commit "net/mlx5: split PCI from generic probing code" extracted the inner loop to a separate function, mlx5_dev_spawn_one() is left with an unnecessary indent level. This patch eliminates a block, moves its local variables to function scope, and re-indents its contents. No functional impac

[dpdk-dev] [PATCH 5/7] net/mlx5: add port representor awareness

2018-05-25 Thread Adrien Mazarguil
The current PCI probing method is not aware of Verbs port representors, which appear as standard Verbs devices bound to the same PCI address and cannot be distinguished. Problem is that more often than not, the wrong Verbs device is used, resulting in unexpected traffic. This patch adds necessary

[dpdk-dev] [PATCH 6/7] net/mlx5: probe all port representors

2018-05-25 Thread Adrien Mazarguil
Probe existing port representors in addition to their master device and associate them automatically. To avoid name collision between Ethernet devices, their names use the same convention as ixgbe and i40e PMDs, that is, instead of only a PCI address in DBDF notation: - "net_{DBDF}_0" for master/

[dpdk-dev] [PATCH 3/7] net/mlx5: split PCI from generic probing code

2018-05-25 Thread Adrien Mazarguil
All the generic probing code needs is an IB device. While this device is currently supplied by a PCI lookup, other methods will be added soon. This patch divides the original function, which has become huge over time, as follows: 1. PCI-specific (mlx5_pci_probe()). 2. All ports of a Verbs device

[dpdk-dev] [PATCH 2/7] net/mlx5: remove redundant objects in probe code

2018-05-25 Thread Adrien Mazarguil
This patch gets rid of redundant calls to open the device and query its attributes in order to simplify the code. Signed-off-by: Adrien Mazarguil --- drivers/net/mlx5/mlx5.c | 60 +--- 1 file changed, 28 insertions(+), 32 deletions(-) diff --git a/drivers

[dpdk-dev] [PATCH 1/7] net/mlx5: rename confusing object in probe code

2018-05-25 Thread Adrien Mazarguil
There are several attribute objects in this function: - IB device attributes (struct ibv_device_attr_ex device_attr). - Direct Verbs attributes (struct mlx5dv_context attrs_out). - Port attributes (struct ibv_port_attr). - IB device attributes again (struct ibv_device_attr_ex device_attr_ex). "at

[dpdk-dev] [PATCH 0/7] net/mlx5: add port representor support

2018-05-25 Thread Adrien Mazarguil
This series adds support for port (VF) representors to the mlx5 PMD, which can be instantiated using the standard "representor" device parameter. Note the PMD only probes existing representors which exist as Verbs devices; their creation is part of the host system configuration. Adrien Mazarguil

Re: [dpdk-dev] [PATCH] doc: update release notes for vhost interrupt mode

2018-05-25 Thread Ferruh Yigit
On 5/25/2018 4:23 PM, Kovacevic, Marko wrote: >> Signed-off-by: Zhihong Wang > Acked-by: Marko Kovacevic Applied to dpdk-next-net/master, thanks.

Re: [dpdk-dev] [PATCH] doc: update release notes for vdpa

2018-05-25 Thread Ferruh Yigit
On 5/25/2018 4:22 PM, Kovacevic, Marko wrote: >> Signed-off-by: Zhihong Wang > Acked-by: Marko Kovacevic Applied to dpdk-next-net/master, thanks.

Re: [dpdk-dev] [PATCH] doc: add doc for vdpa

2018-05-25 Thread Ferruh Yigit
On 5/25/2018 4:36 PM, Kovacevic, Marko wrote: >> >> Signed-off-by: Zhihong Wang > Acked-by: Marko Kovacevic Applied to dpdk-next-net/master, thanks.

[dpdk-dev] [PATCH] net/mlx5: fix error message in probe function

2018-05-25 Thread Adrien Mazarguil
Error values passed to strerror() must be positive. Fixes: 012ad9944dfc ("net/mlx5: fix probe return value polarity") Cc: Shahaf Shuler Signed-off-by: Adrien Mazarguil --- drivers/net/mlx5/mlx5.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/mlx5/mlx5.c b/

Re: [dpdk-dev] [PATCH] net/mlx5: fix memory region cache init

2018-05-25 Thread Yongseok Koh
> On May 25, 2018, at 6:18 AM, Xueming(Steven) Li wrote: > > > >> -Original Message- >> From: Yongseok Koh >> Sent: Friday, May 25, 2018 6:20 PM >> To: Xueming(Steven) Li >> Cc: Shahaf Shuler ; dev@dpdk.org >> Subject: Re: [PATCH] net/mlx5: fix memory region cache init >> >>> On May

Re: [dpdk-dev] [PATCH] doc: move and update experimental API description

2018-05-25 Thread Ferruh Yigit
On 5/25/2018 1:22 PM, Luca Boccassi wrote: > On Fri, 2018-05-25 at 17:37 +0530, Shreyansh Jain wrote: >> Experimental API text has been moved into a sub-section of ABI >> Policy. >> A paragraph has been added to explain the process for removal of an >> experimental tag. >> >> Signed-off-by: Shreyan

Re: [dpdk-dev] [PATCH] doc: add doc for vdpa

2018-05-25 Thread Kovacevic, Marko
> > Signed-off-by: Zhihong Wang > --- > doc/guides/prog_guide/vhost_lib.rst | 59 > + > 1 file changed, 59 insertions(+) > Acked-by: Marko Kovacevic

Re: [dpdk-dev] [PATCH] doc: deprecation notice for EAL runtime path changes

2018-05-25 Thread Van Haaren, Harry
> From: Burakov, Anatoly > Sent: Friday, May 25, 2018 2:39 PM > To: dev@dpdk.org > Cc: Neil Horman ; Mcnamara, John > ; Kovacevic, Marko ; > tho...@monjalon.net; Richardson, Bruce ; Van > Haaren, Harry > Subject: [PATCH] doc: deprecation notice for EAL runtime path changes > > Most of this work w

Re: [dpdk-dev] [PATCH v1] doc: add SPDX Licence to doc files

2018-05-25 Thread Kovacevic, Marko
> > > It has been recommended to add SPDX tags to release notes, with a global > copyright on behalf of all contributors, or community. > > We need a v2 of this patch, thanks. > > Hi Thomas, What exactly is the global copyright ? Marko K

Re: [dpdk-dev] [PATCH] doc: update release notes for vhost interrupt mode

2018-05-25 Thread Kovacevic, Marko
> Signed-off-by: Zhihong Wang > --- > doc/guides/rel_notes/release_18_05.rst | 6 ++ > 1 file changed, 6 insertions(+) > Acked-by: Marko Kovacevic

Re: [dpdk-dev] [PATCH] doc: update release notes for vdpa

2018-05-25 Thread Kovacevic, Marko
> Signed-off-by: Zhihong Wang > --- > doc/guides/rel_notes/release_18_05.rst | 6 ++ > 1 file changed, 6 insertions(+) > Acked-by: Marko Kovacevic

Re: [dpdk-dev] [PATCH v2] devtools: add test script for meson builds

2018-05-25 Thread Bruce Richardson
On Fri, May 25, 2018 at 04:51:58PM +0200, Thomas Monjalon wrote: > From: Bruce Richardson > > To simplify testing with the meson and ninja builds, we can add a script > to set up and do multiple builds. Currently this script sets up: > > * clang and gcc builds > * builds using static and shared

Re: [dpdk-dev] [PATCH] ring: relax alignment constraint on ring structure

2018-05-25 Thread Olivier Matz
On Fri, May 25, 2018 at 03:57:07PM +0100, Burakov, Anatoly wrote: > On 25-May-18 1:18 PM, Burakov, Anatoly wrote: > > On 25-May-18 11:59 AM, Burakov, Anatoly wrote: > > > On 03-Apr-18 2:26 PM, Olivier Matz wrote: > > > > The initial objective of > > > > commit d9f0d3a1ffd4 ("ring: remove split cach

Re: [dpdk-dev] [dpdk-stable] [PATCH v1] net/tap: fix keep-alive queue not detached

2018-05-25 Thread Ferruh Yigit
On 5/25/2018 9:29 AM, Thomas Monjalon wrote: > 25/05/2018 01:10, Ophir Munk: >> The TAP keep-alive queue was created in order to keep the TAP device >> in Linux even in case all of its Rx/Tx queues are released (in Linux >> terminology: even in case all of the TAP device file descriptors are >> clo

[dpdk-dev] [RFC] eventdev: event tx adapter APIs

2018-05-25 Thread Nikhil Rao
The patch below introduces the event tx adapter APIs that encapsulate common code for the tx stage of a packet processing pipeline. These APIs allow the application to configure a rte_service function that reads mbuf events from an event queue and sends mbufs on the transmit queue and ethernet port

Re: [dpdk-dev] [PATCH] ring: relax alignment constraint on ring structure

2018-05-25 Thread Burakov, Anatoly
On 25-May-18 1:18 PM, Burakov, Anatoly wrote: On 25-May-18 11:59 AM, Burakov, Anatoly wrote: On 03-Apr-18 2:26 PM, Olivier Matz wrote: The initial objective of commit d9f0d3a1ffd4 ("ring: remove split cacheline build setting") was to add an empty cache line betwee, the producer and consumer dat

Re: [dpdk-dev] [dpdk-stable] [PATCH] doc: remove old deprecation notice

2018-05-25 Thread Thomas Monjalon
25/05/2018 16:47, Rybalchenko, Kirill: > Hi Tomas, > > > You CC:stable because it was implemented in 18.02 > > Sorry, I was misled by check-git-log script warning. > > > > Fixes: 09dd01ad9a68 ("doc: announce behaviour change to i40e RSS") > > > > The Fixes line should not reference the initial

Re: [dpdk-dev] Kernel Module dependency in DPDK 18.05-rc5 and earlier DPDK releases

2018-05-25 Thread Thomas Monjalon
25/05/2018 15:57, Bruce Richardson: > On Fri, May 25, 2018 at 04:20:42PM +0300, Kevin Wilson wrote: > > Thanks, Thomas. > > > > Actually there is an EAL rte_eal_check_module() method which does this > > exactly: > > http://dpdk.org/browse/dpdk/tree/lib/librte_eal/linuxapp/eal/eal.c#n1089 > > It i

[dpdk-dev] [PATCH v2] devtools: add test script for meson builds

2018-05-25 Thread Thomas Monjalon
From: Bruce Richardson To simplify testing with the meson and ninja builds, we can add a script to set up and do multiple builds. Currently this script sets up: * clang and gcc builds * builds using static and shared linkage for binaries (libs are always built as both) * a build using the low

[dpdk-dev] [PATCH] doc: add tested platforms for NXP SoCs

2018-05-25 Thread Shreyansh Jain
Signed-off-by: Shreyansh Jain --- note: pattern of this doc change is different from other NICs as NXP SoC have integrated NICs. Thus, separating CPU from NIC doesn't make much sense. doc/guides/rel_notes/release_18_05.rst | 11 +++ 1 file changed, 11 insertions(+) diff --git a/doc/gu

Re: [dpdk-dev] [dpdk-stable] [PATCH] doc: remove old deprecation notice

2018-05-25 Thread Rybalchenko, Kirill
Hi Tomas, > You CC:stable because it was implemented in 18.02 Sorry, I was misled by check-git-log script warning. > > Fixes: 09dd01ad9a68 ("doc: announce behaviour change to i40e RSS") > > The Fixes line should not reference the initial announce, but the commit > implementing it, because the

[dpdk-dev] [PATCH] doc: update release notes with packet framework library changes

2018-05-25 Thread Jasvinder Singh
Signed-off-by: Jasvinder Singh --- doc/guides/rel_notes/release_18_05.rst | 9 + 1 file changed, 9 insertions(+) diff --git a/doc/guides/rel_notes/release_18_05.rst b/doc/guides/rel_notes/release_18_05.rst index a790882..4abddd7 100644 --- a/doc/guides/rel_notes/release_18_05.rst +++ b/

Re: [dpdk-dev] [PATCH] doc: deprecation notice for EAL runtime path changes

2018-05-25 Thread Bruce Richardson
On Fri, May 25, 2018 at 02:38:43PM +0100, Anatoly Burakov wrote: > Most of this work was already done, but runtime config path is > considered to be part of public API because of high likelihood of > it being used by various tools in the DPDK ecosystem, and thus > requires a deprecation notice. >

Re: [dpdk-dev] Kernel Module dependency in DPDK 18.05-rc5 and earlier DPDK releases

2018-05-25 Thread Bruce Richardson
On Fri, May 25, 2018 at 04:20:42PM +0300, Kevin Wilson wrote: > Thanks, Thomas. > > Actually there is an EAL rte_eal_check_module() method which does this > exactly: > http://dpdk.org/browse/dpdk/tree/lib/librte_eal/linuxapp/eal/eal.c#n1089 > It is declared in eal_private.h. > > Is it reasonable

[dpdk-dev] [PATCH 2/2] doc: update release notes with info about memory changes

2018-05-25 Thread Anatoly Burakov
Signed-off-by: Anatoly Burakov --- doc/guides/rel_notes/release_18_05.rst | 34 ++ 1 file changed, 34 insertions(+) diff --git a/doc/guides/rel_notes/release_18_05.rst b/doc/guides/rel_notes/release_18_05.rst index 40eec3a..84b7434 100644 --- a/doc/guides/rel_not

[dpdk-dev] [PATCH 1/2] doc: update documentation for memory subsystem

2018-05-25 Thread Anatoly Burakov
Document new command-line switches and the principles behind the new memory subsystem. Also, replace outdated malloc heap picture. Signed-off-by: Anatoly Burakov --- doc/guides/linux_gsg/build_sample_apps.rst | 12 +- doc/guides/prog_guide/env_abstraction_layer.rst | 221 +++- doc/guides

[dpdk-dev] [PATCH 2/2] memzone: clarify support for zero-length memzones

2018-05-25 Thread Anatoly Burakov
Currently, memzone allocation with length set to 0 that are also IOVA-contiguous is not supported. Document this limitation. Signed-off-by: Anatoly Burakov --- lib/librte_eal/common/include/rte_memzone.h | 9 + 1 file changed, 9 insertions(+) diff --git a/lib/librte_eal/common/include/r

[dpdk-dev] [PATCH 1/2] mem: document callbacks not being supported in some cases

2018-05-25 Thread Anatoly Burakov
Mem event and validator callbacks may not be supported under all circumstances (such as when running in legacy memory mode, or on FreeBSD), and this case needs to be handled by any code that will use these callbacks. Spell this out more clearly, because it's not immediately obvious that this is an

[dpdk-dev] [PATCH] doc: deprecation notice for EAL runtime path changes

2018-05-25 Thread Anatoly Burakov
Most of this work was already done, but runtime config path is considered to be part of public API because of high likelihood of it being used by various tools in the DPDK ecosystem, and thus requires a deprecation notice. Signed-off-by: Anatoly Burakov --- doc/guides/rel_notes/deprecation.rst |

Re: [dpdk-dev] Kernel Module dependency in DPDK 18.05-rc5 and earlier DPDK releases

2018-05-25 Thread Kevin Wilson
Thanks, Thomas. Actually there is an EAL rte_eal_check_module() method which does this exactly: http://dpdk.org/browse/dpdk/tree/lib/librte_eal/linuxapp/eal/eal.c#n1089 It is declared in eal_private.h. Is it reasonable to send a patch which moves the decalartion to eal.h instead so PMDs can use i

Re: [dpdk-dev] [PATCH] net/mlx5: fix memory region cache init

2018-05-25 Thread Xueming(Steven) Li
> -Original Message- > From: Yongseok Koh > Sent: Friday, May 25, 2018 6:20 PM > To: Xueming(Steven) Li > Cc: Shahaf Shuler ; dev@dpdk.org > Subject: Re: [PATCH] net/mlx5: fix memory region cache init > > > On May 24, 2018, at 11:35 PM, Xueming Li wrote: > > > > This patch moved MR cac

Re: [dpdk-dev] [PATCH] doc: move and update experimental API description

2018-05-25 Thread Luca Boccassi
On Fri, 2018-05-25 at 17:37 +0530, Shreyansh Jain wrote: > Experimental API text has been moved into a sub-section of ABI > Policy. > A paragraph has been added to explain the process for removal of an > experimental tag. > > Signed-off-by: Shreyansh Jain > > --- > note: >  The movement of text

Re: [dpdk-dev] [PATCH] ring: relax alignment constraint on ring structure

2018-05-25 Thread Burakov, Anatoly
On 25-May-18 11:59 AM, Burakov, Anatoly wrote: On 03-Apr-18 2:26 PM, Olivier Matz wrote: The initial objective of commit d9f0d3a1ffd4 ("ring: remove split cacheline build setting") was to add an empty cache line betwee, the producer and consumer data (on platform with cache line size = 64B), pre

[dpdk-dev] [PATCH] doc: move and update experimental API description

2018-05-25 Thread Shreyansh Jain
Experimental API text has been moved into a sub-section of ABI Policy. A paragraph has been added to explain the process for removal of an experimental tag. Signed-off-by: Shreyansh Jain --- note: The movement of text into a sub-section is relevant as the previous position was in middle of a c

[dpdk-dev] [PATCH] doc: update release notes for vdpa

2018-05-25 Thread Zhihong Wang
Signed-off-by: Zhihong Wang --- doc/guides/rel_notes/release_18_05.rst | 6 ++ 1 file changed, 6 insertions(+) diff --git a/doc/guides/rel_notes/release_18_05.rst b/doc/guides/rel_notes/release_18_05.rst index 40eec3a49..44180bb44 100644 --- a/doc/guides/rel_notes/release_18_05.rst +++ b/do

[dpdk-dev] [PATCH] doc: update release notes for vhost interrupt mode

2018-05-25 Thread Zhihong Wang
Signed-off-by: Zhihong Wang --- doc/guides/rel_notes/release_18_05.rst | 6 ++ 1 file changed, 6 insertions(+) diff --git a/doc/guides/rel_notes/release_18_05.rst b/doc/guides/rel_notes/release_18_05.rst index 40eec3a49..eda6cf411 100644 --- a/doc/guides/rel_notes/release_18_05.rst +++ b/do

[dpdk-dev] [PATCH] doc: add doc for vdpa

2018-05-25 Thread Zhihong Wang
Signed-off-by: Zhihong Wang --- doc/guides/prog_guide/vhost_lib.rst | 59 + 1 file changed, 59 insertions(+) diff --git a/doc/guides/prog_guide/vhost_lib.rst b/doc/guides/prog_guide/vhost_lib.rst index 92dcdb587..77af4d775 100644 --- a/doc/guides/prog_guide/v

Re: [dpdk-dev] Process for removing __rte_experimental

2018-05-25 Thread Neil Horman
On Fri, May 25, 2018 at 03:05:34PM +0530, Shreyansh Jain wrote: > While reading through [1], I couldn't understand if __rte_experimental and > EXPERIMENTAL tag removed from code and map file, respectively, are > categorized under ABI breakage or not. Thus, whether deprecation for them > should be s

Re: [dpdk-dev] Kernel Module dependency in DPDK 18.05-rc5 and earlier DPDK releases

2018-05-25 Thread Thomas Monjalon
25/05/2018 11:55, Kevin Wilson: > Hi, > > I am facing the following issue in DPDK 18.05-rc5 (I saw it also with earlier > releases of DPDK from the last year). The issue is with defining > dependency on a kernel module in a PMD. > I want to develop a PMD which requiers that before running DPDK app

Re: [dpdk-dev] [PATCH v1] doc: add SPDX Licence to doc files

2018-05-25 Thread Thomas Monjalon
10/04/2018 06:38, Hemant Agrawal: > On 4/9/2018 7:24 PM, Ferruh Yigit wrote: > > On 4/9/2018 2:11 PM, Marko Kovacevic wrote: > >> Added SPDX headers to doc files to have them aligned with > >> the other doc files. > >> > >> Signed-off-by: Marko Kovacevic > > > > <...> > > > >> doc/guides/rel_n

Re: [dpdk-dev] [dpdk-stable] [PATCH] doc: remove old deprecation notice

2018-05-25 Thread Thomas Monjalon
25/05/2018 11:17, Kirill Rybalchenko: > New default configuration without flexible payload > is implemented now. > > Fixes: 09dd01ad9a68 ("doc: announce behaviour change to i40e RSS") The Fixes line should not reference the initial announce, but the commit implementing it, because the deprecation

Re: [dpdk-dev] Process for removing __rte_experimental

2018-05-25 Thread Shreyansh Jain
> -Original Message- > From: Luca Boccassi [mailto:bl...@debian.org] > Sent: Friday, May 25, 2018 3:47 PM > To: Thomas Monjalon ; Shreyansh Jain > > Cc: dev@dpdk.org; Ferruh Yigit ; > nhor...@tuxdriver.com > Subject: Re: Process for removing __rte_experimental > > On Fri, 2018-05-25 at 11

Re: [dpdk-dev] [PATCH] ring: relax alignment constraint on ring structure

2018-05-25 Thread Burakov, Anatoly
On 03-Apr-18 2:26 PM, Olivier Matz wrote: The initial objective of commit d9f0d3a1ffd4 ("ring: remove split cacheline build setting") was to add an empty cache line betwee, the producer and consumer data (on platform with cache line size = 64B), preventing from having them on adjacent cache lines

Re: [dpdk-dev] [PATCH] lib/librte_rawdev: fix compile error when using sanitizer

2018-05-25 Thread Shreyansh Jain
> -Original Message- > From: Liu Hongbo [mailto:cnli...@gmail.com] > Sent: Friday, May 25, 2018 8:50 AM > To: dev@dpdk.org > Cc: Shreyansh Jain ; Liu Hongbo > > Subject: [PATCH] lib/librte_rawdev: fix compile error when using > sanitizer > > Otherwise, make will report the following error

Re: [dpdk-dev] [PATCH] net/mlx5: fix memory region cache init

2018-05-25 Thread Yongseok Koh
> On May 24, 2018, at 11:35 PM, Xueming Li wrote: > > This patch moved MR cache init from device configuration function to > probe function to make sure init only once. > > Fixes: 974f1e7ef146 ("net/mlx5: add new memory region support") > Cc: ys...@mellanox.com > > Signed-off-by: Xueming Li >

Re: [dpdk-dev] Process for removing __rte_experimental

2018-05-25 Thread Luca Boccassi
On Fri, 2018-05-25 at 11:49 +0200, Thomas Monjalon wrote: > 25/05/2018 11:35, Shreyansh Jain: > > While reading through [1], I couldn't understand if > > __rte_experimental  > > and EXPERIMENTAL tag removed from code and map file, respectively, > > are  > > categorized under ABI breakage or not. Th

Re: [dpdk-dev] [PATCH 1/2] net/qede: use SPDX tag for QLogic copyright files

2018-05-25 Thread Thomas Monjalon
23/05/2018 08:27, Rasesh Mody: > Signed-off-by: Rasesh Mody Series applied

Re: [dpdk-dev] [PATCH] examples/l3fwd: update copyright and licenses

2018-05-25 Thread Thomas Monjalon
23/01/2018 17:45, Lee Daly: > This updates the Intel and Linaro Limited license on files in examples > to be the standard BSD-3-Clause license used for the rest of DPDK, > bringing the files in compliance with the DPDK licensing policy. > > Signed-off-by: Lee Daly > --- > examples/l3fwd/l3fwd_co

Re: [dpdk-dev] [PATCH] examples/performance-thread: convert license headers to SPDX

2018-05-25 Thread Thomas Monjalon
18/04/2018 09:57, Pablo de Lara: > Convert dual license headers with Intel and Hasan Alayli > names to SPDX. > > Signed-off-by: Pablo de Lara Waiting for confirmation from Hasan Alayli.

Re: [dpdk-dev] [PATCH 1/2] net/qede: change copyright info to Cavium

2018-05-25 Thread Thomas Monjalon
23/05/2018 22:56, Rasesh Mody: > Signed-off-by: Rasesh Mody Series applied

Re: [dpdk-dev] [PATCH] examples/performance-thread: convert license headers to SPDX

2018-05-25 Thread Thomas Monjalon
20/04/2018 11:53, Pablo de Lara: > Convert dual license headers with Intel and Dmitry Vyukov > names to SPDX. > > Signed-off-by: Pablo de Lara > --- > examples/performance-thread/common/lthread_pool.h | 68 > +- > examples/performance-thread/common/lthread_queue.h | 68 > +

[dpdk-dev] Kernel Module dependency in DPDK 18.05-rc5 and earlier DPDK releases

2018-05-25 Thread Kevin Wilson
Hi, I am facing the following issue in DPDK 18.05-rc5 (I saw it also with earlier releases of DPDK from the last year). The issue is with defining dependency on a kernel module in a PMD. I want to develop a PMD which requiers that before running DPDK app which uses this PMD, a specified kernel mod

Re: [dpdk-dev] Process for removing __rte_experimental

2018-05-25 Thread Thomas Monjalon
25/05/2018 11:35, Shreyansh Jain: > While reading through [1], I couldn't understand if __rte_experimental > and EXPERIMENTAL tag removed from code and map file, respectively, are > categorized under ABI breakage or not. Thus, whether deprecation for > them should be sent or not in a release cyc

Re: [dpdk-dev] [PATCH v3 1/3] examples/l3fwd: convert to SPDX license tags

2018-05-25 Thread Thomas Monjalon
18/05/2018 13:41, Ferruh Yigit: > On 5/18/2018 12:25 PM, gavin...@linaro.org wrote: > > From: Gavin Hu > > > > Signed-off-by: Gavin Hu > > Acked-by: Hemant Agrawal > > For Intel part, > Acked-by: Ferruh Yigit Applied, thanks

Re: [dpdk-dev] [PATCH] net/qede: fix slow path completion timeout

2018-05-25 Thread Ferruh Yigit
On 5/24/2018 7:02 PM, Mody, Rasesh wrote: > Hi Ferruh, > >> From: Ferruh Yigit [mailto:ferruh.yi...@intel.com] >> Sent: Thursday, May 24, 2018 10:22 AM >> >> On 5/23/2018 7:48 PM, Rasesh Mody wrote: >>> From: Shahed Shaikh >>> >>> In 100G mode, we poll firmware slow path completion for every 1 >>

[dpdk-dev] Process for removing __rte_experimental

2018-05-25 Thread Shreyansh Jain
While reading through [1], I couldn't understand if __rte_experimental and EXPERIMENTAL tag removed from code and map file, respectively, are categorized under ABI breakage or not. Thus, whether deprecation for them should be sent or not in a release cycle for removal in subsequent release. L

[dpdk-dev] [PATCH] doc: remove old deprecation notice

2018-05-25 Thread Kirill Rybalchenko
New default configuration without flexible payload is implemented now. Fixes: 09dd01ad9a68 ("doc: announce behaviour change to i40e RSS") Cc: sta...@dpdk.org Signed-off-by: Kirill Rybalchenko --- doc/guides/rel_notes/deprecation.rst | 6 -- 1 file changed, 6 deletions(-) diff --git a/doc/g

Re: [dpdk-dev] [PATCH v1] doc/eth: update document for functional limitation

2018-05-25 Thread Ferruh Yigit
On 5/25/2018 10:08 AM, Zhang, Qi Z wrote: > > >> -Original Message- >> From: Yigit, Ferruh >> Sent: Friday, May 25, 2018 4:35 PM >> To: Zhang, Qi Z ; Thomas Monjalon >> ; Varghese, Vipin >> Cc: dev@dpdk.org; Kovacevic, Marko ; Jain, >> Deepak K >> Subject: Re: [dpdk-dev] [PATCH v1] doc/

Re: [dpdk-dev] [PATCH] doc: address the offload API changes for virtio guide

2018-05-25 Thread Ferruh Yigit
On 5/25/2018 9:54 AM, Tiwei Bie wrote: > On Fri, May 25, 2018 at 04:27:36PM +0800, Tiwei Bie wrote: >> On Fri, May 25, 2018 at 09:20:08AM +0100, Ferruh Yigit wrote: >>> On 5/25/2018 7:17 AM, Tiwei Bie wrote: Signed-off-by: Tiwei Bie >>> >>> <...> >>> @@ -252,7 +252,7 @@ The corresponding

Re: [dpdk-dev] [PATCH v1] doc/eth: update document for functional limitation

2018-05-25 Thread Zhang, Qi Z
> -Original Message- > From: Yigit, Ferruh > Sent: Friday, May 25, 2018 4:35 PM > To: Zhang, Qi Z ; Thomas Monjalon > ; Varghese, Vipin > Cc: dev@dpdk.org; Kovacevic, Marko ; Jain, > Deepak K > Subject: Re: [dpdk-dev] [PATCH v1] doc/eth: update document for functional > limitation > >

Re: [dpdk-dev] [PATCH] doc: address the offload API changes for virtio guide

2018-05-25 Thread Tiwei Bie
On Fri, May 25, 2018 at 04:27:36PM +0800, Tiwei Bie wrote: > On Fri, May 25, 2018 at 09:20:08AM +0100, Ferruh Yigit wrote: > > On 5/25/2018 7:17 AM, Tiwei Bie wrote: > > > Signed-off-by: Tiwei Bie > > > > <...> > > > > > @@ -252,7 +252,7 @@ The corresponding callbacks are: > > > Example of usin

Re: [dpdk-dev] Compiling RSS ebpf

2018-05-25 Thread Sameeh Jubran
Ping. On Sun, May 13, 2018 at 1:16 PM, Sameeh Jubran wrote: > Sorry I have accidentally sent my last email without finishing it. > > I believe it is due misconfiguration of the linux headers and their > inclusion. Anyone else faced these errors? > > > On Sun, May 13, 2018 at 1:10 PM, Sameeh Jubr

Re: [dpdk-dev] Critical fixes for next-net-mlx

2018-05-25 Thread Ferruh Yigit
On 5/24/2018 7:55 PM, Shahaf Shuler wrote: > Thursday, May 24, 2018 7:56 PM, Ferruh Yigit: >> Subject: Re: Critical fixes for next-net-mlx >> >> On 5/24/2018 3:11 PM, Shahaf Shuler wrote: >>> Hi Ferruh, >>> >>> In next-net-mlx and for “next-net” there are several critical fixes: >>> * fecb5cb net/m

Re: [dpdk-dev] [PATCH] use SPDX tag for 6WIND copyright files

2018-05-25 Thread Thomas Monjalon
03/05/2018 09:30, Olivier Matz: > Signed-off-by: Olivier Matz > --- > buildtools/auto-config-h.sh| 32 ++-- > devtools/check-git-log.sh | 30 +- > devtools/check-includes.sh | 32 ++-- > d

Re: [dpdk-dev] [PATCH] doc: address the offload API changes for virtio guide

2018-05-25 Thread Ferruh Yigit
On 5/25/2018 8:16 AM, Maxime Coquelin wrote: > > > On 05/25/2018 08:17 AM, Tiwei Bie wrote: >> Signed-off-by: Tiwei Bie > > Acked-by: Maxime Coquelin Applied to dpdk-next-net/master, thanks.

Re: [dpdk-dev] [dpdk-stable] [PATCH v1] net/tap: fix keep-alive queue not detached

2018-05-25 Thread Ferruh Yigit
On 5/25/2018 9:29 AM, Thomas Monjalon wrote: > 25/05/2018 01:10, Ophir Munk: >> The TAP keep-alive queue was created in order to keep the TAP device >> in Linux even in case all of its Rx/Tx queues are released (in Linux >> terminology: even in case all of the TAP device file descriptors are >> clo

Re: [dpdk-dev] [PATCH] use SPDX license tag in Mellanox copyrighted files

2018-05-25 Thread Thomas Monjalon
02/05/2018 14:37, Shahaf Shuler: > Tuesday, May 1, 2018 11:07 PM, Thomas Monjalon: > > Subject: [PATCH] use SPDX license tag in Mellanox copyrighted files > > > > Some files were left with full license and wrong copyright format. > > They are switched to this format: > > SPDX-License-Identifie

Re: [dpdk-dev] [PATCH v1] doc/eth: update document for functional limitation

2018-05-25 Thread Ferruh Yigit
On 5/25/2018 1:44 AM, Zhang, Qi Z wrote: > > >> -Original Message- >> From: Thomas Monjalon [mailto:tho...@monjalon.net] >> Sent: Friday, May 25, 2018 1:06 AM >> To: Varghese, Vipin >> Cc: dev@dpdk.org; Zhang, Qi Z ; Kovacevic, Marko >> ; Jain, Deepak K ; >> Yigit, Ferruh >> Subject: Re

Re: [dpdk-dev] [PATCH] eal: convert dual-license to SPDX

2018-05-25 Thread Thomas Monjalon
12/04/2018 08:28, Hemant Agrawal: > > On 4/12/2018 4:38 AM, Pablo de Lara wrote: > > Signed-off-by: Pablo de Lara > > --- > > .../common/include/rte_pci_dev_feature_defs.h | 58 > > +- > > .../common/include/rte_pci_dev_features.h | 58 > > +-

Re: [dpdk-dev] [dpdk-stable] [PATCH v1] net/tap: fix keep-alive queue not detached

2018-05-25 Thread Thomas Monjalon
25/05/2018 01:10, Ophir Munk: > The TAP keep-alive queue was created in order to keep the TAP device > in Linux even in case all of its Rx/Tx queues are released (in Linux > terminology: even in case all of the TAP device file descriptors are > closed), however, the keep-alive queue itself is attac

Re: [dpdk-dev] [PATCH] doc: address the offload API changes for virtio guide

2018-05-25 Thread Tiwei Bie
On Fri, May 25, 2018 at 09:20:08AM +0100, Ferruh Yigit wrote: > On 5/25/2018 7:17 AM, Tiwei Bie wrote: > > Signed-off-by: Tiwei Bie > > <...> > > > @@ -252,7 +252,7 @@ The corresponding callbacks are: > > Example of using the vector version of the virtio poll mode driver in > > ``testpmd``:: >

Re: [dpdk-dev] [PATCH] pkg: change to SPDX license identifier

2018-05-25 Thread Thomas Monjalon
09/04/2018 10:58, Hemant Agrawal: > Cc: olivier.m...@6wind.com > Cc: tho...@monjalon.net > > Signed-off-by: Hemant Agrawal > --- > pkg/dpdk.spec | 30 +- > 1 file changed, 1 insertion(+), 29 deletions(-) Olivier has sent a patch which this file among others.

Re: [dpdk-dev] [PATCH] eal: add missing SPDX identifiers

2018-05-25 Thread Thomas Monjalon
09/04/2018 10:58, Hemant Agrawal: > Cc: roman.dement...@intel.com > Cc: vikto...@rehivetech.com > > Signed-off-by: Hemant Agrawal Applied, thanks

Re: [dpdk-dev] [PATCH] doc: address the offload API changes for virtio guide

2018-05-25 Thread Ferruh Yigit
On 5/25/2018 7:17 AM, Tiwei Bie wrote: > Signed-off-by: Tiwei Bie <...> > @@ -252,7 +252,7 @@ The corresponding callbacks are: > Example of using the vector version of the virtio poll mode driver in > ``testpmd``:: > > - testpmd -l 0-2 -n 4 -- -i --txqflags=0xF01 --rxq=1 --txq=1 --nb-cores

Re: [dpdk-dev] [PATCH] net/nfp: fix lock file usage

2018-05-25 Thread Ferruh Yigit
On 5/23/2018 1:28 PM, Alejandro Lucero wrote: > DPDK apps can be executed as non-root users but current NFP lock > file for avoiding concurrent accesses to CPP interface is precluding > this option or requires to modify system file permissions. > > When the NFP device is bound to VFIO, this driver

Re: [dpdk-dev] [PATCH v3] doc: advise to specify LTS branch when backporting patches

2018-05-25 Thread Thomas Monjalon
17/05/2018 15:53, luca.bocca...@gmail.com: > From: Luca Boccassi > > We have many stable branches being maintained at the same time, and > sometimes it's not clear which branch a patch is being backported for. > Note in the guidelines that it should be specified via the cover letter, > annotation

Re: [dpdk-dev] [dpdk-stable] [PATCH 1/2] mk: fix cross build errors

2018-05-25 Thread Gavin Hu
-Original Message- From: Thomas Monjalon Sent: Thursday, May 24, 2018 9:47 PM To: Gavin Hu Cc: dev@dpdk.org Subject: Re: [dpdk-stable] [PATCH 1/2] mk: fix cross build errors 24/05/2018 05:38, Gavin Hu: > +ifeq ($(shell test $(USE_HOST) -e 1 && test $(HOST_GCC_VERSION) -gt 70 && > echo

Re: [dpdk-dev] [RFC] hot plug failure handle mechanism

2018-05-25 Thread Guo, Jia
hi,matan On 5/24/2018 10:57 PM, Matan Azrad wrote: Hi Guo Some questions. From: Guo Jia As we know, hot plug is an importance feature whenever it use for the datacenter device's fail-safe and consumption management , or use for the dynamic deployment and SRIOV Live Migration in SDN/NFV, it

Re: [dpdk-dev] [PATCH v2] doc: announce removal of indirect mbuf check macro

2018-05-25 Thread Olivier Matz
On Thu, May 24, 2018 at 06:20:06PM -0700, Yongseok Koh wrote: > Link: http://dpdk.org/ml/archives/dev/2018-April/099476.html > > Signed-off-by: Yongseok Koh Acked-by: Olivier Matz

Re: [dpdk-dev] [PATCH] doc: address the offload API changes for virtio guide

2018-05-25 Thread Maxime Coquelin
On 05/25/2018 08:17 AM, Tiwei Bie wrote: Signed-off-by: Tiwei Bie --- doc/guides/nics/virtio.rst | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/doc/guides/nics/virtio.rst b/doc/guides/nics/virtio.rst index 8922f9c0b..a42d1bb30 100644 --- a/doc/guides/nics/virtio.rst

Re: [dpdk-dev] [PATCH 2/2] doc: add a guide doc for cross compiling from x86

2018-05-25 Thread Gavin Hu
Hi Bruce and Jerin, Thanks for your comments, some inline feedback for your comments. Any further comments are welcome. Best Regards, Gavin -Original Message- From: Bruce Richardson Sent: Thursday, May 24, 2018 9:21 PM To: Jerin Jacob Cc: Gavin Hu ; dev@dpdk.org Subject: Re: [dpdk-dev