Re: [dpdk-dev] [PATCH v6 07/15] vhost: extract split ring handling from Rx and Tx functions

2018-07-03 Thread Tiwei Bie
On Mon, Jul 02, 2018 at 10:16:21AM +0200, Maxime Coquelin wrote: [...] > + > + if (unlikely(vq->access_ok == 0)) > + if (unlikely(vring_translate(dev, vq) < 0)) > + goto out; > + > + Please just keep one blank line. > + /* > + * Construct a RARP broadc

Re: [dpdk-dev] [PATCH v2 02/20] net/mlx5: handle drop queues are regular queues

2018-07-03 Thread Nélio Laranjeiro
On Tue, Jul 03, 2018 at 10:05:05AM -0700, Yongseok Koh wrote: > On Tue, Jul 03, 2018 at 09:17:56AM +0200, Nélio Laranjeiro wrote: > > On Mon, Jul 02, 2018 at 06:07:03PM -0700, Yongseok Koh wrote: > > > On Wed, Jun 27, 2018 at 05:07:34PM +0200, Nelio Laranjeiro wrote: > [...] > > flow_drop_queue is

Re: [dpdk-dev] [PATCH v6 14/15] vhost: add notification for packed ring

2018-07-03 Thread Tiwei Bie
On Mon, Jul 02, 2018 at 10:16:28AM +0200, Maxime Coquelin wrote: > Signed-off-by: Maxime Coquelin > --- > lib/librte_vhost/vhost.c | 73 > > lib/librte_vhost/vhost.h | 71 ++ > lib/librte_vhost/vhost_use

Re: [dpdk-dev] [PATCH v6 10/15] vhost: create descriptor mapping function

2018-07-03 Thread Tiwei Bie
On Mon, Jul 02, 2018 at 10:16:24AM +0200, Maxime Coquelin wrote: > Signed-off-by: Maxime Coquelin > --- > lib/librte_vhost/virtio_net.c | 61 > ++- > 1 file changed, 37 insertions(+), 24 deletions(-) > > diff --git a/lib/librte_vhost/virtio_net.c b/lib/li

Re: [dpdk-dev] [PATCH v6 11/15] vhost: add vector filling support for packed ring

2018-07-03 Thread Tiwei Bie
On Mon, Jul 02, 2018 at 10:16:25AM +0200, Maxime Coquelin wrote: [...] > +static __rte_always_inline int > +fill_vec_buf_packed_indirect(struct virtio_net *dev, > + struct vhost_virtqueue *vq, > + struct vring_desc_packed *desc, uint16_t *vec_idx, > +

Re: [dpdk-dev] [PATCH v6 13/15] vhost: add Tx support for packed ring

2018-07-03 Thread Tiwei Bie
On Mon, Jul 02, 2018 at 10:16:27AM +0200, Maxime Coquelin wrote: > Signed-off-by: Maxime Coquelin > --- > lib/librte_vhost/vhost.h | 1 + > lib/librte_vhost/virtio_net.c | 121 > +- > 2 files changed, 121 insertions(+), 1 deletion(-) > > diff --git

Re: [dpdk-dev] [PATCH v6 02/15] vhost: add helpers for packed virtqueues

2018-07-03 Thread Tiwei Bie
On Mon, Jul 02, 2018 at 10:16:16AM +0200, Maxime Coquelin wrote: > From: Jens Freimann > > Add some helper functions to check descriptor flags > and check if a vring is of type packed. > > Signed-off-by: Jens Freimann > Signed-off-by: Maxime Coquelin > --- > lib/librte_vhost/vhost.h |

Re: [dpdk-dev] [PATCH v6 01/15] vhost: add virtio packed virtqueue defines

2018-07-03 Thread Tiwei Bie
On Mon, Jul 02, 2018 at 10:16:15AM +0200, Maxime Coquelin wrote: > From: Jens Freimann > > Signed-off-by: Jens Freimann > --- > lib/librte_vhost/vhost.h | 3 +++ > lib/librte_vhost/virtio-packed.h | 22 ++ > 2 files changed, 25 insertions(+) > create mode 100644 li

Re: [dpdk-dev] [PATCH v4 0/4] net/virtio: Tx simple path removal and offload improvements

2018-07-03 Thread Tiwei Bie
On Mon, Jul 02, 2018 at 05:25:43PM +0200, Maxime Coquelin wrote: > In this v3, the main change is the removal of the Tx simple path. > Indeed, this path is not compliant with the Virtio specification, > so could cause problems with some host implementations. > > Since Marvin has introduced the in-

Re: [dpdk-dev] [PATCH V4 8/9] app/testpmd: show example to handle hot unplug

2018-07-03 Thread Guo, Jia
hi, thomas On 7/4/2018 6:44 AM, Thomas Monjalon wrote: 03/07/2018 11:35, Guo, Jia: On 7/1/2018 3:46 PM, Matan Azrad wrote: From: Jeff Guo --- a/app/test-pmd/testpmd.c +++ b/app/test-pmd/testpmd.c @@ -2206,9 +2209,12 @@ eth_dev_event_callback(char *device_name, enum rte_dev_event_type type,

Re: [dpdk-dev] [PATCH v8 04/19] ethdev: introduce device lock

2018-07-03 Thread Zhang, Qi Z
Hi Yuanhan: > -Original Message- > From: Yuanhan Liu [mailto:y...@fridaylinux.org] > Sent: Wednesday, July 4, 2018 10:20 AM > To: Zhang, Qi Z ; tho...@monjalon.net; Burakov, > Anatoly > Cc: Ananyev, Konstantin ; dev@dpdk.org; > Richardson, Bruce ; Yigit, Ferruh > ; Shelton, Benjamin H > ;

[dpdk-dev] [PATCH] net/virtio: fix build with gcc optimization on

2018-07-03 Thread Marvin Liu
build error on gcc version 8.1.1 20180502 (Red Hat 8.1.1-1), with optimization level >= O2 .../drivers/net/virtio/virtio_rxtx.c: In function ‘virtio_xmit_cleanup_inorder’: .../drivers/net/virtio/virtio_rxtx.c:195:24: error: ‘desc_idx’ may be used uninitialized in this function [-Werror=ma

[dpdk-dev] [PATCH v2] net/bonding: don't clear active slave count

2018-07-03 Thread Chas Williams
From: "Charles (Chas) Williams" When the bond PMD is stopped, the active slave count is reset. For 802.3ad mode this potentially leaks memory and clears state since a second sequential activate_slave() will occur when the bond PMD is restarted and the LSC callback is triggered while the active sl

Re: [dpdk-dev] [PATCH v8 03/19] ethdev: enable hotplug on multi-process

2018-07-03 Thread Zhang, Qi Z
> -Original Message- > From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Wednesday, July 4, 2018 6:36 AM > To: Zhang, Qi Z > Cc: dev@dpdk.org; Burakov, Anatoly ; Ananyev, > Konstantin ; Richardson, Bruce > ; Yigit, Ferruh ; Shelton, > Benjamin H ; Vangati, Narender > > Subject

Re: [dpdk-dev] [PATCH v8 04/19] ethdev: introduce device lock

2018-07-03 Thread Yuanhan Liu
On Mon, Jul 2, 2018, at 1:44 PM, Qi Zhang wrote: > Introduce API rte_eth_dev_lock and rte_eth_dev_unlock to let > application lock or unlock on specific ethdev, a locked device > can't be detached, this help applicaiton to prevent unexpected > device detaching, especially in multi-process envrio

Re: [dpdk-dev] [PATCH v8 04/19] ethdev: introduce device lock

2018-07-03 Thread Zhang, Qi Z
> -Original Message- > From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Wednesday, July 4, 2018 6:14 AM > To: Zhang, Qi Z > Cc: dev@dpdk.org; Burakov, Anatoly ; Ananyev, > Konstantin ; Richardson, Bruce > ; Yigit, Ferruh ; Shelton, > Benjamin H ; Vangati, Narender > > Subject

Re: [dpdk-dev] [PATCH 1/2] test/link_bonding: disable HW CRC strip by default.

2018-07-03 Thread Phil Yang
Hi Ferruh, Thanks for you patch. > -Original Message- > From: Ferruh Yigit > Sent: Monday, July 2, 2018 6:00 PM > To: dev-boun...@dpdk.org; dev@dpdk.org > Cc: nd ; Phil Yang > Subject: Re: [dpdk-dev] [PATCH 1/2] test/link_bonding: disable HW CRC strip by > default. > > On 7/2/2018 9:26

[dpdk-dev] [PATCH] test/virtual_pmd: Add DEV_RX_OFFLOAD_CRC_STRIP to virtual driver

2018-07-03 Thread Phil Yang
Add DEV_RX_OFFLOAD_CRC_STRIP to virtual drivers since they don't use CRC at all, when an application requires this offload virtual PMDs should not return error. Fixes: b219c8c("test: enable HW CRC strip by default") Signed-off-by: Phil Yang --- test/test/virtual_pmd.c | 1 + 1 file changed, 1 i

Re: [dpdk-dev] [RFC 0/3] ethdev: add IP address and TCP/UDP port rewrite actions to flow API

2018-07-03 Thread Jack Min
Rahul, Thank you 😊! -Jack > -Original Message- > From: Rahul Lakkireddy > Sent: July 3, 2018 21:39 > To: Jack Min > Cc: dev@dpdk.org; Shagun Agarwal ; Indranil Choudhury > ; Nirranjan Kirubaharan ; Shahaf > Shuler ; Xueming(Steven) Li > Subject: Re: [dpdk-dev] [RFC 0/3] ethdev: add IP

Re: [dpdk-dev] [PATCH v8 02/19] eal: enable multi process init callback

2018-07-03 Thread Zhang, Qi Z
> -Original Message- > From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Wednesday, July 4, 2018 5:51 AM > To: Zhang, Qi Z > Cc: dev@dpdk.org; Burakov, Anatoly ; Ananyev, > Konstantin ; Richardson, Bruce > ; Yigit, Ferruh ; Shelton, > Benjamin H ; Vangati, Narender > > Subject

Re: [dpdk-dev] [PATCH v2 11/20] net/mlx5: add flow TCP item

2018-07-03 Thread Yongseok Koh
On Wed, Jun 27, 2018 at 05:07:43PM +0200, Nelio Laranjeiro wrote: > Signed-off-by: Nelio Laranjeiro > --- Acked-by: Yongseok Koh Thanks

Re: [dpdk-dev] [PATCH v2 10/20] net/mlx5: add flow UDP item

2018-07-03 Thread Yongseok Koh
On Wed, Jun 27, 2018 at 05:07:42PM +0200, Nelio Laranjeiro wrote: > Signed-off-by: Nelio Laranjeiro > --- Acked-by: Yongseok Koh Thanks

Re: [dpdk-dev] [PATCH v2 09/20] net/mlx5: add flow IPv6 item

2018-07-03 Thread Yongseok Koh
On Wed, Jun 27, 2018 at 05:07:41PM +0200, Nelio Laranjeiro wrote: > Signed-off-by: Nelio Laranjeiro > --- Acked-by: Yongseok Koh Thanks

Re: [dpdk-dev] [PATCH v2 08/20] net/mlx5: add flow IPv4 item

2018-07-03 Thread Yongseok Koh
On Wed, Jun 27, 2018 at 05:07:40PM +0200, Nelio Laranjeiro wrote: > Signed-off-by: Nelio Laranjeiro > --- > drivers/net/mlx5/mlx5_flow.c | 83 > 1 file changed, 83 insertions(+) > > diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c > in

Re: [dpdk-dev] [PATCH v2 07/20] net/mlx5: add flow VLAN item

2018-07-03 Thread Yongseok Koh
On Wed, Jun 27, 2018 at 05:07:39PM +0200, Nelio Laranjeiro wrote: > Signed-off-by: Nelio Laranjeiro > --- > drivers/net/mlx5/mlx5_flow.c | 123 +++ > 1 file changed, 123 insertions(+) > > diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c > i

Re: [dpdk-dev] [PATCH v2 06/20] net/mlx5: add flow stop/start

2018-07-03 Thread Yongseok Koh
On Wed, Jun 27, 2018 at 05:07:38PM +0200, Nelio Laranjeiro wrote: > Signed-off-by: Nelio Laranjeiro > --- Acked-by: Yongseok Koh Thanks

Re: [dpdk-dev] [PATCH v2 05/20] net/mlx5: add flow queue action

2018-07-03 Thread Yongseok Koh
On Wed, Jun 27, 2018 at 05:07:37PM +0200, Nelio Laranjeiro wrote: > Signed-off-by: Nelio Laranjeiro > --- Acked-by: Yongseok Koh Thanks

Re: [dpdk-dev] [PATCH V4 8/9] app/testpmd: show example to handle hot unplug

2018-07-03 Thread Thomas Monjalon
03/07/2018 11:35, Guo, Jia: > On 7/1/2018 3:46 PM, Matan Azrad wrote: > > From: Jeff Guo > >> --- a/app/test-pmd/testpmd.c > >> +++ b/app/test-pmd/testpmd.c > >> @@ -2206,9 +2209,12 @@ eth_dev_event_callback(char *device_name, enum > >> rte_dev_event_type type, > >>case RTE_DEV_EVENT_REMOVE: >

Re: [dpdk-dev] [PATCH v8 03/19] ethdev: enable hotplug on multi-process

2018-07-03 Thread Thomas Monjalon
03/07/2018 23:57, Thomas Monjalon: > 03/07/2018 17:03, Zhang, Qi Z: > > From: Thomas Monjalon [mailto:tho...@monjalon.net] > > > 03/07/2018 14:59, Zhang, Qi Z: > > > > > > +do_eth_dev_attach(const char *devargs, uint16_t *port_id); > > > > > > > > > > So you are duplicating rte_eth_dev_attach which

Re: [dpdk-dev] [PATCH v2 04/20] net/mlx5: support flow Ethernet item among with drop action

2018-07-03 Thread Yongseok Koh
On Wed, Jun 27, 2018 at 05:07:36PM +0200, Nelio Laranjeiro wrote: net/mlx5: support flow Ethernet item among with drop action Typo? "among" -> "along"? > Signed-off-by: Nelio Laranjeiro > --- > drivers/net/mlx5/mlx5.c | 1 + > drivers/net/mlx5/mlx5_flow.c | 671 +

Re: [dpdk-dev] [PATCH V4 1/9] bus: introduce hotplug failure handler

2018-07-03 Thread Thomas Monjalon
29/06/2018 12:30, Jeff Guo: > /** > + * Implementation a specific hot plug handler, which is responsible > + * for handle the failure when hot remove the device, guaranty the system > + * would not crash in the case. > + * @param dev > + * Pointer of the device structure. > + * > + * @return > +

[dpdk-dev] [PATCH v9 27/27] eal: add generic dev parameter

2018-07-03 Thread Gaetan Rivet
Add the --dev parameter to the EAL. This new parameter takes a generic device declaration as argument. It uses the new devargs parsing API. Signed-off-by: Gaetan Rivet --- lib/librte_eal/common/eal_common_devargs.c | 4 lib/librte_eal/common/eal_common_options.c | 36 +

[dpdk-dev] [PATCH v9 26/27] ethdev: process declarative eth devargs

2018-07-03 Thread Gaetan Rivet
Process the class-specific arguments in a devargs. This processing takes the form of setting the proper eth_dev fields when relevant. Signed-off-by: Gaetan Rivet --- lib/librte_ethdev/eth_private.h | 5 lib/librte_ethdev/rte_class_eth.c | 61 +++ lib/l

[dpdk-dev] [PATCH v9 25/27] bus/pci: process declarative PCI devargs

2018-07-03 Thread Gaetan Rivet
Introduce the facility to process future PCI parameters. Once the matching between PCI devices and devargs has been done, it is possible to process each devargs. New parameters would have the PCI device handle to work with when parsing the device (bus specific) parameters. Signed-off-by: Gaetan R

[dpdk-dev] [PATCH v9 24/27] bus/vdev: pre-process declarative vdev devargs

2018-07-03 Thread Gaetan Rivet
The new devargs format does not recognize a particular device name. Each bus uses its specific format. Process each devargs privately prior to attempting a bus scan. Prepare them if they are using the new devargs format. Signed-off-by: Gaetan Rivet --- drivers/bus/vdev/vdev.c | 10 +

[dpdk-dev] [PATCH v9 23/27] bus/pci: pre-process declarative PCI devargs

2018-07-03 Thread Gaetan Rivet
The new devargs format does not recognize a particular device name. Each bus uses its specific format. Instead of introducing a new bus API, process those devargs privately for the moment. Prepare them for matching during scan against the bus devices. Signed-off-by: Gaetan Rivet --- drivers/bus

[dpdk-dev] [PATCH v9 22/27] app/testpmd: add show device command

2018-07-03 Thread Gaetan Rivet
A new interactive command is offered: show device This commands lists all rte_device element matching the device description. e.g.: show device bus=pci show device bus=vdev show device bus=vdev/class=eth show device bus=vdev,driver=net_ring/class=eth show device bus=vdev/class

[dpdk-dev] [PATCH v9 19/27] ethdev: add private generic device iterator

2018-07-03 Thread Gaetan Rivet
This iterator can be customized with a comparison function that will trigger a stopping condition. It can be leveraged to write several different iterators that have similar but non-identical purposes. It is private to librte_ethdev. Signed-off-by: Gaetan Rivet --- lib/librte_ethdev/Makefile

[dpdk-dev] [PATCH v9 21/27] ethdev: add device matching field name

2018-07-03 Thread Gaetan Rivet
The eth device class can now parse a field name, matching the eth_dev name with one passed as "class=eth,name=xx" Signed-off-by: Gaetan Rivet --- lib/librte_ethdev/rte_class_eth.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/lib/librte_ethdev/rte_class_eth.c b/lib/librte_e

[dpdk-dev] [PATCH v9 20/27] ethdev: register ether layer as a class

2018-07-03 Thread Gaetan Rivet
Signed-off-by: Gaetan Rivet --- lib/librte_ethdev/Makefile| 3 +- lib/librte_ethdev/rte_class_eth.c | 79 +++ 2 files changed, 81 insertions(+), 1 deletion(-) create mode 100644 lib/librte_ethdev/rte_class_eth.c diff --git a/lib/librte_ethdev/Makefil

[dpdk-dev] [PATCH v9 17/27] bus/vdev: implement device iteration

2018-07-03 Thread Gaetan Rivet
Signed-off-by: Gaetan Rivet --- drivers/bus/vdev/Makefile | 3 ++- drivers/bus/vdev/vdev.c | 10 drivers/bus/vdev/vdev_params.c | 51 + drivers/bus/vdev/vdev_private.h | 26 + 4 files changed, 85 insertions(+), 5

[dpdk-dev] [PATCH v9 15/27] bus/pci: implement device iteration and comparison

2018-07-03 Thread Gaetan Rivet
Signed-off-by: Gaetan Rivet --- drivers/bus/pci/Makefile | 3 ++- drivers/bus/pci/pci_common.c | 1 + drivers/bus/pci/pci_params.c | 53 drivers/bus/pci/private.h| 25 + 4 files changed, 81 insertions(+), 1 deletion(-) cr

[dpdk-dev] [PATCH v9 16/27] bus/pci: add device matching field id

2018-07-03 Thread Gaetan Rivet
The PCI bus can now parse a matching field "id" as follows: "bus=pci,id=:00:00.0" or "bus=pci,id=00:00.0" Signed-off-by: Gaetan Rivet --- drivers/bus/pci/pci_params.c | 29 +++-- 1 file changed, 27 insertions(+), 2 deletions(-) diff --git a/driver

[dpdk-dev] [PATCH v9 18/27] bus/vdev: add device matching field driver

2018-07-03 Thread Gaetan Rivet
The vdev bus parses a field "driver", matching a vdev driver name with one passed as follows: "bus=vdev,driver=" Signed-off-by: Gaetan Rivet --- drivers/bus/vdev/vdev_params.c | 15 +-- 1 file changed, 13 insertions(+), 2 deletions(-) diff --git a/drivers/bus/vdev/vdev_param

[dpdk-dev] [PATCH v9 14/27] kvargs: add generic string matching callback

2018-07-03 Thread Gaetan Rivet
This function can be used as a callback to rte_kvargs_process. This should reduce code duplication. Signed-off-by: Gaetan Rivet --- lib/librte_kvargs/rte_kvargs.c | 10 ++ lib/librte_kvargs/rte_kvargs.h | 28 lib/librte_kvargs/rte_kvargs_

[dpdk-dev] [PATCH v9 13/27] eal/dev: implement device iteration

2018-07-03 Thread Gaetan Rivet
Use the iteration hooks in the abstraction layers to perform the requested filtering on the internal device lists. Signed-off-by: Gaetan Rivet --- lib/librte_eal/common/eal_common_dev.c | 168 lib/librte_eal/common/include/rte_dev.h | 26 + lib/librte_eal/r

[dpdk-dev] [PATCH v9 10/27] eal/class: add device iteration

2018-07-03 Thread Gaetan Rivet
Signed-off-by: Gaetan Rivet --- lib/librte_eal/common/include/rte_class.h | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/librte_eal/common/include/rte_class.h b/lib/librte_eal/common/include/rte_class.h index e8176f5e1..9d5b06807 100644 --- a/lib/librte_eal/common/include/rte_class.h ++

[dpdk-dev] [PATCH v9 12/27] eal/dev: implement device iteration initialization

2018-07-03 Thread Gaetan Rivet
Parse a device description. Split this description in their relevant part for each layers. No dynamic allocation is performed. Signed-off-by: Gaetan Rivet --- lib/Makefile| 1 + lib/librte_eal/bsdapp/eal/Makefile | 1 + lib/librte_eal/common/eal_common_dev.c |

[dpdk-dev] [PATCH v9 11/27] eal/bus: add device iteration

2018-07-03 Thread Gaetan Rivet
Signed-off-by: Gaetan Rivet --- lib/librte_eal/common/include/rte_bus.h | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/librte_eal/common/include/rte_bus.h b/lib/librte_eal/common/include/rte_bus.h index eb9eded4e..747baf140 100644 --- a/lib/librte_eal/common/include/rte_bus.h +++ b/lib/

[dpdk-dev] [PATCH v9 09/27] eal/dev: add device iterator interface

2018-07-03 Thread Gaetan Rivet
A device iterator allows iterating over a set of devices. This set is defined by the two descriptions offered, * rte_bus * rte_class Only one description can be provided, or both. It is not allowed to provide no description at all. Each layer of abstraction then performs a filter based on th

[dpdk-dev] [PATCH v9 07/27] eal/class: register destructor

2018-07-03 Thread Gaetan Rivet
Signed-off-by: Gaetan Rivet --- lib/librte_eal/common/include/rte_class.h | 5 + 1 file changed, 5 insertions(+) diff --git a/lib/librte_eal/common/include/rte_class.h b/lib/librte_eal/common/include/rte_class.h index b5e550a34..e8176f5e1 100644 --- a/lib/librte_eal/common/include/rte_class

[dpdk-dev] [PATCH v9 08/27] devargs: add function to parse device layers

2018-07-03 Thread Gaetan Rivet
This function is private to the EAL. It is used to parse each layers in a device description string, and store the result in an rte_devargs structure. Signed-off-by: Gaetan Rivet --- lib/librte_eal/common/eal_common_devargs.c | 144 lib/librte_eal/common/eal_private

[dpdk-dev] [PATCH v9 05/27] eal: introduce dtor macros

2018-07-03 Thread Gaetan Rivet
Signed-off-by: Gaetan Rivet --- lib/librte_eal/common/include/rte_common.h | 23 +++ 1 file changed, 23 insertions(+) diff --git a/lib/librte_eal/common/include/rte_common.h b/lib/librte_eal/common/include/rte_common.h index 434adfd45..0dd832728 100644 --- a/lib/librte_eal/c

[dpdk-dev] [PATCH v9 06/27] eal: introduce device class abstraction

2018-07-03 Thread Gaetan Rivet
Signed-off-by: Gaetan Rivet --- lib/librte_eal/bsdapp/eal/Makefile | 1 + lib/librte_eal/common/Makefile | 2 +- lib/librte_eal/common/eal_common_class.c | 62 +++ lib/librte_eal/common/include/rte_class.h | 121 + lib/librte_eal

[dpdk-dev] [PATCH v9 03/27] kvargs: build before EAL

2018-07-03 Thread Gaetan Rivet
Signed-off-by: Gaetan Rivet --- lib/Makefile | 3 +-- lib/librte_kvargs/Makefile | 2 +- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/lib/Makefile b/lib/Makefile index d82462ba2..e8e903c8f 100644 --- a/lib/Makefile +++ b/lib/Makefile @@ -4,6 +4,7 @@ include $(RTE_

[dpdk-dev] [PATCH v9 04/27] kvargs: introduce a more flexible parsing function

2018-07-03 Thread Gaetan Rivet
This function permits defining additional terminating characters, ending the parsing to arbitrary delimiters. Signed-off-by: Gaetan Rivet --- lib/Makefile | 1 + lib/librte_kvargs/rte_kvargs.c | 25 + lib/librte_kvargs/rte_kvargs.h

[dpdk-dev] [PATCH v9 02/27] kvargs: remove error logs

2018-07-03 Thread Gaetan Rivet
Error logs in kvargs parsing should be better handled in components calling the library. This library must be as lean as possible. Signed-off-by: Gaetan Rivet --- lib/librte_kvargs/rte_kvargs.c | 22 +- 1 file changed, 5 insertions(+), 17 deletions(-) diff --git a/lib/librt

[dpdk-dev] [PATCH v9 00/27] Device querying

2018-07-03 Thread Gaetan Rivet
This patchset introduces a new EAL API for querying devices, filtered by arbitrary properties. The following elements are introduced to this end: * A new object, "rte_class", is used to describe the device class abstraction layer (eth, crypto, ...). * Both rte_bus and rte_class now offer a

[dpdk-dev] [PATCH v9 01/27] devargs: add non-variadic parsing function

2018-07-03 Thread Gaetan Rivet
rte_devargs_parse becomes non-variadic, rte_devargs_parsef becomes the variadic version, to be used to compose device strings. Signed-off-by: Gaetan Rivet --- drivers/net/failsafe/failsafe_args.c| 2 +- drivers/net/failsafe/failsafe_eal.c | 2 +- lib/librte_eal/common/eal_commo

Re: [dpdk-dev] [PATCH v8 04/19] ethdev: introduce device lock

2018-07-03 Thread Thomas Monjalon
03/07/2018 17:08, Zhang, Qi Z: > From: Thomas Monjalon [mailto:tho...@monjalon.net] > > 02/07/2018 07:44, Qi Zhang: > > > Introduce API rte_eth_dev_lock and rte_eth_dev_unlock to let > > > application lock or unlock on specific ethdev, a locked device can't > > > be detached, this help applicaiton

Re: [dpdk-dev] [PATCH v8 03/19] ethdev: enable hotplug on multi-process

2018-07-03 Thread Thomas Monjalon
03/07/2018 17:03, Zhang, Qi Z: > From: Thomas Monjalon [mailto:tho...@monjalon.net] > > 03/07/2018 14:59, Zhang, Qi Z: > > > > > +do_eth_dev_attach(const char *devargs, uint16_t *port_id); > > > > > > > > So you are duplicating rte_eth_dev_attach which is flawed in its > > > > design and should be

Re: [dpdk-dev] [PATCH v8 02/19] eal: enable multi process init callback

2018-07-03 Thread Thomas Monjalon
03/07/2018 17:16, Zhang, Qi Z: > From: Thomas Monjalon [mailto:tho...@monjalon.net] > > > > Hi Qi, > > > > Sorry I do not understand neither the commit log, nor the doxygen. > > If it can help, consider your reader is in a bad mood and needs a pleasant > > description. > > OK, I think is not a g

[dpdk-dev] [PATCH] net/ark: use SPDX tags for Atomic Rules copyrighted files

2018-07-03 Thread Ed Czeck
Replace the BSD license header with the SPDX tag. Signed-off-by: Ed Czeck --- drivers/net/ark/Makefile| 32 ++-- drivers/net/ark/ark_ddm.c | 33 ++--- drivers/net/ark/ark_ddm.h | 33 ++--- dri

Re: [dpdk-dev] [PATCH v2 0/5] remove old ethdev offload API

2018-07-03 Thread Ferruh Yigit
On 7/2/2018 10:27 PM, Thomas Monjalon wrote: > A new offload API has been introduced in DPDK 17.11. > > This patchset resumes the work started by Ferruh (RFC) > to definitely drop the old offload API. > > There are: > - 3 patches to remove some useless code where the old API was found. > - 1 patc

Re: [dpdk-dev] [PATCH v4] net/pcap: rx_iface_in stream type support

2018-07-03 Thread Ferruh Yigit
On 7/1/2018 12:05 PM, ido goshen wrote: > From: ido g > > Support rx of in direction packets only > Useful for apps that also tx to eth_pcap ports in order to not see them > echoed back in as rx when out direction is also captured > > Example: > In case using rx_iface and sending *single* packet

[dpdk-dev] [PATCH] app/testpmd: set keep CRC offload flag

2018-07-03 Thread Ferruh Yigit
If "--disable-crc-strip" testpmd parameter issued, it removes the DEV_RX_OFFLOAD_CRC_STRIP flag. With introduction of new DEV_RX_OFFLOAD_KEEP_CRC offload flag, this flag also should be set when this parameter issued. Fixes: 3d12dceed2df ("ethdev: add new offload flag to keep CRC") Signed-off-by:

[dpdk-dev] [PATCH v5] examples: fix RSS hash function configuration

2018-07-03 Thread Ferruh Yigit
ethdev layer introduced checks for application requested RSS hash functions and returns error for ones unsupported by hardware This check breaks some sample applications which blindly configures RSS hash functions without checking underlying hardware support. Updated examples to mask out unsuppor

Re: [dpdk-dev] [PATCH v2 02/20] net/mlx5: handle drop queues are regular queues

2018-07-03 Thread Yongseok Koh
On Tue, Jul 03, 2018 at 09:17:56AM +0200, Nélio Laranjeiro wrote: > On Mon, Jul 02, 2018 at 06:07:03PM -0700, Yongseok Koh wrote: > > On Wed, Jun 27, 2018 at 05:07:34PM +0200, Nelio Laranjeiro wrote: [...] > flow_drop_queue is also confusing as it is a drop hash rx queue, it can > be used without a

[dpdk-dev] [PATCH] crypto/aesni_gcm: support IPsec Multi-buffer lib v0.50

2018-07-03 Thread Pablo de Lara
Adds support for the v0.50 of the IPsec Multi-buffer lib. The library now exposes its version, with the idea of maintaining backwards compatibility in the future, avoiding breaking the compilation of the PMD every time there is a new version available. Signed-off-by: Pablo de Lara --- doc/guides

[dpdk-dev] [PATCH] crypto/aesni_mb: support IPsec Multi-buffer lib v0.50

2018-07-03 Thread Pablo de Lara
Adds support for the v0.50 of the IPsec Multi-buffer lib. The library now exposes its version, with the idea of maintaining backwards compatibility in the future, avoiding breaking the compilation of the PMD every time there is a new version available. Signed-off-by: Pablo de Lara --- doc/guides

[dpdk-dev] [PATCH v2] examples/multi_process: add l2fwd_fork to Makefile

2018-07-03 Thread Emma Kenny
l2fwd_fork is not complied by default, this will make it compile Fixes: 95e8005a56e8 ("examples/l2fwd_fork: new app") Signed-off-by: Emma Kenny --- examples/multi_process/Makefile | 1 + 1 file changed, 1 insertion(+) diff --git a/examples/multi_process/Makefile b/examples/multi_process/Makefi

Re: [dpdk-dev] [PATCH] ethdev: document xstats API assumption

2018-07-03 Thread Van Haaren, Harry
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Ferruh Yigit > Sent: Thursday, June 28, 2018 3:16 PM > To: Thomas Monjalon > Cc: dev@dpdk.org; Yigit, Ferruh ; David Marchand > ; Olivier Matz ; Horton, > Remy > Subject: [dpdk-dev] [PATCH] ethdev: document xstats API assumption > > Document

[dpdk-dev] [PATCH v4] examples: fix RSS hash function configuration

2018-07-03 Thread Ferruh Yigit
ethdev layer introduced checks for application requested RSS hash functions and returns error for ones unsupported by hardware This check breaks some sample applications which blindly configures RSS hash functions without checking underlying hardware support. Updated examples to mask out unsuppor

[dpdk-dev] [PATCH v4 2/4] cryptodev: support asymmetric operations

2018-07-03 Thread Shally Verma
From: Umesh Kartha Extend DPDK librte_cryptodev to: - define asym op type in rte_crypto_op_type and associated op pool create/alloc APIs - define asym session and associated session APIs If PMD shows in its feature flag that it supports both sym and asym then it must support those on all its q

[dpdk-dev] [PATCH v4 3/4] lib/cryptodev: add asymmetric crypto capability in cryptodev

2018-07-03 Thread Shally Verma
From: Ashish Gupta Extend cryptodev with asymmetric capability APIs and definitions. Signed-off-by: Shally Verma Signed-off-by: Sunila Sahu Signed-off-by: Ashish Gupta Signed-off-by: Umesh Kartha --- lib/librte_cryptodev/rte_cryptodev.c | 76 ++ lib/librte_cryptod

[dpdk-dev] [PATCH v4 4/4] doc: add asym crypto in cryptodev programmer guide

2018-07-03 Thread Shally Verma
From: Sunila Sahu Update cryptodev programmer guide with description of asymmetric crypto framework in lib cryptodev. Signed-off-by: Shally Verma Signed-off-by: Sunila Sahu Signed-off-by: Ashish Gupta Signed-off-by: Umesh Kartha --- doc/guides/prog_guide/cryptodev_lib.rst | 290

[dpdk-dev] [PATCH v4 0/4] crypto: add asym crypto support

2018-07-03 Thread Shally Verma
This patch series add support for asymmetric crypto in DPDK librte_cryptodev framework along with documentation updates. This patch series is divided in to following categories: 1. library patches with asymmetric API, xform and capability definitions 2. Programmer Guide updates with asymmetric

[dpdk-dev] [PATCH v4 1/4] lib/cryptodev: add asymmetric algos in cryptodev

2018-07-03 Thread Shally Verma
Add rte_crypto_asym.h with supported xfrms and associated op structures and APIs API currently supports: - RSA Encrypt, Decrypt, Sign and Verify - Modular Exponentiation and Inversion - DSA Sign and Verify - Deffie-hellman private key exchange - Deffie-hellman public key exchange - Deffie-hellman

Re: [dpdk-dev] [PATCH v8 02/19] eal: enable multi process init callback

2018-07-03 Thread Zhang, Qi Z
> -Original Message- > From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Tuesday, July 3, 2018 5:28 PM > To: Zhang, Qi Z > Cc: dev@dpdk.org; Burakov, Anatoly ; Ananyev, > Konstantin ; Richardson, Bruce > ; Yigit, Ferruh ; Shelton, > Benjamin H ; Vangati, Narender > > Subject:

Re: [dpdk-dev] [PATCH v3 5/6] crypto/openssl: add asym crypto support

2018-07-03 Thread Verma, Shally
>-Original Message- >From: Trahe, Fiona [mailto:fiona.tr...@intel.com] >Sent: 03 July 2018 20:41 >To: Verma, Shally ; De Lara Guarch, Pablo > >Cc: akhil.go...@nxp.com; dev@dpdk.org; Athreya, Narayana Prasad >; Sahu, Sunila >; Gupta, Ashish >Subject: RE: [PATCH v3 5/6] crypto/openssl:

Re: [dpdk-dev] [PATCH v3 5/6] crypto/openssl: add asym crypto support

2018-07-03 Thread Trahe, Fiona
> -Original Message- > From: Verma, Shally [mailto:shally.ve...@cavium.com] > Sent: Tuesday, July 3, 2018 4:00 PM > To: Trahe, Fiona ; De Lara Guarch, Pablo > > Cc: akhil.go...@nxp.com; dev@dpdk.org; Athreya, Narayana Prasad > ; Sahu, Sunila ; > Gupta, Ashish > > Subject: RE: [PATCH

Re: [dpdk-dev] [PATCH v8 04/19] ethdev: introduce device lock

2018-07-03 Thread Zhang, Qi Z
> -Original Message- > From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Tuesday, July 3, 2018 5:56 PM > To: Zhang, Qi Z > Cc: dev@dpdk.org; Burakov, Anatoly ; Ananyev, > Konstantin ; Richardson, Bruce > ; Yigit, Ferruh ; Shelton, > Benjamin H ; Vangati, Narender > > Subject:

Re: [dpdk-dev] [PATCH v8 03/19] ethdev: enable hotplug on multi-process

2018-07-03 Thread Zhang, Qi Z
> -Original Message- > From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Tuesday, July 3, 2018 10:11 PM > To: Zhang, Qi Z > Cc: dev@dpdk.org; Burakov, Anatoly ; Ananyev, > Konstantin ; Richardson, Bruce > ; Yigit, Ferruh ; Shelton, > Benjamin H ; Vangati, Narender > > Subject:

Re: [dpdk-dev] [PATCH v3 5/6] crypto/openssl: add asym crypto support

2018-07-03 Thread Verma, Shally
>-Original Message- >From: Trahe, Fiona [mailto:fiona.tr...@intel.com] >Sent: 03 July 2018 20:21 >To: Verma, Shally ; De Lara Guarch, Pablo > >Cc: akhil.go...@nxp.com; dev@dpdk.org; Athreya, Narayana Prasad >; Sahu, Sunila >; Gupta, Ashish ; Trahe, >Fiona >Subject: RE: [PATCH v3 5/6]

Re: [dpdk-dev] [PATCH v3 5/6] crypto/openssl: add asym crypto support

2018-07-03 Thread Trahe, Fiona
Hi Shally, > -Original Message- > From: Shally Verma [mailto:shally.ve...@caviumnetworks.com] > Sent: Wednesday, May 16, 2018 7:05 AM > To: De Lara Guarch, Pablo > Cc: Trahe, Fiona ; akhil.go...@nxp.com; dev@dpdk.org; > pathr...@caviumnetworks.com; Sunila Sahu ; > Ashish Gupta > > Subje

Re: [dpdk-dev] [PATCH v3 3/6] lib/cryptodev: add asymmetric crypto capability in cryptodev

2018-07-03 Thread Verma, Shally
HI Fiona Thanks for review. I was just about to send lib patch v4. So for now, I couldn't consider all input but some of them. But , in any case, this version is experimental so it is open for further feedback after 1st version go in. Rest, please see my feedback inline. >-Original Messag

Re: [dpdk-dev] [PATCH v3 3/6] lib/cryptodev: add asymmetric crypto capability in cryptodev

2018-07-03 Thread Trahe, Fiona
Hi Shally, > -Original Message- > From: Shally Verma [mailto:shally.ve...@caviumnetworks.com] > Sent: Wednesday, May 16, 2018 7:05 AM > To: De Lara Guarch, Pablo > Cc: Trahe, Fiona ; akhil.go...@nxp.com; dev@dpdk.org; > pathr...@caviumnetworks.com; Sunila Sahu ; > Ashish Gupta > > Subje

Re: [dpdk-dev] [PATCH v8 03/19] ethdev: enable hotplug on multi-process

2018-07-03 Thread Thomas Monjalon
03/07/2018 14:59, Zhang, Qi Z: > > > +/** > > > + * this is a synchronous wrapper for secondary process send > > > + * request to primary process, this is invoked when an attach > > > + * or detach request issued from primary. > > > + */ > > > +int eth_dev_request_to_primary(struct eth_dev_mp_req *

[dpdk-dev] [PATCH] crypto/aesni_mb: call buffer manager allocation

2018-07-03 Thread Pablo de Lara
Instead of having a static field for the buffer manager MB_MGR in the queue pair structure, use the provided API that allocates memory for it and store a pointer to it. Signed-off-by: Pablo de Lara --- drivers/crypto/aesni_mb/rte_aesni_mb_pmd.c | 10 +- drivers/crypto/aesni_mb/rt

Re: [dpdk-dev] [RFC 0/3] ethdev: add IP address and TCP/UDP port rewrite actions to flow API

2018-07-03 Thread Rahul Lakkireddy
On Tuesday, July 07/03/18, 2018 at 07:57:55 +0530, Jack Min wrote: > Hey Rahul, > > Thank you, those two are the ways to achieve that. > > Personally I prefer the option 1 but with a little bit difference, something > like: > > struct rte_flow_action_of_set_nw_ipv4 { > uint32_t ipv

Re: [dpdk-dev] [PATCH v1 00/15] preparing l2fwd for eventmode additions

2018-07-03 Thread Joseph, Anoob
Hi, Gentle reminder! Thanks, Anoob On 19-06-2018 19:37, Anoob Joseph wrote: External Email Hi Bruce, Thanks for the feedback. Please see inline. + Hemant, Nikhil, Sunil, Gage, Harry, Narender, Pavan, Thomas, Akhil On 19/06/18 15:39, Bruce Richardson wrote: On Tue, Jun 19, 2018 at 03:34

Re: [dpdk-dev] [PATCH 01/20] eventdev: add files for eventmode helper

2018-07-03 Thread Joseph, Anoob
Hi Sunil, Please see inline. Thanks, Anoob On 03-07-2018 11:57, Sunil Kumar Kori wrote: External Email Hello Anoob, Regards Sunil Kumar -Original Message- From: Joseph, Anoob [mailto:anoob.jos...@caviumnetworks.com] Sent: Thursday, June 28, 2018 4:13 PM To: Sunil Kumar Kori ; Bru

[dpdk-dev] [PATCH] ethdev: change vtune profiling approach

2018-07-03 Thread ilia . kurakin
From: Ilia Kurakin The patch changes rx_burst profiling approach: 1. VTune's instrumentation is removed 2. empty hook callback for profiling is added This way all VTune-specific logic moves to the VTune side. Hook is enabled only when CONFIG_RTE_ETHDEV_PROFILE_WITH_VTUNE option is

Re: [dpdk-dev] [PATCH v8 03/19] ethdev: enable hotplug on multi-process

2018-07-03 Thread Zhang, Qi Z
Hi Thomas: <...> > > +enum eth_dev_req_type { > > + REQ_TYPE_ATTACH, > > + REQ_TYPE_PRE_DETACH, > > + REQ_TYPE_DETACH, > > + REQ_TYPE_ATTACH_ROLLBACK, > > +}; > > These constants are missing an ethdev prefix. OK, will fix. > > > + > > +struct eth_dev_mp_req { > > + enum eth_dev_req_t

[dpdk-dev] [PATCH] crypto/snow3g: add dynamic logging

2018-07-03 Thread Pablo de Lara
Registered new dynamic logtype for driver and replaced SNOW3G_LOG_ERR and CDEV_LOG_ERR with the new SNOW3G_LOG macro, which uses the new logtype. Signed-off-by: Pablo de Lara --- drivers/crypto/snow3g/rte_snow3g_pmd.c | 25 ++- drivers/crypto/snow3g/rte_snow3g_pmd_ops

Re: [dpdk-dev] [PATCH v2 1/6] mem: add function for checking memsegs IOVAs addresses

2018-07-03 Thread Burakov, Anatoly
On 03-Jul-18 1:09 PM, Alejandro Lucero wrote: A device can suffer addressing limitations. This functions checks memsegs have iovas within the supported range based on dma mask. PMD should use this during initialization if supported devices suffer addressing limitations, returning an error if thi

Re: [dpdk-dev] [PATCH v2 4/6] mem: use address hint for mapping hugepages

2018-07-03 Thread Burakov, Anatoly
On 03-Jul-18 1:09 PM, Alejandro Lucero wrote: Linux kernel uses a really high address as starting address for serving mmaps calls. If there exists addressing limitations and IOVA mode is VA, this starting address is likely too high for those devices. However, it is possible to use a lower address

Re: [dpdk-dev] [PATCH] net/mlx5: activate Verbs cleanup on removal

2018-07-03 Thread Shahaf Shuler
Monday, July 2, 2018 9:58 PM, Yongseok Koh: > Subject: Re: [dpdk-dev] [PATCH] net/mlx5: activate Verbs cleanup on > removal > > > > On Jul 1, 2018, at 10:13 PM, Matan Azrad wrote: > > > > Starting from rdma-core v19, Mellanox OFED 4.4, the Verbs resources > > cleanup is properly activated in plu

Re: [dpdk-dev] [PATCH v2 0/6] use IOVAs check based on DMA mask

2018-07-03 Thread Burakov, Anatoly
On 03-Jul-18 1:09 PM, Alejandro Lucero wrote: This patchset adds, mainly, a check for ensuring IOVAs are within a restricted range due to addressing limitations with some devices. There are two known cases: NFP and IOMMU VT-d emulation. With this check IOVAs out of range are detected and PMDs ca

Re: [dpdk-dev] [PATCH v2] crypto/virtio: fix iv physical address

2018-07-03 Thread Zhoujian (jay)
> -Original Message- > From: Fan Zhang [mailto:roy.fan.zh...@intel.com] > Sent: Tuesday, June 26, 2018 10:11 AM > To: dev@dpdk.org > Cc: pablo.de.lara.gua...@intel.com; Zhoujian (jay) ; > sta...@dpdk.org > Subject: [PATCH v2] crypto/virtio: fix iv physical address > > The physical address

  1   2   >