Re: [dpdk-dev] [PATCH] net/i40e: fix packet type parser error

2018-07-04 Thread Lin, Xueqin
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Beilei Xing > Sent: Thursday, July 5, 2018 9:36 AM > To: Zhang, Qi Z > Cc: dev@dpdk.org; sta...@dpdk.org > Subject: [dpdk-dev] [PATCH] net/i40e: fix packet type parser error > > To parse packet type corr

[dpdk-dev] FW: [PATCH] net/i40e: fix PPPoL2TP packet type parser issue

2018-07-04 Thread Lin, Xueqin
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Beilei Xing > Sent: Thursday, July 5, 2018 9:36 AM > To: Zhang, Qi Z > Cc: dev@dpdk.org; sta...@dpdk.org > Subject: [dpdk-dev] [PATCH] net/i40e: fix PPPoL2TP packet type parser > issue > > Since PPPoL2T

[dpdk-dev] [PATCH] mk: using initial-exec model for thread local variable

2018-07-04 Thread Marvin Liu
When building share library, thread-local storage model will be changed to global-dynamic. It will add additional cost for reading thread local variable. On the other hand, dynamically load share library with static TLS will request additional DTV slot which is limited by loader. By now only librte

Re: [dpdk-dev] [PATCH V4 1/9] bus: introduce hotplug failure handler

2018-07-04 Thread Guo, Jia
On 7/4/2018 3:55 PM, Thomas Monjalon wrote: 04/07/2018 09:16, Guo, Jia: On 7/4/2018 6:21 AM, Thomas Monjalon wrote: 29/06/2018 12:30, Jeff Guo: /** + * Implementation a specific hot plug handler, which is responsible + * for handle the failure when hot remove the device, guaranty the sys

[dpdk-dev] [PATCH v2] app/testpmd: fix buffer leak in tm cmdline

2018-07-04 Thread Nithin Dabilpuram
Free the buffer allocated for shared_shaper_id array in case of configuration without shared shapers. Signed-off-by: Nithin Dabilpuram Acked-by: Jasvinder Singh --- v2 changes: - Modify subject to use proper keyword for test-pmd - Change author email address app/test-pmd/cmdline_tm.c | 16

Re: [dpdk-dev] [PATCH v7 14/15] vhost: add notification for packed ring

2018-07-04 Thread Tiwei Bie
On Wed, Jul 04, 2018 at 11:54:37PM +0200, Maxime Coquelin wrote: [...] > @@ -225,6 +231,15 @@ struct vring_desc_packed { > uint16_t index; > uint16_t flags; > }; > + > +#define VRING_EVENT_F_ENABLE 0x0 > +#define VRING_EVENT_F_DISABLE 0x1 > +#define VRING_EVENT_F_DESC 0x2 > + > +struct

Re: [dpdk-dev] [PATCH v8 04/19] ethdev: introduce device lock

2018-07-04 Thread Zhang, Qi Z
> -Original Message- > From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Thursday, July 5, 2018 9:55 AM > To: Zhang, Qi Z > Cc: dev@dpdk.org; Burakov, Anatoly ; Ananyev, > Konstantin ; Richardson, Bruce > ; Yigit, Ferruh ; Shelton, > Benjamin H ; Vangati, Narender > ; arybche..

Re: [dpdk-dev] [PATCH v3 2/4] doc: rename compress feature flag

2018-07-04 Thread Verma, Shally
>-Original Message- >From: Pablo de Lara [mailto:pablo.de.lara.gua...@intel.com] >Sent: 04 July 2018 19:41 >To: Verma, Shally ; Gupta, Ashish >; fiona.tr...@intel.com; >lee.d...@intel.com >Cc: dev@dpdk.org; Pablo de Lara >Subject: [PATCH v3 2/4] doc: rename compress feature flag > >Ext

Re: [dpdk-dev] [PATCH v8 04/19] ethdev: introduce device lock

2018-07-04 Thread Thomas Monjalon
05/07/2018 03:38, Zhang, Qi Z: > From: Thomas Monjalon [mailto:tho...@monjalon.net] > > 04/07/2018 12:49, Zhang, Qi Z: > > > From: Thomas Monjalon [mailto:tho...@monjalon.net] > > > > 04/07/2018 03:47, Zhang, Qi Z: > > > > > From: Thomas Monjalon [mailto:tho...@monjalon.net] > > > > > > 03/07/2018

Re: [dpdk-dev] [PATCH v8 04/19] ethdev: introduce device lock

2018-07-04 Thread Zhang, Qi Z
> -Original Message- > From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Thursday, July 5, 2018 5:42 AM > To: Zhang, Qi Z > Cc: dev@dpdk.org; Burakov, Anatoly ; Ananyev, > Konstantin ; Richardson, Bruce > ; Yigit, Ferruh ; Shelton, > Benjamin H ; Vangati, Narender > ; arybche..

[dpdk-dev] [PATCH] net/i40e: fix packet type parser error

2018-07-04 Thread Beilei Xing
To parse packet type correctly, profile needs to be loaded again to update tables in SW even if profile has exited. But previously packet type parser will be false after loading profile when profile already exists. This patch fixes the issue. Fixes: 0585f5c3d264 ("net/i40e: fix DDP profile DEL ope

[dpdk-dev] [PATCH] net/i40e: fix PPPoL2TP packet type parser issue

2018-07-04 Thread Beilei Xing
Since PPPoL2TP profile is updated, PPPoL2TP packet type parser will be false with the current parser function. This patch fixes the issue. Fixes: 11556c915a08 ("net/i40e: improve packet type parser") Cc: sta...@dpdk.org Signed-off-by: Beilei Xing --- drivers/net/i40e/i40e_ethdev.c | 3 ++- 1 fi

[dpdk-dev] [PATCH v3 2/4] doc: rename compress feature flag

2018-07-04 Thread Pablo de Lara
Renamed feature "Bypass" to "Pass-through", as it is a more explicit name, meaning that the PMD is capable of passing the mbufs through it, without making any modifications (i.e.. NULL algorithm). Signed-off-by: Pablo de Lara --- doc/guides/compressdevs/features/default.ini | 2 +- doc/guides/co

[dpdk-dev] [PATCH v3 3/4] compressdev: replace mbuf scatter gather flag

2018-07-04 Thread Pablo de Lara
The current mbuf scatter gather feature flag is too ambiguous, as it is not clear if input and/or output buffers can be scatter gather mbufs or not. Therefore, three new flags will replace this flag: - RTE_COMP_FF_OOP_SGL_IN_SGL_OUT - RTE_COMP_FF_OOP_SGL_IN_FB_OUT - RTE_COMP_FF_OOP_FB_IN_SGL_OUT

[dpdk-dev] [PATCH v3 4/4] compressdev: add huffman encoding flags

2018-07-04 Thread Pablo de Lara
Added Huffman fixed and dynamic encoding feature flags, so an application can query if a device supports these two types, when performing DEFLATE compression. Signed-off-by: Pablo de Lara Acked-by: Fiona Trahe --- Changes in v3: - No change Changes in v2: - Fixed typo drivers/compress/isal

[dpdk-dev] [PATCH v3 1/4] doc: cleanup ISA-L PMD feature matrix

2018-07-04 Thread Pablo de Lara
In PMD feature matrices (.ini files), it is not required to have the list of features that are not supported, just the ones that are. Signed-off-by: Pablo de Lara --- doc/guides/compressdevs/features/isal.ini | 8 1 file changed, 8 deletions(-) diff --git a/doc/guides/compressdevs/feat

[dpdk-dev] [PATCH v7 15/15] vhost: advertize packed ring layout support

2018-07-04 Thread Maxime Coquelin
Signed-off-by: Maxime Coquelin --- lib/librte_vhost/vhost.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lib/librte_vhost/vhost.h b/lib/librte_vhost/vhost.h index 5c7effabe..a2930b620 100644 --- a/lib/librte_vhost/vhost.h +++ b/lib/librte_vhost/vhost.h @@ -274,7 +274,8 @@

[dpdk-dev] [PATCH v7 14/15] vhost: add notification for packed ring

2018-07-04 Thread Maxime Coquelin
Signed-off-by: Maxime Coquelin --- lib/librte_vhost/vhost.c | 70 +-- lib/librte_vhost/vhost.h | 63 -- lib/librte_vhost/vhost_user.c | 24 +++ lib/librte_vhost/virtio_net.c | 12 4 files ch

[dpdk-dev] [PATCH v7 12/15] vhost: add Rx support for packed ring

2018-07-04 Thread Maxime Coquelin
Signed-off-by: Maxime Coquelin --- lib/librte_vhost/virtio_net.c | 117 +- 1 file changed, 116 insertions(+), 1 deletion(-) diff --git a/lib/librte_vhost/virtio_net.c b/lib/librte_vhost/virtio_net.c index 1a04df807..764f7cd23 100644 --- a/lib/librte_vhost/

[dpdk-dev] [PATCH v7 10/15] vhost: create descriptor mapping function

2018-07-04 Thread Maxime Coquelin
Signed-off-by: Maxime Coquelin --- lib/librte_vhost/virtio_net.c | 70 --- 1 file changed, 40 insertions(+), 30 deletions(-) diff --git a/lib/librte_vhost/virtio_net.c b/lib/librte_vhost/virtio_net.c index da5a13aad..e3b73c951 100644 --- a/lib/librte_vhost

[dpdk-dev] [PATCH v7 11/15] vhost: add vector filling support for packed ring

2018-07-04 Thread Maxime Coquelin
Signed-off-by: Maxime Coquelin --- lib/librte_vhost/virtio_net.c | 111 ++ 1 file changed, 111 insertions(+) diff --git a/lib/librte_vhost/virtio_net.c b/lib/librte_vhost/virtio_net.c index e3b73c951..1a04df807 100644 --- a/lib/librte_vhost/virtio_net.c ++

[dpdk-dev] [PATCH v7 09/15] vhost: add shadow used ring support for packed rings

2018-07-04 Thread Maxime Coquelin
Signed-off-by: Maxime Coquelin --- lib/librte_vhost/vhost.c | 9 -- lib/librte_vhost/vhost.h | 13 ++-- lib/librte_vhost/vhost_user.c | 64 -- lib/librte_vhost/virtio_net.c | 71 +-- 4 files changed, 13

[dpdk-dev] [PATCH v7 13/15] vhost: add Tx support for packed ring

2018-07-04 Thread Maxime Coquelin
Signed-off-by: Maxime Coquelin --- lib/librte_vhost/vhost.h | 1 + lib/librte_vhost/virtio_net.c | 119 +- 2 files changed, 119 insertions(+), 1 deletion(-) diff --git a/lib/librte_vhost/vhost.h b/lib/librte_vhost/vhost.h index 993f10ef9..92a87712e

[dpdk-dev] [PATCH v7 03/15] vhost: vring address setup for packed queues

2018-07-04 Thread Maxime Coquelin
From: Yuanhan Liu Add code to set up packed queues when enabled. Signed-off-by: Yuanhan Liu Signed-off-by: Jens Freimann Signed-off-by: Maxime Coquelin --- lib/librte_vhost/vhost.c | 43 ++- lib/librte_vhost/vhost.h | 7 ++- lib/librte_v

[dpdk-dev] [PATCH v7 08/15] vhost: append shadow used ring function names with split

2018-07-04 Thread Maxime Coquelin
Signed-off-by: Maxime Coquelin --- lib/librte_vhost/virtio_net.c | 28 +++- 1 file changed, 15 insertions(+), 13 deletions(-) diff --git a/lib/librte_vhost/virtio_net.c b/lib/librte_vhost/virtio_net.c index 7705c853b..7db3877d4 100644 --- a/lib/librte_vhost/virtio_net.c +

[dpdk-dev] [PATCH v7 05/15] vhost: make indirect desc table copy desc type agnostic

2018-07-04 Thread Maxime Coquelin
Signed-off-by: Maxime Coquelin --- lib/librte_vhost/virtio_net.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/lib/librte_vhost/virtio_net.c b/lib/librte_vhost/virtio_net.c index e189cbb2c..85b7ca02f 100644 --- a/lib/librte_vhost/virtio_net.c +++ b/lib/librt

[dpdk-dev] [PATCH v7 04/15] vhost: clear shadow used table index at flush time

2018-07-04 Thread Maxime Coquelin
Signed-off-by: Maxime Coquelin --- lib/librte_vhost/virtio_net.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/lib/librte_vhost/virtio_net.c b/lib/librte_vhost/virtio_net.c index 81377e79a..e189cbb2c 100644 --- a/lib/librte_vhost/virtio_net.c +++ b/lib/librte_vhost/virtio

[dpdk-dev] [PATCH v7 07/15] vhost: extract split ring handling from Rx and Tx functions

2018-07-04 Thread Maxime Coquelin
Signed-off-by: Maxime Coquelin --- lib/librte_vhost/virtio_net.c | 238 +++--- 1 file changed, 129 insertions(+), 109 deletions(-) diff --git a/lib/librte_vhost/virtio_net.c b/lib/librte_vhost/virtio_net.c index b5f4f14df..7705c853b 100644 --- a/lib/librte_vho

[dpdk-dev] [PATCH v7 06/15] vhost: clear batch copy index at copy time

2018-07-04 Thread Maxime Coquelin
Signed-off-by: Maxime Coquelin --- lib/librte_vhost/virtio_net.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/lib/librte_vhost/virtio_net.c b/lib/librte_vhost/virtio_net.c index 85b7ca02f..b5f4f14df 100644 --- a/lib/librte_vhost/virtio_net.c +++ b/lib/librte_vhost/v

[dpdk-dev] [PATCH v7 02/15] vhost: add helpers for packed virtqueues

2018-07-04 Thread Maxime Coquelin
From: Jens Freimann Add some helper functions to check descriptor flags and check if a vring is of type packed. Signed-off-by: Jens Freimann Signed-off-by: Maxime Coquelin --- lib/librte_vhost/vhost.h | 13 + 1 file changed, 13 insertions(+) diff --git a/lib/librte_vhost/vhost.h

[dpdk-dev] [PATCH v7 01/15] vhost: add virtio packed virtqueue defines

2018-07-04 Thread Maxime Coquelin
From: Jens Freimann Signed-off-by: Jens Freimann --- lib/librte_vhost/vhost.h | 20 1 file changed, 20 insertions(+) diff --git a/lib/librte_vhost/vhost.h b/lib/librte_vhost/vhost.h index 79e3117d2..d1f3a4d22 100644 --- a/lib/librte_vhost/vhost.h +++ b/lib/librte_vhost/vho

[dpdk-dev] [PATCH v7 00/15] Vhost: add support to packed ring layout

2018-07-04 Thread Maxime Coquelin
This series is a handover from Jen's "[PATCH v4 00/20] implement packed virtqueues", which only implements the vhost side. Virtio PMD implementation will follow in a next series. The series applies on top of previous reworks I posted during this cycle that merges mergeable and non-mergeable recei

Re: [dpdk-dev] [PATCH v8 04/19] ethdev: introduce device lock

2018-07-04 Thread Thomas Monjalon
04/07/2018 12:49, Zhang, Qi Z: > From: Thomas Monjalon [mailto:tho...@monjalon.net] > > 04/07/2018 03:47, Zhang, Qi Z: > > > From: Thomas Monjalon [mailto:tho...@monjalon.net] > > > > 03/07/2018 17:08, Zhang, Qi Z: > > > > > From: Thomas Monjalon [mailto:tho...@monjalon.net] > > > > > > 02/07/2018

Re: [dpdk-dev] [PATCH v6 07/15] vhost: extract split ring handling from Rx and Tx functions

2018-07-04 Thread Maxime Coquelin
On 07/04/2018 08:51 AM, Tiwei Bie wrote: On Mon, Jul 02, 2018 at 10:16:21AM +0200, Maxime Coquelin wrote: [...] + + if (unlikely(vq->access_ok == 0)) + if (unlikely(vring_translate(dev, vq) < 0)) + goto out; + + Please just keep one blank line. +

Re: [dpdk-dev] [PATCH v6 14/15] vhost: add notification for packed ring

2018-07-04 Thread Maxime Coquelin
On 07/04/2018 08:25 AM, Tiwei Bie wrote: On Mon, Jul 02, 2018 at 10:16:28AM +0200, Maxime Coquelin wrote: Signed-off-by: Maxime Coquelin --- lib/librte_vhost/vhost.c | 73 lib/librte_vhost/vhost.h | 71 ++

Re: [dpdk-dev] [PATCH v1] net/tap: explain how to compile eBPF C file

2018-07-04 Thread Thomas Monjalon
04/07/2018 21:47, Ferruh Yigit: > On 6/12/2018 3:02 PM, Ophir Munk wrote: > > Please note that other than cloning iproute2 we also need to install clang > > and llvm tools versions 3.7 and upper. > > Not sure there are clang and llvm packages of the required versions for the > > common distributi

Re: [dpdk-dev] [PATCH 0/5] net/cxgbe: feature updates and bug fixes

2018-07-04 Thread Ferruh Yigit
On 6/29/2018 8:23 PM, Rahul Lakkireddy wrote: > Patch 1 adds link up and down operations for PF and VF. > > Patch 2 enables 2-tuple based RSS hash on IPv4 fragment packets and > IPv6 packets with extension headers. > > Patch 3 queries firmware for max queues that can be allocated. > > Patch 4 fi

Re: [dpdk-dev] [PATCH 0/9] net/cxgbe: add support for offloading flows to HASH region

2018-07-04 Thread Ferruh Yigit
On 7/4/2018 8:16 PM, Ferruh Yigit wrote: > On 6/29/2018 7:12 PM, Rahul Lakkireddy wrote: >> This series of patches add support to offload flows to HASH region >> available on Chelsio T6 NICs. HASH region can only offload exact match >> (maskless) flows and hence the masks must be all set for all ma

Re: [dpdk-dev] [PATCH v1] net/tap: explain how to compile eBPF C file

2018-07-04 Thread Ferruh Yigit
On 6/12/2018 3:02 PM, Ophir Munk wrote: > Please note that other than cloning iproute2 we also need to install clang > and llvm tools versions 3.7 and upper. > Not sure there are clang and llvm packages of the required versions for the > common distributions. > I compiled the tools source code a

Re: [dpdk-dev] [PATCH] doc: update CRC feature with new offload flag

2018-07-04 Thread Andrew Rybchenko
On 04.07.2018 20:15, Ferruh Yigit wrote: Fixes: 3d12dceed2df ("ethdev: add new offload flag to keep CRC") Signed-off-by: Ferruh Yigit Acked-by: Andrew Rybchenko

Re: [dpdk-dev] [PATCH 3/9] net/cxgbe: add Compressed Local IP region

2018-07-04 Thread Ferruh Yigit
On 6/29/2018 7:12 PM, Rahul Lakkireddy wrote: > From: Shagun Agrawal > > CLIP region holds destination IPv6 addresses to be matched for > corresponding flows. Query firmware for CLIP resources and allocate > table to manage them. Also update LE-TCAM to use CLIP to reduce > number of slots needed

Re: [dpdk-dev] [PATCH 0/9] net/cxgbe: add support for offloading flows to HASH region

2018-07-04 Thread Ferruh Yigit
On 6/29/2018 7:12 PM, Rahul Lakkireddy wrote: > This series of patches add support to offload flows to HASH region > available on Chelsio T6 NICs. HASH region can only offload exact match > (maskless) flows and hence the masks must be all set for all match > items. Hi Shagun, Rahul, Can you pleas

[dpdk-dev] [PATCH v6] examples: fix RSS hash function configuration

2018-07-04 Thread Ferruh Yigit
ethdev layer introduced checks for application requested RSS hash functions and returns error for ones unsupported by hardware This check breaks some sample applications which blindly configures RSS hash functions without checking underlying hardware support. Updated examples to mask out unsuppor

Re: [dpdk-dev] [PATCH v2 0/5] remove old ethdev offload API

2018-07-04 Thread Ferruh Yigit
On 7/3/2018 7:37 PM, Ferruh Yigit wrote: > On 7/2/2018 10:27 PM, Thomas Monjalon wrote: >> A new offload API has been introduced in DPDK 17.11. >> >> This patchset resumes the work started by Ferruh (RFC) >> to definitely drop the old offload API. >> >> There are: >> - 3 patches to remove some usel

Re: [dpdk-dev] [PATCH] test/virtual_pmd: Add DEV_RX_OFFLOAD_CRC_STRIP to virtual driver

2018-07-04 Thread Ferruh Yigit
On 7/4/2018 10:45 AM, Ferruh Yigit wrote: > On 7/4/2018 10:34 AM, Ferruh Yigit wrote: >> On 7/4/2018 2:31 AM, dev-boun...@dpdk.org wrote: >>> Add DEV_RX_OFFLOAD_CRC_STRIP to virtual drivers since they don't >>> use CRC at all, when an application requires this offload virtual >>> PMDs should not re

Re: [dpdk-dev] [PATCH] net/ark: use SPDX tags for Atomic Rules copyrighted files

2018-07-04 Thread Ferruh Yigit
On 7/4/2018 7:04 PM, Ferruh Yigit wrote: > On 7/3/2018 10:36 PM, Ed Czeck wrote: >> Replace the BSD license header with the SPDX tag. >> >> Signed-off-by: Ed Czeck > > Reviewed-by: Ferruh Yigit Applied to dpdk-next-net/master, thanks.

Re: [dpdk-dev] [PATCH 1/2] net/sfc: support ops to check ready descriptors in ESSB Rx

2018-07-04 Thread Ferruh Yigit
On 6/29/2018 4:41 PM, Andrew Rybchenko wrote: > Implement EF10 ESSB Rx datapath callback to get number of pending > descriptors. > > Signed-off-by: Andrew Rybchenko > Reviewed-by: Ivan Malov Series applied to dpdk-next-net/master, thanks.

Re: [dpdk-dev] [dpdk-stable] [PATCH] net/sfc: fix double-free in EF10 ESSB Rx queue purge

2018-07-04 Thread Ferruh Yigit
On 6/29/2018 4:41 PM, Andrew Rybchenko wrote: > Number of buffers left in completed descriptor may be 0. If so, > all buffers of the descriptor are freed once again. > > Fixes: 390f9b8d82c9 ("net/sfc: support equal stride super-buffer Rx mode") > Cc: sta...@dpdk.org > > Signed-off-by: Andrew Rybc

Re: [dpdk-dev] [PATCH] net/ark: use SPDX tags for Atomic Rules copyrighted files

2018-07-04 Thread Ferruh Yigit
On 7/3/2018 10:36 PM, Ed Czeck wrote: > Replace the BSD license header with the SPDX tag. > > Signed-off-by: Ed Czeck Reviewed-by: Ferruh Yigit

Re: [dpdk-dev] [dpdk-stable] [PATCH] net/sfc: discard packets with bad CRC on EF10 ESSB Rx

2018-07-04 Thread Ferruh Yigit
On 6/29/2018 4:27 PM, Andrew Rybchenko wrote: > Fixes: 390f9b8d82c9 ("net/sfc: support equal stride super-buffer Rx mode") > Cc: sta...@dpdk.org > > Signed-off-by: Andrew Rybchenko > Reviewed-by: Ivan Malov Applied to dpdk-next-net/master, thanks.

Re: [dpdk-dev] [PATCH v4] net/pcap: rx_iface_in stream type support

2018-07-04 Thread Ferruh Yigit
On 7/3/2018 7:37 PM, Ferruh Yigit wrote: > On 7/1/2018 12:05 PM, ido goshen wrote: >> From: ido g >> >> Support rx of in direction packets only >> Useful for apps that also tx to eth_pcap ports in order to not see them >> echoed back in as rx when out direction is also captured >> >> Example: >> I

Re: [dpdk-dev] [dpdk-stable] [PATCH] net/sfc: cut non VLAN ID bits from TCI

2018-07-04 Thread Ferruh Yigit
On 6/29/2018 4:23 PM, Andrew Rybchenko wrote: > TCI may contain PCP or DEI bits. Matching of these bits is not > supported, but the bits still may be set in specification value and > not covered by mask. So, these bits should be ignored. > > Fixes: 894080975e1e ("net/sfc: support VLAN in flow API

Re: [dpdk-dev] [PATCH] ethdev: document xstats API assumption

2018-07-04 Thread Ferruh Yigit
On 6/29/2018 8:15 AM, David Marchand wrote: > On Thu, Jun 28, 2018 at 4:16 PM, Ferruh Yigit wrote: >> Documents the assumption that 'xstats[i].id == i' and >> key=xstats_names[i].name, value=xstats[i].value >> >> xstats[i].id is still used for xstats _by_id() APIs. >> >> This patch reverts some pa

Re: [dpdk-dev] [PATCH] net/thunderx: add support for Rx VLAN offload

2018-07-04 Thread Ferruh Yigit
On 7/1/2018 5:46 PM, Pavan Nikhilesh wrote: > From: "Kudurumalla, Rakesh" > > This feature is used to offload stripping of vlan header from recevied > packets and update vlan_tci field in mbuf when > DEV_RX_OFFLOAD_VLAN_STRIP & ETH_VLAN_STRIP_MASK flag is set. > > Signed-off-by: Rakesh Kudurumal

[dpdk-dev] [PATCH v3 09/10] net/mlx5: add parameter for port representors

2018-07-04 Thread Adrien Mazarguil
Prior to this patch, all port representors detected on a given device were probed and Ethernet devices instantiated for each of them. This patch adds support for the standard "representor" parameter, which implies that port representors are not probed by default anymore, except for the list provid

[dpdk-dev] [PATCH v3 10/10] net/mlx5: support negative identifiers for port representors

2018-07-04 Thread Adrien Mazarguil
This patch brings support for BlueField representors. Signed-off-by: Adrien Mazarguil Cc: Shahaf Shuler -- v3 changes: - This patch was not present in prior revisions. --- drivers/net/mlx5/mlx5.c | 8 1 file changed, 8 insertions(+) diff --git a/drivers/net/mlx5/mlx5.c b/drivers/net/

[dpdk-dev] [PATCH v3 08/10] net/mlx5: probe port representors in natural order

2018-07-04 Thread Adrien Mazarguil
Port representors are probed in whatever unspecified order ibv_get_device_list() returns them. This is counterintuitive to users since DPDK port IDs assignment almost never follows the same sequence as representor IDs. Additionally, the master device does not necessarily inherit the lowest DPDK po

[dpdk-dev] [PATCH v3 07/10] net/mlx5: probe all port representors

2018-07-04 Thread Adrien Mazarguil
Probe existing port representors in addition to their master device and associate them automatically. To avoid collision between Ethernet devices, they are named as follows: - "{DBDF}" for master/switch devices. - "{DBDF}_representor_{rep}" with "rep" starting from 0 for port representors. (Pa

[dpdk-dev] [PATCH v3 06/10] net/mlx5: add port representor awareness

2018-07-04 Thread Adrien Mazarguil
The current PCI probing method is not aware of Verbs port representors, which appear as standard Verbs devices bound to the same PCI address and cannot be distinguished. Problem is that more often than not, the wrong Verbs device is used, resulting in unexpected traffic. This patch makes the driv

[dpdk-dev] [PATCH v3 03/10] net/mlx5: drop useless support for several Verbs ports

2018-07-04 Thread Adrien Mazarguil
Unlike mlx4 from which this capability was inherited, mlx5 devices expose exactly one Verbs port per PCI bus address. Each physical port gets assigned its own bus address with a single Verbs port. While harmless, this code requires an extra loop that would get in the way of subsequent refactoring.

[dpdk-dev] [PATCH v3 02/10] net/mlx5: remove redundant objects in probe code

2018-07-04 Thread Adrien Mazarguil
This patch gets rid of redundant calls to open the device and query its attributes in order to simplify the code. Signed-off-by: Adrien Mazarguil Reviewed-by: Xueming Li -- v2 changes: - Minor indent fix on existing code. --- drivers/net/mlx5/mlx5.c | 64 +--

[dpdk-dev] [PATCH v3 04/10] net/mlx5: split PCI from generic probing code

2018-07-04 Thread Adrien Mazarguil
All the generic probing code needs is an IB device. While this device is currently supplied by a PCI lookup, other methods will be added soon. This patch divides the original function, which has become huge over time, as follows: 1. PCI-specific (mlx5_pci_probe()). 2. Verbs device (mlx5_dev_spawn

[dpdk-dev] [PATCH v3 05/10] net/mlx5: re-indent generic probing function

2018-07-04 Thread Adrien Mazarguil
Since commit "net/mlx5: drop useless support for several Verbs ports" removed an inner loop, mlx5_dev_spawn() is left with an unnecessary indent level. This patch eliminates a block, moves its local variables to function scope, and re-indents its contents (diff best viewed with --ignore-all-space)

[dpdk-dev] [PATCH v3 01/10] net/mlx5: rename confusing object in probe code

2018-07-04 Thread Adrien Mazarguil
There are several attribute objects in this function: - IB device attributes (struct ibv_device_attr_ex device_attr). - Direct Verbs attributes (struct mlx5dv_context attrs_out). - Port attributes (struct ibv_port_attr). - IB device attributes again (struct ibv_device_attr_ex device_attr_ex). "at

[dpdk-dev] [PATCH v3 00/10] net/mlx5: add port representor support

2018-07-04 Thread Adrien Mazarguil
This series adds support for port (VF) representors to the mlx5 PMD, which can be instantiated using the standard "representor" device parameter. Note the PMD only probes existing representors which exist as Verbs devices; their creation is part of the host system configuration. v3 changes: - Ad

[dpdk-dev] [PATCH v4 16/16] cryptodev: check if symmetric sessions are supported

2018-07-04 Thread Pablo de Lara
Since asymmetric functionality will be implemented soon, not all PMDs must support symmetric sessions. Therefore, a check is added if a device does not implement the symmetric functions, meaning that the device does not support symmetric operations. Signed-off-by: Pablo de Lara Acked-by: Akhil Go

[dpdk-dev] [PATCH v4 14/16] cryptodev: remove attach/detach session API

2018-07-04 Thread Pablo de Lara
As announced in the previous release, The API to attach/dettach a session to a queue pair is removed, as it was only used in DPAA, and it is not actually needed. Signed-off-by: Pablo de Lara Acked-by: Akhil Goyal --- doc/guides/rel_notes/deprecation.rst | 8 doc/guides/rel_notes

[dpdk-dev] [PATCH v4 15/16] cryptodev: rename PMD symmetric session API

2018-07-04 Thread Pablo de Lara
The PMD specific API to configure, clear and obtain session private size is renamed, including the word _sym_ to clarify that it is API for symmetric sessions, so there will not be any conflicts for asymmetric and other type of sessions in the future. Signed-off-by: Pablo de Lara Acked-by: Akhil

[dpdk-dev] [PATCH v4 11/16] cryptodev: remove queue start/stop functions

2018-07-04 Thread Pablo de Lara
Removed cryptodev queue start/stop functions, as they were marked deprecated in 18.05, since they were not implemented by any driver. Signed-off-by: Pablo de Lara Acked-by: Akhil Goyal --- doc/guides/rel_notes/deprecation.rst | 4 --- doc/guides/rel_notes/release_18_08.rst |

[dpdk-dev] [PATCH v4 12/16] cryptodev: remove old get session size functions

2018-07-04 Thread Pablo de Lara
Removed rte_cryptodev_get_header_session_size and rte_cryptodev_get_private_session_size functions, as they have been substituted with functions specific for symmetric operations, with _sym_ word after "rte_cryptodev_". Signed-off-by: Pablo de Lara Acked-by: Akhil Goyal --- doc/guides/rel_notes

[dpdk-dev] [PATCH v4 13/16] cryptodev: replace mbuf scatter gather flag

2018-07-04 Thread Pablo de Lara
The current mbuf scatter gatter feature flag is too ambiguous, as it is not clear if input and/or output buffers can be scatter gather mbufs or not, plus if in-place and/or out-of-place is supported. Therefore, five new flags will replace this flag: - RTE_CRYPTODEV_FF_IN_PLACE_SGL - RTE_CRYPTODEV_

[dpdk-dev] [PATCH v4 10/16] doc: remove unneeded deprecation notice

2018-07-04 Thread Pablo de Lara
In release 18.05, a deprecation notice to remove the `sym` structure in the cryptodev info structure was sent. However, only one of the fields inside the structure will be removed, so the notice is not actually correct. In any case, it needs to be removed. Signed-off-by: Pablo de Lara Acked-by: A

[dpdk-dev] [PATCH v4 09/16] cryptodev: remove max number of sessions parameter

2018-07-04 Thread Pablo de Lara
Most crypto PMDs do not have a limitation of the number of the sessions that can be handled internally. The value that was set before was not actually used at all, since the sessions are created at the application level. Therefore, this value is not parsed from the initial crypto parameters anymore

[dpdk-dev] [PATCH v4 06/16] examples/ipsec-secgw: check for max supported sessions

2018-07-04 Thread Pablo de Lara
Signed-off-by: Pablo de Lara Acked-by: Akhil Goyal --- examples/ipsec-secgw/ipsec-secgw.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/examples/ipsec-secgw/ipsec-secgw.c b/examples/ipsec-secgw/ipsec-secgw.c index a5da8b280..2582dcb6e 100644 --- a/examples/ipsec-secgw/ipsec-secgw.c

[dpdk-dev] [PATCH v4 07/16] crypto/mvsam: parse max number of sessions

2018-07-04 Thread Pablo de Lara
The maximum number of sessions device argument will be removed, as most PMDs do not have a limitation on this number. Therefore, the MVSAM PMD needs to parse this value internally. Signed-off-by: Pablo de Lara --- drivers/crypto/mvsam/rte_mrvl_pmd.c | 132 1

[dpdk-dev] [PATCH v4 08/16] cryptodev: define value for unlimited sessions

2018-07-04 Thread Pablo de Lara
Currently, the info structure contains the maximum number of sessions that a device can manage. This field was useful when the session mempool was created inside each device, but now it is created at the application level. Most PMDs do not have a limitation on the sessions managed, but a few do, t

[dpdk-dev] [PATCH v4 01/16] cryptodev: replace bus specific struct with generic dev

2018-07-04 Thread Pablo de Lara
Structure rte_cryptodev_info has currently PCI device information ("struct rte_pci_device") in it. This information is not generic to all devices, so this gets replaced with the generic "rte_device" structure, compatible with all crypto devices. Signed-off-by: Pablo de Lara Acked-by: Akhil Goyal

[dpdk-dev] [PATCH v4 02/16] cryptodev: remove max number of sessions per queue

2018-07-04 Thread Pablo de Lara
The cryptodev info structure currently contains the maximum number of sessions that can be used in a queue pair. This is only set in DPAA_SEC PMD, and since it is calculated based on the maximum number of sessions (which is not used anymore), this field can be removed. Signed-off-by: Pablo de Lara

[dpdk-dev] [PATCH v4 04/16] test/crypto: limit number of sessions

2018-07-04 Thread Pablo de Lara
Instead of using the maximum number of sessions allowed by the PMDs (which will change to unlimited most of the PMDs), limit the number to a small sufficient amount. Signed-off-by: Pablo de Lara Acked-by: Akhil Goyal --- test/test/test_cryptodev.c | 27 +-- 1 file change

[dpdk-dev] [PATCH v4 03/16] app/crypto-perf: limit number of sessions

2018-07-04 Thread Pablo de Lara
Instead of creating a fixed number of sessions, calculate the necessary number based on number of devices and queue pairs used. Signed-off-by: Pablo de Lara Acked-by: Akhil Goyal --- app/test-crypto-perf/main.c | 34 +++--- 1 file changed, 31 insertions(+), 3 deletio

[dpdk-dev] [PATCH v4 05/16] examples/l2fwd-crypto: limit number of sessions

2018-07-04 Thread Pablo de Lara
Calculate the number of sessions required for the application, knowing that there is only one session required per device. Signed-off-by: Pablo de Lara Acked-by: Akhil Goyal --- examples/l2fwd-crypto/main.c | 22 -- 1 file changed, 20 insertions(+), 2 deletions(-) diff --gi

[dpdk-dev] [PATCH v4 00/16] Cryptodev API changes

2018-07-04 Thread Pablo de Lara
API changes in the cryptodev library, announced in the previous release, 18.05. Changes in v4: - Fixed MVSAM max number of sessions (Tomasz Duszynksi) - Changed OUT_OF_PLACE to OOP in feature flags (Akhil Goyal) - Added missing feature flags in aesni_gcm and openssl PMDs (Akhil Goyal) - Removed

Re: [dpdk-dev] [PATCH v6 10/15] vhost: create descriptor mapping function

2018-07-04 Thread Maxime Coquelin
On 07/04/2018 07:56 AM, Tiwei Bie wrote: On Mon, Jul 02, 2018 at 10:16:24AM +0200, Maxime Coquelin wrote: Signed-off-by: Maxime Coquelin --- lib/librte_vhost/virtio_net.c | 61 ++- 1 file changed, 37 insertions(+), 24 deletions(-) diff --git a/lib/

Re: [dpdk-dev] [PATCH v6 11/15] vhost: add vector filling support for packed ring

2018-07-04 Thread Maxime Coquelin
On 07/04/2018 07:53 AM, Tiwei Bie wrote: On Mon, Jul 02, 2018 at 10:16:25AM +0200, Maxime Coquelin wrote: [...] +static __rte_always_inline int +fill_vec_buf_packed_indirect(struct virtio_net *dev, + struct vhost_virtqueue *vq, + struct vring_desc_p

[dpdk-dev] [PATCH] doc: update CRC feature with new offload flag

2018-07-04 Thread Ferruh Yigit
Fixes: 3d12dceed2df ("ethdev: add new offload flag to keep CRC") Signed-off-by: Ferruh Yigit --- doc/guides/nics/features.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/guides/nics/features.rst b/doc/guides/nics/features.rst index ee89d6bfa..6fe6aa559 100644 --- a/do

Re: [dpdk-dev] [PATCH v6 13/15] vhost: add Tx support for packed ring

2018-07-04 Thread Maxime Coquelin
On 07/04/2018 07:45 AM, Tiwei Bie wrote: On Mon, Jul 02, 2018 at 10:16:27AM +0200, Maxime Coquelin wrote: Signed-off-by: Maxime Coquelin --- lib/librte_vhost/vhost.h | 1 + lib/librte_vhost/virtio_net.c | 121 +- 2 files changed, 121 inserti

Re: [dpdk-dev] [PATCH v6 02/15] vhost: add helpers for packed virtqueues

2018-07-04 Thread Maxime Coquelin
On 07/04/2018 07:39 AM, Tiwei Bie wrote: On Mon, Jul 02, 2018 at 10:16:16AM +0200, Maxime Coquelin wrote: From: Jens Freimann Add some helper functions to check descriptor flags and check if a vring is of type packed. Signed-off-by: Jens Freimann Signed-off-by: Maxime Coquelin --- lib/

Re: [dpdk-dev] [PATCH v6 01/15] vhost: add virtio packed virtqueue defines

2018-07-04 Thread Maxime Coquelin
On 07/04/2018 07:37 AM, Tiwei Bie wrote: On Mon, Jul 02, 2018 at 10:16:15AM +0200, Maxime Coquelin wrote: From: Jens Freimann Signed-off-by: Jens Freimann --- lib/librte_vhost/vhost.h | 3 +++ lib/librte_vhost/virtio-packed.h | 22 ++ 2 files changed, 25 in

Re: [dpdk-dev] [PATCH v6 14/15] vhost: add notification for packed ring

2018-07-04 Thread Maxime Coquelin
On 07/03/2018 08:06 AM, Jason Wang wrote: On 2018年07月02日 16:16, Maxime Coquelin wrote: Signed-off-by: Maxime Coquelin ---   lib/librte_vhost/vhost.c | 73   lib/librte_vhost/vhost.h | 71 ++   lib

Re: [dpdk-dev] [PATCH v3 13/16] cryptodev: replace mbuf scatter gather flag

2018-07-04 Thread De Lara Guarch, Pablo
Hi Akhil, > -Original Message- > From: Akhil Goyal [mailto:akhil.go...@nxp.com] > Sent: Wednesday, July 4, 2018 1:57 PM > To: De Lara Guarch, Pablo ; Doherty, Declan > ; shally.ve...@caviumnetworks.com; > ravi1.ku...@amd.com; jerin.ja...@caviumnetworks.com; Zhang, Roy Fan > ; Trahe, Fiona

Re: [dpdk-dev] [PATCH v3] docs: add default that all fixes should be backported

2018-07-04 Thread Thomas Monjalon
30/06/2018 01:10, Kevin Traynor: > Set the starting point that all commits on master branch > with Fixes tag should be backported to relevant stable/LTS > branches, and explain that the submitter may indicate it is > not suitable for backport. > > Of course there will be exceptions that will crop

Re: [dpdk-dev] [PATCH v7 0/2] app/testpmd implement VXLAN/NVGRE Encap/Decap

2018-07-04 Thread Ferruh Yigit
On 7/2/2018 11:40 AM, Mohammad Abdul Awal wrote: > > On 27/06/2018 12:45, Nelio Laranjeiro wrote: >> This series adds an easy and maintainable configuration version support for >> those two actions for 18.08 by using global variables in testpmd to store the >> necessary information for the tunnel

[dpdk-dev] [PATCH v4] net/mlx4: support hardware TSO

2018-07-04 Thread Moti Haimovsky
Implement support for hardware TSO. Signed-off-by: Moti Haimovsky --- v4: * Bug fixes in filling TSO data segments. * Modifications according to review inputs from Adrien Mazarguil and Matan Azrad. in reply to 1530190137-17848-1-git-send-email-mo...@mellanox.com v3: * Fixed compilation errors

[dpdk-dev] [PATCH v1 2/3] app/crypto-perf: honour cryptodev's min headroom/tailroom

2018-07-04 Thread Anoob Joseph
Crypto dev would specify its headroom and tailroom requirement and the application is expected to honour this while creating buffers. Signed-off-by: Anoob Joseph --- v1: * Accomodated the name change of new fields app/test-crypto-perf/cperf_options.h | 2 ++ app/test-crypto-perf/cperf_test

[dpdk-dev] [PATCH v1 1/3] cryptodev: add min headroom and tailroom requirement

2018-07-04 Thread Anoob Joseph
Enabling crypto devs to specify the minimum headroom and tailroom it expects in the mbuf. For net PMDs, standard headroom has to be honoured by applications, which is not strictly followed for crypto devs. This prevents crypto devs from using free space in mbuf (available as head/tailroom) for inte

[dpdk-dev] [PATCH v1 3/3] test/crypto: skip validation of head/tailroom used by PMD

2018-07-04 Thread Anoob Joseph
Crypto PMDs would specify the head/tailroom it would use while processing the crypto requests. This need to be considered while verifying buffers processed by crypto PMDs. Signed-off-by: Anoob Joseph --- v1: * Added patch test/test/test_cryptodev_blockcipher.c | 60 +

[dpdk-dev] [PATCH v1 0/3] add head/tailroom requirement for crypto PMDs

2018-07-04 Thread Anoob Joseph
This series adds the ability, for crypto PMDs, to communicate the minimum head/tailroom requirement it may have, using the existing cryptodev_info framework. The availability and use of head/tailroom is an optimisation if the hardware supports its use for crypto-op info. Devices that do not suppor

Re: [dpdk-dev] [PATCH v2] net/mlx5: add support for 32bit systems

2018-07-04 Thread Ferruh Yigit
On 7/2/2018 12:11 PM, Moti Haimovsky wrote: > This patch adds support for building and running mlx5 PMD on > 32bit systems such as i686. > > The main issue to tackle was handling the 32bit access to the UAR > as quoted from the mlx5 PRM: > QP and CQ DoorBells require 64-bit writes. For best perfor

Re: [dpdk-dev] [PATCH] app/test-pmd: Fix buffer leak in tm cmdline

2018-07-04 Thread Singh, Jasvinder
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Nithin Dabilpuram > Sent: Wednesday, July 4, 2018 11:18 AM > To: Lu, Wenzhuo ; Wu, Jingjing > ; Iremonger, Bernard > > Cc: dev@dpdk.org; kka...@caviumnetworks.com; Nithin Dabilpuram > > Subject: [dpdk-dev] [PAT

Re: [dpdk-dev] [PATCH] security: change to SPDX license tags

2018-07-04 Thread Akhil Goyal
Acked-by: Akhil Goyal

  1   2   >