Re: [dpdk-dev] [PATCH v5 4/4] compressdev: add huffman encoding flags

>-Original Message- >From: Pablo de Lara [mailto:pablo.de.lara.gua...@intel.com] >Sent: 06 July 2018 10:58 >To: Verma, Shally ; Gupta, Ashish >; fiona.tr...@intel.com; >lee.d...@intel.com >Cc: dev@dpdk.org; Pablo de Lara >Subject: [PATCH v5 4/4] compressdev: add huffman encoding flags

Re: [dpdk-dev] [PATCH v5 3/4] compressdev: replace mbuf scatter gather flag

>-Original Message- >From: Pablo de Lara [mailto:pablo.de.lara.gua...@intel.com] >Sent: 06 July 2018 10:58 >To: Verma, Shally ; Gupta, Ashish >; fiona.tr...@intel.com; >lee.d...@intel.com >Cc: dev@dpdk.org; Pablo de Lara >Subject: [PATCH v5 3/4] compressdev: replace mbuf scatter gather

[dpdk-dev] [PATCH v3 5/8] hash: add read and write concurrency support

The existing implementation of librte_hash does not support read-write concurrency. This commit implements read-write safety using rte_rwlock and rte_rwlock TM version if hardware transactional memory is available. Both multi-writer and read-write concurrency is protected by rte_rwlock now. The x8

[dpdk-dev] [PATCH v3 7/8] test: add test case for read write concurrency

This commits add a new test case for testing read/write concurrency. Signed-off-by: Yipeng Wang --- test/test/Makefile | 1 + test/test/test_hash_readwrite.c | 646 2 files changed, 647 insertions(+) create mode 100644 test/test/test_hash_

[dpdk-dev] [PATCH v3 1/8] hash: fix multiwriter lock memory allocation

When malloc for multiwriter_lock, the align should be RTE_CACHE_LINE_SIZE rather than LCORE_CACHE_SIZE. Also there should be check to verify the success of rte_malloc. Fixes: be856325cba3 ("hash: add scalable multi-writer insertion with Intel TSX") Cc: sta...@dpdk.org Signed-off-by: Yipeng Wang

[dpdk-dev] [PATCH v3 6/8] test: add tests in hash table perf test

New code is added to support read-write concurrency for rte_hash. Due to the newly added code in critial path, the perf test is modified to show any performance impact. It is still a single-thread test. Signed-off-by: Yipeng Wang --- test/test/test_hash_perf.c | 36 +-

[dpdk-dev] [PATCH v3 4/8] hash: make duplicated code into functions

This commit refactors the hash table lookup/add/del code to remove some code duplication. Processing on primary bucket can also apply to secondary bucket with same code. Signed-off-by: Yipeng Wang --- lib/librte_hash/rte_cuckoo_hash.c | 186 +++--- 1 file changed,

[dpdk-dev] [PATCH v3 2/8] hash: fix a multi-writer bug

Current multi-writer implementation uses Intel TSX to protect the cuckoo path moving but not the cuckoo path searching. After searching, we need to verify again if the same empty slot still exists at the beginning of the TSX region. Otherwise another writer could occupy the empty slot before the TS

[dpdk-dev] [PATCH v3 8/8] hash: add new API function to query the key count

Add a new function, rte_hash_count, to return the number of keys that are currently stored in the hash table. Corresponding test functions are added into hash_test and hash_multiwriter test. Signed-off-by: Yipeng Wang --- lib/librte_hash/rte_cuckoo_hash.c| 24 lib/li

[dpdk-dev] [PATCH v3 3/8] hash: fix to have more accurate key slot size

This commit calculates the needed key slot size more accurately. The previous local cache fix requires the free slot ring to be larger than actually needed. The calculation of the value is inaccurate. Fixes: 5915699153d7 ("hash: fix scaling by reducing contention") Cc: sta...@dpdk.org Signed-off-

[dpdk-dev] [PATCH v3 0/8] Add read-write concurrency to rte_hash library

This patch set adds the read-write concurrency support in rte_hash. A new flag value is added to indicate if read-write concurrency is needed during creation time. Test cases are implemented to do functional and performance tests. The new concurrency model is based on rte_rwlock. When Intel TSX is

Re: [dpdk-dev] [PATCH v2 20/20] net/mlx5: add count flow action

On Wed, Jun 27, 2018 at 05:07:52PM +0200, Nelio Laranjeiro wrote: > This is only supported by Mellanox OFED. > > Signed-off-by: Nelio Laranjeiro > --- Acked-by: Yongseok Koh Thanks

Re: [dpdk-dev] [PATCH v2 19/20] net/mlx5: add flow MPLS item

On Wed, Jun 27, 2018 at 05:07:51PM +0200, Nelio Laranjeiro wrote: > Signed-off-by: Nelio Laranjeiro > --- > drivers/net/mlx5/mlx5_flow.c | 77 +++- > 1 file changed, 76 insertions(+), 1 deletion(-) > > diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/m

Re: [dpdk-dev] [PATCH v2 18/20] net/mlx5: add flow GRE item

On Wed, Jun 27, 2018 at 05:07:50PM +0200, Nelio Laranjeiro wrote: > Signed-off-by: Nelio Laranjeiro > --- > drivers/net/mlx5/mlx5_flow.c | 191 ++- > 1 file changed, 186 insertions(+), 5 deletions(-) > > diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5

Re: [dpdk-dev] [PATCH v2 17/20] net/mlx5: add flow VXLAN-GPE item

On Wed, Jun 27, 2018 at 05:07:49PM +0200, Nelio Laranjeiro wrote: > Signed-off-by: Nelio Laranjeiro > --- > drivers/net/mlx5/mlx5_flow.c | 123 ++- > 1 file changed, 120 insertions(+), 3 deletions(-) > > diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5

Re: [dpdk-dev] [PATCH v2 16/20] net/mlx5: add flow VXLAN item

On Wed, Jun 27, 2018 at 05:07:48PM +0200, Nelio Laranjeiro wrote: > Signed-off-by: Nelio Laranjeiro > --- Acked-by: Yongseok Koh Thanks

[dpdk-dev] [Bug 69] Intel x550 SFP+ fails to update link state

https://bugs.dpdk.org/show_bug.cgi?id=69 Bug ID: 69 Summary: Intel x550 SFP+ fails to update link state Product: DPDK Version: 18.05 Hardware: x86 OS: Linux Status: CONFIRMED Severity: normal Pri

[dpdk-dev] [PATCH] test: add unit tests for latencystats library

From: Jananee Parthasarathy Unit Test Cases added for latencystats library. Signed-off-by: Agalya Babu RadhaKrishnan Reviewed-by: Reshma Pattan --- test/test/Makefile| 3 + test/test/test_latencystats.c | 178 ++ 2 files changed, 181 inse

Re: [dpdk-dev] [PATCH v2 6/6] hash: add new API function to query the key count

> -Original Message- > From: Wang, Yipeng1 > Sent: Friday, June 29, 2018 1:25 PM > To: De Lara Guarch, Pablo > Cc: dev@dpdk.org; Wang, Yipeng1 ; Richardson, > Bruce ; honnappa.nagaraha...@arm.com; > vgu...@caviumnetworks.com; brijesh.s.si...@gmail.com > Subject: [PATCH v2 6/6] hash: add

Re: [dpdk-dev] [PATCH v2 13/20] net/mlx5: add RSS flow action

> On Jul 6, 2018, at 8:59 AM, Nélio Laranjeiro > wrote: > > Hi Yongseok, > > I am only addressing your questions concerns here, almost all other > points I also agree with them. > > On Thu, Jul 05, 2018 at 07:16:35PM -0700, Yongseok Koh wrote: >> On Wed, Jun 27, 2018 at 05:07:45PM +0200, Neli

Re: [dpdk-dev] [PATCH v5 00/23] net/softnic: refactoring

> -Original Message- > From: Singh, Jasvinder > Sent: Friday, July 6, 2018 6:21 PM > To: dev@dpdk.org > Cc: Dumitrescu, Cristian > Subject: [PATCH v5 00/23] net/softnic: refactoring > > This patch set modifies the Soft NIC device driver to use the Packet > Framework, which makes it muc

Re: [dpdk-dev] [PATCH v2 5/6] hash: fix to have more accurate key slot size

> -Original Message- > From: Wang, Yipeng1 > Sent: Friday, June 29, 2018 1:25 PM > To: De Lara Guarch, Pablo > Cc: dev@dpdk.org; Wang, Yipeng1 ; Richardson, > Bruce ; honnappa.nagaraha...@arm.com; > vgu...@caviumnetworks.com; brijesh.s.si...@gmail.com > Subject: [PATCH v2 5/6] hash: fix

Re: [dpdk-dev] [PATCH v2 4/6] test: add test case for read write concurrency

> -Original Message- > From: Wang, Yipeng1 > Sent: Friday, June 29, 2018 1:25 PM > To: De Lara Guarch, Pablo > Cc: dev@dpdk.org; Wang, Yipeng1 ; Richardson, > Bruce ; honnappa.nagaraha...@arm.com; > vgu...@caviumnetworks.com; brijesh.s.si...@gmail.com > Subject: [PATCH v2 4/6] test: add

[dpdk-dev] [PATCH v5 18/23] net/softnic: add cli for meter action

Add cli commands for meter action in softnic pipeline objects. Signed-off-by: Cristian Dumitrescu Signed-off-by: Jasvinder Singh --- drivers/net/softnic/rte_eth_softnic_cli.c | 418 drivers/net/softnic/rte_eth_softnic_internals.h | 29 ++ drivers/net/softnic/rte_

[dpdk-dev] [PATCH v5 22/23] net/softnic: add firmware script

Add default firmware script for softnic. Signed-off-by: Jasvinder Singh --- drivers/net/softnic/firmware.cli | 21 + 1 file changed, 21 insertions(+) create mode 100644 drivers/net/softnic/firmware.cli diff --git a/drivers/net/softnic/firmware.cli b/drivers/net/softnic/firm

[dpdk-dev] [PATCH v5 21/23] net/softnic: start and stop function

Implements softnic start and stop function. Signed-off-by: Cristian Dumitrescu Signed-off-by: Jasvinder Singh --- drivers/net/softnic/rte_eth_softnic.c | 49 - drivers/net/softnic/rte_eth_softnic_internals.h | 6 +++ drivers/net/softnic/rte_eth_softnic_pipelin

[dpdk-dev] [PATCH v5 17/23] net/softnic: add cli to read stats

Add cli commands to read port and table stats of softnic pipeline objects. Signed-off-by: Cristian Dumitrescu Signed-off-by: Jasvinder Singh --- drivers/net/softnic/rte_eth_softnic_cli.c | 288 +++ drivers/net/softnic/rte_eth_softnic_internals.h | 29 ++ drivers/net/softn

[dpdk-dev] [PATCH v5 19/23] net/softnic: add cli for ttl action

Add cli commands for ttl action in softnic pipeline objects. Signed-off-by: Cristian Dumitrescu Signed-off-by: Jasvinder Singh --- drivers/net/softnic/rte_eth_softnic_cli.c | 23 ++ drivers/net/softnic/rte_eth_softnic_internals.h | 8 +++ drivers/net/softnic/rte_eth_softnic_thread.c

[dpdk-dev] [PATCH v5 23/23] app/testpmd: rework softnic forward mode

Modied the testpmd softnic forwarding mode as per the changes in softnic PMD. To run testpmd application with softnic fwd mode, following command is used; $ ./testpmd -c 0xc -n 4 --vdev 'net_softnic0,firmware=script.cli' -- -i --forward-mode=softnic Signed-off-by: Jasvinder Singh Signed-off-b

[dpdk-dev] [PATCH v5 20/23] net/softnic: receive and transmit queue setup

Implements softnic receive and transmit queues setup using swq object. Signed-off-by: Cristian Dumitrescu Signed-off-by: Jasvinder Singh --- drivers/net/softnic/rte_eth_softnic.c | 62 ++- 1 file changed, 32 insertions(+), 30 deletions(-) diff --git a/drivers/ne

[dpdk-dev] [PATCH v5 16/23] net/softnic: add cli for pipeline table entries

Add cli commands for table entries in softnic pipeline objects. Signed-off-by: Cristian Dumitrescu Signed-off-by: Jasvinder Singh --- drivers/net/softnic/rte_eth_softnic_cli.c | 2187 --- drivers/net/softnic/rte_eth_softnic_internals.h | 35 + drivers/net/softnic/rte

[dpdk-dev] [PATCH v5 15/23] net/softnic: add cli to enable and disable pipeline

Add cli commands to enable and disable pipelines on specific threads in softnic. Signed-off-by: Cristian Dumitrescu Signed-off-by: Jasvinder Singh --- drivers/net/softnic/rte_eth_softnic_cli.c | 103 drivers/net/softnic/rte_eth_softnic_internals.h | 10 + drivers/net/softnic/rte

[dpdk-dev] [PATCH] test: add unit tests for bitrate library

From: Jananee Parthasarathy Unit Test Cases for BitRate library. Signed-off-by: Chaitanya Babu Talluri Reviewed-by: Reshma Pattan --- test/test/Makefile| 1 + test/test/autotest_data.py| 6 ++ test/test/test_bitratestats.c | 187 ++

[dpdk-dev] [PATCH v5 14/23] net/softnic: add cli to create softnic objects

Add cli commands to create softnic objects such as mempool, swq, pipeline, etc. Signed-off-by: Cristian Dumitrescu Signed-off-by: Jasvinder Singh --- drivers/net/softnic/rte_eth_softnic_cli.c | 1646 ++- drivers/net/softnic/rte_eth_softnic_internals.h | 85 ++ driver

[dpdk-dev] [PATCH v5 09/23] net/softnic: add pipeline object

Add pipeline object implementation to the softnic. Signed-off-by: Cristian Dumitrescu Signed-off-by: Jasvinder Singh --- drivers/net/softnic/Makefile| 3 +- drivers/net/softnic/meson.build | 5 +- drivers/net/softnic/rte_eth_softnic.c | 2 + d

[dpdk-dev] [PATCH v5 12/23] net/softnic: add cli interface

Add interface for softnic cli commands. Signed-off-by: Cristian Dumitrescu Signed-off-by: Jasvinder Singh --- drivers/net/softnic/Makefile| 2 + drivers/net/softnic/meson.build | 4 +- drivers/net/softnic/parser.c| 685

[dpdk-dev] [PATCH v5 10/23] net/softnic: add thread

Add thread data structure and init function to run softnic pipelines objects. Signed-off-by: Cristian Dumitrescu Signed-off-by: Jasvinder Singh --- drivers/net/softnic/Makefile| 1 + drivers/net/softnic/meson.build | 3 +- drivers/net/softnic/rte_eth_softni

[dpdk-dev] [PATCH v5 11/23] net/softnic: add softnic run API

Implements softnic API function to run pipeline objects. Signed-off-by: Cristian Dumitrescu Signed-off-by: Jasvinder Singh --- drivers/net/softnic/rte_eth_softnic.c| 13 -- drivers/net/softnic/rte_eth_softnic_thread.c | 195 +++ 2 files changed, 195 insertions(+

[dpdk-dev] [PATCH v5 13/23] net/softnic: add connection agent

Add connection agent to enable connectivity with external agen (e.g. telnet, netcat, Python script, etc). Signed-off-by: Cristian Dumitrescu Signed-off-by: Jasvinder Singh --- config/common_base | 2 +- config/common_linuxapp | 1 +

[dpdk-dev] [PATCH v5 04/23] net/softnic: add mempool object

Add mempool object implementation to the softnic. Signed-off-by: Cristian Dumitrescu Signed-off-by: Jasvinder Singh --- drivers/net/softnic/Makefile| 1 + drivers/net/softnic/meson.build | 1 + drivers/net/softnic/rte_eth_softnic.c | 2 + driv

[dpdk-dev] [PATCH v5 07/23] net/softnic: add port action profile

Add pipeline's port action profile implementation to the softnic. Signed-off-by: Cristian Dumitrescu Signed-off-by: Jasvinder Singh --- drivers/net/softnic/Makefile| 3 + drivers/net/softnic/hash_func.h | 359 drivers/net/softnic/ha

[dpdk-dev] [PATCH v5 05/23] net/softnic: add tap object

Add tap object implementation to the softnic. Signed-off-by: Cristian Dumitrescu Signed-off-by: Jasvinder Singh --- drivers/net/softnic/Makefile| 1 + drivers/net/softnic/meson.build | 3 +- drivers/net/softnic/rte_eth_softnic.c | 2 + drivers

[dpdk-dev] [PATCH v5 06/23] net/softnic: add traffic manager object

Add traffic manager(tmgr) object to the softnic. Signed-off-by: Cristian Dumitrescu Signed-off-by: Jasvinder Singh --- drivers/net/softnic/rte_eth_softnic.c | 70 +++- drivers/net/softnic/rte_eth_softnic.h | 11 ++- drivers/net/softnic/rte_eth_softnic_internals

[dpdk-dev] [PATCH v5 02/23] net/softnic: add software queue object

Add swq object implementation to the softnic. Signed-off-by: Cristian Dumitrescu Signed-off-by: Jasvinder Singh --- drivers/net/softnic/Makefile| 1 + drivers/net/softnic/meson.build | 3 +- drivers/net/softnic/rte_eth_softnic.c | 7 ++ drivers/n

[dpdk-dev] [PATCH v5 03/23] net/softnic: add link object

Add link object implementation to the softnic. Signed-off-by: Cristian Dumitrescu Signed-off-by: Jasvinder Singh --- drivers/net/softnic/Makefile| 1 + drivers/net/softnic/meson.build | 3 +- drivers/net/softnic/rte_eth_softnic.c | 4 + drivers/n

[dpdk-dev] [PATCH v5 08/23] net/softnic: add table action profile

Add pipeline's table action profile implementation to the softnic. Signed-off-by: Cristian Dumitrescu Signed-off-by: Jasvinder Singh --- drivers/net/softnic/rte_eth_softnic.c | 2 + drivers/net/softnic/rte_eth_softnic_action.c| 227 drivers/net/softnic/r

[dpdk-dev] [PATCH v5 01/23] net/softnic: restructuring

Rework the softnic implementation to have flexiblity in enabling more features to its receive and transmit data path. Signed-off-by: Cristian Dumitrescu Signed-off-by: Jasvinder Singh --- drivers/net/softnic/rte_eth_softnic.c | 607 drivers/net/softnic/rte_eth

[dpdk-dev] [PATCH v5 00/23] net/softnic: refactoring

This patch set modifies the Soft NIC device driver to use the Packet Framework, which makes it much more modular, flexible and extensible with new functionality. * The Soft NIC allows building custom NIC pipelines in SW. The Soft NIC pipeline is DIY and reconfigurable through "firmware" (DPDK Pa

Re: [dpdk-dev] [PATCH v2 3/6] test: add tests in hash table perf test

> -Original Message- > From: Wang, Yipeng1 > Sent: Friday, June 29, 2018 1:25 PM > To: De Lara Guarch, Pablo > Cc: dev@dpdk.org; Wang, Yipeng1 ; Richardson, > Bruce ; honnappa.nagaraha...@arm.com; > vgu...@caviumnetworks.com; brijesh.s.si...@gmail.com > Subject: [PATCH v2 3/6] test: add

Re: [dpdk-dev] [PATCH v2 2/6] hash: add read and write concurrency support

> -Original Message- > From: Wang, Yipeng1 > Sent: Friday, June 29, 2018 1:25 PM > To: De Lara Guarch, Pablo > Cc: dev@dpdk.org; Wang, Yipeng1 ; Richardson, > Bruce ; honnappa.nagaraha...@arm.com; > vgu...@caviumnetworks.com; brijesh.s.si...@gmail.com > Subject: [PATCH v2 2/6] hash: add

[dpdk-dev] [PATCH] add sample functions for packet forwarding

From: Jananee Parthasarathy Add sample test functions for packet forwarding. These can be used for unit test cases for LatencyStats and BitrateStats libraries. Signed-off-by: Chaitanya Babu Talluri Reviewed-by: Reshma Pattan --- test/test/Makefile| 1 + test/test/sample_pack

Re: [dpdk-dev] [PATCH v2] librte_lpm: Improve performance of the delete and add functions

Please see inline replies > On Mon, Jul 02, 2018 at 07:42:11PM +0300, Alex Kiselev wrote: >> There are two major problems with the library: >> first, there is no need to rebuild the whole LPM tree >> when a rule is deleted and second, due to the current >> rules algorithm with complexity O(n) it's

Re: [dpdk-dev] [PATCH v2] librte_lpm: Improve performance of the delete and add functions

On Mon, Jul 02, 2018 at 07:42:11PM +0300, Alex Kiselev wrote: > There are two major problems with the library: > first, there is no need to rebuild the whole LPM tree > when a rule is deleted and second, due to the current > rules algorithm with complexity O(n) it's almost > impossible to deal with

Re: [dpdk-dev] [PATCH v2 13/20] net/mlx5: add RSS flow action

Hi Yongseok, I am only addressing your questions concerns here, almost all other points I also agree with them. On Thu, Jul 05, 2018 at 07:16:35PM -0700, Yongseok Koh wrote: > On Wed, Jun 27, 2018 at 05:07:45PM +0200, Nelio Laranjeiro wrote: > > Signed-off-by: Nelio Laranjeiro > > --- >[...] >

Re: [dpdk-dev] [PATCH V5 6/7] eal: add failure handle mechanism for hotplug

> -Original Message- > From: Guo, Jia > Sent: Thursday, July 5, 2018 3:39 PM > > This patch introduces a failure handler mechanism to handle device > hot plug removal event. > > First register sigbus handler, once sigbus error be captured, will > check the failure address and accordingl

Re: [dpdk-dev] [PATCH V5 5/7] bus: add helper to handle sigbus

> -Original Message- > From: Guo, Jia > Sent: Thursday, July 5, 2018 3:39 PM > > This patch aim to add a helper to iterate all buses to find the > corresponding bus to handle the sigbus error. > [...] > + bus = rte_bus_find(NULL, bus_handle_sigbus, failure_addr); > + /* failed

Re: [dpdk-dev] [PATCH V5 4/7] bus/pci: implement sigbus handler operation

> -Original Message- > From: Guo, Jia > Sent: Thursday, July 5, 2018 3:39 PM > > This patch implements the ops of sigbus handler for PCI bus, it is > functional to find the corresponding pci device which is be hotplug out. " which is been hotplug out "? > and then handle the hotplug fa

Re: [dpdk-dev] [PATCH V5 3/7] bus: add sigbus handler

> -Original Message- > From: Guo, Jia > > When device be hotplug out, if data path still read/write device, the > sigbus error will occur, this error need to be handled. So a handler > need to be here to capture the signal and handle it correspondingly. > > This patch introduces a bus o

Re: [dpdk-dev] [PATCH V5 2/7] bus/pci: implement hotplug failure handler ops

> -Original Message- > From: Guo, Jia > Sent: Thursday, July 5, 2018 3:39 PM > [...] > + switch (pdev->kdrv) { > + case RTE_KDRV_IGB_UIO: > + case RTE_KDRV_UIO_GENERIC: > + case RTE_KDRV_NIC_UIO: > + /* mmio resources is invalid, remap it to be safe. */ Bette

Re: [dpdk-dev] [PATCH V5 1/7] bus: add hotplug failure handler

> -Original Message- > From: Guo, Jia > Sent: Thursday, July 5, 2018 3:39 PM > > When device be hotplug out, if app still continue to access device by mmio, > it will cause of memory failure and result the system crash. > > This patch introduces a bus ops to handle device hotplug failur

[dpdk-dev] [PATCH] net/cxgbe: update release notes for flow API support

Signed-off-by: Rahul Lakkireddy --- doc/guides/nics/cxgbe.rst | 2 +- doc/guides/rel_notes/release_18_08.rst | 5 - 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/doc/guides/nics/cxgbe.rst b/doc/guides/nics/cxgbe.rst index 124022cfc..58d88eef5 100644 --- a/doc/gui

Re: [dpdk-dev] [PATCH v4 1/4] lib/cryptodev: add asymmetric algos in cryptodev

Hi Declan >-Original Message- >From: Doherty, Declan [mailto:declan.dohe...@intel.com] >Sent: 05 July 2018 20:24 >To: Verma, Shally ; pablo.de.lara.gua...@intel.com >Cc: dev@dpdk.org; Athreya, Narayana Prasad >; Murthy, Nidadavolu >; Sahu, Sunila ; Gupta, >Ashish ; Kartha, >Umesh >Subje

[dpdk-dev] [PATCH v9 19/19] doc: update release notes for multi process hotplug

Update release notes for the new multi-process hotplug feature. Signed-off-by: Qi Zhang --- doc/guides/rel_notes/release_18_08.rst | 11 +++ 1 file changed, 11 insertions(+) diff --git a/doc/guides/rel_notes/release_18_08.rst b/doc/guides/rel_notes/release_18_08.rst index bc0124295..12

[dpdk-dev] [PATCH v9 18/19] examples/multi_process: add hotplug sample

The sample code demonstrates device (ethdev only) management at a multi-process environment. The user can attach/detach a device on primary process and see it is synced on secondary process automatically. How to start? ./hotplug_mp --proc-type=auto Command Line Example: >help >list /* attach a

[dpdk-dev] [PATCH v9 16/19] net/tap: enable port detach on secondary process

Previously, detach port on a secondary process will mess primary process and cause the same device can't be attached back again. A secondary process should use rte_eth_release_port_private to release a port. Signed-off-by: Qi Zhang Acked-by: Keith Wiles --- drivers/net/tap/rte_eth_tap.c | 17 ++

[dpdk-dev] [PATCH v9 17/19] net/vhost: enable port detach on secondary process

Previously, detach port on a secondary process will mess primary process and cause the same device can't be attached back again. A secondary process should use rte_eth_release_port_private to release a port. Signed-off-by: Qi Zhang --- drivers/net/vhost/rte_eth_vhost.c | 11 +++ 1 file c

[dpdk-dev] [PATCH v9 15/19] net/softnic: enable port detach on secondary process

Previously, detach port on a secondary process will mess primary process and cause the same device can't be attached back again. A secondary process should use rte_eth_release_port_private to release a port. Signed-off-by: Qi Zhang --- drivers/net/softnic/rte_eth_softnic.c | 19 -

[dpdk-dev] [PATCH v9 10/19] net/bonding: enable port detach on secondary process

Previously, detach port on a secondary process will mess primary process and cause the same device can't be attached back again. A secondary process should use rte_eth_release_port_private to release a port. Signed-off-by: Qi Zhang --- drivers/net/bonding/rte_eth_bond_pmd.c | 11 +++ 1 f

[dpdk-dev] [PATCH v9 14/19] net/pcap: enable port detach on secondary process

Previously, detach port on a secondary process will mess primary process and cause the same device can't be attached back again. A secondary process should use rte_eth_release_port_private to release a port. Signed-off-by: Qi Zhang --- drivers/net/pcap/rte_eth_pcap.c | 15 ++- 1 file

[dpdk-dev] [PATCH v9 13/19] net/octeontx: enable port detach on secondary process

Previously, detach port on a secondary process will mess primary process and cause the same device can't be attached back again. A secondary process should use rte_eth_release_port_private to release a port. Signed-off-by: Qi Zhang --- drivers/net/octeontx/octeontx_ethdev.c | 16

[dpdk-dev] [PATCH v9 06/19] eal: support attach or detach share device from secondary

This patch cover the multi-process hotplug case when a device attach/detach request be issued from a secondary process device attach on secondary: a) secondary send sync request to the primary. b) primary receive the request and attach the new device if failed goto i). c) primary forward attach

[dpdk-dev] [PATCH v9 12/19] net/null: enable port detach on secondary process

Previously, detach port on a secondary process will mess primary process and cause the same device can't be attached back again. A secondary process should use rte_eth_release_port_private to release a port. Signed-off-by: Qi Zhang --- drivers/net/null/rte_eth_null.c | 16 +++- 1 fil

[dpdk-dev] [PATCH v9 11/19] net/kni: enable port detach on secondary process

Previously, detach port on a secondary process will mess primary process and cause the same device can't be attached back again. A secondary process should use rte_eth_release_port_private to release a port. Signed-off-by: Qi Zhang --- drivers/net/kni/rte_eth_kni.c | 11 +++ 1 file chang

[dpdk-dev] [PATCH v9 01/19] ethdev: add function to release port in local process

Add driver API rte_eth_release_port_private to support the case when an ethdev need to be detached on a secondary process. Local state is set to unused and shared data will not be reset so the primary process can still use it. Signed-off-by: Qi Zhang Reviewed-by: Andrew Rybchenko Acked-by: Remy

[dpdk-dev] [PATCH v9 03/19] bus/pci: enable vfio unmap resource for secondary

Subroutine to unmap VFIO resource is shared by secondary and primary, and it does not work on the secondary process. The patch adds a dedicate function to handle the situation when a device is unmapped on a secondary process. Signed-off-by: Qi Zhang --- drivers/bus/pci/linux/pci_vfio.c | 75

[dpdk-dev] [PATCH v9 05/19] eal: enable hotplug on multi-process

We are going to introduce the solution to handle hotplug in multi-process, it includes the below scenario: 1. Attach a device from the primary 2. Detach a device from the primary 3. Attach a device from a secondary 4. Detach a device from a secondary In the primary-secondary process model, we ass

[dpdk-dev] [PATCH v9 07/19] net/i40e: enable port detach on secondary process

Previously, detach port on a secondary process will mess primary process and cause the same device can't be attached back again. A secondary process should use rte_eth_release_port_private to release a port. Signed-off-by: Qi Zhang --- drivers/net/i40e/i40e_ethdev.c | 2 ++ 1 file changed, 2 ins

[dpdk-dev] [PATCH v9 04/19] vfio: remove uneccessary IPC for group fd clear

Clear vfio_group_fd is not necessary to involve any IPC. Also, current IPC implementation for SOCKET_CLR_GROUP is not correct. rte_vfio_clear_group on secondary will always fail, that prevent device be detached correctly on a secondary process. The patch simply removes all IPC related stuff in rte_

[dpdk-dev] [PATCH v9 08/19] net/ixgbe: enable port detach on secondary process

Previously, detach port on a secondary process will mess primary process and cause the same device can't be attached back again. A secondary process should use rte_eth_release_port_private to release a port. Signed-off-by: Qi Zhang --- drivers/net/ixgbe/ixgbe_ethdev.c | 3 +++ 1 file changed, 3

[dpdk-dev] [PATCH v9 02/19] bus/pci: fix PCI address compare

When use memcmp to compare two PCI address, sizeof(struct rte_pci_addr) is 4 bytes aligned, and it is 8. While only 7 byte of struct rte_pci_addr is valid. So compare the 8th byte will cause the unexpected result, which happens when repeatedly attach/detach a device. Fixes: c752998b5e2e ("pci: int

[dpdk-dev] [PATCH v9 09/19] net/af_packet: enable port detach on secondary process

Previously, detach port on a secondary process will mess primary process and cause the same device can't be attached back again. A secondary process should use rte_eth_release_port_private to release a port. Signed-off-by: Qi Zhang --- drivers/net/af_packet/rte_eth_af_packet.c | 11 +++

[dpdk-dev] [PATCH v9 00/19] enable hotplug on multi-process

v9: - Move hotplug IPC from rte_eth_dev_attach/rte_eth_dev_detach to eal_dev_hotplug_add and eal_dev_hotplug_remove, now all kinds of devices will be synced in multi-process. - Fix couple issue when a device is bound to vfio. 1) The device can't be detached clearly in a secondary process, whi

Re: [dpdk-dev] [PATCH v4 2/4] cryptodev: support asymmetric operations

Hi Shally > Ya . right now they were there for consistency. You prefer to remove them? Yes.

Re: [dpdk-dev] [PATCH v4 2/4] cryptodev: support asymmetric operations

Hi Fiona >-Original Message- >From: Trahe, Fiona [mailto:fiona.tr...@intel.com] >Sent: 06 July 2018 19:11 >To: Verma, Shally ; De Lara Guarch, Pablo > >Cc: dev@dpdk.org; Athreya, Narayana Prasad >; Murthy, Nidadavolu >; Kartha, Umesh ; Sahu, >Sunila ; Gupta, >Ashish ; Trahe, Fiona >Sub

Re: [dpdk-dev] [PATCH v4 2/4] cryptodev: support asymmetric operations

Hi Shally, Umesh, > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Shally Verma > Sent: Tuesday, July 3, 2018 4:24 PM > To: De Lara Guarch, Pablo > Cc: dev@dpdk.org; pathr...@caviumnetworks.com; nmur...@caviumnetworks.com; > Umesh Kartha > ; Sunila Sahu > ; As

[dpdk-dev] [PATCH] cryptodev: rename experimental private data APIs

The name private_data is confusing in these APIs: rte_cryptodev_sym_session_set_private_data() rte_cryptodev_sym_session_get_private_data() It refers to data added at the end of the session hdr for use by the application. The session already contains sess_private_data[index] which is used to store

[dpdk-dev] [PATCH v5 3/4] compressdev: replace mbuf scatter gather flag

The current mbuf scatter gather feature flag is too ambiguous, as it is not clear if input and/or output buffers can be scatter gather mbufs or not. Therefore, three new flags will replace this flag: - RTE_COMP_FF_OOP_SGL_IN_SGL_OUT - RTE_COMP_FF_OOP_SGL_IN_FB_OUT - RTE_COMP_FF_OOP_LB_IN_SGL_OUT

[dpdk-dev] [PATCH v5 2/4] doc: rename compress feature flag

Renamed feature "Bypass" to "Pass-through", as it is a more explicit name, meaning that the PMD is capable of passing the mbufs through it, without making any modifications (i.e.. NULL algorithm). Signed-off-by: Pablo de Lara Acked-by: Fiona Trahe Acked-by: Shally Verma --- v5: - No change v4

[dpdk-dev] [PATCH v5 4/4] compressdev: add huffman encoding flags

Added Huffman fixed and dynamic encoding feature flags, so an application can query if a device supports these two types, when performing DEFLATE compression. Signed-off-by: Pablo de Lara Acked-by: Fiona Trahe --- v5-v3: - No change v2: - Fixed typo drivers/compress/isal/isal_compress_pmd_op

[dpdk-dev] [PATCH v5 1/4] doc: cleanup ISA-L PMD feature matrix

In PMD feature matrices (.ini files), it is not required to have the list of features that are not supported, just the ones that are. Signed-off-by: Pablo de Lara Acked-by: Lee Daly --- v5: - Removed "HW Accelerated" from isa-l feature list v4: - No change doc/guides/compressdevs/features/is

[dpdk-dev] [PATCH v1] lib/metrics: add check for invalid metric keys

This patchset adds a check to rte_metrics_update_values() that prevents the updating of metrics when presented with an invalid metric key. Previously, doing the latter could result in a crash. Fixes: 349950ddb9c5 ("metrics: add information metrics library") Signed-off-by: Remy Horton --- lib/li

[dpdk-dev] [RFC 03/11] malloc: index heaps using heap ID rather than NUMA node

Switch over all parts of EAL to use heap ID instead of NUMA node ID to identify heaps. Heap ID for DPDK-internal heaps is NUMA node's index within the detected NUMA node list. Signed-off-by: Anatoly Burakov --- config/common_base| 1 + lib/librte_eal/common/eal_commo

[dpdk-dev] [RFC 11/11] memzone: enable reserving memory from named heaps

Add ability to allocate memory for memzones from named heaps. The semantics are kept similar to regular allocations, and as much of the code as possible is shared. Signed-off-by: Anatoly Burakov --- lib/librte_eal/common/eal_common_memzone.c | 237 +++- lib/librte_eal/common/inc

[dpdk-dev] [RFC 10/11] malloc: allow destroying heaps

Add an API to destroy specified heap. Any memory regions still contained within the heap will be removed first. Signed-off-by: Anatoly Burakov --- lib/librte_eal/common/include/rte_malloc.h | 21 lib/librte_eal/common/malloc_heap.c| 29 ++ lib/librte_

[dpdk-dev] [RFC 05/11] malloc: enable retrieving statistics from named heaps

Add internal functions to look up heap by name, and enable dumping statistics for a specified named heap. Signed-off-by: Anatoly Burakov --- lib/librte_eal/common/include/rte_malloc.h | 19 +++-- lib/librte_eal/common/malloc_heap.c| 31 ++ lib/librte_eal/commo

[dpdk-dev] [RFC 06/11] malloc: enable allocating from named heaps

Add new malloc API to allocate memory from heap referenced to by specified name. Signed-off-by: Anatoly Burakov --- lib/librte_eal/common/include/rte_malloc.h | 25 ++ lib/librte_eal/common/malloc_heap.c| 2 +- lib/librte_eal/common/malloc_heap.h| 6 ++

[dpdk-dev] [RFC 08/11] malloc: allow adding memory to named heaps

Add an API to add externally allocated memory to malloc heap. The memory will be stored in memseg lists like regular DPDK memory. Multiple segments are allowed within a heap. If IOVA table is not provided, IOVA addresses are filled in with RTE_BAD_IOVA. Signed-off-by: Anatoly Burakov --- lib/lib

[dpdk-dev] [RFC 07/11] malloc: enable creating new malloc heaps

Add API to allow creating new malloc heaps. They will be created with indexes higher than heaps reserved for NUMA sockets, and up to RTE_MAX_HEAPS. Signed-off-by: Anatoly Burakov --- lib/librte_eal/common/include/rte_malloc.h | 21 ++ lib/librte_eal/common/malloc_heap.c| 16 +

[dpdk-dev] [RFC 04/11] malloc: add name to malloc heaps

We will need to refer to external heaps in some way. While we use heap ID's internally, for external API use it has to be something more user-friendly. So, we will be using a string to uniquely identify a heap. Signed-off-by: Anatoly Burakov --- lib/librte_eal/common/include/rte_malloc_heap.h |

[dpdk-dev] [RFC 01/11] mem: allow memseg lists to be marked as external

When we allocate and use DPDK memory, we need to be able to differentiate between DPDK hugepage segments and segments that were made part of DPDK but are externally allocated. Add such a property to memseg lists. Signed-off-by: Anatoly Burakov --- lib/librte_eal/common/eal_common_memory.c |

  1   2   >