Re: [dpdk-dev] [PATCH] net/mlx5: fix possible endless loop when clearing flow flags

On Tue, Jul 24, 2018 at 09:47:19PM +, Yongseok Koh wrote: > > > On Jul 23, 2018, at 11:57 PM, Nélio Laranjeiro > > wrote: > > > > On Mon, Jul 23, 2018 at 11:27:44AM -0700, Yongseok Koh wrote: > >> If one of (*priv->rxqs)[] is null, the for loop can iterate infinitely as > >> idx can't be in

Re: [dpdk-dev] Accessing "device_id" from "rte_pci_device"

Hi Santhos. >There is no member named "device" in "rte_eth_dev_info" struct. I looked at >both 17.11 API >documentation >and 18.05 API >documentation. This is not accura

Re: [dpdk-dev] [PATCH] mk: fix application compilation with lmnl and mlx5

Tuesday, July 24, 2018 6:14 PM, Adrien Mazarguil: > Subject: Re: [PATCH] mk: fix application compilation with lmnl and mlx5 > On Tue, Jul 24, 2018 at 01:03:28PM +, Shahaf Shuler wrote: > > Tuesday, July 24, 2018 3:56 PM, Adrien Mazarguil: > > > Subject: Re: [PATCH] mk: fix application compilati

Re: [dpdk-dev] [PATCH v3] examples/vhost: workaround qemu abort

On Wed, Jul 25, 2018 at 06:25:56PM +0800, Marvin Liu wrote: > Current qemu vhost net ring start has a dependency on feature bit > VHOST_USER_F_PROTOCOL_FEATURES. Without this feature, vhost ring can't > enabled and ioevent fd won't be deleted after vhost device stop. That > will cause qemu abort wh

[dpdk-dev] [PATCH] net/i40e: fix multiple device arguments parsing error

There will be parsing error when using multiple device arguments. This patch fixes the issue Fixes: cfdfca493cae ("net/i40e: fix multiple driver support") Fixes: ee653bd80044 ("net/i40e: determine number of queues per VF at run time") Cc: sta...@dpdk.org Signed-off-by: Beilei Xing --- drivers/n

Re: [dpdk-dev] [PATCH v2] net/ixgbe: fix link status when link is NACK

Hi Yanglang: > -Original Message- > From: Wu, Yanglong > Sent: Tuesday, July 24, 2018 3:31 PM > To: dev@dpdk.org > Cc: Zhang, Qi Z ; Wang, Dong1 > ; Wu, Yanglong > Subject: [PATCH v2] net/ixgbe: fix link status when link is NACK > > Link status should be set as down when link is NACK. >

[dpdk-dev] [PATCH v4] doc: add i40e recommended matching list

Add suggested DPDK/kernel driver/firmware version matching list for i40e. Signed-off-by: Xiaoyun Li Acked-by: Beilei Xing --- doc/guides/nics/i40e.rst | 30 ++ 1 file changed, 30 insertions(+) --- v4: * Add statement that the detail can refer to the release notes. v3

Re: [dpdk-dev] [PATCH] app/testpmd: fix commands to config some offload

-Original Message- From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Wei Dai Sent: Tuesday, July 24, 2018 11:45 AM To: Wu, Jingjing ; Lu, Wenzhuo ; dev@dpdk.org Cc: Dai, Wei ; sta...@dpdk.org Subject: [dpdk-dev] [PATCH] app/testpmd: fix commands to config some offload Without this p

Re: [dpdk-dev] [PATCH v2] examples/vhost: workaround qemu abort

> -Original Message- > From: Bie, Tiwei > Sent: Wednesday, July 25, 2018 10:19 AM > To: Liu, Yong > Cc: dev@dpdk.org > Subject: Re: [PATCH v2] examples/vhost: workaround qemu abort > > On Wed, Jul 25, 2018 at 05:56:54PM +0800, Marvin Liu wrote: > > Current qemu vhost net ring start has

[dpdk-dev] [PATCH v3] examples/vhost: workaround qemu abort

Current qemu vhost net ring start has a dependency on feature bit VHOST_USER_F_PROTOCOL_FEATURES. Without this feature, vhost ring can't enabled and ioevent fd won't be deleted after vhost device stop. That will cause qemu abort when reloading driver. Work around qemu issues by enabling feature bit

Re: [dpdk-dev] [PATCH v2] examples/vhost: workaround qemu abort

On Wed, Jul 25, 2018 at 05:56:54PM +0800, Marvin Liu wrote: > Current qemu vhost net ring start has a dependency on feature bit > VHOST_USER_F_PROTOCOL_FEATURES. If vhost device start without it, stop > action will be skipped. Consequently, same ioevent fd will be added > twice after reloading driv

[dpdk-dev] [PATCH v2] examples/vhost: workaround qemu abort

Current qemu vhost net ring start has a dependency on feature bit VHOST_USER_F_PROTOCOL_FEATURES. If vhost device start without it, stop action will be skipped. Consequently, same ioevent fd will be added twice after reloading driver and then cause qemu abort. However, ring should be initialized in

Re: [dpdk-dev] [PATCH] examples/vhost: fix qemu abort

On Tue, Jul 24, 2018 at 11:16:49PM +0800, Marvin Liu wrote: > When start vhost sample with builtin-net-driver argument, vhost feature > bit will be zero. If VHOST_USER_F_PROTOCOL_FEATURES is not set, vhost > net start will be failed in qemu. This occasion will cause device stop > action was skipped

[dpdk-dev] [PATCH 1/2] net/bnx2x: fix to poll link status

The PMD has been modified to invoke the polling function in the link management code which detects the peer speed/mode, configure the link and update the status accordingly. This patch is the fix for the link down issue seen when we do dev_stop() and dev_start() from an application. Fixes: 540a211

[dpdk-dev] [PATCH 2/2] net/bnx2x: bump PMD version to 1.0.6.1

Signed-off-by: Rasesh Mody --- drivers/net/bnx2x/bnx2x.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/bnx2x/bnx2x.c b/drivers/net/bnx2x/bnx2x.c index 4bb3343..a3304c6 100644 --- a/drivers/net/bnx2x/bnx2x.c +++ b/drivers/net/bnx2x/bnx2x.c @@ -31,7 +31,7 @@ #d

[dpdk-dev] [PATCH 1/4] net/qede: fix handler in interrupt callback unregister

From: Shahed Shaikh Commit 023d7a0449f11 ("net/qede: fix legacy interrupt mode") added a handler for legacy interrupt mode but forgot to unregister same handler in rte_intr_callback_unregister() Fixes: 245aec289338 ("net/qede: fix legacy interrupt mode") Signed-off-by: Shahed Shaikh --- drive

[dpdk-dev] [PATCH 4/4] net/qede: fix MAC address removal failure message

From: Shahed Shaikh Don't treat MAC address removal failure as a fatal error and print in logs. Fixes: 77fac1b54fc9 ("net/qede: fix filtering code") Cc: sta...@dpdk.org Signed-off-by: Shahed Shaikh --- drivers/net/qede/qede_ethdev.c |5 - 1 file changed, 4 insertions(+), 1 deletion(-)

[dpdk-dev] [PATCH 2/4] net/qede/base: fix to clear HW indication

VDMs may cause the was_error indication to be set after the driver clears it. Clear the indication after the internal FID_enable for the PF is set. Fixes: 60c78a5e258a ("net/qede/base: fix recovery from previous ungraceful exit") Cc: sta...@dpdk.org Signed-off-by: Rasesh Mody --- drivers/net/q

[dpdk-dev] [PATCH 3/4] net/qede/base: fix GRC attention callback

Treat any attention which is not for timeout event as invalid and return status accordingly. The HW error handler logs and clears the HW attention. Without this fix we can see flood of GRC attentions. Fixes: e6051bd6b07d ("qede: add interrupt handling support") Cc: sta...@dpdk.org Signed-off-by:

Re: [dpdk-dev] [PATCH] net/mlx5: fix possible endless loop when clearing flow flags

> On Jul 23, 2018, at 11:57 PM, Nélio Laranjeiro > wrote: > > On Mon, Jul 23, 2018 at 11:27:44AM -0700, Yongseok Koh wrote: >> If one of (*priv->rxqs)[] is null, the for loop can iterate infinitely as >> idx can't be increased. >> >> Fixes: cd24d526395e ("net/mlx5: add mark/flag flow action")

[dpdk-dev] [PATCH 4/4] netvsc/vmbus: avoid signalling host on read

Don't signal host that receive ring has been read until all events have been processed. This reduces the number of guest exits and therefore improves performance. Signed-off-by: Stephen Hemminger --- drivers/bus/vmbus/rte_bus_vmbus.h | 13 +- drivers/bus/vmbus/rte_bus_vmbus_version

[dpdk-dev] [PATCH 3/4] netvsc: implement queue info get handles

This helps when diagnosing ring issues in testpmd. Signed-off-by: Stephen Hemminger --- drivers/net/netvsc/hn_ethdev.c | 2 ++ drivers/net/netvsc/hn_rxtx.c | 22 ++ drivers/net/netvsc/hn_var.h| 4 3 files changed, 28 insertions(+) diff --git a/drivers/net/netvsc

[dpdk-dev] [PATCH 1/4] netvsc: change rx descriptor setup and sizing

Increase the size of the ring used to hold mbuf's received but not processed. The default is now based off the size of thw receive mbuf pool not the number of sections from the host. Signed-off-by: Stephen Hemminger --- drivers/net/netvsc/hn_rxtx.c | 24 +++- 1 file changed,

[dpdk-dev] [PATCH 2/4] netvsc: avoid over filling receive descriptor ring

If the number of packets requested are already present in the rx_ring then skip reading the ring buffer from the host. If the ring between the poll and receive side is full, then don't poll (let incoming packets stay on host). If no more transmit descriptors are available, then still try and flus

[dpdk-dev] [PATCH 0/4] netvsc PMD performance fixes

The netvsc PMD is faster than the kernel but is still slow on receiving packets. These patches help. Stephen Hemminger (4): netvsc: change rx descriptor setup and sizing netvsc: avoid over filling receive descriptor ring netvsc: implement queue info get handles netvsc/vmbus: avoid signalli

Re: [dpdk-dev] [PATCH v2 1/6] net/mlx5: lay groundwork for switch offloads

On Tue, 24 Jul 2018 04:35:05 + Shahaf Shuler wrote: > Stephen, > > Tuesday, July 24, 2018 3:51 AM, Stephen Hemminger: > > Subject: Re: [dpdk-dev] [PATCH v2 1/6] net/mlx5: lay groundwork for switch > > offloads > > > > On Mon, 23 Jul 2018 22:40:47 +0100 > > Ferruh Yigit wrote: > > > > > >

Re: [dpdk-dev] Accessing "device_id" from "rte_pci_device"

Hi, Santosh, Indeed the following patch from Ferruh removed the rte_pci_device from the rte_eth_dev_info object, and instead added an object of rte_device: http://patchwork.dpdk.org/patch/37654/ However, I see that the date that this patch was applied to dpdk-next-net/master is 4/10/2018. Ar

Re: [dpdk-dev] [PATCH] app/testpmd: workaround softnic CLI modifications

> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Moti Haimovsky > Sent: Tuesday, July 24, 2018 5:21 PM > To: tho...@monjalon.net > Cc: dev@dpdk.org; sta...@dpdk.org; Moti Haimovsky > > Subject: [dpdk-dev] [PATCH] app/testpmd: workaround softnic CLI > modificat

Re: [dpdk-dev] [PATCH] app/testpmd: fix testpmd exit using ctrl+d

> -Original Message- > From: Mordechay Haimovsky [mailto:mo...@mellanox.com] > Sent: Tuesday, July 24, 2018 3:37 PM > To: Thomas Monjalon ; Singh, Jasvinder > > Cc: dev@dpdk.org; Iremonger, Bernard ; > Pattan, Reshma ; olivier.m...@6wind.com; > Dumitrescu, Cristian > Subject: RE: [dpdk

Re: [dpdk-dev] [PATCH 2/3] app/testpmd: update softnic mode documentation

> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Jasvinder Singh > Sent: Tuesday, July 24, 2018 4:50 PM > To: dev@dpdk.org > Cc: Mcnamara, John ; Kovacevic, Marko > ; Pattan, Reshma > Subject: [dpdk-dev] [PATCH 2/3] app/testpmd: update softnic mode > documentatio

Re: [dpdk-dev] [PATCH 1/2] examples/ipsec-secgw: fix bypass rule processing for outbound port

> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Akhil Goyal > Sent: Thursday, June 21, 2018 2:26 PM > To: Ananyev, Konstantin ; dev@dpdk.org > Cc: Nicolau, Radu > Subject: Re: [dpdk-dev] [PATCH 1/2] examples/ipsec-secgw: fix bypass rule > processing for outbou

Re: [dpdk-dev] [PATCH] baseband/turbo_sw: update Turbo driver for FlexRAN 1.6.0

> -Original Message- > From: Mokhtar, Amr > Sent: Thursday, July 19, 2018 2:04 PM > To: De Lara Guarch, Pablo > Cc: dev@dpdk.org; Mokhtar, Amr > Subject: [PATCH] baseband/turbo_sw: update Turbo driver for FlexRAN 1.6.0 > > Update BBDEV Turbo SW driver download/build instructions for F

[dpdk-dev] [PATCH] app/testpmd: workaround softnic CLI modifications

This patch returns the previous testpmd command line handling routines (namely cmdline_interact and cmdline_stdin_exit) to the prompt routine in order to overcome testpmd abnormal exit observed on several setups. These routines will only by used when testpmd is compiled without support for RTE_LIBR

Re: [dpdk-dev] [PATCH v5 0/3]crypto/openssl: support asymmetric crypto

> -Original Message- > From: Shally Verma [mailto:shally.ve...@caviumnetworks.com] > Sent: Monday, July 23, 2018 3:46 PM > To: De Lara Guarch, Pablo > Cc: dev@dpdk.org; pathr...@caviumnetworks.com; > nmur...@caviumnetworks.com > Subject: [PATCH v5 0/3]crypto/openssl: support asymmetric

Re: [dpdk-dev] [PATCH] app/testpmd: fix dcb config failure

> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Xiaoyun Li > Sent: Tuesday, July 24, 2018 12:33 PM > To: Lu, Wenzhuo ; Wu, Jingjing > > Cc: dev@dpdk.org; Li, Xiaoyun ; sta...@dpdk.org > Subject: [dpdk-dev] [PATCH] app/testpmd: fix dcb config failure > > After a

Re: [dpdk-dev] [PATCH] net/mlx5: fix linkage error for glue lib

On Tue, Jul 24, 2018 at 02:24:12PM +, Yaroslav Brustinov (ybrustin) wrote: > Hi, > > Are you OK with C11? > I saw in file dpdk/drivers/net/mlx4/mlx4_utils.c: > > * C11 code would include stdalign.h and use alignof(max_align_t) however > * we'll stick with C99 for the time being. >

Re: [dpdk-dev] [PATCH v5 0/5] compress: add ZLIB compression PMD

> -Original Message- > From: Shally Verma [mailto:shally.ve...@caviumnetworks.com] > Sent: Tuesday, July 24, 2018 4:06 PM > To: De Lara Guarch, Pablo > Cc: dev@dpdk.org; pathr...@caviumnetworks.com; > mcha...@caviumnetworks.com > Subject: [PATCH v5 0/5] compress: add ZLIB compression PM

[dpdk-dev] [PATCH 3/3] doc: update release notes for softnic pmd

Update release notes for softnic pmd restructuring. Signed-off-by: Jasvinder Singh --- doc/guides/rel_notes/release_18_08.rst | 6 ++ 1 file changed, 6 insertions(+) diff --git a/doc/guides/rel_notes/release_18_08.rst b/doc/guides/rel_notes/release_18_08.rst index dd611b5..8bb299c 100644 -

[dpdk-dev] [PATCH 2/3] app/testpmd: update softnic mode documentation

Update tespmd documentation with softnic forwarding mode description. Signed-off-by: Jasvinder Singh Signed-off-by: Reshma Pattan --- doc/guides/testpmd_app_ug/testpmd_funcs.rst | 12 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/doc/guides/testpmd_app_ug/testpmd_fu

[dpdk-dev] [PATCH 1/3] net/softnic: add softnic documentation

Add softnic documentation to NIC drivers guide. Signed-off-by: Cristian Dumitrescu Signed-off-by: Jasvinder Singh --- MAINTAINERS | 2 + doc/guides/nics/features/softnic.ini | 9 ++ doc/guides/nics/index.rst| 1 + doc/guides/nics/softnic.rst |

Re: [dpdk-dev] [PATCH v4] app/eventdev: use proper teardown sequence

-Original Message- > Date: Tue, 24 Jul 2018 17:44:50 +0530 > From: Pavan Nikhilesh > To: jerin.ja...@caviumnetworks.com > Cc: dev@dpdk.org, Pavan Nikhilesh > Subject: [dpdk-dev] [PATCH v4] app/eventdev: use proper teardown sequence > X-Mailer: git-send-email 2.18.0 > > Use proper teardow

Re: [dpdk-dev] [PATCH] event/octeontx: remove unnecessary port start and stop in Rx adapter

-Original Message- > Date: Thu, 19 Jul 2018 17:17:47 +0530 > From: Pavan Nikhilesh > To: jerin.ja...@caviumnetworks.com > Cc: dev@dpdk.org, Pavan Nikhilesh , > sta...@dpdk.org > Subject: [dpdk-dev] [PATCH] event/octeontx: remove unnecessary port start > and stop in Rx adapter > X-Mailer:

Re: [dpdk-dev] [PATCH] net/octeontx: fix stop clearing fastpath functions

-Original Message- > Date: Tue, 24 Jul 2018 16:13:50 +0530 > From: Pavan Nikhilesh > To: jerin.ja...@caviumnetworks.com, santosh.shu...@caviumnetworks.com, > ferruh.yi...@intel.com > Cc: dev@dpdk.org, Pavan Nikhilesh > Subject: [dpdk-dev] [PATCH] net/octeontx: fix stop clearing fastpath

Re: [dpdk-dev] [PATCH] app/eventdev: fix order test service init

-Original Message- > Date: Fri, 13 Jul 2018 17:52:42 + > From: "Eads, Gage" > To: Pavan Nikhilesh , > "jerin.ja...@caviumnetworks.com" > CC: "dev@dpdk.org" , "sta...@dpdk.org" > Subject: RE: [dpdk-dev] [PATCH] app/eventdev: fix order test service init > > External Email > > >

Re: [dpdk-dev] [PATCH v2] app/testpmd: fix testpmd exit for ctrl+d

Hi , Can you check if v2 version is working ? And it would be great if you add Tested-by: if test passes. Else, please let me know the steps to reproduce the issue. Thanks, Reshma

Re: [dpdk-dev] [PATCH v2] app/testpmd: fix testpmd exit for ctrl+d

Hi Reshma, > -Original Message- > From: Pattan, Reshma > Sent: Tuesday, July 24, 2018 3:47 PM > To: dev@dpdk.org > Cc: Iremonger, Bernard ; > tho...@monjalon.net; Singh, Jasvinder ; > olivier.m...@6wind.com; Mordechay Haimovsky > Subject: RE: [PATCH v2] app/testpmd: fix testpmd exit for c

Re: [dpdk-dev] [PATCH] mk: fix application compilation with lmnl and mlx5

On Tue, Jul 24, 2018 at 01:03:28PM +, Shahaf Shuler wrote: > Tuesday, July 24, 2018 3:56 PM, Adrien Mazarguil: > > Subject: Re: [PATCH] mk: fix application compilation with lmnl and mlx5 > > > > On Tue, Jul 24, 2018 at 11:21:52AM +, Shahaf Shuler wrote: > > > Tuesday, July 24, 2018 12:29 P

[dpdk-dev] [PATCH v5 5/5] doc: add ZLIB PMD guide

Add zlib pmd feature support and user guide with build and run instructions Signed-off-by: Sunila Sahu Signed-off-by: Shally Verma Signed-off-by: Ashish Gupta --- MAINTAINERS | 2 + doc/guides/compressdevs/features/zlib.ini | 10 + doc/guides/compressdevs/ind

[dpdk-dev] [PATCH v5 4/5] compress/zlib: support burst enqueue/dequeue

From: Sunila Sahu Signed-off-by: Sunila Sahu Signed-off-by: Shally Verma Signed-off-by: Ashish Gupta --- drivers/compress/zlib/zlib_pmd.c | 255 ++- 1 file changed, 254 insertions(+), 1 deletion(-) diff --git a/drivers/compress/zlib/zlib_pmd.c b/drivers/co

[dpdk-dev] [PATCH v5 2/5] compress/zlib: add device PMD ops

From: Ashish Gupta Implement device configure and queue pair setup PMD ops Signed-off-by: Sunila Sahu Signed-off-by: Shally Verma Signed-off-by: Ashish Gupta --- drivers/compress/zlib/Makefile | 1 + drivers/compress/zlib/meson.build| 2 +- drivers/compress/zlib/zlib_pm

[dpdk-dev] [PATCH v5 3/5] compress/zlib: create private xform

From: Sunila Sahu Create non-shareable private xform for stateless operation processing Signed-off-by: Sunila Sahu Signed-off-by: Shally Verma Signed-off-by: Ashish Gupta --- drivers/compress/zlib/zlib_pmd.c | 94 drivers/compress/zlib/zlib_pmd_ops.c

[dpdk-dev] [PATCH v5 1/5] compress/zlib: add ZLIB PMD

From: Ashish Gupta Add initial PMD setup routines in compressdev framework. ZLIB PMD appears as virtual compression device. User would need to install zlib prior to enabling this PMD. Signed-off-by: Sunila Sahu Signed-off-by: Shally Verma Signed-off-by: Ashish Gupta --- MAINTAINERS

[dpdk-dev] [PATCH v5 0/5] compress: add ZLIB compression PMD

This patch series add software zlib library (http://zlib.net/) based compression PMD in DPDK compress drivers. Application must need to install zlib prior to enabling this PMD to avail compression/decompression services. Currently driver only tested for deflate, stateless compression and decompres

Re: [dpdk-dev] [PATCH v2] test: add unit tests for metrics library

Tested using the following patches also applied: http://patches.dpdk.org/patch/42097/ http://patches.dpdk.org/patch/42098/ http://patches.dpdk.org/patch/42510/ http://patches.dpdk.org/patch/42971/ Two test-cases fail, but these in themselves ought not block this patch. Details below. Acked-by

Re: [dpdk-dev] [PATCH v2] app/testpmd: fix testpmd exit for ctrl+d

+ CC: Olivier and Mordechay Haimovsky. > -Original Message- > From: Pattan, Reshma > Sent: Tuesday, July 24, 2018 3:17 PM > To: dev@dpdk.org > Cc: Iremonger, Bernard ; > tho...@monjalon.net; Singh, Jasvinder ; > Pattan, Reshma > Subject: [PATCH v2] app/testpmd: fix testpmd exit for ctrl+

Re: [dpdk-dev] [PATCH] app/testpmd: fix testpmd exit using ctrl+d

Even after this fix we still have setups that use netvsc for example, on which testpmd exits with rte_panic right after loading it even without touching the KBD. I recommend returning the previous prompt routine in test-pmd/cmdline.c and rework the SOFTNIC section there, preferably moving its

Re: [dpdk-dev] [PATCH] net/bonding: set started flag at the end of dev start

I think this adds another race. In bond_ethdev_slave_link_status_change_monitor(), it checks to see if bonding is started, if not it exits. So you need to have dev_started = 1 set before you enable this callback. On Fri, Jul 20, 2018 at 6:09 AM Radu Nicolau wrote: > Race condition can appear i

Re: [dpdk-dev] [PATCH] app/testpmd: fix commands to config some offload

Hi Wei, > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Wei Dai > Sent: Tuesday, July 24, 2018 4:45 AM > To: Wu, Jingjing ; Lu, Wenzhuo > ; dev@dpdk.org > Cc: Dai, Wei ; sta...@dpdk.org > Subject: [dpdk-dev] [PATCH] app/testpmd: fix commands to config some > off

[dpdk-dev] [PATCH v2] app/testpmd: fix testpmd exit for ctrl+d

Testpmd should be existed gracefully when ctrl+d is typed. This behaviour is not handled properly, fix this by calling pmd_test_exit() instead of rte_panic. Fixes: 0ad778b398c6 ("app/testpmd: rework softnic forward mode") Reported-by: Mordechay Haimovsky Signed-off-by: Jasvinder Singh Signed-of

[dpdk-dev] [PATCH] test/compress: add offset tests

From: "Daly, Lee" Added offset test, which tests compression/decompression with a buffer containing an offset spanning across multiple segments. Signed-off-by: Lee Daly --- test/test/test_compressdev.c | 233 +++ 1 file changed, 189 insertions(+), 44 del

Re: [dpdk-dev] [PATCH] net/mlx5: fix linkage error for glue lib

Yaroslav, Tuesday, July 24, 2018 3:06 PM, Adrien Mazarguil: > Subject: Re: [PATCH] net/mlx5: fix linkage error for glue lib > > Odd, how could this happen assuming both files are compiled during the > > same run using identical flags? Looks like a compiler issue. > > > > Anyway, may I suggest an

Re: [dpdk-dev] [PATCH] net/mlx5: fix route Netlink message overflow

Tuesday, July 24, 2018 9:50 AM, Nelio Laranjeiro: > Subject: [PATCH] net/mlx5: fix route Netlink message overflow > > Route Netlink message socket is wrongly initialised by registering to the > route link group. This causes the socket to receive all link message related > to > routes whereas the

Re: [dpdk-dev] [PATCH] net/mlx5: fix assert for Tx completion queue count

Monday, July 23, 2018 9:00 PM, Yongseok Koh: > Subject: [PATCH] net/mlx5: fix assert for Tx completion queue count > > There should be at least one Tx CQE remained if Tx WQ and txq->elts[] have > available slots to send a packet because the size of Tx CQ is exactly > calculated > from the size of

Re: [dpdk-dev] [PATCH v2] net/mlx5: fix representors detection

Tuesday, July 24, 2018 11:37 AM, Nelio Laranjeiro: > Subject: [PATCH v2] net/mlx5: fix representors detection > > On systems where the required Netlink commands are not supported but > Mellanox OFED is installed, representors information must be retrieved > through sysfs. > > Fixes: 4c10141488fe

Re: [dpdk-dev] [PATCH] doc: fix mlx5 dependencies

Monday, July 23, 2018 2:51 PM, Adrien Mazarguil: > Subject: [PATCH] doc: fix mlx5 dependencies > > The new dependency of mlx5 to libmnl must be reflected in documentation. > > Fixes: 4d5cce06231a ("net/mlx5: lay groundwork for switch offloads") > > Signed-off-by: Adrien Mazarguil > --- > doc/g

Re: [dpdk-dev] [PATCH] net/mlx5: fix tci mask filter

Tuesday, July 24, 2018 1:38 AM, Yongseok Koh: > Subject: Re: [PATCH] net/mlx5: fix tci mask filter > > > > On Jul 23, 2018, at 12:18 AM, Nelio Laranjeiro > wrote: > > > > In mlx5_traffic_enable() the TCI mask for the VLAN is wrong causing > > the sub flow engine to reject the rule. > > > > Fixes

Re: [dpdk-dev] [PATCH] app/testpmd: fix testpmd exit using ctrl+d

24/07/2018 14:41, Iremonger, Bernard: > Hi Thomas, > > +John > > From: Thomas Monjalon [mailto:tho...@monjalon.net] > > > > Important note: > > testpmd is currently really broken. > > We cannot have a RC2 until it is fixed. > > > > > > 24/07/2018 13:25, Thomas Monjalon: > > > 23/07/201

Re: [dpdk-dev] [PATCH v4] compress/isal: add chained mbuf support

> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of De Lara Guarch, Pablo > Sent: Tuesday, July 24, 2018 2:28 PM > To: Daly, Lee > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v4] compress/isal: add chained mbuf support > > > > > -Original Message

Re: [dpdk-dev] [PATCH v4] compress/isal: add chained mbuf support

> -Original Message- > From: Daly, Lee > Sent: Tuesday, July 24, 2018 12:19 PM > To: De Lara Guarch, Pablo > Cc: dev@dpdk.org; Daly, Lee > Subject: [PATCH v4] compress/isal: add chained mbuf support > > This patch adds chained mbuf support for input or output buffers during > compress

Re: [dpdk-dev] [PATCH v2] ethdev: change vtune profiling approach

> On Jul 19, 2018, at 7:21 AM, ilia.kura...@intel.com wrote: > > From: Ilia Kurakin > > The patch changes rx_burst profiling approach: > 1. VTune's instrumentation is removed > 2. empty hook callback for profiling is added > This way all VTune-specific logic moves to the VTune sid

Re: [dpdk-dev] [PATCH] net/tap: add probe finish call for tun secondary

> On Jul 24, 2018, at 12:05 AM, Vipin Varghese wrote: > > Invoke rte_eth_dev_probing_finish for rte_pmd_tun_probe. > > Signed-off-by: Vipin Varghese > --- > drivers/net/tap/rte_eth_tap.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/

Re: [dpdk-dev] [PATCH 2/2] examples/ipsec-secgw: fix portmask option parsing

> -Original Message- > From: Akhil Goyal [mailto:akhil.go...@nxp.com] > Sent: Tuesday, July 24, 2018 1:50 PM > To: Ananyev, Konstantin ; dev@dpdk.org > Cc: Nicolau, Radu > Subject: Re: [dpdk-dev] [PATCH 2/2] examples/ipsec-secgw: fix portmask option > parsing > > Hi Konstantin, > > On

Re: [dpdk-dev] rte_mbuf library likely()/unlikely()

> On Jul 24, 2018, at 6:31 AM, Van Haaren, Harry > wrote: > >> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Morten Brørup >> Sent: Tuesday, July 24, 2018 9:14 AM >> To: Olivier Matz ; Wiles, Keith >> >> Cc: Honnappa Nagarahalli ; dev@dpdk.org >> Subject: Re: [dpdk-dev] rte_mbuf librar

Re: [dpdk-dev] [PATCH] mk: fix application compilation with lmnl and mlx5

Tuesday, July 24, 2018 3:56 PM, Adrien Mazarguil: > Subject: Re: [PATCH] mk: fix application compilation with lmnl and mlx5 > > On Tue, Jul 24, 2018 at 11:21:52AM +, Shahaf Shuler wrote: > > Tuesday, July 24, 2018 12:29 PM, Nelio Laranjeiro: > > > Subject: [PATCH] mk: fix application compilati

Re: [dpdk-dev] [PATCH] mk: fix application compilation with lmnl and mlx5

On Tue, Jul 24, 2018 at 11:21:52AM +, Shahaf Shuler wrote: > Tuesday, July 24, 2018 12:29 PM, Nelio Laranjeiro: > > Subject: [PATCH] mk: fix application compilation with lmnl and mlx5 > > > > When Mellanox MLX5 PMD is compiled with > > CONFIG_RTE_LIBRTE_MLX5_DLOPEN_DEPS=y, the external depende

Re: [dpdk-dev] [PATCH 2/2] examples/ipsec-secgw: fix portmask option parsing

Hi Konstantin, On 7/24/2018 6:07 PM, Ananyev, Konstantin wrote: Hi Akhil, Hi Konstantin, On 6/22/2018 5:21 PM, Ananyev, Konstantin wrote: -Original Message- From: Akhil Goyal [mailto:akhil.go...@nxp.com] Sent: Friday, June 22, 2018 11:41 AM To: Ananyev, Konstantin ; dev@dpdk.org Cc

Re: [dpdk-dev] [PATCH] app/testpmd: fix testpmd exit using ctrl+d

Hi Thomas, +John > -Original Message- > From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Tuesday, July 24, 2018 1:34 PM > To: Singh, Jasvinder > Cc: dev@dpdk.org; Iremonger, Bernard ; > Pattan, Reshma ; mo...@mellanox.com; > olivier.m...@6wind.com; Dumitrescu, Cristian > > Sub

Re: [dpdk-dev] [PATCH] app/testpmd: fix testpmd exit using ctrl+d

Hi, Jasvinder is OOO, let me have a look and send the next version of patch. Thanks, Reshma > -Original Message- > From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Tuesday, July 24, 2018 1:34 PM > To: Singh, Jasvinder > Cc: dev@dpdk.org; Iremonger, Bernard ; > Pattan, Reshma ;

Re: [dpdk-dev] [PATCH 2/2] examples/ipsec-secgw: fix portmask option parsing

Hi Akhil, > > Hi Konstantin, > > On 6/22/2018 5:21 PM, Ananyev, Konstantin wrote: > > > > >> -Original Message- > >> From: Akhil Goyal [mailto:akhil.go...@nxp.com] > >> Sent: Friday, June 22, 2018 11:41 AM > >> To: Ananyev, Konstantin ; dev@dpdk.org > >> Cc: Nicolau, Radu > >> Subject:

Re: [dpdk-dev] [PATCH] app/testpmd: fix testpmd exit using ctrl+d

Important note: testpmd is currently really broken. We cannot have a RC2 until it is fixed. 24/07/2018 13:25, Thomas Monjalon: > 23/07/2018 12:44, Jasvinder Singh: > > Fix testpmd app exit by pressing ctrl+d, End-of-Transmission character (EOT) > > on the empty command line. > >

Re: [dpdk-dev] [PATCH v5 4/4] test: add unit test for pdump library

On 24-Jul-18 11:54 AM, Naga Suresh Somarowthu wrote: Unit test cases are added for pdump library. Primary process will act as server, forks a child secondary process. Secondary process acts as client. Server will do pdump init to serve any pdump client requests. Server will create a vdev, send/re

[dpdk-dev] [PATCH] Revert "mem: allocate in reverse to reduce fragmentation"

This reverts commit 179f916e88e4a0fdd5ad4d20e226771d3d271c41. A few regressions with virtio/vhost have been discovered, due to the strong dependency of virtio/vhost on the underlying memory layout. Specifically, virtio/vhost share all memory pages starting from the beginning of the segment, while

[dpdk-dev] [PATCH v4] app/eventdev: use proper teardown sequence

Use proper teardown sequence when SIGINT is caught to prevent eventdev from going into undefined state. Signed-off-by: Pavan Nikhilesh --- v4 Changes: - Check opts before closing ethdev. v3 Changes: - Segregate ethdev_stop and close to prevent possible SEGFAULT. - handle early shutdown. v

Re: [dpdk-dev] [PATCH] net/mlx5: fix linkage error for glue lib

On Tue, Jul 24, 2018 at 02:00:48PM +0200, Adrien Mazarguil wrote: > On Tue, Jul 24, 2018 at 11:54:45AM +0300, Shahaf Shuler wrote: > > From: Yaroslav Brustinov > > > > Compiling with gcc 4.7.2 introduced the linkage error > > > > "bin/ld: Warning: alignment 8 of symbol `mlx5_glue' in > > src/dpd

Re: [dpdk-dev] [PATCH] config: reduce memory requirements for DPDK

24/07/2018 13:04, Burakov, Anatoly: > On 24-Jul-18 11:23 AM, Thomas Monjalon wrote: > > 24/07/2018 12:03, Anatoly Burakov: > >> It has been reported that current memory limitations do not work > >> well on an 8-socket machines in default configuration when big > >> page sizes are used [1]. > >> > >

Re: [dpdk-dev] [PATCH] net/mlx5: fix linkage error for glue lib

On Tue, Jul 24, 2018 at 11:54:45AM +0300, Shahaf Shuler wrote: > From: Yaroslav Brustinov > > Compiling with gcc 4.7.2 introduced the linkage error > > "bin/ld: Warning: alignment 8 of symbol `mlx5_glue' in > src/dpdk/drivers/net/mlx5/mlx5_glue.c.21.o is smaller than 16 in > src/dpdk/drivers/net

Re: [dpdk-dev] [PATCH] mk: fix application compilation with lmnl and mlx5

Tuesday, July 24, 2018 2:45 PM, Nélio Laranjeiro: > Subject: Re: [PATCH] mk: fix application compilation with lmnl and mlx5 > > On Tue, Jul 24, 2018 at 11:21:52AM +, Shahaf Shuler wrote: > > Tuesday, July 24, 2018 12:29 PM, Nelio Laranjeiro: > > > Subject: [PATCH] mk: fix application compilati

Re: [dpdk-dev] [PATCH] mk: fix application compilation with lmnl and mlx5

On Tue, Jul 24, 2018 at 11:21:52AM +, Shahaf Shuler wrote: > Tuesday, July 24, 2018 12:29 PM, Nelio Laranjeiro: > > Subject: [PATCH] mk: fix application compilation with lmnl and mlx5 > > > > When Mellanox MLX5 PMD is compiled with > > CONFIG_RTE_LIBRTE_MLX5_DLOPEN_DEPS=y, the external depende

[dpdk-dev] [PATCH] app/testpmd: fix dcb config failure

After adding RSS hash offload check, default rss_hf will fail on devices that do not support all bits. This will lead to dcb config failure. The patch fixes this issue by taking rss_hf as a suggested value and only setting bits that the device supports based on rte_eth_dev_get_info. Fixes: 8863a1f

Re: [dpdk-dev] rte_mbuf library likely()/unlikely()

> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Morten Brørup > Sent: Tuesday, July 24, 2018 9:14 AM > To: Olivier Matz ; Wiles, Keith > > Cc: Honnappa Nagarahalli ; dev@dpdk.org > Subject: Re: [dpdk-dev] rte_mbuf library likely()/unlikely() > > > -Original Message- > > From: dev [

Re: [dpdk-dev] [PATCH] app/testpmd: fix testpmd exit using ctrl+d

23/07/2018 12:44, Jasvinder Singh: > Fix testpmd app exit by pressing ctrl+d, End-of-Transmission character (EOT) > on the empty command line. Please describe what is the issue and what is the cause. > Fixes: 0ad778b398c6 ("app/testpmd: rework softnic forward mode") > > Reported-by: Mordechay Ha

Re: [dpdk-dev] [PATCH] mk: fix application compilation with lmnl and mlx5

Tuesday, July 24, 2018 12:29 PM, Nelio Laranjeiro: > Subject: [PATCH] mk: fix application compilation with lmnl and mlx5 > > When Mellanox MLX5 PMD is compiled with > CONFIG_RTE_LIBRTE_MLX5_DLOPEN_DEPS=y, the external dependency on > libmln is missing. > > Fixes: 4d5cce06231a ("net/mlx5: lay grou

Re: [dpdk-dev] [PATCH v5 1/4] test: add ring pmd based packet rx/tx for UT

On 24-Jul-18 11:54 AM, Naga Suresh Somarowthu wrote: Added ring pmd based packet rx/tx helper functions for verifying Latency, Bitrate and pdump lib UTs. Signed-off-by: Naga Suresh Somarowthu Reviewed-by: Reshma Pattan Reviewed-by: Anatoly Burakov Why is it carrying my Reviewed-by: ? I do n

[dpdk-dev] [PATCH v4] compress/isal: add chained mbuf support

This patch adds chained mbuf support for input or output buffers during compression/decompression operations. V2 - split chained mbuf functionality into separate functions. - code optimizations. V3 - bug fixes & optimizations. v4 - bug fixes & optimizations. Signed-off-by: Lee Daly --- doc

Re: [dpdk-dev] [PATCH] config: reduce memory requirements for DPDK

On 24-Jul-18 11:23 AM, Thomas Monjalon wrote: 24/07/2018 12:03, Anatoly Burakov: It has been reported that current memory limitations do not work well on an 8-socket machines in default configuration when big page sizes are used [1]. Fix it by reducing memory amount reserved by DPDK by default

[dpdk-dev] [PATCH v3] app/eventdev: use proper teardown sequence

Use proper teardown sequence when SIGINT is caught to prevent eventdev from going into undefined state. Signed-off-by: Pavan Nikhilesh --- v3 Changes: - Segregate ethdev_stop and close to prevent possible SEGFAULT. - handle early shutdown. v2 Changes: - Only stopping the ethdev(producer) is

[dpdk-dev] [PATCH v5 3/4] test: add unit tests for latencystats library

Unit Test Cases added for latencystats library. Signed-off-by: Naga Suresh Somarowthu Reviewed-by: Reshma Pattan --- test/test/Makefile| 1 + test/test/autotest_data.py| 6 ++ test/test/test_latencystats.c | 216 ++ 3 files changed, 22

[dpdk-dev] [PATCH v5 2/4] test: add unit tests for bitrate library

Unit Test Cases for BitRate library. Signed-off-by: Naga Suresh Somarowthu Reviewed-by: Reshma Pattan Reviewed-by: Remy Horton --- test/test/Makefile| 1 + test/test/autotest_data.py| 6 ++ test/test/test_bitratestats.c | 227 ++ 3 fi

[dpdk-dev] [PATCH v5 4/4] test: add unit test for pdump library

Unit test cases are added for pdump library. Primary process will act as server, forks a child secondary process. Secondary process acts as client. Server will do pdump init to serve any pdump client requests. Server will create a vdev, send/receive packets continuously in a separate thread. Clien

[dpdk-dev] [PATCH v5 1/4] test: add ring pmd based packet rx/tx for UT

Added ring pmd based packet rx/tx helper functions for verifying Latency, Bitrate and pdump lib UTs. Signed-off-by: Naga Suresh Somarowthu Reviewed-by: Reshma Pattan Reviewed-by: Anatoly Burakov --- test/test/Makefile| 1 + test/test/sample_packet_forward.c | 115

  1   2   >