[dpdk-dev] [PATCH] net/avf: fix missing offload capabilities

There are several tx/rx offload capabilities missing in AVF. Add them in this patch since AVF supports them. Fixes: 69dd4c3d0898 ("net/avf: enable queue and device") Cc: sta...@dpdk.org Signed-off-by: Xiaoyun Li --- drivers/net/avf/avf_ethdev.c | 18 -- 1 file changed, 16 insert

[dpdk-dev] [PATCH 1/3] net/virtio: remove unnecessary assignments

Remove the unnecessary assignments in Rx functions as they are useless and misleading. Signed-off-by: Tiwei Bie --- drivers/net/virtio/virtio_rxtx.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/net/virtio/virtio_rxtx.c b/drivers/net/virtio/virtio_rxtx.c index 7c105229e..eb891433e

[dpdk-dev] [PATCH 3/3] net/virtio: remove an unused macro

This macro isn't used any more after below commit: commit a4996bd89c42 ("ethdev: new Rx/Tx offloads API") Signed-off-by: Tiwei Bie --- drivers/net/virtio/virtio_ethdev.h | 7 --- 1 file changed, 7 deletions(-) diff --git a/drivers/net/virtio/virtio_ethdev.h b/drivers/net/virtio/virtio_ethd

[dpdk-dev] [PATCH 2/3] vhost: remove an unused variable

The nr_updated is just increased and not really used. Signed-off-by: Tiwei Bie --- lib/librte_vhost/virtio_net.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/lib/librte_vhost/virtio_net.c b/lib/librte_vhost/virtio_net.c index 2b7ffcf92..b17c3e907 100644 --- a/lib/librte_vhost/virtio_net

[dpdk-dev] [Bug 75] 16.11 compile fail on RHEL 6.9

https://bugs.dpdk.org/show_bug.cgi?id=75 Bug ID: 75 Summary: 16.11 compile fail on RHEL 6.9 Product: DPDK Version: 16.11 Hardware: x86 OS: Linux Status: CONFIRMED Severity: normal Priority: Norma

[dpdk-dev] [PATCH] vhost: fix return value

This patch fixes the incorrect return value for rte_vhost_dequeue_burst() when virtqueue is not enabled or virtqueue address translation fails. Fixes: 62250c1d0978 ("vhost: extract split ring handling from Rx and Tx functions") Signed-off-by: Jiayu Hu --- lib/librte_vhost/virtio_net.c | 8

Re: [dpdk-dev] [PATCH] app/testpmd: fix testpmd exit using ctrl+d

24/07/2018 18:59, Dumitrescu, Cristian: > From: Mordechay Haimovsky [mailto:mo...@mellanox.com] > > > > Even after this fix we still have setups that use netvsc for example, on > > which testpmd exits with rte_panic right after loading it even without > > touching the KBD. > > > > I recommend r

Re: [dpdk-dev] [dpdk-stable] [PATCH] app/testpmd: workaround softnic CLI modifications

24/07/2018 19:39, Dumitrescu, Cristian: > > > -Original Message- > > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Moti Haimovsky > > Sent: Tuesday, July 24, 2018 5:21 PM > > To: tho...@monjalon.net > > Cc: dev@dpdk.org; sta...@dpdk.org; Moti Haimovsky > > > > Subject: [dpdk-dev] [

Re: [dpdk-dev] [PATCH] app/testpmd: fix testpmd exit using ctrl+d

> -Original Message- > From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Wednesday, July 25, 2018 9:19 AM > To: Dumitrescu, Cristian > Cc: dev@dpdk.org; Mordechay Haimovsky ; Singh, > Jasvinder ; Iremonger, Bernard > ; Pattan, Reshma > ; olivier.m...@6wind.com > Subject: Re: [d

[dpdk-dev] [PATCH] ethdev: remove unused forward declaration.

The forward declaraion of rte_pci_device in rte_ethdev.h is not needed anymore. Fixes: cd8c7c7ce241 ("replace bus specific struct with generic dev") Signed-off-by: Rami Rosen --- lib/librte_ethdev/rte_ethdev.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/lib/librte_ethdev/rte_ethdev.h b/

[dpdk-dev] [PATCH] net/mlx5: fix count query when flow has not counters

Querying a counters on a flow without counter is ending with a segmentation fault. Fixes: 60bd8c9747e8 ("net/mlx5: add count flow action") Signed-off-by: Nelio Laranjeiro --- drivers/net/mlx5/mlx5_flow.c | 56 1 file changed, 32 insertions(+), 24 deletions(-

Re: [dpdk-dev] [PATCH] app/testpmd: fix testpmd exit using ctrl+d

> -Original Message- > From: Singh, Jasvinder > Sent: Wednesday, July 25, 2018 9:31 AM > To: Thomas Monjalon ; Dumitrescu, Cristian > > Cc: dev@dpdk.org; Mordechay Haimovsky ; > Iremonger, Bernard ; Pattan, Reshma > ; olivier.m...@6wind.com > Subject: RE: [dpdk-dev] [PATCH] app/testpmd:

Re: [dpdk-dev] [PATCH] net/bonding: set started flag at the end of dev start

On 7/24/2018 3:34 PM, Chas Williams wrote: I think this adds another race.  In bond_ethdev_slave_link_status_change_monitor(), it checks to see if bonding is started, if not it exits.  So you need to have dev_started = 1 set before you enable this callback. Indeed, I will have another loo

Re: [dpdk-dev] [PATCH] app/testpmd: fix testpmd exit using ctrl+d

Hi, This issue happens on some of our setups sometimes without even pressing any key. I will try to create a minimalistic setup which will show the problem and will be easy to construct by you. Will send you all the details later on today. Moti > -Original Message- > From: Singh, Jasvin

Re: [dpdk-dev] [dpdk-stable] [PATCH] doc: fix incorrect create bonding command in testpmd

Hi Shreyansh, > -Original Message- > From: Yigit, Ferruh > Sent: Monday, July 23, 2018 9:49 PM > To: Shreyansh Jain ; dev@dpdk.org > Cc: Iremonger, Bernard ; Wu, Jingjing > ; Lu, Wenzhuo ; > Mcnamara, John ; sta...@dpdk.org > Subject: Re: [dpdk-stable] [PATCH] doc: fix incorrect create bon

Re: [dpdk-dev] [PATCH] sched: add 64-bit counter retrieval API

Hi Stephen, Sorry about the delay in responding to your comment. Maybe I'm missing something but I don't consider 64-bit counter rollover to be a problem. The DPDK QoS stats are just 32-bits wide and are zeroed when read. So if we read them frequently enough the 32-bit counters won't wrap. This

Re: [dpdk-dev] [PATCH] app/testpmd: fix testpmd exit using ctrl+d

> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Dumitrescu, Cristian > Sent: Tuesday, July 24, 2018 5:59 PM > To: Mordechay Haimovsky ; Thomas Monjalon > ; Singh, Jasvinder > > Cc: dev@dpdk.org; Iremonger, Bernard ; Pattan, > Reshma ; > olivier.m...@6wind.c

Re: [dpdk-dev] [PATCH] mk: fix application compilation with lmnl and mlx5

On Wed, Jul 25, 2018 at 06:39:32AM +, Shahaf Shuler wrote: > Tuesday, July 24, 2018 6:14 PM, Adrien Mazarguil: > > Subject: Re: [PATCH] mk: fix application compilation with lmnl and mlx5 > > On Tue, Jul 24, 2018 at 01:03:28PM +, Shahaf Shuler wrote: > > > Tuesday, July 24, 2018 3:56 PM, Adr

Re: [dpdk-dev] [PATCH v2] ip_frag: extend rte_ipv6_frag_get_ipv6_fragment_header()

Hi Cody, > -Original Message- > From: Cody Doucette [mailto:douce...@bu.edu] > Sent: Thursday, July 19, 2018 4:58 PM > To: Ananyev, Konstantin ; Olivier Matz > ; Dumitrescu, Cristian > > Cc: dev@dpdk.org; mic...@digirati.com.br; Cody Doucette ; > Qiaobin Fu > Subject: [PATCH v2] ip_fra

Re: [dpdk-dev] [PATCH] vhost: fix return value

On Wed, Jul 25, 2018 at 04:21:42PM +0800, Jiayu Hu wrote: This patch fixes the incorrect return value for rte_vhost_dequeue_burst() when virtqueue is not enabled or virtqueue address translation fails. Fixes: 62250c1d0978 ("vhost: extract split ring handling from Rx and Tx functions") An alte

[dpdk-dev] [Bug 76] 2MB hugepages with IOMMU and passthrough not working

https://bugs.dpdk.org/show_bug.cgi?id=76 Bug ID: 76 Summary: 2MB hugepages with IOMMU and passthrough not working Product: DPDK Version: 18.05 Hardware: All OS: All Status: CONFIRMED Severity: normal

Re: [dpdk-dev] [PATCH] net/mlx5: fix linkage error for glue lib

On Wed, Jul 25, 2018 at 07:38:39AM +, Yaroslav Brustinov (ybrustin) wrote: > +Hanoch > > I've added -std=c11 flag to our compilation to check. > > Without alignas(max_align_t): > /usr/bin/ld: Warning: alignment 8 of symbol `mlx5_glue' in > src/dpdk/drivers/net/mlx5/mlx5_glue.c.11.o is smalle

[dpdk-dev] [PATCH] doc: add note for builtin-net-driver option

If builtin-net-driver option is enabled, simple vhost device will not enable protocol feature bit. QEMU vhost net device startup will be failed without protocol feature. Then QEMU process will be aborted when reloading virtio net driver due to previous failure. Signed-off-by: Marvin Liu diff --g

Re: [dpdk-dev] [PATCH] app/testpmd: fix testpmd exit using ctrl+d

> -Original Message- > From: Ananyev, Konstantin > Sent: Wednesday, July 25, 2018 10:04 AM > To: Dumitrescu, Cristian ; Mordechay > Haimovsky ; Thomas Monjalon > ; Singh, Jasvinder > Cc: dev@dpdk.org; Iremonger, Bernard ; > Pattan, Reshma ; olivier.m...@6wind.com > Subject: RE: [dpdk-de

[dpdk-dev] [PATCH v2] net/bonding: fix race condition

Race condition can appear in the bond_mode_8023ad_periodic_cb() callback when bonding port is stopped, reconfigured and restarted. Re-ordered calls in bond_ethdev_start() to have callback alarm set after slave ports are reconfigured. Fixes: 2efb58cbab6e ("bond: new link bonding library") Cc: sta.

[dpdk-dev] [PATCH] examples/ipsec-secgw: add 3des-cbc support

Signed-off-by: Hemant Agrawal --- doc/guides/sample_app_ug/ipsec_secgw.rst | 3 ++- examples/ipsec-secgw/esp.c | 3 +++ examples/ipsec-secgw/sa.c| 11 ++- 3 files changed, 15 insertions(+), 2 deletions(-) diff --git a/doc/guides/sample_app_ug/ipsec_secgw.r

Re: [dpdk-dev] Accessing "device_id" from "rte_pci_device"

Hi Rami Rosen, et al, Thanks for the response. Yes I can see in the code that rte_device struct is part of rte_eth_dev_info. I tried to apply the patch you pointed o n 17.11.3. But it failed at many places. We don't want to migrate to 18.05 as it is not a s

Re: [dpdk-dev] Accessing "device_id" from "rte_pci_device"

Hi Santosh, My personal opinion is: Look at the patch in http://patchwork.dpdk.org/patch/37654/ Three lines were changes in rte_ethdev.c and rte_ethdev.h: lib/librte_ether/rte_ethdev.c | 1 + lib/librte_ether/rte_ethdev.h | 2 +- Take these changes as a basis, and add everythi

[dpdk-dev] [PATCH] net/mlx5: fix invalid network interface index value

Network interface indices being unsigned, an invalid index or error is normally expressed through a zero value (see if_nametoindex()). mlx5_ifindex() has a signed return type for negative values in case of error. Since mlx5_nl.c does not check for errors, these may be fed back as invalid interface

[dpdk-dev] [PATCH v2] doc: fix incorrect create bonding command in testpmd

Fixes: ac718398f477 ("doc: testpmd application user guide") Cc: bernard.iremon...@intel.com Cc: sta...@dpdk.org Signed-off-by: Shreyansh Jain Reviewed-by: Ferruh Yigit Acked-by: Bernard Iremonger --- v2: Update the Fixes line to represent the first commit rather than the formatting patch

Re: [dpdk-dev] [PATCH] app/testpmd: fix testpmd exit using ctrl+d

> -Original Message- > From: Dumitrescu, Cristian > Sent: Wednesday, July 25, 2018 10:36 AM > To: Ananyev, Konstantin ; Mordechay Haimovsky > ; Thomas Monjalon > ; Singh, Jasvinder > Cc: dev@dpdk.org; Iremonger, Bernard ; Pattan, > Reshma ; > olivier.m...@6wind.com > Subject: RE: [dpd

Re: [dpdk-dev] [PATCH] app/testpmd: fix testpmd exit using ctrl+d

This is how we reproduce the issue : app/testpmd -n 4 --vdev="net_tap0,iface=tap0,remote=eth1" -- --burst=64 --mbcache=512 -i --rxq=2 --txq=2 --txd=512 --rxd=512 --port-topology=chained --forward-mode=rxonly > -Original Message- > From: Ananyev, Konstantin [mailto:konstantin.anan..

Re: [dpdk-dev] [PATCH] app/testpmd: fix testpmd exit using ctrl+d

> -Original Message- > From: Ananyev, Konstantin > Sent: Wednesday, July 25, 2018 12:39 PM > To: Dumitrescu, Cristian ; Mordechay > Haimovsky ; Thomas Monjalon > ; Singh, Jasvinder > Cc: dev@dpdk.org; Iremonger, Bernard ; > Pattan, Reshma ; olivier.m...@6wind.com; Van > Haaren, Harry >

Re: [dpdk-dev] [PATCH] app/testpmd: fix testpmd exit using ctrl+d

> -Original Message- > From: Dumitrescu, Cristian > Sent: Wednesday, July 25, 2018 12:57 PM > To: Ananyev, Konstantin ; Mordechay Haimovsky > ; Thomas Monjalon > ; Singh, Jasvinder > Cc: dev@dpdk.org; Iremonger, Bernard ; Pattan, > Reshma ; > olivier.m...@6wind.com; Van Haaren, Harry

Re: [dpdk-dev] [PATCH] app/testpmd: fix testpmd exit using ctrl+d

> -Original Message- > From: Ananyev, Konstantin > Sent: Wednesday, July 25, 2018 1:18 PM > To: Dumitrescu, Cristian ; Mordechay Haimovsky > ; Thomas Monjalon ; Singh, Jasvinder > > Cc: dev@dpdk.org; Iremonger, Bernard ; Pattan, > Reshma ; olivier.m...@6wind.com; Van Haaren, Harry > > Sub

[dpdk-dev] [pull-request] next-eventdev 18.08 RC2

The following changes since commit 711f43ba568acadf6cbccb9f8a29abf0fb3baa25: examples/vm_power: make branch ratio configurable (2018-07-21 00:00:43 +0200) are available in the Git repository at: http://dpdk.org/git/next/dpdk-next-eventdev for you to fetch changes up to f094d5a870e88536eab6

Re: [dpdk-dev] [PATCH] app/testpmd: fix testpmd exit using ctrl+d

> -Original Message- > From: Ananyev, Konstantin > Sent: Wednesday, July 25, 2018 1:18 PM > To: Dumitrescu, Cristian ; Mordechay > Haimovsky ; Thomas Monjalon > ; Singh, Jasvinder > Cc: dev@dpdk.org; Iremonger, Bernard ; > Pattan, Reshma ; olivier.m...@6wind.com; Van > Haaren, Harry >

Re: [dpdk-dev] [PATCH] net/i40e: fix multiple device arguments parsing error

Hi Beilei > -Original Message- > From: Xing, Beilei > Sent: Wednesday, July 25, 2018 2:37 PM > To: Zhang, Qi Z > Cc: dev@dpdk.org; Stillwell Jr, Paul M ; > sta...@dpdk.org > Subject: [PATCH] net/i40e: fix multiple device arguments parsing error > > There will be parsing error when using

[dpdk-dev] [PATCH v3 2/2] app/testpmd: fix help string for tm commit cmd

Fixes: 996cb153af06 ("app/testpmd: add commands for TM nodes and hierarchy commit") Cc: jasvinder.si...@intel.com Signed-off-by: Krzysztof Kanas --- app/test-pmd/cmdline_tm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/test-pmd/cmdline_tm.c b/app/test-pmd/cmdline_tm.

[dpdk-dev] [PATCH v3 1/2] app/testpmd: fix use of uninitialized field

print_err_msg uses message field that may be not initialized causing segmentation fault. Fixes: 12f76f5247e2 ("app/testpmd: add command to resume a TM node") Cc: t...@semihalf.com Signed-off-by: Krzysztof Kanas --- v3: Fix the Fixes: commit message line --- app/test-pmd/cmdline_tm.c | 19 ++

Re: [dpdk-dev] [PATCH] net/mlx5: fix count query when flow has not counters

> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Nelio Laranjeiro > Sent: Wednesday, July 25, 2018 11:46 AM > To: dev@dpdk.org; Shahaf Shuler ; Yongseok Koh > > Subject: [dpdk-dev] [PATCH] net/mlx5: fix count query when flow has not > counters > > Querying a

[dpdk-dev] [PATCH v1] doc/samples: update vm power manager sample docs

Add information on the ability of guest app to sent a policy to the host app. Add information on the branch ratio out-of-band method of workload monitoring and power management. Signed-off-by: David Hunt --- .../sample_app_ug/vm_power_management.rst | 165 -- 1 file changed,

Re: [dpdk-dev] [PATCH] net/mlx5: fix possible endless loop when clearing flow flags

Wednesday, July 25, 2018 9:59 AM, Nélio Laranjeiro: > Subject: Re: [PATCH] net/mlx5: fix possible endless loop when clearing flow > flags > > On Tue, Jul 24, 2018 at 09:47:19PM +, Yongseok Koh wrote: > > > > > On Jul 23, 2018, at 11:57 PM, Nélio Laranjeiro > wrote: > > > > > > On Mon, Jul 23,

Re: [dpdk-dev] [PATCH v4] app/eventdev: use proper teardown sequence

-Original Message- > Date: Tue, 24 Jul 2018 21:09:50 +0530 > From: Jerin Jacob > To: Pavan Nikhilesh > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v4] app/eventdev: use proper teardown > sequence > User-Agent: Mutt/1.10.1 (2018-07-13) > > -Original Message- > > Date: Tue,

Re: [dpdk-dev] [PATCH] net/mlx5: fix queue rollback when starting device

Monday, July 23, 2018 11:57 PM, Yongseok Koh: > Subject: [PATCH] net/mlx5: fix queue rollback when starting device > > mlx5_rxq_start() and mlx5_rxq_stop() must be strictly paired because > internal reference counter is increased or decreased inside. Also, > mlx5_rxq_get() must be paired with mlx5

Re: [dpdk-dev] [PATCH] event/octeontx: remove unnecessary port start and stop in Rx adapter

-Original Message- > Date: Tue, 24 Jul 2018 21:08:04 +0530 > From: Jerin Jacob > To: Pavan Nikhilesh > Cc: dev@dpdk.org, sta...@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] event/octeontx: remove unnecessary port > start and stop in Rx adapter > User-Agent: Mutt/1.10.1 (2018-07-13) > > --

[dpdk-dev] [PATCH v2] net/mlx5: fix linkage error for glue lib

From: Yaroslav Brustinov addressing a gcc 4.7.2 bug that cannot be reproduced with latter versions: "bin/ld: Warning: alignment 8 of symbol `mlx5_glue' in src/dpdk/drivers/net/mlx5/mlx5_glue.c.21.o is smaller than 16 in src/dpdk/drivers/net/mlx5/mlx5_rxq.c.21.o" Fix it be forcing the alignment

Re: [dpdk-dev] [PATCH] app/testpmd: fix testpmd exit using ctrl+d

> -Original Message- > From: Van Haaren, Harry > Sent: Wednesday, July 25, 2018 1:27 PM > To: Ananyev, Konstantin ; Dumitrescu, > Cristian ; Mordechay Haimovsky > ; Thomas Monjalon ; > Singh, Jasvinder > Cc: dev@dpdk.org; Iremonger, Bernard ; > Pattan, Reshma ; olivier.m...@6wind.com >

Re: [dpdk-dev] [PATCH v2] ip_frag: extend rte_ipv6_frag_get_ipv6_fragment_header()

Hi Konstantin, On Wed, Jul 25, 2018 at 09:11:30AM +, Ananyev, Konstantin wrote: > Hi Cody, > > > -Original Message- > > From: Cody Doucette [mailto:douce...@bu.edu] > > Sent: Thursday, July 19, 2018 4:58 PM > > To: Ananyev, Konstantin ; Olivier Matz > > ; Dumitrescu, Cristian > > >

Re: [dpdk-dev] [PATCH v3 1/2] app/testpmd: fix use of uninitialized field

> -Original Message- > From: Krzysztof Kanas [mailto:krzysztof.ka...@caviumnetworks.com] > Sent: Wednesday, July 25, 2018 1:42 PM > To: Iremonger, Bernard ; > krzysztof.ka...@caviumnetworks.com; dev@dpdk.org; Lu, Wenzhuo > ; Wu, Jingjing > Cc: Nithin Dabilpuram ; Singh, Jasvinder > ; t...@

Re: [dpdk-dev] [PATCH v2] net/mlx5: fix linkage error for glue lib

On Wed, Jul 25, 2018 at 04:18:54PM +0300, Shahaf Shuler wrote: > From: Yaroslav Brustinov > > addressing a gcc 4.7.2 bug that cannot be reproduced with latter > versions: > > "bin/ld: Warning: alignment 8 of symbol `mlx5_glue' in > src/dpdk/drivers/net/mlx5/mlx5_glue.c.21.o is smaller than 16 in

Re: [dpdk-dev] [PATCH v3 2/2] app/testpmd: fix help string for tm commit cmd

> -Original Message- > From: Krzysztof Kanas [mailto:krzysztof.ka...@caviumnetworks.com] > Sent: Wednesday, July 25, 2018 1:42 PM > To: Iremonger, Bernard ; > krzysztof.ka...@caviumnetworks.com; dev@dpdk.org; Lu, Wenzhuo > ; Wu, Jingjing > Cc: Nithin Dabilpuram ; Singh, Jasvinder > > S

Re: [dpdk-dev] [PATCH] mk: fix application compilation with lmnl and mlx5

Wednesday, July 25, 2018 12:07 PM, Adrien Mazarguil: > Subject: Re: [PATCH] mk: fix application compilation with lmnl and mlx5 > > The approach of linking .a files instead of .so and still generate a dynamic > program also has drawbacks: duplication and link time issues with multiple > users. For

Re: [dpdk-dev] [PATCH] event/octeontx: prefetch mbuf instead of wqe

-Original Message- > Date: Tue, 17 Jul 2018 22:08:30 +0530 > From: santosh > To: Pavan Nikhilesh , > jerin.ja...@caviumnetworks.com > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] event/octeontx: prefetch mbuf instead of wqe > User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Geck

Re: [dpdk-dev] [PATCH] app/eventdev: fix order test service init

-Original Message- > Date: Fri, 13 Jul 2018 17:52:42 + > From: "Eads, Gage" > To: Pavan Nikhilesh , > "jerin.ja...@caviumnetworks.com" > CC: "dev@dpdk.org" , "sta...@dpdk.org" > Subject: RE: [dpdk-dev] [PATCH] app/eventdev: fix order test service init > > External Email > > >

Re: [dpdk-dev] [PATCH] app/testpmd: fix testpmd exit using ctrl+d

> -Original Message- > From: Dumitrescu, Cristian > Sent: Wednesday, July 25, 2018 1:41 PM > To: Ananyev, Konstantin ; Mordechay Haimovsky > ; Thomas Monjalon > ; Singh, Jasvinder > Cc: dev@dpdk.org; Iremonger, Bernard ; Pattan, > Reshma ; > olivier.m...@6wind.com; Van Haaren, Harry

[dpdk-dev] [PATCH v2] test: fix prefix discovery

Config file has moved, but the tests weren't updated to point to its new location. Update the code to find current prefix. Also, this function is duplicated across multiple tests, so move it into process.h and force compile failures for any attempts to use it on platforms other than Linux. Fixes:

[dpdk-dev] [PATCH v2] app/testpmd: removed softnic CLI modifications

This patch reverts the testpmd CLI prompt routine modifications done in order to support softnic. The reason of doing so is due to testpmd abnormal exit observed on several setups caused by the softnic modifications to this routine, for example: When running testpmd with tap interface (/app/testpmd

Re: [dpdk-dev] [PATCH v2] app/testpmd: removed softnic CLI modifications

+Cc 25/07/2018 16:40, Moti Haimovsky: > This patch reverts the testpmd CLI prompt routine modifications done > in order to support softnic. > The reason of doing so is due to testpmd abnormal exit observed on > several setups caused by the softnic modifications to this routine, > for example: When

[dpdk-dev] [PATCH] net/mlx4: verify RSS supports num Rx Qs being used

This patch verifies that the number of Rx queues configured for RSS is supported by the device hardware. RSS support in mlx4 requires contiguous chunk of QPs to be reserved, there is a hardware limitation on the amount of contiguous QPs which is reported by the hardware. Ignoring this value will ca

Re: [dpdk-dev] [PATCH v2] app/testpmd: removed softnic CLI modifications

> -Original Message- > From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Wednesday, July 25, 2018 3:43 PM > To: Moti Haimovsky > Cc: dev@dpdk.org; sta...@dpdk.org; Singh, Jasvinder > ; Dumitrescu, Cristian > ; Ananyev, Konstantin > > Subject: Re: [PATCH v2] app/testpmd: removed

[dpdk-dev] [PATCH v3] app/testpmd: removed softnic CLI modifications

This patch reverts the testpmd CLI prompt routine modifications done in order to support softnic. The reason of doing so is due to testpmd abnormal exit observed on several setups caused by the softnic modifications to this routine, for example: When running testpmd with tap interface (/app/testpmd

Re: [dpdk-dev] [PATCH v3] app/testpmd: removed softnic CLI modifications

> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Moti Haimovsky > Sent: Wednesday, July 25, 2018 4:30 PM > To: tho...@monjalon.net > Cc: Singh, Jasvinder ; dev@dpdk.org; > sta...@dpdk.org; Moti Haimovsky > Subject: [dpdk-dev] [PATCH v3] app/testpmd: removed so

Re: [dpdk-dev] [PATCH] net/mlx5: fix linkage error for glue lib

+Hanoch I've added -std=c11 flag to our compilation to check. Without alignas(max_align_t): /usr/bin/ld: Warning: alignment 8 of symbol `mlx5_glue' in src/dpdk/drivers/net/mlx5/mlx5_glue.c.11.o is smaller than 32 in src/dpdk/drivers/net/mlx5/mlx5_rxq.c.11.o With alignas(max_align_t): /usr/bin/

Re: [dpdk-dev] [PATCH] net/mlx5: fix linkage error for glue lib

Hi, Are you OK with C11? I saw in file dpdk/drivers/net/mlx4/mlx4_utils.c: * C11 code would include stdalign.h and use alignof(max_align_t) however * we'll stick with C99 for the time being. :) As far as I understand, the issue is alignment of the pointer itself, not the struct. I'm

Re: [dpdk-dev] [PATCH] net/mlx5: fix linkage error for glue lib

Hi, Sounds good to me. Thanks, Yaroslav. -Original Message- From: Adrien Mazarguil [mailto:adrien.mazarg...@6wind.com] Sent: Wednesday, July 25, 2018 12:25 To: Yaroslav Brustinov (ybrustin) Cc: Shahaf Shuler ; Yongseok Koh ; dev@dpdk.org; sta...@dpdk.org; Nélio Laranjeiro ; Hanoch H

[dpdk-dev] [PATCH v4 0/6] compress: add Octeontx ZIP compression PMD

From: Shally Verma This patch series add compression PMD for cavium octeontx ZIP module in DPDK compress drivers. Currently PMD only tested for deflate, stateless compression and decompression with direct memory buffers. Changes in v4: - removed scatter-gather implementation as not tested - revi

[dpdk-dev] [PATCH v4 1/6] compress/octeontx: add octeontx zip PMD

From: Sunila Sahu Octentx zipvf PMD provides hardware acceleration for deflate and lzs compression and decompression operations using Octeontx zip co-processor, which provide 8 virtualized zip devices. This patch add basic initialization routine to register zip VFs to compressdev library. Signe

[dpdk-dev] [PATCH v4 2/6] compress/octeontx: add device setup PMD ops

Add compression PMD device and queue pair setup ops. Signed-off-by: Ashish Gupta Signed-off-by: Shally Verma Signed-off-by: Sunila Sahu --- drivers/compress/octeontx/otx_zip.c | 71 + drivers/compress/octeontx/otx_zip.h | 57 ++- drivers/compress/octeontx/otx_zip_pmd.c |

[dpdk-dev] [PATCH v4 3/6] compress/octeontx: create private xform

Create non-shareable private xform for applications to perform stateless compression/decompression. Signed-off-by: Ashish Gupta Signed-off-by: Shally Verma Signed-off-by: Sunila Sahu --- drivers/compress/octeontx/otx_zip.h | 19 +++- drivers/compress/octeontx/otx_zip_pmd.c | 149 +

[dpdk-dev] [PATCH v4 5/6] doc: add Octeonx zip guide

Add Octeontx ZIP PMD feature specification and user guide with build and run instructions. Signed-off-by: Ashish Gupta Signed-off-by: Shally Verma Signed-off-by: Sunila Sahu --- MAINTAINERS | 2 + doc/guides/compressdevs/features/octeontx.ini | 10 +++ doc/

[dpdk-dev] [PATCH v4 4/6] compress/octeontx: support burst enqueue/dequeue

Implement enqueue/dequeue APIs to perform compression/decompression operations Signed-off-by: Ashish Gupta Signed-off-by: Shally Verma Signed-off-by: Sunila Sahu --- drivers/compress/octeontx/otx_zip.c | 47 +++ drivers/compress/octeontx/otx_zip.h | 96 +-

[dpdk-dev] [PATCH v4 6/6] usertools: update devbind for octeontx zip device

From: Sunila Sahu Add the cavium octeontx zip pci device details. Signed-off-by: Ashish Gupta Signed-off-by: Shally Verma Signed-off-by: Sunila Sahu --- usertools/dpdk-devbind.py | 9 + 1 file changed, 9 insertions(+) diff --git a/usertools/dpdk-devbind.py b/usertools/dpdk-devbind.p

Re: [dpdk-dev] [PATCH] net/mlx5: fix invalid network interface index value

> On Jul 25, 2018, at 4:24 AM, Adrien Mazarguil > wrote: > > Network interface indices being unsigned, an invalid index or error is > normally expressed through a zero value (see if_nametoindex()). > > mlx5_ifindex() has a signed return type for negative values in case of > error. Since mlx5_

[dpdk-dev] [PATCH v6 1/4] test: add ring pmd based packet rx/tx for UT

Added ring pmd based packet rx/tx helper functions for verifying Latency, Bitrate and pdump lib UTs. Signed-off-by: Naga Suresh Somarowthu Reviewed-by: Reshma Pattan --- test/test/Makefile| 1 + test/test/sample_packet_forward.c | 115 ++ te

[dpdk-dev] [PATCH v6 2/4] test: add unit tests for bitrate library

Unit Test Cases for BitRate library. Signed-off-by: Naga Suresh Somarowthu Reviewed-by: Reshma Pattan Reviewed-by: Remy Horton --- test/test/Makefile| 1 + test/test/autotest_data.py| 6 ++ test/test/test_bitratestats.c | 227 ++ 3 fi

[dpdk-dev] [PATCH v6 4/4] test: add unit test for pdump library

Unit test cases are added for pdump library. Primary process will act as server, forks a child secondary process. Secondary process acts as client. Server will do pdump init to serve any pdump client requests. Server will create a vdev, send/receive packets continuously in a separate thread. Client

[dpdk-dev] [PATCH v6 0/4] add unit tests for bitrate, latency and pdump libraries

1/4: add ring pmd based packet helper functions for UT 2/4: unit test cases added for bitrate library 3/4: unit test cases added for latencystats library 4/4: unit test cases added for pdump library Patches 2/4,3/4 depends on 1/4 Patch 4/4 depends on 1/4 and the below patch http://patches.dpdk.org

[dpdk-dev] [PATCH v6 3/4] test: add unit tests for latencystats library

Unit Test Cases added for latencystats library. Signed-off-by: Naga Suresh Somarowthu Reviewed-by: Reshma Pattan --- test/test/Makefile| 1 + test/test/autotest_data.py| 6 ++ test/test/test_latencystats.c | 216 ++ 3 files changed, 22

[dpdk-dev] [PATCH 0/6] net/softnic: expose tmgr through firmware

This patchset provide the necessary Soft NIC firmware CLI commands to control the Traffic Manager (TMGR) through firmware. The Soft NIC TMGR function can now be controlled through either Soft NIC firmware or through the ethdev TM API (e.g. via test-pmd app). Cristian Dumitrescu (6): net/softnic

[dpdk-dev] [PATCH 1/6] net/softnic: add CLI command for tmgr create

From: Cristian Dumitrescu Add support to create Traffic Manager (TMGR) object through firmware CLI script. Signed-off-by: Cristian Dumitrescu Signed-off-by: Jasvinder Singh --- drivers/net/softnic/rte_eth_softnic.c | 17 +- drivers/net/softnic/rte_eth_softnic_cli.c | 32

[dpdk-dev] [PATCH 2/6] net/softnic: add CLI command for tmgr shaper profile

From: Cristian Dumitrescu Add support to create Traffic Manager (TMGR) shaper profile through firmware CLI script. Signed-off-by: Cristian Dumitrescu Signed-off-by: Jasvinder Singh --- drivers/net/softnic/parser.c | 18 ++ drivers/net/softnic/parser.h | 2 + d

[dpdk-dev] [PATCH 3/6] net/softnic: add CLI command for tmgr shared shaper

From: Cristian Dumitrescu Add support to create Traffic Manager (TMGR) shared shaper through firmware CLI script. Signed-off-by: Cristian Dumitrescu Signed-off-by: Jasvinder Singh --- drivers/net/softnic/rte_eth_softnic_cli.c | 73 +++ 1 file changed, 73 insertions

[dpdk-dev] [PATCH 4/6] net/softnic: add CLI command for tmgr node addition

From: Cristian Dumitrescu Add support for adding Traffic Manager (TMGR) hierarchy node through firmware CLI script. Signed-off-by: Cristian Dumitrescu Signed-off-by: Jasvinder Singh --- drivers/net/softnic/rte_eth_softnic_cli.c | 171 ++ 1 file changed, 171 inserti

[dpdk-dev] [PATCH 6/6] net/softnic: add CLI command for default tmgr hierarchy

From: Cristian Dumitrescu Add support for creating default Traffic Manager (TMGR) hierarchy through firmware CLI script. Signed-off-by: Cristian Dumitrescu Signed-off-by: Jasvinder Singh --- drivers/net/softnic/rte_eth_softnic_cli.c | 498 ++ 1 file changed, 498 in

[dpdk-dev] [PATCH 5/6] net/softnic: add CLI command for tmgr hierarchy commit

From: Cristian Dumitrescu Add support for Traffic Manager (TMGR) hierarchy commit through firmware CLI script. Signed-off-by: Cristian Dumitrescu Signed-off-by: Jasvinder Singh --- drivers/net/softnic/rte_eth_softnic_cli.c | 47 +++ 1 file changed, 47 insertions(+)

Re: [dpdk-dev] [PATCH] net/mlx5: fix count query when flow has not counters

> On Jul 25, 2018, at 1:46 AM, Nelio Laranjeiro > wrote: > > Querying a counters on a flow without counter is ending with a > segmentation fault. > > Fixes: 60bd8c9747e8 ("net/mlx5: add count flow action") > > Signed-off-by: Nelio Laranjeiro > --- > drivers/net/mlx5/mlx5_flow.c | 56 +++

[dpdk-dev] [pull-request] next-pipeline 18.08 pre-rc2

The following changes since commit 9d6d5b4d470ba27243c42d1b369f098d8a6b9c60: app/crypto-perf: compile with -O3 (2018-07-24 01:48:10 +0200) are available in the git repository at: http://dpdk.org/git/next/dpdk-next-pipeline for you to fetch changes up to d85cb1311a0068cd6177019649fc4ae5463e

Re: [dpdk-dev] [PATCH 0/6] net/softnic: expose tmgr through firmware

> -Original Message- > From: Singh, Jasvinder > Sent: Wednesday, July 25, 2018 6:10 PM > To: dev@dpdk.org > Cc: Dumitrescu, Cristian > Subject: [PATCH 0/6] net/softnic: expose tmgr through firmware > > This patchset provide the necessary Soft NIC firmware CLI commands to > control the

Re: [dpdk-dev] [PATCH] config: reduce memory requirements for DPDK

On 07/24/2018 01:03 PM, Thomas Monjalon wrote: > 24/07/2018 13:04, Burakov, Anatoly: >> On 24-Jul-18 11:23 AM, Thomas Monjalon wrote: >>> 24/07/2018 12:03, Anatoly Burakov: It has been reported that current memory limitations do not work well on an 8-socket machines in default configurati

[dpdk-dev] [PATCH] doc: fix spelling error in vdev_netvsc

Signed-off-by: Stephen Hemminger --- doc/guides/nics/vdev_netvsc.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/guides/nics/vdev_netvsc.rst b/doc/guides/nics/vdev_netvsc.rst index e02ae9acbac6..d1da07118783 100644 --- a/doc/guides/nics/vdev_netvsc.rst +++ b/doc/guides

Re: [dpdk-dev] [PATCH] ethdev: remove unused forward declaration.

On 25.07.2018 11:30, Rami Rosen wrote: The forward declaraion of rte_pci_device in rte_ethdev.h is not needed anymore. Fixes: cd8c7c7ce241 ("replace bus specific struct with generic dev") Signed-off-by: Rami Rosen Acked-by: Andrew Rybchenko

[dpdk-dev] [PATCH 0/4] small cleanups

These were discovered when running internal policy checker to try and get rid of potentially offensive language in DPDK. After looking at a couple of these places, they were also places where some improvement could be made. Stephen Hemminger (4): arm: remove profanity in comment bnx2x: remove

Re: [dpdk-dev] [PATCH] net/i40e: fix tx queue setup after stop queue

On 07/10/2018 11:37 AM, Shaopeng He wrote: > Currently, i40e_dev_tx_queue_setup_runtime checks simple tx and treats > mbuf fast free offloading as No-simple, which is classified as simple tx > in i40e_set_tx_function_flag. This inconsistent behavior causes tx queue > setup fail after queue was stop

[dpdk-dev] [PATCH 2/4] bnx2x: remove profanity

No need for profanity in comments. Signed-off-by: Stephen Hemminger --- drivers/net/bnx2x/elink.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/bnx2x/elink.c b/drivers/net/bnx2x/elink.c index 34a29373af3b..08fe817720a1 100644 --- a/drivers/net/bnx2x/elink.c

[dpdk-dev] [PATCH 1/4] arm: remove profanity in comment

Update comment to describe the problem better without risk of being offensive. Signed-off-by: Stephen Hemminger --- lib/librte_eal/common/include/arch/arm/rte_cycles_32.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/librte_eal/common/include/arch/arm/rte_cycles_32.

[dpdk-dev] [PATCH 3/4] eal: don't crash if alarm set fails

There is no need to call rte_exit and crash the application here; better to let the application handle the error itself. Remove the gratuitous profanity which would be visible if the rte_exit was still there. Signed-off-by: Stephen Hemminger --- lib/librte_eal/common/eal_common_proc.c | 10

[dpdk-dev] [PATCH 4/4] ixgbe: remove mild profanity

At the tail end of comment about barriers (I feel your pain); remove mild profanity. Signed-off-by: Stephen Hemminger --- drivers/net/ixgbe/ixgbe_rxtx.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/ixgbe/ixgbe_rxtx.c b/drivers/net/ixgbe/ixgbe_rxtx.c index 354

Re: [dpdk-dev] [PATCH v2 00/15] enic PMD fixes and performance improvements

On 06/29/2018 10:29 AM, John Daley wrote: > Updated a few commits in the patchset per suggestions by Ferrus Yigit. > thanks, > John > > Hyong Youb Kim (12): > net/enic: fix receive packet types > net/enic: update the UDP RSS detection mechanism > net/enic: do not overwrite admin Tx queue lim

[dpdk-dev] deprecation of rte_pci_ioport_unmap()

Hi dpdk-dev, Shouldn't rte_pci_ioport_unmap() be deprecated ? No one calls this methods, still I did not find deprecation notice anywhere. Regards, Kevin

  1   2   >