Re: [dpdk-dev] MLX5 should define the timestamp field in the doc

2018-09-05 Thread Tom Barbette
Thanks for your answer Shahaf ! We're trying to measure the latency of packets going through various service chains inside individual "server". Eg. we can see that on Server 1, the latency for the service chain handling HTTP packets is ~800ns (+ max and mins, tail latency, etc). What we do no

Re: [dpdk-dev] eventdev: method for finding out unlink status

2018-09-05 Thread Elo, Matias (Nokia - FI/Espoo)
>> >> I'm not sure I understand the issue here. >> Is anybody suggesting to make unlink() blocking? >> >> For certain PMDs, perhaps it must be a synchronous handled unlink(). >> For other PMDs (eg event/sw) there are multiple threads involved, >> so it must be async. Hence, APIs should be async

Re: [dpdk-dev] [PATCH 1/3] net/virtio-user: fix deadlock in memory events callback

2018-09-05 Thread Sean Harte
On 5 September 2018 at 05:28, Tiwei Bie wrote: > Deadlock can occur when allocating memory if a vhost-kernel > based virtio-user device is in use. To fix the deadlock, > we will take memory hotplug lock explicitly in virtio-user > when necessary, and always call the _thread_unsafe memory > functio

Re: [dpdk-dev] MLX5 should define the timestamp field in the doc

2018-09-05 Thread Shahaf Shuler
Thanks for the details. The use case is clear. We will take it internally to see when we can support it. AFAIK we cannot read the internal time from userspace. Adding also AlexR to comment From: Tom Barbette Sent: Wednesday, September 5, 2018 10:11 AM To: Shahaf Shuler ; dev@dpdk.org Cc: Yongse

Re: [dpdk-dev] [PATCH v2 3/4] app/test-eventdev: add Tx adapter support

2018-09-05 Thread Pavan Nikhilesh
On Wed, Sep 05, 2018 at 12:24:18PM +0530, Rao, Nikhil wrote: > On 9/4/2018 7:42 PM, Pavan Nikhilesh wrote: > > Convert existing Tx service based pipeline to Tx adapter based APIs and > > simplify worker functions. > > > > Signed-off-by: Pavan Nikhilesh > > --- > > app/test-eventdev/test_pipeline

Re: [dpdk-dev] MLX5 should define the timestamp field in the doc

2018-09-05 Thread Tom Barbette
Actually I managed this patch to implement support for rte_eth_timesync_read_time. Please tell me potential modifications, and if I shall submit it again as a "normal" patch to dev ? --- drivers/net/mlx5/mlx5.c| 1 + drivers/net/mlx5/mlx5.h| 1 + drivers/net/mlx5/mlx5_ethde

[dpdk-dev] [PATCH 2/2] net/bonding: inherit descriptor limits from slaves

2018-09-05 Thread Andrew Rybchenko
From: Ivan Malov Descriptor limits are used by applications to take optimal decisions on queue sizing. Signed-off-by: Ivan Malov Signed-off-by: Andrew Rybchenko --- drivers/net/bonding/rte_eth_bond_api.c | 54 ++ drivers/net/bonding/rte_eth_bond_pmd.c | 8 dr

[dpdk-dev] [PATCH 1/2] net/bonding: provide default Rx/Tx configuration

2018-09-05 Thread Andrew Rybchenko
From: Ivan Malov Default Rx/Tx configuration has become a helpful resource for applications relying on the optimal values to make rte_eth_rxconf and rte_eth_txconf structures. These structures can then be tweaked. Default configuration is also used internally by rte_eth_rx_queue_setup or rte_eth

Re: [dpdk-dev] [PATCH] doc: Clarify IOMMU usage with "uio-pci" kernel module

2018-09-05 Thread Stephen Hemminger
On Wed, 5 Sep 2018 00:20:29 + "Tone Zhang (Arm Technology China)" wrote: > Hi Rami, > > Yes, I mean “uio_pci_generic” kernel module. > > I will update the change accordingly. > > Thanks. > > Br, > Tone > > From: Rami Rosen > Sent: Wednesday, September 5, 2018 3:55 AM > To: Tone Zhang (A

Re: [dpdk-dev] [PATCH v2 3/4] app/test-eventdev: add Tx adapter support

2018-09-05 Thread Rao, Nikhil
On 9/5/2018 2:24 PM, Pavan Nikhilesh wrote: On Wed, Sep 05, 2018 at 12:24:18PM +0530, Rao, Nikhil wrote: On 9/4/2018 7:42 PM, Pavan Nikhilesh wrote: Convert existing Tx service based pipeline to Tx adapter based APIs and simplify worker functions. Signed-off-by: Pavan Nikhilesh --- app/tes

[dpdk-dev] [PATCH] test/event: remove RSS config in eth Rx adapter test

2018-09-05 Thread Nikhil Rao
Remove RSS config as it is not required (this also fixes an error with a hardcoded RSS config not supported by the NIC) Signed-off-by: Nikhil Rao Fixes: 8863a1fbfc66 ("ethdev: add supported hash function check") CC: sta...@dpdk.org --- test/test/test_event_eth_rx_adapter.c | 7 --- 1 file ch

Re: [dpdk-dev] [PATCH] doc: Clarify IOMMU usage with "uio-pci" kernel module

2018-09-05 Thread Tone Zhang (Arm Technology China)
-Original Message- From: Stephen Hemminger Sent: Wednesday, September 5, 2018 5:22 PM To: Tone Zhang (Arm Technology China) Cc: Rami Rosen ; dev@dpdk.org; nd Subject: Re: [dpdk-dev] [PATCH] doc: Clarify IOMMU usage with "uio-pci" kernel module On Wed, 5 Sep 2018 00:20:29 + "Tone

Re: [dpdk-dev] [PATCH 1/5] qat: remove redundant C register keyword

2018-09-05 Thread Jozwiak, TomaszX
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Stephen > Hemminger > Sent: Tuesday, July 31, 2018 6:31 PM > To: dev@dpdk.org > Cc: Stephen Hemminger > Subject: [dpdk-dev] [PATCH 1/5] qat: remove redundant C register keyword > > Modern C compilers ignore the

[dpdk-dev] [PATCH v5] net/mlx: add meson build support

2018-09-05 Thread Shahaf Shuler
From: Nelio Laranjeiro Compile Mellanox drivers when their external dependencies are met. A glue version of the driver can still be requested by using the -Denable_driver_mlx_glue=true To avoid modifying the whole sources and keep the compatibility with current build systems (e.g. make), the ml

[dpdk-dev] Change in binary name w/ meson build

2018-09-05 Thread Shahaf Shuler
Hi Bruce, Playing w/ meson build I got to know that the binary name for testpmd got changed to dpdk-testpmd. Not sure if it was discussed or not before, but such change will affect all the automation used to run testpmd w/ the old build system. What is the reason for the change in the name?

[dpdk-dev] [PATCH] test/event: fix eth Rx adapter autotest for skeleton PMD

2018-09-05 Thread Nikhil Rao
skeleton PMD does not support RTE_EVENT_ETH_RX_ADAPTER_CAP_MULTI_EVENTQ and implicit_release_disable so make the Rx queue_id = -1 and initialize the event port configuration to zero. Fixes: ec36d881f56d ("eventdev: add implicit release disable capability") Fixes: 2a9c83ae3b2e ("test/eventdev: add

Re: [dpdk-dev] [PATCH v3] net/i40e: add interface to choose latest vector path

2018-09-05 Thread Zhang, Qi Z
Hi Xiaoyun: > -Original Message- > From: Li, Xiaoyun > Sent: Tuesday, September 4, 2018 7:40 PM > To: Xing, Beilei ; Zhang, Qi Z > Cc: dev@dpdk.org; Yang, Zhiyong ; Richardson, > Bruce ; Hunt, David ; Li, > Xiaoyun > Subject: [PATCH v3] net/i40e: add interface to choose latest vector pat

[dpdk-dev] [PATCH 1/2] eventdev: fix port id argument in Rx adapter caps API

2018-09-05 Thread Nikhil Rao
Make the ethernet port id passed into rte_event_eth_rx_adapter_caps_get() 16 bit. Fixes: c2189c907dd1 ("eventdev: make ethdev port identifiers 16-bit") Cc: sta...@dpdk.org Signed-off-by: Nikhil Rao --- lib/librte_eventdev/Makefile | 2 +- lib/librte_eventdev/rte_eventdev.c | 2 +- lib/libr

[dpdk-dev] [PATCH 2/2] test/event: change ethernet port ids to be 16 bit

2018-09-05 Thread Nikhil Rao
Update the event rx adapter test to use 16 bit ethernet port ids. Fixes: c2189c907dd1 ("eventdev: make ethdev port identifiers 16-bit") Cc: sta...@dpdk.org Signed-off-by: Nikhil Rao --- test/test/test_event_eth_rx_adapter.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git

Re: [dpdk-dev] [PATCH v2] net/ixgbe: do not return internal code in rte_eth_dev_reset

2018-09-05 Thread Zhang, Qi Z
> -Original Message- > From: Luca Boccassi [mailto:bl...@debian.org] > Sent: Monday, September 3, 2018 10:18 PM > To: dev@dpdk.org > Cc: Lu, Wenzhuo ; Ananyev, Konstantin > ; Zhang, Qi Z ; Luca > Boccassi ; sta...@dpdk.org > Subject: [PATCH v2] net/ixgbe: do not return internal code in >

[dpdk-dev] [PATCH] examples/ipsec-secgw: increase the number of dev mappings

2018-09-05 Thread Anoob Joseph
Increasing the number of cdev mappings to accomodate usage of crypto devices with larger number of capabilities, with higher number of cores. Required mappings : ([no of ciphers] * [no of auth] + [aead algos]) * [no of cores] Signed-off-by: Ankur Dwivedi Signed-off-by: Anoob

Re: [dpdk-dev] [PATCH v2 10/10] kni: add API to set link status on kernel interface

2018-09-05 Thread Stephen Hemminger
On Mon, 3 Sep 2018 21:47:22 -0300 Dan Gora wrote: > Hi All, > > One other problem with using the sysfs method to change the link state > rather than this ioctl method. The sysfs/netdev method to change the > carrier was only introduced in kernel 3.9. For older kernels, we > would just be out o

Re: [dpdk-dev] [PATCH v1 1/2] eal: add nanosleep based delay function

2018-09-05 Thread Stephen Hemminger
On Mon, 3 Sep 2018 17:47:42 +0300 Ilya Maximets wrote: > > +void __rte_experimental > +rte_delay_us_sleep(unsigned int us) > +{ > + struct timespec wait[2]; > + int ind = 0; > + > + wait[0].tv_sec = 0; > + if (us >= US_PER_S) { > + wait[0].tv_sec = us / US_PER_S; >

[dpdk-dev] [PATCH] examples/eventdev_pipeline: add Tx adapter support

2018-09-05 Thread Pavan Nikhilesh
Signed-off-by: Pavan Nikhilesh --- This patch depends on the following series: http://patches.dpdk.org/project/dpdk/list/?series=1121 examples/eventdev_pipeline/main.c | 62 ++-- examples/eventdev_pipeline/pipeline_common.h | 31 +- .../pipeline_worker_generic.c

[dpdk-dev] [PATCH v2 1/2] test/event: fix eth Rx adapter autotest for skeleton PMD

2018-09-05 Thread Nikhil Rao
skeleton PMD does not support RTE_EVENT_ETH_RX_ADAPTER_CAP_MULTI_EVENTQ and implicit_release_disable so make the Rx queue_id = -1 and initialize the event port configuration to zero. Fixes: ec36d881f56d ("eventdev: add implicit release disable capability") Fixes: 2a9c83ae3b2e ("test/eventdev: add

[dpdk-dev] [PATCH v2 2/2] test/event: fix Rx adapter intr autotest for skeleton PMD

2018-09-05 Thread Nikhil Rao
skeleton PMD does not support RTE_EVENT_ETH_RX_ADAPTER_CAP_MULTI_EVENTQ so make the Rx queue_id = -1 and initialize the event port configuration to zero. Fixes: d65856999dd6 ("test/event: add Rx adapter tests for interrupt driven queues") Cc: nikhil@intel.com Signed-off-by: Nikhil Rao --- t

[dpdk-dev] [PATCH] test/event: add adapter tests to meson build

2018-09-05 Thread Nikhil Rao
Add tests for event eth Rx, crypto and timer adapters to meson build Cc: Abhinandan Gujjar Cc: Erik G. Carrillio Signed-off-by: Nikhil Rao --- test/test/meson.build | 7 +++ 1 file changed, 7 insertions(+) diff --git a/test/test/meson.build b/test/test/meson.build index b1dd6ec..1b2e8b7 1

[dpdk-dev] [PATCH v2] test/event: add adapter tests to meson build

2018-09-05 Thread Nikhil Rao
Add tests for event eth Rx, crypto and timer adapters to meson build Cc: Abhinandan Gujjar Cc: Erik G. Carrillo Signed-off-by: Nikhil Rao --- v2: * fix Erik's email address test/test/meson.build | 7 +++ 1 file changed, 7 insertions(+) diff --git a/test/test/meson.build b/test/test/meso

[dpdk-dev] [PATCH] test/eventdev: fix incorrect unit test

2018-09-05 Thread Pavan Nikhilesh
Enqueue, dequeue depths are only valid for event devs that have burst mode capability. Check event dev capability before testing depth boundary. Fixes: f8f9d233ea0e ("test/eventdev: add unit tests") Signed-off-by: Pavan Nikhilesh --- test/test/test_eventdev.c | 21 - 1 file

Re: [dpdk-dev] [RFC] ipsec: new library for IPsec data-path processing

2018-09-05 Thread Joseph, Anoob
Hi Konstantin, Please see inline. On 03-09-2018 23:51, Ananyev, Konstantin wrote: External Email Hi Anoob, Hi Konstantin, Few comments. Please see inline. Thanks, Anoob On 24-08-2018 22:23, Konstantin Ananyev wrote: External Email This RFC introduces a new library within DPDK: librte_

Re: [dpdk-dev] 18.05.1 patches review and test

2018-09-05 Thread Christian Ehrhardt
On Mon, Aug 27, 2018 at 11:29 AM Christian Ehrhardt < christian.ehrha...@canonical.com> wrote: > > > On Wed, Aug 22, 2018 at 9:26 AM Christian Ehrhardt < > christian.ehrha...@canonical.com> wrote: > >> Hi all, >> >> Here is a list of patches targeted for stable release 18.05.1. Please >> help revi

[dpdk-dev] [RFC] ethdev: add min/max MTU to device info

2018-09-05 Thread Stephen Hemminger
This addresses the usability issue raised by OVS at DPDK Userspace summit. It adds general min/max mtu into device info. For compatiablity, and to save space, it fits in a hole in existing structure. The initial version sets max mtu to normal Ethernet, it is up to PMD to set larger value if it sup

Re: [dpdk-dev] [PATCH v3] hash table: add an iterator over conflicting entries

2018-09-05 Thread Wang, Yipeng1
Hmm I see, it falls back to my original thought to have malloc inside the init function.. Thanks for the explanation. :) So I guess with your implementation, in future if we change the internal state to be larger, the ABI will be broken. BTW, this patch set also changes API so proper notice is

[dpdk-dev] ppc64: fix compilation of when AltiVec is enabled

2018-09-05 Thread dwilder
Hi Christian I am new to the list thus was unable to reply directly to your post: [PATCH v2] ppc64: fix compilation of when AltiVec is enabled I reproduce the build error on my ppc64le box and verified that your V2 patch corrects the build failure on both RHEL 7.5 and Ubuntu 18.04. Thanks fo

Re: [dpdk-dev] [PATCH] test/bpf: use hton instead of __builtin_bswap

2018-09-05 Thread Malvika Gupta
Hi Ananyev, I used clang version 6.0.0. Please see the following output for your reference. $ clang -v clang version 6.0.0-1ubuntu2 (tags/RELEASE_600/final) Target: aarch64-unknown-linux-gnu Thread model: posix InstalledDir: /usr/bin Found candidate GCC installation: /usr/bin/../lib/gcc/aarch64

Re: [dpdk-dev] [PATCH v3] hash table: add an iterator over conflicting entries

2018-09-05 Thread Honnappa Nagarahalli
-Original Message- From: Michel Machado Sent: Tuesday, September 4, 2018 2:37 PM To: Honnappa Nagarahalli ; Qiaobin Fu ; bruce.richard...@intel.com; pablo.de.lara.gua...@intel.com Cc: dev@dpdk.org; douce...@bu.edu; keith.wi...@intel.com; sameh.gobr...@intel.com; charlie@intel.com;

[dpdk-dev] [PATCH v1] examples/ipsec-secgw: increase the number of dev mappings

2018-09-05 Thread Anoob Joseph
Increasing the number of cdev mappings to accommodate usage of crypto devices with larger number of capabilities, with higher number of cores. Required mappings : ([no of ciphers] * [no of auth] + [aead algos]) * [no of cores] Signed-off-by: Ankur Dwivedi Signed-off-by: Anoob

Re: [dpdk-dev] [PATCH 1/3] security: support pdcp protocol

2018-09-05 Thread Joseph, Anoob
Hi Akhil, Please see inline. Thanks, Anoob On 28-08-2018 18:31, akhil.go...@nxp.com wrote: External Email From: Akhil Goyal Signed-off-by: Hemant Agrawal Signed-off-by: Akhil Goyal --- doc/guides/prog_guide/rte_security.rst | 90 -- lib/librte_security/rte_secur

[dpdk-dev] [PATCH] vhost: fix return value on enqueue path

2018-09-05 Thread Tiwei Bie
Fixes: 62250c1d0978 ("vhost: extract split ring handling from Rx and Tx functions") Fixes: a922401f35cc ("vhost: add Rx support for packed ring") Cc: sta...@dpdk.org Signed-off-by: Tiwei Bie --- lib/librte_vhost/virtio_net.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --g

Re: [dpdk-dev] [PATCH] net/ixgbe: fix ixgbevf link status

2018-09-05 Thread Zhang, Qi Z
Hi Yanglong: > -Original Message- > From: Wu, Yanglong > Sent: Friday, August 10, 2018 4:10 PM > To: dev@dpdk.org > Cc: Xu, Rosen ; Wang, Dong1 ; > Zhang, Qi Z ; Wu, Yanglong > Subject: [PATCH] net/ixgbe: fix ixgbevf link status > > For ixgbevf kernel driver, link status changes from dow

Re: [dpdk-dev] [RFC] ethdev: add min/max MTU to device info

2018-09-05 Thread Shahaf Shuler
Wednesday, September 5, 2018 7:42 PM, Stephen Hemminger: > Subject: [dpdk-dev] [RFC] ethdev: add min/max MTU to device info > > This addresses the usability issue raised by OVS at DPDK Userspace summit. > It adds general min/max mtu into device info. For compatiablity, and to save > space, it fits

[dpdk-dev] [PATCH 0/3] introduces the ENETC PMD

2018-09-05 Thread Gagandeep Singh
This patch set introduces the PMD which integrates with the existing PCI bus. Document is also part of the set Gagandeep Singh (3): doc: add usage doc for ENETC PMD net/enetc: add ENETC PMD with basic operations net/enetc: enable Rx and Tx MAINTAINERS | 7

[dpdk-dev] [PATCH 2/3] net/enetc: add ENETC PMD with basic operations

2018-09-05 Thread Gagandeep Singh
This patch introduces the enetc PMD with basic initialisation functions includes probe, teardown, hardware intialisation Signed-off-by: Gagandeep Singh --- MAINTAINERS | 1 + config/common_base | 5 + config/common_linuxapp

[dpdk-dev] [PATCH 3/3] net/enetc: enable Rx and Tx

2018-09-05 Thread Gagandeep Singh
Add RX and TX queue setup, datapath functions and enable the packet parsing Signed-off-by: Gagandeep Singh --- MAINTAINERS | 1 + drivers/net/enetc/Makefile | 3 +- drivers/net/enetc/enetc_ethdev.c | 6 +- drivers/net/enetc/enetc_rxtx.c | 447 ++

[dpdk-dev] [PATCH 1/3] doc: add usage doc for ENETC PMD

2018-09-05 Thread Gagandeep Singh
Add enetc usage document to compile and run the DPDK application on enetc supported platform. This document introduces the enetc driver, supported platforms and supported features. Signed-off-by: Gagandeep Singh --- MAINTAINERS| 5 + doc/guides/nics/enetc.rst |

Re: [dpdk-dev] IXGBE throughput loss with 4+ cores

2018-09-05 Thread Saber Rezvani
On 08/29/2018 11:22 PM, Wiles, Keith wrote: > >> On Aug 29, 2018, at 12:19 PM, Saber Rezvani wrote: >> >> >> >> On 08/29/2018 01:39 AM, Wiles, Keith wrote: On Aug 28, 2018, at 2:16 PM, Saber Rezvani wrote: On 08/28/2018 11:39 PM, Wiles, Keith wrote: > Which versio

[dpdk-dev] [PATCH v1 1/2] vhost: introduce rte_vdpa_get_device_num api

2018-09-05 Thread Xiaolong Ye
Signed-off-by: Xiaolong Ye --- lib/librte_vhost/rte_vdpa.h | 3 +++ lib/librte_vhost/vdpa.c | 6 ++ 2 files changed, 9 insertions(+) diff --git a/lib/librte_vhost/rte_vdpa.h b/lib/librte_vhost/rte_vdpa.h index 90465ca26..b8223e337 100644 --- a/lib/librte_vhost/rte_vdpa.h +++ b/lib/librte

[dpdk-dev] [PATCH v1 2/2] examples/vdpa: add a new sample for vdpa

2018-09-05 Thread Xiaolong Ye
From: Xiao Wang This patch adds a sample which creates vhost-user socket based on vdpa driver. vdpa driver can help to set up vhost datapath so this app doesn't need to spend a dedicated worker thread on vhost enqueue/dequeue operations. Below are setup steps for your reference (using IFC driver

Re: [dpdk-dev] [RFC] ethdev: add min/max MTU to device info

2018-09-05 Thread Andrew Rybchenko
On 09/05/2018 07:41 PM, Stephen Hemminger wrote: This addresses the usability issue raised by OVS at DPDK Userspace summit. It adds general min/max mtu into device info. For compatiablity, and to save space, it fits in a hole in existing structure. It is true for amd64, but it looks like it is

[dpdk-dev] [PATCH] net/mlx5: fix wrong representor port link status

2018-09-05 Thread Xueming Li
Current code uses PF links status for representor port, not the representor interface itself. This caused wrong representor port link status when toggling linterface up or down. Fixes: 5a4b8e2612c5 ("net/mlx5: probe all port representors") Cc: adrien.mazarg...@6wind.com Signed-off-by: Xueming Li