Re: [dpdk-dev] [PATCH v5 06/11] net/virtio-user: add option to use packed queues

> -Original Message- > From: dev On Behalf Of Jens Freimann > Sent: Friday, September 7, 2018 2:20 AM > To: dev@dpdk.org > Cc: tiwei@intel.com; maxime.coque...@redhat.com > Subject: [dpdk-dev] [PATCH v5 06/11] net/virtio-user: add option to use > packed queues > > From: Yuanhan Liu

Re: [dpdk-dev] [PATCH] devtools: use bash for checkpatches.sh

On Fri, Aug 31, 2018 at 10:00 AM, Arnon Warshavsky wrote: > On Thu, Aug 30, 2018 at 4:00 PM, Andrzej Ostruszka wrote: > >> On some systems /bin/sh does not support '-d' option of 'read'. >> So instead of /bin/sh use /bin/bash. >> >> Fixes: 7413e7f2aeb3 ("devtools: alert on new calls to exit from

Re: [dpdk-dev] [PATCH v13] devtools: alert on new instances of rte_panic and rte_exit

On Mon, Sep 10, 2018 at 8:17 AM, Arnon Warshavsky wrote: > I get some warning when running this on Ubuntu 18.04. >> >> >> marchand@gribouille:~/git/dpdk$ ./devtools/checkpatches.sh >> sanity/0001-mbuf-add-sanity-checks-on-segment-metadata.patch >> ./devtools/checkpatches.sh: 52: read: Illegal opti

Re: [dpdk-dev] [PATCH v5 05/11] net/virtio: dump packed virtqueue data

On Mon, Sep 10, 2018 at 06:02:19AM +, Gavin Hu (Arm Technology China) wrote: > > > > -Original Message- > > From: dev On Behalf Of Jens Freimann > > Sent: Friday, September 7, 2018 2:20 AM > > To: dev@dpdk.org > > Cc: tiwei@intel.com; maxime.coque...@redhat.com > > Subject: [dpdk

Re: [dpdk-dev] [PATCH v13] devtools: alert on new instances of rte_panic and rte_exit

I get some warning when running this on Ubuntu 18.04. > > marchand@gribouille:~/git/dpdk$ ./devtools/checkpatches.sh > sanity/0001-mbuf-add-sanity-checks-on-segment-metadata.patch > ./devtools/checkpatches.sh: 52: read: Illegal option -d > > Hi, A patch that fixes that was already sent a few days

[dpdk-dev] [PATCH] app/test-crypto-perf: fix double allocation of memory

The field, 'cipher_iv.data' is allocated twice when cipher is not null. Ideally the allocation should depend only on the field 'cperf_options.cipher_iv_sz'. This will make sure this code path gets valid for ciphers which doesn't require IV. Fixes: 0fbd75a99fc9 ("cryptodev: move IV parameters to se

Re: [dpdk-dev] [PATCH v3 0/8] Add Marvell NETA PMD

On 31.08.2018 14:59, Andrzej Ostruszka wrote: > This patch series introduces new PMD for Marvell NETA adapters (MVNETA). > See the documentation for more info. [...] Hello all I'd appreciate comments on this patch series. So far I have received one comment for the redundant license text when SPD

Re: [dpdk-dev] [PATCH v5 02/11] net/virtio: add virtio 1.1 defines

On Mon, Sep 10, 2018 at 05:22:43AM +, Gavin Hu (Arm Technology China) wrote: > The following 1.1 new defines should be added in this patch or the parent > patch. > VIRTIO_F_IO_BARRIER > VIRTIO_F_SR_IOV I don't think we should introduce these defines in this patch or this series. This series s

Re: [dpdk-dev] [PATCH v13] devtools: alert on new instances of rte_panic and rte_exit

On Tue, Jul 31, 2018 at 2:38 PM, Thomas Monjalon wrote: > 27/07/2018 00:10, Arnon Warshavsky: >> This patch adds a new function that is called >> per every checked patch, >> and alerts for new instances of rte_panic/rte_exit. >> The check excludes comments, and alerts in the case >> of a positive

Re: [dpdk-dev] [PATCH v5 05/11] net/virtio: dump packed virtqueue data

> -Original Message- > From: dev On Behalf Of Jens Freimann > Sent: Friday, September 7, 2018 2:20 AM > To: dev@dpdk.org > Cc: tiwei@intel.com; maxime.coque...@redhat.com > Subject: [dpdk-dev] [PATCH v5 05/11] net/virtio: dump packed virtqueue > data > > Add support to dump packed v

Re: [dpdk-dev] [PATCH 2/3] mbuf: add a non fatal sanity check helper

On Mon, Sep 10, 2018 at 7:45 AM, David Marchand wrote: > Let's add a little helper that does the same as rte_mbuf_sanity_check but > without the panic. > > Signed-off-by: David Marchand > --- > lib/librte_mbuf/Makefile | 2 + > lib/librte_mbuf/meson.build | 2 + > lib/libr

Re: [dpdk-dev] [PATCH v5 01/11] net/virtio: vring init for packed queues

> -Original Message- > From: dev On Behalf Of Jens Freimann > Sent: Friday, September 7, 2018 2:20 AM > To: dev@dpdk.org > Cc: tiwei@intel.com; maxime.coque...@redhat.com > Subject: [dpdk-dev] [PATCH v5 01/11] net/virtio: vring init for packed queues > > Add and initialize descripto

[dpdk-dev] [PATCH 3/3] app/testpmd: add sanity checks on received/sent packets

Make use of the newly introduced rte_mbuf_check() to (optionally) check all packets received/sent through a port. The idea behind this is to help to quickly identify badly formatted mbufs coming from the pmd on the rx side, and from the application on the tx side. Setting the verbose level to some

[dpdk-dev] [PATCH 2/3] mbuf: add a non fatal sanity check helper

Let's add a little helper that does the same as rte_mbuf_sanity_check but without the panic. Signed-off-by: David Marchand --- lib/librte_mbuf/Makefile | 2 + lib/librte_mbuf/meson.build | 2 + lib/librte_mbuf/rte_mbuf.c | 74 lib/lib

[dpdk-dev] [PATCH 0/3] segment sanity checks

Here is a little series which helped me identify a multi segment issue. Hope it can help others. The difference since the RFC patches I sent some time ago is that, rather than force the user to build the dpdk with CONFIG_RTE_LIBRTE_MBUF_DEBUG enabled, it uses rx/tx callbacks to apply checks on the

[dpdk-dev] [PATCH 1/3] mbuf: add sanity checks on segment metadata

Add some basic checks on the segments offset and length metadata: always funny to have a < 0 tailroom cast to uint16_t ;-). Signed-off-by: David Marchand --- lib/librte_mbuf/rte_mbuf.c | 5 + 1 file changed, 5 insertions(+) diff --git a/lib/librte_mbuf/rte_mbuf.c b/lib/librte_mbuf/rte_mbuf.

Re: [dpdk-dev] [PATCH v5 02/11] net/virtio: add virtio 1.1 defines

The following 1.1 new defines should be added in this patch or the parent patch. VIRTIO_F_IO_BARRIER VIRTIO_F_SR_IOV > -Original Message- > From: dev On Behalf Of Jens Freimann > Sent: Friday, September 7, 2018 2:20 AM > To: dev@dpdk.org > Cc: tiwei@intel.com; maxime.coque...@redhat.c

[dpdk-dev] [PATCH] mbuf: remove deprecated segment free functions

__rte_mbuf_raw_free and __rte_pktmbuf_prefree_seg have been deprecated for a long time now (early 17.05), are not part of the abi and are easily replaced with existing api. Signed-off-by: David Marchand --- lib/librte_mbuf/rte_mbuf.h | 16 1 file changed, 16 deletions(-) diff -

Re: [dpdk-dev] [PATCH 00/17] net/qede: add enhancements and fixes

On Sat, Sep 8, 2018 at 10:30 PM, Rasesh Mody wrote: > This patchset adds enhancements and fixes for QEDE PMD. > > Rasesh Mody (8): > net/qede/base: fix to handle stag update event > net/qede/base: add support for OneView APIs > net/qede/base: get pre-negotiated values for stag and bw > net

Re: [dpdk-dev] [PATCH v1 2/2] examples/vdpa: add a new sample for vdpa

On 09/10, Wang, Haiyue wrote: >Can we add options to support 'int rte_vdpa_find_device_id(struct >rte_vdpa_dev_addr *addr)' API calling >to get the device id ? Not just hard code 0 ~ num ? Like choosing one of >vDPA engines explicitly by BDF: >-w :06:00.2,vdpa=1 -w :06:00.3,vdpa=1 > G

Re: [dpdk-dev] [PATCH 3/3] net/virtio-user: fix memory hotplug support in vhost-kernel

On Fri, Sep 07, 2018 at 01:24:05PM +0100, Burakov, Anatoly wrote: > On 07-Sep-18 12:37 PM, Tiwei Bie wrote: > > On Fri, Sep 07, 2018 at 10:44:22AM +0100, Burakov, Anatoly wrote: > > > On 05-Sep-18 5:28 AM, Tiwei Bie wrote: > > > > It's possible to have much more hugepage backed memory regions > > >

Re: [dpdk-dev] [PATCH 2/3] net/virtio-user: avoid parsing process mappings

On Fri, Sep 07, 2018 at 01:21:35PM +0100, Burakov, Anatoly wrote: > On 07-Sep-18 12:35 PM, Tiwei Bie wrote: > > On Fri, Sep 07, 2018 at 10:39:16AM +0100, Burakov, Anatoly wrote: > > > On 05-Sep-18 5:28 AM, Tiwei Bie wrote: > > > > Recently some memory APIs were introduced to allow users to > > > >

Re: [dpdk-dev] [PATCH v1 2/2] examples/vdpa: add a new sample for vdpa

Can we add options to support 'int rte_vdpa_find_device_id(struct rte_vdpa_dev_addr *addr)' API calling to get the device id ? Not just hard code 0 ~ num ? Like choosing one of vDPA engines explicitly by BDF: -w :06:00.2,vdpa=1 -w :06:00.3,vdpa=1 BR, Haiyue > -Original Message---

[dpdk-dev] Question / possible issue with vdev_scan() in secondary process

Hi, I have a test case where vdev_scan() is being called in a secondary process as shown below in a snippet from the function. My test application is compiled with AddressSanitizer which was complaining about a memory leak of memory allocated in rte_mp_request_sync(). I added the free() call

Re: [dpdk-dev] [dpdk-stable] [PATCH v4] net/bonding: per-slave intermediate rx ring

On Sun, Sep 2, 2018 at 7:34 AM Matan Azrad wrote: > > Hi Luca\Chas > > From: Luca Boccassi > > On Wed, 2018-08-29 at 15:20 +, Matan Azrad wrote: > > > > > > From: Chas Williams > > > > On Tue, Aug 28, 2018 at 5:51 AM Matan Azrad > > > com> wrote: > > > > > > > > > > >