[dpdk-dev] strscpy() support to DPDK?

Hello, There has been some discussion earlier about the downsides of strlcpy(). How about adding strscpy() support to DPDK as a better option? It seems that it really resolves the API issues of strlcpy(). https://lwn.net/Articles/659214/ BR, -- Juhamatti

[dpdk-dev] [PATCH v3] net/i40e: add alarm handler

This patch adds alarm handler, and then i40e PF will use alarm handler instead of interrupt handler when device is started and Rx interrupt mode is disabled. This way will save CPU cycles during receiving packets. Signed-off-by: Beilei Xing --- drivers/net/i40e/i40e_ethdev.c | 67 +++

Re: [dpdk-dev] [PATCH] net/bonding: propagate promiscous mode in mode 4

On Mon, Aug 6, 2018 at 3:35 PM Matan Azrad wrote: > > > Hi Chas > > From: Chas Williams > >On Mon, Aug 6, 2018 at 1:46 PM Matan Azrad wrote: > >Hi Chas > > > >From: Chas Williams > >>On Fri, Aug 3, 2018 at 1:47 AM Matan Azrad > >> wrot

Re: [dpdk-dev] [PATCH] net/fm10k: add imissed stats

Hi, -Original Message- From: Julien Meunier [mailto:julien.meun...@nokia.com] Sent: Monday, September 10, 2018 11:51 PM To: Zhang, Qi Z ; Wang, Xiao W Cc: dev@dpdk.org Subject: [PATCH] net/fm10k: add imissed stats Add support of imissed and q_errors statistics, reported by PCIE_QPRDC re

Re: [dpdk-dev] [PATCH v2 5/5] vhost: message handling implemented as a callback array

On Mon, Sep 10, 2018 at 06:43:17PM +0200, Maxime Coquelin wrote: > Hi Ilya, > > On 09/10/2018 06:09 PM, Ilya Maximets wrote: > > Hi Maxime, > > Thanks for pointing to this patch set. I missed it somehow. > > > > This patch could not replace mine [1], because it does not improve > > the message ha

[dpdk-dev] [PATCH v7] linuxapp, eal: Fix the memory leak issue of logid

From: Ziye Yang This patch is used to fix the memory leak issue of logid. We use the ASAN test in SPDK when intergrating DPDK and find this memory leak issue. By the way, we also fix several missed function call of rte_atomic32_clear. Signed-off-by: Ziye Yang --- lib/librte_eal/linuxapp/eal/e

[dpdk-dev] [PATCH v4 4/4] build: generate API documentation with Meson

Signed-off-by: Luca Boccassi Acked-by: Bruce Richardson --- v2: made doxygen dependency optional, skip doxygen build when not found v3: made doxygen dependency mandatory if enable_docs is true, add alternative doc target that prints "doxygen not found" when doxygen is not found and enable

[dpdk-dev] [PATCH v4 2/4] mk: use templated doxygen config, modified on the fly

This will allow the same config file to be used from Meson. The result has been verified to be identical via diffoscope. Signed-off-by: Luca Boccassi Acked-by: Bruce Richardson --- v2: reordered generated fields as requested v4: add acked-by doc/api/doxy-api.conf| 87 --

[dpdk-dev] [PATCH v4 1/4] mk: use script to generate examples.dox

This will make it possible to generate the file in the same way from Meson as well. Signed-off-by: Luca Boccassi Acked-by: Bruce Richardson --- v2: simplified script by using exec > file v4: add acked-by doc/api/generate_examples.sh | 12 mk/rte.sdkdoc.mk | 5 + 2

[dpdk-dev] [PATCH v4 3/4] build: use same version as make showversion in Meson

make showversion will print 18.11.0-rc0 but Meson sets 18.11-rc0, causing among other things a difference in the generated documentation. Fixes: 76b9d9de5c7d ("version: 18.11-rc0") Signed-off-by: Luca Boccassi Acked-by: Thomas Monjalon Acked-by: Bruce Richardson --- v3: add acked-by meson.bu

[dpdk-dev] [PATCH 15/15] build: add Meson file for vmxnet3_uio PMD

Signed-off-by: Luca Boccassi --- drivers/net/meson.build | 4 +++- drivers/net/vmxnet3/meson.build | 19 +++ 2 files changed, 22 insertions(+), 1 deletion(-) create mode 100644 drivers/net/vmxnet3/meson.build diff --git a/drivers/net/meson.build b/drivers/net/meson.buil

[dpdk-dev] [PATCH 14/15] net/vmxnet3: rename version map after library file name

The library is called librte_pmd_vmxnet3_uio, so rename the map file and set the name in the meson file so that the built library names with meson and legacy makefiles are the same Signed-off-by: Luca Boccassi --- drivers/net/vmxnet3/Makefile| 2 +- ..._pmd_vm

[dpdk-dev] [PATCH 13/15] compress/octeontx: rename version map after library file name

The library is called librte_pmd_octeonx_compress, so rename the map file and set the name in the meson file so that the built library names with meson and legacy makefiles are the same Fixes: 43e610bb8565 ("compress/octeontx: introduce octeontx zip PMD") Cc: sta...@dpdk.org Signed-off-by: Luca B

[dpdk-dev] [PATCH 12/15] event/octeontx: rename version map after library file name

The library is called librte_pmd_octeonx_ssovf, so rename the map file and set the name in the meson file so that the built library names with meson and legacy makefiles are the same. Also refactor how the event PMDs library names are built in Meson to allow for this discrepancy in the octeonx dri

[dpdk-dev] [PATCH 10/15] net/thunderx: rename version map after library file name

The library is called librte_pmd_thunderx_nicvf, so rename the map file and set the name in the meson file so that the built library names with meson and legacy makefiles are the same Fixes: 7f615033d64f ("drivers/net: build Cavium NIC PMDs with meson") Cc: sta...@dpdk.org Signed-off-by: Luca Boc

[dpdk-dev] [PATCH 09/15] build: add Meson file for opdl_event PMD

Signed-off-by: Luca Boccassi --- drivers/event/meson.build | 2 +- drivers/event/opdl/meson.build | 11 +++ 2 files changed, 12 insertions(+), 1 deletion(-) create mode 100644 drivers/event/opdl/meson.build diff --git a/drivers/event/meson.build b/drivers/event/meson.build index e

[dpdk-dev] [PATCH 08/15] event/opdl: rename map file to match library name

So that it can be used from Meson as well Signed-off-by: Luca Boccassi --- drivers/event/opdl/Makefile | 2 +- ...md_evdev_opdl_version.map => rte_pmd_opdl_event_version.map} | 0 2 files changed, 1 insertion(+), 1 deletion(-) rename drivers/event/opdl/{rte_p

[dpdk-dev] [PATCH 11/15] net/sfc: rename version map after library file name

The library is called librte_pmd_sfc_efx, so rename the map file and set the name in the meson file so that the built library names with meson and legacy makefiles are the same Fixes: bfa8d5990cd6 ("net/sfc: support meson build") Cc: sta...@dpdk.org Signed-off-by: Luca Boccassi --- drivers/net/

[dpdk-dev] [PATCH 07/15] net/liquidio: rename version map after library file name

The library is called librte_pmd_lio, so rename the map file and set the name in the meson file so that the built library names with meson and legacy makefiles are the same Fixes: bad475c03fee ("net/liquidio: add to meson build") Cc: sta...@dpdk.org Signed-off-by: Luca Boccassi --- drivers/net/

[dpdk-dev] [PATCH 06/15] build: add Meson file for bbdev_null PMD

Signed-off-by: Luca Boccassi --- drivers/baseband/meson.build | 7 +++ drivers/baseband/null/meson.build | 7 +++ drivers/meson.build | 1 + 3 files changed, 15 insertions(+) create mode 100644 drivers/baseband/meson.build create mode 100644 drivers/baseband/null/meso

[dpdk-dev] [PATCH 04/15] build: add Meson files for avf PMD

Signed-off-by: Luca Boccassi --- drivers/net/avf/base/meson.build | 20 drivers/net/avf/meson.build | 15 +++ drivers/net/meson.build | 1 + 3 files changed, 36 insertions(+) create mode 100644 drivers/net/avf/base/meson.build create mode 100644 d

[dpdk-dev] [PATCH 03/15] build: add Meson file for crypto scheduler PMD

Signed-off-by: Luca Boccassi --- drivers/crypto/meson.build | 2 +- drivers/crypto/scheduler/meson.build | 19 +++ 2 files changed, 20 insertions(+), 1 deletion(-) create mode 100644 drivers/crypto/scheduler/meson.build diff --git a/drivers/crypto/meson.build b/driver

[dpdk-dev] [PATCH 02/15] build: add Meson file for vdev_netvsc PMD

Signed-off-by: Luca Boccassi --- drivers/net/meson.build | 1 + drivers/net/vdev_netvsc/meson.build | 19 +++ 2 files changed, 20 insertions(+) create mode 100644 drivers/net/vdev_netvsc/meson.build diff --git a/drivers/net/meson.build b/drivers/net/meson.build inde

[dpdk-dev] [PATCH 05/15] build: add Meson files for qede PMD

Signed-off-by: Luca Boccassi --- config/rte_config.h | 3 ++ drivers/net/meson.build | 2 +- drivers/net/qede/base/meson.build | 57 +++ drivers/net/qede/meson.build | 14 4 files changed, 75 insertions(+), 1 deletion(-) create

[dpdk-dev] [PATCH 01/15] build: add Meson file for tap PMD

Use same autoconf generation mechanism as the MLX4/5 PMDs Signed-off-by: Luca Boccassi --- drivers/net/meson.build | 1 + drivers/net/tap/meson.build | 41 + 2 files changed, 42 insertions(+) create mode 100644 drivers/net/tap/meson.build diff --git a/d

[dpdk-dev] [PATCH 00/15] rename PMDs map files to match library name and add Meson files

A few PMDs have a mismatch between the library filenames and the directory and maps names, so adding support for Meson is awkward or, if it already exists, the shared/static library filenames are different. Rename the map files of the following PMDs to match the libraries: - net/liquidio - net/thu

Re: [dpdk-dev] [PATCH v3 4/4] build: generate API documentation with Meson

On Mon, 2018-09-10 at 18:30 +0100, Bruce Richardson wrote: > On Mon, Sep 10, 2018 at 05:13:06PM +0100, Luca Boccassi wrote: > > Signed-off-by: Luca Boccassi > > --- > > v2: made doxygen dependency optional, skip doxygen build when not > > found > > v3: made doxygen dependency mandatory if enable_d

Re: [dpdk-dev] [PATCH v3 4/4] build: generate API documentation with Meson

On Mon, Sep 10, 2018 at 06:30:51PM +0100, Bruce Richardson wrote: > On Mon, Sep 10, 2018 at 05:13:06PM +0100, Luca Boccassi wrote: > > Signed-off-by: Luca Boccassi > > --- > > v2: made doxygen dependency optional, skip doxygen build when not found > > v3: made doxygen dependency mandatory if enabl

Re: [dpdk-dev] [PATCH v3 4/4] build: generate API documentation with Meson

On Mon, Sep 10, 2018 at 05:13:06PM +0100, Luca Boccassi wrote: > Signed-off-by: Luca Boccassi > --- > v2: made doxygen dependency optional, skip doxygen build when not found > v3: made doxygen dependency mandatory if enable_docs is true, add > alternative doc target that prints "doxygen not fo

Re: [dpdk-dev] [PATCH v5] net/pcap: physical interface MAC address support

Hello Ferruh, > From: Ferruh Yigit [mailto:ferruh.yi...@intel.com] > Sent: Monday, September 10, 2018 3:04 PM > > Hi Juhamatti, > > Thanks for the patch. > > Can you please add a little more details into commit log that why this new > feature is enabled, what is the use case? > > Also can you

[dpdk-dev] [PATCH v6] net/pcap: physical interface MAC address support

At the moment, PCAP interfaces use dummy MAC by default. This change adds support for selecting PCAP physical interface MAC with phy_mac=1 devarg. This allows to setup packet flows using the physical interface MAC. Signed-off-by: Juhamatti Kuusisaari --- v6: * Review changes: * Clarified

Re: [dpdk-dev] [PATCH v2] app/testpmd: add check for Rx offload security flag

> -Original Message- > From: Laatz, Kevin > Sent: Monday, September 10, 2018 5:29 PM > To: dev@dpdk.org > Cc: Iremonger, Bernard ; Laatz, Kevin > > Subject: [PATCH v2] app/testpmd: add check for Rx offload security flag > > Add a check for the DEV_RX_OFFLOAD_SECURITY flag to the > port_

[dpdk-dev] [PATCH 8/8] net/ixgbe/base: update README file

Update README file to specify the version of CID drop. Signed-off-by: Xiaoyun Li --- drivers/net/ixgbe/base/README | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ixgbe/base/README b/drivers/net/ixgbe/base/README index 70fdfe7c8..431be0260 100644 --- a/drivers

[dpdk-dev] [PATCH 7/8] net/ixgbe: remove Light Spring code

Since the base code is updated to remove the Light Spring device due to the device was never productised. So also remove it in ethdev. Signed-off-by: Xiaoyun Li --- drivers/net/ixgbe/ixgbe_ethdev.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/

[dpdk-dev] [PATCH 4/8] net/ixgbe/base: relpace an operation in X550 setup

Replace "=" operation with "|=" operation to only set the intended register bits. Signed-off-by: Xiaoyun Li --- drivers/net/ixgbe/base/ixgbe_x550.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ixgbe/base/ixgbe_x550.c b/drivers/net/ixgbe/base/ixgbe_x550.c i

[dpdk-dev] [PATCH 3/8] net/ixgbe/base: add FW recovery mode check

Add FM NVM recovery mode check. Allow the software to detect this. Signed-off-by: Xiaoyun Li --- drivers/net/ixgbe/base/ixgbe_api.c | 12 drivers/net/ixgbe/base/ixgbe_api.h | 1 + drivers/net/ixgbe/base/ixgbe_type.h | 4 drivers/net/ixgbe/base/ixgbe_x550.c | 16

[dpdk-dev] [PATCH 6/8] net/ixgbe/base: add support for DCB registers dump

Add support for DCB registers dump. Signed-off-by: Xiaoyun Li --- drivers/net/ixgbe/base/ixgbe_type.h | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/net/ixgbe/base/ixgbe_type.h b/drivers/net/ixgbe/base/ixgbe_type.h index ea34bb979..cee6ba2e0 100644 --- a/drivers/net/ixgbe/base

[dpdk-dev] [PATCH 5/8] net/ixgbe/base: update X550 SFP identification

Use ixgbe_identify_sfp_module_X550em to update SFP identification flow. ixgbe_identify_sfp_module_X550em includes specific checks for X550 about supported SFP modules. Signed-off-by: Xiaoyun Li --- drivers/net/ixgbe/base/ixgbe_x550.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) dif

[dpdk-dev] [PATCH 2/8] net/ixgbe/base: cleanup codes

Cleanup UNREFERENCED_1PARAMETER() macro because "hw" is used. And remove Light Spring codes because the device was never productised. And cleanup unused bypass codes. Signed-off-by: Xiaoyun Li --- drivers/net/ixgbe/base/ixgbe_82599.c | 10 -- drivers/net/ixgbe/base/ixgbe_api.c| 3 -

[dpdk-dev] [PATCH 1/8] net/ixgbe/base: update the license

Update the GPL and BSD license headers to use the SPDX License Identifier instead. Signed-off-by: Xiaoyun Li --- drivers/net/ixgbe/base/ixgbe_82598.c | 35 ++- drivers/net/ixgbe/base/ixgbe_82598.h | 35 ++- drivers/net/ixgbe/base/ixgbe_82599.c

[dpdk-dev] [PATCH 0/8] update ixgbe base code

Update the ixgbe base code to version cid-ixgbe.2018.08.28.tar.gz. Xiaoyun Li (8): net/ixgbe/base: update the license net/ixgbe/base: cleanup codes net/ixgbe/base: add FW recovery mode check net/ixgbe/base: relpace an operation in X550 setup net/ixgbe/base: update X550 SFP identification

Re: [dpdk-dev] [PATCH v2 5/5] vhost: message handling implemented as a callback array

Hi Ilya, On 09/10/2018 06:09 PM, Ilya Maximets wrote: Hi Maxime, Thanks for pointing to this patch set. I missed it somehow. This patch could not replace mine [1], because it does not improve the message handling from the error handling point of view. But it completely changes the code, so we n

[dpdk-dev] [PATCH v2] app/testpmd: add check for Rx offload security flag

Add a check for the DEV_RX_OFFLOAD_SECURITY flag to the port_offload_cap_display(). Signed-off-by: Kevin Laatz Reviewed-by: Ferruh Yigit --- app/test-pmd/config.c | 9 + 1 file changed, 9 insertions(+) diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c index 14ccd68..4c60c7e 10

Re: [dpdk-dev] [PATCH] app/testpmd: add check for rx offload security flag

Hi Kevin, > -Original Message- > From: Laatz, Kevin > Sent: Tuesday, September 4, 2018 1:33 PM > To: dev@dpdk.org > Cc: Iremonger, Bernard ; Laatz, Kevin > > Subject: [PATCH] app/testpmd: add check for rx offload security flag > > Add a check for the DEV_RX_OFFLOAD_SECURITY flag to the >

Re: [dpdk-dev] [PATCH v2 4/4] build: generate API documentation with Meson

On Mon, 2018-09-10 at 16:47 +0100, Bruce Richardson wrote: > On Fri, Sep 07, 2018 at 05:55:24PM +0100, Luca Boccassi wrote: > > Signed-off-by: Luca Boccassi > > --- > > v2: made doxygen dependency optional, skip doxygen build when not > > found > > > >  doc/api/generate_doxygen.sh | 10 +++ >

[dpdk-dev] [PATCH v3 4/4] build: generate API documentation with Meson

Signed-off-by: Luca Boccassi --- v2: made doxygen dependency optional, skip doxygen build when not found v3: made doxygen dependency mandatory if enable_docs is true, add alternative doc target that prints "doxygen not found" when doxygen is not found and enable_docs is false (default) d

[dpdk-dev] [PATCH v3 3/4] build: use same version as make showversion in Meson

make showversion will print 18.11.0-rc0 but Meson sets 18.11-rc0, causing among other things a difference in the generated documentation. Fixes: 76b9d9de5c7d ("version: 18.11-rc0") Signed-off-by: Luca Boccassi --- meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/m

[dpdk-dev] [PATCH v3 2/4] mk: use templated doxygen config, modified on the fly

This will allow the same config file to be used from Meson. The result has been verified to be identical via diffoscope. Signed-off-by: Luca Boccassi --- v2: reordered generated fields as requested doc/api/doxy-api.conf| 87 doc/api/doxy-api.conf.in | 96

[dpdk-dev] [PATCH v3 1/4] mk: use script to generate examples.dox

This will make it possible to generate the file in the same way from Meson as well. Signed-off-by: Luca Boccassi --- v2: simplified script by using exec > file doc/api/generate_examples.sh | 12 mk/rte.sdkdoc.mk | 5 + 2 files changed, 13 insertions(+), 4 deletions

Re: [dpdk-dev] [PATCH v2 5/5] vhost: message handling implemented as a callback array

Hi Maxime, Thanks for pointing to this patch set. I missed it somehow. This patch could not replace mine [1], because it does not improve the message handling from the error handling point of view. But it completely changes the code, so we need to negotiate the order in which they will be applied

[dpdk-dev] [PATCH v2] net/pcap: Generate unique MAC addresses for interfaces

The MAC addresses are generated in a similar manner as in the TAP PMD, where the address is based on the number of PCAP ports created. This is useful for the purposes of debugging DPDK applications using PCAP devices instead of real devices where multiple devices should still have unique MAC addre

[dpdk-dev] [PATCH] net/fm10k: add imissed stats

Add support of imissed and q_errors statistics, reported by PCIE_QPRDC register (see datasheet, section 11.27.2.60), which exposes the number of receive packets dropped for a queue. Signed-off-by: Julien Meunier --- drivers/net/fm10k/fm10k_ethdev.c | 7 +-- 1 file changed, 5 insertions(+), 2

Re: [dpdk-dev] [PATCH v2 1/4] mk: use script to generate examples.dox

On Fri, Sep 07, 2018 at 05:55:21PM +0100, Luca Boccassi wrote: > This will make it possible to generate the file in the same way from > Meson as well. > > Signed-off-by: Luca Boccassi > --- Couple of comments on patch 4, otherwise looks ok to me. Series-acked-by: Bruce Richardson

Re: [dpdk-dev] [PATCH v2 4/4] build: generate API documentation with Meson

On Fri, Sep 07, 2018 at 05:55:24PM +0100, Luca Boccassi wrote: > Signed-off-by: Luca Boccassi > --- > v2: made doxygen dependency optional, skip doxygen build when not found > > doc/api/generate_doxygen.sh | 10 +++ > doc/api/meson.build | 54 + >

Re: [dpdk-dev] [PATCH] app/testpmd: add commands for TM to mark pkts

-Original Message- > Date: Fri, 17 Aug 2018 13:39:19 +0200 > From: Krzysztof Kanas > To: dev@dpdk.org > Cc: krzysztof.ka...@caviumnetworks.com, > jerin.jacobkollanukka...@cavium.com, nithin.dabilpu...@cavium.com > Subject: [dpdk-dev] [PATCH] app/testpmd: add commands for TM to mark pkts >

Re: [dpdk-dev] [PATCH v2 5/5] vhost: message handling implemented as a callback array

On 07/19/2018 09:13 PM, Nikolay Nikolaev wrote: Introduce vhost_message_handlers, which maps the message request type to the message handler. Then replace the switch construct with a map and call. Signed-off-by: Nikolay Nikolaev --- lib/librte_vhost/vhost_user.c | 143 +++-

Re: [dpdk-dev] [PATCH v2 4/5] vhost: unify message handling function signature

On 07/19/2018 09:13 PM, Nikolay Nikolaev wrote: Each vhost-user message handling function will return an int result which is described in the new enum vh_result: error, OK and reply. All functions will now have two arguments, virtio_net double pointer and VhostUserMsg pointer. Signed-off-by:

Re: [dpdk-dev] [PATCH] doc: update API deprecation for device reset

On 09/10/2018 03:04 PM, Qi Zhang wrote: > Device reset may have the dependency, for example, a VF reset expects > PF ready, or a NIC function as a part of a SOC need to wait for other > parts of the system be ready, these are time-consuming tasks and will > block current thread. > > So we claimed

Re: [dpdk-dev] [PATCH v2 3/5] vhost: handle unsupported message types in functions

On 07/19/2018 09:13 PM, Nikolay Nikolaev wrote: Add new functions to handle the unsupported vhost message types: - vhost_user_set_vring_err - vhost_user_set_log_fd Signed-off-by: Nikolay Nikolaev --- lib/librte_vhost/vhost_user.c | 22 +- 1 file changed, 17 inser

Re: [dpdk-dev] [PATCH v1 1/2] eal: add nanosleep based delay function

On 05.09.2018 16:10, Stephen Hemminger wrote: > On Mon, 3 Sep 2018 17:47:42 +0300 > Ilya Maximets wrote: > >> >> +void __rte_experimental >> +rte_delay_us_sleep(unsigned int us) >> +{ >> +struct timespec wait[2]; >> +int ind = 0; >> + >> +wait[0].tv_sec = 0; >> +if (us >= US_PE

Re: [dpdk-dev] [PATCH v2 2/5] vhost: make message handling functions prepare the reply

On 07/19/2018 09:13 PM, Nikolay Nikolaev wrote: As VhostUserMsg structure is resued to generate the reply, move the s/resued/reused/ relevant fields update into the respective message handling functions. Signed-off-by: Nikolay Nikolaev --- lib/librte_vhost/vhost_user.c | 26 +

Re: [dpdk-dev] [PATCH] net/ixgbe: fix busy polling while fiber link update

On 04.09.2018 09:08, Zhang, Qi Z wrote: > Hi Ilya: > >> -Original Message- >> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Ilya Maximets >> Sent: Friday, August 31, 2018 8:40 PM >> To: dev@dpdk.org >> Cc: Lu, Wenzhuo ; Ananyev, Konstantin >> ; Laurent Hardy >> ; Dai, Wei ; Ilya Max

Re: [dpdk-dev] [PATCH v2 1/5] vhost: unify VhostUserMsg usage

Hi Nikolay, On 07/19/2018 09:13 PM, Nikolay Nikolaev wrote: Use the typedef version of struct VhostUserMsg. Also unify the related parameter name. Signed-off-by: Nikolay Nikolaev --- lib/librte_vhost/vhost_user.c | 50 + 1 file changed, 25 insertion

[dpdk-dev] [PATCH] crypto action

Change-Id: If1aecaac3335685f3bef79f47768ba8ae7765fbb Signed-off-by: Zhang, Roy Fan --- examples/ip_pipeline/Makefile | 1 + examples/ip_pipeline/action.c | 11 + examples/ip_pipeline/action.h | 1 + examples/ip_pipeline/cli.c

[dpdk-dev] [PATCH] doc: update API deprecation for device reset

Device reset may have the dependency, for example, a VF reset expects PF ready, or a NIC function as a part of a SOC need to wait for other parts of the system be ready, these are time-consuming tasks and will block current thread. So we claimed rte_eth_dev_reset as an async API, that makes things

Re: [dpdk-dev] [PATCH v2] vhost-user: drop connection on message handling failures

On 09/03/2018 12:12 PM, Ilya Maximets wrote: There are a lot of cases where vhost-user massage handling could fail and end up in a fully not recoverable state. For example, allocation failures of shadow used ring and batched copy array are not recoverable and leads to the segmentation faults l

[dpdk-dev] [RFC v2 1/2] ethdev: claim device reset as async

rte_eth_dev_reset should be implemented in an async way since it is possible to be invoked in interrupt thread and sometimes to reset a device need to wait for some dependency, for example, a VF expects for PF ready or a NIC function as part of a SOC wait for the whole system reset complete, and al

[dpdk-dev] [RFC v2 2/2] testpmd: enable async device reset

rte_eth_dev_reset is claimed as an async API, so re-work on the device reset handling. Signed-off-by: Qi Zhang --- app/test-pmd/testpmd.c | 50 +- 1 file changed, 49 insertions(+), 1 deletion(-) diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/t

[dpdk-dev] [RFC v2 0/2] ethdev: claim device reset as async

Device reset may have the dependency, for example, a VF reset expects PF ready, or a NIC function as a part of a SOC need to wait for other parts of the system be ready, these are time-consuming tasks and will block current thread. So we claimed rte_eth_dev_reset as an async API, that makes things

Re: [dpdk-dev] [PATCH] vhost: fix vhost interrupt support

On 09/05/2018 01:55 AM, Tiwei Bie wrote: When VIRTIO_RING_F_EVENT_IDX is negotiated, we need to update the avail event to enable the notification. Fixes: 3f8ff12821e4 ("vhost: support interrupt mode") Cc:sta...@dpdk.org Signed-off-by: Tiwei Bie --- lib/librte_vhost/Makefile | 1 + lib/li

[dpdk-dev] [PATCH v6] linuxapp, eal: Fix the memory leak issue of logid

From: Ziye Yang This patch is used to fix the memory leak issue of logid. We use the ASAN test in SPDK when intergrating DPDK and find this memory leak issue. By the way, we also fix several missed function call of rte_atomic32_clear. Signed-off-by: Ziye Yang --- lib/librte_eal/linuxapp/eal/e

[dpdk-dev] [RFC v2 0/2] ethdev: claim device reset as async

Device reset may have the dependency, for example, a VF reset expects PF ready, or a NIC function as a part of a SOC need to wait for other parts of the system be ready, these are time-consuming tasks and will block current thread. So we claimed rte_eth_dev_reset as an async API, that makes things

Re: [dpdk-dev] [PATCH v2 1/2] test/event: fix eth Rx adapter autotest for skeleton PMD

-Original Message- > Date: Wed, 5 Sep 2018 19:21:05 +0530 > From: Nikhil Rao > To: jerin.ja...@caviumnetworks.com > CC: dev@dpdk.org, Nikhil Rao , > vipin.vargh...@intel.com, sta...@dpdk.org > Subject: [PATCH v2 1/2] test/event: fix eth Rx adapter autotest for > skeleton PMD > X-Mailer:

Re: [dpdk-dev] [PATCH v3] net/virtio-user: check negotiated features before set

On 08/29/2018 05:55 PM, eric zhang wrote: This patch checks negotiated features to see if necessary to offload before set the tap device offload capabilities. It also checks if kernel support the TUNSETOFFLOAD operation. Signed-off-by: eric zhang --- v3: * make other offloading features dep

Re: [dpdk-dev] [PATCH 3/5] event/dpaa2: enchance timeout handling

-Original Message- > Date: Thu, 30 Aug 2018 11:33:57 +0530 > From: Hemant Agrawal > To: dev@dpdk.org > CC: jerin.ja...@caviumnetworks.com, nipun.gu...@nxp.com > Subject: [PATCH 3/5] event/dpaa2: enchance timeout handling > X-Mailer: git-send-email 2.7.4 > Missing git commit log descripti

Re: [dpdk-dev] [PATCH] vhost: fix zmbufs array leak after NUMA realloc

On 08/15/2018 04:54 PM, Ilya Maximets wrote: 'numa_realloc()' allocates 'zmbufs' even if zero copy mode is not configured. This leads to memory leak, because array is freed only for zero copy case. Fixes: 2651726defb7 ("vhost: do deep copy while reallocating queue") CC: sta...@dpdk.org Signe

Re: [dpdk-dev] [PATCH 2/2] event/dpaa: add select based event support

-Original Message- > Date: Thu, 30 Aug 2018 11:03:16 +0530 > From: Hemant Agrawal > To: dev@dpdk.org > CC: jerin.ja...@caviumnetworks.com, nipun.gu...@nxp.com > Subject: [PATCH 2/2] event/dpaa: add select based event support > X-Mailer: git-send-email 2.7.4 > > External Email > > Signed-

Re: [dpdk-dev] [PATCH] examples/vhost: remove unnecessary MAX_PRINT_BUFF defintion

On 08/25/2018 09:22 PM, Rami Rosen wrote: This patch removes an unnecessary definition of MAX_PRINT_BUFF in examples/vhost/main.c, since it is no longer being used. Fixes: 68363d85857d ("examples/vhost: remove the non-working zero copy code"). Signed-off-by: Rami Rosen --- examples/vhost/

Re: [dpdk-dev] [PATCH v2] build: add PPC64 Meson build

On Mon, Sep 10, 2018 at 12:32:43PM +0100, Luca Boccassi wrote: > This has been only build-tested for now, on a native ppc64el POWER8E > machine running Debian sid. > > Signed-off-by: Luca Boccassi > --- > v2: fix indentation, drop march_opt in ppc build file > LGTM Acked-by: Bruce Richardson

Re: [dpdk-dev] [PATCH 10/10] eventdev: include DSW event device documentation

-Original Message- > Date: Mon, 10 Sep 2018 14:59:51 +0200 > From: Mattias Rönnblom > To: jerin.ja...@caviumnetworks.com > CC: bruce.richard...@intel.com, dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH 10/10] eventdev: include DSW event device > documentation > User-Agent: Mozilla/5.0 (X11

Re: [dpdk-dev] [PATCH] doc: fix wrong usage of bind command

On 08/24/2018 09:43 AM, Rami Rosen wrote: This patch fixes wrong usage of bind command in vhost.rst. Using "dpdk-devbind.py -b=uio_pci_generic :00:04.0" gives an error of "unbind failed". It should be "-b uio_pci_generic" so it will work correctly. Signed-off-by: Rami Rosen --- doc/gui

Re: [dpdk-dev] [PATCH 10/10] eventdev: include DSW event device documentation

Will DSW be included in 18.11? /M On 2018-08-30 16:27, Mattias Rönnblom wrote: The DSW event device is documented in DPDK Programmer's Guide. Signed-off-by: Mattias Rönnblom --- doc/guides/eventdevs/dsw.rst | 97 ++ doc/guides/eventdevs/index.rst | 1 +

Re: [dpdk-dev] [PATCH v5] linuxapp, eal: Fix the memory leak issue of logid

Hi Konstantin, Thanks for your comments. I will revise the patch and submit another patch later. Best Regards Ziye Yang -Original Message- From: Ananyev, Konstantin Sent: Monday, September 10, 2018 8:19 PM To: Yang, Ziye ; dev@dpdk.org Cc: Ziye Yang Subject: RE: [dpdk-dev] [PATCH

Re: [dpdk-dev] [PATCH v5] linuxapp, eal: Fix the memory leak issue of logid

> -Original Message- > From: Yang, Ziye > Sent: Monday, September 10, 2018 12:58 PM > To: Ananyev, Konstantin ; dev@dpdk.org > Cc: Ziye Yang > Subject: RE: [dpdk-dev] [PATCH v5] linuxapp, eal: Fix the memory leak issue > of logid > > Hi Konstantin, > > The global logid is used to pre

Re: [dpdk-dev] [PATCH v2] ethdev: make default behavior CRC strip on Rx

-Original Message- > > Removed DEV_RX_OFFLOAD_CRC_STRIP offload flag. > Without any specific Rx offload flag, default behavior by PMDs is to > strip CRC. > > PMDs that support keeping CRC should advertise DEV_RX_OFFLOAD_KEEP_CRC > Rx offload capability. > > Applications that require keep

Re: [dpdk-dev] [PATCH v5] net/pcap: physical interface MAC address support

On 9/6/2018 5:56 PM, Juhamatti Kuusisaari wrote: > Support for PCAP physical interface MAC with phy_mac=1 devarg. > > Signed-off-by: Juhamatti Kuusisaari Hi Juhamatti, Thanks for the patch. Can you please add a little more details into commit log that why this new feature is enabled, what is t

Re: [dpdk-dev] [PATCH v5] linuxapp, eal: Fix the memory leak issue of logid

Hi Konstantin, The global logid is used to prevent the memory leak. If we do not do this, but directly free(logid), this pointer will still be used by openlog, which means that we cannot free the logid anymore. And by adding the global variable, it will not only solve the memory leak but also m

Re: [dpdk-dev] [PATCH v5] linuxapp, eal: Fix the memory leak issue of logid

Hi > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Ziye Yang > Sent: Wednesday, September 5, 2018 6:39 AM > To: dev@dpdk.org > Cc: Ziye Yang > Subject: [dpdk-dev] [PATCH v5] linuxapp, eal: Fix the memory leak issue of > logid > > From: Ziye Yang > > This p

Re: [dpdk-dev] [PATCH] build: add PPC64 Meson build

On Mon, 2018-09-10 at 11:50 +0100, Bruce Richardson wrote: > On Fri, Sep 07, 2018 at 07:35:02PM +0100, Luca Boccassi wrote: > > This has been only build-tested for now, on a native ppc64el > > POWER8E > > machine running Debian sid. > > > > Signed-off-by: Luca Boccassi > > --- > > The build box c

[dpdk-dev] [PATCH v2] build: add PPC64 Meson build

This has been only build-tested for now, on a native ppc64el POWER8E machine running Debian sid. Signed-off-by: Luca Boccassi --- v2: fix indentation, drop march_opt in ppc build file config/meson.build | 10 +- config/ppc_64/meson.build

[dpdk-dev] [PATCH] net/ifc: do not notify before HW ready

Fixes: a3f8150eac6d ("net/ifcvf: add ifcvf vDPA driver") Signed-off-by: Xiao Wang --- drivers/net/ifc/ifcvf_vdpa.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/net/ifc/ifcvf_vdpa.c b/drivers/net/ifc/ifcvf_vdpa.c index 3c5430dc0..7d3085d8d 100644 --- a/drive

Re: [dpdk-dev] [PATCH v2] ethdev: make default behavior CRC strip on Rx

For szedata2: Acked-by: Jan Remes Thanks, Jan > --- a/drivers/net/szedata2/rte_eth_szedata2.c > +++ b/drivers/net/szedata2/rte_eth_szedata2.c > @@ -1056,8 +1056,7 @@ eth_dev_info(struct rte_eth_dev *dev, > dev_info->max_rx_queues = internals->max_rx_queues; > dev_info->max_tx_qu

[dpdk-dev] [PATCH] net/ifc: add live migration support

IFCVF can help to log dirty page in live migration stage, each queue's index can be read and configured to support VHOST_USER_GET_VRING_BASE and VHOST_USER_SET_VRING_BASE. Signed-off-by: Xiao Wang --- drivers/net/ifc/base/ifcvf.c | 33 +++- drivers/net/ifc/base/ifcvf.h | 7 +

Re: [dpdk-dev] [dpdk-stable] [PATCH] net/mlx5: fix interrupt completion queue index wrapping

On 9/4/2018 7:21 AM, Shahaf Shuler wrote: > Tuesday, August 28, 2018 9:59 PM, Yongseok Koh: >> wrapping >> >>> On Aug 23, 2018, at 4:10 PM, Xueming Li wrote: >>> >>> Rxq cq_ci was 16 bits while hardware is expecting to wrap around 24 >>> bits, this caused interrupt failure after burst of packets.

Re: [dpdk-dev] [PATCH v5 08/11] net/virtio: implement receive path for packed queues

> -Original Message- > From: dev On Behalf Of Jens Freimann > Sent: Friday, September 7, 2018 2:20 AM > To: dev@dpdk.org > Cc: tiwei@intel.com; maxime.coque...@redhat.com > Subject: [dpdk-dev] [PATCH v5 08/11] net/virtio: implement receive path for > packed queues > > Implement the

Re: [dpdk-dev] [PATCH] build: add PPC64 Meson build

On Fri, Sep 07, 2018 at 07:35:02PM +0100, Luca Boccassi wrote: > This has been only build-tested for now, on a native ppc64el POWER8E > machine running Debian sid. > > Signed-off-by: Luca Boccassi > --- > The build box cannot be used to run DPDK as it doesn't have supported > NICs and root access

Re: [dpdk-dev] DPDK Shared lib: No Ethernet ports

On Fri, Sep 07, 2018 at 05:11:21PM +, Shubhachint, Chaitanya wrote: > Thank you for your reply Bruce. > Still having issues with shared-lib DPDK. I tried both options and get two > distinct issues. > I tried running the l2fwd example with e1000 driver and get little farther. > This time it

[dpdk-dev] [PATCH v4] net/i40e: add interface to choose latest vector path

Right now, vector path is limited to only use on later platform. This patch adds a devarg use-latest-vec to allow the users to use the latest vector path that the platform supported. Namely, using AVX2 vector path on broadwell is possible. Signed-off-by: Xiaoyun Li --- v4: * Polish the codes. v3

Re: [dpdk-dev] [PATCH v5 07/11] net/virtio: implement transmit path for packed queues

One more comment: > -Original Message- > From: dev On Behalf Of Jens Freimann > Sent: Friday, September 7, 2018 2:20 AM > To: dev@dpdk.org > Cc: tiwei@intel.com; maxime.coque...@redhat.com > Subject: [dpdk-dev] [PATCH v5 07/11] net/virtio: implement transmit path > for packed queues >

[dpdk-dev] [PATCH 32/37] net/sfc/base: check buffer size for hash flags

From: Ivan Malov The efx_rx_scale_hash_flags_get interface is unsafe, as it does not have an argument for the size of the output buffer used to return the flags. While the only caller currently supplies a sufficiently large buffer, this should be checked at runtime to avoid writing past the end o

  1   2   >