Re: [dpdk-dev] [PATCH] vhost: fix return value on enqueue path

On 09/06/2018 06:59 AM, Tiwei Bie wrote: Fixes: 62250c1d0978 ("vhost: extract split ring handling from Rx and Tx functions") Fixes: a922401f35cc ("vhost: add Rx support for packed ring") Cc: sta...@dpdk.org Signed-off-by: Tiwei Bie --- lib/librte_vhost/virtio_net.c | 7 --- 1 file ch

Re: [dpdk-dev] [PATCH] net/ixgbe: fix busy polling while fiber link update

> -Original Message- > From: Ilya Maximets [mailto:i.maxim...@samsung.com] > Sent: Monday, September 10, 2018 11:09 PM > To: Zhang, Qi Z ; dev@dpdk.org > Cc: Lu, Wenzhuo ; Ananyev, Konstantin > ; Laurent Hardy > ; Dai, Wei ; > sta...@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] net/ixgbe: f

Re: [dpdk-dev] Change in binary name w/ meson build

Friday, September 7, 2018 6:24 PM, Bruce Richardson: > Subject: Re: [dpdk-dev] Change in binary name w/ meson build > > On Fri, Sep 07, 2018 at 03:13:43PM +0100, Bruce Richardson wrote: > > On Wed, Sep 05, 2018 at 11:52:10AM +, Shahaf Shuler wrote: > > >Hi Bruce, > > > > > > > > >Playi

Re: [dpdk-dev] [PATCH] net/bonding: propagate promiscous mode in mode 4

Hi Chas From: Chas Williams > On Mon, Aug 6, 2018 at 3:35 PM Matan Azrad > wrote: > > > > > > Hi Chas > > > > From: Chas Williams > > >On Mon, Aug 6, 2018 at 1:46 PM Matan Azrad > wrote: > > >Hi Chas > > > > > >From: Chas Williams > > >>On Fri, Aug 3, 2018 at 1:47 AM

Re: [dpdk-dev] [dpdk-stable] [PATCH v4] net/bonding: per-slave intermediate rx ring

Hi Chas From: Chas Williams > On Sun, Sep 2, 2018 at 7:34 AM Matan Azrad wrote: > > > > Hi Luca\Chas > > > > From: Luca Boccassi > > > On Wed, 2018-08-29 at 15:20 +, Matan Azrad wrote: > > > > > > > > From: Chas Williams > > > > > On Tue, Aug 28, 2018 at 5:51 AM Matan Azrad >

Re: [dpdk-dev] Deadlock when start virtio_user + vhost_kernel

On Wed, Sep 12, 2018 at 11:47:20AM +0800, Jason Wang wrote: > Hi: > > Try to launch virtio_user + vhost_kernel with: testpmd > --vdev=virtio_user0,path=/dev/vhost-net -- -i > > It seems we get a deadlock on > rte_rwlock_read_lock(&mcfg->memory_hotplug_lock) Yes, you're right. There is a deadlock

Re: [dpdk-dev] [PATCH v2 10/10] kni: add API to set link status on kernel interface

On 2018年09月12日 07:14, Stephen Hemminger wrote: On Tue, 11 Sep 2018 19:07:47 -0300 Dan Gora wrote: On Tue, Sep 11, 2018 at 6:52 PM, Stephen Hemminger wrote: The carrier state has no meaning when device is down, at least for physical devices. Because often the PHY is powered off when the de

[dpdk-dev] Deadlock when start virtio_user + vhost_kernel

Hi: Try to launch virtio_user + vhost_kernel with: testpmd --vdev=virtio_user0,path=/dev/vhost-net -- -i It seems we get a deadlock on rte_rwlock_read_lock(&mcfg->memory_hotplug_lock) calltrace: Thread 1 "testpmd" received signal SIGINT, Interrupt. rte_memseg_contig_walk (func=func@entry=0

Re: [dpdk-dev] [PATCH] app/testpmd: Optimize membuf pool allocation

Hi Bernard, Thanks for you comments. I have updated the patch. Please review it. Thanks, Phil Yang > -Original Message- > From: dev On Behalf Of Iremonger, Bernard > Sent: Wednesday, September 12, 2018 12:23 AM > To: dev ; dev@dpdk.org > Cc: nd ; Gavin Hu (Arm Technology China) > Subje

[dpdk-dev] [PATCH v2] app/testpmd: optimize membuf pool allocation

By default, testpmd will create membuf pool for all NUMA nodes and ignore EAL configuration. Count the number of available NUMA according to EAL core mask or core list configuration. Optimized by only creating membuf pool for those nodes. Fixes: c9cafcc ("app/testpmd: fix mempool creation by sock

[dpdk-dev] [PATCH v8] linuxapp, eal: Fix the memory leak issue of logid

From: Ziye Yang This patch is used to fix the memory leak issue of logid. We use the ASAN test in SPDK when intergrating DPDK and find this memory leak issue. Signed-off-by: Ziye Yang --- lib/librte_eal/linuxapp/eal/eal.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --gi

[dpdk-dev] [PATCH 1/2] kni: add API to set link status on kernel interface

Add a new API function to KNI, rte_kni_update_link() to allow DPDK applications to update the link status for KNI network interfaces in the linux kernel. Signed-off-by: Dan Gora --- lib/librte_kni/rte_kni.c | 57 lib/librte_kni/rte_kni.h | 18

[dpdk-dev] [PATCH 2/2] kni: set default carrier state to 'off'

Set the carrier state to 'off' when the interface is instantiated or when it is marked 'up' or 'down'. This is necessary to set the interface to a known operational state until the carrier state is changed with rte_kni_update_link(). Signed-off-by: Dan Gora --- kernel/linux/kni/kni_misc.c | 2 +

[dpdk-dev] [PATCH 0/2] kni: add API to set link status on kernel interface

Hi All, The following patches are to add support for DPDK applications to be able to change the carrier state of Linux network interfaces in the KNI kernel module. The carrier state is changed by writing to the Linux /sys file: /sys/devices/virtual/net//carrier, where is the KNI interface name.

Re: [dpdk-dev] [PATCH 1/2] kni: add API to set link status on kernel interface

Sorry all.. I totally goofed up with git-send-email.. Please ignore this message. On Tue, Sep 11, 2018 at 8:14 PM, Dan Gora wrote: > Add a new API function to KNI, rte_kni_update_link() to allow DPDK > applications to update the link status for KNI network interfaces in > the linux kernel. >

Re: [dpdk-dev] [PATCH v2 10/10] kni: add API to set link status on kernel interface

On Tue, 11 Sep 2018 19:07:47 -0300 Dan Gora wrote: > On Tue, Sep 11, 2018 at 6:52 PM, Stephen Hemminger > wrote: > > The carrier state has no meaning when device is down, at least for physical > > devices. Because often the PHY is powered off when the device is marked > > down. > > The thing

[dpdk-dev] [PATCH 1/2] kni: add API to set link status on kernel interface

Add a new API function to KNI, rte_kni_update_link() to allow DPDK applications to update the link status for KNI network interfaces in the linux kernel. Signed-off-by: Dan Gora --- lib/librte_kni/rte_kni.c | 57 lib/librte_kni/rte_kni.h | 18

[dpdk-dev] [PATCH 0/2] kni: add API to set link status on kernel interface

Hi All, The following patches are to add support for DPDK applications to be able to change the carrier state of Linux network interfaces in the KNI kernel module. The carrier state is changed by writing to the Linux /sys file: /sys/devices/virtual/net//carrier, where is the KNI interface name.

Re: [dpdk-dev] [PATCH v2 10/10] kni: add API to set link status on kernel interface

On Tue, Sep 11, 2018 at 6:52 PM, Stephen Hemminger wrote: > The carrier state has no meaning when device is down, at least for physical > devices. Because often the PHY is powered off when the device is marked down. The thing that caught my attention is that when you mark a kernel ethernet device

Re: [dpdk-dev] [PATCH v2 10/10] kni: add API to set link status on kernel interface

On Tue, 11 Sep 2018 18:45:49 -0300 Dan Gora wrote: > Hi All, > > So I implemented the "write to /sys/devices/virtual/net/*/carrier" > method to change the link status, but there is one more minor thing > that I wanted to point out about this approach. The problem is that > you cannot read or wr

Re: [dpdk-dev] [PATCH] doc: support building HTML guides with meson

On Tue, 2018-09-11 at 21:36 +0100, Luca Boccassi wrote: > On Tue, 2018-09-11 at 17:13 +0100, Bruce Richardson wrote: > > Signed-off-by: Bruce Richardson > > --- > > NOTE: this patch depends upon: > > http://patches.dpdk.org/project/dpdk/list/?series=1232 > > Just a reminder that's v2, and the pat

Re: [dpdk-dev] [PATCH v2 10/10] kni: add API to set link status on kernel interface

Hi All, So I implemented the "write to /sys/devices/virtual/net/*/carrier" method to change the link status, but there is one more minor thing that I wanted to point out about this approach. The problem is that you cannot read or write the '/sys/devices/virtual/net/*/carrier' file while the inter

[dpdk-dev] [PATCH v5 3/4] build: use same version as make showversion in Meson

make showversion will print 18.11.0-rc0 but Meson sets 18.11-rc0, causing among other things a difference in the generated documentation. Fixes: 76b9d9de5c7d ("version: 18.11-rc0") Signed-off-by: Luca Boccassi Acked-by: Thomas Monjalon Acked-by: Bruce Richardson --- v3: add acked-by meson.bu

[dpdk-dev] [PATCH v5 2/4] mk: use templated doxygen config, modified on the fly

This will allow the same config file to be used from Meson. The result has been verified to be identical via diffoscope. Signed-off-by: Luca Boccassi Acked-by: Bruce Richardson --- v2: reordered generated fields as requested v4: add acked-by doc/api/doxy-api.conf| 87 --

[dpdk-dev] [PATCH v5 4/4] build: generate API documentation with Meson

Signed-off-by: Luca Boccassi Acked-by: Bruce Richardson --- v2: made doxygen dependency optional, skip doxygen build when not found v3: made doxygen dependency mandatory if enable_docs is true, add alternative doc target that prints "doxygen not found" when doxygen is not found and enable

[dpdk-dev] [PATCH v5 1/4] mk: use script to generate examples.dox

This will make it possible to generate the file in the same way from Meson as well. Signed-off-by: Luca Boccassi Acked-by: Bruce Richardson --- v2: simplified script by using exec > file v4: add acked-by doc/api/generate_examples.sh | 12 mk/rte.sdkdoc.mk | 5 + 2

Re: [dpdk-dev] [PATCH] doc: support building HTML guides with meson

On Tue, 2018-09-11 at 17:13 +0100, Bruce Richardson wrote: > Signed-off-by: Bruce Richardson > --- > NOTE: this patch depends upon: > http://patches.dpdk.org/project/dpdk/list/?series=1232 Just a reminder that's v2, and the patch won't apply cleanly on the latest revision >  doc/api/meson.build 

[dpdk-dev] [Bug 90] DPDK Installation fails on Centos

https://bugs.dpdk.org/show_bug.cgi?id=90 Bug ID: 90 Summary: DPDK Installation fails on Centos Product: DPDK Version: 17.02 Hardware: x86 OS: Other Status: CONFIRMED Severity: major Priority: Nor

Re: [dpdk-dev] [PATCH 1/3] mbuf: add sanity checks on segment metadata

> On Sep 9, 2018, at 10:45 PM, David Marchand wrote: > > Add some basic checks on the segments offset and length metadata: > always funny to have a < 0 tailroom cast to uint16_t ;-). > > Signed-off-by: David Marchand > --- > lib/librte_mbuf/rte_mbuf.c | 5 + > 1 file changed, 5 insertions(

Re: [dpdk-dev] [PATCH] net/mlx5: add bluefield vf support

> On Sep 2, 2018, at 6:55 AM, Ori Kam wrote: > > Signed-off-by: Ori Kam > --- Acked-by: Yongseok Koh Thanks > drivers/net/mlx5/mlx5.c | 4 > drivers/net/mlx5/mlx5.h | 1 + > 2 files changed, 5 insertions(+) > > diff --git a/drivers/net/mlx5/mlx5.c b/drivers/net/mlx5/mlx5.c > index 30d4

[dpdk-dev] [PATCH] doc/fix: add CCM to the QAT feature list

Signed-off-by: Tomasz Cel --- doc/guides/cryptodevs/features/qat.ini | 3 +++ doc/guides/cryptodevs/qat.rst | 1 + 2 files changed, 4 insertions(+) diff --git a/doc/guides/cryptodevs/features/qat.ini b/doc/guides/cryptodevs/features/qat.ini index 29d865e..a37a1a1 100644 --- a/doc/guide

Re: [dpdk-dev] [PATCH] eal: force IOVA mode to physical

On 09/07/2018 04:13 PM, Eric Zhang wrote: On 09/07/2018 05:26 AM, Burakov, Anatoly wrote: On 06-Sep-18 8:34 AM, Jerin Jacob wrote: -Original Message- Date: Tue, 4 Sep 2018 23:40:36 -0400 From: Eric Zhang To: santosh , hemant.agra...@nxp.com,   Gaëtan Rivet , "Burakov, Anatoly"

[dpdk-dev] RFC: compressdev: append dest data in PMDs instead of in application

Proposal: In compressdev, move the responsibility for appending data in the destination mbuf from the application to the PMD. Why: Compression operations are all out-of-place and the output size is unknown. Source and destination mbufs are passed to the PMDs. There's no problem with the src, but t

Re: [dpdk-dev] [PATCH 17/21] net/atlantic: device statistics, xstats

On Fri, 7 Sep 2018 18:21:55 +0300 Igor Russkikh wrote: > + > +static int > +atl_dev_xstats_get_names(struct rte_eth_dev *dev __rte_unused, struct > rte_eth_xstat_name *xstats_names, unsigned int size) > +{ > + unsigned int i; > + Please break really long lines at between 80 and 100 charact

Re: [dpdk-dev] [PATCH 05/21] net/atlantic: b0 hardware layer main logic

On Fri, 7 Sep 2018 18:21:43 +0300 Igor Russkikh wrote: > + > +#define pif_rpf_rss_ipv4_hdr_only_i (1 << 4)//calc hash only in IPv4 > header, regardless of presence of TCP > +#define pif_rpf_rss_ipv4_tcp_hdr_only_i (1 << 3)//calc hash only if TCP > header and IPv4 > +#define pif_rpf

Re: [dpdk-dev] [PATCH 05/21] net/atlantic: b0 hardware layer main logic

On Fri, 7 Sep 2018 18:21:43 +0300 Igor Russkikh wrote: > +/* > + * aQuantia Corporation Network Driver > + * Copyright (C) 2014-2017 aQuantia Corporation. All rights reserved > + * > + * This program is free software; you can redistribute it and/or modify it > + * under the terms and conditions

Re: [dpdk-dev] [PATCH 04/21] net/atlantic: hw_atl register declarations

On Fri, 7 Sep 2018 18:21:42 +0300 Igor Russkikh wrote: > +/* register address for bitfield imr_rx{r}_en */ > + static u32 itr_imr_rxren_adr[32] = { > + 0x2100U, 0x2100U, 0x2104U, 0x2104U, > + 0x2108U, 0x2108U, 0x210CU, 0x000

Re: [dpdk-dev] [PATCH 01/21] net/atlantic: atlantic PMD driver skeleton

On Fri, 7 Sep 2018 18:21:39 +0300 Igor Russkikh wrote: > +#CFLAGS_BASE_DRIVER = -Wno-unused-parameter -Wno-unused-value > +CFLAGS_BASE_DRIVER += -Wno-strict-aliasing -Wno-format-extra-args Can't you fix your code to get rid of these errors?

Re: [dpdk-dev] [PATCH] app/testpmd: Optimize membuf pool allocation

Hi Gavin, > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] > Sent: Monday, August 27, 2018 10:33 AM > To: dev@dpdk.org > Cc: n...@arm.com; gavin...@arm.com > Subject: [dpdk-dev] [PATCH] app/testpmd: Optimize membuf pool allocation > > By default, testpmd will create membuf p

[dpdk-dev] [PATCH] doc: support building HTML guides with meson

Signed-off-by: Bruce Richardson --- NOTE: this patch depends upon: http://patches.dpdk.org/project/dpdk/list/?series=1232 doc/api/meson.build| 3 ++- doc/guides/meson.build | 16 doc/meson.build| 11 +++ 3 files changed, 29 insertions(+), 1 deletion(-) crea

[dpdk-dev] [PATCH v2 9/9] build: add Meson file for vmxnet3_uio PMD

Signed-off-by: Luca Boccassi --- drivers/net/meson.build | 4 +++- drivers/net/vmxnet3/meson.build | 18 ++ 2 files changed, 21 insertions(+), 1 deletion(-) create mode 100644 drivers/net/vmxnet3/meson.build diff --git a/drivers/net/meson.build b/drivers/net/meson.build

[dpdk-dev] [PATCH v2 8/9] build: add Meson file for opdl_event PMD

Signed-off-by: Luca Boccassi --- drivers/event/meson.build | 2 +- drivers/event/opdl/meson.build | 11 +++ 2 files changed, 12 insertions(+), 1 deletion(-) create mode 100644 drivers/event/opdl/meson.build diff --git a/drivers/event/meson.build b/drivers/event/meson.build index e

[dpdk-dev] [PATCH v2 5/9] build: add Meson files for qede PMD

Signed-off-by: Luca Boccassi Acked-by: Shahed Shaikh --- config/rte_config.h | 3 ++ drivers/net/meson.build | 2 +- drivers/net/qede/base/meson.build | 57 +++ drivers/net/qede/meson.build | 12 +++ 4 files changed, 73 insertions(+)

[dpdk-dev] [PATCH v2 6/9] build: add Meson file for bbdev_null PMD

Signed-off-by: Luca Boccassi --- drivers/baseband/meson.build | 7 +++ drivers/baseband/null/meson.build | 7 +++ drivers/meson.build | 1 + 3 files changed, 15 insertions(+) create mode 100644 drivers/baseband/meson.build create mode 100644 drivers/baseband/null/meso

[dpdk-dev] [PATCH v2 3/9] build: add Meson file for crypto scheduler PMD

Signed-off-by: Luca Boccassi --- drivers/crypto/meson.build | 2 +- drivers/crypto/scheduler/meson.build | 19 +++ 2 files changed, 20 insertions(+), 1 deletion(-) create mode 100644 drivers/crypto/scheduler/meson.build diff --git a/drivers/crypto/meson.build b/driver

[dpdk-dev] [PATCH v2 7/9] event/opdl: rename map file to match library name

So that it can be used from Meson as well Signed-off-by: Luca Boccassi --- drivers/event/opdl/Makefile | 2 +- ...md_evdev_opdl_version.map => rte_pmd_opdl_event_version.map} | 0 2 files changed, 1 insertion(+), 1 deletion(-) rename drivers/event/opdl/{rte_p

[dpdk-dev] [PATCH v2 4/9] build: add Meson files for avf PMD

Signed-off-by: Luca Boccassi --- drivers/net/avf/base/meson.build | 20 drivers/net/avf/meson.build | 15 +++ drivers/net/meson.build | 1 + 3 files changed, 36 insertions(+) create mode 100644 drivers/net/avf/base/meson.build create mode 100644 d

[dpdk-dev] [PATCH v2 2/9] build: add Meson file for vdev_netvsc PMD

Signed-off-by: Luca Boccassi --- drivers/net/meson.build | 1 + drivers/net/vdev_netvsc/meson.build | 19 +++ 2 files changed, 20 insertions(+) create mode 100644 drivers/net/vdev_netvsc/meson.build diff --git a/drivers/net/meson.build b/drivers/net/meson.build inde

[dpdk-dev] [PATCH v2 1/9] build: add Meson file for TAP PMD

Use same autoconf generation mechanism as the MLX4/5 PMDs Signed-off-by: Luca Boccassi --- drivers/net/meson.build | 1 + drivers/net/tap/meson.build | 41 + 2 files changed, 42 insertions(+) create mode 100644 drivers/net/tap/meson.build diff --git a/d

Re: [dpdk-dev] [PATCH 07/15] net/liquidio: rename version map after library file name

On Tue, 2018-09-11 at 15:06 +0100, Bruce Richardson wrote: > On Tue, Sep 11, 2018 at 02:41:36PM +0100, Luca Boccassi wrote: > > On Tue, 2018-09-11 at 14:32 +0100, Bruce Richardson wrote: > > > On Tue, Sep 11, 2018 at 02:09:30PM +0100, Luca Boccassi wrote: > > > > On Tue, 2018-09-11 at 14:06 +0100,

Re: [dpdk-dev] [PATCH v6] net/pcap: physical interface MAC address support

On 9/10/2018 5:55 PM, Juhamatti Kuusisaari wrote: > At the moment, PCAP interfaces use dummy MAC by default. This change > adds support for selecting PCAP physical interface MAC with phy_mac=1 > devarg. This allows to setup packet flows using the physical interface > MAC. > > Signed-off-by: Juhama

Re: [dpdk-dev] [PATCH v7] linuxapp, eal: Fix the memory leak issue of logid

"Ananyev, Konstantin" writes: >> -Original Message- >> From: Aaron Conole [mailto:acon...@redhat.com] >> Sent: Tuesday, September 11, 2018 2:47 PM >> To: Yang, Ziye >> Cc: dev@dpdk.org; Ananyev, Konstantin >> ; Ziye Yang >> Subject: Re: [dpdk-dev] [PATCH v7] linuxapp, eal: Fix the memor

[dpdk-dev] [PATCH v2] eal: add strscpy function

The strncpy function has long been deemed unsafe for use, in favor of strlcpy or snprintf. While snprintf is standard and strlcpy is still largely available, they both have issues regarding error checking and performance. Both will force reading the source buffer past the requested size if the in

[dpdk-dev] [PATCH v2 15/15] net/softnic: add parsing for raw flow item

Added support for parsing raw flow item. flow_item_raw_preprocess() is added for the same. Signed-off-by: Cristian Dumitrescu Signed-off-by: Reshma Pattan --- drivers/net/softnic/rte_eth_softnic_flow.c | 108 + 1 file changed, 108 insertions(+) diff --git a/drivers/

[dpdk-dev] [PATCH v2 14/15] net/softnic: add flow query API

Added pmd_flow_query() API, for flow query support. Signed-off-by: Cristian Dumitrescu Signed-off-by: Reshma Pattan --- drivers/net/softnic/rte_eth_softnic_flow.c | 55 ++ 1 file changed, 55 insertions(+) diff --git a/drivers/net/softnic/rte_eth_softnic_flow.c b/dr

[dpdk-dev] [PATCH v2 13/15] net/softnic: add flow destroy API

pmd_flow_destroy() API is added to destroy the created flow. Signed-off-by: Cristian Dumitrescu Signed-off-by: Reshma Pattan --- drivers/net/softnic/rte_eth_softnic_flow.c | 39 ++ 1 file changed, 39 insertions(+) diff --git a/drivers/net/softnic/rte_eth_softnic_flo

[dpdk-dev] [PATCH v2 12/15] net/softnic: add flow create API

pmd_flow_create API is added to support rte flow create. Signed-off-by: Cristian Dumitrescu Signed-off-by: Reshma Pattan --- drivers/net/softnic/rte_eth_softnic_flow.c | 174 + 1 file changed, 174 insertions(+) diff --git a/drivers/net/softnic/rte_eth_softnic_flow.c

[dpdk-dev] [PATCH v2 11/15] net/softnic: validate and map flow action with table action

Added validation and mapping of flow rule action with table action profile. Added flow_rule_action_get() to do the same. Signed-off-by: Cristian Dumitrescu Signed-off-by: Reshma Pattan --- drivers/net/softnic/rte_eth_softnic_flow.c | 350 + 1 file changed, 350 inser

[dpdk-dev] [PATCH v2 10/15] net/softnic: validate and map flow with hash table match

Support for validating and mapping flow rule with HASH table match is added. As part of this, below helper functions are added. flow_rule_match_hash_get() hash_key_mask_is_same() Signed-off-by: Cristian Dumitrescu Signed-off-by: Reshma Pattan --- drivers/net/softnic/rte_eth_softnic_flow.c | 20

[dpdk-dev] [PATCH v2 09/15] net/softnic: parse flow protocol for acl table match

Added flow protocol parsing for IPV4/IPV6 and TCP/UDP/SCTP for ACL table rule match. Added below helper functions for doing the same. port_mask_to_range() ipv6_mask_to_depth() ipv4_mask_to_depth() mask_to_depth() Signed-off-by: Cristian Dumitrescu Signed-off-by: Reshma Pattan --- drivers/net/s

[dpdk-dev] [PATCH v2 08/15] net/softnic: validate and map flow rule with acl table match

Support for validating and mapping rte flow rule with ACL table match is added. As part of this support below utility functions been added flow_rule_match_get() flow_rule_match_acl_get() flow_item_skip_disabled_protos() flow_item_proto_preprocess() flow_item_is_proto() flow_item_raw_preprocess()

[dpdk-dev] [PATCH v2 07/15] net/softnic: implement flow validate API

Start adding flow api operations. Started with flow validate api support by adding below basic infrastructure. flow_pipeline_table_get() pmd_flow_validate() Additional flow validate changes will be added in next patches. Signed-off-by: Cristian Dumitrescu Signed-off-by: Reshma Pattan --- dri

[dpdk-dev] [PATCH v2 06/15] net/softnic: add function to get eth device from softnic

Add utility function to get the rte_eth_dev from a given softnic. Signed-off-by: Cristian Dumitrescu Signed-off-by: Reshma Pattan --- drivers/net/softnic/rte_eth_softnic_internals.h | 17 + 1 file changed, 17 insertions(+) diff --git a/drivers/net/softnic/rte_eth_softnic_intern

[dpdk-dev] [PATCH v2 05/15] net/softnic: add free table and find out port functions

Added utility function to freeup the pipeline tables. Added utility functions to find the pipeline output port. Signed-off-by: Cristian Dumitrescu Signed-off-by: Reshma Pattan --- drivers/net/softnic/rte_eth_softnic_internals.h | 13 ++ drivers/net/softnic/rte_eth_softnic_pipeline.c | 57

[dpdk-dev] [PATCH v2 04/15] net/softnic: replace some pointers with arrays

Change dev_name, action_profile_name and key_mask from char* type to arary type of structures softnic_port_in_params, softnic_port_out_params and softnic_table_hash_params. Signed-off-by: Cristian Dumitrescu Signed-off-by: Reshma Pattan --- drivers/net/softnic/rte_eth_softnic_cli.c | 34 +

[dpdk-dev] [PATCH v2 03/15] net/softnic: add new cli for flow attribute map

Added new cli by which user can specify to softnic which rte flow group and direction has to mapped to which pipeline and table. Signed-off-by: Cristian Dumitrescu Signed-off-by: Reshma Pattan --- drivers/net/softnic/rte_eth_softnic_cli.c | 81 +++ 1 file changed, 81

[dpdk-dev] [PATCH v2 02/15] net/softnic: map flow attributes to pipeline table

Added mapping support from rte flow attributes to softnic pipeline and table. So added flow attribute map set and get functions definition to new file rte_eth_sofnic_flow.c. Added pmd flow internals with ingress and egress flow attribute maps. Signed-off-by: Cristian Dumitrescu Signed-off-by: R

[dpdk-dev] [PATCH v2 01/15] net/softnic: add infrastructure for flow API

Add rte_flow infra structure for flow api support. Signed-off-by: Cristian Dumitrescu Signed-off-by: Reshma Pattan --- drivers/net/softnic/rte_eth_softnic_internals.h | 17 + 1 file changed, 17 insertions(+) diff --git a/drivers/net/softnic/rte_eth_softnic_internals.h b/driver

[dpdk-dev] [PATCH v2 00/15] add flow API support to softnic

This patch series adds the flow API support for the softnic. This patch set also introduce a new cli command to provide mapping of flow group and direction to softnic pipeline and table. v2: added missing code to patch #9/10 reworded commit titles. Reshma Pattan (15): net/softnic: add infrastr

Re: [dpdk-dev] [PATCH v7] linuxapp, eal: Fix the memory leak issue of logid

> -Original Message- > From: Aaron Conole [mailto:acon...@redhat.com] > Sent: Tuesday, September 11, 2018 2:47 PM > To: Yang, Ziye > Cc: dev@dpdk.org; Ananyev, Konstantin ; Ziye > Yang > Subject: Re: [dpdk-dev] [PATCH v7] linuxapp, eal: Fix the memory leak issue > of logid > > Ziye

Re: [dpdk-dev] [PATCH 07/15] net/liquidio: rename version map after library file name

On Tue, Sep 11, 2018 at 02:41:36PM +0100, Luca Boccassi wrote: > On Tue, 2018-09-11 at 14:32 +0100, Bruce Richardson wrote: > > On Tue, Sep 11, 2018 at 02:09:30PM +0100, Luca Boccassi wrote: > > > On Tue, 2018-09-11 at 14:06 +0100, Bruce Richardson wrote: > > > > On Mon, Sep 10, 2018 at 09:04:07PM

Re: [dpdk-dev] [PATCH v7] linuxapp, eal: Fix the memory leak issue of logid

Ziye Yang writes: > From: Ziye Yang > > This patch is used to fix the memory leak issue of logid. > We use the ASAN test in SPDK when intergrating DPDK and > find this memory leak issue. > > By the way, we also fix several missed function call of > rte_atomic32_clear. This part I don't understa

Re: [dpdk-dev] [PATCH 07/15] net/liquidio: rename version map after library file name

On Tue, 2018-09-11 at 14:32 +0100, Bruce Richardson wrote: > On Tue, Sep 11, 2018 at 02:09:30PM +0100, Luca Boccassi wrote: > > On Tue, 2018-09-11 at 14:06 +0100, Bruce Richardson wrote: > > > On Mon, Sep 10, 2018 at 09:04:07PM +0100, Luca Boccassi wrote: > > > > The library is called librte_pmd_li

Re: [dpdk-dev] [PATCH 07/15] net/liquidio: rename version map after library file name

On Tue, 2018-09-11 at 14:30 +0100, Bruce Richardson wrote: > On Tue, Sep 11, 2018 at 02:09:30PM +0100, Luca Boccassi wrote: > > On Tue, 2018-09-11 at 14:06 +0100, Bruce Richardson wrote: > > > On Mon, Sep 10, 2018 at 09:04:07PM +0100, Luca Boccassi wrote: > > > > The library is called librte_pmd_li

Re: [dpdk-dev] [PATCH 07/15] net/liquidio: rename version map after library file name

On Tue, Sep 11, 2018 at 02:09:30PM +0100, Luca Boccassi wrote: > On Tue, 2018-09-11 at 14:06 +0100, Bruce Richardson wrote: > > On Mon, Sep 10, 2018 at 09:04:07PM +0100, Luca Boccassi wrote: > > > The library is called librte_pmd_lio, so rename the map file and > > > set > > > the name in the meson

Re: [dpdk-dev] [PATCH 07/15] net/liquidio: rename version map after library file name

On Tue, Sep 11, 2018 at 02:09:30PM +0100, Luca Boccassi wrote: > On Tue, 2018-09-11 at 14:06 +0100, Bruce Richardson wrote: > > On Mon, Sep 10, 2018 at 09:04:07PM +0100, Luca Boccassi wrote: > > > The library is called librte_pmd_lio, so rename the map file and > > > set > > > the name in the meson

Re: [dpdk-dev] [PATCH 0/3] Some fixes/improvements for virtio-user memory table

On 09/05/2018 06:28 AM, Tiwei Bie wrote: This series consists of some fixes and improvements for virtio-user's memory table preparation. This series supersedes below patches: https://patches.dpdk.org/patch/43807/ https://patches.dpdk.org/patch/43918/ The second patch in this series depends o

Re: [dpdk-dev] [PATCH 3/3] net/virtio-user: fix memory hotplug support in vhost-kernel

On 09/05/2018 06:28 AM, Tiwei Bie wrote: It's possible to have much more hugepage backed memory regions than what vhost-kernel supports due to the memory hotplug, which may cause problems. A better solution is to have the virtio-user pass all the memory ranges reserved by DPDK to vhost-kernel.

Re: [dpdk-dev] [PATCH 07/15] net/liquidio: rename version map after library file name

On Tue, 2018-09-11 at 14:06 +0100, Bruce Richardson wrote: > On Mon, Sep 10, 2018 at 09:04:07PM +0100, Luca Boccassi wrote: > > The library is called librte_pmd_lio, so rename the map file and > > set > > the name in the meson file so that the built library names with > > meson > > and legacy makef

Re: [dpdk-dev] [PATCH 10/15] net/thunderx: rename version map after library file name

On Mon, Sep 10, 2018 at 09:04:10PM +0100, Luca Boccassi wrote: > The library is called librte_pmd_thunderx_nicvf, so rename the map file > and set the name in the meson file so that the built library names with > meson and legacy makefiles are the same > > Fixes: 7f615033d64f ("drivers/net: build

Re: [dpdk-dev] [PATCH 07/15] net/liquidio: rename version map after library file name

On Mon, Sep 10, 2018 at 09:04:07PM +0100, Luca Boccassi wrote: > The library is called librte_pmd_lio, so rename the map file and set > the name in the meson file so that the built library names with meson > and legacy makefiles are the same > > Fixes: bad475c03fee ("net/liquidio: add to meson bui

Re: [dpdk-dev] [PATCH v3] net/i40e: add alarm handler

> -Original Message- > From: Xing, Beilei > Sent: Tuesday, September 11, 2018 11:36 AM > To: Zhang, Qi Z > Cc: dev@dpdk.org > Subject: [PATCH v3] net/i40e: add alarm handler > > This patch adds alarm handler, and then i40e PF will use alarm handler instead > of interrupt handler when devi

Re: [dpdk-dev] [PATCH 2/3] net/virtio-user: avoid parsing process mappings

On 09/05/2018 06:28 AM, Tiwei Bie wrote: Recently some memory APIs were introduced to allow users to get the file descriptor and offset for each memory segment. We can leverage those APIs to get rid of the /proc magic on memory table preparation in vhost-user backend. Signed-off-by: Tiwei Bie

Re: [dpdk-dev] [PATCH 1/3] net/virtio-user: fix deadlock in memory events callback

On 09/05/2018 06:28 AM, Tiwei Bie wrote: Deadlock can occur when allocating memory if a vhost-kernel based virtio-user device is in use. To fix the deadlock, we will take memory hotplug lock explicitly in virtio-user when necessary, and always call the _thread_unsafe memory functions. Bugzill

Re: [dpdk-dev] [PATCH v2] net/pcap: Generate unique MAC addresses for interfaces

On 9/10/2018 4:52 PM, Cian Ferriter wrote: > The MAC addresses are generated in a similar manner as in the TAP PMD, > where the address is based on the number of PCAP ports created. > > This is useful for the purposes of debugging DPDK applications using > PCAP devices instead of real devices wher

Re: [dpdk-dev] [PATCH] crypto action

Hi, Sorry about the spam but this patch was not intended to send to DPDK just yet. I need further polish it and splits into a patchset as the v2 of http://patchwork.dpdk.org/patch/43919/ So I marked this patch as rejected in patchwork. Regards, Fan > -Original Message- > From: dev [mail

Re: [dpdk-dev] [PATCH v1] eal: add strscpy function

> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Gaetan Rivet > Sent: Tuesday, September 11, 2018 1:04 PM > To: dev@dpdk.org > Cc: Gaetan Rivet > Subject: [dpdk-dev] [PATCH v1] eal: add strscpy function > > The strncpy function has long been deemed unsafe for

Re: [dpdk-dev] [PATCH v7] linuxapp, eal: Fix the memory leak issue of logid

> -Original Message- > From: Yang, Ziye > Sent: Tuesday, September 11, 2018 2:28 AM > To: dev@dpdk.org > Cc: Ananyev, Konstantin ; Ziye Yang > > Subject: [PATCH v7] linuxapp, eal: Fix the memory leak issue of logid > > From: Ziye Yang > > This patch is used to fix the memory leak is

[dpdk-dev] [PATCH v1] eal: add strscpy function

The strncpy function has long been deemed unsafe for use, in favor of strlcpy or snprintf. While snprintf is standard and strlcpy is still largely available, they both have issues regarding error checking and performance. Both will force reading the source buffer past the requested size if the in

Re: [dpdk-dev] [PATCH v2 0/5] vhost_user.c code cleanup

Hi Nikolay, On 07/19/2018 09:13 PM, Nikolay Nikolaev wrote: vhost: vhost_user.c code cleanup This patchesries introduce a set of code redesigns in vhost_user.c. The goal is to unify and simplify vhost-user message handling. The patches do not intend to introduce any functional changes. v2 cha

Re: [dpdk-dev] [PATCH v2] vhost-user: drop connection on message handling failures

On 09/03/2018 12:12 PM, Ilya Maximets wrote: There are a lot of cases where vhost-user massage handling could fail and end up in a fully not recoverable state. For example, allocation failures of shadow used ring and batched copy array are not recoverable and leads to the segmentation faults l

Re: [dpdk-dev] [PATCH v4 1/2] lib/librte_power: traffic pattern aware power control

Hi Kevin, On 27/6/2018 6:33 PM, Kevin Traynor wrote: On 06/26/2018 12:40 PM, Radu Nicolau wrote: From: Liang Ma 1. Abstract --snip-- 2.2 There are two phases to establish the power management system: a.Initialization/Training phase. There is no traffic pass-through, th

Re: [dpdk-dev] [PATCH 05/15] build: add Meson files for qede PMD

> -Original Message- > From: Luca Boccassi > Sent: Tuesday, September 11, 2018 1:34 AM > To: dev@dpdk.org > Cc: keith.wi...@intel.com; roy.fan.zh...@intel.com; jingjing...@intel.com; > wenzhuo...@intel.com; Mody, Rasesh ; Patil, > Harish ; Shaikh, Shahed > ; amr.mokh...@intel.com; Thotton,

Re: [dpdk-dev] [PATCH] net/fm10k: add imissed stats

Hi, Please, do not merge this patch. I need to check and readapt this patch. A version 2 will be sent later. Thanks, -- Julien Meunier > -Original Message- > From: Wang, Xiao W > Sent: Tuesday, September 11, 2018 3:52 AM > To: Meunier, Julien (Nokia - FR/Paris-Saclay) ; > Zhang, Qi Z

Re: [dpdk-dev] [PATCH v2] ethdev: make default behavior CRC strip on Rx

On Tue, Sep 04, 2018 at 11:12:56AM +0100, Ferruh Yigit wrote: > Removed DEV_RX_OFFLOAD_CRC_STRIP offload flag. > Without any specific Rx offload flag, default behavior by PMDs is to > strip CRC. > > PMDs that support keeping CRC should advertise DEV_RX_OFFLOAD_KEEP_CRC > Rx offload capability. >

[dpdk-dev] [PATCH v3 09/10] event/dsw: implement eventdev 'xstats' counters in DSW

The DSW event device now implements the 'xstats' interface and a number of port- and device-level counters. Signed-off-by: Mattias Rönnblom --- drivers/event/dsw/Makefile | 3 +- drivers/event/dsw/dsw_evdev.c | 5 +- drivers/event/dsw/dsw_evdev.h | 19 +++ drivers/event/dsw/dsw_event.

[dpdk-dev] [PATCH v3 08/10] event/dsw: let DSW event device sort events on dequeue

With this patch, the DSW event device will (optionally) sort the event burst before giving it to the application. The sorting will primarily be on queue id, and secondary on flow id. The sorting is an attempt to optimize data and instruction cache usage for the application, at the cost of addition

[dpdk-dev] [PATCH v3 10/10] event/dsw: include DSW event device documentation

The DSW event device is documented in DPDK Programmer's Guide. Signed-off-by: Mattias Rönnblom --- doc/guides/eventdevs/dsw.rst | 97 ++ doc/guides/eventdevs/index.rst | 1 + 2 files changed, 98 insertions(+) create mode 100644 doc/guides/eventdevs/dsw.rst di

[dpdk-dev] [PATCH v3 06/10] event/dsw: add DSW port load measurements

The DSW event device port now attempts to estimate its load (i.e. how busy it is). This is required for load balancing to work (although load balancing is not included in this patch), and may also be useful for debugging purposes. Signed-off-by: Mattias Rönnblom --- drivers/event/dsw/dsw_evdev.c

[dpdk-dev] [PATCH v3 07/10] event/dsw: add load balancing to the DSW event device

The DSW event device will now attempt to migrate (move) flows between ports in order to balance the load. Signed-off-by: Mattias Rönnblom --- drivers/event/dsw/dsw_evdev.c | 27 ++ drivers/event/dsw/dsw_evdev.h | 80 drivers/event/dsw/dsw_event.c | 735 +-

  1   2   >