Re: [dpdk-dev] [PATCH v2 2/4] eal: modify device event callback process func

2018-10-01 Thread Andrew Rybchenko
On 10/2/18 7:45 AM, Jeff Guo wrote: andrew, On 10/1/2018 5:46 PM, Andrew Rybchenko wrote: On 9/30/18 5:16 PM, Jeff Guo wrote: This patch modify the device event callback process function name to be more explicit, change the variable to be const and exposure the API out from private eal. The bu

Re: [dpdk-dev] [PATCH v2 1/4] eal: add a new req notifier to eal interrupt

2018-10-01 Thread Andrew Rybchenko
On 10/2/18 7:30 AM, Jeff Guo wrote: hi, andrew thanks for your review again, see comment as below. On 10/1/2018 5:46 PM, Andrew Rybchenko wrote: On 9/30/18 5:16 PM, Jeff Guo wrote: Add a new req notifier in eal interrupt for enable vfio hotplug. Signed-off-by: Jeff Guo --- v2->v1: no change

Re: [dpdk-dev] [PATCH v2 3/4] pci: add req handler field to generic pci device

2018-10-01 Thread Jeff Guo
On 10/1/2018 5:46 PM, Andrew Rybchenko wrote: On 9/30/18 5:16 PM, Jeff Guo wrote: There are some extended interrupt types in vfio pci device except from the existing interrupts, such as err and req notifier, they could be useful for device error monitoring. And these corresponding interrupt ha

[dpdk-dev] [PATCH 4/5] net/mlx5: e-switch VXLAN flow translation routine

2018-10-01 Thread Slava Ovsiienko
This part of patchset adds support of VXLAN-related items and actions to the flow translation routine. If some of them are specified in the rule, the extra space for tunnel description structure is allocated. Later some tunnel types, other than VXLAN can be addedd (GRE). No VTEP devices are created

[dpdk-dev] [PATCH 3/5] net/mlx5: e-switch VXLAN flow validation routine

2018-10-01 Thread Slava Ovsiienko
This part of patchset adds support for flow item/actions lists validation. The following entities are now supported: - RTE_FLOW_ITEM_TYPE_VXLAN, contains the tunnel VNI - RTE_FLOW_ACTION_TYPE_VXLAN_DECAP, if this action is specified the items in the flow items list treated as outer network pa

[dpdk-dev] [PATCH 5/5] net/mlx5: e-switch VXLAN tunnel devices management

2018-10-01 Thread Slava Ovsiienko
VXLAN interfaces are dynamically created for each local UDP port of outer networks and then used as targets for TC "flower" filters in order to perform encapsulation. These VXLAN interfaces are system-wide, the only one device with given UDP port can exist in the system (the attempt of creating ano

[dpdk-dev] [PATCH 2/5] net/mlx5: e-switch VXLAN netlink routines update

2018-10-01 Thread Slava Ovsiienko
This part of patchset updates Netlink exchange routines. Message sequence numbers became not random ones, the multipart reply messages are supported, not propagating errors to the following socket calls, Netlink replies buffer size is increased to MNL_SOCKET_BUFFER_SIZE. Suggested-by: Adrien Mazar

[dpdk-dev] [PATCH 1/5] net/mlx5: add VXLAN encap/decap support for e-switch

2018-10-01 Thread Slava Ovsiienko
This patchset adds support for RTE_FLOW_ACTION_TYPE_VXLAN_ENCAP and RTE_FLOW_ACTION_TYPE_VXLAN_DECAP to mlx5 PMD. This patch is refactored version of proposal 20180831092038.23051-2-adrien.mazarg...@6wind.com. A typical use case is port representors in switchdev mode, with VXLAN traffic encapsulat

Re: [dpdk-dev] [PATCH v2 4/4] vfio: enable vfio hotplug by req notifier handler

2018-10-01 Thread Jeff Guo
thanks , andrew. On 10/1/2018 5:47 PM, Andrew Rybchenko wrote: On 9/30/18 5:16 PM, Jeff Guo wrote: When device is be hot-unplugged, the vfio kernel module will sent req notifier to request user space to release the allocated resources at first. After that, vfio kernel module will detect the dev

Re: [dpdk-dev] [PATCH v2 2/4] eal: modify device event callback process func

2018-10-01 Thread Jeff Guo
andrew, On 10/1/2018 5:46 PM, Andrew Rybchenko wrote: On 9/30/18 5:16 PM, Jeff Guo wrote: This patch modify the device event callback process function name to be more explicit, change the variable to be const and exposure the API out from private eal. The bus drivers and eal device would direct

Re: [dpdk-dev] [PATCH v2 1/4] eal: add a new req notifier to eal interrupt

2018-10-01 Thread Jeff Guo
hi, andrew thanks for your review again, see comment as below. On 10/1/2018 5:46 PM, Andrew Rybchenko wrote: On 9/30/18 5:16 PM, Jeff Guo wrote: Add a new req notifier in eal interrupt for enable vfio hotplug. Signed-off-by: Jeff Guo --- v2->v1: no change --- lib/librte_eal/common/include/r

Re: [dpdk-dev] [PATCH v4 1/4] hash: fix race condition in iterate

2018-10-01 Thread Honnappa Nagarahalli
> > >-Original Message- > >From: Honnappa Nagarahalli [mailto:honnappa.nagaraha...@arm.com] > >> @@ -1317,16 +1317,19 @@ rte_hash_iterate(const struct rte_hash *h, > >> const void **key, void **data, uint32 > >>bucket_idx = *next / RTE_HASH_BUCKET_ENTRIES; > >>idx = *next % RTE_HAS

Re: [dpdk-dev] [PATCH v11 6/7] eal: add failure handle mechanism for hot-unplug

2018-10-01 Thread Jeff Guo
hi, constantin On 10/1/2018 3:46 AM, Ananyev, Konstantin wrote: Hi Jeff, The mechanism can initially register the sigbus handler after the device event monitor is enabled. When a sigbus event is captured, it will check the failure address and accordingly handle the memory failure of the corres

Re: [dpdk-dev] [PATCH v4 2/4] hash: add extendable bucket feature

2018-10-01 Thread Honnappa Nagarahalli
> > In use cases that hash table capacity needs to be guaranteed, the extendable > bucket feature can be used to contain extra keys in linked lists when conflict > happens. This is similar concept to the extendable bucket hash table in packet > framework. > > This commit adds the extendable bucke

Re: [dpdk-dev] [PATCH] app/testpmd: check Rx VLAN offload flag to print VLAN TCI

2018-10-01 Thread Hyong Youb Kim
On Mon, Oct 01, 2018 at 03:01:40PM +0100, Ferruh Yigit wrote: > On 9/26/2018 4:06 AM, John Daley wrote: > > From: Hyong Youb Kim > > > > Since the following commit, PKT_RX_VLAN indicates the presence of > > mbuf's vlan_tci, not PKT_RX_VLAN_STRIPPED. > > > > commit 380a7aab1ae2 ("mbuf: rename dep

Re: [dpdk-dev] [PATCH v2 5/7] hash: add extendable bucket feature

2018-10-01 Thread Wang, Yipeng1
>-Original Message- >From: Honnappa Nagarahalli [mailto:honnappa.nagaraha...@arm.com] >> >> +for (i = 1; i <= num_buckets; i++) >> >Since, the bucket index 0 is reserved, should be 'i < num_buckets' >> [Wang, Yipeng] So the bucket array is from 0 to num_buckets - 1, and the >> index Is fro

Re: [dpdk-dev] [PATCH 2/4] hash: add memory ordering to avoid race conditions

2018-10-01 Thread Wang, Yipeng1
>-Original Message- >From: Ola Liljedahl [mailto:ola.liljed...@arm.com] >On 28/09/2018, 02:43, "Wang, Yipeng1" wrote: > >Some general comments for the various __atomic_store/load added, > >1. Although it passes the compiler check, but I just want to confirm that > if we should u

[dpdk-dev] [PATCH v5 2/4] hash: add extendable bucket feature

2018-10-01 Thread Yipeng Wang
In use cases that hash table capacity needs to be guaranteed, the extendable bucket feature can be used to contain extra keys in linked lists when conflict happens. This is similar concept to the extendable bucket hash table in packet framework. This commit adds the extendable bucket feature. User

[dpdk-dev] [PATCH v5 4/4] hash: use partial-key hashing

2018-10-01 Thread Yipeng Wang
This commit changes the hashing mechanism to "partial-key hashing" to calculate bucket index and signature of key. This is proposed in Bin Fan, et al's paper "MemC3: Compact and Concurrent MemCache with Dumber Caching and Smarter Hashing". Bascially the idea is to use "xor" to derive alternative

[dpdk-dev] [PATCH v5 3/4] test/hash: implement extendable bucket hash test

2018-10-01 Thread Yipeng Wang
This commit changes the current rte_hash unit test to test the extendable table feature and performance. Signed-off-by: Yipeng Wang Reviewed-by: Honnappa Nagarahalli --- test/test/test_hash.c | 159 +++-- test/test/test_hash_perf.c | 114

[dpdk-dev] [PATCH v5 1/4] hash: fix race condition in iterate

2018-10-01 Thread Yipeng Wang
In rte_hash_iterate, the reader lock did not protect the while loop which checks empty entry. This created a race condition that the entry may become empty when enters the lock, then a wrong key data value would be read out. This commit reads out the position in the while condition, which makes su

[dpdk-dev] [PATCH v5 0/4] hash: add extendable bucket and partial key hashing

2018-10-01 Thread Yipeng Wang
This patch set made two major optimizations over the current rte_hash library. First, it adds Extendable Bucket Table feature: a new structure that can accommodate keys that failed to get inserted into the main hash table due to the unlikely event of excessive hash collisions. The hash table bucke

Re: [dpdk-dev] [PATCH 1/4] net/mlx5: add flow action functions to glue

2018-10-01 Thread Yongseok Koh
On Thu, Sep 27, 2018 at 05:50:42PM +0300, Dekel Peled wrote: > This patch adds glue functions for operations: > - Create packet reformat (encap/decap) flow action. > - Destroy flow action. > > Signed-off-by: Dekel Peled > --- > drivers/net/mlx5/mlx5_glue.c | 33 +

Re: [dpdk-dev] [PATCH 0/4] Address reader-writer concurrency in rte_hash

2018-10-01 Thread Wang, Yipeng1
>> >> Another comment is as you know we also have a new extension to rte_hash >> to enable extendable buckets and partial-key hashing. Thanks for the >> comments btw. Could you check if your lockless scheme also applies to >> those extensions? >Thank you for reminding me on this. I thought I had co

Re: [dpdk-dev] [PATCH v4 1/4] hash: fix race condition in iterate

2018-10-01 Thread Wang, Yipeng1
>-Original Message- >From: Honnappa Nagarahalli [mailto:honnappa.nagaraha...@arm.com] >> @@ -1317,16 +1317,19 @@ rte_hash_iterate(const struct rte_hash *h, const >> void **key, void **data, uint32 >> bucket_idx = *next / RTE_HASH_BUCKET_ENTRIES; >> idx = *next % RTE_HASH_BUCKET_EN

Re: [dpdk-dev] [PATCH 4/4] hash: enable lock-free reader-writer concurrency

2018-10-01 Thread Wang, Yipeng1
>-Original Message- >From: Honnappa Nagarahalli [mailto:honnappa.nagaraha...@arm.com] >Sent: Sunday, September 30, 2018 9:11 PM >To: Wang, Yipeng1 ; Richardson, Bruce >; De Lara Guarch, Pablo > >Cc: dev@dpdk.org; Gavin Hu (Arm Technology China) ; Steve >Capper ; Ola Liljedahl >; nd ; Gobr

Re: [dpdk-dev] [PATCH 3/4] hash: fix rw concurrency while moving keys

2018-10-01 Thread Wang, Yipeng1
>-Original Message- >From: Honnappa Nagarahalli [mailto:honnappa.nagaraha...@arm.com] >Sent: Sunday, September 30, 2018 4:06 PM >To: Wang, Yipeng1 ; Richardson, Bruce >; De Lara Guarch, Pablo > >Cc: dev@dpdk.org; Gavin Hu (Arm Technology China) ; Steve >Capper ; Ola Liljedahl >; nd >S

Re: [dpdk-dev] [PATCH 2/4] hash: add memory ordering to avoid race conditions

2018-10-01 Thread Wang, Yipeng1
>-Original Message- >From: Honnappa Nagarahalli [mailto:honnappa.nagaraha...@arm.com] >Sent: Sunday, September 30, 2018 3:21 PM >To: Wang, Yipeng1 ; Richardson, Bruce >; De Lara Guarch, Pablo > >Cc: dev@dpdk.org; Gavin Hu (Arm Technology China) ; Steve >Capper ; Ola Liljedahl >; nd >Subj

Re: [dpdk-dev] [PATCH] devtools: use a common prefix for temporary files

2018-10-01 Thread Thomas Monjalon
20/09/2018 13:22, Bruce Richardson: > On Wed, Sep 19, 2018 at 07:16:29PM +0200, Thomas Monjalon wrote: > > Some temporary files were generated in /tmp, others in the current > > directory, and none was "dpdk prefixed". > > > > All these files have a common path prefix now: $TMPDIR/dpdk. > > TMPDIR

Re: [dpdk-dev] [PATCH] devtools: fix printing subject of checked patch

2018-10-01 Thread Thomas Monjalon
01/10/2018 22:48, Neil Horman: > On Mon, Oct 01, 2018 at 10:38:13PM +0200, Thomas Monjalon wrote: > > If checkpatches.sh is not run with verbose option (-v), > > the patch subject is printed as headline of errors only > > if there is an error reported by checkpatch.pl, not with other checks. > > Th

Re: [dpdk-dev] [PATCH v3] devtools: move forbidden tokens awk script to a separate file

2018-10-01 Thread Thomas Monjalon
27/09/2018 11:04, Arnon Warshavsky: > The awk code previously read inline in checkpatches.pl > was using -d which is a bash option, > while bash is not the default shell in all distributions. > Now moved to be read from a separate file. > > Signed-off-by: Arnon Warshavsky > Acked-by: Andrzej Ostr

[dpdk-dev] [PATCH] common/qat: add support for GEN3 devices

2018-10-01 Thread Fiona Trahe
This adds pci detection, queue-pair configuration and documentation for Intel GEN3 QuickAssist devices. Signed-off-by: Fiona Trahe --- doc/guides/cryptodevs/qat.rst | 3 +++ doc/guides/rel_notes/release_18_11.rst | 4 drivers/common/qat/qat_common.h| 3 ++- drivers/commo

[dpdk-dev] [PATCH v2] drivers/qat: fix failure to create PMD

2018-10-01 Thread Fiona Trahe
If QAT crypto pmd failed to be created due to reaching MAX cryptodevs it prevented QAT comp PMD being created. And vice versa. Change to warning in these cases and allow the other PMD to be created. Clarify in documentation. Fixes: c0c90bc4cade ("compress/qat: add create and destroy functions") Cc

Re: [dpdk-dev] [PATCH v2 5/7] hash: add extendable bucket feature

2018-10-01 Thread Honnappa Nagarahalli
> >-Original Message- > >From: Honnappa Nagarahalli [mailto:honnappa.nagaraha...@arm.com] > >> > >> Extendable bucket table composes of buckets that can be linked list > >> to current main table. When extendable bucket is enabled, the table > >> utilization can always acheive 100%. > >IMO,

[dpdk-dev] [PATCH v4 3/4] eal: remove experimental flag of hotplug functions

2018-10-01 Thread Thomas Monjalon
These functions are quite old and are the only available replacement for the deprecated attach/detach functions. Note: some new functions may (again) replace these hotplug functions, in future, with better parameters. Signed-off-by: Thomas Monjalon Reviewed-by: Andrew Rybchenko --- lib/librte_

[dpdk-dev] [PATCH v4 1/4] devargs: remove deprecated functions

2018-10-01 Thread Thomas Monjalon
rte_eal_parse_devargs_str() does not support parsing the bus name at the start of devargs. So it was renamed and deprecated. rte_eal_devargs_add(), rte_eal_devargs_type_count() and rte_eal_devargs_dump() were declared deprecated and had their implementation body renamed. All these functions were

[dpdk-dev] [PATCH v4 4/4] eal: simplify parameters of hotplug functions

2018-10-01 Thread Thomas Monjalon
All information about a device to probe can be grouped in a common string, which is what we usually call devargs. An application should not have to parse this string before calling the EAL probe function. And the syntax could evolve to be more complex and support matching multiple devices in one st

[dpdk-dev] [PATCH v4 0/4] eal: simplify devargs and hotplug functions

2018-10-01 Thread Thomas Monjalon
This is a follow-up of an idea presented at Dublin during the "hotplug talk". Instead of changing the existing hotplug functions, as in the RFC, some new experimental functions are added. The old functions lose their experimental status in order to provide a non-experimental replacement for deprec

[dpdk-dev] [PATCH v4 2/4] devargs: simplify parameters of removal function

2018-10-01 Thread Thomas Monjalon
The function rte_devargs_remove(), which is intended to be internal, can take a devargs structure as argument. The matching is still using string comparison of bus name and device name. It is simpler and may allow a different devargs matching in future. Signed-off-by: Thomas Monjalon Reviewed-by:

Re: [dpdk-dev] [PATCH] devtools: fix printing subject of checked patch

2018-10-01 Thread Neil Horman
On Mon, Oct 01, 2018 at 10:38:13PM +0200, Thomas Monjalon wrote: > If checkpatches.sh is not run with verbose option (-v), > the patch subject is printed as headline of errors only > if there is an error reported by checkpatch.pl, not with other checks. > The headline is moved to a function which i

[dpdk-dev] [PATCH] devtools: fix printing subject of checked patch

2018-10-01 Thread Thomas Monjalon
If checkpatches.sh is not run with verbose option (-v), the patch subject is printed as headline of errors only if there is an error reported by checkpatch.pl, not with other checks. The headline is moved to a function which is called after each check if there is an error and if it has not already

Re: [dpdk-dev] [PATCH v4 1/5] test/hash: fix bucket size in hash perf test

2018-10-01 Thread Honnappa Nagarahalli
> > The bucket size was changed from 4 to 8 but the corresponding perf test was > not changed accordingly. > > In the test, the bucket size and number of buckets are used to map to the > underneath rte_hash structure. They are used to test performance of two > conditions: keys in primary buckets

Re: [dpdk-dev] [PATCH v4 1/4] hash: fix race condition in iterate

2018-10-01 Thread Honnappa Nagarahalli
> > In rte_hash_iterate, the reader lock did not protect the while loop which > checks empty entry. This created a race condition that the entry may become > empty when enters the lock, then a wrong key data value would be read out. > > This commit extends the protected region. > > Fixes: f2e300

Re: [dpdk-dev] [PATCH] net/mlx5: eswitch-IP address UDP/TCP port rewrite

2018-10-01 Thread Yongseok Koh
On Sun, Sep 30, 2018 at 03:21:04PM +0800, Xiaoyu Min wrote: > On 18-09-29 07:03:33, Yongseok Koh wrote: > > On Tue, Sep 25, 2018 at 07:51:06PM +0800, Xiaoyu Min wrote: > > > Offload the following rte_flow actions by inserting accordingly > > > E-Switch rules via TC Flower driver > > > > > > - RTE

Re: [dpdk-dev] [PATCH v4 4/4] hash: use partial-key hashing

2018-10-01 Thread Honnappa Nagarahalli
> > This commit changes the hashing mechanism to "partial-key hashing" to > calculate bucket index and signature of key. > > This is proposed in Bin Fan, et al's paper > "MemC3: Compact and Concurrent MemCache with Dumber Caching and > Smarter Hashing". Bascially the idea is to use "xor" to deri

Re: [dpdk-dev] [PATCH v3 4/4] eal: simplify parameters of hotplug functions

2018-10-01 Thread Thomas Monjalon
01/10/2018 13:26, Andrew Rybchenko: > On 9/28/18 7:21 PM, Thomas Monjalon wrote: > > All information about a device to probe can be grouped > > in a common string, which is what we usually call devargs. > > An application should not have to parse this string before > > calling the EAL probe functio

Re: [dpdk-dev] [PATCH v2] test/hash: solve unit test hash compilation error

2018-10-01 Thread Honnappa Nagarahalli
> > Enable print_key_info() function compilation always. > > Fixes: af75078fece36 ("first public release") > Cc: sta...@dpdk.org > > Suggested-by: Honnappa Nagarahalli > Signed-off-by: Dharmik Thakkar > Reviewed-by: Honnappa Nagarahalli > Reviewed-by: Gavin Hu > --- > v2: > * Fix checkpatch

Re: [dpdk-dev] [PATCH v3 3/4] eal: remove experimental flag of hotplug functions

2018-10-01 Thread Thomas Monjalon
01/10/2018 13:26, Andrew Rybchenko: > On 9/28/18 7:21 PM, Thomas Monjalon wrote: > > These functions are quite old and are the only available replacement > > for the deprecated attach/detach functions. > > > > Note: some new functions may (again) replace these hotplug functions, > > in future, with

Re: [dpdk-dev] [PATCH v4 3/4] test/hash: implement extendable bucket hash test

2018-10-01 Thread Honnappa Nagarahalli
> -Original Message- > From: Yipeng Wang > Sent: Friday, September 28, 2018 12:24 PM > To: bruce.richard...@intel.com > Cc: konstantin.anan...@intel.com; dev@dpdk.org; yipeng1.w...@intel.com; > Honnappa Nagarahalli ; > sameh.gobr...@intel.com > Subject: [PATCH v4 3/4] test/hash: impleme

Re: [dpdk-dev] [PATCH v3 2/4] devargs: simplify parameters of removal function

2018-10-01 Thread Thomas Monjalon
01/10/2018 13:25, Andrew Rybchenko: > On 9/28/18 7:21 PM, Thomas Monjalon wrote: > > The function rte_devargs_remove(), which is intended to be internal, > > can take a devargs structure as argument. > > The matching is still using string comparison of bus name and > > device name. > > It is simple

[dpdk-dev] [pull-request] next-pipeline 18.11 PRE-RC1

2018-10-01 Thread Cristian Dumitrescu
test/crypto: fix number of queue pairs (2018-09-27 13:41:05 +0200) are available in the git repository at: http://dpdk.org/git/next/dpdk-next-pipeline for you to fetch changes up to 8fbb65ab848be6bbf073e0a1db1ec60095368fae: doc: update action documentation (2018-10-01 18:13:54 +0100) --

Re: [dpdk-dev] [PATCH v2 0/7] pipeline: add symmetric crypto to action

2018-10-01 Thread Dumitrescu, Cristian
> -Original Message- > From: Zhang, Roy Fan > Sent: Friday, September 28, 2018 1:26 PM > To: dev@dpdk.org > Cc: Dumitrescu, Cristian > Subject: [PATCH v2 0/7] pipeline: add symmetric crypto to action > > This patchset creates an abstraction layer of DPDK Cryptodev to the pipeline > lib

Re: [dpdk-dev] [PATCH v4] port: add sym crypto port

2018-10-01 Thread Dumitrescu, Cristian
> -Original Message- > From: Zhang, Roy Fan > Sent: Monday, October 1, 2018 11:02 AM > To: dev@dpdk.org > Cc: Dumitrescu, Cristian ; Zhang, Roy Fan > ; Zhang > Subject: [PATCH v4] port: add sym crypto port > > From: "Zhang, Roy Fan" > > This patch adds the symmetric crypto support to

Re: [dpdk-dev] [PATCH v3 1/4] devargs: remove deprecated functions

2018-10-01 Thread Thomas Monjalon
01/10/2018 13:24, Andrew Rybchenko: > On 9/28/18 7:21 PM, Thomas Monjalon wrote: > > rte_eal_parse_devargs_str() does not support parsing the bus name > > at the start of devargs. So it has been renamed and deprecated. > > > > rte_eal_devargs_add(), rte_eal_devargs_type_count() and > > rte_eal_deva

Re: [dpdk-dev] [PATCH v8 01/21] mem: add length to memseg list

2018-10-01 Thread Stephen Hemminger
On Mon, 1 Oct 2018 13:56:09 +0100 Anatoly Burakov wrote: > diff --git a/lib/librte_eal/common/include/rte_eal_memconfig.h > b/lib/librte_eal/common/include/rte_eal_memconfig.h > index aff0688dd..1d8b0a6fe 100644 > --- a/lib/librte_eal/common/include/rte_eal_memconfig.h > +++ b/lib/librte_eal/co

[dpdk-dev] [PATCH] net/softnic: add flow flush API

2018-10-01 Thread Reshma Pattan
Add rte flow flush api for flushing all the flows of the port. Signed-off-by: Reshma Pattan --- This patch depends on below patch sets so must be applied after below patches are applied. https://mails.dpdk.org/archives/dev/2018-September/111379.html https://mails.dpdk.org/archives/dev/2018-Septem

Re: [dpdk-dev] [PATCH 2/4] mbuf: fix Tx offload mask

2018-10-01 Thread Ferruh Yigit
On 10/1/2018 4:53 PM, Jerin Jacob wrote: > -Original Message- >> Date: Mon, 1 Oct 2018 14:45:02 +0100 >> From: Ferruh Yigit >> To: Jerin Jacob , Olivier Matz >> >> CC: dev@dpdk.org, sta...@dpdk.org, jiayu...@intel.com >> Subject: Re: [dpdk-dev] [PATCH 2/4] mbuf: fix Tx offload mask >> Us

Re: [dpdk-dev] [PATCH 1/4] ethdev: add SCTP Rx checksum offload support

2018-10-01 Thread Ferruh Yigit
On 10/1/2018 4:59 PM, Jerin Jacob wrote: > -Original Message- >> Date: Mon, 1 Oct 2018 14:46:39 +0100 >> From: Ferruh Yigit >> To: Jerin Jacob , Wenzhuo Lu >> , Jingjing Wu , Bernard >> Iremonger , John McNamara >> , Marko Kovacevic , >> Thomas Monjalon , Andrew Rybchenko >> >> CC: d

Re: [dpdk-dev] [PATCH v2 1/2] eal: add eal option to configure iova mode

2018-10-01 Thread Eric Zhang
On 09/26/2018 08:42 AM, Burakov, Anatoly wrote: On 18-Sep-18 8:10 PM, eric zhang wrote: From: Santosh Shukla In the case of user don't want to use bus iova scheme and want to override. For that, Adding eal option --iova-mode= where valid input string is 'pa' or 'va'. Signed-off-by: Santos

Re: [dpdk-dev] [PATCH v4 4/4] doc: add usage doc for ENETC PMD

2018-10-01 Thread Ferruh Yigit
On 9/28/2018 8:46 AM, Gagandeep Singh wrote: > Add enetc usage document to compile and run the > DPDK application on enetc supported platform. > This document introduces the enetc driver, supported > platforms and supported features. > > Signed-off-by: Gagandeep Singh <...> > @@ -643,6 +643,13

Re: [dpdk-dev] [PATCH 1/4] ethdev: add SCTP Rx checksum offload support

2018-10-01 Thread Jerin Jacob
-Original Message- > Date: Mon, 1 Oct 2018 14:46:39 +0100 > From: Ferruh Yigit > To: Jerin Jacob , Wenzhuo Lu > , Jingjing Wu , Bernard > Iremonger , John McNamara > , Marko Kovacevic , > Thomas Monjalon , Andrew Rybchenko > > CC: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH 1/4] et

Re: [dpdk-dev] [PATCH v4 3/4] net/enetc: support packet parse type

2018-10-01 Thread Ferruh Yigit
On 9/28/2018 11:17 AM, Shreyansh Jain wrote: > On Friday 28 September 2018 01:16 PM, Gagandeep Singh wrote: >> Signed-off-by: Gagandeep Singh >> --- >> drivers/net/enetc/enetc_ethdev.c | 19 +++ >> 1 file changed, 19 insertions(+) >> > > Commit message is missing in this patch.

Re: [dpdk-dev] [PATCH v4 2/4] net/enetc: enable Rx and Tx

2018-10-01 Thread Ferruh Yigit
On 9/28/2018 8:45 AM, Gagandeep Singh wrote: > Add RX and TX queue setup, datapath functions > > Signed-off-by: Gagandeep Singh <...> > @@ -104,16 +104,19 @@ enum enetc_bdr_type {TX, RX}; > #define ETH_ADDR_LEN 6 > > /* general register accessors */ > -#define enetc_rd_reg(r

Re: [dpdk-dev] [PATCH v4 1/4] net/enetc: add ENETC PMD with basic operations

2018-10-01 Thread Ferruh Yigit
On 9/28/2018 8:45 AM, Gagandeep Singh wrote: > This patch introduces the enetc PMD with basic > initialisation functions includes probe, teardown, > hardware initialisation > > Signed-off-by: Gagandeep Singh <...> > +struct enetc_eth_mac_info { > + uint8_t addr[ETH_ADDR_LEN]; > + uint8_

[dpdk-dev] [PATCH] doc: update the doc for adding EAL option

2018-10-01 Thread eric zhang
This patch updates Programmer's Guide and EAL parameter guides to show EAL option "--iova-mode" support. Signed-off-by: eric zhang --- doc/guides/prog_guide/env_abstraction_layer.rst | 8 doc/guides/testpmd_app_ug/run_app.rst | 4 2 files changed, 12 insertions(+) diff -

Re: [dpdk-dev] [PATCH 2/4] mbuf: fix Tx offload mask

2018-10-01 Thread Jerin Jacob
-Original Message- > Date: Mon, 1 Oct 2018 14:45:02 +0100 > From: Ferruh Yigit > To: Jerin Jacob , Olivier Matz > > CC: dev@dpdk.org, sta...@dpdk.org, jiayu...@intel.com > Subject: Re: [dpdk-dev] [PATCH 2/4] mbuf: fix Tx offload mask > User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:

[dpdk-dev] [PATCH] drivers/qat: fix failure to create PMD

2018-10-01 Thread Fiona Trahe
If QAT crypto pmd failed to be created due to reaching max allowed cryptodevs it prevented QAT comp PMD being created. And vice versa. Change to warning in these cases and allow the other PMD to be created. Fixes: c0c90bc4cade ("compress/qat: add create and destroy functions") Cc: sta...@dpdk.org

Re: [dpdk-dev] [PATCH v8 19/21] app/testpmd: add support for external memory

2018-10-01 Thread Burakov, Anatoly
Hi Bernard, Thanks for your review! Comments inline. + rte_exit(EXIT_FAILURE, + "mp-alloc %s invalid - must be: " + "native, anon or xmem\n", Should xmemhuge be ad

[dpdk-dev] [pull-request] next-eventdev 18.11 PRE-RC1

2018-10-01 Thread Jerin Jacob
The following changes since commit 738ad7b42b63fc5067419bf609296f2c4a6a0cb0: test/crypto: fix number of queue pairs (2018-09-27 13:41:05 +0200) are available in the Git repository at: http://dpdk.org/git/next/dpdk-next-eventdev for you to fetch changes up to 48f07d8d9040b914020965e8c89d092

Re: [dpdk-dev] [PATCH v8 19/21] app/testpmd: add support for external memory

2018-10-01 Thread Iremonger, Bernard
Hi Anatoly, > -Original Message- > From: Burakov, Anatoly > Sent: Monday, October 1, 2018 1:56 PM > To: dev@dpdk.org > Cc: Lu, Wenzhuo ; Wu, Jingjing > ; Iremonger, Bernard ; > Mcnamara, John ; Kovacevic, Marko > ; laszlo.madara...@ericsson.com; > laszlo.vadke...@ericsson.com; andras.kov..

Re: [dpdk-dev] [dpdk-stable] [PATCH] net/nfp: fix RSS

2018-10-01 Thread Ferruh Yigit
On 9/26/2018 2:45 PM, Alejandro Lucero wrote: > Three problems are fixed in this patch: > > - RSS capabilities not advertised properly > - RSS configuration just done for some RSS types > - RSS hash match reported for just some RSS types > > Fixes: 934e4c60fbff ("nfp: add RSS") > Cc: sta...@dp

Re: [dpdk-dev] [PATCH] net/netvsc: check return from kvargs_process

2018-10-01 Thread Ferruh Yigit
On 9/26/2018 10:31 AM, Stephen Hemminger wrote: > Should check return value from processing latency value. > > Coverity issue: 322104 > Signed-off-by: Stephen Hemminger Fixes: a25d39a3eb69 ("net/netvsc: allow tuning latency with devargs") Applied to dpdk-next-net/master, thanks.

Re: [dpdk-dev] [PATCH v2] net/failsafe: report actual device capabilities

2018-10-01 Thread Ferruh Yigit
On 9/26/2018 12:58 PM, Gaëtan Rivet wrote: > On Wed, Sep 26, 2018 at 07:38:04AM +0100, Andrew Rybchenko wrote: >> From: Igor Romanov >> >> Failsafe device capabilities depend on supported by the failsafe >> itself plus capabilities supported by sub-devices. >> Make fs_dev_infos_get() take failsafe

Re: [dpdk-dev] [PATCH 1/6] net/enic: do not use non-standard integer types

2018-10-01 Thread Ferruh Yigit
On 9/26/2018 3:54 AM, John Daley wrote: > From: Hyong Youb Kim > > Bugzilla ID: 39 > Fixes: 9913fbb91df0 ("enic/base: common code") > Fixes: 322b355f2183 ("net/enic/base: bring NIC interface functions up to > date") > > Signed-off-by: Hyong Youb Kim > Reviewed-by: John Daley Series applied t

Re: [dpdk-dev] KNI performance is not what is claimed

2018-10-01 Thread Honnappa Nagarahalli
> > > > On Thu, Sep 20, 2018 at 3:16 PM Stephen Hemminger < > > step...@networkplumber.org> wrote: > > > > > On Thu, 20 Sep 2018 15:02:53 -0500 > > > Jay Rolette wrote: > > > > > > > On Thu, Sep 20, 2018 at 1:11 PM Stephen Hemminger < > > > > step...@networkplumber.org> wrote: > > > > > > > > > I

Re: [dpdk-dev] [PATCH] netvsc: support multicast/promiscuous settings on VF

2018-10-01 Thread Ferruh Yigit
On 9/21/2018 5:54 PM, Stephen Hemminger wrote: > Provide API's to enable allmulticast and promiscuous in Netvsc PMD > with VF. This keeps the VF and PV path in sync. > > Signed-off-by: Stephen Hemminger Applied to dpdk-next-net/master, thanks.

Re: [dpdk-dev] [PATCH] app/testpmd: check Rx VLAN offload flag to print VLAN TCI

2018-10-01 Thread Ferruh Yigit
On 9/26/2018 4:06 AM, John Daley wrote: > From: Hyong Youb Kim > > Since the following commit, PKT_RX_VLAN indicates the presence of > mbuf's vlan_tci, not PKT_RX_VLAN_STRIPPED. > > commit 380a7aab1ae2 ("mbuf: rename deprecated VLAN flags") > Cc: olivier.m...@6wind.com > > Signed-off-by: Hyong

Re: [dpdk-dev] [PATCH] compressdev: fix compression api description

2018-10-01 Thread Akhil Goyal
On 10/1/2018 7:08 PM, Trahe, Fiona wrote: -Original Message- From: Jozwiak, TomaszX Sent: Friday, September 28, 2018 2:14 PM To: dev@dpdk.org; Trahe, Fiona ; Jozwiak, TomaszX ; sta...@dpdk.org; akhil.go...@nxp.com Subject: [PATCH] compressdev: fix compression api description This pa

Re: [dpdk-dev] [PATCH 1/4] ethdev: add SCTP Rx checksum offload support

2018-10-01 Thread Ferruh Yigit
On 9/13/2018 2:47 PM, Jerin Jacob wrote: > Signed-off-by: Jerin Jacob Overall set looks good to me, I put some comments on individual patches. And can you please rebase on top of latest head? Thanks, ferruh

Re: [dpdk-dev] [PATCH 1/4] ethdev: add SCTP Rx checksum offload support

2018-10-01 Thread Ferruh Yigit
On 9/13/2018 2:47 PM, Jerin Jacob wrote: > Signed-off-by: Jerin Jacob > --- > app/test-pmd/config.c | 9 + > doc/guides/nics/features.rst | 4 ++-- > lib/librte_ethdev/rte_ethdev.c | 1 + > lib/librte_ethdev/rte_ethdev.h | 1 + > 4 files changed, 13 insertions(+), 2 deletions(-

Re: [dpdk-dev] [PATCH 4/4] ethdev: add Tx offload outer L4 checksum definitions

2018-10-01 Thread Ferruh Yigit
On 9/13/2018 2:47 PM, Jerin Jacob wrote: > Introduced DEV_TX_OFFLOAD_OUTER_UDP_CKSUM, DEV_TX_OFFLOAD_OUTER_TCP_CKSUM > and DEV_TX_OFFLOAD_OUTER_SCTP_CKSUM offload flags and > > PKT_TX_OUTER_L4_NO_CKSUM, PKT_TX_OUTER_TCP_CKSUM, PKT_TX_OUTER_SCTP_CKSUM > and PKT_TX_OUTER_UDP_CKSUM mbuf ol_flags to e

Re: [dpdk-dev] [PATCH 2/4] mbuf: fix Tx offload mask

2018-10-01 Thread Ferruh Yigit
On 9/13/2018 2:47 PM, Jerin Jacob wrote: > Fixes missing PKT_TX_UDP_SEG value in PKT_TX_OFFLOAD_MASK. > > Fixes: 6d18505efaa6 ("vhost: support UDP Fragmentation Offload") > Cc: sta...@dpdk.org > Cc: jiayu...@intel.com > > Signed-off-by: Jerin Jacob > --- > lib/librte_mbuf/rte_mbuf.h | 3 ++- >

Re: [dpdk-dev] [PATCH] compressdev: fix compression api description

2018-10-01 Thread Trahe, Fiona
> -Original Message- > From: Jozwiak, TomaszX > Sent: Friday, September 28, 2018 2:14 PM > To: dev@dpdk.org; Trahe, Fiona ; Jozwiak, TomaszX > ; sta...@dpdk.org; akhil.go...@nxp.com > Subject: [PATCH] compressdev: fix compression api description > > This patch fixes description of API f

Re: [dpdk-dev] [PATCH v2 0/6] crypto/mvsam: add new features and fixes

2018-10-01 Thread Akhil Goyal
On 9/21/2018 8:23 PM, Andrzej Ostruszka wrote: This patch series introduces following changes: * Add support for HMAC SHA224, AES ECB and NULL algorithms. * Update hash digest sizes to match hardware capabilities. * Fix a shared build. v2: * added Cc: sta...@dpdk.org to couple of patches

[dpdk-dev] [PATCH 1/3] app/compress-perf: add parser

2018-10-01 Thread Tomasz Jozwiak
Added parser part into compression perf. test. Signed-off-by: De Lara Guarch, Pablo Signed-off-by: Tomasz Jozwiak --- app/Makefile | 4 + app/meson.build | 1 + app/test-compress-perf/Makefile | 16 + app

[dpdk-dev] [PATCH 2/3] app/compress-perf: add performance measurement

2018-10-01 Thread Tomasz Jozwiak
Added performance measurement part into compression perf. test. Signed-off-by: De Lara Guarch, Pablo Signed-off-by: Tomasz Jozwiak --- app/test-compress-perf/main.c | 844 ++ 1 file changed, 844 insertions(+) diff --git a/app/test-compress-perf/main.c b/

[dpdk-dev] [PATCH 3/3] doc/guides/tools: add doc file

2018-10-01 Thread Tomasz Jozwiak
Added initial version of compression performance test description file. Signed-off-by: De Lara Guarch, Pablo Signed-off-by: Tomasz Jozwiak --- MAINTAINERS| 5 +++ doc/guides/tools/comp_perf.rst | 73 ++ 2 files changed, 78 insertions(

[dpdk-dev] [PATCH 0/3] app: add initial version of compress-perf

2018-10-01 Thread Tomasz Jozwiak
This patchset adds initial version of compression performance test. Tomasz Jozwiak (3): app/compress-perf: add parser app/compress-perf: add performance measurement doc/guides/tools: add doc file MAINTAINERS | 5 + app/Makefile

Re: [dpdk-dev] [PATCH v2 0/3] crypto/mvsam: yet another round of features

2018-10-01 Thread Akhil Goyal
On 9/21/2018 6:54 PM, Andrzej Ostruszka wrote: Following changes are introduced in this patch series: * Add S/G support. * Start using common/mvep for DMA memory initialization. * Add dynamic logging support. Note that 'crypto/mvsam: common use initialization' relies on 'net/mvpp2: use commo

Re: [dpdk-dev] [PATCH 0/3] crypto/mvsam: align with MUSDK 18.09

2018-10-01 Thread Akhil Goyal
On 9/4/2018 7:29 PM, Tomasz Duszynski wrote: This patch series aligns MVSAM PMD with MUSDK 18.09. Dmitri Epshtein (2): doc: update mvsam documentation crypto/mvsam: get number of CIOs dynamically Tomasz Duszynski (1): crypto/mvsam: update features list doc/guides/cryptodevs/featu

Re: [dpdk-dev] [PATCH v7] app/testpmd: add forwarding mode to simulate a noisy neighbour

2018-10-01 Thread Iremonger, Bernard
Hi Jens, > -Original Message- > From: Jens Freimann [mailto:jfreim...@redhat.com] > Sent: Friday, September 21, 2018 2:27 PM > To: dev@dpdk.org > Cc: ai...@redhat.com; jan.scheur...@ericsson.com; Richardson, Bruce > ; tho...@monjalon.net; > maxime.coque...@redhat.com; Ananyev, Konstantin >

[dpdk-dev] [PATCH v8 13/21] malloc: allow adding memory to named heaps

2018-10-01 Thread Anatoly Burakov
Add an API to add externally allocated memory to malloc heap. The memory will be stored in memseg lists like regular DPDK memory. Multiple segments are allowed within a heap. If IOVA table is not provided, IOVA addresses are filled in with RTE_BAD_IOVA. Signed-off-by: Anatoly Burakov --- lib/lib

[dpdk-dev] [PATCH v8 02/21] mem: allow memseg lists to be marked as external

2018-10-01 Thread Anatoly Burakov
When we allocate and use DPDK memory, we need to be able to differentiate between DPDK hugepage segments and segments that were made part of DPDK but are externally allocated. Add such a property to memseg lists. This breaks the ABI, so document the change in release notes. This also breaks a few

[dpdk-dev] [PATCH v8 00/21] Support externally allocated memory in DPDK

2018-10-01 Thread Anatoly Burakov
This is a proposal to enable using externally allocated memory in DPDK. In a nutshell, here is what is being done here: - Index internal malloc heaps by NUMA node index, rather than NUMA node itself (external heaps will have ID's in order of creation) - Add identifier string to malloc heap, to

[dpdk-dev] [PATCH v8 07/21] sched: do not check for invalid socket ID

2018-10-01 Thread Anatoly Burakov
We will be assigning "invalid" socket ID's to external heap, and malloc will now be able to verify if a supplied socket ID is in fact a valid one, rendering parameter checks for sockets obsolete. Signed-off-by: Anatoly Burakov Acked-by: Cristian Dumitrescu --- lib/librte_sched/rte_sched.c | 2 +

[dpdk-dev] [PATCH v8 16/21] malloc: allow detaching from external memory

2018-10-01 Thread Anatoly Burakov
Add API to detach from existing chunk of external memory in a process. Signed-off-by: Anatoly Burakov --- lib/librte_eal/common/include/rte_malloc.h | 27 +++ lib/librte_eal/common/rte_malloc.c | 31 +- lib/librte_eal/rte_eal_version.map | 1 +

[dpdk-dev] [PATCH v8 18/21] test: add unit tests for external memory support

2018-10-01 Thread Anatoly Burakov
Add simple unit tests to test external memory support. The tests are pretty basic and mostly consist of checking if invalid API calls are handled correctly, plus a simple allocation/deallocation test for malloc and memzone. Signed-off-by: Anatoly Burakov --- test/test/Makefile| 1 +

[dpdk-dev] [PATCH v8 04/21] mem: do not check for invalid socket ID

2018-10-01 Thread Anatoly Burakov
We will be assigning "invalid" socket ID's to external heap, and malloc will now be able to verify if a supplied socket ID is in fact a valid one, rendering parameter checks for sockets obsolete. This changes the semantics of what we understand by "socket ID", so document the change in the release

[dpdk-dev] [PATCH v8 10/21] malloc: add function to check if socket is external

2018-10-01 Thread Anatoly Burakov
An API is needed to check whether a particular socket ID belongs to an internal or external heap. Prime user of this would be mempool allocator, because normal assumptions of IOVA contiguousness in IOVA as VA mode do not hold in case of externally allocated memory. Signed-off-by: Anatoly Burakov

[dpdk-dev] [PATCH v8 20/21] doc: add external memory feature to the release notes

2018-10-01 Thread Anatoly Burakov
Document the addition of external memory support to DPDK. Signed-off-by: Anatoly Burakov --- doc/guides/rel_notes/release_18_11.rst | 6 ++ 1 file changed, 6 insertions(+) diff --git a/doc/guides/rel_notes/release_18_11.rst b/doc/guides/rel_notes/release_18_11.rst index cb6308b1f..9c5f24af

  1   2   >