[dpdk-dev] [PATCH v8] net/pcap: physical interface MAC address support

2018-10-05 Thread Ferruh Yigit
From: Juhamatti Kuusisaari At the moment, PCAP interfaces use dummy MAC by default. This change adds support for selecting PCAP physical interface MAC with phy_mac=1 devarg. This allows to setup packet flows using the physical interface MAC. Signed-off-by: Juhamatti Kuusisaari Signed-off-by: Fe

Re: [dpdk-dev] [PATCH v2 1/4] ethdev: add Rx offload outer UDP checksum definition

2018-10-05 Thread Thomas Monjalon
05/10/2018 22:04, Ferruh Yigit: > On 10/4/2018 6:59 AM, Jerin Jacob wrote: > > From: Andrew Rybchenko > >> On 03.10.2018 21:14, Jerin Jacob wrote: > >>> From: Andrew Rybchenko > On 03.10.2018 20:12, Jerin Jacob wrote: > > From: Jerin Jacob > >> From: Andrew Rybchenko > >>> 3. P

Re: [dpdk-dev] [PATCH v2 00/10] introduce telemetry library

2018-10-05 Thread Gaëtan Rivet
On Thu, Oct 04, 2018 at 05:53:53PM +0200, Thomas Monjalon wrote: > 04/10/2018 15:25, Van Haaren, Harry: > > From: Van Haaren, Harry > > > From: Laatz, Kevin > > > > > > > > This patchset introduces a Telemetry library for DPDK Service Assurance. > > > > This library provides an easy way to query DP

[dpdk-dev] [PATCH v2] testpmd: sfp eeprom display

2018-10-05 Thread Gaetan Rivet
The interactive command show port sfp_eeprom will dump the content of the SFP EEPROM for the selected port. Dumping SFP eeprom of all ports at once is not supported. Signed-off-by: Gaetan Rivet --- app/test-pmd/cmdline.c | 9 +++-- app/test-pmd/config.c | 32 ++

Re: [dpdk-dev] [PATCH v6 4/5] vhost: unify message handling function signature

2018-10-05 Thread Nikolay Nikolaev
On Tue, Oct 2, 2018 at 11:59 AM Maxime Coquelin wrote: > > > > On 09/24/2018 10:17 PM, Nikolay Nikolaev wrote: > > Each vhost-user message handling function will return an int result > > which is described in the new enum vh_result: error, OK and reply. > > All functions will now have two argument

Re: [dpdk-dev] [PATCH v3 1/3] ring: read tail using atomic load

2018-10-05 Thread Ola Liljedahl
On 05/10/2018, 22:29, "Honnappa Nagarahalli" wrote: > > I doubt it is possible to benchmark with such a precision so to see the > potential difference of one ADD instruction. > Just changes in function alignment can affect performance by percents. And > the natural variat

Re: [dpdk-dev] [PATCH v3 1/3] ring: read tail using atomic load

2018-10-05 Thread Honnappa Nagarahalli
> > I doubt it is possible to benchmark with such a precision so to see the > potential difference of one ADD instruction. > Just changes in function alignment can affect performance by percents. And > the natural variation when not using a 100% deterministic system is going to > be a lot larger t

Re: [dpdk-dev] [PATCH v3 1/3] ring: read tail using atomic load

2018-10-05 Thread Ola Liljedahl
I doubt it is possible to benchmark with such a precision so to see the potential difference of one ADD instruction. Just changes in function alignment can affect performance by percents. And the natural variation when not using a 100% deterministic system is going to be a lot larger than one cy

Re: [dpdk-dev] [PATCH v3 1/3] ring: read tail using atomic load

2018-10-05 Thread Honnappa Nagarahalli
Hi Jerin, Thank you for generating the disassembly, that is really helpful. I agree with you that we have the option of moving parts 2 and 3 forward. I will let Gavin take a decision. I suggest that we run benchmarks on this patch alone and in combination with other patches in the serie

Re: [dpdk-dev] [PATCH v2 1/4] ethdev: add Rx offload outer UDP checksum definition

2018-10-05 Thread Ferruh Yigit
On 10/4/2018 6:59 AM, Jerin Jacob wrote: > -Original Message- >> Date: Wed, 3 Oct 2018 22:47:15 +0300 >> From: Andrew Rybchenko >> To: Jerin Jacob >> CC: Wenzhuo Lu , Jingjing Wu , >> Bernard Iremonger , John McNamara >> , Marko Kovacevic , >> Thomas Monjalon , Ferruh Yigit >> , Olivi

Re: [dpdk-dev] [PATCH 1/2] doc: clarify L3 Tx checksum prerequisite

2018-10-05 Thread Ferruh Yigit
On 10/5/2018 5:46 AM, Jerin Jacob wrote: > Based on PKT_TX_IP_CKSUM definition the user needs > to fill l2_len and l3_len mbuf fields before issuing > HW Tx checksum request. > > Fixes: dad1ec72a377 ("doc: document NIC features") > Cc: sta...@dpdk.org > > Signed-off-by: Jerin Jacob > --- > > Se

Re: [dpdk-dev] [PATCH v2 1/4] ethdev: add Rx offload outer UDP checksum definition

2018-10-05 Thread Ferruh Yigit
On 10/4/2018 6:59 AM, Jerin Jacob wrote: > -Original Message- >> Date: Wed, 3 Oct 2018 22:47:15 +0300 >> From: Andrew Rybchenko >> To: Jerin Jacob >> CC: Wenzhuo Lu , Jingjing Wu , >> Bernard Iremonger , John McNamara >> , Marko Kovacevic , >> Thomas Monjalon , Ferruh Yigit >> , Olivi

[dpdk-dev] [PATCH v7] net/pcap: physical interface MAC address support

2018-10-05 Thread Ferruh Yigit
From: Juhamatti Kuusisaari At the moment, PCAP interfaces use dummy MAC by default. This change adds support for selecting PCAP physical interface MAC with phy_mac=1 devarg. This allows to setup packet flows using the physical interface MAC. Signed-off-by: Juhamatti Kuusisaari Signed-off-by: Fe

Re: [dpdk-dev] [PATCH v3 1/3] ethdev: support metadata as flow rule criteria

2018-10-05 Thread Yongseok Koh
> On Oct 5, 2018, at 6:39 AM, Andrew Rybchenko > wrote: > > On 10/5/18 4:31 PM, Ferruh Yigit wrote: >> On 9/27/2018 2:57 PM, Dekel Peled wrote: >>> As described in [1], a new rte_flow item is added to support metadata >>> to use as flow rule match pattern. >>> The metadata is an opaque item, f

Re: [dpdk-dev] [PATCH v2 3/3] net/mlx5: eswitch-modify TTL actions

2018-10-05 Thread Yongseok Koh
> On Oct 5, 2018, at 5:48 AM, Ferruh Yigit wrote: > > On 9/25/2018 3:37 PM, Xiaoyu Min wrote: >> Offload following modify TTL actions to E-Switch via >> TC-Flower driver >> >> - RTE_FLOW_ACTION_TYPE_SET_TTL >> - RTE_FLOW_ACTION_TYPE_DEC_TTL >> >> The corresponding IP protocol rte_flow_item_ip

[dpdk-dev] DPDK Release Status Meeting 4/10/2018

2018-10-05 Thread Ferruh Yigit
Minutes 4 October 2018 -- Agenda: * Dates * Subtrees * Bugzilla Participants: * Intel * RedHat * Mellanox Release Dates - * RC1 date *pushed a week*, it is now *12th October 2018* * Delay is because of existing patch backlog. Subtrees * main * Stil

Re: [dpdk-dev] [PATCH v2] net/mlx5: allow multiple probing for representor

2018-10-05 Thread Yongseok Koh
> On Oct 5, 2018, at 4:06 AM, Ophir Munk wrote: > > Implement probing of a device multiple times, see [1]. > Consecutive probing requests with a devargs string may contain > repetitive master and representors devices for which eth device should > be created. If an eth device already exists - sile

Re: [dpdk-dev] [PATCH v3 1/3] ring: read tail using atomic load

2018-10-05 Thread Ola Liljedahl
So you don't want to write the proper C11 code because the compiler generates one extra instruction that way? You don't even know if that one extra instruction has any measurable impact on performance. E.g. it could be issued the cycle before together with other instructions. We can complain to

Re: [dpdk-dev] [PATCH v3 1/3] ring: read tail using atomic load

2018-10-05 Thread Jerin Jacob
-Original Message- > Date: Fri, 5 Oct 2018 15:11:44 + > From: Honnappa Nagarahalli > To: "Ananyev, Konstantin" , Ola Liljedahl > , "Gavin Hu (Arm Technology China)" > , Jerin Jacob > CC: "dev@dpdk.org" , Steve Capper , nd > , "sta...@dpdk.org" > Subject: RE: [PATCH v3 1/3] ring: r

Re: [dpdk-dev] [PATCH v2] ethdev: add field for device data per process

2018-10-05 Thread Alejandro Lucero
On Fri, Oct 5, 2018 at 5:37 PM Andrew Rybchenko wrote: > On 10/5/18 7:16 PM, Alejandro Lucero wrote: > > Primary and secondary processes share a per-device private data. With > current design it is not possible to have data per-device per-process. > This is required for handling properly the CPP

Re: [dpdk-dev] [PATCH v2] ethdev: add field for device data per process

2018-10-05 Thread Andrew Rybchenko
On 10/5/18 7:16 PM, Alejandro Lucero wrote: Primary and secondary processes share a per-device private data. With current design it is not possible to have data per-device per-process. This is required for handling properly the CPP interface inside the NFP PMD with multiprocess support. There is

Re: [dpdk-dev] [PATCH v2 2/4] drivers: prefix global variables with module name

2018-10-05 Thread Maxime Coquelin
On 10/05/2018 06:26 PM, Ferruh Yigit wrote: drivers/net/virtio/virtio_user/vhost.h| 4 +- drivers/net/virtio/virtio_user/vhost_kernel.c | 2 +- drivers/net/virtio/virtio_user/vhost_user.c | 2 +- For the virtio-user part: Reviewed-by: Maxime Coquelin Thanks, Maxime

[dpdk-dev] [PATCH v2] compress/qat: enable dynamic huffman encoding

2018-10-05 Thread Fiona Trahe
Enable dynamic huffman encoding in the QAT comp PMD. Signed-off-by: Tomasz Jozwiak Signed-off-by: Fiona Trahe --- v2 changes: - allocate 2 buffers per intermediate buffer sgl - Compile out trace for debugging intermediate buffers Depends on: https://patches.dpdk.org/patch/45794/ config/com

[dpdk-dev] [PATCH v2] ethdev: add field for device data per process

2018-10-05 Thread Alejandro Lucero
Primary and secondary processes share a per-device private data. With current design it is not possible to have data per-device per-process. This is required for handling properly the CPP interface inside the NFP PMD with multiprocess support. There is also at least another PMD driver, tap, with s

Re: [dpdk-dev] [PATCH v4 2/2] build: add drivers_install_subdir meson option

2018-10-05 Thread Timothy Redaelli
On Tue, 2 Oct 2018 17:20:46 +0100 Luca Boccassi wrote: > Allow users and packagers to override the default dpdk/drivers > subdirectory where the PMDs get installed under $lib. > > Signed-off-by: Luca Boccassi > --- Acked-by: Timothy Redaelli

Re: [dpdk-dev] [PATCH v4 1/2] build: change default PMD installation subdir to dpdk/pmds-XX.YY

2018-10-05 Thread Timothy Redaelli
On Tue, 2 Oct 2018 17:20:45 +0100 Luca Boccassi wrote: > As part of the effort of consolidating the DPDK installation bits and > pieces across distros, set the default directory of lib/ where PMDs get > installed to dpdk/pmds-XX.YY. It's necessary to have a versioned > subdirectory as multiple A

Re: [dpdk-dev] [PATCH v2 1/4] add missing static keyword to globals

2018-10-05 Thread Andrew Rybchenko
On 10/5/18 7:26 PM, Ferruh Yigit wrote: Some global variables can indeed be static, add static keyword to them. Signed-off-by: Ferruh Yigit --- <...> diff --git a/drivers/net/sfc/sfc_rx.c b/drivers/net/sfc/sfc_rx.c index 000cd0b20..e71ddd001 100644 --- a/drivers/net/sfc/sfc_rx.c +++ b/driver

Re: [dpdk-dev] DPDK 18.05 only works with up to 4 NUMAs systems

2018-10-05 Thread Burakov, Anatoly
On 04-Oct-18 6:07 PM, Sandeep Raman wrote: Hi Anatoly, I made the changes per the patch http://patches.dpdk.org/patch/43298/, however testpmd failed. Alongwith the patch, CONFIG_RTE_MAX_MEM_MB was increased to 1048576. Logs at https://pastebin.com/XPCDRD2h. Cheers, Hi, Please try this pat

Re: [dpdk-dev] DPDK 18.05 only works with up to 4 NUMAs systems

2018-10-05 Thread Sandeep Raman
Hi Anatoly, I made the changes per the patch http://patches.dpdk.org/patch/43298/, however testpmd failed. Alongwith the patch, CONFIG_RTE_MAX_MEM_MB was increased to 1048576. Logs at https://pastebin.com/XPCDRD2h. Cheers,

[dpdk-dev] [PATCH v2 4/4] lib: reduce global variable usage

2018-10-05 Thread Ferruh Yigit
Some global variables can be eliminated, since they are not part of public interface, it is free to remove them. Signed-off-by: Ferruh Yigit --- lib/librte_compressdev/rte_compressdev.c | 32 -- lib/librte_compressdev/rte_compressdev_pmd.h | 5 --- lib/librte_cryptodev/rte_c

[dpdk-dev] [PATCH v2 3/4] fix global variable issues

2018-10-05 Thread Ferruh Yigit
Various fixes related to the global variable usage. Fixes: 43e610bb8565 ("compress/octeontx: introduce octeontx zip PMD") Fixes: c378f084d6e3 ("compress/octeontx: add device setup ops") Fixes: b43ebc65aada ("compress/octeontx: create private xform") Fixes: b1ce8ebd97ba ("eventdev: add PMD callback

[dpdk-dev] [PATCH v2 2/4] drivers: prefix global variables with module name

2018-10-05 Thread Ferruh Yigit
Some global variables are defined with generic names, add component name as prefix to variables to prevent collusion with application variables. Signed-off-by: Ferruh Yigit --- drivers/bus/dpaa/include/fsl_fman_crc64.h | 8 ++-- .../scheduler/rte_cryptodev_scheduler.c | 26 +-

[dpdk-dev] [PATCH v2 1/4] add missing static keyword to globals

2018-10-05 Thread Ferruh Yigit
Some global variables can indeed be static, add static keyword to them. Signed-off-by: Ferruh Yigit --- Series is based on next-net tree --- app/pdump/main.c| 6 +++--- drivers/bus/dpaa/base/fman/netcfg_layer.c | 2 +- drivers/bus/dpaa/dpaa_bus.c

Re: [dpdk-dev] [PATCH v3 1/3] ring: read tail using atomic load

2018-10-05 Thread Honnappa Nagarahalli
> > > > > > Hi Jerin, > > > > > > Thanks for your review, inline comments from our internal > discussions. > > > > > > BR. Gavin > > > > > > > -Original Message- > > > > From: Jerin Jacob > > > > Sent: Saturday

Re: [dpdk-dev] [PATCH v1 0/2] CPU non-blocking delay

2018-10-05 Thread Wiles, Keith
> On Oct 5, 2018, at 9:44 AM, Ilya Maximets wrote: > > On 05.10.2018 17:09, Wiles, Keith wrote: >> >> >>> On Sep 3, 2018, at 9:44 AM, Ilya Maximets wrote: >>> >>> For meson build without deprecation warnings following >>> patch should be applied first: >>> http://patches.dpdk.org/patch/4

Re: [dpdk-dev] [PATCH 01/10] eal: add shorthand __rte_weak macro

2018-10-05 Thread Wiles, Keith
> On Oct 5, 2018, at 9:11 AM, Wiles, Keith wrote: > > > >> On Oct 3, 2018, at 11:09 AM, Yigit, Ferruh wrote: >> >> On 8/3/2018 3:05 PM, keith.wiles at intel.com (Keith Wiles) wrote: >>> Signed-off-by: Keith Wiles >>> --- >>> lib/librte_eal/common/include/rte_common.h | 5 + >>> 1 file

[dpdk-dev] [PATCH v2] add shorthand support for __rte_weak macro

2018-10-05 Thread Keith Wiles
eal: add shorthand __rte_weak macro qat: update code to use __rte_weak macro avf: update code to use __rte_weak macro fm10k: update code to use __rte_weak macro i40e: update code to use __rte_weak macro ixgbe: update code to use __rte_weak macro mlx5: update code to use __rte_weak macro virtio: upd

Re: [dpdk-dev] [PATCH] ethdev: add field for device data per process

2018-10-05 Thread Thomas Monjalon
05/10/2018 15:26, Ferruh Yigit: > On 10/5/2018 2:17 PM, Alejandro Lucero wrote: > > On Fri, Oct 5, 2018 at 2:01 PM Ferruh Yigit wrote: > >> Will there be new version? > >> > >> Are we agree on name? > >> > >> Is LIBABIVER increase should be done in this patch, or will there be other > >> patch > >

[dpdk-dev] [PATCH 3/3] net/sfc: support Tx descriptor status on EF10 datapath

2018-10-05 Thread Andrew Rybchenko
From: Igor Romanov The implemention is shared by ef10 and ef10_simple datapaths. Signed-off-by: Igor Romanov Signed-off-by: Andrew Rybchenko --- doc/guides/rel_notes/release_18_11.rst | 2 ++ drivers/net/sfc/sfc_ef10_tx.c | 43 -- 2 files changed, 42 insertio

[dpdk-dev] [PATCH 2/3] net/sfc: support TSO in EF10 Tx datapath

2018-10-05 Thread Andrew Rybchenko
From: Igor Romanov Implementation includes following limitations: 1) Paket's header length must be less than 256 (SFC_TSOH_STD_LEN); 2) Offset of the TCP header must be less than 208 (EF10_TCP_HEADER_OFFSET_LIMIT); 3) Number of Tx descriptors must be not less than number of descriptors nee

[dpdk-dev] [PATCH 1/3] net/sfc: put generalised TSO declarations in a header

2018-10-05 Thread Andrew Rybchenko
From: Igor Romanov Move general TSO declarations in a separate header to be able to use them in other datapaths (not only EFX). Also update the function that prepares TSO header to make it useful in other datapaths. Signed-off-by: Igor Romanov Signed-off-by: Andrew Rybchenko --- drivers/net/s

[dpdk-dev] [PATCH 0/3] net/sfc: support more features in EF10 Tx

2018-10-05 Thread Andrew Rybchenko
There are few warnings generated by the checkpatches.sh due to positive errno used inside the driver. Igor Romanov (3): net/sfc: put generalised TSO declarations in a header net/sfc: support TSO in EF10 Tx datapath net/sfc: support Tx descriptor status on EF10 datapath doc/guides/nics/sfc_

Re: [dpdk-dev] [PATCH v1 0/2] CPU non-blocking delay

2018-10-05 Thread Ilya Maximets
On 05.10.2018 17:09, Wiles, Keith wrote: > > >> On Sep 3, 2018, at 9:44 AM, Ilya Maximets wrote: >> >> For meson build without deprecation warnings following >> patch should be applied first: >>http://patches.dpdk.org/patch/44129/ > > Not to be super picky (OK I am super picky sometimes) ca

Re: [dpdk-dev] [PATCH v3 18/19] vhost: add flag to enable postcopy live-migration

2018-10-05 Thread Ilya Maximets
I think it'll be nice to have a warning in case zero-copy and postcopy enabled at the same time. This warning will clarify for users why postcopy is not enabled. What do you think? Maybe we can also move the check from the previous patch to rte_vhost_driver_register() like it done for VIRTIO_F_IN_

Re: [dpdk-dev] [PATCH v3 1/3] ring: read tail using atomic load

2018-10-05 Thread Ola Liljedahl
On 05/10/2018, 15:45, "Ananyev, Konstantin" wrote: We all know that 32bit load/store on cpu we support - are atomic. Well, not necessarily true for unaligned loads and stores. But the "problem" here is that we are not directly generating 32-bit load and store instructions (that would re

Re: [dpdk-dev] [PATCH 01/10] eal: add shorthand __rte_weak macro

2018-10-05 Thread Wiles, Keith
> On Oct 3, 2018, at 11:09 AM, Yigit, Ferruh wrote: > > On 8/3/2018 3:05 PM, keith.wiles at intel.com (Keith Wiles) wrote: >> Signed-off-by: Keith Wiles >> --- >> lib/librte_eal/common/include/rte_common.h | 5 + >> 1 file changed, 5 insertions(+) >> >> diff --git a/lib/librte_eal/common/

Re: [dpdk-dev] [PATCH v1 0/2] CPU non-blocking delay

2018-10-05 Thread Wiles, Keith
> On Sep 3, 2018, at 9:44 AM, Ilya Maximets wrote: > > For meson build without deprecation warnings following > patch should be applied first: >http://patches.dpdk.org/patch/44129/ Not to be super picky (OK I am super picky sometimes) can we change the name of the function rte_delay_us_s

Re: [dpdk-dev] [PATCH 0/3] app/testpmd: add l3 encap/decap cmd

2018-10-05 Thread Ori Kam
> -Original Message- > From: Ferruh Yigit > Sent: Friday, October 5, 2018 4:35 PM > To: Ori Kam ; wenzhuo...@intel.com; > jingjing...@intel.com; bernard.iremon...@intel.com; > arybche...@solarflare.com; step...@networkplumber.org; Adrien Mazarguil > > Cc: dev@dpdk.org; Dekel Peled ; Tho

Re: [dpdk-dev] [PATCH v2 0/3] ethdev: add generic L2/L3 tunnel encapsulation actions

2018-10-05 Thread Ori Kam
> -Original Message- > From: Ferruh Yigit > Sent: Friday, October 5, 2018 3:57 PM > To: Ori Kam ; arybche...@solarflare.com; > step...@networkplumber.org; Adrien Mazarguil > > Cc: dev@dpdk.org; Dekel Peled ; Thomas Monjalon > ; Nélio Laranjeiro ; > Yongseok Koh ; Shahaf Shuler > > Subj

[dpdk-dev] [PATCH v3 3/3] crypto/dpaa2_sec: support pdcp offload

2018-10-05 Thread akhil . goyal
From: Akhil Goyal PDCP session configuration for lookaside protocol offload and data path is added. Signed-off-by: Hemant Agrawal Signed-off-by: Akhil Goyal --- drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c | 233 drivers/crypto/dpaa2_sec/dpaa2_sec_priv.h | 172 ++

[dpdk-dev] [PATCH v3 2/3] crypto/dpaa2_sec: add sample pdcp descriptor apis

2018-10-05 Thread akhil . goyal
From: Akhil Goyal DPAA2 SEC platform can support look aside protocol offload for PDCP protocol. The relevant APIs for configuring the hardware for PDCP is added for various modes and crypto algorithms. Signed-off-by: Hemant Agrawal Signed-off-by: Horia Geanta Neag Signed-off-by: Alex Porosanu

[dpdk-dev] [PATCH v3 1/3] security: support pdcp protocol

2018-10-05 Thread akhil . goyal
From: Akhil Goyal Packet Data Convergence Protocol (PDCP) is added in rte_security for 3GPP TS 36.323 for LTE. The patchset provide the structure definitions for configuring the PDCP sessions and relevant documentation is added. Signed-off-by: Hemant Agrawal Signed-off-by: Akhil Goyal --- do

[dpdk-dev] [PATCH v3 0/3] security: support for pdcp

2018-10-05 Thread akhil . goyal
From: Akhil Goyal Security library currently only has support for IPSec protocol. This patchset defines structures for pdcp protocol in rte_security and provide a sample driver implementation for lookaside protocol offload to support PDCP. changes in v3: removed checkpatch warnings. changes in

Re: [dpdk-dev] [PATCH v3 1/3] ring: read tail using atomic load

2018-10-05 Thread Ananyev, Konstantin
> -Original Message- > From: Ola Liljedahl [mailto:ola.liljed...@arm.com] > Sent: Friday, October 5, 2018 12:37 PM > To: Ananyev, Konstantin ; Gavin Hu (Arm > Technology China) ; Jerin Jacob > > Cc: dev@dpdk.org; Honnappa Nagarahalli ; Steve > Capper ; nd > ; sta...@dpdk.org > Subject:

[dpdk-dev] [PATCH v2 0/3] security: support for pdcp

2018-10-05 Thread akhil . goyal
From: Akhil Goyal Security library currently only has support for IPSec protocol. This patchset defines structures for pdcp protocol in rte_security and provide a sample driver implementation for lookaside protocol offload to support PDCP. changes in v2: - removed hfn override. Will be added lat

Re: [dpdk-dev] [PATCH v3 1/3] ethdev: support metadata as flow rule criteria

2018-10-05 Thread Andrew Rybchenko
On 10/5/18 4:31 PM, Ferruh Yigit wrote: On 9/27/2018 2:57 PM, Dekel Peled wrote: As described in [1], a new rte_flow item is added to support metadata to use as flow rule match pattern. The metadata is an opaque item, fully controlled by the application. The use of metadata is relevant for egre

[dpdk-dev] [PATCH v2 2/3] crypto/dpaa2_sec: add sample pdcp descriptor apis

2018-10-05 Thread akhil . goyal
From: Akhil Goyal DPAA2 SEC platform can support look aside protocol offload for PDCP protocol. The relevant APIs for configuring the hardware for PDCP is added for various modes and crypto algorithms. Signed-off-by: Hemant Agrawal Signed-off-by: Horia Geanta Neag Signed-off-by: Alex Porosanu

[dpdk-dev] [PATCH v2 3/3] crypto/dpaa2_sec: support pdcp offload

2018-10-05 Thread akhil . goyal
From: Akhil Goyal PDCP session configuration for lookaside protocol offload and data path is added. Signed-off-by: Hemant Agrawal Signed-off-by: Akhil Goyal --- drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c | 233 drivers/crypto/dpaa2_sec/dpaa2_sec_priv.h | 172 ++

[dpdk-dev] [PATCH v2 1/3] security: support pdcp protocol

2018-10-05 Thread akhil . goyal
From: Akhil Goyal Packet Data Convergence Protocol (PDCP) is added in rte_security for 3GPP TS 36.323 for LTE. The patchset provide the structure definitions for configuring the PDCP sessions and relevant documentation is added. Signed-off-by: Hemant Agrawal Signed-off-by: Akhil Goyal --- do

Re: [dpdk-dev] [PATCH v3 00/32] Adding Cavium's OCTEONTX crypto PMD

2018-10-05 Thread Joseph, Anoob
Hi Akhil, v2: * Moved common code identified for crypto devices of OCTEON TX family to common/cpt. * Divided the patches to make sure one feature gets added with one patch. * Addressed indentation issues. * Addressed comments from Jerin and Pablo. v3: * Merged v2-0001* & v2-0003* patch (Akhil)

Re: [dpdk-dev] [PATCH v3 11/19] vhost: introduce postcopy's advise message

2018-10-05 Thread Maxime Coquelin
On 10/05/2018 01:58 PM, Ilya Maximets wrote: Cleanup part is missing in this patch. We should close and clear postcopy_ufd in vhost_backend_cleanup(). Good catch, I'll spin a v4 with your suggestion. Thanks, Maxime Best regards, Ilya Maximets. On 04.10.2018 11:13, Maxime Coquelin wrote:

Re: [dpdk-dev] [PATCH 0/3] app/testpmd: add l3 encap/decap cmd

2018-10-05 Thread Ferruh Yigit
On 9/29/2018 9:07 PM, Ori Kam wrote: > Currently testpmd have support only for encapsulation and decapsulation > for L2 tunnels. > > This series adds commands for L3 tunnels types, L3 tunnel is a tunnel > that the inner packet is missing the L2 part. The encapsulation uses > the encap_l3 command i

Re: [dpdk-dev] [PATCH v3 1/3] ethdev: support metadata as flow rule criteria

2018-10-05 Thread Ferruh Yigit
On 9/27/2018 2:57 PM, Dekel Peled wrote: > As described in [1], a new rte_flow item is added to support metadata > to use as flow rule match pattern. > The metadata is an opaque item, fully controlled by the application. > > The use of metadata is relevant for egress rules only. > It can be set in

Re: [dpdk-dev] [PATCH v2 3/3] ethdev: remove vxlan and nvgre encapsulation commands

2018-10-05 Thread Awal, Mohammad Abdul
Hi Ferruh, The patch looks ok to me. No objection. Regards, Awal. > -Original Message- > From: Yigit, Ferruh > Sent: Friday, October 5, 2018 1:59 PM > To: Doherty, Declan ; Awal, Mohammad Abdul > > Cc: Ori Kam ; arybche...@solarflare.com; > step...@networkplumber.org; adrien.mazarg...@6

Re: [dpdk-dev] [PATCH v2 1/3] crypto/qat: add support AES-CMAC

2018-10-05 Thread Trahe, Fiona
Hi Mattias, Thanks for reviewing. Sorry we missed that. Will send a v3 Monday to fix. Fiona > -Original Message- > From: Mattias Rönnblom [mailto:mattias.ronnb...@ericsson.com] > Sent: Friday, October 5, 2018 1:02 PM > To: Cel, TomaszX ; dev@dpdk.org > Cc: sta...@dpdk.org; Trahe, Fiona ;

Re: [dpdk-dev] [PATCH v3 3/3] app/testpmd: add debug command Tx metadata set

2018-10-05 Thread Ferruh Yigit
On 9/27/2018 2:57 PM, Dekel Peled wrote: > As described in [1],[2] this series adds option to set metadata value as > match pattern when creating a new flow rule. > > This patch introduces code for debug porpuse only. > The new debug command takes a 32 bit value and stores it per port. > testpmd w

Re: [dpdk-dev] [PATCH v2 3/3] ethdev: remove vxlan and nvgre encapsulation commands

2018-10-05 Thread Mohammad Abdul Awal
On 26/09/2018 22:00, Ori Kam wrote: This patch removes the VXLAN and NVGRE encapsulation commands. Those commands are subset of the TUNNEL_ENCAP command so there is no need to keep both versions. Signed-off-by: Ori Kam --- doc/guides/prog_guide/rte_flow.rst | 107 -

Re: [dpdk-dev] [PATCH] ethdev: add field for device data per process

2018-10-05 Thread Ferruh Yigit
On 10/5/2018 2:17 PM, Alejandro Lucero wrote: > On Fri, Oct 5, 2018 at 2:01 PM Ferruh Yigit wrote: > >> On 10/3/2018 9:44 PM, Thomas Monjalon wrote: >>> + Cc more people >>> >>> 27/09/2018 13:26, Alejandro Lucero: Primary and secondary processes share a per-device private data. With cur

Re: [dpdk-dev] [PATCH v2 3/3] app/testpmd: add debug command Tx metadata set

2018-10-05 Thread Ferruh Yigit
On 9/16/2018 3:37 PM, Dekel Peled wrote: > As described in [1],[2] this series adds option to set metadata value as > match pattern when creating a new flow rule. > > This patch introduces code for debug porpuse only. > The new debug command takes a 32 bit value and stores it per port. > testpmd w

Re: [dpdk-dev] [PATCH] ethdev: add field for device data per process

2018-10-05 Thread Alejandro Lucero
On Fri, Oct 5, 2018 at 2:01 PM Ferruh Yigit wrote: > On 10/3/2018 9:44 PM, Thomas Monjalon wrote: > > + Cc more people > > > > 27/09/2018 13:26, Alejandro Lucero: > >> Primary and secondary processes share a per-device private data. With > >> current design it is not possible to have data per-dev

Re: [dpdk-dev] [PATCH v3 00/32] Adding Cavium's OCTEONTX crypto PMD

2018-10-05 Thread Akhil Goyal
On 10/5/2018 6:43 PM, Joseph, Anoob wrote: Hi Akhil, Do you want me to send revised cover letter patch or just summarizing it over email would do? You could do it as you prefer. Just wanted to know the changes that were done in every version that are sent. Thanks, Anoob On 05-10-2018 18:3

Re: [dpdk-dev] [PATCH v3 00/32] Adding Cavium's OCTEONTX crypto PMD

2018-10-05 Thread Joseph, Anoob
Hi Akhil, Do you want me to send revised cover letter patch or just summarizing it over email would do? Thanks, Anoob On 05-10-2018 18:34, Akhil Goyal wrote: External Email Hi Anoob, Could you please add the change log in the cover note. Thanks, Akhil On 10/5/2018 6:28 PM, Anoob Joseph wr

Re: [dpdk-dev] [PATCH v3 00/32] Adding Cavium's OCTEONTX crypto PMD

2018-10-05 Thread Akhil Goyal
Hi Anoob, Could you please add the change log in the cover note. Thanks, Akhil On 10/5/2018 6:28 PM, Anoob Joseph wrote: Ankur Dwivedi (5): common/cpt: add common logging support config: add Cavium OCTEONTX crypto PMD skeleton crypto/octeontx: add register addresses common/cpt: add

[dpdk-dev] [PATCH v3 32/32] doc: adds doc file

2018-10-05 Thread Anoob Joseph
This patch adds the features file and the document containing help to compile and use octeontx crypto. Signed-off-by: Ankur Dwivedi Signed-off-by: Anoob Joseph Signed-off-by: Murthy NSSR Signed-off-by: Nithin Dabilpuram Signed-off-by: Ragothaman Jayaraman Signed-off-by: Srisivasubramanian S

[dpdk-dev] [PATCH v3 31/32] test: adds validation test

2018-10-05 Thread Anoob Joseph
From: Ankur Dwivedi This patch adds validation tests for octeontx crypto device. Signed-off-by: Ankur Dwivedi Signed-off-by: Anoob Joseph Signed-off-by: Murthy NSSR Signed-off-by: Nithin Dabilpuram Signed-off-by: Ragothaman Jayaraman Signed-off-by: Srisivasubramanian S Signed-off-by: Tejas

[dpdk-dev] [PATCH v3 30/32] crypto/octeontx: add dequeue burst op

2018-10-05 Thread Anoob Joseph
From: Tejasree Kondoj Signed-off-by: Ankur Dwivedi Signed-off-by: Anoob Joseph Signed-off-by: Murthy NSSR Signed-off-by: Nithin Dabilpuram Signed-off-by: Ragothaman Jayaraman Signed-off-by: Srisivasubramanian S Signed-off-by: Tejasree Kondoj --- drivers/crypto/octeontx/otx_cryptodev_hw_ac

[dpdk-dev] [PATCH v3 29/32] common/cpt: add common code for cpt dequeue

2018-10-05 Thread Anoob Joseph
From: Tejasree Kondoj Signed-off-by: Ankur Dwivedi Signed-off-by: Anoob Joseph Signed-off-by: Murthy NSSR Signed-off-by: Nithin Dabilpuram Signed-off-by: Ragothaman Jayaraman Signed-off-by: Srisivasubramanian S Signed-off-by: Tejasree Kondoj --- drivers/common/cpt/cpt_common.h| 2

[dpdk-dev] [PATCH v3 28/32] crypto/octeontx: add enqueue burst op

2018-10-05 Thread Anoob Joseph
From: Tejasree Kondoj Signed-off-by: Ankur Dwivedi Signed-off-by: Anoob Joseph Signed-off-by: Murthy NSSR Signed-off-by: Nithin Dabilpuram Signed-off-by: Ragothaman Jayaraman Signed-off-by: Srisivasubramanian S Signed-off-by: Tejasree Kondoj --- drivers/crypto/octeontx/otx_cryptodev_hw_ac

[dpdk-dev] [PATCH v3 27/32] common/cpt: add common code for enqueuing cpt instruction

2018-10-05 Thread Anoob Joseph
From: Tejasree Kondoj Signed-off-by: Ankur Dwivedi Signed-off-by: Anoob Joseph Signed-off-by: Murthy NSSR Signed-off-by: Nithin Dabilpuram Signed-off-by: Ragothaman Jayaraman Signed-off-by: Srisivasubramanian S Signed-off-by: Tejasree Kondoj --- drivers/common/cpt/cpt_common.h | 3 +

[dpdk-dev] [PATCH v3 26/32] crypto/octeontx: add routines to prepare instructions

2018-10-05 Thread Anoob Joseph
From: Srisivasubramanian S Adding hardware specific routines which prepare cpt instructions. Signed-off-by: Ankur Dwivedi Signed-off-by: Anoob Joseph Signed-off-by: Murthy NSSR Signed-off-by: Nithin Dabilpuram Signed-off-by: Ragothaman Jayaraman Signed-off-by: Srisivasubramanian S Signed-o

[dpdk-dev] [PATCH v3 25/32] common/cpt: add support for hash

2018-10-05 Thread Anoob Joseph
From: Srisivasubramanian S Adding microcode interface for supporting verify and authentication Signed-off-by: Ankur Dwivedi Signed-off-by: Anoob Joseph Signed-off-by: Murthy NSSR Signed-off-by: Nithin Dabilpuram Signed-off-by: Ragothaman Jayaraman Signed-off-by: Srisivasubramanian S Signed

[dpdk-dev] [PATCH v3 24/32] common/cpt: add support for kasumi

2018-10-05 Thread Anoob Joseph
From: Srisivasubramanian S Adding microcode interface for supporting kasumi. Signed-off-by: Ankur Dwivedi Signed-off-by: Anoob Joseph Signed-off-by: Murthy NSSR Signed-off-by: Nithin Dabilpuram Signed-off-by: Ragothaman Jayaraman Signed-off-by: Srisivasubramanian S Signed-off-by: Tejasree

[dpdk-dev] [PATCH v3 22/32] common/cpt: add crypo op enqueue request manager framework

2018-10-05 Thread Anoob Joseph
From: Ragothaman Jayaraman Adding crypto enqueue op request manager framework. This routine won't submit to the hardware yet. Signed-off-by: Ankur Dwivedi Signed-off-by: Anoob Joseph Signed-off-by: Murthy NSSR Signed-off-by: Nithin Dabilpuram Signed-off-by: Ragothaman Jayaraman Signed-off-b

[dpdk-dev] [PATCH v3 23/32] common/cpt: add support for zuc and snow3g

2018-10-05 Thread Anoob Joseph
From: Srisivasubramanian S Adding microcode interface for supporting ZUC and SNOW3G. Signed-off-by: Ankur Dwivedi Signed-off-by: Anoob Joseph Signed-off-by: Murthy NSSR Signed-off-by: Nithin Dabilpuram Signed-off-by: Ragothaman Jayaraman Signed-off-by: Srisivasubramanian S Signed-off-by: T

[dpdk-dev] [PATCH v3 21/32] common/cpt: add microcode interface for decryption

2018-10-05 Thread Anoob Joseph
From: Ragothaman Jayaraman Adding microcode interface additions for supporting decryption. Signed-off-by: Ankur Dwivedi Signed-off-by: Anoob Joseph Signed-off-by: Murthy NSSR Signed-off-by: Nithin Dabilpuram Signed-off-by: Ragothaman Jayaraman Signed-off-by: Srisivasubramanian S Signed-off

[dpdk-dev] [PATCH v3 19/32] common/cpt: add common defines for microcode

2018-10-05 Thread Anoob Joseph
From: Ragothaman Jayaraman Signed-off-by: Ankur Dwivedi Signed-off-by: Anoob Joseph Signed-off-by: Murthy NSSR Signed-off-by: Nithin Dabilpuram Signed-off-by: Ragothaman Jayaraman Signed-off-by: Srisivasubramanian S Signed-off-by: Tejasree Kondoj --- drivers/common/cpt/cpt_mcode_defines.h

[dpdk-dev] [PATCH v3 20/32] common/cpt: add microcode interface for encryption

2018-10-05 Thread Anoob Joseph
From: Ragothaman Jayaraman Adding microcode interface additions for supporting encryption. Signed-off-by: Ankur Dwivedi Signed-off-by: Anoob Joseph Signed-off-by: Murthy NSSR Signed-off-by: Nithin Dabilpuram Signed-off-by: Ragothaman Jayaraman Signed-off-by: Srisivasubramanian S Signed-off

[dpdk-dev] [PATCH v3 18/32] crypto/octeontx: add supported sessions

2018-10-05 Thread Anoob Joseph
From: Nithin Dabilpuram Adding AEAD, cipher & auth sessions support. Signed-off-by: Ankur Dwivedi Signed-off-by: Anoob Joseph Signed-off-by: Murthy NSSR Signed-off-by: Nithin Dabilpuram Signed-off-by: Ragothaman Jayaraman Signed-off-by: Srisivasubramanian S Signed-off-by: Tejasree Kondoj

Re: [dpdk-dev] [PATCH] ethdev: add field for device data per process

2018-10-05 Thread Ferruh Yigit
On 10/3/2018 9:44 PM, Thomas Monjalon wrote: > + Cc more people > > 27/09/2018 13:26, Alejandro Lucero: >> Primary and secondary processes share a per-device private data. With >> current design it is not possible to have data per-device per-process. >> This is required for handling properly the C

[dpdk-dev] [PATCH v3 17/32] common/cpt: add common code for fill session data

2018-10-05 Thread Anoob Joseph
From: Nithin Dabilpuram Adding common code required for filling session data for AEAD, cipher & auth sessions. Signed-off-by: Ankur Dwivedi Signed-off-by: Anoob Joseph Signed-off-by: Murthy NSSR Signed-off-by: Nithin Dabilpuram Signed-off-by: Ragothaman Jayaraman Signed-off-by: Srisivasubra

[dpdk-dev] [PATCH v3 16/32] crypto/octeontx: add session management ops

2018-10-05 Thread Anoob Joseph
From: Nithin Dabilpuram Adding routines for session configure, session clear and get session size ops. Signed-off-by: Ankur Dwivedi Signed-off-by: Anoob Joseph Signed-off-by: Murthy NSSR Signed-off-by: Nithin Dabilpuram Signed-off-by: Ragothaman Jayaraman Signed-off-by: Srisivasubramanian S

[dpdk-dev] [PATCH v3 15/32] common/cpt: add common code required for session management

2018-10-05 Thread Anoob Joseph
From: Nithin Dabilpuram Adding common code required for session configure, session clear and get session size ops routines Signed-off-by: Ankur Dwivedi Signed-off-by: Anoob Joseph Signed-off-by: Murthy NSSR Signed-off-by: Nithin Dabilpuram Signed-off-by: Ragothaman Jayaraman Signed-off-by:

[dpdk-dev] [PATCH v3 13/32] common/cpt: add common macros for queue pair ops

2018-10-05 Thread Anoob Joseph
From: Murthy NSSR Adding common macros required by queue pair op functions. Signed-off-by: Ankur Dwivedi Signed-off-by: Anoob Joseph Signed-off-by: Murthy NSSR Signed-off-by: Nithin Dabilpuram Signed-off-by: Ragothaman Jayaraman Signed-off-by: Srisivasubramanian S Signed-off-by: Tejasree K

[dpdk-dev] [PATCH v3 14/32] crypto/octeontx: add queue pair functions

2018-10-05 Thread Anoob Joseph
From: Nithin Dabilpuram Adding queue pair setup and release functions Signed-off-by: Ankur Dwivedi Signed-off-by: Anoob Joseph Signed-off-by: Murthy NSSR Signed-off-by: Nithin Dabilpuram Signed-off-by: Ragothaman Jayaraman Signed-off-by: Srisivasubramanian S Signed-off-by: Tejasree Kondoj

[dpdk-dev] [PATCH v3 12/32] crypto/octeontx: add basic dev ops

2018-10-05 Thread Anoob Joseph
From: Murthy NSSR Adding the following dev ops, - dev_configure - dev_start - dev_stop - dev_close - dev_infos_get - stats_get - stats_reset Signed-off-by: Ankur Dwivedi Signed-off-by: Anoob Joseph Signed-off-by: Murthy NSSR Signed-off-by: Nithin Dabilpuram Signed-off-by: Ragothaman Jayarama

[dpdk-dev] [PATCH v3 11/32] crypto/octeontx: add mailbox routines

2018-10-05 Thread Anoob Joseph
From: Murthy NSSR Adding mailbox routines to interact with the pf driver Signed-off-by: Ankur Dwivedi Signed-off-by: Anoob Joseph Signed-off-by: Murthy NSSR Signed-off-by: Nithin Dabilpuram Signed-off-by: Ragothaman Jayaraman Signed-off-by: Srisivasubramanian S Signed-off-by: Tejasree Kond

[dpdk-dev] [PATCH v3 10/32] crypto/octeontx: add global resource init

2018-10-05 Thread Anoob Joseph
From: Murthy NSSR Adding initialization of global resources. This will be saved as metadata in cptvf and would be used by common code. Exit path for failure case is also added along with the new routines. Signed-off-by: Ankur Dwivedi Signed-off-by: Anoob Joseph Signed-off-by: Murthy NSSR Sign

[dpdk-dev] [PATCH v3 08/32] crypto/octeontx: adds symmetric capabilities

2018-10-05 Thread Anoob Joseph
This patch adds the symmetric algorithms capabilities supported by octeontx crypto hardware. Signed-off-by: Ankur Dwivedi Signed-off-by: Anoob Joseph Signed-off-by: Murthy NSSR Signed-off-by: Nithin Dabilpuram Signed-off-by: Ragothaman Jayaraman Signed-off-by: Srisivasubramanian S Signed-off

[dpdk-dev] [PATCH v3 09/32] common/cpt: add PMD ops helper functions

2018-10-05 Thread Anoob Joseph
From: Murthy NSSR Adding pmd ops helper functions. Control path accessed APIs would be added as helper functions. Adding microcode defined macros etc as dependencies to the helper functions. Signed-off-by: Ankur Dwivedi Signed-off-by: Anoob Joseph Signed-off-by: Murthy NSSR Signed-off-by: Nit

[dpdk-dev] [PATCH v3 05/32] crypto/octeontx: add hardware init routine

2018-10-05 Thread Anoob Joseph
Adding hardware init routine for OCTEON TX crypto device. A place holder is added for misc polling routine. That will be added in the further patches. Signed-off-by: Ankur Dwivedi Signed-off-by: Anoob Joseph Signed-off-by: Murthy NSSR Signed-off-by: Nithin Dabilpuram Signed-off-by: Ragothaman

  1   2   >