[dpdk-dev] [PATCH] net/tap: fix reported number of Tx packets

2018-10-10 Thread Raslan Darawsheh
When writev fails to send packets it doesn't update the number of Tx packets, but it still num_tx is updated. the value that should be returned is the actual number of sent packets which is num_packets. Fixes: 02f96a0a ("net/tap: add TUN/TAP device PMD") CC: sta...@dpdk.org Signed-off-by: Raslan

[dpdk-dev] [PATCH v5 2/3] net/tap: move fds of Rx/Tx queues to be in process private

2018-10-10 Thread Raslan Darawsheh
fd's cannot be shared between processes, and each process need to have it's own fd's pointer. Signed-off-by: Raslan Darawsheh --- drivers/net/tap/rte_eth_tap.c | 93 +-- drivers/net/tap/rte_eth_tap.h | 7 +++- drivers/net/tap/tap_flow.c| 3 +- driver

[dpdk-dev] [PATCH v5 1/3] net/tap: add queue and port ids in Rx/Tx queues structures

2018-10-10 Thread Raslan Darawsheh
Signed-off-by: Raslan Darawsheh --- drivers/net/tap/rte_eth_tap.c | 3 +++ drivers/net/tap/rte_eth_tap.h | 3 +++ 2 files changed, 6 insertions(+) diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/rte_eth_tap.c index ad5ae98..edfb7da 100644 --- a/drivers/net/tap/rte_eth_tap.c +++ b/dr

[dpdk-dev] [PATCH v5 3/3] net/tap: add queues when attaching from secondary process

2018-10-10 Thread Raslan Darawsheh
In the case the device is created by the primary process, the secondary must request some file descriptors to attach the queues. The file descriptors are shared via IPC Unix socket. Thanks to the IPC synchronization, the secondary process is now able to do Rx/Tx on a TAP created by the primary pro

Re: [dpdk-dev] [PATCH] net/e1000: enable MSI-x for linkup and other events in 82574

2018-10-10 Thread Zhao1, Wei
Acked-by: Wei Zhao > -Original Message- > From: Luca Boccassi [mailto:bl...@debian.org] > Sent: Tuesday, October 9, 2018 6:33 PM > To: Zhao1, Wei ; dev@dpdk.org > Cc: Lu, Wenzhuo ; Zhang, Qi Z > > Subject: Re: [dpdk-dev] [PATCH] net/e1000: enable MSI-x for linkup and > other events in 8

Re: [dpdk-dev] [PATCH] net/e1000: do not error out if rx_drop_en is set

2018-10-10 Thread Zhao1, Wei
Acked-by: Wei Zhao > -Original Message- > From: Luca Boccassi [mailto:bl...@debian.org] > Sent: Monday, October 8, 2018 10:14 PM > To: Zhao1, Wei ; dev@dpdk.org > Cc: Lu, Wenzhuo ; sta...@dpdk.org; Zhang, Qi Z > ; 3ch...@gmail.com > Subject: Re: [dpdk-dev] [PATCH] net/e1000: do not error

Re: [dpdk-dev] [PATCH v5 01/19] vhost: fix messages results handling

2018-10-10 Thread Maxime Coquelin
Hi Ilya On 10/09/2018 10:54 PM, Maxime Coquelin wrote: Return of message handling has now changed to an enum that can take non-negative value that is not zero in case a reply is needed. But the code checking the variable afterwards has not been updated, leading to success messages handling being

Re: [dpdk-dev] [PATCH v7 5/8] net/virtio: implement transmit path for packed queues

2018-10-10 Thread Maxime Coquelin
On 10/03/2018 03:11 PM, Jens Freimann wrote: This implements the transmit path for devices with support for packed virtqueues. Signed-off-by: Jens Freiman --- drivers/net/virtio/virtio_ethdev.c | 32 ++-- drivers/net/virtio/virtio_ethdev.h | 2 + drivers/net/virtio/virtio_ring.h |

Re: [dpdk-dev] [PATCH v3 1/4] net/mlx5: add flow action functions to glue

2018-10-10 Thread Dekel Peled
Thanks, PSB. Note I'm replying here to comments from both emails you sent. > -Original Message- > From: Yongseok Koh > Sent: Wednesday, October 10, 2018 3:36 AM > To: Dekel Peled > Cc: Shahaf Shuler ; dev@dpdk.org; Ori Kam > > Subject: Re: [PATCH v3 1/4] net/mlx5: add flow action functio

Re: [dpdk-dev] [PATCH v2] ethdev: complete closing of port

2018-10-10 Thread Thomas Monjalon
10/10/2018 08:15, Andrew Rybchenko: > On 10/10/18 1:17 AM, Thomas Monjalon wrote: > > After closing a port, it cannot be restarted. > > So there is no reason to not free all associated resources. > > > > The last step was done with rte_eth_dev_detach() which is deprecated. > > Instead of blindly re

Re: [dpdk-dev] [PATCH v2] ethdev: complete closing of port

2018-10-10 Thread Andrew Rybchenko
On 10/10/18 10:44 AM, Thomas Monjalon wrote: 10/10/2018 08:15, Andrew Rybchenko: On 10/10/18 1:17 AM, Thomas Monjalon wrote: After closing a port, it cannot be restarted. So there is no reason to not free all associated resources. The last step was done with rte_eth_dev_detach() which is depre

[dpdk-dev] [RFC PATCH 2/3] ethdev: advertise default MAC as retained on device restart

2018-10-10 Thread Andrew Rybchenko
The documentation says MAC addresses array is retained and it is logical to assume that default MAC address is retained as well. Also some PMDs do not allow to change the default MAC in running state (see RTE_ETH_DEV_NOLIVE_MAC_ADDR). Signed-off-by: Andrew Rybchenko --- lib/librte_ethdev/rte_et

[dpdk-dev] [RFC PATCH 3/3] ethdev: highlight that all-multicast is retained on restart

2018-10-10 Thread Andrew Rybchenko
All-multicast is a part of receive mode configuration and it is better to mention explicitly that it is retained across restart. Signed-off-by: Andrew Rybchenko --- lib/librte_ethdev/rte_ethdev.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/librte_ethdev/rte_ethdev

[dpdk-dev] [RFC PATCH 1/3] ethdev: advertise MTU as retained across device stop/start

2018-10-10 Thread Andrew Rybchenko
Changing MTU in running state may return -EBUSY saying that MTU cannot be changed when the port is running. It assumes that changes may be done in stopped and started (but some PMDs may reject it) state and it is logical to require that changes done in any of these states are retained. Signed-off-

[dpdk-dev] [RFC PATCH 0/3] ethdev: document more retained across restart

2018-10-10 Thread Andrew Rybchenko
The patch series tries to improve documentation of what is retained across default restart. Should it collect acks from all PMD maintainers to be applied? Andrew Rybchenko (3): ethdev: advertise MTU as retained across device stop/start ethdev: advertise default MAC as retained on device resta

[dpdk-dev] [PATCH v4 1/4] net/mlx5: add flow action functions to glue

2018-10-10 Thread Dekel Peled
This patch adds glue functions for operations: - Create packet reformat (encap/decap) flow action. - Destroy flow action. The new operations depend on HAVE_IBV_FLOW_ACTION_DV_SUPPORT. Signed-off-by: Dekel Peled --- drivers/net/mlx5/Makefile| 5 + drivers/net/mlx5/meson.build | 2 ++ d

[dpdk-dev] [PATCH v4 2/4] net/mlx5: add Direct Verbs encap and decap defs

2018-10-10 Thread Dekel Peled
This patch adds the required definitions for DV encap/decap actions. It also adds usage of the new actions definition in validation function of existing drop operation. Signed-off-by: Dekel Peled Acked-by: Yongseok Koh --- drivers/net/mlx5/mlx5_flow.c | 8 drivers/net/mlx5/mlx5_flow.h

[dpdk-dev] [PATCH v4 0/4] add support of Direct Verbs encap and decap actions

2018-10-10 Thread Dekel Peled
This series adds support of encap and decap actions in DV format. It is using the generic encapsulation framework from [1]. Note that encap action is relevant for egress only. Hence this series should be merged on top of [2]. [1] "ethdev: add generic L2/L3 tunnel encapsulation actions" http://

[dpdk-dev] [PATCH v4 3/4] net/mlx5: add L2 and L3 encap to Direct Verbs flow

2018-10-10 Thread Dekel Peled
This patch adds support for Direct Verbs encap operations, L2 and L3. Signed-off-by: Dekel Peled Acked-by: Yongseok Koh --- drivers/net/mlx5/mlx5_flow_dv.c | 227 +++- 1 file changed, 222 insertions(+), 5 deletions(-) diff --git a/drivers/net/mlx5/mlx5_flow_

[dpdk-dev] [PATCH v4 4/4] net/mlx5: add L2 and L3 decap to Direct Verbs flow

2018-10-10 Thread Dekel Peled
This patch adds support for Direct Verbs decap operations, L2 and L3. Signed-off-by: Dekel Peled Acked-by: Yongseok Koh --- drivers/net/mlx5/mlx5_flow_dv.c | 215 1 file changed, 215 insertions(+) diff --git a/drivers/net/mlx5/mlx5_flow_dv.c b/drivers/n

Re: [dpdk-dev] [PATCH] app/testpmd: fix flow list command

2018-10-10 Thread Adrien Mazarguil
Hi John On Tue, Oct 09, 2018 at 03:51:24PM -0700, John Daley wrote: > This patch fixes the 'flow list ' command which caused a > segfault when passing the action or item 'type' field instead > of the action or item struct pointer in the call to rte_flow_conv. > > Fixes: 7d94dcedf7ce ("app/testpmd

Re: [dpdk-dev] [PATCH v2] ethdev: complete closing of port

2018-10-10 Thread Thomas Monjalon
10/10/2018 09:50, Andrew Rybchenko: > On 10/10/18 10:44 AM, Thomas Monjalon wrote: > > 10/10/2018 08:15, Andrew Rybchenko: > >> On 10/10/18 1:17 AM, Thomas Monjalon wrote: > >>> After closing a port, it cannot be restarted. > >>> So there is no reason to not free all associated resources. > >>> > >

Re: [dpdk-dev] Correct use of Arm related names

2018-10-10 Thread Thomas Monjalon
10/10/2018 06:37, Honnappa Nagarahalli: > Hi, > This email was triggered by a request to change ARM to Arm in the dpdk.org > webpage. I went down the path of finding out the correct names to use. There > has not been consistency in using these names across all other projects. So, > the recommend

Re: [dpdk-dev] [RFC PATCH 2/3] ethdev: advertise default MAC as retained on device restart

2018-10-10 Thread Thomas Monjalon
10/10/2018 09:51, Andrew Rybchenko: > The documentation says MAC addresses array is retained and > it is logical to assume that default MAC address is retained > as well. I'm confused. Default MAC address isn't implied by MAC addresses array?

Re: [dpdk-dev] [PATCH v3 1/6] mem: add function for checking memsegs IOVAs addresses

2018-10-10 Thread Tu, Lijuan
Hi > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Alejandro Lucero > Sent: Friday, October 5, 2018 8:45 PM > To: dev@dpdk.org > Subject: [dpdk-dev] [PATCH v3 1/6] mem: add function for checking > memsegs IOVAs addresses > > A device can suffer addressing limi

Re: [dpdk-dev] [PATCH v3 0/3] ethdev: add generic L2/L3 tunnel encapsulation actions

2018-10-10 Thread Ori Kam
> -Original Message- > From: Andrew Rybchenko > Sent: Wednesday, October 10, 2018 9:45 AM > To: Ferruh Yigit ; Ori Kam ; > step...@networkplumber.org; Adrien Mazarguil > ; Declan Doherty > Cc: dev@dpdk.org; Dekel Peled ; Thomas Monjalon > ; Nélio Laranjeiro ; > Yongseok Koh ; Shahaf Shu

Re: [dpdk-dev] [RFC PATCH 2/3] ethdev: advertise default MAC as retained on device restart

2018-10-10 Thread Andrew Rybchenko
On 10/10/18 11:53 AM, Thomas Monjalon wrote: 10/10/2018 09:51, Andrew Rybchenko: The documentation says MAC addresses array is retained and it is logical to assume that default MAC address is retained as well. I'm confused. Default MAC address isn't implied by MAC addresses array? From API po

Re: [dpdk-dev] [PATCH v3 0/3] ethdev: add generic L2/L3 tunnel encapsulation actions

2018-10-10 Thread Andrew Rybchenko
On 10/10/18 12:00 PM, Ori Kam wrote: -Original Message- From: Andrew Rybchenko Sent: Wednesday, October 10, 2018 9:45 AM To: Ferruh Yigit ; Ori Kam ; step...@networkplumber.org; Adrien Mazarguil ; Declan Doherty Cc: dev@dpdk.org; Dekel Peled ; Thomas Monjalon ; Nélio Laranjeiro ; Yongse

Re: [dpdk-dev] [RFC PATCH 2/3] ethdev: advertise default MAC as retained on device restart

2018-10-10 Thread Thomas Monjalon
10/10/2018 11:05, Andrew Rybchenko: > On 10/10/18 11:53 AM, Thomas Monjalon wrote: > > 10/10/2018 09:51, Andrew Rybchenko: > >> The documentation says MAC addresses array is retained and > >> it is logical to assume that default MAC address is retained > >> as well. > > I'm confused. Default MAC ad

Re: [dpdk-dev] [PATCH v3 0/3] ethdev: add generic L2/L3 tunnel encapsulation actions

2018-10-10 Thread Thomas Monjalon
10/10/2018 11:30, Andrew Rybchenko: > It is really bad practice that features are accepted without at least > one implementation/usage. Yes. In future, we should take care of not accepting new API without at least one implementation.

[dpdk-dev] [PATCH] doc: note min required kernel version increase for 19.02

2018-10-10 Thread Kevin Traynor
Updating docs to reflect decision made at the techboard that the min kernel version should be bumped from 3.2 to the latest longterm stable release (3.16), but that compatiblity for commonly used distribution kernels should be kept also. Signed-off-by: Kevin Traynor --- I namechecked RHEL/CentOS

Re: [dpdk-dev] [PATCH v2 0/3] crypto/aesni_mb: add aes-gcm support

2018-10-10 Thread Kusztal, ArkadiuszX
> -Original Message- > From: Zhang, Roy Fan > Sent: Tuesday, October 9, 2018 10:11 PM > To: dev@dpdk.org > Cc: akhil.go...@nxp.com; Kusztal, ArkadiuszX > > Subject: [PATCH v2 0/3] crypto/aesni_mb: add aes-gcm support > > This patchset adds the AES-GCM algorithm support to AESNI-MB Cryp

Re: [dpdk-dev] [PATCH v3 2/4] kni: fix kni fifo synchronization

2018-10-10 Thread Phil Yang (Arm Technology China)
Hi Hemminger, > -Original Message- > From: Stephen Hemminger > Sent: Tuesday, October 9, 2018 5:53 AM > To: Phil Yang (Arm Technology China) > Cc: dev@dpdk.org; jerin.ja...@caviumnetworks.com; Gavin Hu (Arm > Technology China) ; Honnappa Nagarahalli > ; Ola Liljedahl ; > ferruh.yi...@int

Re: [dpdk-dev] [PATCH v3 2/4] kni: fix kni fifo synchronization

2018-10-10 Thread Gavin Hu (Arm Technology China)
> -Original Message- > From: Phil Yang (Arm Technology China) > Sent: Wednesday, October 10, 2018 5:59 PM > To: Stephen Hemminger > Cc: dev@dpdk.org; jerin.ja...@caviumnetworks.com; Gavin Hu (Arm > Technology China) ; Honnappa Nagarahalli > ; Ola Liljedahl ; > ferruh.yi...@intel.com > S

Re: [dpdk-dev] [dpdk-techboard] [PATCH] doc: note min required kernel version increase for 19.02

2018-10-10 Thread Maxime Coquelin
On 10/10/2018 11:40 AM, Kevin Traynor wrote: Updating docs to reflect decision made at the techboard that the min kernel version should be bumped from 3.2 to the latest longterm stable release (3.16), but that compatiblity for commonly used distribution kernels should be kept also. Signed-off

Re: [dpdk-dev] [PATCH v5 07/19] vhost: add number of fds to vhost-user messages and use it

2018-10-10 Thread Tiwei Bie
On Tue, Oct 09, 2018 at 10:54:14PM +0200, Maxime Coquelin wrote: > As soons as some anciliarry datai (fds) are received, it is copied typo: soons anciliarry datai > without checking its length. > > This patch adds adds the number of fds received to the message, s/adds adds/adds/ > which is set

Re: [dpdk-dev] [PATCH v5 15/19] vhost: send userfault range addresses back to qemu

2018-10-10 Thread Tiwei Bie
On Tue, Oct 09, 2018 at 10:54:22PM +0200, Maxime Coquelin wrote: > Signed-off-by: Dr. David Alan Gilbert > Signed-off-by: Maxime Coquelin > --- > lib/librte_vhost/vhost_user.c | 49 --- > 1 file changed, 46 insertions(+), 3 deletions(-) > > diff --git a/lib/librt

Re: [dpdk-dev] [PATCH v5 17/19] vhost: restrict postcopy live-migration enablement

2018-10-10 Thread Tiwei Bie
On Tue, Oct 09, 2018 at 10:54:24PM +0200, Maxime Coquelin wrote: > Postcopy live-migration feature requires the application to > not populate the guest memory. As the vhost library cannot > prevent the application to that (e.g. preventing the > application to call mlockall()), the feature is disabl

Re: [dpdk-dev] [PATCH v5 09/19] vhost: enable fds passing when sending vhost-user messages

2018-10-10 Thread Tiwei Bie
On Tue, Oct 09, 2018 at 10:54:16PM +0200, Maxime Coquelin wrote: > Passing userfault fds to Qemu will be required for postcopy > live-migration feature. > > Signed-off-by: Dr. David Alan Gilbert > Signed-off-by: Maxime Coquelin > --- > lib/librte_vhost/vhost_user.c | 27 +++-

Re: [dpdk-dev] [PATCH v5 17/19] vhost: restrict postcopy live-migration enablement

2018-10-10 Thread Maxime Coquelin
On 10/10/2018 12:17 PM, Tiwei Bie wrote: On Tue, Oct 09, 2018 at 10:54:24PM +0200, Maxime Coquelin wrote: Postcopy live-migration feature requires the application to not populate the guest memory. As the vhost library cannot prevent the application to that (e.g. preventing the application to

Re: [dpdk-dev] [PATCH v4 02/22] net/atlantic: logging macroes and some typedefs

2018-10-10 Thread Ferruh Yigit
On 10/9/2018 10:31 AM, Igor Russkikh wrote: > Signed-off-by: Igor Russkikh > Signed-off-by: Pavel Belous <...> > @@ -168,3 +171,16 @@ atl_dev_info_get(struct rte_eth_dev *dev, struct > rte_eth_dev_info *dev_info) > RTE_PMD_REGISTER_PCI(net_atlantic, rte_atl_pmd); > RTE_PMD_REGISTER_PCI_TABLE

Re: [dpdk-dev] [PATCH v5 15/19] vhost: send userfault range addresses back to qemu

2018-10-10 Thread Maxime Coquelin
On 10/10/2018 12:13 PM, Tiwei Bie wrote: On Tue, Oct 09, 2018 at 10:54:22PM +0200, Maxime Coquelin wrote: Signed-off-by: Dr. David Alan Gilbert Signed-off-by: Maxime Coquelin --- lib/librte_vhost/vhost_user.c | 49 --- 1 file changed, 46 insertions(+), 3 d

Re: [dpdk-dev] [PATCH v4 07/22] net/atlantic: rte device start, stop, initial configuration

2018-10-10 Thread Ferruh Yigit
On 10/9/2018 10:31 AM, Igor Russkikh wrote: > From: Pavel Belous > > Start, stop and reset are all done via hw_atl layer. > Link interrupt configuration is also done here. > > Signed-off-by: Igor Russkikh > Signed-off-by: Pavel Belous > Signed-off-by: Pavel Belous <...> > +static void > +atl

Re: [dpdk-dev] [PATCH v5 09/19] vhost: enable fds passing when sending vhost-user messages

2018-10-10 Thread Maxime Coquelin
On 10/10/2018 12:09 PM, Tiwei Bie wrote: On Tue, Oct 09, 2018 at 10:54:16PM +0200, Maxime Coquelin wrote: Passing userfault fds to Qemu will be required for postcopy live-migration feature. Signed-off-by: Dr. David Alan Gilbert Signed-off-by: Maxime Coquelin --- lib/librte_vhost/vhost_us

Re: [dpdk-dev] [PATCH v4 11/22] net/atlantic: link status and interrupt management

2018-10-10 Thread Ferruh Yigit
On 10/9/2018 10:31 AM, Igor Russkikh wrote: > From: Pavel Belous > > Implement link interrupt, link info, link polling. > > Signed-off-by: Igor Russkikh > Signed-off-by: Pavel Belous <...> > +/** > + * Atomically reads the link status information from global > + * structure rte_eth_dev. > +

Re: [dpdk-dev] [PATCH v4 12/22] net/atlantic: device statistics, xstats

2018-10-10 Thread Ferruh Yigit
On 10/9/2018 10:31 AM, Igor Russkikh wrote: > From: Pavel Belous > > Signed-off-by: Igor Russkikh > Signed-off-by: Pavel Belous <...> > +static void > +atl_dev_stats_reset(struct rte_eth_dev *dev) > +{ > + struct aq_hw_s *hw = ATL_DEV_PRIVATE_TO_HW(dev->data->dev_private); > + > + hw-

Re: [dpdk-dev] [PATCH v4 17/22] net/atlantic: MAC address manipulations

2018-10-10 Thread Ferruh Yigit
On 10/9/2018 10:31 AM, Igor Russkikh wrote: > From: Pavel Belous > > Signed-off-by: Igor Russkikh > Signed-off-by: Pavel Belous > --- > drivers/net/atlantic/atl_ethdev.c | 126 > ++ > 1 file changed, 126 insertions(+) > > diff --git a/drivers/net/atlantic/

Re: [dpdk-dev] [PATCH v4 09/22] net/atlantic: RX side structures and implementation

2018-10-10 Thread Ferruh Yigit
On 10/9/2018 10:31 AM, Igor Russkikh wrote: > Signed-off-by: Igor Russkikh > Signed-off-by: Pavel Belous <...> > +int > +atl_start_queues(struct rte_eth_dev *dev) > { > + int i; > + > + PMD_INIT_FUNC_TRACE(); > + > + for (i = 0; i < dev->data->nb_rx_queues; i++) { > + i

Re: [dpdk-dev] [PATCH v4 22/22] net/atlantic: documentation and rel notes

2018-10-10 Thread Ferruh Yigit
On 10/9/2018 10:32 AM, Igor Russkikh wrote: > Signed-off-by: Igor Russkikh > Signed-off-by: Pavel Belous <...> > @@ -0,0 +1,53 @@ > +.. SPDX-License-Identifier: BSD-3-Clause > +Copyright(c) 2018 Aquantia Corporation. > + > +Aquantia Atlantic DPDK Driver > += > +

Re: [dpdk-dev] [PATCH v4 01/22] net/atlantic: atlantic PMD driver skeleton

2018-10-10 Thread Ferruh Yigit
On 10/9/2018 10:31 AM, Igor Russkikh wrote: > From: Pavel Belous > > Makefile/meson build infrastructure, atl_ethdev minimal skeleton, > header with aquantia aQtion NIC device and vendor IDs. > > Signed-off-by: Igor Russkikh > Signed-off-by: Pavel Belous > --- > config/common_base

Re: [dpdk-dev] [PATCH v4 04/22] net/atlantic: hw_atl register declarations

2018-10-10 Thread Ferruh Yigit
On 10/9/2018 10:31 AM, Igor Russkikh wrote: > This hw_atl layer is maintained in sync with linux kernel driver. > It will generally be in sync with linux upstream. > > Signed-off-by: Igor Russkikh > Signed-off-by: Pavel Belous <...> > +/* set uP Force Interrupt */ > +void mcp_up_force_intr_set

Re: [dpdk-dev] [PATCH v4 20/22] net/atlantic: LED control DPDK and private APIs

2018-10-10 Thread Ferruh Yigit
On 10/9/2018 10:32 AM, Igor Russkikh wrote: > Signed-off-by: Igor Russkikh > Signed-off-by: Pavel Belous <...> > +/** > + * This is a custom API for adapter's LED controls. > + * > + * @param dev > + * Ethernet device to apply control to > + * @param control > + * 6 bit value (3 leds each 2

Re: [dpdk-dev] [PATCH v4 00/22] net/atlantic: Aquantia aQtion 10G NIC Family DPDK PMD driver

2018-10-10 Thread Ferruh Yigit
On 10/9/2018 10:31 AM, Igor Russkikh wrote: > Hello DPDK community! > > Aquantia would like to contribute PMD for aQtion AQC10X NIC family: > https://www.aquantia.com/products/aqtion/chips/ > These are 10G ethernet NICs with various features. > > We do base this work on parts of the existing nati

Re: [dpdk-dev] [PATCH v2 0/3] crypto/aesni_mb: add aes-gcm support

2018-10-10 Thread Akhil Goyal
Please add appropriate patch description. you can send another version/reply to the mail. On 10/10/2018 1:40 AM, Fan Zhang wrote: This patchset adds the AES-GCM algorithm support to AESNI-MB Cryptodev PMD and updates the unit test and documentations along. v2: - rebased on top of latest dpdk-ne

[dpdk-dev] [PATCH] app/testpmd: display devargs in port info output

2018-10-10 Thread Ferruh Yigit
Devargs may affect how device works but currently we don't have a way to observe provided devargs. Add ability to print device argument as part of port info, For example, for "--vdev net_pcap0,iface=lo" output will be " * Infos for port 1 * MAC address: 0

[dpdk-dev] [PATCH v3 00/12] introduce telemetry library

2018-10-10 Thread Kevin Laatz
This patchset introduces a Telemetry library for DPDK Service Assurance. This library provides an easy way to query DPDK Ethdev metrics. The telemetry library provides a method for a service assurance component to retrieve metrics from a DPDK packet forwarding application. Communicating from the s

[dpdk-dev] [PATCH v3 02/12] telemetry: initial telemetry infrastructure

2018-10-10 Thread Kevin Laatz
From: Ciara Power This patch adds the infrastructure and initial code for the telemetry library. The telemetry init is registered with eal_init(). We can then check to see if --telemetry was passed as an eal flag. If --telemetry was parsed, then we call telemetry init at the end of eal init. Co

[dpdk-dev] [PATCH v3 04/12] telemetry: add client feature and sockets

2018-10-10 Thread Kevin Laatz
From: Ciara Power This patch introduces clients to the telemetry API. When a client makes a connection through the initial telemetry socket, they can send a message through the socket to be parsed. Register messages are expected through this socket, to enable clients to register and have a clien

[dpdk-dev] [PATCH v3 03/12] telemetry: add initial connection socket

2018-10-10 Thread Kevin Laatz
From: Ciara Power This patch adds the telemetry UNIX socket. It is used to allow connections from external clients. On the initial connection from a client, ethdev stats are registered in the metrics library, to allow for their retrieval at a later stage. Signed-off-by: Ciara Power Signed-off-

[dpdk-dev] [PATCH v3 06/12] telemetry: update metrics before sending stats

2018-10-10 Thread Kevin Laatz
From: Ciara Power This patch adds functionality to update the statistics in the metrics library with values from the ethdev stats. Values need to be updated before they are encoded into a JSON message and sent to the client that requested them. The JSON encoding will be added in a subsequent pat

[dpdk-dev] [PATCH v3 01/12] eal: add param register infrastructure

2018-10-10 Thread Kevin Laatz
This commit adds infrastructure to EAL that allows an application to register it's init function with EAL. This allows libraries to be initialized at the end of EAL init. This infrastructure allows libraries that depend on EAL to be initialized as part of EAL init, removing circular dependency iss

[dpdk-dev] [PATCH v3 11/12] usertools: add client python script for telemetry

2018-10-10 Thread Kevin Laatz
From: Ciara Power This patch adds a python script which can be used as a demo client. The script is interactive and will allow the user to register, request statistics, and unregister. To run the script, an argument for the client file path must be passed in: "python telemetry_client.py ". This

[dpdk-dev] [PATCH v3 12/12] build: add dependency on telemetry to apps in meson

2018-10-10 Thread Kevin Laatz
This patch adds telemetry as a dependecy to all applications. Without these changes, the --telemetry flag will not be recognised and applications will fail to run if they want to enable telemetry. Signed-off-by: Bruce Richardson Signed-off-by: Kevin Laatz --- app/meson.build |

[dpdk-dev] [PATCH v3 07/12] telemetry: format json response when sending stats

2018-10-10 Thread Kevin Laatz
From: Ciara Power This patch adds functionality to create a JSON message in order to send it to a client socket. When stats are requested by a client, they are retrieved from the metrics library and encoded in JSON format. Signed-off-by: Ciara Power Signed-off-by: Brian Archbold Signed-off-by

[dpdk-dev] [PATCH v3 08/12] telemetry: add tests for telemetry api

2018-10-10 Thread Kevin Laatz
From: Ciara Power This patch adds all tests for the Telemetry API. The tests added include a parser test, selftest, and socket messaging tests. The parser tests pass valid and invalid messages to the parser to ensure the correct return values are received. The selftest tests basic functions in t

[dpdk-dev] [PATCH v3 10/12] doc: add telemetry documentation

2018-10-10 Thread Kevin Laatz
From: Ciara Power This patch adds all documentation for telemetry. A description on how to use the Telemetry API with a DPDK application is given in this document. It also adds the MAINTAINERS file entry for telemetry. Signed-off-by: Ciara Power Signed-off-by: Brian Archbold Signed-off-by: K

[dpdk-dev] [PATCH v3 09/12] telemetry: add ability to disable selftest

2018-10-10 Thread Kevin Laatz
From: Ciara Power This patch adds functionality to enable/disable the selftest. This functionality will be extended in future to make the enabling/disabling more dynamic and remove this 'hardcoded' approach. We are temporarily using this approach due to the design changes (vdev vs eal) made to t

[dpdk-dev] [PATCH v3 05/12] telemetry: add parser for client socket messages

2018-10-10 Thread Kevin Laatz
From: Ciara Power This patch adds the parser file. This is used to parse any messages that are received on any of the client sockets. Currently, the unregister functionality works using the parser. Functionality relating to getting statistic values for certain ports will be added in a subsequent

Re: [dpdk-dev] [PATCH 0/7] net/mlx5: fixes for the new flow engine

2018-10-10 Thread Ferruh Yigit
On 10/10/2018 6:57 AM, Shahaf Shuler wrote: > Tuesday, October 9, 2018 6:49 PM, Ferruh Yigit: >> Subject: Re: [dpdk-dev] [PATCH 0/7] net/mlx5: fixes for the new flow engine >> >> On 10/9/2018 9:58 AM, Shahaf Shuler wrote: >>> Monday, October 8, 2018 9:02 PM, Yongseok Koh: Subject: [PATCH 0/7]

Re: [dpdk-dev] [PATCH v4 0/3] add AES-CMAC support

2018-10-10 Thread Akhil Goyal
On 10/9/2018 9:55 PM, Trahe, Fiona wrote: acked-by: Fiona Trahe Applied to dpdk-next-crypto Thanks

[dpdk-dev] [PATCH v3 3/3] doc: update cryptodev and release note

2018-10-10 Thread Fan Zhang
This patch updates the cryptodev AESNI-MB PMD documentation with added AES-GCM algorithm support listed, and the release note. Signed-off-by: Fan Zhang --- doc/guides/cryptodevs/aesni_mb.rst | 1 + doc/guides/rel_notes/release_18_11.rst | 4 2 files changed, 5 insertions(+) diff --git

[dpdk-dev] [PATCH v3 0/3] crypto/aesni_mb: add aes-gcm support

2018-10-10 Thread Fan Zhang
This patchset adds the AES-GCM algorithm support to AESNI-MB Cryptodev PMD and updates the unit test and documentations. v3: - updated patch descriptions. v2: - rebased on top of latest dpdk-next-crypto. - removed incorrect __rte_unused macros. Fan Zhang (3): crypto/aesni_mb: add aes-gcm algor

[dpdk-dev] [PATCH v3 2/3] test/test_cryptodev: add AES-GCM tests to AESNI-MB

2018-10-10 Thread Fan Zhang
Since AES-GCM algorithm is supported in AESNI-MB PMD, the unit test for the PMD should be updated as well. This patch updates the unit test suite with added AES-GCM test cases. Signed-off-by: Fan Zhang --- test/test/test_cryptodev.c | 114 + 1 file cha

[dpdk-dev] [PATCH v3 1/3] crypto/aesni_mb: add aes-gcm algorithm support

2018-10-10 Thread Fan Zhang
This patch updates the current AESNI-MB PMD with added AES-GCM algorithm support. The patch includes the necessary changes to the code including the capability update, control and data patch changes for the AES-GCM algorithm support. Signed-off-by: Fan Zhang --- drivers/crypto/aesni_mb/aesni_mb_

Re: [dpdk-dev] [PATCH v3 0/3] crypto/aesni_mb: add aes-gcm support

2018-10-10 Thread Akhil Goyal
On 10/10/2018 4:34 PM, Fan Zhang wrote: This patchset adds the AES-GCM algorithm support to AESNI-MB Cryptodev PMD and updates the unit test and documentations. v3: - updated patch descriptions. v2: - rebased on top of latest dpdk-next-crypto. - removed incorrect __rte_unused macros. Fan Zh

Re: [dpdk-dev] [PATCH] common/qat: add support for GEN3 devices

2018-10-10 Thread Akhil Goyal
On 10/9/2018 6:49 PM, Jozwiak, TomaszX wrote: -Original Message- From: Trahe, Fiona Sent: Monday, October 1, 2018 10:18 PM To: dev@dpdk.org Cc: akhil.go...@nxp.com; sta...@dpdk.org; Jozwiak, TomaszX ; Trahe, Fiona Subject: [PATCH] common/qat: add support for GEN3 devices This adds pc

Re: [dpdk-dev] [PATCH v7 5/8] net/virtio: implement transmit path for packed queues

2018-10-10 Thread Jens Freimann
On Wed, Oct 10, 2018 at 09:27:31AM +0200, Maxime Coquelin wrote: On 10/03/2018 03:11 PM, Jens Freimann wrote: This implements the transmit path for devices with support for packed virtqueues. Signed-off-by: Jens Freiman --- drivers/net/virtio/virtio_ethdev.c | 32 ++-- drivers/net/virtio/v

Re: [dpdk-dev] [PATCH 3/7] net/mlx5: rename flow macros

2018-10-10 Thread Ferruh Yigit
On 10/8/2018 7:02 PM, Yongseok Koh wrote: > MLX5_ACTION_* -> MLX5_FLOW_ACTION_* > MLX5_VXLAN* -> MLX5_UDP_PORT_VXLAN* > > Fixes: 0f8775dd8f1c ("net/mlx5: add support for multiple flow drivers") > Fixes: edcdef4e5fe4 ("net/mlx5: add Linux TC flower driver for E-Switch flow") > Cc: Ori Kam > > Sig

Re: [dpdk-dev] [PATCH v3 0/3] ethdev: add generic L2/L3 tunnel encapsulation actions

2018-10-10 Thread Adrien Mazarguil
Sorry if I'm a bit late to the discussion, please see below. On Wed, Oct 10, 2018 at 09:00:52AM +, Ori Kam wrote: > > On 10/7/2018 1:57 PM, Ori Kam wrote: > > This series implement the generic L2/L3 tunnel encapsulation actions > > and is based on rfc [1] "add generic L2/L3 tunnel encapsulati

Re: [dpdk-dev] [PATCH] doc: update for ENA supported drivers

2018-10-10 Thread Rafał Kozik
Hello Ferruh, > Unless installed "igb_uio" won't be available to use with "modprobe", not sure > about adding that detail, what do you think? I did not add it. In current version this information is already present: > -#. Bind the intended ENA device to igb_uio module > This is only required if

[dpdk-dev] [PATCH v2] doc: update for ENA supported drivers

2018-10-10 Thread Rafal Kozik
Add instruction how to bind ENA to VFIO-PCI driver. Fixes: cf8a122c296a ("ena: introduce documentation") Cc: sta...@dpdk.org Signed-off-by: Zorik Machulsky Signed-off-by: Rafal Kozik Acked-by: Michal Krawczyk --- v2: Describe cases with and without IOMMU. --- doc/guides/nics/ena.rst

Re: [dpdk-dev] [dpdk-techboard] [PATCH] doc: note min required kernel version increase for 19.02

2018-10-10 Thread Thomas Monjalon
10/10/2018 11:40, Kevin Traynor: > Updating docs to reflect decision made at the techboard > that the min kernel version should be bumped from 3.2 to > the latest longterm stable release (3.16), but that > compatiblity for commonly used distribution kernels should > be kept also. > > Signed-off-by

Re: [dpdk-dev] [PATCH v3 03/12] telemetry: add initial connection socket

2018-10-10 Thread Thomas Monjalon
10/10/2018 12:51, Kevin Laatz: > --- a/lib/librte_telemetry/rte_telemetry.c > +++ b/lib/librte_telemetry/rte_telemetry.c > +#define DEFAULT_DPDK_PATH "/var/run/dpdk/rte/telemetry" As suggested in v2, please use eal_get_runtime_dir()

Re: [dpdk-dev] [PATCH 5/7] net/mlx5: fix flow validation for no fate action

2018-10-10 Thread Ferruh Yigit
On 10/9/2018 8:49 AM, Ori Kam wrote: > > >> -Original Message- >> From: Yongseok Koh >> Sent: Monday, October 8, 2018 9:02 PM >> To: Shahaf Shuler >> Cc: dev@dpdk.org; Yongseok Koh ; Ori Kam >> >> Subject: [PATCH 5/7] net/mlx5: fix flow validation for no fate action >> >> Fixes: 4f07e13

Re: [dpdk-dev] [PATCH v3 01/12] eal: add param register infrastructure

2018-10-10 Thread Thomas Monjalon
10/10/2018 12:51, Kevin Laatz: > --- /dev/null > +++ b/lib/librte_eal/common/include/rte_param.h Please add a global doxygen comment for the file. The context or goal is missing here. We need to understand what is the purpose of this new API file. Thanks

Re: [dpdk-dev] [PATCH] net/tap: fix reported number of Tx packets

2018-10-10 Thread Wiles, Keith
> On Oct 10, 2018, at 2:01 AM, Raslan Darawsheh wrote: > > When writev fails to send packets it doesn't update the > number of Tx packets, but it still num_tx is updated. > > the value that should be returned is the actual number > of sent packets which is num_packets. > > Fixes: 02f96a0a ("

Re: [dpdk-dev] [PATCH v5 3/3] net/tap: add queues when attaching from secondary process

2018-10-10 Thread Wiles, Keith
> On Oct 10, 2018, at 2:03 AM, Raslan Darawsheh wrote: > > In the case the device is created by the primary process, > the secondary must request some file descriptors to attach the queues. > The file descriptors are shared via IPC Unix socket. > > Thanks to the IPC synchronization, the secon

[dpdk-dev] [PATCH v2] net/mlx5: rewrite IP address UDP/TCP port by E-Switch

2018-10-10 Thread Jack Min
Offload the following rte_flow actions by inserting accordingly E-Switch rules via TC Flower driver - RTE_FLOW_ACTION_TYPE_SET_IPV4_SRC - RTE_FLOW_ACTION_TYPE_SET_IPV4_DST - RTE_FLOW_ACTION_TYPE_SET_IPV6_SRC - RTE_FLOW_ACTION_TYPE_SET_IPV6_DST - RTE_FLOW_ACTION_TYPE_SET_TP_SRC - RTE_FLOW_ACT

Re: [dpdk-dev] [PATCH v5 1/3] net/tap: add queue and port ids in Rx/Tx queues structures

2018-10-10 Thread Wiles, Keith
> On Oct 10, 2018, at 2:03 AM, Raslan Darawsheh wrote: > > Signed-off-by: Raslan Darawsheh This title for the patch is the what we did not why we did it, should that be changed? To me it does not convey the reason or we would need to add a more complete comment body text to explain why we

Re: [dpdk-dev] [PATCH 7/7] net/mlx5: fix errno values for flow engine

2018-10-10 Thread Ferruh Yigit
On 10/9/2018 8:53 AM, Ori Kam wrote: > > >> -Original Message- >> From: Yongseok Koh >> Sent: Monday, October 8, 2018 9:02 PM >> To: Shahaf Shuler >> Cc: dev@dpdk.org; Yongseok Koh ; Ori Kam >> >> Subject: [PATCH 7/7] net/mlx5: fix errno values for flow engine >> >> Fixes: 4f07e13d6af5

Re: [dpdk-dev] [PATCH 0/7] net/mlx5: fixes for the new flow engine

2018-10-10 Thread Ferruh Yigit
On 10/10/2018 11:57 AM, Ferruh Yigit wrote: > On 10/10/2018 6:57 AM, Shahaf Shuler wrote: >> Tuesday, October 9, 2018 6:49 PM, Ferruh Yigit: >>> Subject: Re: [dpdk-dev] [PATCH 0/7] net/mlx5: fixes for the new flow engine >>> >>> On 10/9/2018 9:58 AM, Shahaf Shuler wrote: Monday, October 8, 201

[dpdk-dev] [PATCH] devtools: add exception for OCTEON TX

2018-10-10 Thread Anoob Joseph
The 'TX' in OCTEON TX would cause a warning. Adding an exception for that. OCTEON TX is a registered product under Cavium Signed-off-by: Anoob Joseph --- devtools/check-git-log.sh | 2 ++ 1 file changed, 2 insertions(+) diff --git a/devtools/check-git-log.sh b/devtools/check-git-log.sh index 9

[dpdk-dev] [PATCH v3 0/3] ethdev: add generic TTL rewrite actions

2018-10-10 Thread Jack Min
This patch series is for RFC[1] and depends on patch[2] Patch 1 adds generic TTL rewrite actions to flow API Patch 2 adds corresponding testpmd commands Patch 3 implements the offloading logic of E-Switch rules on Mellanox MLX5 [1]: https://patches.dpdk.org/patch/43617/ [2]: https://patches.dpdk.

[dpdk-dev] [PATCH v3 1/3] ethdev: add generic TTL rewrite actions

2018-10-10 Thread Jack Min
rewrite TTL by decrease or just set it directly it's not necessary to check if the final result is zero or not This is slightly different from the one defined by openflow and more generic Signed-off-by: Xiaoyu Min Acked-by: Yongseok Koh --- doc/guides/prog_guide/rte_flow.rst | 30 +

[dpdk-dev] [PATCH v3 2/3] app/testpmd: add commands of modify TTL

2018-10-10 Thread Jack Min
add commands which supports following TTL actions: - RTE_FLOW_ACTION_TYPE_DEC_TTL - RTE_FLOW_ACTION_TYPE_SET_TTL Signed-off-by: Xiaoyu Min Acked-by: Yongseok Koh --- app/test-pmd/cmdline_flow.c | 34 + doc/guides/testpmd_app_ug/testpmd_funcs.rst | 5 +++ 2 f

[dpdk-dev] [PATCH v3 3/3] net/mlx5: rewrite TTL by E-Switch

2018-10-10 Thread Jack Min
Offload following modify TTL actions to E-Switch via TC-Flower driver - RTE_FLOW_ACTION_TYPE_SET_TTL - RTE_FLOW_ACTION_TYPE_DEC_TTL The corresponding IP protocol rte_flow_item_ipv[4|6] must be present in rte_flow pattern otherwith PMD return error The example testpmd commands are: flow crea

[dpdk-dev] [PATCH v2 0/3] ethdev: add generic MAC address rewrite actions

2018-10-10 Thread Jack Min
This series is for RFC[1] and depends on patch[2] Patch 1 adds generic MAC address rewrite actions to flow API Patch 2 adds testpmd commands for that Patch 3 offloads these actions on Mellanox MLX5 by using E-Switch rule [1]: https://patches.dpdk.org/patch/44005/ [2]: https://patches.dpdk.org/pat

[dpdk-dev] [PATCH v2 2/3] app/testpmd: add commands of modify MAC address

2018-10-10 Thread Jack Min
add commands to support following actions: - RTE_FLOW_ACTION_TYPE_SET_MAC_SRC - RTE_FLOW_ACTION_TYPE_SET_MAC_DST Signed-off-by: Xiaoyu Min Acked-by: Yongseok Koh --- app/test-pmd/cmdline_flow.c | 50 + doc/guides/testpmd_app_ug/testpmd_funcs.rst | 8 2

[dpdk-dev] [PATCH v2 1/3] ethdev: add generic MAC address rewrite actions

2018-10-10 Thread Jack Min
rte_flow actions: - RTE_FLOW_ACTION_TYPE_SET_MAC_SRC - RTE_FLOW_ACTION_TYPE_SET_MAC_DST added in order to offload to NIC The rte_flow_itme_eth must be present in rte_flow pattern Signed-off-by: Xiaoyu Min Acked-by: Yongseok Koh Acked-by: Andrew Rybchenko --- doc/guides/prog_guide/rte_flow.rst

[dpdk-dev] [PATCH v2 3/3] net/mlx5: rewrite MAC address by E-Switch

2018-10-10 Thread Jack Min
Offload following modify MAC address actions to E-Switch via TC-Flower driver - RTE_FLOW_ACTION_TYPE_SET_MAC_SRC - RTE_FLOW_ACTION_TYPE_SET_MAC_DST The corresponding rte_flow_item_eth must be present in rte_flow pattern Only support modify outer layer MAC address The example testpmd command is:

  1   2   >