Hi Yipeng,
I will rebase this further with your V7 and submit V3. Please let me
know if you have any comments in the meantime. Due to time constraints, I do
not plan to support lock-free for extended bucket feature in this release. I
will add that support in the next release. Please let
On Wed, Oct 10, 2018 at 06:11:45AM -0700, Jack Min wrote:
> Offload following modify MAC address actions to E-Switch
> via TC-Flower driver
>
> - RTE_FLOW_ACTION_TYPE_SET_MAC_SRC
> - RTE_FLOW_ACTION_TYPE_SET_MAC_DST
>
> The corresponding rte_flow_item_eth must be present in
> rte_flow pattern
>
On Wed, Oct 10, 2018 at 06:06:00AM -0700, Jack Min wrote:
> Offload following modify TTL actions to E-Switch via
> TC-Flower driver
>
> - RTE_FLOW_ACTION_TYPE_SET_TTL
> - RTE_FLOW_ACTION_TYPE_DEC_TTL
>
> The corresponding IP protocol rte_flow_item_ipv[4|6]
> must be present in rte_flow pattern ot
> >> >
> >> >Add the flag to enable reader-writer concurrency during run time.
> >> >The rte_hash_del_xxx APIs do not free the keystore element when this
> >> >flag is enabled. Hence a new API, rte_hash_free_key_with_position,
> >> >to free the key store element is added.
> >> >
> >> >+/** Flag to
Hi Moti,
Wednesday, October 10, 2018 5:44 PM, Mordechay Haimovsky:
> Subject: [PATCH v3] net/mlx5: support e-switch TCP-flags flow filter
>
> This patch adds support for offloading flow rules with TCP-flags filter to
> mlx5
> eswitch Hardwrae.
>
> With mlx5 it is possible to offload a limited s
> -Original Message-
> From: Wang, Xiao W
> Sent: Wednesday, October 10, 2018 9:40 PM
> To: Ye, Xiaolong ; dev@dpdk.org; Zhang, Qi Z
>
> Subject: RE: [PATCH] net/ifc: invoke ifcvf HW init function in probe
>
> Hi,
>
> > -Original Message-
> > From: Ye, Xiaolong
> > Sent: Wedne
Reader-writer concurrency issue, caused by moving the keys
to their alternative locations during key insert, is solved
by introducing a global counter(tbl_chng_cnt) indicating a
change in table.
Signed-off-by: Honnappa Nagarahalli
Reviewed-by: Gavin Hu
Reviewed-by: Ola Liljedahl
Reviewed-by: St
Only race condition that can occur is - using the key store element
before the key write is completed. Hence, while inserting the element
the release memory order is used. Any other race condition is caught
by the key comparison. Memory orderings are added only where needed.
For ex: reads in the w
Add the flag to enable reader-writer concurrency during
run time. The rte_hash_del_xxx APIs do not free the keystore
element when this flag is enabled. Hence a new API,
rte_hash_free_key_with_position, to free the key store element
is added.
Signed-off-by: Honnappa Nagarahalli
Reviewed-by: Gavin
Correct the key store array element alignment. This is required to
make 'pdata' in 'struct rte_hash_key' align on the correct boundary.
Signed-off-by: Honnappa Nagarahalli
Reviewed-by: Gavin Hu
Reviewed-by: Ola Liljedahl
Reviewed-by: Steve Capper
---
lib/librte_hash/rte_cuckoo_hash.c | 4 +++-
From: Dharmik Thakkar
Unit tests to check for hash lookup perf with lock-free enabled and
with lock-free disabled.
Unit tests performed with readers running in parallel with writers.
Tests include:
- hash lookup on existing keys with:
- hash add causing NO key-shifts of existing keys in the t
rte_hash_lookup_xxx APIs return the index of the element in
the key store. Application(reader) can use that index to reference
other data structures in its scope. Because of this, the
index should not be recycled till the application completes
using the index.
RTE_HASH_EXTRA_FLAGS_RECYCLE_ON_DEL is
Currently, reader-writer concurrency problems in rte_hash are
addressed using reader-writer locks. Use of reader-writer locks
results in following issues:
1) In many of the use cases for the hash table, writer threads
are running on control plane. If the writer is preemp
RW concurrency is required with single writer and multiple reader
usecase as well. Hence, multi-writer should not be enabled by default when
RW concurrency is enabled.
Fixes: f2e3001b53ec ("hash: support read/write concurrency")
Cc: yipeng1.w...@intel.com
Signed-off-by: Honnappa Nagarahalli
Revi
Monday, October 8, 2018 11:25 AM, Shahaf Shuler:
> Subject: [dpdk-dev] [PATCH 0/3] Representor fixes for BlueField device
>
> Setting BlueField device with representors introduced some corner cases
> that were overlooked during the development of representors for x86.
>
> This series enables the
This commit improves the readwrite test to consider
extendable table feature and add more functional tests
to cover more corner cases.
Signed-off-by: Yipeng Wang
---
test/test/test_hash_readwrite.c | 70 ++---
1 file changed, 58 insertions(+), 12 deletions(-)
This patch set depends on another rte hash patch set:
http://patchwork.dpdk.org/cover/46106/
This patch set includes three commits to improve rte_hash
and its unit tests.
1. Remove unnecessary pause code in rte_reset function.
2 and 3. Improve the unit test.
Signed-off-by: Yipeng Wang
Yipeng W
There is a rte_pause in hash table reset function.
Since the loop is not a polling loop on shared
data structure, the rte_pause is not needed.
Fixes: b26473ff8f4a ("hash: add reset function")
Cc: sta...@dpdk.org
Signed-off-by: Yipeng Wang
---
lib/librte_hash/rte_cuckoo_hash.c | 4 ++--
1 file c
With sequential key, the test will cover more corner
cases with jhash instead of crc hash, since jhash
generates more random hash pattern on sequential key.
It is useful for functional verification.
Signed-off-by: Yipeng Wang
---
test/test/test_hash_multiwriter.c | 15 +++
1 file cha
On Wed, Oct 10, 2018 at 05:56:15AM -0700, Jack Min wrote:
> Offload the following rte_flow actions by inserting accordingly
> E-Switch rules via TC Flower driver
>
> - RTE_FLOW_ACTION_TYPE_SET_IPV4_SRC
> - RTE_FLOW_ACTION_TYPE_SET_IPV4_DST
> - RTE_FLOW_ACTION_TYPE_SET_IPV6_SRC
> - RTE_FLOW_ACT
Hi,
> -Original Message-
> From: Ye, Xiaolong
> Sent: Wednesday, October 10, 2018 9:23 PM
> To: dev@dpdk.org; Zhang, Qi Z
> Cc: Wang, Xiao W ; Ye, Xiaolong
>
> Subject: [PATCH] net/ifc: invoke ifcvf HW init function in probe
>
> As ifcvf_init_hw is independent with ifcvf_vfio_setup, it'
This commit changes the hashing mechanism to "partial-key
hashing" to calculate bucket index and signature of key.
This is proposed in Bin Fan, et al's paper
"MemC3: Compact and Concurrent MemCache with Dumber Caching
and Smarter Hashing". Basically the idea is to use "xor" to
derive alternative
This commit changes the current rte_hash unit test to
test the extendable table feature and performance.
Signed-off-by: Yipeng Wang
Reviewed-by: Honnappa Nagarahalli
Acked-by: Dharmik Thakkar
---
test/test/test_hash.c | 159 +++--
test/test/test_has
This patch has dependency on another bug fix patch set:
http://patchwork.dpdk.org/cover/45611/
This patch set makes two major optimizations over the current rte_hash
library.
First, it adds Extendable Bucket Table feature: a new structure that can
accommodate keys that failed to get inserted into
In use cases that hash table capacity needs to be guaranteed,
the extendable bucket feature can be used to contain extra
keys in linked lists when conflict happens. This is similar
concept to the extendable bucket hash table in packet
framework.
This commit adds the extendable bucket feature. User
In rte_hash_iterate, the reader lock did not protect the
while loop which checks empty entry. This created a race
condition that the entry may become empty when enters
the lock, then a wrong key data value would be read out.
This commit reads out the position in the while condition,
which makes su
> -Original Message-
> From: Ye, Xiaolong
> Sent: Wednesday, October 10, 2018 2:42 AM
> To: Wang, Xiao W
> Cc: Zhang, Qi Z ; dev@dpdk.org
> Subject: Re: [PATCH] net/ifc: fix function name
>
> Acked-by: Ye Xiaolong
>
> Thanks,
> Xiaolong
>
> On 09/25, Xiao Wang wrote:
> >The address
I'll have a look at this.. Maybe it will work, I'll have to try it and
test it to see if there are any gotchas that are not obvious.
d
On Wed, Oct 10, 2018 at 7:51 PM Ferruh Yigit wrote:
> >> Very simply, what about prevent kni_net_release() send callback to
> >> userspace?
> >
> > No, because
On Wed, Oct 10, 2018 at 8:00 PM Ferruh Yigit wrote:
> > I'm incredibly frustrated with this whole process to be honest...
>
> Please don't be so, you are spending time/effort to improve an open source
> project which is great, thank you again.
>
> Why don't we take this as incremental steps, first
The cast of hpet_msb_inc is causing a warning in some compilations.
Yet the cast is unnecessary, the function is used only one place
just use the correct signature.
Signed-off-by: Stephen Hemminger
---
lib/librte_eal/linuxapp/eal/eal_timer.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletion
On 10/10/2018 4:01 PM, Dan Gora wrote:
> On Wed, Oct 10, 2018 at 11:16 AM Ferruh Yigit wrote:
>>
>> On 9/27/2018 1:32 AM, Dan Gora wrote:
>>> Hi All,
>>>
>>> Attached is version 3 of a patchset to add a new API function to
>>> set the link status on kernel interfaces created with the KNI kernel
>>
On 10/10/2018 7:18 PM, Dan Gora wrote:
> On Wed, Oct 10, 2018 at 2:25 PM Ferruh Yigit wrote:
>>
>> On 9/4/2018 1:36 AM, Dan Gora wrote:
>>> Hi Ferruh,
>>>
>>> I remembered now the motivation behind separating rte_kni_release()
>>> and rte_kni_free().
>>>
>>> The problem is that the DPDK thread whi
- track whether counter DMAs are active or not so they can be stopped if
needed before DMA memory is freed
- fix counter DMA shut-down by changing vnic_dev_counter_dma_cfg() to
take the number of counters to DMA instead of high counter index and
use num counters = 0 to shut off DMAs
- remove
On Wed, Oct 10, 2018 at 11:35:28AM +0300, Dekel Peled wrote:
> This patch adds glue functions for operations:
> - Create packet reformat (encap/decap) flow action.
> - Destroy flow action.
>
> The new operations depend on HAVE_IBV_FLOW_ACTION_DV_SUPPORT.
>
> Signed-off-by: Dekel Peled
> ---
> d
On Wed, Oct 10, 2018 at 04:43:14PM +0200, Thomas Monjalon wrote:
> 10/10/2018 16:29, Neil Horman:
> > Thomas attempted to submit this:
> > https://patches.dpdk.org/patch/46311/
> >
> > The other day, because the other patches being submitted with it were
> > breaking on a false positive from the c
09/10/2018 12:13, Ferruh Yigit:
> build error:
> .../lib/librte_eventdev/rte_event_eth_tx_adapter.c:
> In function ‘txa_service_queue_del’:
> .../lib/librte_eventdev/rte_event_eth_tx_adapter.c:800:7:
> error: ‘ret’ may be used uninitialized in this function
> [-Werror=maybe-uninitialized]
> c
>
> Hi Jerin,
>
> Following the guide to use the PMU counters(KO inserted and DPDK
> recompiled), the numbers increased 10+ folds(bigger numbers here mean
> more precise?), is this valid and expected?
This is correct, big numbers mean, more precise/granular results.
> No significant difference w
The MAC addresses of a port can be matched with devargs.
As the conflict between rte_ether.h and netinet/ether.h is not resolved,
the MAC parsing is done with a rte_cmdline function.
As a result, cmdline library becomes a dependency of ethdev.
Signed-off-by: Thomas Monjalon
---
lib/Makefile
The representor id is added in rte_eth_dev_data in order to be able
to match a port with its representor id in devargs.
Signed-off-by: Thomas Monjalon
Reviewed-by: Andrew Rybchenko
---
drivers/net/i40e/i40e_vf_representor.c | 1 +
drivers/net/ixgbe/ixgbe_vf_representor.c | 1 +
drivers/net/
The functions for representor devargs parsing were static
in the file rte_ethdev.c.
In order to reuse them in the file rte_class_eth.c,
they are moved to the files ethdev_private.c/.h.
A log is fixed by adding a missing line feed.
Signed-off-by: Thomas Monjalon
Acked-by: Andrew Rybchenko
---
l
The new ethdev iterator lacks the support of filtering
by representor port id or by MAC address.
Changes in v2:
- fix list parsing in kvargs
- support mac= parameter
Thomas Monjalon (4):
kvargs: support list value
ethdev: move representor parsing functions
ethdev: support representor
If a value contains a comma, rte_kvargs_tokenize() will split here.
In order to support list syntax [a,b] as value, an extra parsing of
the square brackets is added.
Signed-off-by: Thomas Monjalon
---
lib/librte_kvargs/rte_kvargs.c | 14 ++
test/test/test_kvargs.c| 21 +++
10/10/2018 20:01, Andrew Rybchenko:
> On 10.10.2018 19:43, Thomas Monjalon wrote:
> > 10/10/2018 17:01, Andrew Rybchenko:
> >> On 10/10/18 11:39 AM, Thomas Monjalon wrote:
> >>> 10/10/2018 09:50, Andrew Rybchenko:
> On 10/10/18 10:44 AM, Thomas Monjalon wrote:
> > 10/10/2018 08:15, Andrew
Ok, makes sense now, both flow query and flow list work with this patch, yeah.
Tested-by: John Daley
Remember that https://patches.dpdk.org/patch/46221/ still needs to be reverted
out of dpdk-next-net/master otherwise we are still broken. The patch was
squished into e5b652ea34.
-johnd
>
> -Original Message-
> From: Zhao1, Wei
> Sent: Monday, October 8, 2018 2:46 AM
> To: Zhang, Qi Z ; mocan
> Cc: dev@dpdk.org; Lu, Wenzhuo
> Subject: RE: Re:RE: [dpdk-dev] [PATCH] net/ixgbe: put 5tuple check in front
> to jump over ntuple filter case
>
> Hi,
>
>
> > -Original Mes
On Wed, Oct 10, 2018 at 2:25 PM Ferruh Yigit wrote:
>
> On 9/4/2018 1:36 AM, Dan Gora wrote:
> > Hi Ferruh,
> >
> > I remembered now the motivation behind separating rte_kni_release()
> > and rte_kni_free().
> >
> > The problem is that the DPDK thread which calls rte_kni_release()
> > _cannot_ be
> -Original Message-
> From: Zhao1, Wei
> Sent: Wednesday, October 10, 2018 12:14 AM
> To: Luca Boccassi ; dev@dpdk.org
> Cc: Lu, Wenzhuo ; Zhang, Qi Z
>
> Subject: RE: [dpdk-dev] [PATCH] net/e1000: enable MSI-x for linkup and
> other events in 82574
>
> Acked-by: Wei Zhao
Applied to
On 10.10.2018 19:43, Thomas Monjalon wrote:
10/10/2018 17:01, Andrew Rybchenko:
On 10/10/18 11:39 AM, Thomas Monjalon wrote:
10/10/2018 09:50, Andrew Rybchenko:
On 10/10/18 10:44 AM, Thomas Monjalon wrote:
10/10/2018 08:15, Andrew Rybchenko:
On 10/10/18 1:17 AM, Thomas Monjalon wrote:
After
> -Original Message-
> From: Zhao1, Wei
> Sent: Wednesday, October 10, 2018 12:25 AM
> To: Luca Boccassi ; dev@dpdk.org
> Cc: Lu, Wenzhuo ; sta...@dpdk.org; Zhang, Qi Z
> ; 3ch...@gmail.com
> Subject: RE: [dpdk-dev] [PATCH] net/e1000: do not error out if rx_drop_en is
> set
>
> Acked-by:
Add support for packet decap table action.
Signed-off-by: Cristian Dumitrescu
---
drivers/net/softnic/rte_eth_softnic_action.c| 11 +++
drivers/net/softnic/rte_eth_softnic_cli.c | 38 +
drivers/net/softnic/rte_eth_softnic_internals.h | 1 +
drivers/net/soft
Add support for packet tag table action.
Signed-off-by: Cristian Dumitrescu
---
drivers/net/softnic/rte_eth_softnic_action.c| 11 +++
drivers/net/softnic/rte_eth_softnic_cli.c | 38 +
drivers/net/softnic/rte_eth_softnic_internals.h | 1 +
drivers/net/softni
Add support for ethdev flow API VXLAN decap action.
Signed-off-by: Cristian Dumitrescu
---
drivers/net/softnic/rte_eth_softnic_flow.c | 35 ++
1 file changed, 35 insertions(+)
diff --git a/drivers/net/softnic/rte_eth_softnic_flow.c
b/drivers/net/softnic/rte_eth_soft
This patch introduces a new table action for packet decapsulation
which removes n bytes from the start of the input packet. The n
is read from the current table entry. The following mbuf fields
are updated by the action: data_off, data_len, pkt_len.
Signed-off-by: Cristian Dumitrescu
---
lib/lib
Add support for packet decap table action.
Signed-off-by: Cristian Dumitrescu
---
examples/ip_pipeline/action.c | 11 +++
examples/ip_pipeline/cli.c | 39 ++-
examples/ip_pipeline/pipeline.h | 1 +
examples/ip_pipeline/thread.c | 10 +
Add support for ethdev flow API mark action.
Signed-off-by: Cristian Dumitrescu
---
drivers/net/softnic/rte_eth_softnic_flow.c | 35 ++
1 file changed, 35 insertions(+)
diff --git a/drivers/net/softnic/rte_eth_softnic_flow.c
b/drivers/net/softnic/rte_eth_softnic_flo
Add support for the packet tag table action.
Signed-off-by: Cristian Dumitrescu
---
examples/ip_pipeline/action.c | 11 +++
examples/ip_pipeline/cli.c | 38 +-
examples/ip_pipeline/pipeline.h | 1 +
examples/ip_pipeline/thread.c | 10
This patch introduces the packet tag table action which attaches
a 32-bit value (the tag) to the current input packet. The tag is
read from the current table entry. The tag is written into the
mbuf->hash.fdir.hi and the flags PKT_RX_FDIR and PKT_RX_FDIR_ID
are set into mbuf->ol_flags.
Signed-off-b
On 9/4/2018 1:36 AM, Dan Gora wrote:
> Hi Ferruh,
>
> I remembered now the motivation behind separating rte_kni_release()
> and rte_kni_free().
>
> The problem is that the DPDK thread which calls rte_kni_release()
> _cannot_ be the same thread which handles callbacks from the KNI
> driver via rte
This patch fixes a bug found in port_flow_query routine which caused
flow query command to fail with the following error "Caught error
type 1 (cause unspecified): unknown object type to retrieve the name
of: Invalid argument".
Fixes: f7ba5e7a0f8c ("app/testpmd: rely on flow API conversion function
10/10/2018 17:01, Andrew Rybchenko:
> On 10/10/18 11:39 AM, Thomas Monjalon wrote:
> > 10/10/2018 09:50, Andrew Rybchenko:
> >> On 10/10/18 10:44 AM, Thomas Monjalon wrote:
> >>> 10/10/2018 08:15, Andrew Rybchenko:
> On 10/10/18 1:17 AM, Thomas Monjalon wrote:
> > After closing a port, it
On Wed, Oct 10, 2018 at 04:27:59PM +, Mordechay Haimovsky wrote:
> Hi Adrien,
> You are correct, the bug is not where we thought it is, moreover the fix
> breaks
> the CLI and should be rejected.
> We investigated more and found that the bug is in the port_flow_query routine
> Which passes an
Hi
> -Original Message-
> From: Parthasarathy, JananeeX M
> Sent: Saturday, September 22, 2018 12:55 PM
> To: dev@dpdk.org
> Cc: Pattan, Reshma ; rsanf...@akamai.com;
> Parthasarathy, JananeeX M
> Subject: [PATCH] test: reduce duration for timer autotest
>
>
> /* pick random time
Hi Adrien,
You are correct, the bug is not where we thought it is, moreover the fix breaks
the CLI and should be rejected.
We investigated more and found that the bug is in the port_flow_query routine
Which passes an incorrect argument to rte_flow_conv as follows:
ret = rte_flow_conv(
On Wed, Oct 10, 2018 at 01:17:01PM +, Ori Kam wrote:
> > -Original Message-
> > From: Adrien Mazarguil
> > On Wed, Oct 10, 2018 at 09:00:52AM +, Ori Kam wrote:
> >
> > > > On 10/7/2018 1:57 PM, Ori Kam wrote:
> > > > In addtion the parameter to to the encap action is a list of
Just a quick reminder that the CFP deadline for this event is October 22nd, so
if you're planning to submit a proposal you have less than 2 weeks left now.
You can submit proposals at:
https://events.linuxfoundation.org/events/dpdknorthamerica2018/dpdk-na-program/cfp/.
If you're attending, you
On 10/10/18 11:39 AM, Thomas Monjalon wrote:
10/10/2018 09:50, Andrew Rybchenko:
On 10/10/18 10:44 AM, Thomas Monjalon wrote:
10/10/2018 08:15, Andrew Rybchenko:
On 10/10/18 1:17 AM, Thomas Monjalon wrote:
After closing a port, it cannot be restarted.
So there is no reason to not free all ass
On Wed, Oct 10, 2018 at 11:16 AM Ferruh Yigit wrote:
>
> On 9/27/2018 1:32 AM, Dan Gora wrote:
> > Hi All,
> >
> > Attached is version 3 of a patchset to add a new API function to
> > set the link status on kernel interfaces created with the KNI kernel
> > module.
> >
> > v3
> >
> > * Use sep
On Wed, Oct 10, 2018 at 11:09 AM Ferruh Yigit wrote:
> > Yes, I understand that.. As I pointed out previously, if there is no
> > physical device which corresponds to this KNI interface, the
> > application can:
> >
> > 1) Not use this API at all, just as they do now.
>
> This API has nothing wit
On 10/8/2018 10:11 AM, phil.y...@arm.com wrote:
> Keep only single config option RTE_USE_C11_MEM_MODEL for C11 memory
> model, so all modules can leverage C11 atomic extension by enable this
> option.
>
> Signed-off-by: Phil Yang
> Reviewed-by: Honnappa Nagarahalli
> Reviewed-by: Gavin Hu
> Ack
This patch adds support for offloading flow rules with TCP-flags
filter to mlx5 eswitch Hardwrae.
With mlx5 it is possible to offload a limited set of flow rules to
the mlxsw (or e-switch) using the DPDK flow commands using the
"transfer" attribute. This set of flow rules also supports filtering
a
10/10/2018 16:29, Neil Horman:
> Thomas attempted to submit this:
> https://patches.dpdk.org/patch/46311/
>
> The other day, because the other patches being submitted with it were
> breaking on a false positive from the check-experimental-syms check.
>
> The problem was that the experimental symb
On 10/10/2018 11:06 AM, Gavin Hu (Arm Technology China) wrote:
>
>
>> -Original Message-
>> From: Phil Yang (Arm Technology China)
>> Sent: Wednesday, October 10, 2018 5:59 PM
>> To: Stephen Hemminger
>> Cc: dev@dpdk.org; jerin.ja...@caviumnetworks.com; Gavin Hu (Arm
>> Technology China)
Hi,
Just sent a new version with the commit log reworded to answer the "why"
question you mentioned.
Thx for your reviews.
Kindest regards,
Raslan Darawsheh
> -Original Message-
> From: Thomas Monjalon
> Sent: Wednesday, October 10, 2018 5:08 PM
> To: Wiles, Keith ; Raslan Darawsheh
>
In the case the device is created by the primary process,
the secondary must request some file descriptors to attach the queues.
The file descriptors are shared via IPC Unix socket.
Thanks to the IPC synchronization, the secondary process
is now able to do Rx/Tx on a TAP created by the primary pro
Just sent a new Version with the commit log reworded as mentioned.
Kindest regards,
Raslan Darawsheh
> -Original Message-
> From: Wiles, Keith
> Sent: Wednesday, October 10, 2018 3:48 PM
> To: Raslan Darawsheh
> Cc: Thomas Monjalon ; dev@dpdk.org; Shahaf
> Shuler ; Ori Kam ; Yigit,
> F
Port and queue ids are added to easily map the file
descriptors stored in each process private.
---
changes in v6:
- reword the commit log
Signed-off-by: Raslan Darawsheh
---
drivers/net/tap/rte_eth_tap.c | 3 +++
drivers/net/tap/rte_eth_tap.h | 3 +++
2 files changed, 6 insertions(+)
diff
fd's cannot be shared between processes, and each process need to have
it's own fd's pointer.
Signed-off-by: Raslan Darawsheh
---
drivers/net/tap/rte_eth_tap.c | 93 +--
drivers/net/tap/rte_eth_tap.h | 7 +++-
drivers/net/tap/tap_flow.c| 3 +-
driver
Thomas attempted to submit this:
https://patches.dpdk.org/patch/46311/
The other day, because the other patches being submitted with it were
breaking on a false positive from the check-experimental-syms check.
The problem was that the experimental symbol check script matched on the
regexs "\.text
On 9/27/2018 1:32 AM, Dan Gora wrote:
> Hi All,
>
> Attached is version 3 of a patchset to add a new API function to
> set the link status on kernel interfaces created with the KNI kernel
> module.
>
> v3
>
> * Use separate function to test rte_kni_update_link() in 'test' app.
>
> * Separat
Updating docs to reflect decision made at the techboard
that the min kernel version should be bumped from 3.2 to
the latest longterm stable release (3.16), but that
compatiblity for commonly used distribution kernels should
be kept also.
Signed-off-by: Kevin Traynor
Acked-by: Maxime Coquelin
Ack
NICs uses different delays up to a second during their
configuration. It makes no sense to busy-wait so long wasting
CPU cycles and preventing any other threads to execute on the
same CPU core. These busy polling are the rudiments that came
from the kernel drivers where you can not sleep in interru
For meson build without deprecation warnings following
patch should be applied first:
http://patches.dpdk.org/patch/46064/
Version 4:
* Fixed return value checking for nanosleep().
It doesn't return EINTR, it sets the errno.
Version 3:
* Minor rebase on top of curren
Add a new rte_delay_us_sleep() function that uses nanosleep().
This function can be used by applications to not implement
their own nanosleep() based callback and by internal DPDK
code if CPU non-blocking delay needed.
Signed-off-by: Ilya Maximets
---
lib/librte_eal/common/eal_common_timer.c
On 10/3/2018 8:07 PM, Dan Gora wrote:
> On Fri, Sep 28, 2018 at 5:03 AM Ferruh Yigit wrote:
>>
>> On 9/28/2018 12:51 AM, Dan Gora wrote:
>>> On Thu, Sep 27, 2018 at 8:44 PM, Ferruh Yigit
>>> wrote:
> Well, yes the link_status (link up, link down) _is_ applied to the KNI
> interface. Whe
10/10/2018 14:50, Wiles, Keith:
>
> > On Oct 10, 2018, at 2:03 AM, Raslan Darawsheh wrote:
> >
> > Signed-off-by: Raslan Darawsheh
>
> This title for the patch is the what we did not why we did it, should that be
> changed? To me it does not convey the reason or we would need to add a more
>
On 10/10/2018 2:35 PM, Igor Russkikh wrote:
> Hi Ferruh,
>
>>> +int rte_pmd_atl_dev_led_control(int port, int control);
>>
>> What is the intention here, making PMD specific public API?
>> If so .map file is missing but we discourage using PMD specific APIs,
>>
>> can't it be possible to extend ex
Hi Ferruh,
>> +int rte_pmd_atl_dev_led_control(int port, int control);
>
> What is the intention here, making PMD specific public API?
> If so .map file is missing but we discourage using PMD specific APIs,
>
> can't it be possible to extend exiting led related dev_ops in a generic way to
> cove
> -Original Message-
> From: Yigit, Ferruh
> Sent: Wednesday, October 10, 2018 12:42 PM
> To: Lu, Wenzhuo ; Wu, Jingjing
> ; Iremonger, Bernard
> Cc: dev@dpdk.org; Yigit, Ferruh
> Subject: [PATCH] app/testpmd: display devargs in port info output
>
> Devargs may affect how device works bu
On 10.10.2018 13:32, Ferruh Yigit wrote:
> Hi Igor,
>
> I put some comments on individual patches, please check them.
>
> Also can you please run "./devtools/check-git-log.sh -22" and fix reported
> warnings there?
Hi Ferruh,
Thanks alot for the detailed review and comments, we'll rework the
Reduced test duration for func_reentrancy_autotest.
Reduced MAX_LPM_ITER_TIMES, introduced new macro
MAX_ITER_ONCE to reduce the unique key check and
altered the macro MAX_ITER_TIMES to MAX_ITER_MULTI.
Combined for loops thereby reduced snprintf calls
and repeated iterations.
Such that the duration
Hi
PSB.
> -Original Message-
> From: Adrien Mazarguil
> Sent: Wednesday, October 10, 2018 3:02 PM
> To: Ori Kam
> Cc: Andrew Rybchenko ; Ferruh Yigit
> ; step...@networkplumber.org; Declan Doherty
> ; dev@dpdk.org; Dekel Peled
> ; Thomas Monjalon ; Nélio
> Laranjeiro ; Yongseok Koh
> ; S
-Original Message-
> Date: Wed, 10 Oct 2018 08:20:56 +0530
> From: Anoob Joseph
> To: Ferruh Yigit , Jerin Jacob
> , Thomas Monjalon
> Cc: Anoob Joseph , Narayana Prasad
> , Shally Verma
> , dev@dpdk.org
> Subject: [PATCH] maintainers: use registered name for OCTEON TX references
> X-M
On 09/10/2018 16:11, Stephen Hemminger wrote:
On Tue, 09 Oct 2018 16:31:24 +0200
[..]
This is getting complex enough that doing a real parser maybe necessary.
I thought the same thing back in April with the port representor
patchsets. Quickly run out of things to use as delimiters otherwis
Offload following modify MAC address actions to E-Switch
via TC-Flower driver
- RTE_FLOW_ACTION_TYPE_SET_MAC_SRC
- RTE_FLOW_ACTION_TYPE_SET_MAC_DST
The corresponding rte_flow_item_eth must be present in
rte_flow pattern
Only support modify outer layer MAC address
The example testpmd command is:
rte_flow actions:
- RTE_FLOW_ACTION_TYPE_SET_MAC_SRC
- RTE_FLOW_ACTION_TYPE_SET_MAC_DST
added in order to offload to NIC
The rte_flow_itme_eth must be present in rte_flow pattern
Signed-off-by: Xiaoyu Min
Acked-by: Yongseok Koh
Acked-by: Andrew Rybchenko
---
doc/guides/prog_guide/rte_flow.rst
add commands to support following actions:
- RTE_FLOW_ACTION_TYPE_SET_MAC_SRC
- RTE_FLOW_ACTION_TYPE_SET_MAC_DST
Signed-off-by: Xiaoyu Min
Acked-by: Yongseok Koh
---
app/test-pmd/cmdline_flow.c | 50 +
doc/guides/testpmd_app_ug/testpmd_funcs.rst | 8
2
This series is for RFC[1] and depends on patch[2]
Patch 1 adds generic MAC address rewrite actions to flow API
Patch 2 adds testpmd commands for that
Patch 3 offloads these actions on Mellanox MLX5 by using E-Switch rule
[1]: https://patches.dpdk.org/patch/44005/
[2]: https://patches.dpdk.org/pat
rewrite TTL by decrease or just set it directly
it's not necessary to check if the final result
is zero or not
This is slightly different from the one defined
by openflow and more generic
Signed-off-by: Xiaoyu Min
Acked-by: Yongseok Koh
---
doc/guides/prog_guide/rte_flow.rst | 30 +
add commands which supports following TTL actions:
- RTE_FLOW_ACTION_TYPE_DEC_TTL
- RTE_FLOW_ACTION_TYPE_SET_TTL
Signed-off-by: Xiaoyu Min
Acked-by: Yongseok Koh
---
app/test-pmd/cmdline_flow.c | 34 +
doc/guides/testpmd_app_ug/testpmd_funcs.rst | 5 +++
2 f
Offload following modify TTL actions to E-Switch via
TC-Flower driver
- RTE_FLOW_ACTION_TYPE_SET_TTL
- RTE_FLOW_ACTION_TYPE_DEC_TTL
The corresponding IP protocol rte_flow_item_ipv[4|6]
must be present in rte_flow pattern otherwith PMD
return error
The example testpmd commands are:
flow crea
1 - 100 of 193 matches
Mail list logo
