[dpdk-dev] [PATCH v2 8/9] app/procinfo: add code for debug mempool

2018-10-23 Thread Vipin Varghese
Function debug_mempool is used for displaying the MEMPOOL of the primary process. For valid mempool name elements are iterated for max of 256 bytes. Signed-off-by: Vipin Varghese --- app/proc-info/main.c | 47 +++- 1 file changed, 46 insertions(+), 1 delet

[dpdk-dev] [PATCH v2 4/9] app/procinfo: add code for debug port

2018-10-23 Thread Vipin Varghese
Function debug_port is used for displaying the port PMD under the primary process. This covers basic and per queue configuration. Signed-off-by: Vipin Varghese --- app/proc-info/main.c | 113 ++- 1 file changed, 112 insertions(+), 1 deletion(-) diff --git

[dpdk-dev] [PATCH v2 7/9] app/procinfo: add code for debug ring

2018-10-23 Thread Vipin Varghese
Function debug_ring is used for displaying the RING of the primary process. Signed-off-by: Vipin Varghese --- app/proc-info/main.c | 29 - 1 file changed, 28 insertions(+), 1 deletion(-) diff --git a/app/proc-info/main.c b/app/proc-info/main.c index d48334bd0..a4cf9f

[dpdk-dev] [PATCH v2 9/9] doc/procinfo: add information for debug options

2018-10-23 Thread Vipin Varghese
Document update for debug options and inforamtion for PMD instances port, traffic manager, crypto, mempool and ring instances. Signed-off-by: Vipin Varghese --- doc/guides/tools/proc_info.rst | 31 +++ 1 file changed, 27 insertions(+), 4 deletions(-) diff --git a/doc

[dpdk-dev] [PATCH v2 6/9] app/procinfo: add code for debug crypto

2018-10-23 Thread Vipin Varghese
Function debug_crypto is used for displaying the crypto PMD under the primary process. Signed-off-by: Vipin Varghese --- app/proc-info/main.c | 70 +++- 1 file changed, 69 insertions(+), 1 deletion(-) diff --git a/app/proc-info/main.c b/app/proc-info/main

[dpdk-dev] [PATCH v2 5/9] app/procinfo: add code for debug tm

2018-10-23 Thread Vipin Varghese
Function debug_tm is used for displaying the tm PMD under the primary process. This covers basic and per node|level details. Signed-off-by: Vipin Varghese --- app/proc-info/main.c | 247 ++- 1 file changed, 246 insertions(+), 1 deletion(-) diff --git a/ap

[dpdk-dev] [PATCH v2 3/9] app/procinfo: add prototype for debug instances

2018-10-23 Thread Vipin Varghese
Add prototype and function calls for the debug functions. Signed-off-by: Vipin Varghese --- app/proc-info/main.c | 41 + 1 file changed, 41 insertions(+) diff --git a/app/proc-info/main.c b/app/proc-info/main.c index 0da148c8c..e2791aaab 100644 --- a/app/

[dpdk-dev] [PATCH v2 2/9] app/procinfo: add compare for new options

2018-10-23 Thread Vipin Varghese
Add code for new debug options to compare usage strings and set enable flag. Signed-off-by: Vipin Varghese --- app/proc-info/main.c | 30 ++ 1 file changed, 30 insertions(+) diff --git a/app/proc-info/main.c b/app/proc-info/main.c index b62b314b2..0da148c8c 100644 --

[dpdk-dev] [PATCH v2 1/9] app/procinfo: add usage for new debug

2018-10-23 Thread Vipin Varghese
Update the file with MACRO for stats border, usage text information and string comparision. Signed-off-by: Vipin Varghese --- app/proc-info/main.c | 16 +++- 1 file changed, 15 insertions(+), 1 deletion(-) diff --git a/app/proc-info/main.c b/app/proc-info/main.c index c20effa4f..b62

[dpdk-dev] [PATCH v2 2/2] ethdev: fix metadata documentation

2018-10-23 Thread Dekel Peled
Previous patch introduced the Tx metadata feature, with unnecessary restrictions on data entry. This fix updates the documentation, removing the data entry restrictions on metadata item. Fixes: aa0b9484eb5f ("ethdev: support metadata as flow rule criteria") Cc: dek...@mellanox.com --- v2: Restor

[dpdk-dev] [PATCH v2 1/2] app/testpmd: fix metadata API and Tx insertion

2018-10-23 Thread Dekel Peled
Previous patch introduces the Tx metadata feature, with unnecessary restrictions on data entry. It also used the metadata in txonly fwd engine only. This fix removes the data entry restrictions on metadata item. It also implements callback function to add the metadata in every Tx packet, sent by a

Re: [dpdk-dev] [PATCH v7] net/mlx5: support metadata as flow rule criteria

2018-10-23 Thread Shahaf Shuler
Hi Ferruh, This patch contains a fix for compilation on top of arm. I hopped to replace between the existing "support metadata as flow rule criteria" to this one before you take it, but I was too late. Can you please replace the old patch with this one? Otherwise we will provide a separate fix p

Re: [dpdk-dev] [PATCH 2/2] ethdev: fix metadata documentation

2018-10-23 Thread Dekel Peled
> -Original Message- > From: Ori Kam > Sent: Tuesday, October 23, 2018 9:06 PM > To: Dekel Peled ; wenzhuo...@intel.com; > jingjing...@intel.com; bernard.iremon...@intel.com; > olivier.m...@6wind.com; Adrien Mazarguil ; > Thomas Monjalon ; ferruh.yi...@intel.com; > arybche...@solarflare.

[dpdk-dev] [PATCH] common/dpaax: fix incorrect error case

2018-10-23 Thread Shreyansh Jain
In case the memory for nodes cannot be allocated, there is no need to check for the length. Also, `node_count` is an unsigned value and cannot be less than 0. Coverity issue: 323521 Fixes: 2f3d633aa593 ("common/dpaax: add library for PA/VA translation table") Cc: shreyansh.j...@nxp.com Signed-of

Re: [dpdk-dev] [PATCH v1 1/9] app/procinfo: add usage for new debug

2018-10-23 Thread Varghese, Vipin
Hi Stephen, > > > + " --dbg-port to display information for all available ports\n" > > + " --dbg-tm to display information for traffic manager\n" > > + " --dbg-crypto to display information for crypto\n" > > + " --dbg-ring[=name] to display informatio

[dpdk-dev] [PATCH] raw/skeleton_rawdev: fix memory leak on test failure

2018-10-23 Thread Shreyansh Jain
In skeleton_rawdev unit tests, a malloc'd memory was leaking in case the next sequential test fails. This fix moves the free of the malloc'd memory above the failing test. Coverity issue: 260402 Fixes: 55ca1b0f2151 ("raw/skeleton: add test cases") Cc: shreyansh.j...@nxp.com Signed-off-by: Shreya

[dpdk-dev] [PATCH] doc/rel-notes: lock-free RW concurrency in hash

2018-10-23 Thread Honnappa Nagarahalli
Add lock-free reader/writer concurrency capability in rte_hash library to release notes. Signed-off-by: Honnappa Nagarahalli Reviewed-by: Gavin Hu --- doc/guides/rel_notes/release_18_11.rst | 5 + 1 file changed, 5 insertions(+) diff --git a/doc/guides/rel_notes/release_18_11.rst b/doc/gu

[dpdk-dev] [PATCH] pci_vfio: Support 64KB kernel page_size with vfio-pci driver

2018-10-23 Thread tone.zhang
With a larger PAGE_SIZE it is possible for the MSI table to very close to the end of the BAR s.t. when we align the MSI table to the PAGE_SIZE, the end offset of the MSI table is out the PCI BAR boundary. This patch addresses the issue by comparing both the start and the end offset of the MSI tabl

[dpdk-dev] [PATCH v6 3/5] hash: fix key store element alignment

2018-10-23 Thread Honnappa Nagarahalli
Fix the key store array element alignment such that every array element is aligned on KEY_ALIGNMENT boundary. This is required to make 'pdata' in 'struct rte_hash_key' align on its natural boundary for atomic load/store. Fixes: 473d1bebce43 ("hash: allow to store data in hash table") Cc: Pablo de

[dpdk-dev] [PATCH v6 5/5] test/hash: read-write lock-free concurrency test

2018-10-23 Thread Honnappa Nagarahalli
From: Dharmik Thakkar Unit tests to check for hash lookup and bulk-lookup perf with lock-free enabled and with lock-free disabled. Unit tests performed with readers running in parallel with writers. Tests include: - hash lookup on existing keys with: - hash add causing NO key-shifts of existi

[dpdk-dev] [PATCH v6 4/5] hash: add lock-free read-write concurrency

2018-10-23 Thread Honnappa Nagarahalli
Add lock-free read-write concurrency. This is achieved by the following changes. 1) Add memory ordering to avoid race conditions. The only race condition that can occur is - using the key store element before the key write is completed. Hence, while inserting the element the release memory order

[dpdk-dev] [PATCH v6 2/5] hash: support do not free on delete

2018-10-23 Thread Honnappa Nagarahalli
rte_hash_lookup_xxx APIs return the index of slot in the key store. Application(reader) can use that index to reference other data structures in its scope. Because of this, the index should not be freed till the application completes using the index. RTE_HASH_EXTRA_FLAGS_NO_FREE_ON_DEL is introduce

[dpdk-dev] [PATCH v6 1/5] hash: separate multi-writer from rw-concurrency

2018-10-23 Thread Honnappa Nagarahalli
RW concurrency is required with single writer and multiple reader usecase as well. Hence, multi-writer should not be enabled by default when RW concurrency is enabled. Fixes: f2e3001b53ec ("hash: support read/write concurrency") Cc: yipeng1.w...@intel.com Signed-off-by: Honnappa Nagarahalli Revi

[dpdk-dev] [PATCH v6 0/5] Address reader-writer concurrency in rte_hash

2018-10-23 Thread Honnappa Nagarahalli
This patch has dependency on the following patches in the order: http://patchwork.dpdk.org/cover/45611/ http://patchwork.dpdk.org/patch/47196/ Currently, reader-writer concurrency problems in rte_hash are addressed using reader-writer locks. Use of reader-writer locks resul

[dpdk-dev] [PATCH] common/qat: fix for invalid response from firmware

2018-10-23 Thread Fiona Trahe
Check that the firmware response has a bit set indicating it's valid before dereferencing the rest of the response contents. Fixes: 0bdd36e12245 ("crypto/qat: make dequeue function generic") Cc: sta...@dpdk.org Signed-off-by: Fiona Trahe --- drivers/common/qat/qat_qp.c | 8 1 file chan

Re: [dpdk-dev] [PATCH] eal: fix floating device argument pointer

2018-10-23 Thread Gaƫtan Rivet
Hi, On Mon, Oct 22, 2018 at 09:25:22AM +0200, Thomas Monjalon wrote: > 22/10/2018 07:49, Qi Zhang: > > After we insert a devargs into devargs_list, following bus->scan may > > destroy it due to another rte_devargs_insert. Its better not to use > > a devargs pointer after it has been inserted. >

Re: [dpdk-dev] [PATCH v3 4/4] ethdev: support MAC address as iterator filter

2018-10-23 Thread Ananyev, Konstantin
> > 23/10/2018 10:33, Ananyev, Konstantin: > > From: Thomas Monjalon [mailto:tho...@monjalon.net] > > > 22/10/2018 23:24, Ananyev, Konstantin: > > > > From: Thomas Monjalon > > > > > 22/10/2018 15:37, Andrew Rybchenko: > > > > > > On 10/22/18 4:15 PM, Thomas Monjalon wrote: > > > > > > > The MA

[dpdk-dev] [PATCH] build: disable compiler AVX512F support

2018-10-23 Thread Yongseok Koh
This is a workaround to prevent a crash, which might be caused by optimization of newer gcc (7.3.0) on Intel Skylake. Bugzilla ID: 97 Cc: sta...@dpdk.org Signed-off-by: Yongseok Koh --- config/x86/meson.build | 5 + mk/rte.cpuflags.mk | 5 + 2 files changed, 10 insertions(+) diff

Re: [dpdk-dev] [PATCH] net/ixgbe: fix RSS flow return error

2018-10-23 Thread Zhang, Qi Z
> -Original Message- > From: Zhao1, Wei > Sent: Monday, October 22, 2018 10:38 PM > To: dev@dpdk.org > Cc: Zhang, Qi Z ; sta...@dpdk.org; Peng, Yuan > ; Zhao1, Wei > Subject: [PATCH] net/ixgbe: fix RSS flow return error > > If hash function is 0, it should disable RSS then return 0. >

Re: [dpdk-dev] [PATCH] net/i40e: cancel alarm handler at the end of device closure

2018-10-23 Thread Zhang, Qi Z
> -Original Message- > From: Xing, Beilei > Sent: Tuesday, October 23, 2018 2:10 AM > To: Ye, Xiaolong ; Zhang, Qi Z > > Cc: dev@dpdk.org; sta...@dpdk.org > Subject: RE: [PATCH] net/i40e: cancel alarm handler at the end of device > closure > > > > > -Original Message- > > Fro

Re: [dpdk-dev] [PATCH v1] net/i40e: enable the loopback function if it is X722 MAC

2018-10-23 Thread Zhang, Qi Z
> -Original Message- > From: Wang, Haiyue > Sent: Monday, October 22, 2018 2:48 AM > To: dev@dpdk.org; Zhang, Qi Z ; Wu, Jingjing > ; Lu, Wenzhuo > Cc: Chilikin, Andrey ; Wang, Haiyue > > Subject: [PATCH v1] net/i40e: enable the loopback function if it is X722 MAC > > In FVL, there wa

[dpdk-dev] [PATCH v7] net/mlx5: support metadata as flow rule criteria

2018-10-23 Thread Dekel Peled
As described in series starting at [1], it adds option to set metadata value as match pattern when creating a new flow rule. This patch adds metadata support in mlx5 driver, in two parts: - Add the validation and setting of metadata value in matcher, when creating a new flow rule. - Add the pass

[dpdk-dev] [PATCH v4 2/3] net/mlx5: release port on close

2018-10-23 Thread Ophir Munk
With the introduction of representors several eth devices are using the same rte device (e.g. a PCI bus). It is therefore required to release the eth device resources during an eth device close operation rather than during an rte device removal (detach) operation. In current version many PMDs are s

[dpdk-dev] [PATCH v4 1/3] net/mlx5: allow multiple probing for representor

2018-10-23 Thread Ophir Munk
Implement probing of a rte device multiple times, see [1]. Set PCI driver RTE_PCI_DRV_PROBE_AGAIN flag to enable multiple probing of the PCI device by the PCI common driver. Consecutive probing requests with a devargs string may contain repetitive master and representors devices for which eth devic

[dpdk-dev] [PATCH v4 3/3] net/mlx5: close all ports on remove

2018-10-23 Thread Ophir Munk
With the introduction of representors several eth devices are using the same rte device (e.g. a PCI bus). When calling port detach on one eth device it is required that all eth devices belonging to the same rte device have been closed in advance, then the rte device itself can be removed/detached.

Re: [dpdk-dev] [PATCH 2/2] ethdev: fix metadata documentation

2018-10-23 Thread Ori Kam
> -Original Message- > From: dev On Behalf Of Dekel Peled > Sent: Tuesday, October 23, 2018 4:29 PM > To: wenzhuo...@intel.com; jingjing...@intel.com; > bernard.iremon...@intel.com; olivier.m...@6wind.com; Adrien Mazarguil > ; Thomas Monjalon ; > ferruh.yi...@intel.com; arybche...@solar

[dpdk-dev] [Bug 97] rte_memcpy() moves data incorrectly on Ubuntu 18.04 on Intel Skylake

2018-10-23 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=97 Bug ID: 97 Summary: rte_memcpy() moves data incorrectly on Ubuntu 18.04 on Intel Skylake Product: DPDK Version: 18.08 Hardware: x86 OS: Linux Status: CONF

Re: [dpdk-dev] [PATCH 4/5] net/mlx5: fix wildcard item for Direct Verbs

2018-10-23 Thread Yongseok Koh
On Tue, Oct 23, 2018 at 08:25:15AM -0700, Ori Kam wrote: > PSB > > > -Original Message- > > From: Shahaf Shuler > > Sent: Tuesday, October 23, 2018 10:42 AM > > To: Yongseok Koh > > Cc: dev@dpdk.org; Ori Kam > > Subject: RE: [PATCH 4/5] net/mlx5: fix wildcard item for Direct Verbs > > >

[dpdk-dev] [PATCH v2 4/5] net/mlx5: fix wildcard item for Direct Verbs

2018-10-23 Thread Yongseok Koh
If a network layer is specified with no spec, it means wildcard match. flow_dv_translate_item_*() returns without writing anything if spec is null and it causes creation of wrong flow. E.g., the following flow has to patch with any ipv4 packet. flow create 0 ingress pattern eth / ipv4 / end acti

[dpdk-dev] [PATCH v2 5/5] net/mlx5: fix flow mark ID conversion in Direct Verbs

2018-10-23 Thread Yongseok Koh
Fixes: d02cb0691299 ("net/mlx5: add Direct Verbs translate actions") Cc: or...@mellanox.com Signed-off-by: Yongseok Koh Acked-by: Ori Kam --- drivers/net/mlx5/mlx5_flow_dv.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/net/mlx5/mlx5_flow_dv.c b/drivers/net/

[dpdk-dev] [PATCH v2 3/5] net/mlx5: fix item validation in Direct Verbs

2018-10-23 Thread Yongseok Koh
1) remove MPLS item in validation as it doesn't have a translator. 2) add missing NVGRE item to validation 3) match switch-case order between validation and translation. Fixes: fc2c498ccb94 ("net/mlx5: add Direct Verbs translate items") Fixes: 3d69434113d1 ("net/mlx5: add Direct Verbs validation

[dpdk-dev] [PATCH v2 2/5] net/mlx5: fix UDP hash field flag in Direct Verbs

2018-10-23 Thread Yongseok Koh
Fixes: fc2c498ccb94 ("net/mlx5: add Direct Verbs translate items") Cc: or...@mellanox.com Signed-off-by: Yongseok Koh Acked-by: Ori Kam --- drivers/net/mlx5/mlx5_flow_dv.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/mlx5/mlx5_flow_dv.c b/drivers/net/mlx

[dpdk-dev] [PATCH v2 0/5] net/mlx5: fixes for Direct Verbs flow

2018-10-23 Thread Yongseok Koh
v2: * rebase on top of the new branch tip Yongseok Koh (5): net/mlx5: add warning message for Direct Verbs flow net/mlx5: fix UDP hash field flag in Direct Verbs net/mlx5: fix item validation in Direct Verbs net/mlx5: fix wildcard item for Direct Verbs net/mlx5: fix flow mark ID convers

[dpdk-dev] [PATCH v2 1/5] net/mlx5: add warning message for Direct Verbs flow

2018-10-23 Thread Yongseok Koh
In case that the library doesn't support DV flow, if enabled by 'dv_flow_en=1', print out a warning message and disable it. Fixes: 51e72d386c99 ("net/mlx5: add runtime parameter to enable Direct Verbs") Cc: or...@mellanox.com Signed-off-by: Yongseok Koh Acked-by: Ori Kam --- drivers/net/mlx5/m

[dpdk-dev] [PATCH] eal: don't double space init alert messages

2018-10-23 Thread Stephen Hemminger
rte_init_alert already adds a newline, don't do it twice. Signed-off-by: Stephen Hemminger --- lib/librte_eal/bsdapp/eal/eal.c | 24 lib/librte_eal/linuxapp/eal/eal.c | 28 ++-- 2 files changed, 26 insertions(+), 26 deletions(-) diff --git a/li

[dpdk-dev] [PATCH] kvargs: fix processing a null list

2018-10-23 Thread Thomas Monjalon
In the doxygen description of rte_kvargs_process(), it is said: If *kvlist* is NULL function does nothing. It has been added by mistake here instead of rte_kvargs_free(). Anyway, null list should be correctly handled in both functions. Comments are fixed in both functions and NULL handling

[dpdk-dev] errors from VHOST on shutdown.

2018-10-23 Thread Stephen Hemminger
I get errors on shutdown of application using virtio-user. For example, quitting testpmd: Detaching a port... vhost_kernel_set_backend(): VHOST_NET_SET_BACKEND fails, Operation not permitted vhost_kernel_set_backend(): VHOST_NET_SET_BACKEND fails, Operation not permitted vhost_kernel_ioctl(): VHOS

Re: [dpdk-dev] [PATCH v5 5/5] test/hash: read-write lock-free concurrency test

2018-10-23 Thread Honnappa Nagarahalli
> > > > --- > > > > > > Does this need to be done via a completely new test case? Given the > > > number of unit tests for the hash table structure, I'm wondering if > > > we can consolidate things a bit. Any thoughts? > > > > > Are you concerned about new test case or new test case file? > > From

Re: [dpdk-dev] [PATCH 4/5] net/mlx5: fix wildcard item for Direct Verbs

2018-10-23 Thread Ori Kam
PSB > -Original Message- > From: Shahaf Shuler > Sent: Tuesday, October 23, 2018 10:42 AM > To: Yongseok Koh > Cc: dev@dpdk.org; Ori Kam > Subject: RE: [PATCH 4/5] net/mlx5: fix wildcard item for Direct Verbs > > Wednesday, October 17, 2018 5:08 AM, Yongseok Koh: > > Subject: [PATCH 4/5

Re: [dpdk-dev] [PATCH v1 1/9] app/procinfo: add usage for new debug

2018-10-23 Thread Stephen Hemminger
On Tue, 23 Oct 2018 19:27:43 +0530 Vipin Varghese wrote: > + " --dbg-port to display information for all available ports\n" > + " --dbg-tm to display information for traffic manager\n" > + " --dbg-crypto to display information for crypto\n" > + "

Re: [dpdk-dev] [PATCH v5 5/5] test/hash: read-write lock-free concurrency test

2018-10-23 Thread Bruce Richardson
On Tue, Oct 23, 2018 at 02:15:30PM +, Honnappa Nagarahalli wrote: > Hi Bruce, > Thank you for the review. > > > > - hash lookup on existing keys NOT likely to be on shift-path with: > > > - hash add causing key-shifts of existing keys in the table > > > > > > - hash lookup on non-exist

Re: [dpdk-dev] [PATCH v5 5/5] test/hash: read-write lock-free concurrency test

2018-10-23 Thread Honnappa Nagarahalli
Hi Bruce, Thank you for the review. > > - hash lookup on existing keys NOT likely to be on shift-path with: > > - hash add causing key-shifts of existing keys in the table > > > > - hash lookup on non-existing keys with: > > - hash add causing NO key-shifts of existing keys in the tabl

Re: [dpdk-dev] [PATCH v2] app/testpmd: support more types for flow RSS

2018-10-23 Thread Ferruh Yigit
On 10/23/2018 11:11 AM, Iremonger, Bernard wrote: >> -Original Message- >> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Wei Zhao >> Sent: Tuesday, October 23, 2018 10:21 AM >> To: dev@dpdk.org >> Cc: Zhang, Qi Z ; sta...@dpdk.org; Peng, Yuan >> ; Zhao1, Wei >> Subject: [dpdk-dev] [

Re: [dpdk-dev] [PATCH v7 0/7] replace attach/detach functions

2018-10-23 Thread Ferruh Yigit
On 10/23/2018 9:28 AM, Thomas Monjalon wrote: > The functions for EAL attach/detach had already some replacements, > so they are removed. > The functions for ethdev attach/detach are removed and replaced > thanks to a new ethdev iterator working with devargs. > > rte_eth_dev_attach(devargs, &p

Re: [dpdk-dev] [PATCH v7 7/7] app/testpmd: check not detaching device twice

2018-10-23 Thread Ferruh Yigit
On 10/23/2018 1:37 PM, Thomas Monjalon wrote: > I want to submit two more patches to clean testpmd for attach/detach. > > I propose to drop this patch from this series, > and I will submit a new series dedicated to testpmd cleanup, > including this patch. Got the set without this patch, please se

[dpdk-dev] [PATCH v1 9/9] doc/proc_info: add information for debug options

2018-10-23 Thread Vipin Varghese
Document update for debug options and inforamtion for PMD instances port, traffic manager, crypto, mempool and ring isntances. Signed-off-by: Vipin Varghese --- doc/guides/tools/proc_info.rst | 31 +++ 1 file changed, 27 insertions(+), 4 deletions(-) diff --git a/doc

[dpdk-dev] [PATCH v1 8/9] app/procinfo: add code for debug mempool

2018-10-23 Thread Vipin Varghese
Function debug_mempool is used for displaying the MEMPOOL of the primary process. For valid mempool name elements are iterated for max of 256 bytes. Signed-off-by: Vipin Varghese --- app/proc-info/main.c | 47 +++- 1 file changed, 46 insertions(+), 1 delet

[dpdk-dev] [PATCH v1 7/9] app/procinfo: add code for debug ring

2018-10-23 Thread Vipin Varghese
Function debug_ring is used for displaying the RING of the primary process. Signed-off-by: Vipin Varghese --- app/proc-info/main.c | 29 - 1 file changed, 28 insertions(+), 1 deletion(-) diff --git a/app/proc-info/main.c b/app/proc-info/main.c index 0f2045858..f8b28d

[dpdk-dev] [PATCH v1 5/9] app/procinfo: add code for debug tm

2018-10-23 Thread Vipin Varghese
Function debug_tm is used for displaying the tm PMD under the primary process. This covers basic and per node|level details. Signed-off-by: Vipin Varghese --- app/proc-info/main.c | 247 ++- 1 file changed, 246 insertions(+), 1 deletion(-) diff --git a/ap

[dpdk-dev] [PATCH v1 4/9] app/procinfo: add code for debug port

2018-10-23 Thread Vipin Varghese
Function debug_port is used for displaying the port PMD under the primary process. This covers basic and per queue configuration. Signed-off-by: Vipin Varghese --- app/proc-info/main.c | 113 ++- 1 file changed, 112 insertions(+), 1 deletion(-) diff --git

[dpdk-dev] [PATCH v1 6/9] app/procinfo: add code for debug crypto

2018-10-23 Thread Vipin Varghese
Function debug_crypto is used for displaying the crypto PMD under the primary process. Signed-off-by: Vipin Varghese --- app/proc-info/main.c | 70 +++- 1 file changed, 69 insertions(+), 1 deletion(-) diff --git a/app/proc-info/main.c b/app/proc-info/main

[dpdk-dev] [PATCH v1 3/9] app/procinfo: add prototype for debug instances

2018-10-23 Thread Vipin Varghese
Add prototype and function calls for the debug functions. Signed-off-by: Vipin Varghese --- app/proc-info/main.c | 41 + 1 file changed, 41 insertions(+) diff --git a/app/proc-info/main.c b/app/proc-info/main.c index 5505d3fe3..5511fcb71 100644 --- a/app/

[dpdk-dev] [PATCH v1 1/9] app/procinfo: add usage for new debug

2018-10-23 Thread Vipin Varghese
Update the file with MACRO for stats border, usage text information and string comparision. Signed-off-by: Vipin Varghese --- app/proc-info/main.c | 16 +++- 1 file changed, 15 insertions(+), 1 deletion(-) diff --git a/app/proc-info/main.c b/app/proc-info/main.c index c20effa4f..928

[dpdk-dev] [PATCH v1 2/9] app/procinfo: add compare for new options

2018-10-23 Thread Vipin Varghese
Add code for new debug options to compare usage strings and set enable flag. Signed-off-by: Vipin Varghese --- app/proc-info/main.c | 30 ++ 1 file changed, 30 insertions(+) diff --git a/app/proc-info/main.c b/app/proc-info/main.c index 92854f5ba..5505d3fe3 100644 --

[dpdk-dev] [PATCH 2/2] ethdev: fix metadata documentation

2018-10-23 Thread Dekel Peled
Previous patch introduced the Tx metadata feature, with unnecessary restrictions on data entry. This fix updates the documentation, removing the data entry restrictions on metadata item. Fixes: aa0b9484eb5f ("ethdev: support metadata as flow rule criteria") Cc: dek...@mellanox.com Signed-off-by:

[dpdk-dev] [PATCH 1/2] app/testpmd: fix metadata API and Tx insertion

2018-10-23 Thread Dekel Peled
Previous patch introduces the Tx metadata feature, with unnecessary restrictions on data entry. It also used the metadata in txonly fwd engine only. This fix removes the data entry restrictions on metadata item. It also implements callback function to add the metadata in every Tx packet, sent by a

Re: [dpdk-dev] [PATCH v3 2/5] test: add quick run tests under test-fast suite

2018-10-23 Thread Pattan, Reshma
Hi, > -Original Message- > From: Vemula, Hari KumarX > Sent: Tuesday, October 23, 2018 12:01 PM > To: dev@dpdk.org > Cc: Richardson, Bruce ; Pattan, Reshma > ; Vemula, Hari KumarX > > Subject: [PATCH v3 2/5] test: add quick run tests under test-fast suite > > From: Hari Kumar Vemula >

[dpdk-dev] [PATCH] drivers: fix compilation if security disabled

2018-10-23 Thread Akhil Goyal
RTE_SECURITY is enabled by default. If it is disabled, dpaa2_sec, dpaa_sec and caam_jr compilation fails. This patch fixes compilation by disabling these drivers when rte_security is not available. Fixes: 1ee9569576f6 ("config: enable dpaaX drivers for generic ARMv8") Fixes: 09e1e8d256b0 ("mk: fi

[dpdk-dev] [PATCH] crypto/caam_jr: fix redefinition error

2018-10-23 Thread Gagandeep Singh
dma_addr_t is already defined in compat.h. so removing the local definition from caam_jr_config.h Fixes: b70a67ab70 ("crypto/caam_jr: add HW tuning options") Signed-off-by: Gagandeep Singh --- drivers/crypto/caam_jr/caam_jr_config.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) dif

Re: [dpdk-dev] [PATCH v7 7/7] app/testpmd: check not detaching device twice

2018-10-23 Thread Iremonger, Bernard
Hi Thomas > Subject: Re: [dpdk-dev] [PATCH v7 7/7] app/testpmd: check not detaching > device twice > > 23/10/2018 14:03, Thomas Monjalon: > > 23/10/2018 12:01, Iremonger, Bernard: > > > From: Thomas Monjalon [mailto:tho...@monjalon.net] > > > > The command "port detach" is removing the EAL rte_d

Re: [dpdk-dev] [dpdk-stable] [PATCH v2] vhost: avoid memory barriers when no descriptors dequeued

2018-10-23 Thread Jens Freimann
On Tue, Oct 23, 2018 at 12:07:10PM +0200, Maxime Coquelin wrote: In both split and packed dequeue paths, flush_shadow_used_ring and vhost_ring_call variants gets called even if not packets have been dequeued, and so no descriptors updates happened. It has an impact on CPU pipeline, as memory bar

Re: [dpdk-dev] [PATCH v7 7/7] app/testpmd: check not detaching device twice

2018-10-23 Thread Thomas Monjalon
I want to submit two more patches to clean testpmd for attach/detach. I propose to drop this patch from this series, and I will submit a new series dedicated to testpmd cleanup, including this patch. 23/10/2018 14:13, Thomas Monjalon: > 23/10/2018 14:03, Thomas Monjalon: > > 23/10/2018 12:01, Ir

Re: [dpdk-dev] [PATCH v6] net/mlx5: support metadata as flow rule criteria

2018-10-23 Thread Shahaf Shuler
Tuesday, October 23, 2018 1:48 PM, Dekel Peled: > Subject: [PATCH v6] net/mlx5: support metadata as flow rule criteria > > As described in series starting at [1], it adds option to set metadata value > as > match pattern when creating a new flow rule. > > This patch adds metadata support in mlx5

Re: [dpdk-dev] [PATCH v7 7/7] app/testpmd: check not detaching device twice

2018-10-23 Thread Thomas Monjalon
23/10/2018 14:03, Thomas Monjalon: > 23/10/2018 12:01, Iremonger, Bernard: > > From: Thomas Monjalon [mailto:tho...@monjalon.net] > > > The command "port detach" is removing the EAL rte_device of the ethdev > > > port specified as parameter. > > > > > > After detaching, the pointer, which maps a p

Re: [dpdk-dev] [PATCH] drivers/raw/ifpga_rawdev: fix coverity issue 323508

2018-10-23 Thread Ferruh Yigit
On 10/23/2018 11:43 AM, Shreyansh Jain wrote: > On Tuesday 23 October 2018 03:21 PM, Ferruh Yigit wrote: >> On 10/23/2018 8:09 AM, Shreyansh Jain wrote: >>> Besides the comment I sent before about 'Fixes' before sign-off, a >>> single trivial comment inline ... >>> >>> On Tuesday 23 October 2018 07

Re: [dpdk-dev] [PATCH v7 7/7] app/testpmd: check not detaching device twice

2018-10-23 Thread Thomas Monjalon
23/10/2018 12:01, Iremonger, Bernard: > From: Thomas Monjalon [mailto:tho...@monjalon.net] > > The command "port detach" is removing the EAL rte_device of the ethdev > > port specified as parameter. > > > > After detaching, the pointer, which maps a port to its device, is resetted. > > This > >

Re: [dpdk-dev] [PATCH v5 5/5] test/hash: read-write lock-free concurrency test

2018-10-23 Thread Bruce Richardson
On Mon, Oct 22, 2018 at 11:22:04PM -0500, Honnappa Nagarahalli wrote: > From: Dharmik Thakkar > > Unit tests to check for hash lookup and bulk-lookup perf > with lock-free enabled and with lock-free disabled. > Unit tests performed with readers running in parallel with writers. > > Tests include

Re: [dpdk-dev] [PATCH v5 5/5] test/hash: read-write lock-free concurrency test

2018-10-23 Thread Bruce Richardson
On Mon, Oct 22, 2018 at 11:22:04PM -0500, Honnappa Nagarahalli wrote: > From: Dharmik Thakkar > > Unit tests to check for hash lookup and bulk-lookup perf > with lock-free enabled and with lock-free disabled. > Unit tests performed with readers running in parallel with writers. > > Tests include

Re: [dpdk-dev] [PATCH v5 4/5] hash: add lock-free read-write concurrency

2018-10-23 Thread Bruce Richardson
On Mon, Oct 22, 2018 at 11:22:03PM -0500, Honnappa Nagarahalli wrote: > Add lock-free read-write concurrency. This is achieved by the > following changes. > > 1) Add memory ordering to avoid race conditions. The only race > condition that can occur is - using the key store element > before the ke

[dpdk-dev] [PATCH v3 5/5] test: add dump test cases under test-dump suite

2018-10-23 Thread Hari kumar Vemula
From: Hari Kumar Vemula Grouped logging or dump related test cases to test-dump category Signed-off-by: Hari Kumar Vemula --- test/test/meson.build | 21 + 1 file changed, 21 insertions(+) diff --git a/test/test/meson.build b/test/test/meson.build index a727cf461..9132ad0c

[dpdk-dev] [PATCH v3 4/5] test: add library dependent tests under test-driver suite

2018-10-23 Thread Hari kumar Vemula
From: Hari Kumar Vemula Added test cases that depend on library as cryptodev Signed-off-by: Hari Kumar Vemula --- test/test/meson.build | 27 +++ 1 file changed, 27 insertions(+) diff --git a/test/test/meson.build b/test/test/meson.build index 70a4c6bed..a727cf461 1006

[dpdk-dev] [PATCH v3 1/5] test: remove existing testcases for categorization

2018-10-23 Thread Hari kumar Vemula
From: Hari Kumar Vemula Removed testcase list from meson build to categorize testcases into suites Signed-off-by: Hari Kumar Vemula --- test/test/meson.build | 111 -- 1 file changed, 111 deletions(-) diff --git a/test/test/meson.build b/test/te

[dpdk-dev] [PATCH v3 2/5] test: add quick run tests under test-fast suite

2018-10-23 Thread Hari kumar Vemula
From: Hari Kumar Vemula Added test cases that runs quickly under test fast category Signed-off-by: Hari Kumar Vemula --- test/test/meson.build | 99 --- 1 file changed, 94 insertions(+), 5 deletions(-) diff --git a/test/test/meson.build b/test/t

[dpdk-dev] [PATCH v3 3/5] test: add performance tests under test-perf suite

2018-10-23 Thread Hari kumar Vemula
From: Hari Kumar Vemula Grouped performace test cases under test-perf category Signed-off-by: Hari Kumar Vemula --- test/test/meson.build | 34 ++ 1 file changed, 34 insertions(+) diff --git a/test/test/meson.build b/test/test/meson.build index 825e84fce..70a4c

[dpdk-dev] [PATCH v3 0/5] create different meson test targets

2018-10-23 Thread Hari kumar Vemula
From: Hari Kumar Vemula 1/5: remove existing test cases to reorganize further 2/5: add test-fast suite to meson targets 3/5: add test-perf suite to meson targets 4/5: add test-driver suite to meson targets 5/5: add test-dump suite to meson targets -- v3: Updated testcase names in file prefix opt

[dpdk-dev] [PATCH v6] net/mlx5: support metadata as flow rule criteria

2018-10-23 Thread Dekel Peled
As described in series starting at [1], it adds option to set metadata value as match pattern when creating a new flow rule. This patch adds metadata support in mlx5 driver, in two parts: - Add the validation and setting of metadata value in matcher, when creating a new flow rule. - Add the pass

Re: [dpdk-dev] [dpdk-users] IPV4/IPV6 TCP/UDP Pseudo Header Checksum APIs

2018-10-23 Thread Shyam Shrivastav
These fixes/modifications should include the upper level APIs, rte_ipv4_udptcp_cksum and rte_ipv6_udptcp_cksum. Even for ipv4 following API is more/really useful if changed to take mbufs rte_ipv4_udptcp_cksum(const struct ipv4_hdr *ipv4_hdr, const void *l4_hdr) I can not use it in present form a

Re: [dpdk-dev] [PATCH] drivers/raw/ifpga_rawdev: fix coverity issue 323508

2018-10-23 Thread Shreyansh Jain
On Tuesday 23 October 2018 03:21 PM, Ferruh Yigit wrote: > On 10/23/2018 8:09 AM, Shreyansh Jain wrote: >> Besides the comment I sent before about 'Fixes' before sign-off, a >> single trivial comment inline ... >> >> On Tuesday 23 October 2018 07:20 AM, Rosen Xu wrote: >>> This patch fixes rte_eal_

Re: [dpdk-dev] [PATCH v5 3/5] hash: fix key store element alignment

2018-10-23 Thread Bruce Richardson
On Mon, Oct 22, 2018 at 11:22:02PM -0500, Honnappa Nagarahalli wrote: > Fix the key store array element alignment such that every array > element is aligned on KEY_ALIGNMENT boundary. This is required to > make 'pdata' in 'struct rte_hash_key' align on its natural boundary > for atomic load/store.

Re: [dpdk-dev] [PATCH v5 2/5] hash: support do not free on delete

2018-10-23 Thread Bruce Richardson
On Mon, Oct 22, 2018 at 11:22:01PM -0500, Honnappa Nagarahalli wrote: > rte_hash_lookup_xxx APIs return the index of slot in > the key store. Application(reader) can use that index to reference > other data structures in its scope. Because of this, the > index should not be freed till the applicati

Re: [dpdk-dev] [PATCH v5 1/5] hash: separate multi-writer from rw-concurrency

2018-10-23 Thread Bruce Richardson
On Mon, Oct 22, 2018 at 11:22:00PM -0500, Honnappa Nagarahalli wrote: > RW concurrency is required with single writer and multiple reader > usecase as well. Hence, multi-writer should not be enabled by default when > RW concurrency is enabled. > > Fixes: f2e3001b53ec ("hash: support read/write con

Re: [dpdk-dev] [PATCH v2] app/testpmd: support more types for flow RSS

2018-10-23 Thread Iremonger, Bernard
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Wei Zhao > Sent: Tuesday, October 23, 2018 10:21 AM > To: dev@dpdk.org > Cc: Zhang, Qi Z ; sta...@dpdk.org; Peng, Yuan > ; Zhao1, Wei > Subject: [dpdk-dev] [PATCH v2] app/testpmd: support more types for flow > RSS

[dpdk-dev] [PATCH v2] vhost: avoid memory barriers when no descriptors dequeued

2018-10-23 Thread Maxime Coquelin
In both split and packed dequeue paths, flush_shadow_used_ring and vhost_ring_call variants gets called even if not packets have been dequeued, and so no descriptors updates happened. It has an impact on CPU pipeline, as memory barriers are used in these functions. This patch don't call these fun

Re: [dpdk-dev] [PATCH v2 4/7] net/mlx5: e-switch VXLAN netlink routines update

2018-10-23 Thread Yongseok Koh
On Mon, Oct 15, 2018 at 02:13:32PM +, Viacheslav Ovsiienko wrote: > This part of patchset updates Netlink exchange routine. Message > sequence numbers became not random ones, the multipart reply messages > are supported, not propagating errors to the following socket calls, > Netlink replies bu

Re: [dpdk-dev] [PATCH v2 3/7] net/mlx5: e-switch VXLAN flow translation routine

2018-10-23 Thread Yongseok Koh
On Mon, Oct 15, 2018 at 02:13:31PM +, Viacheslav Ovsiienko wrote: > This part of patchset adds support of VXLAN-related items and > actions to the flow translation routine. If some of them are > specified in the rule, the extra space for tunnel description > structure is allocated. Later some t

[dpdk-dev] [PATCH v4 6/8] net/mlx5: add new flow counter Verbs API to glue library

2018-10-23 Thread Slava Ovsiienko
This patch updates the mlx5 glue library, new counter support Verbs function pointers are added to the glue linking structure mlx5_glue. This structure now contains the pointers to the both versions of counter supporting functions due to compatibility issues. Depending on configuration macros the f

Re: [dpdk-dev] [PATCH v2 2/7] net/mlx5: e-switch VXLAN flow validation routine

2018-10-23 Thread Yongseok Koh
On Mon, Oct 15, 2018 at 02:13:30PM +, Viacheslav Ovsiienko wrote: > This part of patchset adds support for flow item/action lists > validation. The following entities are now supported: > > - RTE_FLOW_ITEM_TYPE_VXLAN, contains the tunnel VNI > > - RTE_FLOW_ACTION_TYPE_VXLAN_DECAP, if this act

[dpdk-dev] [PATCH v4 8/8] net/mlx5: support new flow counter API

2018-10-23 Thread Slava Ovsiienko
This patch updates the functions performing the Verbs ibrary calls in order to support different versions of the library. The functions: - flow_verbs_counter_new() - flow_verbs_counter_release() - flow_verbs_counter_query() now have the several compilation branches, depending on the counters

[dpdk-dev] [PATCH v4 3/8] net/mlx5: introduce new flow counters configuration macro

2018-10-23 Thread Slava Ovsiienko
The new configuration macro HAVE_IBV_DEVICE_COUNTERS_SET_V45 is introduced. Both makefile and meson.build are changed. Flow counter support code depends on the following configuration macros: - HAVE_IBV_DEVICE_COUNTERS_SET_V42 - is defined if system supports the "old" flow counters functionalit

[dpdk-dev] [PATCH v4 4/8] net/mlx5: simplify flow counters support check

2018-10-23 Thread Slava Ovsiienko
The redundant check of Flow counters support in runtime is removed. The flag flow_counter_en is eliminated from the code. The Verbs create counter function just returns an error if no counter support presented in the system. If there is no any of Flow counters configuration macro defined the log m

  1   2   >