> > + printf("\t -- RSS len %u key (hex):",
>
> Why "(hex)" in printf?
In the follow up lines, we are disapplying the RSS key used in HEX values.
for (k = 0; k < rss_conf.rss_key_len; k++)
printf(" %x", rss_conf.rss_key[k]);
Thanks, I found the correction for the error. I will send the v3.
Since this information was missed out in ' 5.10. Checking Compilation' I will
send a separate patch trying to update documentation.
> -Original Message-
> From: Pattan, Reshma
> Sent: Thursday, October 25, 2018 9:51 PM
> T
Hi,
> ---
> + struct rte_cryptodev_info dev_info = {0};
> + struct rte_cryptodev_stats stats = {0};
> +
>
> Memset for initialization as mentioned in other patch.
>
Yes, I will correct the same as certain compiler flag combination will treat
this as incorrect use.
>
Hi Reshma,
>
> +"\t -- id (%u) flags (0x%"PRIx64") socket (%d)\n"
> +"\t -- queue pairs (%d)\n",
> +rte_cryptodev_name_get(i),
> +dev_info.driver_name, dev_info.driver_id,
> +dev_info.feature_f
When scanning an already plugged device, the virtual address
of mapped PCI resource in rte_pci_device will be overridden
with 0, that may cause driver does not work correctly.
The fix is not to update any rte_pci_device's field if the being
scanned device's driver is already probed.
Bugzilla ID: 8
> -Original Message-
> From: Ye, Xiaolong
> Sent: Friday, October 26, 2018 1:33 AM
> To: Zhang, Qi Z ; Xing, Beilei
> Cc: dev@dpdk.org; Ye, Xiaolong ; Kulasek, TomaszX
>
> Subject: [PATCH 2/2] net/i40e: correct offload not supported mask
>
> Just as the name I40E_TX_OFFLOAD_NOTSUP_MAS
> -Original Message-
> From: Zhang, Qi Z
> Sent: Wednesday, October 24, 2018 9:49 PM
> To: Lu, Wenzhuo
> Cc: Lin, Xueqin ; dev@dpdk.org; Zhang, Qi Z
>
> Subject: [PATCH] net/ixgbe: enable detach from secondary
>
> Since we have enabled the hotplug mechanism for multi-process, it's not
27/10/2018 04:19, Van Haaren, Harry:
> From: Thomas Monjalon [mailto:tho...@monjalon.net]
> > 27/10/2018 01:59, Harry van Haaren:
> > > --- a/mk/rte.vars.mk
> > > +++ b/mk/rte.vars.mk
> > > +JANSSON := $(shell pkg-config --exists jansson; echo $$?)
> > > +ifneq ($(JANSSON),0)
> > > +$(warning Janss
> -Original Message-
> From: Thomas Monjalon [mailto:tho...@monjalon.net]
> Sent: Friday, October 26, 2018 6:56 PM
> To: Van Haaren, Harry ; Laatz, Kevin
> ; Nicolau, Radu ; Hunt, David
>
> Cc: dev@dpdk.org; Richardson, Bruce ;
> step...@networkplumber.org; gaetan.ri...@6wind.com; shrey
27/10/2018 01:59, Harry van Haaren:
> --- a/mk/rte.vars.mk
> +++ b/mk/rte.vars.mk
> +JANSSON := $(shell pkg-config --exists jansson; echo $$?)
> +ifneq ($(JANSSON),0)
> +$(warning Jansson not found, disabling RTE_LIBRTE_TELEMETRY)
> +CONFIG_RTE_LIBRTE_TELEMETRY = n
> +endif
It fails for cross-comp
Fixed bad logic in rte_comp_op_alloc() checking return
value from rte_comp_op_raw_bulk_alloc(). This
could have resulted in a seg-fault in error case.
Made rte_comp_ob_bulk_alloc() code consistent
with rte_comp_op_alloc().
Fixes: 96086db5a369 ("compressdev: add operation management")
Cc: sta...@d
27/10/2018 02:17, Fiona Trahe:
> Fixed bad logic in rte_comp_op_alloc() checking return
> value from rte_comp_op_raw_bulk_alloc(). This
> could have resulted in a seg-fault in error case.
> Made rte_comp_ob_bulk_alloc() code consistent
> with rte_comp_op_alloc().
>
> Thanks to Sabyasachi Sengupta
Fixed bad logic in rte_comp_op_alloc() checking return
value from rte_comp_op_raw_bulk_alloc(). This
could have resulted in a seg-fault in error case.
Made rte_comp_ob_bulk_alloc() code consistent
with rte_comp_op_alloc().
Thanks to Sabyasachi Sengupta for pointing it out.
Fixes: 96086db5a369 ("c
24/10/2018 17:11, Kusztal, ArkadiuszX:
> From: Trahe, Fiona
> >
> > Check that the firmware response has a bit set indicating it's valid before
> > dereferencing the rest of the response contents.
> >
> > Fixes: 0bdd36e12245 ("crypto/qat: make dequeue function generic")
> > Cc: sta...@dpdk.org
>
Add note on usage of op structure and when it can be
accessed and freed.
Fixes: 63f4bfd5328b ("compressdev: add enqueue/dequeue functions")
Cc: sta...@dpdk.org
Signed-off-by: Fiona Trahe
---
lib/librte_compressdev/rte_compressdev.h | 7 +++
1 file changed, 7 insertions(+)
diff --git a/lib/
26/10/2018 20:18, Fiona Trahe:
> Enable dynamic huffman encoding in the QAT comp PMD.
>
> Signed-off-by: Tomasz Jozwiak
> Signed-off-by: Fiona Trahe
> Acked-by: Arek Kusztal
Applied, thanks
27/10/2018 01:53, Ferruh Yigit:
> On 10/27/2018 12:47 AM, Thomas Monjalon wrote:
> > 27/10/2018 02:38, Ferruh Yigit:
> >> build error:
> >> == Build drivers/net/tap
> >> mktemp: cannot create temp file /tmp/dpdk.auto-config-h.sh.XXX.c:
> >> Invalid argument
> >> .../buildtools/auto-config-h.sh: lin
From: Ciara Power
This patch adds all documentation for telemetry.
A description on how to use the Telemetry API with a DPDK
application is given in this document.
It also adds the MAINTAINERS file entry and a release notes update for
telemetry.
Signed-off-by: Ciara Power
Signed-off-by: Brian
From: Ciara Power
This patch adds functionality to enable/disable the selftest.
This functionality will be extended in future to make the
enabling/disabling more dynamic and remove this 'hardcoded' approach. We
are temporarily using this approach due to the design changes (vdev vs eal)
made to t
From: Ciara Power
This patch adds the parser file. This is used to parse any
messages that are received on any of the client sockets.
Currently, the unregister functionality works using the parser.
Functionality relating to getting statistic values for certain ports
will be added in a subsequent
From: Kevin Laatz
This patch adds telemetry as a dependecy to all applications. Without these
changes, the --telemetry flag will not be recognised and applications will
fail to run if they want to enable telemetry.
Signed-off-by: Bruce Richardson
Signed-off-by: Kevin Laatz
Signed-off-by: Radu
From: Ciara Power
This patch adds a python script which can be used as a demo
client. The script is interactive and will allow the user to
register, request statistics, and unregister.
To run the script, an argument for the client file path must
be passed in: "python telemetry_client.py ".
This
From: Ciara Power
This patch introduces clients to the telemetry API.
When a client makes a connection through the initial telemetry
socket, they can send a message through the socket to be
parsed. Register messages are expected through this socket, to
enable clients to register and have a clien
From: Ciara Power
This patch adds functionality to create a JSON message in
order to send it to a client socket.
When stats are requested by a client, they are retrieved from
the metrics library and encoded in JSON format.
Signed-off-by: Ciara Power
Signed-off-by: Brian Archbold
Signed-off-by
From: Ciara Power
This patch adds functionality to update the statistics in
the metrics library with values from the ethdev stats.
Values need to be updated before they are encoded into a JSON
message and sent to the client that requested them. The JSON encoding
will be added in a subsequent pat
From: Ciara Power
This patch adds the telemetry UNIX socket. It is used to
allow connections from external clients.
On the initial connection from a client, ethdev stats are
registered in the metrics library, to allow for their retrieval
at a later stage.
Signed-off-by: Ciara Power
Signed-off-
From: Ciara Power
This patch adds the infrastructure and initial code for the telemetry
library.
The telemetry init is registered with eal_init(). We can then check to see
if --telemetry was passed as an eal option. If --telemetry was parsed, then
we call telemetry init at the end of eal init.
This patchset introduces a Telemetry library for DPDK Service Assurance.
This library provides an easy way to query DPDK Ethdev metrics.
The telemetry library provides a method for a service assurance component
to retrieve metrics from a DPDK packet forwarding application.
Communicating from the s
From: Kevin Laatz
This patch makes the eal_get_runtime_dir() API public so it can be used
from outside EAL.
Signed-off-by: Kevin Laatz
Acked-by: Harry van Haaren
---
lib/librte_eal/bsdapp/eal/eal.c | 2 +-
lib/librte_eal/common/eal_filesystem.h | 15 ---
lib/librte_eal/c
From: Kevin Laatz
This commit adds infrastructure to EAL that allows an application to
register it's init function with EAL. This allows libraries to be
initialized at the end of EAL init.
This infrastructure allows libraries that depend on EAL to be initialized
as part of EAL init, removing cir
On 10/27/2018 12:47 AM, Thomas Monjalon wrote:
> 27/10/2018 02:38, Ferruh Yigit:
>> build error:
>> == Build drivers/net/tap
>> mktemp: cannot create temp file /tmp/dpdk.auto-config-h.sh.XXX.c:
>> Invalid argument
>> .../buildtools/auto-config-h.sh: line 86: : No such file or directory
>> .../drive
27/10/2018 02:38, Ferruh Yigit:
> build error:
> == Build drivers/net/tap
> mktemp: cannot create temp file /tmp/dpdk.auto-config-h.sh.XXX.c:
> Invalid argument
> .../buildtools/auto-config-h.sh: line 86: : No such file or directory
> .../drivers/net/tap/Makefile:55: recipe for target
>'tap_aut
build error:
== Build drivers/net/tap
mktemp: cannot create temp file /tmp/dpdk.auto-config-h.sh.XXX.c:
Invalid argument
.../buildtools/auto-config-h.sh: line 86: : No such file or directory
.../drivers/net/tap/Makefile:55: recipe for target
'tap_autoconf.h.new' failed
Above error observed on W
On 10/26/2018 8:59 PM, Thomas Monjalon wrote:
> 26/10/2018 20:31, Ferruh Yigit:
>> On 10/26/2018 6:59 PM, Thomas Monjalon wrote:
>>> 26/10/2018 20:42, Ferruh Yigit:
build error:
== Build drivers/net/tap
mktemp: cannot create temp file /tmp/dpdk.auto-config-h.sh.XXX.c:
Invalid ar
27/10/2018 00:42, Ferruh Yigit:
> On 10/26/2018 10:56 PM, Thomas Monjalon wrote:
> > 26/10/2018 23:40, Thomas Monjalon:
> >> The atomic functions smp_load_acquire() and smp_store_release()
> >> were introduced in Linux 3.14. Older kernels miss the functions:
> >>
> >> kni_fifo.h:19:2: error:
> >>
27/10/2018 00:13, Ferruh Yigit:
> On 10/26/2018 11:00 PM, Thomas Monjalon wrote:
> > main.c(376): error #592: variable "lcore_id" is used before its value is set
> > RTE_SET_USED(lcore_id);
> > ^
> >
> > The variables were voided with RTE_SET_USED without an obvious reason.
> > Rem
> On Oct 25, 2018, at 1:53 AM, Shahaf Shuler wrote:
>
> 1. The check for the Eth item was wrong. causing an error with
> flow rules like:
>
> flow create 0 ingress pattern eth / vlan vid is 13 / ipv4 / gre / eth /
> vlan vid is 15 / end actions drop / end
>
> 2. align all error messages.
>
>
> On Oct 25, 2018, at 1:53 AM, Shahaf Shuler wrote:
>
> Apply the changes from commit c744f6b1b969 ("net/mlx5: fix bit width of
> item and action flags") in some places that were overlooked.
>
> Fixes: c744f6b1b969 ("net/mlx5: fix bit width of item and action flags")
> Fixes: 23c1d42c7138 ("ne
On 10/26/2018 10:56 PM, Thomas Monjalon wrote:
> 26/10/2018 23:40, Thomas Monjalon:
>> The atomic functions smp_load_acquire() and smp_store_release()
>> were introduced in Linux 3.14. Older kernels miss the functions:
>>
>> kni_fifo.h:19:2: error:
>> implicit declaration of function ‘smp_load
On Fri, Oct 26, 2018 at 02:35:24AM -0700, Slava Ovsiienko wrote:
> > -Original Message-
> > From: Yongseok Koh
> > Sent: Friday, October 26, 2018 9:26
> > To: Slava Ovsiienko
> > Cc: Shahaf Shuler ; dev@dpdk.org
> > Subject: Re: [PATCH v2 5/7] net/mlx5: e-switch VXLAN tunnel devices
> > ma
On 10/26/2018 11:00 PM, Thomas Monjalon wrote:
> main.c(376): error #592: variable "lcore_id" is used before its value is set
> RTE_SET_USED(lcore_id);
> ^
>
> The variables were voided with RTE_SET_USED without an obvious reason.
> Removing these voidings should avoid the icc erro
On Fri, Oct 26, 2018 at 02:06:53AM -0700, Slava Ovsiienko wrote:
> > -Original Message-
> > From: Yongseok Koh
> > Sent: Friday, October 26, 2018 7:22
> > To: Slava Ovsiienko
> > Cc: Shahaf Shuler ; dev@dpdk.org
> > Subject: Re: [PATCH v2 3/7] net/mlx5: e-switch VXLAN flow translation
> >
main.c(376): error #592: variable "lcore_id" is used before its value is set
RTE_SET_USED(lcore_id);
^
The variables were voided with RTE_SET_USED without an obvious reason.
Removing these voidings should avoid the icc error.
Fixes: a137d012 ("examples/l3fwd-power: support traffic
26/10/2018 23:55, Dharmik Thakkar:
>
> > On Oct 26, 2018, at 4:05 PM, Wang, Yipeng1 wrote:
> >
> >> -Original Message-
> >> From: Thomas Monjalon [mailto:tho...@monjalon.net]
> >> Sent: Friday, October 26, 2018 1:25 PM
> >> To: Dharmik Thakkar
> >> Cc: Richardson, Bruce ; De Lara Guarch
On Fri, Oct 26, 2018 at 01:39:38AM -0700, Slava Ovsiienko wrote:
> > -Original Message-
> > From: Yongseok Koh
> > Sent: Friday, October 26, 2018 6:07
> > To: Slava Ovsiienko
> > Cc: Shahaf Shuler ; dev@dpdk.org
> > Subject: Re: [PATCH v2 2/7] net/mlx5: e-switch VXLAN flow validation
> > r
26/10/2018 23:40, Thomas Monjalon:
> The atomic functions smp_load_acquire() and smp_store_release()
> were introduced in Linux 3.14. Older kernels miss the functions:
>
> kni_fifo.h:19:2: error:
> implicit declaration of function ‘smp_load_acquire’
> kni_fifo.h:30:2: error:
> implicit
> On Oct 26, 2018, at 4:05 PM, Wang, Yipeng1 wrote:
>
>> -Original Message-
>> From: Thomas Monjalon [mailto:tho...@monjalon.net]
>> Sent: Friday, October 26, 2018 1:25 PM
>> To: Dharmik Thakkar
>> Cc: Richardson, Bruce ; De Lara Guarch, Pablo
>> ; dev@dpdk.org;
>> honnappa.nagaraha..
On Thu, Oct 25, 2018 at 01:29:38PM -0700, Stephen Hemminger wrote:
> SUSE decided to install the libmnl include file in a non-standard
> place: /usr/include/libmnl/libmnl/libmnl.h
>
> This was probably a mistake by the SUSE package maintainer,
> but hard to get fixed. Workaround the problem by pkg
On Fri, Oct 26, 2018 at 04:48:29PM +0200, Tom Barbette wrote:
> This patch adds support for the rx_queue_count API in mlx5 driver
>
> Changes in v2:
> * Fixed styling issues
> * Fix missing return
>
> Signed-off-by: Tom Barbette
> ---
Thank you for your contribution!
It is good but I have a
Enable print_key_info() function compilation always.
Compilation error message:
'test_hash.c: In function ‘print_key_info’:
test_hash.c:90:15: error: cast discards ‘const’ qualifier from pointer
target type [-Werror=cast-qual]
uint8_t *p = (uint8_t *)key;
^
cc1: all warnings being
The atomic functions smp_load_acquire() and smp_store_release()
were introduced in Linux 3.14. Older kernels miss the functions:
kni_fifo.h:19:2: error:
implicit declaration of function ‘smp_load_acquire’
kni_fifo.h:30:2: error:
implicit declaration of function ‘smp_store_release’
> On Oct 26, 2018, at 3:24 PM, Thomas Monjalon wrote:
>
> +Cc Yipeng
>
> 18/09/2018 21:22, Dharmik Thakkar:
>> Enable print_key_info() function compilation always.
>
> Please see my first comment: you need to show the compilation error
> in this message. Otherwise, we don't know what you are
>-Original Message-
>From: Thomas Monjalon [mailto:tho...@monjalon.net]
>Sent: Friday, October 26, 2018 1:25 PM
>To: Dharmik Thakkar
>Cc: Richardson, Bruce ; De Lara Guarch, Pablo
>; dev@dpdk.org;
>honnappa.nagaraha...@arm.com; Wang, Yipeng1
>Subject: Re: [dpdk-stable] [PATCH v2] test/ha
26/10/2018 16:55, Anatoly Burakov:
> --- a/lib/librte_eal/common/eal_common_proc.c
> +++ b/lib/librte_eal/common/eal_common_proc.c
> + /*
> + * set the alarm before sending message. there are two possible error
> + * scenarios to consider here:
> + *
> + * - if the alarm set
25/10/2018 13:06, Anatoly Burakov:
> When no-huge mode is enabled, we always overwrite the socket ID to be
> SOCKET_ID_ANY in rte_malloc, because there is no NUMA awareness in no-huge
> mode. However, with external memory support, a socket ID may have other
> meaning, and we cannot overwrite the so
+Cc Yipeng
18/09/2018 21:22, Dharmik Thakkar:
> Enable print_key_info() function compilation always.
Please see my first comment: you need to show the compilation error
in this message. Otherwise, we don't know what you are trying
to fix.
> Fixes: af75078fece36 ("first public release")
> Cc: sta
> Yipeng Wang (6):
> hash: fix unnecessary pause
> test/hash: change multiwriter test to use jhash
> test/hash: test more corner cases in unit test
> test/hash: add readwrite test for ext table
> test/hash: remove hash scaling unit test
> test/hash: fix to add read-write test to autotes
26/10/2018 20:31, Ferruh Yigit:
> On 10/26/2018 6:59 PM, Thomas Monjalon wrote:
> > 26/10/2018 20:42, Ferruh Yigit:
> >> build error:
> >> == Build drivers/net/tap
> >> mktemp: cannot create temp file /tmp/dpdk.auto-config-h.sh.XXX.c:
> >> Invalid argument
> >> .../buildtools/auto-config-h.sh: line
On 10/26/2018 6:59 PM, Thomas Monjalon wrote:
> 26/10/2018 20:42, Ferruh Yigit:
>> build error:
>> == Build drivers/net/tap
>> mktemp: cannot create temp file /tmp/dpdk.auto-config-h.sh.XXX.c:
>> Invalid argument
>> .../buildtools/auto-config-h.sh: line 86: : No such file or directory
>> .../driver
Enable dynamic huffman encoding in the QAT comp PMD.
Signed-off-by: Tomasz Jozwiak
Signed-off-by: Fiona Trahe
Acked-by: Arek Kusztal
---
v7 changes:
- replace %ld with %zu for printing size_t to fix compiler issue
- replace phys addr with rte_iova_t
v6 changes:
26/10/2018 20:42, Ferruh Yigit:
> build error:
> == Build drivers/net/tap
> mktemp: cannot create temp file /tmp/dpdk.auto-config-h.sh.XXX.c:
> Invalid argument
> .../buildtools/auto-config-h.sh: line 86: : No such file or directory
> .../drivers/net/tap/Makefile:55: recipe for target
>'tap_aut
14/09/2018 16:40, Ferruh Yigit:
> On 9/14/2018 2:57 PM, Naga Suresh Somarowthu wrote:
> > Check the prerequisites to run the test
> > 1.checked whether the rte_kni module is loaded, if not fail testcase
> > 2.checked whether the rte_kni module is loaded with loop back mode,
> > if not skip packet
build error:
== Build drivers/net/tap
mktemp: cannot create temp file /tmp/dpdk.auto-config-h.sh.XXX.c:
Invalid argument
.../buildtools/auto-config-h.sh: line 86: : No such file or directory
.../drivers/net/tap/Makefile:55: recipe for target
'tap_autoconf.h.new' failed
Above error observed on W
25/10/2018 14:30, Ferruh Yigit:
> On 10/24/2018 11:26 PM, Dan Gora wrote:
> >> Note that checkpatches.sh compains about patch 1/5, but this appears
> >> to be a bug with check-symbol-change or something. If I move the
> >> fragment of the patch modifying rte_kni_version.map to the bottom of
> >> t
The hash scaling unit test is not really needed
any more since the multi-writer is supported now
inside the library and it is tested by multi-writer
unit test.
Signed-off-by: Yipeng Wang
Acked-by: Bruce Richardson
---
test/test/Makefile| 1 -
test/test/autotest_data.py| 6 --
This commit improves the readwrite test to consider
extendable table feature.
Signed-off-by: Yipeng Wang
Acked-by: Bruce Richardson
---
test/test/test_hash_readwrite.c | 42 +
1 file changed, 34 insertions(+), 8 deletions(-)
diff --git a/test/test/test_h
This commit improves the readwrite unit test to cover
more corner cases and reduces the testing time by
reducing the total key count.
Signed-off-by: Yipeng Wang
Acked-by: Bruce Richardson
---
test/test/test_hash_readwrite.c | 32 ++--
1 file changed, 26 insertions(+)
With sequential key, the test will cover more corner
cases with jhash instead of crc hash, since jhash
generates more random hash pattern on sequential key.
It is useful for functional verification.
Signed-off-by: Yipeng Wang
---
test/test/test_hash_multiwriter.c | 3 ++-
1 file changed, 2 inser
Add read-write concurrency test to meson and autotest
file.
Fixes: 0eb3726ebcf1 ("test/hash: add test for read/write concurrency")
Cc: sta...@dpdk.org
Signed-off-by: Yipeng Wang
---
test/test/autotest_data.py | 6 ++
test/test/meson.build | 1 +
2 files changed, 7 insertions(+)
diff -
There is a rte_pause in hash table reset function.
Since the loop is not a polling loop on shared
data structure, the rte_pause is not needed.
Fixes: b26473ff8f4a ("hash: add reset function")
Cc: sta...@dpdk.org
Signed-off-by: Yipeng Wang
Acked-by: Bruce Richardson
---
lib/librte_hash/rte_cuck
This patch set depends on Honnappa's patch set:
http://patchwork.dpdk.org/cover/47268/
This patch set fixes/improves a couple of places mostly
on unit tests:
commit 1: remove unnecessary code in hash library.
commit 2: use jhash in multiwriter unit test.
commit 3: cover more test case in unit tes
10/10/2018 16:48, Ferruh Yigit:
> On 10/8/2018 10:11 AM, phil.y...@arm.com wrote:
> > Keep only single config option RTE_USE_C11_MEM_MODEL for C11 memory
> > model, so all modules can leverage C11 atomic extension by enable this
> > option.
> >
> > Signed-off-by: Phil Yang
> > Reviewed-by: Honnap
> -Original Message-
> From: Richardson, Bruce
> Sent: Friday, October 26, 2018 6:12 AM
> To: Xing, Beilei
> Cc: Zhang, Qi Z ; dev@dpdk.org; sta...@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v2] net/i40e: fix Rx instability with vector
> mode
>
> On Fri, Oct 26, 2018 at 02:33:27PM +0800
> -Original Message-
> From: Ananyev, Konstantin
> Sent: Friday, October 26, 2018 3:47 AM
> To: Xing, Beilei ; Zhang, Qi Z
> Cc: dev@dpdk.org; sta...@dpdk.org
> Subject: RE: [dpdk-dev] [PATCH v2] net/i40e: fix Rx instability with vector
> mode
>
>
> Hi,
>
> >
> > Previously, there is
On 10/26/2018 3:34 PM, Ferruh Yigit wrote:
> On 10/26/2018 1:40 PM, Jerin Jacob wrote:
>> Fix a typo on DEV_RX_OFFLOAD_QINQ_STRIP selection.
>
> I think this is not typo but confusion caused by DEV_RX_OFFLOAD_VLAN_EXTEND
> ...
>
>>
>> Fixes: 0074d02fca21 ("app/testpmd: convert to new Rx offloads
On 10/26/2018 3:32 PM, Ferruh Yigit wrote:
> On 10/26/2018 11:27 AM, dev-boun...@dpdk.org wrote:
>> The forwarding mode mac_swap should be macswap in testpmd guide.
>>
>> Signed-off-by: Yong Wang
>
> Reviewed-by: Ferruh Yigit
Applied to dpdk-next-net/master, thanks.
On 10/26/2018 3:47 PM, Ferruh Yigit wrote:
> On 10/19/2018 6:35 PM, Stephen Hemminger wrote:
>> The offload name functions are useful, but since they are
>> marked experimental they can not be used by upstream projects.
>> For example, VPP duplicates the same table in its code.
>>
>> Signed-off-by:
On 25-Jul-18 7:20 PM, Stephen Hemminger wrote:
No need for profanity in comments.
Signed-off-by: Stephen Hemminger
---
drivers/net/bnx2x/elink.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/bnx2x/elink.c b/drivers/net/bnx2x/elink.c
index 34a29373af3b..0
EAL should not crash when setting alarm fails. Also, remove the
profanity in error message.
Fixes: daf9bfca717e ("ipc: remove thread for async requests")
Cc: sta...@dpdk.org
Cc: step...@networkplumber.org
Signed-off-by: Stephen Hemminger
Signed-off-by: Anatoly Burakov
---
lib/librte_eal/commo
This patch adds support for the rx_queue_count API in mlx5 driver
Changes in v2:
* Fixed styling issues
* Fix missing return
Signed-off-by: Tom Barbette
---
drivers/net/mlx5/mlx5.c | 1 +
drivers/net/mlx5/mlx5_rxtx.c | 60 +---
drivers/net/mlx5/
On 10/19/2018 6:35 PM, Stephen Hemminger wrote:
> The offload name functions are useful, but since they are
> marked experimental they can not be used by upstream projects.
> For example, VPP duplicates the same table in its code.
>
> Signed-off-by: Stephen Hemminger
Reviewed-by: Ferruh Yigit
On 10/25/2018 11:04 PM, Chas Williams wrote:
> From: Chas Williams
>
> Calling rte_eth_macaddr_get to get a copy of the MAC address causes
> a hot spot according to profiling. We can easily get the current
> MAC address by just examining the bonded device.
>
> Signed-off-by: Chas Williams
Appl
-Original Message-
> Date: Fri, 26 Oct 2018 14:40:42 +0100
> From: Ferruh Yigit
> To: Jerin Jacob , "dev@dpdk.org"
>
> CC: "tho...@monjalon.net" ,
> "arybche...@solarflare.com" ,
> "olivier.m...@6wind.com" , "qi.z.zh...@intel.com"
> , "beilei.x...@intel.com" ,
> Wenzhuo Lu , Konstant
On 10/25/2018 6:59 PM, Michal Krawczyk wrote:
> Hi,
>
> version upgrade containt two major fixes:
> * Memory leak fix on ena_start(), if it was called right after stop()
> * Provide application with valid hash, instead of queue ID
>
> The first issue was introduced in 18.08 when the additional st
On 10/26/2018 1:40 PM, Jerin Jacob wrote:
> Fix a typo on DEV_RX_OFFLOAD_QINQ_STRIP selection.
I think this is not typo but confusion caused by DEV_RX_OFFLOAD_VLAN_EXTEND ...
>
> Fixes: 0074d02fca21 ("app/testpmd: convert to new Rx offloads API")
>
> Cc: shah...@mellanox.com
> Cc: sta...@dpdk.o
On 10/26/2018 11:27 AM, dev-boun...@dpdk.org wrote:
> The forwarding mode mac_swap should be macswap in testpmd guide.
>
> Signed-off-by: Yong Wang
Reviewed-by: Ferruh Yigit
On 10/25/2018 2:27 PM, Ferruh Yigit wrote:
> On 10/10/2018 3:12 PM, Ilya Maximets wrote:
>> For meson build without deprecation warnings following
>> patch should be applied first:
>> http://patches.dpdk.org/patch/46064/
>>
>> Version 4:
>> * Fixed return value checking for nanosleep().
>>
On 24-Oct-18 11:11 AM, Darek Stojaczyk wrote:
This function is documented to return the number of unregistered
callbacks or negative numbers on error, but pci_vfio checks for
ret != 0 to detect failures. Not anymore.
Fixes: c115fd000c32 ("vfio: handle hotplug request notifier")
Cc: jia@intel
On 25-Oct-18 11:46 AM, Darek Stojaczyk wrote:
rte_mp_request_sync() says that the caller is responsible
for freeing one of its parameters afterwards. EAL didn't
do that, causing a memory leak.
Fixes: 244d5130719c ("eal: enable hotplug on multi-process")
Cc: qi.z.zh...@intel.com
Cc: sta...@dpdk.o
On 25-Oct-18 11:49 AM, Darek Stojaczyk wrote:
We were reading some memory just after freeing it.
Fixes: 83a73c5fef66 ("vfio: use generic multi-process channel")
Cc: jianfeng@intel.com
Cc: anatoly.bura...@intel.com
Cc: sta...@dpdk.org
Signed-off-by: Darek Stojaczyk
---
lib/librte_eal/linu
On 25-Oct-18 11:49 AM, Alejandro Lucero wrote:
Invoking the right pci read/write functions is based on interrupt
handler type. However, this is not configured for secondary processes
precluding to use those functions.
This patch fixes the issue using the driver name the device is bound
to instea
On 10/4/2018 2:37 PM, Bruce Richardson wrote:
> On Thu, Oct 04, 2018 at 04:18:35PM +0300, Ilya Maximets wrote:
>> This functionality was missed while adding new drivers to
>> the meson build.
>>
>> Fixes: 1d75caf81474 ("net/avf: add meson support")
>> Fixes: 30d3d0168301 ("net/qede: add in meson bu
Hi Dave,
Many thanks!
Regards
Liang
On 26 Oct 13:38, David Hunt wrote:
> 1. %ld to PRId64 for 32-bit builds
> 2. Fix dependency on librte_timer
>
> Fixes: 450f0791312c ("power: add traffic pattern aware power control")
>
> Signed-off-by: David Hunt
> Tested-by: Ferruh Yigit
> ---
> lib/Mak
This patch adds support for the rx_queue_count API in mlx5 driver
Signed-off-by: Tom Barbette
---
drivers/net/mlx5/mlx5.c | 1 +
drivers/net/mlx5/mlx5_rxtx.c | 62 +---
drivers/net/mlx5/mlx5_rxtx.h | 1 +
3 files changed, 54 insertions(+), 10 deleti
On 10/26/2018 11:56 AM, Jerin Jacob wrote:
>
> Does anyone know the expectation of DEV_RX_OFFLOAD_VLAN_EXTEND
> offload? Does not look like it is documented.
>
> Looks like it is very specific to Intel controllers, Based on 82599 HRM,
> it is following, not sure what is the real expectation from
Hi Thomas,
Many thanks, I will check carefully for meson build and doc next time.
Regards
Liang
On 26 Oct 01:55, Thomas Monjalon wrote:
> 19/10/2018 13:07, Liang Ma:
> > The proposed solution focuses on how many times empty polls are executed.
> > The less the number of empty polls, means
Add a script meant to be linked off the DPDK website from the quick start
page to allow user to quickly download DPDK, configure, build DPDK and run
TestPMD. It uses ``dialog`` as a user interface.
This script performs the following:
* Gets the latest DPDK release
* Gets the necessary dependencies
24/10/2018 13:10, Ferruh Yigit:
> The build error observed with Linux kernel 4.19 when KNI ethtool
> support enabled (CONFIG_RTE_KNI_KMOD_ETHTOOL=y)
>
> .../build/build/kernel/linux/kni/kni_ethtool.c:193:3:
>error: ‘struct ethtool_ops’ has no member named ‘get_settings’;
> .get_settings = k
Hi,
-Original Message-
From: Varghese, Vipin
+ "\t -- id (%u) flags (0x%"PRIx64") socket (%d)\n"
+ "\t -- queue pairs (%d)\n",
+ rte_cryptodev_name_get(i),
+ dev_info.driver_name, dev_info.driver_id,
+
Hi
-Original Message-
From: Varghese, Vipin
---
+ struct rte_cryptodev_info dev_info = {0};
+ struct rte_cryptodev_stats stats = {0};
+
Memset for initialization as mentioned in other patch.
+
+#define DSP_CRYPTO_FLAG(x) do { \
+printf(" - feature flags\n")
1 - 100 of 144 matches
Mail list logo
