Set the "value" in the filter spec and not the "mask". Also, remove
duplicate comparison for hardware supported match items already done
earlier.
Fixes: af44a577988b ("net/cxgbe: support to offload flows to HASH region")
Cc: sta...@dpdk.org
Signed-off-by: Rahul Lakkireddy
---
drivers/net/cxgbe/
Individual MPS TCAM entries are not allocated as separate entities.
All entries are allocated once as an array. So, fix bug with attempting
to free illegal memory location.
Also add missing MPS TCAM initialization for CXGBEVF.
Fixes: 6fda3f0ddda9 ("net/cxgbe: add API to program hardware MPS table
During procless startup, dpdk invokes clear_hugedir() to unlink all hugepage
files under /dev/hugepages.
Then in map_all_hugepages(), it invokes mmap to allocate and zero all the huge
pages as
configured in /sys/kernel/mm/hugepages/xxx/nr_hugepages.
This cause startup process extreamly slow
Fix issue where ethertype is set to 0x800 for IPv4 by ether match
item and IPv4 match item also inherently sets ethertype to 0x800.
Current logic returns error when IPv4 match item is parsed. So, fix
by only bailing if the redefined match items have different values.
Fixes: ee61f5113b17 ("net/cxg
Under heavy load, flow related operations can take more time to
complete. Increase max completion wait time to 10 seconds. Also
increase max receive budget to read more replies from firmware
in every cycle.
Fixes: 9eb2c9a48072 ("net/cxgbe: implement flow create operation")
Cc: sta...@dpdk.org
Sig
Fixes: 436125e64174 ("net/cxgbe: update to Rx/Tx offloada API")
Cc: sta...@dpdk.org
Signed-off-by: Rahul Lakkireddy
---
drivers/net/cxgbe/cxgbe_main.c | 10 +++---
1 file changed, 7 insertions(+), 3 deletions(-)
diff --git a/drivers/net/cxgbe/cxgbe_main.c b/drivers/net/cxgbe/cxgbe_main.c
in
Fixes: 2195df6d11bd ("net/cxgbe: rework ethdev device allocation")
Cc: sta...@dpdk.org
Signed-off-by: Rahul Lakkireddy
---
drivers/net/cxgbe/cxgbevf_ethdev.c | 12 +++-
1 file changed, 11 insertions(+), 1 deletion(-)
diff --git a/drivers/net/cxgbe/cxgbevf_ethdev.c
b/drivers/net/cxgbe/c
Patch 1 adds a missing PCI un-initialization function for CXGBEVF to
fix resource leaks.
Patch 2 fixes VLAN strip offload always being enabled without looking
at Rx offload flags.
Patch 3 fixes issue with redefined match items in flows being offloaded
to hardware.
Patch 4 fixes flow offload time
Sent from my iPhone
> On Nov 7, 2018, at 2:36 AM, Jiang Huiyou wrote:
>
> Hi,
> My user-space TCP/IP stack works fine on DPDK 17.02, now I upgrade it to
> 18.02. And then I use wrk http benchmark to test my stack, it work well
> fine, but after a while, it couldn't send packet. I deb
On 11/8/2018 3:32 AM, Stephen Hemminger wrote:
On Wed, 7 Nov 2018 17:41:30 +0800
Jeff Guo wrote:
Since the hotplug API and device event API have make public, so in order
to let applications or driver deal with device directly, it would be
helpful if the states of device could be exposed, es
On Fri, Nov 9, 2018 at 12:01 AM Yongseok Koh wrote:
>
>
> > On Nov 8, 2018, at 9:21 AM, Ferruh Yigit wrote:
> >
> > On 11/8/2018 3:59 PM, Thomas Monjalon wrote:
> >> Hi,
> >>
> >> We need to gather more information about this bug.
> >> More below.
> >>
Thanks Thomas for looping us in!
> >> 07/1
On 11/9/2018 1:24 PM, Matan Azrad wrote:
From: Jeff Guo
On 11/8/2018 5:35 PM, Matan Azrad wrote:
From: Jeff Guo
On 11/8/2018 3:28 PM, Matan Azrad wrote:
From: Ananyev, Konstantin
-Original Message-
From: Guo, Jia
Sent: Wednesday, November 7, 2018 7:30 AM
To: Matan Azrad ; Ananye
With a larger PAGE_SIZE it is possible for the MSI table to very
close to the end of the BAR s.t. when we align the start and end
of the MSI table to the PAGE_SIZE, the end offset of the MSI
table is out of the PCI BAR boundary.
This patch addresses the issue by comparing both the start and the
en
From: Subrahmanyam Nilla
For performance reasons, word1 of send_hdr_s
sub descriptor was not cleared assuming it is always
having default value of zero since it comes from fixed
offsets of SQ buffer.
This is causing issues in case of SG mode because,
the size of send command might change and henc
From: Jeff Guo
> On 11/8/2018 5:35 PM, Matan Azrad wrote:
> >
> > From: Jeff Guo
> >> On 11/8/2018 3:28 PM, Matan Azrad wrote:
> >>> From: Ananyev, Konstantin
> > -Original Message-
> > From: Guo, Jia
> > Sent: Wednesday, November 7, 2018 7:30 AM
> > To: Matan Azrad ; An
On 11/8/2018 5:35 PM, Matan Azrad wrote:
From: Jeff Guo
On 11/8/2018 3:28 PM, Matan Azrad wrote:
From: Ananyev, Konstantin
-Original Message-
From: Guo, Jia
Sent: Wednesday, November 7, 2018 7:30 AM
To: Matan Azrad ; Ananyev, Konstantin
; Burakov, Anatoly
; Thomas Monjalon
;
Iremo
On 11/9/2018 5:55 AM, Stephen Hemminger wrote:
On Thu, 8 Nov 2018 11:10:29 +0800
Jeff Guo wrote:
hi, stephen
On 11/8/2018 3:33 AM, Stephen Hemminger wrote:
On Wed, 7 Nov 2018 17:41:31 +0800
Jeff Guo wrote:
When device is hot-unplugged, the device fd will be deleted in kernel.
Then in
On 11/9/2018 1:48 AM, Zhang, Qi Z wrote:
-Original Message-
From: Guo, Jia
Sent: Thursday, November 8, 2018 12:18 AM
To: Xing, Beilei ; Kovacevic, Marko
; Mcnamara, John
; Zhang, Qi Z
Cc: dev@dpdk.org; Guo, Jia ; Zhang, Helin
; Wu, Jingjing
Subject: [PATCH V2] doc: add known PHY lin
>
> > > Agree. There are multiple micro-architectures in Arm eco-system. We
> > should establish few simple rules to make sure algorithms perform well
> > on all the available platforms. I established few rules in VPP and
> > they are working fine so far.
> >
> > Can you share that rules for every
> > Agree. There are multiple micro-architectures in Arm eco-system. We
> should establish few simple rules to make sure algorithms perform well on all
> the available platforms. I established few rules in VPP and they are working
> fine so far.
>
> Can you share that rules for everyone's benefi
> >> >
> >> > 9) Does anyone else facing this problem?
> >Any data on x86?
> >
> [Wang, Yipeng]
> I tried Jerin's tests on x86. So by default l3fwd on x86 will use lookup_bulk
> and SIMD instruction so there is no obvious throughput drop on both hit
> and miss cases (for hit case, there is about 2.
> On Nov 8, 2018, at 12:50 AM, Ophir Munk wrote:
>
>
>
>> -Original Message-
>> From: Adrien Mazarguil [mailto:adrien.mazarg...@6wind.com]
>> Sent: Wednesday, November 07, 2018 6:41 PM
>> To: Ophir Munk
>> Cc: Ferruh Yigit ; Andrew Rybchenko
>> ; dev@dpdk.org; Thomas Monjalon
>> ; As
> On Nov 8, 2018, at 9:21 AM, Ferruh Yigit wrote:
>
> On 11/8/2018 3:59 PM, Thomas Monjalon wrote:
>> Hi,
>>
>> We need to gather more information about this bug.
>> More below.
>>
>> 07/11/2018 10:04, Wiles, Keith:
On Nov 6, 2018, at 9:30 PM, Yongseok Koh wrote:
> On Nov 5, 2018, a
>From: Stephen Hemminger
>Sent: Thursday, November 08, 2018 1:39 PM
>
>On Thu, 8 Nov 2018 21:19:26 +
>"Mody, Rasesh" wrote:
>
>> Use rte_log() rather than RTE_LOG() for dynamic logging. Rearrange
>> dynamic log types to the top and configurable log types to bottom.
>> Remove unused RTE_LIBRTE
> On Nov 8, 2018, at 1:29 PM, Dekel Peled wrote:
>
> Fix the flow_fdir_cmp() function, used by flow_fdir_filter_lookup().
> This function is used by flow_fdir_filter_add() to check if same rule
> exists, and by flow_fdir_filter_delete() to find flow rule to delete.
>
> The function compared ac
On Thu, 8 Nov 2018 11:10:29 +0800
Jeff Guo wrote:
> hi, stephen
>
> On 11/8/2018 3:33 AM, Stephen Hemminger wrote:
> > On Wed, 7 Nov 2018 17:41:31 +0800
> > Jeff Guo wrote:
> >
> >> When device is hot-unplugged, the device fd will be deleted in kernel.
> >> Then in the progress of detaching
On Thu, 8 Nov 2018 21:19:26 +
"Mody, Rasesh" wrote:
> Use rte_log() rather than RTE_LOG() for dynamic logging. Rearrange
> dynamic log types to the top and configurable log types to bottom.
> Remove unused RTE_LIBRTE_BNX2X_DEBUG_TX_FREE
>
> Fixes: ba7eeb035a5f ("net/bnx2x: fix logging to inc
Fix the flow_fdir_cmp() function, used by flow_fdir_filter_lookup().
This function is used by flow_fdir_filter_add() to check if same rule
exists, and by flow_fdir_filter_delete() to find flow rule to delete.
The function compared actions conf pointers, changed to compare
actions type only.
Fixes
In general the VF driver should not access the chip. For VF link status
update, VF driver should not use HW lock, use bnx2x_link_report_locked()
instead.
Add few prints for releasing previously held HW locks.
Fixes: a9b58b15ed51 ("net/bnx2x: fix to add PHY lock")
Signed-off-by: Rasesh Mody
---
Use rte_log() rather than RTE_LOG() for dynamic logging. Rearrange
dynamic log types to the top and configurable log types to bottom.
Remove unused RTE_LIBRTE_BNX2X_DEBUG_TX_FREE
Fixes: ba7eeb035a5f ("net/bnx2x: fix logging to include device name")
Signed-off-by: Rasesh Mody
---
drivers/net/bnx
> -Original Message-
> From: Burakov, Anatoly
> Sent: Thursday, November 8, 2018 4:16 AM
> To: Ilya Maximets ; dev@dpdk.org; Zhang, Qi Z
>
> Cc: Lu, Wenzhuo ; Ananyev, Konstantin
> ; Laurent Hardy
> ; Yigit, Ferruh ;
> sta...@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH] net/ixgbe: stop lin
Hi, Anatoly,
This is really minor nitpick, but in case you decide to send V2, I believe
it should say
>> + if ret != 0:
>> +print("'lspci' not found - please install pciutils')
as the name of the package containing lspci is pciutils in centos.
Regards,
Rami Rosen
>
This patch fixes a typo in flow_filtering.rst. There is no
method named generate_ipv4_rule in DPDK, it should be generate_ipv4_flow.
Signed-off-by: Rami Rosen
---
doc/guides/sample_app_ug/flow_filtering.rst | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/doc/guides/sample_ap
> -Original Message-
> From: Guo, Jia
> Sent: Thursday, November 8, 2018 12:18 AM
> To: Xing, Beilei ; Kovacevic, Marko
> ; Mcnamara, John
> ; Zhang, Qi Z
> Cc: dev@dpdk.org; Guo, Jia ; Zhang, Helin
> ; Wu, Jingjing
> Subject: [PATCH V2] doc: add known PHY link up issue for i40e
>
> I
On 11/8/2018 3:59 PM, Thomas Monjalon wrote:
> Hi,
>
> We need to gather more information about this bug.
> More below.
>
> 07/11/2018 10:04, Wiles, Keith:
>>> On Nov 6, 2018, at 9:30 PM, Yongseok Koh wrote:
On Nov 5, 2018, at 6:06 AM, Wiles, Keith wrote:
> On Nov 2, 2018, at 9:04 PM,
> -Original Message-
> From: Thomas Monjalon [mailto:tho...@monjalon.net]
> Sent: Thursday, November 8, 2018 5:26 AM
> To: Stojaczyk, Dariusz
> Cc: dev@dpdk.org; gaetan.ri...@6wind.com; Zhang, Qi Z
> ; Guo, Jia
> Subject: Re: [PATCH] devargs: do not replace already inserted devargs
>
Hi,
We need to gather more information about this bug.
More below.
07/11/2018 10:04, Wiles, Keith:
> > On Nov 6, 2018, at 9:30 PM, Yongseok Koh wrote:
> >> On Nov 5, 2018, at 6:06 AM, Wiles, Keith wrote:
> >>> On Nov 2, 2018, at 9:04 PM, Yongseok Koh wrote:
> >>>
> >>> This is a workaround to
When stopping a bonded port all slaves are deactivated. Attempting
to deactivate a slave that was never activated will result in a segfault
when mode 4 is used.
Fixes: 7486331308f6 ("net/bonding: stop and deactivate slaves on stop")
Cc: sta...@dpdk.org
Signed-off-by: Radu Nicolau
---
drivers/ne
Acked-by: Marko Kovacevic
Two spelling mistakes and tabs used instead of space I made the changes.
Just send the patch up.
Builds fine and pdf looks good.
Acked-by: Marko Kovacevic
> +
> +Debug & Troubleshoot guide via PMD
> +==
> +
> +DPDK applications can be designed to run as single thr
> -Original Message-
> From: dev On Behalf Of Stojaczyk, Dariusz
> Sent: Thursday, November 8, 2018 13:25
> To: Thomas Monjalon ; dev@dpdk.org
> Cc: gaetan.ri...@6wind.com; Zhang, Qi Z ; Guo, Jia
>
> Subject: Re: [dpdk-dev] [PATCH] devargs: do not replace already inserted
> devargs
>
>
Minutes 8 November 2018
---
Agenda:
* Dates
* RC2 status
* RC3
* Subtrees
* Bugzilla
* OvS
* Conferences
* Coverity
* Opens
Participants:
* Broadcom
* Cavium
* Debian
* Intel
* Mellanox
* NXP
* RedHat
Release Dates
-
* RC1 was out on Monday, 29 October.
* RC2 w
08/11/2018 13:35, Stojaczyk, Dariusz:
> From: Thomas Monjalon [mailto:tho...@monjalon.net]
> > 08/11/2018 12:25, Stojaczyk, Dariusz:
> > > From: Thomas Monjalon [mailto:tho...@monjalon.net]
> > > >
> > > > The devargs of a device can be replaced by a newly allocated one
> > > > when trying to probe
Thomas Monjalon wrote on 11/07/2018 01:21:22 PM:
> From: Thomas Monjalon
> To: dwilder
> Cc: Pradeep Satyanarayana , dev@dpdk.org,
> adrien.mazarg...@6wind.com, Luca Boccassi , Chao
> Zhu , Christian Ehrhardt
> , t...@jp.ibm.com
> Date: 11/07/2018 01:21 PM
> Subject: Re: [dpdk-dev] [PATCH] p
New test-case to cover (BPF_LD | BPF_IMM | EBPF_DW) instruction.
Signed-off-by: Konstantin Ananyev
---
test/test/test_bpf.c | 108 +++
1 file changed, 108 insertions(+)
diff --git a/test/test/test_bpf.c b/test/test/test_bpf.c
index fa17c4f74..1d50401aa 10
x86 jit can generate invalid code for (BPF_LD | BPF_IMM | EBPF_DW)
instructions, when immediate value is bigger then INT32_MAX.
Fixes: cc752e43e079 ("bpf: add JIT compilation for x86_64 ISA")
Signed-off-by: Konstantin Ananyev
---
lib/librte_bpf/bpf_jit_x86.c | 28
1
*** BLURB HERE ***
Konstantin Ananyev (2):
bpf: fix x86 jit for immediate loads
test/bpf: add test for immediate load
lib/librte_bpf/bpf_jit_x86.c | 28 ++---
test/test/test_bpf.c | 108 +++
2 files changed, 128 insertions(+), 8 deletions(-)
--
> -Original Message-
> From: Thomas Monjalon [mailto:tho...@monjalon.net]
> Sent: Thursday, November 8, 2018 1:26 PM
> To: Stojaczyk, Dariusz
> Cc: dev@dpdk.org; gaetan.ri...@6wind.com; Zhang, Qi Z
> ; Guo, Jia
> Subject: Re: [PATCH] devargs: do not replace already inserted devargs
>
>
08/11/2018 12:25, Stojaczyk, Dariusz:
> From: Thomas Monjalon [mailto:tho...@monjalon.net]
> >
> > The devargs of a device can be replaced by a newly allocated one
> > when trying to probe again the same device (multi-process or
> > multi-ports scenarios). This is breaking some pointer references.
On Tue, Nov 06, 2018 at 02:40:22PM +0800, Tiwei Bie wrote:
The param we are checking is VIRTIO_USER_ARG_PATH, instead
of VIRTIO_USER_ARG_QUEUE_SIZE.
Fixes: ce2eabdd43ec ("net/virtio-user: add virtual device")
Cc: sta...@dpdk.org
Signed-off-by: Tiwei Bie
---
drivers/net/virtio/virtio_user_ethde
On 07/11/2018 21:08, Thomas Monjalon wrote:
07/11/2018 19:10, Kevin Laatz:
Currently, telemetry is not working for shared builds in make.
The --as-needed flag is preventing telemetry from being linked as there are
no direct API calls from the app to telemetry. This is causing the
--telemetry op
One of the failure paths were not updated to clean up on exit,
most likely due to rebase error. Fix the failure path to clean
up instead of simply exiting.
Fixes: 3f9e31d71d63 ("test: clean up on exit")
Signed-off-by: Anatoly Burakov
---
test/test/test.c | 6 --
1 file changed, 4 insertions
> -Original Message-
> From: Thomas Monjalon [mailto:tho...@monjalon.net]
> Sent: Thursday, November 8, 2018 12:21 AM
> To: dev@dpdk.org
> Cc: gaetan.ri...@6wind.com; Zhang, Qi Z ; Guo, Jia
> ; Stojaczyk, Dariusz
> Subject: [PATCH] devargs: do not replace already inserted devargs
>
> Th
On 08-Nov-18 10:24 AM, Ilya Maximets wrote:
We should stop alarm handler before resetting the HW to
avoid concurrent device reconfiguration.
Fixes: 0408f47ba4d6 ("net/ixgbe: fix busy polling while fiber link update")
CC: sta...@dpdk.org
Signed-off-by: Ilya Maximets
---
Tested-by: Anatoly Bur
On 07.11.2018 18:52, Burakov, Anatoly wrote:
> On 01-Nov-18 4:04 PM, Ilya Maximets wrote:
>> If the multispeed fiber link is in DOWN state, ixgbe_setup_link
>> could take around a second of busy polling. This is highly
>> inconvenient for the case where single thread periodically
>> checks the link
We should stop alarm handler before resetting the HW to
avoid concurrent device reconfiguration.
Fixes: 0408f47ba4d6 ("net/ixgbe: fix busy polling while fiber link update")
CC: sta...@dpdk.org
Signed-off-by: Ilya Maximets
---
drivers/net/ixgbe/ixgbe_ethdev.c | 22 ++
1 file
> -Ãüþüþ-
> ·¢¼þÃÃ: Thomas Monjalon
> ·¢ÃÃñ¼ä: 2018Ãê11ÃÃ8Ãà 0:00
> ÃüþÃÃ: dev@dpdk.org
> ³ÂÃÃ: christian.ehrha...@canonical.com; adrien.mazarg...@6wind.com;
> shah...@mellanox.com; ys...@mellanox.com;
> gowrishanka...@linux.vnet.ibm.com; chao...@
From: Jeff Guo
> On 11/8/2018 3:28 PM, Matan Azrad wrote:
> >
> > From: Ananyev, Konstantin
> >>> -Original Message-
> >>> From: Guo, Jia
> >>> Sent: Wednesday, November 7, 2018 7:30 AM
> >>> To: Matan Azrad ; Ananyev, Konstantin
> >>> ; Burakov, Anatoly
> >>> ; Thomas Monjalon
> >> ;
>
> -Original Message-
> From: Adrien Mazarguil [mailto:adrien.mazarg...@6wind.com]
> Sent: Wednesday, November 07, 2018 6:41 PM
> To: Ophir Munk
> Cc: Ferruh Yigit ; Andrew Rybchenko
> ; dev@dpdk.org; Thomas Monjalon
> ; Asaf Penso ; Shahaf
> Shuler ; Olga Shern
> Subject: Re: [dpdk-dev
On 11/8/2018 3:28 PM, Matan Azrad wrote:
From: Ananyev, Konstantin
-Original Message-
From: Guo, Jia
Sent: Wednesday, November 7, 2018 7:30 AM
To: Matan Azrad ; Ananyev, Konstantin
; Burakov, Anatoly
; Thomas Monjalon
;
Iremonger, Bernard ; Wu, Jingjing
; Lu, Wenzhuo
Cc: Yigit, Fer
On 11/8/2018 3:20 PM, Matan Azrad wrote:
From: Jeff Guo
On 11/6/2018 2:23 PM, Matan Azrad wrote:
Hi Jeff
Can you detail more in the commit log that we can understand the
synchronization problematic scenario. And how does this commit fix it?
Please check my reply in the 1/3 mail. And explai
Wednesday, November 7, 2018 11:10 PM, Thomas Monjalon:
> Subject: Re: [PATCH] net/mlx5: fix build on PPC64
>
> 07/11/2018 20:05, dwilder:
> > On 2018-11-07 08:00, Thomas Monjalon wrote:
> > > The AltiVec header file breaks boolean type:
> > >
> > > error: incompatible types when initializing type
62 matches
Mail list logo
