[dpdk-dev] [PATCH v2 2/2] net/mlx5: fix typos

2018-11-13 Thread Ali Alnubani
Fixes: e1114ff6a5ab ("net/mlx5: support e-switch flow count action") Fixes: 974f1e7ef146 ("net/mlx5: add new memory region support") Cc: sta...@dpdk.org Signed-off-by: Ali Alnubani --- Changes in v2: - Fixed one more typo. drivers/net/mlx5/mlx5_flow_tcf.c | 2 +- drivers/net/mlx5/mlx5_

[dpdk-dev] [PATCH 1/2] net/mlx4: fix typo

2018-11-13 Thread Ali Alnubani
Fixes: 9797bfcce1c9 ("net/mlx4: add new memory region support") Cc: sta...@dpdk.org Signed-off-by: Ali Alnubani --- drivers/net/mlx4/mlx4_mr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/mlx4/mlx4_mr.c b/drivers/net/mlx4/mlx4_mr.c index bee858643..c2066ea4b 10

Re: [dpdk-dev] Where is the padding code in DPDK?

2018-11-13 Thread Sam
OK, then shortly speaking, DPDK will NOT care about padding. NIC will care about padding while send and recv with NIC. kernel will care about while send and recv with vhostuser port. Is that right? Burakov, Anatoly 于2018年11月13日周二 下午5:29写道: > On 13-Nov-18 7:16 AM, Sam wrote: > > Hi all, > > > >

Re: [dpdk-dev] [PATCH v1] app/testpmd: set default RSS key as NULL

2018-11-13 Thread Zhao1, Wei
Hi, Ophir Munk Peng yuan has find this problem with patch , if you use the following test step, You will find the problem. She is using i40e nic. ./x86_64-native-linuxapp-gcc/app/testpmd -c 1 -n 4 - -i --nb-cores=8 --rxq=4 --txq=4 --port-topology=chained ... testpmd> st

Re: [dpdk-dev] [PATCH v2] net/ixgbe: fix ixgbevf link status

2018-11-13 Thread Wang, Dong1
-Original Message- From: Wu, Yanglong Sent: Tuesday, November 13, 2018 14:35 To: dev@dpdk.org Cc: Zhang, Qi Z ; Xu, Rosen ; Wang, Dong1 ; Wu, Yanglong Subject: [PATCH v2] net/ixgbe: fix ixgbevf link status For ixgbevf kernel driver, link status changes from down to up will trigger vf

[dpdk-dev] [dpdk-announce] Agenda for DPDK Summit

2018-11-13 Thread O'Driscoll, Tim
The agenda for the DPDK Summit on December 3rd and 4th in San Jose is now available at: https://events.linuxfoundation.org/events/dpdknorthamerica2018/dpdk-na-program/agenda/. Thanks to everybody who submitted proposals. The quality of the submissions was very high, and it was a difficult job t

[dpdk-dev] [dpdk-announce] release candidate 18.11-rc3

2018-11-13 Thread Thomas Monjalon
A new DPDK release candidate is ready for testing: https://git.dpdk.org/dpdk/tag/?id=v18.11-rc3 86 patches were integrated. It is a snapshot in the middle of the bug fixing effort. We should get a fourth release candidate at the end of this week, and a fifth, mostly for last documentation

Re: [dpdk-dev] [dpdk-stable] [PATCH] net/i40e: add parameter check for RSS flow init

2018-11-13 Thread Zhao1, Wei
> -Original Message- > From: Yigit, Ferruh > Sent: Wednesday, November 14, 2018 7:11 AM > To: Zhao1, Wei ; dev@dpdk.org > Cc: Zhang, Qi Z ; sta...@dpdk.org; Peng, Yuan > > Subject: Re: [dpdk-stable] [PATCH] net/i40e: add parameter check for RSS > flow init > > On 11/12/2018 9:25 AM, Wei

[dpdk-dev] [PATCH] net/i40e: fix X710 Rx issue after reading some registers

2018-11-13 Thread Beilei Xing
There's an issue that X710 can't receive any packet after reading some special registers. That's because these registers are only valid for X722, read access for non-X722 will cause ECC error. Fixes: d9efd0136ac1 ("i40e: add EEPROM and registers dumping") Cc: sta...@dpdk.org Signed-off-by: Beilei

Re: [dpdk-dev] [PATCH] test: add missing cleanup to one of the failure paths

2018-11-13 Thread Thomas Monjalon
08/11/2018 12:44, Anatoly Burakov: > One of the failure paths were not updated to clean up on exit, > most likely due to rebase error. Fix the failure path to clean > up instead of simply exiting. > > Fixes: 3f9e31d71d63 ("test: clean up on exit") > > Signed-off-by: Anatoly Burakov Applied, tha

[dpdk-dev] 答复: Re: [PATCH v3] app/proc-info: fix port mask parse issue

2018-11-13 Thread han.li1
Hi, below is maintainer's suggestion,and I think it's ok to do these changes? > -Original Message-> From: dev [mailto:dev-boun...@dpdk.org] On Behalf > Of Li HanTo avoid typecast below , please use uint64_t for enabled_port_mask. > So change below function return type to uint64_t> -stat

Re: [dpdk-dev] [dpdk-stable] [PATCH] test/reorder: fix out of bound access

2018-11-13 Thread Thomas Monjalon
14/11/2018 00:31, Ferruh Yigit: > The value of array index 'i' is out of bound because of the previous > loop it has been used. > > Assuming intention is using '0' since the check before free is robufs[0] > check, fixing according. > > Fixes: ecd867faa860 ("test/reorder: fix freeing mbuf twice")

Re: [dpdk-dev] [PATCH] test: fix to skip kni autotest

2018-11-13 Thread Thomas Monjalon
13/11/2018 17:08, Pattan, Reshma: > From: Poornima, PallantlaX > > > > Kni_autotest should be skipped if rte_kni.ko module is not loaded. > > Hence changed return as TEST_SKIPPED. > > > > Fixes: ee1caebc4d ("test/kni: check module dependency") > > Cc: sta...@dpdk.org > > > > Signed-off-by: Palla

Re: [dpdk-dev] [PATCH] test: fix to skip power acpi cpufreq autotest

2018-11-13 Thread Thomas Monjalon
13/11/2018 17:07, Pattan, Reshma: > From: Poornima, PallantlaX > > > > Power_acpi_cpufreq_autotest should not be run on VM and platforms which > > dont have acpi_cpufreq module loaded. > > Hence changed return as TEST_SKIPPED > > > > Fixes: 0ea2dd4409 ("test: skip when required lib not available"

Re: [dpdk-dev] [PATCH v2] eal: clean up unused files on initialization

2018-11-13 Thread Thomas Monjalon
14/11/2018 04:24, Varghese, Vipin: > Tested-by: Vipin Varghese > > > > > >> When creating process data structures, EAL will create many files in > > >> EAL runtime directory. Because we allow multiple secondary processes > > >> to run, each secondary process gets their own unique file. With ma

Re: [dpdk-dev] [PATCH] examples/l3fwd-power: fix prog exit on ini pwr lib

2018-11-13 Thread Thomas Monjalon
07/11/2018 15:21, Hunt, David: > Hi Mordechay, > > On 7/11/2018 2:09 PM, Mordechay Haimovsky wrote: > > This patch replaces the rte_exit routine with error printing when > > init_power_library() fails and by that restores the previous behavior > > of the program (which was to issue an error messag

Re: [dpdk-dev] [PATCH v2] eal: clean up unused files on initialization

2018-11-13 Thread Varghese, Vipin
Tested-by: Vipin Varghese > >> When creating process data structures, EAL will create many files in > >> EAL runtime directory. Because we allow multiple secondary processes > >> to run, each secondary process gets their own unique file. With many > >> secondary processes running and exiting o

Re: [dpdk-dev] [PATCH] doc: cryptodev deprecation notice for sym session changes

2018-11-13 Thread Joseph, Anoob
Hi Akhil, Konstantin, Wouldn't the new element, userdata, conflict with the one referred by rte_cryptodev_sym_session_set_user_data() rte_cryptodev_sym_session_get_user_data() Do you mind a name change for either? Or do you have a clear picture of when one should be used over the other? Thanks

Re: [dpdk-dev] [PATCH v3] app/proc-info: fix port mask parse issue

2018-11-13 Thread Thomas Monjalon
Hi, 07/11/2018 07:10, Li Han: > parse_portmask return type is int,but global variable > "enabled_port_mask" type is uint32_t.so in proc_info_parse_args > function,when parse_portmask return -1,"enabled_port_mask" will > get a huge value and "if (enabled_port_mask == 0)" will never happen. > > Fix

Re: [dpdk-dev] [PATCH v2] example/ipv4_multicast: fix app hanging when using clone

2018-11-13 Thread Wang, Dong1
Hi Herakliusz, Since pkt->ol_flags might set some other bits except IND_ATTACHED_MBUF, how about set its value to original pkt->ol_flags? Regards, Dong -Original Message- From: Lipiec, Herakliusz Sent: Tuesday, November 13, 2018 19:49 To: dev@dpdk.org Cc: Ananyev, Konstantin ; Wang, Do

Re: [dpdk-dev] [PATCH] doc/proc_info: update support for vdev stats

2018-11-13 Thread Thomas Monjalon
09/11/2018 23:03, Ferruh Yigit: > On 10/12/2018 12:35 PM, Vipin Varghese wrote: > > With the latest release, support for vdev ethernet devices like pcap, > > tun and tap are been added. Hence collecting statistics using proc-info > > is possible now. > > > > Signed-off-by: Vipin Varghese > > Rev

Re: [dpdk-dev] [PATCH v3 2/2] ethdev: device configuration enhancement

2018-11-13 Thread Lu, Wenzhuo
Hi Ferruh, > -Original Message- > From: Yigit, Ferruh > Sent: Tuesday, November 13, 2018 5:41 PM > To: Lu, Wenzhuo ; Andrew Rybchenko > ; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v3 2/2] ethdev: device configuration > enhancement > > On 11/13/2018 12:46 AM, Lu, Wenzhuo wrote: > > Hi

Re: [dpdk-dev] [PATCH 0/4] Coverity issue fixes

2018-11-13 Thread Thomas Monjalon
06/11/2018 20:30, Stephen Hemminger: > These are all error path issues and should not matter in > a real application; most of the error are impossible to cause > and applications just fail if setup fails. > > Stephen Hemminger (4): > net/failsafe: avoid rte_memcpy if rte_realloc fails > bus/vm

Re: [dpdk-dev] [PATCH] doc: cryptodev deprecation notice for sym session changes

2018-11-13 Thread Trahe, Fiona
> -Original Message- > From: Akhil Goyal [mailto:akhil.go...@nxp.com] > Sent: Monday, November 12, 2018 5:04 AM > To: Ananyev, Konstantin ; dev@dpdk.org; Ravi > Kumar > ; Jerin Jacob ; Anoob > Joseph > ; Doherty, Declan > ; Trahe, Fiona > ; Tomasz Duszynski ; Dmitri > Epshtein ; > Nat

Re: [dpdk-dev] [PATCH v2] mk: allow renaming of build directories

2018-11-13 Thread Thomas Monjalon
12/11/2018 13:26, Bruce Richardson: > When building using make, the Makefile in the build directory contained > the name of the build directory to be passed as an "O=" parameter to > the DPDK SDK makefiles. Unfortunately, this meant that the compilation > would always fail if the build directory wa

Re: [dpdk-dev] [RFC] cryptodev: proposed changes in rte_cryptodev_sym_session

2018-11-13 Thread Trahe, Fiona
Hi Konstantin, //snip/// > Can you also have a look at related deprecation note: > http://patches.dpdk.org/patch/46633/ > and provide the feedback? > Konstantin [Fiona] will do > > [Fiona] Ok, I agree with this issue and proposed fix. > > We need to also document that it's user's responsibilit

Re: [dpdk-dev] [PATCH v2] doc: add kni changes to release note

2018-11-13 Thread Ferruh Yigit
On 11/5/2018 7:54 PM, Dan Gora wrote: > Add the new module parameter for the KNI kernel module, the new command > line flag for the KNI sample application, and the new API function > 'rte_kni_update_link()' to the release note. > > Signed-off-by: Dan Gora Acked-by: Ferruh Yigit

Re: [dpdk-dev] [PATCH] eal/x86: move header to standard BSD license

2018-11-13 Thread Thomas Monjalon
04/01/2018 22:22, Thomas Monjalon: > Andi Kleen, as the original author, please could you ack? > > 21/12/2017 17:53, Bruce Richardson: > > This updates the license on the rte_rtm.h file to be the standard > > BSD-3-Clause license used for the rest of DPDK, thus bringing the file in > > compliance

Re: [dpdk-dev] [PATCH v2 0/4] fixes for rte_hash with TSX

2018-11-13 Thread Thomas Monjalon
12/11/2018 11:47, Bruce Richardson: > When testing with rte_hash library and TSX, a higher level of transaction > aborts was observed in some cases, especially with newer compilers. These > patches reduce aborts by ensuring that the compiler does not accidentally > insert instructions that cause a

Re: [dpdk-dev] [PATCH 1/1] eal: Don't fail secondary if primary is missing tailqs

2018-11-13 Thread Burdick, Cliff
From: Thomas Monjalon [tho...@monjalon.net] Sent: Tuesday, November 13, 2018 2:18 PM To: Burdick, Cliff Cc: Burakov, Anatoly; dev@dpdk.org; bruce.richard...@intel.com Subject: Re: [dpdk-dev] [PATCH 1/1] eal: Don't fail secondary if primary is missing tail

[dpdk-dev] [PATCH] test/reorder: fix out of bound access

2018-11-13 Thread Ferruh Yigit
The value of array index 'i' is out of bound because of the previous loop it has been used. Assuming intention is using '0' since the check before free is robufs[0] check, fixing according. Fixes: ecd867faa860 ("test/reorder: fix freeing mbuf twice") Cc: sta...@dpdk.org Signed-off-by: Ferruh Yig

Re: [dpdk-dev] [dpdk-stable] [PATCH] net/i40e: add parameter check for RSS flow init

2018-11-13 Thread Ferruh Yigit
On 11/12/2018 9:25 AM, Wei Zhao wrote: > There need an parameter check for RSS flow init, or it may cause > core dump if pointer is NULL in memory copy. > > Fixes: ac8d22de2394 ("ethdev: flatten RSS configuration in flow API") > > Signed-off-by: Wei Zhao > --- > drivers/net/i40e/i40e_ethdev.c |

Re: [dpdk-dev] [PATCH v2] eal/mp: remove rte_panic and profanity

2018-11-13 Thread Thomas Monjalon
13/11/2018 19:03, Anatoly Burakov: > EAL should not crash when setting alarm fails. Also, remove the > profanity in error message. > > Fixes: daf9bfca717e ("ipc: remove thread for async requests") > > Cc: sta...@dpdk.org > Cc: step...@networkplumber.org > > Signed-off-by: Stephen Hemminger > Si

Re: [dpdk-dev] [PATCH] net/i40e: add parameter check for RSS flow init

2018-11-13 Thread Zhang, Qi Z
> -Original Message- > From: Zhao1, Wei > Sent: Monday, November 12, 2018 1:25 AM > To: dev@dpdk.org > Cc: Zhang, Qi Z ; sta...@dpdk.org; Peng, Yuan > ; Zhao1, Wei > Subject: [PATCH] net/i40e: add parameter check for RSS flow init > > There need an parameter check for RSS flow init, or

Re: [dpdk-dev] FW: [PATCH] net/i40e: add parameter check for RSS flow init

2018-11-13 Thread Zhang, Qi Z
> -Original Message- > From: Yigit, Ferruh > Sent: Tuesday, November 13, 2018 1:28 PM > To: Zhao1, Wei ; ophi...@mellanox.com; Zhang, Qi > Z > Cc: dev@dpdk.org; Peng, Yuan ; Adrien Mazarguil > > Subject: Re: [dpdk-dev] FW: [PATCH] net/i40e: add parameter check for RSS > flow init > > O

Re: [dpdk-dev] [PATCH v2] test/bpf: use hton instead of _builtin_bswap

2018-11-13 Thread Thomas Monjalon
06/11/2018 11:17, Ananyev, Konstantin: > > Hi Malvika, > > > From: Malvika Gupta > > > > Convert host machine endianness to networking endianness for > > comparison of incoming packets with BPF filter > > > > Suggested-by: Brian Brooks > > Signed-off-by: Malvika Gupta > > Reviewed-by: Gavin

Re: [dpdk-dev] [PATCH 0/2] bpf: fix x86 jit issue

2018-11-13 Thread Thomas Monjalon
08/11/2018 13:36, Konstantin Ananyev: > *** BLURB HERE *** > > Konstantin Ananyev (2): > bpf: fix x86 jit for immediate loads > test/bpf: add test for immediate load Applied, thanks

Re: [dpdk-dev] [PATCH 1/1] eal: Don't fail secondary if primary is missing tailqs

2018-11-13 Thread Thomas Monjalon
13/11/2018 23:08, Burdick, Cliff: > From: Thomas Monjalon [mailto:tho...@monjalon.net] > > 13/11/2018 17:38, Burdick, Cliff: > > > From: Thomas Monjalon [mailto:tho...@monjalon.net] > > > 13/11/2018 16:45, Burdick, Cliff: > > > > From: Burakov, Anatoly [mailto:anatoly.bura...@intel.com] > > > > >

Re: [dpdk-dev] [PATCH 1/1] eal: Don't fail secondary if primary is missing tailqs

2018-11-13 Thread Burdick, Cliff
-Original Message- From: Thomas Monjalon [mailto:tho...@monjalon.net] Sent: Tuesday, November 13, 2018 8:44 AM To: Burdick, Cliff Cc: Burakov, Anatoly; dev@dpdk.org; bruce.richard...@intel.com Subject: Re: [dpdk-dev] [PATCH 1/1] eal: Don't fail secondary if primary is missing tailqs 1

Re: [dpdk-dev] FW: [PATCH] net/i40e: add parameter check for RSS flow init

2018-11-13 Thread Ferruh Yigit
On 11/13/2018 2:41 AM, Zhao1, Wei wrote: > Add Ophir Munk for discussion. > > >> -Original Message- >> From: Peng, Yuan >> Sent: Tuesday, November 13, 2018 10:27 AM >> To: Zhao1, Wei ; Adrien Mazarguil >> >> Cc: dev@dpdk.org >> Subject: RE: FW: [PATCH] net/i40e: add parameter check for R

Re: [dpdk-dev] [PATCH v2] net/ixgbe: fix ixgbevf link status

2018-11-13 Thread Zhang, Qi Z
> -Original Message- > From: Wu, Yanglong > Sent: Monday, November 12, 2018 10:35 PM > To: dev@dpdk.org > Cc: Zhang, Qi Z ; Xu, Rosen ; > Wang, Dong1 ; Wu, Yanglong > > Subject: [PATCH v2] net/ixgbe: fix ixgbevf link status > > For ixgbevf kernel driver, link status changes from down t

Re: [dpdk-dev] [PATCH v2] net/pcap: enable data path on secondary

2018-11-13 Thread Zhang, Qi Z
> -Original Message- > From: Yigit, Ferruh > Sent: Tuesday, November 13, 2018 10:44 AM > To: Zhang, Qi Z ; Thomas Monjalon > > Cc: dev@dpdk.org; Lin, Xueqin > Subject: Re: [PATCH v2] net/pcap: enable data path on secondary > > On 11/13/2018 6:27 PM, Zhang, Qi Z wrote: > > First, apolog

[dpdk-dev] [PATCH 1/2] net/mlx4: fix typo

2018-11-13 Thread Ali Alnubani
Fixes: 9797bfcce1c9 ("net/mlx4: add new memory region support") Cc: sta...@dpdk.org Signed-off-by: Ali Alnubani --- drivers/net/mlx4/mlx4_mr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/mlx4/mlx4_mr.c b/drivers/net/mlx4/mlx4_mr.c index bee858643..c2066ea4b 10

[dpdk-dev] [PATCH 2/2] net/mlx5: fix typo

2018-11-13 Thread Ali Alnubani
Fixes: e1114ff6a5ab ("net/mlx5: support e-switch flow count action") Cc: sta...@dpdk.org Signed-off-by: Ali Alnubani --- drivers/net/mlx5/mlx5_flow_tcf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/mlx5/mlx5_flow_tcf.c b/drivers/net/mlx5/mlx5_flow_tcf.c index

[dpdk-dev] [PATCH 2/2] net/mlx5: fix initialization of struct members

2018-11-13 Thread Ali Alnubani
This patch fixes compilation errors with meson and the clang compiler caused by some of the struct members not being initialized. ``` ../drivers/net/mlx5/mlx5_mr.c:345:37: error: missing field 'end' initializer [-Werror,-Wmissing-field-initializers] struct mlx5_mr_cache entry = { 0

[dpdk-dev] [PATCH 1/2] net/mlx4: fix initialization of struct members

2018-11-13 Thread Ali Alnubani
This patch fixes compilation errors with meson and the clang compiler caused by some of the struct members not being initialized. ``` ../drivers/net/mlx4/mlx4_mr.c:357:37: error: missing field 'end' initializer [-Werror,-Wmissing-field-initializers] struct mlx4_mr_cache entry = { 0

Re: [dpdk-dev] [RFC] cryptodev: proposed changes in rte_cryptodev_sym_session

2018-11-13 Thread Ananyev, Konstantin
> -Original Message- > From: Trahe, Fiona > Sent: Monday, November 12, 2018 11:25 PM > To: Ananyev, Konstantin ; dev@dpdk.org > Cc: De Lara Guarch, Pablo ; Akhil Goyal > ; Doherty, Declan > ; Ravi Kumar ; Jerin Jacob > ; Zhang, Roy Fan > ; Tomasz Duszynski ; Hemant > Agrawal ; Natalie

Re: [dpdk-dev] [RFC] cryptodev: proposed changes in rte_cryptodev_sym_session

2018-11-13 Thread Ananyev, Konstantin
Hi Fiona, > -Original Message- > From: Trahe, Fiona > Sent: Monday, November 12, 2018 9:01 PM > To: Ananyev, Konstantin ; dev@dpdk.org > Cc: De Lara Guarch, Pablo ; Akhil Goyal > ; Doherty, Declan > ; Ravi Kumar ; Jerin Jacob > ; Zhang, Roy Fan > ; Tomasz Duszynski ; Hemant > Agrawal ;

Re: [dpdk-dev] [PATCH v2] net/pcap: enable data path on secondary

2018-11-13 Thread Ferruh Yigit
On 11/13/2018 6:27 PM, Zhang, Qi Z wrote: > First, apologies to make this in rush since I was somehow under pressure to > make pdump works in 18.11. > I agree there is lot of things need to improve, but the strategy here is to > make it work quietly and not break anything else :) > add some comm

Re: [dpdk-dev] [PATCH v2] ethdev: document RSS default key and types

2018-11-13 Thread Shahaf Shuler
Hi Adrien, Tuesday, November 13, 2018 7:15 PM, Adrien Mazarguil: > Subject: Re: [dpdk-dev] [PATCH v2] ethdev: document RSS default key and > types > > Again a bit late to the party, please see below. > > On Sun, Nov 11, 2018 at 09:35:22AM +, Ori Kam wrote: [...] > > > The setfault is the

Re: [dpdk-dev] [PATCH v2] net/pcap: enable data path on secondary

2018-11-13 Thread Zhang, Qi Z
First, apologies to make this in rush since I was somehow under pressure to make pdump works in 18.11. I agree there is lot of things need to improve, but the strategy here is to make it work quietly and not break anything else :) add some comments inline. > -Original Message- > From: T

Re: [dpdk-dev] [PATCH v2] ethdev: document RSS default key and types

2018-11-13 Thread Ophir Munk
> -Original Message- > From: Adrien Mazarguil [mailto:adrien.mazarg...@6wind.com] > Sent: Tuesday, November 13, 2018 7:15 PM > To: Ori Kam > Cc: Ophir Munk ; Yongseok Koh > ; Andrew Rybchenko > ; Ferruh Yigit ; > dev@dpdk.org; Thomas Monjalon ; Asaf Penso > ; Shahaf Shuler ; Olga > Sher

[dpdk-dev] [PATCH v2] eal/mp: remove rte_panic and profanity

2018-11-13 Thread Anatoly Burakov
EAL should not crash when setting alarm fails. Also, remove the profanity in error message. Fixes: daf9bfca717e ("ipc: remove thread for async requests") Cc: sta...@dpdk.org Cc: step...@networkplumber.org Signed-off-by: Stephen Hemminger Signed-off-by: Anatoly Burakov --- Notes: v2: fix u

Re: [dpdk-dev] [PATCH] net/enic: fix the size check in Tx prepare handler

2018-11-13 Thread Ferruh Yigit
On 11/13/2018 3:38 PM, Hyong Youb Kim wrote: > The current code wrongly assumes that packets are non-TSO and ends up > rejecting large TSO packets. Check non-TSO and TSO max packet sizes > separately. > > Fixes: 5a12c387405a ("net/enic: check maximum packet size in Tx prepare > handler") > Cc: st

Re: [dpdk-dev] [dpdk-stable] [PATCH] net/sfc/base: fix field order in filter spec struct

2018-11-13 Thread Ferruh Yigit
On 11/13/2018 3:02 PM, Andrew Rybchenko wrote: > From: Igor Romanov > > Fields in the struct efx_filter_spec_t starting from efs_outer_vid > are hashed for software filter lookup. efs_mark is not a matching > criteria. Exclude efs_mark from hash. > > Fixes: 5f78af523912 ("net/sfc: support MARK a

[dpdk-dev] [PATCH 19.02 0/2] Allow using virtio without hugepages

2018-11-13 Thread Anatoly Burakov
It is already possible to use both DPDK in general and virtio specifically, without hugetlbfs mounts, but currently virtio cannot be used without hugepage memory (i.e. with a --no-huge EAL switch) due to the fact that it needs to share memory with the backend. This patchset uses memfd to create ac

[dpdk-dev] [PATCH 19.02 1/2] memalloc: allow setting up segment list fd's

2018-11-13 Thread Anatoly Burakov
Currently, only segment fd's for multi-file segments are supported, while for memfd-backed no-huge memory we need single-file segments mode. Add support for single-file segments in the internal API. Signed-off-by: Anatoly Burakov --- lib/librte_eal/bsdapp/eal/eal_memalloc.c | 6 ++ lib/li

[dpdk-dev] [PATCH 19.02 2/2] mem: use memfd for no-huge mode

2018-11-13 Thread Anatoly Burakov
When running in no-huge mode, we anonymously allocate our memory. While this works for regular NICs and vdev's, it's not suitable for memory sharing scenarios such as virtio with vhost_user backend. To fix this, allocate no-huge memory using memfd, and register it with memalloc just like any other

Re: [dpdk-dev] [PATCH v4 1/3] ethdev: fix invalid device configuration after failure

2018-11-13 Thread Ferruh Yigit
On 11/13/2018 11:19 AM, Andrew Rybchenko wrote: > On 11/13/18 2:12 PM, Ferruh Yigit wrote: >> From: Wenzhuo Lu >> >> The new configuration is stored during the rte_eth_dev_configure() API >> but the API may fail. After failure stored configuration will be >> invalid since it is not fully applied t

Re: [dpdk-dev] [dpdk-stable] [PATCH v2 2/4] hash: add local cache for TSX region

2018-11-13 Thread Bruce Richardson
On Tue, Nov 13, 2018 at 05:24:55PM +, Wang, Yipeng1 wrote: > >-Original Message- > >From: Honnappa Nagarahalli [mailto:honnappa.nagaraha...@arm.com] > >Sent: Tuesday, November 13, 2018 9:17 AM > >To: Thomas Monjalon ; Richardson, Bruce > >; Wang, Yipeng1 > > > >Cc: sta...@dpdk.org; dev

Re: [dpdk-dev] [PATCH v2] eal: clean up unused files on initialization

2018-11-13 Thread Burakov, Anatoly
On 13-Nov-18 4:57 PM, Thomas Monjalon wrote: 13/11/2018 16:54, Anatoly Burakov: When creating process data structures, EAL will create many files in EAL runtime directory. Because we allow multiple secondary processes to run, each secondary process gets their own unique file. With many secondary

[dpdk-dev] [PATCH 1/2] rwlock: introduce 'try' semantics for RD and WR locking

2018-11-13 Thread Konstantin Ananyev
This patch targets 19.02 release. Introduce rte_rwlock_read_trylock() and rte_rwlock_write_trylock(). Signed-off-by: Konstantin Ananyev --- .../common/include/generic/rte_rwlock.h | 54 +++ lib/librte_eal/rte_eal_version.map| 2 + 2 files changed, 56 insertions

[dpdk-dev] [PATCH 0/2] Add 'try' semantics for RD and WR locking

2018-11-13 Thread Konstantin Ananyev
This series targets 19.02 release Introduce rte_rwlock_read_trylock() and rte_rwlock_write_trylock() and new UT test-case for it. Konstantin Ananyev (2): rwlock: introduce 'try' semantics for RD and WR locking test: add new test-cases for rwlock autotest .../common/include/generic/rte_rwloc

[dpdk-dev] [PATCH 2/2] test: add new test-cases for rwlock autotest

2018-11-13 Thread Konstantin Ananyev
This patch targets 19.02 release. Add few functional and perfomance tests for rte_rwlock_read_trylock() and rte_rwlock_write_trylock(). Signed-off-by: Konstantin Ananyev --- test/test/test_rwlock.c | 405 ++-- 1 file changed, 386 insertions(+), 19 deletions(-

Re: [dpdk-dev] [dpdk-stable] [PATCH v2 2/4] hash: add local cache for TSX region

2018-11-13 Thread Wang, Yipeng1
>-Original Message- >From: Honnappa Nagarahalli [mailto:honnappa.nagaraha...@arm.com] >Sent: Tuesday, November 13, 2018 9:17 AM >To: Thomas Monjalon ; Richardson, Bruce >; Wang, Yipeng1 > >Cc: sta...@dpdk.org; dev@dpdk.org; nd ; nd >Subject: RE: [dpdk-stable] [dpdk-dev] [PATCH v2 2/4] has

Re: [dpdk-dev] [dpdk-stable] [PATCH v2 2/4] hash: add local cache for TSX region

2018-11-13 Thread Honnappa Nagarahalli
> > > > > > From: Yipeng Wang > > > > > > This patch adds back the local cache when TSX support is turned on. > > > > > > When TSX is turned on, free key-data slot ring would be contended by > > > various TSX regions. The purpose of this commit is to reduce > > > possible memory collisions during

Re: [dpdk-dev] [PATCH v2] ethdev: document RSS default key and types

2018-11-13 Thread Adrien Mazarguil
Again a bit late to the party, please see below. On Sun, Nov 11, 2018 at 09:35:22AM +, Ori Kam wrote: > > -Original Message- > > From: dev On Behalf Of Ophir Munk > > Sent: Friday, November 9, 2018 10:14 AM > > To: Yongseok Koh ; Adrien Mazarguil > > ; Andrew Rybchenko > > > > Cc: Fe

Re: [dpdk-dev] [PATCH v2] net/pcap: enable data path on secondary

2018-11-13 Thread Thomas Monjalon
Just a quick comment: There are probably some ideas to take from what was done for tap. 13/11/2018 17:56, Ferruh Yigit: > On 11/12/2018 4:51 PM, Qi Zhang wrote: > > Private vdev on secondary is never supported by the new shared > > device mode but pdump still relies on a private pcap PMD on secon

[dpdk-dev] [PATCH] net/pcap: fix pcap handlers for secondary

2018-11-13 Thread Ferruh Yigit
The intension in NOT to make a complete patch, this is to just for input to discussion. Signed-off-by: Ferruh Yigit --- drivers/net/pcap/rte_eth_pcap.c | 61 - 1 file changed, 52 insertions(+), 9 deletions(-) diff --git a/drivers/net/pcap/rte_eth_pcap.c b/drivers

Re: [dpdk-dev] [PATCH] app/pdump: fix port id storage size

2018-11-13 Thread Pattan, Reshma
> -Original Message- > From: Kovacevic, Marko > Sent: Tuesday, November 13, 2018 2:27 PM > To: dev@dpdk.org > Cc: Yigit, Ferruh ; Pattan, Reshma > ; Kovacevic, Marko ; > Yang, Zhiyong > Subject: [PATCH] app/pdump: fix port id storage size > > port_id size should be uint16_t, > fix wher

[dpdk-dev] [Bug 106] running dpdk-procinfo or any secondary leading to system memory exhaustion

2018-11-13 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=106 Vipin Varghese (vipin.vargh...@intel.com) changed: What|Removed |Added Status|IN_PROGRESS |RESOLVED Resol

Re: [dpdk-dev] [PATCH] pci: fix parsing of address without function number

2018-11-13 Thread Thomas Monjalon
12/11/2018 10:29, Gaëtan Rivet: > On Mon, Nov 12, 2018 at 12:58:56AM +0100, Thomas Monjalon wrote: > > If the last part of the PCI address (function number) is missing, > > the parsing was successful, assuming function 0. > > The call to strtoul is not returning an error in such a case, > > so an e

Re: [dpdk-dev] [PATCH v2] eal: clean up unused files on initialization

2018-11-13 Thread Thomas Monjalon
13/11/2018 16:54, Anatoly Burakov: > When creating process data structures, EAL will create many files > in EAL runtime directory. Because we allow multiple secondary > processes to run, each secondary process gets their own unique > file. With many secondary processes running and exiting on the >

Re: [dpdk-dev] [PATCH] lib: fix write unlock during ring creation

2018-11-13 Thread Pattan, Reshma
> -Original Message- > From: Chaitanya Babu, TalluriX > Sent: Tuesday, November 13, 2018 12:55 PM > To: dev@dpdk.org > Cc: Marohn, Byron ; Pattan, Reshma > ; De Lara Guarch, Pablo > ; Chaitanya Babu, TalluriX > ; sta...@dpdk.org > Subject: [PATCH] lib: fix write unlock during ring creati

Re: [dpdk-dev] [PATCH v2] net/pcap: enable data path on secondary

2018-11-13 Thread Ferruh Yigit
On 11/12/2018 4:51 PM, Qi Zhang wrote: > Private vdev on secondary is never supported by the new shared > device mode but pdump still relies on a private pcap PMD on secondary. > The patch enables pcap PMD's data path on secondary so that pdump can > work as usual. It would be great if you describ

[dpdk-dev] [PATCH] examples/bond: fix initialization error

2018-11-13 Thread Radu Nicolau
Queue setup will fail if called before adding slaves. Fixes: 7a0665940fa8 ("net/bonding: inherit descriptor limits from slaves") Cc: sta...@dpdk.org Signed-off-by: Radu Nicolau --- examples/bond/main.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/examples/b

Re: [dpdk-dev] [PATCH 1/1] eal: Don't fail secondary if primary is missing tailqs

2018-11-13 Thread Thomas Monjalon
13/11/2018 17:38, Burdick, Cliff: > > -Original Message- > From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Tuesday, November 13, 2018 8:07 AM > To: Burdick, Cliff > Cc: Burakov, Anatoly; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH 1/1] eal: Don't fail secondary if primary is

Re: [dpdk-dev] [PATCH] lib: fix to free trail queue entry after use

2018-11-13 Thread Pattan, Reshma
> -Original Message- > From: Vemula, Hari KumarX > Sent: Tuesday, November 13, 2018 11:46 AM > To: dev@dpdk.org > Cc: Pattan, Reshma ; Marohn, Byron > ; De Lara Guarch, Pablo > ; Vemula, Hari KumarX > ; sta...@dpdk.org > Subject: [PATCH] lib: fix to free trail queue entry after use Nit:

[dpdk-dev] [PATCH] devbind: don't display non-existent device categories

2018-11-13 Thread Anatoly Burakov
If there aren't any devices of a particular category on user's system, we still display them, which is bad for usability. Fix devbind to not print out a category unless there are devices in it. Signed-off-by: Anatoly Burakov --- usertools/dpdk-devbind.py | 27 --- 1 file

Re: [dpdk-dev] [dpdk-stable] [PATCH v2 2/4] hash: add local cache for TSX region

2018-11-13 Thread Thomas Monjalon
12/11/2018 19:34, Honnappa Nagarahalli: > > > > From: Yipeng Wang > > > > This patch adds back the local cache when TSX support is turned on. > > > > When TSX is turned on, free key-data slot ring would be contended by various > > TSX regions. The purpose of this commit is to reduce possible me

Re: [dpdk-dev] [PATCH 1/1] eal: Don't fail secondary if primary is missing tailqs

2018-11-13 Thread Burdick, Cliff
-Original Message- From: Thomas Monjalon [mailto:tho...@monjalon.net] Sent: Tuesday, November 13, 2018 8:07 AM To: Burdick, Cliff Cc: Burakov, Anatoly; dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH 1/1] eal: Don't fail secondary if primary is missing tailqs 13/11/2018 16:45, Burdick, Cl

Re: [dpdk-dev] [PATCH v2 1/1] hash: separate lf and rw lock lookup code paths

2018-11-13 Thread Thomas Monjalon
11/11/2018 08:48, Jerin Jacob: > > > > The lock-free algorithm has caused significant lookup > > performance regression for certain use cases. The > > regression is attributed to the use of non-relaxed > > memory orderings. 2 versions of the lookup functions > > are created. One that uses the RW l

Re: [dpdk-dev] [PATCH] test: fix to skip kni autotest

2018-11-13 Thread Pattan, Reshma
> -Original Message- > From: Poornima, PallantlaX > Sent: Tuesday, November 13, 2018 2:00 PM > To: dev@dpdk.org > Cc: Pattan, Reshma ; Yigit, Ferruh > ; Poornima, PallantlaX > ; sta...@dpdk.org > Subject: [PATCH] test: fix to skip kni autotest > > Kni_autotest should be skipped if rte_k

Re: [dpdk-dev] [PATCH] test: fix to skip power acpi cpufreq autotest

2018-11-13 Thread Pattan, Reshma
> -Original Message- > From: Poornima, PallantlaX > Sent: Tuesday, November 13, 2018 1:58 PM > To: dev@dpdk.org > Cc: Pattan, Reshma ; Hunt, David > ; Poornima, PallantlaX > ; sta...@dpdk.org > Subject: [PATCH] test: fix to skip power acpi cpufreq autotest > > Power_acpi_cpufreq_autotes

Re: [dpdk-dev] [PATCH 1/1] eal: Don't fail secondary if primary is missing tailqs

2018-11-13 Thread Thomas Monjalon
13/11/2018 16:45, Burdick, Cliff: > From: Burakov, Anatoly [mailto:anatoly.bura...@intel.com] > > On 13-Nov-18 9:21 AM, Thomas Monjalon wrote: > > > 13/11/2018 00:33, Burdick, Cliff: > > >> This patch was submitted by Jean Tourrilhes over two years ago, but > > >> didn't receive any responses. I h

[dpdk-dev] [PATCH v2] devbind: check for lspci

2018-11-13 Thread Anatoly Burakov
On some distributions (such as CentOS 7) lspci may not be installed by default, causing exceptions which are difficult to interpret. Fix devbind script to check if lspci is installed at script startup. Cc: sta...@dpdk.org Signed-off-by: Anatoly Burakov --- Notes: v2: correct package name t

Re: [dpdk-dev] [dpdk-stable] [PATCH] devbind: check for lspci

2018-11-13 Thread Burakov, Anatoly
On 07-Nov-18 4:01 PM, Ferruh Yigit wrote: On 11/7/2018 1:56 PM, Anatoly Burakov wrote: On some distributions (such as CentOS 7) lspci may not be installed by default, causing exceptions which are difficult to interpret. Fix devbind script to check if lspci is installed at script startup. I gu

Re: [dpdk-dev] [PATCH v1 0/2] ring C11 library fix and optimization

2018-11-13 Thread Thomas Monjalon
09/11/2018 12:42, Gavin Hu: > V1: > Update the ring C11 library including the following changes: > 1) On relaxed ordering platforms(like Arm64,PPPC), in ring C11 implementation, >loading head and tail might be reodered, this makes CAS(compare and retry >the flow if the head is outdated) not

[dpdk-dev] [PATCH v2] eal: clean up unused files on initialization

2018-11-13 Thread Anatoly Burakov
When creating process data structures, EAL will create many files in EAL runtime directory. Because we allow multiple secondary processes to run, each secondary process gets their own unique file. With many secondary processes running and exiting on the system, runtime directory will, over time, cr

Re: [dpdk-dev] [PATCH 1/1] eal: Don't fail secondary if primary is missing tailqs

2018-11-13 Thread Burdick, Cliff
-Original Message- From: Burakov, Anatoly [mailto:anatoly.bura...@intel.com] Sent: Tuesday, November 13, 2018 1:39 AM To: Thomas Monjalon; Burdick, Cliff Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH 1/1] eal: Don't fail secondary if primary is missing tailqs On 13-Nov-18 9:21 AM, Th

[dpdk-dev] [PATCH] net/enic: fix the size check in Tx prepare handler

2018-11-13 Thread Hyong Youb Kim
The current code wrongly assumes that packets are non-TSO and ends up rejecting large TSO packets. Check non-TSO and TSO max packet sizes separately. Fixes: 5a12c387405a ("net/enic: check maximum packet size in Tx prepare handler") Cc: sta...@dpdk.org Signed-off-by: Hyong Youb Kim Reviewed-by:

Re: [dpdk-dev] [PATCH] security: remove experimental tag

2018-11-13 Thread Ananyev, Konstantin
> > >> -Original Message- > > >> From: Akhil Goyal [mailto:akhil.go...@nxp.com] > > >> Sent: Tuesday, November 13, 2018 11:28 AM > > >> To: dev@dpdk.org > > >> Cc: tho...@monjalon.net; Ananyev, Konstantin > > >> ; jerin.ja...@caviumnetworks.com; > > >> anoob.jos...@caviumnetworks.com; Nic

[dpdk-dev] [PATCH] eal: clean up unused files on initialization

2018-11-13 Thread Anatoly Burakov
When creating process data structures, EAL will create many files in EAL runtime directory. Because we allow multiple secondary processes to run, each secondary process gets their own unique file. With many secondary processes running and exiting on the system, runtime directory will, over time, cr

[dpdk-dev] [PATCH] net/sfc/base: fix field order in filter spec struct

2018-11-13 Thread Andrew Rybchenko
From: Igor Romanov Fields in the struct efx_filter_spec_t starting from efs_outer_vid are hashed for software filter lookup. efs_mark is not a matching criteria. Exclude efs_mark from hash. Fixes: 5f78af523912 ("net/sfc: support MARK and FLAG actions in flow API") Cc: sta...@dpdk.org Signed-off

[dpdk-dev] [PATCH v2] app/pdump: fix port id storage size

2018-11-13 Thread Marko Kovacevic
port_id size should be uint16_t, fix where it is defined as uint8_t Fixes: f8244c6399d9 ("ethdev: increase port id range") Cc: zhiyong.y...@intel.com Cc: sta...@dpdk.org Signed-off-by: Marko Kovacevic -- v2: Added cc to stable --- app/pdump/main.c | 6 +++--- 1 file changed, 3 insertions(+),

[dpdk-dev] [PATCH] app/pdump: fix port id storage size

2018-11-13 Thread Marko Kovacevic
port_id size should be uint16_t, fix where it is defined as uint8_t Fixes: f8244c6399d9 ("ethdev: increase port id range") Cc: zhiyong.y...@intel.com Signed-off-by: Marko Kovacevic --- app/pdump/main.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/app/pdump/main.c b/

[dpdk-dev] [PATCH] app/pdump: fix port id storage size

2018-11-13 Thread Marko Kovacevic
port_id size should be uint16_t, fix where it is defined as uint8_t Fixes: f8244c6399d9 ("ethdev: increase port id range") Cc: zhiyong.y...@intel.com Signed-off-by: Marko Kovacevic --- app/pdump/main.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/app/pdump/main.c b/

[dpdk-dev] [PATCH] test: fix to skip kni autotest

2018-11-13 Thread Pallantla Poornima
Kni_autotest should be skipped if rte_kni.ko module is not loaded. Hence changed return as TEST_SKIPPED. Fixes: ee1caebc4d ("test/kni: check module dependency") Cc: sta...@dpdk.org Signed-off-by: Pallantla Poornima --- test/test/test_kni.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[dpdk-dev] [PATCH] test: fix to skip power acpi cpufreq autotest

2018-11-13 Thread Pallantla Poornima
Power_acpi_cpufreq_autotest should not be run on VM and platforms which dont have acpi_cpufreq module loaded. Hence changed return as TEST_SKIPPED Fixes: 0ea2dd4409 ("test: skip when required lib not available") Cc: sta...@dpdk.org Signed-off-by: Pallantla Poornima --- test/test/test_power_acpi

Re: [dpdk-dev] [PATCH 2/4] net/mlx5: fix Netlink communication routine

2018-11-13 Thread Shahaf Shuler
Monday, November 12, 2018 10:02 PM, Slava Ovsiienko: > Subject: [PATCH 2/4] net/mlx5: fix Netlink communication routine > > While receiving the Netlink reply messages we should stop at DONE or ACK > message. The existing implementation stops at DONE message or if no > multiple message flag set ( N

  1   2   >