Re: [dpdk-dev] [PATCH] mlx5: Report imissed stat

2018-11-14 Thread Shahaf Shuler
Wednesday, November 14, 2018 6:18 PM, Tom Barbette: > Subject: RE: [PATCH] mlx5: Report imissed stat > > Hi Shahaf, > > Yes we learned this distinction with rx_discards_phy the hard way. I would > expect imissed to be only rx_out_of_buffer actually. I'd say people look at > imissed to see if the

[dpdk-dev] [PATCH] net/ixgbe: update the maximum wait time in comment

2018-11-14 Thread Xiaolong Ye
As the code has changed the max wait time to 1000ms, the comment should be changed accordingly. Fixes: 64f1c8539c8c ("net/ixgbe: wait longer for link after fiber MAC setup") Cc: mgsm...@netgate.com Cc: sta...@dpdk.org Signed-off-by: Xiaolong Ye --- drivers/net/ixgbe/base/ixgbe_common.c | 2 +-

[dpdk-dev] [PATCH v2] test: fix to skip power kvm vm autotest

2018-11-14 Thread Pallantla Poornima
power_kvm_vm_autotest should run on kvm vm and virtio-ports should exist, if not test should skip. Hence changed return as TEST_SKIPPED. Fixes: 0ea2dd4409 ("test: skip when required lib not available") Cc: sta...@dpdk.org Signed-off-by: Pallantla Poornima Acked-by: Reshma Pattan --- v2: Update

Re: [dpdk-dev] [PATCH 2/2] net/mlx5: fix initialization of struct members

2018-11-14 Thread Yongseok Koh
> On Nov 14, 2018, at 4:06 AM, Shahaf Shuler wrote: > > Adding Koh, see below > > Tuesday, November 13, 2018 9:11 PM, Ali Alnubani: >> Subject: [PATCH 2/2] net/mlx5: fix initialization of struct members >> >> This patch fixes compilation errors with meson and the clang compiler caused >> by

Re: [dpdk-dev] Application used for DSW event_dev performance testing

2018-11-14 Thread Mattias Rönnblom
On 2018-11-14 22:56, Venky Venkatesh wrote: Mattias, Thanks for the prompt response. Appreciate your situation of not being able to share the proprietary code. More answers inline as [VV]: --Venky On 11/14/18, 11:41 AM, "Mattias Rönnblom" wrote: On 2018-11-14 20:16, Venky Venkatesh wrot

[dpdk-dev] [PATCH] net/mlx5: fix flow destruction

2018-11-14 Thread Yongseok Koh
As flow_drv_destroy() frees dev_flow, flow_rxq_flags_trim() must be called ahead. Fixes: 84c406e74524 ("net/mlx5: add flow translate function") Cc: or...@mellanox.com Signed-off-by: Yongseok Koh --- drivers/net/mlx5/mlx5_flow.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --g

[dpdk-dev] [PATCH] common/cpt: fix bad shift operation

2018-11-14 Thread Anoob Joseph
From: Ankur Dwivedi Coverity Issue: 323477 Using the rte_bsf32 function to find last set bit. This avoids the for loop and hence the bad bit shift operation. Fixes: 351fbee21986 ("common/cpt: support hash") Signed-off-by: Ankur Dwivedi Signed-off-by: Anoob Joseph --- drivers/common/cpt/cpt_

[dpdk-dev] [PATCH v2] net/i40e: fix X710 Rx issue after reading some registers

2018-11-14 Thread Beilei Xing
There's an issue that X710 can't receive any packet after reading some special registers. That's because these registers are only valid for X722, read access for non-X722 will cause ECC error. Fixes: d9efd0136ac1 ("i40e: add EEPROM and registers dumping") Cc: sta...@dpdk.org Signed-off-by: Beilei

Re: [dpdk-dev] Where is the padding code in DPDK?

2018-11-14 Thread Sam
rte_vhost_dequeue_burst and rte_vhost_enqueue_burst is the same Sam 于2018年11月15日周四 上午10:07写道: > So, to be brief, rte_eth_rx_burst and rte_eth_tx_burst, just send mbuf, > will not do anything. > Is that right? > > Wiles, Keith 于2018年11月15日周四 上午12:19写道: > >> >> >> > On Nov 14, 2018, at 4:51 AM, M

Re: [dpdk-dev] Where is the padding code in DPDK?

2018-11-14 Thread Sam
So, to be brief, rte_eth_rx_burst and rte_eth_tx_burst, just send mbuf, will not do anything. Is that right? Wiles, Keith 于2018年11月15日周四 上午12:19写道: > > > > On Nov 14, 2018, at 4:51 AM, Morten Brørup > wrote: > > > > Anatoly, > > > > This differs from the Linux kernel's behavior, where padding b

[dpdk-dev] [PATCH v4 2/2] net/pcap: enable data path for secondary

2018-11-14 Thread Qi Zhang
Private vdev was the way previously, when pdump developed, now with shared device mode on virtual devices, pcap data path in secondary is not working. When secondary adds a virtual device, related data transferred to primary and primary creates the device and shares device back with secondary. Whe

[dpdk-dev] [PATCH v4 1/2] net/pcap: move pcap handler to process private

2018-11-14 Thread Qi Zhang
This is prework for data path enabling for secondary process. To prevent pcap handler opened by one process be overwritten by another process, each process should have their private copy, `rte_eth_dev->process_private` is exactly what we needed. Signed-off-by: Qi Zhang --- drivers/net/pcap/rte_e

[dpdk-dev] [PATCH v4 0/2] fix pcap handlers for secondary

2018-11-14 Thread Qi Zhang
Private vdev was the way previously, when pdump developed, now with shared device mode on virtual devices, pcap data path in secondary is not working. When secondary adds a virtual device, related data transferred to primary and primary creates the device and shares device back with secondary. Whe

Re: [dpdk-dev] [PATCH v2] pci_vfio: Support 64KB kernel page_size with vfio-pci driver

2018-11-14 Thread Tone Zhang (Arm Technology China)
Hi Anatoly, Sorry for the late response. > -Original Message- > From: Burakov, Anatoly > Sent: Friday, November 9, 2018 8:15 PM > To: Tone Zhang (Arm Technology China) ; > dev@dpdk.org > Cc: Gavin Hu (Arm Technology China) ; Honnappa > Nagarahalli ; Steve Capper > ; nd > Subject: Re: [P

Re: [dpdk-dev] [PATCH v3 1/2] net/pcap: move pcap handler to process private

2018-11-14 Thread Zhang, Qi Z
> -Original Message- > From: Yigit, Ferruh > Sent: Wednesday, November 14, 2018 3:05 PM > To: Zhang, Qi Z > Cc: tho...@monjalon.net; dev@dpdk.org; Lin, Xueqin > Subject: Re: [PATCH v3 1/2] net/pcap: move pcap handler to process private > > On 11/14/2018 7:56 PM, Qi Zhang wrote: > > Thi

Re: [dpdk-dev] [PATCH v3 2/2] net/pcap: enable data path for secondary

2018-11-14 Thread Zhang, Qi Z
> -Original Message- > From: Yigit, Ferruh > Sent: Wednesday, November 14, 2018 3:08 PM > To: Zhang, Qi Z > Cc: tho...@monjalon.net; dev@dpdk.org; Lin, Xueqin > Subject: Re: [PATCH v3 2/2] net/pcap: enable data path for secondary > > On 11/14/2018 7:56 PM, Qi Zhang wrote: > > Private v

Re: [dpdk-dev] [PATCH v3 2/2] net/pcap: enable data path for secondary

2018-11-14 Thread Ferruh Yigit
On 11/14/2018 7:56 PM, Qi Zhang wrote: > Private vdev was the way previously, when pdump developed, now with shared > device mode on virtual devices, pcap data path in secondary is not working. > > When secondary adds a virtual device, related data transferred to primary > and primary creates the

Re: [dpdk-dev] [PATCH v3 1/2] net/pcap: move pcap handler to process private

2018-11-14 Thread Ferruh Yigit
On 11/14/2018 7:56 PM, Qi Zhang wrote: > This is prework for data path enabling for secondary process. > To prevent pcap handler opened by one process be overwritten by > another process, each process should have their private copy, > `rte_eth_dev->process_private` is exactly what we needed. > > S

Re: [dpdk-dev] Application used for DSW event_dev performance testing

2018-11-14 Thread Venky Venkatesh
Mattias, Thanks for the prompt response. Appreciate your situation of not being able to share the proprietary code. More answers inline as [VV]: --Venky On 11/14/18, 11:41 AM, "Mattias Rönnblom" wrote: On 2018-11-14 20:16, Venky Venkatesh wrote: > Hi, > > https://urldefense.

[dpdk-dev] [PATCH] mem: Fix anonymous mapping on Power9.

2018-11-14 Thread David Wilder
Removed the use of MAP_HUGETLB for anonymous mapping on ppc64. The MAP_HUGETLB had previously been added to workaround issues on IBM Power8 systems when mapping /dev/zero (see: commit 284ae3e9ff9a92575c28c858efd2c85c8de6d440). In the current code the MAP_HUGETLB flag will cause the anonymous mapp

Re: [dpdk-dev] [PATCH] net/i40e: fix X710 Rx issue after reading some registers

2018-11-14 Thread Zhang, Qi Z
> -Original Message- > From: Xing, Beilei > Sent: Tuesday, November 13, 2018 8:11 PM > To: Zhang, Qi Z ; Wu, Jingjing > Cc: dev@dpdk.org; sta...@dpdk.org > Subject: [PATCH] net/i40e: fix X710 Rx issue after reading some registers > > There's an issue that X710 can't receive any packet

[dpdk-dev] [PATCH v3 2/2] net/pcap: enable data path for secondary

2018-11-14 Thread Qi Zhang
Private vdev was the way previously, when pdump developed, now with shared device mode on virtual devices, pcap data path in secondary is not working. When secondary adds a virtual device, related data transferred to primary and primary creates the device and shares device back with secondary. Whe

[dpdk-dev] [PATCH v3 0/2] fix pcap handlers for secondary

2018-11-14 Thread Qi Zhang
Private vdev was the way previously, when pdump developed, now with shared device mode on virtual devices, pcap data path in secondary is not working. When secondary adds a virtual device, related data transferred to primary and primary creates the device and shares device back with secondary. Whe

[dpdk-dev] [PATCH v3 1/2] net/pcap: move pcap handler to process private

2018-11-14 Thread Qi Zhang
This is prework for data path enabling for secondary process. To prevent pcap handler opened by one process be overwritten by another process, each process should have their private copy, `rte_eth_dev->process_private` is exactly what we needed. Signed-off-by: Qi Zhang --- drivers/net/pcap/rte_e

Re: [dpdk-dev] Application used for DSW event_dev performance testing

2018-11-14 Thread Mattias Rönnblom
On 2018-11-14 20:16, Venky Venkatesh wrote: Hi, https://mails.dpdk.org/archives/dev/2018-September/111344.html mentions that there is a sample application where “worker cores can sustain 300-400 million event/s. With a pipeline with 1000 clock cycles of work per stage, the average event device

[dpdk-dev] [PATCH v4 2/2] build: establish an invariant machine type

2018-11-14 Thread Christian Ehrhardt
Add the machine definition 'default' which is special compared to 'native' (most optimized for current system) or any explicit type (external entity has to decide on the type). It defaults to the per arch agreed common minimal baseline needed for DPDK to reasonable work. That might not be the mos

[dpdk-dev] [PATCH v4 1/2] build: avoid non supported -march on ppc (meson)

2018-11-14 Thread Christian Ehrhardt
So far only if machine was "native" it did use the re-direction to not set -march on ppc64 (where -march is not supported). We have to use mcpu/mtune in any case on ppc for whatever someone using the build system defines as machine. Fixes: 54d609a13876 ("build: add ppc64 meson build") Acked-by: L

Re: [dpdk-dev] [PATCH v3] build: establish an invariant machine type

2018-11-14 Thread Christian Ehrhardt
On Wed, Nov 14, 2018 at 3:33 PM Christian Ehrhardt wrote: > > Add the machine definition 'default' which is special compared > to 'native' (most optimized for current system) or any explicit > type (external entity has to decide on the type). > > It defaults to the per arch agreed common minimal b

[dpdk-dev] Application used for DSW event_dev performance testing

2018-11-14 Thread Venky Venkatesh
Hi, https://mails.dpdk.org/archives/dev/2018-September/111344.html mentions that there is a sample application where “worker cores can sustain 300-400 million event/s. With a pipeline with 1000 clock cycles of work per stage, the average event device overhead is somewhere 50-150 clock cycles/eve

Re: [dpdk-dev] [PATCH 1/1] eal: Don't fail secondary if primary is missing tailqs

2018-11-14 Thread Burdick, Cliff
-Original Message- From: Luca Boccassi [mailto:bl...@debian.org] Sent: Wednesday, November 14, 2018 10:15 AM To: Burdick, Cliff; Bruce Richardson Cc: Thomas Monjalon; Burakov, Anatoly; dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH 1/1] eal: Don't fail secondary if primary is missing tailq

[dpdk-dev] [PATCH 2/2] net/bnx2x: bump version to 1.0.7.1

2018-11-14 Thread Mody, Rasesh
Signed-off-by: Rasesh Mody --- drivers/net/bnx2x/bnx2x.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/bnx2x/bnx2x.c b/drivers/net/bnx2x/bnx2x.c index e2a6580..83334bf 100644 --- a/drivers/net/bnx2x/bnx2x.c +++ b/drivers/net/bnx2x/bnx2x.c @@ -29,7 +29,7 @@ #d

[dpdk-dev] [PATCH 1/2] net/bnx2x: cleanup info logs

2018-11-14 Thread Mody, Rasesh
Reduced number of INFO logs in BNX2X PMD by converting some INFO logs to DEBUG and few NOTICE logs to INFO, removing extra new lines, printing banner bar once for the adapter and device specific info. Fixes: ba7eeb035a5f ("net/bnx2x: fix logging to include device name") Fixes: 540a211084a7 ("bnx2x

Re: [dpdk-dev] [PATCH 1/1] eal: Don't fail secondary if primary is missing tailqs

2018-11-14 Thread Luca Boccassi
On Wed, 2018-11-14 at 17:40 +, Burdick, Cliff wrote: > > -Original Message- > From: Bruce Richardson [mailto:bruce.richard...@intel.com]  > Sent: Wednesday, November 14, 2018 3:48 AM > To: Burdick, Cliff > Cc: Thomas Monjalon; Burakov, Anatoly; dev@dpdk.org > Subject: Re: [dpdk-dev] [P

Re: [dpdk-dev] [PATCH 1/1] eal: Don't fail secondary if primary is missing tailqs

2018-11-14 Thread Burdick, Cliff
-Original Message- From: Bruce Richardson [mailto:bruce.richard...@intel.com] Sent: Wednesday, November 14, 2018 3:48 AM To: Burdick, Cliff Cc: Thomas Monjalon; Burakov, Anatoly; dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH 1/1] eal: Don't fail secondary if primary is missing tailqs On

Re: [dpdk-dev] [PATCH] security: remove experimental tag

2018-11-14 Thread Boris Pismenny
Acked-By: Boris Pismenny > -Original Message- > From: dev On Behalf Of Akhil Goyal > Sent: Tuesday, November 13, 2018 3:28 AM > To: dev@dpdk.org > Cc: Thomas Monjalon ; > konstantin.anan...@intel.com; jerin.ja...@caviumnetworks.com; > anoob.jos...@caviumnetworks.com; radu.nico...@intel.c

Re: [dpdk-dev] [RFC] ethdev: introduce DMA memory mapping for external memory

2018-11-14 Thread Burakov, Anatoly
On 14-Nov-18 2:53 PM, Shahaf Shuler wrote: Hi Anatoly, Wednesday, November 14, 2018 1:19 PM, Burakov, Anatoly: Subject: Re: [RFC] ethdev: introduce DMA memory mapping for external memory Hi Shahaf, Great to see such effort! Few comments below. Note: halfway through writing my comments i real

Re: [dpdk-dev] [PATCH v3 2/5] bitmap: rename rte_bsf64 and move to common header

2018-11-14 Thread Singh, Jasvinder
> -Original Message- > From: Burakov, Anatoly > Sent: Wednesday, November 14, 2018 4:47 PM > To: dev@dpdk.org > Cc: Neil Horman ; Mcnamara, John > ; Kovacevic, Marko > ; Dumitrescu, Cristian > ; tho...@monjalon.net; Richardson, Bruce > ; Yigit, Ferruh ; Singh, > Jasvinder > Subject: [PA

[dpdk-dev] [PATCH v3 2/5] bitmap: rename rte_bsf64 and move to common header

2018-11-14 Thread Anatoly Burakov
Rename rte_bsf64 to rte_bsf64_safe (this is a "safe" version in that it prevents undefined behavior by checking if incoming parameter is zero) and move it to common header. Signed-off-by: Anatoly Burakov Acked-by: Cristian Dumitrescu --- Notes: v3: - Added clarification that pos is not

[dpdk-dev] [PATCH v3 4/5] memalloc: use library implementation of 64-bit log2

2018-11-14 Thread Anatoly Burakov
Remove duplicated code and use library version of 64-bit log2. Signed-off-by: Anatoly Burakov Acked-by: Cristian Dumitrescu --- lib/librte_eal/linuxapp/eal/eal_memalloc.c | 17 + 1 file changed, 1 insertion(+), 16 deletions(-) diff --git a/lib/librte_eal/linuxapp/eal/eal_memall

[dpdk-dev] [PATCH v3 3/5] common: add missing implementations

2018-11-14 Thread Anatoly Burakov
Implement missing functions for 32-bit safe bsf, as well as 64-bit fls and log2. Signed-off-by: Anatoly Burakov Acked-by: Cristian Dumitrescu --- Notes: v3: - Added clarification that pos is not checked lib/librte_eal/common/include/rte_common.h | 64 +- 1 file cha

[dpdk-dev] [PATCH v3 1/5] bitmap: remove useless code

2018-11-14 Thread Anatoly Burakov
RTE_BITMAP_OPTIMIZATIONS was never set to 0 and makes no sense anyway, so remove all code related to it. Also, drop the "likely" for bsf64 code, because it's a generic function and we cannot make any assumptions about likely values of incoming arguments. Signed-off-by: Anatoly Burakov Acked-by: C

[dpdk-dev] [PATCH v3 5/5] testpmd: use library implementation of 64-bit log2

2018-11-14 Thread Anatoly Burakov
Remove duplicated code and use library version of 64-bit log2. Signed-off-by: Anatoly Burakov Acked-by: Cristian Dumitrescu --- app/test-pmd/testpmd.c | 17 + 1 file changed, 1 insertion(+), 16 deletions(-) diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c index 9c0e

Re: [dpdk-dev] [PATCH v2 1/5] bitmap: remove useless code

2018-11-14 Thread Dumitrescu, Cristian
> -Original Message- > From: Burakov, Anatoly > Sent: Wednesday, November 14, 2018 4:30 PM > To: dev@dpdk.org > Cc: Dumitrescu, Cristian ; > tho...@monjalon.net; Richardson, Bruce ; > Yigit, Ferruh ; Singh, Jasvinder > > Subject: [PATCH v2 1/5] bitmap: remove useless code > > RTE_BITMA

[dpdk-dev] [PATCH v2 5/5] testpmd: use library implementation of 64-bit log2

2018-11-14 Thread Anatoly Burakov
Remove duplicated code and use library version of 64-bit log2. Signed-off-by: Anatoly Burakov --- app/test-pmd/testpmd.c | 17 + 1 file changed, 1 insertion(+), 16 deletions(-) diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c index 9c0edcaed..89c6ffd53 100644 --- a/a

[dpdk-dev] [PATCH v2 3/5] common: add missing implementations

2018-11-14 Thread Anatoly Burakov
Implement missing functions for 32-bit safe bsf, as well as 64-bit fls and log2. Signed-off-by: Anatoly Burakov --- lib/librte_eal/common/include/rte_common.h | 62 +- 1 file changed, 61 insertions(+), 1 deletion(-) diff --git a/lib/librte_eal/common/include/rte_common.h b/

[dpdk-dev] [PATCH v2 1/5] bitmap: remove useless code

2018-11-14 Thread Anatoly Burakov
RTE_BITMAP_OPTIMIZATIONS was never set to 0 and makes no sense anyway, so remove all code related to it. Also, drop the "likely" for bsf64 code, because it's a generic function and we cannot make any assumptions about likely values of incoming arguments. Signed-off-by: Anatoly Burakov --- lib/li

[dpdk-dev] [PATCH v2 2/5] bitmap: rename rte_bsf64 and move to common header

2018-11-14 Thread Anatoly Burakov
Rename rte_bsf64 to rte_bsf64_safe (this is a "safe" version in that it prevents undefined behavior by checking if incoming parameter is zero) and move it to common header. Signed-off-by: Anatoly Burakov --- doc/guides/rel_notes/deprecation.rst | 5 + lib/librte_eal/common/include/rte

[dpdk-dev] [PATCH v2 4/5] memalloc: use library implementation of 64-bit log2

2018-11-14 Thread Anatoly Burakov
Remove duplicated code and use library version of 64-bit log2. Signed-off-by: Anatoly Burakov --- lib/librte_eal/linuxapp/eal/eal_memalloc.c | 17 + 1 file changed, 1 insertion(+), 16 deletions(-) diff --git a/lib/librte_eal/linuxapp/eal/eal_memalloc.c b/lib/librte_eal/linuxapp

Re: [dpdk-dev] Where is the padding code in DPDK?

2018-11-14 Thread Wiles, Keith
> On Nov 14, 2018, at 4:51 AM, Morten Brørup wrote: > > Anatoly, > > This differs from the Linux kernel's behavior, where padding belongs in the > NIC driver layer, not in the protocol layer. If you pass a runt frame (too > short packet) to a Linux NIC driver's transmission function, the NIC

Re: [dpdk-dev] [PATCH] mlx5: Report imissed stat

2018-11-14 Thread Tom Barbette
Hi Shahaf, Yes we learned this distinction with rx_discards_phy the hard way. I would expect imissed to be only rx_out_of_buffer actually. I'd say people look at imissed to see if they consume packets fast enough. If the problem is pure CPU power. And that is more the definition of imissed, it

Re: [dpdk-dev] [PATCH v2] malloc: fix adjacency check to also include segment list

2018-11-14 Thread Burakov, Anatoly
On 14-Nov-18 3:00 PM, Anatoly Burakov wrote: It may so happen that two memory locations may be adjacent in virtual memory, but belong to different segment lists. With current code, such segments will be concatenated. Fix the adjacency checking code to also check if the adjacent malloc elements be

Re: [dpdk-dev] [PATCH v2] eal: clean up unused files on initialization

2018-11-14 Thread Eads, Gage
Worked in my testing. Tested-by: Gage Eads Thanks, Gage

[dpdk-dev] [PATCH] doc: deprecation notice for sched API change

2018-11-14 Thread Jasvinder Singh
There will be change in API functions because of mbuf sched field updates, outlined in deprecation note of mbuf->hash.sched. Signed-off-by: Jasvinder Singh Acked-by: Cristian Dumitrescu --- doc/guides/rel_notes/deprecation.rst | 5 + 1 file changed, 5 insertions(+) diff --git a/doc/guides/

Re: [dpdk-dev] [PATCH] mlx5: Report imissed stat

2018-11-14 Thread Shahaf Shuler
Hi Again Tom, Tuesday, November 13, 2018 12:17 PM, Tom Barbette: > Subject: [PATCH] mlx5: Report imissed stat > > The imissed counters (number of packets dropped because the queues were > full) were actually reported through xstats as "rx_out_of_buffer" > but was not reported through stats. > >

Re: [dpdk-dev] [PATCH v2] ethdev: document RSS default key and types

2018-11-14 Thread Adrien Mazarguil
On Wed, Nov 14, 2018 at 01:51:19PM +, Shahaf Shuler wrote: > IMO, it will make it more clear if the key will *have* to be null, because > there is no single good reason to have it otherwise. > > However it looks like an endless debate between strict and relaxed API. there > are points to b

Re: [dpdk-dev] [PATCH v5 1/3] crypto/openssl: add rsa and mod asym op

2018-11-14 Thread Mcnamara, John
> +err_rsa: > + if (n) > + BN_free(n); > + if (e) > + BN_free(e); > + if (d) > + BN_free(d); > + if (p) > + BN_free(p); > + if (q) > + BN_f

Re: [dpdk-dev] [PATCH v2 2/2] net/mlx5: fix typos

2018-11-14 Thread Shahaf Shuler
Wednesday, November 14, 2018 9:49 AM, Ali Alnubani: > Subject: [PATCH v2 2/2] net/mlx5: fix typos > > Fixes: e1114ff6a5ab ("net/mlx5: support e-switch flow count action") > Fixes: 974f1e7ef146 ("net/mlx5: add new memory region support") > Cc: sta...@dpdk.org > > Signed-off-by: Ali Alnubani Appl

Re: [dpdk-dev] [PATCH 1/2] net/mlx4: fix typo

2018-11-14 Thread Shahaf Shuler
Wednesday, November 14, 2018 9:48 AM, Ali Alnubani: > Subject: [PATCH 1/2] net/mlx4: fix typo > > Fixes: 9797bfcce1c9 ("net/mlx4: add new memory region support") > Cc: sta...@dpdk.org > > Signed-off-by: Ali Alnubani > --- >From some reason my previous mail is not shown on patchwork. Resending

[dpdk-dev] [PATCH v2] malloc: fix adjacency check to also include segment list

2018-11-14 Thread Anatoly Burakov
It may so happen that two memory locations may be adjacent in virtual memory, but belong to different segment lists. With current code, such segments will be concatenated. Fix the adjacency checking code to also check if the adjacent malloc elements belong to the same memseg list. Fixes: 66cc45e29

Re: [dpdk-dev] [PATCH 0/4] net/mlx5: prepare to add E-switch rule flags check

2018-11-14 Thread Shahaf Shuler
Tuesday, November 13, 2018 3:21 PM, Shahaf Shuler: > Subject: Re: [dpdk-dev] [PATCH 0/4] net/mlx5: prepare to add E-switch rule > flags check > > Monday, November 12, 2018 10:02 PM, Slava Ovsiienko: > > Subject: [PATCH 0/4] net/mlx5: prepare to add E-switch rule flags > > check > > > > The tc flow

Re: [dpdk-dev] [RFC] ethdev: introduce DMA memory mapping for external memory

2018-11-14 Thread Shahaf Shuler
Hi Anatoly, Wednesday, November 14, 2018 1:19 PM, Burakov, Anatoly: > Subject: Re: [RFC] ethdev: introduce DMA memory mapping for external > memory > > Hi Shahaf, > > Great to see such effort! Few comments below. > > Note: halfway through writing my comments i realized that i am starting with

[dpdk-dev] [PATCH] malloc: fix adjacency check to also include segment list

2018-11-14 Thread Anatoly Burakov
It may so happen that two memory locations may be adjacent in virtual memory, but belong to different segment lists. With current code, such segments will be concatenated. Fix the adjacency checking code to also check if the adjacent malloc elements belong to the same memseg list. Fixes: 66cc45e29

[dpdk-dev] [PATCH] memalloc: check for contiguousness in external segments

2018-11-14 Thread Anatoly Burakov
For IOVA as VA mode, we assume that memory is contiguous. However, for external segments that assumption may not necessarily hold. Fix the code to not assume that external memory segments are contiguous even in IOVA as VA mode. Fixes: 5282bb1c3695 ("mem: allow memseg lists to be marked as external

[dpdk-dev] [PATCH v3] build: establish an invariant machine type

2018-11-14 Thread Christian Ehrhardt
Add the machine definition 'default' which is special compared to 'native' (most optimized for current system) or any explicit type (external entity has to decide on the type). It defaults to the per arch agreed common minimal baseline needed for DPDK to reasonable work. That might not be the mos

Re: [dpdk-dev] [PATCH v3] doc: add meson build to contributing guide

2018-11-14 Thread Kovacevic, Marko
> Patches has to be validated for meson builds. Updating documentation for > meson build steps in Checking Compilation category. > > Signed-off-by: Vipin Varghese > --- > > V3: > removed extra character - Vipin Varghese > > V2: > updated the meson build options - Bruce Richardson > --- > doc/g

Re: [dpdk-dev] [PATCH] test: fix to skip power kvm vm autotest

2018-11-14 Thread Pattan, Reshma
> -Original Message- > From: Poornima, PallantlaX > Sent: Wednesday, November 14, 2018 9:24 AM > To: dev@dpdk.org > Cc: Pattan, Reshma ; Hunt, David > ; Poornima, PallantlaX > ; sta...@dpdk.org > Subject: [PATCH] test: fix to skip power kvm vm autotest > > Power_kvm_vm_autotest should r

Re: [dpdk-dev] [PATCH] doc: fix DESTDIR variable name in meson guide

2018-11-14 Thread Bruce Richardson
On Wed, Nov 14, 2018 at 03:04:38PM +0300, Ilya Maximets wrote: > ninja does not recognize 'DEST_DIR'. > > Fixes: 9c3adc289c5e ("doc: add instructions on build using meson") > Cc: sta...@dpdk.org > > Signed-off-by: Ilya Maximets > --- > doc/build-sdk-meson.txt | 2 +- > 1 file changed, 1 inserti

Re: [dpdk-dev] [PATCH] build: establish an invariant machine type

2018-11-14 Thread Bruce Richardson
On Wed, Nov 14, 2018 at 02:18:38PM +0100, Christian Ehrhardt wrote: > Add the machine definition 'default' which is special compared > to 'native' (most optimized for current system) or any explicit > type (external entity has to decide on the type). > > It defaults to the per arch agreed common m

Re: [dpdk-dev] [PATCH v2] ethdev: document RSS default key and types

2018-11-14 Thread Shahaf Shuler
Wednesday, November 14, 2018 11:41 AM, Adrien Mazarguil: > Subject: Re: [dpdk-dev] [PATCH v2] ethdev: document RSS default key and > types > > Hi Shahaf, > > On Tue, Nov 13, 2018 at 06:39:04PM +, Shahaf Shuler wrote: > > Hi Adrien, > > > > Tuesday, November 13, 2018 7:15 PM, Adrien Mazarguil:

[dpdk-dev] [PATCH] net/mlx5: fix flow query routine in Direct Verbs

2018-11-14 Thread Slava Ovsiienko
From: Viacheslav Ovsiienko The flow_dv_query() just returns -ENOTSUP value and does not set provided error parameter structure, that crashes the port_flow_query(). The patch fixes flow_db_query(), now it sets an error parameter structure. Fixes: 684dafe795d0 ("net/mlx5: add flow query abstractio

Re: [dpdk-dev] [PATCH 1/2] net/mlx4: fix typo

2018-11-14 Thread Shahaf Shuler
Tuesday, November 13, 2018 9:13 PM, Ali Alnubani: > Subject: [PATCH 1/2] net/mlx4: fix typo > > Fixes: 9797bfcce1c9 ("net/mlx4: add new memory region support") > Cc: sta...@dpdk.org > > Signed-off-by: Ali Alnubani Series applied to next-net-mlx with minor commit title edit. Please have a look,

[dpdk-dev] [PATCH] build: establish an invariant machine type

2018-11-14 Thread Christian Ehrhardt
Add the machine definition 'default' which is special compared to 'native' (most optimized for current system) or any explicit type (external entity has to decide on the type). It defaults to the per arch agreed common minimal baseline needed for DPDK to reasonable work. That might not be the mos

Re: [dpdk-dev] [PATCH 2/2] build: establish an invariant machine type

2018-11-14 Thread Christian Ehrhardt
On Wed, Nov 14, 2018 at 1:05 PM Luca Boccassi wrote: > > On Wed, 2018-11-14 at 11:52 +, Bruce Richardson wrote: > > On Wed, Nov 14, 2018 at 11:40:11AM +, Luca Boccassi wrote: > > > On Wed, 2018-11-14 at 12:34 +0100, Christian Ehrhardt wrote: > > > > Add the machine definition 'baseline' wh

Re: [dpdk-dev] [PATCH 2/2] build: establish an invariant machine type

2018-11-14 Thread Christian Ehrhardt
On Wed, Nov 14, 2018 at 2:06 PM Luca Boccassi wrote: > > On Wed, 2018-11-14 at 12:34 +0100, Christian Ehrhardt wrote: > > Add the machine definition 'baseline' which is special compared > > to 'native' (most optimized for current system) or any explicit > > type (external entity has to decide on t

Re: [dpdk-dev] [PATCH 2/2] build: establish an invariant machine type

2018-11-14 Thread Luca Boccassi
On Wed, 2018-11-14 at 12:34 +0100, Christian Ehrhardt wrote: > Add the machine definition 'baseline' which is special compared > to 'native' (most optimized for current system) or any explicit > type (external entity has to decide on the type). > > It defaults to the per arch agreed common minimal

Re: [dpdk-dev] [PATCH] doc: security deprecation notice for session changes

2018-11-14 Thread Ananyev, Konstantin
> -Original Message- > From: Akhil Goyal [mailto:akhil.go...@nxp.com] > Sent: Wednesday, November 14, 2018 12:40 PM > To: Ananyev, Konstantin ; dev@dpdk.org > Cc: Doherty, Declan > Subject: Re: [dpdk-dev] [PATCH] doc: security deprecation notice for session > changes > > > > On 11/14

Re: [dpdk-dev] [PATCH 2/4] net/mlx5: fix Netlink communication routine

2018-11-14 Thread Slava Ovsiienko
> -Original Message- > From: Shahaf Shuler > Sent: Tuesday, November 13, 2018 15:22 > To: Slava Ovsiienko ; Yongseok Koh > > Cc: dev@dpdk.org > Subject: RE: [PATCH 2/4] net/mlx5: fix Netlink communication routine > > Monday, November 12, 2018 10:02 PM, Slava Ovsiienko: > > Subject: [PATCH

Re: [dpdk-dev] [dpdk-stable] [PATCH 17.11] mem: fix memory initialization time

2018-11-14 Thread Eelco Chaudron
On 12 Nov 2018, at 12:26, Eelco Chaudron wrote: On 12 Nov 2018, at 12:18, Alejandro Lucero wrote: When using large amount of hugepage based memory, doing all the hugepages mapping can take quite significant time. The problem is hugepages being initially mmaped to virtual addresses which wi

Re: [dpdk-dev] [PATCH] security: remove experimental tag

2018-11-14 Thread Hemant Agrawal
Acked-by: Hemant Agrawal On 11/13/2018 4:58 PM, Akhil Goyal wrote: > rte_security has been experimental since DPDK 17.11 release. > Now the library has matured and expermental tag is removed in > this patch. > >

Re: [dpdk-dev] [PATCH] doc: security deprecation notice for session changes

2018-11-14 Thread Akhil Goyal
On 11/14/2018 4:53 PM, Konstantin Ananyev wrote: > Add 'uint64_t opaque_data' inside struct rte_security_session. > That allows upper layer to easily associate some user defined > data with the session. > Proposed new layout for: > struct rte_security_session { > void *sess_private_data; >

[dpdk-dev] [PATCH] examples/bond: wait for slaves to become active

2018-11-14 Thread Radu Nicolau
Do not start the packet processing threads until all configured slaves become active. Signed-off-by: Radu Nicolau --- examples/bond/main.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/examples/bond/main.c b/examples/bond/main.c index b282e68..6623cae 100644 --- a/examples

[dpdk-dev] [PATCH] bitmap: deprecate rte_bsf64

2018-11-14 Thread Anatoly Burakov
The rte_bsf64 in rte_bitmap.h has a global namespace but does not follow convention of existing rte_bsf32 function in rte_common.h. Therefore, deprecate the current rte_bsf64 and introduce a new rte_bitmap_bsf64 function that will do the same thing. In later release cycles, rte_bsf64 will be remo

Re: [dpdk-dev] [PATCH 2/2] net/mlx5: fix initialization of struct members

2018-11-14 Thread Shahaf Shuler
Adding Koh, see below Tuesday, November 13, 2018 9:11 PM, Ali Alnubani: > Subject: [PATCH 2/2] net/mlx5: fix initialization of struct members > > This patch fixes compilation errors with meson and the clang compiler caused > by some of the struct members not being initialized. > > ``` > ../driv

Re: [dpdk-dev] [PATCH 2/2] build: establish an invariant machine type

2018-11-14 Thread Luca Boccassi
On Wed, 2018-11-14 at 11:52 +, Bruce Richardson wrote: > On Wed, Nov 14, 2018 at 11:40:11AM +, Luca Boccassi wrote: > > On Wed, 2018-11-14 at 12:34 +0100, Christian Ehrhardt wrote: > > > Add the machine definition 'baseline' which is special compared > > > to 'native' (most optimized for cu

[dpdk-dev] [PATCH] doc: fix DESTDIR variable name in meson guide

2018-11-14 Thread Ilya Maximets
ninja does not recognize 'DEST_DIR'. Fixes: 9c3adc289c5e ("doc: add instructions on build using meson") Cc: sta...@dpdk.org Signed-off-by: Ilya Maximets --- doc/build-sdk-meson.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/build-sdk-meson.txt b/doc/build-sdk-meson.

[dpdk-dev] [PATCH] testpmd: fix memory leak for dscp table

2018-11-14 Thread Jasvinder Singh
Fix memory leak for dscp table reported by coverity Coverity ID: 326961 Fixes: 281eeb8afc55 ("app/testpmd: add commands for metering and policing") CC: sta...@dpdk.org Signed-off-by: Jasvinder Singh --- app/test-pmd/cmdline_mtr.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) di

Re: [dpdk-dev] [PATCH 2/2] build: establish an invariant machine type

2018-11-14 Thread Bruce Richardson
On Wed, Nov 14, 2018 at 11:40:11AM +, Luca Boccassi wrote: > On Wed, 2018-11-14 at 12:34 +0100, Christian Ehrhardt wrote: > > Add the machine definition 'baseline' which is special compared > > to 'native' (most optimized for current system) or any explicit > > type (external entity has to deci

Re: [dpdk-dev] [PATCH 1/1] eal: Don't fail secondary if primary is missing tailqs

2018-11-14 Thread Bruce Richardson
On Tue, Nov 13, 2018 at 11:42:51PM +, Burdick, Cliff wrote: > > > From: Thomas Monjalon [tho...@monjalon.net] > Sent: Tuesday, November 13, 2018 2:18 PM > To: Burdick, Cliff > Cc: Burakov, Anatoly; dev@dpdk.org; bruce.richard...@intel.com > Subject: Re:

Re: [dpdk-dev] [PATCH 2/2] build: establish an invariant machine type

2018-11-14 Thread Luca Boccassi
On Wed, 2018-11-14 at 12:34 +0100, Christian Ehrhardt wrote: > Add the machine definition 'baseline' which is special compared > to 'native' (most optimized for current system) or any explicit > type (external entity has to decide on the type). > > It defaults to the per arch agreed common minimal

Re: [dpdk-dev] [PATCH 1/2] build: avoid non supported -march on ppc (meson)

2018-11-14 Thread Luca Boccassi
On Wed, 2018-11-14 at 12:34 +0100, Christian Ehrhardt wrote: > So far only if machine was "native" it did use the re-direction to > not set -march on ppc64 (where -march is not supported). > We have to use mcpu/mtune in any case on ppc for whatever someone > using > the build system defines as mach

[dpdk-dev] [PATCH 1/2] build: avoid non supported -march on ppc (meson)

2018-11-14 Thread Christian Ehrhardt
So far only if machine was "native" it did use the re-direction to not set -march on ppc64 (where -march is not supported). We have to use mcpu/mtune in any case on ppc for whatever someone using the build system defines as machine. Signed-off-by: Christian Ehrhardt --- config/meson.build | 5 ++

[dpdk-dev] [PATCH 2/2] build: establish an invariant machine type

2018-11-14 Thread Christian Ehrhardt
Add the machine definition 'baseline' which is special compared to 'native' (most optimized for current system) or any explicit type (external entity has to decide on the type). It defaults to the per arch agreed common minimal baseline needed for DPDK to reasonable work. That might not be the mo

Re: [dpdk-dev] [PATCH v2] example/ipv4_multicast: fix app hanging when using clone

2018-11-14 Thread Wang, Dong1
Acked-by: Wang Dong -Original Message- From: Ananyev, Konstantin Sent: Tuesday, November 13, 2018 19:52 To: Lipiec, Herakliusz ; dev@dpdk.org Cc: Wang, Dong1 ; tho...@monjalon.net; Burakov, Anatoly ; sta...@dpdk.org Subject: RE: [PATCH v2] example/ipv4_multicast: fix app hanging when us

Re: [dpdk-dev] [PATCH v2] example/ipv4_multicast: fix app hanging when using clone

2018-11-14 Thread Wang, Dong1
OK, understand now. Thanks, Dong -Original Message- From: Ananyev, Konstantin Sent: Wednesday, November 14, 2018 19:19 To: Wang, Dong1 ; Lipiec, Herakliusz ; dev@dpdk.org Cc: tho...@monjalon.net; Burakov, Anatoly ; sta...@dpdk.org Subject: RE: [PATCH v2] example/ipv4_multicast: fix app

Re: [dpdk-dev] [PATCH] doc: security deprecation notice for session changes

2018-11-14 Thread Zhang, Roy Fan
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Konstantin > Ananyev > Sent: Wednesday, November 14, 2018 11:24 AM > To: dev@dpdk.org > Cc: akhil.go...@nxp.com; Doherty, Declan ; > Ananyev, Konstantin > Subject: [dpdk-dev] [PATCH] doc: security deprecation notic

Re: [dpdk-dev] [PATCH] doc: security deprecation notice for session changes

2018-11-14 Thread Mohammad Abdul Awal
On 14/11/2018 11:23, Konstantin Ananyev wrote: Add 'uint64_t opaque_data' inside struct rte_security_session. That allows upper layer to easily associate some user defined data with the session. Proposed new layout for: struct rte_security_session { void *sess_private_data; /**

[dpdk-dev] [PATCH v2] lib/efd: fix write unlock during ring creation

2018-11-14 Thread Chaitanya Babu Talluri
In rte_efd_create() write lock has already been unlocked before ring creation itself. So second unlock after the ring creation has been removed. Fixes: 56b6ef874f80 ("efd: new Elastic Flow Distributor library") Cc: sta...@dpdk.org Signed-off-by: Chaitanya Babu Talluri Acked-by: Reshma Pattan --

Re: [dpdk-dev] [PATCH v2] eal: fix duplicate function declaration

2018-11-14 Thread Burakov, Anatoly
On 14-Nov-18 11:20 AM, Kevin Laatz wrote: The rte_eal_get_runtime_dir() function is currently being declared in two header files. This API was made public in commit 6911c9fd8fbe ("eal: export function to get runtime directory"), adding it to rte_eal.h. To make it public, the 'rte' prefix was add

[dpdk-dev] [PATCH] doc: security deprecation notice for session changes

2018-11-14 Thread Konstantin Ananyev
Add 'uint64_t opaque_data' inside struct rte_security_session. That allows upper layer to easily associate some user defined data with the session. Proposed new layout for: struct rte_security_session { void *sess_private_data; /**< Private session material */ + uint64_t opaqu

Re: [dpdk-dev] [PATCH] eal: fix duplicate function declaration

2018-11-14 Thread Burakov, Anatoly
On 14-Nov-18 11:14 AM, Kevin Laatz wrote: The rte_eal_get_runtime_dir() function is currently being declared in two header files. This API was made public in commit 6911c9fd8fbe, adding it to rte_eal.h. To make it public, the 'rte' prefix was added to the function so it needed to be modified in

  1   2   >