Re: [dpdk-dev] [PATCH] doc: document all EAL parameters in one place

2018-11-16 Thread Rami Rosen
On 11/16/2018 4:52 PM, Anatoly Burakov wrote: > Currently, the most complete (but still incomplete) user guide for > EAL command-line parameters resides in user guide for testpmd. > This is wrong on multiple levels, and should not be the case. > > To fix it, we have to create a document that lists

Re: [dpdk-dev] [PATCH] mem: Fix anonymous mapping on Power9.

2018-11-16 Thread dwilder
On 2018-11-15 07:11, Burakov, Anatoly wrote: On 14-Nov-18 8:40 PM, David Wilder wrote: Please include this patch in 18.11 as well, this patch is not suitable for 17.11. Small note: while this patch is not suitable for 17.11 as is, it can be made suitable if you drop the memalloc part. I copied

Re: [dpdk-dev] [PATCH] net/ixgbe: fix TDH register setting issue

2018-11-16 Thread Zhang, Qi Z
Hi Yanglong: > -Original Message- > From: Wu, Yanglong > Sent: Thursday, November 15, 2018 6:32 PM > To: dev@dpdk.org > Cc: Zhang, Qi Z ; Wu, Jingjing ; > Byrne, Stephen1 ; Wu, Yanglong > > Subject: [PATCH] net/ixgbe: fix TDH register setting issue > > The only time that software should

Re: [dpdk-dev] [PATCH V3] doc: add known PHY link up issue for i40e

2018-11-16 Thread Zhang, Qi Z
> -Original Message- > From: Kovacevic, Marko > Sent: Friday, November 16, 2018 1:41 AM > To: Guo, Jia ; Xing, Beilei ; > Mcnamara, John ; Zhang, Qi Z > > Cc: dev@dpdk.org; Zhang, Helin ; Wu, Jingjing > > Subject: RE: [PATCH V3] doc: add known PHY link up issue for i40e > > One very s

[dpdk-dev] [PATCH] Fixed environment variable name

2018-11-16 Thread Burdick, Cliff
The documentation specifies the DEST_DIR parameter to ninja to override the install directory, but it's actually DESTDIR. Signed-off-by: Cliff Burdick --- doc/build-sdk-meson.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/build-sdk-meson.txt b/doc/build-sdk-meson.t

Re: [dpdk-dev] [dpdk-stable] [PATCH v2] net/bonding: fix possible silent failure in configuration

2018-11-16 Thread Ferruh Yigit
On 11/16/2018 4:48 PM, Lee Daly wrote: > This patch checks the return value of function > rte_eth_bond_8023ad_agg_selection_set() in bond_ethdev_configure > for error return value. > > Fixes: 6d72657ce379 ("net/bonding: add other aggregator modes") > Cc: sta...@dpdk.org > > V2: > syntax changes.

[dpdk-dev] [PATCH v3] mem: Fix anonymous mapping on Power9.

2018-11-16 Thread David Wilder
Removed the use of MAP_HUGETLB for anonymous mapping on ppc64. The MAP_HUGETLB had previously been added to workaround issues on IBM Power8 systems when mapping /dev/zero (see: commit 284ae3e9ff9a92575c28c858efd2c85c8de6d440). In the current code the MAP_HUGETLB flag will cause the anonymous mapp

Re: [dpdk-dev] [PATCH] doc: document all EAL parameters in one place

2018-11-16 Thread Ferruh Yigit
On 11/16/2018 4:52 PM, Anatoly Burakov wrote: > Currently, the most complete (but still incomplete) user guide for > EAL command-line parameters resides in user guide for testpmd. > This is wrong on multiple levels, and should not be the case. > > To fix it, we have to create a document that lists

Re: [dpdk-dev] af_packet dev default "framesz" of 2048B

2018-11-16 Thread Ferruh Yigit
On 11/15/2018 7:02 PM, Lam, Tiago wrote: > Hi guys, > > OvS-DPDK has recently had small a change that changed the data room > available in an mbuf (commit dfaf00e in OvS). This seems to have had the > consequence of breaking the initialisation of eth_af_packets interfaces, > when using default val

[dpdk-dev] [PATCH 5/5] app/eventdev: fix possible uninitialized variable

2018-11-16 Thread Thomas Monjalon
When compiling with -O1, this error can appear: app/test-eventdev/test_pipeline_common.c:332:6: error: ‘ret’ may be used uninitialized in this function If there is no device, then ret is returned without being initialized. It is fixed by setting 0 as initial value. Fixes: 032a965a

[dpdk-dev] [PATCH 4/5] eventdev: fix possible uninitialized variable

2018-11-16 Thread Thomas Monjalon
When compiling with -O1, this error can appear: lib/librte_eventdev/rte_event_eth_tx_adapter.c:705:6: error: ‘ret’ may be used uninitialized in this function If tx_queue_id is -1 and nb_queues is 0, then ret is returned without being initialized. It is fixed by setting 0 as initial

[dpdk-dev] [PATCH 3/5] net/mlx4: fix possible uninitialized variable

2018-11-16 Thread Thomas Monjalon
When compiling with gcc -O1, this error appears: drivers/net/mlx4/mlx4_ethdev.c: In function ‘mlx4_rxmode_toggle’: rte_log.h:321:3: error: ‘mode’ may be used uninitialized in this function The function mlx4_rxmode_toggle is never called with a value which is not in the swit

[dpdk-dev] [PATCH 2/5] kni: fix possible uninitialized variable

2018-11-16 Thread Thomas Monjalon
This error can be raised: lib/librte_kni/rte_kni.c:531:15: error: 'req' may be used uninitialized in this function It should not happen because kni_fifo_get() would return 0 if req is not initialized, so the function would return before using req. But GCC complains about it in -O1

[dpdk-dev] [PATCH 1/5] eal: fix build with -O1

2018-11-16 Thread Thomas Monjalon
In case of optimized compilation, RTE_BUILD_BUG_ON use an external variable which is neither defined, nor used. It seems not optimized out in case of OPDL compiled with clang -O1: opdl_ring.c: undefined reference to `RTE_BUILD_BUG_ON_detected_error' clang-6.0: fatal error: linker co

[dpdk-dev] [PATCH 0/5] fix build with option -O1

2018-11-16 Thread Thomas Monjalon
When trying to compile with -O1, the compiler shows some errors. Some are justified, others look like compiler bug. Anyway, it's better to fix all of them. Thomas Monjalon (5): eal: fix build with -O1 kni: fix possible uninitialized variable net/mlx4: fix possible uninitialized variable e

Re: [dpdk-dev] [PATCH v2] devbind: check for lspci

2018-11-16 Thread Rami Rosen
Reviewed-by: Rami Rosen On Tue, 13 Nov 2018 at 18:06, Anatoly Burakov wrote: > > On some distributions (such as CentOS 7) lspci may not be installed > by default, causing exceptions which are difficult to interpret. > > Fix devbind script to check if lspci is installed at script startup. > > Cc:

[dpdk-dev] [PATCH] doc: document all EAL parameters in one place

2018-11-16 Thread Anatoly Burakov
Currently, the most complete (but still incomplete) user guide for EAL command-line parameters resides in user guide for testpmd. This is wrong on multiple levels, and should not be the case. To fix it, we have to create a document that lists all supported EAL command-line arguments. However, beca

[dpdk-dev] [PATCH v2] net/bonding: fix possible silent failure in configuration

2018-11-16 Thread Lee Daly
This patch checks the return value of function rte_eth_bond_8023ad_agg_selection_set() in bond_ethdev_configure for error return value. Fixes: 6d72657ce379 ("net/bonding: add other aggregator modes") Cc: sta...@dpdk.org V2: syntax changes. commit message update. Signed-off-by: Lee Daly --- dri

[dpdk-dev] [PATCH] net/i40e/base: fix comment referencing internal data

2018-11-16 Thread Ferruh Yigit
DCR is Intel internal information, no need to be in public code. Fixes: de2cd512b176 ("net/i40e/base: new AQ commands for cloud filter") Cc: sta...@dpdk.org Signed-off-by: Ferruh Yigit --- Cc: jingjing...@intel.com Cc: Qi Zhang --- drivers/net/i40e/base/i40e_adminq_cmd.h | 3 +-- 1 file change

Re: [dpdk-dev] [PATCH v4 0/2] fix pcap handlers for secondary

2018-11-16 Thread Ferruh Yigit
On 11/16/2018 2:54 PM, Ferruh Yigit wrote: > On 11/15/2018 1:37 AM, Qi Zhang wrote: >> Private vdev was the way previously, when pdump developed, now with >> shared device mode on virtual devices, pcap data path in secondary is >> not working. >> >> When secondary adds a virtual device, related dat

Re: [dpdk-dev] [RFC v2 1/9] usertools: add DPDK config lib python library

2018-11-16 Thread Bruce Richardson
On Fri, Nov 16, 2018 at 04:58:10PM +0100, Thomas Monjalon wrote: > 16/11/2018 16:43, Burakov, Anatoly: > > On 16-Nov-18 2:55 PM, Thomas Monjalon wrote: > > > 16/11/2018 15:37, Burakov, Anatoly: > > >> On 16-Nov-18 2:13 PM, Richardson, Bruce wrote: > > >>> From: Wiles, Keith > > > On Nov 16, 201

Re: [dpdk-dev] [PATCH] doc: deprecation notice for sched API change

2018-11-16 Thread Pattan, Reshma
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Jasvinder Singh > Sent: Wednesday, November 14, 2018 3:37 PM > To: dev@dpdk.org > Cc: Dumitrescu, Cristian > Subject: [dpdk-dev] [PATCH] doc: deprecation notice for sched API change > > There will be change in

Re: [dpdk-dev] [RFC v2 1/9] usertools: add DPDK config lib python library

2018-11-16 Thread Bruce Richardson
On Fri, Nov 16, 2018 at 03:43:57PM +, Burakov, Anatoly wrote: > On 16-Nov-18 2:55 PM, Thomas Monjalon wrote: > > 16/11/2018 15:37, Burakov, Anatoly: > > > On 16-Nov-18 2:13 PM, Richardson, Bruce wrote: > > > > From: Wiles, Keith > > > > > > On Nov 16, 2018, at 5:49 AM, Burakov, Anatoly > > > >

Re: [dpdk-dev] [RFC v2 1/9] usertools: add DPDK config lib python library

2018-11-16 Thread Thomas Monjalon
16/11/2018 16:43, Burakov, Anatoly: > On 16-Nov-18 2:55 PM, Thomas Monjalon wrote: > > 16/11/2018 15:37, Burakov, Anatoly: > >> On 16-Nov-18 2:13 PM, Richardson, Bruce wrote: > >>> From: Wiles, Keith > > On Nov 16, 2018, at 5:49 AM, Burakov, Anatoly > > On 16-Nov-18 12:45 AM, Stephen Hemmin

Re: [dpdk-dev] [PATCH v4 1/2] net/pcap: move pcap handler to process private

2018-11-16 Thread Ferruh Yigit
On 11/15/2018 1:37 AM, Qi Zhang wrote: > This is prework for data path enabling for secondary process. > To prevent pcap handler opened by one process be overwritten by > another process, each process should have their private copy, > `rte_eth_dev->process_private` is exactly what we needed. > > S

Re: [dpdk-dev] [PATCH 17.11] mem: fix memory initialization time

2018-11-16 Thread Burakov, Anatoly
On 16-Nov-18 2:42 PM, Alejandro Lucero wrote: On Fri, Nov 16, 2018 at 1:35 PM Burakov, Anatoly mailto:anatoly.bura...@intel.com>> wrote: On 16-Nov-18 12:49 PM, Alejandro Lucero wrote: > > > On Thu, Nov 15, 2018 at 1:16 PM Burakov, Anatoly > mailto:anatoly.bura...@inte

Re: [dpdk-dev] [PATCH v2] doc/power: add info on jansson conditional build

2018-11-16 Thread Kovacevic, Marko
Acked-by: Marko Kovacevic

[dpdk-dev] [PATCH v2] doc/power: add info on jansson conditional build

2018-11-16 Thread David Hunt
Add more info to the docs on how to set environmental variable to correctly build the vm_power_manager sample app in a cross compile or multilib environment by setting PKG_CONFIG_LIBDIR. Signed-off-by: David Hunt --- v2: Changed the note to be shown using the ``.. Note::`` tag. --- .../sample

Re: [dpdk-dev] [RFC v2 1/9] usertools: add DPDK config lib python library

2018-11-16 Thread Burakov, Anatoly
On 16-Nov-18 2:55 PM, Thomas Monjalon wrote: 16/11/2018 15:37, Burakov, Anatoly: On 16-Nov-18 2:13 PM, Richardson, Bruce wrote: From: Wiles, Keith On Nov 16, 2018, at 5:49 AM, Burakov, Anatoly On 16-Nov-18 12:45 AM, Stephen Hemminger wrote: Anatoly Burakov wrote: This is a placeholder for P

Re: [dpdk-dev] [PATCH] net/bonding: check return value in bond_ethdev_configure

2018-11-16 Thread Ferruh Yigit
On 11/16/2018 2:54 PM, Lee Daly wrote: > This patch checks the return value of function > rte_eth_bond_8023ad_agg_selection_set() in bond_ethdev_configure > for error return value. Thanks Lee, just a few minor syntax comment below. > > Signed-off-by: Lee Daly > --- > drivers/net/bonding/rte_et

Re: [dpdk-dev] [RFC v2 1/9] usertools: add DPDK config lib python library

2018-11-16 Thread Wiles, Keith
> On Nov 16, 2018, at 8:55 AM, Thomas Monjalon wrote: > > 16/11/2018 15:37, Burakov, Anatoly: >> On 16-Nov-18 2:13 PM, Richardson, Bruce wrote: >>> From: Wiles, Keith > On Nov 16, 2018, at 5:49 AM, Burakov, Anatoly > On 16-Nov-18 12:45 AM, Stephen Hemminger wrote: >> Anatoly Burako

Re: [dpdk-dev] [RFC v2 1/9] usertools: add DPDK config lib python library

2018-11-16 Thread Wiles, Keith
> On Nov 16, 2018, at 8:37 AM, Burakov, Anatoly > wrote: > > On 16-Nov-18 2:13 PM, Richardson, Bruce wrote: >>> -Original Message- >>> From: Wiles, Keith >>> Sent: Friday, November 16, 2018 2:10 PM >>> To: Burakov, Anatoly >>> Cc: Stephen Hemminger ; dev ; >>> Mcnamara, John ; Richar

Re: [dpdk-dev] [PATCH v3] net/avf: update Tx offload mask

2018-11-16 Thread Ferruh Yigit
On 11/16/2018 3:25 PM, Zhirun Yan wrote: > Tx offload mask is updated in following commit 1037ed842c37 > ("mbuf: fix Tx offload mask"). Currently, the new added offload > flags are not supported in PMD and application will fail to call > PMD transmit prepare function. > > This patch updates AVF_TX

Re: [dpdk-dev] [PATCH v2] examples/vhost_crypto: fix zero copy

2018-11-16 Thread Ferruh Yigit
On 11/16/2018 10:48 AM, Maxime Coquelin wrote: > > > On 11/14/18 12:16 PM, Fan Zhang wrote: >> This patch fixes the zero copy enable problem for vhost crypto >> sample application. >> >> For some Crypto PMDs such as AESNI-MB and AESNI-GCM the data to >> be processed will be made a copy in the sam

Re: [dpdk-dev] [RFC v2 1/9] usertools: add DPDK config lib python library

2018-11-16 Thread Thomas Monjalon
16/11/2018 15:37, Burakov, Anatoly: > On 16-Nov-18 2:13 PM, Richardson, Bruce wrote: > > From: Wiles, Keith > >>> On Nov 16, 2018, at 5:49 AM, Burakov, Anatoly > >>> On 16-Nov-18 12:45 AM, Stephen Hemminger wrote: > Anatoly Burakov wrote: > > This is a placeholder for Python library abstr

Re: [dpdk-dev] [PATCH v4 0/2] fix pcap handlers for secondary

2018-11-16 Thread Ferruh Yigit
On 11/15/2018 1:37 AM, Qi Zhang wrote: > Private vdev was the way previously, when pdump developed, now with > shared device mode on virtual devices, pcap data path in secondary is > not working. > > When secondary adds a virtual device, related data transferred to > primary and primary creates th

[dpdk-dev] [PATCH] net/bonding: check return value in bond_ethdev_configure

2018-11-16 Thread Lee Daly
This patch checks the return value of function rte_eth_bond_8023ad_agg_selection_set() in bond_ethdev_configure for error return value. Signed-off-by: Lee Daly --- drivers/net/bonding/rte_eth_bond_pmd.c | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/drivers/net/b

Re: [dpdk-dev] [PATCH 17.11] mem: fix memory initialization time

2018-11-16 Thread Alejandro Lucero
On Fri, Nov 16, 2018 at 1:35 PM Burakov, Anatoly wrote: > On 16-Nov-18 12:49 PM, Alejandro Lucero wrote: > > > > > > On Thu, Nov 15, 2018 at 1:16 PM Burakov, Anatoly > > mailto:anatoly.bura...@intel.com>> wrote: > > > > On 12-Nov-18 11:18 AM, Alejandro Lucero wrote: > > > When using larg

[dpdk-dev] dpdk 18.11-rc3 testing results from Red Hat

2018-11-16 Thread Pei Zhang
Hi all, I'm Pei Zhang from Red Hat. We have tested dpdk 18.11-rc3 and we would like to share our testing results. Here are 10 testing scenarios we have covered and all get PASS result: (1)Guest with device assignment(PF) throughput testing(1G hugepage size) PASS (2)Guest with device assignm

Re: [dpdk-dev] [RFC v2 1/9] usertools: add DPDK config lib python library

2018-11-16 Thread Burakov, Anatoly
On 16-Nov-18 2:13 PM, Richardson, Bruce wrote: -Original Message- From: Wiles, Keith Sent: Friday, November 16, 2018 2:10 PM To: Burakov, Anatoly Cc: Stephen Hemminger ; dev ; Mcnamara, John ; Richardson, Bruce ; De Lara Guarch, Pablo ; Hunt, David ; Awal, Mohammad Abdul ; tho...@monj

Re: [dpdk-dev] [PATCH 2/2] cryptodev: change symmetric session structure

2018-11-16 Thread Ananyev, Konstantin
Hi Fan, > > This patch changes the symmetric session structure of cryptodev. > The symmetric session now contains extra information for secure > access purposes. The patch also includes the updates to the > PMDs, test applications, and examples to fit the change. Few more comments from me in-lin

Re: [dpdk-dev] Direct using of 'rte_eth_devices' in DPDK apps.

2018-11-16 Thread Wiles, Keith
> On Nov 16, 2018, at 3:51 AM, Ananyev, Konstantin > wrote: > > Hi everyone, > >> >> Hi, >> >> 16/11/2018 09:42, Ilya Maximets: >>> Hi, >>> While discussing the ways to enable DPDK 18.11 new features in OVS >>> there was suggestions to use 'rte_eth_devices[]' array directly. >>> But this a

Re: [dpdk-dev] Direct using of 'rte_eth_devices' in DPDK apps.

2018-11-16 Thread Wiles, Keith
On Nov 16, 2018, at 3:51 AM, Ananyev, Konstantin mailto:konstantin.anan...@intel.com>> wrote: Hi everyone, Hi, 16/11/2018 09:42, Ilya Maximets: Hi, While discussing the ways to enable DPDK 18.11 new features in OVS there was suggestions to use 'rte_eth_devices[]' array directly. But this ar

Re: [dpdk-dev] [RFC v2 1/9] usertools: add DPDK config lib python library

2018-11-16 Thread Richardson, Bruce
> -Original Message- > From: Wiles, Keith > Sent: Friday, November 16, 2018 2:10 PM > To: Burakov, Anatoly > Cc: Stephen Hemminger ; dev ; > Mcnamara, John ; Richardson, Bruce > ; De Lara Guarch, Pablo > ; Hunt, David ; > Awal, Mohammad Abdul ; tho...@monjalon.net; > Yigit, Ferruh > Su

Re: [dpdk-dev] [RFC v2 1/9] usertools: add DPDK config lib python library

2018-11-16 Thread Wiles, Keith
> On Nov 16, 2018, at 5:49 AM, Burakov, Anatoly > wrote: > > On 16-Nov-18 12:45 AM, Stephen Hemminger wrote: >> On Thu, 15 Nov 2018 15:47:13 + >> Anatoly Burakov wrote: >>> This is a placeholder for Python library abstracting away many of >>> mundane details DPDK configuration scripts ha

Re: [dpdk-dev] [dpdk-stable] [PATCH v2] lib/efd: fix write unlock during ring creation

2018-11-16 Thread Ferruh Yigit
On 11/14/2018 11:24 AM, Chaitanya Babu Talluri wrote: > In rte_efd_create() write lock has already been unlocked > before ring creation itself. > So second unlock after the ring creation has been removed. > > Fixes: 56b6ef874f80 ("efd: new Elastic Flow Distributor library") > Cc: sta...@dpdk.org >

Re: [dpdk-dev] [PATCH 17.11] mem: fix memory initialization time

2018-11-16 Thread Burakov, Anatoly
On 16-Nov-18 12:49 PM, Alejandro Lucero wrote: On Thu, Nov 15, 2018 at 1:16 PM Burakov, Anatoly mailto:anatoly.bura...@intel.com>> wrote: On 12-Nov-18 11:18 AM, Alejandro Lucero wrote: > When using large amount of hugepage based memory, doing all the > hugepages mapping can tak

Re: [dpdk-dev] [PATCH 17.11] mem: fix memory initialization time

2018-11-16 Thread Alejandro Lucero
On Thu, Nov 15, 2018 at 1:16 PM Burakov, Anatoly wrote: > On 12-Nov-18 11:18 AM, Alejandro Lucero wrote: > > When using large amount of hugepage based memory, doing all the > > hugepages mapping can take quite significant time. > > > > The problem is hugepages being initially mmaped to virtual ad

Re: [dpdk-dev] [PATCH 1/2] cryptodev: change queue pair configure structure

2018-11-16 Thread Ananyev, Konstantin
Hi Fan, > --- a/config/common_base > +++ b/config/common_base > @@ -446,7 +446,7 @@ CONFIG_RTE_LIBRTE_VDEV_NETVSC_PMD=n > # > # Compile null PMD > # > -CONFIG_RTE_LIBRTE_PMD_NULL=y > +CONFIG_RTE_LIBRTE_PMD_NULL=n > > # > # Compile software PMD backed by PCAP files > @@ -525,13 +525,13 @@ CON

Re: [dpdk-dev] [RFC v2 1/9] usertools: add DPDK config lib python library

2018-11-16 Thread Burakov, Anatoly
On 16-Nov-18 12:45 AM, Stephen Hemminger wrote: On Thu, 15 Nov 2018 15:47:13 + Anatoly Burakov wrote: This is a placeholder for Python library abstracting away many of mundane details DPDK configuration scripts have to deal with. We need __init__.py file to make the subdirectory a package

Re: [dpdk-dev] [PATCH v2] build: document that Meson < 0.46 will fail to list private deps

2018-11-16 Thread Richardson, Bruce
> -Original Message- > From: Luca Boccassi [mailto:bl...@debian.org] > Sent: Friday, November 16, 2018 10:58 AM > To: dev@dpdk.org > Cc: Richardson, Bruce ; tho...@monjalon.net; > Luca Boccassi > Subject: [PATCH v2] build: document that Meson < 0.46 will fail to list > private deps > >

Re: [dpdk-dev] [PATCH 1/2] net/bnx2x: cleanup info logs

2018-11-16 Thread Ferruh Yigit
On 11/14/2018 6:17 PM, Mody, Rasesh wrote: > Reduced number of INFO logs in BNX2X PMD by converting some INFO > logs to DEBUG and few NOTICE logs to INFO, removing extra new lines, > printing banner bar once for the adapter and device specific info. > > Fixes: ba7eeb035a5f ("net/bnx2x: fix logging

Re: [dpdk-dev] [PATCH] net/octeontx: fix failures when available ports > queues

2018-11-16 Thread Ferruh Yigit
On 11/14/2018 10:40 AM, Jerin Jacob wrote: > -Original Message- >> Date: Wed, 14 Nov 2018 14:52:03 +0530 >> From: "Joseph, Anoob" >> To: Ferruh Yigit , "Jacob, Jerin" >> >> CC: "Joseph, Anoob" , "Athreya, Narayana Prasad" >> , "Bhagavatula, Pavan" >> , "dev@dpdk.org" , >> "sta...@dpd

[dpdk-dev] [PATCH v2] build: document that Meson < 0.46 will fail to list private deps

2018-11-16 Thread Luca Boccassi
Meson can generate the list of private dependencies of libraries automatically for the pkgconfig file only since version 0.46.0. Signed-off-by: Luca Boccassi --- v2: corrected version, minimum required is meson 0.46 doc/build-sdk-meson.txt | 6 ++ 1 file changed, 6 insertions(+) diff --git

Re: [dpdk-dev] [PATCH] net/ena: cleaning HW IO rings configuration

2018-11-16 Thread Ferruh Yigit
On 11/14/2018 9:59 AM, Rafal Kozik wrote: > When queues are stoped release tx buffers. > During start initialize array of empty > tx/rx reqs with default values. > > Fixes: df238f84c0a2 ("net/ena: recreate HW IO rings on start and stop") > > Signed-off-by: Rafal Kozik > Acked-by: Michal Krawczyk

Re: [dpdk-dev] [PATCH] build: document that Meson < 0.45 will fail to list private deps

2018-11-16 Thread Luca Boccassi
On Fri, 2018-11-16 at 10:52 +, Luca Boccassi wrote: > On Fri, 2018-11-16 at 10:26 +, Bruce Richardson wrote: > > On Thu, Nov 15, 2018 at 06:26:28PM +, Luca Boccassi wrote: > > > Meson can generate the list of private dependencies of libraries > > > automatically for the pkgconfig file o

Re: [dpdk-dev] [PATCH] build: document that Meson < 0.45 will fail to list private deps

2018-11-16 Thread Luca Boccassi
On Fri, 2018-11-16 at 10:26 +, Bruce Richardson wrote: > On Thu, Nov 15, 2018 at 06:26:28PM +, Luca Boccassi wrote: > > Meson can generate the list of private dependencies of libraries > > automatically for the pkgconfig file only since version 0.45.0. > > > > Signed-off-by: Luca Boccassi

Re: [dpdk-dev] [PATCH v2] examples/vhost_crypto: fix zero copy

2018-11-16 Thread Maxime Coquelin
On 11/14/18 12:16 PM, Fan Zhang wrote: This patch fixes the zero copy enable problem for vhost crypto sample application. For some Crypto PMDs such as AESNI-MB and AESNI-GCM the data to be processed will be made a copy in the same buffer but next to the data. For example, to encrypt 64 bytes

Re: [dpdk-dev] af_packet dev default "framesz" of 2048B

2018-11-16 Thread Bruce Richardson
On Thu, Nov 15, 2018 at 07:02:37PM +, Lam, Tiago wrote: > Hi guys, > > OvS-DPDK has recently had small a change that changed the data room > available in an mbuf (commit dfaf00e in OvS). This seems to have had the > consequence of breaking the initialisation of eth_af_packets interfaces, > whe

Re: [dpdk-dev] [PATCH] net/mvpp2: fix possible uninitialized variable access

2018-11-16 Thread Ferruh Yigit
On 11/15/2018 2:38 PM, Tomasz Duszynski wrote: > On Mon, Nov 05, 2018 at 03:25:22PM +, Ferruh Yigit wrote: >> Fixes: cdb53f8da628 ("net/mvpp2: support metering") >> >> Signed-off-by: Ferruh Yigit > > Acked-by: Tomasz Duszynski Applied to dpdk-next-net/master, thanks.

Re: [dpdk-dev] [PATCH v2] pci_vfio: Support 64KB kernel page_size with vfio-pci driver

2018-11-16 Thread Burakov, Anatoly
On 16-Nov-18 2:34 AM, Tone Zhang (Arm Technology China) wrote: Hi Anatoly, I have some comments. -Original Message- From: Tone Zhang (Arm Technology China) Sent: Thursday, November 15, 2018 8:49 AM To: Burakov, Anatoly ; dev@dpdk.org Cc: Gavin Hu (Arm Technology China) ; Honnappa Nagar

Re: [dpdk-dev] [PATCH v3] app/proc-info: fix port mask parse issue

2018-11-16 Thread Burakov, Anatoly
On 16-Nov-18 10:15 AM, Burakov, Anatoly wrote: On 07-Nov-18 6:10 AM, Li Han wrote: parse_portmask return type is int,but global variable "enabled_port_mask" type is uint32_t.so in proc_info_parse_args function,when parse_portmask return -1,"enabled_port_mask" will get a huge value and "if (enabl

Re: [dpdk-dev] af_packet dev default "framesz" of 2048B

2018-11-16 Thread Burakov, Anatoly
On 15-Nov-18 7:02 PM, Lam, Tiago wrote: Hi guys, OvS-DPDK has recently had small a change that changed the data room available in an mbuf (commit dfaf00e in OvS). This seems to have had the consequence of breaking the initialisation of eth_af_packets interfaces, when using default values ("optio

Re: [dpdk-dev] DPDK techboard minutes of November 07

2018-11-16 Thread Burakov, Anatoly
On 15-Nov-18 6:31 PM, Ananyev, Konstantin wrote: Meeting notes for the DPDK technical board meeting held on 2018-11-07 Attendees: - Bruce Richardson - Ferruh Yigit - Konstantin Ananyev - Maxime Coquelin - Olivier Matz - Thomas Monjalon 0) I

Re: [dpdk-dev] [PATCH] build: document that Meson < 0.45 will fail to list private deps

2018-11-16 Thread Bruce Richardson
On Thu, Nov 15, 2018 at 06:26:28PM +, Luca Boccassi wrote: > Meson can generate the list of private dependencies of libraries > automatically for the pkgconfig file only since version 0.45.0. > > Signed-off-by: Luca Boccassi > --- > doc/build-sdk-meson.txt | 6 ++ > 1 file changed, 6 ins

Re: [dpdk-dev] [PATCH 2/9] security: add opaque userdata pointer into security session

2018-11-16 Thread Mohammad Abdul Awal
On 15/11/2018 23:53, Konstantin Ananyev wrote: Add 'uint64_t opaque_data' inside struct rte_security_session. That allows upper layer to easily associate some user defined data with the session. Signed-off-by: Konstantin Ananyev --- lib/librte_security/rte_security.h | 2 ++ 1 file change

Re: [dpdk-dev] [PATCH 1/1] eal: Don't fail secondary if primary is missing tailqs

2018-11-16 Thread Bruce Richardson
On Thu, Nov 15, 2018 at 06:22:07PM +, Luca Boccassi wrote: > On Thu, 2018-11-15 at 17:17 +, Bruce Richardson wrote: > > On Thu, Nov 15, 2018 at 05:05:16PM +, Luca Boccassi wrote: > > > On Thu, 2018-11-15 at 17:01 +, Richardson, Bruce wrote: > > > > > -Original Message- > > >

Re: [dpdk-dev] [PATCH 1/9] cryptodev: add opaque userdata pointer into crypto sym session

2018-11-16 Thread Mohammad Abdul Awal
On 15/11/2018 23:53, Konstantin Ananyev wrote: Add 'uint64_t opaque_data' inside struct rte_cryptodev_sym_session. That allows upper layer to easily associate some user defined data with the session. Signed-off-by: Konstantin Ananyev --- lib/librte_cryptodev/rte_cryptodev.h | 2 ++ 1 file

Re: [dpdk-dev] [PATCH 3/9] net: add ESP trailer structure definition

2018-11-16 Thread Mohammad Abdul Awal
On 15/11/2018 23:53, Konstantin Ananyev wrote: Signed-off-by: Konstantin Ananyev --- lib/librte_net/rte_esp.h | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/lib/librte_net/rte_esp.h b/lib/librte_net/rte_esp.h index f77ec2eb2..8e1b3d2dd 100644 --- a/lib/librte

Re: [dpdk-dev] [PATCH 1/1] eal: Don't fail secondary if primary is missing tailqs

2018-11-16 Thread Bruce Richardson
On Thu, Nov 15, 2018 at 05:36:06PM +, Burdick, Cliff wrote: > > > -Original Message- > From: Bruce Richardson [mailto:bruce.richard...@intel.com] > Sent: Thursday, November 15, 2018 9:17 AM > To: Luca Boccassi > Cc: Burdick, Cliff; Thomas Monjalon; Burakov, Anatoly; dev@dpdk.org > Su

��: [PATCH v2] mem: Fix anonymous mapping on Power9.

2018-11-16 Thread Chao Zhu
> -ÓʼþÔ­¼þ- > ·¢¼þÈË: David Wilder > ·¢ËÍʱ¼ä: 2018Äê11ÔÂ16ÈÕ 10:08 > ÊÕ¼þÈË: dev@dpdk.org > ³­ËÍ: sta...@dpdk.org; prad...@us.ibm.com; chao...@linux.vnet.ibm.com; > tho...@monjalon.net > Ö÷Ìâ: [PATCH v2] mem: Fix anonymous mapping on Power9. >

Re: [dpdk-dev] [PATCH v3] app/proc-info: fix port mask parse issue

2018-11-16 Thread Burakov, Anatoly
On 07-Nov-18 6:10 AM, Li Han wrote: parse_portmask return type is int,but global variable "enabled_port_mask" type is uint32_t.so in proc_info_parse_args function,when parse_portmask return -1,"enabled_port_mask" will get a huge value and "if (enabled_port_mask == 0)" will never happen. Fixes: 2

[dpdk-dev] [RFC] Ethernet drivers to add padding on egress

2018-11-16 Thread Morten Brørup
Hi networking driver maintainers, I suggest that the TX functions of Ethernet interface drivers accept packets with less than 60 byte payload, and transmit them on the medium as valid Ethernet frames, i.e. by padding the packets up to the minimum Ethernet packet size of 64 bytes incl. Ethernet

Re: [dpdk-dev] Direct using of 'rte_eth_devices' in DPDK apps.

2018-11-16 Thread Ananyev, Konstantin
Hi everyone, > > Hi, > > 16/11/2018 09:42, Ilya Maximets: > > Hi, > > While discussing the ways to enable DPDK 18.11 new features in OVS > > there was suggestions to use 'rte_eth_devices[]' array directly. > > But this array is marked as '@internal' and also it located in > > the internal header

Re: [dpdk-dev] [PATCH] net/igb: fix LSC interrupt when using MSI-X

2018-11-16 Thread Zhao1, Wei
Hi, Player, Timmons > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Player, Timmons > Sent: Thursday, November 8, 2018 2:31 AM > To: Lu, Wenzhuo > Cc: dev@dpdk.org; Player, Timmons > Subject: [dpdk-dev] [PATCH] net/igb: fix LSC interrupt when using MSI-X > >

Re: [dpdk-dev] [PATCH V3] doc: add known PHY link up issue for i40e

2018-11-16 Thread Kovacevic, Marko
One very small spelling fix > +PHY link up fails when rebinding i40e NICs to kernel driver > +--- > + > +**Description**: > + Some kernel drivers are not able to handle the link status correctly > + after DPDK application sets the PHY to

[dpdk-dev] [PATCH] test: fixed uncorrect interrupt type

2018-11-16 Thread Qiming Yang
Fixed the interrupt type using error. Check valid alarm should use TEST_INTERRUPT_HANDLE_VALID_ALARM. Fixes: 493b8e173fe6 ("eal: add device event handle in interrupt thread") Signed-off-by: Qiming Yang --- test/test/test_interrupts.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff -

Re: [dpdk-dev] Direct using of 'rte_eth_devices' in DPDK apps.

2018-11-16 Thread Ferruh Yigit
On 11/16/2018 8:42 AM, Ilya Maximets wrote: > Hi, > While discussing the ways to enable DPDK 18.11 new features in OVS > there was suggestions to use 'rte_eth_devices[]' array directly. > But this array is marked as '@internal' and also it located in > the internal header 'lib/librte_ethdev/rte_eth

Re: [dpdk-dev] Direct using of 'rte_eth_devices' in DPDK apps.

2018-11-16 Thread Thomas Monjalon
Hi, 16/11/2018 09:42, Ilya Maximets: > Hi, > While discussing the ways to enable DPDK 18.11 new features in OVS > there was suggestions to use 'rte_eth_devices[]' array directly. > But this array is marked as '@internal' and also it located in > the internal header 'lib/librte_ethdev/rte_ethdev_co

[dpdk-dev] Direct using of 'rte_eth_devices' in DPDK apps.

2018-11-16 Thread Ilya Maximets
Hi, While discussing the ways to enable DPDK 18.11 new features in OVS there was suggestions to use 'rte_eth_devices[]' array directly. But this array is marked as '@internal' and also it located in the internal header 'lib/librte_ethdev/rte_ethdev_core.h' with the following disclaimer: /** * @fi