[dpdk-dev] [PATCH V3] doc: add tested Intel platforms with Intel NICs

2018-11-18 Thread Lijuan Tu
Add tested Intel platforms with Intel NICs to the release note. Signed-off-by: Lijuan Tu --- doc/guides/rel_notes/release_18_11.rst | 70 ++ 1 file changed, 70 insertions(+) diff --git a/doc/guides/rel_notes/release_18_11.rst b/doc/guides/rel_notes/release_18_11

[dpdk-dev] [PATCH V2] doc: add tested Intel platforms with Intel NICs

2018-11-18 Thread Lijuan Tu
Add tested Intel platforms with Intel NICs to the release note. Signed-off-by: Lijuan Tu --- doc/guides/rel_notes/release_18_11.rst | 70 ++ 1 file changed, 70 insertions(+) diff --git a/doc/guides/rel_notes/release_18_11.rst b/doc/guides/rel_notes/release_18_11

[dpdk-dev] [PATCH] doc: add tested Intel platforms with Intel NICs

2018-11-18 Thread Lijuan Tu
Signed-off-by: Lijuan Tu --- doc/guides/rel_notes/release_18_11.rst | 70 ++ 1 file changed, 70 insertions(+) diff --git a/doc/guides/rel_notes/release_18_11.rst b/doc/guides/rel_notes/release_18_11.rst index 32ff0e5..6499953 100644 --- a/doc/guides/rel_notes/rel

Re: [dpdk-dev] mlx5 under FreeBSD

2018-11-18 Thread Shahaf Shuler
Hi Mit, Monday, November 19, 2018 1:23 AM, Mit Matelske: > Subject: Re: [dpdk-dev] mlx5 under FreeBSD > > > 15/11/2018 17:48, Mit Matelske: > >> Is anyone working to include support for the mlx5 PMD under FreeBSD? > > > > I think Stephen (Cc) looked at it. > > > >> I've started down this road by

[dpdk-dev] [PATCH v3] pci_vfio: Support 64KB kernel page_size with vfio-pci driver

2018-11-18 Thread tone.zhang
With a larger PAGE_SIZE it is possible for the MSI table to very close to the end of the BAR s.t. when we align the start and end of the MSI table to the PAGE_SIZE, the end offset of the MSI table is out of the PCI BAR boundary. This patch addresses the issue by comparing both the start and the en

Re: [dpdk-dev] [PATCH 1/2] test/pmd_ring_perf: release ring resources after test

2018-11-18 Thread Phil Yang (Arm Technology China)
Hi Thomas, > -Original Message- > From: Thomas Monjalon > Sent: Monday, November 19, 2018 6:21 AM > To: Phil Yang (Arm Technology China) > Cc: dev@dpdk.org; nd ; Gavin Hu (Arm Technology China) > > Subject: Re: [dpdk-dev] [PATCH 1/2] test/pmd_ring_perf: release ring resources > after te

[dpdk-dev] [dpdk-announce] release candidate 18.11-rc4

2018-11-18 Thread Thomas Monjalon
A new DPDK release candidate is ready for testing: https://git.dpdk.org/dpdk/tag/?id=v18.11-rc4 68 patches were integrated. There will be a fifth release candidate on Thursday, for last minute fixes and some documentation updates. The release notes (missing the tested hardware list):

Re: [dpdk-dev] [PATCH] doc: update timestamp validity for latency measurement

2018-11-18 Thread Thomas Monjalon
04/10/2018 14:23, Reshma Pattan: > Updated the doc on how packets are marked to identify > their timestamp as valid and considered for latency > measurement. > > Suggested-by: Bao-Long Tran > Signed-off-by: Reshma Pattan > --- > This change is relevant to the below patch and must be applied > af

Re: [dpdk-dev] [PATCH] doc: use generate_ipv4_flow in flow filtering guide

2018-11-18 Thread Thomas Monjalon
08/11/2018 20:46, Rami Rosen: > This patch fixes a typo in flow_filtering.rst. There is no > method named generate_ipv4_rule in DPDK, it should be generate_ipv4_flow. > > Signed-off-by: Rami Rosen Applied, thanks

Re: [dpdk-dev] [PATCH v1] doc: fix sample application formatting

2018-11-18 Thread Thomas Monjalon
16/10/2018 17:08, Ferruh Yigit: > On 8/16/2018 5:35 PM, Marko Kovacevic wrote: > > Fixed formatting an extra header was added making it an extra > > section when it was not intended. > > > > Fixes: d0dff9ba445e ("doc: sample application user guide") > > Cc: bernard.iremon...@intel.com > > > > Sig

Re: [dpdk-dev] [PATCH v2] doc/power: add info on jansson conditional build

2018-11-18 Thread Thomas Monjalon
16/11/2018 16:47, David Hunt: > Add more info to the docs on how to set environmental variable to > correctly build the vm_power_manager sample app in a cross compile > or multilib environment by setting PKG_CONFIG_LIBDIR. > > Signed-off-by: David Hunt Applied, thanks

Re: [dpdk-dev] [dpdk-stable] [PATCH v2] doc: add cross compile part for sample applications

2018-11-18 Thread Thomas Monjalon
17/09/2018 04:13, Gavin Hu: > Fixes: 7cacb05655 ("doc: add generic build instructions for sample apps") > Cc: sta...@dpdk.org > > Signed-off-by: Gavin Hu > Reviewed-by: Honnappa Nagarahalli Applied, thanks

Re: [dpdk-dev] [PATCH v4 2/2] doc: create a platorm specific page for NXP DPAA2 platform

2018-11-18 Thread Thomas Monjalon
26/09/2018 09:42, Hemant Agrawal: > Signed-off-by: Hemant Agrawal > Acked-by: Marko Kovacevic Series applied, thanks

Re: [dpdk-dev] [PATCH] doc/guides: update build steps for OCTEON TX

2018-11-18 Thread Thomas Monjalon
14/11/2018 10:42, Anoob Joseph: > Updating platform doc with steps to build when using Cavium OCTEON TX > SDK. SDK would be required for using crypto offload block. > > Signed-off-by: Anoob Joseph Applied, thanks

Re: [dpdk-dev] [PATCH v2] doc/linux_gsg: fix numa lib name error

2018-11-18 Thread Thomas Monjalon
07/11/2018 14:28, Burakov, Anatoly: > On 07-Nov-18 2:40 AM, Yong Wang wrote: > > The library for handling NUMA is not libnuma-devel, but numactl-devel > > in Red Hat/Fedora and libnuma-dev in Debian/Ubuntu. > > > > Signed-off-by: Yong Wang > > > > --- > > v2: > > * Add lib name in Ubuntu. > > --

Re: [dpdk-dev] [PATCH v6] doc: Clarify IOMMU usage with "uio_pci_generic" kernel module

2018-11-18 Thread Thomas Monjalon
26/09/2018 07:08, tone.zhang: > If the devices used for DPDK are bound to the "uio_pci_generic" kernel > module, the IOMMU should be disabled in order not to break the IO > transmission because of the virtual / physical address mapping. > > The patch clarifies the IOMMU configurations on both x86_

Re: [dpdk-dev] [PATCH v2] doc: note min required kernel version increase for 19.02

2018-11-18 Thread Thomas Monjalon
10/10/2018 16:14, Kevin Traynor: > Updating docs to reflect decision made at the techboard > that the min kernel version should be bumped from 3.2 to > the latest longterm stable release (3.16), but that > compatiblity for commonly used distribution kernels should > be kept also. > > Signed-off-by

Re: [dpdk-dev] [PATCH] Fixed environment variable name

2018-11-18 Thread Thomas Monjalon
16/11/2018 19:02, Burdick, Cliff: > The documentation specifies the DEST_DIR parameter to ninja to override the > install directory, but it's actually DESTDIR. > > Signed-off-by: Cliff Burdick Thank you A similar patch was sent earlier: https://patches.dpdk.org/patch/48072/

Re: [dpdk-dev] [PATCH] doc: fix DESTDIR variable name in meson guide

2018-11-18 Thread Thomas Monjalon
14/11/2018 14:56, Bruce Richardson: > On Wed, Nov 14, 2018 at 03:04:38PM +0300, Ilya Maximets wrote: > > ninja does not recognize 'DEST_DIR'. > > > > Fixes: 9c3adc289c5e ("doc: add instructions on build using meson") > > Cc: sta...@dpdk.org > > > > Signed-off-by: Ilya Maximets > > --- > > doc/b

Re: [dpdk-dev] [PATCH v2] build: document that Meson < 0.46 will fail to list private deps

2018-11-18 Thread Thomas Monjalon
> > Meson can generate the list of private dependencies of libraries > > automatically for the pkgconfig file only since version 0.46.0. > > > > Signed-off-by: Luca Boccassi > > Acked-by: Bruce Richardson Applied, thanks Title updated: build: document Meson < 0.46 miss private dependencies

Re: [dpdk-dev] [PATCH] doc: document KNI limitation in release notes

2018-11-18 Thread Thomas Monjalon
05/11/2018 18:09, Ferruh Yigit: > Commit a9460a0b2efb ("kni: fix build on Linux 4.19") disables some > ethtool commands because they are removed in newer (4.19) kernels. > > This patch documents removed functionality. > > Signed-off-by: Ferruh Yigit Applied, thanks

Re: [dpdk-dev] [PATCH] doc: update release notes for default KNI carries status

2018-11-18 Thread Thomas Monjalon
05/11/2018 18:28, Ferruh Yigit: > Commit 89397a01ce4a ("kni: set default carrier state of interface") > changes the KNI interface default carrier status. Which prevents traffic > flow by default and may break some existing usage / testing. > > Document this behavior change in release notes. > > S

Re: [dpdk-dev] mlx5 under FreeBSD

2018-11-18 Thread Mit Matelske
> 15/11/2018 17:48, Mit Matelske: >> Is anyone working to include support for the mlx5 PMD under FreeBSD? > > I think Stephen (Cc) looked at it. > >> I've started down this road by building Linux compatibility layers for the >> required Netlink and Ethtool calls in the driver, but would gladly ac

Re: [dpdk-dev] [PATCH v2] doc: add kni changes to release note

2018-11-18 Thread Thomas Monjalon
14/11/2018 01:34, Ferruh Yigit: > On 11/5/2018 7:54 PM, Dan Gora wrote: > > Add the new module parameter for the KNI kernel module, the new command > > line flag for the KNI sample application, and the new API function > > 'rte_kni_update_link()' to the release note. > > > > Signed-off-by: Dan Gor

Re: [dpdk-dev] [PATCH] devbind: don't display non-existent device categories

2018-11-18 Thread Thomas Monjalon
13/11/2018 17:42, Anatoly Burakov: > --- a/usertools/dpdk-devbind.py > +++ b/usertools/dpdk-devbind.py > +n_devs = len(dpdk_drv) + len(kernel_drv) + len(no_drv) > + > +# don't bother displaying anything if there are no devices > +if n_devs == 0: > +msg = "No '%s' devices detecte

Re: [dpdk-dev] [PATCH v2] devbind: check for lspci

2018-11-18 Thread Thomas Monjalon
16/11/2018 17:54, Rami Rosen: > On Tue, 13 Nov 2018 at 18:06, Anatoly Burakov > wrote: > > > > On some distributions (such as CentOS 7) lspci may not be installed > > by default, causing exceptions which are difficult to interpret. > > > > Fix devbind script to check if lspci is installed at scri

Re: [dpdk-dev] [PATCH] devtools: disable coloring of git-log output

2018-11-18 Thread Thomas Monjalon
23/10/2018 10:52, Ali Alnubani: > Colored git-log outputs will have escape characters > appended to hashes, causing check-git-log.sh to fail > with `error: malformed object name ?[33m?[m` when doing > `git tag -l --contains `. I guess it is due to a config specifying to color "always". > Signed-o

Re: [dpdk-dev] [PATCH 1/1] remove unnecessray fw declarations

2018-11-18 Thread Thomas Monjalon
22/08/2018 16:37, Rami Rosen: > --- a/app/test-pmd/testpmd.c > +++ b/app/test-pmd/testpmd.c > @@ -435,9 +435,6 @@ static int eth_event_callback(portid_t port_id, > static void eth_dev_event_callback(char *device_name, > enum rte_dev_event_type type, >

Re: [dpdk-dev] [PATCH] check-symbol-change: fix regex to match on end of map file

2018-11-18 Thread Thomas Monjalon
02/11/2018 12:50, Neil Horman: > On Thu, Nov 01, 2018 at 11:53:00PM +0100, Thomas Monjalon wrote: > > 01/11/2018 14:54, Neil Horman: > > > the regex to determine the end of the map file chunk in a patch seems to > > > be wrong, It was using perl regex syntax, which awk doesn't appear to > > > supp

Re: [dpdk-dev] [PATCH 1/2] test/pmd_ring_perf: release ring resources after test

2018-11-18 Thread Thomas Monjalon
19/10/2018 13:00, Phil Yang: > Need to release the port and the ring resources after test. Otherwise, > it will cause failure to allocate memory when reentry the test. > > Fixes: ea764af ("app/test: add performance test for ring driver") > > Signed-off-by: Phil Yang > Reviewed-by: Gavin Hu Thi

Re: [dpdk-dev] [PATCH] test: fixed uncorrect interrupt type

2018-11-18 Thread Thomas Monjalon
16/11/2018 18:04, Qiming Yang: > Fixed the interrupt type using error. Check valid alarm should use > TEST_INTERRUPT_HANDLE_VALID_ALARM. > > Fixes: 493b8e173fe6 ("eal: add device event handle in interrupt thread") > > Signed-off-by: Qiming Yang Applied, thanks

Re: [dpdk-dev] [PATCH] test: fix eal flags autotest hugepage file handling

2018-11-18 Thread Thomas Monjalon
15/11/2018 13:18, Anatoly Burakov: > Before 18.05, DPDK could not release memory back to the system > neither at runtime nor before shutting down. Over the course of > 18.05 up to 18.11, code was introduced to release memory at > runtime, as well as an rte_eal_cleanup() function that is supposed >

Re: [dpdk-dev] [dpdk-stable] [PATCH v2] test: fix to skip power kvm vm autotest

2018-11-18 Thread Thomas Monjalon
15/11/2018 07:34, Pallantla Poornima: > power_kvm_vm_autotest should run on kvm vm and > virtio-ports should exist, if not test should skip. > Hence changed return as TEST_SKIPPED. > > Fixes: 0ea2dd4409 ("test: skip when required lib not available") > Cc: sta...@dpdk.org > > Signed-off-by: Pallan

Re: [dpdk-dev] [dpdk-stable] [PATCH v2] example/ipv4_multicast: fix app hanging when using clone

2018-11-18 Thread Thomas Monjalon
> > The ipv4_multicast sample application was dropping packets when using > > mbuf clone. When creating an L2 header and copying metadata from the > > source packet, the ol_flags were also copied along with all the other > > metadata. Because the cloned packet had IND_ATTACHED_MBUF flag set in

[dpdk-dev] [PATCH] vfio: fix build with Linux < 4.0

2018-11-18 Thread Thomas Monjalon
drivers/bus/pci/linux/pci_vfio.c:45:23: error: ‘failure_handle_lock’ defined but not used Fixes: 8ffe73865124 ("vfio: add lock for hot-unplug failure handler") Cc: jia@intel.com Signed-off-by: Thomas Monjalon --- Applied immediately. --- drivers/bus/pci/linux/pci_vfio.c | 16 -

Re: [dpdk-dev] [dpdk-stable] [PATCH v3] app/pdump: fix port id storage size

2018-11-18 Thread Thomas Monjalon
14/11/2018 11:28, Pattan, Reshma: > From: Kovacevic, Marko > > > > port_id size should be uint16_t, > > fix where it is defined as uint8_t > > > > Fixes: f8244c6399d9 ("ethdev: increase port id range") > > Cc: zhiyong.y...@intel.com > > Cc: sta...@dpdk.org > > > > Signed-off-by: Marko Kovacevic

Re: [dpdk-dev] [dpdk-stable] [PATCH] testpmd: fix memory leak for dscp table

2018-11-18 Thread Thomas Monjalon
14/11/2018 12:58, Jasvinder Singh: > Fix memory leak for dscp table reported by coverity > > Coverity ID: 326961 > Fixes: 281eeb8afc55 ("app/testpmd: add commands for metering and policing") > CC: sta...@dpdk.org > > Signed-off-by: Jasvinder Singh Applied, thanks

Re: [dpdk-dev] [PATCH] security: remove experimental tag

2018-11-18 Thread Thomas Monjalon
13/11/2018 12:28, Akhil Goyal: > rte_security has been experimental since DPDK 17.11 release. > Now the library has matured and expermental tag is removed in > this patch. > > Signed-off-by: Akhil Goyal Acked-by: Anoob Joseph Acked-by: Hemant Agrawal Acked-by: Boris Pismenny Applied

Re: [dpdk-dev] [PATCH] common/cpt: fix bad shift operation

2018-11-18 Thread Thomas Monjalon
15/11/2018 06:10, Anoob Joseph: > From: Ankur Dwivedi > > Coverity Issue: 323477 > > Using the rte_bsf32 function to find last set bit. This avoids > the for loop and hence the bad bit shift operation. > > Fixes: 351fbee21986 ("common/cpt: support hash") > > Signed-off-by: Ankur Dwivedi > Sig

Re: [dpdk-dev] [PATCH] memalloc: check for contiguousness in external segments

2018-11-18 Thread Thomas Monjalon
14/11/2018 15:51, Anatoly Burakov: > For IOVA as VA mode, we assume that memory is contiguous. However, > for external segments that assumption may not necessarily hold. > Fix the code to not assume that external memory segments are > contiguous even in IOVA as VA mode. > > Fixes: 5282bb1c3695 ("m

Re: [dpdk-dev] [PATCH V2 0/3] fix vfio hot-unplug issue

2018-11-18 Thread Thomas Monjalon
15/11/2018 10:18, Jeff Guo: > This patch set aim to fix some dead lock issue when device be hotplug-in > after device be hot-unplugged for vfio. > > v2->v1: > refine some document and show the limitation. > > Jeff Guo (3): > eal: fix lock issue for hot-unplug > vfio: fix to add handler lock

Re: [dpdk-dev] [RFC 5/5] pipeline: remove dead code

2018-11-18 Thread Thomas Monjalon
+Cc Cristian 06/11/2018 22:49, Stephen Hemminger: > Coverity detected dead code since pointer into a global > array can never be NULL. > > Coverity issue: 323523 > Fixes: 96303217a606 ("pipeline: add symmetric crypto table action") > Signed-off-by: Stephen Hemminger

Re: [dpdk-dev] [RFC 2/5] bus/pci: fix TOCTOU issue

2018-11-18 Thread Thomas Monjalon
+Cc Ferruh 06/11/2018 22:48, Stephen Hemminger: > Using access followed by open causes a static analysis warning > about Time of check versus Time of use. Also, access() and > open() have different UID permission checks. > > This is not a serious problem; but easy to fix by using errno instead. >

Re: [dpdk-dev] [RFC 1/5] bus/pci: fix allocation of pci device path

2018-11-18 Thread Thomas Monjalon
06/11/2018 22:48, Stephen Hemminger: > The pci_resource_by_index called strlen() on uninitialized > memory which would lead to the wrong size of memory allocated > for the path portion of the resource map. This would either cause > excessively large allocation, or worse memory corruption. > > Cove

Re: [dpdk-dev] [PATCH v2] lib/efd: fix to free tail queue entry after use

2018-11-18 Thread Thomas Monjalon
This patch is not trivial, it may require an ack from a maintainer, Pablo is unavailable this month. Byron, any comment please? 14/11/2018 12:17, Hari Kumar Vemula: > In rte_efd_create() allocated memory for tail queue entry but > not freed. > Added freeing the tail queue entry. > > Fixes: 56b6ef

Re: [dpdk-dev] [dpdk-stable] [PATCH v2] lib/efd: fix write unlock during ring creation

2018-11-18 Thread Thomas Monjalon
16/11/2018 14:39, Ferruh Yigit: > On 11/14/2018 11:24 AM, Chaitanya Babu Talluri wrote: > > In rte_efd_create() write lock has already been unlocked > > before ring creation itself. > > So second unlock after the ring creation has been removed. > > > > Fixes: 56b6ef874f80 ("efd: new Elastic Flow D

Re: [dpdk-dev] [dpdk-stable] [PATCH] lib: fix write unlock during ring creation

2018-11-18 Thread Thomas Monjalon
13/11/2018 17:58, Pattan, Reshma: > Heading should have lib/efd: No, heading should have "efd:" When in doubts, please look at the git history.

Re: [dpdk-dev] mlx5 under FreeBSD

2018-11-18 Thread Thomas Monjalon
15/11/2018 17:48, Mit Matelske: > Is anyone working to include support for the mlx5 PMD under FreeBSD? I think Stephen (Cc) looked at it. > I've started down this road by building Linux compatibility layers for the > required Netlink and Ethtool calls in the driver, but would gladly accept > he

Re: [dpdk-dev] [dpdk-stable] [PATCH] build: set -mfpu=neon flag for armv7a builds

2018-11-18 Thread Thomas Monjalon
15/11/2018 20:29, Christian Ehrhardt: > On Thu, Nov 15, 2018 at 5:54 PM Luca Boccassi wrote: > > > > Building on armv7a with meson currenctly fails: > > > > /usr/lib/gcc/arm-linux-gnueabihf/8/include/arm_neon.h:10369:1: error: > > inlining failed in call to always_inline ‘vld1q_s32’: target >

Re: [dpdk-dev] [PATCH v4 1/2] build: avoid non supported -march on ppc (meson)

2018-11-18 Thread Thomas Monjalon
14/11/2018 20:40, Christian Ehrhardt: > So far only if machine was "native" it did use the re-direction to > not set -march on ppc64 (where -march is not supported). > We have to use mcpu/mtune in any case on ppc for whatever someone using > the build system defines as machine. > > Fixes: 54d609a1

Re: [dpdk-dev] [dpdk-stable] [PATCH v3] mem: Fix anonymous mapping on Power9.

2018-11-18 Thread Thomas Monjalon
16/11/2018 18:35, David Wilder: > Removed the use of MAP_HUGETLB for anonymous mapping on ppc64. The > MAP_HUGETLB had previously been added to workaround issues on IBM Power8 > systems when mapping /dev/zero (see: commit > 284ae3e9ff9a92575c28c858efd2c85c8de6d440). In the current code the > MAP_

Re: [dpdk-dev] [PATCH v3] build: establish an invariant machine type

2018-11-18 Thread Thomas Monjalon
14/11/2018 20:39, Christian Ehrhardt: > On Wed, Nov 14, 2018 at 3:33 PM Christian Ehrhardt > wrote: > > > > Add the machine definition 'default' which is special compared > > to 'native' (most optimized for current system) or any explicit > > type (external entity has to decide on the type). > > >

Re: [dpdk-dev] [PATCH v2] malloc: fix adjacency check to also include segment list

2018-11-18 Thread Thomas Monjalon
14/11/2018 16:00, Anatoly Burakov: > It may so happen that two memory locations may be adjacent in > virtual memory, but belong to different segment lists. With > current code, such segments will be concatenated. Fix the > adjacency checking code to also check if the adjacent malloc > elements belo

Re: [dpdk-dev] [PATCH] memalloc: check for contiguousness in external segments

2018-11-18 Thread Thomas Monjalon
14/11/2018 15:51, Anatoly Burakov: > For IOVA as VA mode, we assume that memory is contiguous. However, > for external segments that assumption may not necessarily hold. > Fix the code to not assume that external memory segments are > contiguous even in IOVA as VA mode. > > Fixes: 5282bb1c3695 ("m

Re: [dpdk-dev] [PATCH v2] eal: fix duplicate function declaration

2018-11-18 Thread Thomas Monjalon
14/11/2018 12:24, Burakov, Anatoly: > On 14-Nov-18 11:20 AM, Kevin Laatz wrote: > > The rte_eal_get_runtime_dir() function is currently being declared in two > > header files. > > > > This API was made public in commit 6911c9fd8fbe ("eal: export function to > > get runtime directory"), adding it t