Re: [dpdk-dev] [PATCH v2 2/3] eal: add new rte color definition

2018-12-14 Thread Dumitrescu, Cristian
> -Original Message- > From: Ananyev, Konstantin > Sent: Friday, December 14, 2018 11:36 PM > To: Pattan, Reshma ; dev@dpdk.org; > Dumitrescu, Cristian ; > jerin.ja...@caviumnetworks.com; Singh, Jasvinder > > Cc: Pattan, Reshma > Subject: RE: [dpdk-dev] [PATCH v2 2/3] eal: add new rte

Re: [dpdk-dev] [PATCH v2 2/3] eal: add new rte color definition

2018-12-14 Thread Ananyev, Konstantin
Hi Reshma, > diff --git a/lib/librte_eal/common/include/rte_color.h > b/lib/librte_eal/common/include/rte_color.h > new file mode 100644 > index 0..f4387071b > --- /dev/null > +++ b/lib/librte_eal/common/include/rte_color.h > @@ -0,0 +1,18 @@ > +/* SPDX-License-Identifier: BSD-3-Clause >

[dpdk-dev] [PATCH v4 0/1] New software event timer adapter

2018-12-14 Thread Erik Gabriel Carrillo
This patch introduces a new version of the event timer adapter software PMD [1]. In the original design, timer event producer lcores in the primary and secondary processes enqueued event timers into a ring, and a service core in the primary process dequeued them and processed them further. To impr

[dpdk-dev] [PATCH v4 1/1] eventdev: add new software event timer adapter

2018-12-14 Thread Erik Gabriel Carrillo
This patch introduces a new version of the event timer adapter software PMD. In the original design, timer event producer lcores in the primary and secondary processes enqueued event timers into a ring, and a service core in the primary process dequeued them and processed them further. To improve

Re: [dpdk-dev] [PATCH v3 1/1] eventdev: add new software event timer adapter

2018-12-14 Thread Carrillo, Erik G
> > lib/librte_eventdev/rte_event_timer_adapter.c | 688 +++-- > - > > 1 file changed, 276 insertions(+), 412 deletions(-) > > > > diff --git a/lib/librte_eventdev/rte_event_timer_adapter.c > > b/lib/librte_eventdev/rte_event_timer_adapter.c > > index 79070d4..029a45a 100644

Re: [dpdk-dev] [PATCH v3 2/2] mbuf: implement generic format for sched field

2018-12-14 Thread Dumitrescu, Cristian
> -Original Message- > From: Pattan, Reshma > Sent: Thursday, December 13, 2018 6:09 PM > To: dev@dpdk.org; jerin.ja...@caviumnetworks.com; Rao, Nikhil > ; Singh, Jasvinder ; > Dumitrescu, Cristian > Cc: Pattan, Reshma > Subject: [PATCH v3 2/2] mbuf: implement generic format for sched

Re: [dpdk-dev] [PATCH v3 1/2] eal: add new rte color definition

2018-12-14 Thread Dumitrescu, Cristian
> -Original Message- > From: Pattan, Reshma > Sent: Thursday, December 13, 2018 6:09 PM > To: dev@dpdk.org; jerin.ja...@caviumnetworks.com; Rao, Nikhil > ; Singh, Jasvinder ; > Dumitrescu, Cristian > Cc: Pattan, Reshma > Subject: [PATCH v3 1/2] eal: add new rte color definition > > Ad

Re: [dpdk-dev] [PATCH] eal: simplify RTE_PMD_DEBUG_TRACE

2018-12-14 Thread Stephen Hemminger
On Fri, 14 Dec 2018 13:20:07 -0800 Jeff Shaw wrote: > On Fri, Dec 14, 2018 at 12:50:55PM -0800, Stephen Hemminger wrote: > > Use rte_log directly, eliminating no longer used rte_pmd_dev_trace > > function. This removes variable length array which is problem on > > Windows and other compilers not

[dpdk-dev] net/i40e: VF with vlan ID set from host does not work

2018-12-14 Thread Min Tang
Hi All: When vlan ID was set on a VF from host by "ip link set vf vlan ", other VF with the same ID could not ping it. Packet capturing showed that it could receive packets but it failed to send packet. There was no such issue with linux driver. I understand that it needs vlan stripping/inserti

[dpdk-dev] [PATCH v4 10/10] doc: update ifc NIC document

2018-12-14 Thread Xiao Wang
Add the SW assisted VDPA live migration feature into NIC doc. Signed-off-by: Xiao Wang --- doc/guides/nics/ifc.rst| 8 doc/guides/rel_notes/release_19_02.rst | 6 ++ 2 files changed, 14 insertions(+) diff --git a/doc/guides/nics/ifc.rst b/doc/guides/nics/ifc.rst ind

[dpdk-dev] [PATCH v4 07/10] net/ifc: add devarg for LM mode

2018-12-14 Thread Xiao Wang
This patch series enables a new method for live migration, i.e. software assisted live migration. This patch provides a device argument for user to choose the methold. When "swlm=1", driver/device will do live migration with a relay thread dealing with dirty page logging. Without this parameter, d

[dpdk-dev] [PATCH v4 06/10] net/ifc: detect if VDPA mode is specified

2018-12-14 Thread Xiao Wang
If user wants the VF to be used in VDPA (vhost data path acceleration) mode, then the user can add a "vdpa=1" parameter for the device. So if driver doesn't not find this option, it should quit and let the bus continue the probe. Signed-off-by: Xiao Wang --- drivers/net/ifc/Makefile | 1 +

[dpdk-dev] [PATCH v4 09/10] net/ifc: support SW assisted VDPA live migration

2018-12-14 Thread Xiao Wang
In SW assisted live migration mode, driver will stop the device and setup a mediate virtio ring to relay the communication between the virtio driver and the VDPA device. This data path intervention will allow SW to help on guest dirty page logging for live migration. This SW fallback is event dri

[dpdk-dev] [PATCH v4 08/10] net/ifc: use lib API for used ring logging

2018-12-14 Thread Xiao Wang
Vhost lib has already provided a helper for used ring logging, driver could use it to reduce code. Signed-off-by: Xiao Wang --- drivers/net/ifc/ifcvf_vdpa.c | 27 --- 1 file changed, 8 insertions(+), 19 deletions(-) diff --git a/drivers/net/ifc/ifcvf_vdpa.c b/drivers/net

[dpdk-dev] [PATCH v4 05/10] net/ifc: store only registered device instance

2018-12-14 Thread Xiao Wang
If driver fails to register ifc VF device into vhost lib, then this device should not be stored. Fixes: a3f8150eac6d ("net/ifcvf: add ifcvf vDPA driver") cc: sta...@dpdk.org Signed-off-by: Xiao Wang --- drivers/net/ifc/ifcvf_vdpa.c | 8 1 file changed, 4 insertions(+), 4 deletions(-)

[dpdk-dev] [PATCH v4 03/10] vhost: provide helpers for virtio ring relay

2018-12-14 Thread Xiao Wang
This patch provides two helpers for vdpa device driver to perform a relay between the guest virtio ring and a mediate virtio ring. The available ring relay will synchronize the available entries, and helps to do desc validity checking. The used ring relay will synchronize the used entries from me

[dpdk-dev] [PATCH v4 01/10] vhost: remove unused internal API

2018-12-14 Thread Xiao Wang
vhost_detach_vdpa_device() is internally defined but not used, remove it in this patch. Signed-off-by: Xiao Wang --- lib/librte_vhost/vhost.c | 13 - lib/librte_vhost/vhost.h | 1 - 2 files changed, 14 deletions(-) diff --git a/lib/librte_vhost/vhost.c b/lib/librte_vhost/vhost.c in

[dpdk-dev] [PATCH v4 02/10] vhost: provide helper for host notifier ctrl

2018-12-14 Thread Xiao Wang
VDPA driver can decide if it needs to enable/disable the host notifier mapping, so exposing a API can allow flexibility. A later patch will base on this. Signed-off-by: Xiao Wang --- drivers/net/ifc/ifcvf_vdpa.c | 3 +++ lib/librte_vhost/rte_vdpa.h| 18 ++

[dpdk-dev] [PATCH v4 04/10] net/ifc: dump debug message for error

2018-12-14 Thread Xiao Wang
Driver probe may fail for different causes, debug message is helpful for debugging issue. Signed-off-by: Xiao Wang --- drivers/net/ifc/ifcvf_vdpa.c | 19 +-- 1 file changed, 13 insertions(+), 6 deletions(-) diff --git a/drivers/net/ifc/ifcvf_vdpa.c b/drivers/net/ifc/ifcvf_vdpa.c

[dpdk-dev] [PATCH v4 00/10] support SW assisted VDPA live migration

2018-12-14 Thread Xiao Wang
In the previous VDPA implementation we have enabled live migration support by HW accelerator doing all the stuff, including dirty page logging and device status report/restore. In this mode VDPA sample daemon and device driver just takes care of the control path and does not involve in data path, s

Re: [dpdk-dev] [PATCH] eal: simplify RTE_PMD_DEBUG_TRACE

2018-12-14 Thread Jeff Shaw
On Fri, Dec 14, 2018 at 12:50:55PM -0800, Stephen Hemminger wrote: > Use rte_log directly, eliminating no longer used rte_pmd_dev_trace > function. This removes variable length array which is problem on > Windows and other compilers not doing C99. > > Also, drop unused RTE_PROC_PRIMARY macros. >

Re: [dpdk-dev] [PATCH v3 1/1] eventdev: add new software event timer adapter

2018-12-14 Thread Mattias Rönnblom
On 2018-12-14 16:45, Erik Gabriel Carrillo wrote: This patch introduces a new version of the event timer adapter software PMD. In the original design, timer event producer lcores in the primary and secondary processes enqueued event timers into a ring, and a service core in the primary process de

[dpdk-dev] [PATCH] eal: simplify RTE_PMD_DEBUG_TRACE

2018-12-14 Thread Stephen Hemminger
Use rte_log directly, eliminating no longer used rte_pmd_dev_trace function. This removes variable length array which is problem on Windows and other compilers not doing C99. Also, drop unused RTE_PROC_PRIMARY macros. Reported-by: Jeff Shaw Signed-off-by: Stephen Hemminger --- lib/librte_eal/c

[dpdk-dev] [PATCH v2] eal: remove variable length array

2018-12-14 Thread Jeff Shaw
Compilers that do not support the C99 standard, or do not implement gcc extensions, may not support variable length arrays. The code prior to this commit produced the following warning when compiled with "-Wvla -std=c90". warning: ISO C90 forbids variable length array ‘array’ [-Wvla] This comm

Re: [dpdk-dev] [PATCH] eal: remove variable length array

2018-12-14 Thread Mattias Rönnblom
On 2018-12-14 20:07, Jeff Shaw wrote: The code prior to this commit produced the following warning when compiled with "-Wvla -std=c90". warning: ISO C90 forbids variable length array ‘array’ [-Wvla] This commit removes the variable length array from the PMD debug trace function by allocatin

Re: [dpdk-dev] Incorrectly applied ethdev: fix queue start to 17.11

2018-12-14 Thread Yongseok Koh
Will take care of this. Adding Luca for 16.11. Thanks! Yongseok Koh On Dec 9, 2018, at 11:30 PM, Zhang, Qi Z mailto:qi.z.zh...@intel.com>> wrote: Your understand is correct, I saw the issue happens on both 17.11 and 16.11 both From: Andrew Rybchenko [mailto:arybche...@solarflare.com] Sent: Mo

[dpdk-dev] [PATCH] net/failsafe: remove unnecessary debug messages

2018-12-14 Thread Stephen Hemminger
The failsafe driver spews messages every time it is polling making debugging other things more difficult. Just remove it. Example: net_failsafe: Hot-plug mutex was locked by thread 140182066431744 by the hot-plug alarm net_failsafe: Hot-plug mutex was locked by thread 140182066431744 by the hot-

Re: [dpdk-dev] [PATCH v6 0/5] add initial version of compress-perf

2018-12-14 Thread Trahe, Fiona
> -Original Message- > From: Jozwiak, TomaszX > Sent: Wednesday, December 12, 2018 5:08 AM > To: dev@dpdk.org; Trahe, Fiona ; Jozwiak, TomaszX > ; shally.ve...@cavium.com; akhil.go...@nxp.com > Subject: [PATCH v6 0/5] add initial version of compress-perf > > This patchset adds initial v

Re: [dpdk-dev] [PATCH] eal: remove variable length array

2018-12-14 Thread Jeff Shaw
On Fri, Dec 14, 2018 at 10:59:28AM -0800, Jeff Shaw wrote: > On Fri, Dec 14, 2018 at 10:36:03AM -0800, Stephen Hemminger wrote: > > On Fri, 14 Dec 2018 08:38:27 -0800 > > Jeff Shaw wrote: > > > > > Compilers that do not support the C11 standard, or do not implement > > > gcc extensions, may not s

Re: [dpdk-dev] [PATCH] eal: remove variable length array

2018-12-14 Thread Jeff Shaw
On Fri, Dec 14, 2018 at 07:36:38PM +0100, Mattias Rönnblom wrote: > On 2018-12-14 17:38, Jeff Shaw wrote: > > Compilers that do not support the C11 standard, or do not implement > > gcc extensions, may not support variable length arrays. > > > > VLAs are a C99 thing. You're right, my mistake. >

Re: [dpdk-dev] [PATCH v3 1/9] vhost: provide helper for host notifier ctrl

2018-12-14 Thread Wang, Xiao W
Hi, > -Original Message- > From: Maxime Coquelin [mailto:maxime.coque...@redhat.com] > Sent: Friday, December 14, 2018 5:33 AM > To: Wang, Xiao W ; > alejandro.luc...@netronome.com; Bie, Tiwei > Cc: dev@dpdk.org; Wang, Zhihong ; Ye, Xiaolong > > Subject: Re: [PATCH v3 1/9] vhost: provide

[dpdk-dev] [PATCH 2/2] net/cxgbe: skip parsing match items with no spec

2018-12-14 Thread Rahul Lakkireddy
Skip parsing pattern match items that have no spec. This fixes NULL dereference when accessing their non-existent spec. Fixes: ee61f5113b17 ("net/cxgbe: parse and validate flows") Cc: sta...@dpdk.org Signed-off-by: Rahul Lakkireddy --- drivers/net/cxgbe/cxgbe_flow.c | 4 1 file changed, 4

[dpdk-dev] [PATCH 1/2] net/cxgbe: fix overlapping regions in TID table

2018-12-14 Thread Rahul Lakkireddy
Location of filter TID table should be after active TID table memory, and not from the beginning of TID table memory. This fixes memory corruption due to overlapping regions. Fixes: 3a381a4116ed ("net/cxgbe: query firmware for HASH filter resources") Cc: sta...@dpdk.org Signed-off-by: Rahul Lakki

[dpdk-dev] [PATCH] net/cxgbe: implement reset hit counters for offloaded flows

2018-12-14 Thread Rahul Lakkireddy
Implement logic to reset hit counters for offloaded flows. Signed-off-by: Rahul Lakkireddy --- drivers/net/cxgbe/base/t4_tcb.h | 6 drivers/net/cxgbe/cxgbe_filter.c | 49 drivers/net/cxgbe/cxgbe_filter.h | 2 ++ drivers/net/cxgbe/cxgbe_flow.c | 3 ++ 4

Re: [dpdk-dev] [PATCH] eal: remove variable length array

2018-12-14 Thread Jeff Shaw
On Fri, Dec 14, 2018 at 10:36:03AM -0800, Stephen Hemminger wrote: > On Fri, 14 Dec 2018 08:38:27 -0800 > Jeff Shaw wrote: > > > Compilers that do not support the C11 standard, or do not implement > > gcc extensions, may not support variable length arrays. > > > > The code prior to this commit p

[dpdk-dev] [PATCH 0/2] net/cxgbe: rte_flow related bug fixes

2018-12-14 Thread Rahul Lakkireddy
Patch 1 fixes memory corruption due to overlapping regions in TID table. Patch 2 fixes NULL pointer dereference when attempting to parse pattern match items without any spec. Thanks, Rahul Rahul Lakkireddy (2): net/cxgbe: fix overlapping regions in TID table net/cxgbe: skip parsing match item

Re: [dpdk-dev] [PATCH] compress/qat: fix error counter in dequeue errors

2018-12-14 Thread Trahe, Fiona
> -Original Message- > From: Jozwiak, TomaszX > Sent: Friday, December 14, 2018 5:12 AM > To: dev@dpdk.org; Trahe, Fiona ; Jozwiak, TomaszX > ; akhil.go...@nxp.com; sta...@dpdk.org > Subject: [PATCH] compress/qat: fix error counter in dequeue errors > > This patch increments error count

Re: [dpdk-dev] [PATCH] malloc: make alignment requirements more stringent

2018-12-14 Thread Yongseok Koh
> On Dec 14, 2018, at 3:54 AM, Anatoly Burakov > wrote: > > The external heaps API already implicitly expects start address > of the external memory area to be page-aligned, but it is not > enforced or documented. Fix this by implementing additional > parameter checks at memory add call, and d

Re: [dpdk-dev] [PATCH] compress/qat: fix status return on error building request

2018-12-14 Thread Trahe, Fiona
> -Original Message- > From: Jozwiak, TomaszX > Sent: Friday, December 14, 2018 4:20 AM > To: dev@dpdk.org; Trahe, Fiona ; Jozwiak, TomaszX > ; akhil.go...@nxp.com; sta...@dpdk.org > Subject: [PATCH] compress/qat: fix status return on error building request > > This patch fixes error st

Re: [dpdk-dev] [PATCH] common/qat: revert fix for invalid response from firmware

2018-12-14 Thread Trahe, Fiona
> -Original Message- > From: Jozwiak, TomaszX > Sent: Friday, December 14, 2018 4:20 AM > To: dev@dpdk.org; Trahe, Fiona ; Jozwiak, TomaszX > ; akhil.go...@nxp.com; sta...@dpdk.org > Subject: [PATCH] common/qat: revert fix for invalid response from firmware > > This reverts commit d09973

Re: [dpdk-dev] [PATCH] eal: remove variable length array

2018-12-14 Thread Mattias Rönnblom
On 2018-12-14 17:38, Jeff Shaw wrote: Compilers that do not support the C11 standard, or do not implement gcc extensions, may not support variable length arrays. VLAs are a C99 thing. The code prior to this commit produced the following warning when compiled with "-Wvla -std=c90". warnin

Re: [dpdk-dev] [PATCH] eal: remove variable length array

2018-12-14 Thread Stephen Hemminger
On Fri, 14 Dec 2018 08:38:27 -0800 Jeff Shaw wrote: > Compilers that do not support the C11 standard, or do not implement > gcc extensions, may not support variable length arrays. > > The code prior to this commit produced the following warning when > compiled with "-Wvla -std=c90". > > warni

Re: [dpdk-dev] [PATCH v2] app/test-pmd: add IFPGA AFU register read/write access for testpmd

2018-12-14 Thread Pattan, Reshma
Hi, > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Rosen Xu > Sent: Friday, December 14, 2018 1:14 AM > To: dev@dpdk.org > Cc: Lu, Wenzhuo ; Wu, Jingjing > ; Iremonger, Bernard ; > Xu, Rosen ; Yigit, Ferruh > Subject: [dpdk-dev] [PATCH v2] app/test-pmd: add IF

Re: [dpdk-dev] [PATCH] net/virtio: add platform memory ordering feature support

2018-12-14 Thread Ilya Maximets
On 14.12.2018 20:00, Michael S. Tsirkin wrote: > On Fri, Dec 14, 2018 at 06:38:12PM +0300, Ilya Maximets wrote: >> VIRTIO_F_ORDER_PLATFORM is required to use proper memory barriers >> in case of HW vhost implementations like vDPA. >> >> DMA barriers (rte_cio_*) are sufficent for that purpose. >> >>

[dpdk-dev] [PATCH v2] mem: add --match-allocations

2018-12-14 Thread Jim Harris
SPDK uses the rte_mem_event_callback_register API to create RDMA memory regions (MRs) for newly allocated regions of memory. This is used in both the SPDK NVMe-oF target and the NVMe-oF host driver. DPDK creates internal malloc_elem structures for these allocated regions. As users malloc and free

Re: [dpdk-dev] [PATCH v2] net/igb: fix LSC interrupt when using MSI-X

2018-12-14 Thread Kevin Traynor
On 11/20/2018 04:16 AM, Zhang, Qi Z wrote: > > >> -Original Message- >> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Zhao1, Wei >> Sent: Monday, November 19, 2018 7:29 PM >> To: Player, Timmons >> Cc: dev@dpdk.org; Lu, Wenzhuo >> Subject: Re: [dpdk-dev] [PATCH v2] net/igb: fix L

Re: [dpdk-dev] [PATCH] net/virtio: add platform memory ordering feature support

2018-12-14 Thread Michael S. Tsirkin
On Fri, Dec 14, 2018 at 06:38:12PM +0300, Ilya Maximets wrote: > VIRTIO_F_ORDER_PLATFORM is required to use proper memory barriers > in case of HW vhost implementations like vDPA. > > DMA barriers (rte_cio_*) are sufficent for that purpose. > > Previously known as VIRTIO_F_IO_BARRIER. > > Signed

Re: [dpdk-dev] [PATCH v2] net/i40e: firmware status check

2018-12-14 Thread Kevin Traynor
On 12/03/2018 08:07 AM, Zhang, Qi Z wrote: > > >> -Original Message- >> From: Li, Xiaoyun >> Sent: Monday, December 3, 2018 3:08 PM >> To: Zhang, Qi Z >> Cc: dev@dpdk.org; Li, Xiaoyun >> Subject: [PATCH v2] net/i40e: firmware status check >> >> Check the firmware status at init time. If

[dpdk-dev] [PATCH] eal: remove variable length array

2018-12-14 Thread Jeff Shaw
Compilers that do not support the C11 standard, or do not implement gcc extensions, may not support variable length arrays. The code prior to this commit produced the following warning when compiled with "-Wvla -std=c90". warning: ISO C90 forbids variable length array ‘array’ [-Wvla] This comm

Re: [dpdk-dev] [PATCH v4 30/32] net/ice: support basic RX/TX

2018-12-14 Thread Thomas Monjalon
14/12/2018 14:00, Ferruh Yigit: > On 12/14/2018 8:35 AM, Wenzhuo Lu wrote: > > Signed-off-by: Wenzhuo Lu > > Signed-off-by: Qiming Yang > > Signed-off-by: Xiaoyun Li > > Signed-off-by: Jingjing Wu > > <...> > > > + > > + /* Check to make sure the last descriptor to clean is done */ > > +

[dpdk-dev] [PATCH] eal: remove unnecessary dirent.h include

2018-12-14 Thread Jeff Shaw
Prior to this patch, the two affected .c files include unnecessarily. This commit removes the include lines. Signed-off-by: Jeff Shaw --- lib/librte_eal/common/eal_common_lcore.c | 1 - lib/librte_eal/common/rte_service.c | 1 - 2 files changed, 2 deletions(-) diff --git a/lib/librte_eal/

[dpdk-dev] [PATCH v4 7/9] examples/ipsec-secgw: make data-path to use ipsec library

2018-12-14 Thread Konstantin Ananyev
Changes to make ipsec-secgw data-path code to utilize librte_ipsec library. Note that right now by default current (non-librte_ipsec) code-path will be used. User has to run application with new command-line option ('-l') to enable new codepath. Signed-off-by: Mohammad Abdul Awal Signed-off-by: B

[dpdk-dev] [PATCH v4 9/9] doc: update ipsec-secgw guide and relelase notes

2018-12-14 Thread Konstantin Ananyev
Update ipsec-secgw guide and relelase notes to reflect latest changes. Signed-off-by: Bernard Iremonger Signed-off-by: Konstantin Ananyev --- doc/guides/rel_notes/release_19_02.rst | 14 doc/guides/sample_app_ug/ipsec_secgw.rst | 101 ++- 2 files changed, 113 inserti

[dpdk-dev] [PATCH v4 6/9] examples/ipsec-secgw: make app to use ipsec library

2018-12-14 Thread Konstantin Ananyev
Changes to make ipsec-secgw to utilize librte_ipsec library. That patch provides: - changes in the related data structures. - changes in the initialization code. - new command-line parameters to enable librte_ipsec codepath and related features. Note that right now by default current (non-li

[dpdk-dev] [PATCH v4 8/9] examples/ipsec-secgw: add scripts for functional test

2018-12-14 Thread Konstantin Ananyev
The purpose of these scripts is to automate ipsec-secgw functional testing. The scripts require two machines (SUT and DUT) connected through at least 2 NICs and running linux (so far tested only on Ubuntu 18.04). Introduced test-cases for the following scenarios: - Transport/Tunnel modes - AES-CBC

[dpdk-dev] [PATCH v4 5/9] examples/ipsec-secgw: make local variables static

2018-12-14 Thread Konstantin Ananyev
in sp4.c and sp6.c there are few globals that used only locally. Define them as static ones. Signed-off-by: Konstantin Ananyev Acked-by: Radu Nicolau --- examples/ipsec-secgw/sp4.c | 10 +- examples/ipsec-secgw/sp6.c | 10 +- 2 files changed, 10 insertions(+), 10 deletions(-) d

[dpdk-dev] [PATCH v4 4/9] examples/ipsec-secgw: fix outbound codepath for single SA

2018-12-14 Thread Konstantin Ananyev
Looking at process_pkts_outbound_nosp() there seems few issues: - accessing mbuf after it was freed - invoking ipsec_outbound() for ipv4 packets only - copying number of packets, but not the mbuf pointers itself that patch provides fixes for that issues. Fixes: 906257e965b7 ("examples/ipsec-secgw

[dpdk-dev] [PATCH v4 3/9] examples/ipsec-secgw: fix crypto-op might never get dequeued

2018-12-14 Thread Konstantin Ananyev
In some cases crypto-ops could never be dequeued from the crypto-device. The easiest way to reproduce: start ipsec-secgw with crypto-dev and send to it less then 32 packets. none packets will be forwarded. Reason for that is that the application does dequeue() from crypto-queues only when new packe

[dpdk-dev] [PATCH v4 2/9] examples/ipsec-secgw: allow to specify neighbor mac address

2018-12-14 Thread Konstantin Ananyev
In some cases it is useful to allow user to specify destination ether address for outgoing packets. This patch adds such ability by introducing new 'neigh' config file option. Signed-off-by: Konstantin Ananyev Acked-by: Radu Nicolau --- examples/ipsec-secgw/ipsec-secgw.c | 21 +++-- example

[dpdk-dev] [PATCH v4 1/9] examples/ipsec-secgw: avoid to request unused TX offloads

2018-12-14 Thread Konstantin Ananyev
ipsec-secgw always enables TX offloads (DEV_TX_OFFLOAD_MULTI_SEGS, DEV_TX_OFFLOAD_SECURITY), even when they are not requested by the config. That causes many PMD to choose full-featured TX function, which in many cases is much slower then one without offloads. That patch adds checks to enabled extr

[dpdk-dev] [PATCH v4 0/9] examples/ipsec-secgw: make app to use ipsec library

2018-12-14 Thread Konstantin Ananyev
This patch series depends on the patch series: Add 'try' semantics for RD and WR locking http://patches.dpdk.org/patch/48044/ http://patches.dpdk.org/patch/48045/ ipsec: new library for IPsec data-path processing http://patches.dpdk.org/patch/48900/ http://patches.dpdk.org/patch/48901/ http://pat

[dpdk-dev] [PATCH v4 00/10] ipsec: new library for IPsec data-path processing

2018-12-14 Thread Konstantin Ananyev
This patch series depends on the patch: http://patches.dpdk.org/patch/48044/ to be applied first. v3 -> v4 - Changes to adress Declan comments - Update docs v2 -> v3 - Several fixes for IPv6 support - Extra checks for input parameters in public APi functions v1 -> v2 - Changes to get into

Re: [dpdk-dev] [PATCH 1/3] net/netvsc: support receive without vlan strip

2018-12-14 Thread Stephen Hemminger
On Fri, 14 Dec 2018 16:09:33 + Ferruh Yigit wrote: > On 12/14/2018 1:26 AM, Stephen Hemminger wrote: > > In some cases, VLAN stripping is not desireable. If necessary > > re-insert stripped vlan tag. > > > > Signed-off-by: Stephen Hemminger > > <...> > > > @@ -501,6 +501,14 @@ static vo

[dpdk-dev] [PATCH v4 10/10] doc: add IPsec library guide

2018-12-14 Thread Konstantin Ananyev
Add IPsec library guide and update release notes. Signed-off-by: Bernard Iremonger Signed-off-by: Konstantin Ananyev --- doc/guides/prog_guide/index.rst| 1 + doc/guides/prog_guide/ipsec_lib.rst| 74 ++ doc/guides/rel_notes/release_19_02.rst | 10 3 fil

[dpdk-dev] [PATCH] bbdev: add missing APIs to map file

2018-12-14 Thread Amr Mokhtar
some application facing functions are missing from the map file. these are added by this patch. Signed-off-by: Amr Mokhtar --- lib/librte_bbdev/rte_bbdev_version.map | 4 1 file changed, 4 insertions(+) diff --git a/lib/librte_bbdev/rte_bbdev_version.map b/lib/librte_bbdev/rte_bbdev_versi

[dpdk-dev] [PATCH v4 07/10] ipsec: rework SA replay window/SQN for MT environment

2018-12-14 Thread Konstantin Ananyev
With these changes functions: - rte_ipsec_pkt_crypto_prepare - rte_ipsec_pkt_process can be safely used in MT environment, as long as the user can guarantee that they obey multiple readers/single writer model for SQN+replay_window operations. To be more specific: for outbound SA there are

[dpdk-dev] [PATCH v4 09/10] test/ipsec: introduce functional test

2018-12-14 Thread Konstantin Ananyev
Create functional test for librte_ipsec. Note that the test requires null crypto pmd to pass successfully. Signed-off-by: Mohammad Abdul Awal Signed-off-by: Bernard Iremonger Acked-by: Declan Doherty Signed-off-by: Konstantin Ananyev --- test/test/Makefile |3 + test/test/meson.build

[dpdk-dev] [PATCH v4 08/10] ipsec: helper functions to group completed crypto-ops

2018-12-14 Thread Konstantin Ananyev
Introduce helper functions to process completed crypto-ops and group related packets by sessions they belong to. Signed-off-by: Konstantin Ananyev Acked-by: Declan Doherty --- lib/librte_ipsec/Makefile | 1 + lib/librte_ipsec/meson.build | 2 +- lib/librte_ipsec/rte_i

[dpdk-dev] [PATCH v4 06/10] ipsec: implement SA data-path API

2018-12-14 Thread Konstantin Ananyev
Provide implementation for rte_ipsec_pkt_crypto_prepare() and rte_ipsec_pkt_process(). Current implementation: - supports ESP protocol tunnel mode. - supports ESP protocol transport mode. - supports ESN and replay window. - supports algorithms: AES-CBC, AES-GCM, HMAC-SHA1, NULL. - covers all c

[dpdk-dev] [PATCH v4 04/10] lib: introduce ipsec library

2018-12-14 Thread Konstantin Ananyev
Introduce librte_ipsec library. The library is supposed to utilize existing DPDK crypto-dev and security API to provide application with transparent IPsec processing API. That initial commit provides some base API to manage IPsec Security Association (SA) object. Signed-off-by: Mohammad Abdul Awal

[dpdk-dev] [PATCH v4 02/10] security: add opaque userdata pointer into security session

2018-12-14 Thread Konstantin Ananyev
Add 'uint64_t opaque_data' inside struct rte_security_session. That allows upper layer to easily associate some user defined data with the session. Signed-off-by: Konstantin Ananyev Acked-by: Mohammad Abdul Awal Acked-by: Declan Doherty --- lib/librte_security/rte_security.h | 2 ++ 1 file cha

[dpdk-dev] [PATCH v4 05/10] ipsec: add SA data-path API

2018-12-14 Thread Konstantin Ananyev
Introduce Security Association (SA-level) data-path API Operates at SA level, provides functions to: - initialize/teardown SA object - process inbound/outbound ESP/AH packets associated with the given SA (decrypt/encrypt, authenticate, check integrity, add/remove ESP/AH related

[dpdk-dev] [PATCH v4 03/10] net: add ESP trailer structure definition

2018-12-14 Thread Konstantin Ananyev
Signed-off-by: Konstantin Ananyev Acked-by: Mohammad Abdul Awal Acked-by: Declan Doherty --- lib/librte_net/rte_esp.h | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/lib/librte_net/rte_esp.h b/lib/librte_net/rte_esp.h index f77ec2eb2..8e1b3d2dd 100644 --- a/lib/lib

[dpdk-dev] [PATCH v4 01/10] cryptodev: add opaque userdata pointer into crypto sym session

2018-12-14 Thread Konstantin Ananyev
Add 'uint64_t opaque_data' inside struct rte_cryptodev_sym_session. That allows upper layer to easily associate some user defined data with the session. Signed-off-by: Konstantin Ananyev Acked-by: Fiona Trahe Acked-by: Mohammad Abdul Awal Acked-by: Declan Doherty --- lib/librte_cryptodev/rte_

Re: [dpdk-dev] [RFC v3] /net: memory interface (memif)

2018-12-14 Thread Wiles, Keith
> On Dec 14, 2018, at 3:39 AM, Bruce Richardson > wrote: > > On Thu, Dec 13, 2018 at 10:07:09AM -0800, Stephen Hemminger wrote: >> On Thu, 13 Dec 2018 14:30:51 +0100 >> Jakub Grajciar wrote: >> >>> + >>> +typedef uint16_t memif_region_index_t; >>> +typedef uint32_t memif_region_offset_t; >>

Re: [dpdk-dev] [PATCH 1/3] net/netvsc: support receive without vlan strip

2018-12-14 Thread Ferruh Yigit
On 12/14/2018 1:26 AM, Stephen Hemminger wrote: > In some cases, VLAN stripping is not desireable. If necessary > re-insert stripped vlan tag. > > Signed-off-by: Stephen Hemminger <...> > @@ -501,6 +501,14 @@ static void hn_rxpkt(struct hn_rx_queue *rxq, struct > hn_rx_bufinfo *rxb, > if

[dpdk-dev] [PATCH v13 10/10] net/virtio: enable packed virtqueues by default

2018-12-14 Thread Jens Freimann
Signed-off-by: Jens Freimann --- drivers/net/virtio/virtio_ethdev.h | 1 + drivers/net/virtio/virtio_user/virtio_user_dev.c | 3 ++- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/virtio/virtio_ethdev.h b/drivers/net/virtio/virtio_ethdev.h index 88b8c42a3

[dpdk-dev] [PATCH v13 09/10] net/virtio-user: fail if q used with packed vq

2018-12-14 Thread Jens Freimann
Until we have support for ctrl virtqueues let's disable it and fail device initalization if specified as a parameter. Signed-off-by: Jens Freimann --- drivers/net/virtio/virtio_user/virtio_user_dev.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/drivers/net/virti

[dpdk-dev] [PATCH v13 07/10] net/virtio: add virtio send command packed queue support

2018-12-14 Thread Jens Freimann
Use packed virtqueue format when reading and writing descriptors to/from the ring. Signed-off-by: Jens Freimann --- drivers/net/virtio/virtio_ethdev.c | 90 ++ 1 file changed, 90 insertions(+) diff --git a/drivers/net/virtio/virtio_ethdev.c b/drivers/net/virtio/virt

[dpdk-dev] [PATCH v13 04/10] net/virtio: dump packed virtqueue data

2018-12-14 Thread Jens Freimann
Add support to dump packed virtqueue data to the VIRTQUEUE_DUMP() macro. Signed-off-by: Jens Freimann Reviewed-by: Maxime Coquelin --- drivers/net/virtio/virtqueue.h | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers/net/virtio/virtqueue.h b/drivers/net/virtio/virtqueue.h inde

[dpdk-dev] [PATCH v13 08/10] net/virtio-user: add option to use packed queues

2018-12-14 Thread Jens Freimann
From: Yuanhan Liu Add option to enable packed queue support for virtio-user devices. Signed-off-by: Yuanhan Liu --- .../net/virtio/virtio_user/virtio_user_dev.c | 18 ++ .../net/virtio/virtio_user/virtio_user_dev.h | 2 +- drivers/net/virtio/virtio_user_ethdev.c| 1

[dpdk-dev] [PATCH v13 06/10] net/virtio: implement receive path for packed queues

2018-12-14 Thread Jens Freimann
Implement the receive part. Signed-off-by: Jens Freimann Signed-off-by: Tiwei Bie --- drivers/net/virtio/virtio_ethdev.c | 58 +++-- drivers/net/virtio/virtio_ethdev.h | 5 + drivers/net/virtio/virtio_rxtx.c | 375 - drivers/net/virtio/virtqueue.c | 43 +++-

[dpdk-dev] [PATCH v13 05/10] net/virtio: implement transmit path for packed queues

2018-12-14 Thread Jens Freimann
This implements the transmit path for devices with support for packed virtqueues. Signed-off-by: Jens Freiman Signed-off-by: Tiwei Bie --- drivers/net/virtio/virtio_ethdev.c | 57 --- drivers/net/virtio/virtio_ethdev.h | 2 + drivers/net/virtio/virtio_rxtx.c | 236 +

[dpdk-dev] [PATCH v13 03/10] net/virtio: vring init for packed queues

2018-12-14 Thread Jens Freimann
Add and initialize descriptor data structures. Signed-off-by: Jens Freimann Signed-off-by: Tiwei Bie --- drivers/net/virtio/virtio_ethdev.c | 32 ++-- drivers/net/virtio/virtio_ring.h | 34 -- drivers/net/virtio/virtqueue.h | 2 +- 3 fi

[dpdk-dev] [PATCH v13 02/10] net/virtio: add packed virtqueue helpers

2018-12-14 Thread Jens Freimann
Add helper functions to set/clear and check descriptor flags. Signed-off-by: Jens Freimann --- drivers/net/virtio/virtio_pci.h | 6 +++ drivers/net/virtio/virtqueue.h | 91 - 2 files changed, 95 insertions(+), 2 deletions(-) diff --git a/drivers/net/virtio/virt

[dpdk-dev] [PATCH v13 01/10] net/virtio: add packed virtqueue defines

2018-12-14 Thread Jens Freimann
Signed-off-by: Jens Freimann --- drivers/net/virtio/virtio_pci.h | 1 + drivers/net/virtio/virtio_ring.h | 30 ++ drivers/net/virtio/virtqueue.h | 6 ++ 3 files changed, 37 insertions(+) diff --git a/drivers/net/virtio/virtio_pci.h b/drivers/net/virtio/virtio

[dpdk-dev] [PATCH v13 00/10] implement packed virtqueues

2018-12-14 Thread Jens Freimann
This is a basic implementation of packed virtqueues as specified in the Virtio 1.1 draft. A compiled version of the current draft is available at https://github.com/oasis-tcs/virtio-docs.git (or as .pdf at https://github.com/oasis-tcs/virtio-docs/blob/master/virtio-v1.1-packed-wd10.pdf A packed

Re: [dpdk-dev] [RFC] net/virtio: use real barriers for vDPA

2018-12-14 Thread Ilya Maximets
On 14.12.2018 18:01, Michael S. Tsirkin wrote: > On Fri, Dec 14, 2018 at 05:03:43PM +0300, Ilya Maximets wrote: >> On 14.12.2018 15:58, Michael S. Tsirkin wrote: >>> On Fri, Dec 14, 2018 at 03:37:04PM +0300, Ilya Maximets wrote: SMP barriers are OK for software vhost implementation, but vDPA i

Re: [dpdk-dev] [PATCH v1 2/2] test/compress: add varied buffer input/outputs

2018-12-14 Thread Daly, Lee
> -Original Message- > From: Kovacevic, Marko > Sent: Friday, December 14, 2018 3:33 PM > To: dev@dpdk.org > Cc: akhil.go...@nxp.com; Daly, Lee ; Jozwiak, TomaszX > ; O'Hare, Cathal ; > Trahe, Fiona ; Kovacevic, Marko > > Subject: [PATCH v1 2/2] test/compress: add varied buffer input/ou

Re: [dpdk-dev] [PATCH v1 1/2] test/compress: add out of space test

2018-12-14 Thread Daly, Lee
> -Original Message- > From: Kovacevic, Marko > Sent: Friday, December 14, 2018 3:33 PM > To: dev@dpdk.org > Cc: akhil.go...@nxp.com; Daly, Lee ; Jozwiak, TomaszX > ; O'Hare, Cathal ; > Trahe, Fiona ; Kovacevic, Marko > > Subject: [PATCH v1 1/2] test/compress: add out of space test > >

Re: [dpdk-dev] [PATCH][pktgen] fix repopulation of tx_mbufs table

2018-12-14 Thread Wiles, Keith
> On Dec 14, 2018, at 9:48 AM, Rafał Kozik wrote: > > pt., 14 gru 2018 o 16:45 Wiles, Keith napisał(a): >> >> >> >>> On Dec 14, 2018, at 9:29 AM, Wiles, Keith wrote: >>> >>> >>> On Dec 14, 2018, at 5:26 AM, Rafał Kozik wrote: Hello Keith, as from my last post

Re: [dpdk-dev] [PATCH][pktgen] fix repopulation of tx_mbufs table

2018-12-14 Thread Rafał Kozik
pt., 14 gru 2018 o 16:45 Wiles, Keith napisał(a): > > > > > On Dec 14, 2018, at 9:29 AM, Wiles, Keith wrote: > > > > > > > >> On Dec 14, 2018, at 5:26 AM, Rafał Kozik wrote: > >> > >> Hello Keith, > >> > >> as from my last post passed about three weeks I would kindly ask > >> if you could provid

[dpdk-dev] [PATCH v3 1/1] eventdev: add new software event timer adapter

2018-12-14 Thread Erik Gabriel Carrillo
This patch introduces a new version of the event timer adapter software PMD. In the original design, timer event producer lcores in the primary and secondary processes enqueued event timers into a ring, and a service core in the primary process dequeued them and processed them further. To improve

[dpdk-dev] [PATCH v3 0/1] New software event timer adapter

2018-12-14 Thread Erik Gabriel Carrillo
This patch introduces a new version of the event timer adapter software PMD [1]. In the original design, timer event producer lcores in the primary and secondary processes enqueued event timers into a ring, and a service core in the primary process dequeued them and processed them further. To impr

Re: [dpdk-dev] [PATCH][pktgen] fix repopulation of tx_mbufs table

2018-12-14 Thread Wiles, Keith
> On Dec 14, 2018, at 9:29 AM, Wiles, Keith wrote: > > > >> On Dec 14, 2018, at 5:26 AM, Rafał Kozik wrote: >> >> Hello Keith, >> >> as from my last post passed about three weeks I would kindly ask >> if you could provide any comments about this patch? > > Missed this patch originally as

[dpdk-dev] [PATCH] net/virtio: add platform memory ordering feature support

2018-12-14 Thread Ilya Maximets
VIRTIO_F_ORDER_PLATFORM is required to use proper memory barriers in case of HW vhost implementations like vDPA. DMA barriers (rte_cio_*) are sufficent for that purpose. Previously known as VIRTIO_F_IO_BARRIER. Signed-off-by: Ilya Maximets --- Based on "[RFC] net/virtio: use real barriers for

[dpdk-dev] [PATCH v1 2/2] test/compress: add varied buffer input/outputs

2018-12-14 Thread Marko Kovacevic
Added unit test to check if a SGL buffer was added as an input and a Linear Buffer as output and vice versa so we can test if the application would process the different buffers properly. Signed-off-by: Marko Kovacevic --- test/test/test_compressdev.c | 185 +++---

[dpdk-dev] [PATCH v1 1/2] test/compress: add out of space test

2018-12-14 Thread Marko Kovacevic
From: "Kovacevic, Marko" This patch adds new out of space testcase to check that the destination mbuf is smaller than required for the output of compression to ensure the driver doesn't crash and returns the valid error case. Signed-off-by: Marko Kovacevic --- test/test/test_compressdev.c | 11

Re: [dpdk-dev] [PATCH][pktgen] fix repopulation of tx_mbufs table

2018-12-14 Thread Wiles, Keith
> On Dec 14, 2018, at 5:26 AM, Rafał Kozik wrote: > > Hello Keith, > > as from my last post passed about three weeks I would kindly ask > if you could provide any comments about this patch? Missed this patch originally as it did not have pktgen on the status line. Can you give more details a

Re: [dpdk-dev] [RFC] net/virtio: use real barriers for vDPA

2018-12-14 Thread Michael S. Tsirkin
On Fri, Dec 14, 2018 at 05:03:43PM +0300, Ilya Maximets wrote: > On 14.12.2018 15:58, Michael S. Tsirkin wrote: > > On Fri, Dec 14, 2018 at 03:37:04PM +0300, Ilya Maximets wrote: > >> SMP barriers are OK for software vhost implementation, but vDPA is a > >> DMA capable hardware and we have to use a

  1   2   3   >