Re: [dpdk-dev] DPDK on IBM Power9

Daniel, What exactly is not working for you? Mellanox is testing Power9 for 19.02 release. Thanks, Olga -Original Message- From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Thomas Monjalon Sent: Thursday, January 10, 2019 2:08 AM To: Daniel Waddington Cc: dev@dpdk.org Subject: Re:

Re: [dpdk-dev] [PATCH] ethdev: support double precision RED queue weight

> -Original Message- > From: Stephen Hemminger [mailto:step...@networkplumber.org] > Sent: Monday, December 10, 2018 9:31 PM Hi Stephen, > To: Rao, Nikhil > Cc: Dumitrescu, Cristian ; Singh, Jasvinder > ; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] ethdev: support double precision RED

[dpdk-dev] [PATCH] net/ice: fix firmware-version in the drvinfo result of ethtool

Fix the drvinfo dumped firmware-version when using dpdk ethtool, change it to the same result as linux ethtool shown info. Fixes: e31cb9a36298 ("net/ice: support FW version getting") Signed-off-by: Leyi Rong --- drivers/net/ice/ice_ethdev.c | 17 ++--- 1 file changed, 14 insertions(

Re: [dpdk-dev] [RFC] function to parse packet headers

Also for the bulk API, another option would be passing in a `uint64_t malformed_mask` and let the bulk function set the correspond bit (1 << pos) of that mask if the packet at position pos is malformed. void rte_hdr_parse_bulk(struct rte_mbuf **pkts, uint64_t *malformed_mask, uint_fast16_t nb_p

Re: [dpdk-dev] [PATCH v8 1/7] app/procinfo: prepare for new debug functions

snipped > > Hi Vipin, > > The code split in this v8 looks really better, except this patch which makes > no > sense alone. Hi Thomas, I need this base patch as first one. These include the helper MACRO and include which pans out for next 7 patches. > I feel you can move these changes in next p

[dpdk-dev] [Bug 177] binding i40e with uio_pci_generic fails for DPDK 19.02.0-rc1

https://bugs.dpdk.org/show_bug.cgi?id=177 Vipin Varghese (vipin.vargh...@intel.com) changed: What|Removed |Added Status|CONFIRMED |RESOLVED Resol

[dpdk-dev] [PATCH v2] lib/librte_lpm: remove recursively included header file

includes itself: rte_lpm.h -> rte_lpm_sse.h -> rte_lpm.h includes itself: rte_lpm.h -> rte_lpm_neon.h -> rte_lpm.h Signed-off-by: Congwen Zhang --- lib/librte_lpm/rte_lpm_neon.h | 1 - lib/librte_lpm/rte_lpm_sse.h | 1 - 2 files changed, 2 deletions(-) diff --git a/lib/librte_lpm/rte_lpm_neon.

Re: [dpdk-dev] [PATCH v2 1/2] mbuf: add function returning default buffer address

Hi, Yongseok, Maybe you should consider using the pool member of the mbuf, instead of passing it as a parameter for rte_mbuf_buf_addr_default(). The pool member of mbuf indicates the pool from which it was allocated. See http://git.dpdk.org/dpdk/tree/lib/librte_mbuf/rte_mbuf.h#n631 And actually t

Re: [dpdk-dev] [RFC] function to parse packet headers

Hi, Morten, > And regarding avoiding code duplicity, I'm pursuing Olivier about merging packet header validation into rte_net_get_ptype() instead of writing a separate function. > This seems also a good alternative. +1 Regards, Rami Rosen > > >

Re: [dpdk-dev] DPDK on IBM Power9

> On Jan 9, 2019, at 6:07 PM, Thomas Monjalon wrote: > > Hi, > > 09/01/2019 23:25, Daniel Waddington: >> Hi, >> I'm trying to run DPDK 18.11 on IBM Power9. Should it run? (I'n new to >> DPDK on Power). > > As mentioned in the release notes, Power9 is supported: > http://doc.dpdk.org

Re: [dpdk-dev] DPDK on IBM Power9

Hi, 09/01/2019 23:25, Daniel Waddington: > Hi, > I'm trying to run DPDK 18.11 on IBM Power9. Should it run? (I'n new to DPDK > on Power). As mentioned in the release notes, Power9 is supported: http://doc.dpdk.org/guides/rel_notes/release_18_11.html#known-issues We are missing a stron

Re: [dpdk-dev] [RFC] function to parse packet headers

Adding few more Cc's 09/01/2019 16:53, Morten Brørup: > From: Rami Rosen [mailto:roszenr...@gmail.com] > >Hi Morten, > >A good idea, thanks for volunteering! > >Several minor comments: > >I would consider calling it rte_mbuf_hdr_parse(), to make it more related to > >the rte_mbuf* methods, and

Re: [dpdk-dev] DPDK on IBM Power9

Also, this is what the kernel shows. [ 2812.456773] pci :01 : [PE# 00] Enabling 64-bit DMA bypass [ 2876.395586] pci :01 : [PE# 00] Disabling 64-bit DMA bypass [ 2876.395593] pci :01 : [PE# 00] Removing DMA window #0 [ 2876.395705] pci :01 : [PE# 00] Removing D

Re: [dpdk-dev] Seg fault with GRE in pktgen

Adding Keith Wiles, maintainer of pktgen. 09/01/2019 02:53, Daniel Pharos: > Hi, > > Using pktgen 3.6.1, I'm getting a seg fault when enabling GRE. In > app/pktgen.c, on line 556 l3_hdr is set to NULL, and then on line 567 it is > send to a function that calls memset on it, triggering the seg f

Re: [dpdk-dev] Wrong constant being used

Adding Keith Wiles, maintainer of dpdk-pktgen. 09/01/2019 02:56, Daniel Pharos: > Hi, > > In pktgen 3.6.1, app/pktgen.c, line 219, the constant "IPPROTO_UDP" is used. > Shouldn't that be "PG_IPPROTO_UDP" instead? > > > Kind regards, > DanielPharos

Re: [dpdk-dev] [PATCH v8 1/7] app/procinfo: prepare for new debug functions

Hi Vipin, The code split in this v8 looks really better, except this patch which makes no sense alone. I feel you can move these changes in next patches, where appropriate, isn't it? 07/01/2019 16:38, Vipin Varghese: > Update code base and meson build file to accomadate changes for the > new func

Re: [dpdk-dev] [PATCH v6 01/10] cryptodev: add opaque userdata pointer into crypto sym session

04/01/2019 10:29, Ananyev, Konstantin: > > > -Original Message- > > From: Stephen Hemminger [mailto:step...@networkplumber.org] > > Sent: Friday, January 4, 2019 12:26 AM > > To: Ananyev, Konstantin > > Cc: dev@dpdk.org; akhil.go...@nxp.com > > Subject: Re: [dpdk-dev] [PATCH v6 01/10] cry

Re: [dpdk-dev] DPDK on IBM Power9

> On Jan 9, 2019, at 5:22 PM, Daniel Waddington > wrote: > > This NIC (000:01:00.0) is supported (Intel XL710). I assume that I can use > VFIO instead of UIO. UIO is really bad from a security perspective. > > I think its the "cannot create new DMA window, error 22" which is the first > in

Re: [dpdk-dev] [PATCH] net/softnic: add support for service cores

10/01/2019 00:23, Thomas Monjalon: > 07/01/2019 17:50, Dumitrescu, Cristian: > > > > > -Original Message- > > > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Cristian Dumitrescu > > > Sent: Thursday, January 3, 2019 4:05 PM > > > To: dev@dpdk.org > > > Cc: Singh, Jasvinder > > > Su

Re: [dpdk-dev] [PATCH] net/softnic: add support for service cores

07/01/2019 17:50, Dumitrescu, Cristian: > > > -Original Message- > > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Cristian Dumitrescu > > Sent: Thursday, January 3, 2019 4:05 PM > > To: dev@dpdk.org > > Cc: Singh, Jasvinder > > Subject: [dpdk-dev] [PATCH] net/softnic: add support

Re: [dpdk-dev] DPDK on IBM Power9

This NIC (000:01:00.0) is supported (Intel XL710). I assume that I can use VFIO instead of UIO. UIO is really bad from a security perspective. I think its the "cannot create new DMA window, error 22" which is the first indicator of the problem. Daniel -"Wiles, Keith" wrote: - To: Dani

Re: [dpdk-dev] [PATCH v4 0/2] lib/librte_meter: add RFC4115 trTCM meter support

07/01/2019 16:58, Dumitrescu, Cristian: > From: Eelco Chaudron [mailto:echau...@redhat.com] > > > > This patch adds support for RFC4115 trTCM meters. > > > > > > Signed-off-by: Eelco Chaudron > > > > v4: > > - Fixed typo > > - Cleaned up code to be aligned with RFC diagram > > > > Series A

[dpdk-dev] [PATCH v4 10/12] cryptodev: add user data size to symmetric session

This patch adds a user_data_sz field to cryptodev symmetric session. The field is used to check if reading or writing the session's user data field is eligible. Signed-off-by: Fan Zhang Acked-by: Fiona Trahe --- doc/guides/prog_guide/img/cryptodev_sym_sess.svg | 172 --- lib

[dpdk-dev] [PATCH v4 12/12] cryptodev: add opaque data field to symmetric session

This patch adds a opaque data field to cryptodev symmetric session. Signed-off-by: Fan Zhang Acked-by: Fiona Trahe --- doc/guides/prog_guide/img/cryptodev_sym_sess.svg | 7 +++ lib/librte_cryptodev/rte_cryptodev.c | 1 + lib/librte_cryptodev/rte_cryptodev.h | 2 ++ 3

[dpdk-dev] [PATCH v4 11/12] cryptodev: add reference count to session private data

This patch adds a refcnt field to every session private data in the cryptodev symmetric session. The counter is used to prevent freeing symmetric session blindly before it is not cleared by every type of crypto device in use. Signed-off-by: Fan Zhang Acked-by: Fiona Trahe --- doc/guides/prog_gu

[dpdk-dev] [PATCH v4 09/12] cryptodev: update symmetric session structure

This patch updates the rte_cryptodev_sym_session structure for cryptodev library. The updates include a changed session private data array and an added nb_drivers field. They are used to calculate the correct session header size and ensure safe access of the session private data. Signed-off-by: Fa

[dpdk-dev] [PATCH v4 08/12] cryptodev: add sym session header size API

This patch adds a new API in Cryptodev Framework. The API is used to get the header size for the created symmetric Cryptodev session. Signed-off-by: Fan Zhang Acked-by: Fiona Trahe --- doc/guides/prog_guide/cryptodev_lib.rst| 3 ++- doc/guides/rel_notes/release_19_02.rst | 7 +

[dpdk-dev] [PATCH v4 07/12] test/crypto: use separate session mempools

This patch uses the two session mempool approach to crypto unit test. One mempool is for session header objects, and the other is for session private data. Signed-off-by: Fan Zhang Acked-by: Fiona Trahe --- test/test/test_cryptodev.c | 229 - test/tes

[dpdk-dev] [PATCH v4 04/12] net/softnic: use separate session mempools

This patch uses the two session mempool approach to softnic PMD. One mempool is for session header objects, and the other is for session private data. Signed-off-by: Fan Zhang Acked-by: Fiona Trahe --- drivers/net/softnic/rte_eth_softnic_cli.c | 52 - drivers/net/s

[dpdk-dev] [PATCH v4 05/12] examples: use separate session mempools

This patch uses the two session mempool approach to all cryptodev sample applications. One mempool is for session header objects, and the other is for session private data. Signed-off-by: Fan Zhang Acked-by: Fiona Trahe --- examples/fips_validation/main.c | 34 +- exam

[dpdk-dev] [PATCH v4 06/12] vhost/crypto: use separate session mempools

This patch uses the two session mempool approach to vhost crypto. One mempool is for session header objects, and the other is for session private data. Signed-off-by: Fan Zhang Acked-by: Fiona Trahe --- lib/librte_vhost/rte_vhost_crypto.h | 9 ++--- lib/librte_vhost/vhost_crypto.c | 8 +

[dpdk-dev] [PATCH v4 03/12] app/test-crypto-perf: use separate session mempools

This patch uses the two session mempool approach to crypto perf application. One mempool is for session header objects, and the other is for session private data. Signed-off-by: Fan Zhang Acked-by: Fiona Trahe --- app/test-crypto-perf/cperf.h | 1 + app/test-crypto-perf/cp

[dpdk-dev] [PATCH v4 02/12] cryptodev: add sym session mempool create

This patch adds a new API "rte_cryptodev_sym_session_pool_create()" to cryptodev library. All applications are required to use this API to create sym session mempool as it adds private data and nb_drivers information to the mempool private data. Signed-off-by: Fan Zhang Acked-by: Fiona Trahe ---

[dpdk-dev] [PATCH v4 01/12] cryptodev: change queue pair configure structure

This patch changes the cryptodev queue pair configure structure to enable two mempool passed into cryptodev PMD simutaneously. Signed-off-by: Fan Zhang Acked-by: Fiona Trahe --- app/test-crypto-perf/main.c| 6 ++-- doc/guides/prog_guide/cryptodev_lib.rst| 12

[dpdk-dev] [PATCH v4 00/12] cryptodev: change qp conf and sym session

This patchset changes the queue pair configure structure and sym session structure for cryptodev. An RFC patch http://patchwork.dpdk.org/patch/43883/ has been sent to state the change. The patchset also includes two added APIs for creating symmetric session mempool and getting the session header d

Re: [dpdk-dev] DPDK on IBM Power9

> On Jan 9, 2019, at 4:25 PM, Daniel Waddington > wrote: > > Hi, > I'm trying to run DPDK 18.11 on IBM Power9. Should it run? (I'n new to DPDK > on Power). > Thx, > Daniel > Below is what I get: > > $ sudo ./examples/ethtool/ethtool-app/ppc_64-power8-linuxapp-gcc/app/ethtool > --iova-mo

Re: [dpdk-dev] [PATCH] test/crypto: fix misleading trace message

> -Original Message- > From: stable [mailto:stable-boun...@dpdk.org] On Behalf Of De Lara > Guarch, Pablo > Sent: Friday, December 21, 2018 11:42 AM > To: Trahe, Fiona ; dev@dpdk.org > Cc: Zhang, Roy Fan ; akhil.go...@nxp.com; > sta...@dpdk.org > Subject: Re: [dpdk-stable] [PATCH] test/c

Re: [dpdk-dev] [PATCH] compress/qat: fix status return on error building request

> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Trahe, Fiona > Sent: Friday, December 14, 2018 6:48 PM > To: Jozwiak, TomaszX ; dev@dpdk.org; > akhil.go...@nxp.com; sta...@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] compress/qat: fix status return on error > bu

Re: [dpdk-dev] [PATCH] compress/qat: add compression on dh895x

> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Trahe, Fiona > Sent: Friday, December 21, 2018 5:12 PM > To: Jozwiak, TomaszX ; dev@dpdk.org; > akhil.go...@nxp.com > Cc: Trahe, Fiona > Subject: Re: [dpdk-dev] [PATCH] compress/qat: add compression on dh895x >

Re: [dpdk-dev] [PATCH v4] crypto/aesni_mb: support plain SHA

> -Original Message- > From: Trahe, Fiona > Sent: Thursday, December 20, 2018 5:52 PM > To: Zhang, Roy Fan ; dev@dpdk.org > Cc: akhil.go...@nxp.com; De Lara Guarch, Pablo > ; Nowak, DamianX > ; Krakowiak, LukaszX > ; Trahe, Fiona > Subject: RE: [dpdk-dev] [PATCH v4] crypto/aesni_mb: sup

[dpdk-dev] DPDK on IBM Power9

Hi, I'm trying to run DPDK 18.11 on IBM Power9. Should it run? (I'n new to DPDK on Power). Thx, Daniel Below is what I get: $ sudo ./examples/ethtool/ethtool-app/ppc_64-power8-linuxapp-gcc/app/ethtool --iova-mode=pa -c7 -w :01:00.0 EAL: Detected 128 lcore(s) EAL: Detected 2 NUMA nodes EA

Re: [dpdk-dev] [PATCH v6] crypto/aesni_mb: support AES-GMAC

> -Original Message- > From: Zhang, Roy Fan > Sent: Thursday, December 20, 2018 12:08 PM > To: dev@dpdk.org > Cc: akhil.go...@nxp.com; De Lara Guarch, Pablo > > Subject: [PATCH v6] crypto/aesni_mb: support AES-GMAC > > This patchh adds the AES-GMAC authentication only support to AESNI-

Re: [dpdk-dev] [PATCH v4 0/3] use architecure independent macros

> -Original Message- > From: Zhang, Roy Fan > Sent: Thursday, December 20, 2018 11:57 AM > To: dev@dpdk.org > Cc: akhil.go...@nxp.com; De Lara Guarch, Pablo > > Subject: [PATCH v4 0/3] use architecure independent macros > > This patch updates the aesni_mb to use IMB_* arch independent

Re: [dpdk-dev] [PATCH] eal: move compat includes to common meson file

09/01/2019 21:51, Bruce Richardson: > On Wed, Jan 09, 2019 at 06:29:32PM +0100, David Marchand wrote: > >On Wed, Jan 9, 2019 at 6:18 PM Anatoly Burakov > ><[1]anatoly.bura...@intel.com> wrote: > > > > Currently, while EAL does depend on librte_compat as far as common > > meson bu

Re: [dpdk-dev] [PATCH v5] doc: add GRO API limitations in prog_guide

> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Ananyev, Konstantin > > From: Stephen Hemminger [mailto:step...@networkplumber.org] > > > > Obe merged. > > > + > > > +GRO Library Limitations > > > +--- > > > + > > > +- GRO library uses the values of MBUF->l2_len/l

Re: [dpdk-dev] [PATCH v2] doc: fix MAC address rewrite actions documentation

> -Original Message- > From: dev On Behalf Of Dekel Peled > Sent: Wednesday, January 9, 2019 1:38 PM > To: Adrien Mazarguil > Cc: dev@dpdk.org; Ori Kam ; Dekel Peled > ; Jack Min > Subject: [dpdk-dev] [PATCH v2] doc: fix MAC address rewrite actions > documentation > > This patch fixe

Re: [dpdk-dev] [PATCH] eal: move compat includes to common meson file

On Wed, Jan 09, 2019 at 06:29:32PM +0100, David Marchand wrote: >On Wed, Jan 9, 2019 at 6:18 PM Anatoly Burakov ><[1]anatoly.bura...@intel.com> wrote: > > Currently, while EAL does depend on librte_compat as far as common > meson build is concerned, for some reason the headers fo

Re: [dpdk-dev] [PATCH v2] doc: fix aesni mb documentation.

> -Original Message- > From: De Lara Guarch, Pablo > Sent: Wednesday, January 9, 2019 8:06 PM > To: Zhang, Roy Fan ; dev@dpdk.org > Cc: akhil.go...@nxp.com; Trahe, Fiona ; > sta...@dpdk.org > Subject: RE: [PATCH v2] doc: fix aesni mb documentation. > > > > > -Original Message-

Re: [dpdk-dev] [PATCH v2] doc: fix aesni mb documentation.

> -Original Message- > From: Zhang, Roy Fan > Sent: Wednesday, January 9, 2019 12:11 PM > To: dev@dpdk.org > Cc: akhil.go...@nxp.com; De Lara Guarch, Pablo > ; Trahe, Fiona ; > sta...@dpdk.org > Subject: [PATCH v2] doc: fix aesni mb documentation. > > This patch fixes the incorrect inte

Re: [dpdk-dev] [PATCH v6 3/3] hash: flush the rings instead of dequeuing one by one

>-Original Message- >From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of gavin hu >Sent: Wednesday, January 9, 2019 3:32 AM >To: dev@dpdk.org >Cc: n...@arm.com; tho...@monjalon.net; jer...@marvell.com; >hemant.agra...@nxp.com; honnappa.nagaraha...@arm.com; >gavin...@arm.com; olivier.m...@

Re: [dpdk-dev] [PATCH v5] doc: add GRO API limitations in prog_guide

> -Original Message- > From: Stephen Hemminger [mailto:step...@networkplumber.org] > Sent: Wednesday, January 9, 2019 6:20 PM > To: Hu, Jiayu > Cc: dev@dpdk.org; Ananyev, Konstantin ; > m...@smartsharesystems.com; tho...@monjalon.net; > Varghese, Vipin ; sta...@dpdk.org > Subject: Re:

Re: [dpdk-dev] [PATCH v5] doc: add GRO API limitations in prog_guide

Obe merged. > + > +GRO Library Limitations > +--- > + > +- GRO library uses the values of MBUF->l2_len/l3_len/l4_len/ > + outer_l2_len/outer_l3_len to get protocol headers for the > + input packet, rather than parsing the packet header. Therefore, > + before call GRO

Re: [dpdk-dev] [PATCH] eal: move compat includes to common meson file

On Wed, Jan 9, 2019 at 6:18 PM Anatoly Burakov wrote: > Currently, while EAL does depend on librte_compat as far as common > meson build is concerned, for some reason the headers for that > library are not added into the list of includes. This is fixed in > Linuxapp-specific meson file, but is ab

[dpdk-dev] [PATCH] eal: move compat includes to common meson file

Currently, while EAL does depend on librte_compat as far as common meson build is concerned, for some reason the headers for that library are not added into the list of includes. This is fixed in Linuxapp-specific meson file, but is absent from FreeBSD meson file. This worked fine up until recentl

Re: [dpdk-dev] [PATCH v2 2/2] test/compress: add varied buffer input/outputs

> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Marko Kovacevic > Sent: Thursday, December 20, 2018 2:58 PM > To: dev@dpdk.org > Cc: akhil.go...@nxp.com; Daly, Lee ; Jozwiak, TomaszX > ; O'Hare, Cathal ; > Trahe, Fiona ; Kovacevic, Marko > > Subject: [dpdk-de

Re: [dpdk-dev] [EXT] Re: [PATCH] config: change default cache line size for ARMv8 with meson

On Wed, 2019-01-09 at 16:52 +, Luca Boccassi wrote: > On Wed, 2019-01-09 at 16:36 +, Pavan Nikhilesh Bhagavatula wrote: > > On Wed, 2019-01-09 at 15:41 +, Luca Boccassi wrote: > > > External Email > > > > > > --- > > > >

[dpdk-dev] [PATCH] virtio-user: ctrl vq support for packed

Add support to virtio-user for control virtqueues and reverts commit "5e4e7a752 net/virtio-user: fail if cq used with packed vq". Signed-off-by: Jens Freimann --- .../net/virtio/virtio_user/virtio_user_dev.c | 111 -- .../net/virtio/virtio_user/virtio_user_dev.h | 8 +- drive

Re: [dpdk-dev] [PATCH v3 0/3] Missing barriers and VIRTIO_F_ORDER_PLATFORM.

On 1/9/2019 3:24 PM, Ilya Maximets wrote: > On 09.01.2019 17:55, Michael S. Tsirkin wrote: >> On Wed, Jan 09, 2019 at 05:50:12PM +0300, Ilya Maximets wrote: >>> Version 3: >>> * Added 2 patches with fixes for current virtio driver. >>> Not directly connected with the new feature. >> >> New ve

Re: [dpdk-dev] [EXT] Re: [PATCH] config: change default cache line size for ARMv8 with meson

On Wed, 2019-01-09 at 16:36 +, Pavan Nikhilesh Bhagavatula wrote: > On Wed, 2019-01-09 at 15:41 +, Luca Boccassi wrote: > > External Email > > > > --- > > --- > > On Wed, 2019-01-09 at 15:34 +, Jerin Jacob Kollanukkaran wr

[dpdk-dev] Wrong constant being used

Hi, In pktgen 3.6.1, app/pktgen.c, line 219, the constant "IPPROTO_UDP" is used. Shouldn't that be "PG_IPPROTO_UDP" instead? Kind regards, DanielPharos

[dpdk-dev] Seg fault with GRE in pktgen

Hi, Using pktgen 3.6.1, I'm getting a seg fault when enabling GRE. In app/pktgen.c, on line 556 l3_hdr is set to NULL, and then on line 567 it is send to a function that calls memset on it, triggering the seg fault I'm seeing. I suppose that l3_hdr argument (and the last argument on line 569 to

[dpdk-dev] [PATCH] vhostuser: fix deadlock when vhost unregister

When rte_vhost_driver_unregister delete the connection fd, fdset_try_del will always try and donot release the vhostuser.mutex if the fd is busy, but the fdset_event_dispatch will set the fd to busy and call vhost_user_msg_handler to get vhostuser.mutex, which will cause deadlock. To fix i

Re: [dpdk-dev] [PATCH v2 1/2] test/compress: add out of space test

Hi Marko, > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Marko Kovacevic > Sent: Thursday, December 20, 2018 2:58 PM > To: dev@dpdk.org > Cc: akhil.go...@nxp.com; Daly, Lee ; Jozwiak, TomaszX > ; O'Hare, Cathal ; > Trahe, Fiona ; Kovacevic, Marko > > Subject:

Re: [dpdk-dev] [dpdk-stable] [PATCH] net/sfc: discard last seen VLAN TCI if Tx packet is dropped

On 1/9/2019 11:06 AM, Andrew Rybchenko wrote: > From: Ivan Malov > > Early processing of a packet on transmit may change last seen > VLAN TCI in the queue context. If such a packet is eventually > dropped, last seen VLAN TCI must be set to its previous value. > > Fixes: 7fd636815a43 ("net/sfc: s

Re: [dpdk-dev] [EXT] Re: [PATCH] config: change default cache line size for ARMv8 with meson

On Wed, 2019-01-09 at 15:41 +, Luca Boccassi wrote: > External Email > > --- > --- > On Wed, 2019-01-09 at 15:34 +, Jerin Jacob Kollanukkaran wrote: > > > > Please check below thread and patch. > > > > > > > > http://mails.dp

Re: [dpdk-dev] [PATCH] net/nfp: add CPP bridge as service

On 1/9/2019 2:20 PM, Alejandro Lucero wrote: > > > On Wed, Jan 9, 2019 at 10:54 AM Ferruh Yigit > wrote: > > On 1/3/2019 8:56 AM, Alejandro Lucero wrote: > > The Netronome's Network Flow Processor chip is highly programmable > > with the goal of proces

Re: [dpdk-dev] [dpdk-stable] [PATCH] net/sfc: add missing header guard to TSO header file

On 1/9/2019 11:05 AM, Andrew Rybchenko wrote: > From: Ivan Malov > > Add missing header guard, including compiler directive for cplusplus. > > Fixes: f1f575be9b76 ("net/sfc: put generalised TSO declarations in a header") > Cc: sta...@dpdk.org > > Signed-off-by: Ivan Malov > Signed-off-by: Andr

Re: [dpdk-dev] [RFC] function to parse packet headers

From: Rami Rosen [mailto:roszenr...@gmail.com] >Hi Morten, >A good idea, thanks for volunteering!  >Several minor comments:  >I would consider calling it rte_mbuf_hdr_parse(), to make it more related to >the rte_mbuf* methods, and also I would consider having it in librte_mbuf and >not in librte

Re: [dpdk-dev] [PATCH v2] net/virtio: add platform memory ordering feature support

On Wed, Jan 09, 2019 at 05:34:38PM +0300, Ilya Maximets wrote: > virtio_mb() is really heavy. I'd like to avoid it somehow, but I don't > know how to do this yet. Linux driver doesn't avoid it either. -- MST

Re: [dpdk-dev] [PATCH] config: change default cache line size for ARMv8 with meson

On Wed, 2019-01-09 at 15:34 +, Jerin Jacob Kollanukkaran wrote: > > > Please check below thread and patch. > > > > > > http://mails.dpdk.org/archives/dev/2019-January/122676.html > > > https://patches.dpdk.org/patch/49477/ > > > > > > Debian folks are building like this for the _generic_ imag

Re: [dpdk-dev] [RFC] function to parse packet headers

Cutting in Olivier, requesting input as the maintainer of rte_net. > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of > long...@viettel.com.vn > > Hi Morten, > > What is the difference compare to rte_net_get_ptype(), which also > parses > packet types and reports on header length. > > In my

Re: [dpdk-dev] [PATCH] config: change default cache line size for ARMv8 with meson

> > Please check below thread and patch. > > > > http://mails.dpdk.org/archives/dev/2019-January/122676.html > > https://patches.dpdk.org/patch/49477/ > > > > Debian folks are building like this for the _generic_ image. > > What ever works for every distros, I am fine with that. > > > > meson c

Re: [dpdk-dev] [PATCH v3 0/3] Missing barriers and VIRTIO_F_ORDER_PLATFORM.

On 09.01.2019 17:55, Michael S. Tsirkin wrote: > On Wed, Jan 09, 2019 at 05:50:12PM +0300, Ilya Maximets wrote: >> Version 3: >> * Added 2 patches with fixes for current virtio driver. >> Not directly connected with the new feature. > > New version shouldn't be reply-to old one really :). I

[dpdk-dev] [PATCH] crypto/dpaa2_sec: fix FLC address for physical mode

Fixes: 547a4d40e7bf ("crypto/dpaa2_sec: support out of place protocol offload") Fixes: 0a23d4b6f4c2 ("crypto/dpaa2_sec: support protocol offload IPsec") Cc:sta...@dpdk.org Signed-off-by: Akhil Goyal --- drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c | 4 ++-- 1 file changed, 2 insertions(+), 2 del

[dpdk-dev] [PATCH] crypto/dpaa_sec: support same session flows on multi cores

In dpaa_sec, each session should have a separate in-queue, and each in-queue should be mapped to an outq. So if multiple flows of same SA comes to different cores due to rss distribution of NIC, enqueue from any core will try to do re-assignment of inq - outq mapping which will fail. In this patch

[dpdk-dev] [PATCH] crypto/dpaa_sec: support PDCP offload

From: Hemant Agrawal PDCP session configuration for lookaside protocol offload and data path is added. Signed-off-by: Hemant Agrawal Acked-by: Akhil Goyal --- drivers/crypto/dpaa_sec/dpaa_sec.c | 268 + drivers/crypto/dpaa_sec/dpaa_sec.h | 212 +

Re: [dpdk-dev] [PATCH v2 1/2] config: gather options for dlopen mlx dependency

Wednesday, January 9, 2019 4:23 PM, Thomas Monjalon: > Subject: [PATCH v2 1/2] config: gather options for dlopen mlx dependency > > Rename options CONFIG_RTE_LIBRTE_MLX4_DLOPEN_DEPS and > CONFIG_RTE_LIBRTE_MLX5_DLOPEN_DEPS to a single option > CONFIG_RTE_IBVERBS_LINK_DLOPEN. > Rename meson option

Re: [dpdk-dev] [EXT] [PATCH] config: change default cache line size for ARMv8 with meson

09/01/2019 15:23, Jerin Jacob Kollanukkaran: > On Wed, 2019-01-09 at 14:30 +0100, Thomas Monjalon wrote: > > 09/01/2019 13:47, Jerin Jacob Kollanukkaran: > > > On Wed, 2019-01-09 at 12:28 +0100, Thomas Monjalon wrote: > > > > 09/01/2019 11:49, Jerin Jacob Kollanukkaran: > > > > > On Wed, 2019-01-09

[dpdk-dev] [PATCH] examples/vhost: remove unnecessary method and constant

This cleanup patch removes a method and a constant which are now unnecessary in the VHOST sample applicaiopn, namely the validate_num_devices() method and the MAX_DEVICES constant. Fixes: 56fe86f8dcaf ("examples/vhost: embed statistics into device structure") Cc: sta...@dpdk.org Signed-off-by: R

Re: [dpdk-dev] [PATCH v3 0/3] Missing barriers and VIRTIO_F_ORDER_PLATFORM.

On Wed, Jan 09, 2019 at 05:50:12PM +0300, Ilya Maximets wrote: > Version 3: > * Added 2 patches with fixes for current virtio driver. > Not directly connected with the new feature. New version shouldn't be reply-to old one really :). But the patches are good I think. Acked-by: Michael S. Ts

[dpdk-dev] [PATCH v3 3/3] net/virtio: add platform memory ordering feature support

VIRTIO_F_ORDER_PLATFORM is required to use proper memory barriers in case of HW vhost implementations like vDPA. DMA barriers (rte_cio_*) are sufficent for that purpose. Previously known as VIRTIO_F_IO_BARRIER. Signed-off-by: Ilya Maximets --- drivers/net/virtio/virtio_ethdev.c | 2 ++ driver

[dpdk-dev] [PATCH v3 2/3] net/virtio: update memory ordering comment for vq notify

We're not using io ports in case of modern device even on IA. Also, this comment useless for other architectures. Signed-off-by: Ilya Maximets --- drivers/net/virtio/virtqueue.h | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/net/virtio/virtqueue.h b/drivers/

[dpdk-dev] [PATCH v3 1/3] net/virtio: add missing barrier before reading the flags

Reading the used->flags could be reordered with avail->idx update. vhost in kernel disables notifications for the time of packets receiving, like this: 1. disable notify 2. process packets 3. enable notify 4. has more packets ? goto 1 In case of reordering, virtio driver could rea

[dpdk-dev] [PATCH v3 0/3] Missing barriers and VIRTIO_F_ORDER_PLATFORM.

Version 3: * Added 2 patches with fixes for current virtio driver. Not directly connected with the new feature. Version 2: * rebased on current master (packed rings). RFC --> Version 1: * Dropped vendor-specific hack to determine if we need real barriers. * Added VIRTIO_F_ORDER_PLATFO

Re: [dpdk-dev] [PATCH] drivers: fix sprintf with snprintf

On 1/7/2019 4:16 PM, Pallantla Poornima wrote: > sprintf function is not secure as it doesn't check the length of string. > More secure function snprintf is used > > Fixes: 828d51d8fc ("bus/fslmc: refactor scan and probe functions") > Fixes: c22fab9a6c ("raw/dpaa2_qdma: support configuration APIs

Re: [dpdk-dev] [PATCH v2] net/virtio: add platform memory ordering feature support

On 27.12.2018 13:07, Shahaf Shuler wrote: > Hi Ilya, > > Wednesday, December 26, 2018 6:37 PM, Ilya Maximets: >> Subject: [dpdk-dev] [PATCH v2] net/virtio: add platform memory ordering >> feature support >> >> VIRTIO_F_ORDER_PLATFORM is required to use proper memory barriers in >> case of HW vhos

[dpdk-dev] [PATCH v2 2/2] config: add static linkage of mlx dependency

The libraries provided by rdma-core may be statically linked if enabling CONFIG_RTE_IBVERBS_LINK_STATIC in the make-based build. If CONFIG_RTE_BUILD_SHARED_LIB is disabled, the applications will embed the mlx PMDs with ibverbs and the mlx libraries. If CONFIG_RTE_BUILD_SHARED_LIB is enabled, the ml

[dpdk-dev] [PATCH v2 1/2] config: gather options for dlopen mlx dependency

Rename options CONFIG_RTE_LIBRTE_MLX4_DLOPEN_DEPS and CONFIG_RTE_LIBRTE_MLX5_DLOPEN_DEPS to a single option CONFIG_RTE_IBVERBS_LINK_DLOPEN. Rename meson option enable_driver_mlx_glue to ibverbs_link. There was no good reason for setting a different link option for mlx4 and mlx5. Having a single co

Re: [dpdk-dev] [EXT] [PATCH] config: change default cache line size for ARMv8 with meson

On Wed, 2019-01-09 at 14:30 +0100, Thomas Monjalon wrote: > 09/01/2019 13:47, Jerin Jacob Kollanukkaran: > > On Wed, 2019-01-09 at 12:28 +0100, Thomas Monjalon wrote: > > > 09/01/2019 11:49, Jerin Jacob Kollanukkaran: > > > > On Wed, 2019-01-09 at 10:22 +, Yongseok Koh wrote: > > > > > On Jan 9

Re: [dpdk-dev] [PATCH] net/nfp: add CPP bridge as service

On Wed, Jan 9, 2019 at 10:54 AM Ferruh Yigit wrote: > On 1/3/2019 8:56 AM, Alejandro Lucero wrote: > > The Netronome's Network Flow Processor chip is highly programmable > > with the goal of processing packets at high speed. Processing units > > and other chip components are available from the ho

Re: [dpdk-dev] net/bonding: fix possible null pointer reference

On 1/8/2019 11:17 AM, Declan Doherty wrote: > In function check_for_bonded_ethdev the driver name is used without > validating the pointer references in the passed ethdev object. > > Fixes: 740feaf349b1 ("ethdev: remove driver name from device private data") > Cc: sta...@dpdk.org > > Signed-off-b

Re: [dpdk-dev] [PATCH v2 1/2] mbuf: add function returning default buffer address

On Wed, Jan 9, 2019 at 2:19 PM Yongseok Koh wrote: > This patch introduces two new functions - rte_mbuf_buf_addr_default() and > rte_mbuf_data_baddr_default(). > > rte_mbuf_buf_addr_default() reutrns the default buffer address of given > mbuf which comes after mbuf structure and private data. >

Re: [dpdk-dev] [EXT] [PATCH] config: change default cache line size for ARMv8 with meson

09/01/2019 13:47, Jerin Jacob Kollanukkaran: > On Wed, 2019-01-09 at 12:28 +0100, Thomas Monjalon wrote: > > 09/01/2019 11:49, Jerin Jacob Kollanukkaran: > > > On Wed, 2019-01-09 at 10:22 +, Yongseok Koh wrote: > > > > On Jan 9, 2019, at 2:09 AM, Jerin Jacob Kollanukkaran wrote: > > > > > I thi

[dpdk-dev] [PATCH v2 2/2] net/mlx5: fix instruction hotspot on replenishing Rx buffer

On replenishing Rx buffers for vectorized Rx, mbuf->buf_addr isn't needed to be accessed as it is static and easily calculated from the mbuf address. Accessing the mbuf content causes unnecessary load stall and it is worsened on ARM. Fixes: 545b884b1da3 ("net/mlx5: fix buffer address posting in SS

[dpdk-dev] [PATCH v2 1/2] mbuf: add function returning default buffer address

This patch introduces two new functions - rte_mbuf_buf_addr_default() and rte_mbuf_data_baddr_default(). rte_mbuf_buf_addr_default() reutrns the default buffer address of given mbuf which comes after mbuf structure and private data. rte_mbuf_data_baddr_default() returns the default address of mbu

Re: [dpdk-dev] [EXT] [PATCH] config: change default cache line size for ARMv8 with meson

On Wed, 2019-01-09 at 10:52 +, Jerin Jacob Kollanukkaran wrote: > On Wed, 2019-01-09 at 10:19 +, Luca Boccassi wrote: > > On Wed, 2019-01-09 at 10:09 +, Jerin Jacob Kollanukkaran wrote: > > > On Wed, 2019-01-09 at 01:39 -0800, Yongseok Koh wrote: > > > >

Re: [dpdk-dev] [PATCH v2] config: add Mellanox BlueField ARMv8 SoC

On Wed, 2019-01-09 at 04:34 -0800, Yongseok Koh wrote: > BlueField is Mellanox's new SoC based on ARMv8. BlueField integrates > Mellanox ConnectX-5 interconnect and Cortex-A72 cores into a single > device. > > http://www.mellanox.com/page/products_dyn?product_family=256&mtag=soc_overview > > Sign

Re: [dpdk-dev] [EXT] [PATCH] config: change default cache line size for ARMv8 with meson

On Wed, 2019-01-09 at 12:28 +0100, Thomas Monjalon wrote: > 09/01/2019 11:49, Jerin Jacob Kollanukkaran: > > On Wed, 2019-01-09 at 10:22 +, Yongseok Koh wrote: > > > On Jan 9, 2019, at 2:09 AM, Jerin Jacob Kollanukkaran wrote: > > > > I think, I way forward is to add > > > > config/arm/arm64_a7

[dpdk-dev] [PATCH v2] config: add Mellanox BlueField ARMv8 SoC

BlueField is Mellanox's new SoC based on ARMv8. BlueField integrates Mellanox ConnectX-5 interconnect and Cortex-A72 cores into a single device. http://www.mellanox.com/page/products_dyn?product_family=256&mtag=soc_overview Signed-off-by: Yongseok Koh --- config/defconfig_arm64-bluefield-linuxa

Re: [dpdk-dev] [dpdk-stable] [PATCH v2] app/testpmd: fix quit to stop all ports before close

On 1/4/2019 1:47 PM, Iremonger, Bernard wrote: >> -Original Message- >> From: Dumitrescu, Cristian >> Sent: Friday, January 4, 2019 12:29 PM >> To: dev@dpdk.org >> Cc: Lu, Wenzhuo ; Wu, Jingjing >> ; Iremonger, Bernard ; >> sta...@dpdk.org >> Subject: [PATCH v2] app/testpmd: fix quit to sto

  1   2   >