Re: [dpdk-dev] [RFC] function to parse packet headers

2019-01-10 Thread Andrew Rybchenko
On 1/11/19 3:11 AM, Stephen Hemminger wrote: On Thu, 10 Jan 2019 03:03:24 +0200 Rami Rosen wrote: Hi, Morten, And regarding avoiding code duplicity, I'm pursuing Olivier about merging packet header validation into rte_net_get_ptype() instead of writing a separate function. This seems al

Re: [dpdk-dev] [PATCH v3] config: add Mellanox BlueField ARMv8 SoC

2019-01-10 Thread Yongseok Koh
> On Jan 10, 2019, at 6:47 PM, Gavin Hu (Arm Technology China) > wrote: > > >> -Original Message- >> From: dev On Behalf Of Yongseok Koh >> Sent: Friday, January 11, 2019 2:39 AM >> To: tho...@monjalon.net >> Cc: dev@dpdk.org; shah...@mellanox.com; jer...@marvell.com >> Subject: [dpd

Re: [dpdk-dev] [PATCH v8 10/10] doc: update ipsec-secgw guide and relelase notes

2019-01-10 Thread Akhil Goyal
Hi Vipin, On 1/11/2019 8:19 AM, Varghese, Vipin wrote: > Hi Konstantin, > > As per 19.02-rc1, documentation has to be updated along with the code base. I and Pablo, thought about your comment, but the feature that is added in this patchset is split across multiple patches (mainly 7/10 and 8/10)

Re: [dpdk-dev] [PATCH v2] mbuf: fix compile by removing struct from function

2019-01-10 Thread Stephen Hemminger
On Fri, 11 Jan 2019 03:01:43 + "Gavin Hu (Arm Technology China)" wrote: > > -Original Message- > > From: dev On Behalf Of Dumitrescu, Cristian > > Sent: Friday, January 11, 2019 2:40 AM > > To: Van Haaren, Harry ; dev@dpdk.org > > Cc: Pattan, Reshma ; tho...@monjalon.net; > > olivier

Re: [dpdk-dev] [PATCH 1/6] ring: change head and tail to pointer-width size

2019-01-10 Thread Stephen Hemminger
On Thu, 10 Jan 2019 15:01:17 -0600 Gage Eads wrote: > For 64-bit architectures, doubling the head and tail index widths greatly > increases the time it takes for them to wrap-around (with current CPU > speeds, it won't happen within the author's lifetime). This is important in > avoiding the ABA

Re: [dpdk-dev] [PATCH] build: mention -march in pkg-config description

2019-01-10 Thread Gavin Hu (Arm Technology China)
> -Original Message- > From: dev On Behalf Of Luca Boccassi > Sent: Friday, January 11, 2019 1:28 AM > To: dev@dpdk.org > Cc: bruce.richard...@intel.com; christian.ehrha...@canonical.com; Luca > Boccassi ; sta...@dpdk.org > Subject: [dpdk-dev] [PATCH] build: mention -march in pkg-config

Re: [dpdk-dev] [PATCH v9 1/6] app/procinfo: add support for show port

2019-01-10 Thread Varghese, Vipin
Hi Thomas snipped > > +#include > > Is the crypto include really required in this patch? Function 'show_port' requires the include file. Removing the same results In function 'show_port': /home/saesrv02/Downloads/dpdksrc/procifno/dpdk/app/proc-info/main.c:733:33: error: dereferencing pointer t

Re: [dpdk-dev] [PATCH v2] mbuf: fix compile by removing struct from function

2019-01-10 Thread Gavin Hu (Arm Technology China)
> -Original Message- > From: dev On Behalf Of Dumitrescu, Cristian > Sent: Friday, January 11, 2019 2:40 AM > To: Van Haaren, Harry ; dev@dpdk.org > Cc: Pattan, Reshma ; tho...@monjalon.net; > olivier.m...@6wind.com > Subject: Re: [dpdk-dev] [PATCH v2] mbuf: fix compile by removing stru

Re: [dpdk-dev] [PATCH v1] net/i40e: perform basic validation on the VF messages

2019-01-10 Thread Varghese, Vipin
Hi Kevin, A question, since the patch is fixing issue for 'i40e vf' should not the sections for 'known limitations' or 'i40e PMD' be updated too? Thanks Vipin Varghese > -Original Message- > From: dev On Behalf Of Kevin Traynor > Sent: Thursday, January 10, 2019 11:18 PM > To: Wang, H

Re: [dpdk-dev] [PATCH 6/6] doc: add NB ring comment to EAL "known issues"

2019-01-10 Thread Varghese, Vipin
Hi Gage, Humble suggestion from my end, as per DPDK 19.02-rc1 the documentation and code change have to be in same patch. Can you please take a look into it. > -Original Message- > From: dev On Behalf Of Gage Eads > Sent: Friday, January 11, 2019 2:31 AM > To: dev@dpdk.org > Cc: olivier

Re: [dpdk-dev] [PATCH v8 10/10] doc: update ipsec-secgw guide and relelase notes

2019-01-10 Thread Varghese, Vipin
Hi Konstantin, As per 19.02-rc1, documentation has to be updated along with the code base. snipped > --- a/doc/guides/rel_notes/release_19_02.rst > +++ b/doc/guides/rel_notes/release_19_02.rst > @@ -133,6 +133,20 @@ New Features > >See :doc:`../prog_guide/ipsec_lib` for more information. >

Re: [dpdk-dev] [PATCH v3] config: add Mellanox BlueField ARMv8 SoC

2019-01-10 Thread Gavin Hu (Arm Technology China)
> -Original Message- > From: dev On Behalf Of Yongseok Koh > Sent: Friday, January 11, 2019 2:39 AM > To: tho...@monjalon.net > Cc: dev@dpdk.org; shah...@mellanox.com; jer...@marvell.com > Subject: [dpdk-dev] [PATCH v3] config: add Mellanox BlueField ARMv8 SoC > > BlueField is Mellanox's

Re: [dpdk-dev] [PATCH v7 00/10] examples/ipsec-secgw: make app to use ipsec library

2019-01-10 Thread Xu, Yanjie
The patch series latest versions be tested by yanjie xu, which work for crypto and inline ipsec cases. -Original Message- From: Ananyev, Konstantin Sent: Wednesday, January 9, 2019 7:44 PM To: dev@dpdk.org Cc: akhil.go...@nxp.com; De Lara Guarch, Pablo ; Ananyev, Konstantin Subjec

Re: [dpdk-dev] [PATCH v6 00/10] ipsec: new library for IPsec data-path processing

2019-01-10 Thread Xu, Yanjie
The patch series latest versions be tested by yanjie xu, which work for crypto and inline ipsec cases. -Original Message- From: Ananyev, Konstantin Sent: Friday, January 4, 2019 4:16 AM To: dev@dpdk.org; dev@dpdk.org Cc: akhil.go...@nxp.com; Ananyev, Konstantin Subject: [PATCH v6 00/10

Re: [dpdk-dev] [PATCH v8 00/10] examples/ipsec-secgw: make app to use ipsec library

2019-01-10 Thread Ananyev, Konstantin
> > > -Original Message- > > From: Ananyev, Konstantin > > Sent: Thursday, January 10, 2019 9:09 PM > > To: dev@dpdk.org > > Cc: akhil.go...@nxp.com; De Lara Guarch, Pablo > > ; tho...@monjalon.net; Ananyev, > > Konstantin > > Subject: [PATCH v8 00/10] examples/ipsec-secgw: make app to

Re: [dpdk-dev] [RFC] function to parse packet headers

2019-01-10 Thread Stephen Hemminger
On Thu, 10 Jan 2019 03:03:24 +0200 Rami Rosen wrote: > Hi, Morten, > > > And regarding avoiding code duplicity, I'm pursuing Olivier about merging > packet header validation into rte_net_get_ptype() instead of writing a > separate function. > > > This seems also a good alternative. > +1 > >

Re: [dpdk-dev] [PATCH] crypto/dpaa_sec: support PDCP offload

2019-01-10 Thread De Lara Guarch, Pablo
> -Original Message- > From: Akhil Goyal [mailto:akhil.go...@nxp.com] > Sent: Wednesday, January 9, 2019 3:13 PM > To: dev@dpdk.org > Cc: Hemant Agrawal ; De Lara Guarch, Pablo > > Subject: [PATCH] crypto/dpaa_sec: support PDCP offload > > From: Hemant Agrawal > > PDCP session config

Re: [dpdk-dev] [PATCH] crypto/dpaa_sec: support same session flows on multi cores

2019-01-10 Thread De Lara Guarch, Pablo
> -Original Message- > From: Akhil Goyal [mailto:akhil.go...@nxp.com] > Sent: Wednesday, January 9, 2019 3:14 PM > To: dev@dpdk.org > Cc: Hemant Agrawal ; De Lara Guarch, Pablo > ; Akhil Goyal > Subject: [PATCH] crypto/dpaa_sec: support same session flows on multi > cores > > In dpaa_s

Re: [dpdk-dev] [PATCH] crypto/dpaa2_sec: fix FLC address for physical mode

2019-01-10 Thread De Lara Guarch, Pablo
> -Original Message- > From: Akhil Goyal [mailto:akhil.go...@nxp.com] > Sent: Wednesday, January 9, 2019 3:14 PM > To: dev@dpdk.org > Cc: Hemant Agrawal ; De Lara Guarch, Pablo > ; Akhil Goyal > Subject: [PATCH] crypto/dpaa2_sec: fix FLC address for physical mode > > Fixes: 547a4d40e7b

Re: [dpdk-dev] [PATCH] test/crypto: fix misleading trace message

2019-01-10 Thread De Lara Guarch, Pablo
> -Original Message- > From: Trahe, Fiona > Sent: Friday, December 21, 2018 12:01 AM > To: dev@dpdk.org > Cc: De Lara Guarch, Pablo ; Trahe, Fiona > ; Zhang, Roy Fan ; > akhil.go...@nxp.com; sta...@dpdk.org > Subject: [PATCH] test/crypto: fix misleading trace message > > Test was report

Re: [dpdk-dev] [PATCH] crypto/octeontx: remove usage of DEPDIRS

2019-01-10 Thread De Lara Guarch, Pablo
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Anoob Joseph > Sent: Thursday, January 10, 2019 8:53 AM > To: Akhil Goyal ; De Lara Guarch, Pablo > > Cc: Anoob Joseph ; Ankur Dwivedi > ; Tejasree Kondoj ; Jerin > Jacob Kollanukkaran ; Narayana Prasad Raju Ath

Re: [dpdk-dev] [PATCH v8 00/10] examples/ipsec-secgw: make app to use ipsec library

2019-01-10 Thread De Lara Guarch, Pablo
> -Original Message- > From: Ananyev, Konstantin > Sent: Thursday, January 10, 2019 9:09 PM > To: dev@dpdk.org > Cc: akhil.go...@nxp.com; De Lara Guarch, Pablo > ; tho...@monjalon.net; Ananyev, > Konstantin > Subject: [PATCH v8 00/10] examples/ipsec-secgw: make app to use ipsec > librar

Re: [dpdk-dev] [PATCH v8 0/9] ipsec: new library for IPsec data-path processing

2019-01-10 Thread De Lara Guarch, Pablo
> -Original Message- > From: Ananyev, Konstantin > Sent: Thursday, January 10, 2019 9:06 PM > To: dev@dpdk.org > Cc: akhil.go...@nxp.com; De Lara Guarch, Pablo > ; tho...@monjalon.net; Ananyev, > Konstantin > Subject: [PATCH v8 0/9] ipsec: new library for IPsec data-path processing > >

[dpdk-dev] [PATCH v4 2/2] net/mlx5: fix instruction hotspot on replenishing Rx buffer

2019-01-10 Thread Yongseok Koh
On replenishing Rx buffers for vectorized Rx, mbuf->buf_addr isn't needed to be accessed as it is static and easily calculated from the mbuf address. Accessing the mbuf content causes unnecessary load stall and it is worsened on ARM. Fixes: 545b884b1da3 ("net/mlx5: fix buffer address posting in SS

[dpdk-dev] [PATCH v4 1/2] mbuf: add function returning default buffer address

2019-01-10 Thread Yongseok Koh
This patch introduces two new functions - rte_mbuf_buf_addr() and rte_mbuf_data_addr_default(). rte_mbuf_buf_addr() reutrns the default buffer address of given mbuf which comes after mbuf structure and private data. rte_mbuf_data_addr_default() returns the default address of mbuf data taking the

Re: [dpdk-dev] [PATCH] mbuf: fix compile by making sched struct visible

2019-01-10 Thread Stephen Hemminger
On Thu, 10 Jan 2019 16:50:51 + Harry van Haaren wrote: > Although C compilation works with the struct rte_mbuf_sched > declared inside the struct rte_mbuf namespace, C++ fails to > compile. This fix moves the rte_mbuf_sched struct up to the > global namespace, instead of declaring it inside t

[dpdk-dev] [Patch v3 1/2] net/virtio: check head desc with correct wrap counter

2019-01-10 Thread Jens Freimann
In virtio_pq_send_command() we check for a used descriptor and wait in an idle loop until it becomes used. We can't use vq->used_wrap_counter here to check for the first descriptor we made available because the ring could have wrapped. Let's use the used_wrap_counter that matches the state of the h

[dpdk-dev] [Patch v3 2/2] net/virtio-user: ctrl vq support for packed

2019-01-10 Thread Jens Freimann
Add support to virtio-user for control virtqueues. Signed-off-by: Jens Freimann --- .../net/virtio/virtio_user/virtio_user_dev.c | 104 -- .../net/virtio/virtio_user/virtio_user_dev.h | 15 ++- drivers/net/virtio/virtio_user_ethdev.c | 56 +- 3 files changed, 15

[dpdk-dev] [PATCH v3 0/2] net/virtio-user: add packed vq support

2019-01-10 Thread Jens Freimann
Revert patch to error out when cq is used with packed vq and in second patch add support for packed virtqueues in control virtqueue code. Patch 1 fixes a bug in virtio_pq_send_command(). When we wait for a descriptor to be marked as used we need to consider that the ring might have wrapped and use

Re: [dpdk-dev] [PATCH v2] examples/fips_validate: add power on self test

2019-01-10 Thread De Lara Guarch, Pablo
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Fan Zhang > Sent: Wednesday, December 19, 2018 11:39 PM > To: dev@dpdk.org > Cc: akhil.go...@nxp.com > Subject: [dpdk-dev] [PATCH v2] examples/fips_validate: add power on self > test > > This patch adds a sample po

[dpdk-dev] [PATCH v8 09/10] examples/ipsec-secgw: add scripts for functional test

2019-01-10 Thread Konstantin Ananyev
The purpose of these scripts is to automate ipsec-secgw functional testing. The scripts require two machines (SUT and DUT) connected through at least 2 NICs and running linux (so far tested only on Ubuntu 18.04). Introduced test-cases for the following scenarios: - Transport/Tunnel modes - AES-CBC

[dpdk-dev] [PATCH v8 08/10] examples/ipsec-secgw: make data-path to use ipsec library

2019-01-10 Thread Konstantin Ananyev
Changes to make ipsec-secgw data-path code to utilize librte_ipsec library. Note that right now by default current (non-librte_ipsec) code-path will be used. User has to run application with new command-line option ('-l') to enable new codepath. Signed-off-by: Mohammad Abdul Awal Signed-off-by: B

[dpdk-dev] [PATCH v8 10/10] doc: update ipsec-secgw guide and relelase notes

2019-01-10 Thread Konstantin Ananyev
Update ipsec-secgw guide and relelase notes to reflect latest changes. Signed-off-by: Bernard Iremonger Signed-off-by: Konstantin Ananyev Acked-by: Akhil Goyal --- doc/guides/rel_notes/release_19_02.rst | 14 +++ doc/guides/sample_app_ug/ipsec_secgw.rst | 105 ++- 2 file

[dpdk-dev] [PATCH v8 07/10] examples/ipsec-secgw: make app to use ipsec library

2019-01-10 Thread Konstantin Ananyev
Changes to make ipsec-secgw to utilize librte_ipsec library. That patch provides: - changes in the related data structures. - changes in the initialization code. - new command-line parameters to enable librte_ipsec codepath and related features. Note that right now by default current (non-li

[dpdk-dev] [PATCH v8 03/10] examples/ipsec-secgw: fix crypto-op might never get dequeued

2019-01-10 Thread Konstantin Ananyev
In some cases crypto-ops could never be dequeued from the crypto-device. The easiest way to reproduce: start ipsec-secgw with crypto-dev and send to it less then 32 packets. none packets will be forwarded. Reason for that is that the application does dequeue() from crypto-queues only when new packe

[dpdk-dev] [PATCH v8 05/10] examples/ipsec-secgw: make local variables static

2019-01-10 Thread Konstantin Ananyev
in sp4.c and sp6.c there are few globals that used only locally. Define them as static ones. Cc: sta...@dpdk.org Signed-off-by: Konstantin Ananyev Acked-by: Radu Nicolau Acked-by: Akhil Goyal --- examples/ipsec-secgw/sp4.c | 10 +- examples/ipsec-secgw/sp6.c | 10 +- 2 files c

[dpdk-dev] [PATCH v8 06/10] examples/ipsec-secgw: fix inbound SA checking

2019-01-10 Thread Konstantin Ananyev
In the inbound_sa_check() make sure that sa pointer stored inside mbuf private area is not NULL. Fixes: d299106e8e31 ("examples/ipsec-secgw: add IPsec sample application") Cc: sta...@dpdk.org Signed-off-by: Bernard Iremonger Acked-by: Radu Nicolau Acked-by: Akhil Goyal Signed-off-by: Konstanti

[dpdk-dev] [PATCH v8 01/10] examples/ipsec-secgw: allow user to disable some Rx/Tx offloads

2019-01-10 Thread Konstantin Ananyev
Right now ipsec-secgw always enables TX offloads (DEV_TX_OFFLOAD_MULTI_SEGS, DEV_TX_OFFLOAD_SECURITY), even when they are not requested by the config. That causes many PMD to choose full-featured TX function, which in many cases is much slower then one without offloads. That patch adds ability for

[dpdk-dev] [PATCH v8 04/10] examples/ipsec-secgw: fix outbound codepath for single SA

2019-01-10 Thread Konstantin Ananyev
Looking at process_pkts_outbound_nosp() there seems few issues: - accessing mbuf after it was freed - invoking ipsec_outbound() for ipv4 packets only - copying number of packets, but not the mbuf pointers itself that patch provides fixes for that issues. Fixes: 906257e965b7 ("examples/ipsec-secgw

[dpdk-dev] [PATCH v8 02/10] examples/ipsec-secgw: allow to specify neighbour MAC address

2019-01-10 Thread Konstantin Ananyev
In some cases it is useful to allow user to specify destination ether address for outgoing packets. This patch adds such ability by introducing new 'neigh' config file option. Signed-off-by: Konstantin Ananyev Acked-by: Radu Nicolau Acked-by: Akhil Goyal --- doc/guides/sample_app_ug/ipsec_secg

[dpdk-dev] [PATCH v8 00/10] examples/ipsec-secgw: make app to use ipsec library

2019-01-10 Thread Konstantin Ananyev
This patch series depends on the patch series: ipsec: new library for IPsec data-path processing to be applied first. v7 -> v8 rebase on top of crypto-next check-git-log nit-picks v6 -> v7 Call drain_crypto_queue() for each processed port (reported/suggested by Akhil) Add ixgbe inline-

[dpdk-dev] [PATCH v8 9/9] doc: add IPsec library guide

2019-01-10 Thread Konstantin Ananyev
Add IPsec library guide and update release notes. Signed-off-by: Bernard Iremonger Signed-off-by: Konstantin Ananyev Acked-by: Akhil Goyal --- doc/guides/prog_guide/index.rst| 1 + doc/guides/prog_guide/ipsec_lib.rst| 168 + doc/guides/rel_notes/release_19

[dpdk-dev] [PATCH v8 8/9] test/ipsec: introduce functional test

2019-01-10 Thread Konstantin Ananyev
Create functional test for librte_ipsec. Note that the test requires null crypto pmd to pass successfully. Signed-off-by: Mohammad Abdul Awal Signed-off-by: Bernard Iremonger Signed-off-by: Konstantin Ananyev Acked-by: Declan Doherty Acked-by: Akhil Goyal --- test/test/Makefile |3 +

[dpdk-dev] [PATCH v8 7/9] ipsec: helper functions to group completed crypto-ops

2019-01-10 Thread Konstantin Ananyev
Introduce helper functions to process completed crypto-ops and group related packets by sessions they belong to. Signed-off-by: Konstantin Ananyev Acked-by: Declan Doherty Acked-by: Akhil Goyal --- lib/librte_ipsec/Makefile | 1 + lib/librte_ipsec/meson.build | 2 +-

[dpdk-dev] [PATCH v8 6/9] ipsec: rework SA replay window/SQN for MT environment

2019-01-10 Thread Konstantin Ananyev
With these changes functions: - rte_ipsec_pkt_crypto_prepare - rte_ipsec_pkt_process can be safely used in MT environment, as long as the user can guarantee that they obey multiple readers/single writer model for SQN+replay_window operations. To be more specific: for outbound SA there are

[dpdk-dev] [PATCH v8 3/9] lib: introduce ipsec library

2019-01-10 Thread Konstantin Ananyev
Introduce librte_ipsec library. The library is supposed to utilize existing DPDK crypto-dev and security API to provide application with transparent IPsec processing API. That initial commit provides some base API to manage IPsec Security Association (SA) object. Signed-off-by: Mohammad Abdul Awal

[dpdk-dev] [PATCH v8 4/9] ipsec: add SA data-path API

2019-01-10 Thread Konstantin Ananyev
Introduce Security Association (SA-level) data-path API Operates at SA level, provides functions to: - initialize/teardown SA object - process inbound/outbound ESP/AH packets associated with the given SA (decrypt/encrypt, authenticate, check integrity, add/remove ESP/AH related

[dpdk-dev] [PATCH v8 0/9] ipsec: new library for IPsec data-path processing

2019-01-10 Thread Konstantin Ananyev
v7 -> v8 - update release notes with new version for librte_security - rebase on top of crypto-next v6 -> v7 - Changes to address Thomas comments: bump ABI version remove related deprecation notice update release notes, ABI changes section v5 -> v6 - Fix issues reported by Akhil:

[dpdk-dev] [PATCH v8 1/9] security: add opaque userdata pointer into security session

2019-01-10 Thread Konstantin Ananyev
Add 'uint64_t opaque_data' inside struct rte_security_session. That allows upper layer to easily associate some user defined data with the session. Signed-off-by: Konstantin Ananyev Acked-by: Mohammad Abdul Awal Acked-by: Declan Doherty Acked-by: Akhil Goyal --- doc/guides/rel_notes/deprecati

[dpdk-dev] [PATCH v8 2/9] net: add ESP trailer structure definition

2019-01-10 Thread Konstantin Ananyev
define esp_tail structure. Signed-off-by: Konstantin Ananyev Acked-by: Mohammad Abdul Awal Acked-by: Declan Doherty Acked-by: Akhil Goyal --- lib/librte_net/rte_esp.h | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/lib/librte_net/rte_esp.h b/lib/librte_net/rte_es

[dpdk-dev] [PATCH v8 5/9] ipsec: implement SA data-path API

2019-01-10 Thread Konstantin Ananyev
Provide implementation for rte_ipsec_pkt_crypto_prepare() and rte_ipsec_pkt_process(). Current implementation: - supports ESP protocol tunnel mode. - supports ESP protocol transport mode. - supports ESN and replay window. - supports algorithms: AES-CBC, AES-GCM, HMAC-SHA1, NULL. - covers all c

[dpdk-dev] [PATCH 3/6] test_ring: add non-blocking ring autotest

2019-01-10 Thread Gage Eads
ring_nb_autotest re-uses the ring_autotest code by wrapping its top-level function with one that takes a 'flags' argument. Signed-off-by: Gage Eads --- test/test/test_ring.c | 57 --- 1 file changed, 36 insertions(+), 21 deletions(-) diff --git a/

[dpdk-dev] [PATCH 6/6] doc: add NB ring comment to EAL "known issues"

2019-01-10 Thread Gage Eads
This comment makes users aware of the non-blocking ring option and its caveats. Signed-off-by: Gage Eads --- doc/guides/prog_guide/env_abstraction_layer.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/guides/prog_guide/env_abstraction_layer.rst b/doc/guides/prog_guid

[dpdk-dev] [PATCH 5/6] mempool/ring: add non-blocking ring handlers

2019-01-10 Thread Gage Eads
These handlers allow an application to create a mempool based on the non-blocking ring, with any combination of single/multi producer/consumer. Signed-off-by: Gage Eads --- drivers/mempool/ring/rte_mempool_ring.c | 58 +++-- 1 file changed, 55 insertions(+), 3 deletio

[dpdk-dev] [PATCH 1/6] ring: change head and tail to pointer-width size

2019-01-10 Thread Gage Eads
For 64-bit architectures, doubling the head and tail index widths greatly increases the time it takes for them to wrap-around (with current CPU speeds, it won't happen within the author's lifetime). This is important in avoiding the ABA problem -- in which a thread mistakes reading the same tail in

[dpdk-dev] [PATCH 0/6] Add non-blocking ring

2019-01-10 Thread Gage Eads
For some users, the rte ring's "non-preemptive" constraint is not acceptable; for example, if the application uses a mixture of pinned high-priority threads and multiplexed low-priority threads that share a mempool. This patchset introduces a non-blocking ring, on top of which a mempool can run. C

[dpdk-dev] [PATCH 4/6] test_ring_perf: add non-blocking ring perf test

2019-01-10 Thread Gage Eads
nb_ring_perf_autotest re-uses the ring_perf_autotest code by wrapping its top-level function with one that takes a 'flags' argument. Signed-off-by: Gage Eads --- test/test/test_ring_perf.c | 19 --- 1 file changed, 16 insertions(+), 3 deletions(-) diff --git a/test/test/test_rin

[dpdk-dev] [PATCH 2/6] ring: add a non-blocking implementation

2019-01-10 Thread Gage Eads
This commit adds support for non-blocking circular ring enqueue and dequeue functions. The ring uses a 128-bit compare-and-swap instruction, and thus is limited to x86_64. The algorithm is based on the original rte ring (derived from FreeBSD's bufring.h) and inspired by Michael and Scott's non-blo

[dpdk-dev] [PATCH 3/3] doc: add NB stack comment to EAL "known issues"

2019-01-10 Thread Gage Eads
This comment makes users aware of the non-blocking stack option and its caveats. Signed-off-by: Gage Eads --- doc/guides/prog_guide/env_abstraction_layer.rst | 5 + 1 file changed, 5 insertions(+) diff --git a/doc/guides/prog_guide/env_abstraction_layer.rst b/doc/guides/prog_guide/env_abst

[dpdk-dev] [PATCH 2/3] mempool/nb_stack: add non-blocking stack mempool

2019-01-10 Thread Gage Eads
This commit adds support for non-blocking (linked list based) stack mempool handler. The stack uses a 128-bit compare-and-swap instruction, and thus is limited to x86_64. The 128-bit CAS atomically updates the stack top pointer and a modification counter, which protects against the ABA problem. In

[dpdk-dev] [PATCH 0/3] Add non-blocking stack mempool handler

2019-01-10 Thread Gage Eads
For some users, the rte ring's "non-preemptive" constraint is not acceptable; for example, if the application uses a mixture of pinned high-priority threads and multiplexed low-priority threads that share a mempool. This patchset introduces a non-blocking stack mempool handler. Note that the non-b

[dpdk-dev] [PATCH 1/3] eal: add 128-bit cmpset (x86-64 only)

2019-01-10 Thread Gage Eads
This operation can be used for non-blocking algorithms, such as a non-blocking stack or ring. Signed-off-by: Gage Eads --- .../common/include/arch/x86/rte_atomic_64.h| 22 ++ 1 file changed, 22 insertions(+) diff --git a/lib/librte_eal/common/include/arch/x86/rte_ato

Re: [dpdk-dev] [PATCH v2] net/virtio: add platform memory ordering feature support

2019-01-10 Thread Shahaf Shuler
Wednesday, January 9, 2019 5:50 PM, Michael S. Tsirkin: > alejandro.luc...@netronome.com; Daniel Marcovitch > > Subject: Re: [dpdk-dev] [PATCH v2] net/virtio: add platform memory > ordering feature support > > On Wed, Jan 09, 2019 at 05:34:38PM +0300, Ilya Maximets wrote: > > virtio_mb() is reall

Re: [dpdk-dev] [PATCH v3 2/2] net/mlx5: fix instruction hotspot on replenishing Rx buffer

2019-01-10 Thread Shahaf Shuler
Thursday, January 10, 2019 8:35 PM, Yongseok Koh: > Subject: [dpdk-dev] [PATCH v3 2/2] net/mlx5: fix instruction hotspot on > replenishing Rx buffer > > On replenishing Rx buffers for vectorized Rx, mbuf->buf_addr isn't needed to > be accessed as it is static and easily calculated from the mbuf ad

Re: [dpdk-dev] [PATCH] compressdev: add feature flag to specify where processing is done

2019-01-10 Thread De Lara Guarch, Pablo
Hi Shally, > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Trahe, Fiona > Sent: Wednesday, December 19, 2018 5:10 PM > To: Verma, Shally ; Stephen Hemminger > > Cc: dev@dpdk.org; akhil.go...@nxp.com; Jozwiak, TomaszX > ; Gupta, Ashish ; > Daly, Lee ; Luse, Paul

Re: [dpdk-dev] [PATCH v2] mbuf: fix compile by removing struct from function

2019-01-10 Thread Dumitrescu, Cristian
> -Original Message- > From: Van Haaren, Harry > Sent: Thursday, January 10, 2019 6:07 PM > To: dev@dpdk.org > Cc: Van Haaren, Harry ; Pattan, Reshma > ; Dumitrescu, Cristian > ; tho...@monjalon.net; > olivier.m...@6wind.com > Subject: [PATCH v2] mbuf: fix compile by removing struct from

[dpdk-dev] [PATCH v3] config: add Mellanox BlueField ARMv8 SoC

2019-01-10 Thread Yongseok Koh
BlueField is Mellanox's new SoC based on ARMv8. BlueField integrates Mellanox ConnectX-5 interconnect and Cortex-A72 cores into a single device. http://www.mellanox.com/page/products_dyn?product_family=256&mtag=soc_overview Signed-off-by: Yongseok Koh --- v3: * remove redundant mlx5 config item

[dpdk-dev] [PATCH v3 2/2] net/mlx5: fix instruction hotspot on replenishing Rx buffer

2019-01-10 Thread Yongseok Koh
On replenishing Rx buffers for vectorized Rx, mbuf->buf_addr isn't needed to be accessed as it is static and easily calculated from the mbuf address. Accessing the mbuf content causes unnecessary load stall and it is worsened on ARM. Fixes: 545b884b1da3 ("net/mlx5: fix buffer address posting in SS

[dpdk-dev] [PATCH v3 1/2] mbuf: add function returning default buffer address

2019-01-10 Thread Yongseok Koh
This patch introduces two new functions - rte_mbuf_buf_addr() and rte_mbuf_data_addr_default(). rte_mbuf_buf_addr() reutrns the default buffer address of given mbuf which comes after mbuf structure and private data. rte_mbuf_data_addr_default() returns the default address of mbuf data taking the

Re: [dpdk-dev] [PATCH v2 1/2] mbuf: add function returning default buffer address

2019-01-10 Thread Yongseok Koh
On Jan 9, 2019, at 5:46 AM, David Marchand mailto:david.march...@redhat.com>> wrote: On Wed, Jan 9, 2019 at 2:19 PM Yongseok Koh mailto:ys...@mellanox.com>> wrote: This patch introduces two new functions - rte_mbuf_buf_addr_default() and rte_mbuf_data_baddr_default(). rte_mbuf_buf_addr_defau

Re: [dpdk-dev] [PATCH v2 1/2] mbuf: add function returning default buffer address

2019-01-10 Thread Yongseok Koh
> On Jan 9, 2019, at 5:39 PM, Rami Rosen wrote: > > Hi, Yongseok, > > Maybe you should consider using the pool member of the mbuf, instead of > passing it as a parameter for rte_mbuf_buf_addr_default(). > The pool member of mbuf indicates the pool from which it was allocated. > See > http://g

Re: [dpdk-dev] [PATCH v2] doc: fix MAC address rewrite actions documentation

2019-01-10 Thread Kevin Traynor
On 01/09/2019 11:37 AM, Dekel Peled wrote: > This patch fixes a typo in SET_MAC_DST action description. > It also adds restriction note for set MAC src/dst actions description. > > Fixes: 15dbcdaada77 ("ethdev: add generic MAC address rewrite actions") Cc: sta...@dpdk.org unless there's a reason

[dpdk-dev] [PATCH v2] mbuf: fix compile by removing struct from function

2019-01-10 Thread Harry van Haaren
Although C compilation works with the struct rte_mbuf_sched declared inside the struct rte_mbuf namespace, C++ fails to compile. This fix removes the temporary struct rte_mbuf_sched, instead reading from the mbuf directly for each struct member. As the struct is now not used directly, the C++ comp

Re: [dpdk-dev] [PATCH] mbuf: fix compile by making sched struct visible

2019-01-10 Thread Van Haaren, Harry
> -Original Message- > From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Thursday, January 10, 2019 5:35 PM > To: Van Haaren, Harry > Cc: dev@dpdk.org; Pattan, Reshma ; Dumitrescu, > Cristian ; olivier.m...@6wind.com > Subject: Re: [PATCH] mbuf: fix compile by making sched struct

Re: [dpdk-dev] [PATCH v1] net/i40e: perform basic validation on the VF messages

2019-01-10 Thread Kevin Traynor
On 01/10/2019 12:07 PM, Haiyue Wang wrote: > Do the VF message basic validation such as OPCODE message length check, > some special OPCODE message format check, to protect the i40e PMD from > malicious VF message attack. > > Fixes: 4861cde46116 ("i40e: new poll mode driver") > Missing Cc: sta...

Re: [dpdk-dev] [PATCH v9 1/6] app/procinfo: add support for show port

2019-01-10 Thread Thomas Monjalon
10/01/2019 22:36, Vipin Varghese: > Function show_port is used for displaying the port PMD information under > primary process. The information shows basic, per queue and security. > Also helper MACRO 'MAX_STRING_LEN, STATS_BDR_FMT and STATS_BDR_STR' and > meson build file is updated for new functi

Re: [dpdk-dev] [PATCH] mbuf: fix compile by making sched struct visible

2019-01-10 Thread Thomas Monjalon
10/01/2019 17:50, Harry van Haaren: > Although C compilation works with the struct rte_mbuf_sched > declared inside the struct rte_mbuf namespace, C++ fails to > compile. This fix moves the rte_mbuf_sched struct up to the > global namespace, instead of declaring it inside the struct > mbuf namespac

[dpdk-dev] [PATCH] build: mention -march in pkg-config description

2019-01-10 Thread Luca Boccassi
Applications need to at least match DPDK's -march option to build successfully due to some static inline functions in the public headers. This might cause problems, especially in distributions, so add a note in the pkg-config description. Fixes: a25a650be5f0 ("build: add infrastructure for meson

Re: [dpdk-dev] [PATCH v5 00/12] cryptodev: change qp conf and sym session

2019-01-10 Thread De Lara Guarch, Pablo
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Fan Zhang > Sent: Thursday, January 10, 2019 2:50 PM > To: dev@dpdk.org > Cc: akhil.go...@nxp.com; De Lara Guarch, Pablo > ; Trahe, Fiona > Subject: [dpdk-dev] [PATCH v5 00/12] cryptodev: change qp conf and sym

[dpdk-dev] [PATCH] mbuf: fix compile by making sched struct visible

2019-01-10 Thread Harry van Haaren
Although C compilation works with the struct rte_mbuf_sched declared inside the struct rte_mbuf namespace, C++ fails to compile. This fix moves the rte_mbuf_sched struct up to the global namespace, instead of declaring it inside the struct mbuf namespace. The struct rte_mbuf_sched is being used on

Re: [dpdk-dev] [PATCH v3] doc: add meson build to contributing guide

2019-01-10 Thread Varghese, Vipin
HI Thomas snipped > > > > > > +Compliation of patches has to be tested using meson:: > > > + > > > +./devtools/test-meson-builds.sh > > > + > > > +This will test for shared and static builds. If gcc arm cross > > > +compiler is installed, cross build is tested too. > > > > > > Sending Patches

[dpdk-dev] [PATCH v2] ethdev: support double precision RED queue weight

2019-01-10 Thread Nikhil Rao
RED queue weight is currently specified as a negated log of 2. Add support for RED queue weight to be specified in double precision and TM capability flags for double precision and negated log2 RED queue weight support. Update the softnic PMD and testpmd for the new tm capability flags and the st

[dpdk-dev] [PATCH v2] vfio: don't unregister callback in secondaries

2019-01-10 Thread Anatoly Burakov
Callbacks are only registered in the primary, so do not attempt to unregister callbacks in secondary processes. Fixes: 43e463137154 ("vfio: support memory event callbacks") Cc: sta...@dpdk.org Signed-off-by: Anatoly Burakov --- Notes: v2: - Skip secondaries instead of primaries lib/li

[dpdk-dev] [PATCH] vfio: don't unregister callback in secondaries

2019-01-10 Thread Anatoly Burakov
Callbacks are only registered in the primary, so do not attempt to unregister callbacks in secondary processes. Fixes: 43e463137154 ("vfio: support memory event callbacks") Cc: sta...@dpdk.org Signed-off-by: Anatoly Burakov --- lib/librte_eal/linuxapp/eal/eal_vfio.c | 3 ++- 1 file changed, 2 i

[dpdk-dev] [PATCH 5/5] [pktgen] fix cleanup of not sent packets

2019-01-10 Thread Rafal Kozik
Not sent packets are copied to the beginning of array to be reused in next iteration. But as in some cases more than half of mbuf could not be sent, source and destination locations would overlap. In such case rte_memcpy cannot be used. One of side effects is double sending the same mbuf and as a c

[dpdk-dev] [PATCH 4/5] [pktgen] expose number of missed Rx packets

2019-01-10 Thread Rafal Kozik
Expose number of missed Rx packets from DPDK NIC statistics to Lua API. Signed-off-by: Rafal Kozik --- app/lpktgenlib.c | 1 + 1 file changed, 1 insertion(+) diff --git a/app/lpktgenlib.c b/app/lpktgenlib.c index 9a6307c..e9c7241 100644 --- a/app/lpktgenlib.c +++ b/app/lpktgenlib.c @@ -2888,6 +

[dpdk-dev] [PATCH 3/5] [pktgen] use constants for PCAP creation

2019-01-10 Thread Rafal Kozik
Instead of magic number and DPDK constants use, constants defined in PKTGEN. It allows to easily adjust packets size for users needs. For example jumbo packets could be supported by just increasing DEFAULT_MBUF_SIZE and MAX_PKT_SIZE. Signed-off-by: Rafal Kozik --- app/pktgen-pcap.c | 22

[dpdk-dev] [PATCH 2/5] [pktgen] different PCAP per each queue

2019-01-10 Thread Rafal Kozik
In some test scenario it is necessary to configure different flow per each Tx queue. This patch adds possibility to provide list of PCAPs files. If number of files is smaller than number of queues, first PCAP file is used for the queues which number is above the number of files. To achieve uniform

[dpdk-dev] [PATCH 0/5][pktgen] fixes and minor features

2019-01-10 Thread Rafal Kozik
Hello Keith, This patch set contain two fixes for issues that were noticed when running DPDK in debug configuration. There are also three minor features that may be useful. Those patches are independent from each other. I am kindly asking, if those changes are appropriate to be merged to Pktgen?

[dpdk-dev] [PATCH 1/5] [pktgen] fix race condition in start

2019-01-10 Thread Rafal Kozik
Flag SENDING_PACKETS must be set last. When it is set before SEND_FOREVER flag, Tx lcores start to call pktgen_send_pkts. But as current_tx_count is 0 and SEND_FOREVER is not yet set, SENDING_PACKETS will be cleared. This causes in some cases that start command will no take effect. Fixes: f5f901fd

[dpdk-dev] [PATCH v9 6/6] app/procinfo: add support for iter mempool

2019-01-10 Thread Vipin Varghese
Function iter_mempool is used for iterating slected mempool elements and display the contents of elements for a max of 256 bytes. In case of invalid or no name for mempool, no information is displayed. Signed-off-by: Vipin Varghese Acked-by: Reshma Pattan Acked-by: John McNamara --- app/proc-

[dpdk-dev] [PATCH v9 5/6] app/procinfo: add support for show mempool

2019-01-10 Thread Vipin Varghese
Function show_mempool is used for displaying valid MEMPOOL. In case of invalid or no name, whole list is dump. Signed-off-by: Vipin Varghese Acked-by: Reshma Pattan Acked-by: John McNamara --- app/proc-info/main.c | 65 +- doc/guides/tools/proc_info.r

[dpdk-dev] [PATCH v9 4/6] app/procinfo: add support for debug ring

2019-01-10 Thread Vipin Varghese
Function show_ring is used for displaying information of RING instance of the primary process. Signed-off-by: Vipin Varghese Acked-by: Reshma Pattan Acked-by: John McNamara --- app/proc-info/main.c | 52 +- doc/guides/tools/proc_info.rst | 8 +-

[dpdk-dev] [PATCH v9 3/6] app/procinfo: add support for show crypto

2019-01-10 Thread Vipin Varghese
Function show_crypto is used for displaying the crypto PMD under primary process. Signed-off-by: Vipin Varghese Acked-by: Reshma Pattan Acked-by: John McNamara --- app/proc-info/main.c | 94 +- doc/guides/tools/proc_info.rst | 6 ++- 2 files changed,

[dpdk-dev] [PATCH v9 2/6] app/procinfo: add support for show tm

2019-01-10 Thread Vipin Varghese
Function show_tm is used for displaying the tm PMD under the primary process. This covers basic and per node|level details with statistics. Signed-off-by: Vipin Varghese Acked-by: Reshma Pattan Acked-by: John McNamara --- app/proc-info/main.c | 290 -

[dpdk-dev] [PATCH v9 1/6] app/procinfo: add support for show port

2019-01-10 Thread Vipin Varghese
Function show_port is used for displaying the port PMD information under primary process. The information shows basic, per queue and security. Also helper MACRO 'MAX_STRING_LEN, STATS_BDR_FMT and STATS_BDR_STR' and meson build file is updated for new functionality. Signed-off-by: Vipin Varghese A

[dpdk-dev] [PATCH v9 0/6] app/proc-info: enhance debug of proc-info tool

2019-01-10 Thread Vipin Varghese
This patch adds new debug functions to existing proc-info tool. Motivation == DPDK proc-info tool is been widely used as secondary process to collect stats for any primary process. But these are limited to DPDK NIC ports and basic memory usage. The patch series tries to address the missi

Re: [dpdk-dev] [PATCH v7 00/10] examples/ipsec-secgw: make app to use ipsec library

2019-01-10 Thread Akhil Goyal
On 1/9/2019 5:14 PM, Konstantin Ananyev wrote: > This patch series depends on the patch series: > > ipsec: new library for IPsec data-path processing > http://patches.dpdk.org/patch/49410/ > http://patches.dpdk.org/patch/49411/ > http://patches.dpdk.org/patch/49412/ > http://patches.dpdk.org/patc

Re: [dpdk-dev] [PATCH v3 0/3] Missing barriers and VIRTIO_F_ORDER_PLATFORM.

2019-01-10 Thread Maxime Coquelin
On 1/9/19 3:55 PM, Michael S. Tsirkin wrote: On Wed, Jan 09, 2019 at 05:50:12PM +0300, Ilya Maximets wrote: Version 3: * Added 2 patches with fixes for current virtio driver. Not directly connected with the new feature. New version shouldn't be reply-to old one really :). But the pa

Re: [dpdk-dev] [PATCH] examples/vhost: remove unnecessary method and constant

2019-01-10 Thread Maxime Coquelin
On 1/9/19 3:57 PM, Rami Rosen wrote: This cleanup patch removes a method and a constant which are now unnecessary in the VHOST sample applicaiopn, namely the validate_num_devices() method and the MAX_DEVICES constant. Fixes: 56fe86f8dcaf ("examples/vhost: embed statistics into device structu

  1   2   3   >