[dpdk-dev] [PATCH v5] lib/efd: fix to free tail queue entry after use

2019-01-17 Thread Hari Kumar Vemula
In rte_efd_create() allocated memory for tail queue entry but not freed. Added freeing the tail queue entry. Fixes: 56b6ef874f80 ("efd: new Elastic Flow Distributor library") Cc: sta...@dpdk.org Signed-off-by: Hari Kumar Vemula Reviewed-by: Honnappa Nagarahalli Acked-by: Reshma Pattan Acked-by

[dpdk-dev] [PATCH v2] raw/ifpga: fix a memory leak bug in /driver/raw/ifpga_rawdev

2019-01-17 Thread Andy Pei
When ifpga_rawdev_create() allocate memory for a new rawdev, the original code allocate redundant memory for adapter, which is a member of the rawdev. What is actually necessary is the adapter to be initialized, not memory allocated. Fixes: ef1e8ede3da5 ("raw/ifpga: add Intel FPGA bus rawdev drive

Re: [dpdk-dev] [RFC v2 2/2] test/rcu_qsbr: add API and functional tests

2019-01-17 Thread Honnappa Nagarahalli
> > On Sat, Dec 22, 2018 at 11:30:51PM -0800, Stephen Hemminger wrote: > > On Fri, 21 Dec 2018 20:14:20 -0600 > > Honnappa Nagarahalli wrote: > > > > > From: Dharmik Thakkar > > > > > > Add API positive/negative test cases and functional tests. > > > > > > Signed-off-by: Malvika Gupta > > > Sig

[dpdk-dev] [PATCH] doc: update recommended versions for i40e

2019-01-17 Thread Lijuan Tu
add recommended DPDK/kernel driver/firmware version matching list for i40e for 19.02 Signed-off-by: Lijuan Tu --- doc/guides/nics/i40e.rst | 6 ++ 1 file changed, 6 insertions(+) diff --git a/doc/guides/nics/i40e.rst b/doc/guides/nics/i40e.rst index 6aceb53..53bc024 100644 --- a/doc/guides/

[dpdk-dev] [PATCH] doc: add tested Intel platforms with Intel NICs

2019-01-17 Thread Lijuan Tu
Add tested Intel platforms with Intel NICs to v19.02 release note. Signed-off-by: Lijuan Tu --- doc/guides/rel_notes/release_19_02.rst | 74 ++ 1 file changed, 74 insertions(+) diff --git a/doc/guides/rel_notes/release_19_02.rst b/doc/guides/rel_notes/release_19

Re: [dpdk-dev] [RFC v2 1/2] rcu: add RCU library supporting QSBR mechanism

2019-01-17 Thread Honnappa Nagarahalli
> > > > ... > > > > > > > diff --git a/lib/librte_rcu/rte_rcu_qsbr.h > > > > b/lib/librte_rcu/rte_rcu_qsbr.h new file mode 100644 index > > > > 0..c818e77fd > > > > --- /dev/null > > > > +++ b/lib/librte_rcu/rte_rcu_qsbr.h > > > > @@ -0,0 +1,321 @@ > > > > +/* SPDX-License-Identifier: BSD-

Re: [dpdk-dev] DSW eventdev and multi-process DPDK

2019-01-17 Thread Venky Venkatesh
On 1/17/19, 11:10 AM, "Venky Venkatesh" wrote: On 1/7/19, 7:36 AM, "Mattias Rönnblom" wrote: On 2018-12-21 20:12, Venky Venkatesh wrote: > > > On 12/21/18, 10:59 AM, "Mattias Rönnblom" wrote: > > On 2018-12-21 19:3

Re: [dpdk-dev] [EXT] Default cacheline size for ARM

2019-01-17 Thread Honnappa Nagarahalli
> > > > > > > Hi, > > > > > > > > > > > > > > The cacheline size (RTE_CACHE_LINE_SIZE) for ARM CPUs is set > > > > > > > to be 128B by default. Mellanox's BlueField is an ARM CPU > > > > > > > having > > > > > > > Cortex-A72 > > > > > > > and its CL size is 64B. > > > > > Just wondering how many de

Re: [dpdk-dev] [PATCH v3 1/2] eal: add 128-bit cmpset (x86-64 only)

2019-01-17 Thread Honnappa Nagarahalli
> > > > > > This operation can be used for non-blocking algorithms, such as a > > > non- blocking stack or ring. > > > > > > Signed-off-by: Gage Eads > > > --- > > > .../common/include/arch/x86/rte_atomic_64.h| 22 > > > ++ > > > 1 file changed, 22 insertions(+) > > >

Re: [dpdk-dev] [PATCH v4 2/2] mempool/nb_stack: add non-blocking stack mempool

2019-01-17 Thread Honnappa Nagarahalli
Hi Gage, Thank you for your contribution on non-blocking data structures. I think they are important to extend DPDK into additional use cases. I am wondering if it makes sense to decouple the NB stack data structure from mempool driver (similar to rte_ring)? I see that stack based mempool i

Re: [dpdk-dev] [PATCH v2] devtools: fix error propagation from check-forbidden-tokens.awk

2019-01-17 Thread Ajit Khaparde
On Thu, Jan 17, 2019 at 1:47 PM Thomas Monjalon wrote: > 17/01/2019 22:34, Ajit Khaparde: > > On Thu, Jan 17, 2019 at 9:26 AM David Marchand < > david.march...@redhat.com> > > wrote: > > > > > On Thu, Jan 17, 2019 at 4:33 PM Thomas Monjalon > > > wrote: > > > > > >> 17/01/2019 13:20, David March

[dpdk-dev] [Bug 192] construct function miss for build with static library

2019-01-17 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=192 Bug ID: 192 Summary: construct function miss for build with static library Product: DPDK Version: 18.11 Hardware: All OS: All Status: CONFIRMED Severity: normal

Re: [dpdk-dev] [PATCH] doc: fix an error in ifc NIC document

2019-01-17 Thread Wang, Xiao W
Hi, > -Original Message- > From: Rami Rosen [mailto:ramir...@gmail.com] > Sent: Thursday, January 17, 2019 10:51 PM > To: dev@dpdk.org > Cc: sta...@dpdk.org; Wang, Xiao W ; Rami Rosen > > Subject: [PATCH] doc: fix an error in ifc NIC document > > This patch fixes an error in ifc NIC docu

Re: [dpdk-dev] [PATCH v14 0/4] add unit tests for bitrate, latency and pdump libraries

2019-01-17 Thread Thomas Monjalon
08/10/2018 14:12, Naga Suresh Somarowthu: > 1/4: add helper functions for tests using ring-PMD Rx/Tx > 2/4: unit test cases added for bitrate library > 3/4: unit test cases added for latencystats library > 4/4: unit test cases added for pdump library > > Patches 2/4, 3/4 and 4/4 depends on 1/4 >

Re: [dpdk-dev] [PATCH v5 0/5] create different meson test targets

2019-01-17 Thread Thomas Monjalon
25/10/2018 08:49, Hari Kumar Vemula: > From: Hari Kumar Vemula > > 1/5: remove existing test cases to reorganize further > 2/5: add fast-tests suite to meson targets > 3/5: add perf-tests suite to meson targets > 4/5: add driver-tests suite to meson targets > 5/5: add debug-tests suite to meson t

Re: [dpdk-dev] [PATCH v5 0/3] Compression Unit Tests

2019-01-17 Thread Thomas Monjalon
17/01/2019 11:19, Kovacevic, Marko: > Made changes to the two unit tests for the out of space i have added > proper checkes for all the cases compressing with compress dev and > decompressing with compress dev. > > Varied buffer patch i have removed the extra unit test and merged it > into the sgl

Re: [dpdk-dev] [PATCH v3] test/ipsec: fix test suite setup function

2019-01-17 Thread Thomas Monjalon
> > Check for valid crypto_null device before continuing. > > Use valid_dev instead of valid_devs[]. > > Replace valid_dev_count with valid_dev_found > > Call create_crypto_session for one driver only. > > Refactor code so that driver capabilities can be checked in > > the testsuite_setup function.

Re: [dpdk-dev] [PATCH] test/ipsec: fix compile error on BSD

2019-01-17 Thread Thomas Monjalon
> > Removed ip.h and in.h headers to fix unknown type errors > > when compiling on BSD. > > > > Fixes: 05fe65eb66b2 ("test/ipsec: introduce functional test") > > Signed-off-by: Bernard Iremonger > > Acked-by: Konstantin Ananyev Applied, thanks

Re: [dpdk-dev] [PATCH] test: fix build when disabling ipsec library

2019-01-17 Thread Thomas Monjalon
17/01/2019 13:20, Ananyev, Konstantin: > From: David Marchand [mailto:david.march...@redhat.com] > > > > Caught after pulling ipsec then compile in an existing build directory. > > > > Fixes: 05fe65eb66b2 ("test/ipsec: introduce functional test") > > Signed-off-by: David Marchand > > --- > > Did

Re: [dpdk-dev] [PATCH] examples/fips_validation: fix session private mempool

2019-01-17 Thread Thomas Monjalon
> > This patch fixes the incorrect session private mempool passing to cryptodev. > > > > Fixes: 41d561cbdd24 ("examples/fips_validation: add power on self test") > > > > Signed-off-by: Fan Zhang > > Acked-by: Pablo de Lara Applied, thanks

Re: [dpdk-dev] [PATCH v3 1/2] eal: add 128-bit cmpset (x86-64 only)

2019-01-17 Thread Eads, Gage
> -Original Message- > From: Honnappa Nagarahalli [mailto:honnappa.nagaraha...@arm.com] > Sent: Thursday, January 17, 2019 9:45 AM > To: Eads, Gage ; dev@dpdk.org > Cc: olivier.m...@6wind.com; arybche...@solarflare.com; Richardson, Bruce > ; Ananyev, Konstantin > ; nd ; Honnappa Nagaraha

Re: [dpdk-dev] [PATCH] examples/ip_fragmentation: fix fail to start on i40e

2019-01-17 Thread Thomas Monjalon
16/01/2019 13:55, Konstantin Ananyev: > Previous commit sets mtu to the same value as max_rx_pkt_len. > Though PMDs (at least Intel ones) consider MTU as > max_rx_pkt_len minus ether header, crc bytes, vlan tags. > > Fixes: 73d2c1d3f33c ("examples/ip_fragmentation: support big packets") > Signed-o

Re: [dpdk-dev] [PATCH] examples/kni: fix crash while handling userspace request

2019-01-17 Thread Thomas Monjalon
> > When KNI interface receives RTE_KNI_REQ_CFG_NETWORK_IF request, it > > stap/start the physical device which as a result of stop() can free all the > > mbufs in > > its queue. > > Meanwhile sample application continues to read from KNI interface queues and > > push into device queues. This simu

Re: [dpdk-dev] [PATCH] crypto/aesni_mb: fix compile

2019-01-17 Thread Thomas Monjalon
16/01/2019 14:21, Fan Zhang: > This patch fixes the inflexible compile issue AESNI-MB PMD. > Originally the compile of the PMD will fail if IPSec_MB is > not installed in default location. > > Fixes: c68d7aa354f6 ("crypto/aesni_mb: use architecture independent macros") > > Signed-off-by: Fan Zhan

Re: [dpdk-dev] [PATCH v6] doc: add GRO limitations in prog_guide

2019-01-17 Thread Thomas Monjalon
16/01/2019 10:50, Ananyev, Konstantin: > From: Hu, Jiayu > > > > This patch adds GRO limitations in the programmer guide. > > > > Fixes: 2c900d09055e ("doc: add GRO guide") > > Cc: sta...@dpdk.org > > > > Signed-off-by: Jiayu Hu > > --- > > changes in v6: > > - add VLAN limitation > > changes i

Re: [dpdk-dev] [dpdk-stable] [PATCH v6] doc: add GRO limitations in prog_guide

2019-01-17 Thread Thomas Monjalon
17/01/2019 14:55, Kovacevic, Marko: > > +GRO Library Limitations > > +--- > > + > > +- GRO library uses MBUF->l2_len/l3_len/l4_len/outer_l2_len/ > > + outer_l3_len/packet_type to get protocol headers for the > > + input packet, rather than parsing the packet header. Therefore,

Re: [dpdk-dev] [PATCH v2] devtools: fix error propagation from check-forbidden-tokens.awk

2019-01-17 Thread Thomas Monjalon
17/01/2019 22:34, Ajit Khaparde: > On Thu, Jan 17, 2019 at 9:26 AM David Marchand > wrote: > > > On Thu, Jan 17, 2019 at 4:33 PM Thomas Monjalon > > wrote: > > > >> 17/01/2019 13:20, David Marchand: > >> > On Fri, Dec 21, 2018 at 2:00 AM Thomas Monjalon > >> wrote: > >> > > >> > > 18/12/2018 16

Re: [dpdk-dev] [PATCH v3] gro: add missing invalid TCP header length check

2019-01-17 Thread Thomas Monjalon
16/01/2019 10:49, Ananyev, Konstantin: > From: Hu, Jiayu > > > > When the TCP header length of input packets is invalid (i.e., less > > than 20 bytes or greater than 60 bytes), check_seq_option() will > > access illegal memory area when compare TCP Options, which may > > cause a segmentation fault

Re: [dpdk-dev] [PATCH v2] devtools: fix error propagation from check-forbidden-tokens.awk

2019-01-17 Thread Ajit Khaparde
On Thu, Jan 17, 2019 at 9:26 AM David Marchand wrote: > On Thu, Jan 17, 2019 at 4:33 PM Thomas Monjalon > wrote: > >> 17/01/2019 13:20, David Marchand: >> > On Fri, Dec 21, 2018 at 2:00 AM Thomas Monjalon >> wrote: >> > >> > > 18/12/2018 16:19, Arnon Warshavsky: >> > > > Bugzilla ID: 165 >> > >

[dpdk-dev] [PATCH] compress/isal: fix build with old library version

2019-01-17 Thread Lee Daly
This patch removes an unnecessary flag which was breaking the build with older versions of the ISA-L library (v2.23 and older) and replace with a more appropriate flag which is present in older versions of library. Fixes: bd03d3f1e4f1 ("compress/isal: enable checksum support") Signed-off-by: Lee

Re: [dpdk-dev] [PATCH v2 2/2] mempool/nb_stack: add non-blocking stack mempool

2019-01-17 Thread Eads, Gage
> -Original Message- > From: Gavin Hu (Arm Technology China) [mailto:gavin...@arm.com] > Sent: Thursday, January 17, 2019 9:42 AM > To: Eads, Gage ; Richardson, Bruce > > Cc: dev@dpdk.org; olivier.m...@6wind.com; arybche...@solarflare.com; > Ananyev, Konstantin ; Honnappa Nagarahalli >

Re: [dpdk-dev] [PATCH v4] pdump: fix vdev cleanup

2019-01-17 Thread Thomas Monjalon
15/01/2019 15:57, Ferruh Yigit: > On 1/15/2019 1:45 PM, Reshma Pattan wrote: > > Virtual devices added in pdump application > > using rte_eal_hotplug_add should be removed explicitly > > while exiting the pdump application, otherwise the > > subsequent run of the pdump application will fail with th

Re: [dpdk-dev] [PATCH v3] pdump: fix vdev cleanup

2019-01-17 Thread Thomas Monjalon
15/01/2019 11:25, Pattan, Reshma: > From: Thomas Monjalon [mailto:tho...@monjalon.net] > > 15/01/2019 11:09, Pattan, Reshma: > > > From: Thomas Monjalon [mailto:tho...@monjalon.net] > > > > 11/01/2019 18:51, Reshma Pattan: > > > > > Virtual devices added in pdump application using > > > > > rte_eal

Re: [dpdk-dev] DSW eventdev and multi-process DPDK

2019-01-17 Thread Venky Venkatesh
On 1/7/19, 7:36 AM, "Mattias Rönnblom" wrote: On 2018-12-21 20:12, Venky Venkatesh wrote: > > > On 12/21/18, 10:59 AM, "Mattias Rönnblom" wrote: > > On 2018-12-21 19:34, Venky Venkatesh wrote: > > > > > > On 12/21/18, 10:24 AM, "Matt

Re: [dpdk-dev] [PATCH] doc/power: fix references in power management

2019-01-17 Thread Thomas Monjalon
15/01/2019 14:38, David Hunt: > In the References section in the Power Management overview, > both links pointed to the same l3fwd-power app. Fix the links > so that one points to l3fwd-power, and the other points to > the vm_power_manager sample app. > > Signed-off-by: David Hunt > --- > doc/gu

Re: [dpdk-dev] DPDK techboard minutes for 19th of December

2019-01-17 Thread Luca Boccassi
On Thu, 2019-01-17 at 09:49 -0800, Stephen Hemminger wrote: > Meeting notes for the DPDK technical board meeting held on 2019-12-19 > Sorry for the belated minutes, but the puppy hair killed my desktop > ;-) > > Attendees: 6/9 > - Thomas Monjalon > - Bruce Richardson > - Ferruh Y

[dpdk-dev] [PATCH] doc/qat: add GCM AAD limitation

2019-01-17 Thread Fiona Trahe
Add limitation that AAD buffer must be padded with zeroes in GCM case. Fixes: d4f44265a1d7 ("doc: add limitation of AAD size to QAT guide") Cc: sta...@dpdk.org Signed-off-by: Fiona Trahe --- doc/guides/cryptodevs/qat.rst |3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a

Re: [dpdk-dev] [PATCH] meson: fix compilation with binutils version 2.30

2019-01-17 Thread Thomas Monjalon
17/01/2019 18:23, Ferruh Yigit: > On 1/17/2019 5:17 PM, Harry van Haaren wrote: > > This commit reworks the checks for binutils 2.30 and how > > the flags to disable AVX512F are passed to the compiler. > > > > Previously the #define for including AVX512 code was set, > > while the -mno-avx512f arg

Re: [dpdk-dev] [PATCH] meson: fix compilation with binutils version 2.30

2019-01-17 Thread Van Haaren, Harry
> -Original Message- > From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Thursday, January 17, 2019 5:56 PM > To: Van Haaren, Harry > Cc: dev@dpdk.org; Yigit, Ferruh ; Richardson, Bruce > > Subject: Re: [dpdk-dev] [PATCH] meson: fix compilation with binutils version > 2.30 > > 1

Re: [dpdk-dev] [PATCH] meson: fix compilation with binutils version 2.30

2019-01-17 Thread Thomas Monjalon
17/01/2019 18:17, Harry van Haaren: > +# get binutils version for the workaround of Bug 97 > +ldver = run_command('ld', '-v').stdout().strip() > +if ldver.contains('2.30') > + if cc.has_argument('-mno-avx512f') > + march_opt += '-mno-avx512f' > + message('Binutils 2.30 d

[dpdk-dev] DPDK techboard minutes for 19th of December

2019-01-17 Thread Stephen Hemminger
Meeting notes for the DPDK technical board meeting held on 2019-12-19 Sorry for the belated minutes, but the puppy hair killed my desktop ;-) Attendees: 6/9 - Thomas Monjalon - Bruce Richardson - Ferruh Yigit - Maxime Coquelin - Olivier Matz - Stephe

Re: [dpdk-dev] [PATCH] SDK: Add scripts to initialize DPDK runtime

2019-01-17 Thread Stephen Hemminger
On Tue, 13 Dec 2016 16:19:00 +0100 Christian Ehrhardt wrote: > Stefans mail got rejected by moderator (??!), reposting FYI as I'm > subscribed and should autopass the moderation. > > On Tue, Dec 13, 2016 at 3:45 PM, Stefan Bader > wrote: > > > On 13.12.2016 08:00, Christian Ehrhardt wrote: >

Re: [dpdk-dev] [PATCH] eal: fix out of bound access when no cpu is available

2019-01-17 Thread Thomas Monjalon
17/01/2019 18:17, David Marchand: > On Thu, Jan 17, 2019 at 5:34 PM Thomas Monjalon wrote: > > > 17/01/2019 14:12, David Marchand: > > > In the unlikely case when the dpdk application is started with no cpu > > > available in the [0, RTE_MAX_LCORE - 1] range, the master_lcore is > > > automatical

[dpdk-dev] [PATCH v2] compressdev: add feature flag to specify where processing is done

2019-01-17 Thread Fiona Trahe
A new device feature flag, RTE_COMPDEV_FF_OP_DONE_IN_DEQUEUE is added. A PMD should set this if the bulk of the processing is done during the dequeue. It should leave it cleared if the bulk of the processing is done during the enqueue (default). Applications can use this as a hint for tuning. Sign

[dpdk-dev] [PATCH] vfio: allow secondary process to query IOMMU type

2019-01-17 Thread Anatoly Burakov
It is only possible to know IOMMU type of a given VFIO container by attempting to initialize it. Since secondary process never attempts to set up VFIO container itself (because they're shared between primary and secondary), it never knows which IOMMU type the container is using, and never sets up t

[dpdk-dev] [PATCH v3] eal: support strlcat function

2019-01-17 Thread Bruce Richardson
Add the strlcat function to DPDK to exist alongside the strlcpy one. While strncat is generally safe for use for concatenation, the API for the strlcat function is perhaps a little nicer to use, and supports truncation detection. See commit 5364de644a4b ("eal: support strlcpy function") for more d

Re: [dpdk-dev] [PATCH] libs/power: fix the resource leaking issue

2019-01-17 Thread Thomas Monjalon
15/01/2019 11:01, David Hunt: > From: Liang Ma > > Fixes: e6c6dc0f96c8 ("power: add p-state driver compatibility") > Coverity issue: 328528 > > v2: focus just on the resource leak. Remove additional code around > Turbo Boost frequency handling. > > Signed-off-by: Liang Ma > Reviewed-by: Le

Re: [dpdk-dev] [PATCH v2] devtools: fix error propagation from check-forbidden-tokens.awk

2019-01-17 Thread David Marchand
On Thu, Jan 17, 2019 at 4:33 PM Thomas Monjalon wrote: > 17/01/2019 13:20, David Marchand: > > On Fri, Dec 21, 2018 at 2:00 AM Thomas Monjalon > wrote: > > > > > 18/12/2018 16:19, Arnon Warshavsky: > > > > Bugzilla ID: 165 > > > > > > > Thomas, > > > > I just noticed that the bz is still opened.

Re: [dpdk-dev] [PATCH] meson: fix compilation with binutils version 2.30

2019-01-17 Thread Ferruh Yigit
On 1/17/2019 5:17 PM, Harry van Haaren wrote: > This commit reworks the checks for binutils 2.30 and how > the flags to disable AVX512F are passed to the compiler. > > Previously the #define for including AVX512 code was set, > while the -mno-avx512f argument was given to the compiler. > This woul

Re: [dpdk-dev] [PATCH v2] SDK: Add scripts to initialize DPDK runtime

2019-01-17 Thread Ferruh Yigit
On 12/19/2016 2:15 PM, thomas.monjalon at 6wind.com (Thomas Monjalon) wrote: > Thanks for sending your Debian/Ubuntu work. > > 2016-12-13 16:47, Luca Boccassi: >> From: Christian Ehrhardt >> >> A tools/init directory is added with dpdk-init, a script that can be >> used to initialize a DPDK runti

Re: [dpdk-dev] [PATCH v2 01/13] EAL: count nr_overcommit_hugepages as available

2019-01-17 Thread Ferruh Yigit
On 5/4/2017 7:43 PM, mirq-linux at rere.qmqm.pl (Michał Mirosław) wrote: > On Sun, Apr 30, 2017 at 05:53:55PM +0200, Thomas Monjalon wrote: >> 13/12/2016 02:28, Micha? Miros?aw: >>> Signed-off-by: Micha? Miros?aw >>> --- >>> lib/librte_eal/linuxapp/eal/eal_hugepage_info.c | 43 >>> ++

Re: [dpdk-dev] [PATCH] eal: fix out of bound access when no cpu is available

2019-01-17 Thread David Marchand
On Thu, Jan 17, 2019 at 5:34 PM Thomas Monjalon wrote: > 17/01/2019 14:12, David Marchand: > > In the unlikely case when the dpdk application is started with no cpu > > available in the [0, RTE_MAX_LCORE - 1] range, the master_lcore is > > automatically chosen as RTE_MAX_LCORE which triggers an o

[dpdk-dev] [PATCH] meson: fix compilation with binutils version 2.30

2019-01-17 Thread Harry van Haaren
This commit reworks the checks for binutils 2.30 and how the flags to disable AVX512F are passed to the compiler. Previously the #define for including AVX512 code was set, while the -mno-avx512f argument was given to the compiler. This would cause gcc to correctly refuse to emit AVX512 instruction

Re: [dpdk-dev] [PATCH 1/2] doc: remove chkincs reference

2019-01-17 Thread Ferruh Yigit
On 12/6/2016 11:42 AM, john.mcnamara at intel.com (Mcnamara, John) wrote: >> -Original Message- >> From: Baruch Siach [mailto:baruch at tkos.co.il] >> Sent: Tuesday, December 6, 2016 11:02 AM >> To: dev at dpdk.org >> Cc: Mcnamara, John ; Baruch Siach >> >> Subject: [PATCH 1/2] doc: remove

Re: [dpdk-dev] [PATCH v3] ethdev: report error on name truncation

2019-01-17 Thread Ferruh Yigit
On 1/17/2019 3:38 PM, Thomas Monjalon wrote: > 17/01/2019 15:13, Nithin Kumar Dabilpuram: >> Currently this api doesn't report error if name is >> truncated and so user is not sure about uniqueness >> of name. This change reports error to help user. >> >> Signed-off-by: Nithin Dabilpuram >> --- >>

Re: [dpdk-dev] [PATCH v3] test/ipsec: fix test suite setup function

2019-01-17 Thread Ananyev, Konstantin
> -Original Message- > From: Iremonger, Bernard > Sent: Thursday, January 17, 2019 4:04 PM > To: dev@dpdk.org; Ananyev, Konstantin > Cc: Iremonger, Bernard > Subject: [PATCH v3] test/ipsec: fix test suite setup function > > Check for valid crypto_null device before continuing. > Use v

Re: [dpdk-dev] [PATCH v2] eal: support strlcat function

2019-01-17 Thread Pattan, Reshma
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Bruce Richardson > 3f091ab92..3bd8ed5d8 100644 > --- a/test/test/test_string_fns.c > +++ b/test/test/test_string_fns.c > @@ -129,11 +129,56 @@ test_rte_strsplit(void) > return 0; > } > > +int > +test_rte_

Re: [dpdk-dev] [PATCH] doc: remove file listings

2019-01-17 Thread Thomas Monjalon
17/01/2019 17:53, Kovacevic, Marko: > Sorry for not making it clearer, > So if someone was reading it and saw this line > > "The examples directory contains sample applications that show how libraries > can be used" > > It would be nice to have a link to the sample applications in the docs like

Re: [dpdk-dev] [dpdk-stable] [PATCH V2] doc: add missing loopback option in testpmd guide

2019-01-17 Thread Ferruh Yigit
On 1/17/2019 1:24 PM, Iremonger, Bernard wrote: >> -Original Message- >> From: Rami Rosen [mailto:ramir...@gmail.com] >> Sent: Thursday, January 17, 2019 11:39 AM >> To: dev@dpdk.org >> Cc: sta...@dpdk.org; Mcnamara, John ; >> Iremonger, Bernard ; Rami Rosen >> >> Subject: [PATCH V2] doc:

Re: [dpdk-dev] [PATCH] eal: fix clang build with intrinsics forced

2019-01-17 Thread Thomas Monjalon
15/01/2019 12:29, Ilya Maximets: > This fixes x86_64-native-linuxapp-clang build with > CONFIG_RTE_FORCE_INTRINSICS=y: > > include/generic/rte_atomic.h:218:9: error: > implicit declaration of function '__atomic_exchange_2' > is invalid in C99 [-Werror,-Wimplicit-function-declar

Re: [dpdk-dev] [PATCH] doc: remove file listings

2019-01-17 Thread Kovacevic, Marko
Sorry for not making it clearer, So if someone was reading it and saw this line "The examples directory contains sample applications that show how libraries can be used" It would be nice to have a link to the sample applications in the docs like so, which has all the Info that was deleted.

Re: [dpdk-dev] [PATCH v2] eal: support strlcat function

2019-01-17 Thread Ferruh Yigit
On 1/17/2019 4:30 PM, Bruce Richardson wrote: > Add the strlcat function to DPDK to exist alongside the strlcpy one. > While strncat is generally safe for use for concatenation, the API for the > strlcat function is perhaps a little nicer to use, and supports truncation > detection. > > See commit

Re: [dpdk-dev] [PATCH] drivers: fix to replace strcat with strncat

2019-01-17 Thread Thomas Monjalon
14/01/2019 17:24, Stephen Hemminger: > On Mon, 14 Jan 2019 13:29:38 + > Ferruh Yigit wrote: > > > On 1/14/2019 6:04 AM, Chaitanya Babu Talluri wrote: > > > Strcat does not check the destination length and there might be > > > chances of string overflow so insted of strcat, strncat is used. >

Re: [dpdk-dev] [PATCH] eal: check string parameter lengths

2019-01-17 Thread Thomas Monjalon
16/01/2019 13:12, Anatoly Burakov: > When specifying parameters such as hugefile prefix from the > command-line, it is possibly to supply an empty string. This may > lead to various problems: for example, if hugefile prefix is > empty, the runtime config path construction may end up > looking like

Re: [dpdk-dev] [PATCH v4] lib/efd: fix to free tail queue entry after use

2019-01-17 Thread De Lara Guarch, Pablo
Hi, > -Original Message- > From: Vemula, Hari KumarX > Sent: Thursday, January 17, 2019 1:37 PM > To: dev@dpdk.org > Cc: Marohn, Byron ; Pattan, Reshma > ; De Lara Guarch, Pablo > ; Parthasarathy, JananeeX M > ; Vemula, Hari KumarX > ; sta...@dpdk.org > Subject: [PATCH v4] lib/efd: fix to

Re: [dpdk-dev] [PATCH] eal: fix out of bound access when no cpu is available

2019-01-17 Thread Thomas Monjalon
17/01/2019 14:12, David Marchand: > In the unlikely case when the dpdk application is started with no cpu > available in the [0, RTE_MAX_LCORE - 1] range, the master_lcore is > automatically chosen as RTE_MAX_LCORE which triggers an out of bound > access. > > Either you have a crash then, or the i

[dpdk-dev] [PATCH v2] eal: support strlcat function

2019-01-17 Thread Bruce Richardson
Add the strlcat function to DPDK to exist alongside the strlcpy one. While strncat is generally safe for use for concatenation, the API for the strlcat function is perhaps a little nicer to use, and supports truncation detection. See commit: 5364de644a4b ("eal: support strlcpy function") for more

Re: [dpdk-dev] [dpdk-stable] [PATCH v6] eal: fix core number validation

2019-01-17 Thread Thomas Monjalon
17/01/2019 13:13, Hari Kumar Vemula: > When incorrect core value or range provided, > as part of -l command line option, a crash occurs. > > Added valid range checks to fix the crash. > > Added ut check for negative core values. > Added unit test case for invalid core number range. > > Fixes: d8

Re: [dpdk-dev] [PATCH] doc: remove file listings

2019-01-17 Thread Thomas Monjalon
17/01/2019 16:42, Kovacevic, Marko: > > > Signed-off-by: David Marchand > > > --- > > > doc/guides/prog_guide/dev_kit_build_system.rst | 43 -- > > > doc/guides/prog_guide/source_org.rst | 79 > > > +- > > > 2 files changed, 2 insertions(+), 120 dele

[dpdk-dev] [PATCH v3] test/ipsec: fix test suite setup function

2019-01-17 Thread Bernard Iremonger
Check for valid crypto_null device before continuing. Use valid_dev instead of valid_devs[]. Replace valid_dev_count with valid_dev_found Call create_crypto_session for one driver only. Refactor code so that driver capabilities can be checked in the testsuite_setup function. Fixes: 05fe65eb66b2 ("

Re: [dpdk-dev] [dpdk-stable] [PATCH] doc: fix an error in ifc NIC document

2019-01-17 Thread Ferruh Yigit
On 1/17/2019 2:50 PM, Rami Rosen wrote: > This patch fixes an error in ifc NIC document; a previous patch > changed the semantics to use CONFIG_RTE_LIBRTE_IFC_PMD > instread of CONFIG_RTE_LIBRTE_IFCVF_VDPA_PMD, > but the ifc NIC doc file remained with the old name. > > Fixes: 4b614e9504a1 ("net/

Re: [dpdk-dev] [PATCH v2 1/2] eal: add 128-bit cmpset (x86-64 only)

2019-01-17 Thread Gavin Hu (Arm Technology China)
> -Original Message- > From: Eads, Gage > Sent: Thursday, January 17, 2019 11:14 PM > To: Gavin Hu (Arm Technology China) ; > dev@dpdk.org > Cc: olivier.m...@6wind.com; arybche...@solarflare.com; Richardson, > Bruce ; Ananyev, Konstantin > ; Honnappa Nagarahalli > > Subject: RE: [dpdk-

Re: [dpdk-dev] [PATCH v3 1/2] eal: add 128-bit cmpset (x86-64 only)

2019-01-17 Thread Honnappa Nagarahalli
> Subject: [dpdk-dev] [PATCH v3 1/2] eal: add 128-bit cmpset (x86-64 only) > > This operation can be used for non-blocking algorithms, such as a non- > blocking stack or ring. > > Signed-off-by: Gage Eads > --- > .../common/include/arch/x86/rte_atomic_64.h| 22 > ++ >

Re: [dpdk-dev] [PATCH v2 2/2] mempool/nb_stack: add non-blocking stack mempool

2019-01-17 Thread Gavin Hu (Arm Technology China)
> -Original Message- > From: Eads, Gage > Sent: Thursday, January 17, 2019 11:16 PM > To: Richardson, Bruce > Cc: Gavin Hu (Arm Technology China) ; > dev@dpdk.org; olivier.m...@6wind.com; arybche...@solarflare.com; > Ananyev, Konstantin ; Honnappa > Nagarahalli ; Ruifeng Wang (Arm > Te

Re: [dpdk-dev] [PATCH] doc: remove file listings

2019-01-17 Thread Kovacevic, Marko
> > Signed-off-by: David Marchand > > --- > > doc/guides/prog_guide/dev_kit_build_system.rst | 43 -- > > doc/guides/prog_guide/source_org.rst | 79 > > +- > > 2 files changed, 2 insertions(+), 120 deletions(-) > > > > diff --git a/doc/guides/prog_gu

[dpdk-dev] [PATCH v3] vhost: add external message handling callbacks to the public API

2019-01-17 Thread Darek Stojaczyk
External message callbacks are used e.g. by vhost crypto to parse crypto-specific vhost-user messages. We are now publishing the API to register those callbacks, so that other backends outside of DPDK can use them as well. Signed-off-by: Darek Stojaczyk Reviewed-by: Tiwei Bie --- lib/librte_vh

Re: [dpdk-dev] [PATCH v3] ethdev: report error on name truncation

2019-01-17 Thread Thomas Monjalon
17/01/2019 15:13, Nithin Kumar Dabilpuram: > Currently this api doesn't report error if name is > truncated and so user is not sure about uniqueness > of name. This change reports error to help user. > > Signed-off-by: Nithin Dabilpuram > --- > + rc = snprintf(z_name, sizeof(z_name), "eth_p%d

[dpdk-dev] [PATCH v4 2/2] mempool/nb_stack: add non-blocking stack mempool

2019-01-17 Thread Gage Eads
This commit adds support for non-blocking (linked list based) stack mempool handler. The stack uses a 128-bit compare-and-swap instruction, and thus is limited to x86_64. The 128-bit CAS atomically updates the stack top pointer and a modification counter, which protects against the ABA problem. In

[dpdk-dev] [PATCH v4 0/2] Add non-blocking stack mempool handler

2019-01-17 Thread Gage Eads
For some users, the rte ring's "non-preemptive" constraint is not acceptable; for example, if the application uses a mixture of pinned high-priority threads and multiplexed low-priority threads that share a mempool. This patchset introduces a non-blocking stack mempool handler. Note that the non-b

[dpdk-dev] [PATCH v4 1/2] eal: add 128-bit cmpset (x86-64 only)

2019-01-17 Thread Gage Eads
This operation can be used for non-blocking algorithms, such as a non-blocking stack or ring. Signed-off-by: Gage Eads --- .../common/include/arch/x86/rte_atomic_64.h| 22 ++ 1 file changed, 22 insertions(+) diff --git a/lib/librte_eal/common/include/arch/x86/rte_ato

Re: [dpdk-dev] [PATCH v2] test/ipsec: fix test suite setup function

2019-01-17 Thread Iremonger, Bernard
Hi Konstantin, > > > Subject: [PATCH v2] test/ipsec: fix test suite setup function > > > > > > Check for valid crypto_null device before continuing. > > > Use valid_dev instead of valid_devs[]. > > > Call create_crypto_session for one driver only. > > > > > > Fixes: 05fe65eb66b2 ("test/ipsec: in

Re: [dpdk-dev] [PATCH v2] devtools: fix error propagation from check-forbidden-tokens.awk

2019-01-17 Thread Thomas Monjalon
17/01/2019 13:20, David Marchand: > On Fri, Dec 21, 2018 at 2:00 AM Thomas Monjalon wrote: > > > 18/12/2018 16:19, Arnon Warshavsky: > > > Bugzilla ID: 165 > > > > Thomas, > > I just noticed that the bz is still opened. > Who is supposed to close bug reports ? I think we never formally describ

Re: [dpdk-dev] [dpdk-stable] [PATCH] net/sfc: fix Rx packets counter reported by basic stats

2019-01-17 Thread Ferruh Yigit
On 1/17/2019 6:17 AM, Andrew Rybchenko wrote: > Errors, missed and pauses should not be included in delivered > good Rx packets reported by ipackets. > > Fixes: 1caab2f1e684 ("net/sfc: add basic statistics") > Cc: sta...@dpdk.org > > Signed-off-by: Andrew Rybchenko Applied to dpdk-next-net/mast

Re: [dpdk-dev] [PATCH v8 2/2] examples/vdpa: introduce a new sample for vDPA

2019-01-17 Thread Shahaf Shuler
Thursday, January 17, 2019 5:13 PM, Ye Xiaolong: > Subject: Re: [dpdk-dev] [PATCH v8 2/2] examples/vdpa: introduce a new > sample for vDPA > > Hi, > > On 01/17, Shahaf Shuler wrote: > >Hi, > > > >Going back to this merged commit, > > > >Saturday, September 29, 2018 12:48 AM, Xiaolong Ye: > >> Sub

Re: [dpdk-dev] [PATCH v2 2/2] mempool/nb_stack: add non-blocking stack mempool

2019-01-17 Thread Eads, Gage
> -Original Message- > From: Richardson, Bruce > Sent: Thursday, January 17, 2019 8:21 AM > To: Eads, Gage > Cc: Gavin Hu (Arm Technology China) ; dev@dpdk.org; > olivier.m...@6wind.com; arybche...@solarflare.com; Ananyev, Konstantin > ; Honnappa Nagarahalli > ; Ruifeng Wang (Arm Techno

Re: [dpdk-dev] [PATCH v2 1/2] eal: add 128-bit cmpset (x86-64 only)

2019-01-17 Thread Eads, Gage
> -Original Message- > From: Gavin Hu (Arm Technology China) [mailto:gavin...@arm.com] > Sent: Thursday, January 17, 2019 2:49 AM > To: Eads, Gage ; dev@dpdk.org > Cc: olivier.m...@6wind.com; arybche...@solarflare.com; Richardson, Bruce > ; Ananyev, Konstantin > ; Honnappa Nagarahalli >

Re: [dpdk-dev] [PATCH v8 2/2] examples/vdpa: introduce a new sample for vDPA

2019-01-17 Thread Ye Xiaolong
Hi, On 01/17, Shahaf Shuler wrote: >Hi, > >Going back to this merged commit, > >Saturday, September 29, 2018 12:48 AM, Xiaolong Ye: >> Subject: [dpdk-dev] [PATCH v8 2/2] examples/vdpa: introduce a new sample >> for vDPA >> >> The vdpa sample application creates vhost-user sockets by using the v

[dpdk-dev] [PATCH] doc: fix an error in ifc NIC document

2019-01-17 Thread Rami Rosen
This patch fixes an error in ifc NIC document; a previous patch changed the semantics to use CONFIG_RTE_LIBRTE_IFC_PMD instread of CONFIG_RTE_LIBRTE_IFCVF_VDPA_PMD, but the ifc NIC doc file remained with the old name. Fixes: 4b614e9504a1 ("net/ifc: make driver name consistent") Cc: sta...@dpdk.o

Re: [dpdk-dev] [PATCH v8 2/2] examples/vdpa: introduce a new sample for vDPA

2019-01-17 Thread Shahaf Shuler
Hi, Going back to this merged commit, Saturday, September 29, 2018 12:48 AM, Xiaolong Ye: > Subject: [dpdk-dev] [PATCH v8 2/2] examples/vdpa: introduce a new sample > for vDPA > > The vdpa sample application creates vhost-user sockets by using the vDPA > backend. vDPA stands for vhost Data Pat

Re: [dpdk-dev] [PATCH] doc: remove file listings

2019-01-17 Thread Ferruh Yigit
On 1/17/2019 9:05 AM, David Marchand wrote: > No need to keep those file listings, they are very likely to become > outdated. > > Signed-off-by: David Marchand Reviewed-by: Ferruh Yigit

Re: [dpdk-dev] [PATCH v2 2/2] mempool/nb_stack: add non-blocking stack mempool

2019-01-17 Thread Bruce Richardson
On Thu, Jan 17, 2019 at 02:11:22PM +, Eads, Gage wrote: > > > > -Original Message- > > From: Gavin Hu (Arm Technology China) [mailto:gavin...@arm.com] > > Sent: Thursday, January 17, 2019 2:06 AM > > To: Eads, Gage ; dev@dpdk.org > > Cc: olivier.m...@6wind.com; arybche...@solarflare.c

[dpdk-dev] [PATCH v3] ethdev: report error on name truncation

2019-01-17 Thread Nithin Kumar Dabilpuram
Currently this api doesn't report error if name is truncated and so user is not sure about uniqueness of name. This change reports error to help user. Signed-off-by: Nithin Dabilpuram --- v3: Change log message v2: Fix issue caused by rebase and also fix log message lib/librte_ethdev/rte_ethdev

Re: [dpdk-dev] [PATCH v2 2/2] mempool/nb_stack: add non-blocking stack mempool

2019-01-17 Thread Eads, Gage
> -Original Message- > From: Gavin Hu (Arm Technology China) [mailto:gavin...@arm.com] > Sent: Thursday, January 17, 2019 2:06 AM > To: Eads, Gage ; dev@dpdk.org > Cc: olivier.m...@6wind.com; arybche...@solarflare.com; Richardson, Bruce > ; Ananyev, Konstantin > ; Honnappa Nagarahalli >

Re: [dpdk-dev] [PATCH v6] doc: add GRO limitations in prog_guide

2019-01-17 Thread Kovacevic, Marko
> +GRO Library Limitations > +--- > + > +- GRO library uses MBUF->l2_len/l3_len/l4_len/outer_l2_len/ > + outer_l3_len/packet_type to get protocol headers for the > + input packet, rather than parsing the packet header. Therefore, > + before call GRO APIs to merge packets, use

Re: [dpdk-dev] [PATCH] doc: announce ABI change for cryptodev config

2019-01-17 Thread Anoob Joseph
Hi Fiona, Please see inline. Thanks, Anoob > -Original Message- > From: Trahe, Fiona > Sent: 17 January 2019 17:07 > To: Anoob Joseph ; Akhil Goyal ; > De Lara Guarch, Pablo > Cc: Jerin Jacob Kollanukkaran ; Narayana Prasad Raju > Athreya ; Shally Verma ; > dev@dpdk.org; Trahe, Fiona

[dpdk-dev] [PATCH v4] lib/efd: fix to free tail queue entry after use

2019-01-17 Thread Hari Kumar Vemula
In rte_efd_create() allocated memory for tail queue entry but not freed. Added freeing the tail queue entry. Fixes: 56b6ef874f80 ("efd: new Elastic Flow Distributor library") Cc: sta...@dpdk.org Signed-off-by: Hari Kumar Vemula Acked-by: Reshma Pattan Reviewed-by: Honnappa Nagarahalli --- v4:

Re: [dpdk-dev] [PATCH v2 0/7] net/ice: update share code

2019-01-17 Thread Zhang, Qi Z
> -Original Message- > From: Zhang, Qi Z > Sent: Wednesday, January 16, 2019 10:14 PM > To: Lu, Wenzhuo ; Yang, Qiming > > Cc: Stillwell Jr, Paul M ; dev@dpdk.org; Yigit, > Ferruh ; Zhang, Qi Z > Subject: [PATCH v2 0/7] net/ice: update share code > > For ice family NICs, package proce

Re: [dpdk-dev] [PATCH V2] doc: add missing loopback option in testpmd guide

2019-01-17 Thread Iremonger, Bernard
> -Original Message- > From: Rami Rosen [mailto:ramir...@gmail.com] > Sent: Thursday, January 17, 2019 11:39 AM > To: dev@dpdk.org > Cc: sta...@dpdk.org; Mcnamara, John ; > Iremonger, Bernard ; Rami Rosen > > Subject: [PATCH V2] doc: add missing loopback option in testpmd guide > > This p

[dpdk-dev] [PATCH] eal: fix out of bound access when no cpu is available

2019-01-17 Thread David Marchand
In the unlikely case when the dpdk application is started with no cpu available in the [0, RTE_MAX_LCORE - 1] range, the master_lcore is automatically chosen as RTE_MAX_LCORE which triggers an out of bound access. Either you have a crash then, or the initialisation fails later when trying to pin t

Re: [dpdk-dev] [PATCH] eal: support strlcat function

2019-01-17 Thread Ferruh Yigit
On 1/16/2019 12:48 PM, Bruce Richardson wrote: > Add the strlcat function to DPDK to exist alongside the strlcpy one. While > strncat is generally safe for use for concatenation, the API for the > strlcat function is perhaps a little nicer to use, and supports truncation > detection. > > See comm

  1   2   >