Re: [dpdk-dev] [PATCH 3/4] net/mlx5: rework PMD global data init

2019-03-18 Thread Shahaf Shuler
Monday, March 18, 2019 11:21 PM, Yongseok Koh: > Subject: Re: [PATCH 3/4] net/mlx5: rework PMD global data init > > On Thu, Mar 14, 2019 at 05:36:28AM -0700, Shahaf Shuler wrote: > > Hi Koh, > > > > Thursday, March 7, 2019 9:33 AM, Yongseok Koh: > > > Subject: [PATCH 3/4] net/mlx5: rework PMD glob

[dpdk-dev] [PATCH 08/10] net/virtio: add interrupt helper for split ring

2019-03-18 Thread Tiwei Bie
Add a helper for disabling interrupts in split ring to make the code consistent with the corresponding code in packed ring. Signed-off-by: Tiwei Bie --- drivers/net/virtio/virtqueue.h | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/drivers/net/virtio/virtqueue.

[dpdk-dev] [PATCH 10/10] net/virtio: improve batching in standard Rx path

2019-03-18 Thread Tiwei Bie
This patch improves descriptors refill by using the same batching strategy as done in in-order and mergeable path. Signed-off-by: Tiwei Bie --- drivers/net/virtio/virtio_rxtx.c | 60 ++-- 1 file changed, 34 insertions(+), 26 deletions(-) diff --git a/drivers/net/virt

[dpdk-dev] [PATCH 07/10] net/virtio: drop unused field in Tx region structure

2019-03-18 Thread Tiwei Bie
Drop the unused field tx_indir_pq from virtio_tx_region structure. Signed-off-by: Tiwei Bie --- drivers/net/virtio/virtio_ethdev.c | 10 +- drivers/net/virtio/virtqueue.h | 8 ++-- 2 files changed, 3 insertions(+), 15 deletions(-) diff --git a/drivers/net/virtio/virtio_ethdev.c

[dpdk-dev] [PATCH 04/10] net/virtio: optimize flags update for packed ring

2019-03-18 Thread Tiwei Bie
Cache the AVAIL, USED and WRITE bits to avoid calculating them as much as possible. Note that, the WRITE bit isn't cached for control queue. Signed-off-by: Tiwei Bie --- drivers/net/virtio/virtio_ethdev.c | 35 ++ drivers/net/virtio/virtio_rxtx.c | 31 ++

[dpdk-dev] [PATCH 09/10] net/virtio: add ctrl vq helper for split ring

2019-03-18 Thread Tiwei Bie
Add a helper for sending commands in split ring to make the code consistent with the corresponding code in packed ring. Signed-off-by: Tiwei Bie --- drivers/net/virtio/virtio_ethdev.c | 76 +- 1 file changed, 43 insertions(+), 33 deletions(-) diff --git a/drivers/net

[dpdk-dev] [PATCH 06/10] net/virtio: drop redundant suffix in packed ring structure

2019-03-18 Thread Tiwei Bie
Drop redundant suffix (_packed and _event) from the fields in packed ring structure. Signed-off-by: Tiwei Bie --- drivers/net/virtio/virtio_ethdev.c| 2 +- drivers/net/virtio/virtio_ring.h | 15 ++--- drivers/net/virtio/virtio_rxtx.c | 14 ++

[dpdk-dev] [PATCH 05/10] net/virtio: refactor virtqueue structure

2019-03-18 Thread Tiwei Bie
Put split ring and packed ring specific fields into separate sub-structures, and also union them as they won't be available at the same time. Signed-off-by: Tiwei Bie --- drivers/net/virtio/virtio_ethdev.c | 71 +- drivers/net/virtio/virtio_rxtx.c | 66 +

[dpdk-dev] [PATCH 01/10] net/virtio: fix typo in packed ring init

2019-03-18 Thread Tiwei Bie
The pointer to event structure should be cast to uintptr_t first. Fixes: f803734b0f2e ("net/virtio: vring init for packed queues") Cc: sta...@dpdk.org Signed-off-by: Tiwei Bie --- drivers/net/virtio/virtio_ring.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/vi

[dpdk-dev] [PATCH 02/10] net/virtio: fix interrupt helper for packed ring

2019-03-18 Thread Tiwei Bie
When disabling interrupt, the shadow event flags should also be updated accordingly. The unnecessary wmb is also dropped. Fixes: e9f4feb7e622 ("net/virtio: add packed virtqueue helpers") Cc: sta...@dpdk.org Signed-off-by: Tiwei Bie --- drivers/net/virtio/virtqueue.h | 10 +- 1 file chan

[dpdk-dev] [PATCH 00/10] net/virtio: cleanups and fixes for packed/split ring

2019-03-18 Thread Tiwei Bie
Tiwei Bie (10): net/virtio: fix typo in packed ring init net/virtio: fix interrupt helper for packed ring net/virtio: add missing barrier in interrupt enable net/virtio: optimize flags update for packed ring net/virtio: refactor virtqueue structure net/virtio: drop redundant suffix in p

[dpdk-dev] [PATCH 03/10] net/virtio: add missing barrier in interrupt enable

2019-03-18 Thread Tiwei Bie
Typically, after enabling Rx interrupt, a check should be done to make sure that there is no new incoming packets before going to sleep. So a barrier is needed to make sure that any following check won't happen before the interrupt is actually enabled. Fixes: c056be239db5 ("net/virtio: add Rx inte

[dpdk-dev] [PATCH] app/eventdev: add option to set global dequeue tmo

2019-03-18 Thread Pavan Nikhilesh Bhagavatula
From: Pavan Nikhilesh Add option to provide a global dequeue timeout that is used to create the eventdev. The dequeue timeout provided will be common across all the worker ports. If the eventdev hardware supports power management through dequeue timeout then this option can be used for verifying

Re: [dpdk-dev] [PATCH] net/iavf: fix vertor interrupt number configuration error

2019-03-18 Thread Zhao1, Wei
> -Original Message- > From: Zhang, Qi Z > Sent: Tuesday, March 19, 2019 12:01 PM > To: Zhao1, Wei ; dev@dpdk.org > Cc: sta...@dpdk.org > Subject: RE: [PATCH] net/iavf: fix vertor interrupt number configuration error > > > > > -Original Message- > > From: Zhao1, Wei > > Sent:

Re: [dpdk-dev] [PATCH v2] app/testpmd: fix support of hex string parser for flow API

2019-03-18 Thread Zhao1, Wei
Send on behalf of pengyuan Tested-by: Peng Yuan - Tested Branch: master - Tested Commit: 239912fa798e6e671072ca7ff987afd74c1e506c - OS: 4.13.9-300.fc27.x86_64 - GCC: gcc (GCC) 7.3.1 20180303 (Red Hat 7.3.1-5) - CPU: Intel(R) Xeon(R) CPU E5-2699 v4 @ 2.20GHz - NIC: Intel Corporation Device Fort

[dpdk-dev] [PATCH 3/3] doc/rcu: add lib_rcu documentation

2019-03-18 Thread Honnappa Nagarahalli
Add lib_rcu QSBR API and programmer guide documentation. Signed-off-by: Honnappa Nagarahalli --- doc/api/doxy-api-index.md | 3 +- doc/api/doxy-api.conf.in | 1 + .../prog_guide/img/rcu_general_info.svg | 494 ++ doc/guides/prog

[dpdk-dev] [PATCH 1/3] rcu: add RCU library supporting QSBR mechanism

2019-03-18 Thread Honnappa Nagarahalli
Add RCU library supporting quiescent state based memory reclamation method. This library helps identify the quiescent state of the reader threads so that the writers can free the memory associated with the lock less data structures. Signed-off-by: Honnappa Nagarahalli Reviewed-by: Steve Capper R

[dpdk-dev] [PATCH 2/3] test/rcu_qsbr: add API and functional tests

2019-03-18 Thread Honnappa Nagarahalli
From: Dharmik Thakkar Add API positive/negative test cases, functional tests and performance tests. Signed-off-by: Malvika Gupta Signed-off-by: Dharmik Thakkar Signed-off-by: Honnappa Nagarahalli Reviewed-by: Gavin Hu --- app/test/Makefile | 2 + app/test/autotest_data.py

[dpdk-dev] [PATCH 0/3] lib/rcu: add RCU library supporting QSBR mechanism

2019-03-18 Thread Honnappa Nagarahalli
Lock-less data structures provide scalability and determinism. They enable use cases where locking may not be allowed (for ex: real-time applications). In the following paras, the term 'memory' refers to memory allocated by typical APIs like malloc or anything that is representative of memory, for

Re: [dpdk-dev] [PATCH v2] lib/cryptodev: fix driver name comparison

2019-03-18 Thread Anoob Joseph
Hi Akhil, Declan, Pablo, Can you review this patch and share your thoughts? Thanks, Anoob > -Original Message- > From: Trahe, Fiona > Sent: Monday, March 11, 2019 4:11 PM > To: Anoob Joseph ; Akhil Goyal > ; Doherty, Declan ; De > Lara Guarch, Pablo > Cc: Ankur Dwivedi ; Jerin Jacob Ko

Re: [dpdk-dev] [PATCH 1/3] common/cpt: improve structures used in datapath

2019-03-18 Thread Anoob Joseph
Hi Akhil, Can you review this series and share your thoughts? Thanks, Anoob > -Original Message- > From: Anoob Joseph > Sent: Saturday, March 2, 2019 12:12 AM > To: Akhil Goyal ; Pablo de Lara > > Cc: Anoob Joseph ; Jerin Jacob Kollanukkaran > ; Narayana Prasad Raju Athreya > ; Suheil C

Re: [dpdk-dev] [PATCH] net/iavf: fix vertor interrupt number configuration error

2019-03-18 Thread Stillwell Jr, Paul M
> -Original Message- > From: dev On Behalf Of Wei Zhao > Sent: Monday, March 18, 2019 8:05 PM > To: dev@dpdk.org > Cc: sta...@dpdk.org; Zhang, Qi Z ; Zhao1, Wei > > Subject: [dpdk-dev] [PATCH] net/iavf: fix vertor interrupt number > configuration error > Should the patch name be net/a

Re: [dpdk-dev] [PATCH] net/iavf: fix vertor interrupt number configuration error

2019-03-18 Thread Zhang, Qi Z
> -Original Message- > From: Zhao1, Wei > Sent: Tuesday, March 19, 2019 11:05 AM > To: dev@dpdk.org > Cc: sta...@dpdk.org; Zhang, Qi Z ; Zhao1, Wei > > Subject: [PATCH] net/iavf: fix vertor interrupt number configuration error > > There is a issue when iavf do vertor interrupt configur

[dpdk-dev] [PATCH] net/iavf: fix vertor interrupt number configuration error

2019-03-18 Thread Wei Zhao
There is a issue when iavf do vertor interrupt configuration, it will miss one interrupt vector which set admin queue interrupt when communicate with host pf. Fixes: 69dd4c3d0898 ("net/avf: enable queue and device") Cc: sta...@dpdk.org Signed-off-by: Wei Zhao Signed-off-by: Zhao Wei --- driver

Re: [dpdk-dev] [PATCH v3 00/38] ice share code update.

2019-03-18 Thread Lu, Wenzhuo
Hi, > -Original Message- > From: Zhang, Qi Z > Sent: Monday, March 11, 2019 3:04 PM > To: Lu, Wenzhuo ; Yang, Qiming > > Cc: dev@dpdk.org; Stillwell Jr, Paul M ; Yigit, > Ferruh ; Zhang, Qi Z > Subject: [PATCH v3 00/38] ice share code update. > > Sync to latest kernel driver, main chan

Re: [dpdk-dev] [PATCH] eal/ppc: remove fix of memory barrier for IBM POWER

2019-03-18 Thread Chao Zhu
Dekel£¬ To control the memory order for device memory, I think you should use rte_io_mb() instead of rte_mb(). This will generate correct result. rte_wmb() is used for system memory. > -Original Message- > From: Dekel Peled > Sent: Monday, March 18, 2019 8:58 PM > To: chao...@linux.vne

Re: [dpdk-dev] [PATCH] raw/ifpga: modify log output.

2019-03-18 Thread Xu, Rosen
Hi, This macro IFPGA_RAWDEV_PMD_FUNC_TRACE is very useful for developer. To enable this macro, pls follow these guides: 1. enable gcc debug mode such as options: EXTRA_CFLAGS='-O0 -g' 2. add this option in testpmd startup: --log-level=driver.raw.init,8 > -Original Message- > From: Pei, An

[dpdk-dev] [PATCH v8 3/6] ring: add a lock-free implementation

2019-03-18 Thread Gage Eads
This commit adds support for lock-free circular ring enqueue and dequeue functions. The ring is supported on 32- and 64-bit architectures, however it uses a 128-bit compare-and-swap instruction when run on a 64-bit architecture, and thus is currently limited to x86_64. The algorithm is based on Ol

[dpdk-dev] [PATCH v8 6/6] mempool/ring: add lock-free ring handlers

2019-03-18 Thread Gage Eads
These handlers allow an application to create a mempool based on the lock-free ring, with any combination of single/multi producer/consumer. Also, add a note to the programmer's guide's "known issues" section. Signed-off-by: Gage Eads Acked-by: Andrew Rybchenko --- doc/guides/prog_guide/env_ab

[dpdk-dev] [PATCH v8 5/6] test_ring_perf: add lock-free ring perf test

2019-03-18 Thread Gage Eads
nb_ring_perf_autotest re-uses the ring_perf_autotest code by wrapping its top-level function with one that takes a 'flags' argument. Signed-off-by: Gage Eads --- app/test/test_ring_perf.c | 19 --- 1 file changed, 16 insertions(+), 3 deletions(-) diff --git a/app/test/test_ring_

[dpdk-dev] [PATCH v8 4/6] test_ring: add lock-free ring autotest

2019-03-18 Thread Gage Eads
ring_nb_autotest re-uses the ring_autotest code by wrapping its top-level function with one that takes a 'flags' argument. Signed-off-by: Gage Eads --- app/test/test_ring.c | 61 1 file changed, 38 insertions(+), 23 deletions(-) diff --git a/

[dpdk-dev] [PATCH v8 2/6] ring: add a ring start marker

2019-03-18 Thread Gage Eads
This marker allows us to replace "&r[1]" with "&r->ring" to locate the start of the ring. Signed-off-by: Gage Eads --- lib/librte_ring/rte_ring.h | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/lib/librte_ring/rte_ring.h b/lib/librte_ring/rte_ring.h index c78db6916..f16d

[dpdk-dev] [PATCH v8 0/6] Add lock-free ring and mempool handler

2019-03-18 Thread Gage Eads
For some users, the rte ring's "non-preemptive" constraint is not acceptable; for example, if the application uses a mixture of pinned high-priority threads and multiplexed low-priority threads that share a mempool. This patchset introduces a lock-free ring and a mempool based on it. The lock-free

[dpdk-dev] [PATCH v8 1/6] ring: add a pointer-width headtail structure

2019-03-18 Thread Gage Eads
For 64-bit systems, at current CPU speeds, 64-bit head and tail indexes will not wrap-around within the author's lifetime. This is important to avoiding the ABA problem -- in which a thread mistakes reading the same tail index in two accesses to mean that the ring was not modified in the intervenin

Re: [dpdk-dev] [PATCH v7 0/6] Add lock-free ring and mempool handler

2019-03-18 Thread Eads, Gage
[Snip] > > This patchset makes one API change; a deprecation notice was posted in a > separate commit[1]. > > This patchset depends on the 128-bit compare-and-set patch[2]. > > [1] http://mails.dpdk.org/archives/dev/2019-February/124321.html > [2] http://mails.dpdk.org/archives/dev/2019-March/1

[dpdk-dev] [PATCH v7 6/6] mempool/ring: add lock-free ring handlers

2019-03-18 Thread Gage Eads
These handlers allow an application to create a mempool based on the lock-free ring, with any combination of single/multi producer/consumer. Also, add a note to the programmer's guide's "known issues" section. Signed-off-by: Gage Eads Acked-by: Andrew Rybchenko --- doc/guides/prog_guide/env_ab

[dpdk-dev] [PATCH v7 1/6] ring: add a pointer-width headtail structure

2019-03-18 Thread Gage Eads
For 64-bit systems, at current CPU speeds, 64-bit head and tail indexes will not wrap-around within the author's lifetime. This is important to avoiding the ABA problem -- in which a thread mistakes reading the same tail index in two accesses to mean that the ring was not modified in the intervenin

[dpdk-dev] [PATCH v7 4/6] test_ring: add lock-free ring autotest

2019-03-18 Thread Gage Eads
ring_nb_autotest re-uses the ring_autotest code by wrapping its top-level function with one that takes a 'flags' argument. Signed-off-by: Gage Eads --- app/test/test_ring.c | 61 1 file changed, 38 insertions(+), 23 deletions(-) diff --git a/

[dpdk-dev] [PATCH v7 2/6] ring: add a ring start marker

2019-03-18 Thread Gage Eads
This marker allows us to replace "&r[1]" with "&r->ring" to locate the start of the ring. Signed-off-by: Gage Eads --- lib/librte_ring/rte_ring.h | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/lib/librte_ring/rte_ring.h b/lib/librte_ring/rte_ring.h index c78db6916..f16d

[dpdk-dev] [PATCH v7 3/6] ring: add a lock-free implementation

2019-03-18 Thread Gage Eads
This commit adds support for lock-free circular ring enqueue and dequeue functions. The ring is supported on 32- and 64-bit architectures, however it uses a 128-bit compare-and-swap instruction when run on a 64-bit architecture, and thus is currently limited to x86_64. The algorithm is based on Ol

[dpdk-dev] [PATCH v7 0/6] Add lock-free ring and mempool handler

2019-03-18 Thread Gage Eads
For some users, the rte ring's "non-preemptive" constraint is not acceptable; for example, if the application uses a mixture of pinned high-priority threads and multiplexed low-priority threads that share a mempool. This patchset introduces a lock-free ring and a mempool based on it. The lock-free

[dpdk-dev] [PATCH v7 5/6] test_ring_perf: add lock-free ring perf test

2019-03-18 Thread Gage Eads
nb_ring_perf_autotest re-uses the ring_perf_autotest code by wrapping its top-level function with one that takes a 'flags' argument. Signed-off-by: Gage Eads --- app/test/test_ring_perf.c | 19 --- 1 file changed, 16 insertions(+), 3 deletions(-) diff --git a/app/test/test_ring_

Re: [dpdk-dev] [PATCH 2/4] net/mlx5: replace IPC socket with EAL API

2019-03-18 Thread Yongseok Koh
On Thu, Mar 14, 2019 at 05:36:32AM -0700, Shahaf Shuler wrote: > Hi Koh, > > Thursday, March 7, 2019 9:33 AM, Yongseok Koh: > > Subject: [PATCH 2/4] net/mlx5: replace IPC socket with EAL API > > > > Socket API is used for IPC in order for secondary process to acquire Verb > > command file descri

Re: [dpdk-dev] [PATCH 3/4] net/mlx5: rework PMD global data init

2019-03-18 Thread Yongseok Koh
On Thu, Mar 14, 2019 at 05:36:28AM -0700, Shahaf Shuler wrote: > Hi Koh, > > Thursday, March 7, 2019 9:33 AM, Yongseok Koh: > > Subject: [PATCH 3/4] net/mlx5: rework PMD global data init > > > > There's more need to have PMD global data structure. It should be > > initialized > > once per a proc

Re: [dpdk-dev] [PATCH v2] build: mention machine=default and its use in documentation

2019-03-18 Thread Jerin Jacob Kollanukkaran
On Wed, 2019-02-27 at 12:16 +, Luca Boccassi wrote: > On Mon, 2019-01-14 at 13:41 +, Luca Boccassi wrote: > > Document the new value, as it's useful for distributions and users > > who need to use a stable baseline -march > > > > Signed-off-by: Luca Boccassi > > Reviewed-by: Christian Ehr

[dpdk-dev] [PATCH v7] net/tap: fix missing _SC_IOV_MAX

2019-03-18 Thread olegpoly123
If the value _SC_IOV_MAX is missing, sysconf returns -1. In this case, iov_max is set to a default value of 1024. This should never happen except for redhat bug: https://bugzilla.redhat.com/show_bug.cgi?id=1504165 Fixes: ec12df9504fe ("net/tap: fix support for large Rx queues") Cc: sta...@dpdk.

Re: [dpdk-dev] [PATCH v2 1/3] lib/cryptodev: add rsa priv key feature flag

2019-03-18 Thread Ayuj Verma
Hi Akhil, Arek, Sure, I'll rebase the patch and will send v3 along with doc changes. Thanks and regards Ayuj Verma -Original Message- From: Akhil Goyal Sent: Sunday, March 17, 2019 11:17 PM To: Ayuj Verma Cc: arkadiuszx.kusz...@intel.com; fiona.tr...@intel.com; Shally Verma ; Sunila

Re: [dpdk-dev] [PATCH v6] net/tap: fix missing _SC_IOV_MAX

2019-03-18 Thread Stephen Hemminger
On Mon, 18 Mar 2019 12:55:23 -0400 olegpoly123 wrote: > long iov_max = sysconf(_SC_IOV_MAX); > + > + if (iov_max <= 0) { > + TAP_LOG(WARNING, > + "_SC_IOV_MAX is not defined. Using %d as default\n", > + TAP_IOV_DEFAULT_MAX); > +

Re: [dpdk-dev] [dpdk-users] No supported Ethernet device found Error

2019-03-18 Thread Rami Rosen
Hi Kothuri, This nic is not supported by DPDK (Actually no realtek network device is supported by DPDK). For the list of nics supported by DPDK please look in: https://doc.dpdk.org/guides/nics/index.html Regards, Rami Rosen

Re: [dpdk-dev] [PATCH] meson: remove build warnings

2019-03-18 Thread Luca Boccassi
On Mon, 2019-03-18 at 16:28 +, Jerin Jacob Kollanukkaran wrote: > From: Jerin Jacob > > Remove the following meson build warnings > > 1) WARNING: Project specifies a minimum meson_version '>= 0.47.1' > but uses features which were added in newer versions: > * 0.48.0: {'console arg in custo

[dpdk-dev] [PATCH v6 1/4] mk: introduce helper to check valid compiler argument

2019-03-18 Thread Jerin Jacob Kollanukkaran
From: Jerin Jacob Introduce rte_cc_has_argument() Makefile helper to check a given argument is support by the compiler. Example Usage: include $(RTE_SDK)/mk/rte.helper.mk MACHINE_CFLAGS += $(call rte_cc_has_argument, -mcpu=octeontx2) This would allow adding -mcpu=octeontx2 in MACHINE_CFLAGS if

[dpdk-dev] [PATCH v6] net/tap: fix missing _SC_IOV_MAX

2019-03-18 Thread olegpoly123
If the value _SC_IOV_MAX is missing, sysconf returns -1. In this case, iov_max is set to a default value of 1024. Fixes: ec12df9504fe ("net/tap: fix support for large Rx queues") Cc: sta...@dpdk.org Signed-off-by: Oleg Polyakov Acked-by: Keith Wiles --- drivers/net/tap/rte_eth_tap.c | 9 ++

[dpdk-dev] [PATCH v6 2/4] meson: add infra to support machine specific flags

2019-03-18 Thread Jerin Jacob Kollanukkaran
From: Pavan Nikhilesh Currently, RTE_* flags are set based on the implementer ID but there might be some micro arch specific differences from the same vendor eg. CACHE_LINESIZE. Add support to set micro arch specific flags. Signed-off-by: Pavan Nikhilesh Signed-off-by: Jerin Jacob --- config/

[dpdk-dev] [PATCH v6 4/4] config: add octeontx2 machine config

2019-03-18 Thread Jerin Jacob Kollanukkaran
From: Jerin Jacob Optimized configuration for Marvell octeontx2 SoC. Updated meson build to support Marvell octeontx2 SoC. Added meson cross build target for octeontx2. Signed-off-by: Jerin Jacob Signed-off-by: Pavan Nikhilesh --- config/arm/arm64_octeontx2_linux_gcc | 15 c

[dpdk-dev] [PATCH v6 3/4] config: add thunderx2 machine config

2019-03-18 Thread Jerin Jacob Kollanukkaran
From: Jerin Jacob Optimized configuration for Marvell thunderx2 SoC. Updated meson build to support Marvell thunderx2 SoC. Added meson cross compile target. Product details are here: https://www.marvell.com/server-processors/thunderx2-arm-processors/ Signed-off-by: Jerin Jacob Signed-off-by:

[dpdk-dev] [PATCH] meson: remove build warnings

2019-03-18 Thread Jerin Jacob Kollanukkaran
From: Jerin Jacob Remove the following meson build warnings 1) WARNING: Project specifies a minimum meson_version '>= 0.47.1' but uses features which were added in newer versions: * 0.48.0: {'console arg in custom_target'} 2) config/arm/meson.build:153: WARNING: Trying to compare values of di

Re: [dpdk-dev] [PATCH v3 0/4] support secondary process for failsafe

2019-03-18 Thread Gaëtan Rivet
Hello Raslan, It all seems okay, thank you for the reworks and the added features :). For the series: Acked-by: Gaetan Rivet On Mon, Mar 18, 2019 at 04:05:24PM +, Raslan Darawsheh wrote: > this set of patches are intended to support secondary process for failsafe. > > v3 integrates changes

[dpdk-dev] [PATCH v3 2/4] net/failsafe: change back-reference from sub-device

2019-03-18 Thread Raslan Darawsheh
In multiprocess context, the sub-device structure is shared between processes. The reference to the failsafe device was a per process pointer. It's changed to port id which is the same for all processes. Signed-off-by: Raslan Darawsheh Signed-off-by: Thomas Monjalon --- v2: changed macro to an i

[dpdk-dev] [PATCH v3 4/4] net/failsafe: support secondary process

2019-03-18 Thread Raslan Darawsheh
Add implementation for probe in secondary. Failsafe will attempt to attach all the sub-devices in secondary process. Signed-off-by: Raslan Darawsheh Signed-off-by: Thomas Monjalon --- v2: changed devargs_alread_listed return value to be bool. --- drivers/net/failsafe/failsafe.c | 45 +

[dpdk-dev] [PATCH v3 3/4] net/failsafe: replace sub-device pointer with port id

2019-03-18 Thread Raslan Darawsheh
In multiprocess context, the pointer to sub-device is shared between processes. Previously, it was a pointer to per process eth_dev so it's needed to replace this dependency. Signed-off-by: Thomas Monjalon Signed-off-by: Raslan Darawsheh --- v2: - moved comment in fs_sdev about subs to this comm

[dpdk-dev] [PATCH v3 0/4] support secondary process for failsafe

2019-03-18 Thread Raslan Darawsheh
this set of patches are intended to support secondary process for failsafe. v3 integrates changes after review from Gaetan There is no functional change. Raslan Darawsheh (4): net/failsafe: replace local device with shared data net/failsafe: change back-reference from sub-device net/failsaf

[dpdk-dev] [PATCH v3 1/4] net/failsafe: replace local device with shared data

2019-03-18 Thread Raslan Darawsheh
In multiprocess context, the private structure is shared between processes. The back reference from private to generic data was using a pointer to a per process eth_dev. It's now changed to a reference of the shared data. Signed-off-by: Raslan Darawsheh Signed-off-by: Thomas Monjalon --- driver

Re: [dpdk-dev] [PATCH] app/testpmd: fix support of hex string parser for flow API

2019-03-18 Thread Stephen Hemminger
On Fri, 15 Mar 2019 16:43:55 +0800 Wei Zhao wrote: > + /* Check input parameters */ > + if ((src == NULL) || > + (dst == NULL) || > + (size == NULL) || > + (*size == 0)) > + return -1; > + if ((*size & 1) != 0) > + return -1;

Re: [dpdk-dev] [RFC] net/vdev_netvsc: check for required related drivers

2019-03-18 Thread Stephen Hemminger
On Sun, 17 Mar 2019 06:53:02 + Matan Azrad wrote: > Hi > > From: Stephen Hemminger > > wrote: > > > > > Hi > > > > > > From: Stephen Hemminger > > > > The vdev_netvsc virtual driver that is used to do initialization on > > > > Hyper- V/Azure won't work without failsafe and tap device. >

Re: [dpdk-dev] [PATCH v2 1/4] power: fix non thread-safe power env modification

2019-03-18 Thread Stephen Hemminger
On Mon, 18 Mar 2019 12:56:44 +0100 Hajkowski wrote: > From: Marcin Hajkowski > > Due to lack of thread safety in exisiting solution > use spinlock mechanism for atomic > modification of power environment related data. > > Fixes: 445c6528b5 ("power: common interface for guest and host") > Cc: s

[dpdk-dev] [PATCH v2 2/4] power: extend guest channel api for reading

2019-03-18 Thread Hajkowski
From: Marcin Hajkowski Added new experimental API rte_power_guest_channel_receive_msg which gives possibility to receive messages send to guest. Signed-off-by: Marcin Hajkowski --- lib/librte_power/channel_commands.h| 5 +++ lib/librte_power/guest_channel.c | 57

[dpdk-dev] [PATCH v2 4/4] power: send confirmation cmd to vm guest

2019-03-18 Thread Hajkowski
From: Marcin Hajkowski Use new guest channel API to send confirmation message for received power command. Signed-off-by: Marcin Hajkowski --- examples/vm_power_manager/channel_monitor.c | 67 +++-- 1 file changed, 61 insertions(+), 6 deletions(-) diff --git a/examples/vm_power

[dpdk-dev] [PATCH v2 3/4] power: process incoming confirmation cmds

2019-03-18 Thread Hajkowski
From: Marcin Hajkowski Extend vm_power_guest to check incoming confirmations of messages previously sent to host. Signed-off-by: Marcin Hajkowski --- examples/vm_power_manager/guest_cli/Makefile | 1 + .../guest_cli/vm_power_cli_guest.c| 65 +++ 2 files changed, 5

[dpdk-dev] [PATCH v2 1/4] power: fix invalid socket indicator value

2019-03-18 Thread Hajkowski
From: Marcin Hajkowski Currently 0 is being used for not connected slot indication. This is not consistent with linux doc which identifies 0 as valid (connected) slot, thus modification was done to change it. Fixes: cd0d5547 ("power: vm communication channels in guest") Cc: sta...@dpdk.org Sign

[dpdk-dev] [PATCH v2 0/4] bidirect guest channel

2019-03-18 Thread Hajkowski
From: Marcin Hajkowski Extend guest channel API to allow bidirectional communication. Modify power manager host and guest side to communicate in both directions. v2: * send ack only if power operation return positive value * log diffent error for unexpected incoming command and error during ac

Re: [dpdk-dev] [PATCH] bonding: fix lacp negotiation failed

2019-03-18 Thread Chas Williams
On 3/15/19 5:06 AM, Liang Zhang wrote: When monitor(port-mirroring) traffic from other lacp port-channel, rx_machine_update may recieving other lacp negotiation packets. Thus bond mode 4 will negotiation failed. Signed-off-by: Liang Zhang Acked-by: Chas Williams --- drivers/net/bonding/r

[dpdk-dev] [PATCH] eal/ppc: remove fix of memory barrier for IBM POWER

2019-03-18 Thread Dekel Peled
>From previous patch description: "to improve performance on PPC64, use light weight sync instruction instead of sync instruction." Excerpt from IBM doc [1], section "Memory barrier instructions": "The second form of the sync instruction is light-weight sync, or lwsync. This form is used to contro

[dpdk-dev] [PATCH v2 4/4] crypto/qat: add modular multiplicative inverse to qat asym pmd

2019-03-18 Thread Arek Kusztal
This commit adds modular multiplicative inverse to Intel QuickAssist Technology driver. For capabilities or limitations refer to qat.rst or qat_asym_capabilities.h. Signed-off-by: Arek Kusztal --- doc/guides/cryptodevs/qat.rst | 1 + .../qat/qat_adf/qat_pke_functionality_a

[dpdk-dev] [PATCH v2 1/4] common/qat: add headers for asymmetric crypto

2019-03-18 Thread Arek Kusztal
This commit adds headers to be used in conjunction with asymmetric cryptography operations using Intel QuickAssist Technology driver Signed-off-by: Arek Kusztal --- drivers/common/qat/qat_adf/icp_qat_fw_mmp_ids.h| 1538 drivers/common/qat/qat_adf/icp_qat_fw_pke.h

[dpdk-dev] [PATCH v2 2/4] crypto/qat: add asymmetric cryptography PMD

2019-03-18 Thread Arek Kusztal
This patch adds Poll Mode Driver for asymmetric crypto functions of Intel QuickAssist Technology hardware. It contains plain driver with no functions implmented, specific algorithms will be introduced in separate patches. This patch depends on a QAT PF driver for device initialization. See the fi

[dpdk-dev] [PATCH v2 3/4] crypto/qat: add modular exponentiation to qat asym pmd

2019-03-18 Thread Arek Kusztal
This commit adds modular exponentiation to Intel QuickAssist Technology driver. For capabilities or limitations refer to qat.rst or qat_asym_capabilities.h. Signed-off-by: Arek Kusztal --- doc/guides/cryptodevs/qat.rst | 2 + .../qat/qat_adf/qat_pke_functionality_arrays.h

[dpdk-dev] [PATCH v2 0/4] Add PMD for asymmetric cryptography operations using Intel QuickAssist Technology devices

2019-03-18 Thread Arek Kusztal
This patchset adds Poll Mode Driver to use asymmetric cryptography functions using Intel QuickAssist Techology devices. Following functions are available with this patchset: * Modular Exponentiation * Modular Inverse This patch depends on a QAT PF driver for device initialization. See

[dpdk-dev] [PATCH v7] drivers/net: fix possible overflow using strlcat

2019-03-18 Thread Chaitanya Babu Talluri
strcat does not check the destination length and there might be chances of string overflow so instead of strcat, strlcat is used. Fixes: 540a211084 ("bnx2x: driver core") Fixes: e163c18a15 ("net/i40e: update ptype and pctype info") Cc: sta...@dpdk.org Signed-off-by: Chaitanya Babu Talluri --- v7

Re: [dpdk-dev] [PATCH 4/4] power: send confirmation cmd to vm guest

2019-03-18 Thread Hajkowski, MarcinX
Logging error in case of invalid command is enough in my opinion. In this case we distinguish between invalid command (log error) and unsuccessful power operation (NAK cmd). I agree though that error log might be more precise (separate for error during sending ACK/NAK and separate for invalid

[dpdk-dev] [PATCH v2] app/test: fix possible overflow using strlcat

2019-03-18 Thread Chaitanya Babu Talluri
strcat does not check the destination length and there might be chances of string overflow so instead of strcat, strlcat is used. Fixes: 6f4eec2565 ("test/crypto: enhance scheduler unit tests") Cc: sta...@dpdk.org Signed-off-by: Chaitanya Babu Talluri --- v2: Updated title. --- app/test/test_cr

Re: [dpdk-dev] [PATCH v3 0/5] Supported VXLAN-GPE in i40e

2019-03-18 Thread Zhang, Qi Z
> -Original Message- > From: Yang, Qiming > Sent: Monday, March 18, 2019 11:42 PM > To: dev@dpdk.org > Cc: Zhang, Qi Z ; Yang, Qiming > Subject: [PATCH v3 0/5] Supported VXLAN-GPE in i40e > > This patch set supported new packet type VXLAN-GPE and add support for inner > checksum, RSS a

Re: [dpdk-dev] [PATCH v3] ethdev: check for invalid device name

2019-03-18 Thread Ali Alnubani
> -Original Message- > From: dev On Behalf Of Stephen Hemminger > Sent: Thursday, March 14, 2019 6:21 PM > To: dev@dpdk.org > Cc: Stephen Hemminger > Subject: [dpdk-dev] [PATCH v3] ethdev: check for invalid device name > > Do not allow creating a ethernet device with a name over the a

Re: [dpdk-dev] [PATCH v3 2/5] net/i40e: add support for VXLAN-GPE

2019-03-18 Thread Zhang, Qi Z
> -Original Message- > From: Yang, Qiming > Sent: Monday, March 18, 2019 11:42 PM > To: dev@dpdk.org > Cc: Zhang, Qi Z ; Yang, Qiming > Subject: [PATCH v3 2/5] net/i40e: add support for VXLAN-GPE > > Can recognize new packet type VXLAN-GPE in i40e driver. > Added inner IP/TCP/UDP check

Re: [dpdk-dev] 16.11.9 (LTS) patches review and test

2019-03-18 Thread Luca Boccassi
On Thu, 2019-01-24 at 09:43 +, Luca Boccassi wrote: > On Sat, 2018-12-22 at 11:15 +0100, Luca Boccassi wrote: > > On Thu, 13 Dec 2018, 11:35 Luca Boccassi > > > > On Mon, 2018-12-10 at 18:38 +, Luca Boccassi wrote: > > > > On Thu, 2018-11-29 at 16:23 +, Luca Boccassi wrote: > > > > >

[dpdk-dev] [PATCH v2 2/4] power: return error in set env when power env already set

2019-03-18 Thread Hajkowski
From: Marcin Hajkowski On attempt to set_env in already initialized state notify user by returning error that operation cannot be performed. Signed-off-by: Marcin Hajkowski --- doc/guides/rel_notes/release_19_05.rst | 4 lib/librte_power/rte_power.c | 3 ++- lib/librte_power/rte

[dpdk-dev] [PATCH v2 1/4] power: fix non thread-safe power env modification

2019-03-18 Thread Hajkowski
From: Marcin Hajkowski Due to lack of thread safety in exisiting solution use spinlock mechanism for atomic modification of power environment related data. Fixes: 445c6528b5 ("power: common interface for guest and host") Cc: sta...@dpdk.org Signed-off-by: Marcin Hajkowski --- doc/guides/rel_n

[dpdk-dev] [PATCH v2 3/4] power: reset function pointers on unset env

2019-03-18 Thread Hajkowski
From: Marcin Hajkowski Set all power environment related function pointers to NULL when unset is being made. Signed-off-by: Marcin Hajkowski --- lib/librte_power/rte_power.c | 21 - 1 file changed, 20 insertions(+), 1 deletion(-) diff --git a/lib/librte_power/rte_power.c b

[dpdk-dev] [PATCH v2 4/4] power: add UTs for all power env types

2019-03-18 Thread Hajkowski
From: Marcin Hajkowski Test all existing power environment configuration to verify if related data is properly initialized and clean in set/unset scenarios. Signed-off-by: Marcin Hajkowski --- app/test/test_power.c | 156 -- 1 file changed, 121 insertion

[dpdk-dev] [PATCH] app/testpmd: fix stdout flush absence after printing stats

2019-03-18 Thread Andrew Rybchenko
From: Igor Romanov User can specify stats period(n). The statistics should be available to user every n second. But the print_stats() function does not force stdout to be flushed, so for instance, a user reading testpmd's stdout through pipe will not be able to read it untill the stdout buffer is

[dpdk-dev] [PATCH v2 1/2] app/testpmd: fix tx vlan and qinq dependency

2019-03-18 Thread Nithin Kumar Dabilpuram
Tx VLAN & QinQ insert enable need not depend on Rx VLAN offload ETH_VLAN_EXTEND_OFFLOAD. Fixes: 6a34f91690d0 ("app/testpmd: fix error message when setting Tx VLAN") Cc: xiao.w.w...@intel.com Signed-off-by: Nithin Dabilpuram --- v2: * Split change into two seperate patches as suggested. app/tes

[dpdk-dev] [PATCH v2 2/2] app/testpmd: fix tx qinq insert enable

2019-03-18 Thread Nithin Kumar Dabilpuram
Enable DEV_TX_OFFLOAD_VLAN_INSERT also along with DEV_TX_OFFLOAD_VLAN_QINQ in tx_qinq_set() as it takes both vlan id's as arguments. Fixes: 597f9fafe13b ("app/testpmd: convert to new Tx offloads API") Cc: shah...@mellanox.com Signed-off-by: Nithin Dabilpuram --- v2: * Split change into two seper

[dpdk-dev] issue with memory sync on P9

2019-03-18 Thread Dekel Peled
Hi Chao Zhu, We have recently encountered runtime issues when running DPDK 18.11 (and later) MLX5 PMD on P9 setup. Using rte_wmb() was found to be insufficient in specific location, memory sync problem occurred regardless. Using rte_mb() in this specific location fixed the issue. --- a/drivers/

Re: [dpdk-dev] [PATCH] app/testpmd: fix support of hex string parser for flow API

2019-03-18 Thread Zhao1, Wei
Hi, Konstantin > -Original Message- > From: Ananyev, Konstantin > Sent: Friday, March 15, 2019 5:45 PM > To: Zhao1, Wei ; dev@dpdk.org > Cc: sta...@dpdk.org; Zhang, Qi Z ; > adrien.mazarg...@6wind.com; Zhao1, Wei > Subject: RE: [dpdk-dev] [PATCH] app/testpmd: fix support of hex string >

[dpdk-dev] [PATCH v2] app/testpmd: fix support of hex string parser for flow API

2019-03-18 Thread Wei Zhao
There is need for users to set configuration of HEX number for RSS key. The key byte should be pass down as hex number not as char string. This patch enable cmdline flow parse HEX number, in order to not using string which pass ASIC number. Fixes: f4d623f96119 ("app/testpmd: fix missing RSS fields

Re: [dpdk-dev] [PATCH v3 00/38] ice share code update.

2019-03-18 Thread Yang, Qiming
-Original Message- From: Zhang, Qi Z Sent: Monday, March 11, 2019 3:04 PM To: Lu, Wenzhuo ; Yang, Qiming Cc: dev@dpdk.org; Stillwell Jr, Paul M ; Yigit, Ferruh ; Zhang, Qi Z Subject: [PATCH v3 00/38] ice share code update. Sync to latest kernel driver, main changes: 1. add DCB/FDIR

Re: [dpdk-dev] [PATCH v4 1/1] compress/qat: add dynamic sgl allocation

2019-03-18 Thread arpita das
I know its a wrong forum, but just a 1 liner query, any openings in dodk , please let me know. TIA On Mon, 18 Mar 2019 at 1:43 PM, Jozwiak, TomaszX wrote: > Hi Akhil, > > Please take a look at cover letter (https://patches.dpdk.org/cover/50919/) > > There's dependency on 'malloc: add rte_reallo

[dpdk-dev] [PATCH v3 5/5] doc: add release note for VXLAN-GPE support

2019-03-18 Thread Qiming Yang
Updated release note. Signed-off-by: Qiming Yang --- doc/guides/rel_notes/release_19_05.rst | 6 ++ 1 file changed, 6 insertions(+) diff --git a/doc/guides/rel_notes/release_19_05.rst b/doc/guides/rel_notes/release_19_05.rst index 61a2c73..c936f97 100644 --- a/doc/guides/rel_notes/release_

[dpdk-dev] [PATCH v3 4/5] app/testpmd: add VXLAN-GPE to tunnel type

2019-03-18 Thread Qiming Yang
This patch added new item "vxlan-gpe" to tunnel_type to support new VXLAN-GPE packet type, and its clasification. Signed-off-by: Qiming Yang --- app/test-pmd/cmdline.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c i

[dpdk-dev] [PATCH v3 3/5] net/i40e: support VXLAN-GPE classification

2019-03-18 Thread Qiming Yang
Added VXLAN-GPE tunnel filter, supported filter to queue. Signed-off-by: Qiming Yang --- drivers/net/i40e/i40e_ethdev.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c index b2ec5cc..18faf65 100644 --- a/drivers/net/i40e/i40e

[dpdk-dev] [PATCH v3 1/5] eal: add VXLAN-GPE macro

2019-03-18 Thread Qiming Yang
This patch added VXLAN-GPE macro in rte_eth_tunnel_type. Signed-off-by: Qiming Yang --- lib/librte_ethdev/rte_eth_ctrl.h | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/librte_ethdev/rte_eth_ctrl.h b/lib/librte_ethdev/rte_eth_ctrl.h index 5ea8ae2..b341634 100644 --- a/lib/librte_ethdev/r

  1   2   >